[Koha-bugs] [Bug 4450] Type of error return causes problems

[bugzilla-daemon at kohaorg.ec2.liblime.com]

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4450


Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #14 from Chris Nighswonger <cnighswonger at foundations.edu>  2010-05-13 22:59:35 ---
Unfortunately I ran into more regressions caused by this patch today. While
doing some work on a client installation (code from current HEAD), I found that
attempting to create a new layout results in the following error:

Can't bless non-reference value at
/home/cnighswonger/Repositories/koha.3.2.labels/C4/Creators/Layout.pm line 107.


Additionally, attempting to add an item to a new label batch results in the
following error:

Can't call method "add_item" on an undefined value at
/home/cnighswonger/Repositories/koha.3.2.labels/labels/label-edit-batch.pl line
83.

Both regressions are resolved by reverting commit
1f56a04cadc60f26b36f5599f24d0f380bc23828

While I agree in principle with the need to improve the returns on errors in
the C4::Creators module, I think that the solution needs to touch upon every
line of code which will be affected by the improvement. It seems to me that
this is better left to 3.4.

In any case, any work which changes C4::Creators should also port those changes
to all of the Label and Card creator code as well. So for the time being, I am
withdrawing my sign-off on this patch and reopening the bug. But only until
such a time as a complete solution is provided.


-- 
Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.