[Koha-bugs] [Bug 6875] de-nesting C4 packages
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Sep 21 17:23:33 CEST 2011
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6875
--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> 2011-09-21 15:23:33 UTC ---
Created attachment 5503
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5503
Bug 6875 de-nesting C4::Items
C4::Branch is used only in CheckItemPresave, moving from a use to a require in
the sub
C4::Reserve:
This package is loaded just for C4::Reserves::CheckReserves called in
C4::Items::GetItemsInfo
The GetItemsInfo stores the result of CheckReserves in a hash entry,
count_reserve, that is used only in opac_detail to display the status of a
hold. We could remove the reserve_count hash entry and inline
C4::Reserves::CheckReserves directly from opac-detail.pl page
in opac-detail.pl, instead of
if( $itm->{'count_reserves'} eq "Waiting"){ $itm->{'waiting'} = 1; }
write :
if ( C4::Reserves::CheckReserves(<<parameters>>) eq "Waiting"){
$itm->{'waiting'} = 1; }
C4::Acquisition is used only in MoveItemFromBiblio, a sub that is rarely
called. Moving from a use to a require in the sub
C4::Charset is used only in _parse_unlinked_item_subfields_from_xml. Moving
from a use to require in the sub
--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
More information about the Koha-bugs
mailing list