[Koha-bugs] [Bug 8110] Fines accruing on closed days

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to comment #41)
> (In reply to comment #40)
> > Jonathan, I failed to see how this is a problem with this patch. The test
> > failing does not mean this patch is bad, it *is* the test. The test failing
> > means there is something wrong with the calendar modules.
> 
> Based on Dobrica's comment #35, there may already be a patch that fixes the
> problem. If that is true, the tests are wrong, and should be updated to test
> for correct functioning (because they will fail when the code is working,
> and pass only when it is not working in a very particular way). If that is
> not true, the patch fails to fix the problem, and therefore does not pass QA
> for that reason. If the intention is only to provide a test suite that
> highlights where the code is broken, the patches should probably just be
> moved to a different bug, so that no one is expecting a fix for the "Fines
> accruing on closed days issue" when they see this mentioned in the release
> notes, and so that the QA team is not confused.

You are referring to a patch that was deprecated a long time ago. Unless
Jonathan decided to pull and test, and fail an already deprecated patch, what
you are saying makes not sense. Based on Dobrica's comment I deprecated my
patch that actually fixed the problem. A tester would have to ignore the title
and description for all three patches here to assume one of them fixed the
problem. That would be poor testing, not poor patch writing. I will, however,
change the title of the bug as you have suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.