[Koha-bugs] [Bug 7451] PrepareItemrecordDisplay missing $subfield_data{id} which breaks AJAX value_builders

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7451

--- Comment #9 from Dobrica Pavlinusic <dpavlin at rot13.org> 2012-02-20 15:50:13 UTC ---
PrepareItemrecordDisplay is used by acquisition (that's how we found this
problem) and serials, and this patch fixes problem with it, so it still needs
sign-off.

I did took a long look at C4::Biblio::PrepareItemrecordDisplay and
generate_subfield_form with goal of marging changes, but in the process I found
that code diverged and I'm not brave anough just to merge them together.

I'm quite confused by some parts of generate_subfield_form in
cataloguing/additem.pl:

        if ($frameworkcode eq 'FA' && $subfieldlib->{kohafield} eq
'items.barcode'){
            my $input = new CGI;
            $value = $input->param('barcode');
        }

This just doesn't seem right to me (hard-coded framework and direct access to
CGI params), but hopefully somebody with more knowledge of this code could make
educated guesses and merge those two implementations together in another bug?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.