[Koha-bugs] [Bug 7896] Acquisition statistics wizard: add filters and cell values
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Jul 9 09:41:47 CEST 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7896
Frédéric Demians <frederic at tamil.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |frederic at tamil.fr
--- Comment #6 from Frédéric Demians <frederic at tamil.fr> ---
I can't test completly this patch because I haven't enough acquisition
data. But it seems to work.
Two remarks/demands:
[1] GetMarcSubfieldStructureFromKohaField new routine is querying
marc_subfield_structure table. It should be cached. Or, since it must
have been already retrieved, and cached by GetMarcStructure, the cached
version of frameworks must be used.
[2] Some texts are not translatable. It was already there, but your
patch add text that can't be translated:
In reports/acquisitions_stats.pl, line 126, there is:
$select{''} = "All Suppliers";
Since it isn't in template, it can't be translated.
The is also:
given ($i) {
when (0) { $cell{crit} = "Placed On From" }
when (1) { $cell{crit} = "Placed On To" }
when (2) { $cell{crit} = "Received On From" }
when (3) { $cell{crit} = "Received On To" }
when (4) { $cell{crit} = "Bookseller" }
when (5) { $cell{crit} = "Home branch" }
when (6) { $cell{crit} = "Collection" }
when (7) { $cell{crit} = "Doc Type" }
when (8) { $cell{crit} = "Budget" }
when (9) { $cell{crit} = "Sort1" }
when (10) { $cell{crit} = "Sort2" }
default { $cell{crit} = "" }
Could you propose a fix to help translate this page?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list