[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #107 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #102)
> However, I don't like parsing the SQL ourselves. Why don't we just open the
> SQL file, save the contents into the variable that stores the SQL, and run
> it directly? Writing our own SQL parser is sure to come back and bite us.
> Moreover, requiring special delimiters seems like an unnecessary burden.

Putting my RM hat away, and taking my Jonathan-boss one for this comment.

Jonathan (and me) invested a lot of time and efforts -sponsored by no-one- to
develop this improvement because we thought it was worth it.
We made many changes to fit various comments, and took many time to explain
what we did and why we did it. We don't want to invest more and more time, and
don't think it's fair to refrain this patch because of "don't like" or "could
be done another way".
If there are true QA-related comments, we will deal with them. But please, stop
adding requirements to this patch. Or we will abandon it, it will not be pushed
and we will stick with the current updatedatabase mechanism.

-- 
You are receiving this mail because:
You are watching all bug changes.