[Koha-bugs] [Bug 7729] svc API should allow modification of items
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Mar 26 10:49:48 CEST 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7729
Paul Poulain <paul.poulain at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paul.poulain at biblibre.com
--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
another question:
The code says:
+ my $fullrecord = $record->clone();
then a few lines later:
- foreach my $field ($record->field($itemtag)) {
+ foreach my $field ( $record->field($itemtag) ) {
$record->delete_field($field);
}
then
+ foreach my $field ( $fullrecord->field($itemtag) ) {
+ my $one_item_record = $record->clone();
+ $one_item_record->add_fields($field);
+ ModItemFromMarc( $one_item_record, $biblionumber,
+ $field->subfield($itemsubfield) );
+ }
so= we clone the record, remove items from old record if there are, then
reintroduce item in the new record.
Shouldn't we have
- foreach my $field ($record->field($itemtag)) {
+ foreach my $field ( $fullrecord->field($itemtag) ) {
$record->delete_field($field);
}
?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list