[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue May 22 10:09:03 CEST 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017
Jonathan Druart <jonathan.druart at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |jonathan.druart at biblibre.co
| |m
--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA Comments:
1/ You remove the FIXME in getAllIssues (sanity-check order and limit) but
$order is not sanitized. Please call $dbh->quote with the $order variable.
2/ Why do you remove the parenthesis for the IF statement (template) ? It seems
mandatory by the koha guidelines. But I agree with you, it is useless :)
Failed QA for 1.
Replacement of fetchrow_hashref with a more adapted fetchall_arrayref is good.
I think there is others occurrences of this into the koha code.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list