[Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sat Apr 20 12:28:08 CEST 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029
--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Comment on attachment 17371
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17371
Proposed patch
Review of attachment 17371:
--> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10029&attachment=17371)
-----------------------------------------------------------------
::: C4/Auth_with_cas.pm
@@ +95,5 @@
> my $casparam = $query->param('cas');
> # FIXME: This should be more generic and handle whatever parameters there might be
> + if (defined $casparam) {
> + $uri .= ($uri =~ m/\?/ ) ? '&' : '?';
> + $uri .= "cas=$casparam" ;
You shouldn't need this, because $query->url will already contain the casparam,
ie, if it exists it will be in $query->url, so we will be appending another
copy of it.
So if you remove this and the FIXME then I'd be happy to sign off.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list