[Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231

--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 20219
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20219
Bug 9231 - Batch revert staged MARC records fails if one or more records in a
batch have been deleted.

Review of attachment 20219:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9231&attachment=20219)
-----------------------------------------------------------------

Marking failed QA because of the infinite loop condition that this patch
introduces.

Also, I will not push any patch for this bug that does not include a regression
test in the DB-dependent test suite.

::: C4/Items.pm
@@ +611,5 @@
> +
> +    # FIXME: Why pass $dbh in? We can get it from C4::Context
> +    # FIXME: Why pass $biblionumber in? It would be safer to get it via the itemnumber
> +
> +    return unless ( DelItemCheck( $dbh, $biblionumber, $itemnumber ) eq '1' );

DelItemCheck calls DelItem, so adding a call to DelItemCheck here creates an
infinite loop -- which I've verified actually happens.

Since DelItemCheck is meant as the entry point (although that is problematic
since DelItemCheck currently checks userenv), and DelItem is the internal
routine, I think a better implementation would be for DelItemCheck to check the
results of its call to GetItem and return if the item doesn't exist.

-- 
You are receiving this mail because:
You are watching all bug changes.