[Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #30 from David Cook <dcook at prosentient.com.au> ---
(In reply to Magnus Enger from comment #29)
> (In reply to M. de Rooy from comment #28)
> > What I did mean, was: If we let the user just once insert http or https for
> > his server, and we do not prefix it anymore, we have a solution..
> 
> But isn't it possible to have the same domain available both with and
> without HTTPS? So both of these can work at the same time:
> http://koha.example.org/
> https://koha.example.org/
> 
> Then it would seem to be a bad idea to "hard code" the protocol in a
> syspref, and better to figure it out on a per request basis, perhaps?

I think figuring it out on a per request basis is probably best, but it seems
like there is a problem using the CGI method https() when Plack is in use, yes?

I know next to nothing about Plack but maybe something like this?
(https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-frontend).

Now that I think about it, if you're using a proxy, CGI->https() will probably
always return NO too unless one's using SSL internally too.

-- 
You are receiving this mail because:
You are watching all bug changes.