[Koha-bugs] [Bug 10784] New: SMS-related code needs improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784

            Bug ID: 10784
           Summary: SMS-related code needs improvements
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org

Some more or less random findings:

sms/sms_listen.pl has hardcoded strings in it, in Turkish (according to Google
translate):
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=sms/sms_listen.pl;h=b36b25da46baa3e49b9c0ae77dbf40fa8f3715c8;hb=9c8a1e29f8f25890c341859eb943aff64f7f37ac#l58

This comment from an earlier commit sounds ominous: "SMS - widespread cleanup
and moving code away from Cyprus/Turkey-specific implementation. Much more
needed."
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9c8a1e29f8f25890c341859eb943aff64f7f37ac

To bring this in line with other functionality in Koha it would probably be a
good idea to make the notices editable, in the same way that other notices are. 

C4::SMS references two sysprefs, SMSSendUsername and SMSSendPassword, but when
I search for these in 3.12.x and current master I get no results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.