[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> ---
Kyle, ping !!!

You haven't answered my last-august question, and this patch seems lost in
limbos. Could you answer and try to have it exiting from "in discussion" ?

thx

(In reply to comment #5)
> QA Comment:
> 
> This patch is highly sensible, because it changes Circulation behaviour.
> It replaces:
> SELECT COUNT(*) FROM issues
>   JOIN items USING (itemnumber)
>   WHERE borrowernumber = ?
>   AND issues.branchcode = ? (or  AND items.homebranch = ? or nothing,
> depending on sysprefs)
> 
> by a simple
> SELECT COUNT(*) FROM issues
>   WHERE borrowernumber = ?
> 
> Digging into the code, I see that the comparison is made against
> GetBranchBorrowerCircRule, which retrieve data from
> branch_borrower_circ_rules
> 
> Looking at admin/smart-rules.pl, I see that the description says:
> =========
> Checkout limit by patron category for <<LIBRARY NAME>>
> 
> For this library, you can specify the maximum number of loans that a patron
> of a given category can make, regardless of the item type.
> 
> If the total amount loanable for a given patron category is left blank, no
> limit applies, except possibly for a limit you define for a specific item
> type. 
> =========
> 
> I feel it's unclear. What does "For this library" mean exactly ? is it "for
> items checked out from this library" "For patrons registered at this
> library" ?
> 
> The sub GetBranchBorrowerCircRule is called with $branch and $cat_borrower
> parameters
> $branch is filled depending on sysprefs by _GetCircControlBranch, that
> return a value depending on CircControl syspref
> 
> the patch, if I understand it well, understand the smart-rule.pl description
> as: "For patrons registered to this library, you can specify the maimum
> number of loans, all branches included"
> So it discard the behaviour: "You can specify the maximum number of loans
> that a patron can do from this library"
> 
> As a conclusion, I feel that this patch could unplease some libraries. Maybe
> more explanations are needed on smart-rules.pl.
> 
> Is there something I misunderstood ? (Am I clear in my explanations -because
> it's quite tricky- ?)

-- 
You are receiving this mail because:
You are watching all bug changes.