[Koha-bugs] [Bug 10442] Remove references to non-standard "error" class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 19296
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19296
[PASSED QA] Bug 10442 - Remove references to non-standard "error" class

Review of attachment 19296:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10442&attachment=19296)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
@@ -171,5 @@
>      [% END %]
>  </h2>
>  
> -<div class="error" style="display:none"></div>
> -

I'm not sure whether simply removing this is OK.  There is code in additem.js
that looks for the existence of a div whose CSS class is "error"; if such a div
is not present, an error message (e.g., when trying to add a duplicate item)
would have no place to be displayed.

Setting bug back to "Signed-off" for QA to look into this.  If I'm right,
additem.js will need to be modified, e.g., to use a div ID rather than a div
class to locate the placeholder for an error message.

It may be necessary to apply the patch for bug 10483 to be able to test a
situation where attempting to add an item during the process of creating a new
order results in an error.

-- 
You are receiving this mail because:
You are watching all bug changes.