From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:21:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:21:13 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18554|0 |1 is obsolete| | --- Comment #37 from Melia Meggs --- Created attachment 18568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18568&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:21:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:21:25 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18555|0 |1 is obsolete| | --- Comment #38 from Melia Meggs --- Created attachment 18569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18569&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:21:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:21:36 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18556|0 |1 is obsolete| | --- Comment #39 from Melia Meggs --- Created attachment 18570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18570&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:21:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:21:46 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18557|0 |1 is obsolete| | --- Comment #40 from Melia Meggs --- Created attachment 18571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18571&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:21:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:21:57 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18558|0 |1 is obsolete| | --- Comment #41 from Melia Meggs --- Created attachment 18572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18572&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:22:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:22:09 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18559|0 |1 is obsolete| | --- Comment #42 from Melia Meggs --- Created attachment 18573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18573&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:22:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:22:18 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18560|0 |1 is obsolete| | --- Comment #43 from Melia Meggs --- Created attachment 18574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18574&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 00:22:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 22:22:27 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18561|0 |1 is obsolete| | --- Comment #44 from Melia Meggs --- Created attachment 18575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18575&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:36:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:36:58 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18568|0 |1 is obsolete| | --- Comment #45 from Melia Meggs --- Created attachment 18576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18576&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:08 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18569|0 |1 is obsolete| | --- Comment #46 from Melia Meggs --- Created attachment 18577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18577&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:15 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18570|0 |1 is obsolete| | --- Comment #47 from Melia Meggs --- Created attachment 18578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18578&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:22 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18571|0 |1 is obsolete| | --- Comment #48 from Melia Meggs --- Created attachment 18579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18579&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:31 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18572|0 |1 is obsolete| | --- Comment #49 from Melia Meggs --- Created attachment 18580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18580&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:39 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18573|0 |1 is obsolete| | --- Comment #50 from Melia Meggs --- Created attachment 18581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18581&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:47 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18574|0 |1 is obsolete| | --- Comment #51 from Melia Meggs --- Created attachment 18582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18582&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:37:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:37:55 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18575|0 |1 is obsolete| | --- Comment #52 from Melia Meggs --- Created attachment 18583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18583&action=edit [Signed off] Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again Signed-off-by: Paul Landers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 01:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 23:38:42 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #53 from Melia Meggs --- Helping Paul add his sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 03:40:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 01:40:38 +0000 Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 03:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 01:40:42 +0000 Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17352|0 |1 is obsolete| | --- Comment #20 from Mason James --- Created attachment 18584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18584&action=edit Bug 5858 - Default frameworks missing many MARC21 tags This patch replaces previous ones. Only adds missing tags/subtags or update descriptions. Only to new installs. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Rebased to master. Signed-off-by: Mason James -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 03:57:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 01:57:07 +0000 Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 03:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 01:57:09 +0000 Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #21 from Mason James --- Created attachment 18585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18585&action=edit [FOLLOWUP] Bug 5858 - Default frameworks missing many MARC21 tags This patch is a *followup* to the previous patch Update MARC21 fields/subfields to version 16 http://www.loc.gov/marc/bibliographic/bdapndxg.html Only to new installs. To test: 1) Delete MARC21 default framework 2) Apply patch 3) Test that new default framework loads without problem Rebased to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 04:05:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 02:05:07 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Summary|Default frameworks missing |Update default MARC21 |many MARC21 tags |framework to Update No. 16 | |(April 2013) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 05:27:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 03:27:58 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16174|0 |1 is obsolete| | --- Comment #5 from Mason James --- Created attachment 18586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18586&action=edit Bug 9826 - Missing fields in MARC21 authority framework This patch updates MARC21 authority framework adding missing tags/subtags up to Update No. 15 (September 2012) Missing tags and corresponding subtags only added to default authority framework. For present authtypes only missing subtags are added. Also updates a few legends to match those from LOC. No deletions except for a few not relevant tags in present authtypes without subfields. Only to new installs. To test: 1) Delete present authority frameworks 2) Load new frameworks. On default there are many new tags/subtags. On present authtypes only a few new/renamed subtags. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 05:28:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 03:28:28 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 05:29:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 03:29:58 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 --- Comment #6 from Mason James --- > Signed-off-by: Mason James i've given this patch a good eyeball, and tested it it looks good! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 05:33:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 03:33:39 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #22 from Mason James --- (In reply to comment #9) > I am not sure deleting them is a good idea - I would have to test it, but is > there a chance we loose data if someone imports data that uses fields that > are not defined in the default framework? I think I would prefer to see them > hidden and marked [OBSOLETE] to be sure no data can be lost. it looks like the official MARC21 spec does this too -> http://www.loc.gov/marc/bibliographic/ecbdlist.html ie: it does not delete old fields/subfields, but just marks them [OBSOLETE] -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 05:35:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 03:35:44 +0000 Subject: [Koha-bugs] [Bug 5858] Update default MARC21 framework to Update No. 16 (April 2013) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 --- Comment #23 from Mason James --- (In reply to comment #20) > Created attachment 18584 [details] [review] > Bug 5858 - Default frameworks missing many MARC21 tags > > Signed-off-by: Mason James i've taken a look a Bernardo's patch, and tested it it looks good -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:00:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:00:21 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #9 from M. de Rooy --- Created attachment 18587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18587&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test in VirtualShelves.t. This is intentional: I will still add a test, but saw report 10290 and came across a few other problems in this unit test. Will add a patch under report 10386. Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:02:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:02:06 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Summary|Share a list |Share a list (part 1: send | |the invitation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:06:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:06:31 +0000 Subject: [Koha-bugs] [Bug 10389] New: Share a list (part 2: accept the invitation) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 Bug ID: 10389 Summary: Share a list (part 2: accept the invitation) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl CC: m.de.rooy at rijksmuseum.nl This report is a followup for bug 9032. It will handle accepting the invitation when the patron clicks on the link in the invitation email. But it will also take care of some futher needed adjustments: Showing the type Shared in the private lists overview. Handling the deletion of a shared list (on both sides: owner and sharer). And maybe a little code housekeeping on the way.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:06:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:06:55 +0000 Subject: [Koha-bugs] [Bug 10389] Share a list (part 2: accept the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10389 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |9032 Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:06:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:06:55 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10389 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:07:27 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10206 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:07:27 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9032 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 10:13:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 08:13:19 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #10 from M. de Rooy --- As part of ongoing development, these three patches are imho ready for at least signoff. They should not be pushed without the followup on bug 10389. This allows for gradual test and qa on smaller patches. I would also welcome followups on getting the text but especially the design on a higher level; I am no expert in that area :) Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 1 14:30:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Jun 2013 12:30:42 +0000 Subject: [Koha-bugs] [Bug 10390] New: Add ability to delete unused invoices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Bug ID: 10390 Summary: Add ability to delete unused invoices Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com There is currently no way to delete unused invoices (for example, invoices created by mistake), and there really should be, since errors and absent-mindedness can result in numerous empty invoices over the course of years. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:31:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:31:06 +0000 Subject: [Koha-bugs] [Bug 10208] The ability to order multiple copies of the same title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10208 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com Assignee|amit.gupta at osslabs.biz |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:47:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:47:23 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:48:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:48:30 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18515|0 |1 is obsolete| | --- Comment #2 from Amit --- Created attachment 18588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18588&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number Small typo fix in comma, The ability to order multiple copies of the same item, from different fund classes, on the same order number To Test: 1) Create basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. Atleast one quantity and fund will be there if you try to delete it will show one error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:48:58 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:57:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:57:53 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:58:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:58:43 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18159|0 |1 is obsolete| | --- Comment #2 from Amit --- Created attachment 18589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18589&action=edit Clear not for loan on receipt Clear not for loan on receipt When receiving an item to have the facility to scan the barcode and change the status of the item from ON ORDER to JUST RECEIVED automatically To Test: 1) Create a ACQ framwork in MARC bibliographic framework 2) Search 952 tag and set default value notforloan is to -1 3) Create a basket for ex: basket1 4) Create order under basket 5) Close the basket 6) Receive the shipment 7) By default notforloan value is Ordered 8) Once you receive the order item tag value is available or value is 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 09:59:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 07:59:01 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 10:00:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 08:00:44 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com Assignee|amit.gupta at osslabs.biz |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 20:25:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 18:25:43 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 20:25:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 18:25:44 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 --- Comment #1 from Jared Camins-Esakov --- Created attachment 18590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18590&action=edit Bug 10390: Add ability to delete empty invoices There is currently no way to delete unused invoices (for example, invoices created by mistake), and there really should be, since errors and absent-mindedness can result in numerous empty invoices over the course of years. To test: 1) Apply patch. 2) Create three invoices in the Acquisitions module. For one of them, receive at least one item. For the other two, do not receive any items. 3) View one of the invoices that does not have any items on it. 4) Try to delete it. This should succeed. 5) View the invoice that has an item. There should not be any option to delete it. 6) Do an invoice search that brings up the other invoice with no items on it. Try to delete it from the results page. This should succeed. 7) Run the unit test: > prove t/Acquisition/Invoice.t 8) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 20:30:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 18:30:30 +0000 Subject: [Koha-bugs] [Bug 10391] New: specify due date remaining even if not selected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 Bug ID: 10391 Summary: specify due date remaining even if not selected Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/circulation.pl OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking out materials if you specify a due date but don't check the 'remember for session' box, Koha remembers the date anyway. It should only remember with that box checked. This is so in 3.10.x, 3.12 and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 20:37:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 18:37:10 +0000 Subject: [Koha-bugs] [Bug 7456] itypes with similar codes throw off search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7456 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master Severity|normal |major --- Comment #3 from Nicole C. Engard --- This is still an issue in master, 3.12 and 3.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 21:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 19:53:12 +0000 Subject: [Koha-bugs] [Bug 10392] New: Unable to complete MARC records import after the reservoir Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10392 Bug ID: 10392 Summary: Unable to complete MARC records import after the reservoir Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: imingchan at yahoo.com.au Unable to complete MARC records import after successfully uploaded to the reservoir. The horizontal progress remained at 0%. Have tried different size files (i.e. 10 and 4000+ records). No problem with these files on 3.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 21:53:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 19:53:49 +0000 Subject: [Koha-bugs] [Bug 10392] Unable to complete MARC records import after the reservoir In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10392 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 23:28:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 21:28:18 +0000 Subject: [Koha-bugs] [Bug 10358] Unable to return items via self check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #1 from Mason James --- (In reply to comment #0) > Using Koha's Self checkout module at /cgi-bin/koha/sco/sco-main.pl in Koha > 3.10.4. System preference 'AllowSelfCheckReturns' is set to allow. > When a patron's barcode is submitted, items on loan are refreshed. There is > a button for renewing the item but no button for return. Unable to find any > facility to return the item. Bob, i have a patch for this... i'll upload it today -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 23:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 21:36:00 +0000 Subject: [Koha-bugs] [Bug 10358] Unable to return items via self check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 --- Comment #2 from Mason James --- (In reply to comment #0) > Using Koha's Self checkout module at /cgi-bin/koha/sco/sco-main.pl in Koha > 3.10.4. System preference 'AllowSelfCheckReturns' is set to allow. > When a patron's barcode is submitted, items on loan are refreshed. There is > a button for renewing the item but no button for return. Unable to find any > facility to return the item. fyi: there is some broken workflow in the SCO currently... currently, if you want to return an item - you must 'renew' it many times, until the items renewal limit has been reached; *only* then are you allowed to return it?! this patch fixed this problem, and allows an item to be returned, regardless of its renewal status -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 2 23:37:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 21:37:11 +0000 Subject: [Koha-bugs] [Bug 10358] Unable to return items via self check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 --- Comment #3 from Mason James --- > this patch fixed this problem, and allows an item to be returned, regardless > of its renewal status ... if the 'AllowSelfCheckReturns' syspref is enabled, of course ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 01:57:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Jun 2013 23:57:49 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #5 from Srdjan Jankovic --- Jonathan, I'm getting DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign key constraint (`koha`.`course_instructors`, CONSTRAINT `course_instructors_ibfk_2` FOREIGN KEY (`course_id`) REFERENCES `koha`.`courses` (`course_id`)) at t/db_dependent/CourseReserves.t line 22. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at C4/Items.pm line 2105. Do I need to do some prep first, or some special config? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 02:24:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 00:24:54 +0000 Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18246|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 18591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18591&action=edit Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 02:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 00:26:03 +0000 Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 02:36:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 00:36:43 +0000 Subject: [Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- Then wouldn't it be better to remove maxreserves syspref alltogether? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 02:48:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 00:48:05 +0000 Subject: [Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 02:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 00:52:06 +0000 Subject: [Koha-bugs] [Bug 10391] specify due date remaining even if not selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10391 --- Comment #1 from Nicole C. Engard --- What i had found when doing this is that without the box checked it held the custom date for all the transactions for that patron. It I checked the box to remember the custom date, it held the dat for all the following patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 02:57:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 00:57:57 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 03:21:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 01:21:01 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18166|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 18592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18592&action=edit Bug 10258: Remove erroneous call to haspermission in basket.pl First parameter (userid) was not passed making the test useless. Removed the test for now. Current behavior does not change. Just adding the first parameter here does not make sense. Using the permission here needs more than that. Test plan: Open a closed basket in Acquisition. Check if you see all available basketgroups in the combo at the right side. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 03:22:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 01:22:07 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 03:47:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 01:47:06 +0000 Subject: [Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 --- Comment #2 from Srdjan Jankovic --- Created attachment 18593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18593&action=edit [Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an . should only be used to differentiate the list of individual libraries from search groups. This patch removes the when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no . Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 03:48:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 01:48:49 +0000 Subject: [Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18544|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 03:49:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 01:49:09 +0000 Subject: [Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:30:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:30:41 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18364|0 |1 is obsolete| | Attachment #18365|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 18594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18594&action=edit [SIGNED-OFF] Bug 10321: Followup for hold notes Based on work for report 9722. This patch resolves a small display problem with the number of columns of the table on opac-reserve. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:31:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:31:26 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #4 from Srdjan Jankovic --- Created attachment 18595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18595&action=edit [SIGNED-OFF] Bug 10321: QA Followup on report 9722 As Jonathan suggested, use jQuery toggle function. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:32:09 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:57:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:57:37 +0000 Subject: [Koha-bugs] [Bug 10393] New: To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Bug ID: 10393 Summary: To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com to add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:57:54 +0000 Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main screen e.g. RECEIVE SHIPMENT and the FILTER BOX In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:59:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:59:40 +0000 Subject: [Koha-bugs] [Bug 10394] New: The ability to unreceipt an order line as well as an invoice. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10394 Bug ID: 10394 Summary: The ability to unreceipt an order line as well as an invoice. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com The ability to unreceipt an order line as well as an invoice. (e.g. to edit a price change or incorrectly entered invoice number) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 04:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 02:59:49 +0000 Subject: [Koha-bugs] [Bug 10394] The ability to unreceipt an order line as well as an invoice. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10394 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 05:00:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 03:00:00 +0000 Subject: [Koha-bugs] [Bug 10394] The ability to unreceipt an order line as well as an invoice. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10394 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 05:27:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 03:27:15 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18590|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 18596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18596&action=edit [SIGNED-OFF] Bug 10390: Add ability to delete empty invoices There is currently no way to delete unused invoices (for example, invoices created by mistake), and there really should be, since errors and absent-mindedness can result in numerous empty invoices over the course of years. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 05:31:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 03:31:11 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 --- Comment #3 from Srdjan Jankovic --- It's not abig deal, it's empty invoices, but maybe making a delete button and separating Delete link a bit on the list page? Alternatively a confirm pop-up? Not fussed if the answer is no. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 05:32:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 03:32:34 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 05:40:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 03:40:24 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18517|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 18597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18597&action=edit [SIGNED-OFF] Bug 10380: Change prototype for output_pref routine Koha::DateUtils::output_pref takes 4 parameters and the last one is a boolean, so some calls are: output_pref($dt, undef, undef, 1) This patch changes it prototype to output_pref({ dt => $dt, dateformat => $dateformat, timeformat => $timeformat, dateonly => $boolean }); an alternative is to call the output_pref routine with a datetime object, without using an hashref: output_pref($dt); Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 05:40:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 03:40:57 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 06:04:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 04:04:27 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- @invoices should be checked only if AcqWarnOnDuplicateInvoice is set, otherwise it is an unnecessary db read. Can you please amend to something like my $duplicate_invoices; if ( C4::Context->preference('AcqWarnOnDuplicateInvoice') ) { if ( GetInvoices(...) ) { $duplicate_invoices = 1; } } if ($duplicate_invoices) { ... } else { $op = 'confirm'; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 06:26:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 04:26:29 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- "DELETE FROM search_history" query should go to C4::Search.pm, preferrably with a test (but not a show stopper) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 06:38:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 04:38:00 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- It looks pointless to me to have hashrefs with only one key 'itemnumber'. Would you consider changing those arrays to be pure itemnumbers please, while you're at it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 06:50:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 04:50:46 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #10 from Srdjan Jankovic --- I believe it would be slightly better to write my $userenv = C4::Context->userenv or carp(...); return C4::Context->userenv->{flags} % 2 == 1; It saves one C4::Context->userenv call. I admire this kind of work, having C4::Context->userenv->{flags} % 2 != 1 all over the place is just scandalous. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 07:05:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 05:05:44 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #3 from Srdjan Jankovic --- Amit, I know it works this way, but would you please consider changing it to create separate var names, like budget_1 quantity_1, budget_2 quantity_2 etc, and maybe maintain num_budgets var or similar. As I said, I know it works without it, but html spec does not guarantee submission of multiple values in any particular order. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 07:29:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 05:29:41 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17623|0 |1 is obsolete| | Attachment #17645|0 |1 is obsolete| | --- Comment #17 from Amit --- Created attachment 18598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18598&action=edit Ability to link directly from an item in the Staff client to budget information. To Test: 1) Create budget and fund under budget administration. 2) Create Vendor in acquisitons module. 3) Create basket under vendor. 4) Create order and choose budget while creating order. 5) Receive shipment. 6) Check in catalog details, in holding tab budget information column is displayed , on click it should display the budget information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 07:32:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 05:32:35 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17574|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 18599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18599&action=edit [SIGNED-OFF] Bug 10090: Add itemtype description instead of code On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions. Links for the ordernumber should be changed. In ordered.pl, we are redirected to the receive page. In spent.pl, the links are deleted. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 07:33:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 05:33:14 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 07:39:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 05:39:46 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #18 from Amit --- Created attachment 18600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18600&action=edit New unit tests for routine: GetBudgetInfoFromItemnumber New unit tests for routine: GetBudgetInfoFromItemnumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 08:09:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 06:09:34 +0000 Subject: [Koha-bugs] [Bug 10368] Added price in overdue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 --- Comment #1 from Amit Gupta --- Created attachment 18601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18601&action=edit Added price in overdue report To Test: 1) Click on circulation menu. 2) Click on overdues report. 3) Price of book will come on the tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 08:09:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 06:09:46 +0000 Subject: [Koha-bugs] [Bug 10368] Added price in overdue report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 08:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 06:16:55 +0000 Subject: [Koha-bugs] [Bug 10370] Adding Callno barcode on circulation print page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 --- Comment #1 from Amit Gupta --- Created attachment 18602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18602&action=edit Adding Callno barcode on circulation print page To Test: 1) Search patron 2) Click on Print button on patron toolbar. 3) Click on Print summary link under Print button 4) Itemcallnumber and barcode will show on print summary page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 08:17:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 06:17:06 +0000 Subject: [Koha-bugs] [Bug 10370] Adding Callno barcode on circulation print page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 08:49:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 06:49:52 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 08:50:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 06:50:00 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:00:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:00:09 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 --- Comment #6 from M. de Rooy --- I had a warning: Use of uninitialized value in concatenation (.) or string at misc/cronjobs/purge_orders.pl line 67. Probably related to a deleted biblio (order with biblionumber null)? You could add a check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:11:48 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy --- QA Comment: Code (on itself) looks good to me. No qa-tools complaints. Also the need for a job to optionally delete acquisition records is recognized. I only wonder if you should only delete from aqorders and if receiveddate should be the date to trigger the action. The following thoughts are not blocking this patch, but just raise a discussion about it: Why not delete baskets? Now we can be stuck with empty baskets. Would you really want to delete orders from an open basket or a basket that has not been received fully? Personally, I would go for a job that deletes inactive baskets (closed and all received) with creationdate as trigger. E.g. I could annually delete all inactive baskets, created more than one year ago or something. In the hope that these considerations may stimulate further improvements and since it only is one new script, passing qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:13:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:13:02 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15367|0 |1 is obsolete| | --- Comment #8 from M. de Rooy --- Created attachment 18603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18603&action=edit Bug 8991: New cronjobs script: purge_orders The script takes a '-until' parameter and deletes all orders received before this date. Execute purge_orders.pl -h for more details. Signed-off-by: Melia Meggs Signed-off-by: Marcel de Rooy With some questions on the Bugzilla report for possible improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:18:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:18:17 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:22:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:22:54 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15907|0 |1 is obsolete| | --- Comment #7 from M. de Rooy --- Created attachment 18604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18604&action=edit Bug 9296 - restructure overduerules table to allow future extension The overduerules table is rather hardcoded to three notices. This patch restructures it so we could have more in future, but should not change anything noticeable yet. To test: 1) edit Tools: Overdue notices 2) cause some notices to be sent 3) notice how everything behaves the same as before Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:23:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:23:22 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 --- Comment #8 from M. de Rooy --- Simple rebase for updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:53:46 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from M. de Rooy --- Like the idea of this patch! A grep on delay1 shows me that there is still some work to do: misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: max(overd uerules.branchcode) as rulebranch, TO_DAYS(NOW())-TO_DAYS(date_due) as daysoverd ue, delay1, delay2, delay3, misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: AND ( (TO _DAYS(NOW())-TO_DAYS(date_due) ) = delay1 misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: if ( $issue->{'da ysoverdue'} == $issue->{'delay1'} ) { t/db_dependent/lib/KohaTest/Overdues/GetBranchcodesWithOverdueRules.pm:delay1, letter1, debarred1, Probably same for delay2 etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:58:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:58:07 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16250|0 |1 is obsolete| | --- Comment #15 from M. de Rooy --- Created attachment 18605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18605&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 09:58:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 07:58:37 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #16 from M. de Rooy --- Two simple merge conflicts resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:03:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 08:03:44 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #17 from M. de Rooy --- Created attachment 18606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18606&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 10:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 08:04:03 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #18 from M. de Rooy --- Forgot: 3.11 -> 3.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:37:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:37:56 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Amit, there is another feature in the queue that might do want you do here but in a bit more flexible way (being configurable by a system preference). Maybe take a look at but 8307? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:40:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:40:06 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:43:36 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 --- Comment #9 from Chris Cormack --- Comment on attachment 15980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15980 Bug 9761: Make it possible to confirm future hold requests at checkin time Review of attachment 15980: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9761&attachment=15980) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1810,4 @@ > AND reserves.reservedate = reserveconstraints.reservedate ) > OR reserves.constrainttype='a' ) > AND (reserves.itemnumber IS NULL OR reserves.itemnumber = ?) > + AND reserves.reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY) I was a little worried about adding this constraint, because this column is not indexed, but I tested with some explains and it should be ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:56:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:56:11 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #19 from M. de Rooy --- QA Comment: Tested this under AcqCreateItem=ordering. And verified that it did not change the items with AcqCreateItem=receiving. It works (I only struggled with booksellerid 952e that was overwritten later on). [We use AcqCreateItem=cataloging and have a different use on 952e. Probably, this field should not be in the marc 952 tag, as it is now.] No complaints from qa-tools. But I do have my doubts over this feature. First, AcqItemSetSubfieldsWhenReceived only works for AcqCreateItem=ordering. This should be noted more clearly in the pref description. What about setting an item value for AcqCreateItem=receiving or cataloging btw? Second, it looks like you want to update some status in the acquisition process and you implemented it in a perhaps somewhat unusual way that makes completely different applications possible. I am afraid that it could make code maintenance more difficult in the long run. Added a small followup for the split statement. Setting the status to Passed QA. I am not blocking this patch, but leave the final comment to RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:57:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:57:14 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18606|0 |1 is obsolete| | --- Comment #20 from M. de Rooy --- Created attachment 18607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18607&action=edit Bug 8307: Set a value for subfields when receiving If items are created when ordering, this patch allows to add a value for some items subfields. Test plan: Define status for items.notforloan (mapping 995$o in unimarc), for example 4:On order, 5:On treatment Set the Syspref AcqCreateItem on "ordering". ACQ framework : set default value = 4 for 995$o (in unimarc) Syspref AcqItemSetSubfieldsWhenReceived : set "o=5|b='foo bar'" When ordering the item, default status will be 4 ; when receiving the item, status will be changed from 4 to 5. The subfield b have to contain 'foo bar' Signed-off-by: Frederic Durand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:57:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:57:33 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:57:39 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:57:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:57:44 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:57:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:57:58 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #21 from M. de Rooy --- Created attachment 18608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18608&action=edit Bug 8307: QA Followup for finishreceive.pl Only split the expression a=b on the first = sign. Tested with the very unlikely z=x=1 :) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:58:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:58:31 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 11:59:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 09:59:12 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Passes all QA tests, testing for regressions now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:09:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:09:00 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #22 from Katrin Fischer --- Hi Marcel, I have been following this bug as it's an interesting feature I get asked about a lot. I am not sure I understand your concerns: >First, AcqItemSetSubfieldsWhenReceived only works for AcqCreateItem=ordering. >This should be noted more clearly in the pref description. >What about setting an item value for AcqCreateItem=receiving or cataloging btw? Not sure how it could work for those settings - it seems to me that in these cases we either have no item to change or no defined event to trigger the change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:13:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:13:19 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #33 from Katrin Fischer --- Hi Kyle, I wasn't aware of your RFC until reading about it here on the bug - maybe you could update the wiki page and send a mail to the mailing list about it? People might have good suggestions/comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:15:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:15:10 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #23 from M. de Rooy --- (In reply to comment #22) > >First, AcqItemSetSubfieldsWhenReceived only works for AcqCreateItem=ordering. >This should be noted more clearly in the pref description. > >What about setting an item value for AcqCreateItem=receiving or cataloging btw? > > Not sure how it could work for those settings - it seems to me that in these > cases we either have no item to change or no defined event to trigger the > change? When you set it to receiving, you do have a new item. In that case it would function as a sort of default. So perhaps we should not do that? Trigger would be the same (confirm receive). In another way for cataloging, I opened another report once for default values for fund and itemtype (does not apply anymore). Just curious if we can get a broader application for this pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:15:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:15:20 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15980|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 18609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18609&action=edit Bug 9761: Make it possible to confirm future hold requests at checkin time Description: A new pref ConfirmFutureHolds is added. When confirming a hold at checkin time, the number of days in this pref is taken into account when looking for reserves. Note that this pref does not interfere with renewing, issuing or transferring a book. For report Holds to pull, the default end date is calculated with this new preference. The use of ConfirmFutureHolds is useful only when future holds are allowed. Test plan: 1) Enable future holds. Add a number of days into ConfirmFutureHolds. 2) Place a future hold within this number of days. 3) Run holds to pull report. Check default startdate and enddate. 4) Check this book in. Can you confirm the hold? Do not confirm. 5) Issue the book to another patron. You should not see a warning. 6) Renew the book for this patron via opac or staff. No warning either. 7) Check in again. Warning pops up again. 8) Transfer book. Switch branch. Check in. Hold found pops up. Do not confirm. 9) Back to first branch. Check in (with popup). Remove the hold. Add new future hold past the number of days. Check in (no warn). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:15:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:15:37 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15981|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 18610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18610&action=edit Bug 9761: dbrev for ConfirmFutureHolds Db rev for new pref ConfirmFutureHolds. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:15:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:15:51 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:15:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:15:53 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18610|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 18611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18611&action=edit Bug 9761: dbrev for ConfirmFutureHolds Db rev for new pref ConfirmFutureHolds. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:17:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:17:07 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18611|0 |1 is obsolete| | --- Comment #14 from Chris Cormack --- Created attachment 18612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18612&action=edit Bug 9761: dbrev for ConfirmFutureHolds Db rev for new pref ConfirmFutureHolds. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:18:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:18:43 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18609|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 18613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18613&action=edit Bug 9761: Make it possible to confirm future hold requests at checkin time Description: A new pref ConfirmFutureHolds is added. When confirming a hold at checkin time, the number of days in this pref is taken into account when looking for reserves. Note that this pref does not interfere with renewing, issuing or transferring a book. For report Holds to pull, the default end date is calculated with this new preference. The use of ConfirmFutureHolds is useful only when future holds are allowed. Test plan: 1) Enable future holds. Add a number of days into ConfirmFutureHolds. 2) Place a future hold within this number of days. 3) Run holds to pull report. Check default startdate and enddate. 4) Check this book in. Can you confirm the hold? Do not confirm. 5) Issue the book to another patron. You should not see a warning. 6) Renew the book for this patron via opac or staff. No warning either. 7) Check in again. Warning pops up again. 8) Transfer book. Switch branch. Check in. Hold found pops up. Do not confirm. 9) Back to first branch. Check in (with popup). Remove the hold. Add new future hold past the number of days. Check in (no warn). Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:19:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:19:41 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18612|0 |1 is obsolete| | --- Comment #16 from Chris Cormack --- Created attachment 18614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18614&action=edit Bug 9761: dbrev for ConfirmFutureHolds Db rev for new pref ConfirmFutureHolds. Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:20:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:20:17 +0000 Subject: [Koha-bugs] [Bug 9761] Make it possible to confirm future hold requests at checkin time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9761 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15982|0 |1 is obsolete| | --- Comment #17 from Chris Cormack --- Created attachment 18615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18615&action=edit Bug 9761: Reformulating the preference description After some thought, I had to reformulate what this pref does. No code changes here. Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:26:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:26:48 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #24 from Katrin Fischer --- Hm, I think dealing with defaults is maybe better done in a different place as this is focused on changing existing values from one value to another. For the use case you gave maybe it would work to use default values in the frameworks? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:27:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:27:22 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:27:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:27:44 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:27:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:27:47 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16274|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 18616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18616&action=edit Bug 9744 - Add a column Fund name on the home page of acquisitions This patch offers an alternative option to fix Bug 9744. In this version the table of funds swaps positions with the suggestions block so that the table has the whole width of the screen. This eliminates the need to adjust its float property. Other changes: - Simplification of the column and row-hiding JavaScript - The addition of an "Active" column to be shown when all funds are shown (this helps indicate to the user which rows were hidden) - Linking the fund owner to their patron record - Linking the fund id, given the correct permissions, to the view of all funds for that budget (the best alternative to linking to a view of the fund details, which we do not have). - Correcting permission level required to add a budget To test, view the acquisitions home page. The layout should feel comfortable. The table of available funds thsould show the fund name. The checkbox to show all funds should work correctly. Signed-off-by: caroline very-mathieu Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:29:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:29:24 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #25 from M. de Rooy --- (In reply to comment #24) > Hm, I think dealing with defaults is maybe better done in a different place > as this is focused on changing existing values from one value to another. > For the use case you gave maybe it would work to use default values in the > frameworks? Yes for the item values that probably would be enough. (Not for the fund and itemtype.) So it may be hard to widen the scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:29:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:29:43 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Did you miss adding your sign off to this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:34:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:34:05 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 12:53:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 10:53:45 +0000 Subject: [Koha-bugs] [Bug 10392] Unable to complete MARC records import after the reservoir In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10392 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Iming Chan --- Issue resolved after installing the software from the Live DVD. Thus closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:07:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:07:28 +0000 Subject: [Koha-bugs] [Bug 10395] New: Unable to create new patron category Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10395 Bug ID: 10395 Summary: Unable to create new patron category Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 18617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18617&action=edit Screen image on error message Unable to create new patron category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:08:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:08:17 +0000 Subject: [Koha-bugs] [Bug 10395] Unable to create new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10395 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |imingchan at yahoo.com.au -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:13:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:13:59 +0000 Subject: [Koha-bugs] [Bug 10395] Unable to create new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10395 --- Comment #1 from Jared Camins-Esakov --- It looks like you are using Internet Explorer, which is not supported for the staff client. Please use Firefox, Chromium, or another standard-compliant browser. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:43:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:43:48 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #3 from Jared Camins-Esakov --- (In reply to comment #2) > @invoices should be checked only if AcqWarnOnDuplicateInvoice is set, > otherwise it is an unnecessary db read. Great catch, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:45:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:45:49 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18472|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov --- Created attachment 18618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18618&action=edit Bug 10366: Alert librarian if an invoice number is duplicated Some vendors ship materials from the same invoice in multiple packages. In those cases, it would be good to notify the librarian when they enter a duplicate invoice number, so that they can continue receiving on the previously-created invoice, rather than creating an invoice with a duplicate number. To test: 1) Apply patch and run database update. 2) Make sure that you have created at least one invoice on acqui/parcels.pl and take note of the invoice number. 3) Try to create an invoice with the same invoice number. 4) Note that without changing your configuration this works exactly the same as before. 5) Turn on the AcqWarnOnDuplicateInvoice system preference. 6) Try to create a new invoice with the same number as the one you noted earlier. 7) Make sure you get a warning about a duplicate invoice. 8) Choose to receive on the existing invoice. 9) Confirm that you are receiving on said existing invoice. 10) Start the receiving process over, and this time choose "Create new invoice anyway." 11) Confirm that you are now receiving on a new invoice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:50:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:50:25 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18587|0 |1 is obsolete| | --- Comment #11 from M. de Rooy --- Created attachment 18619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18619&action=edit Bug 9032: Share a list (part 1: send the invitation) Adds a Share button for OPAC private lists. Allows you to send an invitation to share a list. Checks on validity of email addresses (with Email::Valid). NOTE: This patch adds a routine to VirtualShelves.pm but does not add a test in VirtualShelves.t. This is intentional: I will still add a test, but saw report 10290 and came across a few other problems in this unit test. Will add a patch under report 10386. Test plan: 1) Sharing depends on syspref and login. Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. 2) Try to share a public list or a list you do not own. Find a security hole in the interface. Or hack the shareshelf URL and replace the shelfnumber with a public list number. 3) Enter no email address or invalid ones (no domain, forbidden chars). If you enter no address, submit should not work. If you enter only wrong addresses (separated by: ,:; ), you get a message. 4) Test if sending the invitation works. Share one of your private lists. Enter your own email address. After your proc_message_queue cronjob ran, you should have an email. Check also if you see a new record in the virtualshelfshares table. Note that the followup patch handles the second part of accepting this share. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:50:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:50:34 +0000 Subject: [Koha-bugs] [Bug 9890] Fix the new plugin system for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:50:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:50:35 +0000 Subject: [Koha-bugs] [Bug 9890] Fix the new plugin system for package installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18564|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 18620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18620&action=edit Bug 9890 - Fix koha-create and koha-create-dirs As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly fills __PLUGINS_DIR__ in every installed file. - koha-create-dirs now creates the relevant dir. - enable_plugins is set to 0 currently, no action required here. Regarding the apache configurations, I'm not sure what you mean. Regards To+ Edit: got some minutes to test and re-check and found that the substitution didn't put the right data. Fixed Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:51:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:51:16 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list (part 1: send the invitation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #12 from M. de Rooy --- Small adjustment: one line for debugging purposes removed. Adds Share button on view private shelf form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:53:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:53:43 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:53:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:53:44 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18492|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 18621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18621&action=edit Bug 9394: QA Followup * C4::Reserves::_FixPriority - The previous code checked the cancellationdate. If think you never pass in it with bad parameters, but in order to be sure I added the check on this value. - The reservedates array was never used. * circ/circulation.tt There was a bug: it was not possible to remove an hold from the circulation page. Passing reserve_id fixes the issue. * C4::Reserves::GetReserveId This subroutine did not have a unit test. Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 13:56:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 11:56:16 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 --- Comment #4 from Jared Camins-Esakov --- (In reply to comment #3) > It's not abig deal, it's empty invoices, but maybe making a delete button > and separating Delete link a bit on the list page? Alternatively a confirm > pop-up? Not fussed if the answer is no. If you have any thoughts about how it would be best to do that, I'd be happy to make that change. The reason I did not do that initially is that I wanted to keep the user interface consistent and streamlined, and I was concerned that adding an entire additional step would make users' lives more difficult without really providing them with any protection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:02:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:02:12 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Jonathan Druart --- Thanks Kyle. Since the last patch (qa followup) is signed off, I mark the 2 patches as Passed QA. (see comment 27) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:06:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:06:24 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:06:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:06:46 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 --- Comment #3 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:07:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:07:31 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:07:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:07:33 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15247|0 |1 is obsolete| | --- Comment #52 from Kyle M Hall --- Created attachment 18622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18622&action=edit Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. Tested all variations. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:10:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:10:13 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |kyle.m.hall at gmail.com --- Comment #4 from Kyle M Hall --- Looks like this needs updated a bit. perl t/db_dependent/HoldsQueue.t 1..18 ok 1 - use C4::Reserves; ok 2 - use C4::HoldsQueue; Type of arg 1 to keys must be hash (not subroutine entry) at t/db_dependent/HoldsQueue.t line 42, near "GetBranches;" Execution of t/db_dependent/HoldsQueue.t aborted due to compilation errors. # Looks like you planned 18 tests but ran 2. # Looks like your test exited with 255 just after 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:10:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:10:24 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:34:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:34:02 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:34:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:34:04 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18398|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 18623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18623&action=edit Bug 10290: Followup for Virtualshelves.t Put the 10 biblionumbers in a list Add a FIXME for deleting shelves Do temporary repair on duplicate name test (Followup via report 10386) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:34:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:34:23 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:34:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:34:25 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18623|0 |1 is obsolete| | --- Comment #5 from M. de Rooy --- Created attachment 18624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18624&action=edit Bug 10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:34:28 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 --- Comment #6 from M. de Rooy --- Created attachment 18625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18625&action=edit Bug 10290: Followup for Virtualshelves.t Put the 10 biblionumbers in a list Add a FIXME for deleting shelves Do temporary repair on duplicate name test (Followup via report 10386) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:39:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:39:01 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from M. de Rooy --- QA Comment: Works as advertised. Leaving me only with the question if the borrowers from Jenkins are better than the biblios :) Note that if I test with a small testdb without 10 borrowernumbers, some tests do also fail.. I have added a QA followup for the 10 biblionumbers in a list. And I fixed the sometimes failing test on duplicate list name. Will continue that fix under report 10386. Plus a fixme on why all my lists have been deleted :) Galen: If you feel that this second QA followup still needs another signoff, please indicate so. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:39:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:39:08 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18545|0 |1 is obsolete| | --- Comment #7 from Fridolyn SOMERS --- Created attachment 18626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18626&action=edit Proposed patch Revised patch. I revised AddReturn and AddRenewal to be like AddIssue. See commit message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 14:39:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 12:39:15 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:03:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:03:37 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18626|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS --- Created attachment 18627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18627&action=edit Proposed patch (revised) Unifies code also in CanBookBeIssued and CanBookBeRenewed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:04:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:04:00 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:08:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:08:41 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:18:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:18:55 +0000 Subject: [Koha-bugs] [Bug 10396] New: Catalogue stats shows calendar in callnumber field Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Bug ID: 10396 Summary: Catalogue stats shows calendar in callnumber field Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: sophie.meynieux at biblibre.com On Catalog statitics form, first field filters on callnumber, but because of "From" and "To" values, a calendar is displaid, and it is not possible to enter something different from a date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:22:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:22:30 +0000 Subject: [Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8181 Assignee|gmcharlt at gmail.com |sophie.meynieux at biblibre.co | |m Summary|Catalogue stats shows |Catalog stats shows |calendar in callnumber |calendar in callnumber |field |field --- Comment #1 from Sophie MEYNIEUX --- This patch is a followup of BZ8181 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:22:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:22:30 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10396 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 15:30:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 13:30:19 +0000 Subject: [Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 --- Comment #2 from Sophie MEYNIEUX --- Created attachment 18628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18628&action=edit Bug 10396 : Because of "From" and "to" input field on callnumber, a datepicker is forced on those fields. This bug was introduced by bug 8181. The patch removes the datepicker function on "from" and "to" inputs and adds a datepicker class where needed has described in Bug 8181 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:07:23 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Colin Campbell --- (In reply to comment #2) > It looks pointless to me to have hashrefs with only one key 'itemnumber'. > Would you consider changing those arrays to be pure itemnumbers please, > while you're at it? Yes in fact that simplifies the patch. Will post an update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:17:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:17:47 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. I was reluctant to cherry picking refactoring patches, but it is needed by 10310 which is a good bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:19:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:19:03 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- Nice fix, thanks Jonathan! This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:20:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:20:15 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:22:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:22:03 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18259|0 |1 is obsolete| | --- Comment #4 from Colin Campbell --- Created attachment 18629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18629&action=edit Updated patch Simplified the patch by not processing an array to look like a hash just to save a variable name. Passes an array of itemnumbers as exactly that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:22:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:22:28 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:28:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:28:12 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:37:51 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #1 from Galen Charlton --- (In reply to comment #0) > IMO this unit test should not just delete all records at the start. (Why > ruin my test database for lazy programming :) ? Indeed. I think a worthwhile goal would be for each DB-dependent test (or perhaps the DB-dependent test suite as a whole) to leave the database in essentially the same state it started in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:40:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:40:10 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Jonathan and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 16:47:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 14:47:39 +0000 Subject: [Koha-bugs] [Bug 9744] Add a column Fund name on the home page of acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9744 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:17:27 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- (In reply to comment #7) > Personally, I would go for a job that deletes inactive baskets (closed and > all received) with creationdate as trigger. E.g. I could annually delete all > inactive baskets, created more than one year ago or something. Libraries I'm familiar with, if they purged old orders at all (and IMO, one should think twice about doing so anyway because of the potential value of data-mining past acquisitions activity), would do so only in units of fiscal years. I.e., one might choose to delete all closed orders for the 2011 fiscal year, but depending on how the library handles ordering and receiving at the beginning and end of the fiscal year, that may not actually map cleanly to a specific cutoff date for receiving. I agree that if one is deleting from acqorders, one should also delete the relevant baskets. > In the hope that these considerations may stimulate further improvements and > since it only is one new script, passing qa. I have some reservations about the existence of what could be a pretty major foot-gun. For example, imagine what would happen if one's fingers slipped when entering the date; if you blew away closed orders from the current fiscal year, thereby throwing your fund balances out of whack, there's no recourse except to restore from backup. The original bug report said: > We need a script to delete old orders To which I ask: why? Is there a specific way in which the old orders are getting in the way? Is there a regulatory requirement that's satisfied by purging old orders? I'm not trying to be difficult, but I do think that sometimes it's better for this sort of maintenance to be done via SQL rather than a script. At least when you're staring at the 'mysql>' prompt, you likely know that you're about to do something potentially dangerous. I suggest that the purge job should produce an output file with the complete contents of the rows it deletes. All of that said, ultimately, somebody who runs a script called 'purge_orders.pl' presumably will have an idea of what they're in for, so I will push this patch in a day or two, though with a follow-up to add a dry run mode. However, I would appreciate it if the original patch submitter could respond to Marcel's and my questions and comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:29:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:29:08 +0000 Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991 --- Comment #10 from Galen Charlton --- Also, I question the notion of this script existing as a _cronjob_. Is the idea really to run it automatically? I think misc/maintenance is a better home for this script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:41:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:41:59 +0000 Subject: [Koha-bugs] [Bug 10397] New: link_bibs_to_authorities.pl fails when gets to bibs linked to deleted authority records Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10397 Bug ID: 10397 Summary: link_bibs_to_authorities.pl fails when gets to bibs linked to deleted authority records Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: danielle at bywatersolutions.com CC: m.de.rooy at rijksmuseum.nl When running the link_bibs_to_authorities.pl script it fails when it encounters bibs linked to deleted authorities in subfield $9. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:51:45 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:52:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:52:30 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #86 from Tom?s Cohen Arazi --- Last patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:52:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:52:55 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:53:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:53:20 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 17:54:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 15:54:20 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 18:09:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 16:09:11 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #11 from Galen Charlton --- (In reply to comment #10) > my $userenv = C4::Context->userenv or carp(...); > return C4::Context->userenv->{flags} % 2 == 1; > > It saves one C4::Context->userenv call. Does it? Did you mean my $userenv = C4::Context->userenv or carp(...); return $userenv->{flags} % 2 == 1; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 20:08:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 18:08:31 +0000 Subject: [Koha-bugs] [Bug 10398] New: We should have XML validity tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Bug ID: 10398 Summary: We should have XML validity tests Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 20:09:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 18:09:00 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #4 from Amit --- Hi Srdjan Jankovic, If we have three row say budget1 quantity1, budget2 quantity2, budget3 quantity3 etc suppose if i delete the second row so i we identify the remaining items ID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 20:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 18:13:35 +0000 Subject: [Koha-bugs] [Bug 10398] We should have XML validity tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 18630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18630&action=edit Bug 10398 - Provide xml_valid.t for checking XML validity This patch adds a script that checks every XML file in Koha's source tree using xmllint. To test: - Run find . -name '*.xml' - Apply the patch, and run prove -v xt/xml_valid.t - Verify every xml file was tested. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 20:14:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 18:14:23 +0000 Subject: [Koha-bugs] [Bug 10398] We should have XML validity tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 20:14:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 18:14:30 +0000 Subject: [Koha-bugs] [Bug 10398] We should have XML validity tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:10:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:10:54 +0000 Subject: [Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jweaver at bywatersolutions.co | |m Assignee|gmcharlt at gmail.com |jweaver at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:11:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:11:07 +0000 Subject: [Koha-bugs] [Bug 10398] We should have XML validity tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- Interesting, but I think you are only checking well formed xml. For valid xml I think the command needs to be my @command = qw(xmllint --valid --noout); But in the case of 006/008 value builders you need to specify and external XSD, like (cd-ing to the apropriate folder) xmllint --schema marc21_field_CF.xsd --noout marc21_field_006.xml Anyway, well formed is good enough :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:23:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:23:14 +0000 Subject: [Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 --- Comment #2 from Jesse Weaver --- Created attachment 18631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18631&action=edit Bug 9300 - filtering export.pl by accession date does not work Small typo in query construction, fixed. To test: 1) Try filtering a MARC export using "Start date" 2) Notice the lack of filtering 3) Apply patch 4) Try export again, records are filtered by -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:24:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:24:17 +0000 Subject: [Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 --- Comment #3 from Jesse Weaver --- Created attachment 18632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18632&action=edit Bug 9300 - filtering export.pl by accession date does not work Small typo in query construction, fixed. To test: 1) Try filtering a MARC export using "Start date" 2) Notice the lack of filtering 3) Apply patch 4) Try export again, records are filtered by dateaccessioned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:28:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:28:04 +0000 Subject: [Koha-bugs] [Bug 5393] test case for verifying XML/XSLT files are well-formed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5393 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- *** Bug 10398 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:28:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:28:04 +0000 Subject: [Koha-bugs] [Bug 10398] We should have XML validity tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10398 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Tom?s Cohen Arazi --- This bug is a duplicate of 5393, which I missed due to a bad search and the test itself being in t/ instead of xt/ as I expected. *** This bug has been marked as a duplicate of bug 5393 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 3 21:56:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 19:56:59 +0000 Subject: [Koha-bugs] [Bug 10395] Unable to create new patron category In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10395 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Iming Chan --- Thank you Jared for your assistance. All resolved, thus closed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 00:11:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 22:11:12 +0000 Subject: [Koha-bugs] [Bug 10358] Unable to return items via self check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 00:11:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 22:11:15 +0000 Subject: [Koha-bugs] [Bug 10358] Unable to return items via self check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 --- Comment #4 from Mason James --- Created attachment 18633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18633&action=edit Bug 10358 - Unable to return items via self check to test, before applying patch? 1/ issue an item to a user, set the duedate in the past (2001-01-01) to make this item overdue 2/ attempt to check-in item via SCO, at http://opac/cgi-bin/koha/sco/sco-main.pl note a warning message - with no option to return item :/ -------------------------------------- Item cannot be checked out. Sorry, this item cannot be checked out at this station. -------------------------------------- 3/ apply patch 4/ attempt to check-in item via SCO note a warning message - now *with* a check-in button 5/ click 'check-in' button 6/ note that item has been returned successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 00:12:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Jun 2013 22:12:50 +0000 Subject: [Koha-bugs] [Bug 10358] Unable to return *overdue* items via self check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unable to return items via |Unable to return *overdue* |self check |items via self check -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:07:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 00:07:04 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #12 from Srdjan Jankovic --- > Does it? Did you mean > > my $userenv = C4::Context->userenv or carp(...); > return $userenv->{flags} % 2 == 1; Sure, sorry, not enough coffee I guess... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 00:12:45 +0000 Subject: [Koha-bugs] [Bug 10390] Add ability to delete unused invoices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10390 --- Comment #5 from Srdjan Jankovic --- Sure, that was just an idea, I'd actually go for adding an extra nbsp; or something before delete. But as I say, if you wish to leave it like it is now no big deal, I'll sign it off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 02:22:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 00:22:02 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #5 from Srdjan Jankovic --- You can maintain hidden num_budgets or max_budget input var. Upon submit, you go through budget1, budget2, ... budget[max_]budget], and skip if not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 03:03:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 01:03:14 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #3 from Srdjan Jankovic --- A few remarks (you may choose to ignore): _request(): * you are only logging die() case, it may be good to log $response->as_string if !$response->success. GetOverDriveToken(): * m!! (or similar) is a tad easier to read then m,, * in warn $contents->{'error_description'} it is assumed that from_json() was successful Please let me know if you want to leave as is, I'll sign it off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 03:23:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 01:23:49 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #4 from Srdjan Jankovic --- Jonathan, I'm not sure if there's a consensus re constructors in the Koha namespace and use of Class::Accessor. I believe it is rarely necessary to provide new() in those cases. I suggest: * remove new() constructors all together, Koha::AuthorisedValue->new({av => $av}) is unnecessary cause it is equivalent to Koha::AuthorisedValue->new($av} * upgrade fetch(key) to constructors, passing the key values; this way Koha::AuthorisedValues->new() becomes Koha::AuthorisedValues->fetch() * if you need to reload(), make those methods, and make reload() and fetch() call _fetch(key) In general, has there been a discussion on using DBIx::Class or similar? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 03:54:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 01:54:45 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18629|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic --- Created attachment 18634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18634&action=edit [SIGNED-OFF] Bug 10291: Clarify misleading variable name Remove the unrequired extra processing and pass the array of itemnumbers as itemnumbers_array Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 03:55:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 01:55:22 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:11:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 02:11:40 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18618|0 |1 is obsolete| | --- Comment #5 from Srdjan Jankovic --- Created attachment 18635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18635&action=edit Bug 10366: Alert librarian if an invoice number is duplicated Some vendors ship materials from the same invoice in multiple packages. In those cases, it would be good to notify the librarian when they enter a duplicate invoice number, so that they can continue receiving on the previously-created invoice, rather than creating an invoice with a duplicate number. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 04:12:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 02:12:29 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 05:52:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 03:52:10 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic --- SendAlerts() is not used only from serials/claims.pl, but from members/memberentry.pl as well, which would cause unwanted Bcc. I suggest type is examined for Bcc as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 06:40:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 04:40:37 +0000 Subject: [Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18562|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 18636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18636&action=edit [SIGNED-OFF] Bug 9779 - Remove global include of YUI assets from the staff client There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 06:41:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 04:41:13 +0000 Subject: [Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:09:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 06:09:18 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18218|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic --- Created attachment 18637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18637&action=edit [SIGNED-OFF] Bug 9558 - Customize CSS for mobile It is possible to use an environment variable to specify a custom stylesheet for different libraries in a multi-library system: $ENV{'OPAC_CSS_OVERRIDE'}. This patch adds an additional option to override the CCSR theme's mobile stylesheet. The changes in this patch are courtesy Zachary Spalding as described in Bug 9558. Patch and test plan created by Owen Leonard. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:09:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 06:09:49 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:20:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 06:20:42 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I think the point of having the itemtype on item level is that you often have several different itemtypes on one record - like some items are for reference, overnight loan, or normal loan. So the statistics would just be wrong and missing the interesting bit, if we don't look at item level here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 08:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 06:30:26 +0000 Subject: [Koha-bugs] [Bug 10385] item-level_itype checks need to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think there has been some work to make use of the biblio level itemtype for display in the result lists even when item level itemtypes are being used. So I am not sure it will work for everyone to only use the itype from the level set in the system preference. Maybe we could return 3 values? Both itemtypes for biblio and item level and the one to be used for circulation logic? As our libraries participate in a union catalog where the records are imported/updated automatically into Koha, we don't set bilbio level itemtypes at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 10:00:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 08:00:25 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #24 from Dobrica Pavlinusic --- David, can you please post your ldap config from koha-conf.xml? From looking at a code I agree with Rolando that setting auth_by_bind to 1 should fix your problem (hopefully). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:17:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 09:17:22 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #6 from Koha Team Lyon 3 --- Yes, I completely forgot, sorry. And now the patch doesn't apply any more... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 11:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 09:17:36 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:17:34 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #14 from Jonathan Druart --- Sorry Owen but I always get the same error, tested on several instance :-/ Could someone else try to apply it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:35:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:35:02 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #6 from Jonathan Druart --- (In reply to comment #5) > Do I need to do some prep first, or some special config? No, it is the goal of this patch :) Since the course course are removed at the end of the test file, I think the truncate queries are useless. I will provide a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:35:19 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18382|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 18638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18638&action=edit Bug 10332: CourseReserves.t needs to create its own data prove t/db_dependent/CourseReserves.t t/db_dependent/CourseReserves.t .. ok All tests successful. Files=1, Tests=20, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.48 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:37:51 +0000 Subject: [Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:38:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:38:19 +0000 Subject: [Koha-bugs] [Bug 10396] Catalog stats shows calendar in callnumber field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10396 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|major |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:44:48 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 --- Comment #5 from Jonathan Druart --- (In reply to comment #4) > Looks like this needs updated a bit. Kyle, did you seen my comment 2? :) Do you plan to work on it? That would be really good if this file passes all the tests. I managed to pass all tests from all others files, but not these ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 14:47:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 12:47:33 +0000 Subject: [Koha-bugs] [Bug 9930] can't update patron info in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9930 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #6 from Fridolyn SOMERS --- (In reply to comment #5) > Pushed to 3.10.x will be in 3.10.5 This patch depends on Bug 7067 which is only pushed in 3.12. Actually in 3.10.x the link leads to 404 page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:08:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 13:08:13 +0000 Subject: [Koha-bugs] [Bug 10399] New: rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399 Bug ID: 10399 Summary: rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com Currently, the only way to get indexes reset is to run the zebraidx... init by hand on each database (authorities or biblios). This leads to several problems: ownership, permission, wrong paths, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:21:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 13:21:56 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 --- Comment #6 from Kyle M Hall --- I read it, but I didn't fully understand it until today. I should have noticed the WIP in the title. I hadn't planned on working on this. If I can get some free time I'd be more than happy to assist! However, I cannot say when that may be. (In reply to comment #5) > (In reply to comment #4) > > Looks like this needs updated a bit. > > Kyle, did you seen my comment 2? :) > Do you plan to work on it? That would be really good if this file passes all > the tests. I managed to pass all tests from all others files, but not these > ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:22:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 13:22:01 +0000 Subject: [Koha-bugs] [Bug 10399] rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 18639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18639&action=edit Bug 10399 - rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty This patch add the reset_indexes sub to the rebuild_zebra.pl script. And changes the scripts' logic to run it in case -r was passed and there are no records pending on the zebraqueue table. Regards To+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:22:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 13:22:11 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:22:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 13:22:59 +0000 Subject: [Koha-bugs] [Bug 10399] rebuild_zebra.pl should reset the indexes with -r even if zebraqueue empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 15:49:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 13:49:34 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #3 from Mirko Tietgen --- Actually I was thinking it should go into some kind of privacy section in the future. There is more personal data that may have to be deleted on a regular basis to meet privacy/data protection requirements. I see the relation to Search.pm but it is not the place I would have been looking for this kind of feature. And Search.pm is bloated as it is. I'd welcome more comments on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 14:15:21 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18070|0 |1 is obsolete| | Attachment #18265|0 |1 is obsolete| | --- Comment #35 from Koha Team Lyon 3 --- Created attachment 18640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18640&action=edit Bug 9593 Prices not imported correctly from a staged file Hello Mathieu The last patch I proposed was not coherent with the possibility to choose in currency choice list of Accounting detail block a different currency than the active one. It could produce a double conversion of the price. So, at the end, I propose again the previous patch(with marginal modifications). You wrote in comment 28 "Not sure to agree with this behavior if it is a new one" but it's not. Even if it modifies thoroughly the MungeMarcPrice routine, it keeps the main logic ( picking the active currency if possible) with the advantage of finding it whatever the position of symbol or isocode regarding the digits part. Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:15:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 14:15:30 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:18:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 14:18:44 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- >From IRC: [06:54:14] @later tell gmcharlt could you have a look at the comments on bug?10361 please? do you agree i should move the query to Search.pm? ... [07:16:14] to answer your question, if you don't want to spend too much effort at it, I agree with Srdjan that it should go into C4::Search -- that's where AddSearchHistory and GetSearchHistory live at the moment [07:17:05] if you want to take a little more time and refactor, maybe put it in a new module called Koha::Search::History on thel ike -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 16:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 14:36:09 +0000 Subject: [Koha-bugs] [Bug 10400] New: Text::CSV_XS error-checking should be standardized Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10400 Bug ID: 10400 Summary: Text::CSV_XS error-checking should be standardized Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: gmcharlt at gmail.com As reported by Doug Kingston on koha-devel on 2013-06-02, if version 0.97 of Text::CSV_XS is installed, it can segfault. From Doug's email: "The error from t/Labels.t is a segmentation fault when calling $csv->error_input() in Labels/Label.pm. sub _get_text_fields { my $format_string = shift; my $csv = Text::CSV_XS->new({allow_whitespace => 1}); my $status = $csv->parse($format_string); my @sorted_fields = map {{ 'code' => $_, desc => $_ }} map { $_ eq 'callnumber' ? 'itemcallnumber' : $_ } # see bug 5653 $csv->fields(); my $error = $csv->error_input(); warn sprintf('Text field sort failed with this error: %s', $error) if $error; return \@sorted_fields; }" A ticket was opened with the maintainer of Text::CSV_XS (https://rt.cpan.org/Ticket/Display.html?id=85810), and he fixed the segfault bug in version 0.98 of the module. Nonetheless, Koha code that uses Text::CSV_XS should follow the module's documentation more closely; in particular, it looks like the correct thing to do is the check the value of the $status returned by $csv->parse() before deciding whether to invoke error_input(). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:11:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:11:48 +0000 Subject: [Koha-bugs] [Bug 10385] item-level_itype checks need to be refactored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385 --- Comment #2 from Galen Charlton --- In light of that... how about no syspref at all? What I mean is that we make *both* biblio- and item-level item types visible. For the sake of clarity, I'll call the biblo-level ones "material types". For circulation rules, *both* the item type and the material type could be taken into account by adding a material type column to issuingrules (and on upgrade, populating it based on the value of the syspref). For OPAC display, allow icons to be associated with both material types and item types. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:20:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:20:04 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18540|0 |1 is obsolete| | --- Comment #3 from Fridolyn SOMERS --- Created attachment 18641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18641&action=edit Proposed patch Here is a new patch with warn regardless to debug mode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:20:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:20:36 +0000 Subject: [Koha-bugs] [Bug 10400] Text::CSV_XS error-checking should be standardized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10400 --- Comment #1 from Galen Charlton --- Also, in that snippet of code, there's no point in calling ->fields() until we know that the parsing was successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:43:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:43:51 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18367|0 |1 is obsolete| | Attachment #18370|0 |1 is obsolete| | Attachment #18371|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 18642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18642&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:43:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:43:50 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:45:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:45:48 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18642|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 18643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18643&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:54:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:54:11 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks for the fix Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:55:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:55:28 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. Leaving as ASSIGNED, waiting for the followups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:56:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:56:24 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to comment #6) > This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks for the fix > Kyle! Thanks Galen, I mixed my bug comments with 10262 :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:56:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:56:55 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Kyle for the fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 17:58:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 15:58:01 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #12 from mathieu saby --- Sorry, my VM is broken, so the followups won't be there until some days... Mathieu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:04:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:04:53 +0000 Subject: [Koha-bugs] [Bug 10401] New: Add ability to merge invoices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401 Bug ID: 10401 Summary: Add ability to merge invoices Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com In situations where items from a single vendor invoice are received on more than one Koha invoice, it would be really useful to be able to merge invoices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:10:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:10:18 +0000 Subject: [Koha-bugs] [Bug 10402] New: Add multiple contacts for vendors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402 Bug ID: 10402 Summary: Add multiple contacts for vendors Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com Some vendors may have more than one contact. For example, a technical contact and a billing contact, or a contact for journals and a contact for monographs. Rather than require that each contact be either made into a separate vendor or recorded somewhere outside of Koha, it would be really useful of Koha had the ability to add multiple additional contacts to vendors i the acquisitions module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:13:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:13:41 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #10 from Fridolyn SOMERS --- (In reply to comment #9) And do you agree with the patch ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:22:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:22:57 +0000 Subject: [Koha-bugs] [Bug 10403] New: Add ability to set fund/budget on receipt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Bug ID: 10403 Summary: Add ability to set fund/budget on receipt Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This development will add the ability to change the budget and fund when receiving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:24:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:24:13 +0000 Subject: [Koha-bugs] [Bug 10404] New: Add previous/next browsing to staff client search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10404 Bug ID: 10404 Summary: Add previous/next browsing to staff client search results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: new feature Priority: P5 - low Component: Staff Client Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com CC: gmcharlt at gmail.com There is currently no way to go to the next record in a search result list on the staff client, and there really should be some sort of previous/next browse functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:39:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:39:09 +0000 Subject: [Koha-bugs] [Bug 5695] Cart display should show proper item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5695 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 18:47:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 16:47:53 +0000 Subject: [Koha-bugs] [Bug 10405] New: User-editable sections should have ids Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405 Bug ID: 10405 Summary: User-editable sections should have ids Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jcamins at cpbibliography.com Right now the following user-editable sections do not have css ids: opacheader OpacNavBottom OpacNavRight OpacSearchForTitleIn OpacUserCSS opacuserjs They should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 19:19:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 17:19:58 +0000 Subject: [Koha-bugs] [Bug 10406] New: Remove obsolete CSS related to YUI autocomplete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 Bug ID: 10406 Summary: Remove obsolete CSS related to YUI autocomplete Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org There are a couple of sections in staff-global.css which relate to YUI autocomplete. Since this has been replaced with jQueryUI autocomplete they can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 19:36:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 17:36:30 +0000 Subject: [Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 --- Comment #1 from Owen Leonard --- Created attachment 18644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18644&action=edit Bug 10406 - Remove obsolete CSS related to YUI autocomplete staff-global.css contains CSS which related to the old YUI autocomplete widget. Since this has been replaced with jQueryUI the CSS is now unused and can be removed. To test, apply the patch and confirm that autocomplete looks correct and works correctly in the global circulation search box (with CircAutocompl enabled) and in the overdues report when entering a value into the filter form in a patron attribute field which is linked to an authorized value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 19:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 17:36:29 +0000 Subject: [Koha-bugs] [Bug 10406] Remove obsolete CSS related to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10406 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 19:59:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 17:59:36 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 19:59:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 17:59:37 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18638|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov --- Created attachment 18645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18645&action=edit Bug 10332: CourseReserves.t needs to create its own data prove t/db_dependent/CourseReserves.t t/db_dependent/CourseReserves.t .. ok All tests successful. Files=1, Tests=20, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.48 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov Without correct data, test fails prior to patch, passes no matter what after patch is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:03:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:03:09 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Jared Camins-Esakov --- This one does not work for me. I get the following output (with DEBUG on): jcamins at kohadev:~/kohaclone$ perl t/db_dependent/Reserves.t 1..4 ok 1 - use C4::Reserves; # # Creating biblio instance for testing. # Creating item instance for testing. INSERT INTO borrowers SET borrowers.firstname = ? , borrowers.dateenrolled = ? , borrowers.userid = ? , borrowers.categorycode = ? , borrowers.surname = ? , borrowers.dateexpiry = ? , borrowers.password = ? , borrowers.cardnumber = ? , borrowers.branchcode = ? my firstname,2013-06-04,myfirstname.mysurname,S,my surname,2021-09-04,!,CARDNUMBER42,CPL at /home/jcamins/kohaclone/C4/SQLHelper.pm line 182. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. not ok 2 - CheckReserves Test 1 # Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 66. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. not ok 3 - CheckReserves Test 2 # Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 69. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. not ok 4 - CheckReserves Test 3 # Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 72. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. # Looks like you failed 3 tests of 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:08:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:08:48 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Jared Camins-Esakov --- I am not sure this one is right. It looks like the DelOrder calls are hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't make sense to me. Should it perhaps be DelOrder($biblionumber1, $ordernumber1) ... etc.? Setting to In Discussion in case I am misunderstanding the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:10:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:10:30 +0000 Subject: [Koha-bugs] [Bug 10383] printable version of bib record doesn't include subtitle in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10383 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 --- Comment #1 from Owen Leonard --- Setting version to 3.10.x: 3.12 and higher do not have a custom print view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:14:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:14:40 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:14:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:14:42 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18235|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 18646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18646&action=edit Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update ' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install ' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links Signed-off-by: Jared Camins-Esakov Strings are now translated, and no emergent JS errors have revealed themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:18:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:18:49 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 --- Comment #32 from Kyle M Hall --- Melia is correct, the each enable different functionality. (In reply to comment #31) > I think they are two different things - one is concerned with overdue fines > only, and the other is concerned with paying/refunding the replacement price. > > ForgiveFineWhenLost - an item goes overdue and starts to accrue fines. > Eventually, it goes to lost status but has maybe accrued $300 in overdue > fines already. Now that the item is lost, the library wants to charge the > replacement price for the lost item but is not concerned about collecting > the $300 in overdue fines. So this sys pref lets you forgive all of the > overdue fines when the item goes to lost. > > RefundLostItemFeeOnReturn - an item goes to lost, and the replacement price > is charged. But then later the patron finds the lost item and returns it. > Right now, I think Koha refunds the replacement price to the patron. Some > libraries aren't allowed to refund money that patrons have already paid > them, so this sys pref makes it so that you can choose whether the > replacement price is refunded to the patron or not. ('He found the book, so > he is not required to pay the replacement price any more and gets a refund' > versus 'He kept the book for so long that we thought it was lost, so now he > must pay regardless'). > > At least I think that's the idea... Kyle, please correct me if I got any of > that is wrong! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:36:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:36:48 +0000 Subject: [Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:38:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:38:51 +0000 Subject: [Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 --- Comment #1 from Owen Leonard --- Created attachment 18647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18647&action=edit Bug 10307 - z39.50 server search tab shows z390.50 The label on the global search form for Z39.50 administration reads "Z390.50." This patch corrects the typo. To test, apply the patch and navigate to Administration -> Z39.50 servers. The label on the global search tab should read "Search Z39.50 servers." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:38:50 +0000 Subject: [Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:41:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:41:39 +0000 Subject: [Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:41:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:41:44 +0000 Subject: [Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:42:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:42:06 +0000 Subject: [Koha-bugs] [Bug 10307] z39.50 server search tab shows z390.50 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Galen Charlton --- Trivial string patch; pushing directly to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:46:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:46:44 +0000 Subject: [Koha-bugs] [Bug 10407] New: allow MARCXML records to be imported via Koha's GUI Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Bug ID: 10407 Summary: allow MARCXML records to be imported via Koha's GUI Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com currently, you can only import MARCXML records into Koha using the ./bulkmarcimport.pl tool, from the command-line this bug will attempt to add that functionality to Koha's GUI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 20:50:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 18:50:24 +0000 Subject: [Koha-bugs] [Bug 10408] New: allow Koha to automatically link to authoritiy records, when importing bibs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10408 Bug ID: 10408 Summary: allow Koha to automatically link to authoritiy records, when importing bibs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com currently, Koha does not attempt to link bibs to existing auth records, during bib import this bug will attempt to add that functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 21:09:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 19:09:50 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 21:48:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 19:48:28 +0000 Subject: [Koha-bugs] [Bug 10409] New: Do not show course entry form if no departments are found Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Bug ID: 10409 Summary: Do not show course entry form if no departments are found Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/course_reserves/course.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org The course reserves entry form shows an error message instead of a form field for the department if no departments are defined: "No DEPARTMENT authorised values found! Please create one or more authorised values with the category DEPARTMENT." If you can't fill out the form because there are no departments, there's no reason to display the form. Otherwise people might fill in the rest of the fields and find they can't submit the form. It would be better to show the error message alone on the page and link the user to the authorized values page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 4 23:13:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 21:13:52 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtj at kohaaloha.com --- Comment #8 from Mason James --- (In reply to comment #7) > Created attachment 18108 [details] [review] > Bug 10096 [DB Follow-up] - Add a Z39.50 interface for authority searching > > This patch adds the "recordtype" column to the "z3950servers" table. > > The value in this column (biblio or authority) then controls whether > the z3950 server shows up in a bibliographic search (through the > Acq and Cataloguing modules) or in an authority search (through > the Authorities module). > > I also edited the z3950 management console to show this value > and allow users to edit it. The default value is "biblio", since > the vast majority of z3950 targets will be bibliographic. However, > there is an option to add/edit a z3950 target as a source of > authority records. > > Test Plan: > > 1) Apply both patches hmm, the 2nd patch does not apply to master (b74ac4a) ------------------------------------------- head$ git reset --hard origin/master HEAD is now at b74ac4a Bug 10307 - z39.50 server search tab shows z390.50 mason at xen1:~/g/head$ git bz attach 10096 Bug 10096 - Add a Z39.50 interface for authority searching (2) Apply? [yn] y Applying: Bug 10096 - Add a Z39.50 interface for authority searching Bug 10096 [DB Follow-up] - Add a Z39.50 interface for authority searching Apply? [yn] y Applying: Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching ------------------------------------------- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:06:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 23:06:19 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #1 from mathieu saby --- I agree it is a needed feature. For example, if librarians want to use a tool like Zotero to gather bibliographic references on the web, and import the result into Koha for creating orders, presently, they need to use an extra-koha tool for converting marcxml records into iso2709 records. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:28:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 23:28:52 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:28:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 23:28:54 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18108|0 |1 is obsolete| | --- Comment #9 from Mason James --- Created attachment 18648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18648&action=edit Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 01:30:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Jun 2013 23:30:02 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #10 from Mason James --- > > Test Plan: > > > > 1) Apply both patches > > hmm, the 2nd patch does not apply to master (b74ac4a) > i've uploaded a 2nd patch that does apply to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 02:06:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 00:06:43 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Conflict in koha-tmpl/intranet-tmpl/prog/en/js/datatables.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 02:25:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 00:25:51 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #12 from Chris Cormack --- I like the idea of use Net::Printer, but did you know there is already a printer queue and a script to set the printer (network one). This could be generalised to use this Check admin/printers.pl And DROP TABLE IF EXISTS `printers`; CREATE TABLE `printers` ( `printername` varchar(40) NOT NULL default '', `printqueue` varchar(20) default NULL, `printtype` varchar(20) default NULL, PRIMARY KEY (`printername`) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; So i'd like to see it use this (extended if nessecary). Will put this to In discussion and will wait for an opinion from Galen, if he is happy with it as it is, I will continue with QA on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 02:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 00:35:22 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- This seems to work well, 1/ but could you please do a follow up fixing the text in the ilsdi.pl?service=Describe&verb=CancelHold page 2/ Also we introduce 2 new subroutines, so could we get a unit test for each one. 3/ Finally we do this $query = qq{ INSERT INTO old_reserves SELECT * FROM reserves WHERE reserve_id = ? }; $sth = $dbh->prepare($query); $sth->execute($reserve_id); $query = qq{ DELETE FROM reserves WHERE reserve_id = ? }; $sth = $dbh->prepare($query); $sth->execute($reserve_id); It would be safer/nicer to check the result of our execute into the old_reserves before we delete it from reserves, if that insert fails we do the delete anyway at the moment Failing QA for 1 and 2, bonus points if you fix 3 also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 03:13:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 01:13:47 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 03:13:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 01:13:50 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16592|0 |1 is obsolete| | --- Comment #21 from Chris Cormack --- Created attachment 18649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18649&action=edit Bug 8600 - Remove search terms in advanced search Rewrote parts of previous patch by Marc Veron to remove remove href and onclick of links and instead use jQuery Signed-off-by: Cedric Vita Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 03:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 01:42:05 +0000 Subject: [Koha-bugs] [Bug 10358] add a syspref to allow BLOCKED patrons to return items, via the SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unable to return *overdue* |add a syspref to allow |items via self check |BLOCKED patrons to return | |items, via the SCO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 03:43:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 01:43:20 +0000 Subject: [Koha-bugs] [Bug 7382] normalization on isbn matching rule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7382 JaTara Barnes changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30 at gmail.com --- Comment #4 from JaTara Barnes --- What's a good starting point for getting this fixed? I'd love to help with this project. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 03:59:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 01:59:52 +0000 Subject: [Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 03:59:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 01:59:54 +0000 Subject: [Koha-bugs] [Bug 9728] XISBN use simple search instead of SQL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9728 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16633|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 18650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18650&action=edit Bug 9728: XISBN use simple search instead of SQL XISBN API uses normalized ISBN of a biblio to get a list of ISBNs, then searches via SQL in database for notices with those ISBNs. I noticed that if input ISBN has hyphens then returned ISBNs have hyphens else they don't have. So SQL query will not find if ISBNs have hyphens in database. Also, if biblio has several ISBN, only first one can be found with actual SQL query (isbn LIKE '$xisbn%'). This patch replaces SQL query by a simple search "nb=$xisbn". This will find biblio from ISBN with or without hyphen. Test plan : - Activate FRBRizeEditions and XISBN sysprefs - Go to a biblio witch has several editions - Note its normalized ISBN (you may look in amazon links) - Replace [ISBN] by biblio normalized ISBN in this URL : http://xisbn.worldcat.org/webservices/xid/isbn/[ISBN]?method=getEditions&format=xml&fl=form,year,lang,ed - Go to this URL and see which ISBNs are returned - Perform a simple search on thoses ISBNs : nb:1234567890 - Look at "Editions" tab => Check that diplayed biblios are the same you found by simple search Signed-off-by: jmbroust Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 04:37:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 02:37:34 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #9 from Srdjan Jankovic --- I know this is not the right forum to raise the topic, but I've done worse things in my life: When I do this kind of testing, I do it within a transaction, and rollback at the end. That way I do not need to think about a proper cleanup. Has there been any thoughts on that subject? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 05:02:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 03:02:53 +0000 Subject: [Koha-bugs] [Bug 10410] New: SCO displays 'return this item' even if item's barcode is not found Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10410 Bug ID: 10410 Summary: SCO displays 'return this item' even if item's barcode is not found Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com Created attachment 18651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18651&action=edit pic currently in the SCO, when returning an item - the SCO displays 'return this item' even if item's barcode is not found pic attached -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 05:20:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 03:20:59 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #10 from Jared Camins-Esakov --- (In reply to comment #9) > I know this is not the right forum to raise the topic, but I've done worse > things in my life: > > When I do this kind of testing, I do it within a transaction, and rollback > at the end. That way I do not need to think about a proper cleanup. Has > there been any thoughts on that subject? I love that idea! But I have no idea if it's possible to do that within our existing code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 06:37:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 04:37:49 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 --- Comment #2 from Srdjan Jankovic --- Created attachment 18652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18652&action=edit bug_9299: rework unique attributes check on ldap login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 06:41:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 04:41:07 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Srdjan Jankovic --- To test: Have ldap server set up in koha-conf.xml and ExtendedPatronAttributes syspref enabled, with no extended attributes defined. Successful login should not throw an exception. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 06:50:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 04:50:56 +0000 Subject: [Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Pierre Angot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #2 from Pierre Angot --- +1 ! It's really a good idea ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 07:49:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 05:49:57 +0000 Subject: [Koha-bugs] [Bug 10411] New: Add cache control headers to static resources in the apache config Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Bug ID: 10411 Summary: Add cache control headers to static resources in the apache config Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz CC: robin at catalyst.net.nz Currently, the static resources aren't explicitly cached. In the case of firefox, this causes a request every time for every image, that usually results in a 304 Not Modified response. This isn't a good use of apache's time, also may make the page appear to render a bit slower. The patch for this will put a 12 hour cache timeout on the images, javascript, and CSS files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 08:00:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 06:00:58 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 --- Comment #1 from Robin Sheat --- Created attachment 18653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18653&action=edit Bug 10411 - add cache control headers for static resources This adds caching directives to the static resources so that the browser doesn't ask about them all the time. By default, Debian apache doesn't have the required module (mod_expires) enabled, and so this patch will have no effect. In order to enable this function, run: a2enmod expires and restart apache. Test Plan: * Using firebug or equivalent, load a page. * Note that none of the images, css, or js files have a Cache-Control or Expires header set. * Add this patch, redeploy the package with it (or overwrite the apache-share.conf file) enable the 'expires' module, restart apache. * Force-reload the page * Note that the images, css, js now have Cache-Control and Expires set for 12 hours into the future. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 08:02:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 06:02:15 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 08:02:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 06:02:34 +0000 Subject: [Koha-bugs] [Bug 10411] Add cache control headers to static resources in the apache config In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10411 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 08:18:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 06:18:13 +0000 Subject: [Koha-bugs] [Bug 9549] Local Cover are not displayed in the Shelf Browser. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9549 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16700|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 18654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18654&action=edit Bug 9549 Fix localcovers not shown in shelves browser. I had to add some css to align to center the span containing the images. Add the ability to view local cover images in the shelf browser. To test: 1. Add a local cover image to a record. Set OPACLocalCoverImages sys pref to "display." 2. Search for the record, go to the Details page, and click on Browse Shelf. 3. Verify that the local cover image appears in the shelf browser. Sponsored-by: CCSR Signed-off-by: Melia Meggs Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 08:18:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 06:18:10 +0000 Subject: [Koha-bugs] [Bug 9549] Local Cover are not displayed in the Shelf Browser. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9549 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:15:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:15:47 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:15:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:15:49 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16461|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 18655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18655&action=edit Bug 9747: Fix sorting issues on z3950 search results At least the BNF server returns results containing non-sorting characters (NSB SNE). In order to sort results according these characters, this patch adds a new Datatable function. Test plan: - search 'tintin' on the z3950 search (cataloguing/z3950_search.pl) - sort on title (default sort) and check that results are not well sorted. - apply this patch - do the same search and check that the first result is "Herg?. Les Aventures de Tintin..." The value of the cell is: ?Herg?. Les ?Aventures de Tintin... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:26:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:26:07 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18655|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 18656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18656&action=edit Bug 9747: Fix sorting issues on z3950 search results At least the BNF server returns results containing non-sorting characters (NSB SNE). In order to sort results according these characters, this patch adds a new Datatable function. Test plan: - search 'tintin' on the z3950 search (cataloguing/z3950_search.pl) - sort on title (default sort) and check that results are not well sorted. - apply this patch - do the same search and check that the first result is "Herg?. Les Aventures de Tintin..." The value of the cell is: ?Herg?. Les ?Aventures de Tintin... Signed-off-by: Chris Cormack Works as advertised and doesn't break existing searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:26:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:26:08 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #11 from Jonathan Druart --- (In reply to comment #9) > When I do this kind of testing, I do it within a transaction, and rollback > at the end. That way I do not need to think about a proper cleanup. Has > there been any thoughts on that subject? Yes we should look deeper into this way. The t/db_dependent/HoldsQueue.t already use a roolback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:26:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:26:29 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:37:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:37:48 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18656|0 |1 is obsolete| | Status|Passed QA |Needs Signoff Assignee|jonathan.druart at biblibre.co |fridolyn.somers at biblibre.co |m |m --- Comment #12 from Fridolyn SOMERS --- Created attachment 18657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18657&action=edit Bug 9747 - sort issue for the z3950 results Rebased patch. Datatable sorting is now very different, I really have rewritten this part. I also applied this sort on acquisition page using z3950 search. There are many changes so I set bug to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:40:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:40:40 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 --- Comment #13 from Fridolyn SOMERS --- You may test with Tolkien as author, you get : The Lord of the rings, The Two towers, The Return of the king, ... Note that NSB and NSE are not visible in MARC popup view, but if you copy/paste the title in an advanced editor (like Geany), you will see them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:49:10 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16272|0 |1 is obsolete| | --- Comment #7 from Fridolyn SOMERS --- Created attachment 18658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18658&action=edit Bug 9576 - Enable or disable issue limit confirmation Rebased master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 09:50:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 07:50:05 +0000 Subject: [Koha-bugs] [Bug 9576] Enable or disable issue limit confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:11:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:11:00 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:11:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:11:02 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18250|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 18659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18659&action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:12:31 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #4 from Jonathan Druart --- Jared, thank you for testing. I confirm the tests pass here :-/ Could you retry with the last patch please? It replaces ok with is. We should have a more readable failure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:13:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:13:23 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18659|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 18660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18660&action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:17:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:17:01 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #4 from Jonathan Druart --- (In reply to comment #3) > I am not sure this one is right. It looks like the DelOrder calls are > hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't > make sense to me. Should it perhaps be DelOrder($biblionumber1, > $ordernumber1) ... etc.? Yes, of course! I will provide a new patch. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:17:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:17:35 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18251|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 18661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18661&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:17:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:17:33 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:58:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:58:54 +0000 Subject: [Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 10:58:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 08:58:56 +0000 Subject: [Koha-bugs] [Bug 10015] UniqueItemFields could have link to database documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10015 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17347|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 18662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18662&action=edit Bug 10015 - UniqueItemFields could have link to database documentation Other system preferences which require entry of database column names include a link to the scheme for reference. The UniqueItemFields should do the same. This patch rewords the preference description to incorporate a link. To test, open the acquisitions tab in system preferences and confirm that the UniqueItemFields description looks correct and links to the right page in the schema. Signed-off-by: Frederic Durand Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:04:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:04:30 +0000 Subject: [Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:04:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:04:32 +0000 Subject: [Koha-bugs] [Bug 8584] Improve cleanup_database.pl to only purge emails older than X days. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8584 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17396|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 18663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18663&action=edit cleanup_database.pl : Add a DAYS parameter for email purges. You can now specify a number of DAYS with the --mail parameter. Only mails older than DAYS days will be deleted. http://bugs.koha-community.org/show_bug.cgi?id=8584 Signed-off-by: Kyle M Hall Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:06:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:06:31 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:06:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:06:34 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18550|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 18664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18664&action=edit Bug 766 Remove CGI::scrolling_list from request.pl Let the template take care of generating the display. Lets at least part of request.pl be more succinct. To test, place a hold and search for the patron using a partial name. You should get a dropdown select list of patrons and be able to select the patron to hold for from there. The functionality should remain unimpaired after this patch is applied. Signed-off-by: Owen Leonard Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:08:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:08:44 +0000 Subject: [Koha-bugs] [Bug 10412] New: The ability to update Acquisitions with credit notes, with the option to link to an existing invoice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Bug ID: 10412 Summary: The ability to update Acquisitions with credit notes, with the option to link to an existing invoice Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amitddng135 at gmail.com The ability to update Acquisitions with credit notes, with the option to link to an existing invoice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:08:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:08:58 +0000 Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Amit changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:22:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:22:04 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:22:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:22:06 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18646|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 18665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18665&action=edit Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update ' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install ' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links Signed-off-by: Jared Camins-Esakov Strings are now translated, and no emergent JS errors have revealed themselves. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:25:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:25:53 +0000 Subject: [Koha-bugs] [Bug 10413] New: French staff po file is not translatable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 Bug ID: 10413 Summary: French staff po file is not translatable Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com CC: frederic at tamil.fr In 3.12 and master, I get an error on translate update fr-FR. It is caused by /misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po l.103798 (in 3.12): #: intranet-tmpl/prog/en/modules/help/members/moremember.tt:18 #, c-format msgid " " msgstr " " The error is (in french of course...): AVERTISSEMENT?: Il manque le jeu de caract?res dans l'en-t?te. La conversion vers le jeu de caract?res de l'utilisateur ne fonctionnera pas. fr-FR-i-staff-t-prog-v-3006000.po:103800: Double d?finition de message... fr-FR-i-staff-t-prog-v-3006000.po:21: ...voici l'endroit de la premi?re occurence msgmerge: 1 erreur fatale trouv?e It means a duplicate message definition errors line 103800 of the header. The po file is not regenerated! I will provide a patch, but maybe it is not the right place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:28:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:28:44 +0000 Subject: [Koha-bugs] [Bug 7892] on staged marc record management open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7892 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:28:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:28:46 +0000 Subject: [Koha-bugs] [Bug 7892] on staged marc record management open in tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7892 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17490|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 18666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18666&action=edit Bug 7892: Open link to imported record in new tab Change links to imported records to open in a new window/tab on the staged records management page. To test: 1) Go to Tools > Staged MARC record management 2) Open an imported batch by clicking on the file name 3) Click on bib# in the record column 4) Verify links open in a new window/tab now Signed-off-by: Nicole C. Engard All tests pass Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:29:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:29:12 +0000 Subject: [Koha-bugs] [Bug 10413] French staff po file is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 --- Comment #1 from Jonathan Druart --- Created attachment 18667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18667&action=edit Bug 10413: FIX translate update for french translation files For 3.12.x branch ./translate update fr-FR will raise an error without this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:30:48 +0000 Subject: [Koha-bugs] [Bug 10413] French staff po file is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 --- Comment #2 from Jonathan Druart --- Created attachment 18668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18668&action=edit Bug 10413: FIX translate update for french translation files For master branch ./translate update fr-FR will raise an error without this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 11:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 09:30:58 +0000 Subject: [Koha-bugs] [Bug 10413] French staff po file is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 12:04:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 10:04:26 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 --- Comment #14 from Fridolyn SOMERS --- Oups, we both worked on this bug. I revert my patch, I will add it in a new bug since it adds features. So I set PassedQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 12:05:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 10:05:13 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 12:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 10:05:35 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18656|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 12:06:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 10:06:38 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 12:06:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 10:06:49 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:01:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 11:01:40 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 --- Comment #15 from Bernardo Gonzalez Kriegel --- Hi, this is no more in current master, fixed by Bug 10176. I did test using Karam records, for me facets are working. Could someone else test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:16:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 11:16:44 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 --- Comment #16 from Tigran --- (In reply to comment #15) > Hi, > this is no more in current master, fixed by Bug 10176. > I did test using Karam records, for me facets are working. > Could someone else test? my Koha version is 3.12.00 and the problem exist. See the ? mark for Cyrillic and Armenian scripts. Tigran Cyrillic script Topics ??????????... ????????? ????????? ?... Armenian script Series ????????? ?... ??????????... ??????? ???... Authors ????? ?????????, ... ?????????, ... ???????, ??... ???????, ??... Show more Places ????? ?????... Topics ??????????... ??? ???????... ??? ???????... ???? ??????... ???? ??????... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:47:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 11:47:00 +0000 Subject: [Koha-bugs] [Bug 10413] French staff po file is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Fr?d?ric Demians --- .po files should be modified directly on http://translate.koha-community.org where there are pulled from the Translation Manager, and send to Release Manager for inclusion to Koha Git repository. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:49:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 11:49:52 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 --- Comment #17 from Bernardo Gonzalez Kriegel --- Hi Tigran, you can have two problems: wrong display and wrong links, 10176 fixes the link, not the display :-) To fix the display we need to rewrite how facets are trimmed, at this moment it use preference FacetLabelTruncationLength, that truncates facet text at that lenght, which is alright but only for scripts that use latin or not ligate chars. It needs to be rewritten so it cut facet text on " " (space) position <= FacetLabelTruncationLength. A workaround is set FacetLabelTruncationLength to a bigger value, 50 for example, then facets will not show those . The test I was talking about involves the links :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 13:56:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 11:56:06 +0000 Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747 --- Comment #15 from Fridolyn SOMERS --- Created attachment 18669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18669&action=edit Bug 9747 - sort issue for the z3950 results - Followup Finally I created a follow-up just to add the new sort in z3950 in acquisition module. Also adds default sorting on title column. This feature is really usefull I bet. Thanks all for your work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:18:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:18:31 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #45 from Fridolyn SOMERS --- Small problem : Second query in updatedatabase is not executed. This second query added by followup patch is not mandatory, so maybe correcting updatedatabase.pl is enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:21:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:21:00 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #46 from Fridolyn SOMERS --- Created attachment 18670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18670&action=edit Bug 6898 - updatedatabase second query not executed Patch to correct updatedatabase. I created it on the bug branch but it applies on a master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:21:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:21:29 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:25:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:25:10 +0000 Subject: [Koha-bugs] [Bug 10413] French staff po file is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10413 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #4 from Fridolyn SOMERS --- On http://translate.koha-community.org, I do not see the misgid="", I think it is hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:27:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:27:12 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #47 from M. de Rooy --- Fridolyn: Are you sure that this will really fix your problem? Just updating an older dbrev will not help someone that never comes back to that piece of code.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:44:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:44:59 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:45:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:45:01 +0000 Subject: [Koha-bugs] [Bug 10409] Do not show course entry form if no departments are found In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10409 --- Comment #1 from Owen Leonard --- Created attachment 18671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18671&action=edit Bug 10409 - Do not show course entry form if no departments are found The course reserves entry form should not be shown if there are no DEPARTMENT authorized values, since this prevents the form from being submitted. This patch replaces the form with an error message when no DEPARTMENT authorized values are found. Also corrected: - Corrected grid structure for more standard display - Converted labels with no corresponding inputs to - Closed unclosed tags - Corrected incorrect capitalization This patch contains whitespace changes, so please ignore whitespace when examining changes. To test, delete any DEPARTMENT authorized values, if present. Create a new course in Course Reserves. You should see a warning that no DEPARTMENT values were found. If you are logged in with the correct permission, the warning should contain a link to the correct authorized value page. If you do no, the warning should refer the problem to an administrator. After creating one or more DEPARTMENT values, the form should display and submit correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:47:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:47:39 +0000 Subject: [Koha-bugs] [Bug 10414] New: "Course Reserves" should be "Course reserves" in global "More" menu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414 Bug ID: 10414 Summary: "Course Reserves" should be "Course reserves" in global "More" menu Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org Koha coding guidelines as of 2012 (Bug 2780) state that only the first letter of titles, headings, buttons, etc. should be capitalized. "Course Reserves" in the global "More" menu is incorrect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:55:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:55:05 +0000 Subject: [Koha-bugs] [Bug 10414] "Course Reserves" should be "Course reserves" in global "More" menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:55:07 +0000 Subject: [Koha-bugs] [Bug 10414] "Course Reserves" should be "Course reserves" in global "More" menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10414 --- Comment #1 from Owen Leonard --- Created attachment 18672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18672&action=edit Bug 10414 - "Course Reserves" should be "Course reserves" in global "More" menu The global "More" menu lists "Course Reserves," which is incorrectly capitalized. This patch changes it to "Course reserves." To test, apply the patch and view any page in the staff client. When you click the "More" menu item the link should read "Course reserves." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 14:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 12:58:49 +0000 Subject: [Koha-bugs] [Bug 10415] New: Add course reserves to staff client home page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415 Bug ID: 10415 Summary: Add course reserves to staff client home page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org CC: gmcharlt at gmail.com If course reserves is an important enough module to list in the global "More" menu then it should follow that it is important enough to include on the staff client home page. The menu choices in the header menu (with the exception of "Cart" mirror the main module links on the staff client home page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:00:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:00:28 +0000 Subject: [Koha-bugs] [Bug 10415] Add course reserves to staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415 --- Comment #1 from Owen Leonard --- Some possible choices for a "course reserves" icon for the home page: http://thenounproject.com/noun/stack-of-books/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:07:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:07:19 +0000 Subject: [Koha-bugs] [Bug 6898] circulation librarians can't run overdues without reports permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6898 --- Comment #48 from Fridolyn SOMERS --- (In reply to comment #47) > Fridolyn: > Are you sure that this will really fix your problem? > Just updating an older dbrev will not help someone that never comes back to > that piece of code.. I know but this query adds the new permission to some borrowers. Now that this permission in not new, I think it whould be dangerous to add it to borrowers. This was only a way to ease the set of the new permission. For libraries that have already used updatedatabase, they will easily see for who the permission is missing and set it manually. Rather less permissions than to much no ? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:10:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:10:53 +0000 Subject: [Koha-bugs] [Bug 7718] Remove itemnumber column from serials table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #14 from M. de Rooy --- (In reply to comment #3) > Yes, serials:items is a 1:many relationship. It seems to me that the correct > solution here is not to populate serial.itemnumber, but rather to remove it > so that no one thinks that they should be using it. Jared: Could you tell me how I can create more than one item for one serial record? It just looks like a 1:1 relationship. Note that the table name serial is somewhat misleading. It actually is some kind of "subscription item". The relation between calling AddItem2Serial and NewIssue is not very clear in the current Koha code. If this is just 1:1, it would not have been a bad idea to remove the serialitems table? If it is not, I am even more interested.. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:11:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:11:59 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #83 from Pierre Angot --- Is it possible to push this patch to 3.10.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:06:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:06:08 +0000 Subject: [Koha-bugs] [Bug 10416] New: Correct template markup problems on course detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Bug ID: 10416 Summary: Correct template markup problems on course detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/course_reserves/course-details.pl?course _id=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org There are issues with validity and consistency on the course reserves course detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:27:23 +0000 Subject: [Koha-bugs] [Bug 10417] New: keep deleted authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10417 Bug ID: 10417 Summary: keep deleted authorities Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com CC: m.de.rooy at rijksmuseum.nl We keep deleted bibs and items, but not authorities. There should be a deleted authorities table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:28:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:28:17 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 --- Comment #27 from Jared Camins-Esakov --- I tested this script and found that it did not work at all with MARC21 because of the way it was retrieving authid. I am working on a counter-patch which I hope to upload tomorrow which incorporates the matching options from your script but should work properly with both UNIMARC and MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:35:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:35:13 +0000 Subject: [Koha-bugs] [Bug 10416] Correct template markup problems on course detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:35:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:35:15 +0000 Subject: [Koha-bugs] [Bug 10416] Correct template markup problems on course detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10416 --- Comment #1 from Owen Leonard --- Created attachment 18673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18673&action=edit Bug 10416 - Correct template markup problems on course detail page This patch corrects several problems with the course reserves course detail page: - Unescaped ampersands - Extra - Incorrect text in title tag - Use of a table to display information which is more consistently displayed as a list. - More accurate alert message, "Are you sure you want to remove this item from the course?" rather than "Are you sure you want to delete this item?" - Missing icons from toolbar buttons To test, apply the patch and view the details of an existing course (Course reserves -> [Course name]). Confirm that these changes are present and look like an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:36:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:36:34 +0000 Subject: [Koha-bugs] [Bug 10418] New: Correct template markup problems on course reserves add item page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 Bug ID: 10418 Summary: Correct template markup problems on course reserves add item page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/course_reserves/add_items.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org There are issues with validity and consistency on the course reserves add item page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:37:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:37:29 +0000 Subject: [Koha-bugs] [Bug 5636] clean borrowers run from command line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5636 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #14 from Jonathan Druart --- This patch add a script which allow to 1/ Anonymize patron history => Done in misc/cronjobs/batch_anonymise.pl (bug 6572) 2/ Delete patrons => I will open a new report for that *** This bug has been marked as a duplicate of bug 6572 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 15:37:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 13:37:29 +0000 Subject: [Koha-bugs] [Bug 6572] Need a script to allow cronning of patron history deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6572 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #4 from Jonathan Druart --- *** Bug 5636 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:03:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 14:03:40 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #1 from Kyle M Hall --- Created attachment 18674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18674&action=edit Bug 10382 - collection not returning to null when removed from course reserves Test Plan: 1) Create an item, do not set a collection code 2) Add the item to a course, and choose to set a collection code 3) Ensure the course is enabled, and the collection code is now visible 4) Disable the course, ensure the collection code is no longer visible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:03:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 14:03:38 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:05:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 14:05:28 +0000 Subject: [Koha-bugs] [Bug 10418] Correct template markup problems on course reserves add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 5 16:05:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Jun 2013 14:05:29 +0000 Subject: [Koha-bugs] [Bug 10418] Correct template markup problems on course reserves add item page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10418 --- Comment #1 from Owen Leonard --- Created attachment 18675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18675&action=edit Bug 10418 - Correct template markup problems on course reserves add item page This patch corrects several problems with the course reserves add item pages: - Non-standard grid markup. - Extra . - Incorrect styling of errors and messages. - Redundant JS for adding focus to a field (use "focus" class). - Invalid use of