[Koha-bugs] [Bug 9103] overdue_notices.pl should use AutoEmailPrimaryAddress syspref

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 7 15:07:10 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13511|0                           |1
        is obsolete|                            |

--- Comment #5 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 15931
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15931&action=edit
Proposed patch (revised)

Due to Bug 6835 integration in master, I've rewritten patch.

New patch renames as asked method GetPrimaryEmailAddress into
GetNoticeEmailAddress, meaning the email used to sent notices.

Bug 6835 added a GetMember() call to get emails. I changed to get them in the
existing query. A consequence is the use of fetchrow_hashref to have datas into
a hash. This is more useful and generally used to get query results. Also,
prepare_letter_for_printing was called twice where it can be once.

See test plan on comment 3.
Note that if --email option is used, it overrides notice email address.
I could uses some help on a more complex one and for unit test.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list