[Koha-bugs] [Bug 9842] SIP tests : fix for 07hold.t on Cancel Hold

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9842

--- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> ---
Created attachment 16380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16380&action=edit
proposed patch #1

Proposed patch : removes the ERRORS #2 and #3

Once these errors disappear, another one replaces them:
#   Failed test 'match leader Cancel Hold: no hold on specified item'
#   at /home/asaurat/workspace/versions/community/C4/SIP/t/SIPtest.pm line 204.
# Response '161N20130319    123020AA1X981|AB1783B|AJL ANGOISSE DU ROI
SALOMON|AOVIL|AFHold Cancelled.|AY8AZE623' doesn't match pattern
'(?-xism:^160N\d{8} {4}\d{6})'
The lack of efficient return value when calling CancelReserve is causing this.
I'd rather resolve this in another patch once this one has been validated.

TEST PLAN :
1) In "C4/SIP/t", configure the SIPtest.pm file.
2) Configure your SIPconfig.xml if needed.
3) Start your SIP server.
4) In "C4/SIP/t", do a "make test" (see the README file for more informations)
You can also run the 07hold.t only. Still, running everything can help to
ensure that your SIPtest.pm is well configured.

Before the patch, this plan should generate 3 errors for 7hold. After the patch
it will generate 2 errors.

-- 
You are receiving this mail because:
You are watching all bug changes.