[Koha-bugs] [Bug 9394] Use reserve_id where possible

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 29 23:31:30 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394

--- Comment #31 from Maxime Pelletier <pelletiermaxime at gmail.com> ---
(In reply to comment #29)
> Created attachment 18466 [details] [review]
> Bug 9394: QA Followup
> 
> * C4::Reserves::GetReserveId
> This subroutine did not have a unit test.

This new test fails for me. You pass an itemnumber to GetReserveId after an
AddReserve with no itemnumber, so GetReserveId returns the wrong of the 2
existing reserves at that point. We could either remove the "itemnumber =>
$itemnumber," line or add modify the AddReserve above it. What do you think ?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list