[Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Nov 17 16:41:56 CET 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078
M. Tompsett <mtompset at hotmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |mtompset at hotmail.com
--- Comment #25 from M. Tompsett <mtompset at hotmail.com> ---
mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master
HEAD is now at 73d4ac9 Merge branch 'new/bug11163'
mtompset at ubuntu:~/kohaclone$ git bz apply 6435
Bug 6435 - [ENH] Added daemon mode parameters to rebuild_zebra.pl
22859 - Bug 6435 Add daemon mode to rebuild_zebra.pl
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 6435 Add daemon mode to rebuild_zebra.pl
mtompset at ubuntu:~/kohaclone$ git bz apply 11078
Bug 11078 - rebuild_zebra.pl can lose updates due to race condition during full
rebuilds
22458 - Bug 11078 Add locking to rebuild_zebra to prevent race conditions
(revised 10/27)
22506 - Bug 11078 Add locking to rebuild_zebra (QA patch 10/28)
22508 - Bug 11078 Add locking to rebuild_zebra (QA Patch 2 10/28)
22532 - Bug 11078 Add locking to rebuild_zebra (QA Patch 3 10/29)
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11078 Add locking to rebuild_zebra to prevent race conditions.
Applying: Bug 11078 rebuild-zebra can lose updates, QA patch 1
Applying: Bug 11078 Add locking to rebuild_zebra (QA Patch 2 10/28)
Applying: Bug 11078 Add locking to rebuild_zebra (QA Patch 3 10/29)
mtompset at ubuntu:~/kohaclone$ ~/qa-test-tools/koha-qa.pl -v 2 -c 4
testing 4 commit(s) (applied to d8a974a 'Bug 6435 Add daemon mode to
rebuild_z')
FAIL misc/migration_tools/rebuild_zebra.pl
OK pod
FAIL forbidden patterns
forbidden pattern: tab char (line 182)
forbidden pattern: tab char (line 181)
forbidden pattern: tab char (line 183)
forbidden pattern: tab char (line 180)
OK valid
FAIL critic
# InputOutput::ProhibitBarewordFileHandles: Got 1 violation(s).
# InputOutput::ProhibitTwoArgOpen: Got 1 violation(s).
# ValuesAndExpressions::ProhibitLeadingZeros: Got 1
violation(s).
OK rewrite-config.PL
OK pod
OK forbidden patterns
OK valid
OK critic
OK etc/koha-conf.xml
OK xml_valid
Doug, could you clean up the problems?
Perl::Critic::Policy::InputOutput::ProhibitTwoArgOpen - Write open $fh, q{<},
$filename; instead of open $fh, "<$filename";.
Perl::Critic::Policy::InputOutput::ProhibitBarewordFileHandles - Write open my
$fh, q{<}, $filename; instead of open FH, q{<}, $filename;
Perl::Critic::Policy::ValuesAndExpressions::ProhibitLeadingZeros - Write
oct(755) instead of 0755.
I'm wondering if this a tightening up of the perlcritic stuff?
$ perlcritic --version
1.117
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list