From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:04:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:04:10 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-U4KLNqSSuV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21684
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21684&action=edit
[PATCH 3] Bug 7791 Followup: add warning after deletion if some records were
not deleted

Here is the followup.

This followup add some warnings after deletion if some items were not deleted.
4 types of messages are possible :
- x item(s) attached.
- x subscription(s) attached.
- x order(s) attached.
- Unknown error.

To test :
test a
1. create a basket with
- an order using a record A which has already an item, which is used in a
subscription, and in other order (in an other basket)
- an order using a record B used nowhere elese
2. click on "Delete basket"
3. choose button "Delete basket, orders and records"
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item, subscription and order.
5. check the link around the title of record B takes you to the record
6. check the link under the warning box ("Click here to go back to booksellers
page") takes you to booksellers page
5. check record B is deleted

test b
1. suppress the subscription linked with record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item and order

test c
1. suppress the item attached under record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its order

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:04:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:04:22 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-Oyoj4PHTaK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:04:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:04:35 +0000
Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable
In-Reply-To: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10925-70-3egrG7TRC2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:04:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:04:38 +0000
Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable
In-Reply-To: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10925-70-37fOhh0hAX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21545|0                           |1
        is obsolete|                            |

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 21685
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21685&action=edit
Bug 10925: LDAP auth fails if DEBUG is enable

To reproduce:
1/ Edit your apache virtual host and set the DEBUG environment variable
(SetEnv DEBUG 1).
2/ Try to login with an ldap user
3/ You will be redirected to the 500 error page.
The Koha logs contains:
malformed header from script. Bad header=------------------------------:
mainpage.pl

The hashdump routine directly punks to the STDOUT (!) and breaks the
headers.
It appears Net::LDAP::?->dump does the same thing.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

Maybe we can kill C4::Utils after getting rid of this

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:04:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:04:58 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-qPx1LFIaNo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Patch 1 and 2 were already signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:08:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:08:14 +0000
Subject: [Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users
In-Reply-To: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9375-70-BEzB2eQc8M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:24:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:24:14 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-RXyYb0P4BO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi Owen & Jonathan

I experienced the same bug during my tests.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 00:36:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 22:36:02 +0000
Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable
In-Reply-To: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10925-70-d7dO9kA3pk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

--- Comment #6 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Chris Cormack from comment #5)
> Maybe we can kill C4::Utils after getting rid of this

That's what 10927 does. I've signed it off. It is awaiting QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:15:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:15:03 +0000
Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error
In-Reply-To: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10843-70-BbNVEYLhnC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:15:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:15:07 +0000
Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error
In-Reply-To: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10843-70-LM3EQcGgCI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21651|0                           |1
        is obsolete|                            |

--- Comment #6 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 21686
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21686&action=edit
[SIGNED-OFF] Bug 10843: the DateTime->add method takes a scalar, not undef

Test plan:
1) set an empty string for the ReservesMaxPickUpDelay pref
2) place a hold on an item
3) check in the item
4) click on "Print and confirm"
5) an error occurs
> The 'days' parameter (undef) to DateTime::Duration::new was an 'undef'
6) apply the patch
7) repeat steps 1 to 4
8) the error does not occur anymore.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:21:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:21:07 +0000
Subject: [Koha-bugs] [Bug 10979] New: No undef checks in DateUtils
Message-ID: <bug-10979-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10979

            Bug ID: 10979
           Summary: No undef checks in DateUtils
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: srdjan at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

There are many places in Koha::DateUtils where values not undef tested before
matching (ie output_pref(), dt_from_string() etc). This causes unnecessary
processing and gives unsightly warnings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:22:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:22:24 +0000
Subject: [Koha-bugs] [Bug 10979] No undef checks in DateUtils
In-Reply-To: <bug-10979-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10979-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10979-70-KdCx0mh0PR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10979

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:24:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:24:34 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-8clr1p19z7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #11 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 21687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21687&action=edit
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC

This adds a new page to the OPAC that can search several Z39.50 targets
using Pazpar2.

Test plan:
1) Apply patches.
2) Update database.
3) Add one or more Z39.50 targets, using the Administration -> External
   targets screen. Note that not all targets support keyword search, but
   here are some that do:
     * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8
     * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8
4) Perform a search on the OPAC, check to see if the "external targets"
   notice pops up at the top.
5) Click on the results link near that message.
6) This should bring back results from all enabled targets, all of which
   should be clickable to bring up a detailed view of the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:24:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:24:55 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-nb3nM1mlMT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19226|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:25:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:25:01 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-llqVoCBwlR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19227|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:25:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:25:06 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-IrHYDNOVqk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19680|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:26:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:26:22 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-iRvRHpVkqi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #12 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Phew, new version, updated to apply on master and with a couple small bugfixes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:34:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:34:22 +0000
Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time
 in "from" argument
In-Reply-To: <bug-10824-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10824-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10824-70-3qaxJxXd6F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
(In reply to Srdjan Jankovic from comment #6)
> Not nitpicking or anything, just curious: why adding T...Z string just to
> strip it off? Wouldn't it be better to do something on the lines of
> 
> $arg = length($date_string) == 10
>   ? ($date_string .= " $time_string") # 00:00:00 or 23:59:59
>   : _strip_UTC_designators($date_string);

Fair question.

I'm adding T...Z string, because it's only stripped off half the time. 

If you read through the code, you'll see that "from" and "until" properties
retain the T and Z designators. It's only the "from_arg" and "until_arg"
properties that have them stripped off.

The reasoning here is that the "from" and "until" properties are used to
generate the actual resumption token, which requires the T and Z designators,
while the "from_arg" and "until_arg" have them stripped off for matching in
MySQL.

Does that make sense? We want the T and Z for the token, but no T and Z for the
database.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:39:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:39:54 +0000
Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
In-Reply-To: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10781-70-aZR2TlxaxC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 01:39:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 30 Sep 2013 23:39:56 +0000
Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
In-Reply-To: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10781-70-CzNtAIgDn8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20620|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 21688
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21688&action=edit
bug_10781: Removed ILSDI::Utility

Test:
This should be a noop. Regression testing required:
/cgi-bin/koha/ilsdi.pl functioanality, in particuler:
GetAvailability - ?service=Describe&verb=GetAvailability
AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron

ILS-DI syspref must be turned on

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 02:39:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 00:39:08 +0000
Subject: [Koha-bugs] [Bug 10980] New: purchase suggestion doesn't always show
Message-ID: <bug-10980-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10980

            Bug ID: 10980
           Summary: purchase suggestion doesn't always show
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I have noticed that the 'not finding what you're looking for make a purchase
suggestion' box doesn't appear consistently. I have to admit I don't have much
information on what could be causing this but I wanted to report the issue. 

What I've seen is that on all opacs I've tested the link shows at the bottom of
some searches and not others - and it shows on some 'no results found' pages
and not others.  This is all on one system - not that it works on some and not
others - that it's inconsistent within one system depending on what you search
for and where you search from.

This is with CCSR on Koha 3.12.4 and master in Firefox on Mac & Windows.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 04:41:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 02:41:04 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-2MkPulJnCt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #88 from Pierre Angot <tredok.pierre at gmail.com> ---
I can't test on sandbox, there is something wrong with them. I'm waiting for
Jonathan ^^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:31:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:31:13 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-UP7Z6R4dDr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #89 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:31:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:31:43 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-lrj1nWlkzA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20894|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:31:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:31:49 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-zKoPO4XkxJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20895|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:31:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:31:55 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-VZXc52Bx2p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20896|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:01 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-UDXNrVlpSN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20897|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:09 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-1ndnDiFYwk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20898|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:14 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-cJKeOy4Lro@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20899|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:22 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-IBEEpc2E1D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #90 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21689
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21689&action=edit
Bug 5336:Order search (search and UI enhancements)

You can now search orders by
- order status
- fund

New field aqorders.orderstatus, it can contains following values:
  0 => New
  1 => Ordered
  2 => Partial
  3 => Complete
  4 => Deleted

To test: Search and check if results are consistent in histsearch.pl
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:27 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-EBMdZJ4233@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #91 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21690
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21690&action=edit
Bug 5336: Late orders search: don't display deleted order.

Test plan:
Check that deleted orders are not listed in the late orders search
results.
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:31 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-SM4f59l7N7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #92 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21691
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21691&action=edit
Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by:
Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:35 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-uO7JplyEU3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #93 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21692
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21692&action=edit
Bug 5336: Add unit tests for 3 acq routines

Unit tests In C4::Acquisition for:
- CloseBasket
- ReopenBasket
- GetBiblioCountByBasketno
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:40 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-ZIbrRLhDpx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #94 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21693&action=edit
Bug 5336: QA followup

- fix capitalization
- fix update database message

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:32:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:32:44 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-wKRXT2uyY3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #95 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21694&action=edit
Bug 5336: Change numbers with understandable codes for orderstatus

This patch uses understandable codes instead of magical numbers for the
aqorders.orderstatus field.

+ execute sql queries in unit tests into a transaction.

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:33:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:33:56 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-9OSTPqdQ6H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #96 from Pierre Angot <tredok.pierre at gmail.com> ---
Well, it works on sandbox 3 ^^

Test plan :
- Add 2 orders, first with 3 items, second with 2
- Receive 2 of the first order
- cancel one order
- search order

Results :
- isbn : ok (isbn 10 and 13)
- author : ok
- title : ok, even if it is partial
- fund : ok
- basket : ok
- basketgroup : ok
- Bookseller invoice : ok, but label is not correct, it works with invoice
name, not number
- order status : ok for all

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 05:52:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 03:52:16 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-8IYsiSzveE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Pete <pgsengstock at wisc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pgsengstock at wisc.edu

--- Comment #5 from Pete <pgsengstock at wisc.edu> ---
Martin, have you made any headway on shib in 3.12?  We're also hoping to get
this running.  Thanks!

-Pete

(In reply to Martin Renvoize from comment #4)
> I'm interested in testing either/both of these patches, and have grabbed a
> copy of Matthias's code for a start and rebased it onto 3.12 (I don't think
> it would be too difficult to rebase onto master, but 3.12 was what I had to
> hand).
> 
> Could one of your put up a test plan please, including any apache steps
> you've undertaken?
> 
> Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 07:59:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 05:59:55 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-8xmY2M5tGG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #97 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Pierre, thanks :) What I am trying to do is check the update procedure - but
I am still stuck with receiving orders. I will try again tonight to see what's
going wrong in my installation. It puzzles me quite a bit! Have you tested with
AcqCreateItems "on order"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 08:05:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 06:05:11 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-TljBMWPx3q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #98 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21695&action=edit
my orders...

Maybe someone spots something I don't see?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 08:05:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 06:05:50 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-00cXQCENzW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #99 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21696&action=edit
... and no pending orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 09:18:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 07:18:35 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-lQ4DPbcyW8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #100 from Pierre Angot <tredok.pierre at gmail.com> ---
On sandboxes, AcqCreateItems is "placing an order". I haven't tested with
others :/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 09:30:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 07:30:54 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-Hzzc7YgKlf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #101 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Testing with that too - it's just I am missing all pending orders... until I
get that working I can't really continue to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 11:38:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 09:38:27 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-eS7er0yEL9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #102 from Pierre Angot <tredok.pierre at gmail.com> ---
I've made a test with AcqCreateItem on "Receive an order". Everything is
correct.

All my pending orders are there. No one is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 11:40:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 09:40:10 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-fYcOjA3R1c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #103 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I will investigate the code and the database tonight - another idea I have is
permissions - are you superlibrarian?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 12:40:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 10:40:25 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-BVfevIN58a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #104 from Pierre Angot <tredok.pierre at gmail.com> ---
Yes, I'm SuperLibriarian ^^

You can check on sandbox n?3 : http://pro.test3.biblibre.com/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 12:57:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 10:57:39 +0000
Subject: [Koha-bugs] [Bug 10981] New: changing focus when alert on check in
Message-ID: <bug-10981-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10981

            Bug ID: 10981
           Summary: changing focus when alert on check in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

I remember a patch for this a while ago - but can't find it and don't know if I
actually remember right.

When an alert appears in circulation the focus should not be on the checkin /
checkout box anymore. That way if you accidentally scan the next item you don't
lose the alert.  The focus shouldn't be on the button either because scanning
would end up "clicking" the button.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 13:08:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 11:08:06 +0000
Subject: [Koha-bugs] [Bug 10980] purchase suggestion doesn't always show
In-Reply-To: <bug-10980-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10980-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10980-70-V2abrkyzzW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10980

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
I found it! See here: http://screencast.com/t/akXrkZkuF

I think it has to do with the 'did you mean' interfering with the 'would you
like to make a suggestion' box.  If you don't have 'did you mean' enabled then
this still happens.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 13:15:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 11:15:19 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-XaG7mLiC0C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 13:18:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 11:18:40 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-nHm3BNgQdC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |3.12

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 13:26:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 11:26:06 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-mhqZORzS2O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #105 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx - but I really need to figure out what's wrong with my installation :) I am
never testing with superlibrarian, because our users don't get this permission
and I want to make sure it works right for them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:05:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:05:32 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-qOVe60MmpG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #106 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #105)
> Thx - but I really need to figure out what's wrong with my installation :) I
> am never testing with superlibrarian, because our users don't get this
> permission and I want to make sure it works right for them.

Katrin,
Sorry for the delay.
I think there is a bug on updating the orderstatus field.
I will try to submit a followup asap.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:09:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:09:28 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-IhOfMUQ7T3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #107 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21697
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21697&action=edit
Bug 5336: FIX: partial status was not correctly set

An order (o1) is considered as partially received if (at least) another
order (o2) has the o1.ordernumber == o2.parent_ordernumber and the
quantity received is < to the quantity (to receive).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:10:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:10:39 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-vouZB2vSSC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #108 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Katrin,
I let you switch to needs signoff if you think it is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:11:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:11:02 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-6Si4OnJPZG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #109 from Pierre Angot <tredok.pierre at gmail.com> ---
Do you have check permission order_manage and order_receive ? Here, I give the
2 permissions.

I think I've maybe missed something. Did this patch do a modification in
receive shipment ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:21:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:21:04 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-2i0X1fxfQ2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #28)
> Worked! :)
> 
> Last question:
> On a dev install, koha-tmpl is accesible from oapc and staff,
> but on a packages/tar install DocumentRoot for opac and staff
> do not overlap.
> 
> opac  -> DocumentRoot /usr/share/koha/opac/htdocs
> staff -> DocumentRoot /usr/share/koha/intranet/htdocs
> 
> I solved this doing a symlink of discharges dir to both htdocs
> but this must be stated on instructions

I think this feature should be installed/configured by a sysadmin.
Paths have to be adapted depending each installation/preference.

> Do you plan some followup to remove these files?

No, currently I don't have followups for this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:38:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:38:55 +0000
Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality
In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7736-70-V5s1Q59w1W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |paola.rossi at cineca.it

--- Comment #84 from Paola Rossi <paola.rossi at cineca.it> ---
The field san in vendor_edi_accounts table is varchar(10).
In the template, field "Vendor SAN" is longer.
In the documentation the length of SAN/EAN is 13.
So I don't signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:54:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:54:54 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-ypzkIFd5uK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Owen Leonard from comment #19)
> I haven't run across the "Bad request" error again, but I did find this:
> 
> 1. Perform a search
> 2. Click a library facet
> 3. Cancel the library facet
> 4. Click another library facet
> 
> At this point there is no "[x]" by the facet I clicked in step 4. Same
> results in the OPAC and staff client.

I cannot reproduced, tested in the OPAC and staff.
The link appears and works.
What is the url generated in step 4?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 14:58:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 12:58:43 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-tNAJuSXn6q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #110 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Pierre, I am sorry - I think I confused you. I can't receive anything in my
normal installation without these patches. It's hard to test anything in acq
when you have such a problem. I will figure it out, don't worry. This patch is
not applied yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 15:01:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 13:01:04 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-cOjVjGWcqI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #111 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, thx for the follow-up - I remember from reading the code I had a
feeling there might be a problem for the partial receives. Give me a chance to
fix my installation and I will continue testing this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 15:17:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 13:17:22 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-lvEb7QIUE0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
1. Keyword search from the main search bar: 
   /cgi-bin/koha/opac-search.pl?idx=&q=blue

2. Click library facet:
  
/cgi-bin/koha/opac-search.pl?q=blue%2520%2523relevance_dsc&sort_by=relevance_dsc&limit=branch:APL

3. Cancel library facet:
  
/cgi-bin/koha/opac-search.pl?idx=kw&q=blue%2520&limit=branch:APL&sort_by=relevance_dsc&nolimit=branch:APL

4. Click another library facet: 
  
/cgi-bin/koha/opac-search.pl?q=kw%253Ablue%2520%2523relevance_dsc&sort_by=relevance_dsc&limit=branch:NPL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 15:23:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 13:23:06 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-SeODpT8eg6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 15:27:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 13:27:19 +0000
Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to
 items being receipted, to be identified during the receipting process.
In-Reply-To: <bug-10440-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10440-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10440-70-S3Y3qAmQT2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
I thought it was already the case!
I will test, as it seems to be an interesting enh.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 15:31:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 13:31:08 +0000
Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the
	itemtype code
In-Reply-To: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10090-70-qjGlHvtdmQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
What do you mean by itemtypes, the items types defined at item level (useless
for my library), or at biblio level?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 16:29:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 14:29:42 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-HobR1d0R3g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

--- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21698
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21698&action=edit
Bug 6113 [ENH] - enhancement to keep previous ids

Created the test cases.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 16:30:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 14:30:54 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-Nh27OSJwxl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21698|0                           |1
        is obsolete|                            |

--- Comment #16 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21699
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21699&action=edit
Bug 6113 [ENH] - enhancement to keep previous ids

Created the test cases.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 16:33:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 14:33:05 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-WRxclSK1JW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21699|0                           |1
        is obsolete|                            |

--- Comment #17 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21700
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21700&action=edit
Bug 6113 [ENH] - enhancement to keep previous ids

Forgot the extra warnings in C4::Biblio.
Removed double warnings.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 16:33:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 14:33:26 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-hOivwVzXOO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21700|0                           |1
        is obsolete|                            |

--- Comment #18 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21701
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21701&action=edit
Bug 6113 [ENH] - enhancement to keep previous ids

Fixed warning messages.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 16:33:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 14:33:48 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-EN1nndvlcB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21701|0                           |1
        is obsolete|                            |

--- Comment #19 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21702
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21702&action=edit
Bug 6113 [ENH] - enhancement to keep previous ids

Modified the C4::Biblio::_koha_add_biblioitem() && _koha_add_biblio() to
support INSERTing biblionumbers and biblioitemnumbers to the DB. Also
validating that id's are positive integers and well below the critical Perl
LONG_MAX limit so we don't get buffer overflow. Duplicate id INSERTion will
fail, but in normal use scenarios this is not an issue, if "Koha to MARC
mapping" has biblionumber and biblioitemnumber mapped under field 999.
MySQL takes care of the primary key sequence refreshing.

Updated the bulkmarcimport.pl -script to copy the desired legacy id MARC field
to the field designated in "Koha to MARC mapping" -> biblionumber &&
biblioitemnumber.
This is handy if you have the legacy id in just 001 and need to populate 999c
and 999d to push them to DB. No need to make an extra modification run to
source bibliographic records just to facilitate Koha migration better.
Documented the new functionality in bulkmarcimport.pl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 17:34:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 15:34:00 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-4RfSklfG4M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21702|0                           |1
        is obsolete|                            |

--- Comment #20 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21703
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21703&action=edit
Bug 6113 [ENH] - enhancement to keep previous ids

Modified the C4::Biblio::_koha_add_biblioitem() && _koha_add_biblio() to
support INSERTing biblionumbers and biblioitemnumbers to
the Koha DB. Created validators to make sure the primary keys are positive
integers and well below the Perl's LONG_MAX threshold
to keep Koha from getting crazy. Duplicate id's are the users responsibility
and in normal use conditions they are non-existing,
unless the "Koha to MARC mapping" to biblionumber is a user-modifiable MARC
field, which is TROUBLE!
MySQL takes care of the primary key sequence refreshing.

Updated the bulkmarcimport.pl -script to copy the desired legacy id MARC field
to the biblionumber- and biblioitemnumber-fields
designated in "Koha to MARC mapping", eg. copy field 001 to 999c and 999d.
This is handy if you have the legacy id in just 001 and need to populate 999c
and 999d to push them to DB.
No need to make an extension to the existing migration scripts.

Documented the new functionality in bulkmarcimport.pl

Created test cases for C4::Biblio.pm modifications.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 17:37:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 15:37:52 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-3ACEfXlKls@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
       Hours Worked|                            |12.00
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 17:43:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 15:43:31 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-XLOBsLgmoD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored-by: Joensuu Regional Library

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 18:04:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 16:04:56 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-pVfbwoVwN1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Owen Leonard from comment #22)
> 1. Keyword search from the main search bar: 
>    /cgi-bin/koha/opac-search.pl?idx=&q=blue
> 
> 2. Click library facet:
>   
> /cgi-bin/koha/opac-search.
> pl?q=blue%2520%2523relevance_dsc&sort_by=relevance_dsc&limit=branch:APL
> 
> 3. Cancel library facet:
>   
> /cgi-bin/koha/opac-search.pl?idx=kw&q=blue%2520&limit=branch:
> APL&sort_by=relevance_dsc&nolimit=branch:APL
> 
> 4. Click another library facet: 
>   
> /cgi-bin/koha/opac-search.
> pl?q=kw%253Ablue%2520%2523relevance_dsc&sort_by=relevance_dsc&limit=branch:
> NPL

Here I get:
1/ opac-search.pl?q=d
2/ opac-search.pl?idx=kw&q=d&sort_by=author_asc&limit=branch:CPL
3/
opac-search.pl?idx=kw&q=d&limit=branch:CPL&sort_by=author_asc&nolimit=branch:CPL
4/ opac-search.pl?idx=kw&q=d&sort_by=author_asc&limit=branch:MPL

I don't understand why between your 3 and 4 the idx=kw&q=blue become kw:blue.
But in all cases, a facet is considered as active if a limit param is
index:value.
Since it works with the first query, it is really odd that it does not work
with the second one.

Mathieu, did you reproduce on a sandbox?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 18:41:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 16:41:20 +0000
Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present
 shows wrong (XSLT)
In-Reply-To: <bug-10957-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10957-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10957-70-9fx8sPF5V2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 18:58:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 16:58:40 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-agkVsleCvd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #112 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I used git bisect to locate the problem:
04b4afbd92ab952671e5ea6124e9e95da4a05874 is the first bad commit
Bug 9130 follow up: add statesave cookie and "all" option for parcel drop-down
menu

After deleting all cookies, the pending orders show again. So maybe a broken
cookie caused the problem? Can continue testing now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:35:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:35:37 +0000
Subject: [Koha-bugs] [Bug 10399] rebuild_zebra.pl should reset the indexes
 with -r even if zebraqueue empty
In-Reply-To: <bug-10399-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10399-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10399-70-mAPPCwFWT0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10399

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:39:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:39:36 +0000
Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 -
	DB update
In-Reply-To: <bug-10970-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10970-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10970-70-bJUKgSm9Qd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:39:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:39:59 +0000
Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb
	setup
In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8773-70-i9ID6ovEHA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:40:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:40:08 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-o1URIItm1t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:40:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:40:27 +0000
Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb
	setup
In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8773-70-U4ml0rnAOC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19805|0                           |1
        is obsolete|                            |

--- Comment #37 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 21704
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21704&action=edit
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
using a new(ly introduced) /etc/default/koha-common config file that
can be used for other stuff too, and is the Debian way of handling
init scripts control variables[1].

Also provide command line tools to manage the running indexer daemons
for your instances.

Long:

Using an indexing daemon avoids launching a new interpreter each time
the cron triggers the indexing, and also allows sub-minute incremental
reindexing, a requirement from our librarians.[2]

Using the indexer daemon should remain "experimental" so is disabled by
default. To enable the use of the indexer the user has to tweak the
/etc/default/koha-common config file (introduced by this patch). Specifically
the USE_INDEXER_DAEMON variable, which is clearly explained in the file.

Update frecquency defaults to 30 sec, and can be changed by tweaking the
/etc/default/koha-common config file too.

This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3],
but could be easily adjusted to use another if we got a new one (SolR?).
As Robin proposed it checks for availability of the relevant files before
trying to spawn the daemon.

If there's something I could change to make this patches better just let me
know.

Note: there was a problem Robin found regarding the spawned processes
forgetting
the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version
with the inclusion of the 'export' keyword for the relevant variables.

Edit: fixed koha-create to call the koha-indexer script instead, and added
-q to make koha-inxeder quiet (useful for the init script).

Regards
To+

[1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html
[2] This is the .deb version of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519
[3] The default cronjob that is set using the debian/koha-common.cron.d file
is being disbaled by this patch to avoid collision.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:40:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:40:38 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-FZb6DwLaXb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:41:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:41:51 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-Drd17JoEz6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #34 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:42:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:42:35 +0000
Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions:
 force_checkout and lift_restriction
In-Reply-To: <bug-10863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10863-70-neHWHAaU3d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #26 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:43:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:43:12 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-ChmsplOqtE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #16 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:43:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:43:45 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-qVuS428bfg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #13 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:44:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:44:14 +0000
Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
In-Reply-To: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10781-70-mPJEmDuU86@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #4 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 20:44:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 18:44:49 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-xNFk4jJcqt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #23 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 21:47:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 19:47:23 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-XPlc3a5HCk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #113 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

I am pretty impressed with this :) 

But there are some issues, that need fixing:

1) Database update - I end up with too many partials. My test cases:

 - New orders, basket still open
   NOT OK Expected: new, Result: partial
 - Ordered orders, basket and basketgroup closed
   NOT OK Expected: ordered, Result: partial 
 - Partially received orders
   OK Expected: partial/complete, Result: partial/complete
 - Received orders
   OK: Expected: complete, Result: complete
 - Cancelled orders
   * cancelled from open basket before order
   OK: Expected: cancelled, Result: cancelled
   * cancelled from closed basket before receive
   OK: Expected: cancelled, Result: cancelled

I have saved my 'pre-updatedatabase' and can repeat the test anytime you have a
follow up.

2) Testing search functionality

  a) Order search - result list
  Order search shows a new column, I think it would be a bit better if the
  status there was singular instead of plural - new order, partially received
  order etc. - maybe we could even leave out the 'order'? (minor)

  The column seems a bit lost in the middle, not sure where it would make more
  sense (just saying)

  b) Order search - advanced search form
  The advanced search form now shows a new filter: Order status
  All new status can be searched.
  - an "empty" search will find all but cancelled orders
  - searching for cancelled orders works correctly and shows results
  Search works correctly, no regressions found.

  When a search gives no results, there is no message. Also, all filters and
  fields are cleared so you can't modify or check you previous search
  (minor)

3) Testing setting of status after applying the patch

   a) Create a new order with 2 items - status is new. OK
   b) Close the basket - status is ordered. OK
   c) Receive both items - status is completed. OK
   d) Undo receipt - status is ordered. OK
   e) Receive only 1 item - order is split up into 2 orders:
       - status is partial OK
       - status is completed OK
   f) Undo receipt of received item - order is combined into 1 again
       - status is ordered OK!
   g) Receive only 1 item again - status ordered/partial.
   h) Delete order.
       - status is completed
       - status is cancelled
      OK!
   i) Undo receipt of 1 item again.
      Refresh page. Error message is shown:

Cannot cancel receipt. Possible reasons :
    The order line you trying to cancel was created from a partial receipt of
another order line which is already received. Try to cancel this one first and
retry.
    The order line you trying to cancel was created from a partial receipt of
another order line which has been deleted. Cancellation is not possible.

BUT: The receipt is undon, you are left with an order
     line with 2 items, a cancellation date and the status ordered.

Because of the cancellation date the order is not visible in pending orders.

Summary: The database update is not quite right yet and there is an edge case
where you are left with the wrong status. Also singulars in the orders search
result page would be nice.

Hope you can take another look - I like this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 22:58:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 20:58:12 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-XpZ8mlSbpy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #10 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 22:58:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 20:58:26 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-SKedWLcMF1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21365|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 22:58:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 20:58:32 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-7f55DnJ1M1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

--- Comment #11 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21705
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21705&action=edit
Bug 5645: improve converting simple search to Z39.50 search

This patch builds on the patch for bug 10742 by ensuring
that when a search initiated from the staff interface simple
search returns results, if you click on the Z39.50 search
button, the search form is populated with the search string
without "kw,wrdl".

To test:

[1] Perform a search in the staff interface that will return
    results.
[2] Click the Z39.50 search button.
[3] Observe that the search string appears in the title
    field in the Z39.50 search form, but with a prefix of
    "kw,wrdl".
[4] Apply the patch.
[5] Repeat steps 1-2.  This time, the search string appears
    without the index prefix.  This will make the Z39.50 search
    much more likely to work.
[6] Repeat steps 1-2, but with a search that does *not* return
    any hits in the Koha database.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  1 23:01:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 21:01:21 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-mu1Wiqzb2q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 00:30:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 01 Oct 2013 22:30:40 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-z30RJFfUcs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I have just seen that Jonathan Druart has made an other choice (COALESCE
biblio.title, deletedbiblio.title) for the same purpose in his bug for
improving order search (bug 5336, attachment 21689).
I am not a database expert, so could somebody check the code and tell me if my
solution (UNION ALL...) is good?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 02:59:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 00:59:33 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
 'status' option switch
In-Reply-To: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10624-70-1FfLD6CYrY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624

--- Comment #7 from Robin Sheat <robin at catalyst.net.nz> ---
$ sudo ./koha-common.init status
Zebra server running for instace test:.
SIP server running for instace test:.
$ sudo kill  2170 2171 2179
$ sudo ./koha-common.init status
Zebra server running for instace test:.
SIP server running for instace test: failed!

looks good. One note is that if you forget to use sudo, the error message is
pretty obscure. We should probably fail cleaner. But that's not the fault of
this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 03:01:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 01:01:16 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
 'status' option switch
In-Reply-To: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10624-70-M2e49n0MZp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 03:01:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 01:01:19 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
 'status' option switch
In-Reply-To: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10624-70-2EVEAqIdNy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21513|0                           |1
        is obsolete|                            |

--- Comment #8 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21706
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21706&action=edit
Bug 10624: 'status' option switch for the packages init script

This patch makes the init script return the status of the relevant processes.
It relies on the koha-list switches added by 10622, and is written on top of
the patch from 10617 that cleaned the init script.

To test:
- Apply the patch (+ 10622 so the SIP part works), build package and install
- Run
 $ service koha-common status

Note: it can be tested just copying the debian/koha-common.init script to a
server running koha-common instances and calling it
 $ ./koha-common.init status

If you don't have a patched koha-list command it will fail to report SIP
servers status.

Regards
To+

Edit: added the PID parameter to daemon as it failed to check SIP servers were
running otherwise.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Robin Sheat <robin at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 03:10:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 01:10:12 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
 'status' option switch
In-Reply-To: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10624-70-aVPXfYjduE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 03:30:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 01:30:35 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in opac results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-nXxrTsDIle@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 07:34:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 05:34:52 +0000
Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN
	and ISSN
In-Reply-To: <bug-5377-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5377-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5377-70-CaT6cNwkoK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 07:36:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 05:36:52 +0000
Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21)
	(GRS1+DOM)
In-Reply-To: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9972-70-Nf2Nr8Fz42@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 08:12:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 06:12:53 +0000
Subject: [Koha-bugs] [Bug 3206] OAI repositry deleted record support
In-Reply-To: <bug-3206-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3206-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3206-70-y8BYziWxR6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206

--- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> ---
> Something to check into would be how biblios are deleted when a batch
> import is reverted...we'll need to make sure that the bibs are logged
> in the deletedbiblio table and not just nuked.

Yes, there may be some intricacies here, and some new added by OAI Sets.
What will happen if a SET definition is modified in Koha? As it is,
harvesters must be notified to re-harvest Koha repository from scratch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 09:03:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 07:03:13 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-zzxjSKJ2wH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(I suppose Jonathan's code is better)
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 09:21:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 07:21:50 +0000
Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the
	itemtype code
In-Reply-To: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10090-70-PX8mb0l0Cm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #6)
> Hi
> What do you mean by itemtypes, the items types defined at item level
> (useless for my library), or at biblio level?

It is hardcoded, it is items.itype.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 09:21:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 07:21:58 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-tTdnEyopxi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #24 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---

> 
> Mathieu, did you reproduce on a sandbox?

Hi
I tried this morning, but 
- Sandbox 1 did not set up
- Sandbox 8 (Marc21) did set up, but 0 results to any search on staff interface
and opac (maybe zebra not running?)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 09:26:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 07:26:21 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-eawE0Gl3Qz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
I did not test yet, but I noticed some months ago that invoices seem to use
ecost, while they should use the real unit cost (MT11242).
Could you say me if this bug is also changing this behavior?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 09:42:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 07:42:00 +0000
Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the
	itemtype code
In-Reply-To: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10090-70-uZIrFJdiwr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090

--- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Well, I will take a look, but adding biblioitems.itemtype some day could be
nice too (by the way, the name of this field is sometime confusing...)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 09:58:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 07:58:47 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-4WKpTihsLb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hi Pete,

You have good timing, I've made lots of headway and am hoping to submit the
patches soon.

I've based my work mostly upon the work done by Matthias linked to above, with
a few additions inspired by Tom's work.

The biggest barrier to entry on this is understanding how shibboleth all fits
together and how to test it so I'm currently writing a test plan with such
instructions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:02:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:02:07 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-uMiTDGVIJB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21697|0                           |1
        is obsolete|                            |

--- Comment #114 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21707
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21707&action=edit
Bug 5336: FIX: partial status was not correctly set

An order (o1) is considered as partially received if (at least) another
order (o2) has the o1.ordernumber == o2.parent_ordernumber and the
quantity received is < to the quantity (to receive) and o1.ordernumber
!= o1.parent_ordernumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:02:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:02:15 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-yzkNTJTufR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #115 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21708
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21708&action=edit
Bug 5336: Multiple QA fixes

- add a message if the search returns no result
- keep selected values if the search returns no result (for fund and
  order status)
- remove plurals in order status
- move the order status column in the search results table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:06:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:06:27 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-oVnWnyEw1a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #116 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #113)
> Hi Jonathan,

Hi Katrin, Thanks for this great feedback :)

> 1) Database update - I end up with too many partials. My test cases:

Yep, The previous followup introduces some issues on updating status. I think
this one is good.

> 2) Testing search functionality
> 
>   a) Order search - result list
>   Order search shows a new column, I think it would be a bit better if the
>   status there was singular instead of plural - new order, partially received
>   order etc. - maybe we could even leave out the 'order'? (minor)

Fixed.

> 
>   The column seems a bit lost in the middle, not sure where it would make
> more
>   sense (just saying)

Fixed, moved to the beginning of the table.

>   When a search gives no results, there is no message. Also, all filters and
>   fields are cleared so you can't modify or check you previous search
>   (minor)

Fixed. The issue only existed for fund and order status.

>    i) Undo receipt of 1 item again.
>       Refresh page. Error message is shown:
>       
> Cannot cancel receipt. Possible reasons :
>     The order line you trying to cancel was created from a partial receipt
> of another order line which is already received. Try to cancel this one
> first and retry.
>     The order line you trying to cancel was created from a partial receipt
> of another order line which has been deleted. Cancellation is not possible.
> 
> BUT: The receipt is undon, you are left with an order
>      line with 2 items, a cancellation date and the status ordered.
> 
> Because of the cancellation date the order is not visible in pending orders.

I reproduce the issue with the master branch. It is not from these patches.
Could you confirm that?

I will try to have a look and propose a followup on another report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:10:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:10:25 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-pKLmMnG34J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #3)
> Hi
> I did not test yet, but I noticed some months ago that invoices seem to use
> ecost, while they should use the real unit cost (MT11242).
> Could you say me if this bug is also changing this behavior?

I don't remember.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:16:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:16:04 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-JOLNz1f8Fu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #117 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can't test before tonight - so if you could confirm it's also on master I
would be ok with that. Could you go ahead and file the new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:20:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:20:32 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-SQOnMdgo6U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Well, I will test and describe what I see.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:47:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:47:16 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-5dM375gl3g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I made 2 tests. 
I think some points need to be fixed, or maybe I am not well understanding the
price management in Koha


first test with "yes" (list price) and "yes" (invoiced price) for the 2 prefs
of the vendor.

10 euros
discount 10%
tax rate : 5,5%

on receipt page:
- ecost : 9 euros
- actual price : 9 euros

on invoice, before clicking on "finish receiving" :
- ecost : 9 euros
- actual price : 9 euros
- total tax inc : 9 euros
=> OK

on invoice, after clicking on "finish receiving" :
- est. : 9 euros
- total tax inc : 9.48 euros
=> KO

================
2d test with "yes" and "no" for the 2 prefs of the vendor.

10 euros
discount 10%
tax rate : 5,5%

on receipt page:
- ecost : 9,48 euros
- actual price : 8.53 euros
=> KO. Ecost should be 9 euros. Probably not linked with your patch.

on invoice, before clicking on "finish receiving" :
- ecost : 8.53 euros
- actual price : 8.53 euros
- Total tax inc. : 9.00    euros
=> KO. Why adding the tax on the "Total tax inc."? We don't pay tax for this
vendor.

on invoice, after clicking on "finish receiving" :
- est. : 9 euros
- total tax inc : 9.48 euros
=> KO

=> Failed QA : 
* for "yes" and "no" (2d test) : the "total tax inc." amount should be 8.53,
because we don't add tax for this vendor (if I understand well price
management)

* after the reception is finished, the table for "invoice details"
- does not give me the actual price
- still add tax even when it is not needed



I note an other bug, probably in master : 
with "yes" / "no" preference (list price includes tax and invoiced does not
include tax), the Replacement price on receipt page is bad (9.48 euros, while
it should be 9 euros)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:48:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:48:32 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-BiKSEt22Hd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
AHHH
Sorry
In fact your patch did not apply well on my VM!
So I tested the current master ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:48:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:48:41 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-edCqJ2HZMO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:51:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:51:42 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-fC7ElNjocE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21708|0                           |1
        is obsolete|                            |

--- Comment #118 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21709
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21709&action=edit
Bug 5336: Multiple QA fixes

- add a message if the search returns no result
- keep selected values if the search returns no result (for fund and
  order status)
- remove plurals in order status
- move the order status column in the search results table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:52:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:52:11 +0000
Subject: [Koha-bugs] [Bug 10982] New: Link to IFLA UNIMARC documentation in
	Cataloging
Message-ID: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

            Bug ID: 10982
           Summary: Link to IFLA UNIMARC documentation in Cataloging
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: frederic at tamil.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In Cataloging, a ? documentation page on IFLA web site. The current
implementation rely on the tag tab to select the appropriate IFLA
documentation web page. It doesn't work when UNIMARC tag are displayed
in a tab which digit is different for tag first digit.

To reproduce the bug:

  - Modify default framework, put all 200 subfields in tab 1
  - Add a new biblio record
  - Click on ? on 200 field
    => Wrong IFLA page is opened

Apply the patch and retry...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 10:54:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 08:54:21 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-pEMeOIeOIf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |frederic at tamil.fr

--- Comment #1 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 21710
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21710&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:01:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:01:26 +0000
Subject: [Koha-bugs] [Bug 10983] New: Unused subroutines in C4:Budgets
Message-ID: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983

            Bug ID: 10983
           Summary: Unused subroutines in C4:Budgets
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

C4::Budgets contains two private subroutines _columns and _filter_fields.
_filter_fields is not called anywhere else and _columns is only used by
_filter_fields. They should be removed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:04:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:04:10 +0000
Subject: [Koha-bugs] [Bug 10984] New: Cannot cancel received order if the
 parent order is deleted
Message-ID: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984

            Bug ID: 10984
           Summary: Cannot cancel received order if the parent order is
                    deleted
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- create an order with 2 items
- close the basket
- receive 1 item
- delete the order (with the remaining item)
- cancel the receipt
- nothing append
- cancel the receipt again
- an error occurred: "Cannot cancel receipt. Possible reasons : ..."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:04:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:04:33 +0000
Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent
 order is deleted
In-Reply-To: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10984-70-Ve1ZnWfD1j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:06:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:06:02 +0000
Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets
In-Reply-To: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10983-70-y7KgW5f4RX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 21711
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21711&action=edit
Proposed patch

No change to functionality - merely removes unused code

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:35:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:35:23 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-QSC4ULVbiA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:35:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:35:50 +0000
Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets
In-Reply-To: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10983-70-S9jXJnP7Nz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-02
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:43:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:43:16 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-r3N8gADjrX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #12 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #11)
> I am sorry, but this doesn't work for me. 
> 
What versions of yaz and zebra are you using? also what is the output of
icu-config --version ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:46:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:46:16 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-hJHOgE9jLe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Colin, I can't check before tonight, but maybe this might give you an idea -
I have installed all dependencies using the koha-common packages under Ubuntu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 11:51:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 09:51:39 +0000
Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent
 order is deleted
In-Reply-To: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10984-70-ml8lQAaAjb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Katrin,

I don't know how to fix this issue.

I see 2 ways:

1/ Don't allow to delete order with children (but there will be no way to
remove remaining items to receive)

2/ When an order is deleted and there are already received children, the
parent_ordernumber for children become the ordernumber from the first order
received (and we lost the link to the original order parent).
Example:
- O1 is pending with 3 items.
- receive 1 item: O2 is created (1 item received) and the parent_ordernumber is
O1.
- receive 1 item: O3 is created (1 item received) and the parent_ordernumber is
O1.
- now we have 01 (1 item to receive), O2 (1 item received) linked to O1, O3 (1
item received).
- cancel O1: O2 become the parent for O2 and O3 (we don't have the link to O1
anymore).
Restriction: we cannot cancel the receipt for O3 (we should cancel the receipt
for O2 before).

Do you see a third way?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 12:25:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 10:25:26 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-NIczEqhmm7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #24)

> - Sandbox 1 did not set up

The sandbox is now available. I blocked it for tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 12:36:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 10:36:51 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-hCw1l8azNG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Yeah, I am curious about this bug as well. Tho we would like to extend this to
cover placing holds as well. Well I already wrote the code for that as a proof
of concept for our librarians. I there some way I can contribute to this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 12:41:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 10:41:29 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-9mcRb1R9Jw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|paul.poulain at biblibre.com   |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
Jonathan, if you can have a look to this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 12:42:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 10:42:05 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-hd65MJlpju@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(my previous test was made on master, and I made a confusion between receipt
page and invoiced page, so forget it)

I tested with your patch
for all test, a basket with 1 book
- list price (the one I entered) : 10 eur
- tax : vat = 5,5%
- discount = 10%

I have made a complete acq workflow and found some weird things. Most of all
are are not related with your patch. Only the 4th step of each test (invoice
page) is directly related with it.
I made 4 full tests for all the possible vendor setting. 

My conclusion is : the more I test, the less I understand price management in
Koha, and the documentation about it is too poor, so I cannot be sure, but I
think your patch was not working well for test 1,2,3.
I also think there are some other bugs in baskets and receipt pages on current
master.

So all that I can do is Fail QA for the moment.

If I misunderstood price management, please correct me. If there are bugs to be
fixed in basket and receipt page, I would like to know it (And I would also
DREAM of a page on the wiki or on Koha documentation that explain precisely
what Koha is supposed to do with prices and taxes..., or maybe a kind of UT for
prices, but I don't know how it could be possible)

Mathieu

test 1 : 
vendor no (list price) / no (invoiced price).  The list price entered by the
librarian does NOT include tax, and the library does NOT pay tax

basket :
- RRP tax exc. : 10
- RRP tax inc. : 10.55
- ecost price tax exc. : 9
- ecost price tax inc. : 9.49
=> maybe KO, but out of the scope of this bug : if the library does not pay
tax, the total ecost price tax inc. should probably be the same as the total
price tax exc. Or the column "ecost tax inc." should be hidden if it means
nothing in this configuration.

receipt page :
- replacement : 10
- budgeted : 9
- actual cost : 9
=> maybe KO, but out of the scope (I suppose replacement price should be tax
included in remplacement cost)

receipt page (after reception, table "already received") :
- est cost : 9
- actual cost : 9
- total : 9
- Total tax inc. : 9.49
=> KO for "Total tax inc. : 9.49", Should be "9", but out of the scope of this
bug

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> KO : we don't pay tax for this vendor, so actual cost tax incl should be "9"

=========
test 2:
vendor yes  (list price) / yes  (invoiced price).  The list price entered by
the librarian does include tax, and the library does pay tax

basket :
- RRP tax exc. : 9.48
- RRP tax inc. : 10
- total price tax exc. : 8.53
- total price tax inc. : 9
=> OK

receipt page :
- replacement : 10
- budgeted : 9
- actual cost : 9
=> OK

receipt page (after reception, table "already received") :
- est cost : 9
- actual cost : 9
- total : 9
- Total tax inc. : 9
=> OK

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> KO : we should have "8.53" and "9"

======
Test 3:
vendor yes  (list price) / no  (invoiced price). The list price entered by the
librarian does include tax, and the library does NOT pay tax

basket :
- RRP tax exc. : 9.48
- RRP tax inc. : 10
- total price tax exc. : 8.53
- total price tax inc. : 9
=> maybe KO but out of the scope of the bug : If the library does not pay tax,
ecost tax inc. should be the same as tax exc. and the 2 equal 8.53 ? Or the
column should be hidden

receipt page :
- replacement : 9.48
- budgeted : 8.53
- actual cost : 8.53
=> maybe KO : replacement price must be tax inc. (I suppose so, if the aim is
to know the public price of the book to get it paid back by a reader who had
lost it). 

receipt page (after reception, table "already received") :
- est cost : 8.53
- actual cost : 8.53
- total : 8.53
- Total tax inc. : 9
=> KO. Total tax inc. should be "8.53" as we pay no tax

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> KO : we should have "8.53" in both column

======
test 4:
vendor no  (list price) / yes  (invoiced price).  The list price entered by the
librarian does NOT include tax, and the library does pay tax

basket :
- RRP tax exc. : 10
- RRP tax inc. : 10.55
- total price tax exc. : 9
- total price tax inc. : 9.49
=> OK

receipt page :
- replacement : 10.55
- budgeted : 9.49
- actual cost : 9.49
=> OK

receipt page (after reception, table "already received") :
- est cost : 9.49
- actual cost : 9.49
- total : 9.49
- Total tax inc. (bottom of table) : 9.49
=> OK

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 12:42:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 10:42:14 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-kY0AxvRUjV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 12:44:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 10:44:37 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-f9JiYTLbU2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Great. I spent a lot of time on your patch for invoice prices (prices give me
headache...) but I will try this one on sandbox 1 this afternoon.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 13:01:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 11:01:19 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-zS5BPferTB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 13:08:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 11:08:02 +0000
Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent
 order is deleted
In-Reply-To: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10984-70-CMD8RLMXD6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, 

Hm, I am not sure I have advice on this without replicating it - but i can't do
that before tonight. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 13:16:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 11:16:13 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-cps86a4YyT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

--- Comment #12 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing status with reference to comment8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 13:16:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 11:16:26 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-hc9KCm8z4G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:04:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:04:13 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4045-70-pjCfObHILf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21200|0                           |1
        is obsolete|                            |

--- Comment #47 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21712
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21712&action=edit
Bug 4045 - No check for maximum number of allowed holds.

Re-add the system preference maxreserves.

All the code using maxreserves is still in place. Though it
is not used in the Reserves module, it is used in all the
scripts where holds are placed.

Also adds a check so that a borrower cannot exceed the maximum
number of allowed holds by using the multi-hold feature via
the opac.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:04:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:04:38 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4045-70-6A91mI4CHt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #48 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
trivial rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:10:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:10:44 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4045-70-NAMmTQ6VCT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #49 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21713
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21713&action=edit
Bug 4045: Followup for optional insertion of maxreserves

Adds IGNORE to the INSERT statement. Since this is in the mysql folder,
that should be allowed ;)
Also: Do the version check via CheckVersion.

Test plan:
Run webinstaller updatestructure step.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:19:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:19:03 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4045-70-z5vwi7iVFL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #50 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Global symbol "$warnings" requires explicit package name at
/usr/share/koha/testclone/reserve/request.pl line 132.
Global symbol "$messages" requires explicit package name at
/usr/share/koha/testclone/reserve/request.pl line 166.
Global symbol "$warnings" requires explicit package name at
/usr/share/koha/testclone/reserve/request.pl line 168.
Execution of /usr/share/koha/testclone/reserve/request.pl aborted due to
compilation errors.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:20:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:20:14 +0000
Subject: [Koha-bugs] [Bug 10985] New: Unimarc: Authority summary does not
 work as expected
Message-ID: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

            Bug ID: 10985
           Summary: Unimarc: Authority summary does not work as expected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Example:
The following authority:

000 - Record Label
  @ 00190 a2200097 4500
001 - Record Identifier
  @ 55347
005 - Version Identifier
  @ 20131002124236.0
009 - ppn
  @ my_ppn
200 ## - Heading - Personal Name
  a Entry Element Personal name
  b Part of Name Other t G.

And the following summary:
  NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*]

We got:
 NP : 23849 ppn: -- NP : ppn: my_ppn -- NP : -- NP -- ppn: -- NP : Personal
name, D. ppn: :

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:21:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:21:53 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-GzVkrvsFze@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #27 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Note : it is easier to test by setting  maxRecordsForFacets to a big number
(say 500 or 1000) and activate  displayFacetCount.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:22:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:22:12 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-wrYOFy73t1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:22:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:22:16 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-EoicvjdDYX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21714
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21714&action=edit
Bug 10985: [UNIMARC] Fix authority summary

Test plan:
- edit an authority summary with:
NP : [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*]
- create a new authority with previous fields (it is possible some
  fields don't exist).
- search this authority and verify the summary is someting like:
 NP : Name, D.-- NP -- 23849 ppn my_ppn:
- Verify some summary for existing authority and check there are
  correct.
/!\ For the ppn, it should be defined in the zebra indexes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:24:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:24:52 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-Im8HVXNzXi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:25:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:25:04 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-Cvmfy6vMlj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:30:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:30:06 +0000
Subject: [Koha-bugs] [Bug 2172] Cart attaches an iso2709 file,
 which confuses 99% of patrons.
In-Reply-To: <bug-2172-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2172-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2172-70-wvHbGTmrds@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2172

--- Comment #1 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Does anyone works in this ?  Almost nobody can read files iso2709 except for
the IT librarians...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 14:46:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 12:46:17 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-pbxK3Sn6sC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #28 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Test made on sandbox 1

Not easy at all to test, because (in Unimarc at least)
- Author facets with "," are broken
Ex :
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=fr%252A&limit=au:Balzac,%20Honor%C3%A9%20de
=> 0 results

- Topic facets with "-" are broken
Ex : 
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=fr%252A&limit=su-to:Nature%20-%20revue
=> 0 results
I did not check, but I think they are broken in master too as your patch is not
supposed to change their behavior


Test 1 on OPAC:
maxRecordsForFacets = 1000
initial search ="a*"
1st click on series facet "Folio(39)" => [x] before facet Folio; 147 results
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=a%252A&limit=se:Folio

2d click on topic facet "823 (9)" => [x] before facet "823" ; facet "Folio"
still activated ; 2 results
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=a%252A&limit=se:Folio&limit=su-to:823

3rd click on series facet "Folio" => [x] disapear before "Folio" ; 52 results
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=a%252A&limit=se:Folio&limit=su-to:823&nolimit=se:Folio

Just to check : manually editing the url to limit only to "823" topic : 52
results
catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=a%252A&limit=su-to:823
Click on "Folio (2)" series facet => the 2 facets now have [x] ; 9 results are
showing (why not 2?)
Click on "823" facet topic => the [x] disapear before "823" ; 147 results

=> it seems OK

Test 2 on staff interface : 
paying with 3 different facets, checking, unchecking in a different order 
=> it seems OK

I will try to reproduce Owen's issue
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:01:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:01:16 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-x9ulyUdUVv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #29 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Test 3 : I confirm the problem if the 2 facets are in the same category. And I
experienced again the crash server again, but I have no idea whether it is
related to your patch.

- search "e*"
- click on library "Le Canet (1000)" => 
[x] before
 3950 result(s) found for 'kw,wrdl: e*' with limit(s): 'branch:Le Cannet' in
M?diath?que municipale Le Cannet des Maures Catalog.
http://pro.test1.biblibre.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=e%252A&limit=branch:MAURES

- click on library "M?diath?que d?partementale de pr?t (4)"
http://pro.test1.biblibre.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=e%252A&limit=branch:MAURES&limit=branch:BDP

BOUM!
FF Error "La connexion avec le serveur a ?t? r?initialis?e pendant le
chargement de la page."
I broke sandbox staff interface!

I had made the same test 5 before, but I did not note the results at that time.
And I did not experience the server error. Strange.

I try to test the same search on OPAC

- search "e*"
- click on library "Le Canet (1000)" => 
[x] before
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:MAURES
Your search returned 3950 results

- click on library "M?diath?que d?partementale de pr?t"
[x] before the 2 facets
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:MAURES&limit=branch:BDP
Your search returned 21 results. Subscribe to this search 

- uncheck "Le Canet" => still 21 results!
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:MAURES&limit=branch:BDP&nolimit=branch:MAURES
Your search returned 21 results. 

M?diath?que D?partementale de Pr?t [x]
Le Cannet (21)



Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:02:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:02:56 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-ET95zQ5HSg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #30 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hem, wait a second, in fact I think it working as expecteded...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:03:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:03:23 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-Dyz3V8adLk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:03:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:03:26 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-fJoAcfvIzx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6954|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21715&action=edit
Bug 7376 Transfer limits should be checked at check-in

Test case:
* UseBranchTransferLimits must be set
* define your branch transfer limit. Refuse transfers from libraryA to libraryB
* checkout a book owned by libraryB, from libraryB, with a librarian located at
libraryB
* move the librarian to libraryA ("Set Library" link top/right)
* check-in the book => it's possible whatever your setup

After the patch, the behaviour respect the branch transfer limit parameter: you
can check-in if you accept transfers, you can't if you refuse them.

(Note: IndependantBranches must be OFF, otherwise it's not possible to do the
checkin whatever the branch transfer limits)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:03:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:03:41 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-gQlxgtgDwA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:03:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:03:47 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-5cgl7CNWfO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha.sekjal at gmail.com       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:07:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:07:14 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-jGN0liB8Ap@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

--- Comment #31 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
In fact, there is only 21 documents in BDP
http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:BDP
and all of these seems to be also in "Le Canet" (I cannot see "Le Canet" items
on records, maybe they are hidden).

So my 3d test does not prove anything :(

And I cannot go back to staff interface so suppress some items, as I broke
it...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:12:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:12:15 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-20rqueRYFe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
Jonathan wrote a patch about GST on invoices.
I made 4 long tests (from basket to invoice, with 4 vendors), and found a lot
of weird things about prices in general. Maybe it could be helpfull for this
one.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:16:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:16:13 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-FC7cY0czSZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #12 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(Nicole, in comment for Bug 10613 I say documentation about prices is poor.
Don't take it for you! I was just meaning if there were somewhere a detailed
specification page with all different "prices" and their expected behavior with
different vendor settings, it would be easier to agree on bugs to fix.)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:37:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:37:51 +0000
Subject: [Koha-bugs] [Bug 10986] New: Limit the list of languages in
 advanced search through system preferences
Message-ID: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

            Bug ID: 10986
           Summary: Limit the list of languages in advanced search through
                    system preferences
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

In Advanced Search, the list of available language is long and will only get
longer.  For a library offering books in 2-3 languages, that is offering too
much info to the user (most of the small libraries we deal with only offer
documents in two langages).

So through an optional preference listing language codes, we would override the
list offered.

Files modified:
C4/Languages.pm
preferences/*.pref ?
updatedatabase.pl
sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 15:49:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 13:49:57 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-2WXPtDDzOt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:20:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:20:06 +0000
Subject: [Koha-bugs] [Bug 10912] Streamline hold error messages in staff
	interface
In-Reply-To: <bug-10912-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10912-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10912-70-qZhQtMSUpi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

Nora Blake <nblake at masslibsystem.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nblake at masslibsystem.org

--- Comment #3 from Nora Blake <nblake at masslibsystem.org> ---
Hello,

We were the source of this bug fix and in our estimation is solves the problem
have been experiencing.  This patch seems good to us.

Nora Blake
MassCat

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:27:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:27:41 +0000
Subject: [Koha-bugs] [Bug 10925] LDAP Auth fails if DEBUG is enable
In-Reply-To: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10925-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10925-70-wj28AqpSSd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10925

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:32:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:32:29 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-eVcrxpFSsK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #63 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Jared,
I really would like to mark this feature as passed qa but I think I found 2
potential blocker things:
1/ I am under the impression that the payment don't work
To reproduce:
online: checkout/checkin an item in order to produce a fine
offline: the alert appears, I make the payment, upload the transaction, execute
the action.
In the payment list, there is a new line:
Payment,thanks          0.00     0.00

2/ Why don't you block a checkout to a restricted user?

Minor: The search by partial name does not work, only a checkout using a
cardnumber works (contrary to what it is displayed).

For discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:36:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:36:45 +0000
Subject: [Koha-bugs] [Bug 10965] Sample itemtypes can't load on new install
In-Reply-To: <bug-10965-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10965-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10965-70-3LZmlilHcK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10965

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:37:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:37:10 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-qTPqpUMmCO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |blocker

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
Marking as release blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:37:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:37:10 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4045-70-jyTeirPpyx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #51 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just another question in this regard:
dbrev 3.01.00.066: should the delete statement of maxreserves here be undone? 

Or would that present problems for those upgrading from below this dbrev to
some version without this patch? Looks like we offer the choice bad or worse??

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:39:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:39:07 +0000
Subject: [Koha-bugs] [Bug 10949] hold request not retrieved when printing
	hold slip
In-Reply-To: <bug-10949-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10949-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10949-70-BTXXXNqzck@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10949

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:50:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:50:43 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-RdDGwD4T48@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #64 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to Jonathan Druart from comment #63)
> Jared,
> I really would like to mark this feature as passed qa but I think I found 2
> potential blocker things:
> 1/ I am under the impression that the payment don't work
> To reproduce:
> online: checkout/checkin an item in order to produce a fine
> offline: the alert appears, I make the payment, upload the transaction,
> execute the action.
> In the payment list, there is a new line:
> Payment,thanks  		0.00 	0.00

I will check this.

> 2/ Why don't you block a checkout to a restricted user?

If the offline database is out-of-date (because, for example, you're using
offline circ due to an unplanned outage), you don't want to be blocking people
from checking out. Same reason an incorrect barcode can't block circ: it could
be a new book.

> Minor: The search by partial name does not work, only a checkout using a
> cardnumber works (contrary to what it is displayed).

Good point. I'll change that label. I never even thought about it, since it's
generated elsewhere in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:54:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:54:25 +0000
Subject: [Koha-bugs] [Bug 10967] POD ERROR in acqui/booksellers.pl
In-Reply-To: <bug-10967-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10967-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10967-70-f7Lt7OobXN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10967

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Ketan!  Looks like this is your first patch accepted
into Koha, so again, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:58:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:58:28 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-OdXA67CjXu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:58:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:58:46 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-wUtkYiP5jr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21210|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 21716
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21716&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list

This patch changes the URL and data used to show the 'see also' links
on the OPAC's authority search results page.

Bonus points: makes some strings translatable.

To test:
- On your dev setup (master) create some authority records (i created personal
name authorities).
- Pick one of them and link 400$a to another one, do the same with 500$a
- Add some other 400$a and 500$a without linking (i.e. plain text)
- Make sure zebra is running and changes got indexed.
- In the OPAC search for the authority that is linked to the others.
- Check the 'see also:' link points to an authority search
- Apply the patch
- Reload/re-do the search
- Check the 'see also:' link points to the authority id in the case of linked
authorities,
  and to an authority search in the case of plain text names.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:59:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:59:11 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-N4ea6vQSCo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21212|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 21717
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21717&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list
[Staff]

This patch changes the URL and data used to show the 'see also' links
on the Staff's authority search results page.

Bonus points: makes some strings translatable.

To test:
- On your dev setup (master) create some authority records (i created personal
name authorities).
- Pick one of them and link 400$a to another one, do the same with 500$a
- Add some other 400$a and 500$a entries with plain text (i.e. no linking)
- Make sure zebra is running and changes got indexed.
- In the staff interface search for the authority that is linked to the others.
- Check the 'see also:' link points to an authority search
- Apply the patch
- Reload/re-do the search
- Check the 'see also:' link points to the authority id for linked authorities,
  and to an authority search result in the case of plain text entries.
- Check that the authority search from the cataloguing interface still works as
usual.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 16:59:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 14:59:18 +0000
Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not
 parsing query correctly
In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5645-70-DZjCWue6Nb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:03:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:03:53 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-fNFUwu7i3X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #65 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Created attachment 21718
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21718&action=edit
Bug 10240 QA follow-up: correctly record fines and fix label

At some point in rebasing I managed to remove the part of the code
that saved fine payments. This patch re-adds that feature. This patch
also corrects the label on the check out tab to not mention partial
names for checkouts when offline, and partial name searches are not
supported in offline circ.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:22:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:22:34 +0000
Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list
 turned out untranslatable
In-Reply-To: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10948-70-HGvnjjt8Ro@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jared!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:27:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:27:54 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-q4sZLXY8Aj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #66 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Thanks Jared for your quick patch!

QA comment:

I follow this feature from the beginning and all detected issues have been
taken into consideration.

Further improvement: displays the list of checkout and payment for a patron. At
the moment, if a librarian go back on the checkout page, the previous (but not
processed!) offline operations are not shown).

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:28:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:28:23 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-rIrGZomlP9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21573|0                           |1
        is obsolete|                            |
  Attachment #21574|0                           |1
        is obsolete|                            |
  Attachment #21575|0                           |1
        is obsolete|                            |
  Attachment #21576|0                           |1
        is obsolete|                            |
  Attachment #21577|0                           |1
        is obsolete|                            |
  Attachment #21578|0                           |1
        is obsolete|                            |
  Attachment #21579|0                           |1
        is obsolete|                            |
  Attachment #21718|0                           |1
        is obsolete|                            |

--- Comment #67 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21719
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21719&action=edit
Bug 10240: Offline circulation using HTML5 and IndexedDB

This patch adds an HTML5-based offline mode to Koha's existing
circulation module, allowing librarians to check out items using a
basically familiar interface. The feature will be implemented using
the Application Cache and IndexedDB features of the HTML5 specification,
both of which are fully supported on Firefox 10+ and Chrome 23+, with
limited support going back to Firefox 4 and Chrome 11. The basic
workflow enabled by this patch is as follows:

Part 1: While connected to the Internet
1. Enable offline functionality by turning on the
   "AllowOfflineCirculation" system preference.
2. Sync the offline circulation database on the computer that will be
   used for offline circulation by following the "Offline circulation
   interface" link on the Circulation home page, choosing "Synchronize (must be
online)",
   and clicking the "Download records" button. This process may take a while.
3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently
   on) for easy access when offline.

Part 2: While disconnected from the Internet
4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you
   created while online.
5. Start checking books in by scanning the barcode of an item that has
   been returned into the box in the "Check in" tab.
6. Scan the barcodes of any additional items that have been returned.
7. Start checking out books to a patron by scanning the patron's barcode
   in the box in the "Check out" tab.
8. Set a due date (the "Remember for session" box will be checked by
   default, since circulation rules are not computed during offline
   transactions and therefore a due date must be specified by the
   librarian).
9. Scan an item barcode (if you did not set a due date, it will prompt
   you) to check the item out to the patron.
10. If a patron has a fine you can see the total amount (current to when
    the offline module was synced), and record a payment. Unlike when in
    online mode, there will be no breakdown of what item(s) fines are
    for, and you will only be able to record the payment amount and not
    associate it with a particular item.

Part 3: While connected to the Internet
11. Click the "Synchronize" link and choose "Upload transactions" to
    upload the transactions recorded during the offline circulation
    session.
12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a
    link from the Offline circulation page) and review the
    transactions, as described in the documentation for the Firefox
    Offline circulation plugin:
    http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Comment: Works very well, no koha-qa errors

Test with Firefox 24.0
1) did some checkouts pre sync
2) synchronize database (Download)
3) go offline
4) Proceed to checkin some items from patron
5) Proceed to checkout items to patrons, setting date
6) Proceed to checkout to expired patron, warning appears
7) go online
8) Upload records
9) go to review transacctions and proceed
10) verified on patrons that checkin/out are done

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:28:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:28:29 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-aWJ7bgCISF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #68 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21720
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21720&action=edit
Bug 10240 QA follow-up

Address the following issues:
    1/ Address minor qa issues with the templates:
     FAIL    koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt
      FAIL      forbidden patterns
                forbidden pattern: intranet-tmpl should certainly
                replaced with [% interface %] (line 24)
                [etc.]
     OK      tt_valid
     OK      valid_template

    FAIL    koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt
     FAIL      forbidden patterns
               forbidden pattern: intranet-tmpl should certainly
               replaced with [% interface %] (line 509)
               [etc.]
    FAIL      tt_valid
        lines 5, 5
    2/ Run perltidy on new scripts
    3/ download.pl returns data.finished = 1 if number of returned
       data < 5000 (avoids 1 ajax call)
    4/ Replace qq{} around sql queries with q{}

Also, a race condition existed that resulted in pending transactions
only getting deleted from the local database in certain circumstances
(fast connections under Chrome, mostly). This patch fixes that so that
successfully-uploaded transactions are always deleted.

This patch also addresses Jonathan's suggestion:
3/ add a message on check in (currently the input becomes empty but the
   user is not informed).

... and Magnus's suggestion about moving the Synchronize link to the
right on the homepage.

Also, this addresses the further issues Jonathan noted:

- The tab of checkouts always shows "*0* Checkouts"
- If I am not well-educated, I click on the "Check out" link on the
  offline home page, I enter a barcode, click on "Check out" and I get a
  js error (without user message): "TypeError: curpatron is undefined"
  (with chromium I get: Numeric transaction modes are deprecated in
  IDBDatabase.transaction. Use "readonly" or "readwrite").
- There is a "border-right" css rule on the h5.patron-title. It is
  display when there is no patron selected) [really minor!].
- tables are displayed even if there is no data
- The "Clear screen" link (X) points to an old script:
  circ/offline-circulation.pl
- There is a warning when clicking on the "Synchronize" link when the
  user is offline, but not for the "Pending offline circulation actions"
  link.
- Still exists:
> The "Checked in item." message text never disappear (even if I go on the
> offline home page (circ/offline.pl#offline-home)).

Finally, this patch adds a link to the Pending offline operations page
on the synchronize page for easier navigation.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:28:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:28:35 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-3YVsjpZCal@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #69 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21721
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21721&action=edit
Bug 10240 follow-up: don't delete transactions if auth fails

When uploading transactions, we were not checking that authentication
had succeeded before deleting the transactions from the local database.
That was bad. With this patch, we check. That is good.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:28:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:28:42 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-3jkulkjOOu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #70 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21722
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21722&action=edit
Bug 10240 follow-up: fix display

Fix the following two issues:
1) After paying a fine when offline the fine amount becomes NaN.
2) For previous checkouts for a pratron the title and barcode
   fields have the wrong infomation in them (i.e. they have been swapped)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:28:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:28:48 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-flaHmT4msz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #71 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21723
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21723&action=edit
Bug 10240 follow-up: disable logout/set library

Logging out/setting the library does not work while using offline
mode, so it makes no sense to present those options to the user.
Much better is some sort of explanatory message informing them that
those two links don't work.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:28:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:28:55 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-9RP6WHG1Sq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #72 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21724
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21724&action=edit
Bug 10240: warn when patron's card is expired

This patch improves the alert messages to be slightly better English
and warns the librarian if a patron's card has expired. Like all alerts,
this is non-fatal since in the case of network failure there is no
particular reason to expect that the offline database is current.
To test this particular patch you can try checking something out to an
expired patron, otherwise test plan remains the same as above.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:29:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:29:10 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-dKBzAvklsV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #74 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21726
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21726&action=edit
Bug 10240 QA follow-up: correctly record fines and fix label

At some point in rebasing I managed to remove the part of the code
that saved fine payments. This patch re-adds that feature. This patch
also corrects the label on the check out tab to not mention partial
names for checkouts when offline, and partial name searches are not
supported in offline circ.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:29:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:29:01 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-LMuJ7lqueZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

--- Comment #73 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21725
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21725&action=edit
Bug 10240 follow-up: make sure datepicker icons are available offline

The next month/previous month icons for the datepicker were not available
offline. With this patch they are.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:29:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:29:56 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-n7ruKxPwDP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10068

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:29:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:29:56 +0000
Subject: [Koha-bugs] [Bug 10068] Move from the utf8:: pragma methods to
	Encode::
In-Reply-To: <bug-10068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10068-70-VdAyZWkMUE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10068

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=6554

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:32:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:32:34 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-X2vh4xZRM1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #153 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I marked 10068 as 'see also', not because of the patches, but to mention the
first comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:35:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:35:39 +0000
Subject: [Koha-bugs] [Bug 10806] The staff benchmark script does not check
 authentication failure
In-Reply-To: <bug-10806-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10806-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10806-70-WlMuswLTy5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10806

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:39:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:39:54 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-9ZmxGyoRPi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21716|0                           |1
        is obsolete|                            |

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 21727
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21727&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list

This patch changes the URL and data used to show the 'see also' links
on the OPAC's authority search results page.

Bonus points: makes some strings translatable.

To test:
- On your dev setup (master) create some authority records (i created personal
name authorities).
- Pick one of them and link 400$a to another one, do the same with 500$a
- Add some other 400$a and 500$a without linking (i.e. plain text)
- Make sure zebra is running and changes got indexed.
- In the OPAC search for the authority that is linked to the others.
- Check the 'see also:' link points to an authority search
- Apply the patch
- Reload/re-do the search
- Check the 'see also:' link points to the authority id in the case of linked
authorities,
  and to an authority search in the case of plain text names.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:41:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:41:15 +0000
Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list
 turned out untranslatable
In-Reply-To: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10948-70-iVuL6WjXIJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10691

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:41:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:41:15 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-RFHD817jXK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10948

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:42:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:42:23 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-oMpdt3NVku@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #32 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
So, still "need signoff"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:42:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:42:52 +0000
Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list
 turned out untranslatable
In-Reply-To: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10948-70-2LZoM0FFJ3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
I'd like to note that bug 10691 fixes this for the staff interface also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:51:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:51:49 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-Pg06wsZvv4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
And what about french db? is it needed too?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:52:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:52:19 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-eEtfET0nMG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 21728
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21728&action=edit
Bug 10691: Small glitch fixed

A small glitch prevented 'see from' headings to show.

Sponsored-by: Universidad Nacional de C?rdoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 17:59:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 15:59:29 +0000
Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC
	7XX
In-Reply-To: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9352-70-o4BW94JnHO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

--- Comment #18 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I don't know if it need to be tested on DOM, as DOM is not working well for
UNIMARC.
Maybe we should consider it as signed off?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 18:01:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 16:01:16 +0000
Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC
	7XX
In-Reply-To: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9352-70-xIpg0UvRi0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I would like to see this patch and the other ones about unimarc pushed before
making my patch for configuring facets. Otherwise there would be too many
dependancies.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 18:03:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 16:03:47 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-rEriLLEEPc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10948

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 18:03:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 16:03:47 +0000
Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list
 turned out untranslatable
In-Reply-To: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10948-70-opoemu5tbp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10691

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 18:04:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 16:04:54 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-edSeohWqiA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I checked all languages and French was using a differnt SQL statement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 18:15:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 16:15:13 +0000
Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC
	7XX
In-Reply-To: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9352-70-iDawBvQbtK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

--- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to mathieu saby from comment #18)
> I don't know if it need to be tested on DOM, as DOM is not working well for
> UNIMARC.
> Maybe we should consider it as signed off?
> 
> Mathieu

Only way I think is obsoleting the other patch.

Thinking on your other comment, what's is needed?
I could try to help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:00:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:00:48 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-2pORC3MUjE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Jonathan, can you point me to the code that is currently accomplishing this?
I'm afraid I'm having a difficult time locating it. Thanks!

> In fact it is especially for discussion, I will try to explain:
> If I specify a hard due date with now - 1 day and I check in today, the
> patron is debarred until now + 3 days (in the issuing rules: Suspension in
> days(=3) * 1).
> If I specify a hard due date with now - 30 days and I specify a return date
> of the day after (now - 29 days), what about the suspension delay?
> Currently, the patron is suspended until now + 29*3 days.
> I am not sure it is relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:14:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:14:10 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-2XzqrSqMyk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:14:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:14:13 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-TlOB0D5QfY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17311|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21729
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21729&action=edit
Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send
drivers

Nearly all cellular providers allow a person to send an text message to a
cellular
phone by sending an email to phonenumber at provider. We can leverage this
capability
to add the ability for Koha to send sms messages to patrons without the need to
subscribe to an sms gateway server.

Basic plan:
1. Add a table sms_providers to the db to tell Koha what service providers are
available, and what domain emails should be sent to.
2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron
subscribes to for the number given in smsalertnumber
3. Modify Koha to send an email rather than using SMS::Send if the driver is
set to 'Email'

Test plan:
0) Get a mobile phone
1) Apply the patch
2) Run updatedatabase.pl
3) Set the value of SMSSendDriver to 'Email'
4) Go to the admin page, the "Additional parameters" area should now have the
link "SMS cellular providers"
5) On this page, add some providers. Make sure to add the provider for your own
cellular phone service.

Here are some examples:
Sprint   phonenumber at messaging.sprintpcs.com
Verizon  phonenumber at vtext.com
T-Mobile phonenumber at tmomail.net
AT&T     phonenumber at txt.att.net

Only add the domain part in the 'domain' field. So for Verizon, that would be
'vtext.com'

6) Create an account for yourself, add your SMS number, and select your
provider from the dropdown box directly below it.

7) Enable SMS messaging for Item check-in and Item checkout
8) Check out an item to yourself
9) Run process_message_queue.pl
10) Wait! You should receive a text message shortly, when I tested it, I
received my sms message within the minute.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:21:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:21:14 +0000
Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or
	withdrawn
In-Reply-To: <bug-9673-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9673-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9673-70-VBWlVtq4cF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19489|0                           |1
        is obsolete|                            |

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21730
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21730&action=edit
Bug 9673 - Track when items are marked as lost or withdrawn

Add date fields to track when an item was marked as lost or withdrawn.
Display those fields on catalogue/moredetail.pl

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Pick a record with items, browse to the 'items' tab ( moredetail.pl )
4) Mark an item as lost, verify the field "Lost on:" displays below
   the "Lost status" field with todays date.
5) Mark the item as not lost, verify the field no longer displays
6) Repeat steps 4 and 5 with the Withdrawn field.

Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:21:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:21:25 +0000
Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or
	withdrawn
In-Reply-To: <bug-9673-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9673-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9673-70-WGkO0XdljC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:21:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:21:27 +0000
Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or
	withdrawn
In-Reply-To: <bug-9673-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9673-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9673-70-A8gbW6OFY8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19492|0                           |1
        is obsolete|                            |

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21731
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21731&action=edit
Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 19:59:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 17:59:14 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-CpzMS4y48V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |eric.begin at inLibro.com
           Assignee|oleonard at myacpl.org         |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:22:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:22:19 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-gg8QClASQz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mathieu - maybe we need to start a wiki page for that. Without a clear
specification, those bugs will be hard to fix :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:23:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:23:05 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-odK1kwOUaa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:29:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:29:32 +0000
Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC
	7XX
In-Reply-To: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9352-70-NYajomcKdq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

--- Comment #21 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
Not sure what comment you refer to ;-)

What is needed is applying attachment 15229 on a DOM Unimarc Koha, and testing
it (copying modified configuration files into {installdir}/etc/zebra.... and
rebuild_zebra.pl)

As it is pure copy of the patch for GRS1, I'd say there is no need to test ALL
the items of the test plan. If it was working for GRS1, it *must* work with
DOM.
And if there is something wrong, the QA team will tell us.

Maybe just check you can still search for authors after the pach is applied,
and that the search is limited to the fistname + family name of the author (not
his birthdate, nor his function code in $4 subfield)

You're very kind for proposing your help.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:36:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:36:29 +0000
Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees
In-Reply-To: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9448-70-KExCmn9TBU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:36:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:36:31 +0000
Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees
In-Reply-To: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9448-70-9BXtn4FCex@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21732
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21732&action=edit
Bug 9448 - Add separate permission for writing off fees

Adds new sub-permissions to updatecharges, 'writeoff' for writing off fees
and 'remaining_permissions' for all other fee related activites.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Remove the 'writeoff' permission from your privileges
4) Attempt to write off a fee, you should not be able to
5) Re-add the 'writeoff' permission
6) Attempt to write off a fee, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:37:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:37:12 +0000
Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees
In-Reply-To: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9448-70-DaXv2FTahC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16606|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:51:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:51:41 +0000
Subject: [Koha-bugs] [Bug 10987] New: Too many 'see also' and 'usedfor/see
 from' labels occurences
Message-ID: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

            Bug ID: 10987
           Summary: Too many 'see also' and 'usedfor/see from' labels
                    occurences
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If you do an authority search and the results contain authorities with more
than one 4xx or 5xx the 'see also' and 'used for/see from' labels are
unnecesarilly repeated, affecting readability.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:52:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:52:57 +0000
Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from'
 labels occurences
In-Reply-To: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10987-70-x1P5v5xpNj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:53:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:53:03 +0000
Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from'
 labels occurences
In-Reply-To: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10987-70-vylYiSowS6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 21733
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21733&action=edit
Bug 10987: Too many 'see also' and 'see from' labels occurences

If an authority record has more than one 4xx$a (or 5xx$a) entries the
corresponding labels 'see also' and 'used for/see from' are repeated.

To test:
- Have authority records with more than one entry on the 4xx (or 5xx) fields.
- Do a search, check "see also:" (or 'used for/see from') appear more than
once.
- Apply the patch
- Reload and check it looks nicer :-D
- Repeat for: staff auth search, opac using ccsr, opac using prog
- Signoff

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:53:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:53:26 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-lWVQpB3n20@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10987

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 20:53:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 18:53:26 +0000
Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from'
 labels occurences
In-Reply-To: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10987-70-TkbbewW96i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10691
  Change sponsored?|---                         |Sponsored
           Assignee|oleonard at myacpl.org         |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 21:33:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 19:33:52 +0000
Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number
	generation
In-Reply-To: <bug-7911-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7911-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7911-70-JIBGECkaBC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

--- Comment #6 from Eric B?gin <eric.begin at inLibro.com> ---
Which options were implemented so far in the autobarcode ?

Do you still plan to release something for this ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 21:39:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 19:39:48 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-OxE1F88VQA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #141 from M. Tompsett <mtompset at hotmail.com> ---
First patch needs to be rebased. uploaddatabase.pl patch issues. Still going
ahead with testing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 22:21:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 20:21:28 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-Hwqrr5oHJ4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #14 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 21734
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21734&action=edit
Bug 10486 - Followup: Minor typo fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 22:25:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 20:25:39 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-9g4frYx1YC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
It's sad only the 1996 version is online in html.

But do you think it would be possible for french ppl version to have link to
the french version of the manual on BNF website?
http://www.bnf.fr/fr/professionnels/anx_formats/a.unimarc_manuel_format_bibliographique.html
Or maybe to the version of ABES network (used by french academic libraries, but
some details are only on BNF website...)
http://documentation.abes.fr/sudoc/formats/unmb/index.htm

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 22:37:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 20:37:13 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-SMX1WyWMGh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21616|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21735
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21735&action=edit
[SIGNED-OFF] Bug 10705 - Shipment cost should be 'shipping'

http://bugs.koha-community.org/show_bug.cgi?id=10705
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Trivial string change. No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 22:37:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 20:37:32 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-n6hf2etSBW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 23:02:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 21:02:20 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-ARnVeyyOlP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #1 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21736
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21736&action=edit
Limit the list of languages in advanced search

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 23:02:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 21:02:46 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-rRS2DS2vZS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 23:19:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 21:19:04 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-zVFjbEdpf9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #13)
> Hi Mathieu - maybe we need to start a wiki page for that. Without a clear
> specification, those bugs will be hard to fix :(

I can try to write something, but I don't know if I have rights to create a
page.
Some ideas it may be usefull to list :
- the different columns for prices in aqorders and their meaning (listprice,
ecost, unitprice) + discount + tax rate
(maybe also prices in records in a 2d time)
- the different settings for vendors and their meaning
- the different settings for currencies
- the pages (not forgetting pdf and csv export) displaying prices (not to
forget some of them is a patch is made for altering general price management)
- maybe the subs in C4 handling prices
- Which prices stored in database Koha must calculate, when and how
- Which prices must be visible in staff interface, when and how to calculate
them
- arithmetic details : how much decimals are taken into consideration in the
calculations? what kind of "rounding" is made in the final price displayed or
store in db (15.005 => 15 or 15.01 ?)

For example : in a detailed order create by hand, 
-> the user enter a price (could be with or without tax)
10 EUR
-> this input is saved in DB as listprice (is it usefull?)
(I think a correction is made depending on currency at this step. not sure)
-> rrp tax exc. and tax. inc are calculated depending on listprice and the
preference "list prices include tax" of the vendor
for ex : rrp tax inc = 10.55 EUR
-> rrp (which one : tax inc., or tax exl, or depending on vendor preference?)
is saved in database in rrp column
-> rrp tax INC (or also tax exc. but it must be clear) is displayed on screen
-> ecost (tax inc.? tax exl?) is calculated depending on rrp tax inc., the
discount and the preference "invoiced prices include tax"
etc

It would be long and tedious, but I am sure it could be usefull for fixing
bugs, avoiding future regressions, and make easier future enh.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  2 23:47:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 02 Oct 2013 21:47:50 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-sWNHnwCt4Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
I did not look yet, and I will, as it could be usefull, but I have considering
a more important more work for management of document languages in Koha for
years. The current way of dealing with it is just horrible! 3 SQL tables, no
way to update them easily, no way to translate them automaticaly...

It's out of the scope of your bug, but if you are interested in language
management, you will probably have an opinion. Could you tell me what you think
of that?

A enh could be : 
- store somewhere (a table? a yaml file?) the complete list of iso 639-2 codes,
used in UNIMARC, with the "native name" of this language
- store somewhere the complete list of MARC21 codes used in MARC21 (mostly the
same as iso 639-2, but not always), with the "native name" of this language
- include in the 2 lists "obsolete" codes for the 2 lists, because when a code
is marked as obsolete by the agency responsible for a list (ISO or LoC), it
does not mean automaticaly that the records using it are updated in every
library...
Maybe store the 2 lists (iso 639 and marc codes) in the same table or the same
yaml file, using for a key the iso 639-2(or iso 639-3 if needed) code (we must
check if there are some languages existing in one list and not in the other...)
These 2 lists won't be editable by users

- map each of these code with the english name of the list, and store the
resulting file (xml?) somewhere in koha templates where it could be translated
- make some PO files for translating this list

The PO files could be make automaticaly (need some work...) from data freely
available on Lexvo.org website (GLP licence).

effects for users on OPAC : 
- in language search dropdown list, show for "name depending on OPAC locale
language - native name". Sort the list alphabeticaly according to the name on
OPAC locale language. Ex : if OPAC is in french : "allemand - deutsch" ; in
english : "german - deutshc"
- when OPAC is switch in some language, the name of the language used in the
record would be translated. Ex : for a UNIMARC record with 101$a = "ger",
display "german" if OPAC is in english, "allemand" if it in french...
- we could also build facets on document language.

administration on staff interface:
- show the complete list of avalaible language on a page
- let the staff check a box before the name of the languages they want to be in
the dropdown list on avanced search page.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 02:00:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 00:00:57 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-vMlNXMr5Qy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Trying to test.
Is there any documentation of how to enable/configure pazpar2?
I'm to the point that I need to know where to find "/pazpar2/search.pz2" file
referenced in pazpar2_init on line 72

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 02:41:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 00:41:28 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-eg78SyMjjk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #12 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I'm not sure this is correct. C4::Context is not an object, hence has no
methods. I believe :: is more appropriate under the circumstances. Although we
may agree to call C4::Context subs using ->, but that would be just a waste of
the first argument.

Context *should* be an object, I agree, but unfortunately it is not. Is this
being addressed in Koha:: namespace?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 02:56:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 00:56:12 +0000
Subject: [Koha-bugs] [Bug 10890] Autobarcode "<branch>yymm00001" Fails in
 Acquisitions When Receiving Item
In-Reply-To: <bug-10890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10890-70-eGIIXRavYv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 02:56:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 00:56:15 +0000
Subject: [Koha-bugs] [Bug 10890] Autobarcode "<branch>yymm00001" Fails in
 Acquisitions When Receiving Item
In-Reply-To: <bug-10890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10890-70-in52rMJkHn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21111|0                           |1
        is obsolete|                            |

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 21737
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21737&action=edit
[SIGNED-OFF] Bug 10890 - Autobarcode "<branch>yymm00001" Fails in Acquisitions
When Receiving Item

This patch adds the name "f" to the form that adds items when placing or
receiving
an order in Acquisitions.

This is needed so that the autobarcode code (which uses document.f.field_name)
will
work properly when the system preference is set to "<branch>yymm00001".

AcqCreateItem
"placing an order"
"receiving an order"

TEST PLAN

1) Set the autobarcode system preference to "<branch>yymm00001"
2) Set the AcqCreateItem system preference to "placing an order"
3) Plan an order
4) Try to add a barcode to the item in the AJAX form
5) Note that no barcode appears. Depending on your browser, you might
receive a Javascript error popup message or a error icon at the bottom
of your screen. You might receive no error message at all and it will
fail seemingly silently.

6) Set the AcqCreateItem system preference to "receiving an order"
7) Receive the order
8) Try to add a barcode to the item in the AJAX form
9) See step 5. No barcode will appear and you might get an error message.

10) Apply the patch
11) Repeat steps 2, 3, 4, 6, 7, and 8 again. That is, try to add
barcodes when placing an order and receiving an order.
12) Note that a barcode now appears with the pattern of <branch>yymm00001

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 03:09:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 01:09:33 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-RzRLGnE5fJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
I don't know if it is being addressed in the Koha:: namespace. However, if
someone is working on splitting C4::Context, this means that one piece of the
split up is closer to being the object it should be. See bug 7176.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 03:16:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 01:16:42 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-xSVy00uE0c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #14 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Ok, then I'll rephrase:
If Context is moving to Koha, then this is not necessary. If it is not, well
then I can see the point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 03:25:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 01:25:21 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-TzCBb4sDSJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |srdjan at catalyst.net.nz

--- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I got a javascript validatePayment() not defined error. Am I missing something?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 03:53:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 01:53:32 +0000
Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices
 table doesn't work
In-Reply-To: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10794-70-IZ6PrCz0Ug@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 03:53:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 01:53:35 +0000
Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices
 table doesn't work
In-Reply-To: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10794-70-Ij7o5el64O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20924|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 21738
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21738&action=edit
[SIGNED-OFF] Bug 10794 - Sorting on billing date column in invoices table
doesn't work

This patch adds the sorting by title string option to the table of
invoices. This allows column data to be sorted based on the
ISO-formatted date rather than the formatted-for-display date. A "blank"
(0000-00-00) date is added to cells which contain no date data.

To test, view the Acquisitions Invoices page (acqui/invoices.pl) and
confirm that the "Billing date" column is sorted correctly regardless of
the dateformat system preference.

http://bugs.koha-community.org/show_bug.cgi?id=10749

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 04:06:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 02:06:41 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-qdK3WL4d2v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #142 from M. Tompsett <mtompset at hotmail.com> ---
Testing with Javascript enabled.

click plugin icon
click Submit Query with nothing filled in.
- Was only told about the file location not filled in. I would expected to be
told neither were filled in, if I get told this.

Selected a file
click Submit Query
- expected to be told location not filled it. As expected.

closed pop up window.
click plugin icon
click location, but not select a file.
- Refreshed blank. A valid behaviour, but confusing since now we have the file
location validation.

selected a file and chose a location
click Submit Query
- File uploaded as expected.

click close
- URL is filled in nicely, as expected.

click plugin icon
- Would you like to delete window pops up. Okay behaviour.

click cancel
- windows closes no changes as expected.

click plugin icon
click delete
- told it was deleted successfully, as expected. URL is blanked, as expected.

click close
repeat steps to get back to delete popup and click delete
upload a new file

-- after a few cycles of trying to repeat the nothing, browse, root, browse &
root selections, I realized I would really like a way to clear the file
selected. Though, perhaps this isn't the real need.

I did try testing with Javascript off, but it is nearly impossible to work with
different browers and scripting off. I was able to trigger your non-javascript
red message under IE 10, but not Firefox 24 since the plugin icon refused to
popup a window. The problem with it disabled was that then the 'close' doesn't
work with javascript disabled, and the URL isn't filled in, but the file is
uploaded.

On a positive note it continues to behave as if there was no file uploaded,
which is what is expected from a blank 856$u field. However, there are table
entries and files sitting on the server now.

SUGGESTIONS FOR IMPROVEMENTS:
- If we validate the location, could we also validate if the filename is set?
- Could we add a 'Cancel' which just closes the window to this? Not just a
'Submit Query' button.
- Could we change 'Submit Query' to 'Upload File'?
- When nothing was selected, got a refresh, which is okay, but strange in light
of validation message logic that was added.
- Javascript off generates bizarre (but not unstable) state of file uploaded
and table pointing to it, but textbox empty, under IE 10. I couldn't even open
the new popup windows under FireFox 24. I think if we document this requires
Javascript, this is passable.

This is getting really close to useable. Thank you for working on this, Julian.
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 04:09:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 02:09:21 +0000
Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search
	groups
In-Reply-To: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10798-70-a0KT0Ejj1W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 04:09:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 02:09:24 +0000
Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search
	groups
In-Reply-To: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10798-70-sur4T8kA8h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20708|0                           |1
        is obsolete|                            |

--- Comment #3 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 21739
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21739&action=edit
[SIGNED-OFF] Bug 10798 - OPAC_SEARCH_LIMIT behaves badly with search groups

Since the addition of search groups to koha, the branch limiting
parameter in multiple PAC by URL support should also support
limiting by these search groups.  This patch adds this ability.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 08:46:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 06:46:16 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-oRaA5bFSAU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

--- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> ---
> It's sad only the 1996 version is online in html.

Imagine a community of librarians managing collaboratively an up-to-date
UNIMARC documentation, for free, for freedom... Hey, isn't IFLA supposed to do
that?

> But do you think it would be possible for french ppl version to have link to
> the french version of the manual on BNF website?
> http://www.bnf.fr/fr/professionnels/anx_formats/a.
> unimarc_manuel_format_bibliographique.html

+1

But I can't find direct link to UNIMARC specific tag documentation.

> Or maybe to the version of ABES network (used by french academic libraries,
> but some details are only on BNF website...)
> http://documentation.abes.fr/sudoc/formats/unmb/index.htm

Direct links are available. It could work. IFLA documentation was selected by
default, and since it is obsoleting, we could switch to ABES documentation
without damage. Dont' you think ABES will require specific authorisation to
link to their web site. Would you mind asking them?

But such an enhencement must be the object of another bug report. In the
meantime, my patch is a just a quick fix to an annoying bug, which can easily
be signed-off...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 08:59:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 06:59:41 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-gXDWNWzmcq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:00:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:00:20 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-DXQ7iCiwPp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #17 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:00:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:00:51 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-V8pc2osawf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #23 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:01:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:01:24 +0000
Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees
In-Reply-To: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9448-70-aBpHF2S8Mw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:01:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:01:49 +0000
Subject: [Koha-bugs] [Bug 10948] Some strings in the authority result list
 turned out untranslatable
In-Reply-To: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10948-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10948-70-VN3LdrJ5Rx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10948

--- Comment #9 from Nu?o L?pez Ans?tegui <nunyo at masmedios.com> ---
(In reply to Tom?s Cohen Arazi from comment #8)
> I'd like to note that bug 10691 fixes this for the staff interface also.

I thought too, however in staff interface there isn't such problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:02:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:02:03 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-qJMGHgaZOB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #10 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:02:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:02:56 +0000
Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from'
 labels occurences
In-Reply-To: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10987-70-F5sa0QfuVD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:03:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:03:25 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-ovFg3aYpes@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-03
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:08:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:08:00 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-P4gKFkVHCM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Fr?d?ric Demians from comment #4)
> > It's sad only the 1996 version is online in html.
> 
> Imagine a community of librarians managing collaboratively an up-to-date
> UNIMARC documentation, for free, for freedom... Hey, isn't IFLA supposed to
> do that?

I will volunteer for the next meeting in Lyon. The only way to attend the
meeting without paying a BIG contribution...

> 
> > But do you think it would be possible for french ppl version to have link to
> > the french version of the manual on BNF website?
> > http://www.bnf.fr/fr/professionnels/anx_formats/a.
> > unimarc_manuel_format_bibliographique.html
> 
> +1
> 
> But I can't find direct link to UNIMARC specific tag documentation.

Table of contents on the page I gave
Maybe the links are not made the same way
But it seems to be
http://multimedia.bnf.fr/unimarcb_trad/B022-6-2010.pdf
http://multimedia.bnf.fr/unimarcb_trad/B127-6-2010.pdf
http://multimedia.bnf.fr/unimarcb_trad/B304-6-2010.pdf

But for some tags there is no links, only information about the "bloc"
ex : 440 Devient
441 Devient partiellement
442 Remplac? par
443 Remplac? partiellement par
444 Absorb? par
Only info about the block : http://www.bnf.fr/documents/B4XX-6-2010.pdf


Sadly, for authorities, there is only a big pdf in french 
http://www.bnf.fr/documents/UnimarcA.pdf

> 
> > Or maybe to the version of ABES network (used by french academic libraries,
> > but some details are only on BNF website...)
> > http://documentation.abes.fr/sudoc/formats/unmb/index.htm
> 
> Direct links are available. It could work. IFLA documentation was selected
> by default, and since it is obsoleting, we could switch to ABES
> documentation without damage. Dont' you think ABES will require specific
> authorisation to link to their web site. Would you mind asking them?


But the Methodological Guide has been "opened" 2/3 years ago. Before it was
accessible only with authentification.
They put it on licence CC (BY NC SA), so I suppose they won't object if links
are made to it.
http://documentation.abes.fr/sudoc/formats/unmb/index.htm
But we could ask to be sure.




> 
> But such an enhencement must be the object of another bug report. In the
> meantime, my patch is a just a quick fix to an annoying bug, which can
> easily be signed-off...



Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 09:17:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 07:17:45 +0000
Subject: [Koha-bugs] [Bug 10988] New: Allow login via Google OAuth2
Message-ID: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

            Bug ID: 10988
           Summary: Allow login via Google OAuth2
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: vanoudt at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Created attachment 21740
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21740&action=edit
oauth login helper

Here at PBC, we use google apps for education to provide email for our
students, and also koha for our library systems. Although we synchronise our
koha accounts and google accounts, it would be much nicer for patrons to be
able to simply login using OAuth2.

I'm working on getting this going, basing my work on bug 9587.

More details to come - but wanted to get this bug set up and start getting
advice from the Koha experts.

As it currently stands, the oauth2 authentication is working perfectly - on
https. (Switching between the two causes issues with the cookies, as one would
expect).

opac/svc/oauthlogin handles all of the oauth2 magic. Opening this page will log
you in.

There is LOTS of room for improvement in the oauth2 login... mostly because
perl is not my weapon of choice. More obviously:

1. the clientid, clientsecret need to be moved systempreferences (I've stripped
ours from the attached file - these can be obtained from
https://code.google.com/apis/console and then choosing "API Access"
2. Google recommends verifying and decrypting the id_token locally, which means
caching some information and updating it daily. That would make things a lot
faster, but does add to the complication.

As was stated for the personas implementation: "The nice thing about it is, the
user doesn't have to do anything, like linking their account. As long as the
email address they are using... is the same as the one in Koha it will just
work."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:06:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:06:35 +0000
Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt
In-Reply-To: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10043-70-WikK6LVPYu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|amit.gupta at osslabs.biz      |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:31:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:31:56 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-5O0XyZ7ku6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree that the current way seems complicated, but it does more than just
control the list on the advanced search page. It also controls the BIDI
display, by telling the templates when a language is LTR or RTL. We have to see
where else it is used before changing anything here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:39:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:39:08 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-ZlbrMOBM30@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Oh, the tables also control the hierarchies for the language chooser and
multible languages en-nz, en-US, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:43:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:43:47 +0000
Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item
 referring to more parts/volumes
In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9743-70-L4lkAB3Wsj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21233|0                           |1
        is obsolete|                            |

--- Comment #22 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21741
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21741&action=edit
Bug 9743: Mandatory opac hold notes under specified conditions

Description:
Adds a new preference OPACMandatoryHoldNotes controlling when hold notes are
mandatory for opac users placing a hold.
In this initial implementation four reasons for a mandatory hold are added:
1) MARC21 300$a contains a reference to multiple volumes/parts
2) Biblio has one item (used in combination with 1)
3) UNIMARC 200$a contains the word test (for testing purposes only)
4) MARC21 leader pos 7 is collection
A new file is added to describe the use of this pref. The opac preferences form
shows a link to that file.

Test plan:
1) Enable OPACHoldNotes.
2) Enter 1&2,4 into OPACMandatoryHoldNotes (for MARC21 testing). For UNIMARC,
you could use 3.
3) Change two biblios: one with leader 7==c and one with 1 item and 300a==2 v.
For UNIMARC, you could add the word test to 200$a.
4) Place a hold in opac on these two books separately. Just verify if the hold
notes display the reason for mandatory notes. Do not place the holds. Test if
you can place a hold if the notes are empty. You should not be allowed to do
so.
5) Enable DisplayMultiPlaceHold. Place hold on both books simultaneously.
Verify
if you see both reasons for mandatory notes. Place the holds. Check them in
staff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:48:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:48:16 +0000
Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item
 referring to more parts/volumes
In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9743-70-kqZ71BlULi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21236|0                           |1
        is obsolete|                            |

--- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21742
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21742&action=edit
Bug 9743: dbrev for mandatory hold notes

Adds pref OPACMandatoryHoldNotes.

Test plan:
Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure
Optionally, run a new install to test sysprefs.sql.
Or:
Edit sysprefs.sql, leave at least the last few lines including the new one.
And run from command line:  mysql -p [yourdatabase] <
[your-clone]/installer/data/mysql/sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:50:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:50:05 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-dm3ZNwaU7Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #4)
> I agree that the current way seems complicated, but it does more than just
> control the list on the advanced search page. It also controls the BIDI
> display, by telling the templates when a language is LTR or RTL. We have to
> see where else it is used before changing anything here.

That's not a problem : direction of display could be retreived automaticaly.
It depends on the kind of "script" used by the language
http://en.wikipedia.org/wiki/Right-to-left
And you can get the type of script of each language on several pages.

For ex : http://www.lexvo.org/page/iso639-3/ara use arabic (and syriac) script
(lvont:usesScript lexvo:script/Arab), whitch is written RTL.

But of course, this would be a big-work-enh.
So, the patch of Blou deserves attention ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:52:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:52:01 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-RwqqWwtmkk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #5)
> Oh, the tables also control the hierarchies for the language chooser and
> multible languages en-nz, en-US, etc.

I thinks that's not good.
The display of OPAC should be deconnected from the language of the records.
That's a completely different point.
You can have only iso 639-2 codes in records, while you can have more precise
codes in PO (fr-fr, fr-ca etc)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:57:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:57:00 +0000
Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item
 referring to more parts/volumes
In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9743-70-xLvwj6xYy4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21240|0                           |1
        is obsolete|                            |

--- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21743
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21743&action=edit
Bug 9743: Unit test for mandatory hold notes

Adds three unit tests to Reserves.t

Test plan:
Run t/db_dependent/Reserves.t.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:57:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:57:55 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-6SJimdytAf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think that's why we have 3 tables :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 11:59:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 09:59:34 +0000
Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item
 referring to more parts/volumes
In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9743-70-SzfLbAck0s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21743|0                           |1
        is obsolete|                            |

--- Comment #25 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21744
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21744&action=edit
Bug 9743: Unit test for mandatory hold notes

Adds three unit tests to Reserves.t

Test plan:
Run t/db_dependent/Reserves.t.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:01:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:01:55 +0000
Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item
 referring to more parts/volumes
In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9743-70-j417eGF727@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743

--- Comment #26 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased three patches, mainly due to new layout of opac-reserve.
Note that the design for the line with the reason for a mandatory hold note
still needs improvement. I asked Owen for a suggestion there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:03:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:03:21 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-0SpXICIFUZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
icu-config wasn't installed.
sudo apt-get install libicu-dev
icu-config --version
4.8.1.1
Zebra 2.0.44 
I was not sure how to get he yaz version, so this is what I did:
yaz-client
zversion
zversion is 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:10:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:10:45 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-TYdZXPTuSg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:10:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:10:50 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-PO3sBgd1vg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21561|0                           |1
        is obsolete|                            |
  Attachment #21562|0                           |1
        is obsolete|                            |
  Attachment #21563|0                           |1
        is obsolete|                            |
  Attachment #21564|0                           |1
        is obsolete|                            |
  Attachment #21683|0                           |1
        is obsolete|                            |

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21745
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21745&action=edit
[PASSED QA] Bug 9044: Provide item selection in record detail page (staff
client)

This patch add a column in the items table of catalogue/detail.pl that
contains checkboxes for item selection and a drop-down list of actions
that can be executed for the selection of items.
Currently available actions are:
- Delete selected items: redirect to batch items deletion
- Modify selected items: redirect to batch items modification
These actions replace the two menu entries corresponding to the same
action.
Item selection is only enabled if the new syspref
StaffDetailItemSelection is ON.
Actions are not displayed if user doesn't have the right permissions.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Further testing notes on last patch.

http://bugs.koha-community.org/show_bug.cgi?id=9055

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:12:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:12:06 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-Jrgw1UKPG7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21746
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21746&action=edit
[PASSED QA] Bug 9044 [Follow-up] Add a blank option + add missing 'for'
attributes

Signed-off-by: Pierre Angot et Leila Arkab <tredok.pierre at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:12:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:12:16 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-XuOrcECfGB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21747
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21747&action=edit
[PASSED QA] Bug 9044: QA followup

1/ Remove filter and sort for the checkboxes column.
2/ Enable the pref by default.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:12:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:12:21 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-WgKwctToNx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #8)
> I think that's why we have 3 tables :)

Mmmmm I understand now!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:13:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:13:07 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-UYrTI7wKyn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

--- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21748
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21748&action=edit
[PASSED QA] Bug 9044: Change dropdown list into links list

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
That's the one I sign.

Comment: At first I don't know where to find links, until
I selected an item.
Works as described. No koha-qa errors.

Solved merge conflict on updatedatabase.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:14:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:14:41 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-X2fRULJOJx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:14:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:14:53 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-l494mplDvl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

--- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21749
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21749&action=edit
[PASSED QA] Bug 9044: Set the number of filters according to number of columns

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Filters now shows correctly. No errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
This feature is a little controversial as it removes
the batch edit/delete options from the menu and moves them
to the item table, additionally controlled by a system
preference. Maybe later on, we can think about the UI a bit
more, but it works nicely.

Tested with.
- SeparateHoldings and SeparateHoldingsBranch activated/deactivated.
- Search filters.
- None, both, or one of the permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:16:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:16:05 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-awMPNW0B9i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21481|0                           |1
        is obsolete|                            |

--- Comment #31 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21750
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21750&action=edit
Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

Adds three tests to Reserves.t for GetReservesFromItemnumber.
We test if this routine does not return a future next available hold,
a future item level hold. And if it does return a future wait (that is:
a confirmed future hold, using ConfirmFutureHolds).

Note that Holds.t does also contains some basic tests for this routine,
but the additional tests seem to better located in the direct context of
tests for bug 9761 for ConfirmFutureHolds.

Test plan:
Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
Verify if both tests do not fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:18:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:18:11 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-JXV9NdlRIb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Not saying we should keep them - just that rewriting will need some thought put
into it. And I think this patch would be a nice enh.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:28:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:28:38 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-IVrDaSbNio@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #119 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, I wanted to come back to this but see you have set Failed QA still
- is it because of the edge case?

I think we could deal with that as a separate bug, as the behaviour is buggy on
master as well. - If that is the only problem remaining.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:43:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:43:09 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-mbrxtqscts@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #154 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
This also fixes Bug 9897 - members/member.pl double encoded utf-8 strings
so I added it to see also so we can close it once this gets into master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:50:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:50:18 +0000
Subject: [Koha-bugs] [Bug 5573] delete lists when patron deleted
In-Reply-To: <bug-5573-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5573-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5573-70-3zayrAmCJR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
To my knowledge and after checking with Marcel this is fixed in current master.
Please reopen if I am mistaken.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:56:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:56:35 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-4B2j5TQMqf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10984

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 12:56:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 10:56:35 +0000
Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent
 order is deleted
In-Reply-To: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10984-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10984-70-fpxFVxbFoi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=5336

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:03:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:03:30 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-yi9gzrc71n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:03:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:03:35 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-iLo59ZihGw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21689|0                           |1
        is obsolete|                            |
  Attachment #21690|0                           |1
        is obsolete|                            |
  Attachment #21691|0                           |1
        is obsolete|                            |
  Attachment #21692|0                           |1
        is obsolete|                            |
  Attachment #21693|0                           |1
        is obsolete|                            |
  Attachment #21694|0                           |1
        is obsolete|                            |
  Attachment #21707|0                           |1
        is obsolete|                            |
  Attachment #21709|0                           |1
        is obsolete|                            |

--- Comment #120 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21751&action=edit
[PASSED QA] Bug 5336:Order search (search and UI enhancements)

You can now search orders by
- order status
- fund

New field aqorders.orderstatus, it can contains following values:
  0 => New
  1 => Ordered
  2 => Partial
  3 => Complete
  4 => Deleted

To test: Search and check if results are consistent in histsearch.pl
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Comments on last patch.
Note: status are no longer numeric, but strings now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:03:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:03:47 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-i2oOonU3rG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #121 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21752&action=edit
[PASSED QA] Bug 5336: Late orders search: don't display deleted order.

Test plan:
Check that deleted orders are not listed in the late orders search
results.
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:03:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:03:56 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-DYpl7OuUad@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #122 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21753&action=edit
[PASSED QA] Bug 5336: Merge parent ordernumber and ordernumber columns
Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:04:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:04:07 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-EPRMtybeHC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #123 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21754&action=edit
[PASSED QA] Bug 5336: Add unit tests for 3 acq routines

Unit tests In C4::Acquisition for:
- CloseBasket
- ReopenBasket
- GetBiblioCountByBasketno

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>
Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:04:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:04:20 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-3avCIJGFQB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #124 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21755&action=edit
[PASSED QA] Bug 5336: QA followup

- fix capitalization
- fix update database message

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:04:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:04:30 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-dPEwwRfwBD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #125 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21756&action=edit
[PASSED QA] Bug 5336: Change numbers with understandable codes for orderstatus

This patch uses understandable codes instead of magical numbers for the
aqorders.orderstatus field.

+ execute sql queries in unit tests into a transaction.

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:04:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:04:42 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-7bnNm4wUWC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #126 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21757&action=edit
[PASSED QA] Bug 5336: FIX: partial status was not correctly set

An order (o1) is considered as partially received if (at least) another
order (o2) has the o1.ordernumber == o2.parent_ordernumber and the
quantity received is < to the quantity (to receive) and o1.ordernumber
!= o1.parent_ordernumber.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:04:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:04:52 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-9OfnITbQcl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #127 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21758&action=edit
[PASSED QA] Bug 5336: Multiple QA fixes

- add a message if the search returns no result
- keep selected values if the search returns no result (for fund and
  order status)
- remove plurals in order status
- move the order status column in the search results table

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
New tests also pass:
    t/db_dependent/Acquisition/close_reopen_basket.t

1) Database update - I end up with too many partials. My test cases:

 - New orders, basket still open
   OK Expected: new, Result: partial
 - Ordered orders, basket and basketgroup closed
   OK Expected: ordered, Result: partial
 - Partially received orders
   OK Expected: partial/complete, Result: partial/complete
 - Received orders
   OK: Expected: complete, Result: complete
 - Cancelled orders
   * cancelled from open basket before order
   OK: Expected: cancelled, Result: cancelled
   * cancelled from closed basket before receive
   OK: Expected: cancelled, Result: cancelled

All aqorders where updated with the correct status.

I have saved my 'pre-updatedatabase' and can repeat the test anytime you have a
follow up.

2) Testing search functionality

  a) Order search - result list
  Order search shows a new column, I think it would be a bit better if the
  status there was singular instead of plural - new order, partially received
  order etc. - maybe we could even leave out the 'order'? (minor)

  The column seems a bit lost in the middle, not sure where it would make more
  sense (just saying)

  b) Order search - advanced search form
  The advanced search form now shows a new filter: Order status

  All new status can be searched.
  - an "empty" search will find all but cancelled orders
  - searching for cancelled orders works correctly and shows results
  Search works correctly, no regressions found.

  If no result is found a message is shown.
  All search input is kept, so you can modify your search terms easily.

3) Testing setting of status after applying the patch

   a) Create a new order with 2 items - status is new. OK
   b) Close the basket - status is ordered. OK
   c) Receive both items - status is completed. OK
   d) Undo receipt - status is ordered. OK
   e) Receive only 1 item - order is split up into 2 orders:
       - status is partial OK
       - status is completed OK
   f) Undo receipt of received item - order is combined into 1 again
       - status is ordered OK!
   g) Receive only 1 item again - status ordered/partial.
   h) Delete order.
       - status is completed
       - status is cancelled
      OK!

   i) Undo receipt of 1 item again.
      Refresh page.

This results in the following behaviour, that has been reported as
bug 10984. After refreshing the page follow message is shown:
  Cannot cancel receipt. Possible reasons :
    - The order line you trying to cancel was created from a partial
    receipt of another order line which is already received.
    Try to cancel this one first and retry.
    - The order line you trying to cancel was created from a partial
    receipt of another order line which has been deleted.
    Cancellation is not possible.
  BUT: The receipt is undone, but you are left with a
    line with 2 items, a cancellation date and the status ordered.
    Because of the cancellation date the order is not visible in pending
orders.

The status is correct - so I feel this should not stop this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:05:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:05:56 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-qKkH2d4rt7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #128 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, guess it's ok that I retested, but please let me know if I missed
something :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:06:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:06:20 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-9Rqud1sB6P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #155 from Ketan Kulkarni <ketan at carvingit.com> ---
Hello Tom?s,

Yes, we should move from utf8::encode/decode to Encode::
This particular bug (6554) is about double encoding that happens in
Templates.pm.
I guess we should treat 10068 as a separate thing. It is linked for sure with
the same issue. However, it's more about encoding. This one deals with
decoding. 

Ketan


(In reply to Tom?s Cohen Arazi from comment #153)
> I marked 10068 as 'see also', not because of the patches, but to mention the
> first comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:47:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:47:41 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-ACvVaE5ScP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #15 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #14)
> icu-config wasn't installed.
> sudo apt-get install libicu-dev
> icu-config --version
> 4.8.1.1
> Zebra 2.0.44 
> I was not sure how to get he yaz version, so this is what I did:
> yaz-client
> zversion
> zversion is 3

I suspect its the bounds checking bug in zebra fixed in 2.0.51. I'll try
building an older version to confirm

Here's the zebra changelog:
--- 2.0.51 2012/05/31

Fix buffer overrun for terms using ICU normalization.

Increase max size of indexing term from 256 to 512.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:48:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:48:12 +0000
Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull'
	notices
In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8352-70-awbfe0hRlQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think I like the idea to have a separate printing queue. Here in Germany we
have big libraries with closed stacks with multiple areas and printers. It
looks to me like using printers this feature would be easier extendable in the
future?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:59:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:59:23 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-K7PgZZzVd2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19086|0                           |1
        is obsolete|                            |

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21759&action=edit
Bug 9468 - Add ability to hide items from purchase suggestions forms

Test Plan:
1) Apply patch
2) Run updatedatabase.pl
3) Add some itemtypes to the new system pref SuggestionsHideItemTypes
4) Make a purchase suggestion
5) Verify those item types set in SuggestionsHideItemTypes do not appear
   in the pulldown menu for "Item type"

Signed-off-by: Frederic Durand <frederic.durand at unilim.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 13:59:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 11:59:40 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-MlD0YUxNCJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #11 from Blou <philippe.blouin at inlibro.com> ---
(In reply to Katrin Fischer from comment #10)
> Not saying we should keep them - just that rewriting will need some thought
> put into it. And I think this patch would be a nice enh.

Well, am I glad I made sure to not impact anything else.  I was first wondering
if "just removing the language entries from a table would do it for the
libraries", but then I saw the JOIN on the tables involved and decided not to
touch it.  

If the language features have reached maturity, then it might be a good time to
start thinking about refactoring it safely, now that all the pieces can be
considered.  But the solution doesn't necessarily involve touching the tables
if it is all nicely hidden behind a single and clear API.  And as they say :
"if ain't broke, don't mess it" :)

Btw, only the installer and the advanced search used the getAllLanguages
function.

Thanks for the discussion, that's very good source of information to me.

Blou

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:08:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:08:29 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-YMwyka7PN6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #12 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Blou from comment #11)
> (In reply to Katrin Fischer from comment #10)
> > Not saying we should keep them - just that rewriting will need some thought
> > put into it. And I think this patch would be a nice enh.
> 
> Well, am I glad I made sure to not impact anything else.  I was first
> wondering if "just removing the language entries from a table would do it
> for the libraries", but then I saw the JOIN on the tables involved and
> decided not to touch it.  
> 
> If the language features have reached maturity, then it might be a good time
> to start thinking about refactoring it safely, now that all the pieces can
> be considered.  But the solution doesn't necessarily involve touching the
> tables if it is all nicely hidden behind a single and clear API.  And as
> they say : "if ain't broke, don't mess it" :)


Maybe we could fill the tables with all the 639-2 codes, and use your syspref
not for overriding the table, but for picking up in it the codes we want to
display in the dropdown list (and the order of the codes in the syspref would
alter the order of the list)?
If so, the syspref could have a defaut value the list of the codes currently
displayed.
That assume that all records are using iso 639-2, while technically it is not
the case for MARC21 records. But Koha is currently not making distinction
between iso 639-2 and MARC21 codes, so it could be a future enh.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:13:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:13:47 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-1trspIC5Mk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #13 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I forgot to mention that in France we use an authorized value "LANG" with all
the iso 639-2 codes for "translating" the UNIMARC 101a field.
This is not really good, because if we swich our OPAC in english or spanish,
the codes are still translated in the french name of the language.

I don't know how it is done in MARC21. But for me one of the goal of a future
enh could make the use of this authorized value obsolete.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:19:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:19:01 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-Hcm3g1vdsJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:19:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:19:05 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-Gz3zuPx0eV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21760
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21760&action=edit
Bug 9468 - Add ability to hide itemtypes from purchase suggestions forms - QA
Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:22:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:22:21 +0000
Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase
 suggestions forms
In-Reply-To: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9468-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9468-70-CdqsZ0TynZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
> 1/ The syspref is created for OPAC but affect the intranet too : the
> C4::Koha::GetSupportList routine is used in suggestion/suggestion.pl.
Fixed!

> 2/ For the moment, this routine is only used in suggestions page, but could
> be used for something else, don't you think?
> 3/ Moreover it seems this routine is buggy. It does not deal with the
> multivalued AdvancedSearchTypes values (maybe I'm wrong).
I don't really no, but that would be beyond the scope of this bug.

> 4/ If the pref is equal to "ccode", don't we want to hide them too?
This is also beyond the scope of this bug. I future patch could extend this to
ccodes and locations too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:26:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:26:08 +0000
Subject: [Koha-bugs] [Bug 10989] New: titles of suggestions are truncated
Message-ID: <bug-10989-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10989

            Bug ID: 10989
           Summary: titles of suggestions are truncated
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

Sometimes, titles of suggestions are truncated.
I suppose the field in database is too small.

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:35:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:35:38 +0000
Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless
In-Reply-To: <bug-10927-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10927-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10927-70-efntEgRjWS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:35:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:35:40 +0000
Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless
In-Reply-To: <bug-10927-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10927-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10927-70-jLvSHMJU6u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21426|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21761&action=edit
Bug 10927: C4::Utils is unused

Bug 10925 removes the last call to C4::Utils.
The module becomes useless and can be deleted.

Verify that t/db_dependent/Context.t still successfully passes.
git grep hashdump
git grep maxwidth

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl, no subs from the module are used anywhere

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 14:59:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 12:59:04 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-TBF9iLJZno@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #156 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
I think that for this to pass QA and eventually been pushed we need a test plan

1) A way to check what error this patch is trying to fix, i.e. how and where to
look encoding problems (add sample record/data)
2) How it's fixed

In it's current incarnation this is a simple patch, but it's not clear how to
test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 15:31:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 13:31:31 +0000
Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority
	searching
In-Reply-To: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10096-70-cRVSlhU6d0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21611|0                           |1
        is obsolete|                            |

--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21762&action=edit
Bug 10096 - Add a Z39.50 interface for authority searching

This patch introduces a new Z39.50 interface for searching z39.50
compliant databases for MARC authority records.

These databases aren't as common as their bibliographic equivalents,
but they're out there and very useful. I have included info at the
bottom of this messsage for sample authority databases you can try.

To test this patch:

1) Set up Z39.50 client targets for authority databases. (I've included
information at the bottom of this message for LibrariesAustralia's
test server for authorities as well as instructions on how to use
your Koha's z39.50 authority server as well. The Library of Congress
also has authority databases available (unsure if these are test or
prod), and you might have access to others through OCLC or RLIN. OCLC
provides login credentials for their test databases.

2) Go to the Authorities module

3) Click on the new "Z39.50 search button"

4) Select your authoriy search targets from the list (N.B. bibliographic
targets will also display. These are of no use to you.)

5) Do a search for an authority you would like using either the "Raw"
input box or the more specific input boxes for names, subjects, subject
sub divisions, or titles. (I like searching Name (personal): Eric on
the LibrariesAustralia test DB.)

6) You should see a table listing the server, heading, authority type,
and two other columns (MARC and a nameless column). "Authority type"
is the type of authority it will become when imported in to Koha. In
the Eric example, "PERSO_NAME".

7) Click on "MARC" next to the results of interest to review the MARC
authority record.

8) When you're satisfied with a record, click on "Import".

9) The pop-up window will close and your original Koha window will
change to the "Adding authority Personal Name" screen (in the Eric
example).

10) All the relevant fields should be filled out for the record. Review
them and make any changes as necessary. (N.B. The 001 will be cleared
when saved, so if you have a use for the imported control number, move
it to the 010, 016, or 035 as appropriate. If you have a default value
for the 003, this will also likely be overwritten. Move it if necessary.
The 005 will also be updated when saved, so do not worry about that.)

11) When you're satisfied, click save.

12) Presto! You've imported your first authority record via Z39.50!

--

Here is the info for the LibrariesAustralia test Z39.50 authority
database:

Z39.50 server: LibrariesAustralia Authorities
Hostname: z3950-test.librariesaustralia.nla.gov.au
Port: 210
Database: AuthTraining
Userid: ANLEZ
Password: z39.50
Syntax: MARC21/USMARC
Encoding: utf8

-

The U.S.A. Library of Congress also provides Z39.50 access to its Name
and Subject Authorities (http://www.loc.gov/z3950/lcserver.html).

Name Authority:
Z39.50 server: Library of Congress Name Authority File
Hostname: lx2.loc.gov
Port: 210
Database: NAF
Syntax: MARC21/USMARC
Encoding: utf8

Subject Authority:
Z39.50 server: Library of Congress Subject Authority File
Hostname: lx2.loc.gov
Port: 210
Database: SAF
Syntax: MARC21/USMARC
Encoding: utf8

(N.B. Both of these databases also include title authorities.)

-

For testing purposes, you can also set up a Z39.50 client target,
which points at your own Koha instance's Z39.50 authority server.

To find the hostname, go to /etc/koha-conf.xml and find the value for
the <listen id="authorityserver"> element. Depending on your
configuration, this could be something like the following:

unix:/zebra/koha/var/run/zebradb/authoritysocket

(N.B. You might be using a different scheme than unix sockets...)

To find the database, scroll down to the bottom of koha-conf.xml until
you reach the <config> element. Within this, look for the value of the
element <authorityserver>. It should probably be "authorities".

To set up this Z39.50 client target in Koha...

Z39.50 server: my koha authorities
Hostname: unix:/zebra/koha/var/run/zebradb/authoritysocket
Port:
Database: authorities
Userid:
Password:
Syntax: MARC21/USMARC (or whichever flavour you need)
Encoding: utf8

Signed-off-by: Mason James <mtj at kohaaloha.com>

Bug 10096 [FOLLOW-UP] - Add a z39.50 interface for authority searching

This patch adds the "recordtype" column to the "z3950servers" table.

The value in this column (biblio or authority) then controls whether
the z3950 server shows up in a bibliographic search (through the
Acq and Cataloguing modules) or in an authority search (through
the Authorities module).

I also edited the z3950 management console to show this value
and allow users to edit it. The default value is "biblio", since
the vast majority of z3950 targets will be bibliographic. However,
there is an option to add/edit a z3950 target as a source of
authority records.

Test Plan:

1) Apply both patches
2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5
environmental variables)
3) Use the test plan from the 1st patch

N.B. Make sure that your Z39.50 client target has a Record Type
of Authority, otherwise it won't display when you're doing a
Z3950 search for authorities.

Signed-off-by: Mason James <mtj at kohaaloha.com>

Bug 10096 [FOLLOW-UP] - fix tabs/whitespace errors to pass QA

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 15:31:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 13:31:45 +0000
Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority
	searching
In-Reply-To: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10096-70-Si9pQUmG7D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 15:31:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 13:31:48 +0000
Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority
	searching
In-Reply-To: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10096-70-lwawz3RFPE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21612|0                           |1
        is obsolete|                            |

--- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21763
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21763&action=edit
Bug 10096 - [FOLLOW-UP] QA Improvements

0) Run updatedatabase.pl (to add "recordtype" to the z3950servers table.

1) Set up Z39.50 client targets for authority databases. (I've included
information at the bottom of this message for LibrariesAustralia's
test server for authorities as well as instructions on how to use
your Koha's z39.50 authority server as well. The Library of Congress
also has authority databases available (unsure if these are test or
prod), and you might have access to others through OCLC or RLIN. OCLC
provides login credentials for their test databases.

N.B. Make sure that your Z39.50 client target has a Record Type
of Authority, otherwise it won't display when you're doing a
Z3950 search for authorities.

2) Go to the Authorities module

3) Click on the new "Z39.50 search button"

4) Select your authority search targets from the list

5) Do a search for an authority you would like using either the "Keyword"
input box or the more specific input boxes for names, subjects, subject
sub divisions, or titles. (I like searching Author (personal): Eric on
the LibrariesAustralia test DB.)

6) You should see a table listing the server, heading, authority type,
and two other columns (MARC and a nameless column). "Authority type"
is the type of authority it will become when imported in to Koha. In
the Eric example, "PERSO_NAME".

7) Click on "MARC" next to the results of interest to review the MARC
authority record.

8) When you're satisfied with a record, click on "Import".

9) The pop-up window will close and your original Koha window will
change to the "Adding authority Personal Name" screen (in the Eric
example).

10) All the relevant fields should be filled out for the record. Review
them and make any changes as necessary. (N.B. The 001 will be cleared
when saved, so if you have a use for the imported control number, move
it to the 010, 016, or 035 as appropriate. If you have a default value
for the 003, this will also likely be overwritten. Move it if necessary.
The 005 will also be updated when saved, so do not worry about that.)

11) When you're satisfied, click save.

12) Presto! You've imported your first authority record via Z39.50!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 15:53:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 13:53:43 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-dhCdNUyRK5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:07:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:07:21 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-OAJB4snrfM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #14 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21764
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21764&action=edit
Bugs 10986 - Limit the list of languages in advanced search

In Advanced Search, the list of available language is long and will only get
longer.  For a library offering books in 2-3 languages, that is offering too
much info to the user (most of the small libraries we deal with only offer
documents in two languages).

Code changes:
Languages.pm: Extract getAllLanguages to make a more customizable getLanguages
(have getAllLanguage call it, so rest of codebase is oblivious to the change). 
Build array returned based on system pref if corresponding argument is set.
search.pl and opac-search.pl: call getLanguages instead of getAllLanguages.

TESTING
0) All language codes are iso 639-2 (three characters)
1) in OPAC, Advanced search, open Language box, acknowledge 30+ items.
2) in Intranet, go to system preferences AdvancedSearchLanguages, enter
"ita|eng"
3) back in OPAC, refresh screen, acknowledge only Italian and English are
listed.
4) in Intranet, click Search then click "More options" to make the Language box
appear.  Acknowledge limited options.
5) Regression Test: Back to the preference, empty the field then save.  Go back
to the OPAC and Intranet search, refresh the page, then the Language drop-box
will now contain 30+ items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:13:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:13:59 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-dwLRLGLYJr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20297|0                           |1
        is obsolete|                            |

--- Comment #35 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21765
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21765&action=edit
[SIGNED-OFF] Bug 10419: FIX hardcoded records and pod

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Missing a sign. Removes harcoded values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:14:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:14:22 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-LiWeLkV8Cq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Does it obsolete your first patch? If so, you can change the status of the 1st
patch (Details > Edit details > obsolete)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:14:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:14:50 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-qwG73EXdFq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21765|0                           |1
        is obsolete|                            |

--- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21766
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21766&action=edit
[SIGNED-OFF] Bug 10419: Patrons with fines should not be deleted

Test plan:
- add a fine for a patron
- verify the script does not delete this patron.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works, script do not delete a patron with fines.
No koha-qa errors with all patches applied

Test
1) Added a fine to a patron
2) run script
3) reports condition
Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in
fines
4) Patron is not deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:17:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:17:37 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-NMqGjEQcN6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21766|0                           |1
        is obsolete|                            |
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:17:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:17:46 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-1eDxrLtlVm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:17:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:17:51 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-TCL7BuDMzn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21625|0                           |1
        is obsolete|                            |

--- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21767
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21767&action=edit
bug_9611: Extracted checkpw_internal() and checkpw_hash() from checkpw()

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:18:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:18:06 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-Jv1JQ47zf0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20297|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:18:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:18:51 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-uEsFGthxRe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #37 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
sorry, made a mistake, re-uploading patches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:18:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:18:54 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-9KBFwQYPMA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #77 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, I think I was able to fix the conflict - It was removing C4::Utils
that has gone into master very recently.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:19:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:19:52 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-EbIBUx9ifg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #78 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, but i messed up attaching the rebased patch, trying again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:21:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:21:19 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-1XQPjdMejc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21621|0                           |1
        is obsolete|                            |
  Attachment #21622|0                           |1
        is obsolete|                            |
  Attachment #21623|0                           |1
        is obsolete|                            |
  Attachment #21624|0                           |1
        is obsolete|                            |
  Attachment #21626|0                           |1
        is obsolete|                            |
  Attachment #21627|0                           |1
        is obsolete|                            |
  Attachment #21628|0                           |1
        is obsolete|                            |
  Attachment #21767|0                           |1
        is obsolete|                            |

--- Comment #79 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21768
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21768&action=edit
Bug 9611: add Crypt::Eksblowfish::Bcrypt to list of Perl dependencies

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:21:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:21:34 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-vgz91kNh1s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #80 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21769
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21769&action=edit
Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt

What this patch aims to accomplish?

 * All new passwords are stored as Bcrypt-hashes
 * For password verification:
     - If the user was created before this patch was applied then use
        MD5 to hash the entered password <-- backwards compatibility
     - If the user was created after this patch was applied then use
       Bcrypt to hash the entered password
 * Any password change made via the staff interface or the OPAC will
   be automatically Bcrypt-hashed; this applies to old users whose
   passwords were stored as MD5 hashes previously

Test plan:
  1) Add new users and check whether their passwords are stored as
     Bcrypt hashes or not.
  2) To test that authentication works for both old as well as new
     users:
       a) Login as an existing user whose password is stored as a
          MD5 hash
       b) Login as an existing user whose password is stored as a
          Bcrypt hash
  3) In the staff interface, change the password of an existing user
     whose password is stored as an MD5 hash
    a) Check the new password is stored as a Bcrypt-hash in the database
    b) Try to login with the new password
  4) In the OPAC, verify that
    a) Old user with old pass can change password, new format
    b) New user with new pass can change password
    c) Old and new user with self-updated pass can login

Whitespace cleanup was contributed by  Bernardo Gonzalez Kriegel.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:21:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:21:44 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-22wp3JqO78@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #81 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21770
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21770&action=edit
bug_9611: Extracted checkpw_internal() and checkpw_hash() from checkpw()

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:21:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:21:53 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-RZYjWKdUko@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #82 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21771
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21771&action=edit
bug_9611: removed md5_base64 from imports - not used

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:22:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:22:05 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-s87XNQjTDj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #83 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21772
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21772&action=edit
bug_9611: use hash_password() and checkpw_* instead of md5 hash

Test:

* LDAP:
- Turn on LDAP auth in koha-config.xml. Sset "update" in your server config to
1
- Change user's password on LDAP
- Login to Koha using LDAP - Koha password should be updated, to check
- Turn off LDAP auth in koha-config.xml
- You should be ble to log in with the new password

I do not have a LDAP facility, so I cheated. I ran
perl -e 'use C4::Auth_with_ldap;
C4::Auth_with_ldap::_do_changepassword("srdjan", 1000022259, "srdjan");'
and was able to change the password.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described.

Test
1) change <useldapserver> to 1
2) copy/paste sample <ldapserver> config from perldoc C4/Auth_with_ldap
3) using sample script was able to change password,
use (userid, borrowernumber, newpass) as arguments
4) checked with OPAC and in database

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:22:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:22:09 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-e8FFVDG7gF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20297|0                           |1
        is obsolete|                            |

--- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21773
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21773&action=edit
[SIGNED-OFF] Bug 10419: FIX hardcoded records and pod

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Missing a sign. Removes harcoded values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:22:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:22:22 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-7g1V2LpCKx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21658|0                           |1
        is obsolete|                            |

--- Comment #39 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21774
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21774&action=edit
[SIGNED-OFF] Bug 10419: Patrons with fines should not be deleted

Test plan:
- add a fine for a patron
- verify the script does not delete this patron.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works, script do not delete a patron with fines.
No koha-qa errors with all patches applied

Test
1) Added a fine to a patron
2) run script
3) reports condition
Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in
fines
4) Patron is not deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:22:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:22:23 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-fkfz3uhJ5R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21775
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21775&action=edit
bug_9611: use checkpw_hash() instead of md5 hash

Test:

* SIP: Have an old user and create a new user
- use either tenet sip test or
  C4/SIP/interactive_patron_check_password.pl to check old
  userid/password
- do the same for the new user

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described

Test
1) using perl C4/SIP/interactive_patron_check_password.pl
can check current (short) and new (long) passwords

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:22:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:22:33 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-HtLn8icgpI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #85 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21776
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21776&action=edit
Bug 9611: Database update, changing password from varchar(30) to varchar(60)

This is necessary because Bcrypt hashes are longer than MD5 hashes.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:22:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:22:47 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-GqAUzJCGil@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #86 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21777
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21777&action=edit
Bug 9611 - followup to fix POD

Small patch to make koha-qa happy.
Fixes small POD error

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:23:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:23:04 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-sEpBX0TnEh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:24:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:24:58 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-7ybWm9QApV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #87 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The conflict was in  bug_9611: use hash_password() and checkpw_* instead of md5
hash at the very beginning. I think it was caused by this very recent change:
http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=C4/Auth_with_ldap.pm;h=0efeb95dca806015fbcbc9f05e7227a9d93138a3;hp=d7a5e9a3cfe588359e2cee593b939fdd00c8900c;hb=561107bb5b348eaa14054e3470f39ff9cf080d22;hpb=7e3f8e0838584a89f3fbdce8e956880de8556d7a

Hoping it's ok :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:26:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:26:38 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-NAp5mMFdBZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21764|0                           |1
        is obsolete|                            |

--- Comment #16 from Blou <philippe.blouin at inlibro.com> ---
Comment on attachment 21764
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21764
Bugs 10986 - Limit the list of languages in advanced search

This new patch is exactly the same as the previous one.  It should not have
been attached, I apologize for the confusion.  I was trying to get my git-bz to
work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 16:58:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 14:58:36 +0000
Subject: [Koha-bugs] [Bug 10927] C4::Utils becomes useless
In-Reply-To: <bug-10927-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10927-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10927-70-1b9VPdFoCM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10927

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #17 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:08:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:08:08 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-tN6bAnhw7K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21045|0                           |1
        is obsolete|                            |

--- Comment #16 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 21778
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21778&action=edit
Amended Patch

One character change to icu-phrases.xml changes tokenize rule from s to l
(wgich matches the values in icu-words.xml. This seems to avoid the buffer
overrun in zebra versions before 2.0.50

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:09:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:09:57 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-Mu6kQzYlIl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:19:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:19:21 +0000
Subject: [Koha-bugs] [Bug 118] searching
In-Reply-To: <bug-118-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-118-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-118-70-ecg55uGPWx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=118

Muhammad Tufail Khan <mtufail440 at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtufail440 at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:21:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:21:13 +0000
Subject: [Koha-bugs] [Bug 10990] New: Urdu searching not gives exact result
Message-ID: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10990

            Bug ID: 10990
           Summary: Urdu searching not gives exact result
 Change sponsored?: ---
           Product: Koha
           Version: 3.8
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mtufail440 at hotmail.com
        QA Contact: testopia at bugs.koha-community.org

I am checking urdu books searching through urdu keyboard it not gives exact
result. you may visit my system OPAC on below address: 113.197.55.2 


Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:24:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:24:31 +0000
Subject: [Koha-bugs] [Bug 10990] Urdu searching not gives exact result
In-Reply-To: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10990-70-XqSVZQboI4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WONTFIX

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Muhammed, did you turn on ICU for indexing? If you have non-latin scripts it's
required to make search work right. 

I am resolving this won't fix - as I think it's a configuration issue, that is
better solved on the mailing list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:24:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:24:37 +0000
Subject: [Koha-bugs] [Bug 10990] Urdu searching not gives exact result
In-Reply-To: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10990-70-EuwV92ixnW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10990

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:27:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:27:24 +0000
Subject: [Koha-bugs] [Bug 10990] Urdu searching not gives exact result
In-Reply-To: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10990-70-EgjHteAMWk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10990

--- Comment #2 from Muhammad Tufail Khan <mtufail440 at hotmail.com> ---
you may visit my link 113.197.55.2 and search word "??????" so it display
unknown results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:31:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:31:00 +0000
Subject: [Koha-bugs] [Bug 10990] Urdu searching not gives exact result
In-Reply-To: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10990-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10990-70-H5rckjAKGc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10990

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
That's normally a sign ICU has not been used, it's a configuration option you
have to choose when running the installer - there is some information on the
wiki:
http://wiki.koha-community.org/wiki/Correcting_Search_of_Arabic_records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:43:55 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-KsdYGsNAFE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21710|0                           |1
        is obsolete|                            |

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21779
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21779&action=edit
[SIGNED-OFF] Bug 10982 Link to IFLA UNIMARC documentation in Cataloging

In Cataloging, a ? documentation page on IFLA web site. The current
implementation rely on the tag tab to select the appropriate IFLA
documentation web page. It doesn't work when UNIMARC tag are displayed
in a tab which digit is different for tag first digit.

To reproduce the bug:

  - Modify default framework, put all 200 subfields in tab 1
  - Add a new biblio record
  - Click on ? on 200 field
   => Wrong IFLA page is opened

Apply the patch and retry...

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Simple fix. Work as described. No koha-qa errors

Test on UNIMARC install
1) Switched all 2xx tags to tab 1
2) press any 2xx ?, wrong page
3) patch applied
4) links are now correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:51:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:51:38 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-k83A7BmeXJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 17:55:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 15:55:57 +0000
Subject: [Koha-bugs] [Bug 10958] no need for home link on home page
In-Reply-To: <bug-10958-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10958-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10958-70-LQUzBHdjXg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
Well that works for now :) But I do think that link should be removed for real
(not just with js).

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:00:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:00:24 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-4n57pg2R0n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:00:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:00:28 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-5V7jUQrfeK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20133|0                           |1
        is obsolete|                            |
  Attachment #20134|0                           |1
        is obsolete|                            |
  Attachment #20135|0                           |1
        is obsolete|                            |
  Attachment #20294|0                           |1
        is obsolete|                            |
  Attachment #20295|0                           |1
        is obsolete|                            |
  Attachment #20296|0                           |1
        is obsolete|                            |
  Attachment #21773|0                           |1
        is obsolete|                            |
  Attachment #21774|0                           |1
        is obsolete|                            |

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21780
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21780&action=edit
[PASSED QA] Bug 10419: new cronjob for deleting patrons

This patch provides a cronjob script for deleting patrons.

It takes 3 options:

--not_borrowed_since
--expired_date
--category_code

See the perldoc misc/cronjobs/delete_patrons.pl.
Use the -v flag for a verbose mode.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.

http://bugs.koha-community.org/show_bug.cgi?id=10219

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:00:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:00:43 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-sUF5ub41Qa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21781
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21781&action=edit
[PASSED QA] Bug 10419: (followup) - tidy up cronjob for deleting patrons

This followup adds:
- execute flag (+x) for the cronjob script.
- replaces --dry-run with --confirm (according with existing scripts).
- changes output text (remove 'first person' style).
- updates the doc and simplifies the dates parameters.
- changes flags PrintError and RaiseError for the dbh in order to catch
  something if an error occurs...

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:00:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:00:52 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-rWLvmvPfVc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21782
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21782&action=edit
[PASSED QA] Bug 10419: add branchcode parameter to patron deletion script

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:01:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:01:00 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-Iz3JHQrbJY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21783
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21783&action=edit
[PASSED QA] Bug 10419: (followup) fix license statement

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:01:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:01:10 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-L0iLtXxbl5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21784
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21784&action=edit
[PASSED QA] Bug 10419: (follow-up) tidy names of command-line switches

[1] Use --library instead of --branchcode to be consistent
    with other scripts and user-facing Koha terminology.
[2] Use --not_borrowed_since instead of --not_borrowered_since;
    no need to expose typos in the API to the user.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:01:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:01:18 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-rbmBC4Xo6v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21785
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21785&action=edit
[PASSED QA] Bug 10419: (follow-up) functional improvements

[1] Patron deletion now happens atomically; if one part
    of the process fails, the record isn't left in a
    partially deleted state.
[2] The routine for handling lists properly during patron
    deletion is now invoked.
[3] The script now prints an indication if it's run
    without --confirm; otherwise, one might think that
    patron records were actually being deleted.
[4] --verbose now actually does something.

Without --verbose, the script will print the dry-run
warning (if applicable), the number of patrons to be
deleted, and error messages.

With --verbose, the script will also print a line with
the borrowernumber of each patron to be deleted.

To test:

[1] Run the script with and without --verbose and compare
    the, well, verbosity.
[2] Run the script without --confirm and note that the script
    prints a message saying that it's running in dry-run mode.
[3] Use the script to try to delete one or more patrons that have
    loans.  Confirm that error messages are printed reporting
    foreign constraints preventing the deletion.  Also confirm that
    no new rows are added to deletedborrowers for those patrons that
    could not be completely deleted.
[4] Use the script to delete a patron that has a public list.  Verify
    that after the deletion, the public list still exists but now
    has a null owner.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:01:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:01:27 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-XFJQ4Ck59E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21786
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21786&action=edit
[PASSED QA] Bug 10419: FIX hardcoded records and pod

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Missing a sign. Removes harcoded values

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:01:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:01:39 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-tF9GzliEOx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21787
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21787&action=edit
[PASSED QA] Bug 10419: Patrons with fines should not be deleted

Test plan:
- add a fine for a patron
- verify the script does not delete this patron.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works, script do not delete a patron with fines.
No koha-qa errors with all patches applied

Test
1) Added a fine to a patron
2) run script
3) reports condition
Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in
fines
4) Patron is not deleted

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.

Tested various combinations of options:
./delete_patrons.pl
  Gives a helpful message about the use of the script.
./delete_patrons.pl -h
  Outputs useful information about the use of the script
  and its various options.
./delete_patrons.pl --category_code ST --library CPL
  Gives the correct results in numbers and deletion was done
  properly.

Also tested:
  --expired_before
  --not_borrowed_since
  -v

Testing various conditions where a delete should not occur:
- Patron has checkouts
  Patron is not in list of patrons to delete (x patrons to delete)
- Patron has fines
  Patron is still in list of patrons to delete (x patrons to delete)

Checked deleted patrons had been moved to deletedborrowers.

Notes about possible enhancements:
- only print the success message 'x patrons deleted' when confirm
  flag was set
- patrons with current checkouts are silently excluded from the number
  of patrons to be deleted. Printing the number with current checkouts
  might be helpful.

Changes made:
  Fixed a small error in the documentation: expired_date is expired_before.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:11:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:11:25 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-EwPy71cLX9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |normal

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Looks more like a bug fix to me than an enh - marking accordingly.

Changing the tab a field is displayed in is a standard feature, so
documentation links  should not break if you do it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:15:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:15:16 +0000
Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by
	category type
In-Reply-To: <bug-10796-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10796-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10796-70-eHhzNyPFSp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
         QA Contact|katrin.fischer at bsz-bw.de    |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:17:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:17:38 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-dW8KzwpzJE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Starting to test this...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:17:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:17:43 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-VNINMfXXfy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

--- Comment #8 from Fr?d?ric Demians <frederic at tamil.fr> ---
Bernardo: Thanks for testing and signing-off.

Katrin: you're correct of course, concerning the bug wording.

Mathieu: would you mind opening a new bug-enhancement with your findings about
ABES/BNF links rather than IFLA, or a proposal to HTMLize IFLA doc. It would
keep track of this discussion. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:25:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:25:52 +0000
Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC
	7XX
In-Reply-To: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9352-70-yRMgdYKfGi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15229|0                           |1
        is obsolete|                            |

--- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21788
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21788&action=edit
[PATCH 2] Bug 9352 : More specific indexing of UNIMARC 7XX fields (DOM)

little correction : add 2 lines for "index_all" in the begining and the end of
biblio-zebra-indexdefs.xsl
(biblio-zebra-indexdefs.xsl is made from biblio-koha-indexdefs.xml with
xsltproc)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:48:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:48:17 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-15j2TFbcuv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21768|0                           |1
        is obsolete|                            |

--- Comment #88 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21789
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21789&action=edit
Bug 9611: add Crypt::Eksblowfish::Bcrypt to list of Perl dependencies

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:48:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:48:27 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-EkaCbNqXZa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21769|0                           |1
        is obsolete|                            |

--- Comment #89 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21790
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21790&action=edit
Bug 9611: Change the password hashing algorithm from MD5 to Bcrypt

What this patch aims to accomplish?

 * All new passwords are stored as Bcrypt-hashes
 * For password verification:
     - If the user was created before this patch was applied then use
        MD5 to hash the entered password <-- backwards compatibility
     - If the user was created after this patch was applied then use
       Bcrypt to hash the entered password
 * Any password change made via the staff interface or the OPAC will
   be automatically Bcrypt-hashed; this applies to old users whose
   passwords were stored as MD5 hashes previously

Test plan:
  1) Add new users and check whether their passwords are stored as
     Bcrypt hashes or not.
  2) To test that authentication works for both old as well as new
     users:
       a) Login as an existing user whose password is stored as a
          MD5 hash
       b) Login as an existing user whose password is stored as a
          Bcrypt hash
  3) In the staff interface, change the password of an existing user
     whose password is stored as an MD5 hash
    a) Check the new password is stored as a Bcrypt-hash in the database
    b) Try to login with the new password
  4) In the OPAC, verify that
    a) Old user with old pass can change password, new format
    b) New user with new pass can change password
    c) Old and new user with self-updated pass can login

Whitespace cleanup was contributed by  Bernardo Gonzalez Kriegel.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:48:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:48:52 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-tqWchtQR6p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21770|0                           |1
        is obsolete|                            |

--- Comment #90 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21791
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21791&action=edit
bug_9611: Extracted checkpw_internal() and checkpw_hash() from checkpw()

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:49:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:49:13 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-OIBiIT1vHQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21772|0                           |1
        is obsolete|                            |

--- Comment #92 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21793
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21793&action=edit
bug_9611: use hash_password() and checkpw_* instead of md5 hash

Test:

* LDAP:
- Turn on LDAP auth in koha-config.xml. Sset "update" in your server config to
1
- Change user's password on LDAP
- Login to Koha using LDAP - Koha password should be updated, to check
- Turn off LDAP auth in koha-config.xml
- You should be ble to log in with the new password

I do not have a LDAP facility, so I cheated. I ran
perl -e 'use C4::Auth_with_ldap;
C4::Auth_with_ldap::_do_changepassword("srdjan", 1000022259, "srdjan");'
and was able to change the password.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described.

Test
1) change <useldapserver> to 1
2) copy/paste sample <ldapserver> config from perldoc C4/Auth_with_ldap
3) using sample script was able to change password,
use (userid, borrowernumber, newpass) as arguments
4) checked with OPAC and in database

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:49:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:49:03 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-pJI4g9o7Sa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21771|0                           |1
        is obsolete|                            |

--- Comment #91 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21792
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21792&action=edit
bug_9611: removed md5_base64 from imports - not used

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:49:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:49:23 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-kzOP6B44PI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21775|0                           |1
        is obsolete|                            |

--- Comment #93 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21794
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21794&action=edit
bug_9611: use checkpw_hash() instead of md5 hash

Test:

* SIP: Have an old user and create a new user
- use either tenet sip test or
  C4/SIP/interactive_patron_check_password.pl to check old
  userid/password
- do the same for the new user

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described

Test
1) using perl C4/SIP/interactive_patron_check_password.pl
can check current (short) and new (long) passwords

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:49:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:49:33 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-lrcbMreFoN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21776|0                           |1
        is obsolete|                            |

--- Comment #94 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21795&action=edit
Bug 9611: Database update, changing password from varchar(30) to varchar(60)

This is necessary because Bcrypt hashes are longer than MD5 hashes.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:50:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:50:09 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-7vmCzN3jNY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 18:50:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 16:50:12 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-C3bIWDdBoS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21777|0                           |1
        is obsolete|                            |

--- Comment #95 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21796&action=edit
Bug 9611 - followup to fix POD

Small patch to make koha-qa happy.
Fixes small POD error

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
All patches pass koha-qa.pl, works as advertised!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 19:10:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 17:10:09 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-HXiyhd9FLE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Posting some first testing results - unit tests is a bigger one, but it would
also be good to fix the warning in the script:

Passes all tests and QA script.

0) Database changes done by updatedatabase and in kohastructure match.

1) Patch touches core routines in C4::ImportBatch.pm , but doesn't 
provide regression tests:
- BatchCommitRecords
- BatchCommitItems
- BatchRevertRecords

2) Regression test: stage_file.pl and commit_file.pl command line scripts

Note: Adding items works as before, new options for item overlay should 
  be added to stage_file.pl later on, but we need to make sure there are 
  no regressions.

Staging file:
  ./stage_file.pl --file ../../data/Katrin-biblios.mrc --add-items --comment
"something" --match 3
Committing staged records to catalog:
  ./commit_file.pl --batch-number 2
  Produces lots of warnings, that are not there on master:
  Use of uninitialized value $bib_items_replaced in addition (+) at
/home/katrin/kohaclone/C4/ImportBatch.pm line 639.
  (minor)
Reverting bath import:
  ./commit_file.pl --revert --batch-number 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 19:12:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 17:12:15 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-pkfoiTLO1o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

--- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Ok Frederic

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 19:22:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 17:22:25 +0000
Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment
In-Reply-To: <bug-5620-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5620-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5620-70-5w1eJIhvOm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

--- Comment #3 from Eric B?gin <eric.begin at inLibro.com> ---
It would be nice if an authorized value (PAYMODE?) was used in order to add
other mode of payment

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 19:23:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 17:23:37 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-E22eM94e1U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

--- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21797&action=edit
Bug 7131 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 19:38:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 17:38:49 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-wQoAc0piTf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |eric.begin at inLibro.com
           Assignee|oleonard at myacpl.org         |eric.begin at inLibro.com
            Summary|Option to hide some         |Option to hide and group
                   |itemtypes from advanced     |itemtypes from advanced
                   |search                      |search

--- Comment #1 from Eric B?gin <eric.begin at inLibro.com> ---
Two new columns will be added in the item type.

1) Display in OPAC
Default : Yes
Set to NO to hide and itemtype in the opac's advanced search.

2) Search category
The search category allows library to group some ? similar ? itemtypes in a
single checkbox in the opac.
The categories are defined in an Authorized value.

For Example, itemtypes DVD, VHS could use the Video category.
Searching for Video in the OPAC would returns the DVD and VHS items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 21:16:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 19:16:20 +0000
Subject: [Koha-bugs] [Bug 9067] Staging an authority file gives conflicting
	messages
In-Reply-To: <bug-9067-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9067-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9067-70-IuZwieS925@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is still true for managing staged imports on current master: item options
are offered and displayed in the summary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 22:15:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 20:15:02 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-O21fYbLRz4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm there is a bug caused by this:

This is the result of importing a batch from command line without the patch. 
All numbers shown are correct.

MARC record staging report
------------------------------------
Input file:                 ../../Downloads/bib-4.utf8
Record type:                biblio
Number of input records:    1
Number of valid records:    1
Number of invalid records:  0
Number of records matched:  1
Number of items parsed:  4

And that's the result with the patch:

MARC record import report
----------------------------------------
Batch number:                    7
Number of new records added:     0
Number of records replaced:      1
Number of records ignored:       4
Number of items added:           0
Number of items ignored:         0

The number of records ignored should be the number of items ignored.

Commands used:
./stage_file.pl --file ../../Downloads/bib-4.utf8 --add-items --comment
"something" --match 3
./commit_file.pl --batch-number 8

Matching rule 3 is 001 in my database, as my records all have unique
identifiers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 22:40:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 20:40:54 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-rBkR9JCTzg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #143 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21798&action=edit
Bug 6874 - kohastructure.sql, jquery.js, refocus, and more

Two problems were discovered while doing a fresh install
of Koha. These problems in the kohastructure.sql file are
addressed with this patch.

Clicking the plug-in icon should cause the popup window
to refocus.  This adds the refocus code to the upload.pl file.

The path to the jquery.js script was wrong in the
upload_delete_file.tt file. Changed [% themelang %] to
[% interface %].

After some validation was added, it was extended to include
other cases. This serves to patch 6874 to a state where sign
off should be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 22:41:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 20:41:27 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-hhFOH5myQ7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

--- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ok, posting my complete testing notes here for reference:

Passes all tests and QA script.

0) Database changes done by updatedatabase and in kohastructure match.

1) Patch touches core routines in C4::ImportBatch.pm , but doesn't 
provide regression tests:
- BatchCommitRecords
- BatchCommitItems
- BatchRevertRecords

2) Regression test: stage_file.pl and commit_file.pl command line scripts

Note: Adding items works as before, new options for item overlay should 
  be added to stage_file.pl later on, but we need to make sure there are 
  no regressions.

Staging file:
  ./stage_file.pl --file ../../data/Katrin-biblios.mrc --add-items --comment
"something" --match 3
Committing staged records to catalog:
  ./commit_file.pl --batch-number 2
Reverting bath import:
  ./commit_file.pl --revert --batch-number 2

PROBLEM: The summaries are not correct regarding the numbe rof items  with the 
patch applied 

Without patch:
MARC record staging report
------------------------------------
Input file:                 ../../Downloads/bib-4.utf8
Record type:                biblio
Number of input records:    1
Number of valid records:    1
Number of invalid records:  0
Number of records matched:  1
Number of items parsed:  4

With patch applied:
MARC record import report
----------------------------------------
Batch number:                    7
Number of new records added:     0
Number of records replaced:      1
Number of records ignored:       4
Number of items added:           0
Number of items ignored:         0

3) Regression test: Authority import

Authority staging and importing works, no regressions found.
I noticed that item processing options are offered on the managed MARC
imports page, but this has already been reported as bug 9067.

4) Bibliographic records import

Tried different options for importing:
- Always add items.
  Still adds items, when the barcode doesn't exist in the database.
  If barcode already exists, no item is added.
- Ignore record if there is a match, but replace items.
  Record is ignored, item gets replaced.
* Delete item with the itemnumber in the import file.

PROBLEM:
- Replace incoming record on match, replace items.
  Item will not be created, but summary gives a wrong positive:
  Number of items replaced  1
  We should either create the item with a new itemnumber in that case, 
  or give a proper error message.

So 2 smaller problems, but overall it seems to work quite well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 22:42:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 20:42:39 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-xav18h9XLO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21798|0                           |1
        is obsolete|                            |

--- Comment #144 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21799&action=edit
Bug 6874 - kohastructure.sql, jquery.js, refocus, and more

Two problems were discovered while doing a fresh install
of Koha. These problems in the kohastructure.sql file are
addressed with this patch.

Clicking the plug-in icon should cause the popup window
to refocus.  This adds the refocus code to the upload.pl file.

The path to the jquery.js script was wrong in the
upload_delete_file.tt file. Changed [% themelang %] to
[% interface %].

After some validation was added, it was extended to include
other cases. This serves to patch 6874 to a state where sign
off should be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 22:43:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 20:43:29 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-o8d9JyhwNL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21546|0                           |1
        is obsolete|                            |

--- Comment #145 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21546
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21546
Bug 6874 - kohastructure.sql & jquery.js fix with refocus

squashed my patches into one on the end.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 23:00:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 21:00:19 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-eitB0tbHl0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
After talking to Galen I am setting this to passed QA, but with some
conditions:
 - Unit tests must be provided 
 - Summaries must be fixed
by the end of KohaCon to make this go in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct  3 23:42:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 21:42:03 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-ihh4PibzEe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 00:14:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 22:14:15 +0000
Subject: [Koha-bugs] [Bug 10419] There is no cronjob script for deleting
	patrons
In-Reply-To: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10419-70-EsYumJESgp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #48 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 00:39:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 22:39:01 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10402-70-VMXJZiY1cz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |bgkriegel at gmail.com

--- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
There is a problem in updatedatabase.pl
this creates the table, note selected columns (->)

    $dbh->do("CREATE TABLE aqcontacts (
        id int(11) NOT NULL auto_increment,
        name varchar(100) default NULL,
        position varchar(100) default NULL,
        phone varchar(100) default NULL,
        altphone varchar(100) default NULL,
        fax varchar(100) default NULL,
        email varchar(100) default NULL,
        notes mediumtext,
->        claimacquisition BOOLEAN NOT NULL DEFAULT 0,
->        claimissues BOOLEAN NOT NULL DEFAULT 0,
        booksellerid int(11) not NULL,
        PRIMARY KEY  (id),
        CONSTRAINT booksellerid_fk2 FOREIGN KEY (booksellerid)
            REFERENCES aqbooksellers (id) ON DELETE CASCADE ON UPDATE CASCADE
        ) ENGINE=InnoDB DEFAULT CHARSET=utf8 AUTO_INCREMENT=1;");

this try to insert into non-existent columns (->)

    $dbh->do("INSERT INTO aqcontacts (name, position, phone, altphone, fax,
            email, notes, booksellerid, -> acq_claim, -> serial_claim)

perl installer/data/mysql/updatedatabase.pl
DBD::mysql::db do failed: Unknown column 'acq_claim' in 'field list' at
installer/data/mysql/updatedatabase.pl line 7176.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 00:59:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 22:59:48 +0000
Subject: [Koha-bugs] [Bug 10991] New: C4::ImportExportFramework has
 unnecessary temporary file and directory management code
Message-ID: <bug-10991-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10991

            Bug ID: 10991
           Summary: C4::ImportExportFramework has unnecessary temporary
                    file and directory management code
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There is code in C4::ImportExportFramework that supplies alternative code if
the module File::Temp is not installed.  As File::Temp is both a core Perl
module and marked as a required dependency of Koha, that code only serves to
add unnecessary complexity to the module and (not that this is a core concern)
reduces portability to non-Unix-like platforms.

In particular, the _createTmpDir routine is unnecessary.  Removing it would
also remove a dependency on Digest::MD5.

Similarly, there's code that handles the case where File::Path is not present,
but this is also a core Perl module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 01:21:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 23:21:50 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-PFAsVfTXjC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21436|0                           |1
        is obsolete|                            |

--- Comment #146 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21800
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21800&action=edit
[SIGNED OFF] Bug 6874 - File upload in MARC - QA Followup

* Renames uploadPath to upload_path to follow the standard naming
  conventions in koha-conf which use underscores rather than camel case
* Remove reference to intranet-tmpl and replace with [% interface %]
  required to pass qa

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 01:24:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 23:24:46 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-Hl97Ybc4pD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21800|0                           |1
        is obsolete|                            |

--- Comment #147 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21801
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21801&action=edit
[SIGNED OFF] Bug 6874 - File upload in MARC - QA Followup

* Renames uploadPath to upload_path to follow the standard naming
  conventions in koha-conf which use underscores rather than camel case
* Remove reference to intranet-tmpl and replace with [% interface %]
  required to pass qa

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 01:25:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 23:25:00 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-XP3LjnkNXq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21635|0                           |1
        is obsolete|                            |

--- Comment #148 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21802
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21802&action=edit
[SIGNED OFF] Bug 6874: Force user to select a directory

This patch adds a javascript and a server-side checks

Test plan:
1/ Choose a file, leave the radios not selected and submit
2/ You have a javascript alert which prevents form to be submitted
3/ Disable javascript and repeat step 1
4/ Form is submitted but form is redisplayed with an error message
telling you to choose a directory.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 01:25:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 23:25:24 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-ZFzpAYYCVT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21799|0                           |1
        is obsolete|                            |

--- Comment #149 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21803
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21803&action=edit
Bug 6874 - kohastructure.sql, jquery.js, refocus, and more

Two problems were discovered while doing a fresh install
of Koha. These problems in the kohastructure.sql file are
addressed with this patch.

Clicking the plug-in icon should cause the popup window
to refocus.  This adds the refocus code to the upload.pl file.

The path to the jquery.js script was wrong in the
upload_delete_file.tt file. Changed [% themelang %] to
[% interface %].

After some validation was added, it was extended to include
other cases. This serves to patch 6874 to a state where sign
off should be possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 01:29:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 23:29:53 +0000
Subject: [Koha-bugs] [Bug 10992] New: Error using solr search engine
Message-ID: <bug-10992-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10992

            Bug ID: 10992
           Summary: Error using solr search engine
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mcampechano at escire.com.mx
        QA Contact: testopia at bugs.koha-community.org

I've sucessfully install a koha instance, but when i change de preferences:
searchEngine to Solr, ican't use de search and advanced search features. This
are the errors:

Can't locate opac/search.pl in @INC (@INC contains: /home/user/instalacion/lib
/usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl
/usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at
/home/user/instalacion/opac/cgi-bin/opac/opac-search.pl line 36.


Any suggestions?


I use the koha single installation on a centos 6.4 server with WHM installed

Thanks in advance!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 01:33:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 03 Oct 2013 23:33:19 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-tBe31q3S8k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #150 from M. Tompsett <mtompset at hotmail.com> ---
Test Plan for my patch:
- click plugin icon (after all the necessary configuration and setup).
No red message is given.
- Turn off javascript
- click 'Upload file'
Should get pretty red message about both things not selected.
- go through combinations of one or the other, but not both, and clicking
upload
Should get pretty red message each time with appropriate message.
- Turn on javascript
- go through combinations of none, one, and then the other, javascript alerts
should warn appropriately.
- after linking the 856$u field to a preset URL, click the plugin icon, and
delete the file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 02:01:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 00:01:09 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-eVNGrQuu2G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21524
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21524
Adding NoLoginInstructions to system preferences

Review of attachment 21524:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10951&attachment=21524)
-----------------------------------------------------------------

::: installer/data/mysql/updatedatabase.pl
@@ +7157,5 @@
>  
> +$DBversion ="3.13.00.XXX";
> +if ( CheckVersion($DBversion) ) {
> +    $dbh->do("INSERT IGNORE INTO systempreferences (variable,value,options,explanation,type) 
> +    VALUES ('NoLoginInstructions', '<h5>Don't have a password yet?</h5> <p> If you don't have a password yet, stop by the circulation desk the next time you're in the library. We'll happily set one up for you.</p> <h5>Don't have a library card?</h5> <p> If you don't have a library card, stop by your local library to sign up.  </p>', '60|10', 'Instructions when a person is not connected', 'Textarea')");

You forgot to escape the single quotes in the message and you then typed
contractions like "Don't" and "We'll" in the message. Escape the single quotes,
and this works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 02:18:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 00:18:51 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-1Xe7CDJnZq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #96 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Srikanth!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 02:24:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 00:24:05 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10402-70-YkodhMC4AL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21549|0                           |1
        is obsolete|                            |

--- Comment #39 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Created attachment 21804
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21804&action=edit
Bug 10402 follow-up: choose contacts for serials and acq claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
    > prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 02:24:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 00:24:01 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10402-70-aMQqoBSD3Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 03:15:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 01:15:54 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-DpBfiZOO6z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Mixed content warnings in   |Mixed content warnings in
                   |opac results and detail     |results and detail with
                   |with Amazon images on https |Amazon images on https

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 03:25:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 01:25:06 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-TH0P6qF8N2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #157 from Ketan Kulkarni <ketan at carvingit.com> ---
Hello,

Here's the scenario to reproduce the error condition.

* Create patron categories with non-latin characters and then perform a search
on patrons using non-latin characters.

The patch is trying to fix two things.

* Double encoding of utf8 strings. This happens in Templates.pm.
* In some places query needs to be uft8::decode'ed. I have done that to fix
problems that showed up when Templates.pm was updated.

After applying the patch, following pages need to be tested.

* Patron search - Need to see all places on the results page that may contain
non-latin characters. You need to have patron categories with non-latin
characters.
* Catalog search - Need to check places where non-latin characters appear
* Non-latin templates e.g. koha in Russian language. I think this task will
take a lot of time.

Regards,
Ketan

(In reply to Bernardo Gonzalez Kriegel from comment #156)
> I think that for this to pass QA and eventually been pushed we need a test
> plan
> 
> 1) A way to check what error this patch is trying to fix, i.e. how and where
> to look encoding problems (add sample record/data)
> 2) How it's fixed
> 
> In it's current incarnation this is a simple patch, but it's not clear how
> to test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:25 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
 'status' option switch
In-Reply-To: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10624-70-ihiIHndB1P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:25 +0000
Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in
	C4::Reserve.pm
In-Reply-To: <bug-10682-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10682-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10682-70-lGkAU3UuRa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:25 +0000
Subject: [Koha-bugs] [Bug 10733] Memcached on package installs
In-Reply-To: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10733-70-SYopKEtbRx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:26 +0000
Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the
	shelf browser
In-Reply-To: <bug-10856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10856-70-uM9AnjZuPv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:26 +0000
Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
In-Reply-To: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9739-70-6xNi8NoiuB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:26 +0000
Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for
	parameters
In-Reply-To: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10380-70-T9hI8GZWBc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:26 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-YnUclFg9uw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:27 +0000
Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17
 (September 2013)
In-Reply-To: <bug-10962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10962-70-3o3Ebwd3wX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:27 +0000
Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket
In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7295-70-bheqO5DYRA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:28 +0000
Subject: [Koha-bugs] [Bug 10853] Create CSV profiles with sql fields
In-Reply-To: <bug-10853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10853-70-H0dKsDDFFY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:28 +0000
Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in
	C4::Circulation.pm
In-Reply-To: <bug-10681-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10681-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10681-70-j4r71IeROx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:28 +0000
Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial
	claims
In-Reply-To: <bug-10854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10854-70-qmfzsM56E8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:29 +0000
Subject: [Koha-bugs] [Bug 9295] Introduce operator equal/ notequal to OAI
 set mapping instead of hardcoded 'equal' value
In-Reply-To: <bug-9295-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9295-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9295-70-b14R1GFxEP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9295

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:29 +0000
Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type
 Choice, choices being "no", "yes", "force"
In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7825-70-tyEogMik6J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:30 +0000
Subject: [Koha-bugs] [Bug 9822] No alert appears on adding an order to a
 basket if the budget has exceeded
In-Reply-To: <bug-9822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9822-70-YFrDsSm4lU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:30 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-1nWN04509x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:30 +0000
Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities
In-Reply-To: <bug-10602-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10602-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10602-70-OSa2XUaccB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:31 +0000
Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt
In-Reply-To: <bug-10403-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10403-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10403-70-tt50HX0kt0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:31 +0000
Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in
	C4::Accounts.pm
In-Reply-To: <bug-10685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10685-70-KomCg5xKcY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:31 +0000
Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be
	merged
In-Reply-To: <bug-10723-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10723-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10723-70-B4pTOS2YN2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:31 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-0VUFEol3Oy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:32 +0000
Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page
In-Reply-To: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10724-70-a952wtm6f5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:32 +0000
Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should
 undebar automatically when returned
In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2720-70-luMFm1uCId@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:33 +0000
Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results
In-Reply-To: <bug-9747-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9747-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9747-70-U7j620qzCl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:33 +0000
Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules
In-Reply-To: <bug-8044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8044-70-DkbLxFhsO2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:34 +0000
Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table
In-Reply-To: <bug-10725-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10725-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10725-70-uT75maHj75@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:34 +0000
Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority
	searching
In-Reply-To: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10096-70-1GhdhwTCHa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:36 +0000
Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any
	page
In-Reply-To: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9735-70-BucMIegZfo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:35 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-10Wvn9fa7G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:34 +0000
Subject: [Koha-bugs] [Bug 10078] show location facet for all
In-Reply-To: <bug-10078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10078-70-O2XoVdjq3s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:35 +0000
Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit
	tests
In-Reply-To: <bug-10683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10683-70-CVJibNYpi8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:36 +0000
Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips
In-Reply-To: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10365-70-kaOr7jyTxR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:36 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-gbRS2nEk7j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:37 +0000
Subject: [Koha-bugs] [Bug 8190] Add a logging module to Koha
In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8190-70-mrt8c4aQx6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:38 +0000
Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address
In-Reply-To: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5544-70-rwBRJClhmh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:39 +0000
Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
In-Reply-To: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8231-70-QH05GywdA0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:39 +0000
Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
In-Reply-To: <bug-9282-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9282-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9282-70-PFoSZAEzau@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:40 +0000
Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page
In-Reply-To: <bug-10668-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10668-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10668-70-1E1mkM8Cfv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:38 +0000
Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart
In-Reply-To: <bug-9456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9456-70-EecCUuqWpi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:40 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-pSSYVF4bof@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:39 +0000
Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices
In-Reply-To: <bug-10401-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10401-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10401-70-h2cHCtlXGJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:41 +0000
Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving
In-Reply-To: <bug-8307-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8307-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8307-70-lWLUNbwFur@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:41 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7688-70-1xldYCu2pC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:42 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7167-70-5mp74XGhUU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:43 +0000
Subject: [Koha-bugs] [Bug 5202] Merge authority records
In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5202-70-xjiG6Sbhcl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:44:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:44:43 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-EpaxHW5C9q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:45:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:45:35 +0000
Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class
In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8798-70-9IGHQNcBQt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:45:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:45:56 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-qoPz7IUfCU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:46:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:46:25 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-55SlIoQ01h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:46:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:46:51 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-HCUC4QCavG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 04:48:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 02:48:11 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-xxmH5xDvVc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 05:21:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 03:21:23 +0000
Subject: [Koha-bugs] [Bug 10668] Improve suggestion detail page
In-Reply-To: <bug-10668-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10668-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10668-70-Sjr3MA752k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10668

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #8 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 05:30:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 03:30:32 +0000
Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any
	page
In-Reply-To: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9735-70-P9fnfJdEcJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Tom?s!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 08:39:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 06:39:07 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-mccvFE7AX8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #18 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
I think we should make a single function
&CheckBranchTransferLimits($item, $biblio, $destinationBranch, $sourceBranch)
# either $item or $biblio should be given, preferably both due to
# C4::Context->preference("item-level_itypes")

Otherwise we get crazy code duplication since the check for
BranchTransferLimits is really messy in the calling method.
Also this check is performed during circ/branchtransfers.pl and it definetely
should be checked when placing reservations/holds as well.
Also some Restful API's we have, place holds and they should be
UseBranchTransferLimits-capable.

Placing holds is beyond the scope of this bug, but now that a patch has been
applied I'd prefer to have a central way of checking the UseBranchTransferLimit
instead of replicating this code everywhere.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 08:56:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 06:56:56 +0000
Subject: [Koha-bugs] [Bug 10993] New: Transfer limits should be checked when
 placing a hold/reservation.
Message-ID: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

            Bug ID: 10993
           Summary: Transfer limits should be checked when placing a
                    hold/reservation.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

If a Borrower cannot get an Item transfered to his pickup location of choice,
the
Borrower needs to know that before he places a hold.
This is especially true when placing Item-level holds.
If a patron can place a hold on an item, he expects the item to be available at
his pickup location of choice. Currently there is no warning or hold block for
holds that violate the UseBranchTransferLimits-setting.

Solution. Create or use an existing centralized
CheckBranchTransferLimits-function inside the
C4::Reserves::CanItemBeReserved(), to see if an item can be reserved for the
desired pickup location.
When the borrower changes his pickup location in
koha/opac-reserve.pl?biblionumber=xxx, the BranchTransferLimits need to be
recalculated.


UseBranchTransferLimits should also affect placing holds via the Restful API's.
$pickuplocation is not always available in the Restful API -requests so we can
use the Borrowers homebranch as the default pickup location.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 08:57:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 06:57:18 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-ExUQHOmTcI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4
           Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 08:58:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 06:58:16 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-uyALRlDvjR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
BTW: Should this be optional?
Is it against the initial spirit of UseBranchTransferLimits?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 10:25:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 08:25:49 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-e0iOijt3qm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #129 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #128)
> Hi Jonathan, guess it's ok that I retested, but please let me know if I
> missed something :)

Yep, thanks! It seems I missed to change the status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 10:35:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 08:35:59 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-1a8Dly5hDA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #19 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21805
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21805&action=edit
When failing UseBranchTransferLimits-check, don't display the "Thanks for
returning this book"-message.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 10:47:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 08:47:03 +0000
Subject: [Koha-bugs] [Bug 10994] New: Email sending is not working in claim
	notice
Message-ID: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

            Bug ID: 10994
           Summary: Email sending is not working in claim notice
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: amitddng135 at gmail.com
        QA Contact: testopia at bugs.koha-community.org

>From address is null acquisitions claim and serial notice.

my $userenv = C4::Context->userenv;
$userenv->{emailaddress}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 10:47:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 08:47:20 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-4Cm2Y9PT7f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 10:48:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 08:48:42 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-CglOkRgGQK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

--- Comment #1 from Amit <amitddng135 at gmail.com> ---
(In reply to Amit from comment #0)
> From address is null acquisitions claim and serial notice.
> 
> my $userenv = C4::Context->userenv;
> $userenv->{emailaddress}

>From address contain null value in acquisitions claim and serial notice.
my $userenv = C4::Context->userenv;
$userenv->{emailaddress}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 10:56:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 08:56:19 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-XZ5xWm0Gmu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #20 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Test case parameters:
-----------------------------
* UseBranchTransferLimits must be set

* define your branch transfer limit.
  IPT -> CPL -> FFL -> IPT

Test case 1, transfer is not allowed:
-----------------------------

* move the librarian to IPT ("Set Library" link top/right)

* check-out an item, with homebranch IPT

* move the librarian to CPL ("Set Library" link top/right)

* FAIL check-in the item => Book check-in fails, but the template is incorrect
(Attachment: When failing UseBranchTransferLimits-check, don't display the
"Thanks for returning this book"-message.)
  OK (check-in fails): Item's checkout status still "Checked out to Olli-Antti2
Kivilahti2, Due back on 11/01/2013"


Test case 2, transfer is allowed:
---------------------------------

* move the librarian to IPT ("Set Library" link top/right)

* check-out an item, with homebranch IPT

* move the librarian to FFL ("Set Library" link top/right)

* OK check-in succeeds and printing a transfer slip is proposed.
  Item's checkout status:  undef


Test conclusion:
--------------------------------
Covered:
Item checkout status changes (Checked out, undef)
Transfer limits (Allow transfer?, true, false)
Template in circ/returns.pl

Test fails the template check, otherwise OK.


Note:
---------------------------------
Should test for SIP2 as well, but probably it works ok, since AddReturn returns
false when BranchTransferLimits check fails.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 11:02:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 09:02:52 +0000
Subject: [Koha-bugs] [Bug 10995] New: Accessibility: Allow manual entry of
 renewal date and specific due date in circ
Message-ID: <bug-10995-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995

            Bug ID: 10995
           Summary: Accessibility: Allow manual entry of renewal date and
                    specific due date in circ
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

In 3.12 it's no longer possible to enter dates manually as specific due date
and renewal date in the patron account in circulation. This is a big
accessibility problem as not everyone can use the datepickers for filling those
fields. We have a library where this is a blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 11:08:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 09:08:25 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-uZahQax146@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It has worked nicely for me in the past - does your staff user have an email
address?

I agree that it's unusual for Koha to use the staff patron's email address, so
maybe this should only be an option and not the default.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 11:24:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 09:24:00 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-KPhNPAW5ba@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

--- Comment #3 from Amit <amitddng135 at gmail.com> ---
Hi Katrin,

Yes if staff have an email address claim notice is working fine. But this is
not a correct behavior. If we modify the code then it will not check whether
staff have email address or not.

my $email_address = $userenv->{'branchemail'} ||
C4::Context->preference('KohaAdminEmailAddress');

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 11:48:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 09:48:53 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-nkX4TFChk8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Olli-Antti Kivilahti from comment #19)
> Created attachment 21805 [details]
> When failing UseBranchTransferLimits-check, don't display the "Thanks for
> returning this book"-message.

I don't get this message. Are you sure you applied this patch on the master
branch?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 11:58:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 09:58:54 +0000
Subject: [Koha-bugs] [Bug 10996] New: Cannot exclude numeric subfields on
	export
Message-ID: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

            Bug ID: 10996
           Summary: Cannot exclude numeric subfields on export
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Tools export allows you to specify tags and subfields to strip from exported
records. However if the subfields you specify are numeric they are not stripped

Cause the regexp used to parse the exclusion list considers all numerics to be
part of the tag number so an attempt to strip $9 from tag 110 ends up in
stripping tag 1109!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 12:48:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 10:48:05 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-uVOH9nCDm4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 21806
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21806&action=edit
Proposed Patch

To test export a record containing a numeric subfield (e.g. 100 $9 ) with
exclusion specified thus 1009. Without patch the $9 is in the export. With
patch it should be stripped

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 13:22:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 11:22:18 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-VBjavImBx5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #130 from Pierre Angot <tredok.pierre at gmail.com> ---
Yeah ! Now, we are waiting for pushing. I can start to test 8230 ^^

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 13:52:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 11:52:09 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-DB3xizuDi4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Kyle M Hall from comment #11)
> Jonathan, can you point me to the code that is currently accomplishing this?
> I'm afraid I'm having a difficult time locating it. Thanks!

I suppose it is in the C4::Circulation::_debar_user_on_return routine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 14:07:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 12:07:30 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-nP7atdJFrI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I take the liberty of switching back the status to Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 14:34:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 12:34:44 +0000
Subject: [Koha-bugs] [Bug 10997] New: Modernize value_builders for NORMARC
Message-ID: <bug-10997-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10997

            Bug ID: 10997
           Summary: Modernize value_builders for NORMARC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I have reports of the NORMARC value_bilders doing wonky things, but the MARC21
ones seem to behave better. The NORMARC ones still use the old JS-only
approach. This bug aims to upgrade them to use the XML-based approach adopted
by MARC21.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 14:35:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 12:35:57 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-TZ8ioyjxOk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #18 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21807
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21807&action=edit
Neglected to escape the single quotes in the sql command.  This corrects it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 14:38:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 12:38:25 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-C1Y9AF3HP3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #19 from Blou <philippe.blouin at inlibro.com> ---
Thank you!  I can't believe i had done the escaping for its sister file
(sysprefs.sql) and not this one.

This new patch patches the big previous patch.

My apologies.  I'll be more careful next time.

> You forgot to escape the single quotes in the message and you then typed
> contractions like "Don't" and "We'll" in the message. Escape the single
> quotes, and this works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:12:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:12:07 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-2cx2fwCj2W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #20 from M. Tompsett <mtompset at hotmail.com> ---
Oops. I forgot to mention escaping the question mark too. :) Could you patch
that up too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:16:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:16:13 +0000
Subject: [Koha-bugs] [Bug 8667] Add budget and branch columns in
	histsearch.pl results
In-Reply-To: <bug-8667-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8667-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8667-70-SFoL5VzeRs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8667

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Jonathan Druart from comment #11)
> Blocked by bug 5336 (for the aqorders.branchcode columns).

Bug 5336 will be pushed *without* the aqorders.branchcode column!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:28:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:28:22 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-us9PHfd2rF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #139 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Is there anything to do before running tests?

- prove t/SimpleMarc.t
All tests successful.
Files=1, Tests=37,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.04 cusr  0.00
csys =  0.06 CPU)
Result: PASS

- prove t/db_dependent/MarcModificationTemplates.t
...
Test Summary Report
-------------------
t/db_dependent/MarcModificationTemplates.t (Wstat: 3584 Tests: 74 Failed: 14)
  Failed tests:  25-28, 35-39, 48-51, 65
  Non-zero exit status: 14
Files=1, Tests=74,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.22 cusr  0.02
csys =  0.28 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:32:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:32:46 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-6ljGYrc2g4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:32:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:32:51 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-pus1HXFJe9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:34:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:34:45 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-nTfYJzI2oS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21524
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21524
Adding NoLoginInstructions to system preferences

Review of attachment 21524:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10951&attachment=21524)
-----------------------------------------------------------------

::: installer/data/mysql/sysprefs.sql
@@ +418,5 @@
>  ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'),
>  ('yuipath','local','local|http://yui.yahooapis.com/2.5.1/build','Insert the path to YUI libraries, choose local if you use koha offline','Choice'),
>  ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'),
> +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'),
> +('NoLoginInstructions', '<h5>Don\'t have a password yet?</h5> <p> If you don\'t have a password yet, stop by the circulation desk the next time you\'re in the library. We\'ll happily set one up for you.</p> <h5>Don\'t have a library card?</h5> <p> If you don\'t have a library card, stop by your local library to sign up.  </p>', '60|10', 'Instructions when a person is not connected', 'Textarea')

This should probably be in the alphabetical order location. This question mark
didn't need escaping, because it isn't wrapped in perl code. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:37:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:37:58 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-mieHa7dMew@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Vitor Fernandes <vfernandes at keep.pt> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vfernandes at keep.pt

--- Comment #31 from Vitor Fernandes <vfernandes at keep.pt> ---
THis patch works fine for me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 15:45:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 13:45:48 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-7f6CS1mlCo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #140 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #139)
> Is there anything to do before running tests?
No! I will fix that asap

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:02:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:02:43 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-XYfr1Oth15@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #151 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21434
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21434
[SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles

Review of attachment 21434:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21434)
-----------------------------------------------------------------

::: C4/Installer/PerlDependencies.pm
@@ +692,5 @@
> +    'Test::CGI::Multipart' => {
> +        'usage'    => 'Tests',
> +        'required' => '0',
> +        'min_ver'  => '0.0.3',
> +    },

This needs a rebase now. :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:04:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:04:38 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-QPJnMpgDTO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21486|0                           |1
        is obsolete|                            |
  Attachment #21487|0                           |1
        is obsolete|                            |

--- Comment #141 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21808
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21808&action=edit
Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = "/foo/bar/i").
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:04:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:04:44 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-Excii4CRk0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #142 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21809
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21809&action=edit
Bug 8015: FIX ui issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:05:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:05:49 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-2evLcvaGnL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #143 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #139)
I didn't change the unit test file after changing the table structure.
Now it is fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:16:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:16:40 +0000
Subject: [Koha-bugs] [Bug 7294] status "in order"
In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7294-70-6v93Wl91cr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #73 from Jonathan Druart <jonathan.druart at biblibre.com> ---
The status of orders is managed by bug 5336.
We don't want order status information in the marc record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:16:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:16:41 +0000
Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus
In-Reply-To: <bug-7163-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7163-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7163-70-eYmq8e9xpN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163

Bug 7163 depends on bug 7294, which changed state.

Bug 7294 Summary: status "in order"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:55:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:55:08 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-umRsIpqn8w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #22 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21810
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21810&action=edit
Bug 10951 - Adding NoLoginInstructions to system preferences

On a failed login, the default message is harcorded into opac-auth.tt.

    It would be preferable to allow for a preference to override that message
(for example: ...Please bring an ID to t
    The changes modify
            -opac-auth.tt to allow for custom value
            -admin/preferences/opac.pref to add it to the preferences with a
description
            -C4/Auth.pm for the loading of the preference
            -sysprefs.sql
            -updatedatabase.pl

    TESTING
            1) in OPAC, logged out, try login in by entering no or wrong
credentials.  Acknowledge the "Don't have a p
            2) Apply the patch
            3) Regression Test: Redo step 1.  Same (default) message should
appear.
            4) Log in to intranet,
               - select NoLoginInstructions in system preferences.
               - Enter new (xml) message.  Possible:
               <h5>Welcome to Koha, please bring your passport to the front
office</h5>
               - and save
            5) refresh the OPAC, try login again with invalid credentials.  The
new message should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:57:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:57:14 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-Qfy5PIt7gZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21524|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:57:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:57:34 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-IIorpKbSOp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21807|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 16:58:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 14:58:59 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-MWEqbLj5ry@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #23 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21524
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21524
Adding NoLoginInstructions to system preferences

Last patch posted replaces this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 17:15:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 15:15:56 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-OTMoXeVA04@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #24 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21811
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21811&action=edit
Corrected entry which was on two lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 17:32:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 15:32:41 +0000
Subject: [Koha-bugs] [Bug 10998] New: code duplication introduced by Z39.50
 authority search
Message-ID: <bug-10998-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10998

            Bug ID: 10998
           Summary: code duplication introduced by Z39.50 authority search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Bug 10096, which introduces a feature to import authority records via Z39.50,
also introduces some code duplication.

To summarize the differences:

- z3950_search.pl and z3950_auth_search.pl differ only in the input search
attributes they accept
- C4::Breeding::ImportBreeding() and C4::Breeding::ImportAuth() do mostly the
same thing
- the actual search logic in C4::Breeding::Z3950SearchAuth() and
C4::Breeding::Z3950Search() is the same; the two routines differ only in the
specific Z39.50 attributes they handle and in some details of post-retrieval
record processing.  Also, Z3950SearchAuth() does not reflect the work that was
done for bug 10462.

Consequently, there is plenty of opportunity for code consolidation, as well as
adding unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 17:35:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 15:35:09 +0000
Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority
	searching
In-Reply-To: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10096-70-p2Kzw2mvYF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #34 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, David!

But also note bug 10998, as the code duplication introduced by this patch
concerns me -- not to the point of not pushing the feature, but were it earlier
in the 3.14 cycle, I would have asked for some refactoring before this got in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 17:35:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 15:35:30 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-xiKD3ouuk9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #158 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Ketan,

(In reply to Ketan Kulkarni from comment #155)
> Hello Tom?s,
> 
> Yes, we should move from utf8::encode/decode to Encode::
> This particular bug (6554) is about double encoding that happens in
> Templates.pm.

Take a look at this work from Marcel:
http://wiki.koha-community.org/wiki/Handling_UTF8_in_development

If we (currently) do things wrong inside Koha regarding encoding/decoding of
UTF-8 data (double encoding means we are encoding wrong somewhere), then fixing
those symptms will just hide the problem (using utf8::upgrade will avoid the
consequences but not fix the root cause, it might even hide new bugs introduced
by future patches).

It is up to the QA team and the RM to think of the best approach for tackling
this so I'm just leaving this comment, also I appreciate you efforts and hope
this gets fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 17:48:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 15:48:56 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-9OUFPVwCyR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21811|0                           |1
        is obsolete|                            |

--- Comment #25 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21812
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21812&action=edit
Corrected entry which was on two lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 17:49:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 15:49:57 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-jd4yEoM3qh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #26 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21813
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21813&action=edit
changed escape \' to '' (and \? to ?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 18:02:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 16:02:47 +0000
Subject: [Koha-bugs] [Bug 10856] Improve the previous and next items on the
	shelf browser
In-Reply-To: <bug-10856-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10856-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10856-70-OAvXo3UQcN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10856

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #31 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 18:09:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 16:09:58 +0000
Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address
In-Reply-To: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5544-70-NlCNZsNtxJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #20 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 18:30:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 16:30:22 +0000
Subject: [Koha-bugs] [Bug 7764] INSTALL.ubuntu needs to be updated
In-Reply-To: <bug-7764-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7764-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7764-70-qfPVu51jMM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7764

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #19 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a follow-up to direct people to the wiki
instructions for installing Koha on Ubuntu from packages for production. 
Thanks, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 20:04:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 18:04:00 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-rzmtkOnyeq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21810|0                           |1
        is obsolete|                            |
  Attachment #21812|0                           |1
        is obsolete|                            |
  Attachment #21813|0                           |1
        is obsolete|                            |

--- Comment #27 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21814
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21814&action=edit
Adding NoLoginInstructions to system preferences

Ok, this is a clean one, containing all the changes, from the start.  All
previous patches are obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 21:37:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 19:37:14 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-4uXTce7MIS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #28 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21815
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21815&action=edit
Bug 10951 - Adding NoLoginInstructions to system preferences

     On a failed login, the default message is harcorded into opac-auth.tt.

     It would be preferable to allow for a preference to override that message
(for example: ...Please bring an ID to t
     The changes modify
         -opac-auth.tt to allow for custom value
         -admin/preferences/opac.pref to add it to the preferences with a
description
         -C4/Auth.pm for the loading of the preference
         -sysprefs.sql
         -updatedatabase.pl

     TESTING
         1) in OPAC, logged out, try login in by entering no or wrong
credentials.  Acknowledge the "Don't have a p
         2) Apply the patch
         3) Regression Test: Redo step 1.  Same (default) message should
appear.
         4) Log in to intranet,
             - select NoLoginInstructions in system preferences.
             - Enter new (xml) message.  Possible:
             <h5>Welcome to Koha, please bring your passport to the front
office</h5>
            - and save
         5) refresh the OPAC, try login again with invalid credentials.  The
new message should appear.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 21:38:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 19:38:00 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-kcdi5BkTdH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21814|0                           |1
        is obsolete|                            |

--- Comment #29 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21814
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21814
Adding NoLoginInstructions to system preferences

This is obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 21:46:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 19:46:37 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-w6xudutWxc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #30 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21816
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21816&action=edit
[SIGNED OFF] Bug 10951 - Adding NoLoginInstructions to system preferences

     On a failed login, the default message is harcorded into opac-auth.tt.

     It would be preferable to allow for a preference to override that message
(for example: ...Please bring an ID to t
     The changes modify
         -opac-auth.tt to allow for custom value
         -admin/preferences/opac.pref to add it to the preferences with a
description
         -C4/Auth.pm for the loading of the preference
         -sysprefs.sql
         -updatedatabase.pl

     TESTING
         1) in OPAC, logged out, try login in by entering no or wrong
credentials.  Acknowledge the "Don't have a p
         2) Apply the patch
         3) Regression Test: Redo step 1.  Same (default) message should
appear.
         4) Log in to intranet,
             - select NoLoginInstructions in system preferences.
             - Enter new (xml) message.  Possible:
             <h5>Welcome to Koha, please bring your passport to the front
office</h5>
            - and save
         5) refresh the OPAC, try login again with invalid credentials.  The
new message should appear.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 21:47:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 19:47:24 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-kwY9iFFMF4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21815|0                           |1
        is obsolete|                            |

--- Comment #31 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21815
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21815
Bug 10951 - Adding NoLoginInstructions to system preferences

Obsolete (unsigned) version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 21:50:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 19:50:19 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-ic0ZMFp4MS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #32 from M. Tompsett <mtompset at hotmail.com> ---
test plan:

- drop kohadatabase, create blank one
- go to staff client and do web install
- confirm the nologin-ish system preference was created.
- restore only koha database
- go to staff client and do web upgrade
- confirm the nologin-ish system preference was created.

play with values of the system preference
- does the message appear on failed log in? YES.
- blank the system preference, refresh OPAC, gives old default message? YES.
- set system preference to 'blah', refresh OPAC, gives 'blah'? YES.

Looks great! Signed off. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 22:06:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 20:06:44 +0000
Subject: [Koha-bugs] [Bug 10999] New: koha-restore --force option to just
 overwrite easily a Koha instance with an older backup
Message-ID: <bug-10999-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10999

            Bug ID: 10999
           Summary: koha-restore --force option to just overwrite easily a
                    Koha instance with an older backup
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Right now for eg
koha-restore /var/spool/koha/myInstance/myInstance-2013-09-23.sql.gz 
/var/spool/koha/myInstance/myInstance-2013-09-23.tar.gz
gives 78 lines starting with "ERROR: File exists:" and a "adduser: The user
`myInstance' already exists."
It would be great to just overwrite whatever needs to have the dump runing
again, without having to koha-remove.

BTW, even using koha-remove before koha-restore, a username problem that
GRANT ALL PRIVILEGES ON `koha_myInstance` . * TO 'koha_myInstance'@'localhost';
fix. Something to do with bug 10517?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 22:12:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 20:12:57 +0000
Subject: [Koha-bugs] [Bug 11000] New: koha-restore not working: Koha
	username error
Message-ID: <bug-11000-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

            Bug ID: 11000
           Summary: koha-restore not working: Koha username error
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org

koha-restore without previously removing the instance give 78 links of "ERROR:
File exists:" and that?s more or less expected, but:
koha-remove myInstance
(OK)
Then:
koha-restore /var/spool/koha/myInstance/myInstance-2013-09-23.sql.gz 
/var/spool/koha/myInstance/myInstance-2013-09-23.tar.gz  
ERROR: File exists: /var/lib/koha/myInstance/
ERROR: File exists: /var/lib/koha/myInstance/.bash_history
ERROR: File exists: ....
[total 44 lines]

ERROR 1396 (HY000) at line 1: Operation DROP USER failed for
'koha_myInstance'@'%'
DBI
connect('dbname=koha_myInstance;host=localhost;port=3306','koha_myInstance',...)
failed: Access denied for user 'koha_myInstance'@'localhost' (using password:
YES) at /usr/share/koha/lib/C4/Context.pm line 803
Access denied for user 'koha_myInstance'@'localhost' (using password: YES) at
/usr/share/koha/lib/C4/Context.pm line 803.
Something went wrong rebuilding biblio indexes for myInstance
DBI
connect('dbname=koha_myInstance;host=localhost;port=3306','koha_myInstance',...)
failed: Access denied for user 'koha_myInstance'@'localhost' (using password:
YES) at /usr/share/koha/lib/C4/Context.pm line 803
Access denied for user 'koha_myInstance'@'localhost' (using password: YES) at
/usr/share/koha/lib/C4/Context.pm line 803.
Something went wrong rebuilding authority indexes for myInstance
[ ok ] Restarting web server: apache2 ... waiting .

I fix this just with:
GRANT ALL PRIVILEGES ON `koha_myInstance` . * TO 'koha_myInstance'@'localhost';
and running again the previous command, but is very scary to erase and not
being able to restore an instance...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 22:24:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 20:24:24 +0000
Subject: [Koha-bugs] [Bug 10999] koha-restore --force option to just
 overwrite easily a Koha instance with an older backup
In-Reply-To: <bug-10999-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10999-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10999-70-fcNOukKEeD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10999

Pablo AB <pablo.bianchi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 22:25:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 20:25:18 +0000
Subject: [Koha-bugs] [Bug 11000] koha-restore not working: Koha username
	error
In-Reply-To: <bug-11000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11000-70-P9dByXcS97@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

Pablo AB <pablo.bianchi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 22:28:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 20:28:14 +0000
Subject: [Koha-bugs] [Bug 11000] koha-restore not working: Koha username
	error
In-Reply-To: <bug-11000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11000-70-B4vuyVe8q4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11000

--- Comment #1 from Pablo AB <pablo.bianchi at gmail.com> ---
This probably is duplicated or related to bug 10517.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 23:25:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 21:25:27 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-nXJK6LDdht@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 23:25:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 21:25:43 +0000
Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate
	fields
In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8956-70-XcsxlCUQok@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, 

failing to get your attention and answers to my questions :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 23:25:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 21:25:47 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-Jg0XOCBj3U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct  4 23:26:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 04 Oct 2013 21:26:29 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-T184lhAm3g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_3_14_candidate
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:20:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:20:43 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-eJakt4tmKE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-05
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:21:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:21:24 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-8eQ31XRTX8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-05
    last check this|                            |

--- Comment #16 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:28:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:28:32 +0000
Subject: [Koha-bugs] [Bug 7031] More options for AdvancedSearchTypes
In-Reply-To: <bug-7031-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7031-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7031-70-u30RQK6jL0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7031

--- Comment #27 from Chris Cormack <chris at bigballofwax.co.nz> ---
*** Bug 4481 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:28:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:28:32 +0000
Subject: [Koha-bugs] [Bug 4481] Search's Limit to Available filters out many
 available items
In-Reply-To: <bug-4481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4481-70-vXfU7Rc9mV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4481

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
                 CC|                            |chris at bigballofwax.co.nz
         Resolution|---                         |DUPLICATE

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
This was fixed by 7031

*** This bug has been marked as a duplicate of bug 7031 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:28:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:28:33 +0000
Subject: [Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten
In-Reply-To: <bug-9234-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9234-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9234-70-GEp1UOGbEl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234

Bug 9234 depends on bug 4481, which changed state.

Bug 4481 Summary: Search's Limit to Available filters out many available items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4481

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:32:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:32:26 +0000
Subject: [Koha-bugs] [Bug 7362] Allow searching by item number as a fallback
In-Reply-To: <bug-7362-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7362-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7362-70-5wdb6OWZv0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7362

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
I had a crack at rebasing this but there are a lot of conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:40:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:40:17 +0000
Subject: [Koha-bugs] [Bug 6890] Add reserves to modification logging
In-Reply-To: <bug-6890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6890-70-BAHR8jldab@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 03:40:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 01:40:21 +0000
Subject: [Koha-bugs] [Bug 6890] Add reserves to modification logging
In-Reply-To: <bug-6890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6890-70-Fjrx3vHpAg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14109|0                           |1
        is obsolete|                            |

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 21817
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21817&action=edit
Bug 6890 - log reservation actions

C4/Reserves.pm: log reservation actions
catalogue/issuehistory.tt: link to viewlog for circulation log
tools/viewlog.tt: add HOLD and UNHOLD actions, move results table nearer top
tools/viewlog.tt: rewrite to use loopro.module and to link better
members/readingrec.tt: link to circulation log for hold/unhold info

To test:
  1. place a few holds and release them somehow (cancel or issue);
  2. view the reading record of an affected borrower;
  3. click the link to the modification log and see the holds;
  4. click the link to an affected biblio;
  5. click to view its circulation history;
  6. click the link to the modification log and see the holds.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:08:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:08:07 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-jZWoKyu7Z5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:08:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:08:12 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-VWXldFcZ0a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15859|0                           |1
        is obsolete|                            |

--- Comment #43 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 21818
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21818&action=edit
Bug 9316: Add ability to install/configure nginx

Amended permissions for plack socket and fixed type
Altered mount location for opac to reflect current koha path settings

Update:

Resolved merge problems

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:08:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:08:44 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-RVwFKJzEj7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15151|0                           |1
        is obsolete|                            |

--- Comment #44 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 21819
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21819&action=edit
Bug 9316: Add ability to install/configure nginx - Minor Corrections

This patch adds minor changes to koha-plack.sh upstart script and a few
corrections to permissions and missing directory locations to quiet errors

This patch should be applied after Elliott Davis's patch.

Test as before:
1) Ensure that you have nginx installed
2) Esure that you have the following packages installed libplack-perl
libcgi-emulate-psgi-perl libcgi-compile-perl starman
3) Apply patch
4) Run through the make file, you will notice 5 new configuration options.
5) Make sure you choose NGiNX as your webserver
6) You may choose whatever ports you wish and also whatever DNS entries you
wish
7) After you're done configuring run make
8) Run make install (you may need sudo if you've used sudo before)
9) Start plack (you may wish to copy the script to init.d) with the script in
koha-dev/bin/koha-plack.sh (requires sudo)
10) TURN OFF APACHE, and start NGiNX
11) go to your web browser and see if everything fires up as normal.

removed dependencies and updated init script to allow for the use of starman or
plackup

fixed debian control
added a warning for nginx configurations
modified koha.psgi to enable debugging only if plack::middleware::debug had
been installed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:09:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:09:49 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-vN2XomESNM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #45 from Chris Cormack <chris at bigballofwax.co.nz> ---
This took quite a bit of rebasing, I ended up needing to use the old git apply
PATCH --reject trick

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:19:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:19:23 +0000
Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to
 choose to display an icon based on the marc control fields,
 or based on the koha biblio level itemtype
In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8732-70-AZ5W96a8pd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:19:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:19:27 +0000
Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to
 choose to display an icon based on the marc control fields,
 or based on the koha biblio level itemtype
In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8732-70-bnTRTIDWJr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16453|0                           |1
        is obsolete|                            |

--- Comment #17 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 21820
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21820&action=edit
Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones

If you switch BiblioItemtypeImage to Koha, you will see the Koha
itemtypes, if it is Control you will get the ones generated from
the MARC control fields.

Squashed commit of the following:

commit a36d5fdbfc484639ae7939f14e0363fda79b9323
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Mon Oct 1 10:56:47 2012 +1300

    WR96747, Bug 8732 Finishing staff side

commit feff903c77ffc0fcec9459ecffab6c2ee5b1349d
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Mon Oct 1 09:47:07 2012 +1300

    Bug 8732 : Now working for staff side too

commit 641be286401cf1be54fddb3cc58a53566d80dcca
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Mon Oct 1 09:10:27 2012 +1300

    Bug 8732 - generalising syspref

    Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

commit c4ce95c12a773d84e6f8d0b05664649e170799d8
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Wed Sep 12 09:19:31 2012 +1200

    Bug 8732 : Showing the images on the OPAC detail page

commit 105acad0f76628536840577fa96fb0839f9f3e2f
Author: Chris Cormack <chrisc at catalyst.net.nz>
Date:   Thu Sep 6 14:19:37 2012 +1200

    Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones

    If you switch OpacResultsItemtypeImage to Koha, you will see the Koha
    itemtypes, if it is Control you will get the ones generated from the
    MARC control fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 04:19:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 02:19:42 +0000
Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to
 choose to display an icon based on the marc control fields,
 or based on the koha biblio level itemtype
In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8732-70-aELCvJSsK9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16454|0                           |1
        is obsolete|                            |

--- Comment #18 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 21821
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21821&action=edit
Bug 8732 Style fixes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 05:12:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 03:12:20 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-eSMeNA4JHc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #159 from Ketan Kulkarni <ketan at carvingit.com> ---
Hello Tom?s,

I appreciate your concerns. I have read the web page. It's up to the QA and RM
to decide.

Nevertheless, the updates in the patch have been done in accordance with the
principle - decode the input and encode the output.

Although utf8::upgrade() is a temporary fix to "hide" the problems if any, does
fix things to a great extent. Besides, upgrade() is an inbuilt perl function.
And on production systems it's better we use upgrade() than just encode() if it
is going to break things. Once we have a plan in place, this will be replaced
by Encode::.... You see, there's talk about using Encode::... instead of
utf8::....
In the current scenario, utf8::upgrade() appears to be a decent (and forgiving)
way of handling errors in coding.

There's another bug related to writing a generic subroutine for utf-decoding
for input. The discussion is on.

Considering the size of the code-base, UTF handling related updates are going
to take time. The present patch tries to fix the problem that is there in the
stable release temporarily.

Regards,
Ketan

(In reply to Tom?s Cohen Arazi from comment #158)
> Ketan,
> 
> (In reply to Ketan Kulkarni from comment #155)
> > Hello Tom?s,
> > 
> > Yes, we should move from utf8::encode/decode to Encode::
> > This particular bug (6554) is about double encoding that happens in
> > Templates.pm.
> 
> Take a look at this work from Marcel:
> http://wiki.koha-community.org/wiki/Handling_UTF8_in_development
> 
> If we (currently) do things wrong inside Koha regarding encoding/decoding of
> UTF-8 data (double encoding means we are encoding wrong somewhere), then
> fixing those symptms will just hide the problem (using utf8::upgrade will
> avoid the consequences but not fix the root cause, it might even hide new
> bugs introduced by future patches).
> 
> It is up to the QA team and the RM to think of the best approach for
> tackling this so I'm just leaving this comment, also I appreciate you
> efforts and hope this gets fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 05:15:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 03:15:08 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-sjJBhNJVEu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #160 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Ketan Kulkarni from comment #159)
> Hello Tom?s,
> 
> I appreciate your concerns. I have read the web page. It's up to the QA and
> RM to decide.
> 
Just one note here, Tom?s is the release maintainer for the 3.12.x branch, so
it is up to him to decide if this will go into that stable release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 14:43:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 12:43:22 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-lzASh5K1t5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #144 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Testing this!
Tests now run without problems :)

For me this works, I've tried add, copy, delete, move, 
regex find and replace (text and also changing branch in 952ab
using __BRANCHNAME__)

What's missing:

1) Check that template name is non empty. If you press "Create template" 
can create as many "no name" templates as you wish. Avoiding duplicates
could be cool.

2) Help File. This is important for prospective users and DocManager job. 
At last a minimal one could help testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 16:32:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 14:32:15 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-RIeUVdwHD0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
[SIGNED-OFF] Bug 10309 - New OPAC theme based on Bootstrap

Add remote, merge branch, enable bootstrap theme.

Tested any feature I can: simple and advanced search, 
lists and carts, logging in/out, user data, change password, change
personal details, holds, search history, authority search, facets.

Tested on PC and android (phone & tablet)

For me it works well, and looks very well. 
But we can't fix any eventual glitch if it's not pushed
So I sign.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 20:13:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 18:13:45 +0000
Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to
 Update Nr. 17 (September 2013)
In-Reply-To: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10964-70-O0rHG3gtxr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21822
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21822&action=edit
Bug 10964 - [AUTH] Update MARC21 de-DE default frameworks to Update Nr. 17
(September 2013)

This patch updates MARC21 default authority framework
to Update Nr. 17 (September 2013)

Also rewrites creation of auth types as in EN file
and removes backticks

Not to sign, needs translation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 20:23:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 18:23:43 +0000
Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to
 Update Nr. 17 (September 2013)
In-Reply-To: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10964-70-yrBlA1yS7B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21822|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21823
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21823&action=edit
Bug 10964 - [AUTH] Update MARC21 de-DE default frameworks to Update Nr. 17
(September 2013)

Ooops! wrong file on previous patch.
Fixed.

This patch updates MARC21 default authority framework
to Update Nr. 17 (September 2013)

Also rewrites creation of auth types as in EN file
and removes backticks

Not to sign, needs translation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 20:30:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 18:30:51 +0000
Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to
 Update Nr. 17 (September 2013)
In-Reply-To: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10964-70-ela11EPxRi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21823|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21824
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21824&action=edit
Bug 10964 - [AUTH] Update MARC21 de-DE default frameworks to Update Nr. 17
(September 2013)

Ooops! wrong file on previous patch.
Fixed.

This patch updates MARC21 default authority framework
to Update Nr. 17 (September 2013)

Also rewrites creation of auth types as in EN file
and removes backticks

Not to sign, needs translation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 20:33:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 18:33:31 +0000
Subject: [Koha-bugs] [Bug 10964] Update MARC21 de-DE default framework to
 Update Nr. 17 (September 2013)
In-Reply-To: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10964-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10964-70-AIcwM9D5jb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10964

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 21:29:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 19:29:28 +0000
Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error
In-Reply-To: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10843-70-rXZCHhjl1N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The tests pass, but there are a lot of warnings. Could you take a look,
Jonathan?
Use of uninitialized value $_ in pattern match (m//) at
/home/katrin/kohaclone/Koha/DateUtils.pm line 128.
Use of uninitialized value $_ in pattern match (m//) at
/home/katrin/kohaclone/Koha/DateUtils.pm line 133.
Use of uninitialized value $_ in pattern match (m//) at
/home/katrin/kohaclone/Koha/DateUtils.pm line 138.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 67.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 72.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 77.
Use of uninitialized value $date_format in string eq at
/home/katrin/kohaclone/Koha/DateUtils.pm line 80.
Use of uninitialized value $_ in pattern match (m//) at
/home/katrin/kohaclone/Koha/DateUtils.pm line 128.
Use of uninitialized value $_ in pattern match (m//) at
/home/katrin/kohaclone/Koha/DateUtils.pm line 133.
Use of uninitialized value $_ in pattern match (m//) at
/home/katrin/kohaclone/Koha/DateUtils.pm line 138.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 21:41:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 19:41:12 +0000
Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error
In-Reply-To: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10843-70-IoGH1magWW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 21:41:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 19:41:15 +0000
Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error
In-Reply-To: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10843-70-3HdLgHjw3N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21686|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21825
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21825&action=edit
[PASSED QA] Bug 10843: the DateTime->add method takes a scalar, not undef

Test plan:
1) set an empty string for the ReservesMaxPickUpDelay pref
2) place a hold on an item
3) check in the item
4) click on "Print and confirm"
5) an error occurs
> The 'days' parameter (undef) to DateTime::Duration::new was an 'undef'
6) apply the patch
7) repeat steps 1 to 4
8) the error does not occur anymore.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
An empty string didn't do it for me, I had to set the
variable for the systempreference to NULL. I am not sure
if this can happen when editing from the interface, but
this change should not have any ill side effects and it has
unit tests!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:05:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:05:06 +0000
Subject: [Koha-bugs] [Bug 10884] Circulation table: odd behavior on
	checkboxes
In-Reply-To: <bug-10884-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10884-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10884-70-Od6pPGnWNO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10884

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:05:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:05:09 +0000
Subject: [Koha-bugs] [Bug 10884] Circulation table: odd behavior on
	checkboxes
In-Reply-To: <bug-10884-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10884-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10884-70-ePOYdobGHX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10884

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21455|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21826
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21826&action=edit
[PASSED QA] Bug 10884: circulation table: fix odd behavior on checkboxes

Test plan:
Play with renew, check in and export checkboxes.
The expected behavior is: the renew and check in cb should work as radio
button, without affecting the export cb.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Template changes only.
Amended test plan:
* Create a CSV profile under Tools > CSV profiles
* Add CSV profile to system preference ExportWithCsvProfile

1) Check export checkbox
2) Check check in for same item
3) Switch to Renew

The export checkbox should not get unchecked when switching
between renew and check in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:18:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:18:38 +0000
Subject: [Koha-bugs] [Bug 10917] Librarian cannot update hold pickup
 location without modify_holds_priority
In-Reply-To: <bug-10917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10917-70-YwVOysNpK8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:18:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:18:41 +0000
Subject: [Koha-bugs] [Bug 10917] Librarian cannot update hold pickup
 location without modify_holds_priority
In-Reply-To: <bug-10917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10917-70-cVDsZRrTKV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21456|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21827
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21827&action=edit
[PASSED QA] Bug 10917 - Librarian cannot update hold pickup location without
modify_holds_priority

A librarian cannot modify a hold's pickup location unless he or she has
the permission modify_holds_priority. This appears to be a bug and not
by design. The reason the update fails is due to the priority not being
passed to ModReserve. The priority is not displayed when a librarian
does not have the modify_holds_priority permission.

Test Plan:
1) Remove the modify_holds_priority from your logged in user
   * User cannot be a superlibrarian
2) Attempt to change the pickup location for a hold
3) Note the change fails
4) Apply this patch
5) Repeat step 2
6) Note the change succeeds

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Template change only.
Passes all tests and QA script.

Tested:
- Confirmed that changing the pickup location is not
  possible in master without the modify_holds_priority
  permission
- Confirmed that the patch fixes the problem - pickup
  location can now be changed with and without the
  permission
- Pickup location can still not be changed, when
  IndependentBranches is activated

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:30:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:30:20 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-uhOyXFPCNz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:30:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:30:23 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-TurISZRKW1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21735|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21828
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21828&action=edit
[PASSED QA] Bug 10705 - Shipment cost should be 'shipping'

http://bugs.koha-community.org/show_bug.cgi?id=10705
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Trivial string change. No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
String change - fixing another occurence in a follow up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:30:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:30:40 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-7JePoUKGZF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21829
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21829&action=edit
Bug 10705: Follow-up - shippment cost should be shipping cost

Term also occurs on the spent page accessible from the funds
table on the acquisition module start page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:38:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:38:37 +0000
Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices
 table doesn't work
In-Reply-To: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10794-70-dPOlCIiI7T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:38:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:38:40 +0000
Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices
 table doesn't work
In-Reply-To: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10794-70-WusEm43NQ0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21738|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21830
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21830&action=edit
Bug 10794 - Sorting on billing date column in invoices table doesn't work

This patch adds the sorting by title string option to the table of
invoices. This allows column data to be sorted based on the
ISO-formatted date rather than the formatted-for-display date. A "blank"
(0000-00-00) date is added to cells which contain no date data.

To test, view the Acquisitions Invoices page (acqui/invoices.pl) and
confirm that the "Billing date" column is sorted correctly regardless of
the dateformat system preference.

http://bugs.koha-community.org/show_bug.cgi?id=10749

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Template only change, passes all tests and QA script.
Sorting of the billing column now works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 22:46:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 20:46:54 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-GhbiFVKYMA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21168|0                           |1
        is obsolete|                            |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 23:05:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 21:05:29 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-27vlgpsr0e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, bit confused about the example values: and|And|or|Or

1) Do we need 'And' and 'and' when the values are now case insensitive?
>I've now taken this into account too, making it case insensitive was a great >idea!

2) Why not list 'not'?

I will continue to test, this could go into a follow up.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 23:22:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 21:22:51 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-glKExmRB77@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 23:22:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 21:22:56 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-GZeAzZWJST@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21582|0                           |1
        is obsolete|                            |

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21831
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21831&action=edit
[PASSED QA] Bug 6149 - Stopwords for Result Highlighting

This patch adds a system preference to control stopwords used to
prevent operators and other 'minor' words from being highlighted
in search results when the OpacHighlightWords syspref is enabled

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Works as advertised, I fixed the updatedatabase to use XXX so it won't
clash as much

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixed a conflict in updatedatabase.pl.
Also fixed tabs in opac-detail.tt

Feature passes all tests and QA script now.
Tested in intranet and OPAC with different words and searches.
Works on results pages and OPAC detail page.
Highlighting and unhighlighting still works correctly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct  5 23:47:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 21:47:32 +0000
Subject: [Koha-bugs] [Bug 10890] Autobarcode "<branch>yymm00001" Fails in
 Acquisitions When Receiving Item
In-Reply-To: <bug-10890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10890-70-dwSncG3ugD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
When creating multiple items, always the same barcode number is created. This
will result in an error message on saving. Could this be improved so that the
script notices the first number and counts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 00:04:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 22:04:36 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-am0U3qF947@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I had problems last time to test this, because I was not able to create
authorities in my UNIMARC installation. Could you please provide some
instructions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 00:07:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 22:07:27 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-mETLDECGtn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can I please get a test plan for this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 00:16:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 22:16:52 +0000
Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-RlA85koD8h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Please provide a step by step test plan to make this easier to QA. Thx!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 00:17:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 05 Oct 2013 22:17:24 +0000
Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-AQWwBo1x7w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |dpk at randomnotes.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 03:55:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 01:55:11 +0000
Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-dOsm0Ye87l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #30 from Doug Kingston <dpk at randomnotes.org> ---
Apply both patches above.  One is the real code and the small one fixes a typo.

Suggested test plan:
Invoke the daemon exercising all the options I added and observe it doing the
intended updates in line with the update interval.

1. Set up a test koha configuration (populate with data if you wish)
2. Ensure that the zebra database is up to date (rebuild_zebra.pl -b -a)
3. Stop any cronjob that may be updating zebra with rebuild_zebra.pl
4. Start rebuild_zebra in daemon mode (rebuild_zebra.pl -daemon -sleep 3 -b -a
v
5. TEST: observe the periodic message "queued records: 0" every 3 seconds. 
this will test the use of -sleep option.
6. Add an authority.
7. TEST: observe the daemon pick up the authority change and update zebra
(which should be within 3 seconds of completing the add operation)
8. TEST: check that you can search for the new authority from the admin
interface
9. Add a biblio.
10. TEST: observe teh daemon pickup up the biblio change and update zebra
(which should be within 3 seconds of completing the add operation)
11. TEST: check that you can search for the new biblio in either OPAC or admin
interface.

Possibly repeat steps 6-11 with authority and biblio modification and deletion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 03:57:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 01:57:13 +0000
Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-onrOxeUqlo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|dpk at randomnotes.org         |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 11:00:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 09:00:08 +0000
Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-N5lNmHOWUt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|katrin.fischer at bsz-bw.de    |dpk at randomnotes.org

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Doug, you wrote the patch, so you are assignee :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 15:22:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 13:22:47 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-kACjhDgrwR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

--- Comment #6 from Ketan Kulkarni <ketan at carvingit.com> ---
Created attachment 21832
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21832&action=edit
One more instance of Shipment replaced with Shipping

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 15:27:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 13:27:45 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-Hh8UJOnji9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21828|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 15:28:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 13:28:16 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-tZzgnGwQId@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 15:30:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 13:30:25 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-nolrdqt45J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21832|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 15:31:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 13:31:01 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-6PpcnC2Oqt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21616|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 15:33:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 13:33:17 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-lTttGNBfMZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

--- Comment #7 from Ketan Kulkarni <ketan at carvingit.com> ---
I am sorry for the mess I have created here. I marked my QA passed patch as
obsolete and I see no way to take it back to that state.

Ketan

(In reply to Katrin Fischer from comment #5)
> Created attachment 21829 [details] [review]
> Bug 10705: Follow-up - shippment cost should be shipping cost
> 
> Term also occurs on the spent page accessible from the funds
> table on the acquisition module start page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 16:19:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 14:19:43 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-TlC19GK2QM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Ketan Kulkarni from comment #7)
> I am sorry for the mess I have created here. I marked my QA passed patch as
> obsolete and I see no way to take it back to that state.

First switch Bug to Signed Off, then you could switch to Passed QA
but that is one of the things we can't do :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 16:49:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 14:49:03 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-hXedt4l06d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 19:17:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 17:17:06 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-05APtkYaCo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18751|0                           |1
        is obsolete|                            |

--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21833
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21833&action=edit
[SIGNED-OFF] Bug 10363: Add 2 packages for authorised values

Currently, the authorised values are anarchically managed :)
We have to have a better way to manage them.
I propose 2 packages in order to execute the sql queries into a package
instead of directly into the pl script.

This development adds:
- A new unique key (category and authorised values) for the
  authorised_values table.
- 2 new packages Koha::AuthorisedValue and Koha::AuthorisedValues
- 1 new unit test file in order to test these 2 packages.

It is a code source evolution, but there is no change for the final user.

Test plan:
1/ Apply the patches
2/ Check that existing authorised values is displayed on your admin
page (admin/authorised_values.pl).
3/ Update an existing one
4/ Create a new category
5/ Create a new AV for this category
6/ Create another one with the same value, an error should be occur.
7/ Delete one AV.
8/ Click everywhere on the authorised values admin page and try to find
a bug.
9/ Launch t/db_dependent/AuthorisedValues.t and check that all tests
pass (1 sql error appears, it is normal).

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Just arrived to this trying to remove one scrolling_list
from a function on C4/Input.pm, and trying to find a module
for authorised values.

Re-tested adding, removing and updating authorised values
No koha-qa errors.
Unit test reports sucess

Think that this is a good module to have.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 19:17:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 17:17:17 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-DJvNtmvgWj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18752|0                           |1
        is obsolete|                            |

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21834
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21834&action=edit
[SIGNED-OFF] Bug 10363: DB Changes: Adds a unique key for the authorised values
table.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 19:17:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 17:17:25 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-utyoXiXTXF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18753|0                           |1
        is obsolete|                            |

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21835
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21835&action=edit
[SIGNED-OFF] Bug 10363: Adds unit tests for Koha::AuthorisedValue[s] packages

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 19:17:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 17:17:40 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-1VglNlIYvT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20729|0                           |1
        is obsolete|                            |

--- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21836
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21836&action=edit
[SIGNED-OFF] Bug 10363: UT: execute tests into a transaction

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 19:18:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 17:18:10 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-HtIO1kCsCH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:12:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:12:32 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-lypSk6wdG6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21828|1                           |0
        is obsolete|                            |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:12:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:12:43 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-YN89uj63RW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21616|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:12:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:12:49 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-xGyZfStiZX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:13:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:13:13 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-9pQG9a21AY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I did a tiny follow-up for the last string and set passed QA - should be all ok
now (hopefully).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:37:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:37:45 +0000
Subject: [Koha-bugs] [Bug 10995] Accessibility: Allow manual entry of
 renewal date and specific due date in circ
In-Reply-To: <bug-10995-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10995-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10995-70-96X6QGmUVT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
+1

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:40:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:40:48 +0000
Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in
 serials-collection.pl
In-Reply-To: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10609-70-RmVs9N4hhZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:40:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:40:52 +0000
Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in
 serials-collection.pl
In-Reply-To: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10609-70-slxB7Q2B7y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21580|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21837
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21837&action=edit
[PASSED QA] Bug 10609: Use branch name rather than branch code in
serials-collection.pl (3.12.x)

This is the 3.12.x compatible version of the patch for 10609.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Serial collection page now displays the branch description
instead of the branchcode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:57:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:57:19 +0000
Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be
	added
In-Reply-To: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10648-70-e18naOENrI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:57:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:57:22 +0000
Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be
	added
In-Reply-To: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10648-70-XWyjA2B5vc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21177|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21838
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21838&action=edit
[PASSED QA][3.12.x] Bug 10648 - In records merge greatest field can not be
added

When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl),
the destination record is build using the fields and subfields
checked in source records.
When a field is checked, the javascript code searches in
destination record a field with a greater tag number to insert
new field before.
When the new field tag number is greater than all existing field
tag numbers, the field is not added.

This patch corrects this by adding at end if no greater field tag
number exists. Also adds a sort of fields by tag number because
all merge code is based on this.

Test plan :
- Add to a framework a repeatable field with the greates non
  existing tag number. For example 998.
- Edit to records with this framework and add them a value in this
  tag.
- Put those records is a list
- Go to this list and check the two records
- Click on "Merge selected"
- Click on next
- Go to second source record
- Click on the greatest tag number. for example 998.
=> The field is added at the end of destination record

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
All tests and QA script pass. Fixed some tabs.
Could reproduce the behaviour by defining a 999$z subfield.
After the patch it works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:57:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:57:59 +0000
Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be
	added
In-Reply-To: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10648-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10648-70-hgQRQ0H3bg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Patch for master still needs QA, will do that later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct  6 23:59:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 21:59:14 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-VZK40B49iI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:00:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:00:19 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-8W90MqW7VV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21839
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21839&action=edit
Bug 10944 - Mixed content warnings for covers on staff client

This switches the URLs used to access Amazon's cover images to the SSL image
server, preventing warnings when using this on a secure site.

To test:
* Enable Amazon images in the sysprefs, all other cover images off.
* Do a search in the staff client. Using firebug or similar, inspect the
  images that indicate both "no image found" and the covers.
* Are they all https, and showing correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:06:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:06:04 +0000
Subject: [Koha-bugs] [Bug 6435] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-pi7kRDwFGn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.4                         |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:06:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:06:21 +0000
Subject: [Koha-bugs] [Bug 8007] Discharge management
In-Reply-To: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8007-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8007-70-bkJ3Qk2fct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:06:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:06:37 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-XZ4ZUpbrPK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.14                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:07:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:07:51 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-KFtgaLcBIT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|3.12                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:14:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:14:47 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-LAHAM3nM6B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is a blocker - as Uli from BSZ has signed off I shouldn't do QA and I
honestly can't because I don't know how to set up a test environment for LDAP.
Is there someone else who can on the QA team?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:16:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:16:55 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-eIp5yRNYTz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20876|0                           |1
        is obsolete|                            |

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21840
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21840&action=edit
[SIGNED-OFF] Bug 7421 Add UNIMARC DOM Filter

I took as a base the patch of F. Demians, but made a lot of changes, so I think
it is more logical to create a new patch as the behavior is not the same as
previous patch.
I tried to define DOM config files as a "miror" of record.abs, so the behavior
be the same.
If it is OK, we will be able to improve indexing later, for example suppressing
warns, managing indicators or subdivisions, etc.
I made some little changes to record.abs :
- comments
- 216 was indexed in Conference-name as well as Trademark. I supposes
"Conference-name" is an error, so I indexed only in Trademark
- index 2 new notes : 340 / 356

The only difference between record.abs and DOM is that DOM config files does
not index complete fields, but subfields.
Ex :
melm 200 ===> <kohaidx:index_subfields tag="200" subfields="abcdfgjxyz">
I took all the subfields from the UNIMARC Authorities manual. The only
subfields not indexed are numeric subfields : $7, $8 for language of record,
and $0,2,3,5,6 for 4XX/5XX/7XX

To test :
- index a set of bib and auth records with GRS-1
- make some searches on different kind of authorities
- index the same records with DOM
- make the same searches
- You are not supposed to see differences

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
As I am not a UNIMARC user it's hard for me to test this, but
while testing other authority related patches I noticed that I couldn't
index the UNIMARC authorities of the sample base. The files are obviously
missing and reindex_zebra.pl notes this. With this patch applied,
indexing works and authorities are searchable in my installation.

[2013-10-07] Added second sign off from Vitor.

Signed-off-by: Vitor Fernandes <fvernandes at keep.pt>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 00:38:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 06 Oct 2013 22:38:47 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-o1VtIGXLFK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Bit stuck on testing here as I have some errors on running a full reindex:
REINDEXING zebra
====================
00:34:32-07/10 zebraidx(27269) [warn] isamb: Inconsistent register (2)
zebraidx: isamb.c:1102: insert_leaf: Assertion `*lookahead_mode' failed.
00:34:33-07/10 zebraidx(27279) [warn] previous transaction didn't reach commit

I will have to investigate some more.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 06:58:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 04:58:47 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-Bnvlgbw4BV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

--- Comment #4 from Amit <amitddng135 at gmail.com> ---
Created attachment 21841
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21841&action=edit
Email sending is not working in claim notice

Email sending is not working in claim notice.
This patch will not check whether staff patron's email address or not for
sending claim notices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 06:59:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 04:59:02 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-fibizo8sZu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 08:42:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 06:42:19 +0000
Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display
 properly information on parallel form
In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10335-70-fxxQs8xk9i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I have tried and I can't seem to catalog it right, can I get a full example
with all fields and subfields to enter?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 08:47:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 06:47:38 +0000
Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display
 properly information on parallel form
In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10335-70-JDrzuXrnUv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 08:47:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 06:47:42 +0000
Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display
 properly information on parallel form
In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10335-70-ZgoSWXD0y9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20869|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 21842
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21842&action=edit
[PASSED QA] Bug 10335 - UNIMARC authorities search doesn't display properly
information on parallel form

The patch corrects the issue and should not harm those who (improperly)
put only one triple in $8

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors.
Same result on OPAC and STAFF

Turns out that test plan is wrong,
you neet to fill tag 200ab, not 100ab, for main heading.
I filled 100a with some example data from UNIMARC auth manual.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Took me a bit to figure it out, works according to test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 08:59:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 06:59:49 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-uokz6ye4nu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
sudo apt-get install ldap-server

Make sure to remember the password you use to set this up!
Next, we'll figure out the connection string.

sudo slapcat

The second entries 'dn' line will be important in setting up LDAP
authentication

sudo apt-get install phpldapadmin

Now you should be able to web browse to http.../phpldapadmin and actually log
in with the information you got from slapcat.

cn=admin;dc=<from slapcat>
<password set while installing ldap-server>

Congratulations, you have an LDAP server with just the admin user set up on
your machine. Feel free to "sudo apt-get remove phpldapadmin". That was just to
prove the set up was working.

Then you'll need to tweak your koha-conf.xml

hostname should be the nice name you'd use for the machine.
base I matched to be "dc=<slapcat mess>"
same with user.
and of course principle_name.
in the mapping section, the branchcode and patron code better be in your system
already.


<useldapserver>1</useldapserver><!-- see C4::Auth_with_ldap for extra configs
you must add if you want to turn this on -->
<ldapserver id='ldapserver'  listenref='ldapserver'>
<hostname>demo.library.kohasystem.ca</hostname>
<base>dc=nodomain</base>
<user>CN=admin,OU=Special,OU=Accounts,DC=nodomain</user>
<pass>ldap123</pass>
<replicate>1</replicate>
<update>1</update>
<auth_by_bind>1</auth_by_bind>
<principal_name>CN=%s,DC=nodomain</principal_name>
<mapping>
<firstname    is='givenname'></firstname>
<surname      is='sn'> </surname>
<address      is='postaladdress'>3900 University Blvd</address>
<city         is='l'>Tyler, TX</city>
<zipcode      is='postalcode'>75799</zipcode>
<branchcode   is=''>MNL</branchcode>
<userid       is='cn'></userid>
<password     is=''></password>
<cardnumber   is='extensionattribute2'></cardnumber>
<email        is='userprincipalname'></email>
<categorycode is=''>PT</categorycode>
<phone        is='telephonenumber'>903-566-7343</phone>
<dateenrolled is=''>2011-03-27</dateenrolled>
<dateexpiry   is=''>2011-05-13</dateexpiry>
</mapping>
</ldapserver>

Hope this helps, KF.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:00:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:00:39 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-ET7KeTXLua@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
The strange message I got was due to the checkin message attached to my
itemtype.
Not sure if the checkin message should be disabled if checkin fails? Propably
it should.

circ/returns.pl::>>
# Check if we should display a checkin message, based on the the item
# type of the checked in item
    my $itemtype = C4::ItemType->get( $biblio->{'itemtype'} );
    if ( $itemtype->{'checkinmsg'} ) {
        ...print checking message...;
    }

Still:
The item which failed to checkin is still added to the list of checked in
material at the end of the page.


laurendthl has requested the ability for a librarian to override the transfer
limit. This is probably pretty useful in ILL-cases.
And they are the bug sponsor as well :)

SYNOPSIS:
-OPTIONAL: Disable checkin message
-OPTIONAL: Do not add the failed checkin to the "Checked-in items"-table
-Make it possible for a librarian to override the branchtransferlimit (no
special permissions requested in the RFP)
--Log this override event to catch misbehaving librarians.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:02:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:02:50 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-a5zLeT0Mri@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hello
That's maybe related with other errors in the config file.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:06:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:06:43 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-kM8eRZFscQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
By the way it is probably not a good thing to index all subfields of 995 in the
same item index, because some subfields contains data useless to index (as
internal notes...).
But it could be the object of an other patch after this one is pushed.


Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:09:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:09:09 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-cfrIuZqGtu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #17 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Thanks. What do you think of my comment 12?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:19:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:19:50 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-bFYcUHEaiH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Mark. I am not sure when I have time for this - if anyone wants to have a
go on this I would appreciate it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:44:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:44:09 +0000
Subject: [Koha-bugs] [Bug 11001] New: The aqorders.branchcode field is
 missing into the DB
Message-ID: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

            Bug ID: 11001
           Summary: The aqorders.branchcode field is missing into the DB
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:44:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:44:24 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-Y0PJrMM8JF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
            Summary|The aqorders.branchcode     |The aqorders.branchcode
                   |field is missing into the   |field is missing in the DB
                   |DB                          |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:48:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:48:03 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-nF52f5LfWk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21843
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21843&action=edit
Bug 11001: aqorders.branchcode is missing

Some BibLibre developments have been taken into account a
aqorders.branchcode field but not one adds it (cf bug 5335, 5339, etc.).

This patch adds this new field in the DB and the ability to fill it
from the new order empty form.

Test plan:
- execute the DB entry.
- add a new order to a basket.
- the select "library" value should be the library of the connected
  librarian.
- save.
- close the basket.
- edit/show the order and verify the library value is the same as
  selected before.
- receive the order.
- search invoices by library and verify results are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 09:48:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 07:48:00 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-oyda4shtuZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 10:13:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 08:13:33 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-Y3k2HIqZu1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21843|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21844
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21844&action=edit
Bug 11001: aqorders.branchcode is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 10:31:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 08:31:59 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-5KSbODsfp8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Also when a Patron is placing a hold,
the Patron should be able to choose the pickup location even if there are no
available/holdable Items in his home branch.
So instead of failing to reach the "Place hold"-dialogue and choose the
pickuplocation, the Patron should be sent to the
koha/opac-reserve.pl?biblionumber=xxx with a notifcation that no items are
available to his pickup location, prompting the Patron to choose another pickup
location.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 10:41:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 08:41:03 +0000
Subject: [Koha-bugs] [Bug 11002] New: Mandatory fields are not translatable
Message-ID: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

            Bug ID: 11002
           Summary: Mandatory fields are not translatable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When the pref BorrowerMandatoryField is set and a librarian forget to fill
fields, a js popup appears with the following message:
  "The following fields are mandatory: surname, etc."
The fields are not translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 10:41:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 08:41:14 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-1mKDjK8gaK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 10:44:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 08:44:38 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-ZqLsh1Os5z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 10:44:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 08:44:41 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-AdfBmfrR25@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21845
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21845&action=edit
Bug 11002: Mandatory fields are not translatable

When the pref BorrowerMandatoryField is set and a librarian forget to
fill fields, a js popup appears with the following message:
  "The following fields are mandatory: surname, etc."
The fields are not translatable.

Test plan:
- fill the pref BorrowerMandatoryField with something like:
  title|zipcode|surname|cardnumber|branchcode
- go the members/memberentry.pl?op=add page
- verify you are not allowed to add the patron without filling all
  mandatory fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:17:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:17:06 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-MCRMt3m7yV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

I am a bit worried about the consequences of this. I think we can not assume
safely that a library only orders items for itself, but there are also use
cases where items for other branches will be ordered. How will this appear in
the interface? As ordering branch? Or do we assume that the order will go to
this library as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:33:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:33:10 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-LTqjt0zahI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
            Summary|intranet cart email broken  |intranet cart email broken
                   |for non english templates   |
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:36:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:36:00 +0000
Subject: [Koha-bugs] [Bug 10605] Problems with translated cart email sent
	from OPAC
In-Reply-To: <bug-10605-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10605-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10605-70-xadbL6yxaY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10605

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:36:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:36:03 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-MpQ8upZjyB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Fridolyn, please also take a look at bug 10605 - it's still waiting for a
sign off (*hint*) and a correction to the encoding that will also be needed for
the intranet I think :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:40:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:40:08 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-GPaUO1tS5a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|intranet cart email broken  |intranet cart email broken
                   |                            |for non english templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:41:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:41:08 +0000
Subject: [Koha-bugs] [Bug 11003] New: intranet cart email broken
Message-ID: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

            Bug ID: 11003
           Summary: intranet cart email broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

A call to yuiToolbar breaks js code on the cart page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:43:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:43:15 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-znL4WWd1l2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:43:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:43:17 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-WwxZ3msCLG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21846
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21846&action=edit
Bug 11003: intranet cart email broken

A call to yuiToolbar breaks js code on the cart page.

Test plan:
- add some biblio to your cart
- open the cart
- try to send the cart, the url is basket/sendbasket.pl?bib_list=null
- apply the patch
- reload the cart view
- try to send the cart, the url is now
  basket/sendbasket.pl?bib_list=X,Y,Z

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:43:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:43:39 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-ASFxxYm7hv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:43:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:43:57 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-B8hI17SGUK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9218

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 11:43:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 09:43:57 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-PPvWF7mjND@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11003

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 12:28:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 10:28:55 +0000
Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron
 values for serial items
In-Reply-To: <bug-10825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10825-70-yfgOqvX0yV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

--- Comment #8 from Bob Birchall <bob at calyx.net.au> ---
(In reply to Katrin Fischer from comment #7)
> Hi Mason,
> 
> I am sorry, but I can't reproduce the wrong display. I am wondering where
> the date and serialseq should be pulled from? Can you please clarify?


Hi Cait, as far as I understand, the problem arises only for serials items
received through the Serials module.  Mason tells me that both items.enumchron
and serial.serialseq are displayed, hence the duplication.  I hope this helps.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 12:32:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 10:32:30 +0000
Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron
 values for serial items
In-Reply-To: <bug-10825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10825-70-m8MrIbwLoA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Bob,

thx for the comment :) I had tested with items created in serials, but I just
couldn't make both fields show up :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 14:23:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 12:23:12 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-S9oIhRcxQ2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #18 from Blou <philippe.blouin at inlibro.com> ---
(In reply to mathieu saby from comment #17)
> Thanks. What do you think of my comment 12?
> 
> Mathieu

Technically, it does that.  The tableS contain all the language information,
and the preference determines which one is used by the drop down.  The default
is EMPTY.  I find that cleaner and easier to maintain long term.  If nothing is
in the preference, the whole list is returned.

I must point out I don't know the difference between Marc21 and iso codes.  I
detailed it as using iso 639-2 just because some variable in the code was
refering to it.  The fact is, it is using whichever code we are currently
building our "language hash" with.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 14:41:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 12:41:15 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-QeFxjvpzte@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 14:41:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 12:41:20 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-DiuO2JWab4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Blou from comment #18)
> (In reply to mathieu saby from comment #17)
> > Thanks. What do you think of my comment 12?
> > 
> > Mathieu
> 
> Technically, it does that.  The tableS contain all the language information,
> and the preference determines which one is used by the drop down.  The
> default is EMPTY.  I find that cleaner and easier to maintain long term.  If
> nothing is in the preference, the whole list is returned.
> 
> I must point out I don't know the difference between Marc21 and iso codes. 
> I detailed it as using iso 639-2 just because some variable in the code was
> refering to it.  The fact is, it is using whichever code we are currently
> building our "language hash" with.


I am not an expert, but the differences seems to be slight, and mainly between
the names of the languages, not the codes themselves.
http://www.loc.gov/marc/languages/introduction.pdf

"ISO 639-2 (Codes for the representation of names of languages-- Part 2:
alpha-3 code) was based on the MARC Code List for Languages and published in
1998. In the 22 cases where the ISO 639-2 list has two alternative codes, the
bibliographic code is the same as the MARC code. Language names in ISO 639-2
are not necessarily the same as those in MARC, particularly because of the
practice of correlating the MARC language names with those used in
Library of Congress Subject Headings. The MARC list includes references
for unused forms of language names, while the ISO list has in some cases
included alternative name forms,but many are lacking, since this practice of
supplying alternate forms has only recently been implemented.
In addition the MARC documentation includes a list of individual languages
under collective codes or language groups, while the ISO list only includes the
group codes themselves.The Library of Congress is maintenance agency for both
lists, and the two are kept compatible in terms of code additions and deletion"


M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 14:41:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 12:41:23 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-q3tpnzZlmx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21847
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21847&action=edit
Bug 9218: intranet cart email broken for non english templates

While bug 9189 is not resolved, we have to find workaround for
templates broken by missing carriage return.

This (dirty) patch adds a personal tag "PARAGRAPH" for adding new lines.

Test plan:
- add somes notices to the cart
- try to send the cart by email
- the email should be the same as before
- translate templates and retry with another language. Before this patch,
  the email was empty. With this patch, it contains the list of records
  and items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 14:48:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 12:48:49 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-lcFGCZAJN2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

hm not sure, but why not copy the OPAC solution 1:1? I think normal HTML is
used there and stripped out using some TT magic:

   5 [% USE HtmlToText %]
   6 [% myhtml FILTER html2text(leftmargin => 0, rightmargin => 0) %]
   7 [% myhtmltext | html2text %]

http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt;h=dc6929da2c3b357f92d90af5ef6f505152bf3bd6;hb=b9c85431ddf967ecadf88ee9d2cbe14ac95d5be4

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 14:58:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 12:58:52 +0000
Subject: [Koha-bugs] [Bug 11004] New: Make xmlControlfield.js use the
 marcflavour syspref to look for XML files
Message-ID: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004

            Bug ID: 11004
           Summary: Make xmlControlfield.js use the marcflavour syspref to
                    look for XML files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org

On line 208, xmlControlfield.js is hardcoded to look for MARC21 XML files: 

  url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml",

In order to fix Bug 10997 I will need this JS to use the value of the
marcflavour syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:02:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:02:29 +0000
Subject: [Koha-bugs] [Bug 10997] Modernize value_builders for NORMARC
In-Reply-To: <bug-10997-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10997-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10997-70-cZzjxomqpA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10997

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11004

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:02:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:02:29 +0000
Subject: [Koha-bugs] [Bug 11004] Make xmlControlfield.js use the marcflavour
 syspref to look for XML files
In-Reply-To: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11004-70-vxJ9akdade@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10997

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:17:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:17:58 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-w6qNAeHpO2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #161 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Just to add my $0.02 since I was original author of encoding fixes: this patch
indeed goes against idea of correctly encoding everything in Koha, but does fix
some really broken places in current code.

I would appreciate if this patch was accepted upstream (encoding of borrower
characters is my most pressing concern) and if nothing else it does mark few
more places in which we will have to take a look when making koha utf-8 clean.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:26:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:26:48 +0000
Subject: [Koha-bugs] [Bug 11004] Make xmlControlfield.js use the marcflavour
 syspref to look for XML files
In-Reply-To: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11004-70-ZcQi5hPAix@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:26:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:26:51 +0000
Subject: [Koha-bugs] [Bug 11004] Make xmlControlfield.js use the marcflavour
 syspref to look for XML files
In-Reply-To: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11004-70-3Kx9mkcSQ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004

--- Comment #1 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 21848
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21848&action=edit
Bug 11004 - Make xmlControlfield.js use the marcflavour syspref to look for XML
files

Currently, xmlControlfield.js is hard coded to look for XML files for MARC21:

  url: this.themelang + "/data/marc21_field_" + this.tagfield + ".xml",

This patch makes this code use the value from the marcflavour syspref, as a
preparation for making the NORMARC value builders use the XML technique
employed by the MARC21 value builders for 006 and 008.

To test:
- Make sure you have a MARC21 installation
- Set marcflavour = NORMARC
- Go to Cataloguing and start a new record with the default framework
- Open the value builders for 006 and 008 and observe that they still work,
showing
  the coded values for MARC21
- Apply this patch
- Check the value builders for 006 and 008 and observe that you get a truncated
view
  with an empty "Select a type of material" dropdown
- Use e.g. the Net console in Firebug to observe requests to
  http://localhost/intranet-tmpl/prog/en/data/normarc_field_008.xml
  that result in a 404 status
- Set marcflavour = MARC21
- Observe that the value builders for 006 and 008 are now fully working
- 006 and 008 should be the only value builders affected by this change, since
  they are the only ones using xmlControlfield.js, but please also verify that
  other value builders are still working as expected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:45:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:45:19 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-NX33E6aMS0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21512|0                           |1
        is obsolete|                            |
  Attachment #21521|0                           |1
        is obsolete|                            |

--- Comment #13 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21849
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21849&action=edit
Add forgot password link to OPAC

Following what I learned last week, I 
1) fixed updatedatabase.pl ('' for escaping quotes)
2) put setprefs.sql (alphabetical order)
3) renamed a variable (very minor)
4) packaged it all in one new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:45:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:45:43 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-W1a31XZVRG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #3)
> Hi Jonathan,
> 
> hm not sure, but why not copy the OPAC solution 1:1?

Pfff, I don't know...
quick_and_dirty--

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:45:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:45:53 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-EJQwv70e6C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21847|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:45:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:45:59 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-K5sCdybDEg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:47:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:47:02 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-m1TYOJQEw5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21844|0                           |1
        is obsolete|                            |

--- Comment #4 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21850
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21850&action=edit
aqorders.branchcode is missing

I sign off the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:47:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:47:34 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-wi7U6VoxiU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:51:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:51:19 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-AulAo6YT2r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #3)
> Hi Jonathan,
> 
> I am a bit worried about the consequences of this. I think we can not assume
> safely that a library only orders items for itself, but there are also use
> cases where items for other branches will be ordered. How will this appear
> in the interface? As ordering branch? Or do we assume that the order will go
> to this library as well?

Katrin, the idea behind this value is to know the library where the order will
be sent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 15:53:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 13:53:51 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-OH9XBV375b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry, just trying to think how this will work :)
We have the option to set a different billing and delivery place in basket
groups, so this would overwrite the aqorders branch then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:15:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:15:09 +0000
Subject: [Koha-bugs] [Bug 11005] New: Centralize the
 UseBranchTransferLimits-check under one function
Message-ID: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

            Bug ID: 11005
           Summary: Centralize the UseBranchTransferLimits-check under one
                    function
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org

Currently the IsBranchTransferAllowed() doesn't take into account multiple
different global preferences and the check for IsBranchTransferAllowed() is
really messy with multiple if-else statements.
Move these global parameter checks to the core
IsBranchTransferAllowed()-function to make using the function clearer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:15:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:15:20 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-mp00znrUoN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

--- Comment #13 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Test plan : 
- Launch UNIMARC_sync_date_created_with_marc_biblio.pl : 
- with -c 512
=> Script dies with message : "date-created-marc field is greated that 009, it
should have a subfield."
- with -c 006a
=> Script dies with message : "die "date-created-marc field is lower that 010,
it should not have a subfield."
- with -m 512
=> Script dies with message : "date-modified-marc field is greated that 009, it
should have a subfield."
- with -m 006a
=> Script dies with message : "die "date-modified-marc field is lower that 010,
it should not have a subfield."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:17:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:17:04 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-HghN3YPpqM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
   Patch complexity|---                         |Small patch
         Depends on|                            |7376
  Change sponsored?|---                         |Sponsored
           Assignee|gmcharlt at gmail.com          |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:17:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:17:04 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-fIYV9Pm12Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11005

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:17:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:17:28 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-8btPe80PzF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:18:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:18:24 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-orgTMY5Qne@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11005

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:18:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:18:24 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-3H5P99PyaM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10993

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:25:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:25:12 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-LOGWrKJDcA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
1st draft on the wiki
wiki.koha-community.org/wiki/Handling_Prices

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:26:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:26:34 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-HotOFhvZ1D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21851
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21851&action=edit
Refactored the IsBranchTransferAllowed() and it's dependencies. Created test
cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:36:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:36:29 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-9bUC56qp8t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #15 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #14)
> I had problems last time to test this, because I was not able to create
> authorities in my UNIMARC installation. Could you please provide some
> instructions?
Does it not work with a UNIMARC sandbox ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:41:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:41:10 +0000
Subject: [Koha-bugs] [Bug 11004] Make xmlControlfield.js use the marcflavour
 syspref to look for XML files
In-Reply-To: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11004-70-X5fwta9wir@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Maybe we could use the xml files for unimarc latter. I did not realized before
that value builders were not build the same way in different marc flavor...

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:41:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:41:53 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-SEWLH2vxs9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Fridolyn, I have my own UNIMARC installation with the data from the sandbox.
My problem is I need to create a test case to see if this works correctly and
my cataloguing skills in UNIMARC are limited.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:45:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:45:00 +0000
Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its
	own id
In-Reply-To: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10850-70-26v38T0ppF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20993|0                           |1
        is obsolete|                            |

--- Comment #3 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21852
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21852&action=edit
Give Quick spine label template page its own id

I sign off the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:45:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:45:11 +0000
Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its
	own id
In-Reply-To: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10850-70-S5mc32y5Kf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |paola.rossi at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 16:52:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 14:52:30 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-BxSUyW2FKZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #16 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Thank you Mathieu for your wiki page.
I have just tested the comportement in master for the calculation of the budget
summary in acqui-home.pl.
If you choose for the vendor :
* list price include tax : YES / invoice price include tax : YES
or 
* list price include tax : YES / invoice price include tax : NO

The spending are tax included 

but if you choose :
* list price include tax : NO / invoice price include tax : YES
or
* list price include tax : NO / invoice price include tax : NO

The spending are without the tax

I think there's a bug here.

In any case, my patch isn't appropriate anymore.

The unitprice in acqorders are re-calculted and I don't take this into account
in this patch.

I try to find out an other way to have the right spending in the summary of
acqui-home.pl

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:11:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:11:00 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-exQIO1R0wz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20745|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:12:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:12:29 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-3kZiaaHesY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #33 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21853
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21853&action=edit
Bug 10951 - Extra Patch to fix next sentence.

We noticed that an extra . (dot) was appearing in the message.  And if the
"self-registration" was ON, it started on a new line without an uppercase.  
Very minor, but style is important.  I'm sorry to break a sign-off we worked so
hard to get :(

Code change is one line in one file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:22:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:22:35 +0000
Subject: [Koha-bugs] [Bug 11006] New: Useless column totalamount in aqorders
	table
Message-ID: <bug-11006-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11006

            Bug ID: 11006
           Summary: Useless column totalamount in aqorders table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In Schemaspy, column totalamount is reported as "not used? always NULL".
"grep -r totalamount *" give this result, so I suppose it is true : 

blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql:  `totalamount`
decimal(28,6) default NULL, -- not used? always NULL
blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:totalamount
decimal(28,6) default NULL,
installer/data/mysql/kohastructure.sql:  `totalamount` decimal(28,6) default
NULL, -- not used? always NULL
installer/data/Pg/kohastructure.sql:totalamount decimal(28,6) default NULL,
t/db_dependent/Acquisition.t:                         totalamount

I propose the deletion of this column.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:25:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:25:51 +0000
Subject: [Koha-bugs] [Bug 11007] New: Useless column cancelledby in aqorders
	table
Message-ID: <bug-11007-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11007

            Bug ID: 11007
           Summary: Useless column cancelledby in aqorders table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In Schemaspy, column cancelledby is reported as "not used? always NULL".
"grep -r cancelledby *" give this result, so I suppose it is true : 

blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql:  `cancelledby`
varchar(10) default NULL, -- not used? always NULL
blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:cancelledby
varchar(10) default NULL,
installer/data/mysql/kohastructure.sql:  `cancelledby` varchar(10) default
NULL, -- not used? always NULL
installer/data/Pg/kohastructure.sql:cancelledby varchar(10) default NULL,
t/db_dependent/Acquisition.t:                         cancelledby


I propose the deletion of this column.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:30:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:30:38 +0000
Subject: [Koha-bugs] [Bug 11008] New: Useless column supplierreference in
	aqorders table
Message-ID: <bug-11008-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008

            Bug ID: 11008
           Summary: Useless column supplierreference in aqorders table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In Schemaspy, column supplierreference is reported as "not used? always NULL".
"grep -r supplierreference *" give this result, so I suppose it is true : 


blib/INTRANET_CGI_DIR/installer/data/mysql/update22to30.pl:               
field   => 'supplierreference',
blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql: 
`supplierreference` mediumtext, -- not used? always NULL
blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:supplierreference
text,
installer/data/mysql/update22to30.pl:                field   =>
'supplierreference',
installer/data/mysql/kohastructure.sql:  `supplierreference` mediumtext, -- not
used? always NULL
installer/data/Pg/kohastructure.sql:supplierreference text,
t/db_dependent/Acquisition.t:                         supplierreference

I propose the deletion of this column.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:32:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:32:07 +0000
Subject: [Koha-bugs] [Bug 11009] New: Do not allow reading records of
	anonymous patron
Message-ID: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

            Bug ID: 11009
           Summary: Do not allow reading records of anonymous patron
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When using an anonymous patron to anonymise issues history, this patron may
have a huge number of old issues.
In this case, trying to display the reading history of this patron will perform
a huge SQL query.
It is not usefull to have the reading history of this anonymous patron.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 17:43:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 15:43:08 +0000
Subject: [Koha-bugs] [Bug 11010] New: Useless column purchaseordernumber in
 aqorders table
Message-ID: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

            Bug ID: 11010
           Summary: Useless column purchaseordernumber in aqorders table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In Schemaspy, column purchaseordernumber is reported as "not used? always
NULL".
"grep -r cancelledby *" give this result : 

C4/Acquisition.pm:The following keys are used: "biblionumber", "title",
"basketno", "quantity", "notes", "rrp", "ecost", "gstrate", "unitprice",
"subscription", "sort1", "sort2", "booksellerinvoicenumber", "listprice",
"budgetdate", "purchaseordernumber", "branchcode", "booksellerinvoicenumber",
"budget_id".
C4/Acquisition.pm:                datereceived,purchaseordernumber,
installer/data/mysql/update22to30.pl:                field   =>
'purchaseordernumber',
installer/data/mysql/kohastructure.sql:  `purchaseordernumber` mediumtext, --
not used? always NULL
installer/data/Pg/kohastructure.sql:purchaseordernumber text,
t/db_dependent/Acquisition.t:                         purchaseordernumber


In C4::Acquisition.pm::GetParcels, the SELECT statement retreives
purchaseordernumber, but no value is pushed to that column in any part of
Koha's code. So I think it is useless.

I propose the deletion of this column.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 18:26:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 16:26:16 +0000
Subject: [Koha-bugs] [Bug 11010] Useless column purchaseordernumber in
	aqorders table
In-Reply-To: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11010-70-vmT5ejLHKc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
There is a patch on bug 4456 to utilize this field. see also bug 4960

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:20:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:20:59 +0000
Subject: [Koha-bugs] [Bug 11010] Useless column purchaseordernumber in
	aqorders table
In-Reply-To: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11010-70-ycckf1qpjB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Thank you.
4456 is very old, and there is nothing attached to 4456.
Do you think these enh could be "revived" ?
What's the difference between the ordernumber and the purchaseordernumber?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:21:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:21:43 +0000
Subject: [Koha-bugs] [Bug 11010] Useless column purchaseordernumber in
	aqorders table
In-Reply-To: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11010-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11010-70-mq1hFxCQvR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
oups, the patch attached to 4456 is not very old, sorry for that.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:25:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:25:42 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-jOGoHt9FLh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #34 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21854
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21854&action=edit
The change was causing issue with the next sentence. Adjusted the start
(uppercase) and ending (dot) on self-registration invitation.

Modified opac-auth.tt

http://bugs.koha-community.org/show_bug.cgi?id=10951

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:28:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:28:03 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-uDu2f1jToQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #35 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21855
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21855&action=edit
[ SIGNED OFF] Bug 10951 - Tweaked opac-auth.tt sentence.

The change was causing issue with the next sentence. Adjusted
the start (uppercase) and ending (dot) on self-registration
invitation.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:28:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:28:18 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-ysSKBGYMEr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21853|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:28:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:28:39 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-fL8cqnsNMN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21854|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:35:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:35:54 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-uGqghoQd2O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #36 from M. Tompsett <mtompset at hotmail.com> ---
The patch was such a minor tweak. Unless someone wants to complain about a few
pixels shifting up between the default message and the one that is preloaded, I
see no reason for QA to fail this. Though, optimization-wise, perhaps a blank
setting and not filling in the system preference is better? It would certainly
have saved us the escaping headache. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:54:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:54:05 +0000
Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable
 field through preferences
In-Reply-To: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10951-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10951-70-stt5dDsfVN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951

--- Comment #37 from Blou <philippe.blouin at inlibro.com> ---
Well, not sure I should say that, but the patch would have worked perfectly
without messing the preference, indeed.  There's a default value in the .tt
that would have done the job.

I can't tell you how we got to this.  But if I can ship you some Tylenol (for
the headache I caused), I'll be happy to do.

I made sure to reuse the lessons on my other patches.  They should be a lot
easier on the signee, I promess.

Thanks again and again!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 19:54:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 17:54:22 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-nLUy62m5GS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to mathieu saby from comment #19)
> (In reply to Blou from comment #18)
> > (In reply to mathieu saby from comment #17)
> > > Thanks. What do you think of my comment 12?
> > > 
> > > Mathieu
> > 
> > Technically, it does that.  The tableS contain all the language information,
> > and the preference determines which one is used by the drop down.  The
> > default is EMPTY.  I find that cleaner and easier to maintain long term.  If
> > nothing is in the preference, the whole list is returned.
> > 
OK for me.
But I as soon as your patch is pushed, I think I or other french ppl will add
to the SQL the iso codes missing for french libraries (french regional
languages, old french, middle french, etc.). And other people will do the same
for other codes I suppose. So the best would be to add all iso codes in one
operation to avoid mistakes. But this could be done after your patch is pushed.
So I think every library will soon need to use your syspref if they don't want
to have 400 codes in the dropdown menu ;-) But that's not an issue if the
syspref is working well.
Just a question : if the syspref is ita|fre or fre|ita, does it change the
order of display of the languages in the dropdown menu?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:03:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:03:10 +0000
Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in
 serials-collection.pl
In-Reply-To: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10609-70-90TuLHoGgZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Stable

--- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:05:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:05:55 +0000
Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for
 bibliographic information on OPAC results and detail pages (UNIMARC)
In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10218-70-oz2oJAiBuq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Mathieu!

Marked 'Pushed to stable' as there's a NORMARC-specific bug for the remaining
NORMARC fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:06:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:06:08 +0000
Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for
 bibliographic information on OPAC results and detail pages (UNIMARC)
In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10218-70-fiEwgIb2jf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:06:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:06:18 +0000
Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for
 bibliographic information on OPAC results and detail pages (UNIMARC)
In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10218-70-1twOUeOgUg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:06:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:06:26 +0000
Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for
 bibliographic information on OPAC results and detail pages (UNIMARC)
In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10218-70-nytIymnEF8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Stable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:07:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:07:09 +0000
Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use
 ti, phr indexes like other linking entries
In-Reply-To: <bug-10793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10793-70-MgaJrMT7Qx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:20:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:20:59 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-mNxhJ6gYuZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

--- Comment #21 from Eric B?gin <eric.begin at inLibro.com> ---

> Just a question : if the syspref is ita|fre or fre|ita, does it change the
> order of display of the languages in the dropdown menu?

>From what I remember, the syspref is just a filter on the languages list, it
doesn't affect the order

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:35:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:35:56 +0000
Subject: [Koha-bugs] [Bug 11011] New: rephrase "in keyword" in OPAC
	authority search
Message-ID: <bug-11011-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11011

            Bug ID: 11011
           Summary: rephrase "in keyword" in OPAC authority search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In OPAC authority search, you can choose to search "in keyword". I am not
fluent in english but I find this wording awkward (and the french translation
too, of course)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 20:55:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 18:55:04 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-buN45WYEZV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
As you said, the order is not altered.
It works well with "," or  "|" separator.
I tried to put a lot of codes in the syspref to see if there is a limit. I hope
not, but I don't think so.
I sign off.

I my opinion further enh could be :
- add the list of all iso codes in database
- make the order dependant of the order of codes in syspref, or of the
alphabetcial order of languages in the langugage of OPAC (currenty the sorting
order is based on the english name)
- make 2 sysprefs (one for OPAC and one for Staff)
- display the "native" name after the translated one (ex : "italien
(italiano)"). It would improve UX, because the main public of a french or
english library is not italian speaking people.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:00:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:00:43 +0000
Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced
 search through system preferences
In-Reply-To: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10986-70-skrDXzk9IY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21736|0                           |1
        is obsolete|                            |

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21856
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21856&action=edit
Bugs-10986-Limit-the-list-of-languages-in-advanced

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:06:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:06:44 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-vy2hE2sZ38@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21533|0                           |1
        is obsolete|                            |

--- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21857
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21857&action=edit
Bug 10963 - [1/9] - Simplified creation of MARC21 sample frameworks

Patch 1/9

This patch modifies fast add framework
Corrected to put all tags on tab 0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:56:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:56:19 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-ArsxsMw0Eo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

--- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 21858
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21858&action=edit
Bug 10309 [Follow-up] Updates for Bug 6594, Schema.org structured data

This patch adds the changes from Bug 6594:

"To support schema.org processors, such as Google, Bing, and Yandex,
structure our data so that it has machine-readable attributes. This pass
declares the CreativeWork sub-types as well as Product for the main
bibliographic record details, and uses the Offer type for holdings
information per the W3C Schema Bib Extend community group discussions."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:56:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:56:31 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-de3P3ozGxs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

--- Comment #20 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 21860
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21860&action=edit
Bug 10309 [Follow-up] Update for Bug 10856, improve shelf browser

This patch updates this theme with the changes made in Bug 10856.
Because of the way JavaScript is loaded in the new theme, the JS in the
shelfbrowser include had to be moved to the opac-detail template.

Test plan from that bug:
- On a detail biblio page, click on a "Browse shelf" link.
- Play with the next and previous links.
- Deactivate Javascript (using NoScript for example) and check that you
  get the same behavior (but the page is reloaded).
- Launch the unit tests: prove t/db_dependent/ShelfBrowser.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:56:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:56:26 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-e0TVRtQVPe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

--- Comment #19 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 21859
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21859&action=edit
Bug 10309 [Follow-up] Applying changes from Bug 10349

This patch applies the changes from Bug 10349, Don't show empty
Descriptions/Title notes tabs in OPAC and staff.

"The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC record or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:56:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:56:35 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-9RFWSb3BvJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

--- Comment #21 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 21861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21861&action=edit
Bug 10309 [Follow-up] Add changes from Bug 8712, "and" labels in advanced
search

This patch adds the changes from Bug 8712 to the new theme. Some HTML
markup errors have also been corrected. From Bug 8712:

"The "and" label not only improves the accessibility but also gives the
user an idea that the operation between multiple search fields is a
boolean "AND" by default."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct  7 21:56:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 07 Oct 2013 19:56:40 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-67xmhnPOMR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 21862
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21862&action=edit
Bug 10309 [Follow-up] Markup fix from Bug 10566 follow-up

This patch corrects a markup error which was fixed recently in the prog
template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 04:39:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 02:39:13 +0000
Subject: [Koha-bugs] [Bug 11012] New: Update dependencies to account for new
	crypt lib
Message-ID: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

            Bug ID: 11012
           Summary: Update dependencies to account for new crypt lib
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: robin at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

Bug 9611 has a new dependency that the packages need to refer to.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 04:41:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 02:41:56 +0000
Subject: [Koha-bugs] [Bug 11012] Update dependencies to account for new
	crypt lib
In-Reply-To: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11012-70-GOLJ6oXPVR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

--- Comment #1 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21863
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21863&action=edit
Bug 11012 - update package dependencies for koha-perldeps

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 04:42:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 02:42:14 +0000
Subject: [Koha-bugs] [Bug 11012] Update dependencies to account for new
	crypt lib
In-Reply-To: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11012-70-8Dl3EQegdc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 04:42:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 02:42:22 +0000
Subject: [Koha-bugs] [Bug 11012] Update dependencies to account for new
	crypt lib
In-Reply-To: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11012-70-qiPea4VtZM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 04:42:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 02:42:38 +0000
Subject: [Koha-bugs] [Bug 11012] Update dependencies to account for new
	crypt lib
In-Reply-To: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11012-70-1qhIPxsvI5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 05:11:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 03:11:56 +0000
Subject: [Koha-bugs] [Bug 11013] New: Tests broken by new crypto stuff
Message-ID: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

            Bug ID: 11013
           Summary: Tests broken by new crypto stuff
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: robin at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Bug 9611 broke the test cases when running without a database (i.e. when
packages are being built.)

The problem is that the hashing stuff was put into C4::Auth, which makes sense,
however this means that C4::Members has to use C4::Auth, and C4::Auth requires
a database, and many things use C4::Members...

So I'm going to move the hashing stuff into its own place in the Koha
namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 05:12:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 03:12:10 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-8zWgDZHwvT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Assignee|gmcharlt at gmail.com          |robin at catalyst.net.nz
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 05:19:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 03:19:35 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-ggY0gowkwV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11013

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 05:19:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 03:19:35 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-HLdZTvWSkT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |9611

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 05:59:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 03:59:55 +0000
Subject: [Koha-bugs] [Bug 11014] New: Slip Print Problem in Chrome
Message-ID: <bug-11014-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11014

            Bug ID: 11014
           Summary: Slip Print Problem in Chrome
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

Currently, you can print circulation slips in Internet Explorer, Firefox,
Chromium, and probably heaps of other browsers but not Chrome. 

When one goes to print a slip in Chrome, a new browser tab is opened, and the
"printThenClose" javascript initiates a print. However, instead of using the
system dialogue box, it uses a Chrome-specific print preview screen.

Since this preview screen is non-standard, the javascript doesn't even detect
it, and it proceeds to close the window.

(Not the most technical description but that's basically what happens.)

Alas, I can't think of any way of getting around this problem. Some research
suggests that people use timers or keyboard/mouse movement handlers, but none
of those are really optimal strategies for fixing the problem.

Another way of getting around it in Chrome is to open the browser using the
"--args --disable-print-preview" flags. That will use the system dialogue
(which halts the processing of the Javascript and thus the closing of the
window until after the actual print is either initiated or cancelled) instead
of the custom print screen.

However, that might be a lot to ask from a lot of users.

I suppose another idea might be to make the printing happen "silently" but then
you don't get to choose your printer which is also sub-optimal.

At the moment, the easiest thing is just to use a different browser (like
Firefox) for circulation if the library prints slips. But again...not really an
optimal solution to the problem.

Just logging it here anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 06:13:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 04:13:48 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-PMZGrDyEts@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4585|0                           |1
        is obsolete|                            |
   Attachment #4586|0                           |1
        is obsolete|                            |

--- Comment #9 from Amit <amitddng135 at gmail.com> ---
Created attachment 21864
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21864&action=edit
Check for Change in Remote IP address for Session Security. Disable when remote
IP address changes frequently

To Test:
1) Enable the system preference SessionRestrictionByIP
2) Change your system IP. It will not checkout your system IP or signout.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 06:14:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 04:14:30 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-pjEguDu31K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

--- Comment #10 from Amit <amitddng135 at gmail.com> ---
Created attachment 21865
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21865&action=edit
Added new system preference: SessionRestrictionByIP

Added new system preference: SessionRestrictionByIP

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 06:14:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 04:14:48 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-2ndmzzLSJI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 06:34:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 04:34:48 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-894fBFG0u5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Amit Gupta <kohapatch at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohapatch at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 06:46:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 04:46:02 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-SULiUbY4WZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED
                 CC|                            |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 06:46:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 04:46:25 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-5joNDfxqXF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.8                         |master
           Assignee|kohapatch at gmail.com         |amitddng135 at gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 07:11:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 05:11:30 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-Y4UiCVzwCi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

--- Comment #1 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21866
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21866&action=edit
Bug 11013 - move hashing functions into their own module

As the hashing functions were centralised into C4::Auth, this required
more modules (C4::Members in particular) to use it. However, C4::Auth
uses the database, and so anything that used C4::Members failed to load
in the 00-load.t test. This patch moves the hashing into its own small
module so this isn't an issue.

Test plan:
* Ensure that password related functions work:
** Creating a user account
** Logging in
** Changing a password (OPAC and staff client)
** LDAP logins still work like they should
* Ensure that tests pass without a database server present

Note: there are testing notes for LDAP on bug 9611 that'll bypass the
need to set up an LDAP server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 07:12:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 05:12:12 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-unHhVMMWzN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 07:22:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 05:22:57 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-deMAnPgGRE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #2 from Robin Sheat <robin at catalyst.net.nz> ---
Upgraded the importance, as packages can't be built while this bug is here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 07:27:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 05:27:35 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-sMizpM0uCt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21866|0                           |1
        is obsolete|                            |

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21867
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21867&action=edit
Bug 11013 - move hashing functions into their own module

As the hashing functions were centralised into C4::Auth, this required
more modules (C4::Members in particular) to use it. However, C4::Auth
uses the database, and so anything that used C4::Members failed to load
in the 00-load.t test. This patch moves the hashing into its own small
module so this isn't an issue.

Test plan:
* Ensure that password related functions work:
** Creating a user account
** Logging in
** Changing a password (OPAC and staff client)
** LDAP logins still work like they should
* Ensure that tests pass without a database server present

Note: there are testing notes for LDAP on bug 9611 that'll bypass the
need to set up an LDAP server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 09:15:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 07:15:38 +0000
Subject: [Koha-bugs] [Bug 11015] New: Copyright headers are missing in some
	packages
Message-ID: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

            Bug ID: 11015
           Summary: Copyright headers are missing in some packages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 09:15:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 07:15:46 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-WOsMyDqyGk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 09:33:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 07:33:41 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-PpwFmGCd0l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 09:33:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 07:33:44 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-YiSLvbkdYg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21868
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21868&action=edit
Bug 11015: Copyright headers are missing in some packages

This patch adds a copyright headers where don't exist in the Koha
namespace.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 09:43:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 07:43:14 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-ZSZuTNiqzF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |INVALID

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #6)
> Sorry, just trying to think how this will work :)
> We have the option to set a different billing and delivery place in basket
> groups, so this would overwrite the aqorders branch then?

After a discussion with Laurence, it appears this field is not fundamental and
not obvious.
So we decide to drop it. I will provide a patch (in another report) for the
filter by library in the invoices search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:20:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:20:06 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-l9yO9hSd0P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I didn't want to discourage you :(. Just wanted to say that we have a lot
of possibilities here where the branch can be a bit confusing and it should be
clear what it does and what it does not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:23:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:23:33 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-o8mWBVqpMU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #8)
No worries :)
With your question, we doubt on the usefulness of this field. It's a good thing
:)
But now we have a search by library on the invoices search page (which does
nothing), and I don't know how could we search invoices by library...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:50:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:50:44 +0000
Subject: [Koha-bugs] [Bug 11016] New: Move SQL query from acqui/spent.pl to
 C4/Acquisitions.pm ?
Message-ID: <bug-11016-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11016

            Bug ID: 11016
           Summary: Move SQL query from acqui/spent.pl to
                    C4/Acquisitions.pm ?
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

I'm surprised to see a big SQL query in acqui/spent.pl.
Is not that kind of stuff supposed to be rather in C4/Aquisitions.pm ?

my $query = <<EOQ;
SELECT
    aqorders.basketno, aqorders.ordernumber,
    quantity-quantityreceived AS tleft,
    ecost, budgetdate, entrydate,
    aqbasket.booksellerid,
    itype,
    title,
    aqorders.invoiceid,
    aqinvoices.invoicenumber,
    quantityreceived,
    unitprice,
    datereceived,
    aqorders.biblionumber
FROM (aqorders, aqbasket)
LEFT JOIN biblio ON
    biblio.biblionumber=aqorders.biblionumber
LEFT JOIN items ON
    biblio.biblionumber = items.biblionumber
LEFT JOIN aqorders_items ON
     items.itemnumber = aqorders_items.itemnumber
LEFT JOIN aqinvoices ON
    aqorders.invoiceid = aqinvoices.invoiceid
WHERE
    aqorders.ordernumber=aqorders_items.ordernumber AND
    aqorders.basketno=aqbasket.basketno AND
    budget_id=? AND
    (datecancellationprinted IS NULL OR
        datecancellationprinted='0000-00-00')
    GROUP BY aqorders.ordernumber
EOQ



M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:55:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:55:39 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-G2VKEo7IHh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:55:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:55:42 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-OtxDhDHfV1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21869
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21869&action=edit
Bug 9218: intranet cart email broken for non english templates

This patch adapts the method from OPAC to the staff interface (cf bug 8062).

Test plan:
- add somes notices to the cart
- try to send the cart by email
- the email should be the same as before
- translate templates and retry with another language. Before this patch,
  the email was empty. With this patch, it contains the list of records
  and items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:56:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:56:28 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-gUzqCOUnUY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:58:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:58:45 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-7aiW81tFIO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9751|0                           |1
        is obsolete|                            |

--- Comment #8 from Amit <amitddng135 at gmail.com> ---
Created attachment 21870
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21870&action=edit
Send membership expiry reminder notices.

 A new crontab based perl script to send membership expiry reminders. A system
    preference controls the number of days in advance of membership expiry that
the
    notices will be sent on.

    To Test:
    1) Create a new Patron and set membership expiry date 14 days from the date
of registration.
    2) Check your systemprefence ( MemExpDayNotice to 14 days default value)
    3) Manual testing Run ( perl membership_expiry.pl -h)
        It would give you various option:
        This script prepares for membership expiry reminders to be sent to
        patrons. It queues them in the message queue, which is processed by
        the process_message_queue.pl cronjob.
        See the comments in the script for directions on changing the script.
        This script has the following parameters :
         -c Confirm and remove this help & warning
         -n send No mail. Instead, all mail messages are printed on screen.
Usefull for testing purposes.
         -v verbose
        Do you wish to continue? (y/n)
    4) Choose option for ex: perl membership_expiry.pl -c
    5) Go to your koha database and check message_queue table you see some
results.
    6) Run (perl process_message_queue.pl) it will send email to those patron
whose membership after 14 days from today.
    7) Cron testing: (10   1 * * *  $KOHA_CRON_PATH/membership_expiry.pl -c)
    8) Set your 15   * * * *  $KOHA_CRON_PATH/process_message_queue.pl
    9) After running membership_expiry.pl, (process_message_queue.pl will send
emails to those patron whose membership after 14 days from today).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 10:59:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 08:59:26 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-5e2uyZ3iue@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

--- Comment #9 from Amit <amitddng135 at gmail.com> ---
Created attachment 21871
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21871&action=edit
Added new systempreference: Membership

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 11:00:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 09:00:17 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-OvWxESU8zm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21871|0                           |1
        is obsolete|                            |

--- Comment #10 from Amit <amitddng135 at gmail.com> ---
Created attachment 21872
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21872&action=edit
Added new systempreference: MembershipExpiryNotice

Added new systempreference: MembershipExpiryNotice

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 11:00:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 09:00:41 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-pC2VapL4b8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 11:19:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 09:19:00 +0000
Subject: [Koha-bugs] [Bug 8925] Late orders : checkbox to claim order
 shouldn't appear if no email is known
In-Reply-To: <bug-8925-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8925-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8925-70-1y78KwuDDP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8925

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m
         Resolution|---                         |WONTFIX

--- Comment #4 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Email of vendor is checked in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 11:27:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 09:27:58 +0000
Subject: [Koha-bugs] [Bug 9438] Biblio notes displayed when ordering
In-Reply-To: <bug-9438-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9438-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9438-70-hqFCmBtFeb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9438

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m
            Version|master                      |3.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 11:56:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 09:56:27 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-vLWVeNjpfd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:02:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:02:15 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-iD60dNVTgv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21867|0                           |1
        is obsolete|                            |

--- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21873
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21873&action=edit
[SIGNED-OFF] Bug 11013 - move hashing functions into their own module

As the hashing functions were centralised into C4::Auth, this required
more modules (C4::Members in particular) to use it. However, C4::Auth
uses the database, and so anything that used C4::Members failed to load
in the 00-load.t test. This patch moves the hashing into its own small
module so this isn't an issue.

Test plan:
* Ensure that password related functions work:
** Creating a user account
** Logging in
** Changing a password (OPAC and staff client)
** LDAP logins still work like they should
* Ensure that tests pass without a database server present

Note: there are testing notes for LDAP on bug 9611 that'll bypass the
need to set up an LDAP server.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All Works. No koha-qa errors

Test
1) patch applied
2) new user created
3) change pass from opac/staff
4) change pass using LDAP (sort of, same as on Bug 9611)

NOTE: Robin, you just sent an email about copyright headers,
KohaPassword.pm's reads "...either version 2 of the License,...",
coding guidelines suggests other wording and version 3 of GPL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:02:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:02:46 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-xC5QM37TzH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:17:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:17:53 +0000
Subject: [Koha-bugs] [Bug 11017] New: neworderempy.pl strip 952 field
 (Marc21) but not 995 (Unimarc)
Message-ID: <bug-11017-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11017

            Bug ID: 11017
           Summary: neworderempy.pl strip 952 field (Marc21) but not 995
                    (Unimarc)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

neworderempy.pl strip 952 field (Marc21) but not 995 (Unimarc)
I suppose it should do, depending on marcflavor

foreach my $item ($marcrecord->field('952')) {
        $marcrecord->delete_field($item);
    }

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:27:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:27:00 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-80LYgfAtqq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

--- Comment #5 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Bernardo Gonzalez Kriegel from comment #4)
> NOTE: Robin, you just sent an email about copyright headers,
> KohaPassword.pm's reads "...either version 2 of the License,...",
> coding guidelines suggests other wording and version 3 of GPL.

That was a test! Actually, it was because I copy-pasted from elsewhere and
didn't check. You are totally correct. I'll add a follow-up tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:27:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:27:54 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-Qst6C9XT36@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:31:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:31:18 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-pB8eOqtTlE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

--- Comment #2 from Robin Sheat <robin at catalyst.net.nz> ---
Your patches appear to be "Copyright 2012 C & P Bibliography Services", is that
correct?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 13:31:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 11:31:57 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-GciqzgdlCc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
Ah wait, only some of them are. You're covering for Jared too. I'd allow that
:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 14:01:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 12:01:08 +0000
Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call
	method "raw"
In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9864-70-dRIuSizL7m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #9 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Im trying to set up a dev instance of Koha following instructions here:
http://wiki.koha-community.org/wiki/Install_and_Setup_Koha_to_use_Git_on_a_Development_Server

I completed all the steps and now I'm stuck with this same error when trying to
do a search.

I'll try to start over again on another machine..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 14:26:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 12:26:10 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-TCPLddBpkU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21869|0                           |1
        is obsolete|                            |
                 CC|                            |paola.rossi at cineca.it

--- Comment #6 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21874
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21874&action=edit
intranet cart email broken for non english templates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 14:26:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 12:26:42 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-1qID1p24R7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Paola Rossi <paola.rossi at cineca.it> ---
I sign off the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 15:36:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 13:36:04 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-SkTs4ik90I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21845|0                           |1
        is obsolete|                            |

--- Comment #2 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21875
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21875&action=edit
Mandatory fields are not translatable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 15:36:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 13:36:44 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-JESGgwpSOY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |paola.rossi at cineca.it

--- Comment #3 from Paola Rossi <paola.rossi at cineca.it> ---
The patch is signed off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 15:45:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 13:45:48 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-P0Mj5Yq8IM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #145 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21876
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21876&action=edit
Bug 8015: The template name is a required field

Test plan:
Try to add a template with an empty string as name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 15:48:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 13:48:21 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-WwZNppyHOp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #146 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #144)
> What's missing:
> 
> 1) Check that template name is non empty. If you press "Create template" 
> can create as many "no name" templates as you wish. Avoiding duplicates
> could be cool.

Done in the last patch.

> 2) Help File. This is important for prospective users and DocManager job. 
> At last a minimal one could help testing

I don't have the time to do that. Maybe Kyle?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 15:51:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 13:51:36 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-v5srV6CwmB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #147 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Jonathan Druart from comment #146)
> > 2) Help File. This is important for prospective users and DocManager job. 
> > At last a minimal one could help testing
> 
> I don't have the time to do that. Maybe Kyle?

well... I would also add that your english is, how to say... a little bit
french :D :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:11:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:11:59 +0000
Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes
 tabs in OPAC and staff
In-Reply-To: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10349-70-M1Z8gvdpwX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:12:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:12:36 +0000
Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly
 in normal view (UNIMARC / no XSLT)
In-Reply-To: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10324-70-OX3dSqaMbc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:13:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:13:08 +0000
Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting
 ReservesControlBranch
In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10272-70-xIf8qioHM1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:13:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:13:38 +0000
Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts,
 overdues, and holds on the patron summary
In-Reply-To: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10672-70-WMefU5WApr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:14:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:14:04 +0000
Subject: [Koha-bugs] [Bug 10721] Improve DataTables configuration on
 transfers to receive report
In-Reply-To: <bug-10721-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10721-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10721-70-YqCkbSTuQD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10721

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:31:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:31:32 +0000
Subject: [Koha-bugs] [Bug 10917] Librarian cannot update hold pickup
 location without modify_holds_priority
In-Reply-To: <bug-10917-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10917-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10917-70-aVXdcvYuYl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10917

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:38:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:38:00 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-2Tv52uJf8x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21858|0                           |1
        is obsolete|                            |

--- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21877
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21877&action=edit
[SIGNED-OFF] Bug 10309 [Follow-up] Updates for Bug 6594, Schema.org structured
data

This patch adds the changes from Bug 6594:

"To support schema.org processors, such as Google, Bing, and Yandex,
structure our data so that it has machine-readable attributes. This pass
declares the CreativeWork sub-types as well as Product for the main
bibliographic record details, and uses the Offer type for holdings
information per the W3C Schema Bib Extend community group discussions."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Tested against linter.structured-data.org, microdata present
No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:38:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:38:18 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-RJunl1KvmA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21859|0                           |1
        is obsolete|                            |

--- Comment #24 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21878
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21878&action=edit
[SIGNED-OFF] Bug 10309 [Follow-up] Applying changes from Bug 10349

This patch applies the changes from Bug 10349, Don't show empty
Descriptions/Title notes tabs in OPAC and staff.

"The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC record or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works well. No errors

Tested on OPAC, records without notes don't show title notes tab.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:38:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:38:32 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-ZtBqpz0i3o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21860|0                           |1
        is obsolete|                            |

--- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21879
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21879&action=edit
[SIGNED-OFF] Bug 10309 [Follow-up] Update for Bug 10856, improve shelf browser

This patch updates this theme with the changes made in Bug 10856.
Because of the way JavaScript is loaded in the new theme, the JS in the
shelfbrowser include had to be moved to the opac-detail template.

Test plan from that bug:
- On a detail biblio page, click on a "Browse shelf" link.
- Play with the next and previous links.
- Deactivate Javascript (using NoScript for example) and check that you
  get the same behavior (but the page is reloaded).
- Launch the unit tests: prove t/db_dependent/ShelfBrowser.t

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works well. No errors

Disabled JavaScript on Firefox (about:config, javascript.enable -> false)
Browse shelf works by reloading.
Unit test report success.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:39:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:39:08 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-TjaGI8Fq6h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21861|0                           |1
        is obsolete|                            |

--- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21880
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21880&action=edit
[SIGNED-OFF] Bug 10309 [Follow-up] Add changes from Bug 8712, "and" labels in
advanced search

This patch adds the changes from Bug 8712 to the new theme. Some HTML
markup errors have also been corrected. From Bug 8712:

"The "and" label not only improves the accessibility but also gives the
user an idea that the operation between multiple search fields is a
boolean "AND" by default."

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

"and" looks well on advanced search. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:39:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:39:22 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-0pap22wO38@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21862|0                           |1
        is obsolete|                            |

--- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21881
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21881&action=edit
[SIGNED-OFF] Bug 10309 [Follow-up] Markup fix from Bug 10566 follow-up

This patch corrects a markup error which was fixed recently in the prog
template.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Simple fix. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:41:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:41:58 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-8Xsu3RxNgJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20484|0                           |1
        is obsolete|                            |

--- Comment #4 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21882
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21882&action=edit
move test prediction pattern button

I confirm that the patch works well

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 16:42:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 14:42:34 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-6IxbeSE33y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |paola.rossi at cineca.it

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 17:06:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 15:06:41 +0000
Subject: [Koha-bugs] [Bug 11018] New: Add order from a reverted file
Message-ID: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018

            Bug ID: 11018
           Summary: Add order from a reverted file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

If a batch is reverted, it is not possible to create an order from this file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 17:06:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 15:06:51 +0000
Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file
In-Reply-To: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11018-70-zqAn8HezHN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 17:25:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 15:25:50 +0000
Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file
In-Reply-To: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11018-70-dSziWUYIfj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 17:25:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 15:25:53 +0000
Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file
In-Reply-To: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11018-70-7nkfZ5WXAl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21883
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21883&action=edit
Bug 11018 - Add order from a reverted file

Weird behavior:
When an import is undone into catalog, the status is set to "reverted".
But if you open the add orders from iso2709, the status is automatically
set to "imported" and does not appear in the list.
So it is not possible to import a reverted batch.

Test plan:
- verify you reproduce the weird behavior
- apply this patch
- import a file and the batch into the catalog
- verify (in the your mysql/MariaDB cli) the status is "imported"
- verify it does not appears in the add orders from iso2809 page
- undo the import
- verify (in the your mysql/MariaDB cli) the status is "reverted"
- verify it appears in the add orders from iso2809 page and the status
  is always "reverted"
- finish the order

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:16:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:16:03 +0000
Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
In-Reply-To: <bug-10742-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10742-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10742-70-uWzJeUsaWV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:21:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:21:25 +0000
Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable
 from koha-httpd.conf
In-Reply-To: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10325-70-LAzyB83wrG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:23:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:23:04 +0000
Subject: [Koha-bugs] [Bug 8215] Add Course Reserves
In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8215-70-LrfmrcCf0P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7478

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:23:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:23:04 +0000
Subject: [Koha-bugs] [Bug 7478] Template/translation problem in
	catalogue_out.tt
In-Reply-To: <bug-7478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7478-70-g4Zp5b8niW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
         Depends on|                            |8215

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:32:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:32:10 +0000
Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address
In-Reply-To: <bug-8125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8125-70-IcsbNRjsJD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21884
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21884&action=edit
Bug 8215 - Course Reserves - Omnibus - v3.12.05

Bug 8215 - Course Reserves

Adds a course reserves system for academic libraries.

The course reserves system allows libraries to create courses
and put items on reserves for those courses.

Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.

Test Plan:
  1) Create new authorised value categories DEPARTMENT and TERM
  2) Create a new course, add instructors to that course.
  3) Reserve items for that course, verify item attributes have changed.
  4) Disable course, verify item attributes have reverted.
  5) Enable course again, verify item attributes again.
  6) Delete course, verify item attributes again.
  7) Create two new courses, add the same item(s) to both courses.
  8) Disable one course, verify item attributes have not reverted.
  9) Disable both courses, verify item attributes have reverted.
 10) Enable one course, verify item attributes are again set to the
     new values.
 11) Edit reserve item attributes, verify.
 12) Disable all courses, edit reserve item attributes, verify
     the item itself still has its original attributes, verify
     the reserve item attributes have been updated.
 13) Verify the ability to remove instructors from a course.
 14) Verify new permissions, top level coursereserves, with
     subpermissions add_reserves and delete_reserves.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

http://bugs.koha-community.org/show_bug.cgi?id=8125

Bug 8215 follow-up encoding for branches & itemtypes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215: Followup FIX QA issues

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215 - Add Course Reserves - QA Followup

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215: Followup Fix confirmation links for delete course and item

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215: FIX ergonomic issue : 'Unchanged()'

bug 8215: (followup) run new files through perltidy

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) make sure C4::CourseReserves doesn't export anything

New modules should not export any symbols by default
without a very good reason.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) don't allow deleting course reserves from OPAC

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) avoid SQL syntax error in logs

ModItem currently will attempt to update an item
even if no field updates are specified.  This patch
avoids (harmless) error messages in the Apache
logs if an item is not actually being changed when it
is placed or taken off reserve.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) rename GetItemReservesInfo

Renamed that routine to GetItemCourseReservesInfo in
order to avoid any potential confusion with reserves
qua hold requests.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) remove extraneous underscore in template

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:32:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:32:58 +0000
Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address
In-Reply-To: <bug-8125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8125-70-lgOHa0msj8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21884|0                           |1
        is obsolete|                            |
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 18:33:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 16:33:05 +0000
Subject: [Koha-bugs] [Bug 8215] Add Course Reserves
In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8215-70-EhuxHKY7QL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #147 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21885
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21885&action=edit
Bug 8215 - Course Reserves - Omnibus - v3.12.05

Bug 8215 - Course Reserves

Adds a course reserves system for academic libraries.

The course reserves system allows libraries to create courses
and put items on reserves for those courses.

Each item with at least one reserve can have some of its attributes
modified while it is on reserve for at least one active course.
These attributes include item type, collection code, shelving location,
and holding library. If there are no active courses with this item
on reserve, it's attributes will revert to the original attributes
it had before going on reserve.

Test Plan:
  1) Create new authorised value categories DEPARTMENT and TERM
  2) Create a new course, add instructors to that course.
  3) Reserve items for that course, verify item attributes have changed.
  4) Disable course, verify item attributes have reverted.
  5) Enable course again, verify item attributes again.
  6) Delete course, verify item attributes again.
  7) Create two new courses, add the same item(s) to both courses.
  8) Disable one course, verify item attributes have not reverted.
  9) Disable both courses, verify item attributes have reverted.
 10) Enable one course, verify item attributes are again set to the
     new values.
 11) Edit reserve item attributes, verify.
 12) Disable all courses, edit reserve item attributes, verify
     the item itself still has its original attributes, verify
     the reserve item attributes have been updated.
 13) Verify the ability to remove instructors from a course.
 14) Verify new permissions, top level coursereserves, with
     subpermissions add_reserves and delete_reserves.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

http://bugs.koha-community.org/show_bug.cgi?id=8125

Bug 8215 follow-up encoding for branches & itemtypes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215: Followup FIX QA issues

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215 - Add Course Reserves - QA Followup

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215: Followup Fix confirmation links for delete course and item

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

Bug 8215: FIX ergonomic issue : 'Unchanged()'

bug 8215: (followup) run new files through perltidy

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) make sure C4::CourseReserves doesn't export anything

New modules should not export any symbols by default
without a very good reason.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) don't allow deleting course reserves from OPAC

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) avoid SQL syntax error in logs

ModItem currently will attempt to update an item
even if no field updates are specified.  This patch
avoids (harmless) error messages in the Apache
logs if an item is not actually being changed when it
is placed or taken off reserve.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) rename GetItemReservesInfo

Renamed that routine to GetItemCourseReservesInfo in
order to avoid any potential confusion with reserves
qua hold requests.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

bug 8215: (followup) remove extraneous underscore in template

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 19:57:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 17:57:41 +0000
Subject: [Koha-bugs] [Bug 8215] Add Course Reserves
In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8215-70-pm9myJHWl7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #148 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch series introduce new TT plugins. They have been grabbed and pushed
to 3.12.x, will be in 3.12.6 as they have been actively used for some bugfixes
on the stable branch.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 19:58:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 17:58:55 +0000
Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its
	own data
In-Reply-To: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10333-70-QdTYriCRN9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |tomascohen at gmail.com

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct  8 20:01:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 18:01:25 +0000
Subject: [Koha-bugs] [Bug 8215] Add Course Reserves
In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8215-70-Z7bqUmdsnf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Maxime Pelletier <pelletiermaxime at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|pelletiermaxime at gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 00:14:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 08 Oct 2013 22:14:15 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-0gnuJ40Ggq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #10 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi

Rather than a unique field for searching invoice for library, why not 2 fields,
one for billing library and one for delivery library, which will use either
aqorders.deliveryplace and aqorders.billingplace (if the basket is NOT in a
basketgroup), or aqbasketgroups.deliveryplace and aqbasketgroups.billingplace
(if it is in a basketgroup) ?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 02:20:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 00:20:18 +0000
Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time
 in "from" argument
In-Reply-To: <bug-10824-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10824-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10824-70-UGyoFHs3yr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 02:26:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 00:26:16 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-a3PNgQLJBF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 04:03:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 02:03:55 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-HJJzHm7pgK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 04:03:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 02:03:59 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-SxorlyB1hX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21839|0                           |1
        is obsolete|                            |

--- Comment #4 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 21886
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21886&action=edit
Bug 10944 - Mixed content warnings for covers on staff client

This switches the URLs used to access Amazon's cover images to the SSL image
server, preventing warnings when using this on a secure site.

To test:
* Enable Amazon images in the sysprefs, all other cover images off.
* Do a search in the staff client. Using firebug or similar, inspect the
  images that indicate both "no image found" and the covers.
* Are they all https, and showing correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 04:48:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 02:48:41 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-SOayKnDjJK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Added daemon mode           |[ENH] Added daemon mode
                   |parameters to               |parameters to
                   |rebuild_zebra.pl            |rebuild_zebra.pl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:13:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:13:05 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-pchQGMwWYP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

--- Comment #6 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21887
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21887&action=edit
Bug 11013 - make copyright headers current

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:26:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:26:11 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-4g3iB607K0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21887|0                           |1
        is obsolete|                            |

--- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21888
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21888&action=edit
[SIGNED-OFF] Bug 11013 - make copyright headers current

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Updated copyright headers ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:30:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:30:25 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-7b0VoHpXAM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21868|0                           |1
        is obsolete|                            |

--- Comment #4 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21889
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21889&action=edit
Bug 11015: Copyright headers are missing in some packages

This patch adds a copyright headers where don't exist in the Koha
namespace.

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:30:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:30:52 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-Glo95HSf9F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:43:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:43:58 +0000
Subject: [Koha-bugs] [Bug 11019] New: Adding new category in authorized
	values
Message-ID: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

            Bug ID: 11019
           Summary: Adding new category in authorized values
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: amitddng135 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Adding new category in authorized values.
If not fill any field it save blank record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:44:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:44:18 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-OZJnPkako8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:58:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:58:12 +0000
Subject: [Koha-bugs] [Bug 10685] Inappropriate uses of finish() in
	C4::Accounts.pm
In-Reply-To: <bug-10685-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10685-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10685-70-a815WCY99H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10685

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:58:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:58:30 +0000
Subject: [Koha-bugs] [Bug 10682] Inappropriate uses of finish() in
	C4::Reserve.pm
In-Reply-To: <bug-10682-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10682-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10682-70-5ixZhbvKtx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10682

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:58:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:58:52 +0000
Subject: [Koha-bugs] [Bug 10681] Inappropriate uses of finish() in
	C4::Circulation.pm
In-Reply-To: <bug-10681-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10681-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10681-70-iIBzhCzGPn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10681

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:59:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:59:22 +0000
Subject: [Koha-bugs] [Bug 10711] GetOfflineOperation in C4/Circulation.pm
 should returns $sth->fetchrow_hashref instead of $result
In-Reply-To: <bug-10711-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10711-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10711-70-w0Afqalulw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10711

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:59:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:59:39 +0000
Subject: [Koha-bugs] [Bug 10698] DeleteTransfer in C4::Circulation.pm needs
	return value
In-Reply-To: <bug-10698-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10698-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10698-70-GQhKuAO63V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10698

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 05:59:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 03:59:55 +0000
Subject: [Koha-bugs] [Bug 10683] CRUD routines in C4::Circulation need unit
	tests
In-Reply-To: <bug-10683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10683-70-7HFIMkK5xW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10683

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:00:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:00:13 +0000
Subject: [Koha-bugs] [Bug 10795] Improvements for GetOpenIssue in
	C4::Circulation
In-Reply-To: <bug-10795-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10795-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10795-70-NZYM4jMX8F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10795

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:07:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:07:28 +0000
Subject: [Koha-bugs] [Bug 10641] GetBooksellerWithLateOrders in
 C4::Bookseller.pm has some incoherences
In-Reply-To: <bug-10641-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10641-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10641-70-V2KKPrUGCG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10641

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #14 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:10:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:10:23 +0000
Subject: [Koha-bugs] [Bug 11012] Update dependencies to account for new
	crypt lib
In-Reply-To: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11012-70-3RHB8FVdR3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kenza!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:17:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:17:03 +0000
Subject: [Koha-bugs] [Bug 10794] Sorting on billing date column in invoices
 table doesn't work
In-Reply-To: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10794-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10794-70-pEYOCQEZPT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10794

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:22:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:22:11 +0000
Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
In-Reply-To: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8921-70-FY50EVp9yF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
"In Debian the cron package is installed as part of the base system, and will
be running by default." (http://www.debian-administration.org/articles/56)

I also looked at Ubuntu. (https://help.ubuntu.com/community/CronHowto) is
written such that one can assume it is installed as well.

What virtual environment are you talking about? Can you cite an example? I know
this would be a problem from RPM-based Linux variants, but then you wouldn't be
installing from packages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:25:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:25:26 +0000
Subject: [Koha-bugs] [Bug 9747] sort issue for the z3950 results
In-Reply-To: <bug-9747-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9747-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9747-70-iXzQU7SQvF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9747

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #16 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:25:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:25:48 +0000
Subject: [Koha-bugs] [Bug 11012] Update dependencies to account for new
	crypt lib
In-Reply-To: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11012-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11012-70-J7LiU56MPL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11012

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Galen Charlton from comment #2)
> Pushed to master.  Thanks, Kenza!

Who is Kenza?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:26:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:26:49 +0000
Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
In-Reply-To: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8921-70-8uQAJ8uanO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921

--- Comment #2 from Robin Sheat <robin at catalyst.net.nz> ---
There's no harm on depending on it, but it shouldn't really be necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:30:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:30:45 +0000
Subject: [Koha-bugs] [Bug 10430] status filter not working in serial claims
 when translated
In-Reply-To: <bug-10430-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10430-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10430-70-yeATbXbTWu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10430

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 06:56:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 04:56:06 +0000
Subject: [Koha-bugs] [Bug 10624] koha-common.init should implement the
 'status' option switch
In-Reply-To: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10624-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10624-70-ThYhDPnUX2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10624

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Tom?s!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 07:01:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 05:01:39 +0000
Subject: [Koha-bugs] [Bug 10705] Shipment cost should be 'shipping'
In-Reply-To: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10705-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10705-70-3fUWLNFBpX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10705

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #10 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Ketan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 07:30:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 05:30:38 +0000
Subject: [Koha-bugs] [Bug 6201] BibTeX export does not incude MARC21 main
	entry
In-Reply-To: <bug-6201-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6201-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6201-70-apAR6RGMkp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6201

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Philippe!  Also, looks like this is your first patch
accepted into Koha.  Congratulations!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:13:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:13:13 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-6AtaqkKZLN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #10)
> Hi
> 
> Rather than a unique field for searching invoice for library, why not 2
> fields, one for billing library and one for delivery library, which will use
> either aqorders.deliveryplace and aqorders.billingplace (if the basket is
> NOT in a basketgroup), or aqbasketgroups.deliveryplace and
> aqbasketgroups.billingplace (if it is in a basketgroup) ?

The main problem is an invoice can contain any orders from a vendor (so from
any basket, basketgroup link to this vendor).
The billing and delivery places can differ.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:31:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:31:03 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-4dOfViHXQA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #12 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jonathan Druart from comment #11)
> (In reply to mathieu saby from comment #10)
> > Hi
> > 
> > Rather than a unique field for searching invoice for library, why not 2
> > fields, one for billing library and one for delivery library, which will use
> > either aqorders.deliveryplace and aqorders.billingplace (if the basket is
> > NOT in a basketgroup), or aqbasketgroups.deliveryplace and
> > aqbasketgroups.billingplace (if it is in a basketgroup) ?
> 
> The main problem is an invoice can contain any orders from a vendor (so from
> any basket, basketgroup link to this vendor).
> The billing and delivery places can differ.


Oh, I did not think of that, because that's not our workflow...

(By the way, I am not sure that current "flexibility" is really needed, because
in real word (for my library at least), I think invoices sent by a vendor
always contains orders from a single basketgroup. But maybe it is usefull for
other libraries.)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:33:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:33:19 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-q0eztFs1Fz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think multiple basket groups is a possiblity, but I think they should all go
to the shipping address, so that branch woudl be the same... unless someone
makes a mistake.

Would it be an option to say the branch searched here is the branch where the
invoice has been processed? (logged in branch of the staff member doing it?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:35:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:35:05 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-gPrrcUbrk5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Robin,
Galen pushed a followup  for bug 9611 (3min after the Bernardo's signoff!),
moving the password routines into a new module (Koha::AuthUtils).
These patchs don't apply anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:36:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:36:46 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-GTZnQRMBdI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
In fact I think this report can be marked as resolved/duplicate. I let you
change the status, except if you disagree.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:38:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:38:24 +0000
Subject: [Koha-bugs] [Bug 11013] Tests broken by new crypto stuff
In-Reply-To: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11013-70-F9wStrNUGR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11013

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #10 from Robin Sheat <robin at catalyst.net.nz> ---
Yeah, if it solves the same problem, that's good too :)

*** This bug has been marked as a duplicate of bug 9611 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:38:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:38:24 +0000
Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from
 MD5 to more secure Bcrypt
In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9611-70-dVR9rJ1iC4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611

--- Comment #97 from Robin Sheat <robin at catalyst.net.nz> ---
*** Bug 11013 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:44:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:44:31 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-OKnj56UI9L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amitddng135 at gmail.com

--- Comment #1 from Amit <amitddng135 at gmail.com> ---
Created attachment 21890
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21890&action=edit
Adding new category in authorized values

If not fill any field it save blank record

To Test:
1) Go to Authorized values.
2) Create New Category.
3) If you not fill the Category field it will not save the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:45:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:45:05 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-s47flVrMmv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:50:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:50:15 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-SMwvy3bXGC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note for QAers: Given that bug 7688 is ready for the v.3.14 release, this patch
won't be valid.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 09:51:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 07:51:34 +0000
Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
In-Reply-To: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8921-70-GY0bZYj7MA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921

--- Comment #3 from johannes_graumann at web.de ---
I had the experience of cron being missed despite it not being listed as a
prerequisite in an lxc container (minimal system setup via debbootstrap).

Joh

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 10:01:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 08:01:20 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-F2881EDc7E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #13)
> I think multiple basket groups is a possiblity, but I think they should all
> go to the shipping address, so that branch woudl be the same... unless
> someone makes a mistake.
> 
> Would it be an option to say the branch searched here is the branch where
> the invoice has been processed? (logged in branch of the staff member doing
> it?)


Maybe create a new field in aqinvoice, which will be filled at receipt either
with (basket or basketgroup) delivery address or the library of the staff
member, depending on a syspref?
No sure it is needed to search on billing adress.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 10:19:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 08:19:46 +0000
Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call
	method "raw"
In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9864-70-7u5x9z13bs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864

--- Comment #10 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Update: problem dissapears when I installed using the squeeze-dev package
instead of squeeze-main

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 10:30:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 08:30:19 +0000
Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
In-Reply-To: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8921-70-W2r0wwG288@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921

--- Comment #4 from johannes_graumann at web.de ---
You may note that the prior comment doesn't really mak sense ... new attempt:
in an debbootstrapped lxc container's minimal system cron is not necessarily
present. Zebra's cron job functionality may thus break despite cron not being
listed as a prerequisite.

Joh

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 10:49:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 08:49:13 +0000
Subject: [Koha-bugs] [Bug 8921] koha-common*.deb should depend on cron
In-Reply-To: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8921-70-cPjo74NDQM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8921

--- Comment #5 from Robin Sheat <robin at catalyst.net.nz> ---
Yeah, it's an easy fix and I shouldn't imagine there are side-effects from it.
Probably should also include 'at' in the list if it's not there already.

Johannes, if you want you could make a patch for it easily enough. Just edit
debian/control.in and stick cron and at into the one or two places they need to
go.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:12:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:12:21 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-hjeSCgyfkR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Transfer limits should be   |Transfer limits should be
                   |checked when placing a      |checked when placing a
                   |hold/reservation.           |hold/reservation in OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:15:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:15:09 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-jjoMSwFOqc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21891
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21891&action=edit
Bug 10993 [ENH] - Transfer limits should be checked when placing a
hold/reservation in OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:16:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:16:24 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-PW8cKrYBo9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21892
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21892&action=edit
quickie test document

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:32:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:32:44 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-GmXnUqY05r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:34:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:34:23 +0000
Subject: [Koha-bugs] [Bug 11020] New: Transfer limits should be checked when
 placing a hold/reservation in Staff client
Message-ID: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

            Bug ID: 11020
           Summary: Transfer limits should be checked when placing a
                    hold/reservation in Staff client
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Extending bug 10993, 11005 to the staff client.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:35:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:35:05 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-IJ6TfFcwxO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:35:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:35:05 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-w9rdIhZ3Lu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
   Patch complexity|---                         |Medium patch
         Depends on|                            |10993, 11005, 7376
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:35:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:35:05 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-ALhlP7ZTB1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 12:35:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 10:35:05 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-93osPCXrbJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 13:48:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 11:48:29 +0000
Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts,
 overdues, and holds on the patron summary
In-Reply-To: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10672-70-VnR5ItxdsB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
Could you tell me how subtitle is stored, as there is no subtitle field in
biblio table?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 13:53:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 11:53:47 +0000
Subject: [Koha-bugs] [Bug 11021] New: Delete useless 9XX field in unimarc
	frameworks
Message-ID: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

            Bug ID: 11021
           Summary: Delete useless 9XX field in unimarc frameworks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Unimarc frameworks contains a lot of 9XX fields.
Most of them are useless.
I suppose they were copied from the framework used by the main french record
provider company, Electre. But Electre changed their framework some years ago,
so those fields must be delete.
I will provide a list of fields to delete.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 13:54:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 11:54:05 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-2LOPR9uX7V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 13:54:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 11:54:14 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-vxPHB7a0pb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 13:54:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 11:54:26 +0000
Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts,
 overdues, and holds on the patron summary
In-Reply-To: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10672-70-LNT6gUH4Si@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to mathieu saby from comment #9)
> Could you tell me how subtitle is stored, as there is no subtitle field in
> biblio table?

Subtitle is not stored in any MySQL column. It is pulled from the MARC record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 13:59:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 11:59:55 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-1vo83Stpab@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21717|0                           |1
        is obsolete|                            |

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21893
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21893&action=edit
[SIGNED-OFF] Bug 10691: 5xx not properly linked by authid in authority search
result list [Staff]

This patch changes the URL and data used to show the 'see also' links
on the Staff's authority search results page.

Bonus points: makes some strings translatable.

To test:
- On your dev setup (master) create some authority records (i created personal
name authorities).
- Pick one of them and link 400$a to another one, do the same with 500$a
- Add some other 400$a and 500$a entries with plain text (i.e. no linking)
- Make sure zebra is running and changes got indexed.
- In the staff interface search for the authority that is linked to the others.
- Check the 'see also:' link points to an authority search
- Apply the patch
- Reload/re-do the search
- Check the 'see also:' link points to the authority id for linked authorities,
  and to an authority search result in the case of plain text entries.
- Check that the authority search from the cataloguing interface still works as
usual.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Work as described. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:00:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:00:11 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-QskqxdHtS3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21727|0                           |1
        is obsolete|                            |

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21894
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21894&action=edit
[SIGNED-OFF] Bug 10691: 5xx not properly linked by authid in authority search
result list

This patch changes the URL and data used to show the 'see also' links
on the OPAC's authority search results page.

Bonus points: makes some strings translatable.

To test:
- On your dev setup (master) create some authority records (i created personal
name authorities).
- Pick one of them and link 400$a to another one, do the same with 500$a
- Add some other 400$a and 500$a without linking (i.e. plain text)
- Make sure zebra is running and changes got indexed.
- In the OPAC search for the authority that is linked to the others.
- Check the 'see also:' link points to an authority search
- Apply the patch
- Reload/re-do the search
- Check the 'see also:' link points to the authority id in the case of linked
authorities,
  and to an authority search in the case of plain text names.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Work as described. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:03:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:03:03 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-CHYPSAwo4e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21728|0                           |1
        is obsolete|                            |

--- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21895
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21895&action=edit
[SIGNED-OFF] Bug 10691: Small glitch fixed

A small glitch prevented 'see from' headings to show.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:05:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:05:10 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-A7LEguCAHt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:05:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:05:08 +0000
Subject: [Koha-bugs] [Bug 11022] New: Reorganize or rename french unimarc
	frameworks
Message-ID: <bug-11022-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11022

            Bug ID: 11022
           Summary: Reorganize or rename french unimarc frameworks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

French unimarc frameworks follow this organization : 
 fr-FR / marcflavour / unimarc_complet 
 fr-FR / marcflavour / lecture_publique

"Unimarc complet" is said to be made for "conservation libraries"
("biblioth?ques de conservation"). It means nothing on administrative and
functionnal point of view. Most conservation libraries in France are public
libraries depending from towns.

On a functional point of view, in France the distinction must made between 2
kind of libraries : 
- academic libraries linked to Sudoc network
- other libraries

Sudoc UNIMARC is not exactly the same as standard UNIMARC, especially for 9XX
fields.

So I propose to rename "biblioth?ques de conservation" to "biblioth?ques du
r?seau SUDOC". Everyone will understand in France.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:07:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:07:47 +0000
Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts,
 overdues, and holds on the patron summary
In-Reply-To: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10672-70-OuowAg4WdJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672

--- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Ok.
Don't you think it could be interesting to store it in sql? There is already a
lot of more or less interesting fields in biblio table, and subtitle is
definitly an important information.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:11:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:11:24 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-76wXRTXSGh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co
                   |ity.org                     |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 21896
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21896&action=edit
Bug 11009 - Do not allow reading records of anonymous patron

See commit message

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:11:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:11:39 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-Ib0YnUe9CV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:12:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:12:51 +0000
Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from'
 labels occurences
In-Reply-To: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10987-70-2yZezOp1uq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21733|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21897
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21897&action=edit
[SIGNED-OFF] Bug 10987: Too many 'see also' and 'see from' labels occurences

If an authority record has more than one 4xx$a (or 5xx$a) entries the
corresponding labels 'see also' and 'used for/see from' are repeated.

To test:
- Have authority records with more than one entry on the 4xx (or 5xx) fields.
- Do a search, check "see also:" (or 'used for/see from') appear more than
once.
- Apply the patch
- Reload and check it looks nicer :-D
- Repeat for: staff auth search, opac using ccsr, opac using prog
- Signoff

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Work as decribed. No koha-qa errors
Nice view on staff and both opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:13:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:13:07 +0000
Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from'
 labels occurences
In-Reply-To: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10987-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10987-70-pzMTELENLE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:15:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:15:39 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-Dd2zQoYuk2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

--- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Each reading record will fetch from database all columns of biblio, biblioitems
(including marcxml), items and issues or old_issues.
So if there are a great number of reading records, the page may create a heavy
load on server.
Considering the page exists at OPAC, this may be used to overload the server.

So I created a follow-up that adds an hardcoded limit to reading records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 14:21:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 12:21:03 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-GralpQldwo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

--- Comment #3 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 21898
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21898&action=edit
Bug 11009 - Add hardcoded limit to OPAC reading records

See commit message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 15:20:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 13:20:37 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-rnnz30O81P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21890|0                           |1
        is obsolete|                            |
                 CC|                            |paola.rossi at cineca.it

--- Comment #2 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21899
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21899&action=edit
Adding new category in authorized values

I sign off the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 15:21:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 13:21:30 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-wSL9dthikN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 15:24:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 13:24:42 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-6lvT0YE39U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Why not use the validation method offered by the plugin introduced in Bug 6209?

Is there a server-side check that can be added to the JavaScript-based one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 15:31:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 13:31:33 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-X4TVnG9Ui2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |ketan at carvingit.com
           Assignee|koha-bugs at lists.koha-commun |ketan at carvingit.com
                   |ity.org                     |

--- Comment #1 from Ketan Kulkarni <ketan at carvingit.com> ---
Created attachment 21900
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21900&action=edit
Just labels changed

The new label is -

Book Drop mode

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 15:43:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 13:43:03 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-r0aGvUkZtu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |paola.rossi at cineca.it

--- Comment #2 from Paola Rossi <paola.rossi at cineca.it> ---
I think that the situation is modified by bug 9218 "intranet cart email broken
for non english templates (edit)". 
After applying 9218, and trying to send the cart, the url is not
basket/sendbasket.pl?bib_list=null
So I can't sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:07:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:07:23 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-qwTioEle4u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

--- Comment #4 from Paola Rossi <paola.rossi at cineca.it> ---
Sorry, I didn't know the discussion in bug 6209 about form validation.
I think to pass status of this bug to "failed QA" because Amit wrote specific
javascript code, and he didn't use the plugin instead.
What do you think about it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:18:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:18:43 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-OPlqMgpuMp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21024|0                           |1
        is obsolete|                            |

--- Comment #148 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21901
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21901&action=edit
Bug 8015 - Add MARC Modifications Templates

The MARC Modification Templates system gives Koha users
the power to make alterations to MARC records automatically
while staging MARC records for import.

This tool is useful for altering MARC records from
various venders work with your MARC framework.

The system essentially allows one to create a basic script
using actions to Copy, Move, Add, Update and Delete fields.

Each action can also have an optional condition to check
the value or existance of another field.

The Copy & Move actions also support Regular Expressions,
which can be used to automatically modify field values during the
copy/move. An example would be to strip out the '$' character
in field 020$c.

Furthermore, the value for an update can include variables
that change each time the template is used. Currently,
the system supports two variables, __BRANCHCODE__ which
is replaced with the branchcode of the library currently
using the template, and __CURRENTDATE__ which is replaced
with the current date in ISO format ( YYYY-MM-DD ).

At its simplist, it can perform functions such as:
Copy field 092$a to 952$c
At its most complex it can run actions like:
Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Works as described. No koha-qa errors

One comment to rule them all
(please squash this patchset!)

I think I tested all possible cases: add, copy, delete, move,
regex find and replace (text and also changing branch in 952ab
using __BRANCHNAME__)

Unit test run fine.

No help file yet but not a functional requirement.
Think is a good adition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:19:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:19:20 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-v0KUBN64ZS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21025|0                           |1
        is obsolete|                            |

--- Comment #149 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21902
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21902&action=edit
Bug 8015: Followup: FIX cp and mv if subfields don't exist.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:19:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:19:53 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-A0NyjBIQyX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21026|0                           |1
        is obsolete|                            |

--- Comment #150 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21903
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21903&action=edit
Bug 8015: Followup: On move, we cant delete existing fields

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:20:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:20:23 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-a4sGuHl5ev@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21027|0                           |1
        is obsolete|                            |

--- Comment #151 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21904
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21904&action=edit
Bug 8015 - Add MARC Modifications Templates - Followup

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:21:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:21:01 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-pML2KYRcgU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21028|0                           |1
        is obsolete|                            |

--- Comment #152 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21905
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21905&action=edit
Bug 8015: Followup Add MARC Modifications Templates

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:21:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:21:35 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-zPQLAcjyyk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21029|0                           |1
        is obsolete|                            |

--- Comment #153 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21906
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21906&action=edit
Bug 8015: Catch error in the SetUTF8Flag routine

The eval avoids the interface to run endlessly if an error occurred.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:22:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:22:04 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-SXquFKFMIk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21030|0                           |1
        is obsolete|                            |

--- Comment #154 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21907
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21907&action=edit
Bug 8015: Fix template capitalization amd other template issues

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:22:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:22:34 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-eiQpSaIrwN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21031|0                           |1
        is obsolete|                            |

--- Comment #155 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21908
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21908&action=edit
Bug 8015: Fix error where field object is returned instead of field value for
fields without subfields

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:23:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:23:10 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-TlJPE0IQjC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21032|0                           |1
        is obsolete|                            |

--- Comment #156 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21909
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21909&action=edit
Bug 8015: Fix bad ordering on function parameters

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:23:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:23:41 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-uWJZ9PlyBq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21033|0                           |1
        is obsolete|                            |

--- Comment #157 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21910
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21910&action=edit
Bug 8015: Escape escape characters for strings

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:24:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:24:16 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-YUkhjLtJ2O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21034|0                           |1
        is obsolete|                            |

--- Comment #158 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21911
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21911&action=edit
Bug 8015: Fix bad parameter list for direct external call to update_field

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:24:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:24:47 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-ldXugwvrHI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21035|0                           |1
        is obsolete|                            |

--- Comment #159 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21912
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21912&action=edit
Bug 8015: Fix problem with moving existing subfield value to nonexistent
field/subfield

Signed-off-by: Leila <koha.aixmarseille at gmail.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:25:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:25:24 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-dMkBh4EfY2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21036|0                           |1
        is obsolete|                            |

--- Comment #160 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21913
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21913&action=edit
Bug 8015: FIX QA issues

This patch fixes some stuffs failing qa tests: POD, indentation (tabs),
perlcritic

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:26:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:26:05 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-KV3XcF8rr2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21037|0                           |1
        is obsolete|                            |

--- Comment #161 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21914
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21914&action=edit
Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:26:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:26:41 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-OdTtVYIViy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21038|0                           |1
        is obsolete|                            |

--- Comment #162 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21915
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21915&action=edit
Bug 8015: Fix complains from qa tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:27:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:27:32 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-IKz3Or5aN4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21484|0                           |1
        is obsolete|                            |

--- Comment #163 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21916
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21916&action=edit
Bug 8015: Get rid of the eval in ModifyRecordWithTemplate

This patch removes the use of eval in the
C4::MarcModificationTemplates::ModifyRecordWithTemplate routine.

Now this routine call the wanted modification routine with the list of
parameters.
This call is done only if the condition is respected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:28:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:28:21 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-JljeO8YXv8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21485|0                           |1
        is obsolete|                            |

--- Comment #164 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21917
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21917&action=edit
Bug 8015: Get rid of eval for evaluating =~ m//

Koha::SimpleMarc::field_equals uses eval in order to check if a string
matches a pattern.
Now this eval is removed and the "regex" variable does not contain the
regex separated character (/ or |).

Regression: Before this patch, the user was able to user a modifier. Now
it is not possible.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:28:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:28:51 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-5FVZWDSQmd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21808|0                           |1
        is obsolete|                            |

--- Comment #165 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21918
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21918&action=edit
Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = "/foo/bar/i").
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:29:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:29:27 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-7BbVuPNrDR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21809|0                           |1
        is obsolete|                            |

--- Comment #166 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21919
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21919&action=edit
Bug 8015: FIX ui issue

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:29:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:29:55 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-RNE0ydqTw1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21876|0                           |1
        is obsolete|                            |

--- Comment #167 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21920
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21920&action=edit
Bug 8015: The template name is a required field

Test plan:
Try to add a template with an empty string as name.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:32:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:32:27 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-vmwlKCZWJ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #168 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Signed!

1) Could you consider squashing this into one... or two patches.
This is insane :)

2) Needed follow-up: Help

3) Needed follow-up: Update copyright headers as current usage

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:44:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:44:05 +0000
Subject: [Koha-bugs] [Bug 10318] show email on patron search results
In-Reply-To: <bug-10318-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10318-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10318-70-vAWwa3QmiT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |ketan at carvingit.com
           Assignee|koha-bugs at lists.koha-commun |ketan at carvingit.com
                   |ity.org                     |

--- Comment #1 from Ketan Kulkarni <ketan at carvingit.com> ---
Created attachment 21921
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21921&action=edit
Template update

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 16:52:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 14:52:11 +0000
Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system
In-Reply-To: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6427-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6427-70-wNwifA2jAG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21922
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21922&action=edit
Bug 6427 - Rewrite of the accounts system - WIP

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:09:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:09:50 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
 PK, not cardnumber
In-Reply-To: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10636-70-fIbVjT0W6z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:09:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:09:55 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
 PK, not cardnumber
In-Reply-To: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10636-70-HtQlSBYEQQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20801|0                           |1
        is obsolete|                            |

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21923
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21923&action=edit
Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:28:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:28:12 +0000
Subject: [Koha-bugs] [Bug 11023] New: Toggle new status for items
Message-ID: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

            Bug ID: 11023
           Summary: Toggle new status for items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Some libraries would like to manage a "new" status for items.
This status should be removed depending on some conditions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:28:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:28:25 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-TucPkYsgaQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:40:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:40:57 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-JHlXZqK3gk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21924
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21924&action=edit
Bug 11020 [ENH] - Transfer limits should be checked when placing a
hold/reservation in Staff client

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:41:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:41:18 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-DGPNzjEvhV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21925
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21925&action=edit
manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:43:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:43:11 +0000
Subject: [Koha-bugs] [Bug 11024] New: Transfer limits should be respected in
 the build_holds_queue.pl -script.
Message-ID: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

            Bug ID: 11024
           Summary: Transfer limits should be respected in the
                    build_holds_queue.pl -script.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

No point in having fancy transfer limits if they cannot be targeted properly to
respect the transfer limits.

Modify the holds targeter to respect transfer limits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:43:55 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-cg3OqaK3ZB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
   Patch complexity|---                         |Small patch
         Depends on|                            |7376, 10993, 11005, 11020
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:43:55 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-oKGcK1SCwq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11024

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:43:55 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-iaXqGaXDTI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11024

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:43:55 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-pmMfagpHxS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11024

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:43:55 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-FrznNOeKjU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11024

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:49:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:49:38 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-WZKnEKp3aW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:50:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:50:00 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-0XaBZ0P1uW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 17:51:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 15:51:04 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-Ao5ZkRGSAy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 18:00:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 16:00:04 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-HnQQ6EJyiP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 18:00:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 16:00:09 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-aaEjQWJzk8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21926
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21926&action=edit
Bug 11023: Toggle "new" status

This patch adds:
- a new DB field items.new.
- a new page to configure this new status
  (tools/toggle_new_status.pl).
- a new cronjob script (misc/cronjob/toggle_new_status.pl).

Why this status is useful for some libraries ?
The use cases are:
- to know easily what are the new items (with a simple sql query).
- to display an icon in the search results.
- issuing rules can be adapt for new items. Automatically (using the
  cronjob script), the status change (depending the configuration) and
  the item can be issued, for example.
- a RSS/Atom feeds can be created on these new items.

Test plan:
- log in with a librarian having the tools > items_batchmod permission.
- navigate to Home > Tools > Toggle new status
- click on the edit button
- there are 3 "blocks":
  * duration: the duration during an item is considered as new.
  * conditions: the status will change only if the conditions are meet.
  * substitutions: if there is no substitution, no action will be done.
    You can add some change to apply to the matching items.
    E.g. ccode=3
         new=''
    If the value is an empty string (in other words, the input does not
    contain anything), the field will be deleted.
  You can create as many rules as you want.
- test the interface : add/remove rule, conditions, substitutions,
  submit the form, edit, etc.
  (There is a looot of JS everywhere, so certainly a looot of bugs...).
- when you have your rules defined, you can now launch the cronjob
  script without any parameter.
  A report will be displayed with the matching itemnumber and the
  substitutions to apply. Verify results are consistent.
- launch the script with the -c argument and verify values have been
  modified depending the substitution rules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 18:43:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 16:43:47 +0000
Subject: [Koha-bugs] [Bug 11025] New: Display UNIMARC fields having $5
 subfield with related items
Message-ID: <bug-11025-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11025

            Bug ID: 11025
           Summary: Display UNIMARC fields having $5 subfield with related
                    items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In UNIMARC, if a field contains a $5, it means the information contained in
that field is related to a specific items. So this field should be displayed in
item detail, not in biblio detail.

Citation from the manual
http://www.ifla.org/files/assets/uca/unimarc_updates/BIBLIOGRAPHIC/u-b_317_update.pdf

"It is expected that the record is made for the ideal copy. However, in this
note field provenance of the copy in hand is described in the form in which it
appears in the book, e.g. book plates, author's and/or owner's autographs,
seals, etc. Code of the institution to which the Provenance Note field applies
is
recorded in $5."

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 19:24:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 17:24:09 +0000
Subject: [Koha-bugs] [Bug 11026] New: in UNIMARC,
 pubdate index should be based on 100 field and not 210
Message-ID: <bug-11026-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11026

            Bug ID: 11026
           Summary: in UNIMARC, pubdate index should be based on 100 field
                    and not 210
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

210$d, curently indexed as pubdate, contains the date of the document
The content can be a complex string like "impr. 2010, cop. 2009" (according to
cataloguing standard). Not sure how zebra
For ancient books, the date could be in latin numbers (MCM...) Zebra does not
like that ;-)

Dates are also in roman numbers 100 coded field. In fact there is 2 dates (pos
9-12 and 13-16) and a code in pos 8 giving the type of date. In most case the
1st date should be indexed and not the 2d one.

Other issue : Sometimes date are uncertain and if the decade only is known, we
will have 198X in 210 field, and "198 " (but I have found 198X and 198. in real
word...). Zebra does not like that too...

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 19:27:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 17:27:10 +0000
Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance
 with new edition of the Unimarc manual
In-Reply-To: <bug-10726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10726-70-jNPXEe4UW1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726

--- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
See also http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11022 and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021 for unimarc
frameworks.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 19:49:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 17:49:30 +0000
Subject: [Koha-bugs] [Bug 11027] New: add a column for basketgroups in late
	orders table
Message-ID: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

            Bug ID: 11027
           Summary: add a column for basketgroups in late orders table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In lateorders.pl it could be usefull to add a new column for basket groups.

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 19:50:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 17:50:35 +0000
Subject: [Koha-bugs] [Bug 11028] New: add new filters in lateorders.pl
Message-ID: <bug-11028-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11028

            Bug ID: 11028
           Summary: add new filters in lateorders.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

Search filters by fund, basket and basketgroup could be usefull in
lateorders.pl

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 20:03:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 18:03:59 +0000
Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests
 that contradict the branch holds policy
In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10243-70-xMfegEl3lX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21927
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21927&action=edit
Bug 10243 - Holds queue is making transfer requests that contradict the branch
holds policy - QA Followup

Using the TransportCostMatrix can cause the same issue. Removing the
last ditch use of the first item causes the the subroutine to continue
with the traditional matching, which will respect the hold policies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 20:55:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 18:55:27 +0000
Subject: [Koha-bugs] [Bug 11029] New: Marc Language Code in a list
Message-ID: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029

            Bug ID: 11029
           Summary: Marc Language Code in a list
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: fabreupeixoto at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When inputing a language code KOHA could have a pre-defined list of language
codes from the Library of Congress Marc Language Code List. It would save time
and would reduce errors in cataloguing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 20:56:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 18:56:33 +0000
Subject: [Koha-bugs] [Bug 11029] Marc Language Code in a list
In-Reply-To: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11029-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11029-70-0oMBAqHj9m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029

Francisco Peixoto <fabreupeixoto at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:38:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:38:18 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-fhaK140oOx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21928
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21928&action=edit
[PATCH 1] Suppress unneeded fields in unimarc_complet default Framework


First patch, for "complete" framework, used by academic libray
900, 901, 910, 918, 920,950,960,970,980,987 fields were useless. I removed
them.
I kept only the fields mentionned in Sudoc documentation
http://documentation.abes.fr/sudoc/formats/loc/index.htm
916 field is not cited in that page, but it belongs to Sudoc format.

I kept also 2 fields specific to Electre in 2013 : 
902 niveau de lecture (Electre)
903  indexation (Electre)

I also added to the name of the 9XX fields I kept the mention (Sudoc) /
(Electre) / (Koha), so it could be easier for librarians to know what is the
purpose and the origin of each field

I don't make an updatedatabase, because some libraries could still be using
these fields for good or bad reasons.

To test :
1) take a fresh Koha with unimarc marcflavor
2) in web installer, select french language, unimarc marflavor and "Grilles de
catalogage compl?tes".
3) check default framework in Administration > MARC Frameworks : it should be
without 900,901,910,918,920,950,970,980,987

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:38:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:38:28 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-d5qwUMcOxU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:39:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:39:06 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-UoELVEeba0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
You can test and sign off even if I did not write yet the patch for "public
libraries" framework.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:43:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:43:23 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-22mEjLrvjM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21928|0                           |1
        is obsolete|                            |

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21929
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21929&action=edit
[PATCH 1] Bug 11021: Suppress unneeded fields in unimarc_complet default
Framework

correct a typo

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:45:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:45:22 +0000
Subject: [Koha-bugs] [Bug 11030] New: Add 359,
 347 and 369 field in french unimarc_complete framework
Message-ID: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

            Bug ID: 11030
           Summary: Add 359, 347 and 369 field in french unimarc_complete
                    framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

3 fields are missing in french unimarc_complete framework, used by french
academic libraries ; 
359 : table of contents in Sudoc network
(http://documentation.abes.fr/sudoc/formats/unmb/zones/359.htm)
347 and 369, used by the french main record provider (Electre)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:45:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:45:32 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-prAIZKMINg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 21:45:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 19:45:41 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-KGynwR5QFo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:22:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:22:53 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-e76xoY9iHj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:23:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:23:24 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-iHfdLtB3Fj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21930
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21930&action=edit
[PATCH] Bug 11030 : add fields 947,969,359 in unimarc_complete french framework

This patch must be tested on top of bug 11021

This patch adds 3 fields to unimarc_complete french framework
- 359 (2-a-b-c-d-e-f-g-h-i-p-u-v) used by Sudoc network, to be displayed in tab
3
- 947 (c) used by Electre
- 969 (a-h) used by Electre
I don't know the difference between 969a and 969h so I gave them quite the same
name

To test :
1) take a fresh Koha with unimarc marcflavor
2) in web installer, select french language, unimarc marflavor and "Grilles de
catalogage compl?tes".
3) check default framework in Administration > MARC Frameworks : it should
contains 359/947/969 fields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:23:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:23:58 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-NY190KEmeM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:24:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:24:09 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-Dct2nvhCgf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11030

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:24:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:24:09 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-Xiwl0CkhfM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11021

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:24:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:24:21 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc
	frameworks
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-qUHyufQ6RT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct  9 22:32:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 09 Oct 2013 20:32:04 +0000
Subject: [Koha-bugs] [Bug 10913] useless code in acqui/basket.pl ?
In-Reply-To: <bug-10913-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10913-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10913-70-e2lI3zTo3D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
           Severity|minor                       |normal

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I update priority. Maybe it is an important issue, I don't know...

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 06:00:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 04:00:22 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
 PK, not cardnumber
In-Reply-To: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10636-70-czrcPWkTYC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 06:00:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 04:00:25 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
 PK, not cardnumber
In-Reply-To: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10636-70-v4PwmSNuOG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Srdjan Jankovic <srdjan at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21923|0                           |1
        is obsolete|                            |

--- Comment #14 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Created attachment 21931
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21931&action=edit
[SIGNED-OFF] Bug 10636 - patronimage should have borrowernumber as PK, not
cardnumber

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable patronimages
4) Verify patron images are still displaying correctly
5) Test deleting a patron image
6) Test adding a patron image from moremember.pl
7) Test adding a patron image from tools/picture-upload.pl

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:20:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:20:34 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-udJXBOuHQU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21926|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21932
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21932&action=edit
Bug 11023: Toggle "new" status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:25:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:25:15 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-U1uc0TB62b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:28:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:28:03 +0000
Subject: [Koha-bugs] [Bug 10913] useless code in acqui/basket.pl ?
In-Reply-To: <bug-10913-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10913-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10913-70-VoN45hCM0P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:29:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:29:17 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc_complet
 default Framework
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-NDMkHIlbvA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Delete useless 9XX field in |Delete useless 9XX field in
                   |unimarc frameworks          |unimarc_complet default
                   |                            |Framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:30:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:30:08 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in unimarc_complet
 default Framework
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-Bq8DzlSUGH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
This bug will be only for french unimarc_complet default Framework.
An other bug will be filled for french unimarc for public library, as the case
may be different

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:30:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:30:19 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
 unimarc_complet default Framework
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-QX2AUag1I3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Delete useless 9XX field in |Delete useless 9XX field in
                   |unimarc_complet default     |french unimarc_complet
                   |Framework                   |default Framework

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:33:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:33:18 +0000
Subject: [Koha-bugs] [Bug 11031] New: Delete useless 9XX field in french
 unimarc public library default Framework
Message-ID: <bug-11031-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11031

            Bug ID: 11031
           Summary: Delete useless 9XX field in french unimarc public
                    library default Framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Same logic as 11030 for french unimarc framework for public libraries.
The unimarc records provided by BNF contains only 2 9XX fields : 918 and 987
http://www.bnf.fr/documents/UNIMARC%28B%29_conversion.pdf
Electre provides 902,903,947,969 fields.
942 and 995 are used by Koha

All other 9XX fields must be deleted.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:33:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:33:32 +0000
Subject: [Koha-bugs] [Bug 11031] Delete useless 9XX field in french unimarc
 public library default Framework
In-Reply-To: <bug-11031-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11031-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11031-70-fdmX68NcdU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11031

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:46:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:46:37 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-29hXGCEsJC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:46:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:46:40 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-XEjFtcm4TB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21846|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21933
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21933&action=edit
Bug 11003: JS error on the cart page

A call to yuiToolbar breaks js code on the cart page.

Test plan:
- add some biblio to your cart
- open the cart
- a js error occurs (see it with firebug):
  ReferenceError: yuiToolbar is not defined
- apply the patch
- retry and verify the error does not appear anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:47:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:47:33 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-WCgExs9FOZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21806|0                           |1
        is obsolete|                            |

--- Comment #3 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21934
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21934&action=edit
Cannot exclude numeric subfields on export

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:47:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:47:43 +0000
Subject: [Koha-bugs] [Bug 11003] intranet cart email broken
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-uyyhkDRKgG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Paola,
Yes you are right, but the js error still occurs, it should be fixed.
I updated the path.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:47:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:47:54 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-eTgSlMPdmQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |paola.rossi at cineca.it

--- Comment #4 from Paola Rossi <paola.rossi at cineca.it> ---
I sign off the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:47:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:47:58 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-g23vXduTQe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|intranet cart email broken  |JS error on the cart page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 09:50:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 07:50:50 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-CLGCKIuutp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #162 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Sorry, but applying this patch breaks a lot of encodings on several places in
opac and staff. Just look at opac-search and catalogue search. I have lots of
broken characters (that should have diacritics) in the results (based on XSLT)
and in the facets.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 10:35:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 08:35:16 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-OUEueyNXe6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21933|0                           |1
        is obsolete|                            |

--- Comment #5 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21935
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21935&action=edit
JS error on the cart page

Thanks, Jonathan.
I confirm that the patch fixes the js error.
I sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 10:35:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 08:35:26 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-t3zdi68WKM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 10:40:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 08:40:39 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-6lnXEcUoOO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #1 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 21936
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21936&action=edit
Bug 10988 [ENH] Allow login via Google OAuth2 Adds googleoauth2 login to koha.
Adds applicable system preferences Modifies templates to support oauth2 login
failures changes the login links to use googleoauth2 when oauth2 is enabled.

Current status: NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 10:49:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 08:49:29 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-m66bCiu3xU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #163 from Ketan Kulkarni <ketan at carvingit.com> ---
Created attachment 21937
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21937&action=edit
My opac after search

My opac search does not break after applying the patch. Could you please upload
a screenshot? This is from the latest master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 10:54:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 08:54:30 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-8YfmMZjFAg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #2 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
The latest patch is a fully functional version of GoogleOAuth2, being used in
production here at http://library.pbc.wa.edu.au/

Test Plan:
1) Apply this patch
2) Update the database (this is the bit I'm not sure about - I've added the SQL
into the atomicupdates directory - is this right?)
3) Create a web app in the google cloud console:
     - Go to https://cloud.google.com/console
     - Create a project, and give it some details
     - Open the Project by clicking on it
     - Under APIs & auth menu, open "Registered Apps" and click "Register App"
     - Give it a name and make sure you select "Web app", click ok
     - Under OAuth 2.0 Client ID,
         - under web origin, type <your_opac_address>
         - in the redirect uri enter
<your_opac_address>/cgi-bin/koha/svc/googleoauth2
         - click Generate
4) Set the GoogleOAuth2ClientID and GoogleOAuth2ClientSecret according to the
values generated above
5) Test that clicking login intiates an oauth2 login
6) Try logging in with an email that is not registered to a library user. It
should fail and offer either to retry or to login manually.
7) Try logging in with an email that is registered to a library user. You
should be logged in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 11:08:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 09:08:15 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-wSjrwPR6aa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #3 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 21938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21938&action=edit
Bug 10988 [ENH] Allow login via Google OAuth2

This patch fixes a minor typo in the previous one regarding the oauth2 redirect
uri
Adds googleoauth2 login to koha. Adds applicable system preferences Modifies
templates to support oauth2 login failures changes the login links to use
googleoauth2 when oauth2 is enabled.

Test Plan:
1) Apply this patch
2) Update the database (this is the bit I'm not sure about - I've added the SQL
into the atomicupdates directory - is this right?)
3) Create a web app in the google cloud console:
     - Go to https://cloud.google.com/console
     - Create a project, and give it some details
     - Open the Project by clicking on it
     - Under APIs & auth menu, open "Registered Apps" and click "Register App"
     - Give it a name and make sure you select "Web app", click ok
     - Under OAuth 2.0 Client ID,
         - under web origin, type <your_opac_address>
         - in the redirect uri enter
<your_opac_address>/cgi-bin/koha/svc/googleoauth2
         - click Generate
4) Set the GoogleOAuth2ClientID and GoogleOAuth2ClientSecret according to the
values generated above
5) Test that clicking login intiates an oauth2 login
6) Try logging in with an email that is not registered to a library user. It
should fail and offer either to retry or to login manually.
7) Try logging in with an email that is registered to a library user. You
should be logged in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 11:13:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 09:13:29 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-EeBxBKObiw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #4 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Created attachment 21939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21939&action=edit
Bug 10988 Fix some minor typos

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 11:15:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 09:15:27 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-vft9hjU5Zv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21740|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 11:16:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 09:16:13 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-8UFjvJqowq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Nicholas van Oudtshoorn <vanoudt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21936|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 11:38:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 09:38:13 +0000
Subject: [Koha-bugs] [Bug 10777] runreport.pl allows for sending html
 reports via email, but mimetype is wrong
In-Reply-To: <bug-10777-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10777-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10777-70-Su7PWAnTcU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10777

--- Comment #5 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
Test plan:

1. Run a report as follows:
./runreport.pl --format=html --to=YOUREMAIL --subject="Bad formatting"
REPORTNUMBER
2. Look at the email - the html code should show in modern email readers.
3. Apply the pathc
4. Run the report again:
./runreport.pl --format=html --to=vanoudt at gmail.com --subject="Lost items
report" 45
5. Look at the email - it should appear nicely formatted with no html codes
visible

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:18:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:18:28 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-cMNpFy2Oq9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #164 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Ketan Kulkarni from comment #163)
> Created attachment 21937 [details]
> My opac after search
> 
> My opac search does not break after applying the patch. Could you please
> upload a screenshot? This is from the latest master.

You are not using XSLT on OPAC? Please change these preferences and test.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:24:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:24:28 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-drN7zyCcIR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         QA Contact|                            |jonathan.druart at biblibre.co
                   |                            |m
           Severity|minor                       |normal

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

The patch works as expected and the behavior is consistent to me.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:24:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:24:48 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-og6oORueDp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21061|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21940&action=edit
Bug 10037 : item index is broken in UNIMARC DOM indexing

In UNIMARC DOM indexing, "item" index is working only for subfields of 995
field mapped with specific indexes, and also in index (ex : $a, $b...)
It is not working for the other subfields (ex : $g), because a comment from
record.abs was integrated in DOM config files.
This patch removes the comment.

To test, in a DOM UNIMARC environment :
1) in a item, write some value "Test10037" in 995$g
2) search for this value in simple search, this way : item=Test10037 => you
should have no results
3) apply the patch. if necessary, copy the modified
src/etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml and 
src/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl into the
/etc/... directory in your main Koha directory
4) reindex zebra biblios
5) do the same search as 2) => you should have one result

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors.

Test

NOTE: default UNIMARC framework don't have 995g,
so I must add it first.

1) Added test string to 995b on some record
2) Reindex and search as indicated, no results
3) cp files to destination
4) reindex
5) search and result ok !

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:25:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:25:50 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-tanTVbEIXR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #3)
> Bit stuck on testing here as I have some errors on running a full reindex:
> REINDEXING zebra
> ====================
> 00:34:32-07/10 zebraidx(27269) [warn] isamb: Inconsistent register (2)
> zebraidx: isamb.c:1102: insert_leaf: Assertion `*lookahead_mode' failed.
> 00:34:33-07/10 zebraidx(27279) [warn] previous transaction didn't reach
> commit
> 
> I will have to investigate some more.

Note: I hadn't these errors on reindexing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:32:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:32:15 +0000
Subject: [Koha-bugs] [Bug 11032] New: Validate passed records in Biblio.pm
Message-ID: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

            Bug ID: 11032
           Summary: Validate passed records in Biblio.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

We've all seen Biblio.pm giving the error 'can't call method fields on an
undefined value' for various reasons. They usually cause confusion or panic as
a low level error gets thrown at the user with no apparent relation to their
current operation. The problem is that many of Biblio's routines are rather
optimistically written so that it thinks you've passed a MARC::Record object
you have and it assumes that nothing could every go wrong in this best of all
possible worlds.

Routines should at least check they have a defined record before trying to
process it, and should log a stack trace so that the cause can be determined in
the case of the error.

Merely passing a low level error to the end user is non-productive.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:33:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:33:00 +0000
Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present
 shows wrong (XSLT)
In-Reply-To: <bug-10957-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10957-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10957-70-wwURoni3dp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21494|0                           |1
        is obsolete|                            |
  Attachment #21501|0                           |1
        is obsolete|                            |

--- Comment #3 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 21941
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21941&action=edit
710$a with 710$b (subordinate unit) present shows wrong (XSLT)

I sign off the patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:33:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:33:14 +0000
Subject: [Koha-bugs] [Bug 10957] 710$a with 710$b (subordinate unit) present
 shows wrong (XSLT)
In-Reply-To: <bug-10957-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10957-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10957-70-bs2ZVsxOEQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10957

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |paola.rossi at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:42:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:42:58 +0000
Subject: [Koha-bugs] [Bug 3873] Gracefully handle errors when item in staff
 client cart has been deleted
In-Reply-To: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3873-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3873-70-zB9DcoErCm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3873

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
I've added a bug 11032 to address the susceptability of Biblio.pm to abort in
such cases leaving the calling routines unable to clean up sensibly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 12:57:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 10:57:33 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-8mOVREjVmG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It's very likely my Zebra UNIMARC configuration was problematic, as I had
tested other patches before. Thx Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:08:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:08:55 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-lR8LnyXTVF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

--- Comment #10 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Anyway, the current code was obviously wrong ;-)
"<target_index>item   # just to index every subfield:w</target_index>"

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:15:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:15:46 +0000
Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating
In-Reply-To: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8769-70-kXB5m0j8me@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20000|0                           |1
        is obsolete|                            |

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21942
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21942&action=edit
Bug 8769 - Allow SIP2 return backdating

Currently Koha's SIP server ignores the return date part of an 09 ( aka
CHECKIN ) message. Koha should backdate a return, and remove
fines accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:43:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:43:01 +0000
Subject: [Koha-bugs] [Bug 11033] New: In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
Message-ID: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

            Bug ID: 11033
           Summary: In basketgroup pages, Save button and Cancel link are
                    hidden by chooselanguage bar
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In basketgroup pages, Save button and Cancel link are hidden by chooselanguage
bar
This is caused by the css declaration setting body margin and padding in
basketgroup.tt to 0.

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:43:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:43:27 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-0VuxTtFI4H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:43:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:43:35 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-mdZXWbSJzT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f
                   |ity.org                     |r

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:43:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:43:40 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-oyjwFLdFZI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:44:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:44:49 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-xOpkcXYVGl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Mathieu, the commit message says the patch adds 2 indexes: damaged and lost.
But in fact it adds damaged and withdrawn.

Could you fix the commit message please?
Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:49:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:49:54 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-6lB8mgcf6V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21943&action=edit
[PATCH] Bug 11033 Make Save button and Cancel link always visible on
basketgroup page


This patch suppress the first CSS declaration in basketgroup.tt. It was
unneeded, and was the cause of the Save button and Cancel link not being
visible if the bar for changing language was activated.

To test :
1. activate the "language" syspref, with at least 2 languages
2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at
the bottom of basketgroup page
3. Check you can use the basketgroup as before : put a basket in it, cancel,
save etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 13:50:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 11:50:04 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-grtqUVSZKN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:33:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:33:31 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-VRQaeyI0Le@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
By the way, the code of this template file is pretty ugly, but that's not the
problem here ;-)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:34:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:34:47 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-tHWY3TLlz7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:34:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:34:45 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-zmlY6ESkP8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:34:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:34:49 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-l141o9mgMW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:37:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:37:50 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-Dho3unubU6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I am working on that
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:38:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:38:55 +0000
Subject: [Koha-bugs] [Bug 10919] Use the date of closing basketgroup for
 calculating late orders
In-Reply-To: <bug-10919-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10919-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10919-70-zWuSatxWnx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10919

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I am working on that. First, create 1 or 2 a new columns in aqbasketgroup table
in database

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:51:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:51:24 +0000
Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a
	separated js file
In-Reply-To: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10533-70-vzq6uBGPBD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
"- Try all actions for basketgroup ( drag/drop, add, delete, close, print,
reopen, edit, export as csv)."
=> OK for me

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 14:53:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 12:53:12 +0000
Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a
	separated js file
In-Reply-To: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10533-70-qIHRBMuv8Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

--- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Is there really a risk of regression on the other pages? Is there a specific
point to test?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:00:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:00:35 +0000
Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a
	separated js file
In-Reply-To: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10533-70-sPkVcVDsS7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #9)
> Is there really a risk of regression on the other pages? Is there a specific
> point to test?

No, it is a c/p code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:06:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:06:56 +0000
Subject: [Koha-bugs] [Bug 11034] New: BiblioAutoLink has incorrect return in
	addbiblio.pl
Message-ID: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

            Bug ID: 11034
           Summary: BiblioAutoLink has incorrect return in addbiblio.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

addbiblio.pl calls BiblioAutoLink expecting an array to be returned but the
routine returns a scalar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:09:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:09:28 +0000
Subject: [Koha-bugs] [Bug 10435] To add some shortcuts to acquisitions main
 screen e.g. Receive Shipment and Filter Box
In-Reply-To: <bug-10435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10435-70-hCxxciUkDq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10435

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |philippe.blouin at inlibro.com
         Resolution|---                         |DUPLICATE

--- Comment #1 from Blou <philippe.blouin at inlibro.com> ---


*** This bug has been marked as a duplicate of bug 10393 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:09:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:09:28 +0000
Subject: [Koha-bugs] [Bug 10393] To add some shortcuts to acquisitions main
 screen e.g. RECEIVE SHIPMENT and the FILTER BOX
In-Reply-To: <bug-10393-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10393-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10393-70-qWYH7Wqsbc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10393

--- Comment #7 from Blou <philippe.blouin at inlibro.com> ---
*** Bug 10435 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:15:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:15:55 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-CJscesVLZZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:17:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:17:15 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-wKuojqHHcV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 21944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21944&action=edit
Proposed Patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:29:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:29:22 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-DYSffRex4P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
   Patch complexity|Small patch                 |Large patch
         QA Contact|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #45 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

The patch works as expected. I'm not sure to have tested all cases but I don't
encounter any problem.
Tested with GRS-1 and DOM, tested indexes, coded fields, etc.

I am not an UNIMARC expert and certainly not a zebra expert but I take the
responsibility of passing QA on these patch relying on Fr?d?ric and Bernardo
sign off.

Note: The zebra index will have to be rebuilt.

Marked as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:30:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:30:27 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-C8JlOo4YY0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21057|0                           |1
        is obsolete|                            |
  Attachment #21058|0                           |1
        is obsolete|                            |
  Attachment #21059|0                           |1
        is obsolete|                            |
  Attachment #21437|0                           |1
        is obsolete|                            |
  Attachment #21454|0                           |1
        is obsolete|                            |

--- Comment #46 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21945&action=edit
Bug 8252: Fix indexing of UNIMARC 1xx for GRS-1

Before fixing UNIMARC DOM indexing, we must fix GRS-1 indexing

1) In advanced search, some Coded fields index are not working : Print,
Illustration, Content
2) Country-heading index is not working
3) Some subfields are indexed in wrong indexes :
102$a should be in Country-publication instead of Country-heading (non defined
in bib1.att)
106$a, filled only for printed works, should be in ff88-23 (form of item)
instead of itype
(ff88-23 is made for Marc21 008 pos 23, which contains the same data as 106a)
200$b should be in Material-type instead of (or in addition to) itype and
itemtype
(Material-type :"free-form string, ... that describes the material type of the
item, e.g., cassette, kit, computer database, computer file.")
100$a pos 22-24 should not be indexed as "ln" : it is the language of the
record, not the language of the ressource
4) Index names are too long : if we index new positions of coded fields, with
existing names it breaks zebra indexing (there must be a limit in line lenghth
in record.abs?)
5) There are a lot of warns when rebuiding zebra.

This patch make some changes in bib1.att (could be used later to improve
search) :
- fixing wording for att 51 and 1012
- adding comments for attributes based on MARC21 008 field (8800-8841)
- creating 8806 (tpubdate), 8838 (Modified-code), 8818 (ff8-18), 8840
(ff8-18-21), 8819 (ff8-19), 8821 (ff8-21), 8828 (ff8-28), 8830 (ff8-30), 8831
(ff8-31)
- creating attributes specific to UNIMARC : 9701-9707 (Video-mt, Graphics-type,
Graphics-support, Title-page-availability, Cumulative-index-availability,
script-Title, char-encoding)
- setting apart 3 blocks of attributes, so it could be easy to make further
changes :
-- common to Marc21 and UNIMARC : 8806, 8822, 8838
-- slightly different in Marc21 and UNIMARC (different meanings according to
the type of the record => don't match a single UNIMARC field)
-- specific to UNIMARC : 9701-9707

in ccl.properties :
- creating a new index: Country-publication 1=1053
- suppressing some warns by mapping with bib1 att: Date-time-last-modified,
Name, rtype, Music-number
- defining indexes using the 3 blocks attributes defined in bib1 (common to
Marc21 and UNIMARC, slightly different, specific to UNIMARC)

in record.abs :
- renaming some index for 100-105-110 fields
- correcting indexing of 102$a (country of publication)
                         106$a (ff88-23)
                         100$a pos 22-24 (language of record, no more indexed)
                         105$a pos. 0-3 (illustration code)
                         200$b (for the moment, I keep it indexed in itype and
itemtype, but also Material-Type)

in C4/Search.pm :
- adding "Country-publication" index

in opac and staff interface template subtypes_unimarc.in :
- renaming indexes to take into account the changes made to Zebra config files

To test (this cannot be done with a sandbox) :
1) apply the patch in a UNIMARC GRS-1 Koha instance
2) copy the following files from the etc/zebradb of your source directory into
the etc/zebradb of your main Koha directory :
-- etc/zebradb/biblios/etc/bib1.att
-- etc/zebradb/ccl.properties
-- etc/zebradb/marc_defs/unimarc/biblios/record.abs
3) reindex your data (rebuild_zebra -x -b -r -v)
4) try to use those Coded fields indexes in Advanced search, in OPAC and Staff
interface (available after clicking on "More options", then on "Coded
information filters"):
Audience, Print, Literary genre, Biography, Illustration, Content, Video Types,
Serials, Serial Type, Periodicity, Regularity
5) try to search "Country-publication=FR" in simple search

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No koha-qa errors.

Tests for GRS-1
Followed test plan
Search by coded fields works, but only on OPAC,
on staff there are few options
Search by Country-publication works after patch

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:30:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:30:33 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-FhPwHbQryo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #47 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21946&action=edit
Bug 8252: Fix indexing of UNIMARC 1xx for DOM

This patch makes the same changes in UNIMARC DOM configuration as PATCH 1 made
for GRS-1.
You MUST apply the first patch with this one (this one depends on some
modifications made by patch 1/2)

positions of subfields are indexed that way :
In biblio-koha-indexdefs.xml :
tag="100" subfields="a" offset="17" length="1"
In biblio-zebra-indexdefs.xsl :
xslo:value-of select="substring(., 17, 1)"

I had to edit biblio-zebra-indexdefs.xsl by hand, because
etc/zebdradb/xml/koha-indexdefs-to-zebra.xsl does only support "subtring" in
handle-one-index-control-field template.
It is good for MARC21, but not for UNIMARC : in MARC21, indexing subtrings is
needed for controled field (001-009, with no subfields)
But in UNIMARC it is needed for subfields of 1XX fields.
So if DOM indexing is working with these new files, we may need to change
koha-indexdefs-to-zebra.xsl.

Test plan (not possible in a sandbox) :
1) In a Koha instance using UNIMARC and DOM indexing
2) apply Patch 1 and Patch 2 (this one)
3) copy the following files from the etc/zebradb directory of your source into
the etc/zebradb directory of your main Koha directory :
-- etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
-- etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
-- etc/zebradb/ccl.properties
-- etc/zebradb/biblios/etc/bib1.att
4) rebuild zebra with -x -b -r -v options
5) check if coded filters in advanced search are usable in OPAC and Staff
interface

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works. No koha-qa errors.

Test for DOM
Apply patches
Don't forget to copy files
reindex
Search by coded fields works, also Country-publication

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:30:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:30:38 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-lpFGyo4vow@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21947&action=edit
Bug 8252 : Followup for Date/time-last-modified and Music number

This followup restores the original wording of "Date/time-last-modified" index,
and change the name of "Music-number" index to "Number-music-publisher"

To test :
1. In a UNIMARC Koha instance
2. apply patchs #1, #2 and this followup
3. copy from src/etc/zebradb directory to the etc/zebradb/ in your main koha
directory the following files :
-- zebradb/biblios/etc/bib1.att
-- zebradb/ccl.properties
-- zebradb/marc_defs/unimarc/biblios/record.abs
-- zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
-- zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
4. rebuild zebra with -b -x -v -r options
5. write a value like "test071a" in 071$a field in a record
6. check if you can find this record with this search :
"ccl=Number-music-publisher:test071a"

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No koha-qa errors.

Test
Copy files
reindex full
Modify a couple of record to add 071a with test message
Reindex -v -z -b -x
Search test message as described and found modified records.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:30:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:30:44 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-nwhB6osA5Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #49 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21948&action=edit
Bug 8852 XSL handling sufield substring extraction

This patch modify koha-indexdefs-to-zebra.xsl in order to add the
ability to populate indexes with subfield substring.

It's now possible to understand such construction as:

<index_subfields xmlns="http://..." tag="100" subfields="a" offset="7"
length="1">
  <target_index>tpubdate:s</target_index>
</index_subfields>

Signed-off-by:Mathieu Saby <mathieu.saby at univ-rennes2.fr>
I applied the patch and run xsltproc koha-indexdefs-to-zebra.xsl
../marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml >
../marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
I lookes at the generated file. It looks nice.
Then I copied it file in my INSTALLDIR/etc/zebra.... and reindexed my records
with rebuild_zebra.pl
I made some searches on coded position index and non coded position indexes,
everything works.

http://bugs.koha-community.org/show_bug.cgi?id=8252

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 15:32:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 13:32:22 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-wvFlqTnYp7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #50 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21949&action=edit
Bug 8252: Fixing biblio-zebra-indexdefs.xsl

    Bug 8252: Fixing biblio-zebra-indexdefs.xsl

    This patch fixes biblio-zebra-indexdefs.xsl files.
    It was generated from biblio-koha-indexdefs.xsm with the new
koha-indexdefs-to-zebra.xsl amended by F. D?mians's patch.

    To test :
    - take a DOM UNIMARC Koha
    - apply all the patchs of 8252 bug, including this one
    - copy src/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
to your etc/zebradb/marc_defs/unimarc/biblios/ located in your installation
directory
    - run rebuid_zebra -b -x -r -v
    - make advanced searches on staff interface and opac, on coded fields
indexes (Audience, Literary genre, Biography, Illustration, Content, Video
Types, Serial Type, Periodicity, Regularity, Picture)

    Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr>

    Ok for me. This patch put in sync indexes XSL definition with
    authoritative XML definition. Subsequently, it won't be difficult to
    amend DOM UNIMARC indexes defintion if necessary. And, as it is, I don't
    see any regression, whereas I can see huge improvements. Thanks Mathieu!

    Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:00:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:00:32 +0000
Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for
	authorities
In-Reply-To: <bug-7484-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7484-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7484-70-rQlfcXtJj9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paola.rossi at cineca.it

--- Comment #4 from Paola Rossi <paola.rossi at cineca.it> ---
Page "Home ? Authorities"

1) I'm on the "Search authorities" tab. I select an authority type, then change
the active tab. The type change is lost.

The type seemes to be lost only if the "second" tab is empty, as it initially
is.
If a selection would have been previously made for that "second" tab, it would
not be lost.
Now a user can make a selection for a tab, and a different selection for a
another tab, and they would be both kept.
All the 4 parts (name/term, verb, data, sort) of a condition set in one of the
3  tab ("main headings" or "all headings" or "keyword" search) are kept exactly
the same after moving from this tab to another one, and then coming back to the
first tab.

If the user would choose different selections in the 3 tabs, the patch would
loose this information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:08:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:08:11 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-G2nov0Lvo6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #17 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #16)
Could you tell where you are stopped in test plan ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:11:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:11:09 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-EIXvjCJXVL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Fridolyn, see comment 14 - I need instructions on how to correctly catalog a
UNIMARC authority with the required fields to reproduce this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:24:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:24:47 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-GD7AGioOqz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #33 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:

I retry same tests as Henri Damien:

- go on authorities/authorities-home.pl
- Select "default" "contains" "wil" "main heading"
  * GSR-1: 27 results
  * Dom  : 27 results
- Select "default" "contains" "wil" "all headings"
  * GSR-1: 0 result
  * Dom  : 27 results
- Select "default" "contains" "wil" "Keyword search"
  * GSR-1: 27 results
  * Dom  : 29 results

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:25:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:25:47 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-BwMtLQRAzR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(Maybe I did an error somewhere, I start to be tired to parse xml with my
eyes...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:51:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:51:23 +0000
Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request
 management by branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-jaP7NpIRDM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:51:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:51:27 +0000
Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request
 management by branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-mpP6pVLFou@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21950
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21950&action=edit
Bug 10904 - would like to limit patron update request management by branch

By not limiting the patron modification lists by branch, it can quickly
become overwhelming for a librarian. This patch makes the following
modifications:

* Only superlibrians will see the full list of borrowers with pending
  modifications.
* Adds the patron cardnumber after the patrons name on the modification
  list.
* Adds a link to the patron's record from the modification list.

Test Plan:
1) Apply this patch
2) Set up some pending modifications for two branches
3) Log in to the staff intranet as one of those branches
4) You should note the number of pending modifications counts
   only your logged in branch's patrons
5) Click the link, you should only see your logged in branches
   patrons in the pending modifications list.
6) You should note the cardnumber is displayed next to the patron name
7) You should note the "View record" link below each patron's name

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 16:51:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 14:51:57 +0000
Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request
 management by branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-MYezjTknny@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
   Patch complexity|---                         |Small patch
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 17:16:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 15:16:51 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-aBvWbspBu2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #35 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jonathan Druart from comment #33)
> QA comment:
> 
> I retry same tests as Henri Damien:
> 
> - go on authorities/authorities-home.pl
> - Select "default" "contains" "wil" "main heading"
>   * GSR-1: 27 results
>   * Dom  : 27 results
> - Select "default" "contains" "wil" "all headings"
>   * GSR-1: 0 result
>   * Dom  : 27 results
> - Select "default" "contains" "wil" "Keyword search"
>   * GSR-1: 27 results
>   * Dom  : 29 results
> 
> Marked as Failed QA.

I will look at it.
In what precise field/subfield did you put the "wil" string?

Maybe the small discrepancy for Keyword search exists also between MARC21 DOM
and GRS1? 

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 17:22:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 15:22:25 +0000
Subject: [Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ?
In-Reply-To: <bug-10913-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10913-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10913-70-h7zCbzDvTW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|useless code in             |non executed code in
                   |acqui/basket.pl ?           |acqui/basket.pl ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 17:23:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 15:23:33 +0000
Subject: [Koha-bugs] [Bug 11017] neworderempy.pl strip 952 field (Marc21)
 but not 995 (Unimarc)
In-Reply-To: <bug-11017-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11017-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11017-70-uuDXKmByNl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11017

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I think this part of code is only executed when a record is imported with z3950

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 17:51:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 15:51:41 +0000
Subject: [Koha-bugs] [Bug 11035] New: Replace shortcut plugin
	jquery.hotkeys.min.js
Message-ID: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

            Bug ID: 11035
           Summary: Replace shortcut plugin jquery.hotkeys.min.js
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

(Not sure I have have the right Component or Severity, feedbacks welcomed).

A sponsor asked for some specific keyboard shortcuts.  After discussion a month
ago with (oleonard, jcamins), it seemed a change of plugin was needed because
the current one is not maintained and would limit our ability to upgrade
jquery, simply.

I was suggested a few independant ones, and implemented my feature with
openjs's.

This bug is ONLY about changing the plugin.  It brings no new functionnality
nor does it changes behavior.  Enhancement to shortcut could bring a lot of
discussion.

Refression TESTING: 
1) apply the patch, 
2) in intranet, validate that the three available shortcuts (Alt-r, alt-u,
alt-q) are still functionning perfectly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 17:52:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 15:52:10 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-QFUTj7Hzua@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 17:55:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 15:55:56 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-gO91bRUNdn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 18:44:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 16:44:55 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-vtMGBYDcsR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21951&action=edit
PATCH] Bug 11027 : Add a column for basketgroups in late orders table and
improve other columns

To apply ON TOP of bug bug 7298

This patch makes 4 changes in late orders page : 
- adding a new column for basketgroup, displaying the name and number of the
basketgroup
- displaying the name of the basket as well as its number
- displaying fund in a separate column to make sorting easier, and renaming it
from "budget" to "fund" (the confusion can be found elsewhere in Koha...)
- displaying branch in a separate column to make sorting easier (this column
could be improved later, by getting branch from basketgroup if there is one)

For that, in Aquisition.pm, I made some changes to GetLateOrders :
- 3 new columns in SELECT, 1 new join
- cosmetic : rename "closedate" to "aqbasket.closedate" in 4 occurences : it
will be usefull later, because I am envisonning an other patch that will create
a "closedate" column in basketgroup table, and I don't want MySQL to crash
because of ambiguous column.

To test :
1. display the list of late orders of your instanc.
2. You should have 3 new columns for basketgroups, fund and branch
3. In basketgroup column you should have "name of basket group (number)"
4. In basket column you should have "name of basket (number)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 18:45:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 16:45:14 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-sAGabw3S2U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 18:45:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 16:45:24 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-Dnc2mS1fhT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f
                   |ity.org                     |r

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 18:45:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 16:45:36 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-RbnTdbTycI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 18:45:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 16:45:48 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-R166xieW5k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11027

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 18:45:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 16:45:48 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-3OYp13S16r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7298

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 19:22:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 17:22:26 +0000
Subject: [Koha-bugs] [Bug 11036] New: track log ins to the OPAC
Message-ID: <bug-11036-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11036

            Bug ID: 11036
           Summary: track log ins to the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be great to track log ins to the OPAC. Maybe not the 'who' but the
when would be super helpful for tracking OPAC usage.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 19:52:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 17:52:37 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-rESSNsm7NI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

--- Comment #1 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21952
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21952&action=edit
Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

To old plugin prevents the upgrade to the latest jquery.  By replacing with
openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest.

Changes:
- removed jquery.hotkeys.min.js
- added shortcut.js
- modified the related includes (doc-head-close.inc and help-top.inc)
- modified the calls in staff-global.js

Regression test:
1) apply the patch
2) in the intranet, test the shortcuts alt-q, alt-r, alt-u.

These are the only affected functionalities.  There is no new functionnality.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 19:53:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 17:53:25 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-cytbseJG1c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 20:36:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 18:36:23 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-SBL1GkrBiu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #51 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Mathieu and Fr?d?ric!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 20:48:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 18:48:04 +0000
Subject: [Koha-bugs] [Bug 9057] Add support for authorities to NORMARC
In-Reply-To: <bug-9057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9057-70-BMPRLa7QE4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9057

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add support for athorities  |Add support for authorities
                   |to NORMARC                  |to NORMARC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 20:56:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 18:56:48 +0000
Subject: [Koha-bugs] [Bug 10037] fix item index in UNIMARC DOM indexing
In-Reply-To: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10037-70-ugAiopPmRd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master along with a regression test.  Thanks, Mathieu!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 21:16:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 19:16:48 +0000
Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display
 properly information on parallel form
In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10335-70-DWQdCbxy3Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Janusz!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 21:18:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 19:18:56 +0000
Subject: [Koha-bugs] [Bug 9808] Show basketgroup information for each basket
 in basket list
In-Reply-To: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9808-70-fE2aWCGRml@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9808

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 21:23:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 19:23:41 +0000
Subject: [Koha-bugs] [Bug 9808] Show basketgroup information for each basket
 in basket list
In-Reply-To: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9808-70-UgIr8LaLyj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9808

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21953&action=edit
[PATCH] Bug 9808: Show basketgroup information in baskets list on bookseller
page


This patch adds a column for basketgroup information in the list of basket
displayed for each bookseller.

To test :
1. display the list of baskets of a bookseller, with some baskets included in
basketgroups, and some other not
2. check a new column "Basket group" appears
3. If the basket belongs to a basket group, the following information must be
displayed in new column : "Basketgroupname (basketgroupnumber)"
4. If the basket does not belong to a basket group, the new column must be void

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 21:23:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 19:23:55 +0000
Subject: [Koha-bugs] [Bug 9808] Show basketgroup information for each basket
 in basket list
In-Reply-To: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9808-70-rrNROQI9xu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9808

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 21:28:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 19:28:03 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-yvYDQ1dQEs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #52 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
yippee!

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 22:15:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 20:15:18 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-wYMLfbSmZQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #36 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I am not sure I understood how Koha is searching authorities, so I explored the
code.

In authorities-search.inc : 
- you have 3 choices (main heading, match heading, all headings.
- each choice is linked with a value of "marclist" field, passed in the form in
an <input>.
- main heading => marclist=mainentry
- match heading => marclist=match
- all heading => marclist=all
These data are passed to authorities-home.pl

In authorities-home.pl : 
my ( $results, $total ) = SearchAuthorities(
        [$marclist],  [$and_or],
        [$excluding], [$operator],
        [$value], ( $startfrom - 1 ) * $resultsperpage,
        $resultsperpage, $authtypecode,
        $orderby
    );


In C4/AuthoritiesMarc.pm :
sub SearchAuthorities {
    my ($tags, $and_or, $excluding, $operator, $value,
$offset,$length,$authtypecode,$sortby,$skipmetadata) = @_;
...
elsif ( @$tags[$i] eq "mainentry" ) {
                $attr = " \@attr 1=Heading ";
...
elsif ( @$tags[$i] eq "match" ) {
                $attr = " \@attr 1=Match ";
...
else { # Assume any if no index was specified
                $attr = " \@attr 1=Any ";


There is no specific choice for the "all" value, so the "any" index is used. I
wonder if it is normal.

But your failing case
- Select "default" "contains" "wil" "all headings"
>   * GSR-1: 0 result
>   * Dom  : 27 results

probably means that "Any" index is broken.


Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 22:20:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 20:20:27 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-EC0Pcb5ti6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #37 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
In record.abs for GRS1 we have :
" all any"

It is "translated" in DOM zebra-xsl file as : 
+  <xslo:template mode="index_all" match="text()">
+    <z:index name="Any:w Any:p">
+      <xslo:value-of select="."/>
+    </z:index>
+  </xslo:template>

And I don't find it in DOM koha-xml file.

I don't remember how I did that. It is probably the xslt transformation
stylesheet that added those lines, and maybe it is not good.
More investigation later...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 10 23:19:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 21:19:04 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-XrGRV4Xjyx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |In Discussion

--- Comment #38 from Galen Charlton <gmcharlt at gmail.com> ---
I'm taking a chance on this and have pushed it to master (and the reason why
I'm taking a chance is that I've also written and pushed a regression test that
shows, with the dataset provided by Henri-Damien, that GRS-1 and DOM indexing
are behaving the same).

I'm not sure where Jonathan's 27 hits on "wil" are coming from -- only 11
records in the sample file have that sequence of letters at all.  Are you using
a different dataset?  If so, could you attach the records or a download link to
the bug?

I'm setting to in discussion rather than pushed to master in case it turns out
that I was too precipitous and a revert is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 00:01:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 22:01:13 +0000
Subject: [Koha-bugs] [Bug 5202] Merge authority records
In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5202-70-d4VSH7wT8l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #25 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jared!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 00:50:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 22:50:40 +0000
Subject: [Koha-bugs] [Bug 9282] authorities auto-completion in mainmainentry
In-Reply-To: <bug-9282-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9282-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9282-70-aEcxm6Frt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9282

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 01:12:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 23:12:12 +0000
Subject: [Koha-bugs] [Bug 9295] Introduce operator equal/ notequal to OAI
 set mapping instead of hardcoded 'equal' value
In-Reply-To: <bug-9295-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9295-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9295-70-93S4MS2gHV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9295

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Mirko!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 01:34:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 23:34:30 +0000
Subject: [Koha-bugs] [Bug 10602] Set a default value for authorities
In-Reply-To: <bug-10602-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10602-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10602-70-gSJoR6x9VO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10602

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #16 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 01:39:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 10 Oct 2013 23:39:15 +0000
Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips
In-Reply-To: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10365-70-aXzasnwjmb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Chris!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 03:11:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 01:11:44 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To: <bug-10662-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10662-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10662-70-jnDv7lxo29@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20758|0                           |1
        is obsolete|                            |

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Created attachment 21954
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21954&action=edit
Bug 10662 - Build OAI-PMH Harvesting Client

N.B. This feature is still a work in progress. This commit represents
my work to date on the OAI-PMH harvester, but it's not complete...

N.B. The test is currently broken (as it was created for an older version
of the code).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 04:05:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 02:05:41 +0000
Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and
	IndexedDB
In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10240-70-uqBpg19R8h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #75 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jared!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 05:27:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 03:27:17 +0000
Subject: [Koha-bugs] [Bug 10853] Create CSV profiles with sql fields
In-Reply-To: <bug-10853-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10853-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10853-70-zKP8ZyU6gi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10853

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 05:57:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 03:57:18 +0000
Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial
	claims
In-Reply-To: <bug-10854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10854-70-kKgULVdtQO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #24 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 06:12:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 04:12:56 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-ubq16Rqf69@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #165 from Ketan Kulkarni <ketan at carvingit.com> ---
Created attachment 21955
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21955&action=edit
My opac xslt preferences

Please see my OPAC preferences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 06:28:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 04:28:23 +0000
Subject: [Koha-bugs] [Bug 10689] public note does not appear in
	subscriptions search
In-Reply-To: <bug-10689-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10689-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10689-70-5IpTZxXz6a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10689

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a follow-up that adds a regression test.  Thanks,
Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 07:51:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 05:51:40 +0000
Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted
 according to dateformat system preference
In-Reply-To: <bug-9084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9084-70-h3C185ThZX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
I'm happy to see that someone else has already started work on this one. 

However, I have a few reservations about this patch at the moment.

1) The list of tables.fields for which to format dates:

This list isn't comprehensive (it should probably include all date columns).
Also, being hard-coded, it makes for a bit of a maintenance nightmare, I think.

The overdue_notices.pl and advanced-notices.pl scripts use this regex
"/^date|date$/" to choose columns for which to format dates when using
items.content. I think that this would make sense here too. 

Of course, "items.onloan" wouldn't be included in this, so we might need to use
a hard-coded list, or regex + a shorter hard-coded list.

2) I don't know if we want to strip the time from all of these fields. 

I imagine there might be fields, like duedate, where we might want to include
the time. 

We might not. I'm not 100% on this one. 

--

In any case, if the list were expanded, I would be happy to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 09:20:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 07:20:26 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-C4RKuzbEf8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #39 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
(In reply to Galen Charlton from comment #38)
> I'm taking a chance on this and have pushed it to master (and the reason why
> I'm taking a chance is that I've also written and pushed a regression test

Is it attached to an other bug ?

> that shows, with the dataset provided by Henri-Damien,

I forgot there were a sample of records attached to the bug ;-)

 that GRS-1 and DOM
> indexing are behaving the same).
> 

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 10:17:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 08:17:59 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-BLWsjkk1vu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Galen,
I tested with the dataset provide by Mathieu (mail "pending bugs about UNIMARC
marc flavor": https://www.dropbox.com/s/idw98d7jiy5e5xd/dump_unimarc.zip).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 10:43:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 08:43:00 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-WpR7JVK5kk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #41 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
For info, here is the content of HDL file

=LDR  00166    a2200085   4500
=001  1
=100  \\$a20121025              frey50       
=999  \\$a1
=152  \\$bNP
=200  \\$aMeusburger$bMatthias

=LDR  00143    a2200073   4500
=001  2
=100  \\$a20121025              frey50       
=200  \\$aBela?di$bAlice
=152  \\$bNP

=LDR  00147    a2200073   4500
=001  3
=100  \\$a20121025              frey50       
=210  \\$aMartires del compas
=152  \\$bCO

=LDR  00138    a2200073   4500
=001  4
=100  \\$a20121025              frey50       
=200  \\$aMrak$bMira
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  5
=100  \\$a20121025              frey50       
=200  \\$aWaffler$bEmmanuel
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  6
=100  \\$a20121025              frey50       
=200  \\$aManjarres$bBruno
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  7
=100  \\$a20121025              frey50       
=200  \\$aMartinez$bPepe
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  8
=100  \\$a20121025              frey50       
=200  \\$aNeveu$bPhilippe
=152  \\$bNP

=LDR  00136    a2200073   4500
=001  9
=100  \\$a20121025              frey50       
=210  \\$aZaragraf
=152  \\$bCO

=LDR  00142    a2200073   4500
=001  12
=100  \\$a20121025              frey50       
=200  \\$aKali Live Dub
=152  \\$bNP

=LDR  00133    a2200073   4500
=001  13
=100  \\$a20121025              frey50       
=200  \\$aAvia
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  14
=100  \\$a20121025              frey50       
=200  \\$aFugitive (The)
=152  \\$bNP

=LDR  00137    a2200073   4500
=001  15
=100  \\$a20121025              frey50       
=200  \\$aTh?s?e
=152  \\$bNP

=LDR  00136    a2200073   4500
=001  16
=100  \\$a20121025              frey50       
=210  \\$aZenzile
=152  \\$bCO

=LDR  00150    a2200073   4500
=001  17
=100  \\$a20121025              frey50       
=210  \\$aAir$cDuo instrumental
=152  \\$bCO

=LDR  00138    a2200073   4500
=001  18
=100  \\$a20121025              frey50       
=210  \\$aRoudoudou
=152  \\$bCO

=LDR  00138    a2200073   4500
=001  19
=100  \\$a20121025              frey50       
=210  \\$aSeven Dub
=152  \\$bCO

=LDR  00145    a2200073   4500
=001  20
=100  \\$a20121025              frey50       
=210  \\$aWilliams Traffic
=152  \\$bCO

=LDR  00152    a2200073   4500
=001  21
=100  \\$a20121025              frey50       
=210  \\$a Le  Peuple de l'Herbe 
=152  \\$bCO

=LDR  00142    a2200073   4500
=001  22
=100  \\$a20121025              frey50       
=210  \\$aSporto Kantes
=152  \\$bCO

=LDR  00141    a2200073   4500
=001  23
=100  \\$a20121025              frey50       
=210  \\$aOto Electrik
=152  \\$bCO

=LDR  00142    a2200073   4500
=001  24
=100  \\$a20121025              frey50       
=210  \\$aGotan Project
=152  \\$bCO

=LDR  00136    a2200073   4500
=001  25
=100  \\$a20121025              frey50       
=210  \\$aEz3kiel
=152  \\$bCO

=LDR  00141    a2200073   4500
=001  26
=100  \\$a20121025              frey50       
=210  \\$aBrain Damage
=152  \\$bCO

=LDR  00132    a2200073   4500
=001  27
=100  \\$a20121025              frey50       
=210  \\$aArk
=152  \\$bCO

=LDR  00134    a2200073   4500
=001  28
=100  \\$a20121025              frey50       
=210  \\$aOctet
=152  \\$bCO

=LDR  00137    a2200073   4500
=001  29
=100  \\$a20121025              frey50       
=200  \\$aBeyonc?
=152  \\$bNP

=LDR  00149    a2200073   4500
=001  30
=100  \\$a20121025              frey50       
=200  \\$aWashington$bBrittani
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  31
=100  \\$a20121025              frey50       
=200  \\$aChapa$bMarcie
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  32
=100  \\$a20121025              frey50       
=200  \\$aGlaspie$bNikki
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  33
=100  \\$a20121025              frey50       
=200  \\$aIfrah$bLaurence
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  34
=100  \\$a20121025              frey50       
=200  \\$aCassourra$bAlain
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  35
=100  \\$a20121025              frey50       
=200  \\$aGrimm$bWilhelm
=152  \\$bNP

=LDR  00149    a2200073   4500
=001  36
=100  \\$a20121025              frey50       
=200  \\$aSpirine$bGuennadi K.
=152  \\$bNP

=LDR  00155    a2200073   4500
=001  37
=100  \\$a20121025              frey50       
=200  \\$aTchekhov$bAnton Pavlovitch
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  38
=100  \\$a20121025              frey50       
=200  \\$aLissitsky$bEl
=152  \\$bNP

=LDR  00148    a2200073   4500
=001  39
=100  \\$a20121025              frey50       
=200  \\$aOusatschev$bAndre?
=152  \\$bNP

=LDR  00140    a2200073   4500
=001  40
=100  \\$a20121025              frey50       
=200  \\$aL?$bCheikh
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  41
=100  \\$a20121025              frey50       
=200  \\$aSarr$bThierno
=152  \\$bNP

=LDR  00138    a2200073   4500
=001  42
=100  \\$a20121025              frey50       
=200  \\$aSow$bOmar
=152  \\$bNP

=LDR  00140    a2200073   4500
=001  43
=100  \\$a20121025              frey50       
=200  \\$aAllen$bTony
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  44
=100  \\$a20121025              frey50       
=200  \\$aEllis$bPee Wee
=152  \\$bNP

=LDR  00149    a2200073   4500
=001  45
=100  \\$a20121025              frey50       
=200  \\$aTall$bCheikh Tidiane
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  46
=100  \\$a20121025              frey50       
=200  \\$aShin$bSe-jung
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  47
=100  \\$a20121025              frey50       
=200  \\$aZanasi$bGianni
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  48
=100  \\$a20121025              frey50       
=200  \\$aMurino$bCaterina
=152  \\$bNP

=LDR  00148    a2200073   4500
=001  49
=100  \\$a20121025              frey50       
=200  \\$aMastandrea$bValerio
=152  \\$bNP

=LDR  00148    a2200073   4500
=001  50
=100  \\$a20121025              frey50       
=200  \\$aBattiston$bGiuseppe
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  51
=100  \\$a20121025              frey50       
=200  \\$aRobillot$bHenri
=152  \\$bNP

=LDR  00150    a2200073   4500
=001  52
=100  \\$a20121025              frey50       
=200  \\$aSan Millan$bFran?ois
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  53
=100  \\$a20121025              frey50       
=200  \\$aLecaye$bEmmanuel
=152  \\$bNP

=LDR  00148    a2200073   4500
=001  54
=152  \\$bSNC
=100  \\$a20121025              frey50       
=250  \\$aMusique$yS?n?gal

=LDR  00143    a2200073   4500
=001  55
=100  \\$a20121025              frey50       
=200  \\$aScherfig$bLone
=152  \\$bNP

=LDR  00141    a2200073   4500
=001  56
=100  \\$a20121025              frey50       
=200  \\$aHornby$bNick
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  57
=100  \\$a20121025              frey50       
=200  \\$aEnglishby$bPaul
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  58
=100  \\$a20121025              frey50       
=200  \\$aSarsgaard$bPeter
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  59
=100  \\$a20121025              frey50       
=200  \\$aMulligan$bCarey
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  60
=100  \\$a20121025              frey50       
=200  \\$aMolina$bAlfred
=152  \\$bNP

=LDR  00174    a2200073   4500
=001  61
=100  \\$a20121025              frey50       
=250  \\$aExtraterrestres$xC?d?roms pour la jeunesse
=152  \\$bSNC

=LDR  00173    a2200073   4500
=001  62
=100  \\$a20121025              frey50       
=250  \\$aChauves-souris$xC?d?roms pour la jeunesse
=152  \\$bSNC

=LDR  00165    a2200073   4500
=001  63
=100  \\$a20121025              frey50       
=250  \\$aBourse$xC?d?roms pour la jeunesse
=152  \\$bSNC

=LDR  00165    a2200073   4500
=001  64
=100  \\$a20121025              frey50       
=250  \\$aF?tes$xC?d?roms pour la jeunesse
=152  \\$bSNC

=LDR  00166    a2200073   4500
=001  65
=100  \\$a20121025              frey50       
=250  \\$aAutomne$xC?d?roms pour la jeunesse
=152  \\$bSNC

=LDR  00151    a2200073   4500
=001  66
=152  \\$bSNC
=100  \\$a20121025              frey50       
=250  \\$aMusique$yBurkina Faso

=LDR  00143    a2200073   4500
=001  67
=100  \\$a20121025              frey50       
=200  \\$aD?m?$bVictor
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  68
=100  \\$a20121025              frey50       
=200  \\$aDiabat?$bIssouf
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  69
=100  \\$a20121025              frey50       
=200  \\$aDiarra$bSalif
=152  \\$bNP

=LDR  00140    a2200073   4500
=001  70
=100  \\$a20121025              frey50       
=200  \\$aDiarra$bAli
=152  \\$bNP

=LDR  00138    a2200073   4500
=001  71
=100  \\$a20121025              frey50       
=200  \\$aKoud?d?
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  72
=100  \\$a20121025              frey50       
=200  \\$aAnderson$bLaurie
=152  \\$bNP

=LDR  00138    a2200073   4500
=001  73
=100  \\$a20121025              frey50       
=200  \\$aReed$bLou
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  74
=100  \\$a20121025              frey50       
=200  \\$aScherer$bPeter
=152  \\$bNP

=LDR  00140    a2200073   4500
=001  75
=100  \\$a20121025              frey50       
=200  \\$aBurger$bRob
=152  \\$bNP

=LDR  00140    a2200073   4500
=001  76
=100  \\$a20121025              frey50       
=200  \\$aHakim$bOmar
=152  \\$bNP

=LDR  00139    a2200073   4500
=001  77
=100  \\$a20121025              frey50       
=200  \\$aZorn$bJohn
=152  \\$bNP

=LDR  00135    a2200073   4500
=001  78
=100  \\$a20121025              frey50       
=200  \\$aAntony
=152  \\$bNP

=LDR  00160    a2200073   4500
=001  79
=100  \\$a20121025              frey50       
=250  \\$aJeux de simulation$xC?d?roms
=152  \\$bSNC

=LDR  00168    a2200073   4500
=001  80
=100  \\$a20121025              frey50       
=250  \\$aGuerre mondiale (1939-1945)$xLudiciels
=152  \\$bSNC

=LDR  00142    a2200073   4500
=001  81
=100  \\$a20121025              frey50       
=200  \\$aAim?e$bAnouk
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  82
=100  \\$a20121025              frey50       
=200  \\$aPiccoli$bMichel
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  83
=100  \\$a20121025              frey50       
=200  \\$aPlacido$bMichele
=152  \\$bNP

=LDR  00142    a2200073   4500
=001  84
=100  \\$a20121025              frey50       
=200  \\$aMiller$bSteve
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  85
=100  \\$a20121025              frey50       
=200  \\$aBuffalo$bNorton
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  86
=100  \\$a20121025              frey50       
=200  \\$aCharles$bSonny
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  87
=100  \\$a20121025              frey50       
=200  \\$aKnudtson$bGordy
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  88
=100  \\$a20121025              frey50       
=200  \\$aPeterson$bBilly
=152  \\$bNP

=LDR  00144    a2200073   4500
=001  89
=100  \\$a20121025              frey50       
=200  \\$aClaerr$bThierry
=152  \\$bNP

=LDR  00146    a2200073   4500
=001  90
=100  \\$a20121025              frey50       
=200  \\$aWesteel$bIsabelle
=152  \\$bNP

=LDR  00148    a2200073   4500
=001  91
=100  \\$a20121025              frey50       
=200  \\$aSauvage$bChristiane
=152  \\$bNP

=LDR  00171    a2200073   4500
=001  92
=100  \\$a20121025              frey50       
=210  \\$aAssociation des biblioth?caires fran?ais
=152  \\$bCO

=LDR  00143    a2200073   4500
=001  93
=100  \\$a20121025              frey50       
=200  \\$aMundy$bAnthony
=152  \\$bNP

=LDR  00150    a2200073   4500
=001  94
=100  \\$a20121025              frey50       
=200  \\$aMuldrow$bGeorgia Anne
=152  \\$bNP

=LDR  00174    a2200073   4500
=001  95
=152  \\$bSNC
=100  \\$a20121025              frey50       
=250  \\$aMusique$yCongo (R?publique D?mocratique)  

=LDR  00141    a2200073   4500
=001  96
=100  \\$a20121025              frey50       
=200  \\$aNsangue$bGuy
=152  \\$bNP

=LDR  00139    a2200073   4500
=001  97
=100  \\$a20121025              frey50       
=200  \\$aTran$bAlex
=152  \\$bNP

=LDR  00141    a2200073   4500
=001  98
=100  \\$a20121025              frey50       
=200  \\$aIpupa$bFally
=152  \\$bNP

=LDR  00145    a2200073   4500
=001  99
=100  \\$a20121025              frey50       
=200  \\$aGalison$bWilliam
=152  \\$bNP

=LDR  00143    a2200073   4500
=001  100
=100  \\$a20121025              frey50       
=200  \\$aClerc$bArnaud
=152  \\$bNP

=LDR  00138    a2200073   4500
=001  101
=100  \\$a20121025              frey50       
=200  \\$aWiretree
=152  \\$bNP

=LDR  00147    a2200073   4500
=001  102
=100  \\$a20121025              frey50       
=200  \\$aBlanchard$bDaniel
=152  \\$bNP



Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 10:44:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 08:44:18 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-T0t4M0BedY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #42 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
oups, maybe it is was not a good idea to copy all the records. too long...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 10:47:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 08:47:13 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-BrjfGynrBG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #43 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I think if we want a set of records for testing, we should take only a small
file with 10 records from the "real word".
With a small set, if there is a oddity in results it would be easier to find
why.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 11:22:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 09:22:39 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-JCtqK7UY5n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #44 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Here is a set of 11 auth record from my catalog. unicode encoding.
Diffent types of auths, rejected forms etc.

I join 2 file : marc raw file, and marc file "translated" to plain text, to
make verifications easier.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 11:23:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 09:23:15 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-zWmoSbNZMe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #45 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21956&action=edit
MSAby - 11 auth records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 11:23:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 09:23:50 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-1dzVc0NTrg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #46 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21957
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21957&action=edit
MSAby - 11 auth records (plain text)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 11:29:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 09:29:03 +0000
Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm
In-Reply-To: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11032-70-TLhotMOYY2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 21958
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21958&action=edit
Proposed Patch

As these cases do not need to access db have added a Biblio.t which test error
returns and logs messages to stderr, to run
prove t/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 11:29:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 09:29:04 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-J6pEz5mcov@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |koha.aixmarseille at gmail.com

--- Comment #23 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
I follow the Test Plan, it's Ok. 

But the librarian can't override, it should be better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 11:58:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 09:58:08 +0000
Subject: [Koha-bugs] [Bug 11037] New: C4::Biblio exports non-existent
	subroutines
Message-ID: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

            Bug ID: 11037
           Summary: C4::Biblio exports non-existent subroutines
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

C4/Biblio.pm exports two subroutine names Get and TransformHtmlToMarc2 which do
not correspond to actual subroutines. They should be removed from @EXPORT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:06:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:06:46 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-KVVfwEd2aN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 21959
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21959&action=edit
Proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:18:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:18:08 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-h2TS7fl9JZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |koha.aixmarseille at gmail.com

--- Comment #5 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
This patch adds the "not available" or "missing" at the missing list. He adds
the "received" at the received list. It works even when I change status.
The missing list and the received list are OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:18:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:18:14 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-L8sb9t8WeM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:18:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:18:31 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-Ce489lh3Fp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17576|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:18:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:18:43 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-WgCdrj5RD7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

--- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21960
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21960&action=edit
Bug 10092: Small improvements on serial missinglist and receivedlist

Builds upon report 8896 with changes for missinglist.
Similar changes for receivedlist to be consistent.

Test plan:
Go to serial collection information.
Edit serials.
Toggle the status through all possible values.
On another tab or in the db, check missinglist and receivedlist (subscription
detail tab Summary).

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:18:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:18:36 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-2si5eviFEM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17580|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:18:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:18:46 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-LUTsspMRFQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

--- Comment #8 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21961
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21961&action=edit
Bug 10092 Followup for NewIssue

Same logic for new issue.
Moves the shared code to a local subroutine.

Test plan:
Add an issue via Generate Next button. No changes to missing and received.
Now add an issue via Edit Serials and Supplemental issue with status Arrived.
Check the received list.
Now add supplemental issue with status Missing or Not available.
Check the missing list.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 12:46:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 10:46:06 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-Ehl05g5Bp2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #19 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #18)
> Fridolyn, see comment 14 - I need instructions on how to correctly catalog a
> UNIMARC authority with the required fields to reproduce this problem.
Don't you have existing authorities ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 13:02:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 11:02:13 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-FDBiytlTf6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 13:02:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 11:02:25 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-fHDRncQAG2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21943|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 13:02:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 11:02:30 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-Yetqzup4F1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21962
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21962&action=edit
Bug 11033 Make Save button and Cancel link always visible on basketgroup page

This patch suppress the first CSS declaration in basketgroup.tt. It was
unneeded, and was the cause of the Save button and Cancel link not being
visible if the bar for changing language was activated.

To test :
1. activate the "language" syspref, with at least 2 languages
2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at
the bottom of basketgroup page
3. Check you can use the basketgroup as before : put a basket in it, cancel,
save etc.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 13:52:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 11:52:44 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-E08xkKbvqT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tredok.pierre at gmail.com

--- Comment #21 from Pierre Angot <tredok.pierre at gmail.com> ---
There is a problem on sandbox : 

Some problems occurred applying patches from bug 10758:
<h1>Something went wrong !</h1>Applying: Bug 10758 - Show bibliographic
information of deleted records in acquisitions
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 10758 - Show bibliographic information of deleted
records in acquisitions
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 10758 - Show bibliographic information of deleted records in acquisitions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 13:55:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 11:55:43 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-AW9t7to33X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Depends on:     10869
You cannot test on sandbox

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 13:58:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 11:58:36 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-OfuC6DI9Ux@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
By the way, if Jonathan or Katrin could drop an eye on my code before somebody
try to sign it off, I would appreciate (especially the queries changed in
C4/Acquisitions)
If somebody sign it off and if QA tell me I need to rewrite it on a different
base it afterwards, the tester would have work for nothing ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:01:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:01:26 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-lhYccBbl9Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
I wrote the following test and ran it before and after the patch. As expected,
the routines were exported before (notice the text is &C4::Biblio), but they
were undefined. After the patch, they are no longer in C4::Biblio (notice the
text is now &main::), and are still undefined.

mtompset at ubuntu:~/kohaclone$ cat ~/test_missing.t
#!/usr/bin/perl

use Modern::Perl;
use Test::More tests => 3;
use Try::Tiny;

BEGIN {
    use_ok('C4::Biblio');
}

my $check1 = try { Get(); }
             catch { "$_"; }
             finally { "ok"; };
print "CHECK: $check1\n";
ok( $check1 =~ /Undefined/ , "Get() is undefined." );
my $check2 = try { TransformHtmlToMarc2(); }
             catch { "$_"; }
             finally { "ok"; };
print "CHECK: $check2\n";
ok( $check2 =~ /Undefined/ , "TransformHtmlToMarc2() is undefined." );
mtompset at ubuntu:~/kohaclone$ prove -v ~/test_missing.t
/home/mtompset/test_missing.t ..
1..3
ok 1 - use C4::Biblio;
CHECK: Undefined subroutine &C4::Biblio::Get called at
/home/mtompset/test_missing.t line 11.
ok 2 - Get() is undefined.
CHECK: Undefined subroutine &C4::Biblio::TransformHtmlToMarc2 called at
/home/mtompset/test_missing.t line 16.
ok 3 - TransformHtmlToMarc2() is undefined.
ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.22 cusr  0.00
csys =  0.23 CPU)
Result: PASS
mtompset at ubuntu:~/kohaclone$ git bz apply 11037
Bug 11037 - C4::Biblio exports non-existent subroutines

21959 - Proposed patch

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11037 Remove non-existent subs from Biblio's @EXPORT
mtompset at ubuntu:~/kohaclone$ prove -v ~/test_missing.t
/home/mtompset/test_missing.t ..
1..3
ok 1 - use C4::Biblio;
CHECK: Undefined subroutine &main::Get called at /home/mtompset/test_missing.t
line 11.
ok 2 - Get() is undefined.
CHECK: Undefined subroutine &main::TransformHtmlToMarc2 called at
/home/mtompset/test_missing.t line 16.
ok 3 - TransformHtmlToMarc2() is undefined.
ok
All tests successful.
Files=1, Tests=3,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.21 cusr  0.00
csys =  0.22 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:02:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:02:35 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-z58hH1ikvo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 21963
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21963&action=edit
[SIGNED OFF] Bug 11037 Remove non-existent subs from Biblio's @EXPORT

No code implements the subs Get and TransformHtmlToMarc2
so dont export them into users' namespace

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:03:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:03:37 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-5ZkfntTdxK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21959|0                           |1
        is obsolete|                            |

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 21959
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21959
Proposed patch

Obsoleting non-signed off version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:06:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:06:36 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-uKWpBPL9hi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
I also tried doing greps to see if they were defined anywhere else in the code.
There were no such routines anywhere.

$ grep TransformHtmlToMarc2 `find .`
$ grep "sub Get" `find .` | less

Lots of GetBlah's, but nothing that was just "sub Get".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:08:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:08:43 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-bVShUrVbql@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mathieu,

I don't have a lot of time until after KohaCon probably - but it would really
help this along if you can provide unit tests for the changed routines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:23:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:23:05 +0000
Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm
In-Reply-To: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11032-70-QCvJHuiNa9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I'm happy to see that you're trying to address this problem. Can you please add
a test plan to your commit message?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:46:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:46:24 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-ZF2k57wAwO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> ---
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:48:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:48:59 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-bCner7l7vN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |eric.begin at inLibro.com,
                   |                            |philippe.blouin at inlibro.com
           Assignee|koha-bugs at lists.koha-commun |eric.begin at inLibro.com
                   |ity.org                     |

--- Comment #2 from Eric B?gin <eric.begin at inLibro.com> ---
We do have a simple feature allowing part of this.

We added a SendAllEmailsToLibrarian. We will change this for allowing to
SendAllEmailTo in order to specify any email address.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:50:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:50:32 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-xWucFpKdhG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:50:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:50:32 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-h4mjVOquax@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com
           Assignee|eric.begin at inLibro.com      |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 14:51:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 12:51:41 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-SRqLAvaGtf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|eric.begin at inLibro.com      |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:13:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:13:36 +0000
Subject: [Koha-bugs] [Bug 9416] We should have 2 kinds of notes for each
	order line
In-Reply-To: <bug-9416-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9416-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9416-70-F1vcsRvRG0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21293|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21964&action=edit
Bug 9416: Add a new note for vendor in each order

This patch adds a new note made for vendor in each order. The existing note is
renamed "internal note".
The behavior of the 2 notes are the same
An other patch will display this vendor note in pdf printed basketgroups.

To test :
Make a complete acquisiton process (creating the order > looking at the basket
> looking the order > receiving)
and try to use the 2 notes (internal note / vendor note)
check the changes made on one page (eg detail of the order) are well saved and
visible on an other page (eg receipt page)

Note : display of existing acq note is broken on receipt page. It must be fixed
in an other bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:16:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:16:00 +0000
Subject: [Koha-bugs] [Bug 11038] New: Custom CSS for Staff Login like
	OPAC/StaffIntranet
Message-ID: <bug-11038-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038

            Bug ID: 11038
           Summary: Custom CSS for Staff Login like OPAC/StaffIntranet
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: ssammons at npelem.com
        QA Contact: testopia at bugs.koha-community.org

Performing a simple color change to staff login screen, required file system
access to create a new CSS file. As documented @
http://www.myacpl.org/koha/?p=612 , you must do that OR use the javascript
hack.

I am suggesting there be a simple way to add custom CSS without the need for
file system access. You can use a text box with OPACUserCSS, can a that just be
duplicated?

As stated in bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7424
a custom store for custom-css is great, perhaps we could look at having an
"upload file" buttom, or a simple file editor like WordPress uses for its theme
editor, so you have file write access without being in the file system for said
custom-css files?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:18:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:18:11 +0000
Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority
	searches
In-Reply-To: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10829-70-1o0eNvrgkU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:18:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:18:23 +0000
Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority
	searches
In-Reply-To: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10829-70-tPgkV9zxET@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20803|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:18:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:18:28 +0000
Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority
	searches
In-Reply-To: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10829-70-FjlSYhC3g2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21965&action=edit
Bug 10829 - Browse across pages breaks for authority searches

Test plan
1. Do an authority search in the OPAC (A search for 'an:49' perhaps..
that should bring up results for authority number 49, hopefully there
are multiple pages of results, if not try again and find one that
gives you multiple pages of results)
2. Click the final result on any page of results (there must be more
results to follow for this to work)
3. Try clicking the 'Next' button in the 'Browse results' pane on
the right of the page.
4. It should take you to the next result in the search list (i.e
the first result from the next page of results) - Double check it is
correct, we found that it was often not.

5. Apply patch and run same process, this time you should get the
correct paging.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:32:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:32:52 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-jtYaWhkxje@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #18 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
zut

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:34:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:34:44 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-kk7YZrLorj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Jonathan, I don't understand, I don't have any problem : 

$git bz apply 7791
Bug 7791 - Deleting basket should not delete all existing orders without
warning

Bug 7791 : Give the ability to delete records when deleting a basket
Apply? [yn] y

Applying: Bug 7791 : Give the ability to delete records when deleting a basket
Bug 7791 Followup: delete warns, add missing curly braket and make a simpler
message if basket is void
Apply? [yn] y

Applying: Bug 7791 Followup: delete warns, add missing curly braket and make a
simpler message if basket is void
[PATCH 3] Bug 7791 Followup: add warning after deletion if some records were
not deleted
Apply? [yn] y

Applying: Bug 7791 Followup: add warning after deletion if some records were
not deleted


Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:40:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:40:13 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-nHytVFuVTE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:40:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:40:28 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-2RM1tDE17j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21646|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:40:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:40:33 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-q0b0EcVGWt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21647|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:40:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:40:39 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-vw2A3tzsOi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #9 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21966
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21966&action=edit
Bug 10858: Browse selected biblios

After launching a search, some people would like to browse some results
from several pages.

This patch adds, at the OPAC, a link "Browse selected biblios >>" when
at least one biblio is checked. You can choose biblios from several
page, not the current one. In this way, checkboxes already checked
become again checked when you come back on this results page.
After clicking the link, the "Browse results" block is filled with
selected biblios, not (like as the current behavior) with the classic
results.

Test plan:
- Launch a search at the OPAC
- Check some biblios
- Go on another page
- Check some biblios
- Come back to the first page and check that already checked biblio is
  automatically checked.
- Click on the "Browse selected biblios >>" link
- Check that you are able to browse results you had checked.

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:40:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:40:43 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-LZRyD2Szvp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

--- Comment #10 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21967
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21967&action=edit
Bug 10858 [Follow-up] Browse selected biblios

This follow-up adds the browse functionality to the CCSR theme and
adds some CSS for the "browse" link, including a new image in the image
sprite.

To test, apply the patch, clear your cache, and test the browsing
functionality again. Confirm that the browse link looks good and works
correctly in both the prog and CCSR themes.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:43:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:43:04 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-NTp1LE45it@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.aixmarseille at gmail.com

--- Comment #11 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
Potential development : to have a list of results after the click on the
"Browse selected biblios"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:45:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:45:55 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-T21xlrDKEO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Tested again, I cannot apply your patch, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 15:57:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 13:57:46 +0000
Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as
 Amazon, Google and add fail over i.e. if first source fails, go to next
In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7187-70-JTENL1XwKI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187

Sebastian Hierl <s.hierl at aarome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4
                 CC|                            |s.hierl at aarome.org

--- Comment #24 from Sebastian Hierl <s.hierl at aarome.org> ---
(In reply to Cab Vinton from comment #23)
As VuFind has been mentioned above, I thought I'd confirm that VuFind separates
its book covers functionality from the book previews API -- and that it can
search the various sources (Google Books, Amazon, Open Library, and Hathi
Trust) by ISBNS, LCCNs, and OCLC numbers:

https://github.com/vufind-org/vufind/blob/master/themes/bootstrap/js/preview.js

Thus, not only the most recent publications that have ISBNs are
retrieved/linked to in the OPAC, but also those that have OCLC and LCCN #s,
thus numerous titles that are available in full text--which is the point of
such a feature, i.e. to link to the full text for immediate access.



> (In reply to comment #22)
> > The question is not whether you can retrieve a record on Amazon with a UPC,
> > but whether the Amazon cover image service works with UPC. It does not.
> 
> Hmmm... No doubt you're correct, Owen. Amazon's Product Advertising API
> seems to allow the use of a number of different identifiers, including ASINs:
> 
> http://docs.amazonwebservices.com/AWSECommerceService/latest/DG/ItemLookup.
> html
> 
> Presumably Koha is using a different service.
> 
> Note that the LibGuides folks have added a separate option for users to
> specify a URL source for cover art for each record ...
> 
> http://guidefaq.com/a.php?qid=2200

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:05:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:05:47 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-ca8kRwfrCf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #21 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
strange
Do you know what attachment is causing the problem?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:14:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:14:04 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-n1K02skjOl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #21)
The last one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:30:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:30:51 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-6S57XaCahH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #96 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21968
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21968&action=edit
Bug 7684: Argument missing

The cgi argument in missing for routine
C4::Reports::Guided::_get_column_defs. It causes a crash on generating
the CSV file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:32:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:32:46 +0000
Subject: [Koha-bugs] [Bug 7567] News by Library
In-Reply-To: <bug-7567-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7567-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7567-70-ADpDDE2f86@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com
           Assignee|ebin.joseph at osslabs.biz     |mtompset at hotmail.com

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Since I recently heard that osslabs.biz is no longer in business, I am taking
this bug. Though, I am probably going to take it a slightly different
direction.

The tools->news will have branch fields added. This would allow for every
branch to create a news item for their library hours or other specific news,
which will be then become visible once a user logs in. Anonymous users will not
be able to see branch specific news.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:35:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:35:55 +0000
Subject: [Koha-bugs] [Bug 10820] Lost items on search results don't jive
 with record details
In-Reply-To: <bug-10820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10820-70-OMk4XJEoAl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10820

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:37:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:37:12 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-aqgSNSF4ip@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21684|0                           |1
        is obsolete|                            |

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21969
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21969&action=edit
[PATCH 3/3] Bug 7791 Followup: add warning after deletion if some records were
not deleted

I applied it, and regenerate a patch with format pach.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:37:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:37:23 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-ckOcgit48j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:45:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:45:46 +0000
Subject: [Koha-bugs] [Bug 11039] New: SIP Server responds to valid CHECKIN
 to SC but fails to checkin item on Koha
Message-ID: <bug-11039-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039

            Bug ID: 11039
           Summary: SIP Server responds to valid CHECKIN to SC but fails
                    to checkin item on Koha
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: barry at oslo.ie
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

If a patron borrowers an item from Branch_A and attempts to return it in
Branch_B, via a selfcheck system, the SIP server will respond with an valid
CHECKIN response giving the impression the item has been checked in
successfully. However, when the borrower record is viewed via the Staff client
the patron still has the item checked out. This only appears to happen if the
SysPref "AllowReturnToBranch" is set to "only the library the item is from".
Switching this SysPref to "to any library" does apply the checkin. 

The same item - checked out in Branch_A and checked in at Branch_B - does flag
an error on the staff client, dissallowing the checkin. This is not passed
correctly to the SIP server.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:46:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:46:39 +0000
Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to
 SC but fails to checkin item on Koha
In-Reply-To: <bug-11039-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11039-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11039-70-eMQf28gpNI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039

Barry Cannon <barry at oslo.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|SIP Server responds to      |SIP Server responds with
                   |valid CHECKIN to SC but     |valid CHECKIN to SC but
                   |fails to checkin item on    |fails to checkin item on
                   |Koha                        |Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:52:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:52:55 +0000
Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
 control whether patron links go to circ or patron details
In-Reply-To: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7680-70-asTO3G40NH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

--- Comment #10 from marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> ---
Hi,
anyone know where is the discussion of this system preference?

Thanks
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 16:53:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 14:53:20 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-Dh09efR5yo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #47 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to mathieu saby from comment #39)
> Hi
> (In reply to Galen Charlton from comment #38)
> > I'm taking a chance on this and have pushed it to master (and the reason why
> > I'm taking a chance is that I've also written and pushed a regression test
> 
> Is it attached to an other bug ?

No -- see the following commit:

http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=521e599dd82061fd10321d681d06d1409134d39c

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:06:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:06:13 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-aGq8yIq4GN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #97 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:06:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:06:45 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-MJoRXsROoR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21331|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:06:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:06:52 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-6bln0u22Nc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21441|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:06:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:06:58 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-oknzfU7wYI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21968|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:07:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:07:08 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-ygpnJIzNDU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #98 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21970
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21970&action=edit
Bug 7684: multiple fixes for inventory

* when a file was uploaded and the comparison with catalogue range
 requested, the comparison was wrong: the logic was wrong
* items that were not supposed to be scanned (ie: supposed to be on another
shelf)
  didn't had the author and title, it was hard to retrieve them on the shelved
* some useful fields were missing, like homebranch, location, status
* the CSV export contained all the item information. It should contain the same
   informations as the screen

Behaviour now:
   * scan a list of barcode & select a range of location
   * if a barcode has been scanned and should not be (mis placed item), the
information is displayed
   * if you choose "compare barcodes list to result option", the resulting list
contains all items that have been scanned and those that were supposed to be.
Any item not in both list appears with a specific message on the last column

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:07:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:07:13 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-7bOVJewAQR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #99 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21971
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21971&action=edit
Bug 7684: QA Followup and bugfixes

This followup fixes some QA issues:
- replace the MySQLism SQL_CALC_FOUND_ROWS
- use Koha::DateUtils instead of C4::Dates
- replace "branch" and "location" with "library"
- fixe wrong capitalisation on "Clear all" and "Select all"

and fixes some behaviors:
- the inventory tools can be used without barcode file (fixed for the
  csv export too).
- mark as not scanned a non scanned item.
- update the datelastseen 1 time per biblio (and fixes the displayed
  count)

Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr>

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:07:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:07:17 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-03HZiPhFTz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #100 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 21972
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21972&action=edit
Bug 7684: Argument missing

The cgi argument in missing for routine
C4::Reports::Guided::_get_column_defs. It causes a crash on generating
the CSV file.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:11:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:11:18 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-DM8Wz9GfVV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #101 from Koha Team AMU <koha.aixmarseille at gmail.com> ---
Just a problem fixed : the csv was ko.

It's really better now! Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:16:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:16:38 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-7DZxk4Cxe9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #48 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jonathan Druart from comment #40)
> Galen,
> I tested with the dataset provide by Mathieu (mail "pending bugs about
> UNIMARC marc flavor":
> https://www.dropbox.com/s/idw98d7jiy5e5xd/dump_unimarc.zip).

Thanks.  I took this file and adapted the test cases I wrote yesterday.  Here
are the results I got:

[1] main heading contains "wil"

GRS-1 = 27 hits
DOM   = 27 hits

[2] all headings contains "wil"

GRS-1 = 27 hits
DOM   = 27 hits

[3] keyword contains "wil"

GRS-1 = 27 hits
DOM   = 29 hits

The following indicates that the DOM filter is not necessarily wrong:

$ perl -ne 'BEGIN { $/ = "\035"; } END { print "$ct\n" } { $ct++ if /wil/i; }'
< unimarc_auth_3.mrc 
29

IOW, there really are 29 records that contain the substring "wil".

I'll investigate further to see why the GRS-1 any index is behaving slightly
differently.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:17:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:17:45 +0000
Subject: [Koha-bugs] [Bug 11038] Enable use of IntranetUserCSS and
 intranetcolorstylesheet on staff client login page
In-Reply-To: <bug-11038-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11038-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11038-70-P1GatsHV1l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11038

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
          Component|Architecture, internals,    |Templates
                   |and plumbing                |
            Version|unspecified                 |master
           Assignee|gmcharlt at gmail.com          |oleonard at myacpl.org
            Summary|Custom CSS for Staff Login  |Enable use of
                   |like OPAC/StaffIntranet     |IntranetUserCSS and
                   |                            |intranetcolorstylesheet on
                   |                            |staff client login page
           Severity|enhancement                 |normal

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
The staff client login page does not load CSS stored in the IntranetUserCSS
system preference. While it does load intranetcolorstylesheet, it loads the
file before it loads login.css, so any styles you add specific to the login
page will be overridden by login.css.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:19:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:19:30 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-MdWoVbvHnA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #49 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to Galen Charlton from comment #48)
> I'll investigate further to see why the GRS-1 any index is behaving slightly
> differently.

Because GRS-1's "any" directive does not include all fields, whereas the DOM
"equivalent" does.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:25:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:25:17 +0000
Subject: [Koha-bugs] [Bug 11040] New: Add option to print regular slip to
 CircAutoPrintQuickSlip
Message-ID: <bug-11040-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040

            Bug ID: 11040
           Summary: Add option to print regular slip to
                    CircAutoPrintQuickSlip
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: p.thrasher at dover.nh.gov
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently the CircAutoPrintQuickSlip has two options:

When an empty barcode field is submitted in circulation
either
open a print quick slip window
OR
clear the screen.

Can a third option be added to open a regular slip window?  Our patrons want to
see it all, and we'd love to make it easier to print.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:28:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:28:57 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-e2lxoH4CHu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #50 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jared Camins-Esakov from comment #49)
> (In reply to Galen Charlton from comment #48)
> > I'll investigate further to see why the GRS-1 any index is behaving slightly
> > differently.
> 
> Because GRS-1's "any" directive does not include all fields, whereas the DOM
> "equivalent" does.

all fields? you mean really ALL fields even if they are not used by an other
index? That must very annoying for users!
I made a patch some time ago for repacing "any" with "anywhere" and make a
reasonable "any" index, like we can found in other ILS. I made it for GRS1, but
it may be even more usefull for DOM.
Bug 8962 (need some rewrite I suppose)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:31:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:31:05 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-D0BkUz2P4e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure if it's annoying - I always tell people that everything that is
indexed can be searched in keyword search and the reactions so far are quite
positive.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:37:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:37:48 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-4hrZvFPMSG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #52 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to mathieu saby from comment #50)
> (In reply to Jared Camins-Esakov from comment #49)
> > (In reply to Galen Charlton from comment #48)
> > > I'll investigate further to see why the GRS-1 any index is behaving slightly
> > > differently.
> > 
> > Because GRS-1's "any" directive does not include all fields, whereas the DOM
> > "equivalent" does.
> 
> all fields? you mean really ALL fields even if they are not used by an other
> index? That must very annoying for users!
> I made a patch some time ago for repacing "any" with "anywhere" and make a
> reasonable "any" index, like we can found in other ILS. I made it for GRS1,
> but it may be even more usefull for DOM.
> Bug 8962 (need some rewrite I suppose)

Yeah, ideally there would be a special keyword index for DOM that included all
the normal keyword-ish fields and note fields, but for me a higher priority was
getting keyword working at all.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:44:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:44:16 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-DgASYPZB2f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #53 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jared Camins-Esakov from comment #49)
> (In reply to Galen Charlton from comment #48)
> > I'll investigate further to see why the GRS-1 any index is behaving slightly
> > differently.
> 
> Because GRS-1's "any" directive does not include all fields, whereas the DOM
> "equivalent" does.

The "all" directive, in particular, just specifies one or more attributes that
are tacked on to the attribute list for each element being indexed.

The two "wil" records that DOM includes in the "any" index have the "William"
string in the 810 field.  Since the UNIMARC GRS-1 record.abs does not index the
810 at all, it is likewise not included in the "any" index.  By contrast, the
DOM XSL index_all option indexes all text strings present in the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 17:48:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 15:48:30 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-g3WiRA6zeH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #54 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Katrin Fischer from comment #51)
> I am not sure if it's annoying - I always tell people that everything that
> is indexed can be searched in keyword search and the reactions so far are
> quite positive.

I agree -- it's easier to explain that an "any" index includes everything
(though whether or not fixed fields should be included is a matter of opinion),
so I for one don't really see a problem with the change in behavior of the
"any" index.

Note, though, that that's a separate question from whether the "any" index
should be included in, say, auth_finder.pl, as somebody looking for authority
records via that interface has little reason to be using anything other than
the headings searches to begin with.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 18:00:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 16:00:08 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-i7KaKQQjLh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, I think fixing that in the commit message when doing QA would be
ok - I also tend to fix typos where I spot them :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 18:43:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 16:43:03 +0000
Subject: [Koha-bugs] [Bug 11041] New: Hi, I am new and I have a question,
 you may help me!
Message-ID: <bug-11041-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11041

            Bug ID: 11041
           Summary: Hi, I am new and I have a question, you may help me!
 Change sponsored?: ---
           Product: Koha
           Version: 3.8
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: hasanelias at yahoo.com
        QA Contact: testopia at bugs.koha-community.org

I have access only at a "administration level" I can access to all Koha
functions:
Circulation, Patrons, Koha Administration, Tools, etc.

And I want to delete all these branches:
Midway
Springfield
Franklin
Pleasant Valley
Union

Also, I want to delete "Koha admin" patron

My question is: CAn I do this without compromise the database, or any
functionallity of Koha?

Thanks in advance.

Hasan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 18:50:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 16:50:11 +0000
Subject: [Koha-bugs] [Bug 11041] Hi, I am new and I have a question,
	you may help me!
In-Reply-To: <bug-11041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11041-70-245a1qot85@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11041

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Bug reports are not an appropriate way to get support for Koha. You could try
the Koha manual (http://koha-community.org/documentation/), Koha mailing lists
(http://koha-community.org/support/koha-mailing-lists/), Koha IRC
(http://koha-community.org/get-involved/irc/), or a support company
(http://koha-community.org/support/paid-support/).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 18:59:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 16:59:10 +0000
Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its
	own id
In-Reply-To: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10850-70-BWnCuaaqrL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 18:59:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 16:59:15 +0000
Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its
	own id
In-Reply-To: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10850-70-cPiGWRO8xN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21852|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21973
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21973&action=edit
Bug 10850 - Give Quick spine label template page its own id

Out of three conditional cases for display of the <body> tag one lacked
a unique ID. This patch copies the unique ID from the other cases to the
one lacking.

This patch also corrects the case of an "onload" attribute which should
follow XHTML style rules.

To test, the patch for Bug 9618 must be applied. Set the
SpineLabelAutoPrint system preference to "[don't] automatically pop up a
print dialog." Submit a barcode on the quick spine label creator and
view source. The <body> tag should have an ID attribute.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 19:41:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 17:41:30 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-eRo1ya1EOJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 19:41:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 17:41:33 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-OqKSG5TG96@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21934|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 21974
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21974&action=edit
Bug 10996 Allow numeric subfields to be stripped on export

Regex assumed all numeric characters were part of the tag number
This is obviously false as $9 would be a likely candidate
to be removed on export. Constrain the tag by length

The code can be any printing ascii character other than space
according to LoC's website

Also changed regexp to no longer allow a zero length tag number
which is nonsensical.
The old regex would accept shorter than 3 digit tags but these were
not stripped so I've removed that option considering it a bug
not a feature

NB assumption that the code makes that a tag is always numeric is
incorrect but works in practice. Handling non-numeric tags is
a 'To be done'

Made code dependent on the regex succeeding. Picking up results
from a previous regex on failure can lead to weird hard to
identify bugs

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl, works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 19:55:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 17:55:13 +0000
Subject: [Koha-bugs] [Bug 11041] Hi, I am new and I have a question,
	you may help me!
In-Reply-To: <bug-11041-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11041-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11041-70-ZtKhZns4pM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11041

--- Comment #2 from hasanelias at yahoo.com ---
OK, thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 20:29:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 18:29:40 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-2d12NANiih@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #20 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to Fridolyn SOMERS from comment #19)
> (In reply to Katrin Fischer from comment #18)
> > Fridolyn, see comment 14 - I need instructions on how to correctly catalog a
> > UNIMARC authority with the required fields to reproduce this problem.
> Don't you have existing authorities ?

They don't use UNIMARC in Germany, so no.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 21:36:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 19:36:08 +0000
Subject: [Koha-bugs] [Bug 7632] Add option for quick renewals
In-Reply-To: <bug-7632-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7632-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7632-70-0mG52UxuMn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7632

Suzanne Fayle <sfayle at roseman.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sfayle at roseman.edu

--- Comment #1 from Suzanne Fayle <sfayle at roseman.edu> ---
I've heard from several staff members that this is something they'd like to see
as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 21:41:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 19:41:22 +0000
Subject: [Koha-bugs] [Bug 7632] Add option for quick renewals
In-Reply-To: <bug-7632-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7632-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7632-70-1vfGKGJLyR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7632

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 10493 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 21:41:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 19:41:22 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-881ex6uG56@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lzuares at collsk12.org

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 7632 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 21:48:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 19:48:55 +0000
Subject: [Koha-bugs] [Bug 11042] New: Color issue for selected tab under
	search box
Message-ID: <bug-11042-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042

            Bug ID: 11042
           Summary: Color issue for selected tab under search box
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: ssammons at npelem.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Created attachment 21975
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21975&action=edit
Image of color issue & element inspector.

When trying to customize colors for the staff/admin area you will encounter a
color code marked with !important in the CSS staff-global.css.

Upon copying the CSS code block and making changes to the color, the
staff-global.css color will over ride your select, even with important left on
the color statement.

Examples:
****My Custom Code:****

#header_search ul.ui-tabs-nav li.ui-tabs-selected {
background-color: #FFFFF1;
border: 1px solid #800000; !important;
border-top: 0 !important;
top: -1px;
}

****staff-global.css code****

#header_search ul.ui-tabs-nav li.ui-tabs-selected {
    background-color : #FFFFF1;
    border: 1px solid #85CA11 !important;
    border-top: 0 !important; top: -1px;
}


Notes:
I am using the Home ? Administration ? System preferences >
intranetcolorstylesheet option for the CSS file to put my code it. 

Coding is done via SSH on the system level to my file called custom-login.css.

I think the solution is just to remove the !important; statement off the code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 21:54:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 19:54:04 +0000
Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6030-70-h77yoWQxVS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

--- Comment #56 from Eric B?gin <eric.begin at inLibro.com> ---
Some email clients doesn't support UTF-8 encoding, should the charset be a
system preference ? (emailCharset or emailEncoding)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 22:02:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 20:02:45 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-CFQxEh3Xl0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #3 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 21976
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21976&action=edit
Bug 8000 - Override emails of every message sent from Koha

For testing purposes, we do not want emails sent to (legitimate) users.  And
sometime we also like to actually see what would be generated for the users. 
This preference will allow to override every message sent by koha with a new
(temporary) To address.  Leave it empty for normal usage.

C4/Letters.pm
installer/data/mysql/sysprefs.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref

TESTING:
0) Run updatedatabase.pl
1) Enter a valid address for new preference SendAllEmailsTo, something that
will be easily identified as NOT the normal destination for the Koha emails.
2) Have koha generate an email to a user.  Or any other mean prefered that
cause Koha to send email.
3) Validate that the email is NOT sent to the user.
4) Validate that the email IS sent to the overriding address.
5) Clean the preference
6) Redo the test, validate that the email is going to the right address.

PS Not sure if those steps are precise enough.  I'm not comfortable enough to
specify the best way to generate emails, I personnally had to hack it in my
environment.  Feedbacks welcomed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 22:04:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 20:04:07 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-n5VKFbvYzf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 23:14:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 21:14:45 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-LxOFe1Y8Bc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #55 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Galen Charlton from comment #54)
> (In reply to Katrin Fischer from comment #51)
> > I am not sure if it's annoying - I always tell people that everything that
> > is indexed can be searched in keyword search and the reactions so far are
> > quite positive.
> 
> I agree -- it's easier to explain that an "any" index includes everything
> (though whether or not fixed fields should be included is a matter of
> opinion), so I for one don't really see a problem with the change in
> behavior of the "any" index.
> 
> Note, though, that that's a separate question from whether the "any" index
> should be included in, say, auth_finder.pl, as somebody looking for
> authority records via that interface has little reason to be using anything
> other than the headings searches to begin with.

Sorry, but I do not agree with both of you.
I'm speaking here in general, not for authorities (we don't give access to
authorities on opac). The OPAC search with GRS1 is very "noisy", with a lot of
unwanted and non understandable results.
Ex : I have a book published in "Roma". It has "1 vol. (215 p.)", it is written
in french ("fre" in 105a) with an item having an INTERNAL note (not shown on
opac) in 995 field, like "book given by a teacher".
This book will currently show on opac when some user search "vol", "fre",
"book", "given", "teacher" or "Roma". For "Roma" I could maybe understand, but
I don't like that. For the other points I don't like that AT ALL.

We have a rather big catalog (400 000 records), to Koha can easily find a lot
of unrelated records for any search. With DOM I understand it will be worse.

Of course this issue could been less problematic, if Koha had a good pertinence
sorting (it is mad), a good date sorting (it is broken, for unimarc at least),
and a good facetting system (all we have are pseudofacets, non parametrable for
the moment, based only on the X first results, not cumulable, and whose general
presentation is not user friendly). We can work on these points, of course, but
it would be easier to define a more reasonable "any" index.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 11 23:30:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 21:30:46 +0000
Subject: [Koha-bugs] [Bug 9416] We should have 2 kinds of notes for each
	order line
In-Reply-To: <bug-9416-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9416-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9416-70-pGdVzRPQQ5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
New attachment ? A problem with sandbox? 

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 00:13:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 22:13:23 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-Uum6YRMNU1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21060|0                           |1
        is obsolete|                            |

--- Comment #13 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21977
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21977&action=edit
[PATCH] [SIGNED-OFF] Bug 9830: Fix some indexes in UNIMARC item indexing

[typo fixed in commit message ; steps 6 and 7 added in test plan]

With this combination of sysprefs, and a UNIMARC configuration, it impossible
to search on location, barcode and ccode indexes :

QueryWeightFields          is activated
QueryAutoTruncate          only if * is added

But in UNIMARC, location, barcode and ccode (995 $e,$f,h) are indexed only as
"words". They need to be indexed also as "phrase"
Additionnaly, in UNIMARC, information about damaged and withdrawn status of
items is not indexed, while it is done in MARC21.
This patch
- add 2 new indexes for 995$1 (damaged) and 995$3 (withdrawn)
- index location, barcode and ccode as "phrase" as well as "words"
indexing of items in UNIMARC could be improved later. So this patch also add
comments explaining the origin of Koha 995, I think it could be usefull for
further changes.

To test, on a UNIMARC configuration :
A. indexed with GRS-1
1) set sysprefs QueryWeightFields as "activated" and QueryAutoTruncate as "only
if * is added"
2) select location index in advanced search and search for a value existing in
your records in 995$e => 0 results
3) Apply patch
4) Rebuild zebra
5) select location index in advanced search and search for a value existing in
your records in 995$e => x results
6) mark an item as withdrawn ; search "withdrawn:1" => x results, and among
them the biblio to which the item is attached
7) mark an item as damaged ; search "damaged:1" => x results, and among them
the biblio to which the item is attached

B. indexed with DOM
Do the same operations

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 00:13:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 22:13:35 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-MPHgG9O7yz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 00:15:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 22:15:46 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-wv4sXzGpka@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Note : I made the test on current master. the 2 indexes damaged and withdrawn
are working well (with DOM). lost index is also working well, like before.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 00:30:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 11 Oct 2013 22:30:52 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-CAbTBtdJk8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
By the way, Jonathan, the idea for this patch comes from Fridolyn (MT10271).

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 09:26:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 07:26:53 +0000
Subject: [Koha-bugs] [Bug 11043] New: rename biblioitems.itemtype
Message-ID: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

            Bug ID: 11043
           Summary: rename biblioitems.itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

I find biblioitems.itemtype confusing.
In discussions about itemtypes, I often had to ask which kind of itemtype it
was about : "biblioitems.itemtype" or "items.itype".

It is an other issue, but zebra conf is confusing too, as in MARC21 the fields
mapped with "biblioitems.itemtype" and "items.itype" are mapped with the same
zebra index, whereas in UNIMARC 2 different indexes are used
(biblioitems.itemtype = 099t = ccode index ; items.itype = 995r = itype index)
I think it is not normal, and should be fixed in an other bug.

biblioitems.itemtype is not about item, but about document, so what I would
propose here is to rename biblioitems.itemtype to biblioitems.doctype
or maybe biblioitems.kohadoctype (as document type can also be retreived from
MARC fields non specific to Koha, like 210$b in UNIMARC)

Any opinions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 15:28:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 13:28:16 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-oq6JRU0UtI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
Nice enh
Tested on sandbox 1

* Test of Sort by hours: seems OK

Period From 03/09/2013
Period To 04/09/2013
Library = MAURES
Home branch = MAURES
Holding branch = MAURES
Event = issue
Display by = 4 
datetime / itemtype         Compact Disque     Livre audio     Livre     Revue 
       TOTAL
9     0     0     0     1     0     0     1
10     0     0     0     2     0     0     2
11     0     0     0     3     0     0     3

In database : 
2013-09-03 09:45:23    MAURES        0.0000    issue            5464    LIVR   
6068        
2013-09-03 10:57:34    MAURES        0.0000    issue            4862    LIVR   
7570        
2013-09-03 10:57:44    MAURES        0.0000    issue            1338    LIVR   
7570        
2013-09-03 11:19:39    MAURES        0.0000    issue            5663    LIVR   
3488        
2013-09-03 11:29:47    MAURES        0.0000    issue            2171    LIVR   
3431        
2013-09-03 11:39:31    MAURES        0.0000    issue            4350    LIVR   
5212        

* test of flter by itemtype : seems ok (same kind of test)

* test of patron attribute filter : 
- display all checkouts between  01/08/2013 and 04/09/2013 ; dates in columns ;
professions in rows
=> I did not check database, but presentation of results seemed ok :
agent administratif     0     0     0     0     0     0     0     0     0     0
    0
agent d'accueil     0     0     0     0     0     0     0     0     0     0    
0
enfant     0     0     1     0     0     0     0     0     0     0     1
Enseignant     0     0     1     0     0     0     0     0     0     0     1
etc.

- use a value of attribute Profession as a filter : value "Enseignant"
display only one line => ok

PROFESSION / datetime     9     10     11     12     13     14     15     16   
 17     18     TOTAL
Enseignant     0     0     1     0     0     0     0     0     0     0     1
TOTAL     0     0     1     0     0     0     0     0     0     0     3

============
But, at that point, I remarked a bug : 
TOTAL is wrong : the last column is displaying "3", while the last column for
the only row ('Enseignant') is 1.
So, for Koha, the "sum" of 1 is 3. Wrong somewhere

Other remarks (cosmetic)

I think "Item type" should be better understood if named "Document type". That
make obvious that is using biblioitems.itemtype (I suppose so?) and not
items.itype.
In the results, the " Display by = [1...4] " line is not easy to understand. It
seems that each number match a kind of date grouping (hours, months...). Could
you display it in plain english?

Could you check the calculation of "TOTAL" line?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 15:28:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 13:28:57 +0000
Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters)
In-Reply-To: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7679-70-3jVilEB7JV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(in fact, tested on sandbox 3, with radio button "Count total items ")

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 15:47:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 13:47:47 +0000
Subject: [Koha-bugs] [Bug 10844] circs by dewey range
In-Reply-To: <bug-10844-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10844-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10844-70-paezfTl5W1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10844

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Here we created a SQL function for that.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 15:49:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 13:49:07 +0000
Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6030-70-7612HWcnJk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #57 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I'm a big lost. Is this bug for 3.8.x or for master ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 21:14:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 19:14:23 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-CVSOgBNRVl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

--- Comment #56 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to mathieu saby from comment #55)
> (In reply to Galen Charlton from comment #54)
> > (In reply to Katrin Fischer from comment #51)
> > > I am not sure if it's annoying - I always tell people that everything that
> > > is indexed can be searched in keyword search and the reactions so far are
> > > quite positive.
> > 
> > I agree -- it's easier to explain that an "any" index includes everything
> > (though whether or not fixed fields should be included is a matter of
> > opinion), so I for one don't really see a problem with the change in
> > behavior of the "any" index.
> > 
> > Note, though, that that's a separate question from whether the "any" index
> > should be included in, say, auth_finder.pl, as somebody looking for
> > authority records via that interface has little reason to be using anything
> > other than the headings searches to begin with.
> 
> Sorry, but I do not agree with both of you.
> I'm speaking here in general, not for authorities (we don't give access to
> authorities on opac). The OPAC search with GRS1 is very "noisy", with a lot
> of unwanted and non understandable results.
> Ex : I have a book published in "Roma". It has "1 vol. (215 p.)", it is
> written in french ("fre" in 105a) with an item having an INTERNAL note (not
> shown on opac) in 995 field, like "book given by a teacher".
> This book will currently show on opac when some user search "vol", "fre",
> "book", "given", "teacher" or "Roma". For "Roma" I could maybe understand,
> but I don't like that. For the other points I don't like that AT ALL.
> 
> We have a rather big catalog (400 000 records), to Koha can easily find a
> lot of unrelated records for any search. With DOM I understand it will be
> worse.
> 
> Of course this issue could been less problematic, if Koha had a good
> pertinence sorting (it is mad), a good date sorting (it is broken, for
> unimarc at least), and a good facetting system (all we have are
> pseudofacets, non parametrable for the moment, based only on the X first
> results, not cumulable, and whose general presentation is not user
> friendly). We can work on these points, of course, but it would be easier to
> define a more reasonable "any" index.

These are reasonable concerns and coments, but IMO they are more for bug 8962
than this one.  Since the immediate concern of this bug -- adding an initial
DOM configuration for UNIMARC authorities -- is now addressed in master and we
have an explanation of the differences in "Any" authority searches in DOM vs.
GRS-1, I'm setting this one to pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 12 21:14:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 12 Oct 2013 19:14:47 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-aZXco0Eygq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 10:21:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 08:21:43 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-k5JcAdeoHN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

--- Comment #57 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
> 
> These are reasonable concerns and coments, but IMO they are more for bug
> 8962 than this one.  

Right ;-)
Now that this one and the one for 1XX are pushed, I will rewrite 8962.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 10:31:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 08:31:30 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-6it26PMPxN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #124 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Jonathan, I remembered of MT10590 : You thought BZ7180 would be the solution
for an price calculation issue, but you had to write an bug 9506 to fix it.
So, maybe 7180 causes a regression because it does not take into account 9506 ?
I did not check the detail.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 11:08:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 09:08:57 +0000
Subject: [Koha-bugs] [Bug 9846] system preference for required purchase
	suggestion fields
In-Reply-To: <bug-9846-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9846-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9846-70-eKfaLnUtfZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9846

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Good idea!

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 11:11:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 09:11:24 +0000
Subject: [Koha-bugs] [Bug 5770] email librarian when purchase suggestion made
In-Reply-To: <bug-5770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5770-70-369qR04dvc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Very very needed!
As the patron does not know which librarian will manage its suggestion, new
suggestions notices could be sent either to the Acq manager for the library
system, or to the Acq manager for each branch of the system, if a branch is
specified by the patron.

M. Saby

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 11:14:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 09:14:26 +0000
Subject: [Koha-bugs] [Bug 11044] New: All the librarians managing a fund
 should see the suggestions related to this fund
Message-ID: <bug-11044-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11044

            Bug ID: 11044
           Summary: All the librarians managing a fund should see the
                    suggestions related to this fund
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

All the librarians managing a fund should see the suggestions related to this
fund

If the  librarian managing history collections is replaced by an other
colleague, this other librarian should have access to all suggestions accepted
by his colleague.
Not sure it is currently possible 

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 11:15:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 09:15:26 +0000
Subject: [Koha-bugs] [Bug 4068] Accepting a suggestion hides 'pending' tab
In-Reply-To: <bug-4068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4068-70-jOSmITONy7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4068

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
This is still an issue.

M. Saby

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 11:19:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 09:19:45 +0000
Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase
	suggestions for patrons
In-Reply-To: <bug-9261-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9261-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9261-70-KPVEXfITM4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261

--- Comment #21 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi Kyle,
this patch would be very interesting for us.
Do you think you can fix the issues raised by Katrin?

For the idea of making a distinction between 2 kinds of suggestion, I don't
think it is necessary. If a patron fill a printed suggestion form and if we
copy it in Koha (that's the way we could use it, to manage all our suggestions
in Koha), he won't be surprised to see this suggestion in OPAC.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 11:20:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 09:20:44 +0000
Subject: [Koha-bugs] [Bug 7096] Receiving suggested items does not trigger
 notification mail (AVAILABLE)
In-Reply-To: <bug-7096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7096-70-mmxoyCeoNt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7096

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
It is fixed in our library (runing 3.11.something).

Mathieu

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:21:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:21:36 +0000
Subject: [Koha-bugs] [Bug 9820] Missing space between 100/700 $a and $c
	(MARC21/XSLT)
In-Reply-To: <bug-9820-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9820-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9820-70-i5yTDUFvAm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:22:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:22:15 +0000
Subject: [Koha-bugs] [Bug 10557] GetBooksellersWithLateOrders has an unused
 branch parameter
In-Reply-To: <bug-10557-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10557-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10557-70-M1UZXIiU7W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10557

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:23:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:23:19 +0000
Subject: [Koha-bugs] [Bug 10528] UT: C4::Bookseller.pm needs unit tests
In-Reply-To: <bug-10528-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10528-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10528-70-trM5XzoBsO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10528

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:23:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:23:44 +0000
Subject: [Koha-bugs] [Bug 9247] Add two more usage examples to the manpage
	for koha-mysql
In-Reply-To: <bug-9247-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9247-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9247-70-ZCWsylCv8a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9247

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:24:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:24:04 +0000
Subject: [Koha-bugs] [Bug 10587] HTML errors on authority detail page in OPAC
In-Reply-To: <bug-10587-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10587-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10587-70-YhNMrIfKae@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10587

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:24:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:24:32 +0000
Subject: [Koha-bugs] [Bug 10690] Warn about trailing slashes in description
 of OPACBaseURL and staffClientBaseURL
In-Reply-To: <bug-10690-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10690-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10690-70-mW9clqCx1i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10690

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:25:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:25:22 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7143-70-rsAFaEVrXA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #109 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Latest patch pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:26:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:26:21 +0000
Subject: [Koha-bugs] [Bug 5904] ysearch.pl members improvements (Independant
 branches behaviour)
In-Reply-To: <bug-5904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5904-70-YJVcsd92WX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5904

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:26:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:26:49 +0000
Subject: [Koha-bugs] [Bug 10786] Javascript error on the parcel page: YAHOO
 is not defined
In-Reply-To: <bug-10786-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10786-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10786-70-FLDgSygI3k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10786

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:27:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:27:16 +0000
Subject: [Koha-bugs] [Bug 10588] opac-topissues first branch always selected
	in filters
In-Reply-To: <bug-10588-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10588-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10588-70-XGMFP0jC69@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10588

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:27:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:27:38 +0000
Subject: [Koha-bugs] [Bug 9603] Fix layout of Patron Card Creator Layout
 screen for display in IE
In-Reply-To: <bug-9603-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9603-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9603-70-aB6wSRHqgI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9603

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:28:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:28:03 +0000
Subject: [Koha-bugs] [Bug 10574] Remove the message about upgrading to 3.4
In-Reply-To: <bug-10574-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10574-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10574-70-BStPn1xmUn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10574

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 15:28:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 13:28:25 +0000
Subject: [Koha-bugs] [Bug 10727] Replace carriage return with <br /> when
 writing hold notices
In-Reply-To: <bug-10727-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10727-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10727-70-14V4vfGBCy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10727

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 18:33:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 16:33:26 +0000
Subject: [Koha-bugs] [Bug 11045] New: Wrong query in C4/Biblios.pm : join
 between biblioitems.itemtypes and itemtypes table
Message-ID: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045

            Bug ID: 11045
           Summary: Wrong query in  C4/Biblios.pm : join between
                    biblioitems.itemtypes and itemtypes table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

C4::Biblios::GetBiblioData and GetBiblioItemData are doing : 
SELECT [...] itemtypes.notforloan  [...]
[...]
LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype

This is wrong becaause itemtypes table could be linked with items.itype (as in
my library) and not with biblioitems.itemtype.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 18:33:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 16:33:39 +0000
Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between
 biblioitems.itemtypes and itemtypes table
In-Reply-To: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11045-70-X1xRZaO2NE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 18:51:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 16:51:13 +0000
Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between
 biblioitems.itemtypes and itemtypes table
In-Reply-To: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11045-70-PFybVYQAuF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045

--- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to mathieu saby from comment #0)
> C4::Biblios::GetBiblioData and GetBiblioItemData are doing : 
> SELECT [...] itemtypes.notforloan  [...]
> [...]
> LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype
> 
> This is wrong becaause itemtypes table could be linked with items.itype (as
> in my library) and not with biblioitems.itemtype.

Actually, I think this is correct, since this is for biblio-level item types,
rather than item-level, which are treated elsewhere. You toggle between the two
with the item-level_itypes syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 20:52:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 18:52:44 +0000
Subject: [Koha-bugs] [Bug 11045] Wrong query in C4/Biblios.pm : join between
 biblioitems.itemtypes and itemtypes table
In-Reply-To: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11045-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11045-70-YgQQSmDbOX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11045

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jared Camins-Esakov from comment #1)
> (In reply to mathieu saby from comment #0)
> > C4::Biblios::GetBiblioData and GetBiblioItemData are doing : 
> > SELECT [...] itemtypes.notforloan  [...]
> > [...]
> > LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype
> > 
> > This is wrong becaause itemtypes table could be linked with items.itype (as
> > in my library) and not with biblioitems.itemtype.
> 
> Actually, I think this is correct, since this is for biblio-level item
> types, rather than item-level, which are treated elsewhere. You toggle
> between the two with the item-level_itypes syspref.

In my library, I have 'LIVRE' (book), 'REVUE' etc. in biblioitems.itemtypes.
I have "DPN", "DPL" (normal/long check out length) etc in items.itype
We have "DPN","DPL" etc itemtypes table 
We use item level type for issuing rules.

So when these subs are making a JOIN between biblioitems.itemtype and
itemtypes.itemtype, it means trying to join "LIVRE,REVUE" and "DPN,DPL" etc.
So it will never get anything.

What I was wondering is : is Koha's code calling this sub supposing that some
value should always be retreived from the join, and using these values for some
purpose ?
If it is not the case, that's not an issue. But I was not sure...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 23:00:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 21:00:23 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-UgvlvvXxoG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #25 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #24)
> Hi Mathieu,
> 
> I don't have a lot of time until after KohaCon probably - but it would
> really help this along if you can provide unit tests for the changed
> routines.

Ok.
I will take  the occasion for improving Biblio.t. It is failing with my unimarc
database.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 13 23:06:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 21:06:16 +0000
Subject: [Koha-bugs] [Bug 11046] New: keeping uncertain or range dates in
 publicationyear and copyright date
Message-ID: <bug-11046-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

            Bug ID: 11046
           Summary: keeping uncertain or range dates in publicationyear
                    and copyright date
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In C4:Biblio::TransformMarcToKoha, publicationyear and copyrightdate are filled
from MARC dates.
MARC dates could be uncertain. like "200X", "2012?", "ca. 2012".
If there is a "X" or a blank, the date is not copied in database.
Maybe this could be fixed. But in that case, publicationyear and copyrightdate
will sometimes contain non numerical data. Maybe that's an issue?

Sometime MARC dates are a range, like "2010-2013". In that case, Koha is
currently using only the first one. Why not both?

Last remark : In UNIMARC, I don't know the difference between publicationyear
and copyrightdate. Is it obvious for MARC21 people ?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:48:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:48:09 +0000
Subject: [Koha-bugs] [Bug 10915] about->timeline broken on upgraded Koha
In-Reply-To: <bug-10915-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10915-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10915-70-3laByYK86z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10915

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:50:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:50:08 +0000
Subject: [Koha-bugs] [Bug 10609] Use branch name rather than branch code in
 serials-collection.pl
In-Reply-To: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10609-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10609-70-a9HPvIiYwH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10609

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:50:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:50:50 +0000
Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for
 bibliographic information on OPAC results and detail pages (UNIMARC)
In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10218-70-5CWImJZSEV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

--- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:52:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:52:13 +0000
Subject: [Koha-bugs] [Bug 10793] XSLT change 780/785 search queries to use
 ti, phr indexes like other linking entries
In-Reply-To: <bug-10793-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10793-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10793-70-m0umY2vXLO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10793

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:52:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:52:49 +0000
Subject: [Koha-bugs] [Bug 10742] simple search to z39.50 search keeps index
In-Reply-To: <bug-10742-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10742-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10742-70-wsmhPrEcOr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10742

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:53:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:53:49 +0000
Subject: [Koha-bugs] [Bug 10672] Add subtitle to display of checkouts,
 overdues, and holds on the patron summary
In-Reply-To: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10672-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10672-70-qQITJem2le@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10672

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:54:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:54:16 +0000
Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting
 ReservesControlBranch
In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10272-70-pYUo2vDmJr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

--- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 00:55:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 13 Oct 2013 22:55:08 +0000
Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly
 in normal view (UNIMARC / no XSLT)
In-Reply-To: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10324-70-VGX7pNkQ6y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Pushed to 3.10.x, will be in 3.10.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 06:37:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 04:37:07 +0000
Subject: [Koha-bugs] [Bug 11047] New: koha-translate won't update
Message-ID: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11047

            Bug ID: 11047
           Summary: koha-translate won't update
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Packaging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: robin at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The update_lang() function calls install_lang, which won't do the update if the
language is already installed. This means you can't update.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 06:38:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 04:38:05 +0000
Subject: [Koha-bugs] [Bug 11047] koha-translate won't update languages
In-Reply-To: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11047-70-oSDudk1Vxt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11047

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
            Summary|koha-translate won't update |koha-translate won't update
                   |                            |languages

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 08:44:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 06:44:38 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-qFjwr4vV2V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #166 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Ketan Kulkarni from comment #165)
> Created attachment 21955 [details]
> My opac xslt preferences
> 
> Please see my OPAC preferences.

OK That looks good. Will post some more details today about what I came across.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 09:19:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 07:19:48 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-NYC2pVRaOk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #167 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 21978
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21978&action=edit
opac-search

Please look at mangled characters with diacritics in the XSLT blocks and
facets.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 09:21:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 07:21:43 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-6H1YKqX1ff@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21978|image/jpeg                  |image/png
          mime type|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 10:35:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 08:35:31 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-3GW8LpbWIJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #168 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
I attached an image for opac-search but opac-detail and opac-MARCdetail contain
similar mangled chars. Also opac-shelves.pl, opac-readingrecord.pl, and maybe
more..

At staff side: similar problems in catalogue/search, catalogue/detail.pl,
virtualshelves/shelves.pl, circ/circulation.pl (confirm checkout had a mangled
char), cataloguing/addbiblio.pl (oops: dangerous! saving mangled data),
acqui/booksellers.pl (look for ?), and maybe more..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 11:22:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 09:22:53 +0000
Subject: [Koha-bugs] [Bug 11048] New: Fix logout redirection for CAS
	authentication
Message-ID: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048

            Bug ID: 11048
           Summary: Fix logout redirection for CAS authentication
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: matthias.meusburger at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

The logout redirection function after a CAS authentication was misused. This
patch fixes it, and allows the CAS server to redirect the user back to the opac
after logout.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 11:30:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 09:30:09 +0000
Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS
	authentication
In-Reply-To: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11048-70-ALx3VPgNLn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048

--- Comment #1 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 21979
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21979&action=edit
proposed patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 11:32:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 09:32:26 +0000
Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS
	authentication
In-Reply-To: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11048-70-CrJ5BN6J1e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 12:52:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 10:52:22 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-h0YmEy8ooN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #169 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21980
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21980&action=edit
OPAC search

Marcel, 
I take a screenshot of your devel site. 
For me it looks right, without mangled chars. 

That's one the problems with this bug, 
different people see different things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 13:13:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 11:13:22 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-lptOvysbO3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #170 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Bernardo Gonzalez Kriegel from comment #169)
> For me it looks right, without mangled chars. 

I got the impression that the mangled chars are from the Latin subset
(diacritics on vowels like a e etc.) Special chars from Chinese or Japanese
seem to be correct.. Can you confirm that? Or are Latin chars also correct in
your case?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 13:24:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 11:24:41 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-CJJtaJvDZy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #171 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21981
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21981&action=edit
OPAC search 3

(In reply to M. de Rooy from comment #170)
> I got the impression that the mangled chars are from the Latin subset
> (diacritics on vowels like a e etc.) Special chars from Chinese or Japanese
> seem to be correct.. Can you confirm that? Or are Latin chars also correct
> in your case?

Problem is they look correct to me (latin diacritics).
Attached same screen but with Firefox. 

When tested latest patchset I can't reproduce errors, I create patron
categories in Chinese, Armenian, Indi, etc. All looked right (on master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 13:34:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 11:34:31 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-BIDpJgVRtJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #172 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Bernardo Gonzalez Kriegel from comment #171)
> Created attachment 21981 [details]
> OPAC search 3
Hi Bernardo
This is another image from my server but the 6554 patch is no longer active.
That makes a difference :)

> When tested latest patchset I can't reproduce errors, I create patron
> categories in Chinese, Armenian, Indi, etc. All looked right (on master)
OK.
My question actually was: If you have only a few latin chars on your screen (so
not combined with *real* eh-eh utf8 chars, are they correct? Do not know if you
have such records in YOUR database?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 13:36:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 11:36:42 +0000
Subject: [Koha-bugs] [Bug 11049] New: Truncated URLs may mangle output of
 sending cart email from opac
Message-ID: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

            Bug ID: 11049
           Summary: Truncated URLs may mangle output of sending cart email
                    from opac
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I stumbled over this in 3.8. A record contains four longer URLs (in MARC 856)
that in total exceed the field length of biblioitems.url (255 chars).
In saving this info into biblioitems.url the output of TransformMarcToKoha is
truncated.
When you put this biblio in the opac cart and send the cart, this truncated
field is inserted into a html template. After that it should be sent as a plain
text email. Somewhere in this process the truncated field causes the email
output to be mangled. Information after the URLs like item info and the closing
line with dashes do no longer appear.

It seems like this bug could be reproduced in master (looking at the code and
templates). But unfortunately, in master when sending the basket another error
pops up before the form of opac-sendbasket is shown.
Can't call method "field" on an undefined value at
/usr/share/koha/testclone/C4/Biblio.pm line 1713.
This is in the routine GetMarcNotes and it is actually not really related to
the error presented in this report ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 13:48:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 11:48:17 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-I8ycwJA3Gi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #173 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to M. de Rooy from comment #172)
> OK.
> My question actually was: If you have only a few latin chars on your screen
> (so not combined with *real* eh-eh utf8 chars, are they correct? Do not know
> if you have such records in YOUR database?

Yes I have :) 
And they look correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:00:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:00:40 +0000
Subject: [Koha-bugs] [Bug 8064] Merge several biblio records
In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8064-70-B6UygnrJzR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |paola.rossi at cineca.it

--- Comment #25 from Paola Rossi <paola.rossi at cineca.it> ---
As it was written in comment 19, I still get the following message when I click
the Merge button:
Following required subfields are missing:
    - 003$@
    - 008$@
    - 005$@
As it was written in comment 18, there is a problem when you try to copy the
LAST field of the record you destroy to the destination record.
So I don't sign off, and pass the patch to Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:03:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:03:37 +0000
Subject: [Koha-bugs] [Bug 8064] Merge several biblio records
In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8064-70-ItL1Yca1f9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi
I don't remember having the fist issue you mentionned when I tested with
UNIMARC records.
Jonathan, is it possible that the patch does not work well with MARC21 records?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:07:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:07:54 +0000
Subject: [Koha-bugs] [Bug 8064] Merge several biblio records
In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8064-70-xXdHZs17pg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064

--- Comment #27 from Paola Rossi <paola.rossi at cineca.it> ---
I as worked with MARC21 en.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:41:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:41:33 +0000
Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
 control whether patron links go to circ or patron details
In-Reply-To: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7680-70-nUjHlsJmzj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

--- Comment #11 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Owen Leonard from comment #2)
> The new include, patron-default-view.inc, outputs the *opening* half of
> the <a> so that individual templates can control whether to show
> full name, barcode, both, etc.
In my opinion, it would be better if include contained the full anchor tag.
Because templates are hard to read when they are not correct HTML.
You could pass to include the content of the tag : 

[% IF ( PatronDefaultView == 'circ' ) %]
<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% borrowernumber
%]">[% text %]</a>
[% ELSE %]
<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber
%]">[% text %]</a>
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:49:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:49:43 +0000
Subject: [Koha-bugs] [Bug 11049] Truncated URLs may mangle output of sending
 cart email from opac
In-Reply-To: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11049-70-cKRhVPMtqd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
OK. The error on GetMarcNotes was completely off-scope. But the new template
for opac-sendbasket seems to resolve this error on master.
So it looks like an old problem (3.8).
Marking it as solved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:50:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:50:57 +0000
Subject: [Koha-bugs] [Bug 7680] Create a PatronDefaultView preference to
 control whether patron links go to circ or patron details
In-Reply-To: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7680-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7680-70-qQkbpGfsBb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7680

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
I'd be happy to pick this up again if others think it's a good idea (and I
think it is). I'd like to hear more opinions though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 14:51:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 12:51:20 +0000
Subject: [Koha-bugs] [Bug 11049] Truncated URLs may mangle output of sending
 cart email from opac
In-Reply-To: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11049-70-AcizPP4WUK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|master                      |3.8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:02:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:02:12 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-YEjdaWkeln@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |paola.rossi at cineca.it

--- Comment #5 from Paola Rossi <paola.rossi at cineca.it> ---
The patch doesn't apply cleanly against master.
There is a merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt.
So I don't sign off the match, and I pass it to "failed QA".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:08:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:08:51 +0000
Subject: [Koha-bugs] [Bug 4880] koha-remove sometimes fails because user is
	logged in
In-Reply-To: <bug-4880-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4880-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4880-70-UBGE8dUICr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

--- Comment #4 from Magnus Enger <magnus at enger.priv.no> ---
Not sure if this really adds anything, but here goes:

I have been moving some instances around today, and done some koha-removes. In
the beginning I was getting errors because the koha user for the given instance
was logged in. Now I have tried several times to run koha-stop-zebra before I
run koha-remove, and now I'm not getting the error about the logged in user. At
least that seems to confirm the theory from comment #2.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:10:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:10:50 +0000
Subject: [Koha-bugs] [Bug 11049] Truncated URLs may mangle output of sending
 cart email from opac
In-Reply-To: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11049-70-qLWiwSvzQ3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just a final note: Copying the new template to 3.8 and taking over the change
in opac-sendbasket to use encode_qp on body and email_header will 'resolve' the
problem under 3.8 too.

But not completely by the way :)
Note that the message is now complete again, but the URL (remember it were
actually four urls) is now presented in the email as one big URL. (And it is
still truncated.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:21:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:21:31 +0000
Subject: [Koha-bugs] [Bug 11049] Multiple URLs (possibly truncated)
 presented as one URL in opac-sendbasket email message
In-Reply-To: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11049-70-k0IfA9xlLo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
            Summary|Truncated URLs may mangle   |Multiple URLs (possibly
                   |output of sending cart      |truncated) presented as one
                   |email from opac             |URL in opac-sendbasket
                   |                            |email message

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
So, we can actually reopen this bug for master now. But we need to rephrase it.

If you have multiple URLs in a biblio record with tag 856. They are put into
one biblioitem field (possibly truncated to 255 chars) and presented as one url
in the opac sendbasket email message.
Two errors at one time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:21:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:21:37 +0000
Subject: [Koha-bugs] [Bug 11049] Multiple URLs (possibly truncated)
 presented as one URL in opac-sendbasket email message
In-Reply-To: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11049-70-rBFpgAIU3p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.8                         |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:21:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:21:54 +0000
Subject: [Koha-bugs] [Bug 11049] Multiple URLs (possibly truncated)
 presented as one URL in opac-sendbasket email message
In-Reply-To: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11049-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11049-70-Ret6NiV2GH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11049

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Cataloging                  |OPAC
           Assignee|gmcharlt at gmail.com          |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:24:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:24:24 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-rh8N3N4q3r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21932|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21982
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21982&action=edit
Bug 11023: Toggle "new" status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:41:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:41:43 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-kzzR2HlbxY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |paola.rossi at cineca.it

--- Comment #12 from Paola Rossi <paola.rossi at cineca.it> ---
Applying: Bug 8230: Display acquisition details on the catalogue detail page
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 8230: Display acquisition details on the catalogue
detail page
So I don't sign off the patch, and pass it to "failed QA".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 15:57:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 13:57:30 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-0SpOz8Vu01@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21982|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21983
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21983&action=edit
Bug 11023: Toggle "new" status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 17:08:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 15:08:28 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-JDPeWm9WPP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from Paola Rossi <paola.rossi at cineca.it> ---
I've applied all the patches for bug 5336 before applying this one.
Applying of this patch is OK too.
Where is the "Acquisition details" tab (point 5 of the test plan)? I can't see
it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 17:36:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 15:36:25 +0000
Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
In-Reply-To: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9312-70-FGbgPdK2wK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

--- Comment #28 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
What is missing to pass QA ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 18:36:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 16:36:03 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-uqwNwgvWhE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #17 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
The principle is that the price including the tax has to be deduct from the
budget.
In fact, there's a bad calculation of the unit in orderreceive.pl.
If we are in the case :
list price include tax : YES
invoice price include tax : NO
So to have price including the tax, you have to add the tax to the unit price
(unitprice+unitprice*gstrate)

If we are in the case : 
list price include tax : NO
invoice price include tax : YES
you have to add the tax to the estimated price 
ecost =ecost+ecost*gstrate 

this is not the case in orderreceive.pl

I prepare a patch for this if everybody is ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 19:26:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 17:26:12 +0000
Subject: [Koha-bugs] [Bug 11026] in UNIMARC,
 pubdate index should be based on 100 field and not 210
In-Reply-To: <bug-11026-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11026-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11026-70-OjfrwYTh5F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11026

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
An other option would be to declare pubdate index both on 210$d AND 100pos9-12
So, if a library does not have 100 filled, the record will still be indexed
with 210.


M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 20:56:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 18:56:14 +0000
Subject: [Koha-bugs] [Bug 11050] New: Remove some non UNIMARC fields from
 UNIMARC Zebra conf files
Message-ID: <bug-11050-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11050

            Bug ID: 11050
           Summary: Remove some non UNIMARC fields from UNIMARC Zebra conf
                    files
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

Fields 603, 630, 631, 632, 633, 634, 635, 636, 646, 400, 401, 403, 414, 415,
416, 417, 418, 419, 420 are not defined in Unimarc, but are defined in Zebra
conf files for unimarc (for GRS 1 and DOM).

They should be removed to "clean" conf files.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 21:19:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 19:19:56 +0000
Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
In-Reply-To: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10782-70-viWAnjg7L1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 21:20:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 19:20:01 +0000
Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
In-Reply-To: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10782-70-vR6bSTHqPZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782

--- Comment #1 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 21984
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21984&action=edit
Bug 10782 - Add a koha-mysqlcheck script

This patch adds the koha-mysqlcheck script, as a "frontend" for
the mysqlcheck command. It can be used to check the integrity of
database tables, as well as to repair them. See "man mysqlcheck"
for more information.

The script takes a Koha instance name as its only required
parameter. Any other parameters provided before the instance
name are passed directly to mysqlcheck, which means that all
the functionality of mysqlcheck is available through this script.

To test the script:
- Apply the patch, build your own packages and install them, or
- copy koha-mysqlcheck to a server already running off packages

- Run some variations of the command, with and without arguments,
  and check that the output makes sense. E.g.:
    sudo koha-mysqlcheck myinstance
    sudo koha-mysqlcheck -e myinstance # Extended checks
    sudo koha-mysqlcheck -e -v myinstance # Extended checks and verbose
- See "man mysqlcheck" for other relevant options

To test the man page:
- Run these commands and look at the formatted man page:
    $ xsltproc
/usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \
      debian/docs/koha-mysqlcheck.xml
    $ man -l koha-mysqlcheck.8
- Make sure this test passes:
    $ prove -v xt/verify-debian-docbook.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 21:21:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 19:21:57 +0000
Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
In-Reply-To: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10782-70-UlbkP94i9y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782

--- Comment #2 from Magnus Enger <magnus at enger.priv.no> ---
Just to be clear: My plan changed a little between the initial comment and the
actual commit. Please disregard the description given in the first comment, and
focus on the description in the actual commit. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:22:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:22:47 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
 PK, not cardnumber
In-Reply-To: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10636-70-gSJCwHQXbQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:23:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:23:56 +0000
Subject: [Koha-bugs] [Bug 10636] patronimage should have borrowernumber as
 PK, not cardnumber
In-Reply-To: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10636-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10636-70-oPh0iszD1e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10636

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
I've pushed to this master, as it's a dependency for the successful inclusion
of DBIx::Class.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:24:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:24:16 +0000
Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class
In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8798-70-NEnwUQCFb4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:26:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:26:32 +0000
Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class
In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8798-70-e7wrFLL4UB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #94 from Galen Charlton <gmcharlt at gmail.com> ---
At long last, this is in master.  I've pushed a few follow-ups, but the only
one of particular note is one that requires update_dbix_class_files.pl to get
its DB connection parameters from the command line rather than the current Koha
context, to reduce the risk that a developer or RM accidentally includes test
database schema cruft when doing a schema class update. 

Thanks, everybody!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:42:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:42:22 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-nIEpolWOGz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P4
             Status|BLOCKED                     |Needs Signoff
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:42:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:42:59 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-Zu63ts0mgD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14871|0                           |1
        is obsolete|                            |

--- Comment #17 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21985
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21985&action=edit
[PATCH 1/3] Bug 8962: Changes to CCL and templates


This patch adds a new index Anywhere in ccl.properties and add "any word"
option in intranet search for using this index.
Default OPAC and intranet search in still using CCL "Any" index.

Testing plan :
In a Marc21 GRS-1 Koha :
1/ make some biblio searches without selecting any index (Koha will use "any"
index) and note the results. Ex : search "fre", "eng", "book", "history",
"history book"
2/ apply the 3 patches
3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth,
Unimarc bib) from your sources to the directory used by Zebra configuration in
your Koha instance
4/ launch rebuild_zebra.pl -b -r -x -v
5/ check that a new choice "Any word (all indexes)" is visible in advanced
search.
6/ make the same searches as 1/ : you should see less results (detailed test
plan in patchs 2 and 3)
7/ in Staff interface adavanced search, select "Any word (all indexes)" and
make the same searches as 1/ : you should see the same results (maybe with a
slight differences, because more notes fields are indexed in Marc21)

In a UNIMARC GRS-1 Koha :
same test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:43:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:43:49 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-ihi2ReIHCF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14873|0                           |1
        is obsolete|                            |

--- Comment #18 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21986
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21986&action=edit
[PATCH 3/3] Bug 8962: Unimarc biblios and authorithies (GRS1)


This patch makes some changes UNIMARC GRS1 indexing, for indexing only some
specific fields in "any" index.
The patch is fully testable, and can be signed off if it works.
But the list of fields I kept in "any" is rather subjective, and based as my
experience as a library user:
It can be discussed in followups.

1. Defines a new index "anywhere" for indexing all biblio and authorities
subfields.
2. Make "any" index more selective than before :
- for authorities : all fields indexed in any except 001 and notes (3XX)
- for biblios : fields indexed in any :
* biblio fields indexed in "any" :
** the more "user friendly" control numbers : 01X, 07X
** authors : 7XX except $9, 200$f$g
** titles : 4XX except $9, 5XX except $9, 200$a$d$e$h$i
** edition statement : 205
** series : 225, 410, 411
** subjects : 6XX except $9 and 67X/68X
** notes : only 327, 328, 314, 330
* items fields indexed in "any" :
** barcode : 995f
** callnumber : 995k

Test plan :
In a Marc21 GRS-1 Koha :
1/ apply patch 1 and this one
2/ in Staff interface, make some searches on authorities (choose "Keyword
search" tab), including searches of words only present in 3XX fields.
3/ copy the 2 new record.abs files (UNIMARC auth, UNIMARC bib) from your
sources to the directory used by Zebra configuration in your Koha instance
4/ launch rebuild_zebra.pl -b -r -x -v
5/ make the same authorities searches as 2/ : you should get the same results,
except for searches based on words only present in 3XX fields : in that case,
you should not see the auth records.
6/ in default search (without selecting any index), search for some record by
- its isbn
- its issn
- its title
- its author(s)
- its series name
- its publisher
- its summary (330 field)
- several subjects
- the barcode of one of its items
- the callnumber of one of its items
=> you should find the record each time
7/ in default search (without selecting any index), search for some record by
- the content of any 3XX fields (except 327,328,314,330)
- the number of pages or volumes (ex : "510 p." or "1 vol")
- its language code ("eng", "fre"...)
- the value of 200$b (like "Texte imprim?")
- its publication year
- its town of publication
- the content of a 670-680 field
- the content of a 995 subfield (except barcode and callnumber)
- the content of a 099 subfield
=> you should not find the record each time
8/ regression test : check that specific indexes are working as usual (title,
subject, callnum, barcode, pubdate etc)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:48:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:48:05 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-CX388yIKT0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14872|0                           |1
        is obsolete|                            |

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 21987
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21987&action=edit
[PATCH 2/3] Bug 8962: Marc21 biblios and authorithies (GRS1)


This patch makes some changes MARC21 GRS1 indexing, for indexing only some
specific fields in "any" index.
The patch is fully testable, and can be signed off if it works.
But the list of fields I kept in "any" is rather subjective, and based as my
experience as a library user:
It can be discussed in followups.

1. Defines a new index "anywhere" for indexing all biblio and authorities
subfields.
2. Make "any" index more selective than before :
- for authorities : all fields indexed in any except 001
- for biblios : fields indexed in any :
* biblio fields indexed in "any" :
** the more "user friendly" control numbers : 020->030
** main entries (authors and uniform title) : 1XX
**  title and Title-Related Fields : 20X-24X
** publisher : 260$b
** series : 4XX
** some notes : 502 (dissertation), 520 (abstract), 505 (formated content), 511
(participant)
** subjects : 6XX
** added Entry Fields : 70X-75X
** linking Entries-General Information : 76X-78X
** series Added Entry Fields : 80X-83X
* item fields indexed in "any" :
** callnumber : 952$o
** barcode : 952$p
3. Also index all the Marc21 notes (5XX) in "Notes" index (same logic as
current 3XX fields indexing in UNIMARC)
- new fields not indexed before :
504,506,507,508,511,513,514,515,516,518,521,522,524,525,530,533,534,535,
536,538,540,541,542,544,545,547,550,552,555,556,561,562,563,567,580,581,583,584,585,586,588
- fields indexed in "Notes" in addition to a more specific index :
502,505,521,520,510,526
4. Also index all the Marc21 notes (5XX) in "Notes" index (same logic as
current 3XX fields indexing in UNIMARC)
5. Adds a lot of comments to make easier further changes and error checking

Test plan :
In a Marc21 GRS-1 Koha :
1/ apply patch 1 and this one
2/ in Staff interface, make some searches on authorities (choose "Keyword
search" tab)
3/ copy the 2 new record.abs files (Marc21 auth, Marc21 bib) from your sources
to the directory used by Zebra configuration in your Koha instance
4/ launch rebuild_zebra.pl -b -r -x -v
5/ make the same authorities searches as 2/ : you should get the same results
5/ edit a record to put the value "xxxx" in newly indexed "5XX" field (for
example in 530)
6/ search "note:xxxx" : you should find the record
7/ edit a record to put the value "xxxx" in a "5XX" field index in note in
addition to a more specifi index (for example in 520)
8/ search "note:xxxx" : you should find the record
9/ in default search (without selecting any index), search for some record by
- its isbn
- its issn
- its title
- its author(s)
- its series name
- its publisher
- its summary (520 field)
- several subjects
- the barcode of one of its items
- the callnumber of one of its items
=> you should find the record each time
10/ in default search (without selecting any index), search for some record by
- the content of any 5XX fields (except 502,505,511,520)
- the number of pages (ex : "510p")
- its language code ("eng", "fre"...)
- its publication year
- its town of publication
- the content of a 05X-08X field
- the content of a 010-018 field
- the content of a 942 subfield
- the content of a 952 subfield (except barcode and callnumber)
=> you should not find the record each time
11/ regression test : check that specific indexes are working as usual (title,
subject, callnum, barcode, pubdate etc)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:54:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:54:56 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-OZoPGtMhdd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I rewrote the patchs and add test plan.
Only for GRS1 for the moment.
My Koha VM is a UNIMARC DOM, so I cannot test it myself, but I hope it will
work.

I made 3 patchs so that somebody can test and sign Marc21 patch and somebody
else UNIMARC patch.
The list of fields I kept in "any" can be discussed, but once the patch is
pushed, each library will have the ability of deleting or adding fields by
modifying its zebra conf files.
When we all agree on the list of fields to keep, I will make patchs for DOM.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 14 23:56:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 21:56:28 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-BwwGSzeLU7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #21 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I add Galen, as we had elsewhere some discussion about this patch.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 00:00:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 22:00:18 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-7DbspIUkwj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Of course, in test plan of UNIMARC patch, read "In a UNIMARC GRS-1 Koha" (and
not Marc21!)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 00:53:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 22:53:52 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-PmInQbQe7v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Pushed for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 00:58:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 22:58:20 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-teUiuOfqjh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed for QA               |Pushed to Master

--- Comment #38 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with follow-ups, including one that adds a new tools
permission for the feature.  Note that I did not include your first three
follow-ups as they ended up conflicting with the fix for 10636.  Thanks, Kyle!

I will add, however, that this made it in by the skin of its teeth, and
primarily because it exercises DBIx::Class support.  In particular, it was
rather careless that the patch as submitted did not require staff
authentication.  This is a BIG deal -- even if the feature were suitable for
all staff users (which is debatable for technical services staff) -- it is
obviously not suitable for anybody who happens to be good add guessing URL
patterns.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 01:29:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 23:29:16 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-crZFATf6Dp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 01:29:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 14 Oct 2013 23:29:25 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-HWL4zV1wLW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #28 from Galen Charlton <gmcharlt at gmail.com> ---
I've pushed the main patch + all of the follow-ups + a follow-up of my own to
master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 03:27:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 01:27:29 +0000
Subject: [Koha-bugs] [Bug 11051] New: Performance of opac-search
Message-ID: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

            Bug ID: 11051
           Summary: Performance of opac-search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: robin at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

I did a profile of opac-search and am going to make a few improvements to it.

You can see the results here:

http://debian.koha-community.org/~robin/opac-search/

This was run on a production 3.12.2 system, with 10 branches, with a database
server on a different machine. This means that database latency is more
visible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 03:27:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 01:27:49 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-G4eJq3CWDm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz
         Depends on|                            |11051

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 03:27:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 01:27:49 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-18sYru93xq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7923

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 03:27:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 01:27:58 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-cLJ9mH0fLr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 03:28:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 01:28:08 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7923-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7923-70-J2VHDwQ9jr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|robin at catalyst.net.nz       |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 03:28:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 01:28:29 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-ruPQRMi9iT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 04:09:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 02:09:57 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-1ya0NjkPmX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #1 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21988
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21988&action=edit
Bug 11051 - remove unneccessary SQL queries in GetBranches

The way GetBranches was written, it will issue one query to get all
branches, and then one query per branch for the branch relations.
This patch pre-fetches the relations table (as we need it all anyway)
and so makes the whole process happen in two queries, rather than take
1+N, where N is the number of branches.

This might not seem like much, but when you do a search, GetBranches is
called once for each result, so 25. And you might have 10 branches. This
causes 275 database requests when you could get away with 50.

>From profiling, when you run a search, this is the thing that calls
DBI::st::execute the most. Refer:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125

Test Plan:
* Have a database with branches and relationships between the branches.
  (these are 'Lubrary groups' in the UI.
* Make sure the relationships show up correctly after applying the
  patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 04:14:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 02:14:51 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-JmPOJ162OD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 04:14:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 02:14:54 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-rqXIIP77D4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21988|0                           |1
        is obsolete|                            |

--- Comment #2 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21989
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21989&action=edit
Bug 11051 - remove unneccessary SQL queries in GetBranches

The way GetBranches was written, it will issue one query to get all
branches, and then one query per branch for the branch relations.
This patch pre-fetches the relations table (as we need it all anyway)
and so makes the whole process happen in two queries, rather than take
1+N, where N is the number of branches.

This might not seem like much, but when you do a search, GetBranches is
called once for each result, so 25. And you might have 10 branches. This
causes 275 database requests when you could get away with 50.

>From profiling, when you run a search, this is the thing that calls
DBI::st::execute the most. Refer:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125

Test Plan:
* Have a database with branches and relationships between the branches.
  (these are 'Lubrary groups' in the UI.
* Make sure the relationships show up correctly after applying the
  patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 06:56:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 04:56:51 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-OxelmDj1vn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #3 from Robin Sheat <robin at catalyst.net.nz> ---
Caching on GetMarcStructure seems to actually be slower than running it.

Compare:

http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78
(uncached)

to:

http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78
(cached)

That function has ~1 second difference across all its calls. Removing the
memoization of GetMarcStructure should fix this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 07:06:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 05:06:28 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-oUDSauuDIi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #4 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 21990
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21990&action=edit
Bug 11051 - remove caching of GetMarcStructure

Profiling suggests that this is actually ~1s slower with caching
enabled, probably due to serialisation overheads.

Compare uncached:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78

to cached:
http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78

Test plan (please do this, more data points are good):
* set up an instance with memcache available but not used
* run the profiler on it
* enable the use of memcache
* run the profiler on it, note that the caching is being used and the
  code runs slower.
* apply the patch
* run the profiler again with memcache, note that the caching is not being used
and
  things are back to being speedy.

A quick primer to using the profiler:
* apt-get install libdevel-nytprof-perl
* sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211
MEMCACHED_NAMESPACE=library-koha-opac
KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib
SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
'q=a'
* this will create nytprof.out in the current dir (use /tmp)
* run nytprofhtml to produce HTML output.
* remove/include the MEMCACHED variables to turn caching on/off
  globally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 07:08:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 05:08:48 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
 multiple branch security mod
In-Reply-To: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9055-70-ulPT8q2akN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

Waylon Robertson <wrobertson1981 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13475|0                           |1
        is obsolete|                            |

--- Comment #10 from Waylon Robertson <wrobertson1981 at gmail.com> ---
Created attachment 21991
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21991&action=edit
Multibranch search/security patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 07:09:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 05:09:55 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
 multiple branch security mod
In-Reply-To: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9055-70-rwR0o0XT0y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

--- Comment #11 from Waylon Robertson <wrobertson1981 at gmail.com> ---
Created attachment 21992
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21992&action=edit
Fix for patch, fixes updatedatabase.pl mistake made by WaylonR

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 07:11:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 05:11:31 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
 multiple branch security mod
In-Reply-To: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9055-70-tEWmFfcgw9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

--- Comment #12 from Waylon Robertson <wrobertson1981 at gmail.com> ---
Brought the code up to the current master - 3.14 first alpha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 09:23:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 07:23:48 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-l0pgIQpMDI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Maybe I could remove the changes made for authorities, as they are not really
needed, and create an other bug for improving auth indexing (index coded
fields, marc21 notes etc)

M. saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 09:25:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 07:25:16 +0000
Subject: [Koha-bugs] [Bug 10833] Multi transport types for advanced notices
In-Reply-To: <bug-10833-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10833-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10833-70-6twiDxwJOm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10833

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
        Bot Control|---                         |Ignore this bug

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to I'm just a bot from comment #3)
> This bug depends on bug9016 which is in status Needs Signoff but the patches
> for it do not apply cleanly

It applies cleanly (but 9016 has a conflict on updatedatabase.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 09:30:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 07:30:21 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-rUEtPHpB6H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #18 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Koha Team Lyon 3 from comment #17)
> The principle is that the price including the tax has to be deduct from the
> budget.
> In fact, there's a bad calculation of the unit in orderreceive.pl.
> If we are in the case :
> list price include tax : YES
> invoice price include tax : NO
> So to have price including the tax, you have to add the tax to the unit
> price (unitprice+unitprice*gstrate)
> 
> If we are in the case : 
> list price include tax : NO
> invoice price include tax : YES
> you have to add the tax to the estimated price 
> ecost =ecost+ecost*gstrate 
> 
> this is not the case in orderreceive.pl
> 
> I prepare a patch for this if everybody is ok

Hi
For me the question is : are we supposed to store a corrected price
(with/without gst) in "unitprice" column, or to calculate dynamicly the right
price at display?
If we store the "gst corrected" unitprice, it will mabye be more precise for
rounding, and it will mean if we change the vendor settings AFTER having
received a book, the remaining available amount for the fund will stay
unchanged. I suppose it will be a good behavior, but I am not completely sure.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 09:40:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 07:40:25 +0000
Subject: [Koha-bugs] [Bug 11052] New: Missing field in french unimarc
 authorities framework
Message-ID: <bug-11052-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11052

            Bug ID: 11052
           Summary: Missing field in french unimarc authorities framework
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

103 field (date of the entity) is typical from french unimarc as it is used by
academic libraries
It must be add to Koha default auth framework for french locale.
http://documentation.abes.fr/sudoc/formats/unma/zones/103.htm

Note : 106 field and 128 field are also typical from french unimarc as it is
used by academic libraries, but they are already in Koha

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 09:44:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 07:44:44 +0000
Subject: [Koha-bugs] [Bug 11053] New: Index notes of authorities in MARC21
Message-ID: <bug-11053-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11053

            Bug ID: 11053
           Summary: Index notes of authorities in MARC21
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

Authorities notes are indexed by Zebra for UNIMARC records, but not for MARC21.
We could index them in "note" index like for UNIMARC :
667  Nonpublic General Note  (R)
670  Source Data Found  (R)
672  Title Related to the Entity  (R)
673  Title Not Related to the Entity  (R)
675  Source Data Not Found  (NR)
678  Biographical or Historical Data  (R)
680  Public General Note  (R)
681  Subject Example Tracing Note  (R)
682  Deleted Heading Information  (NR)
688  Application History Note  (R)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 09:51:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 07:51:43 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-ZAH1hFecKm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #19 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Hi
yes, I understand your point of vue but I'm not sure. But, if the settings
change in the middle of year because the vendor really change his behaviour,
the invoices which have been already paid won't change. If the calculation is
dynamic, it will change the spent amount and the available, but it isn't right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 10:04:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 08:04:52 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-06y6HHd4LN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Koha Team Lyon 3 from comment #19)
> Hi
> yes, I understand your point of vue but I'm not sure. But, if the settings
> change in the middle of year because the vendor really change his behaviour,
> the invoices which have been already paid won't change. If the calculation
> is dynamic, it will change the spent amount and the available, but it isn't
> right.

We made mistakes here for the settings of some vendors, and took profit of the
current behavior ;-), BUT I agree with you, the best solution would be to have
"gst corrected price" stored in database.

And Koha's documentation should maybe be updated to make clear that changing a
vendor setting does not change the prices of received parcels, BUT will change
the price calculation of parcels not yet receveived.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 10:07:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 08:07:15 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-mnlQD4Tpax@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:11:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:11:16 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-g0DOxJL8Yx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21993
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21993&action=edit
Bug 11005 [ENH] - Centralize the UseBranchTransferLimits-check under one
function

Created a C4::Circulation::CheckBranchTransferAllowed() as a more convenient
branch transfer check
than the previous multiline if-else mess. This is a more pleasant and readable
approach to generalizing
branch transfer checks accross Koha.
Includes a error message as the return value so the precise reasons for denial
need not be constructed
when needed.

Unit tests included which test the new C4 function.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:17:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:17:03 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-0R1ZKsSmv7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #21 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 21994
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21994&action=edit
Calculation of price with the gst in ordereceive

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:19:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:19:14 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-2Miuv9vbb3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Deployed the properly formatted patch.
Applied on our testing environment and works fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:20:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:20:18 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-xAuPgiyvME@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11005, 11020, 11024         |
         Depends on|                            |11005

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:20:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:20:18 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-hP0q0rpR2w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7376
         Depends on|7376                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:20:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:20:18 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-DahOMlxboI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|7376                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:20:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:20:18 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-3eVNagePKO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|7376                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:20:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:20:34 +0000
Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in
 C4/Circulation.pm needs return value
In-Reply-To: <bug-10699-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10699-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10699-70-dLVawQnbYw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi
           Assignee|kenza.zaki at biblibre.com     |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:21:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:21:10 +0000
Subject: [Koha-bugs] [Bug 10699] DeleteBranchTransferLimits in
 C4/Circulation.pm needs return value
In-Reply-To: <bug-10699-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10699-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10699-70-ljeo6VTXtB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10699

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|olli-antti.kivilahti at jns.fi |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:23:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:23:57 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-AKpXySj4If@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |olli-antti.kivilahti at jns.fi
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:24:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:24:51 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-jldry9B31Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #24 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Agreed to fix this bug for Joubu, in exchange for QA stuff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:27:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:27:07 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-Skprubk4rP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21993|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21995
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21995&action=edit
Bug 11005 [ENH] - Centralize the UseBranchTransferLimits-check under one
function

Created a C4::Circulation::CheckBranchTransferAllowed() as a more convenient
branch transfer check
than the previous multiline if-else mess. This is a more pleasant and readable
approach to generalizing
branch transfer checks accross Koha.
Includes a error message as the return value so the precise reasons for denial
need not be constructed
when needed.

Unit tests included which test the new C4 function.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:29:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:29:08 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-wRYlBORxLJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21994|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:31:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:31:10 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-trRy0MeuTM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Can someone delete this attachement "Refactored the IsBranchTransferAllowed()
and it's dependencies. Created test cases." and this Comment?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:39:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:39:24 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-GLdIskiw1H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Your patch is marked as "obsolete". A mistake?

Also, could you provide a description of what it does, and a test plan, in the
commit message ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:46:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:46:17 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-8nnppW24ye@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Olli-Antti Kivilahti from comment #6)
> Can someone delete this attachement "Refactored the
> IsBranchTransferAllowed() and it's dependencies. Created test cases." and
> this Comment?

You cannot delete an attachment but you can obsolete it:
click on "Details" > edit details > check the 'obsolete' cb and submit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:50:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:50:49 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-5LGJqYoRvx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #13)
> I've applied all the patches for bug 5336 before applying this one.
> Applying of this patch is OK too.
> Where is the "Acquisition details" tab (point 5 of the test plan)? I can't
> see it.

Paola,
On a biblio detail page. There are some tabs (like 'Holdings', 'Descriptions',
'Subscriptions', 'Images').
The 'Acquisition details' tab is between 'Subscriptions' and 'Images'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 11:57:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 09:57:49 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-w1JYnI3AlN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #23 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
I just realize that my patch just corrected unitprice, thus the budget spent.
But I want to check if estimated cost is ok (for budget ordered) before to
propose it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:03:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:03:04 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-sWQ4gqUwum@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:03:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:03:09 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-7Dp1WgNDPv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18537|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 21996
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21996&action=edit
Bug 7288: Allow to display only subscriptions in the invoices table

This patch adds a checkbox "Show only subscriptions" in the invoices
table.
If this checkbox is checked, a filter is added on the table in order to
show only subscription invoices

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:03:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:03:50 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-NYOx0DpUjY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha.sekjal at gmail.com       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:22:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:22:41 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-ui64GoZT2D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21924|0                           |1
        is obsolete|                            |
  Attachment #21925|0                           |1
        is obsolete|                            |

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21997
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21997&action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:23:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:23:22 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-umkKUwLMkg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21998
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21998&action=edit
Bug 11020 - Transfer limits should be checked when placing a hold/reservation
in Staff client

Extended bug 11005.

Extended C4/Reserves.pm to support checking BranchTransferLimits when
requested. Extension does
in no way disturb existing functionality.

Modified the templates to show branch transfer blocks to the user.
Modified the business layer to re-check branch transfer limits in case user
fools the POST-request.

Created manual test cases.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:27:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:27:06 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-SD5FmKxXj8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10993
         Depends on|10993                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:27:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:27:06 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-COcloc3lhG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11020                       |
         Depends on|                            |11020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:28:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:28:56 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-GjYFyNFloV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21851|0                           |1
        is obsolete|                            |

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 21999
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21999&action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:29:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:29:26 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-ybbIg9AK54@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:40:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:40:32 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-qtHs68J9xp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22000
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22000&action=edit
Bug 10993 - Transfer limits should be checked when placing a hold/reservation
in OPAC.

Depends on bug 11005, 11020

Prevents a user from placing holds on material whose branch transfer is denied.
Displays clear messages that items are
unavailable and re-checks in the business layer in case of UI blocks failing.
Enables choosing another pickup location.

Manual tests included.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:41:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:41:21 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-fRA4povhiT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21891|0                           |1
        is obsolete|                            |
  Attachment #21892|0                           |1
        is obsolete|                            |

--- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22001
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22001&action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:42:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:42:00 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-orsQ0n6HLk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11024                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:42:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:42:00 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-mHbRo1pEaN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|10993                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:42:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:42:14 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-hneFQmMwhy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:48:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:48:39 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-mG6zhaWC0W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22002
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22002&action=edit
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl
-script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:49:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:49:13 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-BtEsirmhBI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 12:57:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 10:57:42 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-aCCHfkWZDY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #25 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
sponsored by Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 13:01:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 11:01:51 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-b86JUPRpVO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 13:01:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 11:01:51 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-roAnEqjjh7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7376

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 15:01:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 13:01:26 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-G9nvy84Yd7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #24 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 22003
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22003&action=edit
correct addorder and orderreceive to store price including gst

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 15:09:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 13:09:42 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-qZHyVlYQ1V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #25 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
This patch correct addorder.pl and orderreceive.pl to store prices including
gst in ecost and unitprice, according to the vendor preference (listinggst and
invoicegst).
The acqui-home.pl the budget summary should take into account the price
including gst.
But invoice table and basket table are not right anymore. I propose to do
others bugzilla ticket to correct this (or to complete bz10313)

Test plan is the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 15:18:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 13:18:56 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-eLROdLFzLK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

--- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Koha Team Lyon 3 from comment #25)
> Test plan is the same.

You mean the same as comment 2?
I did not check, but as you made changes in new places (orderreceived.pl...),
does not it need needs to be updated?
And could you include a description of the patch, and the test plan within
commit message? In a general way, it makes patches more easy to test,
especially if the patch is rewritten after discussion like this one ;-)

I will take a look this evening.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 15:36:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 13:36:21 +0000
Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class
In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8798-70-Bu8tGaL8RK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #95 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Software error on cgi-bin/koha/members/member.pl:
Base class package "DBIx::Class::Schema" is empty.
    (Perhaps you need to 'use' the module which defines that package first,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 15:55:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 13:55:48 +0000
Subject: [Koha-bugs] [Bug 11054] New: Creating a child record has problems
 with accented Latin characters
Message-ID: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

            Bug ID: 11054
           Summary: Creating a child record has problems with accented
                    Latin characters
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When you select New child record from the catalogue detail page. If the data
that will be used to create the host field contains latin characters with
diacritics from the range covered by latin-1 they are incorrectly encoded in
the resulting child record. This is not the case with non-latin characters
(Cyrillic, Arabic and Chinese tested) and I suspect with latin diacritic
combinations that are not in the latin-1 range

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 16:08:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 14:08:43 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-bgsl0c826d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21983|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22004
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22004&action=edit
Bug 11023: Toggle "new" status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 16:32:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 14:32:15 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-LwZ4GPaXTP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22005
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22005&action=edit
Proposed Patch

To test. 
Find a record with an accented character in the title e.g. a vowel with an
acute or grave or an n with a tilde in the detail page select new/new child
record the title will be copied into 773 $t (marc21) without the patch garbage
replaces the accented characters with the patch they appear correctly.

I've confirmed that the change does not have any detrimental effects when
copying non-latin characters e.g. Chinese, Cyrillic, Arabic which were already
being correctly copied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 16:53:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 14:53:58 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-Uq3VwwoLvl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22005|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22006
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22006&action=edit
[SIGNED-OFF] Bug 11054: Specify utf8 encoding when creating a child record

When the only non-ascii characters in a new child record
are latin + diacritic in the range covered by Latin-1 they
are not being added to a new child record correctly encoded.
Explicitly setting the record's encodiing ensures that
they are interpreted correctly.

see "Unicode Bug" in perldoc perlunicode for background on
why these characters are special

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors

Test
search for a record with diacritics on author or title
press New Child Record
without patch, 773's with mangled chars
with patch, all fine

This has nothing to do with major problems of encoding,
here we create a new record and as CPAN page states,
default encoding is MARC-8, so it's the right solution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 16:54:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 14:54:14 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-YZLfXnZxBG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 17:22:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 15:22:00 +0000
Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search,
 multiple branch security mod
In-Reply-To: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9055-70-X0gVuvCCrb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
Patch still has updatedatabase.pl issues.

However, this comment is about the transition from one system preference to
this set of system preferences. I do think this extends the functionality of
the SearchMyLibraryFirst, but there is no attempt to translate the old system
setting to a newer but equivalent one.

I have not tested the functionalities yet, but perhaps the mapping might be
something like:
    SearchMyLibraryFirst:yes => SearchableBranches:preferhome
    SearchMyLibraryFirst:no  => SearchableBranches:all

I would expect to see such a transition in the -- updatedatabase.pl section of
code. Also, you can add 3 system preferences in one section of code for
updatedatabase.pl, you don't need 3 "XXX" sections.

As such, I'll leave the status as is, "Patch doesn't apply", and await a newer
version which does apply and that has this mapping in the updatedatabase.pl
code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 18:17:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 16:17:42 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-hLn2X5u46A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 21974
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21974
Bug 10996 Allow numeric subfields to be stripped on export

Review of attachment 21974:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10996&attachment=21974)
-----------------------------------------------------------------

::: tools/export.pl
@@ +365,5 @@
> +                            my $subfield = $2;
> +
> +                            # skip if this record doesn't have this field
> +                            next if not defined $record->field($field);
> +                            if ($subfield) {

This is not the right test -- consider somebody who wants to exclude a subfield
$0 (zero) from export.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 18:17:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 16:17:56 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-2uWzPfLL8t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 19:21:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 17:21:10 +0000
Subject: [Koha-bugs] [Bug 8589] Advanced Search for itemtype and location
 produces some results that are not useful
In-Reply-To: <bug-8589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8589-70-szjJciKOe6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8589

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 20:47:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 18:47:49 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-2vfyBBPxnb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #2 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22007
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22007&action=edit
Bug 10937 - Options to group or hide items in adv. search

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

Modified:
    C4/Koha.pm    GetItemTypesCategorized
    admin/itemtypes.pl
    koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
    koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
    opac/opac-search.pl
    installer/data/mysql/kohastructure.sql  Added two columns, hideinopac and
searchcategory
    installer/data/mysql/updatedatabase.pl

Testing:
    0) run updatedatabase.pl to add the two columns to itemtypes
    1) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the
category dropdown
    2) Click button "New authorized value for DOCTYPECAT"
    3) Enter HARDWARE as Atuhorize value, ANything as Description and Hardware
as OPAC description then click SAVE.
    4) In Intranet/Koha Amind/Item types, select (at least) two different items
and proceed with the following steps
      a) Click action/Edit on the right column
      b) Third row is the search category list box, select Hardware
      c) click Save changes at the bottom
    5) In Intranet/Koha Admin/Item types (again), select a different item type
and click the checkbox "Hide in OPAC"
    6) Go to OPAC/Adv search.
    7) Validate that all items modified above do not appear in Item type list
    8) Validate that new item type Hardware does appear instead.
    9) Select item Hardware, start Search.
    10) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 20:48:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 18:48:33 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-WaKXqT6DpR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 20:56:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 18:56:11 +0000
Subject: [Koha-bugs] [Bug 8619] Remove hidelostitems syspref
In-Reply-To: <bug-8619-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8619-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8619-70-Y5zlLEIr3t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8619

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
this syspref is still present

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 21:26:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 19:26:16 +0000
Subject: [Koha-bugs] [Bug 11055] New: Add 'minutes' as a load period unit
Message-ID: <bug-11055-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

            Bug ID: 11055
           Summary: Add 'minutes' as a load period unit
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Our user likes to be able to fine by the (5) minutes for hourly loans (2h, 4h,
etc...).

One solution would be to change (hack) the fine amount and grace and... to
allow for fraction.  An easier solution is simply to add "minutes" as a unit.

Code change was very simple, but the Calendar and Holiday mechanisms have
changed since, so I'll see how to do it all cute again.

ALSO: One area of discussion with the user was about the meaning of a 24h loan.
 Unit=Hours, Period=24.  If the library is opened only 10h per day, this is not
a 3 day rental.  This should be a "same time tomorrow, fines by the hour".

Comments welcomed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 21:27:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 19:27:28 +0000
Subject: [Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit
In-Reply-To: <bug-11055-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11055-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11055-70-j9SynkAwiq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com
           Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 15 23:53:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 21:53:43 +0000
Subject: [Koha-bugs] [Bug 11056] New: dead code in basketgroup.pl : remove
 code depending on "validate" param
Message-ID: <bug-11056-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056

            Bug ID: 11056
           Summary: dead code in basketgroup.pl : remove code depending on
                    "validate" param
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

Some code is dead in basketgroup.pl
all the block depending on 
"($op eq 'validate')" clause

the "validate" parameter is no more used in template, since a Biblibre commit
has rewritten basketgroup template in 2009 : 
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=263961312c1ff7605ed1e28df40191ab01a75af9

M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 00:52:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 15 Oct 2013 22:52:38 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-dkeMJJvMjz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

--- Comment #39 from Nicole C. Engard <nengard at gmail.com> ---
Just did a fetch and get this error when trying to open the new tool:


Base class package "DBIx::Class::Schema" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains:
/home/nengard/kohaclone /etc/perl /usr/local/lib/perl/5.10.1
/usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10
/usr/share/perl/5.10 /usr/local/lib/site_perl .).
 at /home/nengard/kohaclone/Koha/Schema.pm line 10
BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/Schema.pm
line 10.
Compilation failed in require at /home/nengard/kohaclone/Koha/Database.pm line
38.
BEGIN failed--compilation aborted at /home/nengard/kohaclone/Koha/Database.pm
line 38.
Compilation failed in require at /home/nengard/kohaclone/Koha/List/Patron.pm
line 32.
BEGIN failed--compilation aborted at
/home/nengard/kohaclone/Koha/List/Patron.pm line 32.
Compilation failed in require at /home/nengard/kohaclone/patron_lists/lists.pl
line 26.
BEGIN failed--compilation aborted at
/home/nengard/kohaclone/patron_lists/lists.pl line 26.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 03:38:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 01:38:42 +0000
Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still
	running
In-Reply-To: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10611-70-XAT44CnvD0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz
             Blocks|                            |11051

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 03:38:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 01:38:42 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-KtKUaMQBlT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10611

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 03:40:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 01:40:05 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-bq8IfxNQue@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

--- Comment #5 from Robin Sheat <robin at catalyst.net.nz> ---
Profiling shows a lot of time being spend doing DBI::ping. Bug 10611 has a
solution to this that ought to be under this umbrella too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 09:19:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 07:19:09 +0000
Subject: [Koha-bugs] [Bug 11057] New: Bootstrap theme: Don't hide language
 chooser below the fold
Message-ID: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

            Bug ID: 11057
           Summary: Bootstrap theme: Don't hide language chooser below the
                    fold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 10309

Created attachment 22008
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22008&action=edit
The chosen language is displayed above the other text in the language chooser

With the (beautiful!) new theme based on Bootstrap, even if there is not a lot
of stuff on the front page of the OPAC, the language chooser is hidden "below
the fold", so you have to scroll to see it. I needed to have it pointed out to
me by someone who was already aware of this, so I think there is a good chance
more people will be confused by it. 

Also, the chosen language is displayed a bit wonky, see attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 09:19:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 07:19:09 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-xaeE94lCLy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11057

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 10:45:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 08:45:49 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-C0QLaqVaHj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21974|0                           |1
        is obsolete|                            |

--- Comment #7 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22009
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22009&action=edit
Amended patch

Changed test to be definedness only so it meets the case Galen spotted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 10:46:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 08:46:47 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-D33xmtbpTl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

--- Comment #8 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Galen Charlton from comment #6)
> Comment on attachment 21974 [details] [review]
> Bug 10996 Allow numeric subfields to be stripped on export
> 
> Review of attachment 21974 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: tools/export.pl
> @@ +365,5 @@
> > +                            my $subfield = $2;
> > +
> > +                            # skip if this record doesn't have this field
> > +                            next if not defined $record->field($field);
> > +                            if ($subfield) {
> 
> This is not the right test -- consider somebody who wants to exclude a
> subfield $0 (zero) from export.

Amended patch to cover this case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 11:07:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 09:07:12 +0000
Subject: [Koha-bugs] [Bug 11058] New: Compile time warning issued by
	C4/Record.pm
Message-ID: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

            Bug ID: 11058
           Summary: Compile time warning issued by C4/Record.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Compile time warning in C4/Record.pm:
perl -wc C4/Record.pm 
"my" variable $stylesheet masks earlier declaration in same scope at
C4/Record.pm line 313.

similar with anything using C4::Record

there are two lexical variable $stylesheet in the same sub.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 11:16:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 09:16:40 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-7OwDOp6PNv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22010
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22010&action=edit
Proposed Patch

Simple renaming of second stylesheet variable.

To test
without the patch
perl -wc C4/Record.pm issues a warning
with the patch
perl -wc C4/Record.pm issues mo warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 11:47:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 09:47:24 +0000
Subject: [Koha-bugs] [Bug 11059] New: Not possible to sort staged dates in
	metric format
Message-ID: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

            Bug ID: 11059
           Summary: Not possible to sort staged dates in metric format
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: koha at univ-lyon3.fr
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22011
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22011&action=edit
Not possible to sort staged dates in metric format

In 'Add order to basket' page, when importing from staged file, it was not
possible to sort the dates if the metric format is used.
The reason is that dt_add_type_uk_date function and call to it were missing.
I set no default sorting in datatable parameters. Anyhow the sorting is made on
staged date desc by perl and I suppose it's what users are expecting ?
I suppressed a split of timestamp data in addorderiso2709.pl because it seems
to me that it's useless (but not sure of it.)

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 11:47:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 09:47:39 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-Ydlxcuvpor@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |koha at univ-lyon3.fr

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 11:51:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 09:51:50 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-3jEjkQFR0m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22011|0                           |1
        is obsolete|                            |

--- Comment #1 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 22012
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22012&action=edit
Bug 11059 not possible to sort staged dates in metric format

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 12:25:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 10:25:47 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-Kb6KoBKqDj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22013
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22013&action=edit
[SIGNED OFF] Bug 11058: make variable name unique within its scope

routine declares two lexical variables named $stylesheet
rename the second to keep code clearer and
avoid propagating compile time warnings

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 12:31:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 10:31:55 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-D3DHhjM0ho@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22010|0                           |1
        is obsolete|                            |
                 CC|                            |mtompset at hotmail.com

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 22010
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22010
Proposed Patch

This is now obsolete.

mtompset at ubuntu:~/kohaclone$ git checkout -b bug_11058 origin/master
Branch bug_11058 set up to track remote branch master from origin.
Switched to a new branch 'bug_11058'

1) Confirmed Problem.
mtompset at ubuntu:~/kohaclone$ perl -wc C4/Record.pm
"my" variable $stylesheet masks earlier declaration in same scope at
C4/Record.p                                                                    
        m line 313.
C4/Record.pm syntax OK

2) Looked at code:
mtompset at ubuntu:~/kohaclone$ vi C4/Record.pm
The code has a parameter passed named stylesheet, and a variable declared
stylesheet. The parameter is used to set other variables which feed into this
secondary declaration. So, renaming this variable is a good solution and should
not cause any problems.

3) Applied patch
mtompset at ubuntu:~/kohaclone$ git bz apply 11058
Bug 11058 - Compile time warning issued by C4/Record.pm

22010 - Proposed Patch

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11058: make variable name unique within its scope

4) Confirmed problem solved.
mtompset at ubuntu:~/kohaclone$ perl -wc C4/Record.pm
C4/Record.pm syntax OK

5) Decided to run koha-qa.pl on it for kicks.
mtompset at ubuntu:~/kohaclone$ ~/qa-test-tools/koha-qa.pl -v 2 -c 1
testing 1 commit(s) (applied to 0f5dc60 'Bug 10309: (follow-up) restore
settin')

 OK     C4/Record.pm
   OK     pod
   OK     forbidden patterns
   OK     valid
                0
   OK     critic

6) Signed it off.
mtompset at ubuntu:~/kohaclone$ git so 1
Rewrite f1111fff1071b4a14251d5ecd80bfad07f567e4b (1/1)
Ref 'refs/heads/bug_11058' was rewritten
mtompset at ubuntu:~/kohaclone$ git commit --amend
[bug_11058 72c273c] [SIGNED OFF] Bug 11058: make variable name unique within
its                                                                            
 scope
 Author: Colin Campbell <colin.campbell at ptfs-europe.com>
 1 file changed, 3 insertions(+), 3 deletions(-)

7) Attached it.
mtompset at ubuntu:~/kohaclone$ git bz attach 11058 HEAD
Bug 11058 - Compile time warning issued by C4/Record.pm

72c273c [SIGNED OFF] Bug 11058: make variable name unique within its scope

Attach? [yn] y
Attached SIGNED-OFF-Bug-11058-make-variable-name-unique-wit.patch

8) And now obsolete the old one, and make sure the status is right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 12:32:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 10:32:07 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-GSkXOTrm5z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:08:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:08:59 +0000
Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
In-Reply-To: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9312-70-87GXOx4MVC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

--- Comment #29 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Fridolyn SOMERS from comment #28)
> What is missing to pass QA ?
Please see comment 26

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:28:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:28:25 +0000
Subject: [Koha-bugs] [Bug 11060] New: Bootstrap theme: Incorrect rendering
 for R2L languages
Message-ID: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

            Bug ID: 11060
           Summary: Bootstrap theme: Incorrect rendering for R2L languages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22014
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22014&action=edit
opac-bootstrap-l2r

New bootstrap theme do not render correctly for R2L languages like Arabic.

Good: Search bar

Not good: Advance search, auth search etc, are rendered correctly but there is
too much space from the right

Bad: Top (black) bar, Main result box, language chooser (hidden below as noted
on Bug 11057)

Attached bootstrap screen capture and ccsr for comaparison.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:28:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:28:58 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
	R2L languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-fwZLk3qdCt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22015
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22015&action=edit
opac-ccsr-l2r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:30:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:30:27 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
	R2L languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-ZKxZVnXCOl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10309

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:30:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:30:27 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-ziUQtBQg24@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11060

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:43:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:43:20 +0000
Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
In-Reply-To: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9312-70-dEXbYzOQXL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #30 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Comment 27 is misleading you cant use a string as a hash_ref in any release of
perl.

A variable called $results suggests theres a bit of confusion here. Meaningless
variable names should be avoided, and we should be more explicit as to what we
are testing.

Another reason for failing QA is that a lexical dirhandle is replaced by the
global DIR. That's surely a backward move

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:54:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:54:51 +0000
Subject: [Koha-bugs] [Bug 11061] New: Koha::Calendar::_mock_init is unused
Message-ID: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

            Bug ID: 11061
           Summary: Koha::Calendar::_mock_init is unused
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init
The routine can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:55:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:55:08 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-ohMu7dC8DL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #26 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22016
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22016&action=edit
Bug 7376 - Transfer limits should be checked at check-in

Extended UseBranchTransferLimits-check to the check-in case.
Made it possible to override the check-in with circulation-permission if
BranchTransfer is denied.
Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t

*Also added override-functionality to Circulation::AddReturn() to override
BranchTransferLimits. (+unit tests)
*Renamed CanBookBeReturned to CanItemBeReturned since that function was
referenced from AddReturn only.
--This is because function name misguidingly references to a
book/Biblio/Title-level, even if the functionality is strictly
--Item dependent.
*Removed duplicating code by making CheckBranchTransferAllowed() call
IsBranchTransferAllowed().
*Made a unit test library out of CheckBranchTransferAllowed.t's environment
initialization parts,
  so these need not be duplicated whenever UseBranchTransferLimits-related
functionality is tested.
*Documented SIP-testing hardships to C4/SIP/README

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:56:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:56:05 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-LWX6T37b8y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21715|0                           |1
        is obsolete|                            |
  Attachment #21805|0                           |1
        is obsolete|                            |

--- Comment #27 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22017
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22017&action=edit
Manual test cases

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:56:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:56:35 +0000
Subject: [Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
In-Reply-To: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11061-70-KWebx5z031@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22018
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22018&action=edit
Bug 11061: Koha::Calendar::_mock_init is unused

Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init
The routine can be removed.

Test plan:
prove t/Calendar.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:56:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:56:52 +0000
Subject: [Koha-bugs] [Bug 9209] Mocked Koha::Calendar tests
In-Reply-To: <bug-9209-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9209-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9209-70-DPjXRmL2IM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9209

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11061

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 13:56:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 11:56:52 +0000
Subject: [Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
In-Reply-To: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11061-70-4CW3HULPfz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch
         Depends on|                            |9209
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 14:03:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 12:03:29 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-I25kIz19Kn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

--- Comment #7 from Paola Rossi <paola.rossi at cineca.it> ---
The applying (against master 031) of the patch is OK.
I've created some invoices for subscriptions' orders and some invoices not.
When the checkbox "Show only subscriptions" is not checked, the patch works
well and all the invoices are shown in the invoices table.
On the contrary, when the checkbox "Show only subscriptions" is checked, no
invoice is shown in the invoices table.
Is it OK?
This is the part of the patch about selecting only subscription' invoices:
resultst.fnFilter( "[0-9]+", 0, true )
Can I create the situation with "[0-9+]" and see the list of the subscriptions'
invoices shown? Thanks.
When I see an invoice (from column "Invoice no." of the invoices table) and the
invoice is not a subscription' one, I see "Invoice details" with a following
table full of dates ("Summary" "Publisher" etc).
When I see an invoice (from column "Invoice no." of the invoices table) and the
invoice is a subscription' one, I see "Invoice details" followed by "No orders
yet". On the contrary the order is present in bd: it is listed by
Orders-search' results table of Acquisitions, and is linked to the subscripted
serial.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:45:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:45:25 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-edpwmuSmYS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22019
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22019&action=edit
Bug 8074 - Define default library for holds to pull report

Modified the BIG SQL in pendingreserves.pl to limit the hold requests shown
by the items.holdingbranch. The behaviour mimics IndependentBranches behaviour.

Also added a branch picker to circ/pendingreserves.tt with an optional
Show all requests-option.
Changed the form from post to get so librarians can bookmark the page.

Made stuff localizable!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:52:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:52:56 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-76gaKWPXrN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
xxxxxxxxxxxxxxxxxxxxxx
xxxxx TEST CASES xxxxx
xxxxxxxxxxxxxxxxxxxxxx

No prerequisites

By default the requested list is calculated based on the current staff client
branch set. (Circulation -> Set Library)

xxxxxxxxxxxxxxxxxxxxxx

cgi-bin/koha/circ/pendingreserves.pl

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

TEST CASE1:

1. Change branch limiter from the select-list.
2. Clear the date fields, "Start date" and "End date".
3. Press "Submit".
4. Enjoy!
5. Bookmark the url. If Date-fields are empty, defaults are calculated and url
can be reused on some future day.

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

TEST CASE2:

1. Select the "Show all requests".
2. Submit.
3. Behold all holds pull requests across all branches.

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:53:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:53:08 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-2KMWlXRPgM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|fridolyn.somers at biblibre.co |olli-antti.kivilahti at jns.fi
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:53:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:53:30 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-wFIdQ9abZ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:53:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:53:46 +0000
Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet
 special library needs
In-Reply-To: <bug-9721-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9721-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9721-70-b9tFJCDwBy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:55:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:55:19 +0000
Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet
 special library needs
In-Reply-To: <bug-9721-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9721-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9721-70-oH5pweoiXT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Not sponsored! I made an error since bugzilla throws me to another bug every
time I make changes to existing bugs and that is distracting!
Can delete this comment and my previous one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 16:57:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 14:57:05 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-G8cz7ZMscS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional library.

Sorry for stealing this bug, but it was so easy to fix and our librarian is
complaining about this issue, so I needed to get it solved asap to convince our
team that Koha is superior! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 17:07:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 15:07:59 +0000
Subject: [Koha-bugs] [Bug 9721] Umbrella report for hold changes to meet
 special library needs
In-Reply-To: <bug-9721-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9721-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9721-70-gdQ9uFNM5S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9721

--- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Olli-Antti Kivilahti from comment #7)
> Not sponsored! I made an error since bugzilla throws me to another bug every
> time I make changes to existing bugs and that is distracting!
> Can delete this comment and my previous one.

No, that is not possible. So be very careful :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 19:08:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 17:08:46 +0000
Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not
	Plack-compatible
In-Reply-To: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9224-70-qx6cpO6EaY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |abl at biblos.pk.edu.pl
           Assignee|koha-bugs at lists.koha-commun |abl at biblos.pk.edu.pl
                   |ity.org                     |

--- Comment #1 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Created attachment 22020
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22020&action=edit
[PATCH] Bug 9224: Make acqui/finishreceive.pl Plack-compatible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 19:10:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 17:10:43 +0000
Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not
	Plack-compatible
In-Reply-To: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9224-70-sWUjAsGNFH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224

--- Comment #2 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
Under Plack/mod_perl wrapping, sub update_item() will become a closure,
so after the 1st run it will retain it's own private instances of the
following variables: $booksellerid, $datereceived, $unitprice, $rrp,
$biblionumber.
I.e., in case update_item() gets invoked 2nd+ time (inside
the same process, but for different-subsequent receives) it may
incorrectly flag the (old, wrong) biblionumber for Zebra reindexing,
and erronously modify the current item[s] with the previously
used (wrong) values.

This simple patch should make acqui/finishreceive.pl Plack-compatible.

Test plan:
Test patched acqui/finishreceive.pl script (create and receive some
orders w/ items, etc.). Ensure items are gettting added and/or modified
correctly during receiving process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 19:15:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 17:15:24 +0000
Subject: [Koha-bugs] [Bug 11062] New: Invoice's shipment/shipping cost
 should be included PRE-gst tax (as an option)
Message-ID: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062

            Bug ID: 11062
           Summary: Invoice's shipment/shipping cost should  be included
                    PRE-gst tax (as an option)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Here in Canada, invoices items should be included in the following order:

Price
Shipment
Taxes
Subtotal
Total

At least, as an option.  Right now, our library gets the wrong Total since
shipping is added to the subtotal, not including the taxes.

I looked for preferences, but the code seemed very clear in acqui/invoice.pl:

my $total_gsti_shipment = $total_est_gsti + $details->{shipmentcost};

Unless a nice solution already exists, I think this ordering should be
customizable.  

Comments and input (on what else should be affected) are very welcomed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 19:16:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 17:16:25 +0000
Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be
 included PRE-gst tax (as an option)
In-Reply-To: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11062-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11062-70-zqo45Q0fuO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 19:25:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 17:25:22 +0000
Subject: [Koha-bugs] [Bug 11063] New: Add circulation message's patron when
 checkin items (returns.pl)
Message-ID: <bug-11063-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11063

            Bug ID: 11063
           Summary: Add circulation message's patron when checkin items
                    (returns.pl)
 Change sponsored?: ---
           Product: Koha
           Version: 3.8
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at ccsr.qc.ca
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Hi,
It would be nice to see on return page if a patron has a circulation message.

Thanks

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 21:48:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 19:48:10 +0000
Subject: [Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
In-Reply-To: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9312-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9312-70-2YCNgPngcW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312

--- Comment #31 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
Yes, sorry I misread the comment, I thought it was about if(%hash) vs if( keys
%hash)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 23:07:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 21:07:05 +0000
Subject: [Koha-bugs] [Bug 7214] can't change framework when editing record
	as duplicate
In-Reply-To: <bug-7214-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7214-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7214-70-Znc0qSCJqF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7214

--- Comment #2 from Nicole C. Engard <nengard at gmail.com> ---
This is an issue that came up at KohaCon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 23:37:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 21:37:37 +0000
Subject: [Koha-bugs] [Bug 11064] New: batch import ignoring framework choice
Message-ID: <bug-11064-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064

            Bug ID: 11064
           Summary: batch import ignoring framework choice
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When importing batches of bib records if you choose a framework and no matter
what you choose it imports as default. Your choice is ignored.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 16 23:43:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 21:43:24 +0000
Subject: [Koha-bugs] [Bug 10906] Reimported records into Koha are imported
 only as DEFAULT frameworks, not what they were originally
In-Reply-To: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10906-70-OsQYIRd2Wa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10906

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
I want to add to this that the problem is also a language issue - the text says
"Add new bibliographic records into this framework" but the records in question
aren't 'new' so that's where part of the confusion occurs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 00:02:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 22:02:17 +0000
Subject: [Koha-bugs] [Bug 11065] New: List of imported biblios is too small
 - increase to a larger number
Message-ID: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11065

            Bug ID: 11065
           Summary: List of imported biblios is too small - increase to a
                    larger number
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: dpk at randomnotes.org
        QA Contact: testopia at bugs.koha-community.org

Usability fix to MARC importing:

When importing biblios using the MARC importing tools, the list of imported
MARC records are display in pages of 25 biblios each.  This means on larger
imports (100s or 1000s of biblios) you have to page through way too many pages
to find import issues.  This process can be facilitated by returning much
larger lists.  We have changed this to 500 entries and its much easier to work
with large imports with this size of returned results.

Steps to reproduce:
1. Create a MARC import file with 1000 unique MARC records
2. Upload the file
3. Import the file to the reservoir.
4. You are now looking at the import results page displayed by
manage-marc-import.pl with 25 results displayed, and a total of 40 pages to
view to see all the import success/failures.

Desired
Reviewing all these pages is tedious.  Less pages will be much better.

Fixing this is a one line change to 
library:/usr/share/koha/intranet/cgi-bin/tools# diff
tools/manage-marc-import.pl*
50c52
< my $results_per_page = $input->param('results_per_page') || 25; 
---
> my $results_per_page = $input->param('results_per_page') || 500;

(This was also the consensus of the Cataloging roundtable at KohaCon2013.  I
volunteered to submit the bug and a formal fix.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 00:40:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 22:40:21 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-Mz5xOkHbek@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22021
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22021&action=edit
[PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it


This patch make possible to view an individual closed basketgroup without
reopening it.
- It adds a new "View" button on closed basketgroup list
- It creates a view for closed basketgroups, with 3 buttons (reopen, print,
export)
- It adds a "delete" button on standard "edit" view (for open basketgroup)

To test :
1/ regression test :
- create some empty basketgroups
- create some basketgroups by closing baskets
- in the list of basketgroups closed and opened, check you can use the buttons
that existed before the patch (close and print, delete, export, print, reopen)
- click on "Edit" to edit a opened basketgroup : check everything is like
before :
-- change the billing and delivery places,
-- add a note,
-- put some new baskets  in the bg,
-- remove baskets from it
-- save it without checking "close" box => it must be save but kept open
-- edit it again, and make other some changes (define a free delivery place for
example)
-- save it with checking "close" => it must be saved but closed

2/ new feature test
- click on "view" button on top right column of some closed basketgroup
- check all the displayed informations are correct (places, free place, note,
list of baskets)
- check you can not change anything
- click on "print" button => check a pdf is created
- click on "export" button => check a csv is created
- click on "reopen" button => you must stay on the same basketgroup, but it is
now open and you can make some changes
- go back to the basketgroup list of the vendor. Check the reopened bg is in
"open" tab
- click on "edit"
- click on new "delete" button => the bg must be deleted, and you are
redirected to the bg list of the vendor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 00:40:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 22:40:31 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-4Ln2a03NOD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 00:42:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 22:42:05 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-PQMlKR5wUg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 01:13:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 16 Oct 2013 23:13:17 +0000
Subject: [Koha-bugs] [Bug 11066] New: Export Citations not RDA compatible
Message-ID: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066

            Bug ID: 11066
           Summary: Export Citations not RDA compatible
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: joy at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Exporting citations does not include the 264 tag for publisher information.  

Bibtex uses 260 tag, subfields $a address, $c Year, $b Publisher $f Editor

Endnote uses 206$a City 260$c Year 710$a Publisher

RIS uses 260 for publisher data.

For Marc records that are RDA records, the publisher information is contained
in the 264 tag.    Can we update the export parameters to pull from the 264
and/or the 260?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 07:59:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 05:59:39 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-5I8gxHGnXH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 08:09:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 06:09:09 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9532-70-rzHQ00mTl2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 08:10:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 06:10:37 +0000
Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not
	Plack-compatible
In-Reply-To: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9224-70-r2qbCXxrcj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 08:55:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 06:55:03 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-YNiSHuNnb3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #131 from Pierre Angot <tredok.pierre at gmail.com> ---
Can you push this patch ?

We are waiting it to test 8230.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:14:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:14:13 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-jPGvwIG7Xv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by cedric.vita at dracenie.com
<cedric.vita at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:14:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:14:32 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-grpEG99z2O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21492|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:14:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:14:38 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-avjqMc3IiA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22022
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22022&action=edit
Bug 10954 - Payment receipt does not display the payment made

When printing a payment receipt, the payment does not display, only the
total currently owed.

Test Plan:
1) Create a payment for a borrower
2) Print the payment with the "print" button to the right of the payment
3) Note the missing payment line
4) Apply this patch
5) Repeat step 2
6) Note the payment line now displays

Signed-off-by: cedric.vita at dracenie.com <cedric.vita at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:38:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:38:20 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-x9CEPqQnJV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Next step for improving basketgroup management will be Bug 10919

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:40:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:40:09 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-KW8iQfCbrK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to mathieu saby from comment #3)
> Next step for improving basketgroup management will be Bug 10919
> 
> M. Saby

And make links from other pages (orders, baskets...) to a specific basket group
when it is needed (it was not possible before this patch, because it reopened
automatically the basketgroup...)

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:46:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:46:50 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-dzQTFxlLl5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #26 from Pierre Angot <tredok.pierre at gmail.com> ---
I think there is a problem when your items are created when placing an order.
I've suppressed item associated to record A. There is no message which warn you
that this items is used in an order.

It's a big problem. When AcqCreateItem is "when placing an order", if you
suppress the item, you cannot add a new one to the order. You must delete the
order or create a new one.
It will be good if there is a new condition linked to this syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 09:57:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 07:57:45 +0000
Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2
In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10988-70-ib4lrqlSi3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

--- Comment #5 from Nicholas van Oudtshoorn <vanoudt at gmail.com> ---
When using this in a public computer, there are some nice javascripts that can
be injected to make this a whole lot more secure. Basically, the following
userscripts disable the google account chooser, and log a person out of their
google accounts when they log out of Koha. This is not very useful or polite
outside of a public terminal, hence my thinking to do it with userscripts.

Just putting it here as a reference for anyone thinking to use this.

--------------------------------------------------------------------------------
// ==UserScript==
// @id             accounts.google.com-forcenocookie at scriptish
// @name           Disable persistent google login
// @version        1.0
// @namespace      
// @author         
// @description    
// @include        https://accounts.google.com/*
// @run-at         document-end
// ==/UserScript==
document.getElementsByName("PersistentCookie")[0].value='no';

--------------------------------------------------------------------------------
// ==UserScript==
// @id             koha-full-oauth2-logout at scriptish
// @name           Force Full Logout
// @version        1.0
// @namespace
// @author
// @description
// @include        http://OPACURLHERE/*
// @run-at         document-end
// ==/UserScript==
document.getElementById('logoutmenu').href="https://www.google.com/accounts/Logout?continue=https://appengine.google.com/_ah/logout?continue="+document.getElementById('logoutmenu').href;
document.getElementById('logout').href="https://www.google.com/accounts/Logout?continue=https://appengine.google.com/_ah/logout?continue="+document.getElementById('logoutmenu').href;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 10:20:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 08:20:26 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-PVh4EnQfrp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #27 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Indeed, I did not try to use the patch with items created when placing an
order.
So there can be an issue with this pref.
I put it in Failed QA and will take a look at it later.

Thank you for testing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 10:53:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 08:53:13 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-V8OGmX3kj4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by cedric.vita at dracenie.com
<cedric.vita at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 10:53:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 08:53:26 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-vAX97Nl3j4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22021|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 10:53:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 08:53:32 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-oo5Jncgd2Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22023
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22023&action=edit
Bug 9807 : Make possible to view a basketgroup without reopening it

This patch make possible to view an individual closed basketgroup without
reopening it.
- It adds a new "View" button on closed basketgroup list
- It creates a view for closed basketgroups, with 3 buttons (reopen, print,
export)
- It adds a "delete" button on standard "edit" view (for open basketgroup)

To test :
1/ regression test :
- create some empty basketgroups
- create some basketgroups by closing baskets
- in the list of basketgroups closed and opened, check you can use the buttons
that existed before the patch (close and print, delete, export, print, reopen)
- click on "Edit" to edit a opened basketgroup : check everything is like
before :
-- change the billing and delivery places,
-- add a note,
-- put some new baskets  in the bg,
-- remove baskets from it
-- save it without checking "close" box => it must be save but kept open
-- edit it again, and make other some changes (define a free delivery place for
example)
-- save it with checking "close" => it must be saved but closed

2/ new feature test
- click on "view" button on top right column of some closed basketgroup
- check all the displayed informations are correct (places, free place, note,
list of baskets)
- check you can not change anything
- click on "print" button => check a pdf is created
- click on "export" button => check a csv is created
- click on "reopen" button => you must stay on the same basketgroup, but it is
now open and you can make some changes
- go back to the basketgroup list of the vendor. Check the reopened bg is in
"open" tab
- click on "edit"
- click on new "delete" button => the bg must be deleted, and you are
redirected to the bg list of the vendor.

Signed-off-by: cedric.vita at dracenie.com <cedric.vita at dracenie.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:10:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:10:35 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-tyLPWP2qIr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #24 from Pierre Angot <tredok.pierre at gmail.com> ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 7791:
<h1>Something went wrong !</h1>Applying: Bug 7791 : Give the ability to delete
records when deleting a basket
Applying: Bug 7791 Followup: delete warns, add missing curly braket and make a
simpler message if basket is void
Applying: Bug 7791 Followup: add warning after deletion if some records were
not deleted
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 7791 Followup: add warning after deletion if some
records were not deleted
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 7791 - Deleting basket should not delete all existing orders without
warning

21245 - Bug 7791 : Give the ability to delete records when deleting a basket
21246 - Bug 7791 Followup: delete warns, add missing curly braket and make a
simpler message if basket is void
21969 - [PATCH 3/3] Bug 7791 Followup: add warning after deletion if some
records were not deleted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:20:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:20:55 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-KpGS7ASjvn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #65 from cedric.vita at dracenie.com ---
Mail when the application sandbox

The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 9811:
<h1>Something went wrong !</h1>Applying: Bug 9811: Patron search improvement
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Members.pm
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
Auto-merging members/member.pl
CONFLICT (content): Merge conflict in members/member.pl
Auto-merging members/moremember.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 9811: Patron search improvement
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 9811 - Patrons search improvements

21169 - Bug 9811: Patron search improvement
21170 - Bug 9811: Add unit tests for C4::Utils::DT::Members
21171 - Bug 9811: QA followup
21172 - Bug 9811 - multilines notes brakes JSON
21173 - Bug 9811: use count(primary_key) instead of count(*)
21174 - Bug 9811: A limit clause should be always added.
21175 - Bug 9811: Load the page without any data.

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-9811-Patron-search-improvement-zsuviY.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:24:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:24:42 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-4liitQTGkc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #25 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Same error Jonathan pointed out.
I regenerated the patch and it applies cleany on my machine (using git am -3iu)
Sorry, I don't understand this sha1 issue, and can't resolve it :(

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:25:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:25:41 +0000
Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of
 a basketgroup without reopening it
In-Reply-To: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9807-70-2ubrdvkfqI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Thank you Pierre and Cedric!

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:27:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:27:50 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-CvsFNmub01@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I could mabye try to merge the 3 patches, maybe it will resolve the issue. But
I would not prefer, as the first 2 patches were already signed off, and not the
3rd...

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:38:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:38:14 +0000
Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials
	search
In-Reply-To: <bug-10809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10809-70-pIG2Xpk0K6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:38:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:38:30 +0000
Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials
	search
In-Reply-To: <bug-10809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10809-70-ujc8okKPJo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22024
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22024&action=edit
Bug 10809 - use template branches plugin in serials search

In serials-search.pl, branch name is computed using branch code and then passed
to template.

This patch uses the new template plugin now for this :
Koha::Template::Plugin::Branches.

Test plan :
- Go to serials search
- Perform a search that returns at least an open an a closed subscription
having a branch defined
=> The branch name is displayed in "Library" column

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:38:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:38:25 +0000
Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials
	search
In-Reply-To: <bug-10809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10809-70-D6iWJN0fiA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20739|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:44:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:44:41 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-jWn8BEHq5C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

cedric.vita at dracenie.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cedric.vita at dracenie.com

--- Comment #4 from cedric.vita at dracenie.com ---
After applying the patch :

http://pro.test1.biblibre.com/cgi-bin/koha/members/member.pl

Software error:

Base class package "DBIx::Class::Schema" is empty.
    (Perhaps you need to 'use' the module which defines that package first,
    or make that module available in @INC (@INC contains: /home/koha/src
/etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1
/usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10
/usr/local/lib/site_perl .).
 at /home/koha/src/Koha/Schema.pm line 10
BEGIN failed--compilation aborted at /home/koha/src/Koha/Schema.pm line 10.
Compilation failed in require at /home/koha/src/Koha/Database.pm line 38.
BEGIN failed--compilation aborted at /home/koha/src/Koha/Database.pm line 38.
Compilation failed in require at /home/koha/src/Koha/List/Patron.pm line 32.
BEGIN failed--compilation aborted at /home/koha/src/Koha/List/Patron.pm line
32.
Compilation failed in require at /home/koha/src/members/member.pl line 35.
BEGIN failed--compilation aborted at /home/koha/src/members/member.pl line 35.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 11:47:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 09:47:56 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-YNDW6Z3x3c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

cedric.vita at dracenie.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 13:17:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 11:17:08 +0000
Subject: [Koha-bugs] [Bug 11067] New: In serial home instead of 'Advanced
 search' on sx column it is better 'Filters on search results'
Message-ID: <bug-11067-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11067

            Bug ID: 11067
           Summary: In serial home instead of 'Advanced search' on sx
                    column it is better 'Filters on search results'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: z.tajoli at cineca.it
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Created attachment 22025
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22025&action=edit
image of serial home

In serial home (cgi-bin/koha/serials/serials-home.pl) there is a link 'Advanced
search' on the sx column, over 'Claims' and 'Check expiration'.

But it doens't do a search on zebra or on mysql.
It is a js filter that works only on results of a previous search.

To use it you need:
-- Do a search with one ot the two instrument on the top
-- Open the box and insert a filter on results.

So I suggesto to change the string from 'Advanced search' to 'Filters on search
results'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 13:17:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 11:17:50 +0000
Subject: [Koha-bugs] [Bug 11067] In serial home instead of 'Advanced search'
 on sx column it is better 'Filters on search results'
In-Reply-To: <bug-11067-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11067-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11067-70-srWoQH3VHC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11067

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 15:01:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 13:01:19 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-PMscJaIlPk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to cedric.vita from comment #4)
> After applying the patch :
> Base class package "DBIx::Class::Schema" is empty.
This is because the DBIx::Class::Schema::Loarder, package
libdbix-class-schema-loader-perl must be installed.
I have installed it on all sandboxes.
Please retest.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 15:05:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 13:05:00 +0000
Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio
In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9532-70-3PbFJlxcNz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532

--- Comment #12 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Those patches are waiting to be pushed into master.
Is there a something blocking ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 15:07:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 13:07:52 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-v8a2YTBK5G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

--- Comment #6 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Olli-Antti Kivilahti from comment #5)
> Sorry for stealing this bug
Your welcome. Who provides a patch as priority ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:11:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:11:44 +0000
Subject: [Koha-bugs] [Bug 11068] New: Update MARC21 es-ES default frameworks
 fields and translation
Message-ID: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

            Bug ID: 11068
           Summary: Update MARC21 es-ES default frameworks fields and
                    translation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

es-ES MARC21 bibliographic and authorities need to be updated and translated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:12:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:12:01 +0000
Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks
 fields and translation
In-Reply-To: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11068-70-NnxwhCZCaf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:20:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:20:05 +0000
Subject: [Koha-bugs] [Bug 11069] New: increase title ranking in relevance
 when using QueryWeightFields
Message-ID: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

            Bug ID: 11069
           Summary: increase title ranking in relevance when using
                    QueryWeightFields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

when using QueryWeightFields to add ranking on a search without index, the
search actually uses: 
 - rank 1 : Title-cover,ext :  exact title-cover
 - rank 2 : ti,ext : exact title
 - rank 3 : Title-cover,phr : phrase title-cover
 - rank >7 : queries without index
This relevance sets title as phrase in priority and then any index.
I propose to add title as words list before search on any index, so that
records with all searched terms in title, even not well ordered, are more
relevant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:33:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:33:09 +0000
Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks
 fields and translation
In-Reply-To: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11068-70-FFrCpm1UZb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22026
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22026&action=edit
Bug 11068 - 1/2 - Update MARC21 es-ES default frameworks fields and translation

This patch updates es-ES MARC21 default bibliographic framework.
It updates fields/subfields and update translation

Version used is master + Bug 10962

Only to new installs

Test
1) remove default MARC21 framework
2) load new file marc21_framework_DEFAULT.sql
3) Check that load without errors
4) Is a direct translation of EN file, chech line count is equal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:34:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:34:16 +0000
Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks
 fields and translation
In-Reply-To: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11068-70-vbdvCDrY6w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22027
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22027&action=edit
Bug 11068 - 2/2 - Update MARC21 es-ES default frameworks fields and translation

This patch updates es-ES authority frameworks.
Updates fields/subfields and also update translation

Version used is master + Bug 10962

Only to new installs

Test
1) remove MARC21 authority framework
2) load new file authorities_normal_marc21.sql
3) Check that load without errors
4) Is a direct translation of EN file, chech line count is equal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:34:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:34:39 +0000
Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when
 using QueryWeightFields
In-Reply-To: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11069-70-60ist99Cmj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22028
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22028&action=edit
Bug 11069 - increase title ranking in relevance when using QueryWeightFields

See commit message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:45:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:45:23 +0000
Subject: [Koha-bugs] [Bug 11070] New: typo in UNIMARC 115a plugin
Message-ID: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

            Bug ID: 11070
           Summary: typo in UNIMARC 115a plugin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In UNIMARC 115a cataloging plugin, there is a typo : "NTSC", not "NSTC" : 
http://fr.wikipedia.org/wiki/Ntsc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:46:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:46:52 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-HjS63PFxxt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22029
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22029&action=edit
Bug 11070 - typo in UNIMARC 115a plugin

See commit message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:46:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:46:58 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-4yKUQJ50x0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 16:47:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 14:47:11 +0000
Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when
 using QueryWeightFields
In-Reply-To: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11069-70-7LmDTAdarq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 17:11:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 15:11:59 +0000
Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21)
	(GRS1+DOM)
In-Reply-To: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9972-70-g8NVLyWdug@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #17 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 22030
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22030&action=edit
Bug 9972 Add/ change some zebra indexes (MARC21)

This patch adds :w and :p versions to the index for ?Lexile number? (it has
only :n so far) and adds indexes for 653 (Index term uncontrolled), 655 (Index
term Genre/Form), 041 (language-audio) and 041 (language-subtitle). It also
adds the ?curriculum?-index to Search.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 17:13:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 15:13:11 +0000
Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21)
	(GRS1+DOM)
In-Reply-To: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9972-70-aHyahcqd5l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

Mirko Tietgen <mirko at abunchofthings.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21234|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 17:14:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 15:14:08 +0000
Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21)
	(GRS1+DOM)
In-Reply-To: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9972-70-CVP9RPKprS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

--- Comment #18 from Mirko Tietgen <mirko at abunchofthings.net> ---
To test:

1) Apply patch.
2) Create test DB (cf. INSTALL.debian, change <user> and <pass>)
mysqladmin -uroot -p<pass> create bug9972
mysql -uroot -p<pass>
grant all on bug9972.* to '<user>'@'localhost' identified by '<pass>';
flush privileges;
3) Run Makefile.PL, choose some local path for test installation, choose GRS-1
for biblio indexing.
4) Run make, make install.
5) symlink /etc/instancename/koha-httpd.conf to
/etc/apache2/sites-available/instancename, a2ensite instancename. disable other
koha instance if neccessary, 
5) Run webinstaller.
6) Catalogue a record with data in
-- 041$a (eg audio)
-- 041$j (eg subtitle)
-- 521$a (eg fivetwoone)
-- 653$a (eg sixfivethree)
-- 655$a (eg sixfivefive)
-- 658$a (eg sixfiveeight)
7) Reindex. Also check if zebrasrv for that instance is running, mine wasn't.
8) Try searches, change q= at the end to match your test record data.
http://YourOPAC/opac-search.pl?idx=ln-audio&q=audio
http://YourOPAC/opac-search.pl?idx=ln-subtitle&q=subtitle
http://YourOPAC/opac-search.pl?idx=lex&q=fivetwoone
http://YourOPAC/opac-search.pl?idx=Index-term-genre&q=sixfivefive
http://YourOPAC/opac-search.pl?idx=Index-term-uncontrolled&q=sixfivethree
http://YourOPAC/opac-search.pl?idx=curriculum&q=sixfiveeight
You should reach the correct record with each search.
9) Run Makefile.PL, choose the same local path as last time, choose DOM for
biblio indexing.
10) Run make, make install.
11) Reindex.
12) Try searches described in 8 again. You should find your test record for all
queries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 17:32:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 15:32:41 +0000
Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra
In-Reply-To: <bug-10482-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10482-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10482-70-d5QkYQxayS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7986

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 17:32:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 15:32:41 +0000
Subject: [Koha-bugs] [Bug 7986] Export issues
In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7986-70-NhSf1NEllW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10482

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 17:58:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 15:58:12 +0000
Subject: [Koha-bugs] [Bug 9975] tracking branches in fines better
In-Reply-To: <bug-9975-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9975-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9975-70-oF2C7PyfM1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9975

Cab Vinton <bibliwho at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:20:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:20:28 +0000
Subject: [Koha-bugs] [Bug 11071] New: RDA Helper
Message-ID: <bug-11071-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11071

            Bug ID: 11071
           Summary: RDA Helper
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It would be great to have an RDA Helper like MarcEdit has (which is not open
source - http://marcedit.reeset.net/features) built in to Koha so that you can
easily add RDA fields to your MARC record with the click of a button or via a
batch biblio modification tool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:22:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:22:42 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-8GkaTgnvq4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20283|0                           |1
        is obsolete|                            |

--- Comment #5 from Amit <amitddng135 at gmail.com> ---
Created attachment 22031
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22031&action=edit
Bug-4456-Enable-addition-of-PO-Number-to-order

Enable addition of PO Number to order

The ability to have a running purchase order sequence

Test Plan:
1) Set systempreference EnablePONumber to Enable for auto generating purchase
order number.
2) Select prefix for ex: Direct to requestor (Create PONUMPREFIX in authorized
value and insert values).
3) Create an basket.
4) Create an order.
5) Select prefix value for ex: Direct to requestor.
6) Purchase order number will come in purchase order section for ex:
DIR0000001.
7) Click on save button

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:23:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:23:27 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-93G9uJ39al@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

--- Comment #6 from Amit <amitddng135 at gmail.com> ---
Created attachment 22032
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22032&action=edit
Adding new table po_sequence

Adding new table po_sequence

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:23:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:23:37 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-VK8xcuE1x6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:26:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:26:15 +0000
Subject: [Koha-bugs] [Bug 11072] New: Add pagination to search results in
	staff client
Message-ID: <bug-11072-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11072

            Bug ID: 11072
           Summary: Add pagination to search results in staff client
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be nice to have the pagination show at the top of the search results
in the staff client like in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:27:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:27:05 +0000
Subject: [Koha-bugs] [Bug 11073] New: drag and drop subfields
Message-ID: <bug-11073-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11073

            Bug ID: 11073
           Summary: drag and drop subfields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

It would be nice in cataloging to be able to drag and drop subfields to where
we want them instead of using the arrows to the left of the subfield

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:27:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:27:58 +0000
Subject: [Koha-bugs] [Bug 11074] New: add checkboxes to frameworks
Message-ID: <bug-11074-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11074

            Bug ID: 11074
           Summary: add checkboxes to frameworks
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Would be nice to be able to batch delete fields and subfields from frameworks
with checkoxes or some sort of options.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:28:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:28:54 +0000
Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up
 the related invoice to see when the item was receipted
In-Reply-To: <bug-10424-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10424-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10424-70-hNsyKDNEry@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19955|0                           |1
        is obsolete|                            |

--- Comment #10 from Amit <amitddng135 at gmail.com> ---
Created attachment 22033
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22033&action=edit
Search Received order

Hi Katrin,

I have change the Licence.

Search against order numbers and pull up the related
invoice to see when the item was received.

This allows users to see details of received orders,
including the details against which invoice the order is
received.

Test Plan:
1) Create a basket.
2) Create a orders under basket and close the basket.
3) Click on Receive shipment button and enter the invoice no and
shipment date.
4) Click on Receive link to receive the items.
5) Click on Received orders link on the left hand side.
6) This allow user to search by orderline, basket, title, author,
ISBN, vendor and date received.
7) Users will be able to see details of received orders.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:29:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:29:13 +0000
Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up
 the related invoice to see when the item was receipted
In-Reply-To: <bug-10424-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10424-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10424-70-h73I30uLO3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:34:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:34:17 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-erQIDAzFbH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19213|0                           |1
        is obsolete|                            |
  Attachment #19214|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135 at gmail.com

--- Comment #4 from Amit <amitddng135 at gmail.com> ---
Created attachment 22034
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22034&action=edit
Bug-10477 Increased flexibility for upload of Staged

When uploading bulk MARC records against existing records need further
    option to allow the process to just add/merge extra MARC tags rather
    than having to completely overwrite an existing record or just leave
    the existing record unchanged.

    Test Plan:
    1. Click on Tools->Stage MARC records for import.
    2. Upload the MARC file for ex: first.mrc
    3. Click on upload button.
    4. Choose Record matching rule: 020$a ISBN.
    5. Choose Action if matching record found: Append or update MARC21/UNIMARC
    tag a text box will appear after choosing enter MARC tag for ex: 700a which
    you want to merge.
    6. Click on Stage for import button.
    7. On the next screen click on Manage staged records.
    8. You can also edit the record matching rule in manage record screen.
    9. Click on Import this batch on catalog button.
    10. Next screen will give no of record updated.
    11. It will check duplicate field record for ex: 700$aamit is already in
record
    it will skip the tag and move to next.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:39:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:39:34 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-iB5jRyZwIF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

--- Comment #5 from Amit <amitddng135 at gmail.com> ---
Created attachment 22035
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22035&action=edit
Alter table import_batches

Added overlay_action to "appendmarctag" and new column "marctag"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:39:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:39:43 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-cnCx27rsbW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:42:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:42:29 +0000
Subject: [Koha-bugs] [Bug 10498] Place Hold on Order
In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10498-70-Q1Ju2O3Nku@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19211|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135 at gmail.com

--- Comment #6 from Amit <amitddng135 at gmail.com> ---
Created attachment 22036
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22036&action=edit
Bug 10498 - Place Hold on Order

When creating an order, to have the option to place a hold against the ordered
item.

Test Plan:
1) Choose Systempreference AcqCreateItem to Create an item when placing an
order.
2) Create an order.
3) Click on Modify link.
4) Reserve for tab will come enter the patron cardnumber or name and click on
Place hold button.
5) Page will go to the request.pl and it will check the circulation rule.
6) Click on Place hold and return to order page.
7) It will redirect to the neworderempty.pl page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:42:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:42:37 +0000
Subject: [Koha-bugs] [Bug 10498] Place Hold on Order
In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10498-70-vzV4pDl9vW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:46:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:46:05 +0000
Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen
In-Reply-To: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10531-70-v5nEGORjc8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:50:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:50:09 +0000
Subject: [Koha-bugs] [Bug 10884] Circulation table: odd behavior on
	checkboxes
In-Reply-To: <bug-10884-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10884-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10884-70-FJ6ncSy12W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10884

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

I did discover a bug when clicking the 'select all' link in the export column;
this was not introduced by this patch, so I'll just open a new bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:56:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:56:12 +0000
Subject: [Koha-bugs] [Bug 11075] New: Clicking 'select all' link in export
 tab in checkout page clears renew checkboxes
Message-ID: <bug-11075-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11075

            Bug ID: 11075
           Summary: Clicking 'select all' link in export tab in checkout
                    page clears renew checkboxes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

[Discovered during testing the patch for bug 10884]

If circulation exports are enabled (by turning on ExportWithCsvProfile), the
table on the checkout page includes three columns of checkboxes -- 'renew',
'checkin', and 'export'.

For each loan, the renew and checkout links should behave like radio buttons,
but the state of the export checkbox is meant to be independent of the renew
and checkin checkboxes.

However, if the 'select all' link in the export column is clicked, active renew
checkboxes are toggled off.

The desired behavior is that clicking the select all link in the export column
should only affect checkboxes in that column.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 18:56:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 16:56:37 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-ENL2wffP0V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #27 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
This bug applies correctly on current master in my VM :

$git bz apply 7791
Bug 7791 - Deleting basket should not delete all existing orders without
warning

Bug 7791 : Give the ability to delete records when deleting a basket
Apply? [yn] y

Applying: Bug 7791 : Give the ability to delete records when deleting a basket
Bug 7791 Followup: delete warns, add missing curly braket and make a simpler
message if basket is void
Apply? [yn] y

Applying: Bug 7791 Followup: delete warns, add missing curly braket and make a
simpler message if basket is void
[PATCH 3/3] Bug 7791 Followup: add warning after deletion if some records were
not deleted
Apply? [yn] y

Applying: Bug 7791 Followup: add warning after deletion if some records were
not deleted



Maybe the problem comes from the sandbox ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 19:04:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 17:04:42 +0000
Subject: [Koha-bugs] [Bug 10935] CSV for basket and basketgroup are broken
 when translated
In-Reply-To: <bug-10935-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10935-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10935-70-tArbe0Ddvb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 19:54:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 17:54:15 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-0xpxvmTx6D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 20:14:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 18:14:35 +0000
Subject: [Koha-bugs] [Bug 11076] New: Style 'Cancel' link like buttons
Message-ID: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11076

            Bug ID: 11076
           Summary: Style 'Cancel' link like buttons
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In many pages, there is a "Cancel" link close to a "Save" or "Submit" button.
It would be nicer if "Cancel" was styled to look like a button.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 20:14:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 18:14:53 +0000
Subject: [Koha-bugs] [Bug 11076] Style 'Cancel' link like buttons
In-Reply-To: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11076-70-2tgPi1TEBF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11076

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 20:23:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 18:23:07 +0000
Subject: [Koha-bugs] [Bug 11076] Style 'Cancel' link like buttons
In-Reply-To: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11076-70-OogXlLH0lx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11076

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I disagree. Here's my comment from the similar Bug 4325:

They are supposed to be styled as links. In most cases, the "cancel" action is
not any kind of form submission, it's just a link back to a view or whatever
the previous action was. In cases where a form submission might be required,
styling the action to match existing patterns gives us a button styled like a
link.

In addition, the distinctly different style of the "cancel" action is a visual
cue to users that the action isn't the primary one: Users do not have to spend
a long time examining the labels to determine which button is the submit and
which is the cancel. This should reduce errors.

I don't believe this should be changed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 20:28:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 18:28:15 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-pDPRu7vUnn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, so lets add some background to this bug.

We have many customers using both ICU and DOM with zebra, and we found that
phrase searching was broken.  A phrase search would end up only actually
searching upon the first word in the phrase and as such return rather
unspecific results.

This was reasonably apparent in the clients as 'bad results' in search.. but
that's very objective.

It's also apparent when using the link bibs to authorities script and this is
much more provable.

The link bibs to authorities script uses the exact search type that this patch
affects, and we found that applying the pathc would drastically improve
matching in the default mode of the script.

Test plan to follow... once I've got Ian to give me some exact examples.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:29:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:29:29 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-rMzSU0pFsM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:42:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:42:13 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-e4L1DEnht3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #28 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I read again your comment. In fact everything is OK for me : 
The goal of the patch is to prevent the suppression of RECORDS used in orders,
not the suppression of ITEMS used in orders.

So the behavior is unchanged for items : you can still suppres an item created
by an order, without any warns, like before the patch. It is bad, but it must
be fixed in an other patch, as it is not exactly the same problem.

Do you agree with that?

I put patch to need sign off again.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:43:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:43:18 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-quXjaKwQRM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:44:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:44:11 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-nDuokahiqG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #29 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
If you agree and if the other points of the test plan were ok for you, you can
sign it off.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:54:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:54:23 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-cMAlkVRiBj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22037
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22037&action=edit
Bug 10900 - Incorrect calling conventions accessing C4::Context

There were multiple calling conventions for C4::Context's
set_userenv routine. So the following commands were used to
find discrepancies:
    grep "::set_userenv" `find .`
    grep "\->set_userenv" `find .`

The first grep demonstrated that the smaller change is from
:: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and
t/db_dependent/Circulation.t would need to be modified. This
patch corrects C4::Context's set_userenv routine to be object
call based (use ->) by using a shift to ignore the first
parameter, and modify the three files found with :: calls.

As the result of trying to roll a distribution,
t/Circulation_barcodedecode.t was discovered to be faulty. The
cause being incorrect parameters! This was hidden when there
was no shift in the set_userenv routine. However, with its
correction, the test broke.

This led me to read the POD documentation for the function
set_userenv in C4::Context and realize it was outdated as
well. It has been revised to match the current version of
the function.

Then intentionally bad parameters passed to the sent_userenv
routine in C4::Context were hunted down. The biggest problems
were missing surnames or branch names.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:57:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:57:20 +0000
Subject: [Koha-bugs] [Bug 11076] Style 'Cancel' link like buttons
In-Reply-To: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11076-70-fp3HWRuUJz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11076

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree with Owen's argument about the primary action being more obvious. I am
actually quite fond of the styling like it is now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:57:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:57:59 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-N4N2Tb64ES@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21290|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:58:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:58:11 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-Sk3TzA2olV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21291|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:58:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:58:25 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-qrezlpyka7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21292|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:58:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:58:31 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-eiqXhHQ7DL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 21:59:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 19:59:42 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-QpHzYq7Kpu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #16 from M. Tompsett <mtompset at hotmail.com> ---
Had to rebase due to the changed hashing algorithm of the passwords patch which
has made it into master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 22:01:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 20:01:04 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-0LH7oR8Mzz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 22:02:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 20:02:39 +0000
Subject: [Koha-bugs] [Bug 11076] Style 'Cancel' link like buttons
In-Reply-To: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11076-70-Fnr6nGS7HC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11076

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Well, I found that not very nice, and a bit surprizing, but you are true, it
makes the difference between "Cancel" and "Save" very obvious, that's an
advantage.

Regarding the use of buttons and links, Koha is not always consistent. For
example, in basket table, you have links for actions (like cancelling an
order...), but in basketgroups table, you have buttons for actions (edit/close
and print/reopen etc).

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 22:03:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 20:03:59 +0000
Subject: [Koha-bugs] [Bug 10498] Place Hold on Order
In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10498-70-AG0zyY0Vs7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 17 22:05:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 20:05:50 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-gp1CjuG3gQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22037|0                           |1
        is obsolete|                            |

--- Comment #17 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22038
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22038&action=edit
Bug 10900 - Incorrect calling conventions accessing C4::Context

There were multiple calling conventions for C4::Context's
set_userenv routine. So the following commands were used to
find discrepancies:
    grep "::set_userenv" `find .`
    grep "\->set_userenv" `find .`

The first grep demonstrated that the smaller change is from
:: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and
t/db_dependent/Circulation.t would need to be modified. This
patch corrects C4::Context's set_userenv routine to be object
call based (use ->) by using a shift to ignore the first
parameter, and modify the three files found with :: calls.

As the result of trying to roll a distribution,
t/Circulation_barcodedecode.t was discovered to be faulty. The
cause being incorrect parameters! This was hidden when there
was no shift in the set_userenv routine. However, with its
correction, the test broke.

This led me to read the POD documentation for the function
set_userenv in C4::Context and realize it was outdated as
well. It has been revised to match the current version of
the function.

Then intentionally bad parameters passed to the set_userenv
routine in C4::Context were hunted down. The biggest problems
were missing surnames or branch names.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:02:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:02:15 +0000
Subject: [Koha-bugs] [Bug 11077] New: Uninitialized value $pki_field warning
Message-ID: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

            Bug ID: 11077
           Summary: Uninitialized value $pki_field warning
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:02:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:02:30 +0000
Subject: [Koha-bugs] [Bug 11077] Uninitialized value $pki_field warning
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-WfUIdPTlFv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8817

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:02:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:02:30 +0000
Subject: [Koha-bugs] [Bug 8817] omnibus bug for warning messages
In-Reply-To: <bug-8817-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8817-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8817-70-ZkQwGABzy1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8817

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11077

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:13:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:13:40 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-kaRDaz91XU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #32 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22039
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22039&action=edit
Add locking to rebuild_zebra to prevent races

This patch adds flock based locking for rebuild_zebra.pl on a per-instance
basis. This prevents races between full rebuilds and background incremental
updates from the zebraqueue table in the database.

The race condition exists whether you are doing incremental updates with
a periodic cronjob or with the new daemon mode.  Suppose you start a full
rebuild
at time T0 which will take until T20 to extract the records.  Suppose also at
T10,
a biblio or auth is updated and processed through the zebraqueue by T15.
In this situation the updated record in zebra will be overwritten when
the full rebuild records are uploaded to zebra after T20.  We prevent this
by only allowing one rebuild_zebra per koha instance to be running at one time.

When running in daemon mode, incremental updates will be skipped while
a full rebuild is running, and resume afterwards.  A full rebuild or other
adhoc request will wait for any previous lock to clear.

Tested by flocking the lock file while invoking rebuild_zebra.pl in
various modes (daemon, adhoc zebraqueue task, and full rebuild) using
flock program I will attach to bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:32:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:32:01 +0000
Subject: [Koha-bugs] [Bug 11076] Style 'Cancel' link like buttons
In-Reply-To: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11076-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11076-70-ArYmA0GPCe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11076

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to mathieu saby from comment #3)

> Regarding the use of buttons and links, Koha is not always consistent. For
> example, in basket table, you have links for actions (like cancelling an
> order...), but in basketgroups table, you have buttons for actions
> (edit/close and print/reopen etc).

I agree with this, and I think there are a lot of places where we should start
to use alternate solutions like Bootstrap buttons or menus (for instance, like
the recent change to saved reports actions). 

Also, all the "Cancel" links should have the class "cancel," so it would be
very simple to add some custom CSS to change the style globally in the staff
client.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:32:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:32:53 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-uvHV9oprW0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #33 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22040
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22040&action=edit
Small perl program to flock files and run commands

This program can be used to test the flock functionality introduced in patch
0003 also attached to this bug.

Test I performed that QA can replicate (modify for your test instance name):

flock the file, and make sure a full rebuild waits for the lock to clear before
proceeding
  window 1: flock /var/lock/koha_rebuild_zebra_koha_test/lock sleep 15
  window 2: ./rebuild_zebra.pl -b -a -v
window 2 should wait for window 1's sleep to time out before proceeding.

test that an flock from another process with cause the daemon mode to pause
updates and resume when the flock is removed
  window 1: ./rebuild_zebra.pl -daemon -sleep 2 -v -z -b -a
  window 2: flock /var/lock/koha_rebuild_zebra_koha_test/lock sleep 15
start window 2 after window 1 is printing a message every 2 seconds.  when you
launch the sleep, it will stop the updates which will resume when the sleep
times out.

remove /var/log/koha_rebuild_zebra_koha_test and make sure its recreated on the
next invocation of rebuild_zebra.pl.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:43:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:43:39 +0000
Subject: [Koha-bugs] [Bug 11065] List of imported biblios is too small -
 increase to a larger number
In-Reply-To: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11065-70-m0qBcf9jQb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11065

--- Comment #1 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22041
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22041&action=edit
Patch to increase size of results list for manage-marc-import page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:47:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:47:45 +0000
Subject: [Koha-bugs] [Bug 11077] Uninitialized value $pki_field warning
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-RbDGWFgnoC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22042
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22042&action=edit
Remove $pki_field variable warning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 00:47:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 22:47:58 +0000
Subject: [Koha-bugs] [Bug 11077] Uninitialized value $pki_field warning
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-kfBVKZnjFT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:04:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:04:53 +0000
Subject: [Koha-bugs] [Bug 11065] List of imported biblios is too small -
 increase to a larger number
In-Reply-To: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11065-70-tAPUGFL5RH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11065

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
There's a nicer fix for this in bug 10558 that uses Datatables and Ajax to
dynamically load the content.  I'de love to see that patch go in in preference
to this... though this is a pretty good quick fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:05:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:05:31 +0000
Subject: [Koha-bugs] [Bug 11065] List of imported biblios is too small -
 increase to a larger number
In-Reply-To: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11065-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11065-70-Ho5W928uAS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11065

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 10558 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:05:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:05:31 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-5PkHwhhfC8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpk at randomnotes.org

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 11065 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:07:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:07:36 +0000
Subject: [Koha-bugs] [Bug 10535] by default sort funds by name
In-Reply-To: <bug-10535-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10535-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10535-70-LF56kJu9dX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10535

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Galen Charlton <gmcharlt at gmail.com> ---
Follow-up pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:14:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:14:54 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-CtaEe15u8d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #39 from Doug Kingston <dpk at randomnotes.org> ---
This bug is now blocking a simpler fix (bug 11065) which will work and has no
licensing issues.  Lets get this one cleared to push or park it in favor of a
simpler but less flexibe fix. This was a high priority issue coming out of the
Cataloging roundtable at KohaCon13.  What precisely do we need to do to clear
this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:32:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:32:20 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-W4lMl2mR36@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Any chance we can move the 'Add locking to rebuild_zebra to prevent races'
followup patch to a dependant bug instead of adding it here.. That way QA can
go on with the deamon mode patch without being held in waiting for a further
signoff.  (PS, if you do that, I'll test and sign off on it).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:42:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:42:15 +0000
Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for
	parameters
In-Reply-To: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10380-70-ANphDpp1h7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with follow-ups to update a couple new calls to
output_pref() and to improve the POD.

Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 01:51:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 17 Oct 2013 23:51:07 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-mQf85vVDGU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #37)
> (In reply to Jonathan Druart from comment #36)
> > ping Kyle, we are close to finish!
> > Is a rebased code from Tamil or the first patch contains a bad c/p of the
> > license?
> 
> Kyle, we need your feedback on this! :)

The file in question is based on a file Tamil wrote that I copied and then
completely re-wrote. However, if someone wants to add a followup to add a
copyright for Tamil to my the new file, I would be fine with that.

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 02:25:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 00:25:48 +0000
Subject: [Koha-bugs] [Bug 11077] Uninitialized value $pki_field warning
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-wgOobVjb95@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Actually, I was thinking about this annoying problem too, and that's not how I
was thinking of solving it.

Around line 774 the $pki_field is defined and set as part of an if statement,
but because it can be short-circuited, the variable is sometimes not defined.

I would suggest that the solution is to put:
my $pki_field = C4::Context->preference('AllowPKIAuth') || q{};
before the if statement.
AND
change the if statement to be
... || $pki_field ne 'None' ...

This way $pki_field is defined, and string comparisons shouldn't generate
silent errors.

I'm switching this to in discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 02:50:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 00:50:16 +0000
Subject: [Koha-bugs] [Bug 11077] Uninitialized value $pki_field warning
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-cHgnWYaLrn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22042|0                           |1
        is obsolete|                            |
             Status|In Discussion               |Needs Signoff
           Assignee|gmcharlt at gmail.com          |tomascohen at gmail.com

--- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22043
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22043&action=edit
Silence uninitialized value $pki_field warning

During login at the Staff interface you get warnings in the logs
regarding an uninitialized value for the $pki_field variable.

To test:
 - tail -f /path/to/your-intranet-logs
 - Point your browser to your staff login page
 - Login
 - Three warnings are showed
 - Apply the patch
 - Log out
 - Log in
 - No new warnings, and you can still log in.

Thanks
To+

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 03:49:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 01:49:49 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-O5VEDCDbGs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 03:50:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 01:50:13 +0000
Subject: [Koha-bugs] [Bug 10472] Receipt by line or invoice
In-Reply-To: <bug-10472-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10472-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10472-70-FZjD5NOUVI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 03:50:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 01:50:38 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
 the Staff client to budget information.
In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10013-70-w1bCl0LqsQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 04:34:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 02:34:13 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-rOL5EBcnZA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Uninitialized value         |Correct silent warnings in
                   |$pki_field warning          |C4/Auth.pm

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
Changed name to reflect the fact that this bug corrects two silent warnings:
[Thu Oct 17 22:32:14 2013] [error] [client 192.168.45.23] [Thu Oct 17 22:32:13
2013] mainpage.pl: Use of uninitialized value in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 685., referer:
http://demo.library-admin.kohasystem.ca/
[Thu Oct 17 22:32:14 2013] [error] [client 192.168.45.23] [Thu Oct 17 22:32:14
2013] mainpage.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/
[Thu Oct 17 22:32:14 2013] [error] [client 192.168.45.23] [Thu Oct 17 22:32:14
2013] mainpage.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/

Reproduce:
Go to staff client url
Log in
Check staff client error log file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 05:26:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 03:26:38 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-Dh2M7PoXUU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #5 from M. Tompsett <mtompset at hotmail.com> ---
Test case to check, which makes a difference whether '' or 'None' is used.

Apply patch.
Make sure you aren't doing cas authentication (not normally configured)
DELETE AllowPKIAuth system preference. -- an upgrade gone bad somehow.
Go to staff client.

DO NOT FILL IN ANYTHING.
Click Login
This triggers the modified if statement ('' ne 'None') and the inner else.
This triggers a warning about $retuserid being uninitialized.

Change the line to be 'None'
DO NOT FILL IN ANYTHING.
Click Login
This triggers nothing as far as I can tell, because there is nothing else at
the same level.

Hopefully I didn't get them backwards. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 06:27:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 04:27:06 +0000
Subject: [Koha-bugs] [Bug 9667] Inventory scrolling to top with every click
In-Reply-To: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9667-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9667-70-Z0Ag4UMXue@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9667

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

--- Comment #1 from Bruce Metcalf <bugzilla at augustansociety.com> ---
Workaround that works in 3.6: go back one page in browser to return to original
position on inventory list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 06:48:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 04:48:06 +0000
Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond
 to current search query
In-Reply-To: <bug-10808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10808-70-ChQ8LXQslt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 06:48:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 04:48:36 +0000
Subject: [Koha-bugs] [Bug 10808] Thesaurus search form does not correspond
 to current search query
In-Reply-To: <bug-10808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10808-70-GwXzyP2LqV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10808

--- Comment #8 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Galen Charlton from comment #7)
> Pushed to master.  Thanks, Jonathan!

Actually, not yet -- sorry, wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 06:49:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 04:49:04 +0000
Subject: [Koha-bugs] [Bug 10038] Doubled 'default' entry when creating a new
 authority type
In-Reply-To: <bug-10038-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10038-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10038-70-iHbJR5LHxw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10038

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 06:52:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 04:52:18 +0000
Subject: [Koha-bugs] [Bug 10850] Give Quick spine label template page its
	own id
In-Reply-To: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10850-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10850-70-QFwddfLSzB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10850

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, OWEN!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 07:10:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 05:10:23 +0000
Subject: [Koha-bugs] [Bug 11078] New: rebuild_zebra.pl can lose updates due
 to race condition during full rebuilds
Message-ID: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

            Bug ID: 11078
           Summary: rebuild_zebra.pl can lose updates due to race
                    condition during full rebuilds
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P4
         Component: Tools
          Assignee: dpk at randomnotes.org
          Reporter: dpk at randomnotes.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 6435

The race condition exists whether you are doing incremental updates with
a periodic cronjob or with the new daemon mode.  Suppose you start a full
rebuild
at time T0 which will take until T20 to extract the records.  Suppose also at
T10,
a biblio or auth is updated and processed through the zebraqueue by T15.
In this situation the updated record in zebra will be overwritten when
the full rebuild records are uploaded to zebra after T20.  We prevent this
by only allowing one rebuild_zebra per koha instance to be running at one time.

This patch adds flock based locking for rebuild_zebra.pl on a per-instance
basis. This prevents races between full rebuilds and background incremental
updates from the zebraqueue table in the database.

When running in daemon mode (see bug 6435), incremental updates will be skipped
while a full rebuild is running, and resume afterwards.  A full rebuild or
other
adhoc request will wait for any previous lock to clear.

Tested by flocking the lock file while invoking rebuild_zebra.pl in
various modes (daemon, adhoc zebraqueue task, and full rebuild) using
flock program I will attach to bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 07:10:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 05:10:23 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-vwRBhSfIDW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11078

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 07:13:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 05:13:27 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-2RVYwKWEkq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpk at randomnotes.org

--- Comment #1 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22044
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22044&action=edit
Add locking to rebuild_zebra to prevent races

Please excuse the wrong bug number in the patch filename.  This change was
forked off that bug because its logically a different bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 07:14:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 05:14:51 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-hS4WhTMwvn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #2 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22045
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22045&action=edit
flock testing program

Small perl program to flock files and run commands

This program can be used to test the flock functionality introduced in patch
0003 also attached to this bug.

Test I performed that QA can replicate (modify for your test instance name):

flock the file, and make sure a full rebuild waits for the lock to clear before
proceeding
  window 1: flock /var/lock/koha_rebuild_zebra_koha_test/lock sleep 15
  window 2: ./rebuild_zebra.pl -b -a -v
window 2 should wait for window 1's sleep to time out before proceeding.

test that an flock from another process with cause the daemon mode to pause
updates and resume when the flock is removed
  window 1: ./rebuild_zebra.pl -daemon -sleep 2 -v -z -b -a
  window 2: flock /var/lock/koha_rebuild_zebra_koha_test/lock sleep 15
start window 2 after window 1 is printing a message every 2 seconds.  when you
launch the sleep, it will stop the updates which will resume when the sleep
times out.

remove /var/log/koha_rebuild_zebra_koha_test and make sure its recreated on the
next invocation of rebuild_zebra.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 07:19:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 05:19:38 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-1V2JvAWRr7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #35 from Doug Kingston <dpk at randomnotes.org> ---
I have created separate bug 11078 to track the race condition and its locking
fix.
11078 depends on this bug.  6435 does not create any race condition that did
not already exist.  The patch for locking and the flock test program are
attached to 11078.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 08:19:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 06:19:07 +0000
Subject: [Koha-bugs] [Bug 10843] print a slip can cause an error
In-Reply-To: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10843-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10843-70-RzN7R1zeDy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10843

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 09:06:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 07:06:47 +0000
Subject: [Koha-bugs] [Bug 11079] New: Number of overdues days come while
 checkin the items
Message-ID: <bug-11079-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11079

            Bug ID: 11079
           Summary: Number of overdues days come while checkin the items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: amitddng135 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 09:08:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 07:08:20 +0000
Subject: [Koha-bugs] [Bug 11079] Number of overdues days come while checkin
	the items
In-Reply-To: <bug-11079-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11079-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11079-70-ud2WlYPXDE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11079

--- Comment #1 from Amit <amitddng135 at gmail.com> ---
related to Bug number 2636
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2636

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 09:09:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 07:09:00 +0000
Subject: [Koha-bugs] [Bug 11079] Number of overdues days come while checkin
	the items
In-Reply-To: <bug-11079-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11079-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11079-70-yWzg8TL8yB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11079

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 09:29:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 07:29:51 +0000
Subject: [Koha-bugs] [Bug 8368] List email broken for non english templates
In-Reply-To: <bug-8368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8368-70-WfuNzQEKSk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with follow-ups to restore the display of ISBNs in the
email, porting the template change to the new Bootstrap theme, and restoring
the use of encode_qp().  Thanks, Fr?d?ric!

As a side note, perhaps the email templates should probably be moved outside of
the OPAC theme template directories.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 11:45:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 09:45:34 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-zuYC5ADRtz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21969|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22046
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22046&action=edit
Bug 7791 Followup: add warning after deletion if some records were not deleted

This followup add some warnings after deletion if some items were not deleted.
4 types of messages are possible :
- x item(s) attached.
- x subscription(s) attached.
- x order(s) attached.
- Unknown error.

To test :
test a
1. create a basket with
- an order using a record A which has already an item, which is used in a
subscription, and in other order (in an other basket)
- an order using a record B used nowhere elese
2. click on "Delete basket"
3. choose button "Delete basket, orders and records"
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item, subscription and order.
5. check the link around the title of record B takes you to the record
6. check the link under the warning box ("Click here to go back to booksellers
page") takes you to booksellers page
5. check record B is deleted

test b
1. suppress the subscription linked with record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item and order

test c
1. suppress the item attached under record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its orderBug 7791 Followup: add warning after deletion if
some
 records were not deleted
Content-Type: text/plain; charset="utf-8"

This followup add some warnings after deletion if some items were not deleted.
4 types of messages are possible :
- x item(s) attached.
- x subscription(s) attached.
- x order(s) attached.
- Unknown error.

To test :
test a
1. create a basket with
- an order using a record A which has already an item, which is used in a
subscription, and in other order (in an other basket)
- an order using a record B used nowhere elese
2. click on "Delete basket"
3. choose button "Delete basket, orders and records"
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item, subscription and order.
5. check the link around the title of record B takes you to the record
6. check the link under the warning box ("Click here to go back to booksellers
page") takes you to booksellers page
5. check record B is deleted

test b
1. suppress the subscription linked with record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item and order

test c
1. suppress the item attached under record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its order

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 11:45:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 09:45:53 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-nE0HxUtPYj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 12:04:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 10:04:40 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-xAsUDGTfjf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from Paola Rossi <paola.rossi at cineca.it> ---
I apply again the 9 patches, and now I see The 'Acquisition details' tab on the
biblio detail page as described, thanks.
I close the basket after having created an order with 5 items.
In Acquisitions, the status of the order has correctly become "Pending".
But, in the fifth column "Status" of the 'Acquisition details' table, nothing
is shown: it is not "Ordered" as required.
I also switch the AcqCreateItem pref to "receiving an order".
I do again steps 3 to 6.
In Acquisitions, the status of the order has correctly become "Pending".
But, in the fifth column "Status" of the 'Acquisition details' table, nothing
is shown: it is not "Ordered" as required.
So I pass the status to "Failed QA".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 12:07:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 10:07:20 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-mtbKDcHaO9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #29 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hello Jonathan
Did you do something with this attachment? What was the issue ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 12:23:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 10:23:10 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-2Awz2YARN1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to mathieu saby from comment #29)
> Hello Jonathan
> Did you do something with this attachment? What was the issue ?

Mathieu, I applied the third patch using 'git apply --reject' and I manually
fix the conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 12:53:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 10:53:13 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-4GuNrdbEVB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

--- Comment #31 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Thank you, I did not know the trick.
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 15:03:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 13:03:05 +0000
Subject: [Koha-bugs] [Bug 3935] Schedule tasks periodically
In-Reply-To: <bug-3935-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3935-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3935-70-lY2q63MKHs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3935

Eric B?gin <eric.begin at inLibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 15:05:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 13:05:40 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-L6Yr5TEqSt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 15:05:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 13:05:43 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-4zH916JjgH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22047
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22047&action=edit
Bug 8230: Followup Bug 5336: Change numbers with understandable codes for
orderstatus

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 15:06:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 13:06:57 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-cRRQXuz1U2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #15)
Hi Paola, thanks for testing.
Yes, there is a bug. The original code had changed in bug 5336.
The followup should be display the order status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 15:53:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 13:53:45 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-tP5k4tWw2O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |paola.rossi at cineca.it

--- Comment #20 from Paola Rossi <paola.rossi at cineca.it> ---
Applying: Bug 10855: Search subscriptions by additional fields
fatal: sha1 information is lacking or useless (C4/Serials.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 10855: Search subscriptions by additional fields

So I pass the status to "Failed QA".

NB. The patch "Update database entry" contains char '|' instead of char ';'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:07:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:07:10 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-692F7Mf91j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22048
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22048&action=edit
Bug 7288: fix typo th/td

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:10:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:10:32 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-0HuEkfIOeV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #7)
Paola, I cannot reproduce your problem but I found a typo in the patch. Could
your retest please?
The regex should match the subscription id in the first column of the table.
Datatables uses it for filtering on subscriptions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:26:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:26:59 +0000
Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks
 fields and translation
In-Reply-To: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11068-70-uUdeI0mTQ4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:31 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-KnWFBchhY6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:34 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-XaY0Mk3bEs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21184|0                           |1
        is obsolete|                            |

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22049
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22049&action=edit
Bug 10855: Add the new package Koha::AdditionalField

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:39 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-evcPXJT0kM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21185|0                           |1
        is obsolete|                            |

--- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22050&action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:43 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-W9pfnYtrkq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21186|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22051
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22051&action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:47 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-pDcIMWIiEk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21187|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22052
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22052&action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the "Add subscription fields" link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:51 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-UpAQAuG4jV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21188|0                           |1
        is obsolete|                            |

--- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22053
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22053&action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the "Additional fields"
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:28:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:28:56 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-sAiPwfXNoH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21189|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22054
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22054&action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:29:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:29:01 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-IFXA7ipHIW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21190|0                           |1
        is obsolete|                            |

--- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22055
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22055&action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:29:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:29:06 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-VGdfM0wyIo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21191|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22056
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22056&action=edit
Bug 10855: FIX: Add additional fields for closed subscriptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:29:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:29:11 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-I9zN5FIdL4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21663|0                           |1
        is obsolete|                            |

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22057
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22057&action=edit
Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:40:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:40:26 +0000
Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merge into the
 C4::Search::History module
In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10933-70-zXhJ69AvrY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 16:40:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 14:40:30 +0000
Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merge into the
 C4::Search::History module
In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10933-70-vQWrE65070@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21364|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22058
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22058&action=edit
Bug 10933: The PurgeSearchHistory should be merge into the C4::Search::History
module

Since bug 10803 adds a C4::Search::History module, the
PurgeSearchHistory routine should be moved.

Test plan:
- run misc/cronjobs/cleanup_database.pl with the searchhistory param and
verify behavior is the same as before applying this patch.
- run prove t/Search/History.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:03:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:03:27 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-ynyElLiguE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18809|0                           |1
        is obsolete|                            |
  Attachment #18810|0                           |1
        is obsolete|                            |
                 CC|                            |amitddng135 at gmail.com

--- Comment #4 from Amit <amitddng135 at gmail.com> ---
Created attachment 22059
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22059&action=edit
Bug 10412 - The ability to update Acquisitions with

Bug 10412 - The ability to update Acquisitions with

    credit notes, with the option to link to an existing
    invoice.

    To Test:
    1) Create a basket.
    2) Create some orders underbakset and close
       the basket.
    3) Receive the shipment give invoice number.
    4) For entering creditnote against bookseller
       click on invoices link on left hand side.
    5) Search invoice number,title,author,isbn etc.
    6) Click on Credit note link.
    7) Enter credit amount, date, notes etc and
       click on Save button.
    8) You can edit and delete also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:04:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:04:19 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-dr5vrgTynm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

--- Comment #5 from Amit <amitddng135 at gmail.com> ---
Created attachment 22060
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22060&action=edit
Bug 10412 - Adding new table aqcreditnotes.

Adding new table aqcreditnotes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:04:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:04:29 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-XpijuN1qD8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:35:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:35:19 +0000
Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen
In-Reply-To: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10531-70-msMjo5B3em@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #6 from Amit <amitddng135 at gmail.com> ---
Hi Jonathan,

I cannot find any error in this patch. Can you please explain me in detail. 
Mean while i am changing the status of the patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:38:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:38:45 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
 the Staff client to budget information.
In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10013-70-6FEvrAKcmW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20064|0                           |1
        is obsolete|                            |

--- Comment #23 from Amit <amitddng135 at gmail.com> ---
Created attachment 22061
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22061&action=edit
Unit Test for newly created routine: GetBudgetInfoFromItemnumber

Kyle,

I have added the Test case for newly created routine:
GetBudgetInfoFromItemnumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:38:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:38:54 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
 the Staff client to budget information.
In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10013-70-56y0ZHzRSC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 17:53:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 15:53:53 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-wQzL6gQCgk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #30 from Pierre Angot <tredok.pierre at gmail.com> ---
Well, I'm agree and disagree ^^

I'm ok with the goal. It's fine, but I prefer having a warn message on item
deletion when AcqCreateItem is "when placing an order".

You've mentionned a new patch. It will be a good thing if this new patch blocks
this one.

Is it possible ? It's easy to test on sandbox, I can sign both of them rapidly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:31:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:31:30 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-npvApvUtCD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20183|0                           |1
        is obsolete|                            |

--- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22062
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22062&action=edit
Bug 10558 - Convert records table in manage-marc-import.pl to ajax DataTable

Some libraries would like to sort by columns for the records of an
import batch. This seems like a good use of ajax DataTables.

Test plan:
1) Apply this patch
2) Import a record batch into Koha
   a) Use some form of matching
   b) Have some records that will match and some that won't
   c) Have at least 30 records so you can test the pager
3) Verify the new table is functionally equivilent to the old static one

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Tests fine and looks good with the exception of the corrections I put in
a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:32:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:32:22 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-x7OWfYalmx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20184|0                           |1
        is obsolete|                            |

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22063
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22063&action=edit
Bug 10558 [Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

This patch makes improvements to the default DataTables CSS and corrects
a couple of errors in the original patch. CSS for the "full numbers"
type pagination, used by this and the quotes editor, has been cleaned up
and made more visually consistent with the brief pagination style.

Also changed:

- removed some hard-coded paths containing "http://staff.kohadev..."
- Added a column header to the column showing record match details. This
  provides both information and a clearer target for clicking to resort
- Expanding the default table pager controls for this page and the
  quotes editor (for consistency)
- Correction to quotes.css to fix pager display problem on wide screens

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:32:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:32:55 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-eRDKDIjNPy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20185|0                           |1
        is obsolete|                            |

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22064
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22064&action=edit
Bug 10558 [QA Follow-up] Convert records table in manage-marc-import.pl to ajax
DataTable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:33:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:33:15 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-HSpWs2VFXZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20328|0                           |1
        is obsolete|                            |

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22065
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22065&action=edit
Bug 10558 [QA Follow-up 2] - Fix JavaScript Error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:33:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:33:39 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-SeostiWO4t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20345|0                           |1
        is obsolete|                            |

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22066
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22066&action=edit
Bug 10558 [QA Follow-up 3] - Change GPL version number and add POD

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:33:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:33:57 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-jQ5OQMzO9e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20395|0                           |1
        is obsolete|                            |

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22067
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22067&action=edit
Bug 10558 [QA Follow-up 4] - switch $.getJSON to $.ajax

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:34:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:34:35 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-JfGugiUKbK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:34:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:34:39 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-gEXov44e36@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22068
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22068&action=edit
Bug 10558 [QA Follow-up 5] - Add Tamil copyrightwq

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:36:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:36:40 +0000
Subject: [Koha-bugs] [Bug 10558] Convert records table in
 manage-marc-import.pl to ajax DataTable
In-Reply-To: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10558-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10558-70-cBWirHvReR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10558

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Setting to Passed QA under the assumption that this was the only QA issue left.
If it is not, then I am wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 18:47:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 16:47:42 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-rkOnuZosIO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> ---
Just for the record: this problem (and the items one) was discussed yesterday
at KohaCon13 acquisition roundtable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:01:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:01:13 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-5P1un5b7zp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by KohaCon13 demo <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:01:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:01:26 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-6qpg7z9t7B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21900|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:01:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:01:32 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-hyR3qRMg6k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22069
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22069&action=edit
just label changed

http://bugs.koha-community.org/show_bug.cgi?id=10785

Signed-off-by: KohaCon13 demo <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:36:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:36:45 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-4pfbMfnE1c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

--- Comment #2 from Heather Braum <hbraum at nekls.org> ---
Created attachment 22070
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22070&action=edit
No holds allowed in staff search results example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:37:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:37:14 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-RU5ENI88Nv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

--- Comment #3 from Heather Braum <hbraum at nekls.org> ---
If there is only one item available to have a hold placed on it, and the item
is waiting for pickup, no holds are allowed in search results, but can be
placed on the detail.pl/reserves.pl pages. 

I can confirm this bug on 3.10.9 as well. 

I am attaching several screenshots examples of this situation. 

A particular record of 100 years of solitude has 1 item attached and is waiting
for pickup. No holds are allowed from search results in both the staff and
catalog sides of the system, but are allowed from the detail.pl and request.pl
pages. 

A particular record of emerald green has 2 items attached. 1 item is waiting
for pickup. 1 item is on order (but available for holds), and holds are allowed
for search results.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:38:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:38:02 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-J0LwCG99ur@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

--- Comment #4 from Heather Braum <hbraum at nekls.org> ---
Created attachment 22071
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22071&action=edit
Detail.pl holds are allowed example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:38:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:38:40 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-itPFVkE7qo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

--- Comment #5 from Heather Braum <hbraum at nekls.org> ---
Created attachment 22072
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22072&action=edit
Request.pl holds allowed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:39:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:39:26 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-R4vttPwjoY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

--- Comment #6 from Heather Braum <hbraum at nekls.org> ---
Created attachment 22073
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22073&action=edit
Catalog side no holds allowed example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:40:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:40:06 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-CVlhUDsypZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

--- Comment #7 from Heather Braum <hbraum at nekls.org> ---
Created attachment 22074
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22074&action=edit
Holds allowed from search results example

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:41:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:41:18 +0000
Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for
 items "Waiting"
In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9774-70-5pnVWotc6k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774

--- Comment #8 from Heather Braum <hbraum at nekls.org> ---
Created attachment 22075
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22075&action=edit
Detail.pl holds are allowed example (where also allowed in search results)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:49:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:49:07 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-BgYkbXBWsg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Bootstrap theme: Incorrect  |Bootstrap theme: Incorrect
                   |rendering for R2L languages |rendering for right to left
                   |                            |languages
           Severity|enhancement                 |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 18 20:53:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 18:53:45 +0000
Subject: [Koha-bugs] [Bug 10883] OPACAllowHoldDateInFuture can let a patron
 jump to the top of the holds list
In-Reply-To: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10883-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10883-70-JBm9DEkjw1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10883

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 00:15:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 22:15:54 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-Xx06UMfCNn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22076
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22076&action=edit
Bug 10493 - Add renewal script

Koha needs a renewal tool that functions similar to the returns where a
librarian can continuously scan items for renewal. This script should
block renewals that are impossible, and allow the same renewal overrides
as circulation.pl

Test plan:
 1) Apply the patches for bug 8798
 2) Apply this patch
 3) Browse to /cgi-bin/koha/circ/renew.pl
 4) Enter an invalid barcode, you should get an error message
 5) Enter a valid, but not checked out barcode, you should get an error
    message.
 6) Enter a valid barcode that is checkout out and should be renewable,
    you should get a success message.
 7) Enable AllowRenewalLimitOverride
 8) Enter a barcode for an item that has been renewed too many times
 9) You should get a warning which you can override.
10) Disable AllowRenewalLimitOverride
11) Repeat steap 8
12) You should get a blocking error message
11) Enter a barcode for an item with unfilled holds on it,
    you should get an overridable warning

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 00:16:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 22:16:07 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-57xUQn7mNp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20143|0                           |1
        is obsolete|                            |

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22077
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22077&action=edit
Bug 10493 [Template follow-up] Add renewal script

This template followup fixes some minor template errors and adds some
style to dialog buttons matching those seen on the circulation page.

To test, submit barcodes to trigger the various error conditions:
Non-existant barcode, over the renew limit, restricted patron, item on
hold. Override and Ignore buttons should be properly styled and
functional.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 00:16:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 22:16:30 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-XoXMKcoMlj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20049|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 00:29:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 22:29:25 +0000
Subject: [Koha-bugs] [Bug 11080] New: Add system preference to not charge
 fines for grace days
Message-ID: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11080

            Bug ID: 11080
           Summary: Add system preference to not charge fines for grace
                    days
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: p.thrasher at dover.nh.gov
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

We would like to have the option to not charge fines for the grace period.  So
if a book is due on Monday and is returned on Thursday, we would want to not
charge them for Tuesday, but charge for Wednesday and Thursday.

Clearly, this is the kind of thing that libraries could disagree about, so a
System Preference would let each library choose what works for them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 00:51:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 18 Oct 2013 22:51:54 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-0deOOzxMe5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Heather Braum <hbraum at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hbraum at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 03:40:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 01:40:26 +0000
Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow
In-Reply-To: <bug-9163-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9163-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9163-70-vlN9RQRkBa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpk at randomnotes.org

--- Comment #24 from Doug Kingston <dpk at randomnotes.org> ---
When using the sandbox to try and test this, I tried searching for 'test'
before proceeding with the test plan and got this error message:
Error: Can't call method "raw" on an undefined value at
/home/koha/src/C4/Search.pm line 490.

I do not get this if I build a sandbox from "msster" instead of "9163".

I subsequently tried to follow the test plan and got to the point of checking
to see if I can see the new record and get the error above.  Could you review
the test plan in light of the fact that you are now using user permissions.  I
think I did the right thing here but it would be good to have more explicit
instructions.  Also there are a few options for visibility in the framework and
for access under cataloging for user permissions.  Being more precise with how
those should be set would be good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 14:08:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 12:08:57 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-K5j7kxM8LV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #32 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Pierre Angot from comment #30)
> Well, I'm agree and disagree ^^
> 
> I'm ok with the goal. It's fine, but I prefer having a warn message on item
> deletion when AcqCreateItem is "when placing an order".
> 
> You've mentionned a new patch. It will be a good thing if this new patch
> blocks this one.
> 
> Is it possible ? It's easy to test on sandbox, I can sign both of them
> rapidly.

Hi Pierre
I agree that an other patch could be made for improving Koha's behavior when
you try to supprss items, but : 
1/ it is better to write small patches, each one adressing a specific issue
(even if we can link bugs together or maybe create a wiki page for grouping
patches about the same kind of issue). More easy and quicker to test, sign off
and QA.
2/ the patch for adding warnings when you suppress items is not written yet
3/ maybe the logic for this new patch should be slightly different from 9780,
so we need to make some specifications first, have discussion, etc, and it will
take time - wile 9780 is already signable.
4/ as Paul Poulain wrote in a message to french list recently, there's
necessarily a "selfish" dimension behind community involvment, especially when
you write patches on week-ends, not beeing paid for that (and you know that's
my case). So I wrote this one for "my" librarians, because for us - we create
items at receipt - deleting records linked with orders is a bigger issue than
deleting items linked with orders. Maybe I could have time to write the other,
maybe not...

For all those reasons, I say to "Signe, boulet!"

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 14:11:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 12:11:25 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-G3JeR8AN2L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #33 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Paul Poulain from comment #31)
> Just for the record: this problem (and the items one) was discussed
> yesterday at KohaCon13 acquisition roundtable.

Of course, Paul, if you have arguments against signing this patch you can
expose them.
Or, maybe, if the patch is working, let it be signed off, and you could make
its QA and tell us if my logic is not good ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 14:27:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 12:27:26 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-VTidicVLuc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #34 from Pierre Angot <tredok.pierre at gmail.com> ---
Ha ha ha !

I've got an idea : go to your Syspref, select AcqCreateItem and change it to
"when placing an order". You are know in the same situation as me :p

Well, I must do a complete test before signing it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 14:37:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 12:37:12 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-dwVDOPyKHN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #35 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Pierre Angot from comment #34)
> Ha ha ha !
> 
> I've got an idea : go to your Syspref, select AcqCreateItem and change it to
> "when placing an order". You are know in the same situation as me :p
> 
I've done it to check my patch was not making things worse for "when placing an
order" syspref ;-)
But I think it does not make things worse in that case, it has just no effect
when tou suppress the items.
But when the items are suppress, you still have the same warning if you try to
delete the record. So it is usefull even with "when placing an order" syspref.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 16:12:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 14:12:55 +0000
Subject: [Koha-bugs] [Bug 10465] Reference to fields 780 and 785 in UNIMARC
 XSLT should be removed
In-Reply-To: <bug-10465-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10465-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10465-70-0196APLJ14@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10465

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Same changes must be made in new bootstrap opac theme.
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 16:13:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 14:13:59 +0000
Subject: [Koha-bugs] [Bug 10218] Add individual CSS classes for
 bibliographic information on OPAC results and detail pages (UNIMARC)
In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10218-70-3PEVNJFULF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Same changes must be made to new bootstrap opac.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 16:16:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 14:16:18 +0000
Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in
 UNIMARCslim2OPACResults.xsl
In-Reply-To: <bug-10564-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10564-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10564-70-MojUYnj5ly@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Do you know if the changes were made too in the new bootstrap opac ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 16:39:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 14:39:51 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-i0zHfvZnB1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #36 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to mathieu saby from comment #33)
> (In reply to Paul Poulain from comment #31)
> > Just for the record: this problem (and the items one) was discussed
> > yesterday at KohaCon13 acquisition roundtable.
> 
> Of course, Paul, if you have arguments against signing this patch you can
> expose them.
> Or, maybe, if the patch is working, let it be signed off, and you could make
> its QA and tell us if my logic is not good ?
I've no arguments against it, it's the opposite: during the round table
librarians where complaining of this problem, I just said "hey, but, there's a
patch for this one" !

Pierre (Mathieu, implying that "pierre" is a "boulet" is funny :D :D :D ),
let's sign off & i'll QA tomorrow, during the hackfest.

[ For now, let's head to the bus going to Lake Tahoe
(http://www.visitinglaketahoe.com/) ! ]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 19:49:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 17:49:39 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-MtWTUTCkA9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

Pierre Angot <tredok.pierre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #37 from Pierre Angot <tredok.pierre at gmail.com> ---
All the tests are ok.

There is a little problem in test plan : if you unckeck "order manage", you
can't created basket :p I mentionned only if someone wants do some other test. 

The second part :

B. test what can do and see a librarian without order managing rights
4) Connect to Koha with a borrower with order managing rights
5) in a basket, create 2 orders A & B from new records
6) delete order B
7) Logoff and connect to Koha with a borrower without order managing rights
8) in the catalogue, try to suppress
- record used for order A : you should see a specific warning informing you you
need specific rights to suppress the record
- record used for order B : idem
- a record not used in any order : you should see no specific warning


PS : we need a same warn on items when AcqCreateItem is "when placing an order"
:p

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 19 20:30:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 18:30:33 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-CGfy1nkJrE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #38 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Pierre Angot from comment #37)
> All the tests are ok.
> 
> There is a little problem in test plan : if you unckeck "order manage", you
> can't created basket :p I mentionned only if someone wants do some other
> test. 
> 
> The second part :
> 
> B. test what can do and see a librarian without order managing rights
> 4) Connect to Koha with a borrower with order managing rights
> 5) in a basket, create 2 orders A & B from new records
> 6) delete order B
> 7) Logoff and connect to Koha with a borrower without order managing rights
> 8) in the catalogue, try to suppress
> - record used for order A : you should see a specific warning informing you
> you need specific rights to suppress the record
> - record used for order B : idem
> - a record not used in any order : you should see no specific warning
> 
> 
> PS : we need a same warn on items when AcqCreateItem is "when placing an
> order" :p

Thank you Pierre. You are definitely my FAVORITE boulet.
Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 00:10:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 22:10:33 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-NUWelqy3yB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22029|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22078
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22078&action=edit
[SIGNED-OFF] Bug 11070 - typo in UNIMARC 115a plugin

In UNIMARC 115a cataloging plugin, there is a typo : "NTSC", not "NSTC" :
http://fr.wikipedia.org/wiki/Ntsc

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Simple string change.
koha-qa complains about tab errors, fixed in followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 00:11:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 22:11:19 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-P0a6xNaBzJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22079
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22079&action=edit
Bug 11070 - followup to correct tabs

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 00:11:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 19 Oct 2013 22:11:40 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-3XJw9LXmko@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 04:11:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 02:11:21 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-ZLpyQ3NMTN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22039|0                           |1
        is obsolete|                            |
  Attachment #22040|0                           |1
        is obsolete|                            |

--- Comment #36 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22080
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22080&action=edit
empty file to allow obsoleting other files.

Deleting unneeded files which have moved to a new bug 11078.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 08:51:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 06:51:40 +0000
Subject: [Koha-bugs] [Bug 10712] Some values not saved in koha install log
In-Reply-To: <bug-10712-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10712-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10712-70-mFNWwOhXTf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10712

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #7 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 08:56:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 06:56:16 +0000
Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the
 alerts are not shown
In-Reply-To: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10362-70-WqqiT7Nyim@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #7 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 08:58:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 06:58:10 +0000
Subject: [Koha-bugs] [Bug 10664] Software error in overdue_notices.pl if
 there is no active currency
In-Reply-To: <bug-10664-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10664-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10664-70-zvpN8E78XD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10664

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #9 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 09:13:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 07:13:14 +0000
Subject: [Koha-bugs] [Bug 10483] check_uniqueness.pl does not work
In-Reply-To: <bug-10483-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10483-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10483-70-8c9QsrY838@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10483

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #8 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 09:15:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 07:15:21 +0000
Subject: [Koha-bugs] [Bug 10715] MARC21 007 Plugin Editor doesn't load
	position 01
In-Reply-To: <bug-10715-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10715-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10715-70-gcBgoctwQ7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #7 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 09:16:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 07:16:22 +0000
Subject: [Koha-bugs] [Bug 10703] add/update database documentation
In-Reply-To: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10703-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10703-70-ezG9ZMzQVf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10703

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #13 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 09:23:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 07:23:03 +0000
Subject: [Koha-bugs] [Bug 10481] No enrollment fee when changing patron
	category
In-Reply-To: <bug-10481-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10481-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10481-70-dwvWI9WZL3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10481

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #29 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 09:59:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 07:59:13 +0000
Subject: [Koha-bugs] [Bug 11081] New: Port Koha::Contrib::Tamil indexer into
 Koha code base
Message-ID: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

            Bug ID: 11081
           Summary: Port Koha::Contrib::Tamil indexer into Koha code base
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: frederic at tamil.fr
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 10:01:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 08:01:07 +0000
Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha
	code base
In-Reply-To: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11081-70-mSVl0Lxoxw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |frederic at tamil.fr

--- Comment #1 from Fr?d?ric Demians <frederic at tamil.fr> ---
Created attachment 22081
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22081&action=edit
Proposed patch

Port Koha::Contrib::Tamil indexer into Koha code base

Add two scripts for indexing: koha-index and koha-index-daemon.

Documentation:

  perldoc koha-index
  perldoc koha-index-daemon

New dependencies:

  MooseX::Getopt
  MooseX::RW
  AnyEvent::Processor

Available as a Debian package: libmoosex-getopt-perl

Test plan:

- Apply the patch
- Install dependencies, if necessary
- Reindex a whole biblio catalog:
  koha-index --verbose
- Reindex a whole authorities catalog:
  koha-index --source authority --verbose
- Modify 1 biblio record, and index it:
  koha-index --select queue
- Modifiy 1 authority record, and index it:
  koha-index --select queue --source authority
- Run indexing daemon, with a 15s timeout:
  koha-index-daemon --timeout 15
- Modify a biblio record: wait 15s, and see
- Modify an authority record: wait 15s, and see

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 10:02:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 08:02:16 +0000
Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha
	code base
In-Reply-To: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11081-70-8ejzuVWlIh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 11:21:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 09:21:04 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-LRSi0k0Xkl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #16 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Could someone QA, so that depending patch (Bug 10758) could be signed on
sandbox once this one is pushed?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 11:22:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 09:22:14 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-76ZWgGhydG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I won't make Biblio.t unimarc compliant, that's too complex. But I'm still
working on writing UT.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 11:29:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 09:29:03 +0000
Subject: [Koha-bugs] [Bug 11082] New: Warn user when trying to suppress an
 item linked with an order
Message-ID: <bug-11082-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11082

            Bug ID: 11082
           Summary: Warn user when trying to suppress an item linked with
                    an order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

I quote here Pierre Angot (in bug 9780 comments)
"I prefer having a warn message on item deletion when AcqCreateItem is "when
placing an order".

Maybe it would be usefull with all positions of  AcqCreateItem syspref, but it
seems to be more critical for "when placing an order" position.

Suppressing items should NOT be forbidden, because the book could have been
lost or withdrawn (and some libraries does not use the "lost" and "withdrawn"
value of item, but merely delete the item)
But there could be some warns, and maybe limiting the right to delete items to
librarians with acq permissions.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 11:29:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 09:29:46 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-GSFp0bi6qF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #39 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Pierre, new bug created for the issue you pointed out:
Bug 11082

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 11:31:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 09:31:10 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-Z3DzXiuvOD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #40 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
By the way, Bug 10758 is more or less related to the same issue (show
title/author from deletedbiblio when the biblio is deleted). And of course the
same could be done with items/deleteditems if it is relevant.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 14:59:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 12:59:31 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-mDJjsw7w4c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #27 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I see UT for Acquisition subs in Acquisition.t and in separate files for
TransferOrder, OrderFromSubscription and GetOrdersByBiblionumber.

If I want to add UT for NewOrder, DelOrder, GetOrder, GetOrders, etc etc etc ,
what is the better : use Acquisition.t, whith comments to make clear which Sub
I am testing, or creating a new file of each one?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 16:37:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 14:37:56 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-X7Pi6EnEly@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Telling the browser not to cache self-check pages should resolve this

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 16:54:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 14:54:14 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-Z7hw7BMfWO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Galen Charlton from comment #2)
> Telling the browser not to cache self-check pages should resolve this

It does already use a no-cache Cache-control directive; some preliminary
testing indicates that adding max-age=0 to the cache-control directive should
do it.  Working on a patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 18:00:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 16:00:45 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-4qPYPG9hnr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22080|0                           |1
        is obsolete|                            |

--- Comment #37 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 22080
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22080
empty file to allow obsoleting other files.

There is no need for this file.
To obsolete files:
Click on "Details" beside the attachment name.
Click on "Edit Details" beside the name at the top.
Check the obsolete box near the middle/bottom right.
Click the appropriate save/submit button.
To un-obsolete files:
Click on link to show all the obsoleted items
Click on "Details" beside the attachment name.
Click on "Edit Details" beside the name at the top.
Un-check the obsolete box near the middle/bottom right.
Click the appropriate save/submit button.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 18:16:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 16:16:58 +0000
Subject: [Koha-bugs] [Bug 11083] New: Authority Search Result Display should
 be XSLT Driven
Message-ID: <bug-11083-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083

            Bug ID: 11083
           Summary: Authority Search Result Display should be XSLT Driven
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: gmcharlt at gmail.com
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

When searching for authorities in the Staff Client, the results page is all
pure template driven. This should be xslt driven like the biblio results pages
such that authorities can be displayed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:09:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:09:53 +0000
Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha
	code base
In-Reply-To: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11081-70-BiAU1xDmPH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
How does this compare to bug 6435?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:10:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:10:27 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-1956qhBGwC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK.. as an update from kohacon13 hackfest.

My aim is to rebase Matthias's git branch to apply to master and post his work
up as a squashed patch that I'll have signed off.

I'll then add a full testplan (including a guide to the difficult bit of
setting up the shibboleth apache modules and shibd deamon and metadata
exchange)

Hopefully, I'll then be able to poke a few people into testing against our test
shibboleth IdP to add additional signoffs...

Watch this space.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:17:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:17:47 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-aV0mGz3yRu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

D Ruth Bavousett <druthb at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|frederic at tamil.fr           |druthb at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:29:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:29:07 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-gjt4YVmocE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

--- Comment #1 from D Ruth Bavousett <druthb at gmail.com> ---
Created attachment 22082
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22082&action=edit
Bug 8070: Showmarc preview looks really wrongheaded RTL.

The Right Answer, according to the cataloger I spoke to, is to make it LTR when
doing "raw" MARC display.

To test:

1) Install this patch, then run misc/translator/translate install ar-Arab
2) search for a bib in the staff client.
3) Switch to Arabic, and click the link to the left of "MARC Preview"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:36:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:36:21 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-3zyifaoDpf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:36:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:36:33 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-lZVBwlOAJc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:36:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:36:36 +0000
Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table
 with shrink to fit option
In-Reply-To: <bug-10451-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10451-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10451-70-qZ0CegIwpr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:41:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:41:41 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-HSaMpxeads@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #16 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #15)
> Trying to test.
> Is there any documentation of how to enable/configure pazpar2?
> I'm to the point that I need to know where to find "/pazpar2/search.pz2" file
> referenced in pazpar2_init on line 72

Ah, yes. The installer's template configuration files have been updated, but
here's the changes you need to make to an existing install (none of these will
break existing functionality):

  * Change the two lines in the Apache .conf that read:

    <DirectoryMatch "/home/feoh3/p/koha/koha-tmpl/.*/(modules|xslt|includes)">

    to read:

    <DirectoryMatch "/home/feoh3/p/koha/koha-tmpl/.*/(modules|includes)">

  * Make sure that the proxy and proxy-http modules are enabled in Apache.
  * If you haven't already, install Pazpar2:
    * Get the packages installed.
    * Copy the configuration files from the Koha source to someplace
convenient.
    * Modify pazpar2.xml to listen on an open port and point at the directory
you just installed the files to.
    * Change __ZEBRA_MARC_FORMAT__ in koha-biblios.xml or generic-settings.xml
to marc21 or unimarc as appropriate.
  * Change the first line in koha-biblios.xml file (if you have it) in the
Pazpar2 directory to read:
    <settings target="*">
  * Copy the new *-work-groups.xsl files to your Pazpar2 directory.
  * Start pazpar2.
  * Add the following lines to your Apache configuration under your OPAC
VirtualHost:

    <Proxy *>
        AddDefaultCharset off
        Order deny,allow
        Allow from all
    </Proxy>

    ProxyRequests off
    ProxyPass /pazpar2/search.pz2 http://localhost:PORT/search.pz2

    replacing PORT with the port you configured Pazpar2 to listen on.
  * Restart Apache.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:49:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:49:18 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-vI1kv4wkSl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22083
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22083&action=edit
Bug 10889: fix comment describing biblioitems.serial

biblioitems.serial is not a foreign key; it's a Boolean indicating
whether the biblio record is a serial, which in turn influences how
serial items are displayed.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:49:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:49:15 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-MqQrvuSXtR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:57:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:57:27 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-SDqdkqgeZE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21687|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:58:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:58:00 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-88oOE8uwe3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Jesse Weaver <jweaver at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21734|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 19:59:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 17:59:33 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-JaK3dzWgeU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #17 from Jesse Weaver <jweaver at bywatersolutions.com> ---
Created attachment 22084
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22084&action=edit
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC

This adds a new page to the OPAC that can search several Z39.50 targets
using Pazpar2.

Test plan:
1) Apply patches.
2) Update database.
3) Add one or more Z39.50 targets, using the Administration -> External
   targets screen. Note that not all targets support keyword search, but
   here are some that do:
     * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8
     * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8
4) Perform a search on the OPAC, check to see if the "external targets"
   notice pops up at the top.
5) Click on the results link near that message.
6) This should bring back results from all enabled targets, all of which
   should be clickable to bring up a detailed view of the record.

(This version fixes some typos and accidental changes.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:00:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:00:19 +0000
Subject: [Koha-bugs] [Bug 11080] Add system preference to not charge fines
	for grace days
In-Reply-To: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11080-70-yODZdZNIcP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Peggy, not surem, but we have a new pref since 3.12 I think that does sound
like it could be what you want: FinesIncludeGracePeriod.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:01:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:01:19 +0000
Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name
In-Reply-To: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2693-70-0mBA4SzqEE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:01:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:01:22 +0000
Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name
In-Reply-To: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2693-70-QJKScuytVv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21202|0                           |1
        is obsolete|                            |

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22085
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22085&action=edit
Bug 2693 - Tagging: Add filter by name

If you want to filter results on the tags management page by the
reviewer you have to know their borrowernumber. It would be better to be
able to search by name, but in the meantime this patch adds an
autocomplete widget to the form field so that you can do a name search
and populate the field with the borrowernumber.

To test you must have approved or rejected tags. From the tags review
page (tags/review.pl), view all, approved, or rejected tags. Type a name
in the "reviewer" form field in the left sidebar filter. You should get
an autocomplete dropdown with names matching your search. When you
select one the form field should be populated by the borrowernumber.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:02:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:02:36 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-C5JOIx4AeH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> ---
We have been discussing this issue at the KohaCon 2013 hackfest, and have come
to the conclusion that we cannot safely reduce the number of punitive
restriction days automatically. We believe the best solution will be to display
a warning to the librarian such that if a return is being backdated, and the
patron is restricted, the librarian will recieve a message to check to make
sure the punitive restricted days is correct and does not need to be adjusted
manually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:02:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:02:46 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-ZqmuPPc0sN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22086
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22086&action=edit
Bug 11034: remove incorrect return for BiblioAutoLink

BiblioAutoLink was being called expecting an array to
be returned. The subroutine in fact returns a scalar

As the variables that the return was stored in, went
out of scope immediately. It is probably better to be
explicit that we are throwing the return away by not
going through the motions of storing it in a variable

To test:

[1] Add or save a bib record using the cataloging editor.
[2] Verify that no regressions have occurred
[3] (optional) If BiblioAddsAuthorities is on, verfiy that
    relevant authority records are linked to.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:04:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:04:40 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-YnHoZ0rueT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:04:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:04:43 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-Id7WgtnU3C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21944|0                           |1
        is obsolete|                            |
  Attachment #22086|0                           |1
        is obsolete|                            |

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22087
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22087&action=edit
Bug 11034: remove incorrect return for BiblioAutoLink

BiblioAutoLink was being called expecting an array to
be returned. The subroutine in fact returns a scalar

As the variables that the return was stored in, went
out of scope immediately. It is probably better to be
explicit that we are throwing the return away by not
going through the motions of storing it in a variable

To test:

[1] Add or save a bib record using the cataloging editor.
[2] Verify that no regressions have occurred
[3] (optional) If BiblioAddsAuthorities is on, verify that
    relevant authority records are linked to from the bib.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:06:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:06:17 +0000
Subject: [Koha-bugs] [Bug 11084] New: Delete biblios on Leader 05 =d
Message-ID: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

            Bug ID: 11084
           Summary: Delete biblios on Leader 05 =d
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: drnoe at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Position 05 of the leader in MARC 21 indicates the record's status. A lower
case ?d? indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

Koha should allow for deletion of bibliographic records that contain a ?d? in
the LEADER position 05 when by overlaying existing records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:08:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:08:17 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-TUxPUQuyva@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
Example : I've 3 items late, i've been suspended by overdues script.
I check-in only 2 => I must still be suspended.
There can be other reasons. So I agree we can't unsuspend safely.

Jonathan, about suspensions in days, they're calculated when the item is
checked-in. Do you imply there's a problem in this case ? (I haven't checked)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:10:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:10:01 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-Ms9zkEBmeo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:10:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:10:05 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-46d7N2aO27@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22088
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22088&action=edit
Bug 11084 - Delete biblios on Leader 05 =d

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:10:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:10:21 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-URlaYrUaS7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:13:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:13:28 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-qQXYDgJA3P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwagner at ptfs.com

--- Comment #53 from Chris Cormack <chris at bigballofwax.co.nz> ---
*** Bug 4239 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:13:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:13:28 +0000
Subject: [Koha-bugs] [Bug 4239] Allow holds on multiple items of selected
	titles
In-Reply-To: <bug-4239-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4239-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4239-70-MiBbJpg2jo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4239

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED
         Resolution|WONTFIX                     |DUPLICATE

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---


*** This bug has been marked as a duplicate of bug 7710 ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:15:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:15:40 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-fjhc40dJxa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22088|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22089
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22089&action=edit
Bug 11084 - Delete biblios on Leader 05 =d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case ?d? indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/deleted_fixed_field_5.pl -c -v
3) Those records should either be deleted, or an error message should
   state why the were not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:17:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:17:05 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-Or86BdyrOw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think not every library is treating the biblio level itemtype as a document
type currently, so there might be different ideas and workflows involved here.
What I always thought was that item-level itypes was being used as a different
way to define circulation rules. Our libraries don't use the biblio level itype
at all, apart from it being set to a default value, as the itemtype being
picked in the item form will then preset to this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:17:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:17:25 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-Yk0vx0iAjJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:17:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:17:29 +0000
Subject: [Koha-bugs] [Bug 7096] Receiving suggested items does not trigger
 notification mail (AVAILABLE)
In-Reply-To: <bug-7096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7096-70-mQunJ9OFLH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7096

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Mathieu, could you do a test and verify it's working/broken on master?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:21:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:21:41 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-qkKOQN3TyD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
PAtch fixing some weird MySQL, nothing specific to say about it, no possible
side-effect for existing setup.

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:22:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:22:07 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-Y8siotFfDT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
There may be different way of using those fields, but in some templates,
biblioitems.itemtype is translated as "document type". In reports maybe.

I suspect the name biblioitems.itemtype dates back to the old days of pre-marc
Koha, when you could have 1 biblio for x biblioitems.
This is no longer the case, so in a bibliographic point of view, biblioitems
table is used to describe documents (FRBR Manifestation), never items.
So documenttype may be more accurate.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:24:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:24:23 +0000
Subject: [Koha-bugs] [Bug 7096] Receiving suggested items does not trigger
 notification mail (AVAILABLE)
In-Reply-To: <bug-7096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7096-70-umRp87IOYg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7096

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Sorry, I cannot for the moment because I never configured a mail server in my
VM.
But I HOPE that in our production server, when a document arrives, the patron
receive a mail. I will check that.

Mathieu

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:25:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:25:07 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-JIeHzNSwk2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21606|0                           |1
        is obsolete|                            |

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22090
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22090&action=edit
Bug 10969: Fix sample itemtypes for translated installers

To test:
- Install the specific language and run the web installer.
Or:
- Truncate or delete all from the itemtypes table in your database.
- Try to run the complete SQL in the itemtypes sample files.

Verify the table is filled correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works for all languages. No koha-qa errors.

Tested removing itemtypes, then loading new file,
and checking on staff.

For de, es, nb, and pl no problems. For ru I disable foreign
keys constraint before TRUNCATE and reenable it afterwards.

Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:26:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:26:43 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-Z6VQdaZ0RW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
In my library, in biblioitems.itemtype we put 'book', 'cd' etc
and in items.itype 'long loan', 'normal loan'
And we use items.itype for circulation rules.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:26:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:26:44 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-KO7cvl4oEP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21245|0                           |1
        is obsolete|                            |

--- Comment #32 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22091
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22091&action=edit
Bug 7791 : Give the ability to delete records when deleting a basket

Currently, when a basket is deleted, all the orders are deleted (there is a
foreign key in aqorders table on basketno).
This could be dangerous, and there is no warn.
After the deletion, unused biblios are left in the catalogue.
This patch
- adds a more detailed message describing the consequences of deletion
- give the choice of also deleting biblio records if possible

To test :
Test A :
1. create a basket with 4 orders:
- an order from a new record A
- an order from a record B which has already an item
- an order from a record C used in a subscription
- an order from a record D used in an other order
2. note the biblionumbers of the records used (or open them in other tabs in
yout browser)
3. click on "Delete basket"
4. choose button "Delete basket and orders"
5. check the catalogue : records A,B,C,D must still be there
Test B:
1. create a basket with 4 orders:
- an order from a new record A
- an order from a record B which has already an item
- an order from a record C used in a subscription
- an order from a record D used in an other order
2. note the biblionumbers of the records used (or open them in other tabs in
yout browser)
3. click on "Delete basket"
4. choose button "Delete basket, orders and records"
5. check the catalogue : records B,C,D must still be there. Record A must be
deleted

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:26:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:26:55 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-H7vkMUDSIN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:26:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:26:58 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-FNyxVe2hcl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21246|0                           |1
        is obsolete|                            |

--- Comment #33 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22092
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22092&action=edit
Bug 7791 Followup: delete warns, add missing curly braket and make a simpler
message if basket is void

This patch
- delete warns
- add a missing }
- add a condition in template of avoiding asking to suppress orders or records
if the basket is void

To test :
1. Make the same tests as defined in test plan of main patch. It should behave
the same way
2. Try to delete a basket with no records inside. You will only have a "Delete
basket" button, with less warnings

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:27:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:27:08 +0000
Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all
 existing orders without warning
In-Reply-To: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7791-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7791-70-PGkXM5jnxI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22046|0                           |1
        is obsolete|                            |

--- Comment #34 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22093
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22093&action=edit
Bug 7791 Followup: add warning after deletion if some records were not deleted

This followup add some warnings after deletion if some items were not deleted.
4 types of messages are possible :
- x item(s) attached.
- x subscription(s) attached.
- x order(s) attached.
- Unknown error.

To test :
test a
1. create a basket with
- an order using a record A which has already an item, which is used in a
subscription, and in other order (in an other basket)
- an order using a record B used nowhere elese
2. click on "Delete basket"
3. choose button "Delete basket, orders and records"
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item, subscription and order.
5. check the link around the title of record B takes you to the record
6. check the link under the warning box ("Click here to go back to booksellers
page") takes you to booksellers page
5. check record B is deleted

test b
1. suppress the subscription linked with record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item and order

test c
1. suppress the item attached under record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its orderBug 7791 Followup: add warning after deletion if
some
 records were not deleted
Content-Type: text/plain; charset="utf-8"

This followup add some warnings after deletion if some items were not deleted.
4 types of messages are possible :
- x item(s) attached.
- x subscription(s) attached.
- x order(s) attached.
- Unknown error.

To test :
test a
1. create a basket with
- an order using a record A which has already an item, which is used in a
subscription, and in other order (in an other basket)
- an order using a record B used nowhere elese
2. click on "Delete basket"
3. choose button "Delete basket, orders and records"
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item, subscription and order.
5. check the link around the title of record B takes you to the record
6. check the link under the warning box ("Click here to go back to booksellers
page") takes you to booksellers page
5. check record B is deleted

test b
1. suppress the subscription linked with record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its item and order

test c
1. suppress the item attached under record A
2. create an other basket using record A
3. delete the basket on the same way as for test a
4. you must see a page anouncing basket deletion, and that record A was not
deleted because of its order

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:29:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:29:56 +0000
Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records
In-Reply-To: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10421-70-oy8eAARhnm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11084

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:29:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:29:56 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-ARC1tkWWFE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10421

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
See also - bug 10421

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:32:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:32:30 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-hMRIKmvorn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think you can only do that, when you change the mapping? So that you are not
using the itemtypes authorised value list for both (like it is the default for
MARC21 at least).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:32:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:32:54 +0000
Subject: [Koha-bugs] [Bug 9046] Items are not exported with the
	tools/export.pl
In-Reply-To: <bug-9046-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9046-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9046-70-FhRdhbMsRr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9046

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> ---
passing QA, I agree with chris last comment: the current patch is for 3.8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:35:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:35:43 +0000
Subject: [Koha-bugs] [Bug 11085] New: text change in description of image
	option
Message-ID: <bug-11085-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11085

            Bug ID: 11085
           Summary: text change in description of image option
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: nikeener at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:38:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:38:04 +0000
Subject: [Koha-bugs] [Bug 11085] text change in description of image option
In-Reply-To: <bug-11085-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11085-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11085-70-nR5fnw2dYP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11085

NancyK <nikeener at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:38:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:38:14 +0000
Subject: [Koha-bugs] [Bug 11086] New: Koha Tools Upload Patron Images text
 description change
Message-ID: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

            Bug ID: 11086
           Summary: Koha Tools Upload Patron Images text description
                    change
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: jbrice at ccfls.org
        QA Contact: testopia at bugs.koha-community.org

Under Koha Tools Patron Images the description currently reads:

          Upload patron images in batch or one at a time

Sentence should be changed for proper English grammar and for clarity sake the
line could be changed to read:

          Upload patron images in a batch or one at a time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:39:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:39:14 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-R7hKeJcwQB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bob at calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:39:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:39:25 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-7BglFw6TWe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Denise <d.gavio at aarome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.gavio at aarome.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:39:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:39:37 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-SQNuKUJrpG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:39:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:39:48 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-6NhlD9Wo3M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

James Weinheimer <weinheimer.jim.l at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |weinheimer.jim.l at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:39:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:39:55 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-ArrTjUKRSh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Jorge de Cardenas <jdeca at smfpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdeca at smfpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:40:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:40:04 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-ZQLlDjrd3Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

William <wartcarlin at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wartcarlin at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:40:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:40:25 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-JEa8RjDmK5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

NancyK <nikeener at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nikeener at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:41:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:41:57 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-44Bk0Gd6eo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:42:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:42:00 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-ELr17LhMMD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22094
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22094&action=edit
Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold

There is a problem with how an active single language is styled, making
the alignment look incorrect. This patch amends the markup and the CSS
to make it look better. This patch does not address the position of the
language menu.

To test you must have at least one additional single translation
installed. Apply the patch, refresh the page, and confirm that the
display of the active language is improved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:47:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:47:39 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-pFc6actZSC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

Amber Hunt <amber at marlboro.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amber at marlboro.edu

--- Comment #54 from Amber Hunt <amber at marlboro.edu> ---
I think Ian's Wall's comment from a while back applies here:

"The need for some kind of restriction mechanism still exists; not all
libraries will want patrons to be able to place multiple holds on a material;
this could lead to gaming the system by placing holds on every available copy
of a popular book, for example.  I think a control mechanism that looks at the
items.enumchron field for distinct values would be a way to go; this would let
different vol/issue items, for example, take in multiple holds, but equivalent
copies could still be restricted (unless they were explicitly given distinct
enumchron values)"

I also wonder if it might be possible to allow staff with the right permissions
to override. So, patrons would still not have the ability to do this, but staff
(who, in the scenarios I have encountered are the ones that really need this
change) could override.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:51:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:51:46 +0000
Subject: [Koha-bugs] [Bug 10969] Fix sample itemtypes for translated
	installers
In-Reply-To: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10969-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10969-70-FWL3rVkSlm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10969

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:54:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:54:00 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-JFoMFCvZ1l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I like the enumchron idea, another thing would be moving the switch to the
circulation conditions. So you can have different settings for
branch/itemtype/patron category. But this would require that the records are
identifiable by itemtype (if that makes sense). I am not sure there is a
'perfect' way of doing it and we should really syspref it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:54:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:54:11 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-Xe8P84qNzL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:54:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:54:14 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-uhXV5PRzWw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22095
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22095&action=edit
Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:55:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:55:28 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-00azHL2Cot@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21899|0                           |1
        is obsolete|                            |

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22096
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22096&action=edit
Bug 11019  Prevent adding new empty category in authorized values

Test plan:
* Go to Koha > admin > authorised values > New category > save without entering
a category value
* You'll get a message saying "this field is required"
* signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:55:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:55:37 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-eWlRmSCgyn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22097
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22097&action=edit
Bug 11019 follow-up : reindenting

While working on bug 11019, I saw many tabs & silly indenting.
This patch fixes both

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:55:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:55:53 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-YUOb4ql0Sf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10841|0                           |1
        is obsolete|                            |
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22098
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22098&action=edit
Matthias's work, rebased on master

OK.. Step one, I've rebased Matthias's work upon master and squashed it into
one patch.

This patch impliments authentication only (i.e no update/additions of user
data).. that will hopefully be in a followup patch on another bug by either
myself or Jesse W (of Bywater Solutions).

Test plan, and my initial signoff to follow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:56:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:56:57 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-Db9P52WJnH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
                 CC|                            |paul.poulain at biblibre.com
           Severity|major                       |normal

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
need signoff again, as I've rewritten the patch. Lowering severity, if the
librarian takes care and enters a category, as he's supposed to do, no problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 20:59:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 18:59:37 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-d0S9aQhbwA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Yes, 2 different lists.
Because our vendor tell us it was possible I presume.
For circulation rules, if the rules are the same for DVD and CD, we did not
want to duplicate them. So we can have
biblioitems.itemtype = DVD
items.itype = SHORT
and
biblioitems.itemtype = CD
items.itype = SHORT

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:00:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:00:07 +0000
Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl
In-Reply-To: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9739-70-paxbWIUlda@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #17 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:01:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:01:49 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-2rDlOqOOG4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It is totally possible, but I think this is the kind of customizations that we
will have to be really careful about when we change how this works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:03:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:03:51 +0000
Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype
In-Reply-To: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11043-70-5lfOSKFzTv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #4)
> I think you can only do that, when you change the mapping? So that you are
> not using the itemtypes authorised value list for both (like it is the
> default for MARC21 at least).

HMM I understand now why in Zebra, Marc21 is indexing both information in the
same index, while in UNIMARC we use ccode for biblioitems.itemytpe (ccode seems
quite a bad choice).
Making this more uniform could be interesting I think. Because some changes
could be unseen for Marc21 ppl, while they will break configs of unimarc ppl.
And as the concept of "type of documents" and "type of items" are easily
understandable by everone, and not specific to a marcflavor, I don't see why
the indexing should be different.

I would appreciate to have the opinion of unimarc ppl, for example from
Biblibre.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:14:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:14:12 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-9xI8621hTO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The promised test plan...

First up, you'll need to install some additional debian packages:

1. Install shibboleth deamon and apache shibboleth module (Testing upon Debian
7.1 is best, as packages are updated and simpler to configure)

    sudo apt-get install libapache2-mod-shib2 libshibsp5:amd64
shibboleth-sp2-schemas


2. Configure shibboleth 'party of trust' arrangement (i.e. trade metadata keys
with your IdP.. see next comment for details)

3. Configure shibboleth attribute mapping (see next comment for further
details)

4. Configure OPAC Virtualhost to enable shibboleth authentication (add the
foloowing to your virtualhost)

   <Location />
      AuthType shibboleth
      Require shibboleth
   </Location>

Note: The above will enable shibboleth authentication with a fallback to local
(or CAS, or LDAP, or Persona).. you can adapt this to enable Shibboleth only if
you like

5. You should have some now options in the staff client under 'Administration >
System Preferences >  Shibboleth Authentication'. Enable 'Shibboleth
Authentication' and set the 'login attribute' to match what you setup in step
3.

6. Test login in the OPAC.  You should either be logged in directly (if you are
already logged into your IdP by some other means) or when clicking 'Login' you
should see the option to login via Shibboleth which will redirect you to your
IdP for authentication.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:23:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:23:42 +0000
Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha
	code base
In-Reply-To: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11081-70-kCrO0P1O9o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

--- Comment #3 from Fr?d?ric Demians <frederic at tamil.fr> ---
> How does this compare to bug 6435?

It's a new implementation of indexing: lightweight, surclassable in
order to accommodate SolR, not mixing indexing and data sanitizing,
quicker (equivalent to -xml option). It's a true event driven script,
not sleep(ed) one. It may also have to do with Koha code base
refactoring.

>From my perspective, rebuild_zebra.pl has grown too far, doing to much
things.

Take a look at:

  http://wiki.koha-community.org/wiki/Background_indexing_with_Zebra

See also bug 8773

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:23:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:23:52 +0000
Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha
	code base
In-Reply-To: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11081-70-5C5xNU8cbF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8773

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:23:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:23:52 +0000
Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb
	setup
In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8773-70-CHzb57K5r5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Fr?d?ric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11081

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:25:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:25:53 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-XrTTGgM3aq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:25:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:25:56 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-CTMV4E8RwG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22082|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22099
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22099&action=edit
Bug 8070: Showmarc preview looks really wrongheaded RTL.

The Right Answer, according to the cataloger I spoke to,
is to make it LTR when doing "raw" MARC display.

To test:

1) Install this patch, then run misc/translator/translate install ar-Arab
2) search for a bib in the staff client.
3) Switch to Arabic, and click the link to the left of "MARC Preview"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

At first glace I was unsure about hard-coding this style in the
template. Further testing indicated that this is required as the
showmarc template doesn't inherit any of the CSS from the containing
page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:38:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:38:24 +0000
Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff
	interface
In-Reply-To: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10862-70-bE0Ozkuzds@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21047|0                           |1
        is obsolete|                            |

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22100
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22100&action=edit
Bug 10862: Add an search history for the intranet interface

Like OPAC, the search history is now available for intranet.

Test plan:
 1/ Switch on the 'EnableSearchHistory' syspref.
 3/ Launch some biblio and authority searches.
 4/ Go on your search history page (top right, under "Set library").
 5/ Check that all yours searches are displayed.
 6/ Click on some links and check that results are consistent.
 7/ Delete your biblio history searches.
 8/ Delete your authority searches history searches.
 9/ Launch some biblio and authority searches
10/ Play with the 4 delete links (current / previous and biblio /
authority).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:39:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:39:16 +0000
Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff
	interface
In-Reply-To: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10862-70-OG7idlrujU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:39:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:39:21 +0000
Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff
	interface
In-Reply-To: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10862-70-4sqDX0oN2T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21048|0                           |1
        is obsolete|                            |

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22101
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22101&action=edit
Bug 10862: Followup: fix a couple of issues

This followup fixes a couple of issues:
- disable the feature by default.
- use the datatables include file.
- fix the syspref description.
- replace "History search" with "Search history".
- replace biblio with catalog

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:39:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:39:40 +0000
Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still
	running
In-Reply-To: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10611-70-nuKm137Iq5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

--- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> ---
I made some tests with NYTProf, on opac-main.pl

* without the patch
 if (defined($context->{"dbh"}) && $context->{"dbh"}->ping()) {
 # spent 13.5ms making 120 calls to DBI::db::ping, avg 112?s/call

=> 120 pings are sent to mysql

* with the patch
121    1.10ms    if ( defined $db_driver && $db_driver eq 'mysql' &&
$context->{"dbh"} ) {
            return $context->{"dbh"};
        } elsif ( defined $db_driver && defined($context->{"dbh"}) &&
$context->{"dbh"}->ping()) {
            return $context->{"dbh"};
        }

=> no pings sent, even if the 120 calls are still here.

We spent on ly 1.10ms instead of 13.5 in those checks. And the lag will be much
larger in case of a "slow" network mySQL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:40:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:40:01 +0000
Subject: [Koha-bugs] [Bug 10862] Add an search history for the staff
	interface
In-Reply-To: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10862-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10862-70-OHZsi9Gj97@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10862

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21049|0                           |1
        is obsolete|                            |

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22102
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22102&action=edit
Bug 10862: FIX if the query returns 1 result, it does not appears in the
history

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:42:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:42:24 +0000
Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still
	running
In-Reply-To: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10611-70-gDTLxFKMku@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21667|0                           |1
        is obsolete|                            |
  Attachment #21668|0                           |1
        is obsolete|                            |
  Attachment #21669|0                           |1
        is obsolete|                            |

--- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22103&action=edit
[PASSED QA]Bug 10611: Use mysql_auto_reconnect instead of ping

DBD::Mysql provides a mysql_auto_reconnect flag. Using it avoid to do a
ping.

Benchmarks:

use Modern::Perl;
use C4::Context;
for ( 1 .. 1000 ) {
    $dbh = C4::Context->dbh;
}

* without this patch on a local DB:
perl t.pl  0,49s user 0,02s system 98% cpu 0,525 total
* without this patch on a remote DB:
perl t.pl  0,52s user 0,05s system 1% cpu 37,358 total
* with this patch on a local DB:
perl t.pl  0,46s user 0,04s system 99% cpu 0,509 total
* with this patch on a remote DB:
perl t.pl  0,49s user 0,02s system 56% cpu 0,892 total

Testing the auto reconnect:
use Modern::Perl;
use C4::Context;
my $ping = $dbh->ping;
say $ping;
$dbh->disconnect;
$ping = $dbh->ping;
say $ping;

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Comment: Real improvement. No koha-qa errors

prove t/db_dependent/Circulation_issuingrules.t produces no error
prove t/db_dependent/Context.t produces no error

Test
1) dumped Koha DB, load it on a non-local server
2) run sample script whit and without patch, local and remote

use Modern::Perl;
use C4::Context;
for ( 1 .. 100000 ) {
    my $dbh = C4::Context->dbh;
}

Main difference I note is with remote server
a) without patch
real    0m16.357s
user    0m2.592s
sys     0m2.132s

b) with patch
real    0m0.259s
user    0m0.240s
sys     0m0.012s

I think this could be good for DBs placed on
remote servers

Bug 10611: add a "new" parameter to C4::Context->dbh

When dbh->disconnect is called and the mysql_auto_reconnect flag is set,
the dbh is not recreated: the old one is used.

Adding a new flag, we can now force the C4::Context->dbh method to
return a new dbh.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 10611: Followup: remove useless calls to dbh->disconnect

These 3 calls to disconnect are done at the end of the script, they are
useless.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:43:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:43:55 +0000
Subject: [Koha-bugs] [Bug 10611] C4::Context->dbh checks if the DB is still
	running
In-Reply-To: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10611-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10611-70-7Rjo93wFeK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10611

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments : passes koha-qa.pl, no visible changes in the interface, improve
performances.

Linked to mysql, but this will be outdated when DBIx::Class will replace
current database management.

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:53:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:53:27 +0000
Subject: [Koha-bugs] [Bug 11087] New: Have the fines tab default to pay
 fines rather than account
Message-ID: <bug-11087-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11087

            Bug ID: 11087
           Summary: Have the fines tab default to pay fines rather than
                    account
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

A suggestion from an attendee at KohaCon13: Since paying fines is the most
likely action when clicking on the Fines tab, the pay fines tab should be the
default rather than the account summary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:57:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:57:58 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-FmKgdkAA5v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

--- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:
 sorry guys, I think there's a regression: I could delete an order that has
been already recieved. I tried without the patch, and I couldn't, which is the
expected behaviour

Otherwise, there's a tab that makes qa tools complain, I'll provide a follow-up
also fixing some indentation & "bibnum" labeling

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:58:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:58:09 +0000
Subject: [Koha-bugs] [Bug 11088] New: Patron entry page should use floating
 toolbar like cataloging interface
Message-ID: <bug-11088-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088

            Bug ID: 11088
           Summary: Patron entry page should use floating toolbar like
                    cataloging interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
        Depends on: 8151

The floating toolbar, which keeps the "save" button at the top of the screen if
the user scrolls down, should be added to the patron entry page so that the
user is not required to scroll to the bottom to make changes midway through the
page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:58:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:58:09 +0000
Subject: [Koha-bugs] [Bug 8151] Authorities editor should use floating
 toolbar like cataloging interface
In-Reply-To: <bug-8151-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8151-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8151-70-NpNrcmoaKu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8151

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11088

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:58:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:58:46 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-hJTX3DgjcE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22104
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22104&action=edit
Bug 10869 follow-up: indent & term

 * removing a few tabs
 * fixed a few silly indents
 * replaced bibnumb by biblionumber in DelOrder sub, for consistency

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:59:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:59:14 +0000
Subject: [Koha-bugs] [Bug 8151] Authorities editor should use floating
 toolbar like cataloging interface
In-Reply-To: <bug-8151-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8151-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8151-70-ojvxVdNK4u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8151

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11088                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 21:59:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 19:59:14 +0000
Subject: [Koha-bugs] [Bug 11088] Patron entry page should use floating
 toolbar like cataloging interface
In-Reply-To: <bug-11088-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11088-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11088-70-zmzNQhGLu7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|8151                        |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:01:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:01:55 +0000
Subject: [Koha-bugs] [Bug 11089] New: Item edit screen should use floating
 toolbar like cataloging interface
Message-ID: <bug-11089-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11089

            Bug ID: 11089
           Summary: Item edit screen should use floating toolbar like
                    cataloging interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The floating toolbar, which keeps the "save" button at the top of the screen if
the user scrolls down, should be added to the item edit page so that the user
is not required to scroll to the bottom to make changes midway through the
page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:03:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:03:23 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-EpWGx9ggra@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
So.... the most complicated bit of all this (as you may have guessed) is
actually in steps 2. and 3. above!

Step 2 - Configuring Shibboleth party of trust.

Shibboleth config files should be located at: /etc/shibboleth

The important files are:
   shibboleth2.xml - The main config file
   attribute-map.xml - The attribute mapping file

You will also want to create a directory to keep IdP metadata backups within:
   mkdir /var/cache/shibboleth/metadata/
   chown -r _shibd:_shibd /var/shibboleth/metadata

Let's configure some things:

1. First up, we need to setup the SP (Service Provider) identity.

In the shibboleth2.xml file you should find a line similar to:

  <ApplicationDefaults entityID="https://kohaopac.mytestserver.com"

Modify this so that the 'entityID' matches your OPAC URL.

2. Next, we need to tell the shibboleth daemon where the IdP (identity
provider) is.

In the shibboleth2.xml file you should find a block similar to:

    <SSO entityID="http://sso.testidentityprovider.com/auth/metadata">
        SAML2 SAML1
    </SSO>

Modify this so that the entityID matches the IdP's sign in URL.

3. Finally, you'll need to tell the daemon where to fetch the IdP's metadata
from and set a backup path:

In the shibboleth2.xml file you should find a block similar to:

     <MetadataProvider type="XML"
uri="https://sso.testidentityprovider.com/auth/metadata"
              
backingFilePath="/var/cache/shibboleth/metadata/testidp-metadata.xml"
               reloadInterval="7200" >
     </MetadataProvider>

Modify this so that the uri matches the IdP's public metadata page, and point
the backingFilePath to the directory we created.

4. The config is now done... but you should create some keys to work with your
shibboleth SP:

    sudo openssl req -new -newkey rsa:2048 -days 365 -nodes -x509 -keyout
server.key -out server.crt

Your key and certicate names will obviously need to match those in the
shibboleth2.xml config file.

5. Restart the shibd daemon:

   sudo /etc/init.d/shibd restart

6. We're about ready to swap Matadata:  Tell you're IdP provider that your
Metadata is available at:

    https://youropacurl.com/Shibboleth.sso/Metadata

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:29:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:29:15 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-HiR0pQNQ0K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22094|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22105
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22105&action=edit
[SIGNED-OFF] Bug 11057 - Bootstrap theme: Don't hide language chooser below the
fold

There is a problem with how an active single language is styled, making
the alignment look incorrect. This patch amends the markup and the CSS
to make it look better. This patch does not address the position of the
language menu.

To test you must have at least one additional single translation
installed. Apply the patch, refresh the page, and confirm that the
display of the active language is improved.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Improved view of current language. No koha-qa errors.

1) Downloaded a couple of xx-YY-bootstrap.po from
http://translate.koha-community.org/projects/314
2) Installed sample languages
3) Enable them and opaclanguagesdisplay
4) Checked correct alignment of selected language

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:31:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:31:59 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-NyhJRScM6k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21296|0                           |1
        is obsolete|                            |

--- Comment #28 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22106
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22106&action=edit
[PATCH] Bug 10758 - Show bibliographic information of deleted records in
acquisitions

Some modification to the original patch + 2 UT
I still need to write 2 UT.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:38:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:38:18 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-JxRWjq1kf6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:38:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:38:47 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-79vDTpGFuS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22098|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22107
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22107&action=edit
Matthias's work, rebased upon master

Sign off - Tested as in above test plan and in live use at 2 Sites so far.

I would imagine it best to have at least one further signoff given the
complexity of shibboleth.  

I am more than happy to be of assistance to anyone wishing to test this bug,
and can offer the use of a test IdP should it be required as I found I had to
set one up to get my head around this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:39:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:39:04 +0000
Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch
In-Reply-To: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8446-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8446-70-OpS6DcDbHH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:42:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:42:18 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-WGXbiFmcnp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Paul Poulain from comment #17)
> QA comments:
>  sorry guys, I think there's a regression: I could delete an order that has
> been already recieved. I tried without the patch, and I couldn't, which is
> the expected behaviour
> 

I don't understand : did you test on a closed or on an opened basket?

In normal acq workflow, 
1 you add books in your basket
=> You can cancel orders, or add new ones

2 you close the basket
=> You cannot cancel orders or add new ones

3 you receive items, or cancel items in receipt module by creating a mock
invoice and clicking on "cancel order" in receipt page (you are not supposed to
go again basket itself).

So for me the issue is when you want to cancel an order before closing the
basket (between steps 1 and 2). If someone delete the record, you cannot,
that's an issue.


Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:45:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:45:42 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-xCHicytuZG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22105|0                           |1
        is obsolete|                            |

--- Comment #3 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22108
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22108&action=edit
[SIGNED-OFF] Bug 11057 - Bootstrap theme: Don't hide language chooser below the
fold

There is a problem with how an active single language is styled, making
the alignment look incorrect. This patch amends the markup and the CSS
to make it look better. This patch does not address the position of the
language menu.

To test you must have at least one additional single translation
installed. Apply the patch, refresh the page, and confirm that the
display of the active language is improved.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Improved view of current language. No koha-qa errors.

1) Downloaded a couple of xx-YY-bootstrap.po from
http://translate.koha-community.org/projects/314
2) Installed sample languages
3) Enable them and opaclanguagesdisplay
4) Checked correct alignment of selected language

Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:50:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:50:11 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-9ZuLrv6s8n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22083|0                           |1
        is obsolete|                            |

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22109
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22109&action=edit
Bug 10889: fix comment describing biblioitems.serial

biblioitems.serial is not a foreign key; it's a Boolean indicating
whether the biblio record is a serial, which in turn influences how
serial items are displayed.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 22:51:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 20:51:33 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-hYxEadiCpV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Maybe the issue is that some ppl in some libraries send orders before closing
the basket.
I think it should be discourage : closing the basket is needed for calculation
of expected shiping date, so the "normal" workflow implies closing the basket.
If there are too many ways to do the same operation, it is impossible to fix
bugs like that, and to make improvements, because you could always find someone
for who the bug is a normal behavior ;-)

As Nicole is the person who fill the bug first, what's her opinion?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:01:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:01:26 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-7LXrhYznPo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Note : the label for UNIMARC is buit the same way
pos5 = "d" means deleted
http://multimedia.bnf.fr/unimarcb_trad/Bsection5-Label_notice-6-2010.pdf

So it could be made too for unimarc.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:03:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:03:54 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-3m1Pg4Xg0g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:03:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:03:56 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-6Ie0hAPQYo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22096|0                           |1
        is obsolete|                            |
  Attachment #22097|0                           |1
        is obsolete|                            |

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22110
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22110&action=edit
Bug 11019 follow-up : reindenting

While working on bug 11019, I saw many tabs & silly indenting.
This patch fixes both

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:10:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:10:30 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-tisx9kCf0G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
                 CC|                            |ed.veal at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:10:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:10:37 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-kkK0C5Y4YV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |ed.veal at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:13:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:13:23 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-UxmhAQXm63@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:13:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:13:34 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-VSTNPHVaXt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:13:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:13:36 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-myJ73eBxNC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22099|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22111
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22111&action=edit
Bug 8070: Showmarc preview looks really wrongheaded RTL.

The Right Answer, according to the cataloger I spoke to,
is to make it LTR when doing "raw" MARC display.

To test:

1) Install this patch, then run misc/translator/translate install ar-Arab
2) search for a bib in the staff client.
3) Switch to Arabic, and click the link to the left of "MARC Preview"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

At first glace I was unsure about hard-coding this style in the
template. Further testing indicated that this is required as the
showmarc template doesn't inherit any of the CSS from the containing
page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:14:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:14:23 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10538-70-WtekhelBMO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19400|0                           |1
        is obsolete|                            |

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22112
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22112&action=edit
Bug 10538 - Improve importation of .CSV framework files

this patch is basically a rewrite of the _import_table_csv() sub, using
Text::CSV

to test this patch...

1/ dump a framework as a .csv file, to your disk

2/ open that .csv file in LibreOffice (or OpenOffice) and save that file as a
new.csv

note: LO/OO has just created a 'broken' new.csv file

3/ import new.csv file into Koha, (the import should FAIL)

4/ apply patch and repeat step 3, (the import should SUCCEED)

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:14:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:14:20 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10538-70-VZj75i1rLF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:15:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:15:23 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-3ZEEk4z4yq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #2 from Bob Birchall <bob at calyx.net.au> ---
We applied the patch, however at
'/cgi-bin/koha/members/member-flags.pl?member=' the text of the line has not
changed.

However, it has changed as expected at '/cgi-bin/koha/tools/tools-home.pl'.

Unable to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:16:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:16:07 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10538-70-IVWRX1I6Vu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22113
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22113&action=edit
Bug 8368: (follow-up) restore use of quoted printable for message body

This is necessary to prevent the equals sign that is part of the
link back to the OPAC from being mangled, thereby breaking the
link.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:17:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:17:07 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10538-70-qT8wICrVde@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22112|0                           |1
        is obsolete|                            |
  Attachment #22113|0                           |1
        is obsolete|                            |

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22114
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22114&action=edit
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:17:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:17:45 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-QIseJ7V8P9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,

2 small things: 

Can you please take a look at the GPL version for renew.pl and see if you can
update it to GPL3?

Also: You are using the KohaBranchName plugin and I think we are going to
standardize to use Branches instead (see bug 10626.
-[% USE KohaBranchName %]
+[% USE Branches %]

So could you switch it please? 

Continuing testing, as both things are small and easy to check in a follow up
later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:22:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:22:35 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-BLfTFrPoir@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:22:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:22:38 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-0c7hGR1vW9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22115
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22115&action=edit
bug 10016: munge history in SCO to discourage resubmitting user login

This patch uses history.replaceState (introduced in HTML5) to manipulate
the browser history to encourage returning to the SCO patron barcode
form if the back button is used.

Note that a side effect of this patch is that if the user uses
the help link, they will be prompted to enter their barcode
again.  It may be better to put the help inline with the rest
of the SCO forms.

To test:

[1] Start a web-based self-check session.
[2] Enter a patron barcode.
[3] Allow the self-check session to time out.
[4] Use the back button.  You should get the patron barcode
    entry form; you should not be prompted to resubmit form input.
[5] Enter a patron barcode, perform some transactions, then
    use the finish button.
[6] Next, use the back button.  You should get the patron barcode
    entry form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:22:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:22:58 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-sKbfwny3RS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22115|0                           |1
        is obsolete|                            |

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22116
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22116&action=edit
Bug 10016: force zero browser-side caching of SCO pages

This patch makes the web-based self-check module pages
specify that no browser (or proxy caching) occur at all.
This prevents a security issue where letting the SCO session time out,
then hitting the back button allowed one to view the previous
patron's session.

This patch adds an optional fifth parameter to output_with_http_headers(),
and output_html_with_http_headers(), a hashref for miscellaneous
options.  One key is defined at the moment: force_no_caching, which if
if present and set to a true value, sets HTTP headers to specify no
browser caching of the page at all.

To test:

[1] Start a web-based self-check session and optionally perform
    some transactions.
[2] Allow the session to time out (it may be helpful to set
    SelfCheckTimeout to a low value such as 10 seconds).
[3] Hit the back button.  You should not see the previous patron's
    self-check session.
[4] Verify that prove -v t/Output.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:23:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:23:04 +0000
Subject: [Koha-bugs] [Bug 9361] MARC 610 and 611 fields in bulk imports are
 not linked to authorities
In-Reply-To: <bug-9361-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9361-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9361-70-5XxNWpgzHQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9361

Denise <d.gavio at aarome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.gavio at aarome.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:23:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:23:09 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-5c8ZbH0XMH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22117
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22117&action=edit
bug 10016: munge history in SCO to discourage resubmitting user login

This patch uses history.replaceState (introduced in HTML5) to manipulate
the browser history to encourage returning to the SCO patron barcode
form if the back button is used.

Note that a side effect of this patch is that if the user uses
the help link, they will be prompted to enter their barcode
again.  It may be better to put the help inline with the rest
of the SCO forms.

To test:

[1] Start a web-based self-check session.
[2] Enter a patron barcode.
[3] Allow the self-check session to time out.
[4] Use the back button.  You should get the patron barcode
    entry form; you should not be prompted to resubmit form input.
[5] Enter a patron barcode, perform some transactions, then
    use the finish button.
[6] Next, use the back button.  You should get the patron barcode
    entry form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:26:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:26:45 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-RMpeW6Vpwq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,

another thing: when I renew an item where the title has an umlaut (Ex. Die
R?uber), the umlaut is not shown right in the "can't renew" message.

Please fix and switch back to signed off. Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:30:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:30:22 +0000
Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records
In-Reply-To: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10421-70-POcry0liJC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drnoe at bywatersolutions.com

--- Comment #14 from David Noe <drnoe at bywatersolutions.com> ---
This is a feature in other systems on which I have relied for keeping my
catalog up to date. Chiefly, this is applied to records that are leased and
subscription ebook collections that are not static. On a routine basis, the
vendor sends or provides access to a batch of records removed from a
collection. The librarian loads the records in order to delete them. I have had
no less than five partners express a desire for this to me in my short time
working with Koha, and I would expect this functionality myself (as in it would
be a deal breaker on ILS selections).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:31:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:31:37 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-uik7UtdIs2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #3 from Bob Birchall <bob at calyx.net.au> ---
We found that the second change was actually applied to the Help documentation.
 A follow up is required to apply the change to the database.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:38:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:38:46 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-wzeFCbhAAu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

--- Comment #5 from Robin Sheat <robin at catalyst.net.nz> ---
Ed, you've marked this as signed off but haven't attached a signed off version
of the patch, was that intentional?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:46:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:46:02 +0000
Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted
 the same on all forms
In-Reply-To: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10661-70-fPEt5DBLsL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20992|0                           |1
        is obsolete|                            |

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Created attachment 22118
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22118&action=edit
Bug 10661 - Mandatory item fields should be formatted the same on all forms

Mandatory item fields are not indicated the same way in all places. This
patch corrects two places where required fields were shown in bold
rather than using the standard "required" class: When adding an order
from a staged file and when adding an item for a new issue of a serial.

This patch also normalizes the text input size on item entry forms: In
some places it was 50, others 67. I have changed the latter to 50.

Unrelated changes: Added $KohaDates formatting of date and time and
corrected capitalization on a heading on the add order from staged file
page.

It would be nice to be able to use the same method for displaying the
item form as we use on neworderentry.tt -- pulling in the form from a
separate include. However that system is designed for handling multiple
items and would need to be adapted for these cases.

To test, you must have a staged file from which to add an order. Open an
existing basket or create a new one and choose to add an order "From a
staged file." Choose a staged file from which to order. The item entry
form under the "Import all" heading should show required fields in red.

To test in serials: Begin the process for receiving an item from an
existing subscription. On the serials-edit page, find the "Click to add
item" links and click to open the item edit forms. There should be one
under the numbered issue and the supplemental issue forms. In both cases
the item edit screen should show the mandatory item fields in red.

Confirm that the cataloging add item form looks correct and works
correctly.

Revision: Left out the "required" note which should appear after each
required field.

Signed-off-by: David Cook <dcook at prosentient.com.au>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:46:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:46:58 +0000
Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted
 the same on all forms
In-Reply-To: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10661-70-Q1P6cCy9hj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
Attaching my notes here as git bz was timing out insanely fast so I couldn't
add them to the commit...

"Works as described. I tried the serial and acquisitions test plans. 
They look much better and uniform now.

It's worth mentioning that the serials module uses the Default 
framework when adding items. We might want to have it look for SER
or SERIAL or something like that like ACQ for Acquisitions. Just
a note though."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:52:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:52:54 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-uy30hP4H8H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it looks like bug number confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 20 23:56:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 21:56:50 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10538-70-HKG0k6MJCz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:01:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:01:01 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-29j1Gj7AgR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

--- Comment #12 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22119
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22119&action=edit
[PASSED-QA] Bug 10908 - fix broken LDAP

Recent changes to LDAP broke auth_by_bind in many situations. This bug
resets the behaviour to what it used to be, however also allows the new
behaviour by adding the 'anonymous_bind' parameter to the LDAP config.

Testing:
    1) Find an LDAP configuration that was broken recently that uses
       auth_by_bind
    2) Apply this patch
    3) See if it works again.
Additionally, testing the original path in the case of 'anonymous_bind'
being set should probably be done too, but I have no idea about the LDAP
server config for that.

Signed-off-by: Ulrich Kleiber <ulrich.kleiber at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:04:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:04:08 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-PHinG9RP3Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21652|1                           |0
           is patch|                            |
  Attachment #21652|0                           |1
        is obsolete|                            |
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:07:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:07:21 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-2QC0iK4d2k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22043|0                           |1
        is obsolete|                            |

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22120
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22120&action=edit
Silence uninitialized value $pki_field warning (and another one)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:15:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:15:48 +0000
Subject: [Koha-bugs] [Bug 569] Searches need 'browse' option
In-Reply-To: <bug-569-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-569-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-569-70-4shTerm175@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=569

Denise <d.gavio at aarome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.gavio at aarome.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:17:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:17:10 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-qQRSeQIxpX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:19:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:19:12 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-FkNZk048AZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21653|0                           |1
        is obsolete|                            |

--- Comment #13 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22121
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22121&action=edit
[PASSED-QA] Bug 10908 - restore docs on principal_name

Signed-off-by: Ulrich Kleiber <ulrich.kleiber at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:19:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:19:32 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-SXa6oQfRiI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:31:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:31:03 +0000
Subject: [Koha-bugs] [Bug 8067] HTML blocks in sysprefs should be definable
 for multiple languages
In-Reply-To: <bug-8067-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8067-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8067-70-8xVU02XI7n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8067

--- Comment #1 from D Ruth Bavousett <druthb at gmail.com> ---
In talking with Owen and Kyle about this, the best bet is probably to yank the
relevant System Prefs out of the systempreferences table, and creating their
own table with the identifier (same as in systempreferences), branch, language,
and value, and use a cascading scheme like with circ prefs.

Then, hack getsystempreference into a new function to use the new table.

Also, we'll need an editor.  And the updatedatabase for this will need to copy
existing ones into the new table, with contexts Branch * and Language *

The prefs we'll need to do this with are:
IntranetmainUserblock
IntranetNav
LibraryName
opaccredits
opacheader
OpacMainUserBlock
OpacMainUserBlockMobile
OpacNav
OpacNavBottom
OpacNavRight
OPACNoResultsFound
OPACResultsSidebar
OPACSearchForTitleIn
PatronSelfRegistrationAdditionalInstructions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:40:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:40:10 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-LQmcCGRvjU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22122
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22122&action=edit
Bug 10694 - Allow arbitrary backdating of returns - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:40:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:40:22 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-iFvjKDX4l3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:41:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:41:20 +0000
Subject: [Koha-bugs] [Bug 10694] Allow arbitrary backdating of returns
In-Reply-To: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10694-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10694-70-3fjd6AgUlP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10694

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22122|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22123
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22123&action=edit
Bug 10694 - Allow arbitrary backdating of returns - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:43:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:43:41 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-DgpbslI1Ex@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22124
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22124&action=edit
Bug 11086 : Follow up, editing the database files also

These changes are only for a new install, I decided it wasn't safe to
change it for an update. It would overwrite any local translations
people had made.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:46:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:46:20 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-WBFlkki7Nc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ed.veal at bywatersolutions.co
                   |                            |m

--- Comment #7 from Ed Veal <ed.veal at bywatersolutions.com> ---
I tested this bug in both Chrome and Firefox 24 (on a mac). It worked in Chrome
but in firefox I got the following error when doing step 4 of the test plan. 

http://edveal.test.bywatersolutions.com/cgi-bin/koha/sco/undefined

An error has occurred
Error 404

    This error means that the link was broken and that the page doesn't exist.
    To report this error, you can email the Koha Administrator.
    Return to the catalog home page.


Ed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:54:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:54:19 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-3iXlIYojdm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:59:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:59:05 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-BbvoBhPbcS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 00:59:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 22:59:08 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-kSTGWEtnL8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #7 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Created attachment 22125
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22125&action=edit
Bug 11077: Uninitialized value $pki_field warning

During login at the Staff interface you get warnings in the logs
regarding an uninitialized value for the $pki_field variable.

To test:
- tail -f /path/to/your-intranet-logs
- Point your browser to your staff login page
- Login
- Three warnings are showed
- Apply the patch
- Log out
- Log in
- No new warnings, and you can still log in.

Thanks
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com>

Followed test plan; it works as advertised.
Also works when I deleted AllowPKIAuth system pref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:00:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:00:50 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-wGUnFv2GIT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:00:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:00:53 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-04hHKY77G9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22116|0                           |1
        is obsolete|                            |
  Attachment #22117|0                           |1
        is obsolete|                            |

--- Comment #8 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22126
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22126&action=edit
Bug 10016: force zero browser-side caching of SCO pages

This patch makes the web-based self-check module pages
specify that no browser (or proxy caching) occur at all.
This prevents a security issue where letting the SCO session time out,
then hitting the back button allowed one to view the previous
patron's session.

This patch adds an optional fifth parameter to output_with_http_headers(),
and output_html_with_http_headers(), a hashref for miscellaneous
options.  One key is defined at the moment: force_no_caching, which if
if present and set to a true value, sets HTTP headers to specify no
browser caching of the page at all.

To test:

[1] Start a web-based self-check session and optionally perform
    some transactions.
[2] Allow the session to time out (it may be helpful to set
    SelfCheckTimeout to a low value such as 10 seconds).
[3] Hit the back button.  You should not see the previous patron's
    self-check session.
[4] Verify that prove -v t/Output.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:00:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:00:59 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-BiQiE3PfIm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22127
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22127&action=edit
bug 10016: munge history in SCO to discourage resubmitting user login

This patch uses history.replaceState (introduced in HTML5) to manipulate
the browser history to encourage returning to the SCO patron barcode
form if the back button is used.

Note that a side effect of this patch is that if the user uses
the help link, they will be prompted to enter their barcode
again.  It may be better to put the help inline with the rest
of the SCO forms.

To test:

[1] Start a web-based self-check session.
[2] Enter a patron barcode.
[3] Allow the self-check session to time out.
[4] Use the back button.  You should get the patron barcode
    entry form; you should not be prompted to resubmit form input.
[5] Enter a patron barcode, perform some transactions, then
    use the finish button.
[6] Next, use the back button.  You should get the patron barcode
    entry form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:05:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:05:54 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-ABN5zDE4SO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
2nd try

I did a clean install of master+10486.

When starting pazpar2 I get

20131020 19:58:03 koha-pazpar2-ctl.kohadev: client (pid 516) exited with 1
status
20131020 19:58:03 koha-pazpar2-ctl.kohadev: client (pid 517) exited with 1
status
20131020 19:58:03 koha-pazpar2-ctl.kohadev: client (pid 518) exited with 1
status
20131020 19:58:03 koha-pazpar2-ctl.kohadev: client (pid 519) exited with 1
status
20131020 19:58:03 koha-pazpar2-ctl.kohadev: client (pid 520) exited with 1
status
20131020 19:58:03 koha-pazpar2-ctl.kohadev: terminating too quickly, waiting 30
seconds

on koha-pazpar2daemon.err, and

</icu_chain>
19:58:03-20/10 pazpar2 [fatal] ICU chain definition error
19:58:03-20/10 pazpar2 [warn] Element normalize is deprecated. Use transform
instead
19:58:03-20/10 pazpar2 [warn] Element normalize is deprecated. Use transform
instead
19:58:03-20/10 pazpar2 [warn] Missing attribute rule for element index
19:58:03-20/10 pazpar2 [fatal] Could not parse ICU chain config:
<icu_chain>
 ... 

on koha-pazpar2daemon-output.log

Q: Is there any documentation of how to enable/configure pazpar2?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:07:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:07:59 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-4sdUPTgN2c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #41 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:
 * passes koha-qa.pl
 * translatable strings are correctly managed
 * works as expected
 * handles nicely various cases, depending on the permissions the librarian has

well done

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:09:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:09:46 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-04Xn6illGO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21254|0                           |1
        is obsolete|                            |

--- Comment #42 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22128
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22128&action=edit
Bug 9780 : Restric the right to suppress a record used in some order

Currently, anyone can suppress a record used in an order.
With this patch, only librarians with managing order permission can suppress it
if it is used in an active or a deleted order.
This patch also add a specific warning informing that deleting a record used in
an active order is dangerous.

To test :
A. test what can do and see a librarian with order managing rights
0) Connect to Koha with a borrower with order managing rights
1) in a basket, create 2 orders A & B from new records
2) delete order B
3) in the catalogue, try to suppress
- record used for order A : you should see a specific warning informing you the
record is used in 1 order, and that deleting it is dangerous
- record used for order B : you should see a specific warning informing you the
record is used in 1 deleted order
- a record not used in any order : you should see no specific warning

B. test what can do and see a librarian without order managing rights
4) Connect to Koha with a borrower without order managing rights
5) in a basket, create 2 orders A & B from new records
6) delete order B
7) in the catalogue, try to suppress
- record used for order A : you should see a specific warning informing you you
need specific rights to suppress the record
- record used for order B : idem
- a record not used in any order : you should see no specific warning

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:10:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:10:06 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-noZQhik9h0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #10 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22129
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22129&action=edit
[SIGN-OFF]bug 10016: munge history in SCO to discourage resubmitting user login

This patch uses history.replaceState (introduced in HTML5) to manipulate
the browser history to encourage returning to the SCO patron barcode
form if the back button is used.

Note that a side effect of this patch is that if the user uses
the help link, they will be prompted to enter their barcode
again.  It may be better to put the help inline with the rest
of the SCO forms.

To test:

[1] Start a web-based self-check session.
[2] Enter a patron barcode.
[3] Allow the self-check session to time out.
[4] Use the back button.  You should get the patron barcode
    entry form; you should not be prompted to resubmit form input.
[5] Enter a patron barcode, perform some transactions, then
    use the finish button.
[6] Next, use the back button.  You should get the patron barcode
    entry form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:14:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:14:38 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-qSgwILV2AC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:14:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:14:41 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-foAlBHmDrT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22126|0                           |1
        is obsolete|                            |
  Attachment #22127|0                           |1
        is obsolete|                            |
  Attachment #22129|0                           |1
        is obsolete|                            |

--- Comment #11 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22130
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22130&action=edit
Bug 10016: force zero browser-side caching of SCO pages

This patch makes the web-based self-check module pages
specify that no browser (or proxy caching) occur at all.
This prevents a security issue where letting the SCO session time out,
then hitting the back button allowed one to view the previous
patron's session.

This patch adds an optional fifth parameter to output_with_http_headers(),
and output_html_with_http_headers(), a hashref for miscellaneous
options.  One key is defined at the moment: force_no_caching, which if
if present and set to a true value, sets HTTP headers to specify no
browser caching of the page at all.

To test:

[1] Start a web-based self-check session and optionally perform
    some transactions.
[2] Allow the session to time out (it may be helpful to set
    SelfCheckTimeout to a low value such as 10 seconds).
[3] Hit the back button.  You should not see the previous patron's
    self-check session.
[4] Verify that prove -v t/Output.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:16:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:16:34 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-enAaWVHrWi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22130|0                           |1
        is obsolete|                            |

--- Comment #12 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22131
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22131&action=edit
Bug 10016: force zero browser-side caching of SCO pages

This patch makes the web-based self-check module pages
specify that no browser (or proxy caching) occur at all.
This prevents a security issue where letting the SCO session time out,
then hitting the back button allowed one to view the previous
patron's session.

This patch adds an optional fifth parameter to output_with_http_headers(),
and output_html_with_http_headers(), a hashref for miscellaneous
options.  One key is defined at the moment: force_no_caching, which if
if present and set to a true value, sets HTTP headers to specify no
browser caching of the page at all.

To test:

[1] Start a web-based self-check session and optionally perform
    some transactions.
[2] Allow the session to time out (it may be helpful to set
    SelfCheckTimeout to a low value such as 10 seconds).
[3] Hit the back button.  You should not see the previous patron's
    self-check session.
[4] Verify that prove -v t/Output.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:16:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:16:43 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-GXArsBFI2e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #13 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22132
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22132&action=edit
[SIGN-OFF]bug 10016: munge history in SCO to discourage resubmitting user login

This patch uses history.replaceState (introduced in HTML5) to manipulate
the browser history to encourage returning to the SCO patron barcode
form if the back button is used.

Note that a side effect of this patch is that if the user uses
the help link, they will be prompted to enter their barcode
again.  It may be better to put the help inline with the rest
of the SCO forms.

To test:

[1] Start a web-based self-check session.
[2] Enter a patron barcode.
[3] Allow the self-check session to time out.
[4] Use the back button.  You should get the patron barcode
    entry form; you should not be prompted to resubmit form input.
[5] Enter a patron barcode, perform some transactions, then
    use the finish button.
[6] Next, use the back button.  You should get the patron barcode
    entry form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:17:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:17:39 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-SRsPaM8Jo3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
 FAIL   C4/SIP/ILS.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                Compilation failed in require 
                Global symbol "$self" requires explicit package name 
   OK     critic

 FAIL   C4/SIP/ILS/Patron.pm
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                C4/SIP/ILS/Patron.pm had compilation errors.
                Global symbol "$self" requires explicit package name 
   OK     critic

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:20:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:20:06 +0000
Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session
In-Reply-To: <bug-10952-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10952-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10952-70-2YpblT1CKf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:20:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:20:10 +0000
Subject: [Koha-bugs] [Bug 10952] Store anonymous search history in session
In-Reply-To: <bug-10952-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10952-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10952-70-Phn9fCYiMk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10952

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21550|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22133
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22133&action=edit
[PASSED QA] Bug 10952: Store anonymous search history in session

Storing search history into cookie can cause problems, due to the size
limitation of 4KB.
The solution here is to store search history into the CGI::Session
object, so there is no size limitation (but anonymous search history
still remember up to 15 requests max.)

Test plan:
- Go to OPAC in anonymous mode.
- Check that the "Search history" link is *not* shown in the top right
  corner of the page
- Make some searches on /cgi-bin/koha/opac-search.pl
- The "Search history" link must appear. Click.
- Your search history must be displayed.
- Try to log in with invalid username/password
- Go back to search history, it's still there
- Now log in with valid username/password
- Your anonymous search history must be saved into your own search
  history.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors

Well, search history saving is similar before and after patch.
i.e. anonmymous search is saved when user logs in, but cookie
KohaOpacRecentSearches is empty.
Shows current an previous session searches

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
All tests and QA script pass, works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:24:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:24:06 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-vcWeFpCGvh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21652|0                           |1
           is patch|                            |
  Attachment #21652|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:24:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:24:21 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-K5WHD93Ifx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22119|1                           |0
           is patch|                            |
  Attachment #22119|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:27:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:27:11 +0000
Subject: [Koha-bugs] [Bug 9780] Restric the right to suppress a record used
	in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-JFdnUxkSwS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is one small thing with this \n in the message will create trouble in
Pootle and can't be translated correctly to be line breaks. What I would do is
split those messages up or take the \n out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:27:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:27:22 +0000
Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 -
	DB update
In-Reply-To: <bug-10970-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10970-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10970-70-unzs0v8caJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21601|0                           |1
        is obsolete|                            |

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Created attachment 22134
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22134&action=edit
Bug 10970 - Update MARC21 frameworks to Update Nr. 17 - DB update

Database counterpart of Bug 10962. Updates existing MARC21
default frameworks to Update Nr. 17 (September 2013)

To test
1) Apply patch
2) run updatedatabase.pl
3) Verify new subtags

biblio
    015_q 020_q 024_q 027_q 800_7 810_7 811_7 830_7

authorities
    020_q 024_q

Signed-off-by: David Cook <dcook at prosentient.com.au>

Adds the fields indicated and specified at the LOC website:
http://www.loc.gov/marc/status.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:32:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:32:30 +0000
Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb
	setup
In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8773-70-YOObIgxgsj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:32:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:32:36 +0000
Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb
	setup
In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8773-70-n4AznNVex1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21704|0                           |1
        is obsolete|                            |

--- Comment #38 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22135
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22135&action=edit
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
using a new(ly introduced) /etc/default/koha-common config file that
can be used for other stuff too, and is the Debian way of handling
init scripts control variables[1].

Also provide command line tools to manage the running indexer daemons
for your instances.

Long:

Using an indexing daemon avoids launching a new interpreter each time
the cron triggers the indexing, and also allows sub-minute incremental
reindexing, a requirement from our librarians.[2]

Using the indexer daemon should remain "experimental" so is disabled by
default. To enable the use of the indexer the user has to tweak the
/etc/default/koha-common config file (introduced by this patch). Specifically
the USE_INDEXER_DAEMON variable, which is clearly explained in the file.

Update frecquency defaults to 30 sec, and can be changed by tweaking the
/etc/default/koha-common config file too.

This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3],
but could be easily adjusted to use another if we got a new one (SolR?).
As Robin proposed it checks for availability of the relevant files before
trying to spawn the daemon.

If there's something I could change to make this patches better just let me
know.

Note: there was a problem Robin found regarding the spawned processes
forgetting
the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version
with the inclusion of the 'export' keyword for the relevant variables.

Edit: fixed koha-create to call the koha-indexer script instead, and added
-q to make koha-inxeder quiet (useful for the init script).

Regards
To+

[1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html
[2] This is the .deb version of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519
[3] The default cronjob that is set using the debian/koha-common.cron.d file
is being disbaled by this patch to avoid collision.

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:35:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:35:57 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-KB9VsC4Dir@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:36:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:36:00 +0000
Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english
	templates
In-Reply-To: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9218-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9218-70-ww8OgdIJFy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21874|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22136
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22136&action=edit
[PASSED QA] Bug 9218: intranet cart email broken for non english templates

This patch adapts the method from OPAC to the staff interface (cf bug 8062).

Test plan:
- add somes notices to the cart
- try to send the cart by email
- the email should be the same as before
- translate templates and retry with another language. Before this patch,
  the email was empty. With this patch, it contains the list of records
  and items.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Passes all tests and QA script.
Fixes quite a bad translation problem, tested with German templates
and umlauts in the message and records.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:36:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:36:27 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-AR4BYW4waS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21652|0                           |1
        is obsolete|                            |
  Attachment #22121|0                           |1
        is obsolete|                            |

--- Comment #14 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22137
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22137&action=edit
[PASSED-QA] Bug 10908 - fix broken LDAP

Recent changes to LDAP broke auth_by_bind in many situations. This bug
resets the behaviour to what it used to be, however also allows the new
behaviour by adding the 'anonymous_bind' parameter to the LDAP config.

Testing:
    1) Find an LDAP configuration that was broken recently that uses
       auth_by_bind
    2) Apply this patch
    3) See if it works again.
Additionally, testing the original path in the case of 'anonymous_bind'
being set should probably be done too, but I have no idea about the LDAP
server config for that.

Signed-off-by: Ulrich Kleiber <ulrich.kleiber at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:36:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:36:37 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-Y4kjr3fiD3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

--- Comment #15 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22138
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22138&action=edit
[PASSED-QA] Bug 10908 - restore docs on principal_name

Signed-off-by: Ulrich Kleiber <ulrich.kleiber at bsz-bw.de>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:45:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:45:30 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-SSvm4rqJZe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:45:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:45:59 +0000
Subject: [Koha-bugs] [Bug 10970] Update MARC21 frameworks to Update Nr. 17 -
	DB update
In-Reply-To: <bug-10970-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10970-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10970-70-Gceb1rPFwJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10970

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:54:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:54:54 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-mj7iUrc7oB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 01:54:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 20 Oct 2013 23:54:57 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-TFCiXD23vO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22139
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22139&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:05:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:05:12 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-akTAXMChgu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22131|0                           |1
        is obsolete|                            |
  Attachment #22132|0                           |1
        is obsolete|                            |

--- Comment #14 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22140
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22140&action=edit
[PASSED-QA] Bug 10016: force zero browser-side caching of SCO pages

This patch makes the web-based self-check module pages
specify that no browser (or proxy caching) occur at all.
This prevents a security issue where letting the SCO session time out,
then hitting the back button allowed one to view the previous
patron's session.

This patch adds an optional fifth parameter to output_with_http_headers(),
and output_html_with_http_headers(), a hashref for miscellaneous
options.  One key is defined at the moment: force_no_caching, which if
if present and set to a true value, sets HTTP headers to specify no
browser caching of the page at all.

To test:

[1] Start a web-based self-check session and optionally perform
    some transactions.
[2] Allow the session to time out (it may be helpful to set
    SelfCheckTimeout to a low value such as 10 seconds).
[3] Hit the back button.  You should not see the previous patron's
    self-check session.
[4] Verify that prove -v t/Output.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:05:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:05:21 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-84YVIBoIEY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

--- Comment #15 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22141
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22141&action=edit
[PASSED-QA] bug 10016: munge history in SCO to discourage resubmitting user
login

This patch uses history.replaceState (introduced in HTML5) to manipulate
the browser history to encourage returning to the SCO patron barcode
form if the back button is used.

Note that a side effect of this patch is that if the user uses
the help link, they will be prompted to enter their barcode
again.  It may be better to put the help inline with the rest
of the SCO forms.

To test:

[1] Start a web-based self-check session.
[2] Enter a patron barcode.
[3] Allow the self-check session to time out.
[4] Use the back button.  You should get the patron barcode
    entry form; you should not be prompted to resubmit form input.
[5] Enter a patron barcode, perform some transactions, then
    use the finish button.
[6] Next, use the back button.  You should get the patron barcode
    entry form.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:05:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:05:51 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-ymeH24ZZ51@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:09:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:09:51 +0000
Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed
In-Reply-To: <bug-2499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2499-70-Abp5XoBZ62@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:09:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:09:53 +0000
Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed
In-Reply-To: <bug-2499-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2499-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2499-70-C7wzYdhwJm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22142
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22142&action=edit
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:15:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:15:58 +0000
Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible
In-Reply-To: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11066-70-1QQlru4Sxs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:23:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:23:28 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-VW47VcS9BW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:28:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:28:08 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-UyL7qZTkW1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:28:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:28:10 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-YPOdIay1xu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22143
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22143&action=edit
Bug 10445 - SIP Server doesn't respect maxoutstanding system preference - QA
Followup

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:28:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:28:31 +0000
Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap
In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10309-70-vMrLw7kVoz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11090

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:28:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:28:31 +0000
Subject: [Koha-bugs] [Bug 11090] New: Bootstrap theme: CSS problem with
 suggestions toolbar links
Message-ID: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

            Bug ID: 11090
           Summary: Bootstrap theme: CSS problem with suggestions toolbar
                    links
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/opac-suggestions.pl
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 10309

The toolbar links on the OPAC suggestions page doesn't look correct in the
Bootstrap theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:46:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:46:31 +0000
Subject: [Koha-bugs] [Bug 8067] HTML blocks in sysprefs should be definable
 for multiple languages
In-Reply-To: <bug-8067-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8067-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8067-70-DAmhlWdI8D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8067

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I think the CSS and JS ones should be included as well. For example: Use
OPACUserCSS to load an alternate image which contains translated text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:46:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:46:35 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9593-70-RUA6ofSvxf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #43 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: nice patch, but one question: why did you put 
+            ( $subfield_value ) = $subfield_value =~ m/(\d[\d\,\. ]*\d{0,2})/;
+            # remove comma,dot or space when used as separators from hundreds
+            $subfield_value =~s/[\,\. ](\d{3})/$1/g;
+            # convert comma to dot to ensure correct display of decimals if
existing
+            $subfield_value =~s/,/./;

outside from MungeMarcPrice, it should be here as well, because it's related to
discovering & retrieving the price from the MARC field
So I think it should go here

Otherwise :
 * great regexp description !
 * patch does not apply anymore due to updatedatabase changes

Failing QA, answer my question 1, provide an updated patch if my point is
relevant and switch back to signed off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:47:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:47:29 +0000
Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used
 in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-nl9hQ3ZtoU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Restric the right to        |Restrict the right to
                   |suppress a record used in   |suppress a record used in
                   |some order                  |some order

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:48:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:48:29 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-I7OqjEw0j7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #37 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Paola Rossi from comment #34)
> Under Debian 7.1 wheezy, the master 3.13.00.021 displays the expected
> results: in output, the diacritic for ? is correct.
<snip>
> So I don't sign off the patch.


Paola, I don't understand : you say "the diacritic is correct" then "I don't
sign off the patch". Did you wanted to say "I sign off the patch" ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:53:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:53:06 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-CckVQiY86A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment :
 * passes koha-qa.pl
 * no side effect (I've checked that MARC21 links are still working)
 * fixes a bug

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:54:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:54:39 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-TcSpfnMkI9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:54:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:54:43 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-xSCbBgi6xt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21779|0                           |1
        is obsolete|                            |

--- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22144
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22144&action=edit
Bug 10982 Link to IFLA UNIMARC documentation in Cataloging

In Cataloging, a ? documentation page on IFLA web site. The current
implementation rely on the tag tab to select the appropriate IFLA
documentation web page. It doesn't work when UNIMARC tag are displayed
in a tab which digit is different for tag first digit.

To reproduce the bug:

  - Modify default framework, put all 200 subfields in tab 1
  - Add a new biblio record
  - Click on ? on 200 field
   => Wrong IFLA page is opened

Apply the patch and retry...

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Simple fix. Work as described. No koha-qa errors

Test on UNIMARC install
1) Switched all 2xx tags to tab 1
2) press any 2xx ?, wrong page
3) patch applied
4) links are now correct

Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:58:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:58:02 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-3axvcLdY1f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19203|0                           |1
        is obsolete|                            |
  Attachment #22143|0                           |1
        is obsolete|                            |

--- Comment #8 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22145
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22145&action=edit
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system
preference

The system preference 'maxoutstanding' is defined as the maximum amount
of fees owed by the patron before Koha should block placing holds (
terrible naming on this one ).

However, although the Koha OPAC respects this preference, placing holds
via a SIP2 device will not.

Test Plan:
1) Set maxoutstanding to $10
2) Pick a patron owning more than $10 in fees
3) Attempt to place a hold for this patron from a SIP2 device
   This attempt should succeed
4) Apply this patch
5) Restart your SIP2 server
6) Attempt to place a hold for this patron from a SIP2 device again
   This attempt should now fail

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 02:59:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 00:59:57 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-yHz1ZnIziw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22120|0                           |1
        is obsolete|                            |

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 22120
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22120
Silence uninitialized value $pki_field warning (and another one)

Looks like the other signed off patch obsoletes this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 03:00:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 01:00:10 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-J4vcl4hwZJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22145|0                           |1
        is obsolete|                            |

--- Comment #9 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22146
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22146&action=edit
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system
preference

The system preference 'maxoutstanding' is defined as the maximum amount
of fees owed by the patron before Koha should block placing holds (
terrible naming on this one ).

However, although the Koha OPAC respects this preference, placing holds
via a SIP2 device will not.

Test Plan:
1) Set maxoutstanding to $10
2) Pick a patron owning more than $10 in fees
3) Attempt to place a hold for this patron from a SIP2 device
   This attempt should succeed
4) Apply this patch
5) Restart your SIP2 server
6) Attempt to place a hold for this patron from a SIP2 device again
   This attempt should now fail

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 03:00:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 01:00:19 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-HehMxxSa0P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

--- Comment #10 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22147
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22147&action=edit
[PASSED-QA] Bug 10445 - SIP Server doesn't respect maxoutstanding system
preference - QA Followup

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Followup to failed QA tests have helped pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 03:00:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 01:00:36 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-NUngk9TM5y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 03:26:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 01:26:08 +0000
Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible
In-Reply-To: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11066-70-dNDvPR0A5t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |joy at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:52:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:52:10 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-BcfAhhjb1c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22095|0                           |1
        is obsolete|                            |

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22148
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22148&action=edit
Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:52:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:52:34 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-OR9cp8y0iP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22149
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22149&action=edit
Bug 11086 : Fixing some grammatical mistakes in member-flags and tools-home

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:53:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:53:26 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-ZiQnh3uKBR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22124|1                           |0
           is patch|                            |
  Attachment #22124|0                           |1
        is obsolete|                            |
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:53:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:53:45 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-WLlVPZDyuE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:55:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:55:53 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-jZ6446kmor@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #7 from Brendan Gallagher <brendan at bywatersolutions.com> ---
During the process of teaching David Noe I inadvertently labeled the second
patch with the wrong title.  I will fix that up in the morning.

-Brendan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:56:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:56:04 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-lLiJZB7NRl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 05:56:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 03:56:17 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-I1Xbm2sGeK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 08:05:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 06:05:45 +0000
Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records
In-Reply-To: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10421-70-l0U0t8v2OH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hello
unimarc is dealing with deleted record exactly the same way (pos 5 of label =
d). I read it in french version of manual. of course it must be checked in
english version, but it probably means this dev could and should be made marc
agnostic.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 08:09:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 06:09:21 +0000
Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used
 in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-F9i6qgLyjR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #44 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #43)
> There is one small thing with this \n in the message will create trouble in
> Pootle and can't be translated correctly to be line breaks. What I would do
> is split those messages up or take the \n out.


I cannot deal with today. we can get rid of /n.
I have seen /n in other javascript alert in Koha. Is it something to fix?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 09:40:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 07:40:10 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To: <bug-7419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7419-70-RlHiNR588A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

stephane.delaune at biblibre.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephane.delaune at biblibre.c
                   |                            |om

--- Comment #41 from stephane.delaune at biblibre.com ---
Created attachment 22150
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22150&action=edit
works with Julian Maurice patchs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 09:48:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 07:48:22 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To: <bug-7419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7419-70-JMQXNfispx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

--- Comment #42 from stephane.delaune at biblibre.com ---
Hi, I test this to dedup authorities. I begin with the 4 Jared patches (
attachment.cgi?id= 18713 20783 20784 20785 ) : this dev is more complete but
didn't work to dedup my authorities.

So I tested The 3?Julian's patches + 1 mine ( attachment.cgi?id= 17790 17791
17792 22150 ) : this dev is less complete (take only authorities) but works to
dedup my authorities

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 10:05:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 08:05:33 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9593-70-y4NKMVlCQE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21477|0                           |1
        is obsolete|                            |

--- Comment #44 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 22151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22151&action=edit
Bug 9593 Prices not imported correctly from a staged file

I did as you suggested and rebased. (Indeed,I could not remember any reason why
I put it outside if ever so !).

Olivier Crouzet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 10:06:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 08:06:14 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9593-70-rYo5nFGyqo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 11:19:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 09:19:31 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-sbPHcf8c8I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #38 from Paola Rossi <paola.rossi at cineca.it> ---
(In reply to Paul Poulain from comment #37)
> (In reply to Paola Rossi from comment #34)
> > Under Debian 7.1 wheezy, the master 3.13.00.021 displays the expected
> > results: in output, the diacritic for ? is correct.
> <snip>
> > So I don't sign off the patch.
> 
> 
> Paola, I don't understand : you say "the diacritic is correct" then "I don't
> sign off the patch". Did you wanted to say "I sign off the patch" ?

Kind Paul, I wanted to say:
"I don't sign off the patch"
because the master was already OK without applying the patch: the master didn't
show diacritics badly.
I write the details of my test, because the bug could appear in another case,
or in another install.
In my opinion, with the test required I couldn't know if the patch fixed a bug
or not, neither if it really improved master in some way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 11:53:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 09:53:36 +0000
Subject: [Koha-bugs] [Bug 11091] New: limits in catalog search when creating
	subscription
Message-ID: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

            Bug ID: 11091
           Summary: limits in catalog search when creating subscription
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

When creating a new subscription, you can click on "Search for Bilbio" to
search into catalog.
A popup opens with a text field for search terms and a combo-box to limit
search.
This combo-box uses the syspref AdvancedSearchTypes to know what list of values
display.
The bug is that the code acts has if AdvancedSearchTypes has always one value,
but since Bug 7031, this syspref can have several values.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 11:53:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 09:53:47 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-Rh5b83QANM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9223

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 11:53:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 09:53:47 +0000
Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in
	suggestions
In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9223-70-xigu2WSIDa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11091

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 12:18:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 10:18:59 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-qfqDfMIia9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co
                   |ity.org                     |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22152
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22152&action=edit
Bug 11091 - limits in catalog search when creating subscription

See commit message

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 12:19:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 10:19:44 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-l5OcCWRjql@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

--- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22153
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22153&action=edit
Bug 11091 - peltidy on serials/subscription-bib-search.pl

Follow-up : only formatting code

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 12:19:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 10:19:58 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-3R5mB8DPaP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 14:00:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 12:00:32 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-CYBaVaX55E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Adding dateformat to template vars is not necessary in addorderiso2709.pl : 
  $template->param(dateformat => C4::Context->preference('dateformat'));
It is already done in C4/Auth.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 14:33:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 12:33:35 +0000
Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script
In-Reply-To: <bug-7419-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7419-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7419-70-k2itEp2EtI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

--- Comment #43 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to stephane.delaune from comment #42)
> Hi, I test this to dedup authorities. I begin with the 4 Jared patches (
> attachment.cgi?id= 18713 20783 20784 20785 ) : this dev is more complete but
> didn't work to dedup my authorities.

What results did you see?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 14:40:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 12:40:31 +0000
Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen
In-Reply-To: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10531-70-xccbljAO24@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Amit from comment #6)
> Hi Jonathan,
> 
> I cannot find any error in this patch. Can you please explain me in detail. 
> Mean while i am changing the status of the patch.

Amit,
To reproduce: Open firebug, Go on acqui/parcel.pl?invoiceid=X, you will see a
JS error: "TypeError: a.aoColumns[c] is undefined".
When you add a new column in a table managed by DataTables, you should adapt
the aoColumns values.

Back to assigned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 14:41:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 12:41:04 +0000
Subject: [Koha-bugs] [Bug 10531] Basket name and PO number on receipt screen
In-Reply-To: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10531-70-G0calDmgDw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10531

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |amitddng135 at gmail.com
                   |ity.org                     |
         QA Contact|amitddng135 at gmail.com       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 14:49:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 12:49:00 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-uylBkdT7Tl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 14:49:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 12:49:06 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-EoAU8O4snJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21977|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22154
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22154&action=edit
Bug 9830: Fix some indexes in UNIMARC item indexing

[typo fixed in commit message ; steps 6 and 7 added in test plan]

With this combination of sysprefs, and a UNIMARC configuration, it impossible
to search on location, barcode and ccode indexes :

QueryWeightFields          is activated
QueryAutoTruncate          only if * is added

But in UNIMARC, location, barcode and ccode (995 $e,$f,h) are indexed only as
"words". They need to be indexed also as "phrase"
Additionnaly, in UNIMARC, information about damaged and withdrawn status of
items is not indexed, while it is done in MARC21.
This patch
- add 2 new indexes for 995$1 (damaged) and 995$3 (withdrawn)
- index location, barcode and ccode as "phrase" as well as "words"
indexing of items in UNIMARC could be improved later. So this patch also add
comments explaining the origin of Koha 995, I think it could be usefull for
further changes.

To test, on a UNIMARC configuration :
A. indexed with GRS-1
1) set sysprefs QueryWeightFields as "activated" and QueryAutoTruncate as "only
if * is added"
2) select location index in advanced search and search for a value existing in
your records in 995$e => 0 results
3) Apply patch
4) Rebuild zebra
5) select location index in advanced search and search for a value existing in
your records in 995$e => x results
6) mark an item as withdrawn ; search "withdrawn:1" => x results, and among
them the biblio to which the item is attached
7) mark an item as damaged ; search "damaged:1" => x results, and among them
the biblio to which the item is attached

B. indexed with DOM
Do the same operations

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Work as described. No koha-qa errors

Test
Apply the patch
Begin with GRS-1
Full reindex
Search by location, no results
cp files biblio-*-indexdefs.xml and record.abs to destination on etc/zebra
Full reindex
Search by location, got results

Switch to DOM
reset files
Full reindex
Search by location, no results
cp files
Full reindex
Search by location, results !

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:03:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:03:43 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-o3yCnsi2K9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

Dobrica Pavlinusic <dpavlin at rot13.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:08:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:08:43 +0000
Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7720-70-EdKP01M0YW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21374|0                           |1
        is obsolete|                            |

--- Comment #60 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22155
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22155&action=edit
Bug 7720 - Ambiguity in OPAC Details location.

Currently, in opac-detail.pl, there exists a column named 'Location'.
This column lists the name of the holding branch, and the item's
location description. This can cause confusion to borrowers, as
they may assume that the holding branch is the *owning* branch
(homebranch) of an item.

This could cause a situation where a borrower waits for an
item to be returned to his or her library, only to find that
the library never owned that item, and it was transferred back
to it's homebranch. It could also lead a borrower to falsely
assume that his or her home library does not own a copy of a
particular item because the borrower does not see an his or her
home library listed for any of the items on the record.

In addition, even when the holding branch is different
than the home branch, the item's shelving location is displayed,
even though that branch may not use that location.

This commit makes the item details table equivilent to the intranet
details page by adding a "Home Library" column, which displays the
item's home library, as well as the shelving location.

If singleBranchMode is enabled, this column disappears and the
"Location" column displays the shelving location only.

This commit adds two new system preferences:

OpacLocationBranchToDisplay, which defines whether
to display the holding library, the home library,
or both for the opac details page.

OpacLocationBranchToDisplayShelving, which defines
where the shelving location should be displayed,
under the home library, the holding library, or both.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Comment: Work as described. Tested all variations.
No koha-qa errors.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:08:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:08:51 +0000
Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7720-70-3ULwlOrcn5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21375|0                           |1
        is obsolete|                            |

--- Comment #61 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22156
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22156&action=edit
Bug 7720 - Ambiguity in OPAC Details location - QA Followup

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:22:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:22:51 +0000
Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location.
In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7720-70-fwUJlpqSry@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

--- Comment #62 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Works as described. Code looks good to me. 
Passed QA

Just a few side-notes:
Can we prevent constructions like 
[% IF ( Branches.GetURL( ITEM_RESULT.homebranch ) ) %]
    <a href="[% Branches.GetURL( ITEM_RESULT.homebranch ) %]">[%
Branches.GetName( ITEM_RESULT.homebranch ) %]</a>
making repeated calls to same function?

The code for showing shelf loc also relies heavily on having 1) the shelf loc
obviously, 2) having auth val LOC on that field and 3) in that particular
framework. I had something in location, but it would not show up until I
realized that the biblio was in another framework :)

GetURL includes a statement:
 return encode( 'UTF-8', $b->{'branchurl'} );
It works, but (outside the scope of this report) it would be even better if we
should not need them at that spot. Referring further to encoding
problems/discussions..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:33:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:33:35 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-0zLE1NJOgi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22157&action=edit
Bug 11037 Remove non-existent subs from Biblio's @EXPORT

No code implements the subs Get and TransformHtmlToMarc2
so dont export them into users' namespace

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:33:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:33:50 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-zhoWdjoWXf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:38:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:38:14 +0000
Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used
 in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-twpsrmRi1m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If they are not in a translated string it shouldn't cause problems. Ex.
$string .= "\n--------------------------------";
The problem is that Pootle seems to escape those automatically, so you end up
with a printed \n in translations (or at least it used to).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:40:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:40:34 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-LC9aaovyWY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---

The ?502 Bad Gateway? error that Mirko Tietgen is coming across is caused by 
not having Plack::Middleware::Debug installed. Can this be made to be a more
graceful error, or even better not be a requirement of the scripts at all? 

I see the middle as being very useful for developers, but not a requirement for
everyday running.. Correct me if I'm wrong however?

Once that's fixed, I'm happy to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:41:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:41:03 +0000
Subject: [Koha-bugs] [Bug 11092] New: Need a processing fee and billing fee
 on late notices.
Message-ID: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092

            Bug ID: 11092
           Summary: Need a processing fee and billing fee  on late
                    notices.
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: philippe.blouin at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22158
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22158&action=edit
Add a processing fee and billing fee  on late notices

This is a RFC, with a proof of concept.

Our client needed a billing fee (added to the total), a processing feed(added
to each late item) and a default replacement fee, added to the Invoice sent to
the patron.
Plus they needed to determine when to send the invoice (1st, 2nd or 3rd notice)
so we modified overduerules.tt (along with overdue_notices.pl and
overduerules.pl).

That change was made on Koha 3.10.  

**But community member kivilahtio  wanted to try it on the master.

So I attach the diffs/patches, below the DB instructions, and am now asking for
feedbacks by the community on what feature would be needed by the community,
before I bring it all cleanly to Master.

DB modifications:

alter table overduerules
  add invoice1 int(1) default 0 after debarred1,
  add invoice2 int(1) default 0 after debarred2,
  add invoice3 int(1) default 0 after debarred3;

insert into systempreferences values('InvoiceProcessingFee', 0, NULL, 'Invoice
processing fee (charged once per item)', 'Float'); 
insert into systempreferences values('InvoiceBillingFee', 0, NULL, 'Invoice
billing fee (charged once per bill)', 'Float'); 
insert into systempreferences values('DefaultReplacementPrice', 10.0, NULL,
'Amount to use when the item has none associated to it.', 'Float');

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:41:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:41:39 +0000
Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on
	late notices.
In-Reply-To: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11092-70-ncmEtw3hBq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092

--- Comment #1 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22159&action=edit
Add a processing fee and billing fee  on late notices

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:42:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:42:07 +0000
Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on
	late notices.
In-Reply-To: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11092-70-yMQbo2Uw47@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092

--- Comment #2 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22160
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22160&action=edit
Add a processing fee and billing fee  on late notices

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:42:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:42:28 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-j6oqdfPiDe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pants, just spotted that I created the small follow-up patch..  Can't really
sign off then.  I'll bully someone at kohacon13 hackfest if the change is made
quick enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 15:48:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 13:48:05 +0000
Subject: [Koha-bugs] [Bug 7710] multiple holds per title
In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7710-70-oIvCeFc9wj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #56 from Amber Hunt <amber at marlboro.edu> ---
I agree that we should system preference it. I would like to see one of the
override syst pref apply to it or have a new override syst pref that would
allow librarians in the staff side to override the syst pref when needed. 

It could be set up however AllowHoldsPoliciyOverride and AllowOnShelfHolds
interact.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 16:07:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 14:07:15 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-3IImTsfb47@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Still nobody working on that?

Mathieu

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 16:27:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 14:27:03 +0000
Subject: [Koha-bugs] [Bug 11093] New: Using "Keywords to MARC mapping"
 double the display of subtitle in non XSLT search (Unimarc)
Message-ID: <bug-11093-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11093

            Bug ID: 11093
           Summary: Using "Keywords to MARC mapping" double the display of
                    subtitle in non XSLT search (Unimarc)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

I tried to use "Keywords to MARC mapping" to define 200e = subtitle (unimarc).
It doubles the display of subtitle in non-XSLT list search.
As "Keywords to MARC mapping" must be used (if I understand well) for taking
advantage of bug 10672, this is an issue.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 16:28:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 14:28:04 +0000
Subject: [Koha-bugs] [Bug 11093] Using "Keywords to MARC mapping" doubles
 the display of subtitle in non XSLT search (Unimarc)
In-Reply-To: <bug-11093-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11093-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11093-70-0sy3HAdBKV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11093

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Using "Keywords to MARC     |Using "Keywords to MARC
                   |mapping" double the display |mapping" doubles the
                   |of subtitle in non XSLT     |display of subtitle in non
                   |search (Unimarc)            |XSLT search (Unimarc)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 17:30:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 15:30:09 +0000
Subject: [Koha-bugs] [Bug 10908] Fix broken auth_by_bind LDAP mode
In-Reply-To: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10908-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10908-70-HzykqCeufc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10908

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #16 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Robin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 17:32:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 15:32:59 +0000
Subject: [Koha-bugs] [Bug 11037] C4::Biblio exports non-existent subroutines
In-Reply-To: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11037-70-eRxyPYHkV3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 17:41:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 15:41:21 +0000
Subject: [Koha-bugs] [Bug 9830] Some UNIMARC item indexes could be broken
 whith Queryweightfields syspref
In-Reply-To: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9830-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9830-70-w5NgHemgXR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9830

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #17 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Mathieu!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 17:58:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 15:58:47 +0000
Subject: [Koha-bugs] [Bug 11080] Add system preference to not charge fines
	for grace days
In-Reply-To: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11080-70-s5skIw5Oe5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11080

--- Comment #2 from Peggy Thrasher <p.thrasher at dover.nh.gov> ---
Yes!  That looks great.  Thanks, Katrin

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:05:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:05:55 +0000
Subject: [Koha-bugs] [Bug 8070] <pre> block produced by showmarc.pl really
 not good in RTL languages
In-Reply-To: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8070-70-dtZvz4vL4j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8070

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Ruth!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:08:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:08:15 +0000
Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form
	in OPAC
In-Reply-To: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10750-70-03u1057lnA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Dani Elder <dani at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:08:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:08:36 +0000
Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form
	in OPAC
In-Reply-To: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10750-70-9qmMXubIGu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20450|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:08:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:08:46 +0000
Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form
	in OPAC
In-Reply-To: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10750-70-niZNMKrC0u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22161
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22161&action=edit
Bug 10750: Correct capitalization on suggestion form in OPAC

Create a new suggestion from your patron account in the OPAC.
Verify that all strings are correctly capitalized on the form
and submit buttons.

- Copyright date
- Standard number ... and other
- Submit your suggestion

Signed-off-by: Dani Elder <dani at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:10:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:10:07 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-VHyB7ATOvI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:10:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:10:19 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-Bx9nmPp5PR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22162
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22162&action=edit
Housebound module for v3.6

Conflicts:
    admin/systempreferences.pl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:10:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:10:57 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-M1it0yCqvl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22163
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22163&action=edit
Added syspref for housebound previously issued items

Conflicts:
    C4/Circulation.pm
    koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:11:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:11:18 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-1Q9moPOzpu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22164
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22164&action=edit
Remove unused variables from C4::Housebound

localized lexical vars to where they are used
Avoided unnecessary method calls
Remove a finish
No need to interpolate to constant strings
Fix some violations of perlstyle

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:11:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:11:36 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-D09TxNLc1c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22165&action=edit
Commit Housebound Updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:19:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:19:27 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-ndATeyiT7P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #5 from David Noe <drnoe at bywatersolutions.com> ---
Tool needs to be able to delete biblios with items (and the items). Also, it
should be able to run in a test mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:26:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:26:00 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-nAEAGitbaE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Patches submitted on behalf of Colin and Mark...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:27:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:27:05 +0000
Subject: [Koha-bugs] [Bug 10891] Make facets customisable (umbrella report)
In-Reply-To: <bug-10891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10891-70-a35Z8WujTR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891

James Weinheimer <weinheimer.jim.l at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |d.gavio at aarome.org,
                   |                            |weinheimer.jim.l at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:30:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:30:13 +0000
Subject: [Koha-bugs] [Bug 11094] New: Bootstrap theme: typo loaction
Message-ID: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094

            Bug ID: 11094
           Summary: Bootstrap theme: typo loaction
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Small typo on opac-user.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:32:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:32:04 +0000
Subject: [Koha-bugs] [Bug 11080] Add system preference to not charge fines
	for grace days
In-Reply-To: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11080-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11080-70-YR3DzvH6GH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11080

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking "RESOLVED" - please just reopen when it doesn't work like you need it
to.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:32:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:32:30 +0000
Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction
In-Reply-To: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11094-70-N9oWHuYPmw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22166
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22166&action=edit
Bug 11094 - Bootstrap theme: typo loaction

This patch fixes a typo on opac-user.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:33:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:33:28 +0000
Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction
In-Reply-To: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11094-70-9q0mT8THau@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 18:56:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 16:56:44 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-p8NMpA22as@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #12 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Edgar Fu? wrote me. He is no working on Koha.
So, could an other dev take in charge this feature?

Mathieu

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:00:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:00:34 +0000
Subject: [Koha-bugs] [Bug 4809] Lost & Paid For doesn't record payment
In-Reply-To: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4809-70-EMomTDZU1X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
In master, if I mark it lost and paid for, I get the charge added, and it is
checked in

However it is not marking the charge paid for.

Testing with other syspref settings now.

So from owens list

1, 2, and 3 are working. It is just 4 (the item being paid for) that is not yet
working

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:02:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:02:34 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-FDtYHrtiCp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

--- Comment #3 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Maybe that SHOULD work without this line, but it does not. I checked it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:09:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:09:43 +0000
Subject: [Koha-bugs] [Bug 4809] Lost & Paid For doesn't record payment
In-Reply-To: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4809-70-kKK6zTkFKJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
I see why this isn't working, the lost values are totally editable (Authorised
Values) so all values of Lost get treated the same.

If we made it be a magic number, we would then have to make it no longer
editable. I don't think we can safely do this with the drop down. I think we
would have to add a checkbox. Mark it lost, and choose the paid for checkbox.

Then it wouldn't break whenever anyone changed the authorised values.

How does that sound?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:10:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:10:56 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-lD33dH07lp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to mathieu saby from comment #12)
> Edgar Fu? wrote me. He is no working on Koha.
> So, could an other dev take in charge this feature?
> 
If you find me some funding, I'd be more than happy to

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:12:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:12:30 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-p0fFAsgIeY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:12:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:12:35 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-MljWQoiOE3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22167
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22167&action=edit
Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages

The right-to-left CSS copied over from the prog theme does is not
relevant to the redesigned templates. This patch updates the OPAC's
right-to-left CSS and adds a couple of other right-to-left CSS files to
override the default Bootstrap and jQueryUI CSS.

To my eye this looks correct, but I don't speak Arabic.

To test you must have a set of right-to-left templates, like
ar-Arab, installed for the Bootstrap theme. At this time it is necessary
to download the po file to your misc/translator/po directory. Again
using ar-Arab as an example:

http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po

Install the translation.

Open the OPAC, switch to that right-to-left language, and reload to
refresh the changed CSS. Confirm that it looks like right-to-left is
working.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:16:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:16:32 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-vN8YfWlHpO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Chris Cormack from comment #13)
> (In reply to mathieu saby from comment #12)
> > Edgar Fu? wrote me. He is no working on Koha.
> > So, could an other dev take in charge this feature?
> > 
> If you find me some funding, I'd be more than happy to

Maybe the work made here can be reused. I'm taking a look...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:23:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:23:34 +0000
Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used
 in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-MPgMF4ZgcG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #46 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Katrin Fischer from comment #45)
> If they are not in a translated string it shouldn't cause problems. Ex.
> $string .= "\n--------------------------------";
> The problem is that Pootle seems to escape those automatically, so you end
> up with a printed \n in translations (or at least it used to).

I'm suppressing that.
But a grep gave me an other '\n' in js in modules/calendar.inc. Maybe it needs
to be fixed too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:26:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:26:20 +0000
Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction
In-Reply-To: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11094-70-xhep7nSwhs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094

William <wcarlin at washoecounty.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |wcarlin at washoecounty.us

--- Comment #2 from William <wcarlin at washoecounty.us> ---
Please add a detailed commit message with a test plan.  we are new patch
testers and this would help us out.
Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:30:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:30:54 +0000
Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used
 in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-2cFHUs17TG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #47 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22168
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22168&action=edit
[PATCH 2] Bug 9780 QA Followup : suppress line feeds in javascript

This patch suppress \n in javascript, in order to keep Pootle quiet.

String patch, no need to test I think.
But if you want to test, replay the test plan of main patch, and check the
messages in javascript alert are displaying the right way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:32:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:32:57 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-qSCAXILD1a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22167|0                           |1
        is obsolete|                            |

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22169
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22169&action=edit
[SIGNED-OFF] Bug 11060 - Bootstrap theme: Incorrect rendering for right to left
languages

The right-to-left CSS copied over from the prog theme does is not
relevant to the redesigned templates. This patch updates the OPAC's
right-to-left CSS and adds a couple of other right-to-left CSS files to
override the default Bootstrap and jQueryUI CSS.

To my eye this looks correct, but I don't speak Arabic.

To test you must have a set of right-to-left templates, like
ar-Arab, installed for the Bootstrap theme. At this time it is necessary
to download the po file to your misc/translator/po directory. Again
using ar-Arab as an example:

http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po

Install the translation.

Open the OPAC, switch to that right-to-left language, and reload to
refresh the changed CSS. Confirm that it looks like right-to-left is
working.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

As far as I can tell it looks very well.
No koha-qa errors

1) Downloaded arabic bootstrap PO
2) Installed ar-Arab language, enabled on OPAC
3) Tested as anonymous user and logged in one, all pages look
well: cart, advanced search, user tabs.

I sent an email to Karam Qubsi asking his opinion.
But for me it's ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:34:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:34:22 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-sD39nmkySW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

--- Comment #40 from Nicole C. Engard <nengard at gmail.com> ---
nevermind - fixed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:34:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:34:57 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-pvJdTMmPGE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:43:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:43:16 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-ld3TivR4aX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:43:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:43:21 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-bwIEHJUmqo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22169|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22170
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22170&action=edit
Bug 11060 - Bootstrap theme: Incorrect rendering for right to left languages

The right-to-left CSS copied over from the prog theme does is not
relevant to the redesigned templates. This patch updates the OPAC's
right-to-left CSS and adds a couple of other right-to-left CSS files to
override the default Bootstrap and jQueryUI CSS.

To my eye this looks correct, but I don't speak Arabic.

To test you must have a set of right-to-left templates, like
ar-Arab, installed for the Bootstrap theme. At this time it is necessary
to download the po file to your misc/translator/po directory. Again
using ar-Arab as an example:

http://translate.koha-community.org/ar/314/ar-Arab-opac-bootstrap.po

Install the translation.

Open the OPAC, switch to that right-to-left language, and reload to
refresh the changed CSS. Confirm that it looks like right-to-left is
working.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

As far as I can tell it looks very well.
No koha-qa errors

1) Downloaded arabic bootstrap PO
2) Installed ar-Arab language, enabled on OPAC
3) Tested as anonymous user and logged in one, all pages look
well: cart, advanced search, user tabs.

I sent an email to Karam Qubsi asking his opinion.
But for me it's ok

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

I was testing this at the same time as Bernardo, so I will Pass QA on
it, instead of signing it off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 19:57:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 17:57:45 +0000
Subject: [Koha-bugs] [Bug 4809] Lost & Paid For doesn't record payment
In-Reply-To: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4809-70-Q10f8i7zKp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809

Amber Hunt <amber at marlboro.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amber at marlboro.edu

--- Comment #7 from Amber Hunt <amber at marlboro.edu> ---
I think what Chris describes will work well. It would also mean that it would
be easy to mark something previously marked lost as paid.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:06:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:06:24 +0000
Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out
In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10016-70-yXceWVsbx0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #16 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:10:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:10:00 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-LKYEL4SVXk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4067|0                           |1
        is obsolete|                            |
   Attachment #4068|0                           |1
        is obsolete|                            |
   Attachment #4781|0                           |1
        is obsolete|                            |

--- Comment #15 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22171
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22171&action=edit
[PATCH] Bug 5260 : Send basketgroup by mail to the bookseller

2 Patchs originally written by Edgar Fu? <ef at math.uni-bonn.de> in 2011
Merged, rebased and ceaned-up by Mathieu Saby on 21st oct 2013

Do not test for the moment

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:10:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:10:16 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-5Ds9vh6TSg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |In Discussion

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:10:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:10:34 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-zGYI8rGF7B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Sponsored                   |---

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:10:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:10:50 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-FX0pY1puPe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:11:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:11:00 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-FKFnwaAh3U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ef at math.uni-bonn.de         |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:11:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:11:53 +0000
Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used
 in some order
In-Reply-To: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9780-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9780-70-IVY0Yj5Lm6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780

--- Comment #48 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to mathieu saby from comment #47)
> String patch, no need to test I think.
> But if you want to test, replay the test plan of main patch, and check the
> messages in javascript alert are displaying the right way.
I've reviewed your patch, it's \n removal only, passed QA still valid imo

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:12:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:12:36 +0000
Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition
 module could order by email
In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5260-70-wKSZKi8Vc5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260

--- Comment #16 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I rebased everything and clean tabs and trailing whistepaces.
It applies, but probably won't work well, as master has evolved since 2011. So,
setting it in dissussion for the moment.

Mathieu

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:22:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:22:25 +0000
Subject: [Koha-bugs] [Bug 11060] Bootstrap theme: Incorrect rendering for
 right to left languages
In-Reply-To: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11060-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11060-70-2RIobRDd3H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11060

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:23:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:23:42 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-NL7VtjIyBF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21440|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:25:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:25:59 +0000
Subject: [Koha-bugs] [Bug 11095] New: Change text of tools menu reupload
	images
Message-ID: <bug-11095-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11095

            Bug ID: 11095
           Summary: Change text of tools menu reupload images
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: jsasse at plumcreeklibrary.net
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:27:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:27:36 +0000
Subject: [Koha-bugs] [Bug 11095] Change text of tools menu reupload images
In-Reply-To: <bug-11095-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11095-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11095-70-VTGV44MBaT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11095

Joel Sasse <jsasse at plumcreeklibrary.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Joel Sasse <jsasse at plumcreeklibrary.net> ---

test ticket, solved, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:35:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:35:56 +0000
Subject: [Koha-bugs] [Bug 11094] Bootstrap theme: typo loaction
In-Reply-To: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11094-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11094-70-lYHonqpwFU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11094

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to William from comment #2)
> Please add a detailed commit message with a test plan.  we are new patch
> testers and this would help us out.
> Thank you.

You are right :)
I'll try to find the exact situation in which this typo surfaces (found it
doing translation) and then I'll resubmit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:44:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:44:37 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-XRMmZrqYyw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22089|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22172
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22172&action=edit
Bug 11084 - Delete biblios on Leader 05 =d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case ?d? indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/deleted_fixed_field_5.pl -c -v
3) Those records should either be deleted, or an error message should
   state why the were not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:50:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:50:33 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-sKLoyhWlku@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|                            |paul.poulain at biblibre.com

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
QA Comment :
 * UNIMARC specific
 * no visible side effect, maintenance script
 * passes koha-qa.pl
 * tested by a French & an Argentina librarian, 2 different UNIMARC libraries

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:51:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:51:12 +0000
Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be
	merged
In-Reply-To: <bug-10723-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10723-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10723-70-uyD2o0qlcM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:51:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:51:58 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-94MAlYjPi3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|Trivial patch               |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:52:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:52:00 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-oiTs8De21J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14939|0                           |1
        is obsolete|                            |
  Attachment #20866|0                           |1
        is obsolete|                            |
  Attachment #20867|0                           |1
        is obsolete|                            |

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22173
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22173&action=edit
[PASSED QA]Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field
creation

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Mason James <mtj at kohaaloha.com>

Bug 9192: UNIMARC_sync_date_created_with_marc_biblio.pl field creation
(followup)

Add tests :
if field < 10 it must not have a subfield
if field > 9 is must have a subfield

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Both patches applied, no koha-qa errors.

Bug 9192: followup fix typo

Fix typo on usage message.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:55:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:55:54 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-m3Bbj4m0V0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 20:59:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 18:59:31 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-JMYrlEQvlC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #6 from Brendan Gallagher <brendan at bywatersolutions.com> ---
I think it would be better to have a widget or choice in the staff side for the
user to choose the limit of reading records to show for anonymous patron and
then have the fall back to the hardcoded limit ? 500 : 50

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:05:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:05:05 +0000
Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page
In-Reply-To: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10724-70-KvH6bKpkuo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

I agree with Katrin that the pending orders list should display the basket
group name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:08:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:08:50 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-RRLH7Uq2T9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |boutrosboutrosboutros at gmail
                   |                            |.com

--- Comment #3 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Strange, the resumptionToken request works for me, without applying the patch.

It also works after I apply the patch of course.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:09:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:09:22 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-vTnIBRuCL5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22152|0                           |1
        is obsolete|                            |

--- Comment #3 from David Noe <drnoe at bywatersolutions.com> ---
Created attachment 22174
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22174&action=edit
[SIGNED-OFF] Bug 11091 - peltidy on serials/subscription-bib-search.pl

Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:15:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:15:53 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-yS3cazT7tv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
I really like the idea for this patch, as it will mean that we only need to
manage the default framework for adding/modifying MARC fields and subfields
when doing a fresh install.

However...it seems to me that it is completely copying the subfields as is
which is different from what we're currently doing. If you run the following
SQL:

"select group_concat(frameworkcode),hidden,tagfield,tagsubfield from
marc_subfield_structure group by concat(tagfield,tagsubfield,hidden);"

You'll notice that the other sample frameworks hide different fields that the
default framework displays.

I think we can still keep the methodology set out in these frameworks, but
maybe we want to come up with some criteria (or copy the existing criteria) for
hiding subfields/fields in these other sample frameworks.

Otherwise, libraries are just going to have to customize every framework and
then it becomes pointless having "other" sample frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:16:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:16:09 +0000
Subject: [Koha-bugs] [Bug 11096] New: Koha cannot retreive big records from
	Zebra
Message-ID: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

            Bug ID: 11096
           Summary: Koha cannot retreive big records from Zebra
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

When we switched from ISO2709 to MARCXML as the default indexing format we got
rid of the errors regarding big record indexing; notably serials with lots of
items.

The problem is that the current ZOOM connection in Koha is set to retreive
records in 'usmarc'. This makes retreiving search results silently fail for big
records, and even when those records are correctly indexed, the user would fail
to reach them.

Steps to reproduce:
- Create a new simple record with 100$a = Arquitectura viva
- Add it several big note fields
- Add several items to it
- Reindex, search for Arquitectura viva
- Record doesn't show
- In a terminal, use yaz-client to do a manual query (adjust to your setup):
$ yaz-client -k 100000 unix:/home/tomas/koha-dev/var/run/zebradb/bibliosocket
> base biblios
> f @attr 1=4 @attr 4=1 @attr 6=3 "Arquitectura viva"
> s
It should fail because of the size of the record.
- Rerun like this:
> format xml
> elem marcxml
> f @attr 1=4 @attr 4=1 @attr 6=3 "Arquitectura viva"
> s
There you go :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:16:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:16:10 +0000
Subject: [Koha-bugs] [Bug 10401] Add ability to merge invoices
In-Reply-To: <bug-10401-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10401-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10401-70-q6gxGSuLmQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10401

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jared!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:18:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:18:06 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-vd5hkvmDMq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

JD at TeTakere <joanned at tetakere.org.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |joanned at tetakere.org.nz

--- Comment #14 from JD at TeTakere <joanned at tetakere.org.nz> ---
Patch didn't apply one the sandboxes. There was a conflict in updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:18:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:18:14 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-4ibJKat2cn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22152|1                           |0
        is obsolete|                            |
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:18:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:18:32 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-BovNtfDhOx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22174|1                           |0
           is patch|                            |
  Attachment #22174|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:20:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:20:16 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-WB8E90r7ax@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |paul.poulain at biblibre.com
         Depends on|                            |7688

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
After 7688 has been pushed, I think this one will become irrelevant. Switching
to "in discussion", but imo, it could be RESO WONTFIX

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:20:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:20:16 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7688-70-pWHxZDA00S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |3934

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:26:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:26:43 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-gENDkD07N7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21849|0                           |1
        is obsolete|                            |

--- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22175
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22175&action=edit
Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:29:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:29:06 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-8Ry7DAomWC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Thanks David, and I agree with you. 

This was just an idea, and I could rewrite it like auth frameworks in which we
copy most fields/subfields except obsolete ones.

But as which fields to show or hide I have no opinion (not a librarian).

Maybe you could give me some hint, and I can rewrite the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:30:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:30:26 +0000
Subject: [Koha-bugs] [Bug 8887] Search preferences: Strange behaviour with
 exact matches (default instead of custom favicon used,
 displays to much results)
In-Reply-To: <bug-8887-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8887-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8887-70-ThCfmmjcTy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8887

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #13 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:31:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:31:36 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-GsdW8ZnrN4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22152|0                           |1
        is obsolete|                            |

--- Comment #4 from David Noe <drnoe at bywatersolutions.com> ---
Created attachment 22176
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22176&action=edit
Bug 11091 - limits in catalog search when creating subscription

When creating a new subscription, you can click on "Search for Bilbio" to
search into catalog.
A popup opens with a text field for search terms and a combo-box to limit
search.
This combo-box uses the syspref AdvancedSearchTypes to know what list of values
display.
The bug is that the code acts has if AdvancedSearchTypes has always one value,
but since Bug 7031, this syspref can have several values (item types,
collection codes and locations).

This patch removes the use of AdvancedSearchTypes syspref and defines search
form with 2 limits : item types and collection codes (from authorised values
CCODE).
One or both of this information can be on biblio. Searching by location seems
to be useless because this information is always on item.
If CCODE authorised value does not exist or is empty, the collection code
filter is not displayed.

Test plan :
- Check CCODE authorised value exists with some values
- Choose a biblio indexed with both itemtype and ccode indexes
- Go to Serials module and click on "New subscription"
- In form, click on "Search for Biblio"
=> The popup "serials/subscription-bib-search.pl" appears with two limits
- Enter a word of biblio title, select its item type and select its collection
code
- Click on "Search"
=> You get the biblio

Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:31:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:31:54 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-JGa96kdJtk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22153|0                           |1
        is obsolete|                            |

--- Comment #5 from David Noe <drnoe at bywatersolutions.com> ---
Created attachment 22177
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22177&action=edit
Bug 11091 - peltidy on serials/subscription-bib-search.pl

Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:32:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:32:27 +0000
Subject: [Koha-bugs] [Bug 10653] UT : C4::RotatingCollections.pm needs unit
	tests.
In-Reply-To: <bug-10653-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10653-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10653-70-lc7PVxJl2D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10653

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #15 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:32:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:32:42 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-qZfhRo1wQW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22176|1                           |0
           is patch|                            |
  Attachment #22176|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:33:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:33:01 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-mSiTL8uFPE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22152|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:33:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:33:21 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-Gz52RvY2bo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22153|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:33:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:33:36 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-TIgZBIu5Cs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22177|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:34:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:34:11 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-RLPXSby7ju@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #16 from Blou <philippe.blouin at inlibro.com> ---
Thank you sir!  I barely had time to notice the issue email then set up my
environment to rebase, that you had already solved it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:36:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:36:52 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-gnDgBTnpCv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22152|0                           |1
        is obsolete|                            |

--- Comment #6 from David Noe <drnoe at bywatersolutions.com> ---
Created attachment 22178
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22178&action=edit
[SIGNED-OFF] Bug 11091 - limits in catalog search when creating subscription

When creating a new subscription, you can click on "Search for Bilbio" to
search into catalog.
A popup opens with a text field for search terms and a combo-box to limit
search.
This combo-box uses the syspref AdvancedSearchTypes to know what list of values
display.
The bug is that the code acts has if AdvancedSearchTypes has always one value,
but since Bug 7031, this syspref can have several values (item types,
collection codes and locations).

This patch removes the use of AdvancedSearchTypes syspref and defines search
form with 2 limits : item types and collection codes (from authorised values
CCODE).
One or both of this information can be on biblio. Searching by location seems
to be useless because this information is always on item.
If CCODE authorised value does not exist or is empty, the collection code
filter is not displayed.

Test plan :
- Check CCODE authorised value exists with some values
- Choose a biblio indexed with both itemtype and ccode indexes
- Go to Serials module and click on "New subscription"
- In form, click on "Search for Biblio"
=> The popup "serials/subscription-bib-search.pl" appears with two limits
- Enter a word of biblio title, select its item type and select its collection
code
- Click on "Search"
=> You get the biblio

Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:37:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:37:08 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-Xc8q0Ne0OD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22153|0                           |1
        is obsolete|                            |

--- Comment #7 from David Noe <drnoe at bywatersolutions.com> ---
Created attachment 22179
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22179&action=edit
[SIGNED-OFF] Bug 11091 - peltidy on serials/subscription-bib-search.pl

Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:37:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:37:52 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-TVewYMx8he@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:39:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:39:26 +0000
Subject: [Koha-bugs] [Bug 10642] Inappropriate uses of $sth->finish() in
 C4::RotatingCollections.pm
In-Reply-To: <bug-10642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10642-70-fqNbczKVkJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10642

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #7 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 21:44:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 19:44:31 +0000
Subject: [Koha-bugs] [Bug 10728] subscription-renew generates unnecessary
 warnings in logs
In-Reply-To: <bug-10728-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10728-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10728-70-yxUCVO96Du@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10728

Chris Hall <chrish at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #9 from Chris Hall <chrish at catalyst.net.nz> ---
Pushed to 3.8.x, will be in 3.8.19

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 22:47:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 20:47:15 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-9G1iKxVieI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22139|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22180&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:00:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:00:06 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-8OdUFfgsmE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment :
 * one-liner
 * I've checked that there is no other reference to yuiToolbar() in the code
 * passes koha-qa.pl

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:00:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:00:47 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-3xLBTa9J0T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21935|0                           |1
        is obsolete|                            |

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22181&action=edit
Bug 11003: JS error on the cart page

A call to yuiToolbar breaks js code on the cart page.

Test plan:
- add some biblio to your cart
- open the cart
- a js error occurs (see it with firebug):
  ReferenceError: yuiToolbar is not defined
- apply the patch
- retry and verify the error does not appear anymore.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>


 Current status: Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:05:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:05:57 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-lcSAIlB4kM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21875|0                           |1
        is obsolete|                            |

--- Comment #4 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22182
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22182&action=edit
[PASSED-QA] Bug 11002: Mandatory fields are not translatable

When the pref BorrowerMandatoryField is set and a librarian forget to
fill fields, a js popup appears with the following message:
  "The following fields are mandatory: surname, etc."
The fields are not translatable.

Test plan:
- fill the pref BorrowerMandatoryField with something like:
  title|zipcode|surname|cardnumber|branchcode
- go the members/memberentry.pl?op=add page
- verify you are not allowed to add the patron without filling all
  mandatory fields.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:06:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:06:29 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-oP4JNksehB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:09:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:09:40 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-piMtbXSwrn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

--- Comment #3 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment
 * one-liner
 * I'm wondering if it would not be better to use C4/Charset.pm   sub
SetMarcUnicodeFlag($marc_record, $marc_flavour);

for this : it raises the utf8 flag, but ALSO set UNIMARC field 100 if
applicable or position 9 of the leader for MARC21/NORMARC

Setting to "in discussion", colin, argue and/or reset status to signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:11:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:11:35 +0000
Subject: [Koha-bugs] [Bug 10905] Author tracings incorrect when
 UseAuthoritiesForTracings is turned on
In-Reply-To: <bug-10905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10905-70-2Nbq2Uj65H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21150|0                           |1
        is obsolete|                            |

--- Comment #3 from David Noe <drnoe at bywatersolutions.com> ---
Created attachment 22183
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22183&action=edit
[SIGNED-OFF] Bug 10905: Author tracings incorrect when
UseAuthoritiesForTracings is turned on

Quotation marks in MARC21slim2OPACDetail.xsl break author tracings in OPAC.
This patch fixes that.

To reproduce:
- Enable UseAuthoritiesForTracings
- Search in the OPAC and go to the detail page of a record that has links to
authorities.
- Click on the magnifier icon
- You get a 404 error page.

To test the fix:
- Apply the patch
- Search in the OPAC and go to the detail page of a record that has links to
authorities.
- Click on the magnifier icon
- You are sent to the corresponding authority record.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

http://bugs.koha-community.org/show_bug.cgi?id=10838
Signed-off-by: David Noe <drnoe at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:12:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:12:08 +0000
Subject: [Koha-bugs] [Bug 10905] Author tracings incorrect when
 UseAuthoritiesForTracings is turned on
In-Reply-To: <bug-10905-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10905-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10905-70-sM2hQT9nQ4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10905

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |drnoe at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:12:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:12:14 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-gqIaAzSJJK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22181|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22184&action=edit
[PASSED QA] Bug 11003: JS error on the cart page

A call to yuiToolbar breaks js code on the cart page.

Test plan:
- add some biblio to your cart
- open the cart
- a js error occurs (see it with firebug):
  ReferenceError: yuiToolbar is not defined
- apply the patch
- retry and verify the error does not appear anymore.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:15:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:15:45 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-gr8e4RkZij@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21901|0                           |1
        is obsolete|                            |
  Attachment #21902|0                           |1
        is obsolete|                            |
  Attachment #21903|0                           |1
        is obsolete|                            |
  Attachment #21904|0                           |1
        is obsolete|                            |
  Attachment #21905|0                           |1
        is obsolete|                            |
  Attachment #21906|0                           |1
        is obsolete|                            |
  Attachment #21907|0                           |1
        is obsolete|                            |
  Attachment #21908|0                           |1
        is obsolete|                            |
  Attachment #21909|0                           |1
        is obsolete|                            |
  Attachment #21910|0                           |1
        is obsolete|                            |
  Attachment #21911|0                           |1
        is obsolete|                            |
  Attachment #21912|0                           |1
        is obsolete|                            |
  Attachment #21913|0                           |1
        is obsolete|                            |
  Attachment #21914|0                           |1
        is obsolete|                            |
  Attachment #21915|0                           |1
        is obsolete|                            |
  Attachment #21916|0                           |1
        is obsolete|                            |
  Attachment #21917|0                           |1
        is obsolete|                            |
  Attachment #21918|0                           |1
        is obsolete|                            |
  Attachment #21919|0                           |1
        is obsolete|                            |
  Attachment #21920|0                           |1
        is obsolete|                            |

--- Comment #169 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22185&action=edit
Bug 8015 - Add MARC Modifications Templates

The MARC Modification Templates system gives Koha users
the power to make alterations to MARC records automatically
while staging MARC records for import.

This tool is useful for altering MARC records from
various venders work with your MARC framework.

The system essentially allows one to create a basic script
using actions to Copy, Move, Add, Update and Delete fields.

Each action can also have an optional condition to check
the value or existance of another field.

The Copy & Move actions also support Regular Expressions,
which can be used to automatically modify field values during the
copy/move. An example would be to strip out the '$' character
in field 020$c.

Furthermore, the value for an update can include variables
that change each time the template is used. Currently,
the system supports two variables, __BRANCHCODE__ which
is replaced with the branchcode of the library currently
using the template, and __CURRENTDATE__ which is replaced
with the current date in ISO format ( YYYY-MM-DD ).

At its simplist, it can perform functions such as:
Copy field 092$a to 952$c
At its most complex it can run actions like:
Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:16:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:16:47 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-mbJxrPjLcM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #170 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22186&action=edit
Bug 8015: Followup: FIX cp and mv if subfields don't exist.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Followup: On move, we cant delete existing fields

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:17:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:17:07 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-CgZLNSIXK4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #171 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22187&action=edit
Bug 8015 - Add MARC Modifications Templates - Followup

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:17:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:17:24 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-uCz8MMX2sz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #172 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22188&action=edit
Bug 8015: Followup Add MARC Modifications Templates

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Catch error in the SetUTF8Flag routine

The eval avoids the interface to run endlessly if an error occurred.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:17:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:17:45 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-D5kvg7HTIj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #173 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22189&action=edit
Bug 8015: Fix template capitalization amd other template issues

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix error where field object is returned instead of field value for
fields without subfields

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix bad ordering on function parameters

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Escape escape characters for strings

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix bad parameter list for direct external call to update_field

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix problem with moving existing subfield value to nonexistent
field/subfield

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: FIX QA issues

This patch fixes some stuffs failing qa tests: POD, indentation (tabs),
perlcritic

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:18:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:18:01 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-YwktvdpxHI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #174 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22190&action=edit
Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 8015: Fix complains from qa tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: Get rid of the eval in ModifyRecordWithTemplate

This patch removes the use of eval in the
C4::MarcModificationTemplates::ModifyRecordWithTemplate routine.

Now this routine call the wanted modification routine with the list of
parameters.
This call is done only if the condition is respected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: Get rid of eval for evaluating =~ m//

Koha::SimpleMarc::field_equals uses eval in order to check if a string
matches a pattern.
Now this eval is removed and the "regex" variable does not contain the
regex separated character (/ or |).

Regression: Before this patch, the user was able to user a modifier. Now
it is not possible.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = "/foo/bar/i").
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: FIX ui issue

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: The template name is a required field

Test plan:
Try to add a template with an empty string as name.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:18:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:18:13 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-v1TezeYMTa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: 
 * code removal only
 * passes koha-qa.pl (of course, considering it's removing code only)
 * regression test = everything fine if there's no language bar with the patch
(as it was without)

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:18:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:18:38 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-hK7FiGecID@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21962|0                           |1
        is obsolete|                            |

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22191&action=edit
Bug 11033 Make Save button and Cancel link always visible on basketgroup page

This patch suppress the first CSS declaration in basketgroup.tt. It was
unneeded, and was the cause of the Save button and Cancel link not being
visible if the bar for changing language was activated.

To test :
1. activate the "language" syspref, with at least 2 languages
2. open a basketgroup : the 'Save' button and 'Cancel' link are now visible at
the bottom of basketgroup page
3. Check you can use the basketgroup as before : put a basket in it, cancel,
save etc.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:19:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:19:27 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-aDAV62ZrVw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #175 from Kyle M Hall <kyle at bywatersolutions.com> ---
To help manage the large number of patches for this bug, I've squashed into
groups, those patches by the same author that were submitted sequentially.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:21:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:21:43 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-lhytgzdfIg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22180|0                           |1
        is obsolete|                            |

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22192&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:23:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:23:18 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-ag9fh0Q0RE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:28:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:28:12 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-hW3N5P9C5e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Bernardo,
failed to fix the conflict correctly I think - could you take a look and
rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:32:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:32:58 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-APaS1tVio0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:33:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:33:00 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-I2AdInaE3T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21889|0                           |1
        is obsolete|                            |

--- Comment #5 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22193&action=edit
[PASSED-QA] Bug 11015: Copyright headers are missing in some packages

This patch adds a copyright headers where don't exist in the Koha
namespace.

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:34:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:34:44 +0000
Subject: [Koha-bugs] [Bug 11033] In basketgroup pages,
 Save button and Cancel link are hidden by chooselanguage bar
In-Reply-To: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11033-70-KRghaxcVaC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Paul Poulain from comment #5)
> QA comment: 
>  * code removal only
>  * passes koha-qa.pl (of course, considering it's removing code only)
>  * regression test = everything fine if there's no language bar with the
> patch (as it was without)
> 
> passed QA

I did think of regression test ;-)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:35:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:35:00 +0000
Subject: [Koha-bugs] [Bug 11097] New: Hide duplicate patron button if logged
 in user lacks CAN_user_borrowers permission
Message-ID: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

            Bug ID: 11097
           Summary: Hide duplicate patron button if logged in user lacks
                    CAN_user_borrowers permission
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

The "duplicate patron" button is shown on in the patron toolbar (on circ and
patrons pages) even for users who lack permission to edit patrons. The display
of this button should be conditional on the logged in user having permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:37:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:37:05 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-YAS07oC6k5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22192|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22194&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:38:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:38:04 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-e4itAd9QrD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:38:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:38:07 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-unT87jXlYR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22195&action=edit
Bug 2310 - Delete grayed out w/out explanation

With some staff client menus options are displayed as disabled when the
logged in user doesn't have permission to perform that function. This
patch adds Bootstrap tooltips to patron menu items with text explaining
why they are disabled.

To test, log in as a user who lacks permission to modify patrons or set
permissions. Open a patron record in circulation or patrons. Hovering
over renew, delete, and set permissions links (in the patron toolbar
"More" menu) should trigger a tooltip with a brief explanation.

Test the "Update child to adult patron" link by viewing an adult patron.

A separate patch will address catalog menu items.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:38:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:38:17 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-AWaTdQUYjK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I'm glad that someone has worked on this issue as I was just talking about it a
few hours ago!

However:

1) There is an issue with your code in regards to "Search Category". If an item
type has a "search category" of none, it won't appear on the Advanced Search
page.

That is...if "searchcategory" is null in the database and "hideinopac" is 0,
the item type will appear.

However, if "searchcategory" is blank and "hideinopac" is 0, the item type will
be hidden. 

"searchcategory" will be blank any time an item type is saved and "None" is
selected as the Search Category. Definitely not a good thing!

There are a few other things that you will also want to consider in revising
your patch:

2) Whitespace changes should be made in a separate patch so it's easier to
separate code differences and format differences (like in kohastructure.sql).

3) You have a typo on the Add/Edit item type page
(http://devonestaff/cgi-bin/koha/admin/itemtypes.pl?op=add_form).

It says "Advanded Search" rather than "Advanced Search".

--

You might want to also consider the following:

4) Your test plan assumes that there is an authorized value category of
"DOCTYPECAT". You should mention that most users will probably have to create
this authorized value category.

Also, your test plan says to choose "Hardware" in the staff client, but the
authorized value will actually be "Anything" according to your plan. Of course,
it should be the only search category available (other than none), but the test
plan is a rather dense block of text, so I found it difficult to tell exactly
what I was supposed to see.

It might be useful to add some whitespace between the test plan steps to make
it easier to read. 

--

I'll be happy to look again once you have an updated patch! Thanks, Philippe.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:39:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:39:39 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-fCjDVjnWph@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
OR -- we could hide the menu items altogether. We do this with toolbar buttons
and global "More" menu items. Opinions?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:42:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:42:21 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-0y42cfi7kR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22194|0                           |1
        is obsolete|                            |

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22196
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22196&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:46:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:46:02 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-8ojkmEIeZO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:48:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:48:48 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-0SJaRAA5vA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
I don't know if it's worth mentioning, but I thought I'd add the following note
about indexes:

While itemtype is an index filled by the 952 and the 942, ccode is just filled
by the 952. 

--

Fridolyn: Do you have any use cases for when a person would want to limit a
"Search for Biblio" when creating a new subscription? 

I imagine it must be there for a reason, but it seems a bit strange to me to
use mainly item-based indexes when searching explicitly for a bib record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:49:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:49:20 +0000
Subject: [Koha-bugs] [Bug 11015] Copyright headers are missing in some
	packages
In-Reply-To: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11015-70-h23dHnhsmu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11015

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:50:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:50:30 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-Tzsem9yqD4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22196|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22197
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22197&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:54:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:54:11 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-j53dhHkMoE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Hmm... Upon reflection, the reason we previously didn't consider the option of
hiding menu options altogether was probably that the template couldn't handle
the logic required to hide the whole "More" menu if no options were available.
This I'm guessing is now moot, not least because the "export checked in
barcodes" item isn't controlled by any permission.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:58:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:58:27 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-bzyU94DAIS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 21 23:58:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 21:58:29 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-VYZthcNV0m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22198
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22198&action=edit
Bug 11097 - Hide duplicate patron button if logged in user lacks
CAN_user_borrowers permission

The "duplicate" button on the circ/patron toolbar should not appear if
the logged in user lacks permission to edit patron records. This patch
wraps the button in the required logic.

To test, open a patron record in circulation or patrons and view as a
staff client user who both has and doesn't have CAN_user_borrowers
permission. The button should be shown and not shown accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:02:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:02:12 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-uo4CzrN3Hd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22197|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22199&action=edit
Bug 10493 [QA follow-up] Add renewal script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:07:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:07:29 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-4V6sLkYO7Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22199|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22200
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22200&action=edit
Bug 10493 [QA follow-up] Add renewal script

Adds the new JavaScript function removeFocus() to staff-global.js
Use this function to remove the focus from any element for
repeated scanning actions on errors so the librarian doesn't
continue scanning and miss the error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:08:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:08:22 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-yE9oGELLeI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Elaine Bradtke <eb at efdss.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eb at efdss.org

--- Comment #16 from Elaine Bradtke <eb at efdss.org> ---
I have a few custom frameworks that we use - modified from those available on
the wiki. I will attach the two that I've edited. FA = Fast add - the original
one was lacking some critical fields for our library.  ART = Articles - for
periodical / journal articles the original of this was also lacking fields we
needed.  I don't know how useful they will be, ours is an unusual library. I
tried to cut out as many of the extra / obsolete fields as I could.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:10:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:10:07 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-dWKKtan3MM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22201
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22201&action=edit
Bug 6345 Add locking to rebuild_zebra

This patch adds flock based locking for rebuild_zebra.pl on a per-instance
basis.
This prevents races between full rebuilds and background incremental updates
from
the zebraqueue table in the database.

The race condition exists whether you are doing incremental updates with
a periodic cronjob or with the new daemon mode.  Suppose you start a full
rebuild
at time T0 which will take until T20 to extract the records.  Suppose also at
T10,
a biblio or auth is updated and processed through the zebraqueue by T15.
In this situation the updated record in zebra will be overwritten when
the full rebuild records are uploaded to zebra after T20.  We prevent this
by only allowing one rebuild_zebra per koha instance to be running at one time.

When running in daemon mode, incremental updates will be skipped while
a full rebuild is running, and resume afterwards.  A full rebuild or other
adhoc request will wait for any previous lock to clear.

Tested by flocking the lock file while invoking rebuild_zebra.pl in
various modes (daemon, adhoc zebraqueue task, and full rebuild) using
flock program I will attach to bug.

http://bugs.koha-community.org/show_bug.cgi?id=11078
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:10:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:10:30 +0000
Subject: [Koha-bugs] [Bug 11098] New: Label in Opac - topics on facets not
 easily css selectable
Message-ID: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

            Bug ID: 11098
           Summary: Label in Opac - topics on facets not easily css
                    selectable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: andrewlockettnz at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Label in Opac - topics on facets not easily css selectable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:10:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:10:31 +0000
Subject: [Koha-bugs] [Bug 11099] New: Label in Staff Client - series on
 facets not easily css selectable
Message-ID: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

            Bug ID: 11099
           Summary: Label in Staff Client - series on facets not easily
                    css selectable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonetem at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:10:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:10:36 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-THZmL6ZHXr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22200|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22202
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22202&action=edit
Bug 10493 [QA follow-up] Add renewal script

Adds a new Template Toolkit filter EncodeUTF8 to encode strings
to utf8 for correct display of diactritics.

Adds the new JavaScript function removeFocus() to staff-global.js
Use this function to remove the focus from any element for
repeated scanning actions on errors so the librarian doesn't
continue scanning and miss the error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:11:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:11:21 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-efQcnA5L5o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22202|0                           |1
        is obsolete|                            |

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22203
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22203&action=edit
Bug 10493 [QA follow-up] Add renewal script

Adds a new Template Toolkit filter EncodeUTF8 to encode strings
to utf8 for correct display of diactritics.

Adds the new JavaScript function removeFocus() to staff-global.js
Use this function to remove the focus from any element for
repeated scanning actions on errors so the librarian doesn't
continue scanning and miss the error.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:11:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:11:41 +0000
Subject: [Koha-bugs] [Bug 11100] New: Label in staff client - Topics on
 facets not easily css selectable
Message-ID: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

            Bug ID: 11100
           Summary: Label in staff client - Topics on facets not easily
                    css selectable
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: gmcharlt at gmail.com
          Reporter: raewyn.adams at bopdhb.govt.nz
        QA Contact: testopia at bugs.koha-community.org

Label in staff client - Topics on facets not easily css selectable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:11:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:11:42 +0000
Subject: [Koha-bugs] [Bug 11101] New: Author label in staff client not
 easily css selectable.
Message-ID: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

            Bug ID: 11101
           Summary: Author label in staff client not easily css
                    selectable.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: claire.stent at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Author label in staff client not easily css selectable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:11:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:11:59 +0000
Subject: [Koha-bugs] [Bug 11102] New: Label in Staff Client - availability
 on facets not easily css selectable
Message-ID: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

            Bug ID: 11102
           Summary: Label in Staff Client - availability on facets not
                    easily css selectable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jen.john at vodafone.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Label in Staff Client - availability on facets not easily css selectable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:12:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:12:02 +0000
Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue
In-Reply-To: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10955-70-vSCvQsRWSc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955

Elaine Bradtke <eb at efdss.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eb at efdss.org

--- Comment #3 from Elaine Bradtke <eb at efdss.org> ---
Created attachment 22204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22204&action=edit
Fast Add framework sample

Sample Fast Add framework in use at VWML

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:12:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:12:20 +0000
Subject: [Koha-bugs] [Bug 11103] New: label authors in facets not easy
	selectable
Message-ID: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103

            Bug ID: 11103
           Summary: label authors in facets not easy selectable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: maddogwilsons at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:12:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:12:22 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-t91GY8T86G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22201|0                           |1
        is obsolete|                            |

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 22201
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22201
Bug 6345 Add locking to rebuild_zebra

Oops.. wrong bug.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:12:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:12:32 +0000
Subject: [Koha-bugs] [Bug 11104] New: Label in opac topics in facets not
 easily css selectable
Message-ID: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

            Bug ID: 11104
           Summary: Label in opac topics in facets not easily css
                    selectable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: timdhannah at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:12:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:12:55 +0000
Subject: [Koha-bugs] [Bug 11105] New: label - staff client - topics on
 facets not easily css selectable
Message-ID: <bug-11105-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105

            Bug ID: 11105
           Summary: label - staff client - topics on facets not easily css
                    selectable
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: r.dustin at massey.ac.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

label - staff client - topics on facets not easily css selectable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:14:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:14:32 +0000
Subject: [Koha-bugs] [Bug 11106] New: label Sitem in facets in staff client
Message-ID: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

            Bug ID: 11106
           Summary: label Sitem in facets in staff client
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: K.Chisholm at massey.ac.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:16:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:16:08 +0000
Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue
In-Reply-To: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10955-70-F3634OoomI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955

--- Comment #4 from Elaine Bradtke <eb at efdss.org> ---
Sorry, gremlins - that attachment went to the wrong bug!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:16:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:16:53 +0000
Subject: [Koha-bugs] [Bug 11107] New: Label in staff client - authors on
 facets not easily accessible
Message-ID: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

            Bug ID: 11107
           Summary: Label  in staff client - authors on facets not easily
                    accessible
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sue.tunnicliff at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Label  in staff client - authors on facets not easily accessible

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:17:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:17:05 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-memCzULMWx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22205&action=edit
Bug 6345 Add locking to rebuild_zebra

This patch adds flock based locking for rebuild_zebra.pl on a per-instance
basis.
This prevents races between full rebuilds and background incremental updates
from
the zebraqueue table in the database.

The race condition exists whether you are doing incremental updates with
a periodic cronjob or with the new daemon mode.  Suppose you start a full
rebuild
at time T0 which will take until T20 to extract the records.  Suppose also at
T10,
a biblio or auth is updated and processed through the zebraqueue by T15.
In this situation the updated record in zebra will be overwritten when
the full rebuild records are uploaded to zebra after T20.  We prevent this
by only allowing one rebuild_zebra per koha instance to be running at one time.

When running in daemon mode, incremental updates will be skipped while
a full rebuild is running, and resume afterwards.  A full rebuild or other
adhoc request will wait for any previous lock to clear.

Tested by flocking the lock file while invoking rebuild_zebra.pl in
various modes (daemon, adhoc zebraqueue task, and full rebuild) using
flock program I will attach to bug.

http://bugs.koha-community.org/show_bug.cgi?id=11078
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

http://bugs.koha-community.org/show_bug.cgi?id=6435

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:17:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:17:44 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-JMlblLY7Pv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22044|0                           |1
        is obsolete|                            |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:17:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:17:52 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-Bsl2zy8zMX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #17 from Elaine Bradtke <eb at efdss.org> ---
I have a few custom frameworks that we use - modified from those available on
the wiki. I will attach the two that I've edited. FA = Fast add - the original
one was lacking some critical fields for our library.  ART = Articles - for
periodical / journal articles the original of this was also lacking fields we
needed.  I don't know how useful they will be, ours is an unusual library. I
tried to cut out as many of the extra / obsolete fields as I could.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:19:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:19:37 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-R80hOU07lj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:19:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:19:47 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-Sa3BeFXG5e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:20:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:20:22 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-20mRxcXDFB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #18 from Elaine Bradtke <eb at efdss.org> ---
Created attachment 22206
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22206&action=edit
Framework for articles

Sample framework for journal articles used in the VWML

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:21:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:21:11 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-BLGFWKUYmW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected to me..

Set rebuild_zebra running, and then tried to run a fruther rebuild only moments
later..  The lock was found to be present and so the rebuild did not run.

It's a simple patch, but a useful one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:22:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:22:37 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-pnMGeO78nd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

--- Comment #19 from Elaine Bradtke <eb at efdss.org> ---
Created attachment 22207
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22207&action=edit
Fast add framework sample

Fast add framework in use at VWML

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:24:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:24:42 +0000
Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue
In-Reply-To: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10955-70-hBpzMh0MNL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955

Elaine Bradtke <eb at efdss.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22204|0                           |1
        is obsolete|                            |

--- Comment #5 from Elaine Bradtke <eb at efdss.org> ---
Comment on attachment 22204
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22204
Fast Add framework sample

this was attached to the wrong bug!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:34:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:34:40 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-UZeJFcgRcz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21970|0                           |1
        is obsolete|                            |

--- Comment #102 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22208
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22208&action=edit
Bug 7684: multiple fixes for inventory

* when a file was uploaded and the comparison with catalogue range
 requested, the comparison was wrong: the logic was wrong
* items that were not supposed to be scanned (ie: supposed to be on another
shelf)
  didn't had the author and title, it was hard to retrieve them on the shelved
* some useful fields were missing, like homebranch, location, status
* the CSV export contained all the item information. It should contain the same
   informations as the screen

Behaviour now:
   * scan a list of barcode & select a range of location
   * if a barcode has been scanned and should not be (mis placed item), the
information is displayed
   * if you choose "compare barcodes list to result option", the resulting list
contains all items that have been scanned and those that were supposed to be.
Any item not in both list appears with a specific message on the last column

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:34:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:34:51 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-YAjkv8Vhv0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21971|0                           |1
        is obsolete|                            |

--- Comment #103 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22209
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22209&action=edit
Bug 7684: QA Followup and bugfixes

This followup fixes some QA issues:
- replace the MySQLism SQL_CALC_FOUND_ROWS
- use Koha::DateUtils instead of C4::Dates
- replace "branch" and "location" with "library"
- fixe wrong capitalisation on "Clear all" and "Select all"

and fixes some behaviors:
- the inventory tools can be used without barcode file (fixed for the
  csv export too).
- mark as not scanned a non scanned item.
- update the datelastseen 1 time per biblio (and fixes the displayed
  count)

Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr>

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:35:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:35:05 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-jWvKyaKQry@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:35:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:35:15 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7684-70-gFim7izMwH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21972|0                           |1
        is obsolete|                            |

--- Comment #104 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22210
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22210&action=edit
Bug 7684: Argument missing

The cgi argument in missing for routine
C4::Reports::Guided::_get_column_defs. It causes a crash on generating
the CSV file.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:36:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:36:11 +0000
Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios
In-Reply-To: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5725-70-4aOLga6qHv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725

James Weinheimer <weinheimer.jim.l at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |weinheimer.jim.l at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:37:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:37:31 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-pifxOxkT77@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:37:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:37:34 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-gWbiOLYzWJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21894|0                           |1
        is obsolete|                            |

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22211
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22211&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list
[Staff]

REBASED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:40:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:40:39 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-4liMBpJLA7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

--- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22212
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22212&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list

This patch changes the URL and data used to show the 'see also' links
on the OPAC's authority search results page.

Bonus points: makes some strings translatable.

To test:
- On your dev setup (master) create some authority records (i created personal
name authorities).
- Pick one of them and link 400$a to another one, do the same with 500$a
- Add some other 400$a and 500$a without linking (i.e. plain text)
- Make sure zebra is running and changes got indexed.
- In the OPAC search for the authority that is linked to the others.
- Check the 'see also:' link points to an authority search
- Apply the patch
- Reload/re-do the search
- Check the 'see also:' link points to the authority id in the case of linked
authorities,
  and to an authority search in the case of plain text names.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Work as described. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:41:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:41:13 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-rG8FOjfIHP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22211|0                           |1
        is obsolete|                            |

--- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Comment on attachment 22211
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22211
Bug 10691: 5xx not properly linked by authid in authority search result list
[Staff]

>From 7d62376b2e76dbed2fc45921b0a4fcbed6b9f496 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen at gmail.com>
>Date: Wed, 18 Sep 2013 12:18:20 -0300
>Subject: [PATCH] Bug 10691: 5xx not properly linked by authid in authority
> search result list [Staff]
>
>This patch changes the URL and data used to show the 'see also' links
>on the Staff's authority search results page.
>
>Bonus points: makes some strings translatable.
>
>To test:
>- On your dev setup (master) create some authority records (i created personal name authorities).
>- Pick one of them and link 400$a to another one, do the same with 500$a
>- Add some other 400$a and 500$a entries with plain text (i.e. no linking)
>- Make sure zebra is running and changes got indexed.
>- In the staff interface search for the authority that is linked to the others.
>- Check the 'see also:' link points to an authority search
>- Apply the patch
>- Reload/re-do the search
>- Check the 'see also:' link points to the authority id for linked authorities,
>  and to an authority search result in the case of plain text entries.
>- Check that the authority search from the cataloguing interface still works as usual.
>
>Regards
>To+
>
>Sponsored-by: Universidad Nacional de Cordoba
>Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
>
>Work as described. No errors
>---
> .../en/includes/authorities-search-results.inc     | 96 ++++++++++++++--------
> .../en/modules/authorities/searchresultlist.tt     |  2 +-
> 2 files changed, 63 insertions(+), 35 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
>index 2ee4571..616bb1b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc
>@@ -1,4 +1,7 @@
> [% BLOCK showreference %]
>+    [% SET authidurl = '/cgi-bin/koha/authorities/detail.pl?authid=' %]
>+    [% SET searchurl = '/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=any&operator=contains&orderby=HeadingAsc&value=' %]
>+
>     [% IF marcflavour == 'UNIMARC' %]
>         [% SWITCH type %]
>         [% CASE 'broader' %]
>@@ -11,30 +14,48 @@
>             <span class="RT">RT: [% heading | html %]</span>
>         [% END %]
>     [% ELSE %]
>-        [% IF ( label ) %]<span class="label">[% label | html %]</span>[% END %]
>+        <span class="label">
>+        [% IF ( type=='seefrom' ) %]
>+            used for/see from:
>+        [% ELSIF  ( type=='seealso' ) %]
>+            see also:
>+        [% END %]
>+        </span>
>         <span class="heading">
>-        [% IF ( linkpath && search ) %]<a href="[% link | url %][% search | url %]">[% heading | html %]</a>
>-        [% ELSE %][% heading | html %][% END %]
>+        [% IF ( type=='seealso' ) %]
>+            [% IF ( authid ) %]
>+            <a href="[% authidurl | url %][% authid | url %]">[% heading | html %]</a>
>+            [% ELSE %]
>+            <a href="[% searchurl | url %][% heading | html %]">[% heading | html %]</a>
>+            [% END %]
>+        [% ELSIF  ( type=='seealso' ) %]
>+            [% heading | html %]
>+        [% END %]
>         </span>
>-        [% UNLESS ( type=='seefrom' || type=='seealso' ) %]<span class="type">[% SWITCH type %]
>-        [% CASE 'earlier' %](Earlier heading)
>-        [% CASE 'later' %](Later heading)
>-        [% CASE 'acronym' %](Acronym)
>-        [% CASE 'musical' %](Musical composition)
>-        [% CASE 'broader' %](Broader heading)
>-        [% CASE 'narrower' %](Narrower heading)
>-        [% CASE 'parent' %](Immediate parent body)
>-        [% CASE %][% IF type %]([% type | html %])[% END %]
>-        [% END %]</span>[% END %]
>+        [% UNLESS ( type=='seefrom' || type=='seealso' ) %]
>+        <span class="type">
>+            [% SWITCH type %]
>+            [% CASE 'earlier' %](Earlier heading)
>+            [% CASE 'later' %](Later heading)
>+            [% CASE 'acronym' %](Acronym)
>+            [% CASE 'musical' %](Musical composition)
>+            [% CASE 'broader' %](Broader heading)
>+            [% CASE 'narrower' %](Narrower heading)
>+            [% CASE 'parent' %](Immediate parent body)
>+            [% CASE %][% IF type %]([% type | html %])
>+            [% END %]
>+        [% END %]
>+        </span>
>+        [% END %]
>     [% END %]
> [% END %]
> [% BLOCK authresult %]
>     [% IF ( summary.summary ) %][% summary.summary | html %]:[% END %]
>     [% UNLESS ( summary.summaryonly ) %]
>         <div class="authorizedheading">
>-        [% FOREACH authorize IN summary.authorized %]
>-          <span class="authorizedheading">[% authorize.heading | html %]</span>
>-        [% END %]
>+          [% FOREACH authorize IN summary.authorized %]
>+            <span class="authorizedheading">[% authorize.heading | html %]</span>
>+          [% END %]
>         </div>
>         [% IF ( marcflavour == 'UNIMARC' ) %]
>           [% IF summary.notes %]
>@@ -52,36 +73,43 @@
>             [% END %]
>             </div>
>           [% END %]
>-          [% IF summary.seealso %]
>-            <div class="authres_seealso">
>-            [% FOREACH see IN summary.seealso %]
>-              [% PROCESS showreference heading=see.heading label="" type=see.type search='' %]
>-              [% IF ! loop.last %] ; [% END %]
>+            [% IF summary.seealso %]
>+              <div class="authres_seealso">
>+              [% FOREACH see IN summary.seealso %]
>+                 [% PROCESS showreference heading=see.heading label="" type=see.type search='' %]
>+                 [% IF ! loop.last %] ; [% END %]
>+              [% END %]
>+              </div>
>             [% END %]
>-            </div>
>-          [% END %]
>-          [% IF summary.otherscript %]
>-            <div class="authres_otherscript">
>-            [% FOREACH other IN summary.otherscript %]
>-              [% PROCESS language lang=other.lang | trim %]:
>-              [% other.term %]
>-              [% IF ! loop.last %] ; [% END %]
>+            [% IF summary.otherscript %]
>+              <div class="authres_otherscript">
>+              [% FOREACH other IN summary.otherscript %]
>+                [% PROCESS language lang=other.lang | trim %]:
>+                [% other.term %]
>+                [% IF ! loop.last %] ; [% END %]
>+              [% END %]
>+              </div>
>             [% END %]
>-            </div>
>-          [% END %]
>-
>         [% ELSE %]
>             [% IF ( summary.seefrom ) %]
>                 [% FOREACH seefro IN summary.seefrom %]
>                     <div class="seefrom authref">
>-                    [% PROCESS showreference heading=seefro.heading label="used for/see from:" type=seefro.type search='' %]
>+                    [% PROCESS showreference
>+                        heading=seefro.heading
>+                        type=seefro.type
>+                        authid=seefro.authid
>+                    %]
>                     </div>
>                 [% END %]
>             [% END %]
>             [% IF ( summary.seealso ) %]
>                 [% FOREACH seeals IN summary.seealso %]
>                     <div class="seealso authref">
>-                    [% PROCESS showreference heading=seeals.heading label="see also:" type=seeals.type linkpath=link search=seeals.search %]
>+                    [% PROCESS showreference
>+                        heading=seeals.heading
>+                        type=seeals.type
>+                        authid=seeals.authid
>+                    %]
>                     </div>
>                 [% END %]
>             [% END %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
>index f73b819..49ba49f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
>@@ -80,7 +80,7 @@ function searchauthority() {
>     [% ELSE %]
>     <tr data-authid="[% resul.authid %]">
>     [% END %]
>-      <td>[% PROCESS authresult summary=resul.summary link="/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=any&operator=contains&orderby=HeadingAsc&value=" %]</td>
>+      <td>[% PROCESS authresult summary=resul.summary %]</td>
>       <td><a href="detail.pl?authid=[% resul.authid %]">Details</a></td>
>   [% UNLESS ( resul.isEDITORS ) %]
>       <td>
>-- 
>1.8.3.2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:41:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:41:30 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-JjHaBw9wdW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22212|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:41:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:41:46 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-FwNbyUGlAN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21895|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:42:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:42:38 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-vfqQeXWSKS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21893|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:43:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:43:51 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-CuAzJh5BiM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

--- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22213
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22213&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list

REBASED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:44:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:44:08 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-FcRzJ1abOA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

--- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22214
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22214&action=edit
Bug 10691: 5xx not properly linked by authid in authority search result list

REBASED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:44:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:44:22 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-JHz9hIbJza@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

--- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22215
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22215&action=edit
Bug 10691: Small glitch fixed

REBASED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:44:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:44:23 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-cmUIpcBZsp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
(In reply to Petter Goks?yr ?sen from comment #3)
> Strange, the resumptionToken request works for me, without applying the
> patch.
> 
> It also works after I apply the patch of course.

Thanks for that Petter. I should've written my test plan better.

In fact, it only looks like it's working.

If you insert some debugging code, you will find that the following token:

oai_dc:50:2012-09-05T13:44:33Z:2013-09-05T13:44:33Z:

is being broken into the following:

metadataPrefix = oai_dc
offset = 50
from = 2012-09-05T13
until = 44
set = 33Z

and the rest of the token will be thrown away.

--

If you re-run the test, take a look at the first result you receive in the
ListRecords response. Change your "until" date to before the datestamp of that
first result.

You will find that record still appears when it shouldn't!

--

Also, the resumption token at the bottom will be similar to the following:

oai_dc:66:2012-09-05T13:44:33Z

This looks like a resumption token with a fully formed From date. 

However, it's a token built up from those split fields I identified before. It
thinks 44 is the until datestamp and 33Z is the set. 

If you try to use that resumptionToken, you will get no results.

--

Please try it again in light of these notes. I'm sure that you'll find I'm
correct :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:45:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:45:57 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-OW7muXP1iF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22213|Bug 10691: 5xx not properly |Bug 10691: 5xx not properly
        description|linked by authid in         |linked by authid in
                   |authority search result     |authority search result
                   |list                        |list [staff]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:48:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:48:03 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-2IfgK7Ln1k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Tim Hannah <timdhannah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |timdhannah at gmail.com

--- Comment #1 from Tim Hannah <timdhannah at gmail.com> ---
Created attachment 22216
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22216&action=edit
Adds <span id... to Topics facet in opac

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:48:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:48:05 +0000
Subject: [Koha-bugs] [Bug 11103] label authors in facets not easy selectable
In-Reply-To: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11103-70-AJ3wo58CNu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103

Catherine Wilson <maddogwilsons at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |maddogwilsons at gmail.com
                   |ity.org                     |

--- Comment #1 from Catherine Wilson <maddogwilsons at gmail.com> ---
Created attachment 22217
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22217&action=edit
Add <span id... to Authors facet staff client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:51:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:51:05 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - availability on
 facets not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-cvkgmCBeiL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

--- Comment #1 from Jennifer McHardy <jen.john at vodafone.net.nz> ---
Created attachment 22218
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22218&action=edit
Label in staff client on places facets not easily css selectable

To test: 

with data that contains places, right click places heading in facets, ensure it
is wrapped in a span.

Jennifer McHardy and Gab Hikaka collaborated on this patch at Librarian to
Developer in 90 Minutes at LIANZA 2013

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:51:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:51:08 +0000
Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily
 css selectable
In-Reply-To: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11098-70-DyuMOHC9ZQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

andrewlockettnz at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |andrewlockettnz at gmail.com

--- Comment #1 from andrewlockettnz at gmail.com ---
Created attachment 22219
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22219&action=edit
patch for issue 11098

Search opac, then right-click "Topics" and select "inspect element"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:51:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:51:58 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-R6aScL7cOQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Jennifer McHardy <jen.john at vodafone.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Label in Staff Client -     |Label in Staff Client -
                   |availability on facets not  |places on facets not easily
                   |easily css selectable       |css selectable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:53:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:53:35 +0000
Subject: [Koha-bugs] [Bug 11106] label Sitem in facets in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-QFkvpb5J5y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

--- Comment #1 from K.Chisholm at massey.ac.nz ---
Created attachment 22220
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22220&action=edit
Allows the Item types facet to be CSS or JQuery selectable

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:53:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:53:45 +0000
Subject: [Koha-bugs] [Bug 11105] label - staff client - topics on facets not
 easily css selectable
In-Reply-To: <bug-11105-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11105-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11105-70-COGsoMbxiA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105

Rachel <r.dustin at massey.ac.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |r.dustin at massey.ac.nz
                   |ity.org                     |

--- Comment #1 from Rachel <r.dustin at massey.ac.nz> ---
Created attachment 22221
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22221&action=edit
Adding span to Topics

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:55:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:55:47 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-l18T0yYmd6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Sue Tunnicliff <sue.tunnicliff at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |sue.tunnicliff at gmail.com
                   |ity.org                     |

--- Comment #1 from Sue Tunnicliff <sue.tunnicliff at gmail.com> ---
Created attachment 22222
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22222&action=edit
added span to Authors facets

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:57:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:57:31 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-hTACv89wjy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

--- Comment #1 from Raewyn Adams <raewyn.adams at bopdhb.govt.nz> ---
Created attachment 22223
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22223&action=edit
Bug 11100 fixed

search in intranet, verify that Topics in the facets is wrapped in a span

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:58:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:58:05 +0000
Subject: [Koha-bugs] [Bug 11101] Author label in staff client not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-fr2ONR4lV7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

claire.stent at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |claire.stent at gmail.com
                   |ity.org                     |

--- Comment #1 from claire.stent at gmail.com ---
Created attachment 22224
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22224&action=edit
Enable facet Authors to be changed

Verify that the facet Authors is is wrapped in a span

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:58:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:58:29 +0000
Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets
 not easily css selectable
In-Reply-To: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11099-70-uIbroR45d4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

jonetem at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |jonetem at gmail.com
                   |ity.org                     |

--- Comment #1 from jonetem at gmail.com ---
Created attachment 22225
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22225&action=edit
add c-span to series facet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 00:59:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 22:59:43 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-uZYEVFDopR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
I believe this patch needs to respect the configuration directory setting for
installations. For example, if I'm installing from git, I would want the
lockfile to be in /home/koha/koha-dev/var/lock/koha_rebuild_zebra rather than
/var/lock/koha_rebuild_zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:11:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:11:13 +0000
Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily
 css selectable
In-Reply-To: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11098-70-ISE0uk0q3n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:11:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:11:16 +0000
Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily
 css selectable
In-Reply-To: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11098-70-iXYbq1RtqB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22219|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22226
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22226&action=edit
[SIGNED-OFF] Bug 11098: fixed bug in label in opac - topics on facets not
easily css selectable

Search opac, then right-click "Topics" and select "inspect element"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Please add a description of the problem and a test plan to your commit
message next time, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:15:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:15:28 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-WhmGyuNif1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22013|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22227
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22227&action=edit
Bug 11058: make variable name unique within its scope

routine declares two lexical variables named $stylesheet
rename the second to keep code clearer and
avoid propagating compile time warnings

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl, works as advertised!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:15:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:15:42 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-q5iGt1WaJ1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:17:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:17:58 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-k24aS0wgwE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22078|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22228
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22228&action=edit
Bug 11070 - typo in UNIMARC 115a plugin

In UNIMARC 115a cataloging plugin, there is a typo : "NTSC", not "NSTC" :
http://fr.wikipedia.org/wiki/Ntsc

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Simple string change.
koha-qa complains about tab errors, fixed in followup

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:18:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:18:10 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-z9aZLbZYcM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:18:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:18:12 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-FzJuTXA0VZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:18:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:18:17 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-wpECTJRxjB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22079|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22229
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22229&action=edit
Bug 11070 - followup to correct tabs

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:18:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:18:34 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-tsxwjHnzIr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:18:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:18:36 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-JDFiWJMSje@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22218|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22230
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22230&action=edit
[SIGNED-OFF] Bug 11102: fixed bug in Label in Staff Client - places on facets
not easily css selectable

Label in staff client on places facets not easily css selectable

To test:

with data that contains places, right click places heading in facets,
ensure it is wrapped in a span.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:20:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:20:08 +0000
Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-BUTSUA1C1S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
          Component|Staff Client                |Templates
            Version|unspecified                 |master
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
            Summary|label Sitem in facets in    |Label item type facet in
                   |staff client                |staff client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:23:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:23:55 +0000
Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-t6dgEn3Zja@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:23:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:23:57 +0000
Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-6iMvzX6PCY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22220|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22231
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22231&action=edit
[SIGNED-OFF] Bug 11106 - Label item type facet in staff client

Allows the Item types facet to be CSS or JQuery selectable

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:25:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:25:22 +0000
Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work
In-Reply-To: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10271-70-NexMeAflzm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21297|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22232
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22232&action=edit
Bug 10271 - An index containing ns or nb does not work

When an index does not contain a structure part, the structure "wrdl" is
automatically added and a structure is mandatory to build search query (to
convert ':' into '=').
But the code that tests that the structure is not already defined looks in
entire index string :
  $index =~ /(st-|phr|ext|wrdl|nb|ns)/
It should look for a comma followed by a structure and in the case of "nb" and
"ns" look for an exact match.
The consequence is that an index containing ns or nb or phr or etc does not
work.

This patch modifies the regexp for this part and other parts looking at
structures into index.

Test plan :
- Desactivate all searching sysprefs.
- Create a new index called "ansa" number 8999 into bib1.att, ccl.properties
and records.abs
- Index a biblio with a value on this index, ie "VALUE"
- Perform a search on this index by editing url :
http://<server>/cgi-bin/koha/catalogue/search.pl?idx=ansa&q=VALUE
=> Without patch, the search does not work. The PQF query is "@and ansa: VALUE"
=> With patch, the search works. The PQF query is "@attr 1=8999 VALUE";
- Perform same test with an index containing a structure ie "aphra"
- Set QueryAutoTruncate syspref to automatically
=> Check * is added to operand : PQF query is "@attr 1=8999 @attr 4=6 @attr 5=1
VALUE"
- You may check stopwords removal but this feature is obsolete

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Comment: as far as I can test, this works. Small tab error reported
by koha-qa, fixed in a followup.

This kind of patch is difficult to test without explicit instructions,
not everyone knows how to check what kind of PQF search is used.
I don't know. But I can test search results.

Test:
1) Deactivate search sysprefs
QueryAutoTruncate = only if * is added
QueryFuzzy = Don't try
QueryStemming = Don't try
QueryWeightFields = Disable
UseQueryParser = Do not try

2) Create new index 'ansa'
bib1.att : att 8999 ansa
ccl.properties : ansa 1=8999
records.abs : melm 999 ansa:w,ansa:p

1) and 2) from comment 3 on Bug

3) In the undestanding that index refers to field 999,
edited default framework, made 999a visible on editor

4) Edit sample record, add 'VALUE' to 999a, save, reindex

5) Search with /cgi-bin/koha/catalogue/search.pl?idx=ansa&q=VALUE
No results

6) Apply patch, repeat search
Got results

That's all I can test. If not enough for QA, then this
must wait until further and explicit test instructions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:26:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:26:14 +0000
Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work
In-Reply-To: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10271-70-3CdKHBNM1B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21298|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22233
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22233&action=edit
Bug 10271 - followup - Correct tabs

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:28:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:28:28 +0000
Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work
In-Reply-To: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10271-70-nhoM1FlAEO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Passes koha-qa.pl. Seems to work as advertised. No ill affects detected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:31:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:31:00 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-rJuaF5D3N9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments :
 * small patch, fixes a bug, nothing to highlight
 * passes koha-qa.pl

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:31:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:31:05 +0000
Subject: [Koha-bugs] [Bug 11105] label - staff client - topics on facets not
 easily css selectable
In-Reply-To: <bug-11105-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11105-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11105-70-0d8BLYc7JR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This patch adds "<span id="topics-span"> Topics</span>" whereas other patches
in this batch do something like this:

<span id="facet-Itemtypes"> Item types </span>

I think the "facet-XXX" pattern is better since it is more descriptive. It's
redundant to give an id to your span which includes the word "span."

Thanks for the patch--I hope you can submit a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:31:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:31:23 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-o0GeKikxp5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22022|0                           |1
        is obsolete|                            |

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22234
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22234&action=edit
Bug 10954 - Payment receipt does not display the payment made

When printing a payment receipt, the payment does not display, only the
total currently owed.

Test Plan:
1) Create a payment for a borrower
2) Print the payment with the "print" button to the right of the payment
3) Note the missing payment line
4) Apply this patch
5) Repeat step 2
6) Note the payment line now displays

Signed-off-by: cedric.vita at dracenie.com <cedric.vita at dracenie.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:34:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:34:05 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-I3NY0Oy4vd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Templates
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:34:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:34:53 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-2u9OoyF1xP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:34:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:34:56 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-jBTUrtfAfO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22222|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22235&action=edit
[SIGNED-OFF] Bug 11107 - Label in staff client - authors on facets not easily
accessible

Label  in staff client - authors on facets not easily accessible

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:36:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:36:11 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-ZrReii6AFT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

David Noe <drnoe at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |drnoe at bywatersolutions.com

--- Comment #10 from David Noe <drnoe at bywatersolutions.com> ---
This patch does not apply.  The change appear to have been made already.  Both
these line are in ccl.properties:

att 1011    date-entered-on-file
att 1012    Date/time-last-modified

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:39:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:39:49 +0000
Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search
	groups
In-Reply-To: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10798-70-LFlMkSzOSy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|testopia at bugs.koha-communit |paul.poulain at biblibre.com
                   |y.org                       |

--- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: trivial patch, but with tabs instead of spaces ! will pass it QA
with a follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:42:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:42:00 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-ivjkT8fV6A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:42:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:42:18 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-BzkAJM839S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:42:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:42:21 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-jZqAsfMP93@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22223|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22236&action=edit
[SIGNED-OFF] Bug 11100 - Label in staff client - Topics on facets not easily
css selectable

Search in intranet, verify that Topics in the facets is wrapped in a span

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:45:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:45:53 +0000
Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search
	groups
In-Reply-To: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10798-70-KjkBDFp60s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22237&action=edit
Bug 10798 - OPAC_SEARCH_LIMIT behaves badly with search groups

Since the addition of search groups to koha, the branch limiting
parameter in multiple PAC by URL support should also support
limiting by these search groups.  This patch adds this ability.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:46:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:46:25 +0000
Subject: [Koha-bugs] [Bug 10798] OPAC_SEARCH_LIMIT behaves badly with search
	groups
In-Reply-To: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10798-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10798-70-qxwPjF57us@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10798

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21739|0                           |1
        is obsolete|                            |

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22238&action=edit
Bug 10798 follow-up: replacing tabs by spaces

Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:47:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:47:31 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-bniMgmUQmi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:50:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:50:13 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-O3XHEwrjQi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #6 from Doug Kingston <dpk at randomnotes.org> ---
How can I get at this config parameter at runtime, or is there a install time
rewrite template I can use to ensure the directory specified is respecting the
"configuration directory setting"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:57:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:57:20 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-UlZ5kzJuH2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:57:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:57:22 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-JRoMP1dryj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21633|0                           |1
        is obsolete|                            |

--- Comment #5 from Petter Goks?yr ?sen <boutrosboutrosboutros at gmail.com> ---
Created attachment 22239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22239&action=edit
Bug 10974 - OAI-PMH Resumption Tokens Do Not Handle Time

This patch changes the value separator in OAI-PMH resumption tokens
from colons to slashes, so that the token string isn't split incorrectly
when a time is included.

TEST PLAN:

1) Turn on the OAI-PMH server syspref in Koha
2) Send a ListRecords request using 'from' and 'until' arguments that
include times (Best to use very far apart times so that you retrieve
more than 50 records which will likely be the trigger for a resumptionToken).
Here is an example:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z

N.B. Replace KOHAINSTANCE with the URL of your Koha instance.

3) Scroll down to the bottom of the page until you find the resumptionToken.
It will look similar to this:

<resumptionToken cursor="50">
oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:
</resumptionToken>

4) Copy that resumption token and send a request with it like so:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:

5) The page should (incorrectly) show no records.

6) APPLY PATCH

7) Repeat steps 2, 3, and 4

8) Note that the resumptionToken now uses slashes (e.g. /) instead of
colons.

Note also that now the second request will show records!!!

N.B. This will only happen if Koha has enough records to serve to you.
If your Koha has less than 50 records, try lowering the number provided
in the "OAI-PMH:MaxCount" system preference.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com>

I understand; I can now confirm the behaviour described in the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:58:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:58:43 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-ygiUySxwvT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 01:58:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 21 Oct 2013 23:58:45 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-UyddqH6QMv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22069|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22240&action=edit
[PASSED QA] 'Dropbox' changed to 'Book drop'

http://bugs.koha-community.org/show_bug.cgi?id=10785

Signed-off-by: KohaCon13 demo <brendan at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Checked the book drop still works, also grepped for
other appearances of the term.
Fixed capitalization.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:05:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:05:50 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-YLJwnlIB41@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #26)
> Hm, bit confused about the example values: and|And|or|Or
> 
> 1) Do we need 'And' and 'and' when the values are now case insensitive?
> >I've now taken this into account too, making it case insensitive was a great >idea!
> 
> 2) Why not list 'not'?
> 
> I will continue to test, this could go into a follow up.

Hmmm, it's passed QA now, but I was intending on posting a followup for
Katrin's comments.  The sample that should go into the sql would probably be
best as 'and|or|not' now that I've made it case insensative and the 'not' is a
good addition that I just hadn't thought of before ;)

Either way, that's very trivial and not worth losing QA for :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:06:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:06:51 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-AxEI1TxD66@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:06:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:06:54 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-rV6ifqzaMJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22076|0                           |1
        is obsolete|                            |
  Attachment #22077|0                           |1
        is obsolete|                            |
  Attachment #22203|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22241&action=edit
[PASSED QA] Bug 10493 - Add renewal script

Koha needs a renewal tool that functions similar to the returns where a
librarian can continuously scan items for renewal. This script should
block renewals that are impossible, and allow the same renewal overrides
as circulation.pl

Test plan:
 1) Apply the patches for bug 8798
 2) Apply this patch
 3) Browse to /cgi-bin/koha/circ/renew.pl
 4) Enter an invalid barcode, you should get an error message
 5) Enter a valid, but not checked out barcode, you should get an error
    message.
 6) Enter a valid barcode that is checkout out and should be renewable,
    you should get a success message.
 7) Enable AllowRenewalLimitOverride
 8) Enter a barcode for an item that has been renewed too many times
 9) You should get a warning which you can override.
10) Disable AllowRenewalLimitOverride
11) Repeat steap 8
12) You should get a blocking error message
11) Enter a barcode for an item with unfilled holds on it,
    you should get an overridable warning

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Passes all tests and QA script, some issues have been
addressed in follow-ups.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:07:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:07:09 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-qYNBcMnhpg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22242&action=edit
[PASSED QA] Bug 10493 [Template follow-up] Add renewal script

This template followup fixes some minor template errors and adds some
style to dialog buttons matching those seen on the circulation page.

To test, submit barcodes to trigger the various error conditions:
Non-existant barcode, over the renew limit, restricted patron, item on
hold. Override and Ignore buttons should be properly styled and
functional.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:07:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:07:17 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-oiv4zangP5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22243&action=edit
[PASSED QA] Bug 10493 [QA follow-up] Add renewal script

Adds a new Template Toolkit filter EncodeUTF8 to encode strings
to utf8 for correct display of diactritics.

Adds the new JavaScript function removeFocus() to staff-global.js
Use this function to remove the focus from any element for
repeated scanning actions on errors so the librarian doesn't
continue scanning and miss the error.

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
This works as described - you have to actually look at the
error and pick what you want to do or confirm it. I think
maybe tying the action to a shortcut (c = confirm or similar)
would be nice, so you can get away with only using the keyboard.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:07:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:07:24 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-B5y6BLP80L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #45 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22244&action=edit
duplication of baskets on the already-received table

In testing I discovered that the change to GetInvoiceDetails() resulted in each
order being returned multiple times if more than zero or one items was attached
to it.  I've attached a screenshot demonstrating this, and am setting this to
failed QA.

One suggestion -- leave GetInvoiceDetails alone, and use
GetItemnumbersFromOrder() to grab the list of items.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:07:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:07:37 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-ZrEqGVV6Sq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:07:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:07:54 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-MH0azfCHLs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com
         QA Contact|                            |paul.poulain at biblibre.com

--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * passes koha-qa.pl
 * works fine, except for the following glitch: let's suppose you've issue #100
missing, and #99 #101 recieved. When you change the #100 status because you get
it, the receivedlist will be #99; #101; #100, which is not perfect. But it's
better than previously, so passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:10:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:10:08 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-PGPIdSpDfk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:10:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:10:11 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-tBNrI749Eo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22236|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22245&action=edit
[PASSED QA] Bug 11100 - Label in staff client - Topics on facets not easily css
selectable

Search in intranet, verify that Topics in the facets is wrapped in a span

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Adds an id, works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:10:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:10:29 +0000
Subject: [Koha-bugs] [Bug 11108] New: undoing receiving does not appear to
 work (but actually does)
Message-ID: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

            Bug ID: 11108
           Summary: undoing receiving does not appear to work (but
                    actually does)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

If one receives an order, then after it has been marked received, undoes the
receipt by using the 'Cancel receipt' link on the already-received orders page,
when the page refreshes, the order is still displayed on that table.  It also
is displayed on the orders-to-receive table.

This is confusing; when an receipt is undone, the order should only display on
the orders-to-receive table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:11:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:11:07 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-hr1CDxlcig@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:11:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:11:10 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-CDQHYAYLHp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21960|0                           |1
        is obsolete|                            |
  Attachment #21961|0                           |1
        is obsolete|                            |

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22246&action=edit
Bug 10092: Small improvements on serial missinglist and receivedlist

Builds upon report 8896 with changes for missinglist.
Similar changes for receivedlist to be consistent.

Test plan:
Go to serial collection information.
Edit serials.
Toggle the status through all possible values.
On another tab or in the db, check missinglist and receivedlist (subscription
detail tab Summary).

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:11:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:11:19 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-phk2AOi7JV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

--- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22247
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22247&action=edit
Bug 10092 Followup for NewIssue

Same logic for new issue.
Moves the shared code to a local subroutine.

Test plan:
Add an issue via Generate Next button. No changes to missing and received.
Now add an issue via Edit Serials and Supplemental issue with status Arrived.
Check the received list.
Now add supplemental issue with status Missing or Not available.
Check the missing list.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:12:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:12:39 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-SI3dxsIpr6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:12:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:12:42 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-P4PUUn4mSA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22235|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22248
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22248&action=edit
[PASSED QA] Bug 11107 - Label in staff client - authors on facets not easily
accessible

Label in staff client - authors on facets not easily accessible

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:21:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:21:16 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-YVOqNyK20L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:21:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:21:19 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-Xcze12OdLY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

--- Comment #1 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22249
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22249&action=edit
Bug 11108: fix duplicate display of basket whose receipt has just been
cancelled

After receiving an order basket, before finishing receiving the shipment,
one has an option to cancel the receipt.  This patch fixes a bug where
a basket whose receipt was just cancelled displays on both the pending orders
and already received tabs.

This patch also fixes a minor unitialized variable warning.

To test:

[1] Create a basket with at least one order and close it.
[2] Receive the order, then on the row in the 'Already received'
    table, click the cancel receipt link.
[3] In the page that displays, the basket just cancelled displays
    on both tables.  Clicking the cancel receipt link again results
    in an error message.
[4] Apply the patch.
[5] Repeat steps 1 and 2.  This time, the cancelled basket displays
    only in the pending orders table, as expected.
[6] Verify that after applying the patch, the following no longer
    is logged in the Apache error log:

parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line...

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:22:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:22:34 +0000
Subject: [Koha-bugs] [Bug 2532] Patron-requested holds limited to one item
	per bib.
In-Reply-To: <bug-2532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2532-70-IeJOYnii35@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P5 - low
           Hardware|PC                          |All

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This bug is so old that I wonder what the original reasoning behind it was. I
assume that it was intended to prevent users from gaming the holds system by
placing holds on multiple copies at multiple locations in an attempt to improve
chances of a fast delivery (perhaps branch A will get it first for me, perhaps
branch B).

Does anyone know of a different reason?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:24:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:24:03 +0000
Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-MnwxA5d9c0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:24:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:24:11 +0000
Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-tU0fPzyOZy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22231|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22250
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22250&action=edit
[PASSED QA] Bug 11106 - Label item type facet in staff client

Allows the Item types facet to be CSS or JQuery selectable

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:26:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:26:42 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-DJuqiEM4Sf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch should affect linking of authorities where multiple similar
authorities exist, i.e.

Law Agency
Law Agency Great Britian
Law Agency Germany
Law Agency France

Before the patch, these authorities would all be matched during a search for
'Law Agency' and thus would a link would not be created.  With the patch, the
full phrase is searched correctly and so an exact match should happen, thus a
link would be created.

The overall upshot, is that if you have a catalogue liek above, then running
link_bibs script sohuld return many more posotive actions after the patch is
applied than compared to before the patch is applied

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:27:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:27:00 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-1JyKGZpdWO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:27:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:27:03 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-5hNFQXEdy4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22230|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22251
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22251&action=edit
[PASSED QA] Bug 11102: fixed bug in Label in Staff Client - places on facets
not easily css selectable

Label in staff client on places facets not easily css selectable

To test:

with data that contains places, right click places heading in facets,
ensure it is wrapped in a span.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:27:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:27:43 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-Z9tYPvksuW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22198|0                           |1
        is obsolete|                            |

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Created attachment 22252
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22252&action=edit
Bug 11097 - Hide duplicate patron button if logged in user lacks
CAN_user_borrowers permission

The "duplicate" button on the circ/patron toolbar should not appear if
the logged in user lacks permission to edit patron records. This patch
wraps the button in the required logic.

To test, open a patron record in circulation or patrons and view as a
staff client user who both has and doesn't have CAN_user_borrowers
permission. The button should be shown and not shown accordingly.

Signed-off-by: David Cook <dcook at prosentient.com.au>

I was only able to open a patron record in circulation, but it works
as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:27:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:27:43 +0000
Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing
 date and status
In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9547-70-fqp8FAUzTu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
I think the changes made in this patch might have been made obsolete now that
the patch for Bug 10737 has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:28:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:28:46 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-Xz7VhVZNlL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:30:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:30:06 +0000
Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily
 css selectable
In-Reply-To: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11098-70-MBCrWEQPKf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:30:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:30:18 +0000
Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily
 css selectable
In-Reply-To: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11098-70-40TCes3TrC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22226|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22253
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22253&action=edit
[PASSED QA] Bug 11098: fixed bug in label in opac - topics on facets not easily
css selectable

Search opac, then right-click "Topics" and select "inspect element"

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Please add a description of the problem and a test plan to your commit
message next time, thanks!

Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as expected. Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:34:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:34:19 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-9UPYJH8SbT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22252|0                           |1
        is obsolete|                            |

--- Comment #3 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22254
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22254&action=edit
[SIGN-OFF]Bug 11097 - Hide duplicate patron button if logged in user lacks
CAN_user_borrowers permission

The "duplicate" button on the circ/patron toolbar should not appear if
the logged in user lacks permission to edit patron records. This patch
wraps the button in the required logic.

To test, open a patron record in circulation or patrons and view as a
staff client user who both has and doesn't have CAN_user_borrowers
permission. The button should be shown and not shown accordingly.

Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:34:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:34:25 +0000
Subject: [Koha-bugs] [Bug 11098] Label in Opac - topics on facets not easily
 css selectable
In-Reply-To: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11098-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11098-70-1O7NarHBiW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11098

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Andrew!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:35:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:35:10 +0000
Subject: [Koha-bugs] [Bug 11102] Label in Staff Client - places on facets
 not easily css selectable
In-Reply-To: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11102-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11102-70-gfqjD5dnnT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11102

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jennifer and Gab!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:35:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:35:19 +0000
Subject: [Koha-bugs] [Bug 11101] Author label in staff client not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-zphqSkleTO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Whoops, looks like someone worked on this same issue in Bug 11103

*** This bug has been marked as a duplicate of bug 11103 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:35:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:35:19 +0000
Subject: [Koha-bugs] [Bug 11103] label authors in facets not easy selectable
In-Reply-To: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11103-70-pp3jFfDL5N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.stent at gmail.com

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 11101 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:35:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:35:21 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-EckVVR0xpY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
                 CC|                            |ed.veal at bywatersolutions.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:35:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:35:56 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-SR6smFOctf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:36:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:36:07 +0000
Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client
In-Reply-To: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11106-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11106-70-VAJs3zHN52@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Katherine!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:36:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:36:44 +0000
Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets
 not easily accessible
In-Reply-To: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11107-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11107-70-xTWnwNmDz6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Sue!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:37:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:37:20 +0000
Subject: [Koha-bugs] [Bug 11100] Label in staff client - Topics on facets
 not easily css selectable
In-Reply-To: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11100-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11100-70-BAAM5gZw7H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11100

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Raewyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:37:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:37:25 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-HLBNJiHR2W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:37:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:37:29 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-PgYBUXWixM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22255
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22255&action=edit
bug 11104: fixed bug in opac-facets.inc

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:37:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:37:41 +0000
Subject: [Koha-bugs] [Bug 11103] label authors in facets not easy selectable
In-Reply-To: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11103-70-TmK1PTZ4gD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:37:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:37:44 +0000
Subject: [Koha-bugs] [Bug 11103] label authors in facets not easy selectable
In-Reply-To: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11103-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11103-70-7UiRSDytUi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22217|0                           |1
        is obsolete|                            |

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22256
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22256&action=edit
[SIGNED-OFF] Bug 11103 - label authors in facets not easy selectable

Add <span id... to Authors facet staff client

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:39:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:39:04 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-dsvWuhJrKM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22216|0                           |1
        is obsolete|                            |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:41:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:41:24 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-C253srkvv7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #7 from Doug Kingston <dpk at randomnotes.org> ---
So there appears to be no support for this configuration right now.
Implementing probably means:
Update Makefile.export to support __RUN_DIR__
Update rewrite-config.PL to support __RUN_DIR__
Update rebuild-zebra.pl to use __RUN_DIR__ instead of /var/run

I don't think we need this step since we won't chown this directory:
Update Makefile to support KOHA_DEST_RUN_DIR

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:41:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:41:25 +0000
Subject: [Koha-bugs] [Bug 11070] typo in UNIMARC 115a plugin
In-Reply-To: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11070-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11070-70-9iOKtFOCZK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11070

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:41:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:41:28 +0000
Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets
 not easily css selectable
In-Reply-To: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11099-70-gNI0TVFwnB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:41:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:41:31 +0000
Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets
 not easily css selectable
In-Reply-To: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11099-70-uS0Kcdod3g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22225|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22257
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22257&action=edit
[SIGNED-OFF] Bug 11099 - Label in Staff Client - series on facets not easily
css selectable

add c-span to series facet

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:45:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:45:50 +0000
Subject: [Koha-bugs] [Bug 10537] Limit ability to grant permissions based on
 user's own permissions
In-Reply-To: <bug-10537-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10537-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10537-70-Lt69Ckpg0D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10537

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Super Librarian Access      |Limit ability to grant
                   |                            |permissions based on user's
                   |                            |own permissions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 02:48:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 00:48:24 +0000
Subject: [Koha-bugs] [Bug 10285] Error 500 in staff client displays old
	start page
In-Reply-To: <bug-10285-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10285-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10285-70-3Io3dXyx3a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I think this is okay. I don't think we want to display the full-styled home
page as that might be confusing. I suspect, however, that we need to update the
page to reflect changes since this was last updated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:18:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:18:24 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-lb7uxeIh7D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:18:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:18:27 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-ysGJwpncmN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22255|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22258
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22258&action=edit
[PASSED QA] Bug 11104: fixed bug in opac-facets.inc

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:22:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:22:33 +0000
Subject: [Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm
In-Reply-To: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11058-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11058-70-Jasuv35Y9H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:40:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:40:20 +0000
Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets
 not easily css selectable
In-Reply-To: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11099-70-6Ph17duKzO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:40:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:40:23 +0000
Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets
 not easily css selectable
In-Reply-To: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11099-70-BBXuZfhlF5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22257|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22259
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22259&action=edit
[PASSED QA] Bug 11099 - Label in Staff Client - series on facets not easily css
selectable

add c-span to series facet

Signed-off-by: Owen Leonard <oleonard at myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer at bsz-bw.de>
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:48:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:48:26 +0000
Subject: [Koha-bugs] [Bug 11003] JS error on the cart page
In-Reply-To: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11003-70-lECO1AT4AU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11003

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:50:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:50:27 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-pL9r8atGBi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off
            Version|master                      |3.12

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It could still be a nice enhancement for 3.12 and earlier.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 03:59:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 01:59:43 +0000
Subject: [Koha-bugs] [Bug 2532] Patron-requested holds limited to one item
	per bib.
In-Reply-To: <bug-2532-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2532-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2532-70-6NpkKft8Rg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

Bob Birchall <bob at calyx.net.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion
                 CC|                            |bob at calyx.net.au

--- Comment #3 from Bob Birchall <bob at calyx.net.au> ---
I am marking this 'In discussion.'  It is hardly new.  :)

At least one library I know of wants this enhancement.  Owen has explained that
there is concern the feature could allow gaming of the holds queue. Maybe a way
to control that could be discerned?

Should the feature be developed and a 'wait and see' approach adopted to the
gaming risk?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 07:20:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 05:20:08 +0000
Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on
	late notices.
In-Reply-To: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11092-70-b7zKzcUP6z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 22159
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22159
Add a processing fee and billing fee  on late notices

I suspect this hard-coded horror was replaced by templates. I don't know how to
apply this to the current 3.10 series.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 07:20:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 05:20:12 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-BPRTMfignw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a follow-up that ensures that the jQuery validator
plugin is used for both new, HTML5-compatible browsers and old,
non-HTML5-compatible ones.

Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 07:22:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 05:22:00 +0000
Subject: [Koha-bugs] [Bug 11099] Label in Staff Client - series on facets
 not easily css selectable
In-Reply-To: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11099-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11099-70-vJzpIb2ev4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11099

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonet!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 07:25:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 05:25:25 +0000
Subject: [Koha-bugs] [Bug 10982] Link to IFLA UNIMARC documentation in
	Cataloging
In-Reply-To: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10982-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10982-70-q3iFrRSyjf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10982

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Fr?d?ric!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 07:43:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 05:43:49 +0000
Subject: [Koha-bugs] [Bug 10785] dropbox should be book drop
In-Reply-To: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10785-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10785-70-EZCg9AQjQW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10785

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Ketan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 07:51:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 05:51:32 +0000
Subject: [Koha-bugs] [Bug 10954] Payment receipt does not display the
	payment made
In-Reply-To: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10954-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10954-70-FgZnKaya8N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10954

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 08:03:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 06:03:23 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-ZIr9j3zlkr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 08:03:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 06:03:26 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-AlBgRN1hA9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22249|0                           |1
        is obsolete|                            |

--- Comment #2 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22260
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22260&action=edit
[SIGN-OFF]Bug 11108: fix duplicate display of basket whose receipt has just
been cancelled

After receiving an order basket, before finishing receiving the shipment,
one has an option to cancel the receipt.  This patch fixes a bug where
a basket whose receipt was just cancelled displays on both the pending orders
and already received tabs.

This patch also fixes a minor unitialized variable warning.

To test:

[1] Create a basket with at least one order and close it.
[2] Receive the order, then on the row in the 'Already received'
    table, click the cancel receipt link.
[3] In the page that displays, the basket just cancelled displays
    on both tables.  Clicking the cancel receipt link again results
    in an error message.
[4] Apply the patch.
[5] Repeat steps 1 and 2.  This time, the cancelled basket displays
    only in the pending orders table, as expected.
[6] Verify that after applying the patch, the following no longer
    is logged in the Apache error log:

parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line...

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:04:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:04:59 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-HIrieQV2tW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
            Version|3.10                        |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:08:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:08:06 +0000
Subject: [Koha-bugs] [Bug 9108] Add uk/euro date sort filter to pages which
	require it
In-Reply-To: <bug-9108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9108-70-qb6iLskJw4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9108

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11059

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:08:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:08:06 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-xvb35yB64K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=9108

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:11:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:11:44 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-b2PPH2VlTp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #4 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Your patch needs a small rebase, because Bug 9108 has already added 
    [% IF (dateformat == 'metric') %]
        dt_add_type_uk_date();
    [% END %]
into addorderiso2709.tt

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:23:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:23:06 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-GJgPuakinb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:23:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:23:15 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-zh0gyIAsmz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

--- Comment #5 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #3)
> Maybe that SHOULD work without this line, but it does not. I checked it.
It works for me, in current master code.
Tested it by added in addorderiso2709.tt :
    $(document).ready(function() {
   +    alert('dateformat=[% dateformat %]');
The page displays an alert with "metric" (since I am in France).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:23:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:23:09 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-589se5LG3r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22254|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22261
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22261&action=edit
Bug 11097 - Hide duplicate patron button if logged in user lacks
CAN_user_borrowers permission

The "duplicate" button on the circ/patron toolbar should not appear if
the logged in user lacks permission to edit patron records. This patch
wraps the button in the required logic.

To test, open a patron record in circulation or patrons and view as a
staff client user who both has and doesn't have CAN_user_borrowers
permission. The button should be shown and not shown accordingly.

Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:24:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:24:51 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-AhroyoY2ub@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note:
The "Change password" button (2 lines above) is contained in a test on the
borrower permission. The test is done twice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:28:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:28:35 +0000
Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing
 date and status
In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9547-70-GN0vvEbhJQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Owen Leonard from comment #6)
> I think the changes made in this patch might have been made obsolete now
> that the patch for Bug 10737 has been pushed.

Yes, you're right.
But maybe the "Date" header in table for baskets should be renamed "Creation
date" or "Created on", and "Closed" header renamed "Closed on" ?

I mark this patch as resolved.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:29:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:29:00 +0000
Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing
 date and status
In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9547-70-GsEptmO0dP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---


*** This bug has been marked as a duplicate of bug 10737 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:29:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:29:01 +0000
Subject: [Koha-bugs] [Bug 10737] Add "Add to basket" link on vendor search
	results page
In-Reply-To: <bug-10737-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10737-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10737-70-x1MXf8NKEh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10737

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
*** Bug 9547 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:30:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:30:59 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-ZoWjszEq1o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20393|0                           |1
        is obsolete|                            |

--- Comment #11 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22262
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22262&action=edit
Bug 10740 - date created and modified indexes in ccl.properties

Patch rebased (Conflict with Bug 8252)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:31:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:31:17 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-OVUQYgD1v3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10740

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:31:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:31:17 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-s1NSH0UwkQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8252

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:31:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:31:49 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-KZK73WDTCS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:32:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:32:30 +0000
Subject: [Koha-bugs] [Bug 11109] New: import marc21 records in unimarc Koha
Message-ID: <bug-11109-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11109

            Bug ID: 11109
           Summary: import marc21 records in unimarc Koha
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

Some records suppliers or vendors are only providing MARC21 records.
For UNIMARC libraries, it is a sad situation, because they cannot use these
records.

So a new feature for importing marc21 records into UNIMARC Koha would be a good
point.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:38:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:38:40 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-DXc036Mwch@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

--- Comment #9 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to David Cook from comment #8)
> Fridolyn: Do you have any use cases for when a person would want to limit a
> "Search for Biblio" when creating a new subscription? 
> 
> I imagine it must be there for a reason, but it seems a bit strange to me to
> use mainly item-based indexes when searching explicitly for a bib record.

Yes, one of our libraries asked for this correction.
In UNIMARC configurations, some use itemtype on items to define the way they
can circulate (loan 7 days, ...) and use CCODE on biblio to define the physical
type of document (Book, DVD, ...).
Some catalogs have for the same title several records with different physical
type. That is why they want to filter when creating a subscription, specially
if there is a type for serials.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:40:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:40:12 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-eO3EDBCin6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21898|0                           |1
        is obsolete|                            |

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Comment on attachment 21898
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21898
Bug 11009 - Add hardcoded limit to OPAC reading records

Set has obsolete, should be in another bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:40:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:40:42 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-sFYrwMiHku@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:41:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:41:53 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-3VNaMXuxhH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

--- Comment #8 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
I removed follow-up (addind OPAC limit) so that this bug can focus on the
anonymous patron problem.
This follow-up may be used for a new bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:42:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:42:32 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-15jTv790W0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #12 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Fridolyn SOMERS from comment #11)
> Created attachment 22262 [details] [review]
> Bug 10740 - date created and modified indexes in ccl.properties
> 
> Patch rebased (Conflict with Bug 8252)

Hi Fridolyn
As 8252 is pushed to master, can we say that it "block" 10740 ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:47:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:47:02 +0000
Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in
 UNIMARCslim2OPACResults.xsl
In-Reply-To: <bug-10564-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10564-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10564-70-FN1lhLXc1V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564

--- Comment #6 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to mathieu saby from comment #5)
> Do you know if the changes were made too in the new bootstrap opac ?
No they didn't.
Must I make a follow-up ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:51:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:51:25 +0000
Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in
 UNIMARCslim2OPACResults.xsl
In-Reply-To: <bug-10564-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10564-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10564-70-dm8jXohSEJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Fridolyn SOMERS from comment #6)
> (In reply to mathieu saby from comment #5)
> > Do you know if the changes were made too in the new bootstrap opac ?
> No they didn't.
> Must I make a follow-up ?

We have now 3 themes for opac. That's a lot ;-)
I did not test boostrap opac. Does the xslt have something "special", or are
they a mere copy of the xslt of old opac? If so, I suppose all changes made to
old xslt should be copied to bootsrap xslt too.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 09:58:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 07:58:56 +0000
Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place
 resets to logged in branch
In-Reply-To: <bug-9993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9993-70-m4FRWpvmca@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
There should definitly be a syspref for choosing if we want to take the branch
of the user, or the branch of the basket!

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 10:09:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 08:09:28 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-9uWi7psOxv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Aur?lie Fichot <aurelie.fichot at iepg.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aurelie.fichot at iepg.fr

--- Comment #61 from Aur?lie Fichot <aurelie.fichot at iepg.fr> ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 8236:
<h1>Something went wrong !</h1>Applying: Bug 8236 Block renewing for overdue
items
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Circulation.pm
Auto-merging circ/circulation.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging members/moremember.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 8236 Block renewing for overdue items
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 8236 - Prevent renewing if overdue or restriction

21223 - Bug 8236 Block renewing for overdue items

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-8236-Block-renewing-for-overdue-items-RX74cM.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 10:10:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 08:10:05 +0000
Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page
In-Reply-To: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10724-70-boXGDzcEm7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Galen Charlton from comment #5)
> Pushed to master.  Thanks, Jonathan!
> 
> I agree with Katrin that the pending orders list should display the basket
> group name.

For me, that's simple : You need to use BG to make pdf, so for some (most?)
libraries, the main "entity" for dealing orders is BG, not Basket.
(1 BG => pdf/csv send to the vendor => matches 1 or several vendor invoices
etc)
It was very important for us to have the ability to search by BG number/name. 
We made a local patch in JS/PHP in my library for that.

So, BG number AND BG name should be displayed and searchable in every place
where basket number and basket name are.

See Bug 11027, Bug 9560, Bug 7682, Bug 9561, Bug 9808.
And when Bug 9807 is pushed, we will be able to made direct links to individual
BG (not possible now, because it reopens the BG).

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 10:14:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 08:14:47 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-VfH7csAttt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #13 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I will test your patch in a DOM UNIMARC this evening.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 10:19:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 08:19:31 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-4lQjO5I2U5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Out of the scope of your bug : 
Each time we add an new index in the list of indexes in Search.pm, my blood is
freezing :(
I know it's needed now, but would not it be more flexible (if a library wants
to add custom index) with a list stored out of Perl code, in some YAML file for
ex?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 11:28:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 09:28:37 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-oZB0CxxCUD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22012|0                           |1
        is obsolete|                            |

--- Comment #6 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 22263
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22263&action=edit
Bug 11059 Not possible to sort staged dates in metric format

Ok Fridolyn, the point is that I opened that bug and tested my patch for 3.10. 
( and in 3.10 we must change the condition in template for this :
[% IF ( dateformat_metric ) %] to make without assignment of dateformat in
addorderiso2709.pl ).
I rebased and modified for master as you suggested.

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 11:45:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 09:45:22 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-0oVoWhqLrm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21223|0                           |1
        is obsolete|                            |

--- Comment #62 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 22264
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22264&action=edit
Bug 8236 Block renewing for overdue items

patch rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 11:45:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 09:45:57 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-tnDZaw5p6o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Koha Team Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 11:49:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 09:49:01 +0000
Subject: [Koha-bugs] [Bug 11110] New: remove useless stopword table
Message-ID: <bug-11110-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11110

            Bug ID: 11110
           Summary: remove useless stopword table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

I think stopword table was used before Zebra. So now, it could be removed from
database?

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 12:06:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 10:06:09 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-Kxqf5wJgKH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #63 from Aur?lie Fichot <aurelie.fichot at iepg.fr> ---
I installed the patch and I receive a message saying to me : sandbox is not
ready! But no text of error in the body of the message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 12:14:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 10:14:19 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-djWq4ipFGP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 12:14:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 10:14:23 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-OrEapW36zA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21169|0                           |1
        is obsolete|                            |
  Attachment #21170|0                           |1
        is obsolete|                            |
  Attachment #21171|0                           |1
        is obsolete|                            |
  Attachment #21172|0                           |1
        is obsolete|                            |
  Attachment #21173|0                           |1
        is obsolete|                            |
  Attachment #21174|0                           |1
        is obsolete|                            |
  Attachment #21175|0                           |1
        is obsolete|                            |

--- Comment #66 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22265
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22265&action=edit
Bug 9811: Patron search improvement

This patch add DataTables using server-side processing for the patrons
search.

It adds:
- 1 module C4/Utils/DataTables/Members.pm
- 2 services svc/members/search and svc/members/add_to_list
- 1 template members/tables/members_results.tt
- 1 new practice which is to add template for DataTables in a
  subdirectory named 'tables'.

Impacted scripts: members/members-home.pl and members/members.pl

To go further: We can imagine that all patrons searches use the same
service with no big changes: 1 little template creates a JSON file and
to implement DataTables on the template page, that's all.

Amended patch: Since bug 10565 has been pushed, these patches don't
apply cleanly. I had to rewrite a part of the patron list feature.
I removed the choice to add all resultant patrons from a search. I think
this choice is useless with this patch: we are able to display the
number of patrons we want and to select all of them.

Test plan:
- Check that there is no regression on searching patrons.
- Try filters on the left of the screen.
- Try to sort each column.
- Try the "Browse by last name" links.
- Check that the "Clear" button clears yours filters.
- Try with IndependantBranches ON and OFF.
- Verify this feature does not break the patron list feature (cf bug
  10565).

Signed-off-by: Cedric Vita <cedric.vita at dracenie.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script, couldn't find any regressions
or problems. Some notes left on the bug.

Bug 9811: Add unit tests for C4::Utils::DT::Members

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

Bug 9811: QA followup

- removes 2 tabs
- removes mysqlisms
- add sort on borrowernotes
- fix wrong capitalization
- cat => Category

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Thx for fixing these!

Bug 9811 - multilines notes brakes JSON

In new patron search feature, the search results are fetched using Ajax and
returned in JSON format.
The JSON is created by TT using
koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/members_results.tt.
One of the fields is the borrower notes. When this notes contains several
lines, the JSON is broken.

This patch uses TT fileters to consert in notes linefeeds into HTML line break
(html_line_break) and then remove linefeeds (collapse).

Test plan :
- perform a member search that does not return a borrower with a circ note
- edit one of the borrowers returned by this search
- enter serveral lines of text in "Circulation note" and save
- reperform the member search
=> circ note is well displayed on several lines

Bug 9811: use count(primary_key) instead of count(*)

Bug 9811: A limit clause should be always added.

By default, we want to retrieve 20 first results.

Bug 9811: Load the page without any data.

Displaying the first 20 patrons is not useful. With this patch, the
table is hidden and no record is retrieved by default.
On the same way, the existing side effect on redirect disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 12:17:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 10:17:32 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-5dEE55ZKuP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #67 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Rebased and squashed patch.
A huge conflict (caused by bug 10565) appeared on rebasing so I preferred
squashing the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 12:19:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 10:19:24 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-oBZPJXRkhi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10565

--- Comment #68 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Jonathan Druart from comment #66)
> Amended patch: Since bug 10565 has been pushed, these patches don't
> apply cleanly. I had to rewrite a part of the patron list feature.
> I removed the choice to add all resultant patrons from a search. I think
> this choice is useless with this patch: we are able to display the
> number of patrons we want and to select all of them.

Kyle, could you agree or disagree with that please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 12:19:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 10:19:24 +0000
Subject: [Koha-bugs] [Bug 10565] Add a "Patron List" feature for storing and
 manipulating collections of patrons
In-Reply-To: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10565-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10565-70-Phe7xnBSJG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10565

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |9811

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:07:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:07:08 +0000
Subject: [Koha-bugs] [Bug 11111] New: The basket group is not display on the
	parcel page
Message-ID: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

            Bug ID: 11111
           Summary: The basket group is not display on the parcel page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Bug 10724 adds the search by basket group on the parcel page but does not
display it the the table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:07:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:07:21 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not display on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-MlhqGRkfgJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |10724
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:07:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:07:21 +0000
Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page
In-Reply-To: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10724-70-Lu6sSDHvOp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11111

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:09:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:09:09 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not display on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-xRhBggoDQf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:09:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:09:11 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not display on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-cwymvcO5Zc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22266
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22266&action=edit
Bug 11111: The basket group is not display on the parcel page

Test plan:
Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name
is displayed into the 2nd column.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:10:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:10:16 +0000
Subject: [Koha-bugs] [Bug 10724] Search by basket group on the parcel page
In-Reply-To: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10724-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10724-70-LSeTcqlFqR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10724

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11111                       |

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #5)
> Pushed to master.  Thanks, Jonathan!
> 
> I agree with Katrin that the pending orders list should display the basket
> group name.

Galen, I submitted a patch on bug 11111.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:10:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:10:16 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not display on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-sbcnTv13SH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|10724                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:17:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:17:40 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-mR8SWMC4DE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #15 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to mathieu saby from comment #14)
> Out of the scope of your bug : 
> Each time we add an new index in the list of indexes in Search.pm, my blood
> is freezing :(
> I know it's needed now, but would not it be more flexible (if a library
> wants to add custom index) with a list stored out of Perl code, in some YAML
> file for ex?

This is how QueryParser works. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:19:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:19:37 +0000
Subject: [Koha-bugs] [Bug 11112] New: Koha::Calendar->new loads all holidays
Message-ID: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

            Bug ID: 11112
           Summary: Koha::Calendar->new loads all holidays
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Each time a new Koha::Calendar is created, all holidays are retrieved from the
DB.
On a 3.8 installation, with 11000 holidays and without caching system, a
checkin is extremely slow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:19:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:19:53 +0000
Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays
In-Reply-To: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11112-70-Mafq41MS5Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |11061
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:19:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:19:53 +0000
Subject: [Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
In-Reply-To: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11061-70-ltHrqRFg8W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11112

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:22:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:22:16 +0000
Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays
In-Reply-To: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11112-70-gMSfw0lYAx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:22:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:22:20 +0000
Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays
In-Reply-To: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11112-70-QzdODKpBdE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22267
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22267&action=edit
Bug 11112: Koha::Calendar needs some caching

holidays is built each time a Koha::Calendar object is created.

The Koha::Calendar's builder retrieves all holidays from the database
and create a DateTime::Set object with all holidays.

In one of our customer's DB, there are 11085 special_holidays and 598
repeatable_holidays.
On a return, there are 3 calls to Koha::Calendar->new.

Nytprof benchmarks (on a 3.8.x branch):
In DateTime::Set->from_datetimes:
3 times (5.49ms+4.90s) by Koha::Calendar::_init at line 80 of Koha/Calendar.pm,
avg 1.63s/call
on a total of 7.67s (of 10.2s), executing 6353333 statements and 3031273
subroutine calls in 147 source files and 36 string evals.
for the circulation/return.pl page.

Comparing the access_log:

Without the patch:
checkout: time=2759838
checkin: time=1832751

Without the patch and with overdues:
checkout: time=1086727 + time=1144706
checkin: time=3928854 (x2)

With the patch and overdues:
checkout: time=1077839 + time=1060886
checkin: time=2420898

Test plan:
- checkout an item with a return date < today
- checkin the item and verify the suspension period is well calculated
  (depending on the holidays).
- prove t/db_dependent/Holidays.t
- t/Calendar.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:25:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:25:35 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-ulm2u9YtKS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #16 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jared Camins-Esakov from comment #15)
> (In reply to mathieu saby from comment #14)
> > Out of the scope of your bug : 
> > Each time we add an new index in the list of indexes in Search.pm, my blood
> > is freezing :(
> > I know it's needed now, but would not it be more flexible (if a library
> > wants to add custom index) with a list stored out of Perl code, in some YAML
> > file for ex?
> 
> This is how QueryParser works. :)

Great! So when we decide that pre-QP search could be deprecated, this piece of
code could be delete I imagine?
But, is there a similar operation to do in QP conf to declare the new index, or
is it automatic?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:25:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:25:45 +0000
Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays
In-Reply-To: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11112-70-5siQ1No0wf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22268
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22268&action=edit
Benchmark scripts

You can test the proposed patch with this script:
perl benchmarks.pl
git bz apply 11112
perl benchmarks.pl 1 # The parameter flag tells the patch is applied.

And compare the durations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:35:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:35:52 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-vUA1mMDOu3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #17 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to mathieu saby from comment #16)
> Great! So when we decide that pre-QP search could be deprecated, this piece
> of code could be delete I imagine?

Yup. We talked about that at the hackfest on Sunday.

> But, is there a similar operation to do in QP conf to declare the new index,
> or is it automatic?

There is a similar configuration required: you have to add your new index to
etc/searchengine/queryparser.yaml.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:47:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:47:26 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-s2IqRdnKkF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #152 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
I also have conflict in sysprefs:

CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:49:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:49:03 +0000
Subject: [Koha-bugs] [Bug 11097] Hide duplicate patron button if logged in
 user lacks CAN_user_borrowers permission
In-Reply-To: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11097-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11097-70-GrnQeAwO9H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11097

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:50:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:50:37 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-JIq9TpVU3w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #18 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jared Camins-Esakov from comment #17)
> (In reply to mathieu saby from comment #16)
> > Great! So when we decide that pre-QP search could be deprecated, this piece
> > of code could be delete I imagine?
> 
> Yup. We talked about that at the hackfest on Sunday.
> 
> > But, is there a similar operation to do in QP conf to declare the new index,
> > or is it automatic?
> 
> There is a similar configuration required: you have to add your new index to
> etc/searchengine/queryparser.yaml.

I did not know that... Is there a page on the wiki or elsewere explaining that,
or other points about QP?
I found http://wiki.koha-community.org/wiki/C_%26_P_Search_Rewrite_RFC but it
is a RFC,  not a page on "What you absolutely need to know about QP now that it
is used by Koha".
For example, with QP, is it possible to search for an exact expression using
Google syntax (double quotes), like "bla bla" ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 14:58:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 12:58:13 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-zXztCmJSIa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

--- Comment #153 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
I'm applying on 3.2.x branch, but since it's removed in another patch, it would
probably be better to drop all changes to sysprefs from this patchset instead
of modifying it and than reverting it back.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:01:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:01:35 +0000
Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt
In-Reply-To: <bug-10403-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10403-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10403-70-ltzxdjkJqe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #10 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jared!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:36:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:36:36 +0000
Subject: [Koha-bugs] [Bug 11113] New: Title of pages are not easy to
 translate in some languages, especially in french
Message-ID: <bug-11113-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11113

            Bug ID: 11113
           Summary: Title of pages are not easy to translate in some
                    languages, especially in french
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: I18N/L10N
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: frederic at tamil.fr

In templates, title of pages are formated this way :

[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END
%] catalog &rsaquo;  Results of search 

In English the result is
"Mylibrary catalog > Results of search"
or
"Koha online catalog > Results of search"


In French : 
"Mylibrary catalogue > R?sultats de recherche"
or
"Koha en ligne catalogue > Results of search"

It's not good French : we should have something like
"Catalogue de Mylibrary > R?sultats de recherche"
or
"Catalogue Koha > Results of search"
(the "online" / "en ligne" is superfluous, and refers to "catalogue", not to
"Koha", so better not displaying it)

or maybe (more easy I suppose)
"Mylibrary > Catalogue > R?sultats de recherche"
or
"Koha > Catalogue > Results of search"


M. Saby

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:37:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:37:19 +0000
Subject: [Koha-bugs] [Bug 11113] Title of pages are not easy to translate in
 some languages, especially in french
In-Reply-To: <bug-11113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11113-70-oFyS48xOf8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11113

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Maybe it could be deal only in Pootle, maybe a change in templates could be
interesting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:37:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:37:36 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-jBR3j6PgPZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #10 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22269
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22269&action=edit
Bug 10671: Add missing patron lists help

To test go to Tools > Patron Lists and click 'Help'.
Confirm that the help is there and without typos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:37:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:37:49 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-ed9LZTSB4B@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:43:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:43:28 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-bJtvC5I5zu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #11 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22270
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22270&action=edit
Bug 10671: Update Authorities Help

To Test go to all authorities pages and click 'Help'.
Confirm that text appears and links work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:45:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:45:06 +0000
Subject: [Koha-bugs] [Bug 11114] New: Search of Invoices by shipment date
 results in DB error
Message-ID: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11114

            Bug ID: 11114
           Summary: Search of Invoices by shipment date results in DB
                    error
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

On the acquisitions invoices screen enter dates in shipment from and to and
search.
Result is an error from the DBI library


Cause is that the field shipment date is misspelt in GetInvoices

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:48:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:48:48 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-UFSDt8Xa5o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #12 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22271
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22271&action=edit
Bug 10671: Update links in Catalog help

To test search the catalog and click results
Test al of the links to the manual and make sure they
go to the 3.14 manual.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:50:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:50:53 +0000
Subject: [Koha-bugs] [Bug 11114] Search of Invoices by shipment date results
	in DB error
In-Reply-To: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11114-70-bNdWSZ4jS9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11114

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Problem exists in 3.12 as well as master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:53:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:53:03 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-hWW95WpyhM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #132 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with some follow-ups.  The most significant one I
believe resolves the concern Katrin had about too many orders ending up in the
partial status when 'ordered' or 'new' would have been better.  I'd appreciate
review of that in case that particular follow-up needs to be modified.

Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 15:53:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 13:53:56 +0000
Subject: [Koha-bugs] [Bug 11114] Search of Invoices by shipment date results
	in DB error
In-Reply-To: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11114-70-bLADEh7hpa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11114

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22272
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22272&action=edit
Proposed Patch

Simple test: Goto Acquisitions/Invoices enter dates in shipment from and to and
press search. Without patch applied a DBI error occurs, with it the search is
carried out

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:06:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:06:39 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-VxbdZe1Sr4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #13 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22273
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22273&action=edit
Bug 10671: Update main help files

This patch updates help files that aren't in any other folder.

To test:

* Visit the main staff page and review the help
* Visit the About page and review the help
* Visit a page without help (which there better not be) and
  review the link to the manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:08:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:08:17 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-Rq3Og5xKk9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #133 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Argh. I see that when I updated my test plan I put in OK everywhere, but I
missed updating the line. The second test I did with Jonathan's changed
updatedatabase procuded perfect results for all test data I had created - so
the partials were correctly set, before I set to passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:18:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:18:52 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-XO2m6nQziu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #14 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22274
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22274&action=edit
Bug 10671: Update Lists Help

To test go to Lists in the staff client and click help
Confirm that the link goes to the right manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:34:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:34:17 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-0nFsWtQTuh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #64 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Aur?lie Fichot <aurelie.fichot at iepg.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:34:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:34:40 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-mujZ4cQoWl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22264|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:34:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:34:47 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-MAHkMQVLCR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

--- Comment #65 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22275
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22275&action=edit
Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit.

Signed-off-by: Aur

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:36:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:36:20 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-jakZQQsWfm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #4 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22276
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22276&action=edit
Sponsor: Vanier college

Following David Cook's comments, I made the following modifications:

- C4/Koha.pm : include the non-NULL but empty category in the selection
- admin/authorised_values.pl : Added the DOCTYPECAT as default.  Seemed the
cleanest solution.
- installer/data/mysql/kohastructure.sql : cleaned the unwelcomed whitespaces.
- koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt : fixed typo and
added instruction message
- koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt : minimized the diff by
redoing the code.

New testing instructions.

SETUP
0) run updatedatabase.pl to add the two columns to itemtypes
1) You need to add a category to group your item types:
   a) In Intranet/Koha Admin/Authorized values, select DOCTYPECAT in the
category dropdown
   b) Click button "New authorized value for DOCTYPECAT"
   c) Enter
         Authorized value: HARDWARE
         Description : Hardware
         Description (OPAC): Hardware

NORMAL USAGE
2) Group your items under that new category
   a) In Intranet/Koha Admin/Item types, choose (at least) two item types and
for each:
      - Click action/Edit on the right column
      - Third row (below Description) is the Search category list box, select
Hardware
      - click Save changes at the bottom
3) Select at least one item to be hidden in the OPAC search
   a) In Intranet/Koha Admin/Item types (again), choose a different item type:
      -  Click action/Edit
      -  Click the checkbox "Hide in OPAC" below the list of icons.

FINAL TESTING
4) Go test your modifications
   a) Go to OPAC/Adv search.
   b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
   c) Validate that new item type Hardware does appear instead.
   d) Select item Hardware, start Search.
   e) Validate returned items are the of the two types that were grouped into
the Hardware category in step 4.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:38:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:38:17 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-47Ff858C7P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #15 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22277
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22277&action=edit
Bug 10671: Add missing authority merge help

Test after 10/23 (when the manual link will work)
Visit authorities
Start a merge
Click help on during the merge process
Be sure that help is there and link works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:40:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:40:18 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-02DexRxL1N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Blou <philippe.blouin at inlibro.com> ---
The patch is additive.  The first one is required.
I rebased before doing it, so all should be good.

Feedbacks are welcomed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:42:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:42:17 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-UO8rDUDRKK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #16 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22278
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22278&action=edit
Bug 10671: Update links in label help

This patch updates the links in the label help
to point to the 3.14 manual.

To test:

Visit all label pages and click the help link
confirm that the manual links goes to the right place

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:49:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:49:01 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-7t7CPeoUUT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #17 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22279
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22279&action=edit
Bug 10671: Update patron card creator help

Update manual links in the patron card help file.

To test:
* visit all patron card creator pages and click 'help'
* confirm that the link to the manual goes to 3.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 16:51:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 14:51:01 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-F5yYEqN9OG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

--- Comment #134 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #132)
> Pushed to master, along with some follow-ups.  The most significant one I
> believe resolves the concern Katrin had about too many orders ending up in
> the partial status when 'ordered' or 'new' would have been better.  I'd
> appreciate review of that in case that particular follow-up needs to be
> modified.

I agree with your followups. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:01:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:01:59 +0000
Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction
In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8236-70-8hv9cN0Q0A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22275|0                           |1
        is obsolete|                            |

--- Comment #66 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22280
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22280&action=edit
Bug 8236 Block renewing for overdue items

Bug 8236 Block renewing for overdue items

If any of patron's document is late, renewal can be allowed, blocked on every
checked out items or only on overdue ones.
The renewal remains nevertheless possible for the librarian checking the
Override renewal limit.

    Signed-off-by: Aur?lie Fichot <aurelie.fichot at iepg.fr>



(I reupload the patch in order to fix the encoding issue caused by the sandbox)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:04:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:04:03 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-SS7vbro7VF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #6)
> Created attachment 22263 [details] [review]
> Bug 11059 Not possible to sort staged dates in metric format
> I rebased and modified for master as you suggested.
Your patch adds : 
    [% IF (dateformat == 'metric') %]
        dt_add_type_uk_date();
    [% END %]
This is not needed, it is done a few lines above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:08:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:08:31 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-I8rdkCdmGt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #18 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22281
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22281&action=edit
Bug 10671: Update tag tool help

This patch updates the links to the manual in the
help files on tags.

To test:

* Visit the tag moderation tool
* Click the help link
* Confirm that the links to the manual are right

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:11:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:11:05 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-p3bbEfOvJd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
I prefer the newer method where the DataTables plugin looks for an
ISO-formatted date in a title attribute. This means that we don't need any
logic around date format. See booksellers.tt for an example. In the DataTables
initialization configuration:

        "aoColumns": [
            null,null,null,null,null,null,{ "sType": "title-string" },{
"sType": "title-string" },null
        ],

...where "sType," the sorting type, is "title-string." This looks for a <span>
with a title attribute containing the unformatted date:

 <td><span title="[% basket.creationdate %]">[% basket.creationdate |
$KohaDates %]</span></td>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:16:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:16:01 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-EKJzsaDhHy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

--- Comment #9 from Koha Team Lyon 3 <koha at univ-lyon3.fr> ---
(In reply to Fridolyn SOMERS from comment #7)
> (In reply to Koha Team Lyon 3 from comment #6)
> > Created attachment 22263 [details] [review] [review]
> > Bug 11059 Not possible to sort staged dates in metric format
> > I rebased and modified for master as you suggested.
> Your patch adds : 
>     [% IF (dateformat == 'metric') %]
>         dt_add_type_uk_date();
>     [% END %]
> This is not needed, it is done a few lines above.

?!! I deleted these lines, there are not any more in the last patch. Did you
really test this one (id=2263) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:37:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:37:38 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-VBxSLn7cdC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #19 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22282
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22282&action=edit
Bug 10671: Update plugins help

To test visit the plugin pages and confirm that the links
to the manual are right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:39:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:39:13 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-k3V5ojqaEO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #20 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22283
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22283&action=edit
Bug 10671: Update suggestion help

To test visit the suggestion management pages
and confirm that the link in the help file goes
to the right manual.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 17:42:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 15:42:13 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-RMI706t8QH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I proposed a patch for previous release in bug 9850:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9850#c12

Maybe it could be great to do something for these links. It is really useless
to keep them up-to-date manually.

For the next release? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:16:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:16:23 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-OIaJoWn8nA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #22 from Nicole C. Engard <nengard at gmail.com> ---
(In reply to Jonathan Druart from comment #21)
> I proposed a patch for previous release in bug 9850:
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9850#c12
> 
> Maybe it could be great to do something for these links. It is really
> useless to keep them up-to-date manually.
> 
> For the next release? :)

Since it didn't make it in to 3.14 before the freeze I'm doing the help files
this way - maybe push to get it in for Koha 3.16 - but I would do that on the
bug in question not after I've started writing the help files :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:17:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:17:46 +0000
Subject: [Koha-bugs] [Bug 11115] New: Pull help files from the manual
Message-ID: <bug-11115-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115

            Bug ID: 11115
           Summary: Pull help files from the manual
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: Documentation
          Assignee: nengard at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be great if the Help links in Koha were pulled directly from the
manual in some way at the time of installation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:18:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:18:14 +0000
Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual
In-Reply-To: <bug-11115-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11115-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11115-70-1Yavoz8M3m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nengard at gmail.com           |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:19:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:19:50 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-LMrCyOZSnI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #176 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22284
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22284&action=edit
Bug 8015: Add user permissions to all languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:24:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:24:36 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-Ba1JzGFDGl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #177 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22285
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22285&action=edit
Bug 8015: Remove references to C4::Koha::Log

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:33:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:33:09 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-FTVeWNkH6h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:33:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:33:12 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-Ka8hfFuFdO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22286
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22286&action=edit
Bug 9288 - Add a script to test SIP from the command line - QA Followup 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:33:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:33:30 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not display on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-f3E6GEVKaq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:33:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:33:32 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not display on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-RsEqb3tgz6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Ed Veal <ed.veal at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22266|0                           |1
        is obsolete|                            |

--- Comment #2 from Ed Veal <ed.veal at bywatersolutions.com> ---
Created attachment 22287
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22287&action=edit
[SIGN-OFF]Bug 11111: The basket group is not display on the parcel page

Test plan:
Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name
is displayed into the 2nd column.

Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:43:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:43:59 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-TvRApB9ksY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 18:44:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 16:44:07 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-sZ85RI3Abk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22288&action=edit
Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links

There is a problem with the style on the toolbar on the suggestions page
which makes it float incorrectly. This patch corrects the problem.

To test, log in to the OPAC as a user who has suggestions. The
selections toolbar (which shows the "select all," etc. controls) should
look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:16:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:16:20 +0000
Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name
In-Reply-To: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2693-70-E58PgzCbPG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:16:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:16:26 +0000
Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name
In-Reply-To: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2693-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2693-70-P9xnZZ2gCj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22085|0                           |1
        is obsolete|                            |

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
Created attachment 22289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22289&action=edit
Bug 2693 - Tagging: Add filter by name

If you want to filter results on the tags management page by the
reviewer you have to know their borrowernumber. It would be better to be
able to search by name, but in the meantime this patch adds an
autocomplete widget to the form field so that you can do a name search
and populate the field with the borrowernumber.

To test you must have approved or rejected tags. From the tags review
page (tags/review.pl), view all, approved, or rejected tags. Type a name
in the "reviewer" form field in the left sidebar filter. You should get
an autocomplete dropdown with names matching your search. When you
select one the form field should be populated by the borrowernumber.

Signed-off-by: David Cook <dcook at prosentient.com.au>

Patch works as described. I'm not sure whether or not it would be better
to be able to search by name, as that would involve either choosing
between names after applying the filter or showing any possible matches,
so this seems fine.

--

Owen and I did observe that we were able to cause AJAX errors while
using this autocomplete, but we are not 100% sure how we caused the error.
In my case, I was able to occasionally cause it by typing in a name
then backspacing rapidly. The ajaxError method is attached to every
element in the DOM (yikes) so it's tough to say what exactly is the
source of the error (which is signalled by a pop-up window that can be
cancelled).

The error is quite rare so I don't think it's necessarily a problem
for us.

One idea that Owen had was to remove the current error message, which
is very unhelpful and replace it with an error like "Something went
wrong. Try again."

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:19:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:19:24 +0000
Subject: [Koha-bugs] [Bug 9197] opacnav shows below tabs on opac-user.pl in
	ccsr
In-Reply-To: <bug-9197-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9197-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9197-70-b9nX3BdrBt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9197

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:19:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:19:36 +0000
Subject: [Koha-bugs] [Bug 9195] nav overlaps lists in ccsr
In-Reply-To: <bug-9195-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9195-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9195-70-YRMskheYSV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9195

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:20:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:20:09 +0000
Subject: [Koha-bugs] [Bug 10405] User-editable sections should have ids
In-Reply-To: <bug-10405-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10405-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10405-70-fDgmGz4T0u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10405

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:21:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:21:17 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-NQWyoKwgRO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #178 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22290&action=edit
Bug 8015: QA Followup

* Add bug number to database update
* Fix capitalization errors
* Fix JavaScript string translation errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:22:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:22:14 +0000
Subject: [Koha-bugs] [Bug 11116] New: QuoteOfTheDay box overlaps OpacNav
 text in ccsr under Firefox
Message-ID: <bug-11116-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11116

            Bug ID: 11116
           Summary: QuoteOfTheDay box overlaps OpacNav text in ccsr under
                    Firefox
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: bugzilla at augustansociety.com
        QA Contact: testopia at bugs.koha-community.org

Seen on Firefox 24. Displays correctly under prog.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:22:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:22:33 +0000
Subject: [Koha-bugs] [Bug 11116] QuoteOfTheDay box overlaps OpacNav text in
 ccsr under Firefox
In-Reply-To: <bug-11116-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11116-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11116-70-WY9zxsc8yA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11116

Bruce Metcalf <bugzilla at augustansociety.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at augustansociety.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:44:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:44:13 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-ImpTKMq5OI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22291&action=edit
Bug 11096: Remove use of MARC::File::USMARC from AuthoritiesMarc.pm

Thats it.

To test:
- Apply the patch
- Test authorities search in all its flavours (staff and opac).
- Use the dontmerge syspref to try the AuthoritiesMarc::merge function.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:44:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:44:45 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-uNGetQyOJ1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:44:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:44:48 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-ixaaRE2WHt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22292&action=edit
Bug 11096: force XML syntax for Zconn

This patch makes Koha <-> Zebra exchange speak XML instead of the
current 'USMARC'. For that, it changes some bits in
- C4::Context->Zconn
- C4::Context-_new_Zconn
Zebra's 'element' variable is set to "marcxml" to match our zebra config files.

References to MARC::File::USMARC::decode are substituted for calls to
the correct one [1] (i.e. MARC::Record::new_from_xml using an explicit
'UTF-8' encoding for the task.

This patch also removes calls to the unsafe ZOOM::Record->render()[2] method.
Due to this last change the code for building facets was rewritten.

- The FindDuplicates function was MARCXML-ized too.
- Unit tests have been moved to expect MARCXML from Zebra as well.

TODO: relevance still uses USMARC. Need advise on that.

Regards
To+

[1] As a side effect some encoding problems got fixed in facets and record
details.
   
http://search.cpan.org/~gmcharlt/MARC-XML-1.0.1/lib/MARC/File/XML.pm#decode()
[2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#render()

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 19:46:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 17:46:44 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-gVvPc42sGg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcamins at cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 20:24:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 18:24:40 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-2FXMftvdqQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Paul SetMarcUnicodeFlag sets the MARC flag in the leader the bug is not related
to this  the patch is setting the utf-8 flag in the perl var containing the
string. A different thing 
Setting back to signed off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 20:34:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 18:34:31 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-qPDKuKcRtB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Colin Campbell from comment #4)
> Paul SetMarcUnicodeFlag sets the MARC flag in the leader the bug is not
> related to this  the patch is setting the utf-8 flag in the perl var
> containing the string. A different thing 
> Setting back to signed off

Right, but it ALSO set the flag:
    $marc_record->encoding('UTF-8');
(3 lines after the sub prototype)

I still think we should use this sub instead of a direct ->encoding

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 20:39:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 18:39:06 +0000
Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm
In-Reply-To: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11032-70-bkewYd0J6V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

--- Comment #3 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Owen Leonard from comment #2)
> I'm happy to see that you're trying to address this problem. Can you please
> add a test plan to your commit message?

test plan is the tests added to t/Biblio.t see previous comment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 20:39:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 18:39:33 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-LXHzQlih4l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #179 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22293&action=edit
Bug 8015: QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 20:49:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 18:49:42 +0000
Subject: [Koha-bugs] [Bug 11117] New: Right to left text in facets + facet
 count = mixed text
Message-ID: <bug-11117-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11117

            Bug ID: 11117
           Summary: Right to left text in facets + facet count = mixed
                    text
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22294&action=edit
Right-to-left parenthesis mixup

Steps to reproduce:

- Have facets to show some right to left text (for example ?) in english
language templates.
- Enable the displayFacetCount.
- Check it displays like the attached snapshot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 21:18:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 19:18:38 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-BjXGfMWpaH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #53 from Paul Poulain <paul.poulain at biblibre.com> ---
Hi Mathieu,

I've giving a try to this patch, it fixes some of the errors that appears in
zebra logs.
But the following aren't:
21:12:42-22/10 zebraidx(29295) [warn] Index 'UPC' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'UPC' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Serials' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Serials' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Printed-music' not found in
attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Printed-music' not found in
attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Electronic-ressource' not found in
attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Title-host' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'title-host' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'Title-host' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'title-host' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'lcn' not found in attset(s)
21:12:42-22/10 zebraidx(29295) [warn] Index 'lcn' not found in attset(s)

(note that title-host should be spelled Title-host in 2 places)

Some questions:
 * is there any reason why you haven't fixed those attributes as well ?
 * how to fix them ? Add another UNIMARC specific attribute into
bib1.att/ccl.properties, change index name in record.abs or remove it ?

Thanks for your feedback !
(I may provide a patch, in another bug)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 21:30:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 19:30:01 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-qNMI7ShJOg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

--- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
For what is worth, with patch applied,
I replaced line 824 in addbiblio.pl

    $record->encoding( 'UTF-8' );

with

    SetMarcUnicodeFlag($record, $marcflavour);

Same (good) result, and perhaps is more general.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 21:30:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 19:30:51 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-WQ6Q5LIwxv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

JD at TeTakere <joanned at tetakere.org.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joanned at tetakere.org.nz

--- Comment #2 from JD at TeTakere <joanned at tetakere.org.nz> ---
Created attachment 22295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22295&action=edit
My Purchase Suggestions toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 21:31:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 19:31:48 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-I4KC5xyn76@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

JD at TeTakere <joanned at tetakere.org.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from JD at TeTakere <joanned at tetakere.org.nz> ---
Logged into Sandbox 8, viewed My Purchase Suggestions.  Toolbar looks fine
(screenshot attached).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 22:18:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 20:18:19 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-sOvu5kigIq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #54 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Paul Poulain from comment #53)
> Hi Mathieu,
> 
> I've giving a try to this patch, it fixes some of the errors that appears in
> zebra logs.
> But the following aren't:
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'UPC' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'UPC' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Serials' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Serials' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Printed-music' not found in
> attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Printed-music' not found in
> attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Electronic-ressource' not found
> in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Title-host' not found in
> attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'title-host' not found in
> attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Title-host' not found in
> attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'title-host' not found in
> attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'lcn' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'lcn' not found in attset(s)
> 
> (note that title-host should be spelled Title-host in 2 places)
> 
> Some questions:
>  * is there any reason why you haven't fixed those attributes as well ?
>  * how to fix them ? Add another UNIMARC specific attribute into
> bib1.att/ccl.properties, change index name in record.abs or remove it ?
> 
> Thanks for your feedback !
> (I may provide a patch, in another bug)



Hi
1/ It was already a complex patch to write and to test ;-)
2/ It is out of the main scope, which was, fixing coded fieds. Those warns are
not linked with coded fields

So it could be fixed in other patches.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 22:20:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 20:20:49 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-cD7sVm4Xmz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #55 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---

> >  * how to fix them ? Add another UNIMARC specific attribute into
> > bib1.att/ccl.properties, change index name in record.abs or remove it ?

I don't know it right know, but I'm pretty certain the same logic could be
apply for them : check if these indexes can be mapped with existing ccl/bib1
values. And if not, create custom ccl/bib1 values for doing that.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 22:35:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 20:35:38 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-Fzer6U2nYW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #17 from Blou <philippe.blouin at inlibro.com> ---
Changing the status from "Patch doesn't apply" to "Need signoff".
Not sure if that was needed since rebaser knows the business, please let me if
otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 22:58:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 20:58:12 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-aKgG65Hcp1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22258|0                           |1
        is obsolete|                            |
                 CC|                            |liz at catalyst.net.nz

--- Comment #4 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 22296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22296&action=edit
Patch for Series

Simply removing duplication in effort from the workshop so Tim gets credit for
his work - LR

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 22:59:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 20:59:26 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-VTXE8kv6Cd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22296|0                           |1
        is obsolete|                            |

--- Comment #5 from Liz Rea <liz at catalyst.net.nz> ---
Comment on attachment 22296
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22296
Patch for Series

Oops. Messed up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:02:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:02:41 +0000
Subject: [Koha-bugs] [Bug 10493] Add renewal script
In-Reply-To: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10493-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10493-70-QfnYIGZAGv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10493

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #27 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:06:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:06:20 +0000
Subject: [Koha-bugs] [Bug 11104] Label in opac topics in facets not easily
	css selectable
In-Reply-To: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11104-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11104-70-9uWc112MM2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11104

--- Comment #6 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 22297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22297&action=edit
Deduplicating effort from the class. Places the span on Series instead of Topic

Tim - come see me with questions :)

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:09:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:09:03 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-R2JLPxQoDy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

--- Comment #56 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
2 other rules of my own would be
"check if the equivalent fields in MARC21 are already indexed, and if the
MARC21 index can be reused"
and
"check if this index as a real utility"

Little enquiry : 
Here are the use for these indexes : 

melm 072$a      UPC:w,Identifier-standard:w
melm 072$z      UPC:w,Identifier-standard:w
melm 207    Serials,Serials:p
melm 208    Printed-music,Printed-music:p
melm 230$a      Electronic-ressource
melm 461$t    Title,Title-host:w,title-host:p
lcn is not used

I think I would try this :
UPC : 
In MARC21, it is in 024, alongside other identifiers (the indicator of the
fields precise the nature of the identifier, but of course record.abs cannot
take that into consideration...)
So UPC is only defined in UNIMARC, whereas it is an id kind of EAN, used mainly
in the USA and Canada, MARC21 countries. That's not logical. This index is
useless for UNIMARC ppl, especially if it is not working well.
=> my proposition: get rid of UPC in UNIMARC conf files and index 072 in
"Identifier-standard" and in ccl.properties
If marc21 ppl want to index this in their DOM conf file, they will create the
propoer custom definition in ccl and bib1.att.

207 field is equivalent to 362 field in MARC21
208 field is equivalent to 254 field in MARC21
http://www.loc.gov/marc/unimarctomarc21_2xx5xx.pdf
Both are not indexed in MARC21, so maybe the information is not really
important.
BNF sites give some examples
http://multimedia.bnf.fr/unimarcb_trad/B207-6-2010.pdf
"Cette zone contient les num?ros de la premi?re et de la derni?re livraison de
la ressource continue et/ou les dates que couvrent ces livraisons quand ces
num?ros et ces dates sont connus."
Ex : "Vol. 1, no. 1 (1 Apr. 1946)-vol. 26, no. 195 (10 Oct.1972) = no. 1-no.
6943 "
=> for me, this field should NOT BE indexed in any way!

http://multimedia.bnf.fr/unimarcb_trad/B208-6-2010.pdf
"Cette zone contient une mention, transcrite ? partir de la ressource, relative
? la pr?sentation particuli?re d'une ressource musicale imprim?e ou manuscrite.
"
Ex : "Partition de poche"
Maybe it can be usefull, and I did not find declarations for that in ccl or
bib1, so let's create a custom one, OR maybe index it in notes.

Electronic-ressource : 230 is deprecated in UNIMARC. Maybe present in legacy
records, but not sure of that.
Let's get rid of this index.


title-host : typo for Title-host

461: Title-host:
as we have 461$9 indexed in "Host-Item-Number", I guess this "Title-host" is a
mistake for "Host-item".
So, 461 would behave like 773 in MARC21

(Technically, 461 is not a strict equivalent of 773. From LOC site, I get that
the official equivalent of 461 in MARC21 is 774)


Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:11:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:11:18 +0000
Subject: [Koha-bugs] [Bug 11118] New: Fixing UNIMARC indexing of 072, 207,
 208, 230, 464 fields
Message-ID: <bug-11118-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11118

            Bug ID: 11118
           Summary: Fixing UNIMARC indexing of 072, 207, 208, 230, 464
                    fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:15:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:15:43 +0000
Subject: [Koha-bugs] [Bug 11101] Author label in staff client not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-eC877Pcztk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22224|0                           |1
        is obsolete|                            |
                 CC|                            |liz at catalyst.net.nz

--- Comment #3 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 22298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22298&action=edit
allow item types facet label to be changed

Changing the target of the patch so that Claire gets credit for work done at
Librarian to Developer in 90 minutes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:16:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:16:14 +0000
Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-lGVYF2VJjO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Author label in staff       |Item Type label in OPAC not
                   |client not easily css       |easily css selectable.
                   |selectable.                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:18:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:18:43 +0000
Subject: [Koha-bugs] [Bug 11119] New: Silent zebra in UNIMARC
Message-ID: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

            Bug ID: 11119
           Summary: Silent zebra in UNIMARC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Searching
          Assignee: paul.poulain at biblibre.com
          Reporter: paul.poulain at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In UNIMARC configuration, there are some complaints from Zebra about non
existing indexes:
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'UPC' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Serials' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Printed-music' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Electronic-ressource' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'Title-host' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'title-host' not found in attset(s)
> 21:12:42-22/10 zebraidx(29295) [warn] Index 'lcn' not found in attset(s)

Those indexes should either be removed from record.abs or created into
bib1.att/ccl.properties

Mathieu suggested the following options, that are worth being followed:


I think I would try this :
*** UPC : 
melm 072$a      UPC:w,Identifier-standard:w
melm 072$z      UPC:w,Identifier-standard:w
In MARC21, it is in 024, alongside other identifiers (the indicator of the
fields precise the nature of the identifier, but of course record.abs cannot
take that into consideration...)
So UPC is only defined in UNIMARC, whereas it is an id kind of EAN, used mainly
in the USA and Canada, MARC21 countries. That's not logical. This index is
useless for UNIMARC ppl, especially if it is not working well.
=> my proposition: get rid of UPC in UNIMARC conf files and index 072 in
"Identifier-standard" and in ccl.properties
If marc21 ppl want to index this in their DOM conf file, they will create the
propoer custom definition in ccl and bib1.att.

*** Serials and Printed-music
melm 207    Serials,Serials:p
melm 208    Printed-music,Printed-music:p
207 field is equivalent to 362 field in MARC21
208 field is equivalent to 254 field in MARC21

http://www.loc.gov/marc/unimarctomarc21_2xx5xx.pdf
Both are not indexed in MARC21, so maybe the information is not really
important.
BNF sites give some examples
http://multimedia.bnf.fr/unimarcb_trad/B207-6-2010.pdf
"Cette zone contient les num?ros de la premi?re et de la derni?re livraison de
la ressource continue et/ou les dates que couvrent ces livraisons quand ces
num?ros et ces dates sont connus."
Ex : "Vol. 1, no. 1 (1 Apr. 1946)-vol. 26, no. 195 (10 Oct.1972) = no. 1-no.
6943 "
=> for me, this field should NOT BE indexed in any way!

http://multimedia.bnf.fr/unimarcb_trad/B208-6-2010.pdf
"Cette zone contient une mention, transcrite ? partir de la ressource, relative
? la pr?sentation particuli?re d'une ressource musicale imprim?e ou manuscrite.
"
Ex : "Partition de poche"
Maybe it can be usefull, and I did not find declarations for that in ccl or
bib1, so let's create a custom one, OR maybe index it in notes.

*** Electronic-ressource
melm 230$a      Electronic-ressource
Electronic-ressource : 230 is deprecated in UNIMARC. Maybe present in legacy
records, but not sure of that.
Let's get rid of this index.

*** Title-host
melm 461$t    Title,Title-host:w,title-host:p

title-host : typo for Title-host

461: Title-host:
as we have 461$9 indexed in "Host-Item-Number", I guess this "Title-host" is a
mistake for "Host-item".
So, 461 would behave like 773 in MARC21

(Technically, 461 is not a strict equivalent of 773. From LOC site, I get that
the official equivalent of 461 in MARC21 is 774)

*** lcn
lcn isn't used

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:19:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:19:14 +0000
Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range
	for fields 1xx)
In-Reply-To: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8252-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8252-70-PTNGcICFKJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11119

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:19:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:19:14 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-GeqLoBXy8a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8252

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:20:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:20:14 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-pla7FWQYOc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I was writing a new bug, but did not validate the form ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:21:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:21:13 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: <bug-10554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10554-70-fnuyZLrWKl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

--- Comment #11 from Bob Birchall <bob at calyx.net.au> ---
I am no longer able to prove the pre-existing behaviour, that is, that only
non-blocked patrons can return via SCO.  

I checked an item out to a patron, setting the due date to a date prior to the
current date (ie it is immediately overdue).  I set the patron to 'restricted'
and I set the patrons membership expiry date to a date preceding the current
date.

I was able to return the item via SCO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:22:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:22:32 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-4AHBxjZaUJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
in fact lcn is an alias for Local-Classification (for 995k)
I removed lcn from record.abs, but forgot to do it for the 2 new DOM conf
files.

The more simple for 208 is probably to index it in notes.

If you or some Biblibre guy write a patch, I could easily test it and sign it
off for DOM Unimarc (current conf of my VM)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:41:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:41:42 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-Z0C5d0zbyL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

JD at TeTakere <joanned at tetakere.org.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Pushed for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 22 23:45:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 21:45:04 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-Vo3XAoVRgS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21480|0                           |1
        is obsolete|                            |

--- Comment #21 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22299&action=edit
[PATCH 1/2] Bug 10869: Allow the deletion of order line if the record is
deleted

Patch Rebased

I suppose adding a UT for DelOrder could be a good point too.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:02:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:02:54 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-QIjqmd4xoL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22104|0                           |1
        is obsolete|                            |
  Attachment #22299|0                           |1
        is obsolete|                            |

--- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22300&action=edit
[PATCH] Bug 10869: Allow the deletion of order line if the record is deleted

My last rebasing was wrong...
Paul, I integrated your changes in the main patch, as they were obvious.

I'd like to write a UT for DelOrder, but I see more and more different files in
t/db_dependant/Acquisition/

When a UT does belong to db_dependant/Acquisition.t, and when to separate file?
For me it would be more logic to put all the UT for a .pm file in a single .t
file, so we could reuse mock records or orders created for the test.
Is there a rule somewhere ?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:03:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:03:13 +0000
Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
In-Reply-To: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8033-70-tqtBQSiu2z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:03:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:03:17 +0000
Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
In-Reply-To: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8033-70-gAQB1A6cy1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18053|0                           |1
        is obsolete|                            |

--- Comment #64 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22301&action=edit
Bug 8033 [Follow-up] add print receipt option to Koha self-check

This follow-up makes some corrections to JavaScript, most importantly
by enabling translation of strings embedded in the script. Other
corrections: Trailing whitespace, proper <![CDATA[ commenting,
and === comparisons (Following coding/JSHint guidelines).

To test, check something out in self checkout and click the "Finish"
button. The JavaScript confirmation dialog should appear and the receipt
should appear and self-close correctly.

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Works as expected.
Signed-off-by: Mason James <mtj at kohaaloha.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:05:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:05:25 +0000
Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
In-Reply-To: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8033-70-0sz8ymQkNn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18054|0                           |1
        is obsolete|                            |

--- Comment #65 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22302&action=edit
Bug 8033 - add print receipt option to Koha self-check (edit)

Reimplementation of Kyle's follow-up, minus the addition of "<title
i18n-content="title">" which is I don't understand. From the original
commit message:

3 misc follow-up fixes

1/ fixed  printslip.tmpl typo
2/ moved hardcoded text string from script to template.
3/ delete unused receipt.tt file

To Test:

- Sign in to self checkout.
- Enter a barcode and click submit.
- Click the finish button
- You should be prompted with a message asking if you would like a
  receipt.
  If you click OK you should be taken to the page with the receipt.
  If you click Cancel you should not see the reciept and you should be
  logged out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:18:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:18:37 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-9LCiIVqPC4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:18:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:18:39 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-EwDQWXfkfK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

--- Comment #3 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 22303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22303&action=edit
Bug 11119 silent zebra in UNIMARC

This patch fixes some zebra configuration mistakes in UNIMARC, that results in
many warnings issued on zebra console

Test plan:
 * run a search with zebra, see that there are lot of warnes like :
23:32:56-22/10 zebrasrv(1) [warn] Index 'lcn' not found in attset(s)
 * apply the patch
 * update your zebra config file, reload zebra (no need to reindex afaik)
 * run the same search => no more warnings

Changes:
 * UPC (on 072$a & $z) has been removed
 * Serials, Printed-music & Electronic-ressource has been removed
 * Title-host has been replaced by Host-item
 * lcn has been removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:31:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:31:05 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-4fNwwGVVtU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

--- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> ---
Mathieu: additional comments:
 * Host-item is also defined in 995$a => seems silly to me. Do you confirm ? (I
haven't changed anything in this patch)
 * all 4xx$t fields are indexed as Title. Isn't it wrong ? (Sounds strange to
me)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:55:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:55:04 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-7YS8tLo29I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |dcook at prosentient.com.au

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
I've applied the patches, but I'm still unable to retrieve the big record from
Zebra.

I created a new bib record with an excessive number of 5xx fields and added
many items, and it has created problems with the MARC record leader.

This is the leader for a small record:
<leader>03322cam a2200469 a 4500</leader>

Here is the (broken) leader for a big record (without items) in MySQL:
<leader>143530nama22006133  45000</leader>

Here is the (broken) leader for a big record (with items) in Zebra (accessed
via YAZ):
<leader>584260nama22019693  4500</leader>

As you can see, both of the broken leaders are quite broken. The MySQL version
is 25 characters rather than 24. In Zebra, it has 24 positions, but much of the
data are in the wrong place because of that 6 character record length.

--

When I try to access the record in Yaz-client, I receive the following error:

<!-- Directory offset 276: Data out of bounds 59725 >= 58426 -->
</record>

As Tomas pointed out, 584260 has been shortened to 58426 as Yaz is expecting 5
characters rather than 6 characters for the record length.

--

So...at the moment...it seems that indexing and retrieving oversized records
doesn't work.

If you try to bring up a detail page manually, you can, but the XSLTs won't
work correctly as it can't rely on the leader positions correctly. A "book"
might show up as a "set".

In one case, some of the XSLT display isn't even showing because the data that
is mixed around is totally unusable.

--

Admittedly, the most likely causes of big records are notes and items, so
perhaps it would make sense to separate out the item records from the bib
records when indexing. 

As for the notes...I'm not sure how we would handle that. While there is a 9999
character limit on a note field, you could have a hundred note fields that
break your record.

--

I'm not really sure what the answer is, but here is the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:56:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:56:11 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-GDIjVGuh3Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

--- Comment #180 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Test report

1)OK
Staging, importing, reverting and cleaning using
- stage_file.pl and commit_file.pl
- Stage and Staged MARC record management tools

2) (normal)
Saving an empty action - fil

3) (minor)
Feedback about mandatory fields not quite standard

4) (major)
Rule: Copy 650 to 689 - no subfields entered
[Wed Oct 23 00:07:58 2013] [error...] [client 127.0.0.1] [Wed Oct 23 00:07:58
2013] stage-marc-import.pl: data() is only for control fields (generally, just
tags below 010) , use subfield() at /home/katrin/koha/Koha/SimpleMARC.pm line
188, referer: http://staff.master/cgi-bin/koha/tools/stage-marc-import.pl
No feedback in the interface, we should make sure people know that
whole fields can't be copied.
Maybe subfield should be required to, if it's not a controlfield (Note:
controlfields are different for MARC21 and UNIMARC)

5) (?)
Rule: Copy 650 a to 689 a
Works, but 689 does not exist in my framework - should this be possible?

6) OK
Rule: Add/Update 952 $a CPL
      Add/Update 952 $b CPL
      Add/Update 952 $y BK
Adds items, works nicely

7) OK
Rule: Copy 245 $a to 500 $a Regex: s/e/foo
Intfoormfoodiatfoo Pfoorl - Works nicely.

8) (normal)
Also: Lots of messages in the logs
[Wed Oct 23 00:09:46 2013] [error] [client 127.0.0.1] [Wed Oct 23 00:09:46
2013] marc_modification_templates.pl: Use of uninitialized value in string eq
at /home/katrin/koha/tools/marc_modification_templates.pl line 70., referer:
http://staff.master/cgi-bin/koha/tools/marc_modification_templates.pl
[Wed Oct 23 00:10:06 2013] [error] [client 127.0.0.1] [Wed Oct 23 00:10:06
2013] stage-marc-import.pl: Use of uninitialized value $template_id in string
eq at /home/katrin/koha/C4/MarcModificationTemplates.pm line 84., referer:
http://staff.master/cgi-bin/koha/tools/stage-marc-import.pl

X) Possible enhancements:
- Allow applying of modification templates on staged and maybe also
  imported records
- Warn people from deleting mandatory fields and subfields
- The Add/Update option should have a regex - Ex. set serial flag on LDR

Other problems found:
- Staging MARC records uploads without selecting a file first

Note to myself:
File a bug about translation issues coursed logic in templates (building
sentences)

Kyle, can you please take a look? *hides*

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:57:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:57:55 +0000
Subject: [Koha-bugs] [Bug 8151] Authorities editor should use floating
 toolbar like cataloging interface
In-Reply-To: <bug-8151-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8151-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8151-70-Ux1aTf8YHB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8151

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---


*** This bug has been marked as a duplicate of bug 9676 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 00:57:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 22:57:55 +0000
Subject: [Koha-bugs] [Bug 9676] Replace YUI buttons on authorities editor
 page with Bootstrap
In-Reply-To: <bug-9676-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9676-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9676-70-4E4Jb8R5Tx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9676

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 8151 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 01:14:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 23:14:30 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-t2UfdBt08z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Martin reminded me that we thought about changing the leader on the fly...we
could check for the length of the record and if it is too long, then we could
replace it with xxxxxx or spaces or low numbers or something like that.

We would need to take this into account anytime we were ingesting or
disseminating MARC records though...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 01:47:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 23:47:33 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-CzjPpx6J9o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #28 from Paul Poulain <paul.poulain at biblibre.com> ---
mmm... this patch has been set to "failed QA" by Aix-Marseille university, and
a new patch has been attached. Shouldn't the status be reset to "need signoff"
? Otherwise, explanation welcomed !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 01:51:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 23:51:56 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-8OBWixeVTS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> ---
Some QA comments about this patch (I haven't tested, just looking at the code)
 * you must use 4 spaces and not tabs
 * +1 for the "manual test case". Note that we use the term "test plan". It
could confuse some tester that are not english natives & could search the test
plan

No other code or patch comment (which does not mean passed QA yet, I haven't
tested it either)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 01:58:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 22 Oct 2013 23:58:20 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-6pSzL8h9Nk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:
 * 4 spaces instead of tabs, please
 * I think the sub CheckBranchTransferAllowed should be named
CanBookBeTransferred, that would be more consistent with ...BeIssued and
...BeRenewed (and also C4/Reserves.pm::CanBookBeReserved
 * there's an unconditional warn:
             warn "NotAllowed: $messages->{'NotAllowed'} to  " . $branches->{
$messages->{'NotAllowed'} }->{'branchname'};
=> please add a condition:
   warn ... if $ENV{DEBUG}

 * +1 for .t, looks great ! Note that it's MARC21 specific, I think you
could/should skip some tests if systempreference("marcflavour") eq "UNIMARC"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 02:00:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 00:00:38 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-93xSkULaWG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments: none, except the 4 spaces/tabs one.

Just in case, you could/should read :
http://wiki.koha-community.org/wiki/Coding_Guidelines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 02:11:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 00:11:28 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-aEtY5ozIA8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
By the coordinated efforts of Galen, Jared, Thomas, Tomas, and myself, we've
found that the problems that I was experiencing were due to using version
2.0.3-1 of MARC::Record and the GRS-1 indexing filter.

Newer versions of MARC::Record will set the record length of the leader to
99999 if it exceeds 99999. Here is the commit that changed MARC::Record:

https://sourceforge.net/p/marcpm/code/ci/3efc45777f8e4bec1cd09beb6ab2968e5fb0e44f/

So, upgrading to a newer version of MARC::Record will fix this problem when
using DOM.

However, these problems will persist when using GRS-1 (as it seems that GRS-1
relies on the ISO2709 spec in some way internally). 

As Jared mentioned on IRC, the best bet is probably to push this patch, even
though it will only work for DOM indexing.

GRS-1 indexing will just work the same as always, so there is no negative
impact for GRS-1 users for using this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 08:43:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 06:43:31 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-77nkQruj31@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|The basket group is not     |The basket group is not
                   |display on the parcel page  |displayed on the parcel
                   |                            |page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 09:13:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 07:13:46 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-GM7TNrEAqD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
In fact, passing the biblionumber to DelBiblio seems useless.
It can be retreived inside the sub, with the ordernumber.
I will rewrite the sub so that it takes only the ordernumber.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 09:14:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 07:14:29 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-SAdqFoZHBU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #29 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
patch does not apply anymore. I'm working on that

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 09:30:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 07:30:34 +0000
Subject: [Koha-bugs] [Bug 10891] Make facets customisable
In-Reply-To: <bug-10891-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10891-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10891-70-NfBb0kj7Sa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Make facets customisable    |Make facets customisable
                   |(umbrella report)           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:12:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:12:30 +0000
Subject: [Koha-bugs] [Bug 11120] New: The date option for the
 overdue_notices cronjob is broken
Message-ID: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

            Bug ID: 11120
           Summary: The date option for the overdue_notices cronjob is
                    broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 7447 introduces the --date option for overdue notices.
This option has never worked: the code is waiting for a value but the option is
defined as a boolean.

The date should be defined as --date:s and the script should correctly manage
this option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:12:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:12:57 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-9GBsvALvpM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |7447
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:12:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:12:57 +0000
Subject: [Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl
In-Reply-To: <bug-7447-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7447-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7447-70-ZRqY9pGBdR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11120

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:40:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:40:39 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-X5b755Q7tw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22304&action=edit
Bug 11120: FIX the --date option for overdue_notices cronjob

Bug 7447 introduces the --date option for overdue notices.
This option has never worked: the code is waiting for a value but the
option is defined as a boolean.

This patch fixes the option and change the way to calculate the range of
dates.
This range is now managed in Perl instead of in the SQL query. To do it
in Perl allows to build dates simply using the DateTime and
DateTime::Duration modules.

To test this patch you should have a DB with a lot of overdues, (I
tested on a DB with 512 overdues).
A test plan could be:
1/ Dump your message_queue table
2/ Verify the number of overdues in the database before applying the
  patch:
  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v -t
  (the triggered option will generate overdue for today)
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 2A

  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 2B

2/ Apply the patch
4/ Verify the number of overdues generated by the patched script:
  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v -t
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4A

  mysql> DELETE FROM message_queue;
  perl misc/cronjobs/overdue_notices.pl -v
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4B

  mysql> DELETE FROM message_queue;
  # The date should be defined depending your dateformat preference
  # and should be the date of the current day
  perl misc/cronjobs/overdue_notices.pl -v -t --date="YYYY-MM-DD"
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4C

  mysql> DELETE FROM message_queue;
  # The date should be defined depending your dateformat preference
  # and should be the date of the current day
  perl misc/cronjobs/overdue_notices.pl -v --date="YYYY-MM-DD"
  mysql> SELECT COUNT(*) FROM message_queue;
  Note this value 4D

5/ Compare the values: All values generated with the -t options should
be equals. Same for values without the -t options.
=> 2A == 4A == 4C and 2B == 4B == 4D

6/ Go back to a normal activity for 3 days or manually change the
date_due for issues in the DB:
  mysql> update issues SET date_due = DATE_SUB(date_due, INTERVAL 3 DAY);
Do again step 4C and 4D with a date equals to today - 3 days.
Values should be the same as 4C and 4D.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:40:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:40:35 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-TTeNnpS3Ev@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:51:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:51:40 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-QqgktHlPHl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
?ric, it is a great idea!
But I think your patch should replace *all* locations where a mail is sent in
order to avoid nasty surprise.
Indeed, sendmail is used at some places into Koha (use git grep sendmail).

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:51:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:51:49 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-A8OTdDGUfc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 10:53:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 08:53:43 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-QCWSRXrwIb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Note for QA: circ/offline-mf.tt uses jquery.hotkeys.min.js too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 11:16:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 09:16:16 +0000
Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong
In-Reply-To: <bug-7019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7019-70-74xVeCGNaV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sophie.meynieux at biblibre.co
                   |                            |m

--- Comment #22 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Would it be possible to have it in 3.10.x ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 11:17:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 09:17:36 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-IWwnEzlQaK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Paul Poulain from comment #4)
> Mathieu: additional comments:

>  * Host-item is also defined in 995$a => seems silly to me. Do you confirm ?
> (I haven't changed anything in this patch)

I never used analytics, so not sure of how it is working.
In MARC21, is the equivalent of 995$a also indexed in "Host-item"? If not so,
it is probably a mistake in Unimarc.

>  * all 4xx$t fields are indexed as Title. Isn't it wrong ? (Sounds strange
> to me)

I suppose it could be usefull for some of them, maybe for all.
For ex, if you have a serial whose name has changed, the old name will be in
4XX. And a user could find it by searching the old name.
Idem, if you have a set of 3 books with a collective title (ex : "French
history", with vol. 1 = "From Ceasar to Clovis", vol. 2 = "From Clovis to De
Gaulle"), the main title will be in 200$a, and some 4XX will be used to store
the title of vol. 1 and 2.

See the indexes used in SUDOC network : 
http://documentation.abes.fr/sudoc/manuels/pdf/index_cles.pdf

index MTI (Mot du Titre)
Titre
200 $a $c $d $e $h $i
Note de contenu
327 $a
Titre uniforme
500 $a $h $i $k $l $m $n $q $r $s $u $3
Rubrique de classement
501 $a $e $k $m $r $s $u $3
Titre de forme
503 $a $b $d $e $f $h $i $j
$k $l $m $n
Tous titres ajout?s
51X $a $e $h $i
520 $a $e $h $i
54X $a $e $h $i
Titre cl?
530 $a $b
Titre d?velopp?
532 $a
Titres principaux de tables des mati?res (PROVISOIRE)
359 $b $c
Titres en relation 4XX sauf 410 qui va en COL


Note that the Sudoc is also indexing 359 (table of contents). This field is - I
think - typically french. It is not in Zebra standard unimarc conf files yet.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 11:35:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 09:35:27 +0000
Subject: [Koha-bugs] [Bug 7019] Circulation History Sort Order Wrong
In-Reply-To: <bug-7019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7019-70-qKCXP7Qifz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7019

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22305&action=edit
Bug 7019: [3.10.x] Circulation History Sort Order Wrong (in datatable)

The "return date" column sort is not using the date sort algorithm because it
is
confused by the combination of date data and text data ("Checked out").

This patch adds the use of datatable "title-string" sort type.
With that, the date in ISO format are used for sorting and because letters are
before numbers, "Checked out" rows are more recent than any date.

Test plan :
- set dateformat syspref to "dd/mm/yyyy"
- Go to members/readingrec.pl for a borrower having a old issues and
checked out issues
=> Check that sort of "Return date" is correct.
For example :
With patch :
  20/01/2011
  06/03/2011
  20/03/2011
  Checked Out
Without patch :
  06/03/2011
  20/01/2011
  20/03/2011
  Checked Out
- Test also with dateformat syspref "mm/dd/yyyy"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 11:43:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 09:43:09 +0000
Subject: [Koha-bugs] [Bug 11121] New: Patron Card Creator batch export
 cannot handle special characters (usually)
Message-ID: <bug-11121-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11121

            Bug ID: 11121
           Summary: Patron Card Creator batch export cannot handle special
                    characters (usually)
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: vincent_muyo at yahoo.com
        QA Contact: testopia at bugs.koha-community.org

Exporting a batch with special characters ( e g ?, ?, ?, ?) for patron posts
<firstname> and <surname> will cause them to be corrupted in the exported pdf -
? becomes ??, ? becomes ?? and ? becomes ??, for example. However, this doesn't
always happen - _usually_ the first page comes out correctly (but not with
things already incorrect). 

Everything (apache2, MySQL, linux locale) is set to UTF-8, and label creator
works flawlessly with these symbols. Going off an installation of the 3.12
liveDVD 3.12 (http://sourceforge.net/projects/kohalivedvd/) in Xubuntu. 

Guessing the exporter uses a different standard, e g ANSI, which corrupts the
text - but this is pure guesswork. :)

Extra information about the setup:

Template is for an A4 page, SI Centimeters, 29.7x21. Cards 7.7x4.8, Margins
2x2. 2 columns, 4 rows, gaps 0.5cm each.

Layout is layouted for front with guidebox on. It uses postscript points.
 Text fields Field 1 houses: the bug-related information <firstname> <surname>,
font Helvetica size 12, alignment center, X: 20 Y: 100. 
 Barcode number is printed, Code 39 (generated automatically in provided Katipo
style), X:20, Y: 40

Koha 3.12.05.000

OS version ('uname -a'):     Linux ubuntu 3.2.0-55-generic #85-Ubuntu SMP Wed
Oct 2 13:43:27 UTC 2013 i686 athlon i386 GNU/Linux
Perl interpreter:     /usr/bin/perl
Perl version:     5.014002
Perl @INC:     /usr/share/koha/lib
/etc/perl
/usr/local/lib/perl/5.14.2
/usr/local/share/perl/5.14.2
/usr/lib/perl5
/usr/share/perl5
/usr/lib/perl/5.14
/usr/share/perl/5.14
/usr/local/lib/site_perl
.
MySQL version:     mysql Ver 14.14 Distrib 5.5.32, for debian-linux-gnu (i686)
using readline 6.2
Apache version:     Server version: Apache/2.2.22 (Ubuntu)
Zebra version:     Zebra 2.0.44 (C) 1994-2010, Index Data ApS Zebra is free
software, covered by the GNU General Public License, and you are welcome to
change it and/or distribute copies of it under certain conditions. SHA1 ID:
419ad759807269fdfa379799a051ed3a551c6541 Using ICU 

Running this in a virtual machine, VirtualBox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 11:45:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 09:45:32 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-qRDp5ISKPZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Reverting status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 12:01:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 10:01:53 +0000
Subject: [Koha-bugs] [Bug 11122] New: publisher code and publication year
 not fetched in acq orders
Message-ID: <bug-11122-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

            Bug ID: 11122
           Summary: publisher code and publication year not fetched in acq
                    orders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In acquisition, several templates try to display publisher code and publication
year : invoice.tt, parcel.tt, transferorder.tt.
Thoses pages use C4::Acquisition methods GetPendingOrders or GetInvoiceDetails.
The bug is that in the SQL query of those methods, biblioitems.publishercode
and biblioitems.publicationyear.
In uncertainprice.pl those datas are fetch using GetBiblioData.
It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 12:05:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 10:05:12 +0000
Subject: [Koha-bugs] [Bug 11026] in UNIMARC,
 pubdate index should be based on 100 field and not 210
In-Reply-To: <bug-11026-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11026-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11026-70-wdIMumkz5t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11026

--- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
in MARC21 : 261$c is index in "copydate"
210 is the UNIMARC equivalent.
So let's index too 210$d in "copydate"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 12:20:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 10:20:13 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
 fetched in acq orders
In-Reply-To: <bug-11122-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11122-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11122-70-Nn8LeEWP56@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co
                   |ity.org                     |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22306&action=edit
Bug 11122 - publisher code and publication year not fetched in acq orders

See commit message

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:35:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:35:55 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-awZmGB5CQS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:35:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:35:58 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-Oh40KaLnja@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22307&action=edit
Bug 2546: Description of charges is not translatable

The descriptions for charges are stored in English in the DB
(accounlines.description). So there are not translatable.

This patch removes the descriptions automatically added and generates
the string in the template.

Test plan:
1/ Execute the updatedatabase entry.
2/ Verify in the following pages the description is consistent:
    - members/pay.pl?borrowernumber=XXXX
    - members/boraccount.pl?borrowernumber=XXXX
    - opac-readingrecord.pl
3/ Launch the translate script and update the po files in order to
translate the new strings.
4/ Verify the strings are translated in the interface.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:36:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:36:16 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-1GaeFwYOmV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|christophe.croullebois at bibl |jonathan.druart at biblibre.co
                   |ibre.com                    |m

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:41:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:41:14 +0000
Subject: [Koha-bugs] [Bug 11123] New: 2 routines are unused in C4::Account
Message-ID: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

            Bug ID: 11123
           Summary: 2 routines are unused in C4::Account
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

C4::Accounts::fixcredit and C4::Accounts::refund are marked as deprecated and
are not used. They can be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:41:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:41:23 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-5RbtmAeY8j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:44:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:44:23 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-xhdAvs9Sxe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 13:44:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 11:44:29 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-TwvyWnSNhM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22308&action=edit
Bug 11123: 2 routines are unused in C4::Account

C4::Accounts::fixcredit and C4::Accounts::refund are marked as
deprecated and are not used. They can be removed.

Use:
  git grep fixcredit
  git rgep refund
and verify these routines are not currently in used.

Bonus: The module exports reconcileaccount which is not defined. The
export is removed too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:19:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:19:01 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-36nywujewg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19944|0                           |1
        is obsolete|                            |

--- Comment #32 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22309&action=edit
Bug 9788: Followup for expirationdate in Letter.pm

Pasting comment from the Bugzilla report:
Looking bit longer at this code, it is kind of strange to find it there in the
first place. Adding maxpickupdelay in Letters.pm should not be there, but it
is..

Also this date is not used normally in the default HOLD Available for Pickup
notice (that we are generating in this case). And if it would be undef, the
expiration date should imo be empty instead of today+0. (before adding
maxreservespickupdelay, you should test the allowexpire pref first)
So it is an (invisible) bug on its own.

Test plan:
See former patch. Kyle just discovered this bug, apparently by deleting the
maxpickupdelay pref..

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:20:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:20:41 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-zfTLPrHeNN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #33 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased for different parameter passing to output_pref.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:24:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:24:33 +0000
Subject: [Koha-bugs] [Bug 7706] AuthorisedValueImages not displaying all
 images on the OPAC
In-Reply-To: <bug-7706-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7706-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7706-70-WybjUREIWM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7706

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to I'm just a bot from comment #9)
> This bug depends on 9740 which is in status Failed QA

Setting status to BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:35:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:35:39 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-DXCZszDBP4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:35:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:35:42 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-jWhryyEjkq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22310&action=edit
Bug 7372: Move road types from the roadtype table to the ROADTYPE AV

Currently road types are stored in a specific table in DB. Moreover, an
admin page is present in order to manage them.
This patch proposes to remove this table and this page in favour of a
new authorised value category 'ROADTYPE'.

This patch:
- adds a new AV category 'ROADTYPE' (created from the roadtype table
  content).
- remove the roadtype table.
- remove the .pl and .tt file admin/roadtype
- remove the 2 routines C4::Members::GetRoadTypes and
  C4::Members::GetRoadTypeDetails

Test plan:
1/ Execute the updatedatabase entry and verify existing roadtypes are
now stored in the AV 'ROADTYPE'.
2/ Verify you can add/update a streettype for patrons.
3/ Verify on following pages the streettype is displayed in patron
information (top left):
  circ/circulation.pl
  members/memberentry.pl
  members/moremember.pl
  members/routing-lists.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:35:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:35:56 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-xJ79kmXInK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha.sekjal at gmail.com       |jonathan.druart at biblibre.co
                   |                            |m
         QA Contact|jonathan.druart at biblibre.co |
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:36:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:36:07 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-0uOHxNlYL5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.8                         |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:38:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:38:35 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-Onm0CHqbLf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21952|0                           |1
        is obsolete|                            |

--- Comment #3 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22311&action=edit
Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

Seems a new file circ/offline-mf.tt got added with hotkeys.js.  I replaced it
but I couldn't find ANY usage of it to fix.

Rebased and fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:38:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:38:40 +0000
Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes
In-Reply-To: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9368-70-sJljjytEY5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Jared Camins-Esakov from comment #6)
> This breaks the yr and acqdate indexes when QP is enabled. I will provide a
> counter-patch or follow-up once we are in feature freeze (assigning to
> myself so that I don't forget).
If QP is enabled, those special behavior for yr and acqdate are usless non ?
May we add a "unless useQueryParser" condition ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:39:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:39:08 +0000
Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes
In-Reply-To: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9368-70-CJty1CfPPd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #8 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Jared Camins-Esakov from comment #6)
> This breaks the yr and acqdate indexes when QP is enabled. I will provide a
> counter-patch or follow-up once we are in feature freeze (assigning to
> myself so that I don't forget).
If QP is enabled, those special behavior for yr and acqdate are usless non ?
May we add a "unless useQueryParser" condition ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:41:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:41:38 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-yHqchx91ks@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21952|1                           |0
        is obsolete|                            |
  Attachment #21952|Bug 11035 - Replace         |Bug 11035 - (first patch)
        description|shortcut plugin             |Replace shortcut plugin
                   |jquery.hotkeys.min.js       |jquery.hotkeys.min.js

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:42:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:42:02 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-wiHK5QAPEb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22311|Bug 11035 - Replace         |Bug 11035 - (patching the
        description|shortcut plugin             |patch) Replace shortcut
                   |jquery.hotkeys.min.js       |plugin
                   |                            |jquery.hotkeys.min.js

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:45:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:45:04 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-jhj4y9zI35@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:45:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:45:08 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-FqsvcqSxVx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22109|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22312&action=edit
Bug 10889: fix comment describing biblioitems.serial

biblioitems.serial is not a foreign key; it's a Boolean indicating
whether the biblio record is a serial, which in turn influences how
serial items are displayed.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:45:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:45:20 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-MUJkXNMhS8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co
                   |y.org                       |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 14:52:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 12:52:04 +0000
Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x
	or 200$y
In-Reply-To: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7442-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7442-70-we0AtA1wvD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

--- Comment #21 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #18)
> Fridolyn, see comment 14 - I need instructions on how to correctly catalog a
> UNIMARC authority with the required fields to reproduce this problem.

> Test plan :
> - Edit an authority type summary : for example subject (heading on 250) : summary "[250a][ -- 250x]"
This authority type should exists as SNC (Sujet (nom commun), with : 
  Summary = [250a][ -- 250x][ -- 250y][ -- 250z] [(250b)]
  Auth field copied = 250

> - Create an authority A1 with one heading and a subdivision : for example a subject : 250$a "History" 250$x "20th century"
Create a new authority of type SNC : 
In existing field 250, set $a and $x
   250
      $a "History"
      $x "20th century"
Only those two subfields matter.

> - Create an authority A2 with several headings. for example a subject : 250$a "History" 250$a "Legends"
Create a new authority of type SNC : 
In existing field 250, set $a
   250
      $a "History"
Create a new field 250 and set $a
   250
      $a "Legends"

Does it help ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:04:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:04:57 +0000
Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for
	authorities
In-Reply-To: <bug-7484-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7484-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7484-70-y1XK8CS25C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484

--- Comment #5 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Paola Rossi from comment #4)
> Page "Home ? Authorities"
> 1) I'm on the "Search authorities" tab.
You mean : I'm on the "Search main heading" tab ?

> I select an authority type, then change the active tab. The type change is lost.
I do not reproduce this.
Please test with flush of browser JS cache (Ctrl+F5) after applying the patch.

> If the user would choose different selections in the 3 tabs, the patch would
> loose this information.
Ok but if a user starts in "Search main heading" (1st tab), enters authority
type/order/terms/sort and performs a search. No results. He wants to perform a
search on "Keyword search" (3rd tab), he must all redo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:15:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:15:38 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-7qiR8xDhLc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:15:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:15:42 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-4lqlciFXCe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22087|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22313&action=edit
Bug 11034: remove incorrect return for BiblioAutoLink

BiblioAutoLink was being called expecting an array to
be returned. The subroutine in fact returns a scalar

As the variables that the return was stored in, went
out of scope immediately. It is probably better to be
explicit that we are throwing the return away by not
going through the motions of storing it in a variable

To test:

[1] Add or save a bib record using the cataloging editor.
[2] Verify that no regressions have occurred
[3] (optional) If BiblioAddsAuthorities is on, verify that
    relevant authority records are linked to from the bib.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:21:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:21:05 +0000
Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority
	searches
In-Reply-To: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10829-70-QxQua0X7rR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21965|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22314
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22314&action=edit
Bug 10829 - Browse across pages breaks for authority searches

Test plan
1. Do an authority search in the OPAC (A search for 'an:49' perhaps..
that should bring up results for authority number 49, hopefully there
are multiple pages of results, if not try again and find one that
gives you multiple pages of results)
2. Click the final result on any page of results (there must be more
results to follow for this to work)
3. Try clicking the 'Next' button in the 'Browse results' pane on
the right of the page.
4. It should take you to the next result in the search list (i.e
the first result from the next page of results) - Double check it is
correct, we found that it was often not.

5. Apply patch and run same process, this time you should get the
correct paging.

Signed-off-by: Koha Team Amu <koha.aixmarseille at gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
I reproduce the issue and I confirm this patch fixes it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:21:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:21:00 +0000
Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority
	searches
In-Reply-To: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10829-70-5LcsTZDy3T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:23:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:23:49 +0000
Subject: [Koha-bugs] [Bug 11002] Mandatory fields are not translatable
In-Reply-To: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11002-70-MbAZHE1WRk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11002

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 15:29:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 13:29:18 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-HQqFPFcDCu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #16 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
It is strange to have a cronjob for doing that in UNIMARC.
Do you know how it is done in MARC21? If it is a better way, maybe we could do
a ENH for making unimarc behave the same way as MARC21?

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:03:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:03:59 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-T7yep86sKa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #5 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22315
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22315&action=edit
Bug 8000 - Override emails of every message sent from Koha

Following Jonathan Druart's comments, I fixed every single sendmail occurence:

C4/Letters.pm  (fixed SendAlerts() in addition to the previous standard method)
basket/sendbasket.pl
misc/cronjobs/runreport.pl
opac/opac-sendbasket.pl
opac/opac-sendshelf.pl
virtualshelves/sendshelf.pl

Rebased on latest master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:05:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:05:07 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-fvbHPRZlO9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Blou <philippe.blouin at inlibro.com> ---
Both patches are required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:14:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:14:07 +0000
Subject: [Koha-bugs] [Bug 10889] wrong description for a column of biblio
 table in kohastructure.sql
In-Reply-To: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10889-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10889-70-4UKOQmOHwK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10889

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:16:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:16:23 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-xpdmD4zUTm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:17:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:17:25 +0000
Subject: [Koha-bugs] [Bug 11034] BiblioAutoLink has incorrect return in
	addbiblio.pl
In-Reply-To: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11034-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11034-70-juF03lwr09@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11034

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Thanks, Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:29:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:29:44 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-AcF2HsFaLY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gmcharlt at gmail.com

--- Comment #17 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to mathieu saby from comment #16)
> It is strange to have a cronjob for doing that in UNIMARC.
> Do you know how it is done in MARC21? If it is a better way, maybe we could
> do a ENH for making unimarc behave the same way as MARC21?

MARC21 users tend to use the 005 field, which per bug 5374 gets updated
automatically whenever a bib is saved (it does that for UNIMARC as well,
actually).

>From my POV, it would be a plausible enhancement to have the UNIMARC date
add/modified fields be updated by ModBiblio(Marc).  Is that plausible from the
POV of UNIMARC users?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:30:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:30:26 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-Jt95Gbv7wr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #18 from Galen Charlton <gmcharlt at gmail.com> ---
I've pushed the current patch to master, BTW.  Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:33:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:33:20 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-RhGCKD35bN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Galen Charlton from comment #18)
> I've pushed the current patch to master, BTW.  Thanks, Fridolyn!

(In reply to Galen Charlton from comment #17)
> (In reply to mathieu saby from comment #16)
> > It is strange to have a cronjob for doing that in UNIMARC.
> > Do you know how it is done in MARC21? If it is a better way, maybe we could
> > do a ENH for making unimarc behave the same way as MARC21?
> 
> MARC21 users tend to use the 005 field, which per bug 5374 gets updated
> automatically whenever a bib is saved (it does that for UNIMARC as well,
> actually).
> 
> From my POV, it would be a plausible enhancement to have the UNIMARC date
> add/modified fields be updated by ModBiblio(Marc).  Is that plausible from
> the POV of UNIMARC users?

005 could probably be used in unimarc, as it is made for that ;-)
We tested a long time ago, but I think I remember that the plugin was just
updating 005 when some value was already in 005, and not filling it at first
when we create the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:48:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:48:00 +0000
Subject: [Koha-bugs] [Bug 11124] New: The staff benchmark script does not
 work with sql administrator account
Message-ID: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124

            Bug ID: 11124
           Summary: The staff benchmark script does not work with sql
                    administrator account
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:48:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:48:08 +0000
Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work
 with sql administrator account
In-Reply-To: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11124-70-Aq036pg4MU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:49:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:49:04 +0000
Subject: [Koha-bugs] [Bug 9522] Koha returns &lt, &gt,
 etc in the record instead of <, >, etc when fulfilling a Z39.50 request
In-Reply-To: <bug-9522-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9522-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9522-70-QE8RnQD3zd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:52:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:52:23 +0000
Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work
 with sql administrator account
In-Reply-To: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11124-70-JLgi7HYQ4e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:52:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:52:25 +0000
Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work
 with sql administrator account
In-Reply-To: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11124-70-KEiwbSVfCf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22316
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22316&action=edit
Bug 11124: The staff benchmark script does not work with sql administrator
account

On step 6 (at least), the circulation and return page redirect to the
select branch page and nothing is done.

The script should die if the user used is the sql administrator account.

Test plan:
Suppose that the sql admin account is root/root and koha/koha a superlibrarian
account.

1/
perl misc/load_testing/benchmark_staff.pl --steps=6
--url=http://admin.koha.local/cgi-bin/koha/
--password="koha" --user="koha"
should produce:
  ...
  Step 6
  ...

2/
perl misc/load_testing/benchmark_staff.pl --steps=1
--url=http://admin.koha.local/cgi-bin/koha/
--password="root" --user="root"
should produce:
Authentication successful
You cannot use the database administrator account to launch this script

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:52:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:52:36 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-EvlC0SHuxC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22006|0                           |1
        is obsolete|                            |

--- Comment #7 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22317
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22317&action=edit
Amended patch

Make the change as suggested in the comments

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 16:54:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 14:54:07 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-xg97tsllrf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #8 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Switched back to needs sign off. Bernardo it should pass your test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:01:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:01:33 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-cfLjiTWKIr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22317|0                           |1
        is obsolete|                            |

--- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22318
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22318&action=edit
[SIGNED-OFF] Bug 11054: Specify utf8 encoding when creating a child record

When the only non-ascii characters in a new child record
are latin + diacritic in the range covered by Latin-1 they
are not being added to a new child record correctly encoded.
Explicitly setting the record's encodiing ensures that
they are interpreted correctly.

see "Unicode Bug" in perldoc perlunicode for background on
why these characters are special

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works well. No koha-qa errors.

Same test as before
1) with a record with diacritics in author/title,
2) press new child record, on new record 773adt
with mangled accents
3) Apply patch
4) Repeat 2, now good results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:01:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:01:55 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-faWXAS2wN2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:02:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:02:54 +0000
Subject: [Koha-bugs] [Bug 9522] Koha returns &lt, &gt,
 etc in the record instead of <, >, etc when fulfilling a Z39.50 request
In-Reply-To: <bug-9522-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9522-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9522-70-r51HsoHVAL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9522

--- Comment #6 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
I confirm this bug.

It appears when Zebra database is in GRS1 and when rebuild uses XML (rebuild
-x) and retrieving in MARC (iso2709).

See :
http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#raw%28%29

Best solution is to avoid GRS-1.

But someone must confirm it works using DOM.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:04:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:04:40 +0000
Subject: [Koha-bugs] [Bug 10829] Browse across pages breaks for authority
	searches
In-Reply-To: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10829-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10829-70-5jCaSidfwk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10829

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Good catch.  Pushed to master; thanks, Martin!

Also, this is an object lesson in the utility of named parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:07:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:07:48 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-SItmalmGzJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
I noticed that a function call to the refund was commented out in C4::Accounts,
having not even read the patch. I did a:
   git blame -L440,450 C4/Accounts.pm
to discover that the commit in question was likely done in 2008. So, the second
and third blocks displayed in the patches "Diff" have about 5 years old. I
don't see a problem with them.

I went brute force and did a:
   grep fixcredit `find .`
And the only code found was C4::Accounts. This included: the commented line,
two POD lines, and the function definition line. I see no reason not to remove
fixcredit.

When I did the same for refund, it was messier, so I hoped that the git grep
provided was cleaner. It basically was the same thing, except piped to less. 

C4::Accounts has 3 lines related to the deprecated function refund. I ignored
the blib and po results. There were unrelated results in the stats.screen.pl,
sysprefs.sql, updatedatabase.pl, and various template files. As far as I can
see, there is nothing using the refund function in C4::Accounts.

There is only one reference to reconcileaccount, which is the line that is
exporting it. That makes no sense, so I see no reason to prevent removal.

In short, this patch is good.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:11:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:11:16 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-v4p3DCCEjd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22319&action=edit
[SIGNED OFF] Bug 11123: 2 routines are unused in C4::Account

C4::Accounts::fixcredit and C4::Accounts::refund are marked as
deprecated and are not used. They can be removed.

Use:
  git grep fixcredit
  git grep refund
and verify these routines are not currently in used.

Bonus: The module exports reconcileaccount which is not defined. The
export is removed too.

MLT: Ran qa tool on this patch with no issues either.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:11:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:11:42 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-smUsiE0dCq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22308|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:11:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:11:56 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-CDJttpNv7J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:12:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:12:45 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-Q1rYaJvXHY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21995|0                           |1
        is obsolete|                            |

--- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22320&action=edit
Bug 11005 [ENH] - Centralize the UseBranchTransferLimits-check under one
function

Created a C4::Circulation::CanItemBeTransferred() as a more convenient branch
transfer check
than the previous multiline if-else mess. This is a more pleasant and readable
approach to generalizing
branch transfer checks accross Koha.
Includes a error message as the return value so the precise reasons for denial
need not be constructed
when needed.

Also a small fix to branchtransfers.pl to make a warning happen only during
debugging.

Unit tests included which test the new C4 function.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:13:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:13:15 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-u48Hp8VTIt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21998|0                           |1
        is obsolete|                            |

--- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22321
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22321&action=edit
Bug 11020 - Transfer limits should be checked when placing a hold/reservation
in Staff client

Extended bug 11005.

Extended C4/Reserves.pm to support checking BranchTransferLimits when
requested. Extension does
in no way disturb existing functionality.

Modified the templates to show branch transfer blocks to the user.
Modified the business layer to re-check branch transfer limits in case user
fools the POST-request.

Created manual test plans.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:13:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:13:40 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-ozxoEMlS5Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22000|0                           |1
        is obsolete|                            |

--- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22322
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22322&action=edit
Bug 10993 - Transfer limits should be checked when placing a hold/reservation
in OPAC.

Depends on bug 11005, 11020

Prevents a user from placing holds on material whose branch transfer is denied.
Displays clear messages that items are
unavailable and re-checks in the business layer in case of UI blocks failing.
Enables choosing another pickup location.

Manual test plan included.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:14:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:14:01 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-BWO58DQaXk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22016|0                           |1
        is obsolete|                            |

--- Comment #29 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22323&action=edit
Bug 7376 - Transfer limits should be checked at check-in

Extended UseBranchTransferLimits-check to the check-in case.
Made it possible to override the check-in with circulation-permission if
BranchTransfer is denied.
Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t

*Also added override-functionality to Circulation::AddReturn() to override
BranchTransferLimits. (+unit tests)
*Renamed CanBookBeReturned to CanItemBeReturned since that function was
referenced from AddReturn only.
--This is because function name misguidingly references to a
book/Biblio/Title-level, even if the functionality is strictly
--Item dependent.
*Removed duplicating code by making CanItemBeTransferred() call
IsBranchTransferAllowed().
*Made a unit test library out of CanItemBeTransferred.t's environment
initialization parts,
  so these need not be duplicated whenever UseBranchTransferLimits-related
functionality is tested.
*Documented SIP-testing hardships to C4/SIP/README

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:14:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:14:43 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-I4FPYcyj5U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22002|0                           |1
        is obsolete|                            |

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22324&action=edit
Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl
-script.

Depends on bug 11005

Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm

Includes unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:17:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:17:21 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-OW0ozg4DGV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:17:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:17:26 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-DcrjRIh8Zu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22108|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22325&action=edit
Bug 11057 - Bootstrap theme: Don't hide language chooser below the fold

There is a problem with how an active single language is styled, making
the alignment look incorrect. This patch amends the markup and the CSS
to make it look better. This patch does not address the position of the
language menu.

To test you must have at least one additional single translation
installed. Apply the patch, refresh the page, and confirm that the
display of the active language is improved.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Improved view of current language. No koha-qa errors.

1) Downloaded a couple of xx-YY-bootstrap.po from
http://translate.koha-community.org/projects/314
2) Installed sample languages
3) Enable them and opaclanguagesdisplay
4) Checked correct alignment of selected language

Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
The selected language has not a padding, contrary to others.
Not perfect but it fixes the descripted behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:21:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:21:20 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-Ceep4ykgny@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #30 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
"mmm... this patch has been set to "failed QA" by Aix-Marseille university, and
a new patch has been attached. Shouldn't the status be reset to "need signoff"
? Otherwise, explanation welcomed !" -PP

It should. I noticed this as well but I decided to leave it as is, since
someone had already signed this bug off. I knew it wasn't exactly a nice thing
and was kinda hoping to skip the sign-off part.
Obviously my behaviour was not very nice. Apologies for the misconduct.

Changed tabs to spaces.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:21:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:21:42 +0000
Subject: [Koha-bugs] [Bug 9002] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-9002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9002-70-jNpgyDcnGw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

--- Comment #13 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
As opac template does not use messaging-preference-form.inc, this problem still
exists on OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:22:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:22:24 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-ijtFO8hZQo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Fixed tabs to spaces in indentation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:24:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:24:05 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-lVVmWZDKk2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

--- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Fixed tabs to spaces in indentation. Didn't realize my IDE uses tabs instead of
spaces until bug 11024/7376.
Not sure about templates since they are such a mess regarding indentation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:25:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:25:00 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-e0JGMPPk71@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Fixed tabs to spaces in indentation. Didn't realize my IDE uses tabs instead of
spaces until bug 11024/7376.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:25:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:25:55 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-yjUXv1Zr2C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Paul,
Please reconsider the reindentation for the template file. I have a big patch
for this page (see bug 10363).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:28:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:28:42 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-lxewi4UBq7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #18 from Paola Rossi <paola.rossi at cineca.it> ---

(In reply to Jonathan Druart from comment #17)
> (In reply to Paola Rossi from comment #15)
> Hi Paola, thanks for testing.
> Yes, there is a bug. The original code had changed in bug 5336.
> The followup should be display the order status.

Thanks, Jonathan, now I can see the order's status in the 'Acquisition details'
tab on the biblio detail page, as described.
The various statuses are shown as required, except "Deleted" which is not shown
at all. Neither selecting the "placing an order" value for the AcqCreateItem
pref, nor selecting the "receiving an order" value for the AcqCreateItem pref.
The "Deleted" status is not shown neither if I create an order, and then I
delete it.
So I passed to "failed QA" status.
There is a bug in ACQ and so the test is not very easy to do.
I open two windows, one on CAT and one on ACQ. When I'm going to test the /14
step and select the required function as it has been prepared by the /12 step,
an error appears.  [I did the /14 step by the way of the invoices list,
instead].
Moreover, IMO the "partial" status, as described in the plan, is similar to the
"ordered" one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:31:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:31:05 +0000
Subject: [Koha-bugs] [Bug 11125] New: Remove Problematic Logic from Patron
 Messaging Preferences Form
Message-ID: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

            Bug ID: 11125
           Summary: Remove Problematic Logic from Patron Messaging
                    Preferences Form
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If you do not have SMSSendDriver set and you do not have a
message_transport_type of "sms", you will get an extra table column filled with
a hyphen "-" and no corresponding table heading in the Patron Messaging
Preferences table.  

This pushes the table out of alignment so the email checkbox goes under
"Digests Only?", the digests checkbox goes under "Do not notify", and the Do
not notify checkbox is pushed to the side with no heading.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002 solves intranet
display but OPAC display is always broken

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:31:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:31:34 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-SsUD6G3p3m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

--- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Fixed indentations from tabs to spaces.

Renamed CheckBranchTransferAllowed() -> CanItemBeTransferred()
CanBookBeTransferred refers to a title level check, when the function only
checks item level transferrability.
Like in C4::Reserves::CanItemBeReserved() vs CanBookBeReserved().

Added a Unimarc example to the unit tests.
Uncertain whether or not the different Marc flavour actually prevents the test
from working, since the itemtype-related Marc modification is pulled
dynamically from the Koha to Marc mappings. Expecting these to alter based on
the chosen Marc flavour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:31:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:31:58 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-cau6tKBTbA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |9002
           Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:31:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:31:58 +0000
Subject: [Koha-bugs] [Bug 9002] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-9002-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9002-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9002-70-A6FgRAaeTv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11125

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:48:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:48:53 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-dl69ffdn25@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #18)
> Thanks, Jonathan, now I can see the order's status in the 'Acquisition
> details' tab on the biblio detail page, as described.
> The various statuses are shown as required, except "Deleted" which is not
> shown at all.

Yes, sorry. I mixed "deleted" and "cancelled". New patch is coming.

> There is a bug in ACQ and so the test is not very easy to do.
> I open two windows, one on CAT and one on ACQ. When I'm going to test the
> /14 step and select the required function as it has been prepared by the /12
> step, an error appears.  [I did the /14 step by the way of the invoices
> list, instead].

What is your error ?
I got
  DBD::mysql::st execute failed: Duplicate entry '23173' for key 'PRIMARY' at
/home/koha/src/C4/Items.pm line 2301.

Could you confirm it is the same error ?
I will try to have a look tomorrow. It seems link to bug 10984.

> Moreover, IMO the "partial" status, as described in the plan, is similar to
> the "ordered" one.

No,
"ordered" is used for orders without items received.
"partial" is set for orders with items already received.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:49:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:49:12 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-YItTFMDcWs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:49:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:49:15 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-x8yMR3idX6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22047|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22326&action=edit
Bug 8230: Followup Bug 5336: Change numbers with understandable codes for
orderstatus

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:53:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:53:34 +0000
Subject: [Koha-bugs] [Bug 11126] New: Make the holds system optionally give
 precedence to local holds
Message-ID: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

            Bug ID: 11126
           Summary: Make the holds system optionally give precedence to
                    local holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

This feature would allow libraries to specify that, when items a returned, a
local hold may be given priority for fulfillment even though it is of lower
priority in the list of unfilled holds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 17:58:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 15:58:05 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-toqiyrF5MR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 18:14:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 16:14:16 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-y2djNJUBrg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #1 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 22327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22327&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

 To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 18:15:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 16:15:02 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-kQdYY7SAFo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 18:19:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 16:19:22 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-szJR2Uhwmm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 18:19:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 16:19:25 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-GIVldux4GP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22328
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22328&action=edit
Bug 11126 - Make the holds system optionally give precedence to local holds

This feature will allow libraries to specify that, when an item is returned,
a local hold may be given priority for fulfillment even though it is
of lower priority in the list of unfilled holds.

This feature has three settings:
* LocalHoldsPriority, which enables the feature
* LocalHoldsPriorityPatronControl, which selects for either tha patron's
  home library, or the patron's pickup library for the hold
* LocalHoldsPriorityItemControl, which selects for either the item's
  holding library, or home library.

So, this feature can "give priority for filling holds to
patrons whose (home library|pickup library) matches the item's
(home library|holding library)"

Test Plan:
1) Apply this patch
2) Run t/db_dependent/Holds/LocalHoldsPriority.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 18:21:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 16:21:42 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-j5QNN7ldqy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22328|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22329&action=edit
Bug 11126 - Make the holds system optionally give precedence to local holds

This feature will allow libraries to specify that, when an item is returned,
a local hold may be given priority for fulfillment even though it is
of lower priority in the list of unfilled holds.

This feature has three settings:
* LocalHoldsPriority, which enables the feature
* LocalHoldsPriorityPatronControl, which selects for either tha patron's
  home library, or the patron's pickup library for the hold
* LocalHoldsPriorityItemControl, which selects for either the item's
  holding library, or home library.

So, this feature can "give priority for filling holds to
patrons whose (home library|pickup library) matches the item's
(home library|holding library)"

Test Plan:
1) Apply this patch
2) Run t/db_dependent/Holds/LocalHoldsPriority.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 18:24:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 16:24:11 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-iXJbTEHlDI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 19:35:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 17:35:14 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-PwOdrevJN0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 19:35:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 17:35:33 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-yTE0WkgXRx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22325|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 19:35:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 17:35:45 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-00tJDDFad9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22008|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 19:36:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 17:36:55 +0000
Subject: [Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language
 chooser below the fold
In-Reply-To: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11057-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11057-70-wsjZjKWqLL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
I am setting this back to ASSIGNED, however -- the patch that was submitted
addresses the side issue that Magnus identified, but does not address the main
intent of the bug, which is making the language chooser visible without always
requiring scrolling.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 20:46:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 18:46:43 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-S2RL1yzPAo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
For 773 and 461 : they are used in C4::Biblio::PrepHostMarcField, respectively
for Marc21 and Unimarc. Confirmation that they are equivalent fields.
(By the way, C4::Biblio::PrepHostMarcField seems more written in Marc21 than in
Unimarc)

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 20:48:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 18:48:13 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-HIl3t06f1e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Paul, I think you forgot to add ../unimarc/biblios/biblio-zebra-indexdefs.xsl
to your patch. Could you regenerate it from
../unimarc/biblios/biblio-koha-indexdefs.xml ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 20:56:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 18:56:28 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-Lvfgu6vKVu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Jonathan Druart from comment #8)
> Galen, in fact the aqorders.branchcode field is added by bug 5336 (needs
> QA). So with this patch, the 2 join will become useless.
> It seems there has been a mistake in bug's relations :-/

Hmm, the patches for bug 5336, which is now pushed, do not add an
aqorders.branchcode column.  Maybe something else does?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:35:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:35:45 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-wy7beMyd0g@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14923|0                           |1
        is obsolete|                            |

--- Comment #10 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22330&action=edit
bug 8854: fix some invoice search filters

Fix the supplier, shipment date, and library filters
on the invoice search.  An invoice's library is
(in parallel with order search) defined as the library
of the staff member that approved the basket.  Before this
patch, the code was referring to an aqorders.branchcode
column that doesn't exist.

This patch also improves the author, title, ISBN/EAN/ISSN,
publisher, and publication year filters to no longer require
exact matches; substring matches now suffice.

Finally, this patch considers biblio.copyrightdate in addition
to biblioitems.publicationyear for publication date searches, as
the MARC21 frameworks use the former column but not the latter.

This patch also fixes the current test cases for invoices
so that they pass and adds regression tests.

Test plan:

[1] Create two invoices for different vendors.
[2] Do an invoice search and filter on shipment
    date.  Verify that the expected invoice(s)
    are returned.
[3] Do an invoice search and filter on branch
    (of the staff member that approved the basket).
    Verify that the expected invoice(s) are returned.
[4] Do an invoice search and filter on supplier.
    Verify that the expected invoice(s) are returned.
[5] Do invoice searches on author, title, ISBN/EAN/ISSN,
    publisher, and publication year and verify that the
    results are as expected.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:35:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:35:40 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-FSC9Pis42f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:36:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:36:40 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-afVigMuRhd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
I have attached a replacement patch that should get all the filters working. 
The question of aqorders.branchcode is still not settled, but I think the joins
I've supplied are an acceptable compromise until such time as
aqorders.branchcode is actually added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:36:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:36:54 +0000
Subject: [Koha-bugs] [Bug 11114] Search of Invoices by shipment date results
	in DB error
In-Reply-To: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11114-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11114-70-QcuYtdvDyO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11114

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
                 CC|                            |gmcharlt at gmail.com
         Resolution|---                         |DUPLICATE

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---


*** This bug has been marked as a duplicate of bug 8854 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:36:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:36:54 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-LhfyBJV0KS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
*** Bug 11114 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:37:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:37:41 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-uwUhEERS4m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22269|0                           |1
        is obsolete|                            |

--- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22331
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22331&action=edit
[SIGNED-OFF] Bug 10671: Add missing patron lists help

To test go to Tools > Patron Lists and click 'Help'.
Confirm that the help is there and without typos.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Help present. No typos

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:37:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:37:56 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-5zvQo25X58@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22270|0                           |1
        is obsolete|                            |

--- Comment #24 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22332
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22332&action=edit
[SIGNED-OFF] Bug 10671: Update Authorities Help

To Test go to all authorities pages and click 'Help'.
Confirm that text appears and links work.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Auth help works.
Note: authorities-home.tt and detail.tt have same content.
It's right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:38:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:38:23 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-lewIRpLHHg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22271|0                           |1
        is obsolete|                            |

--- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22333
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22333&action=edit
[SIGNED-OFF] Bug 10671: Update links in Catalog help

To test search the catalog and click results
Test al of the links to the manual and make sure they
go to the 3.14 manual.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All links Ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:38:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:38:50 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-Ys82yuoi85@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22273|0                           |1
        is obsolete|                            |

--- Comment #26 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22334
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22334&action=edit
[SIGNED-OFF] Bug 10671: Update main help files

This patch updates help files that aren't in any other folder.

To test:

* Visit the main staff page and review the help
* Visit the About page and review the help
* Visit a page without help (which there better not be) and
  review the link to the manual

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

All links works.
For a page without help, in detailed view of a record, select MARC or ISBD
tabs,
no help but good link.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:39:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:39:14 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-0UH4DjPTGv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22274|0                           |1
        is obsolete|                            |

--- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22335
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22335&action=edit
[SIGNED-OFF] Bug 10671: Update Lists Help

To test go to Lists in the staff client and click help
Confirm that the link goes to the right manual

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Good link on shelves help

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:39:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:39:37 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-GxSfbnvm4q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22277|0                           |1
        is obsolete|                            |

--- Comment #28 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22336
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22336&action=edit
[SIGNED-OFF] Bug 10671: Add missing authority merge help

Test after 10/23 (when the manual link will work)
Visit authorities
Start a merge
Click help on during the merge process
Be sure that help is there and link works.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

There is help and link works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:40:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:40:15 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-fKO0EOvSwr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22278|0                           |1
        is obsolete|                            |

--- Comment #29 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22337
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22337&action=edit
[SIGNED-OFF] Bug 10671: Update links in label help

This patch updates the links in the label help
to point to the 3.14 manual.

To test:

Visit all label pages and click the help link
confirm that the manual links goes to the right place

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Correct links

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:40:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:40:35 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-eD6De3Aug8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22279|0                           |1
        is obsolete|                            |

--- Comment #30 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22338
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22338&action=edit
[SIGNED-OFF] Bug 10671: Update patron card creator help

Update manual links in the patron card help file.

To test:
* visit all patron card creator pages and click 'help'
* confirm that the link to the manual goes to 3.14

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All links correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:40:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:40:53 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-TFJDm7mxbd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22281|0                           |1
        is obsolete|                            |

--- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22339
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22339&action=edit
[SIGNED-OFF] Bug 10671: Update tag tool help

This patch updates the links to the manual in the
help files on tags.

To test:

* Visit the tag moderation tool
* Click the help link
* Confirm that the links to the manual are right

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Links correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:41:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:41:16 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-BQ3Nss316u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22282|0                           |1
        is obsolete|                            |

--- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22340
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22340&action=edit
[SIGNED-OFF] Bug 10671: Update plugins help

To test visit the plugin pages and confirm that the links
to the manual are right.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Links correct

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:41:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:41:34 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-sCzENU6SIq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22283|0                           |1
        is obsolete|                            |

--- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22341
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22341&action=edit
[SIGNED-OFF] Bug 10671: Update suggestion help

To test visit the suggestion management pages
and confirm that the link in the help file goes
to the right manual.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Link Ok

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:43:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:43:24 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-nK26RswNba@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

--- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
I think that wait for 3.16 is too much.
Perhaps an ENH for 3.14.1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 21:54:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 19:54:51 +0000
Subject: [Koha-bugs] [Bug 10498] Place Hold on Order
In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10498-70-unKyXiEpF1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:08:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:08:03 +0000
Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields.
 Search/link from host to children is broken
In-Reply-To: <bug-10241-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10241-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10241-70-DpuhuFv4Ws@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:08:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:08:34 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-KAXOiGSB7v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #35 from Nicole C. Engard <nengard at gmail.com> ---
(In reply to Bernardo Gonzalez Kriegel from comment #34)
> I think that wait for 3.16 is too much.
> Perhaps an ENH for 3.14.1

Please put it on another bug report so we can discuss it there. Here we want to
just track the changed help files.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:08:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:08:51 +0000
Subject: [Koha-bugs] [Bug 11115] Pull help files from the manual
In-Reply-To: <bug-11115-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11115-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11115-70-OtcZMvXK1J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11115

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10671

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:08:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:08:51 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-bKtDuEqSBI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11115

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:10:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:10:52 +0000
Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
In-Reply-To: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8133-70-ndbN4dSDd4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric.begin at inLibro.com,
                   |                            |philippe.blouin at inlibro.com

--- Comment #8 from Blou <philippe.blouin at inlibro.com> ---
I this dead?  I suppose not, considering the time invested to do this massive
change.  But I ask because the patch will get harder to rebase/merge as time
goes by.

I would like to do some work on the calendar, but I don't want to conflict with
this if it's going to be merged "sonn" (all relative to current time-space
continuum).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:27:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:27:04 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-aFcd91or9a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Nicole C. Engard from comment #35)
> Please put it on another bug report so we can discuss it there. Here we want
> to just track the changed help files.
> 
Was just a comment when switching state to Signed-off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:56:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:56:46 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-GjrHxybrCM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #24 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22342
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22342&action=edit
[PATCH 2/2] Bug 10869 Followup : change DelOrder and adds UT

Changes made to DelOrder : 
Returns undef if no param
DelOrder does no more need a biblionumber. It can be retreived inside the sub.
DelOrder is now cleaning aqorders_items.

UT added for DelOrder

To test :
A. With syspref  AcqCreateItem  = on placing an order

1. Fill a basket with some orders (some records with already existing items or
holds, some without items). New items linked with the order will be created
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders, and check the deletion of the
order implies the deletion of items created when ordering
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.

7. Add some other orders to your basket  (some records with already existing
items or holds, some without items). New items linked with the order will be
created
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
After you have deleted it, the items created when ordering must have been
deleted.

B. With syspref  AcqCreateItem  = on receiving an order

1. Fill a basket with some orders (some records with already existing items or
holds, some without items).
2. Keep the basket open
3. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
4. In the basket, check you can delete the order that was using deleted record
(click on link "Delete order" in the right column of the table)
5. After deleting the order, check there is a new line in the "Deleted orders"
table
6. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.
7. Add some other orders to your basket  (some records with already existing
items or holds, some without items).
8. In the catalog, supress all the items attached to one of the record used in
the basket, then suppress the record
9. Close the basket
10. Go on receipt page
11. Search the orders of your basket
12. In receipt page, check you can delete the order that was using deleted
record (click on link "Delete order" in the right column of the table)
13. Regression test : try to delete other orders
a/ If no items were attached to the record before you created the basket, you
can delete some other orders, AND their record. Try to delete order and record.
b/ If some items were attached to the record before you created the basket, you
can delete some other orders, BUT NOT their record. Try to delete only order.

and to test the UT :
prove t/db_dependant/Acquisition.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:56:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:56:59 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-VZYV1wZWln@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 23 22:57:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 23 Oct 2013 20:57:44 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-B8aKmmqk1T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

--- Comment #25 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
I ask for a 2d signoff, as my followup changes a lot of things in DelBiblio.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 02:15:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 00:15:43 +0000
Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted
 the same on all forms
In-Reply-To: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10661-70-IMoN6WWj79@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 02:15:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 00:15:46 +0000
Subject: [Koha-bugs] [Bug 10661] Mandatory item fields should be formatted
 the same on all forms
In-Reply-To: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10661-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10661-70-DzpgVtTSLA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10661

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22118|0                           |1
        is obsolete|                            |

--- Comment #9 from Brendan Gallagher <brendan at bywatersolutions.com> ---
Created attachment 22343
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22343&action=edit
[PASSED-QA] Bug 10661 - Mandatory item fields should be formatted the same on
all forms

Mandatory item fields are not indicated the same way in all places. This
patch corrects two places where required fields were shown in bold
rather than using the standard "required" class: When adding an order
from a staged file and when adding an item for a new issue of a serial.

This patch also normalizes the text input size on item entry forms: In
some places it was 50, others 67. I have changed the latter to 50.

Unrelated changes: Added $KohaDates formatting of date and time and
corrected capitalization on a heading on the add order from staged file
page.

It would be nice to be able to use the same method for displaying the
item form as we use on neworderentry.tt -- pulling in the form from a
separate include. However that system is designed for handling multiple
items and would need to be adapted for these cases.

To test, you must have a staged file from which to add an order. Open an
existing basket or create a new one and choose to add an order "From a
staged file." Choose a staged file from which to order. The item entry
form under the "Import all" heading should show required fields in red.

To test in serials: Begin the process for receiving an item from an
existing subscription. On the serials-edit page, find the "Click to add
item" links and click to open the item edit forms. There should be one
under the numbered issue and the supplemental issue forms. In both cases
the item edit screen should show the mandatory item fields in red.

Confirm that the cataloging add item form looks correct and works
correctly.

Revision: Left out the "required" note which should appear after each
required field.

Signed-off-by: David Cook <dcook at prosentient.com.au>
Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 06:22:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 04:22:49 +0000
Subject: [Koha-bugs] [Bug 6874] File upload in MARC
In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6874-70-Y217EZ8yLl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #154 from M. Tompsett <mtompset at hotmail.com> ---
Shoot... My librarian colleague came up with a scenario that breaks this.

1) Upload and set everything for a 856$u.
2) Clone the subfield.
3) Click the plugin icon.
This is where the problem comes in, because now the two subfields you can end
up deleting the file for the current 856$u, but the other 856$u still has a
reference to the deleted file in it.

Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 09:40:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 07:40:57 +0000
Subject: [Koha-bugs] [Bug 9192]
 UNIMARC_sync_date_created_with_marc_biblio.pl field creation
In-Reply-To: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9192-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9192-70-5aUmuAqMIc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9192

--- Comment #20 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Galen Charlton from comment #18)
> I've pushed the current patch to master, BTW.  Thanks, Fridolyn!

Thanks a lot.
I know that using this script with cron once a day and not when record is
created/modified is to speed up those actions.
It was even more usefull when items where in MARCXML.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:05:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:05:05 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-rlKAg9hep8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:05:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:05:10 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-bfbGoaX4E1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19925|0                           |1
        is obsolete|                            |

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22344
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22344&action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

This patch adds the Number-local-acquisition into QueryParser configuration
file.
Like in ccl.properties, "Number-local-acquisition" is the main index name and
"stocknumber" and "inv" are aliases.

Test plan :
Enable QueryParser :
- Enable UseQueryParser syspref
- Edit your koha-conf.xml
- Add to "config" node : <queryparser_config>[your
path]/etc/searchengine/queryparser.yaml</queryparser_config>, adapt [your
patch] to your install configuration folder
- If needed copy from sources "etc/searchengine/queryparser.yaml" into your
install configuration folder
Test search :
- Add Number-local-acquisition on an existing subfield in records.abs. For
example on item barcode field
- Reindex Zebra database
- Choose a value of this field that will match some results. For example : "0*"
will match all barcodes beginning with zero
- In intranet, enter this URL : <your
server>/cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance
=> You get some results
- In intranet, enter this URL : <your
server>/cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance
=> You get the same results
- In intranet, enter this URL : <your
server>/cgi-bin/koha/catalogue/search.pl?idx=Number-local-acquisition&q=0*&sort_by=relevance
=> You get the same results

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:05:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:05:39 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-rcvVTeni4K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19443|0                           |1
        is obsolete|                            |

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22345
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22345&action=edit
Bug 10544 - stocknumber index is an alias of Number-local-acquisition

Bug 6256 replaced in bib1.att stocknumber by Number-local-acquisition for
number 1062.
In this case, Number-local-acquisition must be used in record.abs and
stocknumber can be an alias of it in ccl.properties.

Test plan :
- drop zebra database (rebuild_zebra.pl -r ...)
- reindex
- test in simple search : ccl=Number-local-acquisition,alwaysmatches=''
=> you get all records with a stocknumber
- test in simple search : ccl=stocknumber,alwaysmatches=''
=> you get the same results

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:05:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:05:43 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-JUefCRkd9Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19924|0                           |1
        is obsolete|                            |

--- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22346
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22346&action=edit
Bug 10544 - add Number-local-acquisition in known indexes

Adding Number-local-acquisition in C4::Search known indexes allows to search
without using "ccl=" prefix.
Also corrects in ccl.properties : inv must be an alias of
Number-local-acquisition.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:05:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:05:48 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-Cqqh1zXnYn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22344|0                           |1
        is obsolete|                            |

--- Comment #12 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22347
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22347&action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

This patch adds the Number-local-acquisition into QueryParser configuration
file.
Like in ccl.properties, "Number-local-acquisition" is the main index name and
"stocknumber" and "inv" are aliases.

Test plan :
Enable QueryParser :
- Enable UseQueryParser syspref
- Edit your koha-conf.xml
- Add to "config" node : <queryparser_config>[your
path]/etc/searchengine/queryparser.yaml</queryparser_config>, adapt [your
patch] to your install configuration folder
- If needed copy from sources "etc/searchengine/queryparser.yaml" into your
install configuration folder
Test search :
- Add Number-local-acquisition on an existing subfield in records.abs. For
example on item barcode field
- Reindex Zebra database
- Choose a value of this field that will match some results. For example : "0*"
will match all barcodes beginning with zero
- In intranet, enter this URL : <your
server>/cgi-bin/koha/catalogue/search.pl?idx=stocknumber&q=0*&sort_by=relevance
=> You get some results
- In intranet, enter this URL : <your
server>/cgi-bin/koha/catalogue/search.pl?idx=inv&q=0*&sort_by=relevance
=> You get the same results
- In intranet, enter this URL : <your
server>/cgi-bin/koha/catalogue/search.pl?idx=Number-local-acquisition&q=0*&sort_by=relevance
=> You get the same results

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:15:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:15:13 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-Kura5mvdGk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #13 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just some comments for QAer:

I tested the Zebra changes with MARC21/GRS1. It works as advertised.

MARC21 field 037 is mapped to Stock-number. It may be somewhat confusing to
have Stocknumber and Stock-number indexing different MARC fields. Can they be
merged into the same index?

If I search with catalogue/search.pl?idx=number-local-acquisition&q=stock*
I have the error: Can't call method "sort" on an undefined value at
/usr/share/koha/testclone/C4/Search.pm line 426. 
This is outside the scope of this report, but I would personally like to
receive the same search results (just interpret the idx parameter case
insensitive) instead of this error.

Your editing of the query parser config file now shows another index variant:
number-local-acq. Why not just Number-local-acquisition? Is it really needed to
have four names for this index?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:40:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:40:37 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-j2nj98tcc0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
+            if (!($sendAllEmailsTo && $sendAllEmailsTo =~ /@/) ){ # some
validation.  This could be improved.

Why not use Email::Valid->address() ? (This would be a new dependency.)
I suggested to use this cpan module under report 9032 (failed qa for now).
>From there we could go further in checking email addresses in Koha in a
consistent way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:42:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:42:43 +0000
Subject: [Koha-bugs] [Bug 10520] Add i18n function to English mysql files
 for webinstaller
In-Reply-To: <bug-10520-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10520-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10520-70-KEt3lnNDMA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10520

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 10:43:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 08:43:23 +0000
Subject: [Koha-bugs] [Bug 10521] Add i18n function to German mysql files for
 webinstaller (de-DE)
In-Reply-To: <bug-10521-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10521-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10521-70-ZnMKVp4OdH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10521

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
dep. 10520 does not apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:19:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:19:20 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-SzWET3O2u1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11001

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #9)
> Hmm, the patches for bug 5336, which is now pushed, do not add an
> aqorders.branchcode column.  Maybe something else does?

Galen,
Finally I decided to abandon this field (see bug 11001).
I am not sure searching by branch for invoices is relevant since orders from
different branches can exist for a same invoice.
Moreover I don't know if filtering on the patron branchcode is the better
choice: if the aqbasketgroups.billingplace is different, results could be a
source of misunderstanding. Given that libraries have different work flow for
acquisitions, results could be good for some and wrong for others.
Maybe should we simply remove the search by library for invoices?

I'm adding Katrin and Mathieu to this discussion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:19:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:19:20 +0000
Subject: [Koha-bugs] [Bug 11001] The aqorders.branchcode field is missing in
	the DB
In-Reply-To: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11001-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11001-70-thJNKdOS2W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11001

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8854

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:24:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:24:55 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-Jubup2V57S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed for QA               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:24:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:24:58 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-dhYMIFnRWs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22288|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22348
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22348&action=edit
Bug 11090 - Bootstrap theme: CSS problem with suggestions toolbar links

There is a problem with the style on the toolbar on the suggestions page
which makes it float incorrectly. This patch corrects the problem.

To test, log in to the OPAC as a user who has suggestions. The
selections toolbar (which shows the "select all," etc. controls) should
look correct.

Signed-off-by: JD at TeTakere <joanned at tetakere.org.nz>
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:26:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:26:25 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-guvAUlxIQd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to JD at TeTakere from comment #3)
> Logged into Sandbox 8, viewed My Purchase Suggestions.  Toolbar looks fine
> (screenshot attached).

I added your sign off to the patch.
Please switch the status to "Signed off" instead of "Pushed for QA" when you
sign off a patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:40:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:40:31 +0000
Subject: [Koha-bugs] [Bug 11127] New: OPAC suggestion: the delete link is
 active when no suggestion selected
Message-ID: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

            Bug ID: 11127
           Summary: OPAC suggestion: the delete link is active when no
                    suggestion selected
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:40:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:40:49 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-Bd4RjZp6oV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:44:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:44:26 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-aU1xFMBwAa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:44:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:44:28 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-RdyIMxI5nb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22349
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22349&action=edit
Bug 11127: OPAC suggestion: the delete link is active when no suggestion
selected

To reproduce:
1/ go on opac-suggestions.pl
2/ create a suggestion
3/ click on the delete link without checking any checkbox
The form is submitted with a message "The selected suggestions have been
deleted.".

Test plan:
1/ after applying the patch, click on delete without any checkbox
checked, a js alert should occur.
2/ check at least a cb and click on the delete link. The deletion should
work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:46:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:46:06 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-qBAjgi25qQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Should I produce the same fix for others themes (bootstrap and ccsr)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:46:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:46:35 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-N68C4rvYIo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11127

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I discovered a bug on testing this patch, see bug 11127.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:46:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:46:35 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-tSDyWnYfkP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11090

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 11:53:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 09:53:56 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-fV8qcNVM6K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Galen Charlton from comment #9)
> > Hmm, the patches for bug 5336, which is now pushed, do not add an
> > aqorders.branchcode column.  Maybe something else does?
> 
> Galen,
> Finally I decided to abandon this field (see bug 11001).
> I am not sure searching by branch for invoices is relevant since orders from
> different branches can exist for a same invoice.
> Moreover I don't know if filtering on the patron branchcode is the better
> choice: if the aqbasketgroups.billingplace is different, results could be a
> source of misunderstanding. Given that libraries have different work flow
> for acquisitions, results could be good for some and wrong for others.
> Maybe should we simply remove the search by library for invoices?
> 
> I'm adding Katrin and Mathieu to this discussion.

Hi
Not sure of what could be the best solution.

But I can tell you how we deal with that in Rennes 2 : 

But the only time whe had to search invoices in Koha, it was to compare the
number and amount of invoices of Koha with the financial tool of the University
(Sifac), to fix discrepancies (invoices received in one tool and not in the
other...)
Koha invoices display was not good for that, so I had to make a SQL report.
The result look like that
Poste budgetaire    Fournisseur    N? facture    Nom facture    Frais de port
(montant)    Frais de ports (poste)    Qt? re?ue    Cout reel    Prix public
TTC    Prix remis? TTC    Cout reel * Qt?    Cout reel * Qt? + Frais de ports

The first column "Poste budg?taire" is the name of the fund, which in my
library includes the name of the branch. For ex : "BMUS" for Library of MUSic.

But if the name of the fund had not included the name of the branch, I probably
would have added 2 columns with basketgroup.billingplace and
basketgroup.deliveryplace.
Because, as we use basketgroups are our main "grouping entity" for our
relations with our vendors (they receive no info at all about our Koha
baksets), the relevant information for us are basketgroup fields.
But in some libraries it could be baskets fields I presume.


By the way, the filling of basketgroup.{delivery/billing}place should be
syspref dependant. Filling it with the connection site of the librarian is not
good at all for us, and I suppose we are not an isolated case.

Mathieu

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 12:22:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 10:22:59 +0000
Subject: [Koha-bugs] [Bug 11128] New: On cancelling receipt,
 the order is still listed in the received orders
Message-ID: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

            Bug ID: 11128
           Summary: On cancelling receipt, the order is still listed in
                    the received orders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 12:26:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 10:26:57 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-pWT9lP0Sv1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 12:27:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 10:27:00 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-k6TpWncV1l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22350
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22350&action=edit
Bug 11128: On cancelling receipt, the order is still listed in the received
orders

Cause: The list of received orders is built *before* cancelling the receipt!

Test plan:
0/ don't apply the patch
1/ create a basket
2/ create an order with 3 items
3/ receive 1 item
4/ cancel the receipt
=> The order is still listed in the received orders table!
5/ apply the patch
6/ do again steps 1 to 4
=> The order is not listed in the received orders table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 12:27:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 10:27:31 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-tydKmrZvTS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11128

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 12:27:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 10:27:31 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-B5AX5dTAoG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8230

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 12:59:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 10:59:48 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-hpodBjwrPx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22307|0                           |1
        is obsolete|                            |

--- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22351
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22351&action=edit
Bug 2546: Description of charges is not translatable

The descriptions for charges are stored in English in the DB
(accountlines.description). So they are not translatable.

This patch removes the descriptions automatically added and generates
the string in the template.

Test plan:
1/ Execute the updatedatabase entry.
2/ Verify in the following pages the description is consistent:
    - members/pay.pl?borrowernumber=XXXX
    - members/boraccount.pl?borrowernumber=XXXX
    - opac-account.pl
3/ Launch the translate script and update the po files in order to
translate the new strings.
4/ Verify the strings are translated in the interface.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Works as advertised. Corrected few typos in the commit message.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:00:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:00:36 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-7zq8ozipFn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:03:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:03:51 +0000
Subject: [Koha-bugs] [Bug 11129] New: Limiting the display of Serial issues
 OR Searching a specific Serial issue
Message-ID: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

            Bug ID: 11129
           Summary: Limiting the display of Serial issues OR Searching a
                    specific Serial issue
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

One can easily have thousands of Serial issue items in the database.
Currently they are shown in the OPAC and Staff Client in one huge table.
Finding and placing a hold on the desired issue number is hard.
Also there are performance considerations when showing huge amounts of issues
unnecessarily.

By filtering the display of issues before they are loaded on screen, we can
fulfill those requirements.
Changing the default view from huge blob to the most recent items saves DB
effort.
All these modifications apply only to biblios which have subscriptions and more
than AllSerialIssuesDisplayThreshold -system preference items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:04:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:04:42 +0000
Subject: [Koha-bugs] [Bug 11129] Limiting the display of Serial issues OR
 Searching a specific Serial issue
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-jOY6HVdoPY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Medium patch
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:09:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:09:40 +0000
Subject: [Koha-bugs] [Bug 11129] Limiting the display of Serial issues OR
 Searching a specific Serial issue
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-rmJoqwzZTl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Results are filtered by:
branch, volume, number/issue, fromDate, toDate.

Tricky part is ambiguation in volume, number/issue.
This is pulled from the items.enumchron and can have various different ways of
spelling.
Will add a system preference to define the organisation-wide way of labeling
Serial issues.
Filtering cannot be done if the enumerations are not reasonably consistent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:22:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:22:51 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-XZWaygIXLc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:22:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:22:53 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-AkZnrwKQtO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22352
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22352&action=edit
Bug 11123: 2 routines are unused in C4::Account

C4::Accounts::fixcredit and C4::Accounts::refund are marked as
deprecated and are not used. They can be removed.

Use:
  git grep fixcredit
  git grep refund
and verify these routines are not currently in used.

Bonus: The module exports reconcileaccount which is not defined. The
export is removed too.

MLT: Ran qa tool on this patch with no issues either.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:23:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:23:21 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-kaRXnq3dWD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22319|0                           |1
        is obsolete|                            |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:23:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:23:31 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-13Wmu5NH7H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:27:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:27:25 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-okmUimMJdu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22345|0                           |1
        is obsolete|                            |

--- Comment #14 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22353
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22353&action=edit
[SIGNED-OFF]  Bug 10544 - stocknumber index is an alias of
Number-local-acquisition

No change

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:28:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:28:06 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-r2xHTnP7xF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22346|0                           |1
        is obsolete|                            |

--- Comment #15 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22354
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22354&action=edit
[SIGNED-OFF] Bug 10544 - add Number-local-acquisition in known indexes

No change

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:29:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:29:55 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-9VHeioYGAB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #8 from M. Tompsett <mtompset at hotmail.com> ---
I was looking at the updatedatabase.pl portion of the diff. What descriptions
aren't updated? Why is the table not altered and the description column just
dropped?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:30:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:30:53 +0000
Subject: [Koha-bugs] [Bug 10544] stocknumber index is an alias of
 Number-local-acquisition
In-Reply-To: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10544-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10544-70-fsgpXy3UdJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22347|0                           |1
        is obsolete|                            |

--- Comment #16 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22355
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22355&action=edit
Bug 10544 - add Number-local-acquisition in QueryParser config

I revised QP config.
I changed 'number-local-acq' to 'number-local-acquisition'
It appears all indexes are lowercase in this config.

Please re-sign.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:31:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:31:42 +0000
Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded
In-Reply-To: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2546-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2546-70-h8b4do41eN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #8)
> I was looking at the updatedatabase.pl portion of the diff. What
> descriptions aren't updated? Why is the table not altered and the
> description column just dropped?

The description may contain your typed-in comments etc.
We cannot drop it.
Go to Fines and pay something just to see..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:40:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:40:29 +0000
Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric
	format
In-Reply-To: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11059-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11059-70-TUUtkTtbCi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059

--- Comment #10 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Koha Team Lyon 3 from comment #9)
> ?!! I deleted these lines, there are not any more in the last patch. Did you
> really test this one (id=2263) ?
I still see those lines in actual patch.

(In reply to Owen Leonard from comment #8)
> I prefer the newer method where the DataTables plugin looks for an
> ISO-formatted date in a title attribute
Me too, it is more clear and alows to display the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:54:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:54:35 +0000
Subject: [Koha-bugs] [Bug 11130] New: Change pl Place-publication index for
	Marc21
Message-ID: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130

            Bug ID: 11130
           Summary: Change pl Place-publication index for Marc21
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: mirko at abunchofthings.net
        QA Contact: testopia at bugs.koha-community.org

According to ccl.properties, the pl Place-publication index is supposed to
include 008/15-17 and 260$a. In record.abs, we have the index include all 260
fields. This patch removes the index for the whole field 260, leaving only $a
(and 008/15-17).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 13:58:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 11:58:34 +0000
Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21
In-Reply-To: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11130-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11130-70-TknzKKZVww@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130

--- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> ---
Created attachment 22356
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22356&action=edit
Bug 11130 Change pl Place-publication index for Marc21

According to ccl.properties, the pl Place-publication index is supposed to
include 008/15-17 and 260$a. In record.abs, we have the index include all 260
fields. This patch removes the index for the whole field 260, leaving only $a
(and 008/15-17).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 14:03:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 12:03:14 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-tYb6SQX8Ri@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #8 from Blou <philippe.blouin at inlibro.com> ---
I'd go one step further: All emailing should go through one and only one Koha
method.
It's good practice to have system calls isolated so that when upgrade or a new
platform require adjustment, we don't need to run around touching 10 files.
Or when we simply want to improve the process with validation...

I'd be happy to do that... on a different bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 14:14:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 12:14:17 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-d2KETaHELZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 14:22:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 12:22:05 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-Q0WQ0GitDi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 22125
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22125
Bug 11077: Uninitialized value $pki_field warning

Review of attachment 22125:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11077&attachment=22125)
-----------------------------------------------------------------

::: C4/Auth.pm
@@ +754,5 @@
>              -value    => $session->id,
>              -HttpOnly => 1
>          );
> +        $userid = $query->param('userid');
> +        my $pki_field = C4::Context->preference('AllowPKIAuth') // 'None';

I am not sure it is a good idea to suppress the warning caused by an undefined
syspref. This syspref should exist in the DB, else something wrong happened
when updating the DB. Logs must contain this alert.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 14:34:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 12:34:09 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-f6gQVCEk9s@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to Jonathan Druart from comment #9)
> I am not sure it is a good idea to suppress the warning caused by an
> undefined syspref. This syspref should exist in the DB, else something wrong
> happened when updating the DB. Logs must contain this alert.

If something went wrong updating the DB, should that not be in the logs
already? Suppressing while running in a bad state avoids flooding the logs
more. Flooded logs don't get read. TL;DR is a new short form I've come to
learn: Too Long; Didn't Read. This means the the less flooded log has a better
chance of having someone catch the error and correct it. Just my thoughts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 14:37:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 12:37:42 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-ubWbZZJYDG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22323|0                           |1
        is obsolete|                            |

--- Comment #31 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22357
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22357&action=edit
Bug 7376 - Transfer limits should be checked at check-in

Extended UseBranchTransferLimits-check to the check-in case.
Made it possible to override the check-in with circulation-permission if
BranchTransfer is denied.
Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t

*Also added override-functionality to Circulation::AddReturn() to override
BranchTransferLimits. (+unit tests)
*Renamed CanBookBeReturned to CanItemBeReturned since that function was
referenced from AddReturn only.
--This is because function name misguidingly references to a
book/Biblio/Title-level, even if the functionality is strictly
--Item dependent.
*Removed duplicating code by making CanItemBeTransferred() call
IsBranchTransferAllowed().
*Made a unit test library out of CanItemBeTransferred.t's environment
initialization parts,
  so these need not be duplicated whenever UseBranchTransferLimits-related
functionality is tested.
*Documented SIP-testing hardships to C4/SIP/README

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 14:45:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 12:45:15 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-pe5KnSGFGf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. Tompsett from comment #10)
> If something went wrong updating the DB, should that not be in the logs
> already?

I still disagree :) For some reasons, the administrator may have not seen the
error when updating the DB. If there is nothing in logs, there is nothing to
warn him.
So, I let another QAer to have a look at this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 15:01:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 13:01:04 +0000
Subject: [Koha-bugs] [Bug 10075] Extend CGI to provide a param_utf8_decode
	method
In-Reply-To: <bug-10075-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10075-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10075-70-t6W2ksi5ge@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10075

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 15:28:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 13:28:25 +0000
Subject: [Koha-bugs] [Bug 11131] New: Authority search does not display
 summary while searching by all auth types
Message-ID: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

            Bug ID: 11131
           Summary: Authority search does not display summary while
                    searching by all auth types
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- go on authorities/authorities-home.pl
- search 'hugo' by authtype author
- results are displayed with summary
- now select the "all authority types" entry and search "hugo": the results but
without the summary

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 15:28:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 13:28:32 +0000
Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary
 while searching by all auth types
In-Reply-To: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11131-70-KoNbdMFZRs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 15:34:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 13:34:14 +0000
Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary
 while searching by all auth types
In-Reply-To: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11131-70-fmVSGWcvWT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 15:34:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 13:34:17 +0000
Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary
 while searching by all auth types
In-Reply-To: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11131-70-WxbApUsttt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22358
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22358&action=edit
Bug 11131: Authority search does not display summary while searching by all
auth types

The summary is built using the authtypecode selected from the interface.
So when a search is launch on all auth types, the summary is not
correctly built by the BuildSummary routine.
It should get the authtypecode from the authority (call to
GetAuthTypeCode).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 15:59:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 13:59:49 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-9HByosjWH0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Instead of adding the "disabled" attribute to an element which isn't really
supposed to have it (according to the specification) I think it would be better
to check for the existence of a checked checkbox:

  var checkedBoxes = $("input:checked");
  if ($(checkedBoxes).size() == 0) {
     alert(MSG_NO_RECORD_SELECTED);
     return false;
  }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 16:17:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 14:17:05 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-jr4YIqH1Bt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22056|0                           |1
        is obsolete|                            |
  Attachment #22057|0                           |1
        is obsolete|                            |

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22359
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22359&action=edit
Bug 10855: FIX: Add additional fields for closed subscriptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 16:17:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 14:17:11 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-SJQ4kFkfeX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22360&action=edit
Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 16:31:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 14:31:47 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-7I6bigXzhv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:01:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:01:09 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-DqIMITQI2m@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:01:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:01:00 +0000
Subject: [Koha-bugs] [Bug 11132] New: The results list is reset on adding a
 biblio to a list
Message-ID: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

            Bug ID: 11132
           Summary: The results list is reset on adding a biblio to a list
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

To reproduce:
- launch a search at the OPAC (opac-search.pl).
- click on a result and browse results (using previous/next links).
- a title attract your attention and you add it to a list ("Save to yours
lists" link on the right).
- save the list
- browse again results: you cannot, the "browse results" bloc has disappeared.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:07:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:07:48 +0000
Subject: [Koha-bugs] [Bug 11133] New: Markup errors in OPAC place hold form
	HTML
Message-ID: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

            Bug ID: 11133
           Summary: Markup errors in OPAC place hold form HTML
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

There are a couple of markup errors in the new OPAC place hold form. They don't
appear to cause problems but should be fixed for validity's sake.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:08:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:08:04 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-lDHjG9xiJ3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20846|0                           |1
        is obsolete|                            |

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22361
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22361&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaBranchName.pm
Branches.pm

Test Plan:
1) Apply this patch
2) View a basket group, note the branch name is displayed
3) View a subscription's details, note the branch name is displayed
4) View suggestions, note the branch names are displayed
5) Return an item that needs transfered, note the branch name is displayed
6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t'

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Also tested with a branch name with umlauts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:08:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:08:31 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-UnxTm7UJHo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22362
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22362&action=edit
Bug 11132: The results list is reset on adding a biblio to a list

A "busc" param is cleared if the template name is not opac-.*detail.tt.
So if a user adds a biblio to a list, he cannot continue to browse
results.

Test plan:
- launch a search at the OPAC (opac-search.pl).
- click on a result and browse results (using previous/next links).
- a title attract your attention and you add it to a list ("Save to yours
lists" link on the right).
- save the list.
- browse again results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:08:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:08:28 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-ACB1dv1wjW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:08:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:08:40 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-khaKKBZGBl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20847|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22363
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22363&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches -
Followup

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
To test:
Make sure
- independentbranches is turned on
- Your user doesn't have superlibrarian permission
Then
- Try to check out an item with home and holding branch !=
  logged in branch

Patch works alright.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:08:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:08:43 +0000
Subject: [Koha-bugs] [Bug 10858] Browse selected biblios
In-Reply-To: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10858-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10858-70-J4jkBWpZ43@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11132

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:08:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:08:43 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-U7Rnx54Ixo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10858

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:09:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:09:00 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-faPkJHGALZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22364
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22364&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaAuthorisedValues.pm
AuthorisedValues.pm

Test Plan:
1) Apply this patch
2) View the pages that this patch has modified, make sure the branch
   name is still visible

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Comments on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:09:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:09:23 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-amGpuH46Vq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20848|0                           |1
        is obsolete|                            |
  Attachment #20849|0                           |1
        is obsolete|                            |
  Attachment #20962|0                           |1
        is obsolete|                            |
  Attachment #22361|0                           |1
        is obsolete|                            |
  Attachment #22363|0                           |1
        is obsolete|                            |
  Attachment #22364|0                           |1
        is obsolete|                            |

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22365
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22365&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaBranchName.pm
Branches.pm

Test Plan:
1) Apply this patch
2) View a basket group, note the branch name is displayed
3) View a subscription's details, note the branch name is displayed
4) View suggestions, note the branch names are displayed
5) Return an item that needs transfered, note the branch name is displayed
6) Run 'prove t/db_dependent/Koha_template_plugin_Branches.t'

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Also tested with a branch name with umlauts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:09:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:09:27 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-H20qCgLabQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22366
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22366&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaBranchName and Branches -
Followup

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
To test:
Make sure
- independentbranches is turned on
- Your user doesn't have superlibrarian permission
Then
- Try to check out an item with home and holding branch !=
  logged in branch

Patch works alright.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:09:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:09:32 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-GnE80wxqS1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22367
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22367&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues

Looking at the TT plugin directory I notice we have some plugins that
seem to do the same thing:

KohaAuthorisedValues.pm
AuthorisedValues.pm

Test Plan:
1) Apply this patch
2) View the pages that this patch has modified, make sure the branch
   name is still visible

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Comments on second patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:10:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:10:22 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-YhE9ztUHbP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22368
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22368&action=edit
Bug 10626 - Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues - Followup

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Trying to write my own test plan here:

1) AllowNotForLoanOverride = Allow
   Mark single item not for loan and try to check it out.
   Check item not for loan status shows up correctly in message:
   Item is normally not for loan (Staff Collection). Check out anyway?

2) Toggle AllowNotForLoanOverride = Not Allow
   Try to check out your not for loan item again.
   Message has changed, but not for loan status should still show:
   Item not for loan (Staff Collection).

3) Check out item that is marked damaged.
   Check damaged status shows correctly in list of checkouts.

4) Mark item as lost and check it out.
   Check lost status shows up correctly in message:
   This item has been lost with a status of "Lange ?berf?llig (Verloren)".

5) Create your own custom SUGGEST_STATUS and check that it shows
   up correctly on the suggestion page.

6) Test item status show up correctly on OPAC detail page (lost, not
   for loan, damaged, etc). Requires follow-up patch to be applied.

7) Mark a suggestion with your custom status and make sure it shows
   up in the patron account in OPAC correctly.

Passes tests and QA script - needs a follow up for item-status-schema-org.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:10:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:10:32 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-2lATzLzZMT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22369
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22369&action=edit
Bug 10626: Remove doubled up TT plugins - Merge KohaAuthorisedValues and
AuthorisedValues - Followup 2

Removes USE KohaAuthorisedValues plugin from
item-status-schema-org.inc as it does not seem to be used
in the file.

Couldn't detect regressions removing it on OPAC detail page.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:10:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:10:55 +0000
Subject: [Koha-bugs] [Bug 10626] Remove doubled up TT plugins
In-Reply-To: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10626-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10626-70-16u6hH2oJ8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10626

--- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> ---
Rebased first patch to fix merge conflicts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:13:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:13:46 +0000
Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow
 search in 'all libraries'
In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10542-70-iLTuc47hob@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
           Severity|enhancement                 |critical

--- Comment #1 from Galen Charlton <gmcharlt at gmail.com> ---
Here is the error message that gets logged when I try such a search with both
UseQueryParser and OpacSuppression on:

opac-search.pl: WARNING: query problem with (@attr 2=102 @or @or @attr 1=1016
@attr 5=1 @attr 4=6 "history" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6
"history" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "history") not Suppress=1
ZOOM error 20003 "can't set prefix query" (addinfo: "(@attr 2=102 @or @or @attr
1=1016 @attr 5=1 @attr 4=6 "history" @attr 9=20 @attr 2=102 @attr 5=1 @attr 4=6
"history" @attr 9=34 @attr 2=102 @attr 5=1 @attr 4=6 "history") not
Suppress=1") from diag-set 'ZOOM' at /home/gmc/koha/C4/Search.pm line 378.,
referer:
http://opac.zadi.librarypolice.com/cgi-bin/koha/opac-search.pl?idx=&q=history&branch_group_limit=

I'm bumping up the severity to critical as this would be a blocker to making
QueryParser turned on by default for new installations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:27:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:27:01 +0000
Subject: [Koha-bugs] [Bug 11134] New: Typo on course reserves help
Message-ID: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

            Bug ID: 11134
           Summary: Typo on course reserves help
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bgkriegel at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Small typo con course reserves help

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:33:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:33:17 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-h01t0WlSu9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:33:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:33:45 +0000
Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being
	scanned twice
In-Reply-To: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8004-70-mohzPEyu6t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
I'm a but confused about the state of this bug. The initial patch is in master.
Do we still need these followups?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:34:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:34:59 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-6U9BkXX6CT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

--- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22370
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22370&action=edit
Bug 11134 - Typo on course reserves help

This patch fixes a small typo on course reserves help

To test:
1) Go to Course reserves
2) Press 'New course'
3) Press Help
4) On 3dr paragraph you will read "To link a ninstructor ..."
5) Apply patch
6) Now it reads "To link an instructor ..."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:35:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:35:42 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-3rPYyfCNPd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 17:56:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 15:56:40 +0000
Subject: [Koha-bugs] [Bug 11135] New: Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
Message-ID: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

            Bug ID: 11135
           Summary: Parsing of OVERRIDE_SYSPREF_NAMES logs warnings
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

The recently added environment variable OVERRIDE_SYSPREF_NAMES is parsed using
split but most of the time we're splitting an undefined variable. This fills
the error log with warnings, so we should check theres something to split
before executing it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:00:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:00:49 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-kAZfrazhyb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #37 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22371
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22371&action=edit
Bug 10671: Update Circ Help Files

This patch updates the existing help files and
adds the missing offline circ help file.

To test:

* Visit all circ pages and check the manual links
* Visit the new offline circulation page and confirm text
and link are there (link will work after 10/25)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:06:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:06:35 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-VFNiafpaPK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22371|0                           |1
        is obsolete|                            |

--- Comment #38 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22372
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22372&action=edit
Bug 10671: Update Circ Help Files

This patch updates the existing help files and
adds the missing offline circ help file.

To test:

* Visit all circ pages and check the manual links
* Visit the new offline circulation page and confirm text
and link are there (link will work after 10/25)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:09:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:09:09 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-vsM23GPEhH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22373
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22373&action=edit
Proposed patch

lets take warnings seriously folks 

To test this patch should stop 'Use of uninitialized value in split' be
generated when viewing and updating system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:13:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:13:28 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-AHowprGeFp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #39 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22374
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22374&action=edit
Bug 10671: Update Offline Circ Help

This patch updates the offline circulation help files.

To test:

Visit the KOC file upload and pending transactions page
Review the help and check the links

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:18:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:18:18 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-Z8ljIKLJI4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #40 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22375
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22375&action=edit
Bug 10671: Remove Unused Help File

This patch removes an unused help file in the help/export
folder.

To test:

Just confirm that the file is removed, there were no links
to it anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:20:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:20:12 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-ysiyzge8D7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #41 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22376
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22376&action=edit
Bug 10671: Update Reviews Help

This patch updates the link to the manual in the comments
moderation help.

To test:

* Visit comments moderation
* Click the help link
* Confirm manual link works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:23:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:23:06 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-XzcPK9hAaU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #42 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22377
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22377&action=edit
Bug 10671: Update holds help

This patch updates the manual link in the holds help
file.

To test:

* Place a hold in the staff client
* Click the help link
* Confirm manual link works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:33:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:33:38 +0000
Subject: [Koha-bugs] [Bug 10542] QueryParser + OpacSuppression doesn't allow
 search in 'all libraries'
In-Reply-To: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10542-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10542-70-yj1kSXaYDw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10542

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Poking at this more, the immediate cause of the problem is that tacking on 'not
Suppress=1' to the end of a PQF query generated by QP is a syntax error.  That
can be addressed by munging the input to buildQuery(), but I've run into a
roadblock: the PQF QueryParser driver needs to be taught how to use the
negation operator.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 18:57:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 16:57:42 +0000
Subject: [Koha-bugs] [Bug 11123] 2 routines are unused in C4::Account
In-Reply-To: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11123-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11123-70-WHwBEYD8AA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11123

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 19:01:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 17:01:21 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-7fXSI1BdZs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to mathieu saby from comment #14)
> By the way, the filling of basketgroup.{delivery/billing}place should be
> syspref dependant. Filling it with the connection site of the librarian is
> not good at all for us, and I suppose we are not an isolated case.

I'm not sure it warrants a syspref, and I'd prefer that deliveryplace and
billingplace be FKs to the branches table.  Would adding a freebillingplace
column in addition to the exsting freedeliveryplace column meet your needs?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 20:09:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 18:09:07 +0000
Subject: [Koha-bugs] [Bug 11136] New: action_logs should be a MyISAM table,
	not InnoDB
Message-ID: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

            Bug ID: 11136
           Summary: action_logs should be a MyISAM table, not InnoDB
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The table action_logs is written too at a higher rate than practically any
other table. Additionally, action_logs has no foreign key constraints. It seems
that this would be a somewhat unique situation where using MyISAM would provide
quite a performance boost for large sites with many transactions that use the
Action Logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 20:12:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 18:12:35 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-92tor8Mgbf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22378
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22378&action=edit
Bug 11136 - action_logs should be a MyISAM table, not InnoDB

The table action_logs is written too at a higher rate than practically
any other table. Additionally, action_logs has no foreign key
constraints. It seems that this would be a somewhat unique situation
where using MyISAM would provide quite a performance boost for large
sites with many transactions that use the Action Logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 20:12:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 18:12:57 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-RPRcmHo6sa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 20:13:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 18:13:08 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-24WVQ3rfr6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 20:13:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 18:13:14 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-e7X3UZ3p7l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 20:42:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 18:42:04 +0000
Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm
In-Reply-To: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11077-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11077-70-EPSgcic2VO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

--- Comment #12 from M. Tompsett <mtompset at hotmail.com> ---
I did the following testing to see what the current behaviour is and what the
modified behaviour is:
1) I restored a database from 3 months ago.
2) echo > koha-error_log
3) echo > koha-opac-error_log
4) echo > koha-zebradaemon.err
5) ran the staff client upgrade process.
6) logged in.
7) logged out.
8) deleted the AllowPKIAuth system preference.
9) echo > koha-error_log
10) echo > koha-opac-error_log
11) echo > koha-zebradaemon.err
12) clicked the login in button with nothing.

(I chose this case, because between valid, invalid, username only, password
only, and completely blank, the completely blank is easiest to test and show
the difference)

[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 685., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $pki_field in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 758., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:42
2013] mainpage.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 832., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl?logout.x=1
[Thu Oct 24 14:30:42 2013] [error] [client 192.168.45.23] File does not exist:
/home/mtompset/kohaclone/koha-tmpl/intranet-tmpl/prog/en/css/color.css,
referer: http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $lasttime in numeric lt (<) at
/home/mtompset/kohaclone/C4/Auth.pm line 709., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $pki_field in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 758., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $pki_field in string eq at
/home/mtompset/kohaclone/C4/Auth.pm line 795., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:30:43 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:30:43
2013] 404.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 832., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl

Now apply the patch, clear the logs, and click that login button again.


[Thu Oct 24 14:32:54 2013] [error] [client 192.168.45.23] File does not exist:
/home/mtompset/kohaclone/koha-tmpl/intranet-tmpl/prog/en/css/color.css,
referer: http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:32:54 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:32:54
2013] 404.pl: Use of uninitialized value $lasttime in numeric lt (<) at
/home/mtompset/kohaclone/C4/Auth.pm line 709., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl

The key is noticing that 832 did not trigger an error! This else is inside the
if which we fixed. So, 'None' is wrong, because it is a different behaviour. I
changed it to '', and retried.

[Thu Oct 24 14:37:04 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:37:04
2013] mainpage.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 833., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:37:04 2013] [error] [client 192.168.45.23] File does not exist:
/home/mtompset/kohaclone/koha-tmpl/intranet-tmpl/prog/en/css/color.css,
referer: http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:37:04 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:37:04
2013] 404.pl: Use of uninitialized value $lasttime in numeric lt (<) at
/home/mtompset/kohaclone/C4/Auth.pm line 709., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl
[Thu Oct 24 14:37:04 2013] [error] [client 192.168.45.23] [Thu Oct 24 14:37:04
2013] 404.pl: Use of uninitialized value $retuserid in string ne at
/home/mtompset/kohaclone/C4/Auth.pm line 833., referer:
http://demo.library-admin.kohasystem.ca/cgi-bin/koha/mainpage.pl

This is correct behaviour, because there is an extra line added to clean up the
other silent errors and 833 - 1 = 832, and the error message matches.

So, I was wrong to second guess myself. Sorry, tcohen.

However, this does show that at least 2 other silent errors need correcting
before this bug is fully addressed. I'm setting this back to assigned.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:25:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:25:40 +0000
Subject: [Koha-bugs] [Bug 10480] Cataloging plugins without redefining
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-XDY8fx85Av@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:26:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:26:09 +0000
Subject: [Koha-bugs] [Bug 8991] Add a script to delete old orders
In-Reply-To: <bug-8991-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8991-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8991-70-QpIaJcllp1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #17 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:26:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:26:26 +0000
Subject: [Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays
 when calculating a holds last pickup date.
In-Reply-To: <bug-9004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9004-70-rgVM45H0gs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #12 from I'm just a bot <gitbot at bugs.koha-community.org> ---
This bug depends on 8367 which is in status Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:26:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:26:50 +0000
Subject: [Koha-bugs] [Bug 10138] Add some authorized values in french
	installer
In-Reply-To: <bug-10138-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10138-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10138-70-zm7u4e1HCR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10138

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:27:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:27:15 +0000
Subject: [Koha-bugs] [Bug 9940] Add a new index for original language of
	document
In-Reply-To: <bug-9940-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9940-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9940-70-mV1btX7msC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9940

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 9940 : Add a new index for the original language of a document
Using index info to reconstruct a base tree...
M    C4/Search.pm
M    etc/zebradb/biblios/etc/bib1.att
M    etc/zebradb/ccl.properties
M    etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
M    etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
M    etc/zebradb/marc_defs/marc21/biblios/record.abs
M    etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
M    etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
M    etc/zebradb/marc_defs/unimarc/biblios/record.abs
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/record.abs
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/unimarc/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/marc_defs/marc21/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/ccl.properties
Auto-merging etc/zebradb/biblios/etc/bib1.att
Auto-merging C4/Search.pm
Patch failed at 0001 Bug 9940 : Add a new index for the original language of a
document
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:28:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:28:00 +0000
Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging
In-Reply-To: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7683-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7683-70-UISXeN2UJv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #39 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:28:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:28:27 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-CW0yYiDIVs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #38 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 8993: LDAP authentication improvements
Using index info to reconstruct a base tree...
M    C4/Auth_with_ldap.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Auth_with_ldap.pm
CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm
Patch failed at 0001 Bug 8993: LDAP authentication improvements
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:28:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:28:52 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8296-70-gTdYBxVzrC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #53 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 8296: Add descriptive (text) published date field for serials
Using index info to reconstruct a base tree...
M    C4/Serials.pm
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
M    misc/cronjobs/serialsUpdate.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/serialsUpdate.pl
CONFLICT (content): Merge conflict in misc/cronjobs/serialsUpdate.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for
serials
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:29:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:29:21 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-NbyLKATqrb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #18 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7957: Routing lists enhancements
Using index info to reconstruct a base tree...
M    C4/Items.pm
M    C4/Serials.pm
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
M    serials/routing.pl
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): serials/routing.pl deleted in Bug 7957: Routing lists
enhancements and modified in HEAD. Version HEAD of serials/routing.pl left in
tree.
Removing serials/routing-preview.pl
Removing serials/reorder_members.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
CONFLICT (modify/delete):
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt deleted in Bug 7957:
Routing lists enhancements and modified in HEAD. Version HEAD of
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt left in tree.
Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
Auto-merging C4/Items.pm
Patch failed at 0001 Bug 7957: Routing lists enhancements
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:29:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:29:49 +0000
Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id
In-Reply-To: <bug-8868-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8868-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8868-70-MtttyYQzlg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #15 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 8868: ILS-DI: CancelHold needs to take a reserve_id (follow-up)
Using index info to reconstruct a base tree...
M    C4/Reserves.pm
M    t/db_dependent/Reserves.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Reserves.t
CONFLICT (content): Merge conflict in t/db_dependent/Reserves.t
Auto-merging C4/Reserves.pm
Patch failed at 0001 Bug 8868: ILS-DI: CancelHold needs to take a reserve_id
(follow-up)
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:30:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:30:27 +0000
Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation
In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7162-70-gvgvfeCtU1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #46 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7162: Factorize code for order cancellation
Using index info to reconstruct a base tree...
M    C4/Acquisition.pm
M    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Auto-merging C4/Acquisition.pm
CONFLICT (content): Merge conflict in C4/Acquisition.pm
Patch failed at 0001 Bug 7162: Factorize code for order cancellation
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:30:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:30:52 +0000
Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication -
 Further Enhancement
In-Reply-To: <bug-10842-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10842-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10842-70-C8ZAaYy3gq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10842: Fixed bug in Auth_with_ldap
Using index info to reconstruct a base tree...
M    C4/Auth_with_ldap.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Auth_with_ldap.pm
CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm
Patch failed at 0001 Bug 10842: Fixed bug in Auth_with_ldap
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:31:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:31:24 +0000
Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not
 calculate rank of hold
In-Reply-To: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8918-70-FHV3nThePO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #29 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:31:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:31:47 +0000
Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC
In-Reply-To: <bug-10893-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10893-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10893-70-zOBkhdMSjH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #9 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:32:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:32:13 +0000
Subject: [Koha-bugs] [Bug 10922] Display if prices are tax exc. or inc. when
 creating a new order
In-Reply-To: <bug-10922-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10922-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10922-70-QxQaIR9OUW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10922

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #4 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:32:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:32:36 +0000
Subject: [Koha-bugs] [Bug 8897] Optional GnuPG encryption of outgoing emails
In-Reply-To: <bug-8897-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8897-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8897-70-IjBXgq5HBz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8897

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #36 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 8897 [ENH] GPG Mail encryption -- New version
Using index info to reconstruct a base tree...
M    C4/Installer/PerlDependencies.pm
M    C4/Letters.pm
M    debian/control
M    install_misc/debian.packages
M    opac/opac-sendshelf.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-sendshelf.pl
CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl
Auto-merging install_misc/debian.packages
Auto-merging debian/control
CONFLICT (content): Merge conflict in debian/control
Auto-merging C4/Letters.pm
CONFLICT (content): Merge conflict in C4/Letters.pm
Auto-merging C4/Installer/PerlDependencies.pm
CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm
Patch failed at 0001 Bug 8897 [ENH] GPG Mail encryption -- New version
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:33:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:33:08 +0000
Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin
In-Reply-To: <bug-8334-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8334-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8334-70-2IbyWZVjVU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #13 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:33:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:33:32 +0000
Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and
 resumed from the OPAC
In-Reply-To: <bug-10774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10774-70-kvhXsIPZKl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:34:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:34:22 +0000
Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8436-70-NNfbwUgLvS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:34:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:34:49 +0000
Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers -
 Provide a download file of errors
In-Reply-To: <bug-5771-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5771-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5771-70-6quLehEh6l@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #13 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:35:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:35:19 +0000
Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored
 locally when using LDAP
In-Reply-To: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9165-70-cw1utoSN6b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 9165 - Prevent LDAP passwords being stored locally
Using index info to reconstruct a base tree...
M    C4/Auth_with_ldap.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Auth_with_ldap.pm
CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm
Patch failed at 0001 Bug 9165 - Prevent LDAP passwords being stored locally
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:35:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:35:46 +0000
Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with
 AllowOnShelfHolds off
In-Reply-To: <bug-6918-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6918-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6918-70-YoOmE3JvJJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #19 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:36:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:36:21 +0000
Subject: [Koha-bugs] [Bug 8587] Add a serial lifespan to serial subscriptions
In-Reply-To: <bug-8587-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8587-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8587-70-rAlzyNwpDa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #17 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:36:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:36:44 +0000
Subject: [Koha-bugs] [Bug 10670] /etc/init.d/koha-common fails to start
 zebra due to log permission problem
In-Reply-To: <bug-10670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10670-70-vvqeAA8bTB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10670

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:37:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:37:11 +0000
Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC
	6XX
In-Reply-To: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9828-70-7FhjErTkR8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 9828: More specific indexing of UNIMARC 6XX fields
Using index info to reconstruct a base tree...
M    C4/Search.pm
M    etc/zebradb/biblios/etc/bib1.att
M    etc/zebradb/ccl.properties
M    etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
M    etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
M    etc/zebradb/marc_defs/unimarc/biblios/record.abs
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/ccl.properties
CONFLICT (content): Merge conflict in etc/zebradb/ccl.properties
Auto-merging etc/zebradb/biblios/etc/bib1.att
Auto-merging C4/Search.pm
Patch failed at 0001 Bug 9828: More specific indexing of UNIMARC 6XX fields
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:37:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:37:34 +0000
Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has
	awkward wording
In-Reply-To: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10776-70-97HhosSC5u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:37:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:37:58 +0000
Subject: [Koha-bugs] [Bug 10789] Excessive and often incorrect use of finish
 in C4::Acquisitions
In-Reply-To: <bug-10789-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10789-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10789-70-vFHMVJEVZC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10789

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10789 Remove unnecessary calls to finish in C4::Acquisitions
Using index info to reconstruct a base tree...
M    C4/Acquisition.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Acquisition.pm
CONFLICT (content): Merge conflict in C4/Acquisition.pm
Patch failed at 0001 Bug 10789 Remove unnecessary calls to finish in
C4::Acquisitions
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:38:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:38:26 +0000
Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide
 tab-completion in bash
In-Reply-To: <bug-10003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10003-70-QPePvvuYEZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:38:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:38:51 +0000
Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local
 subject added entry" fields.
In-Reply-To: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10308-70-SdCWNdR1Ft@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:39:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:39:16 +0000
Subject: [Koha-bugs] [Bug 10834] Add Sort 1 and Sort 2 to list of searchable
 patron fields
In-Reply-To: <bug-10834-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10834-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10834-70-sXlD5C14uK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10834

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:39:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:39:39 +0000
Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search
In-Reply-To: <bug-10852-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10852-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10852-70-HOkjJ6uYIn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-25
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:50:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:50:00 +0000
Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-imkfTUxfvr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 21:50:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 19:50:12 +0000
Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-7vU9db8Qq7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:16:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:16:04 +0000
Subject: [Koha-bugs] [Bug 11137] New: QueryParser can ignore parts of a
 Boolean search after the first
Message-ID: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

            Bug ID: 11137
           Summary: QueryParser can ignore parts of a Boolean search after
                    the first
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

The way that the QueryParser configuration is initialized results in duplicate
search field aliases being defined, which in turn can cause problems with
Boolean searches.

For example, consider the following search:

kw:history && earth

This will retrieve all records that have both 'history' and 'earth' as
keywords.

Depending on your search settings, this search is received by Zebra as

@attrset Bib-1 @and @attr 4=6 @attr 5=1 @attr 1=1016 history @attr 4=6 @attr
5=1 @attr 1=1016 earth

Now consider this search, which should be identical:

kw:history && kw:earth

This search retrieves all records containing 'history', but ignores 'earth'. 
The search received by Zebra is:

@attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=1016 histor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:29:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:29:48 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-kZleJ0Lnwv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |z.tajoli at cineca.it

--- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> ---
Hi,

I set 'In discussion' for two points:

1) In fact it is an DB update, so the patch needs to change also 
 installer/data/mysql/kohastructure.sql

2)Are we sure that is a good idea to use two different engine of MySQL at same
time in Koha ?
Reading those two pagees we can think that mixing InnoDB and MySQL needs a
quite tuning to be useful:

http://www.mysqlperformanceblog.com/2010/05/08/the-doom-of-multiple-storage-engines/
http://dba.stackexchange.com/questions/9221/any-problem-will-all-innodb-and-one-myisam-table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:38:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:38:41 +0000
Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC
	6XX
In-Reply-To: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9828-70-qwcOTy15WS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17164|0                           |1
        is obsolete|                            |

--- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22379
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22379&action=edit
[PATCH] Bug 9828: More specific indexing of UNIMARC 6XX fields

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:42:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:42:47 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-WdOHjMDjtx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Jared, I suppose I need to add a followup to this bug I wrote some time ago and
which does not take into account the QP :
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828 and added some
fields to Search.pm.
I don't know at all how to do this, and in which cases (when Search.pm is
altered? when bib1.att is altered? when ccl.properties is altered?).

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:54:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:54:30 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-s2XeCH7tKT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:54:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:54:34 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-adi4E8jyeR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

--- Comment #1 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22380
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22380&action=edit
Bug 11137: regression tests for QP search field alias bug

This patch adds regression tests to verify that
Boolean searches using QueryParser function correctly.

This patch also ensures that QP is correctly initalized
when Search.t is run.

To test:

[1] Apply this patch and the following patch.
[2] Verify that prove -v t/QueryParser.t works
[3] Verify that prove -v t/db_dependent/Search.t works
[4] (optional) instead of applying both patches at the same
    time, apply only the regression test patch and run the
    tests listed in steps 2 and 3.  The following tests
    should fail:

t/db_dependent/Search.t (Wstat: 512 Tests: 198 Failed: 2)
  Failed tests:  42, 71
  Non-zero exit status: 2
t/QueryParser.t (Wstat: 256 Tests: 28 Failed: 1)
  Failed test:  12
  Non-zero exit status: 1

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:54:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:54:40 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-aw4IRv71mE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22381
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22381&action=edit
Bug 11137: fix certain types of searches run using QueryParser

QueryParser was loading redundant search aliases, which in turn resulted
in certain queries involving two or more clauses joined by a Boolean
operator getting parsed in correctly.

To test:

[1] Enable QueryParser.
[2] Arrange your database so that some some bib records contain
    the keyword 'history' while a smaller subset contain
    both 'history' and 'earth'.  (The exact words used don't
    matter.)
[3] Run the following search from the OPAC global search bar:

    kw:history && kw:earth

[4] Observe that the records that are returned include *all* bibs
    in the database with the keyword 'history'.  In other words, the
    restriction  that the records must also contain 'earth' is not
    observed.
[5] Apply the patch and rerun the search.
[6] This time, the results that are returned should include only those
    that contain both 'history' and 'earth'.
[7] Verify that prove -v t/QueryParser.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:58:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:58:20 +0000
Subject: [Koha-bugs] [Bug 9940] Add a new index for original language of
	document
In-Reply-To: <bug-9940-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9940-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9940-70-GN1grIcNSl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9940

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17771|0                           |1
        is obsolete|                            |

--- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Created attachment 22382
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22382&action=edit
[PATCH] Bug 9940 : Add a new index for the original language of a document

Rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:58:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:58:30 +0000
Subject: [Koha-bugs] [Bug 9940] Add a new index for original language of
	document
In-Reply-To: <bug-9940-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9940-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9940-70-nalmUlcDsY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9940

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:58:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:58:40 +0000
Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC
	6XX
In-Reply-To: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9828-70-hhOPpCxHDR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 22:59:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 20:59:24 +0000
Subject: [Koha-bugs] [Bug 9828] Zebra indexes useless subfields in UNIMARC
	6XX
In-Reply-To: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9828-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9828-70-qiwn6H8OtC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9828

--- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
A followup is probably needed for QueryParser. I don't know how to do that.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 23:33:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 21:33:40 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-Vsce5Q3pb4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22380|0                           |1
        is obsolete|                            |
  Attachment #22381|0                           |1
        is obsolete|                            |

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22383
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22383&action=edit
Bug 11137: regression tests for QP search field alias bug

This patch adds regression tests to verify that
Boolean searches using QueryParser function correctly.

This patch also ensures that QP is correctly initalized
when Search.t is run.

To test:

[1] Apply this patch and the following patch.
[2] Verify that prove -v t/QueryParser.t works
[3] Verify that prove -v t/db_dependent/Search.t works
[4] (optional) instead of applying both patches at the same
    time, apply only the regression test patch and run the
    tests listed in steps 2 and 3.  The following tests
    should fail:

t/db_dependent/Search.t (Wstat: 512 Tests: 198 Failed: 2)
  Failed tests:  42, 71
  Non-zero exit status: 2
t/QueryParser.t (Wstat: 256 Tests: 28 Failed: 1)
  Failed test:  12
  Non-zero exit status: 1

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 24 23:33:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 21:33:50 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-zGTumkgpBB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22384
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22384&action=edit
Bug 11137: fix certain types of searches run using QueryParser

QueryParser was loading redundant search aliases, which in turn resulted
in certain queries involving two or more clauses joined by a Boolean
operator getting parsed in correctly.

To test:

[1] Enable QueryParser.
[2] Arrange your database so that some some bib records contain
    the keyword 'history' while a smaller subset contain
    both 'history' and 'earth'.  (The exact words used don't
    matter.)
[3] Run the following search from the OPAC global search bar:

    kw:history && kw:earth

[4] Observe that the records that are returned include *all* bibs
    in the database with the keyword 'history'.  In other words, the
    restriction  that the records must also contain 'earth' is not
    observed.
[5] Apply the patch and rerun the search.
[6] This time, the results that are returned should include only those
    that contain both 'history' and 'earth'.
[7] Verify that prove -v t/QueryParser.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 00:44:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 24 Oct 2013 22:44:55 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-wm1HTHzJvG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 05:16:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 03:16:51 +0000
Subject: [Koha-bugs] [Bug 11138] New: Auto-unsuspend holds not in default
	cronjobs
Message-ID: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138

            Bug ID: 11138
           Summary: Auto-unsuspend holds not in default cronjobs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: liz at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Auto Unsuspend holds is not in the cronjobs by default in the packages. It
should be in the defaults.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 05:41:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 03:41:53 +0000
Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs
In-Reply-To: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11138-70-LCROlLQLHb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138

--- Comment #1 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 22385
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22385&action=edit
Bug 11138 - auto_unsuspend_holds cronjob not in default cron jobs.

to test:
Install the packages with this patch, observe the /etc/cron.daily/koha-common
file - auto_unsuspend_holds should now be in the default list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 05:44:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 03:44:09 +0000
Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs
In-Reply-To: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11138-70-lYQqVuAM3A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 08:35:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 06:35:26 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-zWvfjNVxjz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.aixmarseille at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 09:41:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 07:41:15 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-OtrFH1McSK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22004|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22386&action=edit
Bug 11023: Toggle "new" status

This patch adds:
- a new DB field items.new.
- a new page to configure this new status
  (tools/toggle_new_status.pl).
- a new cronjob script (misc/cronjob/toggle_new_status.pl).

Why this status is useful for some libraries ?
The use cases are:
- to know easily what are the new items (with a simple sql query).
- to display an icon in the search results.
- issuing rules can be adapt for new items. Automatically (using the
  cronjob script), the status change (depending the configuration) and
  the item can be issued, for example.
- a RSS/Atom feeds can be created on these new items.

Test plan:
- log in with a librarian having the tools > items_batchmod permission.
- navigate to Home > Tools > Toggle new status
- click on the edit button
- there are 3 "blocks":
  * duration: the duration during an item is considered as new.
  * conditions: the status will change only if the conditions are meet.
  * substitutions: if there is no substitution, no action will be done.
    You can add some change to apply to the matching items.
    E.g. ccode=3
         new=''
    If the value is an empty string (in other words, the input does not
    contain anything), the field will be deleted.
  You can create as many rules as you want.
- test the interface : add/remove rule, conditions, substitutions,
  submit the form, edit, etc.
  (There is a looot of JS everywhere, so certainly a looot of bugs...).
- when you have your rules defined, you can now launch the cronjob
  script without any parameter.
  A report will be displayed with the matching itemnumber and the
  substitutions to apply. Verify results are consistent.
- launch the script with the -c argument and verify values have been
  modified depending the substitution rules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 09:44:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 07:44:04 +0000
Subject: [Koha-bugs] [Bug 11023] Toggle new status for items
In-Reply-To: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11023-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11023-70-BJnMLXuYqM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
There were been several iterations with Laurence. She found some bugs I fixed.
This last patch is the final version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 11:43:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 09:43:30 +0000
Subject: [Koha-bugs] [Bug 11139] New: opac-topissues does not work with CCODE
Message-ID: <bug-11139-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

            Bug ID: 11139
           Summary: opac-topissues does not work with CCODE
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

When OPAC most populars uses collection code, it does not work.
There are never results.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 11:55:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 09:55:58 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To: <bug-11139-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11139-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11139-70-TRXIxSuAT2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22387&action=edit
Bug 11139 - opac-topissues does not work with CCODE

See commit message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 11:56:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 09:56:05 +0000
Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
In-Reply-To: <bug-11139-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11139-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11139-70-TbqqTTtBxE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:01:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:01:11 +0000
Subject: [Koha-bugs] [Bug 9374] In baskets,
	prices between 0 and 1 are displayed in red
In-Reply-To: <bug-9374-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9374-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9374-70-TFawnP8edP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9374

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #8)
> Bugs 10792 and 10929 are somewhat related, as they touch on the general
> problem of  displaying monetary amounts.

For information, I proposed a similar way in bug 9410.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:10:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:10:02 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-S8avp2sFIu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

--- Comment #32 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Olli-Antti Kivilahti from comment #30)
> "mmm... this patch has been set to "failed QA" by Aix-Marseille university,
> and a new patch has been attached. Shouldn't the status be reset to "need
> signoff" ? Otherwise, explanation welcomed !" -PP
> 
> It should. I noticed this as well but I decided to leave it as is, since
> someone had already signed this bug off. I knew it wasn't exactly a nice
> thing and was kinda hoping to skip the sign-off part.
> Obviously my behaviour was not very nice. Apologies for the misconduct.
I didn't spot any misconduct, but as long as a patch is "failed QA" no one
takes care of it, except the patch author. So if you submit a new patch, then
you need to change the status.

When a failed QA is caused by a small/minor QA problem, like an indent one,
then, it's OK to switch back to "signed off" if the patch has already been
signed off. Otherwise, back to "need signoff". But not let "failed QA" status
as it is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:12:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:12:18 +0000
Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table
	html element
In-Reply-To: <bug-8199-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8199-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8199-70-ZrkulQyxzD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I don't plan to work on it.
Reopen if someone is interested.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:14:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:14:51 +0000
Subject: [Koha-bugs] [Bug 11019] Adding new category in authorized values
In-Reply-To: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11019-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11019-70-8o4pmvGXz2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11019

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10363

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
Considering Jonathan's patch is a large improvement, I set this one "in
discussion", until the bug 10363 has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:14:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:14:51 +0000
Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values.
In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10363-70-sXBnLproz7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11019

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:54:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:54:31 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-9rbhyWY4lj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22350|0                           |1
        is obsolete|                            |
                 CC|                            |paola.rossi at cineca.it

--- Comment #2 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 22388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22388&action=edit
On cancelling receipt, the order is still listed in the received orders

the patch is applied again master 3.13.00.032.
I sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 12:54:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 10:54:46 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-PiSJ0VuTeL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 13:54:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 11:54:21 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-QXp2B7MNsa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 13:54:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 11:54:25 +0000
Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the
	invoice page
In-Reply-To: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10613-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10613-70-ROGO6zsV3c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22389&action=edit
Bug 10613: FIX typo supplierid vs booksellerid

GetInvoiceDetails returns a hashref with a key named booksellerid, not
supplierid.
The bookseller was not retrieved from the DB and the listincgst value
was always false.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 14:32:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 12:32:14 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-D5I8i77BPR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 14:32:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 12:32:18 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-tJAsULew5P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

--- Comment #46 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22390&action=edit
Bug 8037: FIX bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 14:50:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 12:50:00 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-zcAARpdNA5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

--- Comment #20 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to mathieu saby from comment #19)
> I don't know at all how to do this
I will provide a QP follow-up for this bug 10740, to add
"date-time-last-modified".
I noticed that in QP all indexes are lowercase.
So in the end I wonder why not use everywhere : "date-time-last-modified" and
not "Date/time-last-modified".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:04:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:04:08 +0000
Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in
	ccl.properties
In-Reply-To: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10740-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10740-70-enHeNDJ2l1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22262|0                           |1
        is obsolete|                            |

--- Comment #21 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22391&action=edit
Bug 10740 - date created and modified indexes in ccl.properties and QP

Revised patch.
Date/time-last-modified converted in date-time-last-modified for QP.
I think using / in an index would have provoke bugs is future.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:13:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:13:42 +0000
Subject: [Koha-bugs] [Bug 11009] Do not allow reading records of anonymous
	patron
In-Reply-To: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11009-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11009-70-pCztTmvw6u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11009

--- Comment #9 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
I've set this as major because it may really block the server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:30:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:30:19 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-uPXdz5NHl1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22185|0                           |1
        is obsolete|                            |

--- Comment #181 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22392&action=edit
Bug 8015 - Add MARC Modifications Templates

The MARC Modification Templates system gives Koha users
the power to make alterations to MARC records automatically
while staging MARC records for import.

This tool is useful for altering MARC records from
various venders work with your MARC framework.

The system essentially allows one to create a basic script
using actions to Copy, Move, Add, Update and Delete fields.

Each action can also have an optional condition to check
the value or existance of another field.

The Copy & Move actions also support Regular Expressions,
which can be used to automatically modify field values during the
copy/move. An example would be to strip out the '$' character
in field 020$c.

Furthermore, the value for an update can include variables
that change each time the template is used. Currently,
the system supports two variables, __BRANCHCODE__ which
is replaced with the branchcode of the library currently
using the template, and __CURRENTDATE__ which is replaced
with the current date in ISO format ( YYYY-MM-DD ).

At its simplist, it can perform functions such as:
Copy field 092$a to 952$c
At its most complex it can run actions like:
Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:30:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:30:40 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-UjRdJU4NbY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22186|0                           |1
        is obsolete|                            |

--- Comment #182 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22393&action=edit
Bug 8015: Followup: FIX cp and mv if subfields don't exist.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Followup: On move, we cant delete existing fields

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:31:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:31:00 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-tLEoFtuhlL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22187|0                           |1
        is obsolete|                            |

--- Comment #183 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22394&action=edit
Bug 8015 - Add MARC Modifications Templates - Followup

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:31:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:31:18 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-uJqvD75fgu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22188|0                           |1
        is obsolete|                            |

--- Comment #184 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22395&action=edit
Bug 8015: Followup Add MARC Modifications Templates

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Catch error in the SetUTF8Flag routine

The eval avoids the interface to run endlessly if an error occurred.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Leila <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:31:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:31:35 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-jwvSZmvBSp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22189|0                           |1
        is obsolete|                            |

--- Comment #185 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22396&action=edit
Bug 8015: Fix template capitalization amd other template issues

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix error where field object is returned instead of field value for
fields without subfields

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix bad ordering on function parameters

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Escape escape characters for strings

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix bad parameter list for direct external call to update_field

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: Fix problem with moving existing subfield value to nonexistent
field/subfield

Signed-off-by: Leila <koha.aixmarseille at gmail.com>

Bug 8015: FIX QA issues

This patch fixes some stuffs failing qa tests: POD, indentation (tabs),
perlcritic

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:31:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:31:49 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-rwRUFtDQGE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22190|0                           |1
        is obsolete|                            |

--- Comment #186 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22397&action=edit
Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Bug 8015: Fix complains from qa tools

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: Get rid of the eval in ModifyRecordWithTemplate

This patch removes the use of eval in the
C4::MarcModificationTemplates::ModifyRecordWithTemplate routine.

Now this routine call the wanted modification routine with the list of
parameters.
This call is done only if the condition is respected.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: Get rid of eval for evaluating =~ m//

Koha::SimpleMarc::field_equals uses eval in order to check if a string
matches a pattern.
Now this eval is removed and the "regex" variable does not contain the
regex separated character (/ or |).

Regression: Before this patch, the user was able to user a modifier. Now
it is not possible.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: Get rid of the eval for substitution

Before this patch, the regex substitution was contain into only one
variable (e.g. my $regex = "/foo/bar/i").
Now each member of the regex is stored into a field in the
marc_modification_template_actions sql table.

In order to avoid a complex code, only modifiers i and g are take into
account.

Note: If you already add the mmta table, you have to drop it.
This patch also adds a foreign key from mmta to mmt tables.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: FIX ui issue

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Bug 8015: The template name is a required field

Test plan:
Try to add a template with an empty string as name.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:32:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:32:06 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-u8u93ssJyf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22284|0                           |1
        is obsolete|                            |

--- Comment #187 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22398&action=edit
Bug 8015: Add user permissions to all languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:32:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:32:21 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-XKE8ENHTaL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22285|0                           |1
        is obsolete|                            |

--- Comment #188 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22399&action=edit
Bug 8015: Remove references to C4::Koha::Log

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:32:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:32:37 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-Xpq1wtsHNb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22290|0                           |1
        is obsolete|                            |

--- Comment #189 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22400&action=edit
Bug 8015: QA Followup

* Add bug number to database update
* Fix capitalization errors
* Fix JavaScript string translation errors

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:32:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:32:52 +0000
Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates
In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8015-70-YaUrWYDoUB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22293|0                           |1
        is obsolete|                            |

--- Comment #190 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22401&action=edit
Bug 8015: QA Followup 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:41:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:41:21 +0000
Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
In-Reply-To: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10781-70-YjAzlwWnJT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:41:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:41:30 +0000
Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility
In-Reply-To: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10781-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10781-70-aPhbuI5hqs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21688|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22402&action=edit
bug_10781: Removed ILSDI::Utility

Test:
This should be a noop. Regression testing required:
/cgi-bin/koha/ilsdi.pl functioanality, in particuler:
GetAvailability - ?service=Describe&verb=GetAvailability
AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron

ILS-DI syspref must be turned on

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:48:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:48:04 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-WNDt2Qqz0P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:48:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:48:11 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-SPJ090CDbZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22327|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22403
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22403&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:58:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:58:37 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-ATXAq06g3i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21990|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22404&action=edit
Bug 11051 - remove caching of GetMarcStructure

Profiling suggests that this is actually ~1s slower with caching
enabled, probably due to serialisation overheads.

Compare uncached:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78

to cached:
http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78

Test plan (please do this, more data points are good):
* set up an instance with memcache available but not used
* run the profiler on it
* enable the use of memcache
* run the profiler on it, note that the caching is being used and the
  code runs slower.
* apply the patch
* run the profiler again with memcache, note that the caching is not being used
and
  things are back to being speedy.

A quick primer to using the profiler:
* apt-get install libdevel-nytprof-perl
* sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211
MEMCACHED_NAMESPACE=library-koha-opac
KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib
SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
'q=a'
* this will create nytprof.out in the current dir (use /tmp)
* run nytprofhtml to produce HTML output.
* remove/include the MEMCACHED variables to turn caching on/off
  globally.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl and all unit tests. No errors detected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:58:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:58:54 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-OE7uwjZKcU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21989|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22405&action=edit
Bug 11051 - remove unneccessary SQL queries in GetBranches

The way GetBranches was written, it will issue one query to get all
branches, and then one query per branch for the branch relations.
This patch pre-fetches the relations table (as we need it all anyway)
and so makes the whole process happen in two queries, rather than take
1+N, where N is the number of branches.

This might not seem like much, but when you do a search, GetBranches is
called once for each result, so 25. And you might have 10 branches. This
causes 275 database requests when you could get away with 50.

>From profiling, when you run a search, this is the thing that calls
DBI::st::execute the most. Refer:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-Branch-pm-146-line.html#125

Test Plan:
* Have a database with branches and relationships between the branches.
  (these are 'Lubrary groups' in the UI.
* Make sure the relationships show up correctly after applying the
  patch.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:59:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:59:06 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-upCE5CMSn1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22404|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22406&action=edit
Bug 11051 - remove caching of GetMarcStructure

Profiling suggests that this is actually ~1s slower with caching
enabled, probably due to serialisation overheads.

Compare uncached:
http://debian.koha-community.org/~robin/opac-search/usr-share-koha-lib-C4-XSLT-pm-1282-line.html#78

to cached:
http://debian.koha-community.org/~robin/opac-search-cached/nytprof/usr-share-koha-lib-C4-XSLT-pm-1320-line.html#78

Test plan (please do this, more data points are good):
* set up an instance with memcache available but not used
* run the profiler on it
* enable the use of memcache
* run the profiler on it, note that the caching is being used and the
  code runs slower.
* apply the patch
* run the profiler again with memcache, note that the caching is not being used
and
  things are back to being speedy.

A quick primer to using the profiler:
* apt-get install libdevel-nytprof-perl
* sudo -u library-koha env MEMCACHED_SERVERS=localhost:11211
MEMCACHED_NAMESPACE=library-koha-opac
KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/usr/share/koha/lib
SERVER_PORT=80 perl -d:NYTProf /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
'q=a'
* this will create nytprof.out in the current dir (use /tmp)
* run nytprofhtml to produce HTML output.
* remove/include the MEMCACHED variables to turn caching on/off
  globally.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Passes koha-qa.pl and all unit tests. No errors detected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 15:59:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 13:59:24 +0000
Subject: [Koha-bugs] [Bug 11051] Performance of opac-search
In-Reply-To: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11051-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11051-70-LpuBVD4fQM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11051

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:04:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:04:12 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-LQ94Xt7mD9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21431|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22407&action=edit
Bug 10944 - Mixed content warnings in opac results and detail with Amazon
images on https

It's probably going to become more popular to run Koha in SSL environments.
Currently on ssl, with Amazon images enabled, a SSL enabled site will either
not show Amazon images (IE, some versions of Firefox?), or show a warning to
users about mixed secure and insecure content (Firefox, Chrome).

Since we now have the using_https template variable, it makes sense to use it.

To test:

In each browser you have access to, and preferably with SSL set up
(you can set up a self signed cert for your dev install by following, more or
less, the instructions here: https://wiki.debian.org/Self-Signed_Certificate)

For the apache config, just copy the one for the OPAC, but set it to use 443
instead of 80 for the port, and point it to your keys per the instructions
above.

** note that using a self signed cert on your dev install will prompt you when
you connect the first time
that OMG I CAN'T VERIFY THIS IS COOL. You did it yourself, if you can't trust
yourself... then who can you trust?

* Enable Amazon images in the system preferences
* Do a search that you know will have images for, verify that without SSL
1. the images show
2. the image source is from an Amazon url that uses http://
3. the images are the right size, and look ok
* Do the same using https, verify that with SSL
1. the images show
2. the image source is from an Amazon url that uses https://
3. the images are the right size, and look ok

Clicking on the image should link to the item on Amazon. This patch also
corrects a problem with the Amazon url used on the images -
it was pointing to a feature that is currently unavailable. That's fixed here.
All you need to check is that it goes to a valid Amazon endpoint that doesn't
show an error.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:04:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:04:13 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-1l5MHVtFag@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:04:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:04:27 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-Kid6s7X9Yg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22403|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:04:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:04:33 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-Xgn7PEZRyv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22408&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

 To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

Signed-off-by: Koha team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:04:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:04:34 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-mh4R4tC9XT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21886|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22409&action=edit
Bug 10944 - Mixed content warnings for covers on staff client

This switches the URLs used to access Amazon's cover images to the SSL image
server, preventing warnings when using this on a secure site.

To test:
* Enable Amazon images in the sysprefs, all other cover images off.
* Do a search in the staff client. Using firebug or similar, inspect the
  images that indicate both "no image found" and the covers.
* Are they all https, and showing correctly?

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:04:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:04:46 +0000
Subject: [Koha-bugs] [Bug 10944] Mixed content warnings in results and
 detail with Amazon images on https
In-Reply-To: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10944-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10944-70-6Xx7nmnYgI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10944

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:05:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:05:13 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-TKABHxeJ8O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #5 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Koha team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:05:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:05:25 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-z99y9aYw6C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22408|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:05:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:05:31 +0000
Subject: [Koha-bugs] [Bug 11125] Remove Problematic Logic from Patron
 Messaging Preferences Form
In-Reply-To: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11125-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11125-70-LS2w4HwMCz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11125

--- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22410
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22410&action=edit
Bug 11125 : Correct display for patron messaging preferences on OPAC

 To test :
 1) Remove 'sms' from message_transport_types table
 2) Go on OPAC "My messaging" tab => table columns are out of alignment with
table heading
 3) Apply patch => table is correctly displaid

Signed-off-by: Koha team AMU <koha.aixmarseille at gmail.com>

Signed-off-by: Koha team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:30:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:30:48 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-orke9uJhcq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Looks like the table borrower_password_recovery was left out of the database
update by accident.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:39:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:39:41 +0000
Subject: [Koha-bugs] [Bug 11140] New: Centralize all sending of email to one
	subroutine
Message-ID: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140

            Bug ID: 11140
           Summary: Centralize all sending of email to one subroutine
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

To reduce the chances of introducing bugs related to sending emails, and to
follow the DRY principle, we should consolidate all calls to sendmail into a
single subroutine such that any system preferences or other logic that alters
how we send emails can be centralized.

For example, bug 8000 and bug 8753, if both pushed, would introduce a bug into
Koha if nobody noticed, since there would be no merge conflicts or unit test
failures.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:40:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:40:54 +0000
Subject: [Koha-bugs] [Bug 11140] Centralize all sending of email to one
	subroutine
In-Reply-To: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11140-70-vaScnt6Bq6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8000

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:40:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:40:54 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8000-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8000-70-oNAx1lzO0O@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
         Depends on|                            |11140

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Blou from comment #8)
> I'd go one step further: All emailing should go through one and only one
> Koha method.
> It's good practice to have system calls isolated so that when upgrade or a
> new platform require adjustment, we don't need to run around touching 10
> files.
> Or when we simply want to improve the process with validation...
> 
> I'd be happy to do that... on a different bug :)

I completely agree, to the point that I think we whould *require* the
centralization of this code, and this patch depend on said centralization.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:41:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:41:09 +0000
Subject: [Koha-bugs] [Bug 11141] New: Filters are not kept on receiving
Message-ID: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

            Bug ID: 11141
           Summary: Filters are not kept on receiving
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

On receiving orders, the librarian has to filter again the pending orders list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:41:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:41:41 +0000
Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving
In-Reply-To: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11141-70-n7dMTRTo0I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:43:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:43:36 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-GjdRm6I964@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22411&action=edit
Bug 11133 - Markup errors in OPAC place hold form HTML

There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:43:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:43:34 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-rtDUGHlOkh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:43:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:43:39 +0000
Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from
	advanced search
In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10937-70-nJnCZdI6RY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Applying: Sponsor: Vanier college
/home/koha/kohaclone/.git/rebase-apply/patch:24: tab in indent.
            LEFT JOIN authorised_values ON searchcategory = authorised_value
WHERE searchcategory > ''
/home/koha/kohaclone/.git/rebase-apply/patch:62: tab in indent.
        quantity SMALLINT(6) default NULL, -- suggested quantity to be
purchased
/home/koha/kohaclone/.git/rebase-apply/patch:63: tab in indent.
        currency VARCHAR(3) default NULL, -- suggested currency for the
suggested price
/home/koha/kohaclone/.git/rebase-apply/patch:64: tab in indent.
        price DECIMAL(28,6) default NULL, -- suggested price
/home/koha/kohaclone/.git/rebase-apply/patch:65: tab in indent.
        total DECIMAL(28,6) default NULL, -- suggested total cost
(price*quantity updated for currency)
fatal: sha1 information is lacking or useless (C4/Koha.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Sponsor: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:44:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:44:37 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-yb3Fo80XCM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
I should specify: This patch is for the prog template. A separate bug will
address the bootstrap template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:46:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:46:26 +0000
Subject: [Koha-bugs] [Bug 11142] New: Update Bootstrap theme's place hold
 form to match the new version in prog
Message-ID: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

            Bug ID: 11142
           Summary: Update Bootstrap theme's place hold form to match the
                    new version in prog
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

A change was recently made to the place hold form in the prog theme. This
change needs to be made to the Bootstrap theme as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:48:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:48:06 +0000
Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving
In-Reply-To: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11141-70-tl6xuoy5uQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 16:48:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 14:48:11 +0000
Subject: [Koha-bugs] [Bug 11141] Filters are not kept on receiving
In-Reply-To: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11141-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11141-70-iIzDXXpaF4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11141

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22412
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22412&action=edit
Bug 11141: Filters are not kept on receiving.

On receiving orders, the librarian has to filter again the pending
orders list.

This patch stores the filters in a cookie in order to apply them when
the librarian finish a receive and come back on the pending orders list.

Test plan:
1/ choose a vendor with several baskets and orders.
2/ start to receive an item.
3/ on the pending orders page, add some relevant filters.
4/ receive an item.
5/ you are back on the pending orders page and filters are directly
applied.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:11:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:11:34 +0000
Subject: [Koha-bugs] [Bug 11143] New: Upload Patron Image only loads some
	images
Message-ID: <bug-11143-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11143

            Bug ID: 11143
           Summary: Upload Patron Image only loads some images
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Tools
          Assignee: gmcharlt at gmail.com
          Reporter: drnoe at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22413
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22413&action=edit
grep picture-upload.pl

The Upload Patron Image tool does not work with batches as intended.  Some
load. Some do not load. There is no indication of what makes one image load and
another not load. 

The file, DATALINK.TXT, matches the user id to the image name correctly, but
only some of the images in the compressed folder load.   

Error log attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:23:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:23:03 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-bWWw7n6UUO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #43 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22414
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22414&action=edit
Bug 10671: Update Reports Help

Update all of the reports related help files.

To test:

* Visit report pages and confirm that text and links
are right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:25:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:25:51 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-xHyLfi4TSf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #44 from Nicole C. Engard <nengard at gmail.com> ---
Changing back to needs signoff for the new patches - but note that most of
these are signed off and ready for qa

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:27:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:27:09 +0000
Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being
	scanned twice
In-Reply-To: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8004-70-NTdDx7CtWI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20682|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:27:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:27:12 +0000
Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being
	scanned twice
In-Reply-To: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8004-70-MwYzFDxN2I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20582|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:27:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:27:46 +0000
Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being
	scanned twice
In-Reply-To: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8004-70-Nj28N55nzd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Initial patch was pushed to master. These followups are covered by bug 10626,
and thus are not needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:39:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:39:07 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-i62tqgBS7Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21952|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22415
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22415&action=edit
Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

To old plugin prevents the upgrade to the latest jquery.  By replacing with
openjs' shortcut.js, we have now one less hurdle in upgrading Koha to latest.

Changes:
- removed jquery.hotkeys.min.js
- added shortcut.js
- modified the related includes (doc-head-close.inc and help-top.inc)
- modified the calls in staff-global.js

Regression test:
1) apply the patch
2) in the intranet, test the shortcuts alt-q, alt-r, alt-u.

These are the only affected functionalities.  There is no new functionnality.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:39:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:39:15 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-U5EdLw0U62@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22311|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22416
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22416&action=edit
Bug 11035 - Replace shortcut plugin jquery.hotkeys.min.js

Seems a new file circ/offline-mf.tt got added with hotkeys.js.  I replaced it
but I couldn't find ANY usage of it to fix.

Rebased and fixed.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:39:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:39:30 +0000
Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin
	jquery.hotkeys.min.js
In-Reply-To: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11035-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11035-70-gMlBbR81kZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:45:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:45:34 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-NkSG7QtGXp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
I think this patch has the potential to cause a bit of confusion. The holds to
pull table has a branch filter already, and this adds a second branch filter. I
think it would be better to utilize the existing branch filter. You will need
to trigger it via javascript, either during the generation of the datatable if
possible, or after the datatable has been created if not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 17:50:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 15:50:57 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-ofEiJXBZXf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |kyle at bywatersolutions.com

--- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> ---
Would it be possibly better to solve this using bug 8015 as a basis? It's a
more extensible/flexible system and we could easily modify bulkmarcimport.pl to
allow the use of modification templates. I know it means tossing this existing
work, but I'd say it's usually better to have less code than more code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:00:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:00:47 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-OQZfUiUrwB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
perl t/db_dependent/Circulation/CanItemBeTransferred.t
1..20
Running tests for ccode
ok 1 - Successful branch transfer, full parameters
not ok 2 - Failing branch transfer, full parameters
#   Failed test 'Failing branch transfer, full parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 25.
#          got: '1'
#     expected: 'CPL->IPT->FANTASY'
ok 3 - Successful branch transfer, full parameters, no Biblio defined
not ok 4 - Failing branch transfer, full parameters, no Biblio defined
#   Failed test 'Failing branch transfer, full parameters, no Biblio defined'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 31.
#          got: '1'
#     expected: 'CPL->IPT->FANTASY'
ok 5 - Successful branch transfer, using defaults for $fromBranch
not ok 6 - Failing branch transfer, using defaults for $fromBranch
#   Failed test 'Failing branch transfer, using defaults for $fromBranch'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 37.
#          got: '1'
#     expected: 'CPL->IPT->FANTASY'
ok 7 - Successful branch transfer, using minimum parameters
not ok 8 - Failing branch transfer, using minimum parameters
#   Failed test 'Failing branch transfer, using minimum parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 43.
#          got: '1'
#     expected: 'CPL->IPT->FANTASY'
ok 9 - Successful branch transfer, using minimum parameters
ok 10 - Not failing branch transfer, because CCODE cannot be found from the
item and it is not a part of the biblio.
Running tests for itemtype
ok 11 - Successful branch transfer, full parameters
not ok 12 - Failing branch transfer, full parameters
#   Failed test 'Failing branch transfer, full parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 63.
#          got: '1'
#     expected: 'CPL->IPT->BK'
ok 13 - Successful branch transfer, full parameters, no Biblio defined
not ok 14 - Failing branch transfer, full parameters, no Biblio defined
#   Failed test 'Failing branch transfer, full parameters, no Biblio defined'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 69.
#          got: '1'
#     expected: 'CPL->IPT->BK'
ok 15 - Successful branch transfer, using defaults for $fromBranch
not ok 16 - Failing branch transfer, using defaults for $fromBranch
#   Failed test 'Failing branch transfer, using defaults for $fromBranch'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 75.
#          got: '1'
#     expected: 'CPL->IPT->BK'
ok 17 - Successful branch transfer, using minimum parameters
not ok 18 - Failing branch transfer, using minimum parameters
#   Failed test 'Failing branch transfer, using minimum parameters'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 81.
#          got: '1'
#     expected: 'CPL->IPT->BK'
ok 19 - Successful branch transfer, using minimum parameters, itemtype is
pulled from Biblio
not ok 20 - Failing branch transfer, using minimum parameters, itemtype is
pulled from Biblio
#   Failed test 'Failing branch transfer, using minimum parameters, itemtype is
pulled from Biblio'
#   at t/db_dependent/Circulation/CanItemBeTransferred.t line 87.
#          got: '1'
#     expected: 'CPL->IPT->BK'
# Looks like you failed 9 tests of 20.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:07:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:07:35 +0000
Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has
	awkward wording
In-Reply-To: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10776-70-VIcMo0SQFB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:07:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:07:37 +0000
Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has
	awkward wording
In-Reply-To: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10776-70-GeQIOI2DH8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20545|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22417
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22417&action=edit
Bug 10776 - subscription notification screen has awkward wording

to test:
- make a subscription available to be notified about
- log into the opac, click the subscriptions tab, then More details
- click "Subscribe to email notification on new issues"
- observe the text without the patch - there seems to be an extra "arrive?"
- apply the patch, refresh - wording should flow a bit better.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:09:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:09:41 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-4t8meoy0FE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:09:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:09:44 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-cn9QGuAvW8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22411|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22418
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22418&action=edit
Bug 11133 - Markup errors in OPAC place hold form HTML

There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:21:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:21:49 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-AaV6MGv0ly@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:21:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:21:51 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-Gl2fQq0tXY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22195|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22419&action=edit
Bug 2310 - Delete grayed out w/out explanation

With some staff client menus options are displayed as disabled when the
logged in user doesn't have permission to perform that function. This
patch adds Bootstrap tooltips to patron menu items with text explaining
why they are disabled.

To test, log in as a user who lacks permission to modify patrons or set
permissions. Open a patron record in circulation or patrons. Hovering
over renew, delete, and set permissions links (in the patron toolbar
"More" menu) should trigger a tooltip with a brief explanation.

Test the "Update child to adult patron" link by viewing an adult patron.

A separate patch will address catalog menu items.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Great design!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:27:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:27:23 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-erXsUxw1Zu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22372|0                           |1
        is obsolete|                            |

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22420&action=edit
Bug 10671: Update Circ Help Files

This patch updates the existing help files and
adds the missing offline circ help file.

To test:

* Visit all circ pages and check the manual links
* Visit the new offline circulation page and confirm text
and link are there (link will work after 10/25)

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:27:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:27:28 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-fWwMzpNiZB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22374|0                           |1
        is obsolete|                            |

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22421&action=edit
Bug 10671: Update Offline Circ Help

This patch updates the offline circulation help files.

To test:

Visit the KOC file upload and pending transactions page
Review the help and check the links

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:27:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:27:34 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-Gef6SMNT9Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22375|0                           |1
        is obsolete|                            |

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22422&action=edit
Bug 10671: Remove Unused Help File

This patch removes an unused help file in the help/export
folder.

To test:

Just confirm that the file is removed, there were no links
to it anymore.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:27:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:27:39 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-wrsKoFXNNu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22376|0                           |1
        is obsolete|                            |

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22423&action=edit
Bug 10671: Update Reviews Help

This patch updates the link to the manual in the comments
moderation help.

To test:

* Visit comments moderation
* Click the help link
* Confirm manual link works

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:27:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:27:46 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-yvaEd7guGv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22377|0                           |1
        is obsolete|                            |

--- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22424&action=edit
Bug 10671: Update holds help

This patch updates the manual link in the holds help
file.

To test:

* Place a hold in the staff client
* Click the help link
* Confirm manual link works

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:27:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:27:52 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-4WqM6VptM8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22414|0                           |1
        is obsolete|                            |

--- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22425&action=edit
Bug 10671: Update Reports Help

Update all of the reports related help files.

To test:

* Visit report pages and confirm that text and links
are right.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:28:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:28:09 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-SMTk48QoXS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:29:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:29:59 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-6Wg8LQDonC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
perl t/db_dependent/GetHiddenItems_PatronCategory.t
1..22
ok 1 - use C4::Items;
ok 2 - LIB1 Item linked to correct biblionumber.
ok 3 - LIB1 Item linked to correct biblioitemnumber.
ok 4 - LIB2 Item linked to correct biblionumber.
ok 5 - LIB2 Item linked to correct biblioitemnumber.
$VAR1 = {
          'firstname' => 'Sample',
          'userid' => 'Sample.Borrower',
          'categorycode' => 'PT',
          'phone' => '967-1111',
          'zipcode' => 'H0H 0H0',
          'surname' => 'Borrower',
          'email' => 'santa at northpole.com',
          'city' => 'Bogusville',
          'address' => '123 Bogus Street',
          'branchcode' => 'LIB1'
        };

# Sample Borrower added.
CHECK: 54
xJZNdcnysc
# 116 - LIB1
# 117 - LIB2
ok 6 - OpacHiddenItems hid everything correctly.
# 116,117
# Borrower number: 54
# Sample Borrower environment variables set up.
not ok 7 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 125.
#          got: 2
#     expected: 0
# PatronSingleBranch: SPT
# PatronEveryBranch: SPT
# 116,117
not ok 8 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 133.
#          got: 2
#     expected: 1
# PatronSingleBranch: SPT
# PatronEveryBranch: SS
# 116,117
not ok 9 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 141.
#          got: 2
#     expected: 1
# PatronSingleBranch: SPT
# PatronEveryBranch: ''
# 116,117
not ok 10 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 149.
#          got: 2
#     expected: 0
# PatronSingleBranch: SPT
# PatronEveryBranch: SS|SPT
# 116,117
not ok 11 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 157.
#          got: 2
#     expected: 0
# PatronSingleBranch: SS
# PatronEveryBranch: SPT
# 116,117
ok 12 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS
# 116,117
ok 13 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: ''
# 116,117
not ok 14 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 181.
#          got: 2
#     expected: 0
# PatronSingleBranch: SS
# PatronEveryBranch: SS|SPT
# 116,117
not ok 15 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 189.
#          got: 2
#     expected: 0
# PatronSingleBranch: ''
# PatronEveryBranch: SPT
# 116,117
ok 16 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS
# 116,117
ok 17 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: ''
# 116,117
not ok 18 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 213.
#          got: 2
#     expected: 0
# PatronSingleBranch: ''
# PatronEveryBranch: SS|SPT
# 116,117
not ok 19 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 221.
#          got: 2
#     expected: 0
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SPT
# 116,117
not ok 20 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 229.
#          got: 2
#     expected: 1
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS
# 116,117
not ok 21 - OpacHiddenItems hid LIB2 correctly.
#   Failed test 'OpacHiddenItems hid LIB2 correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 237.
#          got: 2
#     expected: 1
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: ''
# 116,117
not ok 22 - OpacHiddenItems unhid everything correctly.
#   Failed test 'OpacHiddenItems unhid everything correctly.'
#   at t/db_dependent/GetHiddenItems_PatronCategory.t line 245.
#          got: 2
#     expected: 0
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS|SPT
# 116,117
# Looks like you failed 12 tests of 22.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:42:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:42:28 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-tsvMjbotJz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:42:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:42:31 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-bAAxv1zlV8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22378|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22426&action=edit
Bug 11136 - action_logs should be a MyISAM table, not InnoDB

The table action_logs is written too at a higher rate than practically
any other table. Additionally, action_logs has no foreign key
constraints. It seems that this would be a somewhat unique situation
where using MyISAM would provide quite a performance boost for large
sites with many transactions that use the Action Logs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:45:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:45:25 +0000
Subject: [Koha-bugs] [Bug 11136] action_logs should be a MyISAM table,
	not InnoDB
In-Reply-To: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11136-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11136-70-KVcjYuit4v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11136

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---

> 1) In fact it is an DB update, so the patch needs to change also 
>  installer/data/mysql/kohastructure.sql

Yep, I just thought of that too!

> 2)Are we sure that is a good idea to use two different engine of MySQL at
> same time in Koha ?
> Reading those two pagees we can think that mixing InnoDB and MySQL needs a
> quite tuning to be useful:

We already have MyISAM tables, so there is already precedent for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:46:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:46:51 +0000
Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when
 exporting batch label to PDF
In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8375-70-Nz4tXN0Mig@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375

--- Comment #39 from Paul Poulain <paul.poulain at biblibre.com> ---
Kyle, could you confirm that/if the problem exist BEFORE the path please ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:54:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:54:24 +0000
Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays
In-Reply-To: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11112-70-n9SH1U5Guc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:54:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:54:27 +0000
Subject: [Koha-bugs] [Bug 11112] Koha::Calendar->new loads all holidays
In-Reply-To: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11112-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11112-70-PVQ9b04WVQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11112

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22267|0                           |1
        is obsolete|                            |

--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22427&action=edit
Bug 11112: Koha::Calendar needs some caching

holidays is built each time a Koha::Calendar object is created.

The Koha::Calendar's builder retrieves all holidays from the database
and create a DateTime::Set object with all holidays.

In one of our customer's DB, there are 11085 special_holidays and 598
repeatable_holidays.
On a return, there are 3 calls to Koha::Calendar->new.

Nytprof benchmarks (on a 3.8.x branch):
In DateTime::Set->from_datetimes:
3 times (5.49ms+4.90s) by Koha::Calendar::_init at line 80 of Koha/Calendar.pm,
avg 1.63s/call
on a total of 7.67s (of 10.2s), executing 6353333 statements and 3031273
subroutine calls in 147 source files and 36 string evals.
for the circulation/return.pl page.

Comparing the access_log:

Without the patch:
checkout: time=2759838
checkin: time=1832751

Without the patch and with overdues:
checkout: time=1086727 + time=1144706
checkin: time=3928854 (x2)

With the patch and overdues:
checkout: time=1077839 + time=1060886
checkin: time=2420898

Test plan:
- checkout an item with a return date < today
- checkin the item and verify the suspension period is well calculated
  (depending on the holidays).
- prove t/db_dependent/Holidays.t
- t/Calendar.t

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:59:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:59:44 +0000
Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form
	in OPAC
In-Reply-To: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10750-70-5bIDeGOdbZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22161|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22428&action=edit
Bug 10750: Correct capitalization on suggestion form in OPAC

Create a new suggestion from your patron account in the OPAC.
Verify that all strings are correctly capitalized on the form
and submit buttons.

- Copyright date
- Standard number ... and other
- Submit your suggestion

Signed-off-by: Dani Elder <dani at bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 18:59:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 16:59:41 +0000
Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form
	in OPAC
In-Reply-To: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10750-70-6xnhbSBchf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 19:03:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 17:03:14 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-cBolbl6wI7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 19:03:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 17:03:17 +0000
Subject: [Koha-bugs] [Bug 3934] move test prediction pattern button
In-Reply-To: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3934-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3934-70-3iBCLTD0lH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3934

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22429&action=edit
Bug 3934 - move test prediction pattern button

On the subscription add/edit screen the buttons related to numbering
patterns are grouped with the "save" button, which is potentially
confusing. This patch moves the buttons into the "serials planning"
region so they are visually grouped with related functionality.

Unrelated changes: Removed a few redundant "javascript:"
pseudo-protocols from event handlers, and added a "Cancel" link.

To test, edit an existing subscription and confirm that the prediction
pattern buttons are grouped inside the "serials planning" region.
Confirm that each button triggers the correct event. Confirm that
clicking the "cancel" link returns you to the subscription detail view.

Also test creating a new subscription. Again buttons should work
correctly. The "Cancel" link should return you to the Serials module
home page.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 19:43:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 17:43:14 +0000
Subject: [Koha-bugs] [Bug 10735] koha-dump not working
In-Reply-To: <bug-10735-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10735-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10735-70-Ax3YnbwljC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10735

Fabio Tiana <fabio.tian at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabio.tian at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 20:23:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 18:23:24 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-xIyFb04I5r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #19 from Blou <philippe.blouin at inlibro.com> ---
Created attachment 22430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22430&action=edit
Bug 8753 - Add forgot password link to OPAC

Added the missing updatedatabase.pl script to add the table
borrower_password_recovery and the preference OpacResetPassword.
Modified kohastructure.sql to use InnoDB

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 20:25:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 18:25:28 +0000
Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC
In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8753-70-n0bOO8UvWC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #20 from Blou <philippe.blouin at inlibro.com> ---
Well, seems I'm fully forgot updatedatabase.pl in first patch.
Rebased and fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 20:50:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 18:50:18 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-CZgTFsOmVc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
This is because you failed to apply bug 10900 first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 20:50:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 18:50:33 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-Gbs2JugDjO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 20:50:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 18:50:36 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-JmfKD4VecD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22362|0                           |1
        is obsolete|                            |

--- Comment #2 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22431&action=edit
Bug 11132: The results list is reset on adding a biblio to a list

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 20:51:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 18:51:47 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-9NoWIJuEtE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
The test plan is in comment #10.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 21:05:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 19:05:45 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-vz6GCVkASa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |kyle at bywatersolutions.com

--- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> ---
Looks like this patch is causing Circulation_barcodedecode.t to fails some
tests. All the unit tests pass on master.

perl t/Circulation_barcodedecode.t
1..26
ok 1 - use C4::Circulation;
ok 2 -        EAN13:       '892685001928' => '0892685001928'
ok 3 -        EAN13:             '695152' => '0000000695152'
ok 4 -     T-prefix:           'T0031472' =>      'T0031472'
ok 5 -     T-prefix:                'T32' =>      'T0000002'
ok 6 -       cuecat:           '26002315' =>      '26002315'
ok 7 -       cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.' => 
'046675000808'
ok 8 -       cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.
# ' =>  '046675000808'
ok 9 -       cuecat: 'q.C3nZC3nZC3nWDNzYDxf2CNnY.fHmc.C3DWC3nZCNjXD3nW.' => 
'043000112403'
ok 10 -       cuecat:
'.C3nZC3nZC3nWCxjWE3D1C3nX.cGf2.ENr7C3v7D3T3ENj3C3zYDNnZ.' =>
'978068484914051500'
not ok 11 -    libsuite8:            'b000126' =>     'IMS-b-126'
#   Failed test '   libsuite8:            'b000126' =>     'IMS-b-126''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-b-126'
not ok 12 -    libsuite8:                'b12' =>      'IMS-b-12'
#   Failed test '   libsuite8:                'b12' =>      'IMS-b-12''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-b-12'
not ok 13 -    libsuite8:              'B0126' =>     'IMS-B-126'
#   Failed test '   libsuite8:              'B0126' =>     'IMS-B-126''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-B-126'
not ok 14 -    libsuite8:          'IMS-B-126' =>     'IMS-B-126'
#   Failed test '   libsuite8:          'IMS-B-126' =>     'IMS-B-126''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-IMS-B--126'
not ok 15 -    libsuite8:          'ims-b-126' =>     'ims-b-126'
#   Failed test '   libsuite8:          'ims-b-126' =>     'ims-b-126''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-ims-b--126'
not ok 16 -    libsuite8:          'CD0000024' =>     'IMS-CD-24'
#   Failed test '   libsuite8:          'CD0000024' =>     'IMS-CD-24''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-CD-24'
not ok 17 -    libsuite8:              '00123' =>     'IMS-b-123'
#   Failed test '   libsuite8:              '00123' =>     'IMS-b-123''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-b-123'
not ok 18 -    libsuite8:              '11998' =>   'IMS-b-11998'
#   Failed test '   libsuite8:              '11998' =>   'IMS-b-11998''
#   at t/Circulation_barcodedecode.t line 38.
# Bad output: 'kale-b-11998'
ok 19 -        other:           '26002315' =>      '26002315'
ok 20 -        other:           'T0031472' =>      'T0031472'
ok 21 -        other:                'T32' =>           'T32'
ok 22 -        other:        'Alphanum123' =>   'Alphanum123'
ok 23 -        other:      'Alpha Num 345' => 'Alpha Num 345'
ok 24 -   whitespace:          ' 26002315' =>      '26002315'
ok 25 -   whitespace:          '26002315 ' =>      '26002315'
ok 26 -   whitespace:        '
#       26002315
# ' =>      '26002315'
# Looks like you failed 8 tests of 26.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Oct 25 21:48:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 25 Oct 2013 19:48:14 +0000
Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and
 resumed from the OPAC
In-Reply-To: <bug-10774-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10774-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10774-70-BCwOveKxqI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774

Chris Rohde <crohde at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #8 from Chris Rohde <crohde at roseville.ca.us> ---
Patch tested per test plan, and functions as expected.  I Chris Rohde, signoff
on this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 26 04:02:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Oct 2013 02:02:30 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-31QG1RGKVL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #20 from M. Tompsett <mtompset at hotmail.com> ---
After reading your post, Kyle, I did a fresh git install on a fresh OS clone. I
could not replicate your failure.

mtompset at ubuntu:~/kohaclone$ git checkout -b bug_10900 origin/master
Branch bug_10900 set up to track remote branch master from origin.
Switched to a new branch 'bug_10900'
mtompset at ubuntu:~/kohaclone$ git diff origin/master
mtompset at ubuntu:~/kohaclone$ git bz apply 10900
Bug 10900 - Incorrect calling conventions accessing C4::Context

Bug 10900 - Incorrect calling conventions accessing C4::Context
Apply? [yn] y

Applying: Bug 10900 - Incorrect calling conventions accessing C4::Context
mtompset at ubuntu:~/kohaclone$ prove -v t/Circulation_barcodedecode.t
t/Circulation_barcodedecode.t ..
1..26
ok 1 - use C4::Circulation;
ok 2 -        EAN13:       '892685001928' => '0892685001928'
ok 3 -        EAN13:             '695152' => '0000000695152'
ok 4 -     T-prefix:           'T0031472' =>      'T0031472'
ok 5 -     T-prefix:                'T32' =>      'T0000002'
ok 6 -       cuecat:           '26002315' =>      '26002315'
ok 7 -       cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.' => 
'046675000808'
ok 8 -       cuecat: '.C3nZC3nZC3nYD3b6ENnZCNnY.fHmc.C3D1Dxr2C3nZE3n7.
# ' =>  '046675000808'
ok 9 -       cuecat: 'q.C3nZC3nZC3nWDNzYDxf2CNnY.fHmc.C3DWC3nZCNjXD3nW.' => 
'043000112403'
ok 10 -       cuecat:
'.C3nZC3nZC3nWCxjWE3D1C3nX.cGf2.ENr7C3v7D3T3ENj3C3zYDNnZ.' =>
'978068484914051500'
ok 11 -    libsuite8:            'b000126' =>     'IMS-b-126'
ok 12 -    libsuite8:                'b12' =>      'IMS-b-12'
ok 13 -    libsuite8:              'B0126' =>     'IMS-B-126'
ok 14 -    libsuite8:          'IMS-B-126' =>     'IMS-B-126'
ok 15 -    libsuite8:          'ims-b-126' =>     'ims-b-126'
ok 16 -    libsuite8:          'CD0000024' =>     'IMS-CD-24'
ok 17 -    libsuite8:              '00123' =>     'IMS-b-123'
ok 18 -    libsuite8:              '11998' =>   'IMS-b-11998'
ok 19 -        other:           '26002315' =>      '26002315'
ok 20 -        other:           'T0031472' =>      'T0031472'
ok 21 -        other:                'T32' =>           'T32'
ok 22 -        other:        'Alphanum123' =>   'Alphanum123'
ok 23 -        other:      'Alpha Num 345' => 'Alpha Num 345'
ok 24 -   whitespace:          ' 26002315' =>      '26002315'
ok 25 -   whitespace:          '26002315 ' =>      '26002315'
ok 26 -   whitespace:        '
#       26002315
# ' =>      '26002315'
ok
All tests successful.
Files=1, Tests=26,  0 wallclock secs ( 0.01 usr  0.01 sys +  0.30 cusr  0.02
csys =  0.34 CPU)
Result: PASS

So, I looked at your bad output line:
# Bad output: 'kale-b-126'

'kale' is the last name in the set_userenv call.
The line that changed in the test file is:
C4::Context->set_userenv(1,'kmkale' , 1, 'km', 'kale' , 'IMS', 'IMS Branch
DEscription', 0, 'kmkale at anantcorp.com');

This would be affected if the set_userenv function in C4::Context is missing
shift @_; or the call is :: in the test file.

>From C4::Context:
    shift @_;
    my ($usernum, $userid, $usercnum, $userfirstname, $usersurname,
$userbranch, $branchname, $userflags, $emailaddress, $branchprinter, $persona)=
@_;

The -> passes an object, which is shifted off, and
$usernum=1,$userid='kmkale',$usercnum=1,$userfirstname='km',$usersurname='kale',$userbranch='IMS'

The barcodedecode function uses the userbranch. So, if there is a missing shift
@_ and the Circulationbarcode.t file has ->set_userenv(...) as above, then that
$userbranch would be 'kale', which matches your failed output. The 'kale-'
portion is based on the branchcode.

>From C4/Circulation.pm
sub barcodedecode {
    my ($barcode, $filter) = @_;
    my $branch = C4::Branch::mybranch();
...
        } elsif ($filter eq 'libsuite8') {
                unless($barcode =~ m/^($branch)-/i){    #if barcode starts with
branch code its in Koha style. Skip it.
                        if($barcode =~ m/^(\d)/i){      #Some barcodes even
start with 0's & numbers and are assumed to have b as the item type in the
libsuite8 software
                                $barcode =~ s/^[0]*(\d+)$/$branch-b-$1/i;
                        }else{
                                $barcode =~ s/^(\D+)[0]*(\d+)$/$branch-$1-$2/i;
                        }
                }

>From C4/Branch.pm
# always returns a string for OK comparison via "eq" or "ne"
sub mybranch {
    C4::Context->userenv           or return '';
    return C4::Context->userenv->{branch} || '';
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 26 04:58:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Oct 2013 02:58:23 +0000
Subject: [Koha-bugs] [Bug 7942] Allow modification of basket group pdf
	template
In-Reply-To: <bug-7942-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7942-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7942-70-e78kYogWCR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7942

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 26 05:15:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Oct 2013 03:15:23 +0000
Subject: [Koha-bugs] [Bug 10746] Improving PDF printing of baskets - Omnibus
In-Reply-To: <bug-10746-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10746-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10746-70-VA4nVOtPHS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10746

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 26 06:13:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Oct 2013 04:13:28 +0000
Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible
In-Reply-To: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11066-70-SMJy8hwbmH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 26 06:13:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Oct 2013 04:13:29 +0000
Subject: [Koha-bugs] [Bug 11066] Export Citations not RDA compatible
In-Reply-To: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11066-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11066-70-GE3cAFJaDP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11066

--- Comment #1 from Joy Nelson <joy at bywatersolutions.com> ---
Created attachment 22432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22432&action=edit
Bug 11066: RIS and Bibtex Exports RDA compatible

RIS and Bibtex exports from staff side and OPAC edited to
allow for additional publisher RDA tag (264).  Script will
look first for 264 then fallback to 260 when pulling publisher
data from marc21 record.

Test Plan:
1. Create RDA and non RDA record
2. In OPAC, export both as RIS and Bibtex - verify publisher information is
exported
3. On staff side, export records as RIS and Bibtex, verify publisher
information
is exported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Oct 26 06:21:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 26 Oct 2013 04:21:42 +0000
Subject: [Koha-bugs] [Bug 11042] Color issue for selected tab under search
	box
In-Reply-To: <bug-11042-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11042-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11042-70-mXkkizZ6HX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11042

Ketan Kulkarni <ketan at carvingit.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |ketan at carvingit.com
           Assignee|koha-bugs at lists.koha-commun |ketan at carvingit.com
                   |ity.org                     |

--- Comment #1 from Ketan Kulkarni <ketan at carvingit.com> ---
Created attachment 22433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22433&action=edit
Updated staff-global.css

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 03:36:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 02:36:29 +0000
Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra
In-Reply-To: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11096-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11096-70-UWMe3clpFe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
David, can you sign off on this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 03:37:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 02:37:22 +0000
Subject: [Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
In-Reply-To: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11061-70-eYgp940go6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 03:37:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 02:37:25 +0000
Subject: [Koha-bugs] [Bug 11061] Koha::Calendar::_mock_init is unused
In-Reply-To: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11061-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11061-70-NHtSA1fFoF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11061

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22018|0                           |1
        is obsolete|                            |

--- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22434&action=edit
Bug 11061: Koha::Calendar::_mock_init is unused

Bug 9209 removes the only occurrence to Koha::Calendar::_mock_init
The routine can be removed.

Test plan:
prove t/Calendar.t

Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com>
I left that routine because I planned to do a follow-up for that so the
Calendar patch series was pushed soon. Nice catch Jonathan, works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 03:39:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 02:39:20 +0000
Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample
	frameworks
In-Reply-To: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10963-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10963-70-TN6yf6fjRq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Elaine,

the goal of this bug is a bit different, as the idea is to change the way we
create the specified frameworks on database level. But we have a place for your
frameworks on the wiki - http://wiki.koha-community.org/wiki/MARC_frameworks.
If you want, you can upload them there or I can do it - just let me know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 03:44:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 02:44:28 +0000
Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place
 resets to logged in branch
In-Reply-To: <bug-9993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9993-70-Elw9TkZdGb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I see the current behaviour as a bug. If I select a specific value and save
that, Koha should respect that and on edit show what has been selected before
and saved to the database.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:29:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:29:45 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-7cEP4gndZM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:29:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:29:48 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-5kPT550KKW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22435&action=edit
[PASSED QA] Bug 11111: The basket group is not display on the parcel page

Test plan:
Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name
is displayed into the 2nd column.

Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Changed basketgroup to basket group to match spelling on other
pages.
Works as described, passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:35:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:35:04 +0000
Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has
	awkward wording
In-Reply-To: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10776-70-vCJ9Hb76wl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:35:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:35:08 +0000
Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has
	awkward wording
In-Reply-To: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10776-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10776-70-rh1N0PZxK9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22417|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22436&action=edit
[PASSED QA] Bug 10776 - subscription notification screen has awkward wording

to test:
- make a subscription available to be notified about
- log into the opac, click the subscriptions tab, then More details
- click "Subscribe to email notification on new issues"
- observe the text without the patch - there seems to be an extra "arrive?"
- apply the patch, refresh - wording should flow a bit better.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Fixes bad wording and works as described.
Passes all tests and QA script, template change only.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:35:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:35:30 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-46jlRVjINF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22287|0                           |1
        is obsolete|                            |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:41:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:41:06 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-BWVnvWs2Kd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:41:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:41:09 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-I55jqL2rWt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22388|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22437&action=edit
[PASSED QA] Bug 11128: On cancelling receipt, the order is still listed in the
received orders

Cause: The list of received orders is built *before* cancelling the receipt!

Test plan:
0/ don't apply the patch
1/ create a basket
2/ create an order with 3 items
3/ receive 1 item
4/ cancel the receipt
=> The order is still listed in the received orders table!
5/ apply the patch
6/ do again steps 1 to 4
=> The order is not listed in the received orders table.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Works as described and passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:46:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:46:25 +0000
Subject: [Koha-bugs] [Bug 11144] New: Switch order of overdues and fines
 cronjob for packages and in crontab.example
Message-ID: <bug-11144-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144

            Bug ID: 11144
           Summary: Switch order of overdues and fines cronjob for
                    packages and in crontab.example
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: ulrich.kleiber at bsz-bw.de

Printing the correct fine in the overdues letters will only work correctly,
when the fines.pl cronjob runs before overdue_notices.pl, else the fine is not
there when the letter is created and can not be printed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:47:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:47:16 +0000
Subject: [Koha-bugs] [Bug 11138] Auto-unsuspend holds not in default cronjobs
In-Reply-To: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11138-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11138-70-4h31tk8FMi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11138

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Liz, I was wondering if this should also be added to the crontrab.example
file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:57:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:57:43 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-cG0a4jgVXK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:57:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:57:46 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-ebSnHisHCa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22383|0                           |1
        is obsolete|                            |
  Attachment #22384|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22438&action=edit
[SIGNED-OFF] Bug 11137: regression tests for QP search field alias bug

This patch adds regression tests to verify that
Boolean searches using QueryParser function correctly.

This patch also ensures that QP is correctly initalized
when Search.t is run.

To test:

[1] Apply this patch and the following patch.
[2] Verify that prove -v t/QueryParser.t works
[3] Verify that prove -v t/db_dependent/Search.t works
[4] (optional) instead of applying both patches at the same
    time, apply only the regression test patch and run the
    tests listed in steps 2 and 3.  The following tests
    should fail:

t/db_dependent/Search.t (Wstat: 512 Tests: 198 Failed: 2)
  Failed tests:  42, 71
  Non-zero exit status: 2
t/QueryParser.t (Wstat: 256 Tests: 28 Failed: 1)
  Failed test:  12
  Non-zero exit status: 1

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 04:57:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 03:57:57 +0000
Subject: [Koha-bugs] [Bug 11137] QueryParser can ignore parts of a Boolean
 search after the first
In-Reply-To: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11137-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11137-70-bhVFkSISij@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11137

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22439&action=edit
[SIGNED-OFF] Bug 11137: fix certain types of searches run using QueryParser

QueryParser was loading redundant search aliases, which in turn resulted
in certain queries involving two or more clauses joined by a Boolean
operator getting parsed in correctly.

To test:

[1] Enable QueryParser.
[2] Arrange your database so that some some bib records contain
    the keyword 'history' while a smaller subset contain
    both 'history' and 'earth'.  (The exact words used don't
    matter.)
[3] Run the following search from the OPAC global search bar:

    kw:history && kw:earth

[4] Observe that the records that are returned include *all* bibs
    in the database with the keyword 'history'.  In other words, the
    restriction  that the records must also contain 'earth' is not
    observed.
[5] Apply the patch and rerun the search.
[6] This time, the results that are returned should include only those
    that contain both 'history' and 'earth'.
[7] Verify that prove -v t/QueryParser.t passes.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes test plans, all tests and QA script.
Also checked the db_dependent/Search.t tests.
Tried some other searches, all seems to be working correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 05:03:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 04:03:54 +0000
Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-01FyH6UofX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 05:03:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 04:03:57 +0000
Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css
	selectable.
In-Reply-To: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11101-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11101-70-AkPdsoRsFD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22298|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22440
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22440&action=edit
[SIGNED OFF] Bug 11101 - Item Types label in opac not easily css selectable.
Verify that the facet label for item type is wrapped in a span

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Adds a CSS class to the Item types facet in OPAC.
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 05:12:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 04:12:24 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-FdA8nMfNWp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 05:12:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 04:12:27 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-WqvmXSHv3q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22260|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22441&action=edit
[PASSED QA] Bug 11108: fix duplicate display of basket whose receipt has just
been cancelled

After receiving an order basket, before finishing receiving the shipment,
one has an option to cancel the receipt.  This patch fixes a bug where
a basket whose receipt was just cancelled displays on both the pending orders
and already received tabs.

This patch also fixes a minor unitialized variable warning.

To test:

[1] Create a basket with at least one order and close it.
[2] Receive the order, then on the row in the 'Already received'
    table, click the cancel receipt link.
[3] In the page that displays, the basket just cancelled displays
    on both tables.  Clicking the cancel receipt link again results
    in an error message.
[4] Apply the patch.
[5] Repeat steps 1 and 2.  This time, the cancelled basket displays
    only in the pending orders table, as expected.
[6] Verify that after applying the patch, the following no longer
    is logged in the Apache error log:

parcel.pl: Use of uninitialized value in string eq at acqui/parcel.pl line...

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Ed Veal <ed.veal at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes test plan, all tests and QA script.
Works as described.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 05:13:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 04:13:28 +0000
Subject: [Koha-bugs] [Bug 11128] On cancelling receipt,
 the order is still listed in the received orders
In-Reply-To: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11128-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11128-70-9Xs5D6tnQM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11128

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking as duplicate of 11108 - I have tested both patches and they both work.
Bug 11108 looks a bit cleaner to me and also fixes a warn, but leaving final
decision to Galen.

*** This bug has been marked as a duplicate of bug 11108 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 05:13:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 04:13:28 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-98BNnzyd9J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 11128 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:25:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:25:42 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10851-70-yE2i6kcPWM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #9 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10851: Serials - Add missing statuses
Using index info to reconstruct a base tree...
M    C4/Serials.pm
M    koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
M    koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging C4/Serials.pm
Patch failed at 0001 Bug 10851: Serials - Add missing statuses
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:26:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:26:11 +0000
Subject: [Koha-bugs] [Bug 9580] Cover image from Coce,
	a remote image URL cache
In-Reply-To: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9580-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9580-70-6HlkVwkTza@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #9 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:27:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:27:13 +0000
Subject: [Koha-bugs] [Bug 10845] Multi transport types for holds
In-Reply-To: <bug-10845-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10845-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10845-70-w1bmbWDRII@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10845

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:28:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:28:16 +0000
Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for
 the same biblio
In-Reply-To: <bug-10859-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10859-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10859-70-tQMgppLCD6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10859: Alert if a borrower already has an issue for the same
biblio
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 10859: Alert if a borrower already has an issue for
the same biblio
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:29:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:29:18 +0000
Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing
In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10877-70-hfti8a2XIX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7180: Add UT for C4::Budgets::GetBudgetByCode
Using index info to reconstruct a base tree...
M    t/db_dependent/Budgets.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Budgets.t
CONFLICT (content): Merge conflict in t/db_dependent/Budgets.t
Patch failed at 0001 Bug 7180: Add UT for C4::Budgets::GetBudgetByCode
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:29:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:29:32 +0000
Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing
In-Reply-To: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10877-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10877-70-R1Qv3FUNGR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

--- Comment #9 from I'm just a bot <gitbot at bugs.koha-community.org> ---
This bug depends on bug7180 which is in status Needs Signoff but the patches
for it do not apply cleanly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:30:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:30:08 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-icodKa473c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #21 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10212: Columns configuration for tables
Using index info to reconstruct a base tree...
M    circ/circulation.pl
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql
Auto-merging circ/circulation.pl
Patch failed at 0001 Bug 10212: Columns configuration for tables
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:31:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:31:16 +0000
Subject: [Koha-bugs] [Bug 10861] Add a check on cardnumber length
In-Reply-To: <bug-10861-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10861-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10861-70-csLyazO2cY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10861

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:31:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:31:45 +0000
Subject: [Koha-bugs] [Bug 10811] Add a 999$c record matching rule to the
	MARC21 defaults
In-Reply-To: <bug-10811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10811-70-k99ruthPxj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10811

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:32:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:32:23 +0000
Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices
In-Reply-To: <bug-9016-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9016-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9016-70-TvRuuozCLv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #18 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:32:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:32:31 +0000
Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables
In-Reply-To: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10212-70-uTnATQ8A5W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
                 CC|                            |chris at bigballofwax.co.nz
        Bot Control|---                         |No Status change

--- Comment #22 from Chris Cormack <chris at bigballofwax.co.nz> ---
Just db conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:33:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:33:19 +0000
Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices
In-Reply-To: <bug-10832-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10832-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10832-70-yOqu63NyQa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:34:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:34:20 +0000
Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds"
	is missing.
In-Reply-To: <bug-10875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10875-70-zAvZlmTILj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-27
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7180: Add UT for C4::Budgets::GetBudgetByCode
Using index info to reconstruct a base tree...
M    t/db_dependent/Budgets.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Budgets.t
CONFLICT (content): Merge conflict in t/db_dependent/Budgets.t
Patch failed at 0001 Bug 7180: Add UT for C4::Budgets::GetBudgetByCode
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:34:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:34:34 +0000
Subject: [Koha-bugs] [Bug 10875] addorderiso2709: the link "show all funds"
	is missing.
In-Reply-To: <bug-10875-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10875-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10875-70-ZzBCkrXyt0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10875

--- Comment #9 from I'm just a bot <gitbot at bugs.koha-community.org> ---
This bug depends on bug7180 which is in status Needs Signoff but the patches
for it do not apply cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:44:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:44:40 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-2PnMwhP0hP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 07:44:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 06:44:44 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-3hlRrQ34qA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22330|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22442&action=edit
[SIGNED OFF] bug 8854: fix some invoice search filters

Fix the supplier, shipment date, and library filters
on the invoice search.  An invoice's library is
(in parallel with order search) defined as the library
of the staff member that approved the basket.  Before this
patch, the code was referring to an aqorders.branchcode
column that doesn't exist.

This patch also improves the author, title, ISBN/EAN/ISSN,
publisher, and publication year filters to no longer require
exact matches; substring matches now suffice.

Finally, this patch considers biblio.copyrightdate in addition
to biblioitems.publicationyear for publication date searches, as
the MARC21 frameworks use the former column but not the latter.

This patch also fixes the current test cases for invoices
so that they pass and adds regression tests.

Test plan:

[1] Create two invoices for different vendors.
[2] Do an invoice search and filter on shipment
    date.  Verify that the expected invoice(s)
    are returned.
[3] Do an invoice search and filter on branch
    (of the staff member that approved the basket).
    Verify that the expected invoice(s) are returned.
[4] Do an invoice search and filter on supplier.
    Verify that the expected invoice(s) are returned.
[5] Do invoice searches on author, title, ISBN/EAN/ISSN,
    publisher, and publication year and verify that the
    results are as expected.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Patch passes all tests, test plan and QA script.

Possible improvements:
- Document the behaviour of the library search as there are
  lots of branches all over acquisitions with different meaning.
- Add the shipment date to the results list table
- Change label ISBN/EAN/ISSN to not include EAN for MARC21
  installations

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 08:24:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 07:24:21 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-iPv5oab6j7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #40 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this doesn't work quite right if you use the daemon mode only for -b
not for -a.

The command I ran was:
./misc/migration_tools/rebuild_zebra.pl -daemon -sleep 4 -b -v -z

Then I added a new authority, it keeps repeating the following lines:

queued records: 1
skipping authorities
====================
exporting biblio
====================

Records exported: 0

Records exported: 0
====================
REINDEXING zebra
====================

The record is not reindexed, but Koha keeps trying. I think this is because the
SQL statement doesn't differentiate between authority and biblio records.

Doug, could you take a look?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 09:23:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 08:23:16 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-nSF8UBYrw1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tomas, I am sorry, but now no links show up at all for my data - after applying
the patch and refreshing the authority result page, all links are gone.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 09:24:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 08:24:36 +0000
Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in
 authority search result list
In-Reply-To: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10691-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10691-70-Q17N8ePFq0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:04:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:04:42 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-pm9KNyDtR3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:04:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:04:46 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-vetO6j22mZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19106|0                           |1
        is obsolete|                            |
  Attachment #19476|0                           |1
        is obsolete|                            |
  Attachment #21278|0                           |1
        is obsolete|                            |
  Attachment #22286|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22443&action=edit
[PASSED QA] Bug 9288 - Add a script to test SIP from the command line

This is a very basic start to a sip server testing script.
I imagine we will want to make it interactive in end,
essentially replicating what a SIP based self-checkout machine does.

Signed-off-by: Adrien Saurat <adrien.saurat at biblibre.com>
Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:05:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:05:05 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-NkUylSRC6r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22444
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22444&action=edit
[PASSED QA] Bug 9288 - Add a script to test SIP from the command line - QA
Followup

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:05:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:05:20 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-wvSv2CDnRz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22445&action=edit
[PASSED QA] Bug 9288 - Add a script to test SIP from the command line - QA
Followup 2

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:05:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:05:32 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-CTqoNtWKjP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22446&action=edit
[PASSED QA] Bug 9288 - Add a script to test SIP from the command line - QA
Followup 3

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:06:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:06:42 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-XaduZDWsXV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Works now ok for me, no more warnings.

Started SIP server and used: 
misc/sip_cli_emulator.pl --a 127.0.0.1 --port 6001 --sip_user sip --sip_pass
sip --location MPL --patron sip --password sip

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:13:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:13:53 +0000
Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command
	line
In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9288-70-Y08M6e1JNr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry Kyle, I missed this from the QA script:

 FAIL    misc/sip_cli_emulator.pl
   OK      pod
   OK      forbidden patterns
   OK      valid
   FAIL      critic
        Subroutine prototypes used at line 115, column 1. See page 194 of PBP.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:21:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:21:11 +0000
Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm
In-Reply-To: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11032-70-xlrbBw1Ukp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 10:21:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 09:21:14 +0000
Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm
In-Reply-To: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11032-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11032-70-LyNpRxlpwU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21958|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22447&action=edit
[SIGNED OFF] Bug 11032: Check a valid MARC::Record passed to Biblio

Intermittently problems in the calling environment
cause a C4::Biblio to be called with and undefined
MARC::Record object. This results in the process
dieing and returning to the enduser a low level
message such as 'cannot call method x on an undefined
object'
For exported subroutines taking a MARC::Record object
check that object is defined otherwise return a logical
return value and log a stack trace to the error log.
A couple of cases were checking but dieing, this may have
unwelcome results in a persistent environment so croak has
been downgraded to carp

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Adds lots of checks for $record in various places, should
not affect behaviour.
Passed all tests and QA script, including new unit tests.
Tested adding and saving a new record.
Also tested detail and result pages without XSLT.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 15:39:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 14:39:07 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-EMtH3hmfMQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22448&action=edit
Bug 6149: Follow-up - Operator highlighted in search results

- changed sample words to and|or|not in sysprefs.sql and
  updatedatabase
- changed systempreference name from OpacHighlightedStopwords
  to HighlightedStopwords, as it also works for the staff
  results page

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 15:39:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 14:39:45 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-ZhNn0yPKWu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Martin, could you take a look at my follow-up and sign-off on it if it's ok?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 15:42:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 14:42:25 +0000
Subject: [Koha-bugs] [Bug 9368] specific behavior of yr and acqdate indexes
In-Reply-To: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9368-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9368-70-3XalG0igca@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9368

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jared, can you submit a follow-up for the QueryParser?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 16:03:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 15:03:24 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-TVla7xWAyL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 16:03:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 15:03:27 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-TLcXmlXPeY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22318|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22449
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22449&action=edit
[PASSED QA] Bug 11054: Specify utf8 encoding when creating a child record

When the only non-ascii characters in a new child record
are latin + diacritic in the range covered by Latin-1 they
are not being added to a new child record correctly encoded.
Explicitly setting the record's encodiing ensures that
they are interpreted correctly.

see "Unicode Bug" in perldoc perlunicode for background on
why these characters are special

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Works well. No koha-qa errors.

Same test as before
1) with a record with diacritics in author/title,
2) press new child record, on new record 773adt
with mangled accents
3) Apply patch
4) Repeat 2, now good results

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Tested with a record containing umlauts in the title,
$t was empty before and umlauts in $a mangled.
After applying the patch fields are correctly filled and
diacritics display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 16:03:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 15:03:59 +0000
Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with
 accented Latin characters
In-Reply-To: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11054-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11054-70-BiT9NVFjIB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         QA Contact|paul.poulain at biblibre.com   |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 16:44:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 15:44:45 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-N99G659jAL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 16:44:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 15:44:49 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-R0KVHFnPo0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22239|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22450&action=edit
[PASSED QA] Bug 10974 - OAI-PMH Resumption Tokens Do Not Handle Time

This patch changes the value separator in OAI-PMH resumption tokens
from colons to slashes, so that the token string isn't split incorrectly
when a time is included.

TEST PLAN:

1) Turn on the OAI-PMH server syspref in Koha
2) Send a ListRecords request using 'from' and 'until' arguments that
include times (Best to use very far apart times so that you retrieve
more than 50 records which will likely be the trigger for a resumptionToken).
Here is an example:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
metadataPrefix=oai_dc&from=2012-09-05T13:44:33Z&until=2014-09-05T13:44:33Z

N.B. Replace KOHAINSTANCE with the URL of your Koha instance.

3) Scroll down to the bottom of the page until you find the resumptionToken.
It will look similar to this:

<resumptionToken cursor="50">
oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:
</resumptionToken>

4) Copy that resumption token and send a request with it like so:

http://KOHAINSTANCE/cgi-bin/koha/oai.pl?verb=ListRecords&
resumptionToken=oai_dc:50:2012-09-05T13:44:33Z:2014-09-05T13:44:33Z:

5) The page should (incorrectly) show no records.

6) APPLY PATCH

7) Repeat steps 2, 3, and 4

8) Note that the resumptionToken now uses slashes (e.g. /) instead of
colons.

Note also that now the second request will show records!!!

N.B. This will only happen if Koha has enough records to serve to you.
If your Koha has less than 50 records, try lowering the number provided
in the "OAI-PMH:MaxCount" system preference.

Signed-off-by: Petter Goksoyr Asen <boutrosboutrosboutros at gmail.com>

I understand; I can now confirm the behaviour described in the test plan.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes test plan, all tests and QA script.
Resumption Token works correctly after applying the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 18:30:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 17:30:43 +0000
Subject: [Koha-bugs] [Bug 10538] Improve importation of .CSV framework files
In-Reply-To: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10538-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10538-70-rlJZnK6Qt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10538

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am a bit worried about this rewrite.

OO/LibreOffice seems to remove the quotation marks from the fields when you
save the file with a new name.

The patch makes it possible to import the file anyway. But this can lead to
other problems, for example it would be possible to have a comma in one of the
descriptions and this field would not be imported, without any warning or error
message.

I also wonder about the use case here, because we also offer a specific
spreadsheet format to be used with OO/Libre Office.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:21:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:21:35 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-SHqZ7Jv3MD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:21:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:21:39 +0000
Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and
	upgrade
In-Reply-To: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10729-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10729-70-0wZawQF5on@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21778|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22451&action=edit
[PASSED QA] Bug 10729: Add phrases configuration for icu

Add a separate phrases-icu.xml for phrase indexes
The file is based on that distributed with zebra
with a couple of additions to reflect Koha usage

This patch adds a separate tokenizer variable
for phrase indexes so that default.idx is
correctly rewritten for sites using icu
indexing

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
- Applied patch
- perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log
- make upgrade
- Restarted Zebra server
- Did a full reindex of bibliographic and authorities
- Checked various searches
- Links records to authorities
- Checked created links work correctly

I couldn't find a regression with this patch.
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:37:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:37:28 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-DuOZqCKuUD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:37:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:37:33 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-ixBxaufnbL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22148|0                           |1
        is obsolete|                            |
  Attachment #22149|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22452&action=edit
[PASSED QA] Bug 11086 : Fixing some grammatical mistakes in member-flags and
tools-home

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
String change, only affecting templates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:37:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:37:48 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-LzkqpAsU2Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22453&action=edit
[PASSED QA] Bug 11086 : Follow up, editing the database files also

To test before the patch is applied notice that on the member-flags page
it says
"upload patron images in batch or one at a time"
After the patch it should say
"upload patron images in a batch or one at a time"

Try also for tools-home

Signed-off-by: David Noe <drnoe at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Changes permission description in en and untranslated
installer files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:46:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:46:33 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-3zrllEFRb7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, I think we will also need a follow up for the Bootstrap OPAC.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:56:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:56:14 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-eUv81lvSde@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22418|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22454&action=edit
[PASSED QA] Bug 11133 - Markup errors in OPAC place hold form HTML

There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes all tests and QA script.
Tested according to test plan and validated souce code with
W3C Validator.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 19:56:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 18:56:11 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-H1am9f2z3q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 20:05:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 19:05:57 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-V6ikVBdxxZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 20:06:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 19:06:00 +0000
Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a
	biblio to a list
In-Reply-To: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11132-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11132-70-mTfZHsilwQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22431|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22455&action=edit
[PASSED QA] Bug 11132: The results list is reset on adding a biblio to a list

A "busc" param is cleared if the template name is not opac-.*detail.tt.
So if a user adds a biblio to a list, he cannot continue to browse
results.

Test plan:
- launch a search at the OPAC (opac-search.pl).
- click on a result and browse results (using previous/next links).
- a title attract your attention and you add it to a list
  ("Save to yours lists" link on the right).
- save the list.
- browse again results.

Signed-off-by: Joy Nelson <joy at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Tested according to test plan, also checked some other pages and actions
accessible from the detail page.
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 20:31:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 19:31:22 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-Ff92E0AeaM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 20:31:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 19:31:26 +0000
Subject: [Koha-bugs] [Bug 2310] Delete grayed out w/out explanation
In-Reply-To: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2310-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2310-70-KNSXTyDHEW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22419|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22456&action=edit
[PASSED QA] Bug 2310 - Delete grayed out w/out explanation

With some staff client menus options are displayed as disabled when the
logged in user doesn't have permission to perform that function. This
patch adds Bootstrap tooltips to patron menu items with text explaining
why they are disabled.

To test, log in as a user who lacks permission to modify patrons or set
permissions. Open a patron record in circulation or patrons. Hovering
over renew, delete, and set permissions links (in the patron toolbar
"More" menu) should trigger a tooltip with a brief explanation.

Test the "Update child to adult patron" link by viewing an adult patron.

A separate patch will address catalog menu items.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
New tooltip texts are translatable, patch passes all tests
and QA script.
Tested according to test plan in Chromium and Firefox.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 20:38:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 19:38:15 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-w92dzlgMgd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, this has come up on other bugs recently. I am not sure how we should deal
with it. For me changing the frameworks to use CCODE on biblevel looks like a
customization and I am not sure if we should hardcode that in. It will only be
useful under very certain circumstances for specific libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 21:32:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 20:32:58 +0000
Subject: [Koha-bugs] [Bug 11145] New: creating a guided report in
 non-english language fails
Message-ID: <bug-11145-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145

            Bug ID: 11145
           Summary: creating a guided report in non-english language fails
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: wwwretive at yahoo.fr
        QA Contact: testopia at bugs.koha-community.org

Hi,

At our library we use Koha with the Unimarc format, in french.
Since we switched to koha 3.10 we are no longer able to create guided reports :
it fails after the second step with message "Unsuported report area "types" at
/usr/share/koha/lib/C4/Reports/Guided.pm line 213".

I googled around and found out that the same happens with the spanish version :
http://groups.yahoo.com/neo/groups/koha-es/conversations/topics/3064

I tried with the english interface and it worked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 21:50:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 20:50:41 +0000
Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english
	language fails
In-Reply-To: <bug-11145-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11145-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11145-70-VaS3IwXbhX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Michel, can you give us the exact version you are using? You can find it on
the About page of your installation.
I think this might be a bug, that has been fixed, but it's easier to check when
we have more information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Oct 27 23:35:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 27 Oct 2013 22:35:59 +0000
Subject: [Koha-bugs] [Bug 11145] creating a guided report in non-english
	language fails
In-Reply-To: <bug-11145-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11145-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11145-70-jCFAUqeZA4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11145

--- Comment #2 from michel <wwwretive at yahoo.fr> ---
I'm using koha version 3.10.11, perl version 5.14 on a debian wheezy system.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 02:40:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 01:40:42 +0000
Subject: [Koha-bugs] [Bug 10498] Place Hold on Order
In-Reply-To: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10498-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10498-70-0H1VaPfoAy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498

--- Comment #7 from Srdjan Jankovic <srdjan at catalyst.net.nz> ---
I got

Global symbol "$messages" requires explicit package name at
/home/srdjan/koha/dev/reserve/request.pl line 170.
Global symbol "$warnings" requires explicit package name at
/home/srdjan/koha/dev/reserve/request.pl line 172.
Execution of /home/srdjan/koha/dev/reserve/request.pl aborted due to
compilation errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 03:24:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 02:24:34 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-RQMM9sym2A@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21390|0                           |1
        is obsolete|                            |
  Attachment #21391|0                           |1
        is obsolete|                            |

--- Comment #41 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22457&action=edit
[ENH] Bug 6435 Add daemon mode to rebuild_zebra.pl (revised 10/27)

(combines previous patches and addresses recent QA issue)
This change adds code to check the zebraqueue table with a cheap SQL query
and a daemon loop that checks for new entries and processes them incremantally
before sleeping for a controllable number of seconds.  The default is 5 seconds
which provides a near realtime search index update.  This is desirable
particularly
for libraries that are doing active catalogue updating.  The query is adjusted
based on whether -a, -b, or -a -b are specified.

Help text updated.  Tested against a live 3.12 system.

Note that this fix will benefit from the fix to lack of locking (bug 11078)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 03:27:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 02:27:27 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-0sbCZfxELG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Doug Kingston <dpk at randomnotes.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22205|0                           |1
        is obsolete|                            |

--- Comment #8 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22458&action=edit
Bug 11078 Add locking to rebuild_zebra to prevent race  conditions (revised
10/27)

(revised to address a QA issue on lock directory location)
The race condition exists whether you are doing incremental updates with
a periodic cronjob or with the new daemon mode.  Suppose you start a full
rebuild at time T0 which will take until T20 to extract the records.  Suppose
also at T10, a biblio or auth is updated and processed through the zebraqueue
by T15. In this situation the updated record in zebra will be overwritten when
the full rebuild records are uploaded to zebra after T20.  We prevent this
by only allowing one rebuild_zebra per koha instance to be running at one time.

This patch adds flock based locking for rebuild_zebra.pl on a per-instance
basis.  This prevents races between full rebuilds and background incremental
updates from the zebraqueue table in the database.  Add a lockdir to the config
file to allow the proper location to be determined at runtime.

When running in daemon mode (see bug 6435), incremental updates will be skipped
while a full rebuild is running, and resume afterwards.  A full rebuild or
other
adhoc request will wait for any previous lock to clear.

Tested by flocking the lock file while invoking rebuild_zebra.pl in
various modes (daemon, adhoc zebraqueue task, and full rebuild) using
flock program I will attach to bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 05:52:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 04:52:16 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-ZezHZDvkiF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |mtompset at hotmail.com

--- Comment #42 from M. Tompsett <mtompset at hotmail.com> ---
I'm just curious if you would want to run daemon mode for only biblios or only
authorities. If this process is going to run in daemon mode, would you not want
both to be picked up? Otherwise, you'd have to run two daemons (one for bibs
and one for auths). Changing the status to needs sign off, since this question
doesn't really affect whether the code does what it is supposed to do, but I
haven't tested it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 06:25:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 05:25:59 +0000
Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to
	rebuild_zebra.pl
In-Reply-To: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6435-70-PW3fFrIRiK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

--- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes, you'd probably want both, but for example if your library don't uses
authorities and you don't turn it on and then someone catalogs an authority for
testing... it shouldn't lead to trouble. It's just something that could go
wrong that we might want to avoid either by documentation or by catching it in
the code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:12:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:12:17 +0000
Subject: [Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
In-Reply-To: <bug-8992-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8992-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8992-70-Qj51L3hDsD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #12 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:12:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:12:53 +0000
Subject: [Koha-bugs] [Bug 10860] In-House Use
In-Reply-To: <bug-10860-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10860-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10860-70-4AuBer3IkA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #13 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10860: In-House Use
Using index info to reconstruct a base tree...
M    C4/Circulation.pm
M    C4/Items.pm
M    circ/circulation.pl
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/sysprefs.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
M    koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
M    koha-tmpl/intranet-tmpl/prog/en/js/pages/circulation.js
M    koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
M    koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/pages/circulation.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging circ/circulation.pl
Auto-merging C4/Items.pm
Auto-merging C4/Circulation.pm
Patch failed at 0001 Bug 10860: In-House Use
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:13:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:13:33 +0000
Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the
 visibility of the content on the Advanced Search page
In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9043-70-c6gPG28sOL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #34 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 9043 - Changes to the advanced search page
Using index info to reconstruct a base tree...
M    installer/data/mysql/sysprefs.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
M    koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
M    opac/opac-search.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Patch failed at 0001 Bug 9043 - Changes to the advanced search page
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:14:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:14:04 +0000
Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to
 items being receipted, to be identified during the receipting process.
In-Reply-To: <bug-10440-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10440-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10440-70-VCrPCdEhBk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10472 - Receipt by line or invoice
Using index info to reconstruct a base tree...
M    acqui/parcel.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
Auto-merging acqui/parcel.pl
CONFLICT (content): Merge conflict in acqui/parcel.pl
Patch failed at 0001 Bug 10472 - Receipt by line or invoice
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:14:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:14:45 +0000
Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions:
 force_checkout and lift_restriction
In-Reply-To: <bug-10863-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10863-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10863-70-reivkgwrwO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-10-02 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #27 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:15:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:15:19 +0000
Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the
	itemtype code
In-Reply-To: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10090-70-328d0yubgg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #9 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:15:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:15:47 +0000
Subject: [Koha-bugs] [Bug 10983] Unused subroutines in C4:Budgets
In-Reply-To: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10983-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10983-70-Ky2LGUmka1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10983

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-10-02 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:16:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:16:33 +0000
Subject: [Koha-bugs] [Bug 10857] Add facets cancellation
In-Reply-To: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10857-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10857-70-KWaoOrlQBB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #33 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:17:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:17:07 +0000
Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as
	expected
In-Reply-To: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10985-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10985-70-sLiOoGDMxR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-10-03 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:21:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:21:23 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-Ivm3ZFg7RB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-10-03 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #24 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 9021 - Add SMS via email as an alternative to SMS services via
SMS::Send drivers
Using index info to reconstruct a base tree...
M    C4/Letters.pm
M    C4/Members.pm
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Members.pm
CONFLICT (content): Merge conflict in C4/Members.pm
Auto-merging C4/Letters.pm
Patch failed at 0001 Bug 9021 - Add SMS via email as an alternative to SMS
services via SMS::Send drivers
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:21:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:21:52 +0000
Subject: [Koha-bugs] [Bug 9448] Add separate permission for writing off fees
In-Reply-To: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9448-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9448-70-JrFMVF0eRV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9448

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-10-03 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:22:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:22:22 +0000
Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt
In-Reply-To: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10043-70-v5T9CJoCS1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:22:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:22:59 +0000
Subject: [Koha-bugs] [Bug 9743] Hold notes are required if there is one item
 referring to more parts/volumes
In-Reply-To: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9743-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9743-70-qG7PeFzDxJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9743

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #27 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:23:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:23:34 +0000
Subject: [Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC
	7XX
In-Reply-To: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9352-70-CxjilZ2auD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #23 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:24:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:24:09 +0000
Subject: [Koha-bugs] [Bug 10402] Add multiple contacts for vendors
In-Reply-To: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10402-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10402-70-xwC8F3Dvl2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-28
    last check this|                            |

--- Comment #40 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10402: Use an object for contacts
Using index info to reconstruct a base tree...
M    C4/Bookseller.pm
M    acqui/uncertainprice.pl
M    koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
M    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
M    t/db_dependent/Bookseller.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Bookseller.t
CONFLICT (content): Merge conflict in t/db_dependent/Bookseller.t
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging acqui/uncertainprice.pl
CONFLICT (content): Merge conflict in acqui/uncertainprice.pl
Auto-merging C4/Bookseller.pm
Patch failed at 0001 Bug 10402: Use an object for contacts
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:24:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:24:40 +0000
Subject: [Koha-bugs] [Bug 6890] Add reserves to modification logging
In-Reply-To: <bug-6890-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6890-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6890-70-zmJpXknhm4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6890

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-28
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:25:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:25:20 +0000
Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to
 choose to display an icon based on the marc control fields,
 or based on the koha biblio level itemtype
In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8732-70-DSMhzW65IS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-28
    last check this|                            |

--- Comment #19 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 8732: Allowing biblio level itemtypes to display instead of MARC
ones
Using index info to reconstruct a base tree...
M    installer/data/mysql/sysprefs.sql
M    installer/data/mysql/updatedatabase.pl
M    opac/opac-detail.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-detail.pl
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Patch failed at 0001 Bug 8732: Allowing biblio level itemtypes to display
instead of MARC ones
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:25:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:25:49 +0000
Subject: [Koha-bugs] [Bug 10994] Email sending is not working in claim notice
In-Reply-To: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10994-70-OhM8YJaLk4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10994

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-28
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:26:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:26:18 +0000
Subject: [Koha-bugs] [Bug 11004] Make xmlControlfield.js use the marcflavour
 syspref to look for XML files
In-Reply-To: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11004-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11004-70-bIx4HQ6Xt6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11004

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-28
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:26:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:26:52 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-JuOfZTX4hA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-28
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 6810 Add new systempreference and sample notice (Membership
Expiry notice)
Using index info to reconstruct a base tree...
M    installer/data/mysql/sysprefs.sql
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Patch failed at 0001 Bug 6810 Add new systempreference and sample notice
(Membership Expiry notice)
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:42:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:42:11 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-45ceNBj71o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21872|0                           |1
        is obsolete|                            |

--- Comment #12 from Amit <amitddng135 at gmail.com> ---
Created attachment 22459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22459&action=edit
Added new systempreference: Membership

Added new systempreference: Membership

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 07:42:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 06:42:23 +0000
Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices
In-Reply-To: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6810-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6810-70-fhHZf3sklG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Amit <amitddng135 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 09:18:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 08:18:04 +0000
Subject: [Koha-bugs] [Bug 6113] enhancement to keep previous ids
In-Reply-To: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6113-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6113-70-4uTPsdmQNI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6113

--- Comment #25 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
>Would it be possibly better to solve this using bug 8015 as a basis? It's a more >extensible/flexible system and we could easily modify bulkmarcimport.pl to allow >the use of modification templates. I know it means tossing this existing work, >but I'd say it's usually better to have less code than more code.

I think bug 8015 is a great basis for this, but I needed this functionality for
our data migration and subsequently this bug was just a target of opportunity.
Hopefully this helps someone else as well.

It's fine by me that someone else will solve this problem with more style and
potentially discard all the work I have made. Unfortunately this is way out of
our scope, so that someone else wont be me.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 09:26:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 08:26:27 +0000
Subject: [Koha-bugs] [Bug 8074] Define default library for holds to pull
	report
In-Reply-To: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8074-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8074-70-rOqbqzawmI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Oops.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 09:41:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 08:41:16 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10851-70-PCnlTZIhJM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20958|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22460&action=edit
Bug 10851: Serials - Add missing statuses

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 09:41:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 08:41:22 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10851-70-VJucMm6zBZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 10:00:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 09:00:00 +0000
Subject: [Koha-bugs] [Bug 10860] In-House Use
In-Reply-To: <bug-10860-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10860-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10860-70-nweexBjuEN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21642|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22461&action=edit
Bug 10860: In-House Use

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 10:00:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 09:00:32 +0000
Subject: [Koha-bugs] [Bug 10860] In-House Use
In-Reply-To: <bug-10860-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10860-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10860-70-S7bCyAhKXP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 10:02:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 09:02:28 +0000
Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the
 visibility of the content on the Advanced Search page
In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9043-70-FDXec0oLsD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21643|Bug 9043: Syspref           |[ALT 1/3] Bug 9043: Syspref
        description|improvement: add new type   |improvement: add new type
                   |"multiple"                  |"multiple"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 10:02:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 09:02:43 +0000
Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the
 visibility of the content on the Advanced Search page
In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9043-70-sLulU9yMYr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21644|Bug 9043: Changes to the    |[ALT 2/3] Bug 9043: Changes
        description|advanced search page        |to the advanced search page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 10:02:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 09:02:57 +0000
Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the
 visibility of the content on the Advanced Search page
In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9043-70-W3QKl66WzZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21645|Bug 9043: Add the dropdown  |[ALT 3/3] Bug 9043: Add the
        description|check list jquery plugin    |dropdown check list jquery
                   |                            |plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 10:04:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 09:04:50 +0000
Subject: [Koha-bugs] [Bug 9043] Adding system preferences to control the
 visibility of the content on the Advanced Search page
In-Reply-To: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9043-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9043-70-NHZGjRKSTN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
        Bot Control|---                         |Ignore this bug

--- Comment #35 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Could it be possible to get some feedback on my proposed patches? The idea was
not to block the enh but to improve it!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:35:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:35:45 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-7nQYqaWOXb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

--- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Katrin,

could you confirm the unit tests pass for you?
I got:
% prove t/Acquisition/Invoice.t
t/Acquisition/Invoice.t .. 1/49 
#   Failed test at t/Acquisition/Invoice.t line 47.
#          got: '16'
#     expected: '15'

#   Failed test at t/Acquisition/Invoice.t line 62.
#          got: 'publicationyear'
#     expected: 'branchcode'
# Looks like you failed 2 tests of 49.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:39:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:39:09 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
	default
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-XKAiu77HT1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi
             Blocks|                            |11129

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:39:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:39:09 +0000
Subject: [Koha-bugs] [Bug 11129] Limiting the display of Serial issues OR
 Searching a specific Serial issue
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-wHAnwAmM8W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6385

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:40:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:40:15 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
	default
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-lBFzTFSS6a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |olli-antti.kivilahti at jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:41:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:41:05 +0000
Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in
 webinstaller mysql files
In-Reply-To: <bug-10509-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10509-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10509-70-beZksfX2WZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #22 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Changing status to Blocked.
Subsequent patches are already in Not apply-status. Apparently, this line of
development is not interesting enough to continue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:41:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:41:46 +0000
Subject: [Koha-bugs] [Bug 8667] Add budget and branch columns in
	histsearch.pl results
In-Reply-To: <bug-8667-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8667-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8667-70-9F4MOlAKCA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8667

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |INVALID

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
aqorders.branchcode won't exist and the fund column has been added by bug 5336.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:45:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:45:34 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-wHVKb8be8v@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

Bug 9921 depends on bug 10480, which changed state.

Bug 10480 Summary: Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 11:45:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 10:45:34 +0000
Subject: [Koha-bugs] [Bug 10480] Cataloging plugins without redefining
In-Reply-To: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10480-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10480-70-5YBrw2TpyK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:16:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:16:51 +0000
Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in
 webinstaller mysql files
In-Reply-To: <bug-10509-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10509-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10509-70-C9951P6bS9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

--- Comment #23 from Zeno Tajoli <z.tajoli at cineca.it> ---
What is it better to do for develop this patch ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:20:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:20:23 +0000
Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets
In-Reply-To: <bug-7308-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7308-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7308-70-9cAA7COKj8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

--- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Galen,
I don't see a good solution here.
Maybe can we change the color for child cells?
I think there is a deep ergonomic issue on this page and should be partially
rewrite (always use DT and insert a way to always see funds as a tree).
I will submit a followup in order to revive this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:21:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:21:19 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-bzJcmN6O9H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Limiting the display of     |Filtering Items based on
                   |Serial issues OR Searching  |type in opac-detail.pl
                   |a specific Serial issue     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:21:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:21:26 +0000
Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets
In-Reply-To: <bug-7308-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7308-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7308-70-rclzEvQOpm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

--- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22462
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22462&action=edit
Bug 7308: change color style for fund child

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:22:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:22:38 +0000
Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets
In-Reply-To: <bug-7308-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7308-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7308-70-rgJ2ClUlmT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Switch to "needs QA", waiting for a QAer point of view.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:24:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:24:54 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-Fo5J3QE09N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22448|0                           |1
        is obsolete|                            |

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22463
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22463&action=edit
[SIGNED OFF] Bug 6149: Follow-up - Operator highlighted in search results

Signed off on Katrin's followup, works perfectly and both changes make great
sense.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:25:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:25:36 +0000
Subject: [Koha-bugs] [Bug 9366] On cataloguing each user can easily display
	tags or not
In-Reply-To: <bug-9366-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9366-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9366-70-k0Bl7PhyTR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9366

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> ---
I leave the "in discussion" status since there is no discussion.
Switch back to Signed Off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:28:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:28:35 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-h59KTNoXtZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |In Discussion
                 CC|                            |z.tajoli at cineca.it

--- Comment #51 from Zeno Tajoli <z.tajoli at cineca.it> ---
Hi to all,

In fact the patch is blocked by discussion on Koha::Sequence (bug 10454).

Is it Ok if i rewrite the patch without the incremental option ?
I will insert two options.

1)001asBiblioNumberForce: with this option you can try to insert everything in
001, but the system force the equivalence 001 = biblionumber
You don't need the plugin

2)biblionumber: with this option you can use the plugin to insert the string
'biblionumber'. The system changes 'biblionumber' with the value of
biblionumber.
You need the plugin. If you insert a different number/string, the system will
insert yoyr number/string.

What do you think ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:32:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:32:43 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-4G0B3IrK9q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22464&action=edit
Bug 11129 - Filtering Items based on type in opac-detail.pl

Currently all Items are always shown on the opac-detail.pl. This is difficult
when the amount of Items grows substantially large.
Implemented a filter to limit the Items shown (and SELECTed from the DB) based
on some typical filters,
  locationbranch, volume, number, issue, fromDate, toDate.
Also streamlined how Serials-data is pulled from the DB to prevent substantial
extra work in C4::Items::GetItemsInfo().
C4::Items::GetItemsInfo() extended to support various filters.

All modifications:
Item filter shown when there are over 50 items (lotsofitems-flag).
Filter fields can be changed based on the Biblio type (isSerial-flag).
-Volume + Issue + Number available only for serials.
Can syspref if Issue-field is used in serial records.
Can syspref a regexp to parse the Volume + Number + Issue from the enumeration
or chronology field.
FromDate and ToDate filter the serial.publisheddate when dealing with serials
otherwise target the items.timestamp -column.
C4::Items::GetItemsInfo() simplified to include the serial data in the BIG SQL.
This makes filtering by publisheddate much more faster.

User input validated using HTML5 <input "number">
Business layer validations as well.

Unit tests:
Serials enumeration and chronology filtering
Items date and branch filtering

Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:33:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:33:31 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8994-70-DjN4WNRIvF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13133|0                           |1
        is obsolete|                            |
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22465
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22465&action=edit
Bug 8994: Make FindDuplicateAuthority behaviour customizable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 12:33:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 11:33:39 +0000
Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour
	customizable
In-Reply-To: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8994-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8994-70-YGGEFYhWuv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 13:20:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 12:20:06 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-0W1OOiBlRg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22466
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22466&action=edit
Bug 6149 - Follow-up - Stopwords for Result Highlighting

This follow-up adds the feature to the bootstrap theme as requested by Katrin
;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 13:22:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 12:22:55 +0000
Subject: [Koha-bugs] [Bug 11140] Centralize all sending of email to one
	subroutine
In-Reply-To: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11140-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11140-70-5tMyU3UHb2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140

Blou <philippe.blouin at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |philippe.blouin at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 13:45:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 12:45:31 +0000
Subject: [Koha-bugs] [Bug 11146] New: Show a go back link on no permission
	page
Message-ID: <bug-11146-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146

            Bug ID: 11146
           Summary: Show a go back link on no permission page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

When a user has not the permission for a page or module, the authentication
page is displayed with message : "Error: You do not have permission to access
this page.".
Most librarians uses the "previous page" button of there browser to come back
on the page they where before trying to get to this non-permitted page.

I propose to add a link to help comming back.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 13:52:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 12:52:10 +0000
Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name
In-Reply-To: <bug-7168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7168-70-1Ip0fKYg1f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephane.delaye at biblibre.co
                   |                            |m

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
*** Bug 7682 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 13:52:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 12:52:10 +0000
Subject: [Koha-bugs] [Bug 7682] search by aqbasketgroups.name
In-Reply-To: <bug-7682-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7682-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7682-70-7kcExj6gv4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7682

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Resolution|---                         |DUPLICATE

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Search by basket group name on histsearch is done in bug 7168 and on parcel.pl
in bug 10724.
I don't understand the need for orderreceive.pl

*** This bug has been marked as a duplicate of bug 7168 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 13:57:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 12:57:09 +0000
Subject: [Koha-bugs] [Bug 11146] Show a go back link on no permission page
In-Reply-To: <bug-11146-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11146-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11146-70-6XNdBiy4Wp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22467
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22467&action=edit
Bug 11146 - Show a go back link on no permission page

See commit message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:02:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:02:45 +0000
Subject: [Koha-bugs] [Bug 11146] Show a go back link on no permission page
In-Reply-To: <bug-11146-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11146-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11146-70-AlcTHrFO9L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11146

--- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
This is a demand for librarians not really used to internet browsers.
yes, it exists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:05:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:05:31 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-RJabKihkkS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #52 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Zeno Tajoli from comment #51)
> In fact the patch is blocked by discussion on Koha::Sequence (bug 10454).
> Is it Ok if i rewrite the patch without the incremental option ?
> I will insert two options.

I would favor a solution using the sequence number engine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:07:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:07:31 +0000
Subject: [Koha-bugs] [Bug 10509] Using i18n function for translation in
 webinstaller mysql files
In-Reply-To: <bug-10509-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10509-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10509-70-3ADQ2nUYY4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10509

--- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Zeno Tajoli from comment #23)
> What is it better to do for develop this patch ?

The patches were there, but nothing happened. They do no longer apply (quite
fast actually with other changes), etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:38:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:38:07 +0000
Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims
In-Reply-To: <bug-10429-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10429-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10429-70-PbilecoNEm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
I set back to signedoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:38:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:38:31 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
	default
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-jtARAAbche@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
My solution:

After a record has more than "OPACmaxItemsOnDetail" Items, display only the
items in the users branch, or if that fails, Items arrived in the past 1 year.

Present the filter from bug 11129 to the user when too many items available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:38:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:38:39 +0000
Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims
In-Reply-To: <bug-10429-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10429-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10429-70-GVY3VAiQUr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19839|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:46:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:46:18 +0000
Subject: [Koha-bugs] =?utf-8?q?=5BBug_11147=5D_New=3A__Changes_on_the_?=
 =?utf-8?q?=E2=80=9Cnew_purchase_suggestion=E2=80=9D_page?=
Message-ID: <bug-11147-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11147

            Bug ID: 11147
           Summary: Changes on the ?new purchase suggestion? page
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gbarna at uttyler.edu
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22468
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22468&action=edit
New Purchase Suggestion page

One of our library staff person made the following inquiry. Is anybody
interested in such changes?

"Would it be possible to change things on the ?new purchase suggestion? page in
the catalog?  Here?s what it currently looks like below.  Could the ?Notes? be
changed to ?Reason?.  Notes seems a little ambivalent.  Could we change the
second sentence at the top to start, ?Only the title, author and reason is
required,??   In titles for research, there are titles that are very close if
not identical, especially dealing with critiques.  I?m thinking if the reason
is pleasure reading I can just process and handle.  If it is for class
research, we can refer to the liaison for evaluation."

I have attached the image she submitted to us. 

Thanks,

Geanina King

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 14:59:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 13:59:12 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-1YRicq13Kj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|All items should optionally |All items should optionally
                   |be displayed by default     |be displayed by default in
                   |                            |the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:04:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:04:59 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-sdozvrZFGV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22469
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22469&action=edit
Bug 6385 - All items should optionally be displayed by default in the OPAC

Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which
only results from the
users branch are displayed, or Items from the past year if homebranch cannot be
defined.

This tightly couples with bug 11129 which provides the filtering mechanism to
display smaller result sets.
Also added lots of complexity to define the warning messages based on is the
filter used to override the
"OPACmaxItemsOnDetail".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:09:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:09:44 +0000
Subject: [Koha-bugs] [Bug 11148] New: 2 routines are useless in
	Koha::DateUtils
Message-ID: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

            Bug ID: 11148
           Summary: 2 routines are useless in Koha::DateUtils
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

There are 2 useless routines in the Koha::DateUtils module:output_pref_due and
format_sqlduedatetime. We can call output_pref and format_datetime with
dateonly = 0.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:09:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:09:54 +0000
Subject: [Koha-bugs] [Bug 11148] 2 routines are useless in Koha::DateUtils
In-Reply-To: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11148-70-aVVxcvZPn6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |jonathan.druart at biblibre.co
                   |                            |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:13:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:13:46 +0000
Subject: [Koha-bugs] [Bug 11148] 2 routines are useless in Koha::DateUtils
In-Reply-To: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11148-70-YcmJtwo3AM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22470
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22470&action=edit
Bug 11148: Two routines are useless in Koha::DateUtils

    There are 2 useless routines in the Koha::DateUtils
    module:output_pref_due and format_sqlduedatetime. We can call
    output_pref and format_datetime with dateonly = 0.

    format_sqlduedatetime is only used in one place: opac-reserve.pl

    Test plan:
    1/ Verify on the opac-reserve.pl page that the date is correctly
    displayed for for onloan items (you should use the "specific copy"
    feature).
    2/ Launch prove t/DateUtils.t UT file and verify all UT pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:13:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:13:53 +0000
Subject: [Koha-bugs] [Bug 11148] 2 routines are useless in Koha::DateUtils
In-Reply-To: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11148-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11148-70-4DT6PmHnOf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:21:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:21:05 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-hdLNhWASSv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22469|0                           |1
        is obsolete|                            |

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22471
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22471&action=edit
Bug 6385 - All items should optionally be displayed by default in the OPAC

Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which
only results from the
users branch are displayed, or Items from the past year if homebranch cannot be
defined.

This tightly couples with bug 11129 which provides the filtering mechanism to
display smaller result sets.
Also added lots of complexity to define the warning messages based on is the
filter used to override the
"OPACmaxItemsOnDetail".

Added a new "limit"-filter to C4::Items::GetItemInfo() which adds the
LIMIT-clause to the big SQL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:24:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:24:32 +0000
Subject: [Koha-bugs] [Bug 11149] New: From an existing record: change
 default to key on exact words instead of any words.
Message-ID: <bug-11149-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11149

            Bug ID: 11149
           Summary: From an existing record: change default to key on
                    exact words instead of any words.
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: gbarna at uttyler.edu
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22472
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22472&action=edit
Add order to basket: From an existing record

In Acquisitions, under Add order to basket > From an existing record, one of
our staff members frequently adds records to the basket that are already in the
catalog.  The default in ?From an existing record? is set to a key word
function.  She reported she can type in the title of an item and may get 200
items that she has to scroll through to find the one she needs. She would like
to know if the default can be changed to key on the exact words instead of any
words?

I have attached an image she submitted to us. 

Thanks,

Geanina King

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 15:42:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 14:42:29 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-QCr3UqDt6u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #10 from Paola Rossi <paola.rossi at cineca.it> ---
Rebasing invoices.tt is neeeded.
Against master 3.13.00.032:
Applying: Bug 7288: Allow to display only subscriptions in the invoices table
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
Auto-merging C4/Acquisition.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 7288: Allow to display only subscriptions in the
invoices table

So I pass the patch to failed QA status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:03:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:03:33 +0000
Subject: [Koha-bugs] [Bug 11133] Markup errors in OPAC place hold form HTML
In-Reply-To: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11133-70-MoOzuEf7wz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11133

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:06:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:06:56 +0000
Subject: [Koha-bugs] [Bug 11108] undoing receiving does not appear to work
 (but actually does)
In-Reply-To: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11108-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11108-70-voMI8Viok7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11108

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:13:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:13:27 +0000
Subject: [Koha-bugs] [Bug 10750] Correct capitalization on suggestion form
	in OPAC
In-Reply-To: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10750-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10750-70-y56oi41bCt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10750

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a follow-up to fix the Bootstrap theme.  Thanks,
Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:16:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:16:55 +0000
Subject: [Koha-bugs] [Bug 11090] Bootstrap theme: CSS problem with
 suggestions toolbar links
In-Reply-To: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11090-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11090-70-zIk2q8z71f@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11090

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:43:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:43:40 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-6TnE7Zm4bn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21996|0                           |1
        is obsolete|                            |
  Attachment #22048|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22473
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22473&action=edit
Bug 7288: Allow to display only subscriptions in the invoices table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:43:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:43:46 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-bURsyYkKgd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 16:51:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 15:51:50 +0000
Subject: [Koha-bugs] [Bug 11150] New: Sorting does not respect branch
 filters ( at least not for accession date )
Message-ID: <bug-11150-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11150

            Bug ID: 11150
           Summary: Sorting does not respect branch filters ( at least not
                    for accession date )
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Let us assume LibraryA and LibraryB each have a copy of Book1 and Book2.

LibraryA's copy of Book1 has an acquisition date of 2001, and their copy of
Book2 has an acquisition date of 2010. 

LibraryB's copy of Book1 has an acquisition date of 2013, and their copy of
Book2 has an aquisition date of 2006.

If we do an advanced search which a branch limit for LibraryA, and sorted by
"Acquisition date: newest to oldest", we would expect the results to be
ordered:
1. Book2
2. Book1

However, what we actually get is:
1. Book1
2. Book2

This is because the search is sorting by *all* the acquisition dates, not just
the acquisition dates of LibraryA's holdings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 17:14:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 16:14:52 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-5xd5ecbh44@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

--- Comment #53 from Zeno Tajoli <z.tajoli at cineca.it> ---
The problem is that sequence number engine is blocked (for mysqlism problems).
I think we can that the low level fruit (force 001 = biblionumber and a plugin
to insert it if want to choose) an wait for a futere improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 17:16:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 16:16:45 +0000
Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work
In-Reply-To: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10271-70-tHo1m812Zg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a patch that adds a regression test.  For MARC21,
there is an existing index that this patch fixes: Code-institution.

Thanks, Fridolyn!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 17:23:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 16:23:40 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-c1AoqeP9lD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #11 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #10)
How may we correct the bug ?
Show only item type filter, only if defined on biblio level ?

In the end, librarians can perform filtering into the search query : "histoire
and itype:perio".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 17:32:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 16:32:23 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-7bKO7ujRvV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #10 from Paola Rossi <paola.rossi at cineca.it> ---
Now the patch let a user exclude a subfield $0 (zero) from export, as required.
However, when the tag is repeatable and a biblio has two tags of these, koha
let the user exclude the numeric subfield of the first tag, but not the second
one (case of the subfield $4 in two different 700 of a biblio).
So I pass the patch to "Failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 18:10:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 17:10:42 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-eqsYmo7IlJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Fridolyn, while I think it won't work for our libraries, it's an existing
feature and I will pass it - I just didn't get to finish it last night, because
git bz is a bit broken right now, until it gets updated for the new bugzilla
version.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 18:11:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 17:11:47 +0000
Subject: [Koha-bugs] [Bug 11142] Update Bootstrap theme's place hold form to
 match the new version in prog
In-Reply-To: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11142-70-I1nj0VO8fK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 22474
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22474&action=edit
[PATCH] Bug 11142 - Update Bootstrap theme's place hold form to match the new
version in prog

The update to the prog theme's place hold page (Bug 10836) happened
after the Bootstrap theme's place hold form had already been converted,
so it lags behind. This patch applies the changes made to prog to Bootstrap.

To test, switch to the Bootstrap theme and follow the test plan from Bug
10836:

Place single and multiple holds under various conditions:

- Items which are not available to be place on hold
- With OpacHoldNotes on and off
- With OPACItemHolds on and off
- With OPACAllowHoldDateInFuture on and off
- With IndependentBranches on and off
- With JavaScript disabled

Test setting hold notes, holding specific copies, and setting hold start
dates. When setting a hold start date and hold expiration date, the two
datepickers should work together to prevent invalid date combinations
(dates after today, expiration dates which precede the start date).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 18:12:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 17:12:12 +0000
Subject: [Koha-bugs] [Bug 11142] Update Bootstrap theme's place hold form to
 match the new version in prog
In-Reply-To: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11142-70-UGwrgwnGGQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:43:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:43:35 +0000
Subject: [Koha-bugs] [Bug 11151] New: hold error message wrong if in transit
Message-ID: <bug-11151-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11151

            Bug ID: 11151
           Summary: hold error message wrong if in transit
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 22475
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22475&action=edit
error

If you try to check out and item that is in transit to another branch to fill a
hold the error message says:


"Item 1001 ways to be romantic : (0114972293947) has been waiting for Lloyd
Bonafide (1114911111119) at South Holiday since
Cancel hold
Revert waiting status"


But the item is in transit - not waiting - I don't know what will happen if I
ignore this because I'm in training right now, but I wanted a record of the
fact that error message reads wrong - and probably will cause problems with
transfers.  See attached images.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:43:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:43:54 +0000
Subject: [Koha-bugs] [Bug 11151] hold error message wrong if in transit
In-Reply-To: <bug-11151-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11151-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11151-70-ftY6UkZzjO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11151

--- Comment #1 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22476
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22476&action=edit
item in transit - not waiting

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:50:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:50:14 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-uL0LL566qj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #123 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22477
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22477&action=edit
git-bz testing patch

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:52:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:52:42 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-14B1ktbRQe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21729|0                           |1
        is obsolete|                            |

--- Comment #25 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22478
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22478&action=edit
Bug 9021 - Add SMS via email as an alternative to SMS services via SMS::Send
drivers

Nearly all cellular providers allow a person to send an text message to a
cellular
phone by sending an email to phonenumber at provider. We can leverage this
capability
to add the ability for Koha to send sms messages to patrons without the need to
subscribe to an sms gateway server.

Basic plan:
1. Add a table sms_providers to the db to tell Koha what service providers are
available, and what domain emails should be sent to.
2. Add borrowers.sms_provider_id to tell Koha which mobile service the patron
subscribes to for the number given in smsalertnumber
3. Modify Koha to send an email rather than using SMS::Send if the driver is
set to 'Email'

Test plan:
0) Get a mobile phone
1) Apply the patch
2) Run updatedatabase.pl
3) Set the value of SMSSendDriver to 'Email'
4) Go to the admin page, the "Additional parameters" area should now have the
link "SMS cellular providers"
5) On this page, add some providers. Make sure to add the provider for your own
cellular phone service.

Here are some examples:
Sprint   phonenumber at messaging.sprintpcs.com
Verizon  phonenumber at vtext.com
T-Mobile phonenumber at tmomail.net
AT&T     phonenumber at txt.att.net

Only add the domain part in the 'domain' field. So for Verizon, that would be
'vtext.com'

6) Create an account for yourself, add your SMS number, and select your
provider from the dropdown box directly below it.

7) Enable SMS messaging for Item check-in and Item checkout
8) Check out an item to yourself
9) Run process_message_queue.pl
10) Wait! You should receive a text message shortly, when I tested it, I
received my sms message within the minute.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:53:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:53:10 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-TNn3YqWKcl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22178|0                           |1
        is obsolete|                            |
  Attachment #22179|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22479
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22479&action=edit
[PASSED QA] Bug 11091 - limits in catalog search when creating subscription

When creating a new subscription, you can click on "Search for Bilbio" to
search into catalog.
A popup opens with a text field for search terms and a combo-box to limit
search.
This combo-box uses the syspref AdvancedSearchTypes to know what list of values
display.
The bug is that the code acts has if AdvancedSearchTypes has always one value,
but since Bug 7031, this syspref can have several values (item types,
collection codes and locations).

This patch removes the use of AdvancedSearchTypes syspref and defines search
form with 2 limits : item types and collection codes (from authorised values
CCODE).
One or both of this information can be on biblio. Searching by location seems
to be useless because this information is always on item.
If CCODE authorised value does not exist or is empty, the collection code
filter is not displayed.

Test plan :
- Check CCODE authorised value exists with some values
- Choose a biblio indexed with both itemtype and ccode indexes
- Go to Serials module and click on "New subscription"
- In form, click on "Search for Biblio"
=> The popup "serials/subscription-bib-search.pl" appears with two limits
- Enter a word of biblio title, select its item type and select its collection
code
- Click on "Search"
=> You get the biblio

Signed-off-by: David Noe <drnoe at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
While I am not sure how useful the collection code is for most libraries, where
this
is an item level value, this fixes a broken feature and works as described.
Passes all tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:53:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:53:31 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-Xecb9Ag75G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22480
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22480&action=edit
[PASSED QA] Bug 11091 - perltidy on serials/subscription-bib-search.pl

Signed-off-by: David Noe <drnoe at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:53:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:53:54 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-IHZv59gh4d@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 19:54:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 18:54:06 +0000
Subject: [Koha-bugs] [Bug 9021] Add SMS via email as an alternative to SMS
 services via SMS::Send drivers
In-Reply-To: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9021-70-scsWCQqnWB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 20:00:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 19:00:26 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-bkYi3U3ubR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22477|0                           |1
        is obsolete|                            |

--- Comment #124 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22481
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22481&action=edit
git-bz testing patch

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 20:13:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 19:13:56 +0000
Subject: [Koha-bugs] [Bug 11152] New: transit notes
Message-ID: <bug-11152-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11152

            Bug ID: 11152
           Summary: transit notes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be nice to have a way to put a note on a transfer to explain why
you're transferring the book so when you check it in you see why it was sent to
your library. Now you just see 'not checked out'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 21:46:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 20:46:04 +0000
Subject: [Koha-bugs] [Bug 11153] New: patron without fines permissions can
 forgive on check in
Message-ID: <bug-11153-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11153

            Bug ID: 11153
           Summary: patron without fines permissions can forgive on check
                    in
 Change sponsored?: ---
           Product: Koha
           Version: 3.12
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When checking in if a staff member does not have fines permissions they still
see the 'forgive fines' box on the check in screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 21:51:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 20:51:45 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-ERHXwSLj0c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22481|0                           |1
        is obsolete|                            |

--- Comment #125 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22482
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22482&action=edit
git-bz testing patch

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:12 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-7LMXHsAVhL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22331|0                           |1
        is obsolete|                            |
  Attachment #22332|0                           |1
        is obsolete|                            |
  Attachment #22333|0                           |1
        is obsolete|                            |
  Attachment #22334|0                           |1
        is obsolete|                            |
  Attachment #22335|0                           |1
        is obsolete|                            |
  Attachment #22336|0                           |1
        is obsolete|                            |
  Attachment #22337|0                           |1
        is obsolete|                            |
  Attachment #22338|0                           |1
        is obsolete|                            |
  Attachment #22339|0                           |1
        is obsolete|                            |
  Attachment #22340|0                           |1
        is obsolete|                            |
  Attachment #22341|0                           |1
        is obsolete|                            |

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22483
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22483&action=edit
[PASSED QA] Bug 10671: Add missing patron lists help

To test go to Tools > Patron Lists and click 'Help'.
Confirm that the help is there and without typos.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Help present. No typos

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Help file shows on correct page, no typos found.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:28 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-vUL4RiSZCZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22484
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22484&action=edit
[PASSED QA] Bug 10671: Update Authorities Help

To Test go to all authorities pages and click 'Help'.
Confirm that text appears and links work.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Auth help works.
Note: authorities-home.tt and detail.tt have same content.
It's right?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:34 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-CEia3OjzJ3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22485
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22485&action=edit
[PASSED QA] Bug 10671: Update links in Catalog help

To test search the catalog and click results
Test al of the links to the manual and make sure they
go to the 3.14 manual.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All links Ok

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:40 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-qBVmHIg0lL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22486
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22486&action=edit
[PASSED QA] Bug 10671: Update main help files

This patch updates help files that aren't in any other folder.

To test:

* Visit the main staff page and review the help
* Visit the About page and review the help
* Visit a page without help (which there better not be) and
  review the link to the manual

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

All links works.
For a page without help, in detailed view of a record, select MARC or ISBD
tabs,
no help but good link.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:44 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-cWlCbZOC7u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22487
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22487&action=edit
[PASSED QA] Bug 10671: Update Lists Help

To test go to Lists in the staff client and click help
Confirm that the link goes to the right manual

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Good link on shelves help

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:50 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-6uP3lszcOx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22488
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22488&action=edit
[PASSED QA] Bug 10671: Add missing authority merge help

Test after 10/23 (when the manual link will work)
Visit authorities
Start a merge
Click help on during the merge process
Be sure that help is there and link works.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

There is help and link works

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:01:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:01:55 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-CW2TPi1eic@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22489
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22489&action=edit
[PASSED QA] Bug 10671: Update links in label help

This patch updates the links in the label help
to point to the 3.14 manual.

To test:

Visit all label pages and click the help link
confirm that the manual links goes to the right place

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Correct links

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:02:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:02:02 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-OQlSV4LJhH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22490
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22490&action=edit
[PASSED QA] Bug 10671: Update patron card creator help

Update manual links in the patron card help file.

To test:
* visit all patron card creator pages and click 'help'
* confirm that the link to the manual goes to 3.14

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
All links correct

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:02:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:02:16 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-lZm0Pl8rIi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22491
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22491&action=edit
[PASSED QA] Bug 10671: Update tag tool help

This patch updates the links to the manual in the
help files on tags.

To test:

* Visit the tag moderation tool
* Click the help link
* Confirm that the links to the manual are right

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Links correct

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:02:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:02:22 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-2ik4qUuif1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22492
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22492&action=edit
[PASSED QA] Bug 10671: Update plugins help

To test visit the plugin pages and confirm that the links
to the manual are right.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Links correct

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:02:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:02:27 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-OYp2qpei0h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22493
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22493&action=edit
[PASSED QA] Bug 10671: Update suggestion help

To test visit the suggestion management pages
and confirm that the link in the help file goes
to the right manual.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Link Ok

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:32:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:32:15 +0000
Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request
 management by branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-Q2ZHJMmXQP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |sandboxes at biblibre.com

--- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:32:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:32:29 +0000
Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request
 management by branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-2yfbfJQ12a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21950|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:32:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:32:35 +0000
Subject: [Koha-bugs] [Bug 10904] would like to limit patron update request
 management by branch
In-Reply-To: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10904-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10904-70-u7D3fmqeYV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 22494
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22494&action=edit
Bug 10904 - would like to limit patron update request management by branch

By not limiting the patron modification lists by branch, it can quickly
become overwhelming for a librarian. This patch makes the following
modifications:

* Only superlibrians will see the full list of borrowers with pending
  modifications.
* Adds the patron cardnumber after the patrons name on the modification
  list.
* Adds a link to the patron's record from the modification list.

Test Plan:
1) Apply this patch
2) Set up some pending modifications for two branches
3) Log in to the staff intranet as one of those branches
4) You should note the number of pending modifications counts
   only your logged in branch's patrons
5) Click the link, you should only see your logged in branches
   patrons in the pending modifications list.
6) You should note the cardnumber is displayed next to the patron name
7) You should note the "View record" link below each patron's name

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:33:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:33:23 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-edCLUwCm5R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22420|0                           |1
        is obsolete|                            |
  Attachment #22421|0                           |1
        is obsolete|                            |
  Attachment #22422|0                           |1
        is obsolete|                            |
  Attachment #22423|0                           |1
        is obsolete|                            |
  Attachment #22424|0                           |1
        is obsolete|                            |
  Attachment #22425|0                           |1
        is obsolete|                            |
  Attachment #22493|0                           |1
        is obsolete|                            |

--- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22495
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22495&action=edit
[PASSED QA] Bug 10671: Update suggestion help

To test visit the suggestion management pages
and confirm that the link in the help file goes
to the right manual.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>

Link Ok

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:15 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-INyIM897QA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:20 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-JmdQLYGkkr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22482|0                           |1
        is obsolete|                            |

--- Comment #126 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22496
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22496&action=edit
git-bz testing patch

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:30 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-3jRtSuWDwH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22497
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22497&action=edit
[PASSED QA] Bug 10671: Update Offline Circ Help

This patch updates the offline circulation help files.

To test:

Visit the KOC file upload and pending transactions page
Review the help and check the links

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:35 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-8SnFTGr1vo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22498
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22498&action=edit
[PASSED QA] Bug 10671: Remove Unused Help File

This patch removes an unused help file in the help/export
folder.

To test:

Just confirm that the file is removed, there were no links
to it anymore.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
A corresponding page in Koha doesn't seem to exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:39 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-nsVrL29CWc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22499
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22499&action=edit
[PASSED QA] Bug 10671: Update Reviews Help

This patch updates the link to the manual in the comments
moderation help.

To test:

* Visit comments moderation
* Click the help link
* Confirm manual link works

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:43 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-FohQ5sIFLa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #66 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22500
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22500&action=edit
[PASSED QA] Bug 10671: Update holds help

This patch updates the manual link in the holds help
file.

To test:

* Place a hold in the staff client
* Click the help link
* Confirm manual link works

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:34:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:34:48 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-ZG99N2SRpp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #67 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22501
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22501&action=edit
[PASSED QA] Bug 10671: Update Reports Help

Update all of the reports related help files.

To test:

* Visit report pages and confirm that text and links
are right.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:35:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:35:51 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-7gTsaOO9Mr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:43:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:43:00 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-VIPOmJhDWn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, Jonathan, you are right, the tests are failing for me too. I must have
missed it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:43:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:43:27 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-AIgdmrWkCc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:43:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:43:32 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-ifnz86j5x0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22496|0                           |1
        is obsolete|                            |

--- Comment #127 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22502
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22502&action=edit
git-bz testing patch

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:45:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:45:38 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-riA1aLm7ow@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED
   Patch complexity|Small patch                 |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 22:45:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 21:45:43 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-Fh8DVKrw5J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22502|0                           |1
        is obsolete|                            |

--- Comment #128 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22503
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22503&action=edit
git-bz testing patch

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:01:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:01:04 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-2W4dZ8JQ9Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:01:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:01:09 +0000
Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work
In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8854-70-DSwBNV642Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22442|0                           |1
        is obsolete|                            |

--- Comment #19 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22504
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22504&action=edit
bug 8854: fix some invoice search filters

Fix the supplier, shipment date, and library filters
on the invoice search.  An invoice's library is
(in parallel with order search) defined as the library
of the staff member that approved the basket.  Before this
patch, the code was referring to an aqorders.branchcode
column that doesn't exist.

This patch also improves the author, title, ISBN/EAN/ISSN,
publisher, and publication year filters to no longer require
exact matches; substring matches now suffice.

Finally, this patch considers biblio.copyrightdate in addition
to biblioitems.publicationyear for publication date searches, as
the MARC21 frameworks use the former column but not the latter.

This patch also fixes the current test cases for invoices
so that they pass and adds regression tests.

Test plan:

[1] Create two invoices for different vendors.
[2] Do an invoice search and filter on shipment
    date.  Verify that the expected invoice(s)
    are returned.
[3] Do an invoice search and filter on branch
    (of the staff member that approved the basket).
    Verify that the expected invoice(s) are returned.
[4] Do an invoice search and filter on supplier.
    Verify that the expected invoice(s) are returned.
[5] Do invoice searches on author, title, ISBN/EAN/ISSN,
    publisher, and publication year and verify that the
    results are as expected.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:12 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-ZCP3BTPXTe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:17 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-78r1Zf4jj2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22466|0                           |1
        is obsolete|                            |

--- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 22505
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22505&action=edit
[SIGNED OFF] Bug 6149: Follow-up - Stopwords for Result Highlighting
(Bootstrap)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Adds fix to the Bootstrap OPAC theme, works nicely.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:21 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-77skVMrwaJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #68 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed all of the pending ones to master.  Thanks, Nicole!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:25 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-MGWEixIghH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22497|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:28 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-dI5XWRWN8y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22498|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:32 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-kBdEHyW5rF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22499|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:35 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-6r6Lb5kDB0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22500|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:39 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-HIwygt5Ghx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22501|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:43 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-LyKtznD3iS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22483|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:46 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-HdyOhdjq6c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22484|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:50 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-lPo2tcrbCs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22485|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:54 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-C0MfvydcYM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22486|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:07:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:07:57 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-eiYPQ6Ei2H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22487|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:08:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:08:01 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-5a6erlXttQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22488|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:08:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:08:06 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-dtIKJN60jd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22489|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:08:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:08:10 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-Qdndbw5Wu6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22490|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:08:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:08:13 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-OJw88qvB9M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22491|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:08:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:08:16 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-ZyG15M87uS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22492|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:08:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:08:20 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-Lmj1MFVXvt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22495|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Oct 28 23:16:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 28 Oct 2013 22:16:09 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-2r0SOEvmzk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz

--- Comment #9 from Robin Sheat <robin at catalyst.net.nz> ---
Oh good, I've been meaning to do this for a while.

A few comments:
* it creates /var/lock/koha_rebuild_zebra_databasename/lock, why not
/var/lock/koha/rebuild_zebra_databasename? That way if we add more locking
stuff, it will all be under the 'koha' directory.
* it doesn't look like it handles lockdir not being set in the config very
nicely, it should probably default to /var/lock if the config setting isn't
available, otherwise it seems it would try to create a directory under '/'.
* it doesn't set up the lockdir config for package installations, this would be
a very simple matter of adding <lockdir>/var/lock</lockdir> in
debian/templates/koha-conf-site.xml.in. It's OK to hard-code the value in there
because it'll always be the same.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 03:19:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 02:19:23 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-XCKAVMxBd3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #10 from Doug Kingston <dpk at randomnotes.org> ---
(In reply to Robin Sheat from comment #9)
> Oh good, I've been meaning to do this for a while.
> 
> A few comments:
> * it creates /var/lock/koha_rebuild_zebra_databasename/lock, why not
> /var/lock/koha/rebuild_zebra_databasename? That way if we add more locking
> stuff, it will all be under the 'koha' directory.
The existing koha scripts that create koha instances call
  install -d -o $kohauser -g $kohauser /var/lock/koha/$kohasite
When invoked this way, only the last directory in this path is owned
by the user and the intervening directories are owned by root. 
rebuild_zebra.pl
is run as $kohauser so it cannot create another directory under /var/lock/koha.

> * it doesn't look like it handles lockdir not being set in the config very
> nicely, it should probably default to /var/lock if the config setting isn't
> available, otherwise it seems it would try to create a directory under '/'.
My changes make sure this is set for proper installs (see the change to
rewrite-config.pl, but I am happy to put in a fallback if QA team wants it.
This level of protection is not present for other config variables.
Lots of other things will go pear-shaped if their definition is missing.

> * it doesn't set up the lockdir config for package installations, this would
> be a very simple matter of adding <lockdir>/var/lock</lockdir> in
> debian/templates/koha-conf-site.xml.in. It's OK to hard-code the value in
> there because it'll always be the same.
Thanks for the pointer, I did not know about that template.  This is just what
code reviews are for.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 03:23:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 02:23:06 +0000
Subject: [Koha-bugs] [Bug 11154] New: collapsable results
Message-ID: <bug-11154-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11154

            Bug ID: 11154
           Summary: collapsable results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

It would be nice if in the OPAC search results you could collapse the results
so that you only saw the title/author if you click 'collapse all' - it's a way
to limit what you see on the results if you just want some basic info.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 03:25:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 02:25:26 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-5rDYvPrbKk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #11 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22506
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22506&action=edit
Bug 11078 Add locking to rebuild_zebra (QA patch 10/28)

Updates the debian configuration template as mentioned in the comments.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 03:37:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 02:37:07 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-cHNBzuU0F8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #12 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Doug Kingston from comment #10)
> The existing koha scripts that create koha instances call
>   install -d -o $kohauser -g $kohauser /var/lock/koha/$kohasite
> When invoked this way, only the last directory in this path is owned
> by the user and the intervening directories are owned by root. 
> rebuild_zebra.pl
> is run as $kohauser so it cannot create another directory under
> /var/lock/koha.

Yeah, I just checked and found that. In that case, it might be best to use that
pattern? If it's only applicable to a package installation, it is something we
could put in just for that case without too much difficulty.

> My changes make sure this is set for proper installs (see the change to
> rewrite-config.pl, but I am happy to put in a fallback if QA team wants it.
> This level of protection is not present for other config variables.
> Lots of other things will go pear-shaped if their definition is missing.

Your changes only apply to _new_ installs. Anyone with a pre-existing
installation who doesn't update their koha-conf.xml will have problems. This
will be most people.

> Thanks for the pointer, I did not know about that template.  This is just
> what code reviews are for.

No problem :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 04:54:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 03:54:27 +0000
Subject: [Koha-bugs] [Bug 11155] New: PostgreSQL schema contains syntax
	errors
Message-ID: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155

            Bug ID: 11155
           Summary: PostgreSQL schema contains syntax errors
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: dan at coffeecode.net
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22507
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22507&action=edit
Fixes syntax errors in PostgreSQL db schema

installer/data/Pg/kohastructure.sql contains two syntax errors:

* "mediumtext" is not a valid data type for PostgreSQL
* "branch_transfer_limits_pkey" defines the primary key twice, which causes an
error for PostgreSQL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 05:12:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 04:12:23 +0000
Subject: [Koha-bugs] [Bug 11156] New: check-url.pl is not utf friendly
Message-ID: <bug-11156-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156

            Bug ID: 11156
           Summary: check-url.pl is not utf friendly
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: gmcharlt at gmail.com
          Reporter: srdjan at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org

Wide character in print at /usr/share/koha/bin/cronjobs/check-url.pl line 215

The easiest way to quiet this warning is simply to add the :utf8 layer to the
output, e.g. binmode STDOUT, ':utf8'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 07:16:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 06:16:03 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-F6el24xn9Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #13 from Doug Kingston <dpk at randomnotes.org> ---
(In reply to Robin Sheat from comment #12)
> (In reply to Doug Kingston from comment #10)
> > The existing koha scripts that create koha instances call
> >   install -d -o $kohauser -g $kohauser /var/lock/koha/$kohasite
> > When invoked this way, only the last directory in this path is owned
> > by the user and the intervening directories are owned by root. 
> > rebuild_zebra.pl
> > is run as $kohauser so it cannot create another directory under
> > /var/lock/koha.
> 
> Yeah, I just checked and found that. In that case, it might be best to use
> that pattern? If it's only applicable to a package installation, it is
> something we could put in just for that case without too much difficulty.
I don't think we can use that pattern because it relies on running as root.  I
think the best solution here is to have each instance create its own directory
under /var/lock which is guaranteed to be in mode 1777 (with the t bit set).
Since /var/lock is often on tmpfs its gone after a reboot and we can't rely in
a subdirectory maintained.  I think this is now in the safest, most maintable
state.

> 
> > My changes make sure this is set for proper installs (see the change to
> > rewrite-config.pl, but I am happy to put in a fallback if QA team wants it.
> > This level of protection is not present for other config variables.
> > Lots of other things will go pear-shaped if their definition is missing.
> 
> Your changes only apply to _new_ installs. Anyone with a pre-existing
> installation who doesn't update their koha-conf.xml will have problems. This
> will be most people.
Fair enough, I'll update it to use /var/lock if the lockdir variable is not
defined.

> 
> > Thanks for the pointer, I did not know about that template.  This is just
> > what code reviews are for.
> 
> No problem :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 07:35:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 06:35:15 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-Sqs2aztkEw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #14 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22508
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22508&action=edit
Bug 11078 Add locking to rebuild_zebra (QA Patch 2 10/28)

In the event lockdir is not specified in the koha-conf.xml file
which will occur for old installations, default the lockdir to a
sensible default (/var/lock).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 08:46:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 07:46:46 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-tXpYVZnfHb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |6385
         Depends on|6385                        |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 08:46:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 07:46:46 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-j7pOhXUG3C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11129                       |
         Depends on|                            |11129

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 08:59:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 07:59:56 +0000
Subject: [Koha-bugs] [Bug 11091] limits in catalog search when creating
	subscription
In-Reply-To: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11091-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11091-70-SSGBM4rTCY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11091

--- Comment #15 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Katrin Fischer from comment #12)
> Hi Fridolyn, while I think it won't work for our libraries, it's an existing feature and I will pass it
Ok, thanks a lot.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 09:04:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 08:04:07 +0000
Subject: [Koha-bugs] [Bug 11157] New: Placing a simple item-level hold for
	serials.
Message-ID: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

            Bug ID: 11157
           Summary: Placing a simple item-level hold for serials.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Our patrons want to place holds on a serial item.
This is problematic when we have thousands of serial items in our DB.
The traditional opac-reserve.pl/.tt way of placing a item-level hold is
impossible.
Extending opac-reserve.pl/.tt to accept a itemnumber as a parameter to display
and preselect only the desired item, without ever SELECTing all the
items+biblios+bibitems unnecessarily.

Also important to disable the default "Place hold"-mechanism for serial records
and replace it with "Place hold" for each serial item so a item-level hold can
be initiated straight from the items-display table in opac-detail.tt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 09:04:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 08:04:43 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-qx4IMljnsY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11129

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 09:04:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 08:04:43 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-hDe3SQatRA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11157

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 09:06:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 08:06:00 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-y81bK3o9bV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 09:27:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 08:27:28 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-zlunzWSm8c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22509
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22509&action=edit
Bug 11157 - Placing a simple item-level hold for serials.

For biblios marked as a serial.
Adds a "Place hold"-link after each item in the opac-detail.tt holdings-tab.
Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc.

Added a new parameter itemnumber to opac-reserve.pl/.tt.
This causes the opac-reserve.tt to display only the desired item, preselect it
and hide unnecessary radio buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 09:59:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 08:59:45 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-teW2Ll6uq5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22471|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22510
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22510&action=edit
Bug 6385 - All items should optionally be displayed by default in the OPAC

Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which
only results from the
users branch are displayed, or Items from the past year if homebranch cannot be
defined.

This tightly couples with bug 11129 which provides the filtering mechanism to
display smaller result sets.
Also added lots of complexity to define the warning messages based on is the
filter used to override the
"OPACmaxItemsOnDetail".

Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the
LIMIT-clause to the big SQL.
Added a unit test for the filter to the Items.t

Fixed a use-case where a user has no items in his branch, and the limited items
set is emtpy.
Now using items from past year if none available in the users branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:00:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:00:53 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-8KfmfoMcu7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #35 from Jonathan Druart <jonathan.druart at biblibre.com> ---
QA comment:
The highlight does not work at all on the detail page with the bootstrap theme
(caused by a JS error: q_array[x] = q_array[x]toLowerCase();).

I think the change should be done in the opac-results-grouped template file
too.
Maybe should you include this function into a js file in order to avoid a
duplication of code.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:04:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:04:21 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-3XFma4ZSmG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, it worked for me yesterday - but i was not using the grouped
template and was not aware it's currently used.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:07:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:07:59 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-dAF94r8stt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #37 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #36)
> Hi Jonathan, it worked for me yesterday - but i was not using the grouped
> template and was not aware it's currently used.

The opac-detail cannot work, a dot is missing in the JS code:
  +                q_array[x] = q_array[x]toLowerCase();

The template seems to be used if the pref OpacGroupResults is enabled.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:13:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:13:48 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-WPF3qgSfM6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #38 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Ah you are right - I forgot to test the highlighting on the detail page :( Just
tested results - thx Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:14:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:14:38 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-RpjYrsQuEk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Pants, there's always a typo.. I must have been in ccsr instead of bootstrap. 
Now I feel silly!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:21:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:21:33 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-dxRwCF1iUA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22505|0                           |1
        is obsolete|                            |

--- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 22511
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22511&action=edit
Bug 6149: Follow-up - Stopwords for Result Highlighting (Bootstrap)

QA Followup to fix the stupid typo... ack, double checked it this time!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 10:30:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 09:30:17 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-kgh1FGATw3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22509|0                           |1
        is obsolete|                            |

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22512
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22512&action=edit
Bug 11157 - Placing a simple item-level hold for serials.

For biblios marked as a serial.
Adds a "Place hold"-link after each item in the opac-detail.tt holdings-tab.
Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc.

Added a new parameter itemnumber to opac-reserve.pl/.tt.
This causes the opac-reserve.tt to display only the desired item, preselect it
and hide unnecessary radio buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:21:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:21:18 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-cxycIbshbW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22464|0                           |1
        is obsolete|                            |

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22513
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22513&action=edit
Bug 11129 - Filtering Items based on type in opac-detail.pl

Currently all Items are always shown on the opac-detail.pl. This is difficult
when the amount of Items grows substantially large.
Implemented a filter to limit the Items shown (and SELECTed from the DB) based
on some typical filters,
  locationbranch, volume, number, issue, fromDate, toDate.
Also streamlined how Serials-data is pulled from the DB to prevent substantial
extra work in C4::Items::GetItemsInfo().
C4::Items::GetItemsInfo() extended to support various filters.

All modifications:
Item filter shown when there are over 50 items (lotsofitems-flag).
Filter fields can be changed based on the Biblio type (isSerial-flag).
-Volume + Issue + Number available only for serials.
Can syspref if Issue-field is used in serial records.
Can syspref a regexp to parse the Volume + Number + Issue from the enumeration
or chronology field.
FromDate and ToDate filter the serial.publisheddate when dealing with serials
otherwise target the items.timestamp -column.
C4::Items::GetItemsInfo() simplified to include the serial data in the BIG SQL.
This makes filtering by publisheddate much more faster.

User input validated using HTML5 <input "number">
Business layer validations as well.

Unit tests:
Serials enumeration and chronology filtering
Items date and branch filtering

Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:21:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:21:38 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-r68wt1txj3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22510|0                           |1
        is obsolete|                            |

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22514
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22514&action=edit
Bug 6385 - All items should optionally be displayed by default in the OPAC

Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which
only results from the
users branch are displayed, or Items from the past year if homebranch cannot be
defined.

This tightly couples with bug 11129 which provides the filtering mechanism to
display smaller result sets.
Also added lots of complexity to define the warning messages based on is the
filter used to override the
"OPACmaxItemsOnDetail".

Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the
LIMIT-clause to the big SQL.
Added a unit test for the filter to the Items.t

Fixed a use-case where a user has no items in his branch, and the limited items
set is emtpy.
Now using items from past year if none available in the users branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:21:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:21:59 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-kj7qILbDjf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22512|0                           |1
        is obsolete|                            |

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22515
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22515&action=edit
Bug 11157 - Placing a simple item-level hold for serials.

For biblios marked as a serial.
Adds a "Place hold"-link after each item in the opac-detail.tt holdings-tab.
Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc.

Added a new parameter itemnumber to opac-reserve.pl/.tt.
This causes the opac-reserve.tt to display only the desired item, preselect it
and hide unnecessary radio buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:31:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:31:41 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-q3adTLacW4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:32:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:32:29 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-zUbLn5PaUz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:33:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:33:58 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-ZkzMiBk2yj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
My solution is a simple dirty hack which works on the existing opac-reserve.pl.
A better solution should be formulated. Ideas about how to implement them are
welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 11:34:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 10:34:08 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-fJuq4YHpqu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 12:21:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 11:21:58 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials in OPAC.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-6EyjPDhMHv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Placing a simple item-level |Placing a simple item-level
                   |hold for serials.           |hold for serials in OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 12:22:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 11:22:27 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-Xxkfp2VisU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Placing a simple item-level |Placing a simple item-level
                   |hold for serials in OPAC.   |hold for serials.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 12:24:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 11:24:01 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-La0luWRh6w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22473|0                           |1
        is obsolete|                            |

--- Comment #12 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 22516
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22516&action=edit
Invoice improvements - Show only subscriptions

The subscription's invoice is linked to a subscription by adding an order from
an already existent subscription.
I sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 12:24:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 11:24:42 +0000
Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only
	subscriptions
In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7288-70-EqDcwb1mVp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 13:40:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 12:40:16 +0000
Subject: [Koha-bugs] [Bug 11158] New: Authorities 'starts with' search
 returns the same as 'contains' when using ICU
Message-ID: <bug-11158-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

            Bug ID: 11158
           Summary: Authorities 'starts with'  search returns the same as
                    'contains' when using ICU
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: colin.campbell at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

If set up to use icu tokenisation
When doing an authorities search and specifying 'starts with' the result set
returned is the same as with the option 'contains'

For example a search on starts_with 'Smith' returns

Campbell-Smith, Duncan.
Smith, Bessie, 1894-1937.
Smith, Sydney Goodsir, 1915-1975.
Smith, Victoria. 

The problem appears be that the starts-with definition is being applied to each
token within the heading rather than to the heading as complete field

(A search for O hoping to retrieve O'Brian will return much more )

the correct return would be

Smith, Bessie, 1894-1937.
Smith, Sydney Goodsir, 1915-1975.
Smith, Victoria.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 13:55:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 12:55:13 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-9q2ZPMwn7L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22517
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22517&action=edit
Proposed patch

This change appears to fix the problem. At the same time it does not appear to
break the behaviour with 'chr' To test on a system set up to use ICU find a
test case similar to that in the bug description. Apply the patch and redo the
'starts with' search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:00:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:00:11 +0000
Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns
 the same as 'contains' when using ICU
In-Reply-To: <bug-11158-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11158-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11158-70-08TH4rpyHB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
There is also a question over the rule being used to tokenise phrase searches
and what would be the best default configuration (including no rule) further
investigation is dependent on bug 10729 as phrase and keyword searching have
different requirements in this respect

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:09:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:09:51 +0000
Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack
In-Reply-To: <bug-8970-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8970-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8970-70-EToyZrGPfH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Retested now on 3.10.7 and Plack v1.0023 and Starman v0.3011
I don't reproduced...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:17:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:17:04 +0000
Subject: [Koha-bugs] [Bug 11159] New: Small typo in catalogue/results.tt
Message-ID: <bug-11159-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159

            Bug ID: 11159
           Summary: Small typo in catalogue/results.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Searching
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In catalogue/results.tt, there is a small HTML error line 377 :
[% ELSE %]<option value"au,phr">Author</option>[% END %]
The = is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:22:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:22:40 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-MdPtj2TIWi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

--- Comment #11 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Actually irrespective of this patch testing reveals if you specify a subfield
then it only gets stripped from the first occurence. Looks like the existing
functionality was in need of fixing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:24:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:24:01 +0000
Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt
In-Reply-To: <bug-11159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11159-70-PjoG3xfQKJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22518&action=edit
Bug 11159 - Small typo in catalogue/results.tt

See commit message.
One-line trivial patch ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:24:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:24:13 +0000
Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt
In-Reply-To: <bug-11159-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11159-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11159-70-uZjfnPIgTU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:32:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:32:23 +0000
Subject: [Koha-bugs] [Bug 6149] Operator Highlighted in Search Results
In-Reply-To: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6149-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6149-70-nokN0u4Cyt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6149

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 14:33:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 13:33:08 +0000
Subject: [Koha-bugs] [Bug 10726] Default Unimarc framework in accordance
 with new edition of the Unimarc manual
In-Reply-To: <bug-10726-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10726-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10726-70-jjCRwI7z5j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726

--- Comment #10 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 22519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22519&action=edit
Bug 10726 - Followup : missing subfields in previous specifications edition

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:01:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:01:06 +0000
Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM
	indexing for bib
In-Reply-To: <bug-8507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8507-70-TAUtMxIx5i@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:01:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:01:25 +0000
Subject: [Koha-bugs] [Bug 8507] koha-create should be updated to use DOM
	indexing for bib
In-Reply-To: <bug-8507-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8507-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8507-70-QXZbH28BdG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8507

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:02:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:02:37 +0000
Subject: [Koha-bugs] [Bug 10802] history.txt missing in packages
In-Reply-To: <bug-10802-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10802-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10802-70-J5p1HL9IVz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10802

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.6.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:05:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:05:29 +0000
Subject: [Koha-bugs] [Bug 10770] reserve slip don't print correctly
In-Reply-To: <bug-10770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10770-70-jxqsy8SrGi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10770

Rafal <rkk0 at poczta.onet.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rkk0 at poczta.onet.pl

--- Comment #1 from Rafal <rkk0 at poczta.onet.pl> ---
Created attachment 22520
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22520&action=edit
0001-Bug-10770-reserve-slip-don-t-print-correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:07:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:07:04 +0000
Subject: [Koha-bugs] [Bug 10770] reserve slip don't print correctly
In-Reply-To: <bug-10770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10770-70-14ZSWid9Bz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10770

--- Comment #2 from Rafal <rkk0 at poczta.onet.pl> ---
First print don't work for reserve on first available copy, beacuse information
about reserve is retrieved before reserve update. 
Here is my patch proposition. 


Test plan:
1. Place new hold on next available copy.
2. Check in any item from this hold biblio.
3. Click Print and confirm.
4. There shuld be missing itemcallnumber and barcode info.
5. Check in and print again and all informations are ok.
6. Delete hold.
7. Apply patch.
8. Repat 1-3, now at print slip there shuld be barcode and itemnumber
after first print.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:07:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:07:51 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-nKp3TiaUdn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Extended the functionality to the staff client.
Added sysprefs (again!) to control placing a item-level hold from the
detail.pl/.tt view and from the OPAC opac-detail.pl/.tt.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:13:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:13:08 +0000
Subject: [Koha-bugs] [Bug 9216] Add a file for table headings translation
 and copy of this file during the translation process
In-Reply-To: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9216-70-ZPFHdXTCbO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:13:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:13:11 +0000
Subject: [Koha-bugs] [Bug 9216] Add a file for table headings translation
 and copy of this file during the translation process
In-Reply-To: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9216-70-fyq3vUcd8M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13895|0                           |1
        is obsolete|                            |
  Attachment #13896|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22521
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22521&action=edit
Bug 9216: columns.def file is not translatable

The sql column headers is stored into the columns.def file.
This file is not managed by the translation script.

This patch makes possible the headers translation.
Note: The translation xml tags were added to avoid all lines to be put
on a single line.

Test plan:
1/ update your po file
cd misc/translate;
perl translate -f columns update LANG # Replace by another language here
2/ translate header columns (search "columns.def" in your po file).
Be careful, you have to keep the column names!
3/ install the translated columns.def
perl translate -f columns install LANG # Replace by another language here
4/ go on the report module > create a new report > next > next
5/ change the language
on the 3rd step, you should see the column header translated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:13:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:13:43 +0000
Subject: [Koha-bugs] [Bug 9216] Add a file for table headings translation
 and copy of this file during the translation process
In-Reply-To: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9216-70-Baf51aLQLF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:15:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:15:18 +0000
Subject: [Koha-bugs] [Bug 9216] Add a file for table headings translation
 and copy of this file during the translation process
In-Reply-To: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9216-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9216-70-4dOsvcIbWc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9216

--- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #3)
> Would it not be better to fold columns.def into the normal translation
> process, i.e., so that translators can supply or update a PO file for which
> language-specific columns.def.lang files can be generated?

It is what I do in this last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 15:56:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 14:56:55 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-DYtsEgQuRP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22515|0                           |1
        is obsolete|                            |

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22522
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22522&action=edit
Bug 11157 - Placing a simple item-level hold for serials.

For biblios marked as a serial or if the sysprefs:
-OPACShowPlaceItemLevelHold or
-ShowPlaceItemLevelHold
are enabled.
Adds a "Place hold"-link after each item in the detailed biblio view.

Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc for serials.

Added a new parameter itemnumber to opac-reserve.pl/.tt and reserve.pl/.tt.
This causes the reserving module to display only the desired item, preselect it
and hide unnecessary buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:03:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:03:05 +0000
Subject: [Koha-bugs] [Bug 11160] New: Better message when placing hold at
	OPAC is blocked
Message-ID: <bug-11160-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160

            Bug ID: 11160
           Summary: Better message when placing hold at OPAC is blocked
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When an OPAC user is in a category where placing hold is blocked on all
itemtypes and all libraries, the actual message when placing hold will be :
"Sorry, none of these items can be placed on hold."
It would be better to tell the user he can not place hold.
And even not show the hold links and icons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:11:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:11:04 +0000
Subject: [Koha-bugs] [Bug 11161] New: relabel child fund to 'sub fund'
Message-ID: <bug-11161-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

            Bug ID: 11161
           Summary: relabel child fund to 'sub fund'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Child fund is confusing in the US and we would like to see 'sub fund' since
that's what we'd call it here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:13:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:13:03 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-CALUAf5Rnp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |6385

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:13:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:13:03 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-zJfWgPT0RE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11157

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:21:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:21:26 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-Ig3ZxNKOz7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|10993                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:21:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:21:26 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-ENCqfoQj4z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|11020                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:21:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:21:54 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-5QAo6jxyni@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10993

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:21:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:21:54 +0000
Subject: [Koha-bugs] [Bug 10993] Transfer limits should be checked when
 placing a hold/reservation in OPAC.
In-Reply-To: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10993-70-rHCWJO3t1e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11020

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:25:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:25:33 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-6pBCvGa9Te@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|11005                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:25:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:25:33 +0000
Subject: [Koha-bugs] [Bug 11005] Centralize the
 UseBranchTransferLimits-check under one function
In-Reply-To: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11005-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11005-70-C3LpEzLHOH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11005

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|7376, 11020, 11024          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:25:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:25:33 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-ik7H4CxT69@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|11005                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:25:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:25:33 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-wbByhWiDMu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|11005                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:26:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:26:05 +0000
Subject: [Koha-bugs] [Bug 11020] Transfer limits should be checked when
 placing a hold/reservation in Staff client
In-Reply-To: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11020-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11020-70-yxRL157lFx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11020

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|7376                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:26:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:26:05 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-r3UGBuILMo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|11020                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:26:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:26:23 +0000
Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the
 build_holds_queue.pl -script.
In-Reply-To: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11024-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11024-70-sDKW7XY4Fu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7376

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:26:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:26:23 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7376-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7376-70-Ty0TQcdV79@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11024

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:33:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:33:04 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-pobLQM74l8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|11129                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:33:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:33:04 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-9TmdmpvPaS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|11157                       |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:36:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:36:54 +0000
Subject: [Koha-bugs] [Bug 11160] Better message when placing hold at OPAC is
	blocked
In-Reply-To: <bug-11160-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11160-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11160-70-SqYQMntzhm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11160

Koha Team AMU <koha.aixmarseille at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.aixmarseille at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:41:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:41:38 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
 that profile marcfields are required
In-Reply-To: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5031-70-tirAml4fcM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031

--- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #8)
> Hi Jonathan,
> 
> moving on from bug 10853 to this one. The highlighting of the required
> fields is a good addition, but the formatting seems a bit non-standard. 
> Maybe check Owen's work on bug 6209?

Katrin, what do you consider as non-standard?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:45:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:45:22 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-YRuY6kgH7K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22522|0                           |1
        is obsolete|                            |

--- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22523
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22523&action=edit
Bug 11157 - Placing a simple item-level hold for serials.

For biblios marked as a serial or if the sysprefs:
-OPACShowPlaceItemLevelHold or
-ShowPlaceItemLevelHold
are enabled.
Adds a "Place hold"-link after each item in the detailed biblio view.

Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc for serials.

Added a new parameter itemnumber to opac-reserve.pl/.tt and reserve.pl/.tt.
This causes the reserving module to display only the desired item, preselect it
and hide unnecessary buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:46:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:46:35 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
 that profile marcfields are required
In-Reply-To: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5031-70-D5kvNHAAdk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It looks really nice, but not like in other places of Koha :) But maybe Owen
could take a look later?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:50:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:50:09 +0000
Subject: [Koha-bugs] [Bug 10429] branch filter not working in serial claims
In-Reply-To: <bug-10429-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10429-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10429-70-gADumjxCwp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10429

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
For information: I removed these filters in one of my patches for bug 10855
(patch "Bug 10855: Search subscriptions by additional fields on the claim
page").

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:53:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:53:35 +0000
Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for
	overdues
In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9180-70-5UYLXDVu2j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to M. de Rooy from comment #10)
> This patch got status Signed off by koha.aixmarseille at gmail.com.
> Please add a signoff line and explain what/how you tested in view of the
> multiple comments referring to impossibilities to test it.
> Thanks for your patience.

Switch back to Needs Signoff, I don't understand the "Failed QA" status

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:57:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:57:19 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-wZyQTViiAY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21199|0                           |1
        is obsolete|                            |
  Attachment #22326|0                           |1
        is obsolete|                            |

--- Comment #21 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 22524
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22524&action=edit
Show the ordered status in catalogue page

I apply the patches today against master 3.13.00.032
I sign off the patches.
Tha orders' advanced search works well but, selecting "cancelled" Order status,
it finds no cancelled order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 16:57:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 15:57:32 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-UnZICkFS2C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 17:03:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 16:03:31 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-JawtSJSfa3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

--- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Paola, it seems you didn't attach the right patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 17:08:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 16:08:01 +0000
Subject: [Koha-bugs] [Bug 11086] Koha Tools Upload Patron Images text
	description change
In-Reply-To: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11086-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11086-70-Km39nHE9Nu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11086

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #10 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Chris!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 17:46:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 16:46:06 +0000
Subject: [Koha-bugs] [Bug 5202] Merge authority records
In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5202-70-0rPFOFSh3W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 18:17:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 17:17:36 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-Lcc35y8TcC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22525
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22525&action=edit
Bug 11157 - Placing a simple item-level hold for serials in OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 18:17:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 17:17:57 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-YSuhnkYiyM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

--- Comment #9 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22526&action=edit
Bug 11157 - Placing a simple item-level hold for serials in staff client.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 18:22:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 17:22:48 +0000
Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected
 UTF8 handling in templates
In-Reply-To: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6554-70-6VjADUzX8J@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4558|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 18:45:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 17:45:53 +0000
Subject: [Koha-bugs] [Bug 9847] arrows for child funds not always showing
In-Reply-To: <bug-9847-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9847-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9847-70-NMWCPONNfO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9847

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
This is still an issue that came up today in training.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 18:51:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 17:51:17 +0000
Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors
In-Reply-To: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11155-70-MYffSqKrad@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WONTFIX

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Dan, 
I am marking this WONTFIX, because we currently do not maintain the PostgresSQL
db schema and it's outdated. To my knowledge Koha can currently not be used
with PostgresSQL, but it might be possible sometime in the future, as we have
started using DBIX::Class.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 18:57:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 17:57:09 +0000
Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors
In-Reply-To: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11155-70-4w9Wuajnj5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155

--- Comment #2 from Dan Scott <dan at coffeecode.net> ---
Okay. Would you entertain a patch that removes the PostgreSQL cruft, then, so
that people like me don't waste our time in the future?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 19:05:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 18:05:27 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-MYcIfaF5hE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22525|0                           |1
        is obsolete|                            |

--- Comment #10 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22527
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22527&action=edit
Bug 11157 - Placing a simple item-level hold for serials in OPAC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 19:15:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 18:15:29 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-5OkA2jasmr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22527|0                           |1
        is obsolete|                            |

--- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22528
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22528&action=edit
Bug 11157 - Placing a simple item-level hold for serials in OPAC.

For biblios marked as a serial or if the syspref:
-OPACShowPlaceItemLevelHold or
is enabled.
Adds a "Place hold"-link after each item in the detailed biblio view.

Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc for serials.

Added a new parameter itemnumber to opac-reserve.pl/.tt.
This causes the reserving module to display only the desired item, preselect it
and hide unnecessary buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 19:16:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 18:16:41 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-NdjxWjyzvT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22526|0                           |1
        is obsolete|                            |

--- Comment #12 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22529
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22529&action=edit
Bug 11157 - Placing a simple item-level hold for serials in staff client.

For biblios marked as a serial or if the syspref:
-ShowPlaceItemLevelHold
is enabled.
Adds a "Place hold"-link after each item in the detailed biblio view.

Added a new parameter itemnumber to reserve.pl/.tt.
This causes the reserving module to display only the desired item, preselect it
and hide unnecessary buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 19:21:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 18:21:59 +0000
Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records
In-Reply-To: <bug-10500-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10500-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10500-70-YORsALfHwm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500

--- Comment #17 from Tom McMurdo <thomas.mcmurdo at state.vt.us> ---
Just following up: where are we in QA with this ISBN matching fix? I don't mean
to seem impatient, but I know that our consortium is anxious to see this added.
Let me know what comes next.
Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 19:22:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 18:22:08 +0000
Subject: [Koha-bugs] [Bug 11162] New: ability to sort items on item edit
	screen
Message-ID: <bug-11162-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11162

            Bug ID: 11162
           Summary: ability to sort items on item edit screen
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: nengard at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Would be nice if there were datatables on the edit items screen table at the
top

example url:

/cgi-bin/koha/cataloguing/additem.pl?biblionumber=76640

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 19:52:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 18:52:46 +0000
Subject: [Koha-bugs] [Bug 11155] PostgreSQL schema contains syntax errors
In-Reply-To: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11155-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11155-70-CxwchGP6Kt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WONTFIX                     |---

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to Dan Scott from comment #2)
> Okay. Would you entertain a patch that removes the PostgreSQL cruft, then,
> so that people like me don't waste our time in the future?

Yes, we will.  Note that the general idea is that in the next release, the
schema will be initialized from the DBIC schema classes, not big SQL scripts as
is the status quo.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 20:40:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 19:40:03 +0000
Subject: [Koha-bugs] [Bug 11047] koha-translate won't update languages
In-Reply-To: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11047-70-UftqBT2EY0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11047

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Robin, koha-translate does three things, in this order:

check_lang_po_files $lang
remove_lang $lang
install_lang $lang

Regards
To+

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 22:36:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 21:36:35 +0000
Subject: [Koha-bugs] [Bug 11163] New: Wrong itemtype usage count when
 deleting an itemtype
Message-ID: <bug-11163-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11163

            Bug ID: 11163
           Summary: Wrong itemtype usage count when deleting an itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

No matter how much biblios or items use an itemtype the count is always 1.

Steps to reproduce:
- Create an itemtype.
- Create some biblios setting the created itemtype at biblio level.
- Create some items setting the created itemtype on them.
- Try to delete the itemtype in Home > Administration > Item types, the count
is 1 and doesn't match the expected result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 22:41:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 21:41:05 +0000
Subject: [Koha-bugs] [Bug 11163] Wrong itemtype usage count when deleting an
	itemtype
In-Reply-To: <bug-11163-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11163-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11163-70-HZhGnUmTZy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11163

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 22:41:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 21:41:09 +0000
Subject: [Koha-bugs] [Bug 11163] Wrong itemtype usage count when deleting an
	itemtype
In-Reply-To: <bug-11163-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11163-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11163-70-2HPwWiawRM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11163

--- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22530
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22530&action=edit
Bug 11163: Wrong itemtype usage count when deleting an itemtype

Wrong usage of UNION instead of UNION ALL prevented the count to match
the expected value.

Regards
To+

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Oct 29 22:50:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 29 Oct 2013 21:50:58 +0000
Subject: [Koha-bugs] [Bug 11164] New: creator_batches table uses
 borrower_number not borrowernumber?
Message-ID: <bug-11164-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11164

            Bug ID: 11164
           Summary: creator_batches table uses borrower_number not
                    borrowernumber?
 Change sponsored?: ---
           Product: Koha
           Version: 3.10
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: hbraum at nekls.org
        QA Contact: testopia at bugs.koha-community.org

The creator_batches table uses borrower_number instead of borrowernumber. All
other tables use borrowernumber (discovered when I was looking at
http://schema.koha-community.org/columns.byColumn.html#columns). 

Was this difference intentional?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 02:13:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 01:13:44 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-0LnzfVnP9c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #15 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Doug Kingston from comment #13)
> I don't think we can use that pattern because it relies on running as root. 

Well, I'm trying to figure a way that'll work with the scheme that the packages
currently use. For them we can expect /var/lock/koha/instancename to exist and
have the correct user permissions, as it's already used for locking zebrasrv.
So we could have a rebuild-zebra.lck (or whatever) lock file under there.

> Since /var/lock is often on tmpfs its gone after a reboot and we can't rely
> in
> a subdirectory maintained.  I think this is now in the safest, most
> maintable state.

We can rely on it for packages as it's created at boot, if needed (and is
already being used.)

> Fair enough, I'll update it to use /var/lock if the lockdir variable is not
> defined.

Cool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 02:16:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 01:16:25 +0000
Subject: [Koha-bugs] [Bug 11142] Update Bootstrap theme's place hold form to
 match the new version in prog
In-Reply-To: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11142-70-DiiFOn7Mj1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22474|0                           |1
        is obsolete|                            |

--- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 22531
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22531&action=edit
[SIGNED-OFF] Bug 11142 - Update Bootstrap theme's place hold form to match the
new version in prog

The update to the prog theme's place hold page (Bug 10836) happened
after the Bootstrap theme's place hold form had already been converted,
so it lags behind. This patch applies the changes made to prog to Bootstrap.

To test, switch to the Bootstrap theme and follow the test plan from Bug
10836:

Place single and multiple holds under various conditions:

- Items which are not available to be place on hold
- With OpacHoldNotes on and off
- With OPACItemHolds on and off
- With OPACAllowHoldDateInFuture on and off
- With IndependentBranches on and off
- With JavaScript disabled

Test setting hold notes, holding specific copies, and setting hold start
dates. When setting a hold start date and hold expiration date, the two
datepickers should work together to prevent invalid date combinations
(dates after today, expiration dates which precede the start date).

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
No koha-qa errors. Works as described, very well.

Tested all situations, all syspref, and without JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 02:16:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 01:16:49 +0000
Subject: [Koha-bugs] [Bug 11142] Update Bootstrap theme's place hold form to
 match the new version in prog
In-Reply-To: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11142-70-qsZvKU3GVH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 02:17:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 01:17:59 +0000
Subject: [Koha-bugs] [Bug 11047] koha-translate won't update languages
In-Reply-To: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11047-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11047-70-oYYptJP2We@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11047

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Robin Sheat <robin at catalyst.net.nz> ---
So it does, but it wasn't working for me when I tried it. Oh well, I'll mark
this invalid and reopen it should I see it again, and get more meaningful data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 04:00:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 03:00:26 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7688-70-exmJZPKMm1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #112 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with the usual bunch of follow-ups.  Thanks, Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 04:23:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 03:23:41 +0000
Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests
 that contradict the branch holds policy
In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10243-70-hpgfiCDRpe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 04:25:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 03:25:50 +0000
Subject: [Koha-bugs] [Bug 10962] Update MARC21 frameworks to Update Nr. 17
 (September 2013)
In-Reply-To: <bug-10962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10962-70-ooSp1Trx8a@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10962

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 04:27:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 03:27:04 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-G93kJFtkUl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #16 from Doug Kingston <dpk at randomnotes.org> ---
(In reply to Robin Sheat from comment #15)
> (In reply to Doug Kingston from comment #13)
> > I don't think we can use that pattern because it relies on running as root. 
> 
> Well, I'm trying to figure a way that'll work with the scheme that the
> packages currently use. For them we can expect /var/lock/koha/instancename
> to exist and have the correct user permissions, as it's already used for
> locking zebrasrv. So we could have a rebuild-zebra.lck (or whatever) lock
> file under there.
My code works with the system as implemented (packages or no packages).
There is not a easy way to get the instance name (unless I am mistaken) right
now without introducing yet more variables and possible problems.  Is there a
pressing reason for the lock file to live under /var/lock/koha/instancename
that warrants the additional complexity?  And whatever we come up with needs
to work for new and legacy installs.  Ideas that keep get us closer without
undue complexity are welcome.  Otherwise, lets get this in and iterate.

> 
> > Since /var/lock is often on tmpfs its gone after a reboot and we can't rely
> > in
> > a subdirectory maintained.  I think this is now in the safest, most
> > maintable state.
> 
> We can rely on it for packages as it's created at boot, if needed (and is
> already being used.)
> 
> > Fair enough, I'll update it to use /var/lock if the lockdir variable is not
> > defined.
> 
> Cool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 04:31:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 03:31:04 +0000
Subject: [Koha-bugs] [Bug 10733] Memcached on package installs
In-Reply-To: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10733-70-J7w2bPyn6e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #25 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Tom?s!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 04:39:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 03:39:00 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-eG4GXdk4bF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #17 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Doug Kingston from comment #16)
> My code works with the system as implemented (packages or no packages).

I know, I'm trying to get it to a point where it also works cleanly with the
packages.

> There is not a easy way to get the instance name (unless I am mistaken) right
> now without introducing yet more variables and possible problems.  

There is for packages, we can put __KOHASITE__ in the koha-conf.xml template.
It's not super tidy, as we'll then be creating an unnecessary directory under
that, but that's not the end of the world by any means.

> Is there
> a pressing reason for the lock file to live under /var/lock/koha/instancename
> that warrants the additional complexity?  

I'm not sure if there are any specific debian policies on what goes in the lock
dir, but as we progress towards making things debian-clean, we ought to avoid
doing things in an obviously inconsistent fashion.

> And whatever we come up with needs
> to work for new and legacy installs.  Ideas that keep get us closer without
> undue complexity are welcome.  Otherwise, lets get this in and iterate.

I'd say for now to modify the template patch to be:
/var/lock/koha/__KOHASITE__
and it'll be clean enough. Not quite as much as I'd like, but it'll do, and
it's hidden away. And we know this is safe to do as they're configured in the
init.d script.

It'll also work on tar, git, etc. systems as they'll use plain /var/lock.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 05:23:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 04:23:44 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-iNfjcgBpz1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #18 from Doug Kingston <dpk at randomnotes.org> ---
Created attachment 22532
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22532&action=edit
Bug 11078 Add locking to rebuild_zebra (QA Patch 3 10/29)

A final tweak to the debian packages template to ensure the lock
file is under /var/lock/koha/INSTANCENAME.  Its not ideal but
this work for all legacy and new installations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 05:38:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 04:38:20 +0000
Subject: [Koha-bugs] [Bug 7131] way to overlay items in in marc import
In-Reply-To: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7131-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7131-70-ingiJ6Sr3p@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7131

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #58 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along of follow-ups.  One of the follow-ups teaches
stage_file.pl how to set the item action and fixes commit_file.pl to display
the summary counts correctly.

I've elected to waive requiring test cases, but they should be added soon.

Thanks, Kyle and Elliott!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 06:04:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 05:04:07 +0000
Subject: [Koha-bugs] [Bug 10078] show location facet for all
In-Reply-To: <bug-10078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10078-70-5oLqXxqVNY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10078

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a follow-up that adds a regression test.

Thanks, David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 06:10:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 05:10:49 +0000
Subject: [Koha-bugs] [Bug 10725] Add filters on the pending orders table
In-Reply-To: <bug-10725-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10725-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10725-70-uNkrKOd5VB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10725

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 07:54:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 06:54:50 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-125rO56EG5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug -5511- Added new system preference: SessionRestrictionByIP
Using index info to reconstruct a base tree...
M    installer/data/mysql/sysprefs.sql
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Patch failed at 0001 Bug -5511- Added new system preference:
SessionRestrictionByIP
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 07:56:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 06:56:43 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-WaMzM3rGd1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21864|0                           |1
           is patch|                            |
  Attachment #21864|application/mbox            |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 07:57:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 06:57:04 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-93oexdH6Xz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21865|0                           |1
           is patch|                            |
  Attachment #21865|application/mbox            |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 07:58:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 06:58:37 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-QJax38ANLd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 07:58:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 06:58:42 +0000
Subject: [Koha-bugs] [Bug 5511] Check for Change in Remote IP address for
 Session Security. Disable when remote ip address changes frequently.
In-Reply-To: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5511-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5511-70-p4gXPUDnRp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21865|0                           |1
        is obsolete|                            |

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22533
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22533&action=edit
Bug -5511- Added new system preference: SessionRestrictionByIP

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 07:59:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 06:59:56 +0000
Subject: [Koha-bugs] [Bug 11018] Add order from a reverted file
In-Reply-To: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11018-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11018-70-XZhvxsqRaQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11018

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:00:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:00:36 +0000
Subject: [Koha-bugs] [Bug 10824] OAI-PMH repository/server not handling time
 in "from" argument
In-Reply-To: <bug-10824-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10824-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10824-70-ObXn0paAGh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10824

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:01:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:01:11 +0000
Subject: [Koha-bugs] [Bug 10318] show email on patron search results
In-Reply-To: <bug-10318-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10318-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10318-70-oDU7ie3F2Z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:02:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:02:07 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-ALoVfUgHKM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 11030 : add fields 947,969,359 in unimarc_complete french
framework
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11030 : add fields 947,969,359 in unimarc_complete
french framework
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:02:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:02:36 +0000
Subject: [Koha-bugs] [Bug 11021] Delete useless 9XX field in french
 unimarc_complet default Framework
In-Reply-To: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11021-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11021-70-OJJrT4zaxm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11021

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:04:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:04:25 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-oUHMJFTJ4L@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:04:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:04:33 +0000
Subject: [Koha-bugs] [Bug 11030] Add 359,
 347 and 369 field in french unimarc_complete framework
In-Reply-To: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11030-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11030-70-7AeDZPRnaZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
        Bot Control|---                         |Ignore this bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:05:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:05:57 +0000
Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating
In-Reply-To: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8769-70-bzewtrfjcH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:06:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:06:33 +0000
Subject: [Koha-bugs] [Bug 10533] basketgroup js functions should in a
	separated js file
In-Reply-To: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10533-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10533-70-89GD7cxgTb@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10533

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:07:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:07:25 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-qgoB41vBVs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7298 Export late orders as csv
Using index info to reconstruct a base tree...
M    C4/Acquisition.pm
M    acqui/lateorders.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
M    serials/lateissues-excel.pl
Falling back to patching base and 3-way merge...
Auto-merging serials/lateissues-export.pl
CONFLICT (content): Merge conflict in serials/lateissues-export.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt
Auto-merging acqui/lateorders.pl
Auto-merging C4/Acquisition.pm
Patch failed at 0001 Bug 7298 Export late orders as csv
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:07:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:07:39 +0000
Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late
	orders table
In-Reply-To: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11027-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11027-70-t7vZ1p4d9e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
This bug depends on bug7298 which is in status Passed QA but the patches for it
do not apply cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:08:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:08:08 +0000
Subject: [Koha-bugs] [Bug 9808] Show basketgroup information for each basket
 in basket list
In-Reply-To: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9808-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9808-70-bfkUubUdxd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9808

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:08:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:08:36 +0000
Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted
 according to dateformat system preference
In-Reply-To: <bug-9084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9084-70-zvIkFlfYnI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:09:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:09:11 +0000
Subject: [Koha-bugs] [Bug 9416] We should have 2 kinds of notes for each
	order line
In-Reply-To: <bug-9416-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9416-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9416-70-gYchZhqXJM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:10:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:10:20 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-f5nTdE1csw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #125 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7180: Order from staged file improvements
Using index info to reconstruct a base tree...
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/js/acq.js
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/acq.js
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Patch failed at 0001 Bug 7180: Order from staged file improvements
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:10:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:10:53 +0000
Subject: [Koha-bugs] [Bug 11048] Fix logout redirection for CAS
	authentication
In-Reply-To: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11048-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11048-70-R0fTdHzKW0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11048

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:12:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:12:52 +0000
Subject: [Koha-bugs] [Bug 10782] Add a koha-mysqlcheck script
In-Reply-To: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10782-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10782-70-zavupXznLt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10782

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:14:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:14:14 +0000
Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search,
 more specific than "any"
In-Reply-To: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8962-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8962-70-dP9mxDRom8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #24 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 8962: Unimarc biblios and authorithies (GRS1)
Using index info to reconstruct a base tree...
M    etc/zebradb/marc_defs/unimarc/biblios/record.abs
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/record.abs
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/unimarc/biblios/record.abs
Patch failed at 0001 Bug 8962: Unimarc biblios and authorithies (GRS1)
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:14:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:14:45 +0000
Subject: [Koha-bugs] [Bug 10461] tax not taken in to account in the acq
	budget summaries
In-Reply-To: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10461-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10461-70-N606D7LGkq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10461

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #27 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:15:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:15:21 +0000
Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not
	Plack-compatible
In-Reply-To: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9224-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9224-70-EIv9fjtDmc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:15:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:15:50 +0000
Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when
 using QueryWeightFields
In-Reply-To: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11069-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11069-70-cQfJoCPYNx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:16:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:16:22 +0000
Subject: [Koha-bugs] [Bug 9972] Add/ change some zebra indexes (MARC21)
	(GRS1+DOM)
In-Reply-To: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9972-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9972-70-YXvwjlLPay@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9972

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #19 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:16:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:16:58 +0000
Subject: [Koha-bugs] [Bug 10482] add items limit and sort to rebuild zebra
In-Reply-To: <bug-10482-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10482-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10482-70-TQKfuoYLhG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10482

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:17:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:17:32 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-RyV6yYn67D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug-4456 Adding table po_sequence
Using index info to reconstruct a base tree...
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Patch failed at 0001 Bug-4456 Adding table po_sequence
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:18:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:18:08 +0000
Subject: [Koha-bugs] [Bug 10424] Search against order numbers and pull up
 the related invoice to see when the item was receipted
In-Reply-To: <bug-10424-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10424-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10424-70-z2iBabN5S0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10424

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #11 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10424 - Search received orders
Using index info to reconstruct a base tree...
M    C4/Acquisition.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Acquisition.pm
CONFLICT (content): Merge conflict in C4/Acquisition.pm
Patch failed at 0001 Bug 10424 - Search received orders
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:21:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:21:18 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-N2m4ru4gwY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:21:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:21:22 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-MyI6sAOwFz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22031|0                           |1
        is obsolete|                            |

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22534
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22534&action=edit
Bug-4456-Enable addition of PO Number to order

The ability to have a running purchase order sequence

Test Plan:
1) Set systempreference EnablePONumber to Enable for auto generating purchase
order number.
2) Select prefix for ex: Direct to requestor (Create PONUMPREFIX in authorized
value and insert values).
3) Create an basket.
4) Create an order.
5) Select prefix value for ex: Direct to requestor.
6) Purchase order number will come in purchase order section for ex:
DIR0000001.
7) Click on save button.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:21:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:21:44 +0000
Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order
In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4456-70-mHnQdIOuSz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22032|0                           |1
        is obsolete|                            |

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22535&action=edit
Bug-4456 Adding table po_sequence

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:23:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:23:28 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-zq3V8s9Zct@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug-10477-Alter table import_batches
Using index info to reconstruct a base tree...
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Patch failed at 0001 Bug-10477-Alter table import_batches
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:28:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:28:40 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-YOYrMJlVxV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:28:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:28:44 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-3gaSIDhCDn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22034|0                           |1
        is obsolete|                            |

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22536
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22536&action=edit
Bug-10477 Increased flexibility for upload of Staged

When uploading bulk MARC records against existing records need further
option to allow the process to just add/merge extra MARC tags rather
than having to completely overwrite an existing record or just leave
the existing record unchanged.

Test Plan:
1. Click on Tools->Stage MARC records for import.
2. Upload the MARC file for ex: first.mrc
3. Click on upload button.
4. Choose Record matching rule: 020$a ISBN.
5. Choose Action if matching record found: Append or update MARC21/UNIMARC
tag a text box will appear after choosing enter MARC tag for ex: 700a which
you want to merge.
6. Click on Stage for import button.
7. On the next screen click on Manage staged records.
8. You can also edit the record matching rule in manage record screen.
9. Click on Import this batch on catalog button.
10. Next screen will give no of record updated.
11. It will check duplicate field record for ex: 700$aamit is already in record
it will skip the tag and move to next.

Signed-off-by: Amit Gupta <amitddng135 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:28:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:28:58 +0000
Subject: [Koha-bugs] [Bug 10477] Increased flexibility for upload of Staged
	MARC records
In-Reply-To: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10477-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10477-70-64fzXjTCPv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10477

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22035|0                           |1
        is obsolete|                            |

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22537
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22537&action=edit
Bug-10477-Alter table import_batches

Added overlay_action to "appendmarctag" and new column "marctag"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:30:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:30:21 +0000
Subject: [Koha-bugs] [Bug 11068] Update MARC21 es-ES default frameworks
 fields and translation
In-Reply-To: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11068-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11068-70-oard9kyuXw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11068

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:30:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:30:58 +0000
Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merge into the
 C4::Search::History module
In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10933-70-9D141LQr7R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #5 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10807: Add an authority search history for the OPAC
Using index info to reconstruct a base tree...
M    C4/Auth.pm
M    C4/Search.pm
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
M    opac/opac-search-history.pl
Falling back to patching base and 3-way merge...
Removing t/db_dependent/Auth_ParseSearchHistoryCookie.t
Auto-merging opac/opac-search-history.pl
CONFLICT (content): Merge conflict in opac/opac-search-history.pl
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Search.pm
Auto-merging C4/Auth.pm
CONFLICT (content): Merge conflict in C4/Auth.pm
Patch failed at 0001 Bug 10807: Add an authority search history for the OPAC
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:31:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:31:14 +0000
Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merge into the
 C4::Search::History module
In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10933-70-YXaHyiPqDS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
This bug depends on bug10807 which is in status Signed Off but the patches for
it do not apply cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:31:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:31:48 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-rKgTEQSxri@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10412 - Adding new table aqcreditnotes.
Using index info to reconstruct a base tree...
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Patch failed at 0001 Bug 10412 - Adding new table aqcreditnotes.
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:35:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:35:27 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-Dr6Wg6wLVK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:35:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:35:31 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-atG3gZ2ZlK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22059|0                           |1
        is obsolete|                            |

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22538
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22538&action=edit
Bug 10412 - The ability to update Acquisitions with

credit notes, with the option to link to an existing
invoice.

To Test:
1) Create a basket.
2) Create some orders underbakset and close
   the basket.
3) Receive the shipment give invoice number.
4) For entering creditnote against bookseller
   click on invoices link on left hand side.
5) Search invoice number,title,author,isbn etc.
6) Click on Credit note link.
7) Enter credit amount, date, notes etc and
   click on Save button.
8) You can edit and delete also.

Signed-off-by: Amit Gupta <amitddng135 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:35:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:35:47 +0000
Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with
 credit notes, with the option to link to an existing invoice
In-Reply-To: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10412-70-K7vVBcxfzi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22060|0                           |1
        is obsolete|                            |

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22539
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22539&action=edit
Bug 10412 - Adding new table aqcreditnotes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:37:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:37:12 +0000
Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in
 the Staff client to budget information.
In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10013-70-w0rgZnhSFg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #24 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10013 - Ability to link directly from an item in the Staff client
to budget information.
Using index info to reconstruct a base tree...
M    C4/Acquisition.pm
M    catalogue/detail.pl
M    koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging catalogue/detail.pl
Auto-merging C4/Acquisition.pm
CONFLICT (content): Merge conflict in C4/Acquisition.pm
Patch failed at 0001 Bug 10013 - Ability to link directly from an item in the
Staff client to budget information.
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:37:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:37:45 +0000
Subject: [Koha-bugs] [Bug 9163] Cataloguing validation workflow
In-Reply-To: <bug-9163-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9163-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9163-70-RsjlZsrAtq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #25 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:38:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:38:17 +0000
Subject: [Koha-bugs] [Bug 10451] Firefox prints only first page of table
 with shrink to fit option
In-Reply-To: <bug-10451-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10451-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10451-70-zfAod1q4ns@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10451

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:39:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:39:10 +0000
Subject: [Koha-bugs] [Bug 11081] Port Koha::Contrib::Tamil indexer into Koha
	code base
In-Reply-To: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11081-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11081-70-knqpRV3ueu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #4 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:39:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:39:49 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-n8cU2DB9ip@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-10-02 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #19 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 10486 - Allow external Z39.50 targets to be searched from the
OPAC
Using index info to reconstruct a base tree...
M    C4/Search.pm
M    Makefile.PL
M    installer/data/mysql/sysprefs.sql
M    installer/data/mysql/updatedatabase.pl
M    koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging Makefile.PL
Auto-merging C4/Search.pm
Patch failed at 0001 Bug 10486 - Allow external Z39.50 targets to be searched
from the OPAC
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:40:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:40:42 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9593-70-qOMQrA79dA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #45 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 9593 Prices not imported correctly from a staged file
Using index info to reconstruct a base tree...
M    C4/Biblio.pm
M    installer/data/mysql/kohastructure.sql
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Biblio.pm
Patch failed at 0001 Bug 9593 Prices not imported correctly from a staged file
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:41:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:41:18 +0000
Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack
In-Reply-To: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9316-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9316-70-7eQiny0pQo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #48 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:42:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:42:05 +0000
Subject: [Koha-bugs] [Bug 5670] Housebound Readers Module
In-Reply-To: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5670-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5670-70-1qrHY587uV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #12 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:42:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:42:35 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-J3RBwXGN1r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #7 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:43:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:43:03 +0000
Subject: [Koha-bugs] [Bug 10955] Add ability to skip deletions in zebraqueue
In-Reply-To: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10955-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10955-70-xY16wzmlzh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10955

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:44:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:44:46 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-ILQnpDXRwp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:44:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:44:52 +0000
Subject: [Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be
 searched from the OPAC
In-Reply-To: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10486-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10486-70-hSK4liYd8c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22084|0                           |1
        is obsolete|                            |

--- Comment #20 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22540&action=edit
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC

This adds a new page to the OPAC that can search several Z39.50 targets
using Pazpar2.

Test plan:
1) Apply patches.
2) Update database.
3) Add one or more Z39.50 targets, using the Administration -> External
   targets screen. Note that not all targets support keyword search, but
   here are some that do:
     * Library of Congress: lx2.loc.gov, 210, LCDB, none, none, MARC21, UTF-8
     * BNF2: z3950.bnf.fr, 2211, TOUT, Z3950, Z3950_BNF, UNIMARC, UTF-8
4) Perform a search on the OPAC, check to see if the "external targets"
   notice pops up at the top.
5) Click on the results link near that message.
6) This should bring back results from all enabled targets, all of which
   should be clickable to bring up a detailed view of the record.

(This version fixes some typos and accidental changes.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:46:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:46:44 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9593-70-5nkY8CzzCT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:46:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:46:49 +0000
Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged
	file
In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9593-70-vW7oxjuH5W@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22151|0                           |1
        is obsolete|                            |

--- Comment #46 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22541&action=edit
Bug 9593 Prices not imported correctly from a staged file

Initial bug :
When there's a round price with no decimals after it,
or when the symbol is after the digits, the price is not captured
by regular expression in MungeMarcPrice routine and the variable is not
initialized.

Enhancement :
The MungeMarcPrice routine had been widely modified.
It 's still possible to priority pick the active currency but unlike the
previous mechanism
that worked only for prices preceded by the currency sign, it's now valid
wherever the symbol is situated.
As symbol you may enter a pure currency sign as well as a string including it
like '$US'.
Moreover, an 'isocode' column had been added in currency table (editable in the
pro interface
from Administration/Currencies and exchange rates). So the active currency can
be picked either
through its symbol or through its iso code.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:49:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:49:23 +0000
Subject: [Koha-bugs] [Bug 9811] Patrons search improvements
In-Reply-To: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9811-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9811-70-GMcfwIp1t1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #69 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:49:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:49:55 +0000
Subject: [Koha-bugs] [Bug 10554] Add more options to 'AllowSelfCheckReturns'
	syspref
In-Reply-To: <bug-10554-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10554-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10554-70-TXPf8aBuvQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10554

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #12 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:50:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:50:42 +0000
Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
In-Reply-To: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8033-70-YMd0H1wCJy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #66 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:51:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:51:27 +0000
Subject: [Koha-bugs] [Bug 11120] The date option for the overdue_notices
 cronjob is broken
In-Reply-To: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11120-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11120-70-5tPdFaCRae@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:51:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:51:57 +0000
Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not
 fetched in acq orders
In-Reply-To: <bug-11122-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11122-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11122-70-WCi7SsHvAz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:52:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:52:39 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-Tbq2xjz2aU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #34 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:53:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:53:11 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-9KQOFUd6ZI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 7372: Move road types from the roadtype table to the ROADTYPE AV
Using index info to reconstruct a base tree...
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Removing koha-tmpl/intranet-tmpl/prog/en/modules/admin/roadtype.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Removing admin/roadtype.pl
Patch failed at 0001 Bug 7372: Move road types from the roadtype table to the
ROADTYPE AV
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:53:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:53:40 +0000
Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for
	authorities
In-Reply-To: <bug-7484-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7484-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7484-70-oHiXZ5QHRK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-29 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #6 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:55:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:55:14 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-M6JbQlfKIE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:55:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:55:18 +0000
Subject: [Koha-bugs] [Bug 7372] RoadTypes should be folded into Authorised
	Values
In-Reply-To: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7372-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7372-70-96AjJ9BQhr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22310|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22542&action=edit
Bug 7372: Move road types from the roadtype table to the ROADTYPE AV

Currently road types are stored in a specific table in DB. Moreover, an
admin page is present in order to manage them.
This patch proposes to remove this table and this page in favour of a
new authorised value category 'ROADTYPE'.

This patch:
- adds a new AV category 'ROADTYPE' (created from the roadtype table
  content).
- remove the roadtype table.
- remove the .pl and .tt file admin/roadtype
- remove the 2 routines C4::Members::GetRoadTypes and
  C4::Members::GetRoadTypeDetails

Test plan:
1/ Execute the updatedatabase entry and verify existing roadtypes are
now stored in the AV 'ROADTYPE'.
2/ Verify you can add/update a streettype for patrons.
3/ Verify on following pages the streettype is displayed in patron
information (top left):
  circ/circulation.pl
  members/memberentry.pl
  members/moremember.pl
  members/routing-lists.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:56:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:56:37 +0000
Subject: [Koha-bugs] [Bug 11124] The staff benchmark script does not work
 with sql administrator account
In-Reply-To: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11124-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11124-70-NBzHG6KZia@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11124

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #2 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:57:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:57:03 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-O5JgvpXwsG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:57:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:57:07 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-9suRorYPjo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:57:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:57:09 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-k9vju121oS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #3 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 11126 - Make the holds system optionally give precedence to local
holds
Using index info to reconstruct a base tree...
M    installer/data/mysql/updatedatabase.pl
Falling back to patching base and 3-way merge...
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Patch failed at 0001 Bug 11126 - Make the holds system optionally give
precedence to local holds
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:57:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:57:13 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-tvpsKfnr5h@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:57:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:57:50 +0000
Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC
In-Reply-To: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11119-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11119-70-lLR2kIUAKE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |gitbot at bugs.koha-community.
                   |                            |org
   When did the bot|                            |2013-10-30
    last check this|                            |

--- Comment #8 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Applying: Bug 11119 silent zebra in UNIMARC
Using index info to reconstruct a base tree...
M    etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
M    etc/zebradb/marc_defs/unimarc/biblios/record.abs
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/record.abs
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/unimarc/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
CONFLICT (content): Merge conflict in
etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
Patch failed at 0001 Bug 11119 silent zebra in UNIMARC
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 08:58:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 07:58:30 +0000
Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted
In-Reply-To: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-juWis3I8gc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

I'm just a bot <gitbot at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   When did the bot|2013-09-24 00:00:00         |2013-10-30
    last check this|                            |

--- Comment #26 from I'm just a bot <gitbot at bugs.koha-community.org> ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:00:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:00:16 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-2SM8zbj38G@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:00:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:00:20 +0000
Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give
 precedence to local holds
In-Reply-To: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11126-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11126-70-CPzRqdwfzF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22329|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22543&action=edit
Bug 11126 - Make the holds system optionally give precedence to local holds

This feature will allow libraries to specify that, when an item is returned,
a local hold may be given priority for fulfillment even though it is
of lower priority in the list of unfilled holds.

This feature has three settings:
* LocalHoldsPriority, which enables the feature
* LocalHoldsPriorityPatronControl, which selects for either tha patron's
  home library, or the patron's pickup library for the hold
* LocalHoldsPriorityItemControl, which selects for either the item's
  holding library, or home library.

So, this feature can "give priority for filling holds to
patrons whose (home library|pickup library) matches the item's
(home library|holding library)"

Test Plan:
1) Apply this patch
2) Run t/db_dependent/Holds/LocalHoldsPriority.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:18:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:18:14 +0000
Subject: [Koha-bugs] [Bug 11165] New: datecreated and datemodified column in
	auth_header
Message-ID: <bug-11165-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11165

            Bug ID: 11165
           Summary: datecreated and datemodified column in auth_header
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In auth_header table has columns datecreated and datemodified.
Those columns are never filled by code.
Should they be managed by database ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:22:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:22:59 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-5OgHESTUNu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22524|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:23:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:23:16 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-FdJidamNtg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21199|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:23:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:23:30 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-j9tkjysbmr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22326|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:25:54 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:25:54 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-7sfyJavIXr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21199|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22544&action=edit
Bug 8230: Display acquisition details on the catalogue detail page

This patch adds a new tab "Acquitition details" on the catalogue detail
page. It provides a list of order made for this biblio.

New system preference:
AcquisitionDetails: Hide/Show the new tab

Test plan:
1/ Apply the patch.
2/ Select the "placing an order" value for the AcqCreateItem pref.
3/ Create a new order with X items.
4/ Go on the catalogue detail page for the selected biblio.
5/ Click on the "Acquisition details" tab and check that your order is
displayed. Itemnumbers are present in the last column. Check that links
are not broken.
6/ Close your basket.
7/ Status become "Ordered"
8/ Receive X-1 items.
9/ Come back on the catalogue detail page. There are 2 orders: 1
complete and 1 partial. The complete one has a receive date.
10/ Receive the last item.
11/ Now you have 2 orders with a complete status.
12/ Cancel the last receipt.
13/ You have 1 ordered and 1 complete (2 items).
14/ Cancel the first receipt.
15/ You have 1 ordered (3 items).
16/ Delete your order
17/ You have 1 deleted order.
18/ Switch the AcqCreateItem pref to "receiving an order"
19/ Do again steps 3 to 17.

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:26:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:26:07 +0000
Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page
In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8230-70-WkfmQTs84P@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22326|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22545&action=edit
Bug 8230: Followup Bug 5336: Change numbers with understandable codes for
orderstatus

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:44:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:44:49 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-1ausBHF3wY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:44:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:44:53 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-o13QOpEQ8Y@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21462|0                           |1
        is obsolete|                            |
  Attachment #21463|0                           |1
        is obsolete|                            |
  Attachment #21464|0                           |1
        is obsolete|                            |
  Attachment #21465|0                           |1
        is obsolete|                            |
  Attachment #21466|0                           |1
        is obsolete|                            |
  Attachment #21467|0                           |1
        is obsolete|                            |
  Attachment #21468|0                           |1
        is obsolete|                            |
  Attachment #21469|0                           |1
        is obsolete|                            |
  Attachment #21470|0                           |1
        is obsolete|                            |
  Attachment #21471|0                           |1
        is obsolete|                            |
  Attachment #21472|0                           |1
        is obsolete|                            |
  Attachment #21473|0                           |1
        is obsolete|                            |
  Attachment #21474|0                           |1
        is obsolete|                            |
  Attachment #21514|0                           |1
        is obsolete|                            |

--- Comment #126 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22546&action=edit
Bug 7180: Order from staged file improvements

This patch adds:
- 1 syspref MarcFieldsToOrder
- 1 ajax script acqui/ajax-getauthvaluedropbox.pl
- 1 routine C4::Budgets::GetBudgetByCode

Before this patch you were not able to order 1 or all the records from
your staged file. You were allowed to specify some information ("Import All"
and "Accounting details" areas) for the order.

With this patch, the previous behaviours still exist.
But now you can *select* which records you want to ordered.
For these ones you can specify independently informations (Quantity,
price, budget, sort1 and sort2).
The cherry on the cake is that you can pre-fill these information with
values

Test plan:
1. Fill the new syspref MarcFieldsToOrder with something like:
==BEGIN==
price: 947$c
quantity: 969$h
budget_code: 922$a
rrp: 010$d
discount: 969$d
sort1: 923$a
sort2: 924$a

==END==
The empty line at the end is mandatory!
The budget (corresponding to your budget_code) can be filled with
authorized value categories (statistic 1 and 2).
The sort1 and sort2 values can be filled with the an authorized value
(of the category previously selected)

2. Choose randomly one or more biblio(s) and fill fields with what is relevant.

3. Export the biblio and import it (with the "Stage MARC records for
import" tool).

4. Go on a basket and add an order from a staged file. Select your
staged file.

5. Well. Now you can see your biblio (or biblios if your had exported
more than one). For each one, informations should be pre-filled with the
biblio values. The budget should be selected on the budget corresponding
to the budget_code (in the field 922$a) and the "planning values" too
(with fields 923$a and 924$a).
You can modify these values (or not) and choose a default value for
budget and planning values (in the "Accounting details" area).

6. Save and check the prices values. Modify the order and check that
budget and sort* are good

Prices are calculated following some parameters:
if there is no price => listprice = 0
else =>
  - the gstrate value for your order is the gstrate value of the bookseller
  - discount = if filled : the discount value / 100
               else: the discount value of the bookseller
  - if the bookseller includes tax( List item price includes tax: Yes )
        if a discount exists:
            ecost = price
            rrp   = ecost / ( 1 - discount )
        else: # a discount does not exist
            ecost = price * ( 1 - discount )
            rrp   = price
    else # the bookseller does not include tax
        if a discount exists:
            ecost = price / ( 1 + gstrate )
            rrp   = ecost / ( 1 - discount )
        else: # a discount does not exist
            rrp   = price / ( 1 + gstrate )
            ecost = rrp * ( 1 - discount )
  - in all cases:
        listprice = rrp / currency rate
        unitprice = ecost
        total = ecost * quantity

7. Retry with different parameters

8. Check the 'Import all' action still works

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:04 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-ktAXrUShvB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #127 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22547&action=edit
Bug 7180: FIX getAuthValueDropbox should display the selected value

If the no AV match the name/category or if no category is defined, the
input field should contain the value.

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:11 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-ukEw412Jek@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #128 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22548&action=edit
Bug 7180: Add UT for C4::Budgets::GetBudgetByCode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:16 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-IeQE0E6xe9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #129 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22549&action=edit
Bug 7180: QA followup

Ergonomic improvements:
- Remove the green color the selected record.
- Use fieldset.rows (and legend).
- Use the required css class for quantity inputs.
- Replace "budget" with "fund".
- fix the "undefined" string
- Add a "show MARC" link
- replace "no_match" with a text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:22 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-QCC7cKyjp8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #130 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22550&action=edit
Bug 7180: The default quantity is 1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:28 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-WADvMyu0li@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #131 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22551
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22551&action=edit
Bug 7180: Follow-up fixing minor issues

- Fixed some labels from Budget to Fund
- Added the system preference to sysprefs.sql
- Fixed some untranslatable Javascript strings

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:33 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-0lvfsSGH1k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #132 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22552&action=edit
Bug 7180: Change syspref description

- the blank line is now useless
- add an example for the syspref value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:39 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-gDmkfa5JKe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #133 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22553&action=edit
Bug 7180: Adapt neworderempty code (js function moved).

The js function fetchSortDropbox has been deleted in previous patch.
The new function is getAuthValueDropbox.

Test plan:
- link some av to some funds
- open an existing order and verify value are correctly filled in the
  sort1 and sort2 values
- create a new order and verify behavior is the same as before

Note: This patch generates 2 ajax queries (max) if the budget is linked
to 2 av categories for sort1 and sort2. This could be improved using a
template plugin for values display on load.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:45 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-imegRzqDtt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #134 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22554
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22554&action=edit
Bug 7180: FIX License version

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:50 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-II6lPtLFYH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #135 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22555&action=edit
Bug 7180: QA followup

- fix unit tests (use a transaction).
- add 3 tabs on the page in order to be more understandable.
- fix a warn in logs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:45:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:45:56 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-2vn6BjJyaQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #136 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22556&action=edit
Bug 7180 - QA Followup - Correct minor language issues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:46:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:46:03 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-5LYWiWGlR8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #137 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22557&action=edit
Bug 7180: Restore the "Add order" link

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:46:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:46:09 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-dvNaWQmJKC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #138 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22558
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22558&action=edit
Bug 7180: Remove useless rrp variable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:46:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:46:16 +0000
Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements
In-Reply-To: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7180-70-VwBAuproWT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180

--- Comment #139 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22559&action=edit
Bug 7180: FIX: discount was divided by 100 twice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:46:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:46:27 +0000
Subject: [Koha-bugs] [Bug 11166] New: branch filter in budgets admin uses
 pattern match instead of equals
Message-ID: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166

            Bug ID: 11166
           Summary: branch filter in budgets admin uses pattern match
                    instead of equals
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolyn.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In budgets administration, admin/aqbudgets.pl, there is a combobox for
filtering by branch code.
The bug is that the filter uses a pattern match  instead of equals : 
  next unless $budget->{budget_branchcode} =~ m/$filter_budgetbranch/;
In this case, if there is a branch with code '1' and one with code '12',
filtering by branch '1' will also show budgets of branch '12'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:51:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:51:52 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10807-70-HE5A3iUOVf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20988|0                           |1
        is obsolete|                            |
  Attachment #20989|0                           |1
        is obsolete|                            |
  Attachment #21070|0                           |1
        is obsolete|                            |
  Attachment #21362|0                           |1
        is obsolete|                            |
  Attachment #21363|0                           |1
        is obsolete|                            |
  Attachment #21403|0                           |1
        is obsolete|                            |

--- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22560&action=edit
Bug 10807: Add an authority search history for the OPAC

Like biblio, this feature provides an authority search history.
This history is available for connected and disconnected user.
If the user is not logged in Koha, the history is stored in a cookie
named 'KohaOpacRecentSearches'.
The search history feature is now factorized in a new module.

This patch adds:
- 1 new db field search_history.type. It permits to distinguish the
  search type (biblio or authority).
- 1 new module C4::Search::History. It deals with 2 different storages:
  db or cookie
- 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t
- 1 new behavior: the 'Search history' link (on the top-right corner of
  the screen) is always displayed.

Test plan:
 1/ Switch on the 'EnableOpacSearchHistory' syspref.
 2/ Go on the opac and log out.
 3/ Launch some biblio and authority searches.
 4/ Go on your search history page.
 5/ Check that all yours searches are displayed.
 6/ Click on some links and check that results are consistent.
 7/ Delete your biblio history searches.
 8/ Delete your authority searches history searches.
 9/ Launch some biblio and authority searches
10/ Delete all your history (cross on the top-right corner)
11/ Check that all your history search is empty.
12/ Launch some biblio and authority searches.
13/ Login to your account.
14/ Check that all previous searches are displayed.
15/ Launch some biblio and authority searches.
16/ Check that these previous searches are displayed under "Current
session".
17/ Play with the 4 delete links (current / previous and biblio /
authority).

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:51:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:51:59 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10807-70-lf0esLZbHK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22561&action=edit
Bug 10807: FIX if zebra is down, total is undef

The search_history.total column cannot be undef. This patch adds a
default value for the total value.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

This change doesn't negatively affect search history as far as I can
tell but I also can't reproduce the bug it is meant to fix, so take this
signoff with a grain of salt.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:52:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:52:05 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10807-70-lFZhIjVLBK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22562&action=edit
Bug 10807 [Follow-up] OPAC: There is no authority search history

This follow-up makes two changes:

1) Change "biblio" to "catalog" when referring to non-authority
   searches.
2) Make display of the authority search tab dependent on the
OpacAuthorities system preference. If OPAC authority searches are
disabled we shouldn't show a tab which will always be empty.

To test, view the OPAC search history page with the OpacAuthorities
preference both on and off.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:52:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:52:10 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10807-70-GNFEltkEex@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22563&action=edit
Bug 10807: Change the GPL version to v3+

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:52:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:52:15 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10807-70-Sz9PJHr3ZL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22564&action=edit
Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:52:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:52:19 +0000
Subject: [Koha-bugs] [Bug 10807] OPAC: There is no authority search history
In-Reply-To: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10807-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10807-70-1OMTF7Yp6I@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807

--- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22565&action=edit
Bug 10807: The new field search_history.type should be a varchar(16)

varchar(255) is too wide for "biblio" and "authority" values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:52:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:52:21 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-R4u2Y0BclX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

--- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22566&action=edit
Manual test plan

Attached a manual test plan.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 09:53:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 08:53:23 +0000
Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merge into the
 C4::Search::History module
In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10933-70-swZgcTxJLX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> ---
apply cleanly, patches for bug 10807 have been rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:06:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:06:39 +0000
Subject: [Koha-bugs] [Bug 10770] reserve slip don't print correctly
In-Reply-To: <bug-10770-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10770-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10770-70-85ICg0OlC3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10770

Rafal <rkk0 at poczta.onet.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Rafal <rkk0 at poczta.onet.pl> ---


*** This bug has been marked as a duplicate of bug 7255 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:06:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:06:39 +0000
Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is
	Inconsistent
In-Reply-To: <bug-7255-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7255-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7255-70-1ANAYl9m6R@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255

Rafal <rkk0 at poczta.onet.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

--- Comment #8 from Rafal <rkk0 at poczta.onet.pl> ---
*** Bug 10770 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:25:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:25:31 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-r3nU5WO7hE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22523|0                           |1
        is obsolete|                            |

--- Comment #13 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22567&action=edit
Manual test plan for OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:31:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:31:30 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-pTR1zrQ6p2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

--- Comment #14 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22568&action=edit
Manual test plan for staff client

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:33:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:33:33 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-Lv8WTuiAbi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22513|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22569&action=edit
Bug 11129 - Filtering Items based on type in opac-detail.pl

Currently all Items are always shown on the opac-detail.pl. This is difficult
when the amount of Items grows substantially large.
Implemented a filter to limit the Items shown (and SELECTed from the DB) based
on some typical filters,
  locationbranch, volume, number, issue, fromDate, toDate.
Also streamlined how Serials-data is pulled from the DB to prevent substantial
extra work in C4::Items::GetItemsInfo().
C4::Items::GetItemsInfo() extended to support various filters.

All modifications:
Item filter shown when there are over 50 items (lotsofitems-flag).
Filter fields can be changed based on the Biblio type (isSerial-flag).
-Volume + Issue + Number available only for serials.
Can syspref if Issue-field is used in serial records.
Can syspref a regexp to parse the Volume + Number + Issue from the enumeration
or chronology field.
FromDate and ToDate filter the serial.publisheddate when dealing with serials
otherwise target the items.timestamp -column.
C4::Items::GetItemsInfo() simplified to include the serial data in the BIG SQL.
This makes filtering by publisheddate much more faster.

User input validated using HTML5 <input "number">
Business layer validations as well.

Unit tests:
Serials enumeration and chronology filtering
Items date and branch filtering

Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:34:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:34:12 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-noDWb3hZLx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22514|0                           |1
        is obsolete|                            |

--- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22570&action=edit
Bug 6385 - All items should optionally be displayed by default in the OPAC

Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which
only results from the
users branch are displayed, or Items from the past year if homebranch cannot be
defined.

This tightly couples with bug 11129 which provides the filtering mechanism to
display smaller result sets.
Also added lots of complexity to define the warning messages based on is the
filter used to override the
"OPACmaxItemsOnDetail".

Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the
LIMIT-clause to the big SQL.
Added a unit test for the filter to the Items.t

Fixed a use-case where a user has no items in his branch, and the limited items
set is emtpy.
Now using items from past year if none available in the users branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:34:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:34:37 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-mSRFxjWwvN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22528|0                           |1
        is obsolete|                            |

--- Comment #15 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22571&action=edit
Bug 11157 - Placing a simple item-level hold for serials in OPAC.

For biblios marked as a serial or if the syspref:
-OPACShowPlaceItemLevelHold or
is enabled.
Adds a "Place hold"-link after each item in the detailed biblio view.

Uses the template parameter 'norequest', to disable the "Place hold"-link in
the sidebar opac-detail-sidebar.inc for serials.

Added a new parameter itemnumber to opac-reserve.pl/.tt.
This causes the reserving module to display only the desired item, preselect it
and hide unnecessary buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:34:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:34:58 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-URsjhXA12X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22529|0                           |1
        is obsolete|                            |

--- Comment #16 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22572&action=edit
Bug 11157 - Placing a simple item-level hold for serials in staff client.

For biblios marked as a serial or if the syspref:
-ShowPlaceItemLevelHold
is enabled.
Adds a "Place hold"-link after each item in the detailed biblio view.

Added a new parameter itemnumber to reserve.pl/.tt.
This causes the reserving module to display only the desired item, preselect it
and hide unnecessary buttons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:39:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:39:51 +0000
Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in
	opac-detail.pl
In-Reply-To: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11129-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11129-70-TlKtS8uWtz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:40:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:40:51 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-G3sIbMak7j@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
  Change sponsored?|---                         |Sponsored

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:41:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:41:07 +0000
Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by
 default in the OPAC
In-Reply-To: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6385-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6385-70-EH7usRt7AZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:41:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:41:30 +0000
Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for
	serials.
In-Reply-To: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11157-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11157-70-9uyNFnsS3n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #17 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:48:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:48:05 +0000
Subject: [Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern
 match instead of equals
In-Reply-To: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11166-70-jC2d1pWgT0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co
                   |ity.org                     |m

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22573&action=edit
Bug 11166 - branch filter in budgets admin uses pattern match instead of equals

See commit message

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:48:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:48:27 +0000
Subject: [Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern
 match instead of equals
In-Reply-To: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11166-70-PBPgzaBK41@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:48:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:48:45 +0000
Subject: [Koha-bugs] [Bug 11166] branch filter in budgets admin uses pattern
 match instead of equals
In-Reply-To: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11166-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11166-70-ccieXv8poV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11166

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |admin/aqbudgets.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:52:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:52:36 +0000
Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for
	overdues
In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9180-70-Zojk9pboBV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13799|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22574&action=edit
Bug 9180: All branches should be returned if a default rule exists

The C4::Overdues::GetBranchcodesWithOverdueRules routine has a bug.
If a default rule *and* a specific rule exist, only the branchcode for
the specific rule is returned.

Test plan:
prove t/db_dependent/Overdues.t
and verify the unit tests are consistent.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:58:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:58:13 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-iJ9j1g7LzF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10914

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 10:58:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 09:58:13 +0000
Subject: [Koha-bugs] [Bug 10914] filters are not cumulative in serial claims
In-Reply-To: <bug-10914-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10914-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10914-70-ZnkdtK75kl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10914

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=10855

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:00:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:00:59 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
 that profile marcfields are required
In-Reply-To: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5031-70-R9n4HOenYO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #10)
> It looks really nice, but not like in other places of Koha :) But maybe Owen
> could take a look later?

I used the "required" attribute and the "required" class. The attribute is a
new one (html5) and the required class is the way to do, I think.
I switch back to Signoff: since bug 10853 is pushed to master, I think this one
should be in 3.14
I will quickly submit another patch if Owen considers something is wrong.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:08:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:08:47 +0000
Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for
	overdues
In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9180-70-zCmMwhqpka@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, sorry for commenting without testing - but I am not sure I
understand your comment correctly. I think if a specific rule exists, we only
want to use this rule, so why would returning only the specific rule be a bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:12:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:12:32 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-U5NSwkBgqo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #22 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
We need this functionality as well. Is there some way I can help?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:15:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:15:43 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-Uik5Y7Y1ml@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #23 from Magnus Enger <magnus at enger.priv.no> ---
(In reply to Olli-Antti Kivilahti from comment #22)
> We need this functionality as well. Is there some way I can help?

More testing and another signoff never hurts. ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:17:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:17:22 +0000
Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for
	overdues
In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9180-70-0PyVync8sp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

--- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Katrin Fischer from comment #13)
> Hi Jonathan, sorry for commenting without testing - but I am not sure I
> understand your comment correctly. I think if a specific rule exists, we
> only want to use this rule, so why would returning only the specific rule be
> a bug?

Katrin,
The routine does not return the rules but the branchcodes.
So if a default rule exists in the DB, all branchcodes should be returned.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:18:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:18:26 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-BKIdbadami@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You could test the feature some more and add an additional sign-off :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:19:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:19:33 +0000
Subject: [Koha-bugs] [Bug 9180] Default rules are not always used for
	overdues
In-Reply-To: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9180-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9180-70-rxfRNW5ixj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, why not only the branchcodes for those where no specific rule exists? I
should really have tested first, sorry for confusing. Overdues is quite a
sensitive area for us.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:29:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:29:00 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-ZqreKq2Rqp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #25 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Could I have a test plan for this feature?
I have no idea where to start looking or how to operate this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:54:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:54:48 +0000
Subject: [Koha-bugs] [Bug 5031] CSV export profile form doesn't indicate
 that profile marcfields are required
In-Reply-To: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5031-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5031-70-QshGIdb0b8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5031

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Yes, that's ok.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:58:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:58:08 +0000
Subject: [Koha-bugs] [Bug 10733] Memcached on package installs
In-Reply-To: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10733-70-iELLKLZFej@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11167

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:58:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:58:08 +0000
Subject: [Koha-bugs] [Bug 6193] Use memcached cache koha-conf.xml
	configuration variables
In-Reply-To: <bug-6193-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6193-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6193-70-VLUoGivNnx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11167

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 11:58:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 10:58:08 +0000
Subject: [Koha-bugs] [Bug 11167] New: Remove memcached config from
	koha-conf-site.xml.in
Message-ID: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

            Bug ID: 11167
           Summary: Remove memcached config from koha-conf-site.xml.in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Packaging
          Assignee: magnus at enger.priv.no
          Reporter: magnus at enger.priv.no
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 10733, 6193

The file debian/templates/koha-conf-site.xml.in, which is used to generate
koha-conf.xml files for packages installations, still contains a couple of
lines for configuring memcached, even though this was moved to the Apache
config files by bug 6193 (see specifically attachment 7630, which removes the
relevant lines from /etc/koha-conf.xml). 

Here are the lines:
 <memcached_servers>__MEMCACHED_SERVERS__</memcached_servers>
 <memcached_namespace>__MEMCACHED_NAMESPACE__</memcached_namespace>

Having them there causes no harm, but it might create some confusion over where
memcached is actually configured. 

This can also be seen as a followup to bug 10733 (attachment 21618), which
needlessly changes the lines mentioned above from:

- <memcached_servers></memcached_servers>
- <memcached_namespace></memcached_namespace>

to:

+ <memcached_servers>__MEMCACHED_SERVERS__</memcached_servers>
+ <memcached_namespace>__MEMCACHED_NAMESPACE__</memcached_namespace>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:00:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:00:57 +0000
Subject: [Koha-bugs] [Bug 10914] filters are not cumulative in serial claims
In-Reply-To: <bug-10914-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10914-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10914-70-RCb705xWoS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10914

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Solved in Bug 10855

*** This bug has been marked as a duplicate of bug 10855 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:00:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:00:57 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-y9DcZCDv0K@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #32 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
*** Bug 10914 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:16:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:16:17 +0000
Subject: [Koha-bugs] [Bug 10733] Memcached on package installs
In-Reply-To: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10733-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10733-70-ZZOsNxfYtW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10733

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

--- Comment #26 from Magnus Enger <magnus at enger.priv.no> ---
Attachment 21618 adds MEMCACHED placeholders both to
debian/templates/apache-site.conf.in and
debian/templates/koha-conf-site.xml.in. The former is correct, the latter is
obsolete. 

I propose to remove the unnecessary memcached config lines from
debian/templates/koha-conf-site.xml.in on bug 11167.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:32:52 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:32:52 +0000
Subject: [Koha-bugs] [Bug 11168] New: GetLateOrMissingIssues: $supplierid is
 not mandatory
Message-ID: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

            Bug ID: 11168
           Summary: GetLateOrMissingIssues: $supplierid is not mandatory
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Serials
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Bug 7688 breaks the export csv in serials/claims.tt (see bug 10854).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:33:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:33:10 +0000
Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not
	mandatory
In-Reply-To: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11168-70-Avr0gVngz1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         Depends on|                            |7688, 10854
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:33:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:33:10 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7688-70-u2dBvKP4Rp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11168

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:33:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:33:10 +0000
Subject: [Koha-bugs] [Bug 10854] Choose a CSV profile for exporting serial
	claims
In-Reply-To: <bug-10854-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10854-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10854-70-206uHYJWE0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10854

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11168

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:34:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:34:26 +0000
Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not
	mandatory
In-Reply-To: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11168-70-7y2y2zHzbF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:34:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:34:30 +0000
Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not
	mandatory
In-Reply-To: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11168-70-zcIMD3MJgj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22575&action=edit
Bug 11168: GetLateOrMissingIssues: $supplierid is not mandatory

Bug 7688 breaks the export csv in serials/claims.tt (see bug 10854).

Test plan:
try to export a serial claim.
Without this patch, the csv is always empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:38:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:38:42 +0000
Subject: [Koha-bugs] [Bug 11167] Remove memcached config from
	koha-conf-site.xml.in
In-Reply-To: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11167-70-enXELqbojh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

Magnus Enger <magnus at enger.priv.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:38:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:38:45 +0000
Subject: [Koha-bugs] [Bug 11167] Remove memcached config from
	koha-conf-site.xml.in
In-Reply-To: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11167-70-8fOVbtGXKN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

--- Comment #1 from Magnus Enger <magnus at enger.priv.no> ---
Created attachment 22576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22576&action=edit
Bug 11167 - Remove memcached config from koha-conf-site.xml.in

Memcached-configuration is now done with environment variables
or SetEnv in the Apache configs. Having remnants of the now
obsolete configuration in koha-conf.xml might cause confusion as
to where memcached is actually configured. This patch removes the
two lines related to memcached from koha-conf-site.xml.in

To test, the hard way:
- Apply the patch
- Build packages
- Install package
- Create instances and enable memcached
- Check that memcached is used, even without the settings in
  koha-conf.xml

To test, the easy way:
- On an installation running off the packages, verify that memcached
  is actually configured through environment variables/SetEnv in the
  Apache configs, and not through koha-conf.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:53:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:53:53 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-goyaoKMI6e@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

Stefano Bargioni <bargioni at pusc.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bargioni at pusc.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 12:57:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 11:57:05 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-AtkLksZpsm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #26 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Rotating collections test case.

In "Tools" -> "Rotating Collections" -> "Add/Remove items":
When adding item barcodes to the collection, the input field
  <input type="text" id="barcode" name="barcode">
should become active
automatically so it is easy to add multiple barcodes rapidly without touching
the
mouse or keyboard.
Enter-press is dealt by the barcode reader so automatic form submittal should
be handled
by the barcode reader.

In "Rotating collections" -> "Transfer Collection":
When the collection is initially transferred, items are set to trasfer
correctly.
When the collection is transferred while items are still being transferred, the
transfer 
destination library doesn't change from the original one.
The holding library changes for all items in the collection to the destination
library on
retransfers as well.
This is tricky if a user accidentally places the wrong destination.
When I try to checkin these items to their new retransfer location, I get the
following messages:
-"This item is part of a rotating collection and needs to be transferred to
<original transfer destination>"
-"Please return Valkoinen ihmissy?j? / to <original transfer destination>"
-"Print slip or Cancel transfer"

When I checkin a Item to a arbitrary branch, I get the following messages:
"This item is part of a rotating collection and needs to be transferred to
<retransfer destination>"
"Please return Valkoinen ihmissy?j? / to <original trasfer destination>"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:01:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:01:30 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-pHbeaTBegM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Any chance of rebasing this again Julian.. I'm hoping to test it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:03:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:03:11 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-jh8FCDGzgV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20342|0                           |1
        is obsolete|                            |

--- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22577&action=edit
Bug 9011 - Add the ability to store the last patron to return an item

Currently if the AnonymousPatron system preference is in use, all patron
data is anonymized. Some libraries would like to be able to see the last
patron who returned out an item ( in case of damage ) but still keep all
other patrons anonymized.

* Add the field items.last_borrower, foreign key to
  borrowers.borrowernumber
* Add new system preference StoreLastBorrower
* If StoreLastBorrower is enabled, upon checkin have Koha set this new
  field to the patron who last returned this item.
* If this new field has a value, link to the patron from the item
  details page.

Test plan:
1) Apply patch
2) Run updatedatabase.pl
3) Enable StoreLastBorrower
4) Issue an item to a patron and return said item
5) Issue the same item to a second patron, do not return it.
6) View moredetail.pl for the given bib, find the given item. There
should be a new field in the history list 'Last returned by' with a link
to the given borrowernumber.

Optionally, you can also verify this works even if patron issuing
history has been set to anonymize issues upon return.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:03:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:03:23 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-Rz1Xc8MeXR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20343|0                           |1
        is obsolete|                            |

--- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22578&action=edit
Bug 9011 - QA Followup

* Use template plugin to get syspref values
* Hide "last returned by" if AnonymousPatron is not set

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:03:33 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:03:33 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-HnhnCaJVzY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:03:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:03:36 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-KMOK5AGJnA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20344|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22579&action=edit
Bug 9011: Update GPL license

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:22:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:22:58 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-CzOVFLjiec@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21345|0                           |1
        is obsolete|                            |

--- Comment #40 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22580&action=edit
Bug 8993: LDAP authentication improvements

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:23:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:23:21 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-pzrNjIq6aE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21347|0                           |1
        is obsolete|                            |

--- Comment #42 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22582&action=edit
Bug 8993 - my attempt to get this module working

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:23:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:23:08 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-bm3kME1txy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21346|0                           |1
        is obsolete|                            |

--- Comment #41 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22581&action=edit
Bug 8993: Follow-up - LDAP authentication improvements

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:23:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:23:30 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-OcV6FTzYnX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21348|0                           |1
        is obsolete|                            |

--- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22583&action=edit
Bug 8993 [Follow-up] update and replicate options used at wrong place

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:23:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:23:40 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-R7s4j7fqec@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21349|0                           |1
        is obsolete|                            |

--- Comment #44 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22584&action=edit
Bug 8993: Add branchcode and categorycode mappings for sample module

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:24:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:24:26 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-5ehJFBmKpO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #45 from Julian Maurice <julian.maurice at biblibre.com> ---
I rebased all patches but not tested them. Hope it will works :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:34:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:34:58 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-te5Do7tDGX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:35:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:35:04 +0000
Subject: [Koha-bugs] [Bug 10900] Incorrect calling conventions accessing
	C4::Context
In-Reply-To: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10900-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10900-70-QeCBI7OBwI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22038|0                           |1
        is obsolete|                            |

--- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22585&action=edit
Bug 10900 - Incorrect calling conventions accessing C4::Context

There were multiple calling conventions for C4::Context's
set_userenv routine. So the following commands were used to
find discrepancies:
    grep "::set_userenv" `find .`
    grep "\->set_userenv" `find .`

The first grep demonstrated that the smaller change is from
:: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and
t/db_dependent/Circulation.t would need to be modified. This
patch corrects C4::Context's set_userenv routine to be object
call based (use ->) by using a shift to ignore the first
parameter, and modify the three files found with :: calls.

As the result of trying to roll a distribution,
t/Circulation_barcodedecode.t was discovered to be faulty. The
cause being incorrect parameters! This was hidden when there
was no shift in the set_userenv routine. However, with its
correction, the test broke.

This led me to read the POD documentation for the function
set_userenv in C4::Context and realize it was outdated as
well. It has been revised to match the current version of
the function.

Then intentionally bad parameters passed to the set_userenv
routine in C4::Context were hunted down. The biggest problems
were missing surnames or branch names.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:39:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:39:40 +0000
Subject: [Koha-bugs] [Bug 10421] Add cron script to delete deleted records
In-Reply-To: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10421-70-oD3wcg9HGK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10421

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |RESOLVED
                 CC|                            |kyle at bywatersolutions.com
         Resolution|---                         |DUPLICATE

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 11084 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:39:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:39:40 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-MXQhDpxanu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 10421 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:43:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:43:20 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-5zfV9ApFUZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22009|0                           |1
        is obsolete|                            |

--- Comment #12 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 22586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22586&action=edit
Amended patch

Expanded the patch to ensure that all occurences of the tag are processed not
just the first as previously was the case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:44:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:44:57 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-dYpL9kn1h3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Reset status to needs signoff. Would be grateful if folks could retest and
confirm that deletes are being applied to all occurences

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:53:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:53:10 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-dEqjzoCcIM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21620|0                           |1
        is obsolete|                            |

--- Comment #20 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22587
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22587&action=edit
Bug 10589 - Override OpacHiddenItems based on Patron Category

Two system preferences, PatronSingleBranch and
PatronEveryBranch, have been added to facilitate some
granularity on the override.

If the home branch of the item and the patron match and the
catgegory code of the patron matches one of the pipe delimited
values in the PatronSingleBranch patron category code, then
an item which would normally be hidden will be visible.

If the patron category matches one of the pipe delimited
values in the PatronEveryBranch patron category, then every
item hidden by OpacHiddenItems will be visible.

Since the patron category codes used by default for these
two system preferences are not added, OpacHiddenItems will
continue function as expected until individual patrons and
system preferences are configured.

There is no need to provide this functionality to staff,
as they have access to the staff client.

Rebased to current master (again).

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 13:53:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 12:53:57 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-9dTAxw3r3Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

--- Comment #21 from M. Tompsett <mtompset at hotmail.com> ---
Rebased again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:05:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:05:05 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-RFsDCCK6c6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:14:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:14:09 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-4p03ECoKDq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

--- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Great fast response Julian.. unfortunately I still can't get it to apply :(

Falling back to patching base and 3-way merge...
Auto-merging C4/Auth_with_ldap.pm
CONFLICT (content): Merge conflict in C4/Auth_with_ldap.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 8993: LDAP authentication improvements

Looking at the merge markers, it looks like the main routine 'checkpw_ldap' is
the issue, but it's such an extensive re-write that I don't want to screw it up
by trying to merge it myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:48:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:48:04 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-4OXl0auA7o@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |10895

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:48:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:48:04 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-H09Ho4T1iv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |10589

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:50:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:50:11 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-ptV3hvdMk7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

--- Comment #47 from Julian Maurice <julian.maurice at biblibre.com> ---
Hmm I forgot to fetch the git remote before rebasing...
Rebased patches are coming.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:50:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:50:49 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-6nUpcDC51u@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22580|0                           |1
        is obsolete|                            |

--- Comment #48 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22588
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22588&action=edit
Bug 8993: LDAP authentication improvements

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:50:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:50:59 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-YrC2nt6mIM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22581|0                           |1
        is obsolete|                            |

--- Comment #49 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22589&action=edit
Bug 8993: Follow-up - LDAP authentication improvements

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:51:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:51:11 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-4Qn9cIBCmp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22582|0                           |1
        is obsolete|                            |

--- Comment #50 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22590
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22590&action=edit
Bug 8993 - my attempt to get this module working

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:51:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:51:21 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-88UxYxIqR2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22583|0                           |1
        is obsolete|                            |

--- Comment #51 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22591
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22591&action=edit
Bug 8993 [Follow-up] update and replicate options used at wrong place

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:51:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:51:31 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-1Enp7sYs8F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22584|0                           |1
        is obsolete|                            |

--- Comment #52 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 22592
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22592&action=edit
Bug 8993: Add branchcode and categorycode mappings for sample module

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:57:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:57:50 +0000
Subject: [Koha-bugs] [Bug 10851] Add missing statuses
In-Reply-To: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10851-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10851-70-T6u8C1H88S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10851

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22460|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22593
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22593&action=edit
Bug 10851: Serials - Add missing statuses

4 new missing statuses is added by this patch:
never received, sold out, damaged or lost.

These status have the same behavior than the simple Missing status.

Test plan:
- Find a serial to claim.
- Modify the status of this serial with one of these new statuses.
- Try to find it with the "serials to claim" search.
- Verify that the status is displayed on the serial module pages and on
  the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 14:59:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 13:59:06 +0000
Subject: [Koha-bugs] [Bug 8993] LDAP authentication improvements: multiple
 branch and transformation modules
In-Reply-To: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8993-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8993-70-jL5wDYF1Aq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8993

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks Julian,

Applies beautifully... now for some testing :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:01:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:01:15 +0000
Subject: [Koha-bugs] [Bug 10842] Allow for new type of LDAP authentication -
 Further Enhancement
In-Reply-To: <bug-10842-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10842-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10842-70-vXKny2mQrP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10842

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm not actually sure if this is required anymore?

If someone has a requirement for searching thier LDAP using a service account
before doing a koha user bind, let me know and I'll rebase the patch.

But I have a feeling that this is now null and void as Robin re-implemented
direct binding in bug 10908

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:08:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:08:17 +0000
Subject: [Koha-bugs] [Bug 11169] New: Display an acquisition details tab
Message-ID: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

            Bug ID: 11169
           Summary: Display an acquisition details tab
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:08:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:08:55 +0000
Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
In-Reply-To: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11169-70-OAFcKpzqHN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
          Component|OPAC                        |Acquisitions
           Assignee|oleonard at myacpl.org         |jonathan.druart at biblibre.co
                   |                            |m
            Summary|Display an acquisition      |OPAC: Display an
                   |details tab                 |acquisition details tab

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:14:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:14:12 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-l8yMBnvUGx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #16 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
> the commit message states that 995... will be automatically filled. And this is indeed hardcoded
The subfield $h was also hardcoded. It has been corrected by Bug 9947.

This patch should be corrected the same way.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:15:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:15:24 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-PeGmwOkYVP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
Here is how I tested this.
mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master
HEAD is now at 5d7aa7e Bug 10725: Add filters on the pending orders table
mtompset at ubuntu:~/kohaclone$ git bz apply 10900
Bug 10900 - Incorrect calling conventions accessing C4::Context

22585 - Bug 10900 - Incorrect calling conventions accessing C4::Context

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10900 - Incorrect calling conventions accessing C4::Context
mtompset at ubuntu:~/kohaclone$ git bz apply 10589
Bug 10589 - Override OpacHiddenItems based on Patron Category

22587 - Bug 10589 - Override OpacHiddenItems based on Patron Category

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10589 - Override OpacHiddenItems based on Patron Category
mtompset at ubuntu:~/kohaclone$ git bz apply 10895
Bug 10895 - Tests for C4::Items GetHiddenItems

21153 - Bug 10895 - Tests for C4::Items GetHiddenItems

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10895 - Tests for C4::Items GetHiddenItems
mtompset at ubuntu:~/kohaclone$ prove -v
t/db_dependent/GetHiddenItems_PatronCategory.t
t/db_dependent/GetHiddenItems_PatronCategory.t ..
1..22
ok 1 - use C4::Items;
ok 2 - LIB1 Item linked to correct biblionumber.
ok 3 - LIB1 Item linked to correct biblioitemnumber.
ok 4 - LIB2 Item linked to correct biblionumber.
ok 5 - LIB2 Item linked to correct biblioitemnumber.
$VAR1 = {
          'firstname' => 'Sample',
          'userid' => 'Sample.Borrower',
          'categorycode' => 'PT',
          'phone' => '967-1111',
          'zipcode' => 'H0H 0H0',
          'surname' => 'Borrower',
          'email' => 'santa at northpole.com',
          'city' => 'Bogusville',
          'address' => '123 Bogus Street',
          'branchcode' => 'LIB1'
        };
# Sample Borrower added.
CHECK: 225
dtHtmrYqik
# 79273 - LIB1
# 79274 - LIB2
ok 6 - OpacHiddenItems hid everything correctly.
# 79273,79274
# Borrower number: 225
# Sample Borrower environment variables set up.
ok 7 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SPT
#
ok 8 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SS
# 79274
ok 9 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: ''
# 79274
ok 10 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SS|SPT
#
ok 11 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SPT
#
ok 12 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS
# 79273,79274
ok 13 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: ''
# 79273,79274
ok 14 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS|SPT
#
ok 15 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SPT
#
ok 16 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS
# 79273,79274
ok 17 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: ''
# 79273,79274
ok 18 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS|SPT
#
ok 19 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SPT
#
ok 20 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS
# 79274
ok 21 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: ''
# 79274
ok 22 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS|SPT
#
ok
All tests successful.
Files=1, Tests=22,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.42 cusr  0.01
csy                                                                            
s =  0.45 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:31:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:31:04 +0000
Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
In-Reply-To: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11169-70-nW7ppaJr9T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:31:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:31:07 +0000
Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
In-Reply-To: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11169-70-PLxwAXSpLU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22594
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22594&action=edit
Bug 11169: Display acquition details at the OPAC

This patch adds a new tab 'Acquisition detail' on the OPAC detail page.
A syspref (OPACAcquisitionDetails) permits to turn on this feature.

Test plan:
- switch on the OPACAcquisitionDetails pref.
- set the AcqCreateItems pref to 'receiving'.
- create some orders on 1 or more items.
- go to the opac detail page and verify the "acquitision details" tab
  contains the right number of items which is in order.
- receive the items.
- verify the number of items has decreased.
- set the AcqCreateItems pref to 'ordering'.
- create some orders on 1 or more items.
- go to the opac detail page and verify the "acquitision details" tab
  contains the list of items which is in order.
- receive the items.
- verify the received items don't appear anymore in the table.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:31:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:31:26 +0000
Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
In-Reply-To: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11169-70-862Glxg6fI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22595
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22595&action=edit
Bug 11169: [Bootstrap] Display acquition details at the OPAC

Patch for the bootstrap theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:31:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:31:39 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-VOuQA82h6t@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22586|0                           |1
        is obsolete|                            |

--- Comment #14 from Paola Rossi <paola.rossi at cineca.it> ---
Created attachment 22596
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22596&action=edit
Cannot exclude numeric subfields on export

The deletes are being applied to all occurences.
I sign off the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:31:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:31:50 +0000
Subject: [Koha-bugs] [Bug 10996] Cannot exclude numeric subfields on export
In-Reply-To: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10996-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10996-70-7g7Pwo2nIk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10996

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:34:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:34:40 +0000
Subject: [Koha-bugs] [Bug 11169] OPAC: Display an acquisition details tab
In-Reply-To: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11169-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11169-70-O1fxnKA5G3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED
         Depends on|                            |5336

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:34:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:34:40 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-rNJJkciaPl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11169

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:35:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:35:22 +0000
Subject: [Koha-bugs] [Bug 11170] New: The pending order list should only
 display orders to receive
Message-ID: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

            Bug ID: 11170
           Summary: The pending order list should only display orders to
                    receive
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

The parcel page should only display status "ordered" and "partial".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:35:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:35:35 +0000
Subject: [Koha-bugs] [Bug 11170] The pending order list should only display
 orders to receive
In-Reply-To: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11170-70-R9skeKk2Ew@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:36:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:36:18 +0000
Subject: [Koha-bugs] [Bug 11170] The pending order list should only display
 orders to receive
In-Reply-To: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11170-70-ejKV2dzZOe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:36:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:36:21 +0000
Subject: [Koha-bugs] [Bug 11170] The pending order list should only display
 orders to receive
In-Reply-To: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11170-70-nWu9GV2WgY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22597
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22597&action=edit
Bug 11170: The pending order list should only display orders to receive

The order status ordered is set when the basket is closed.
The parcel page should only display status "ordered" and "partial".

Test plan:
- create a basket.
- create an order.
- verify the order is not listed on the parcel page (i.e. you cannot
  receive it).
- close the basket.
- verify the order is listed on the parcel page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:36:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:36:34 +0000
Subject: [Koha-bugs] [Bug 11170] The pending order list should only display
 orders to receive
In-Reply-To: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11170-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11170-70-kFRO3bcuja@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11170

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |5336

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:36:34 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:36:34 +0000
Subject: [Koha-bugs] [Bug 5336] Acq history search
In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5336-70-UIffOuMTjX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |11170

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:50:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:50:39 +0000
Subject: [Koha-bugs] [Bug 11171] New: The basket group is not displayed on
 the supplier list page
Message-ID: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171

            Bug ID: 11171
           Summary: The basket group is not displayed on the supplier list
                    page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:52:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:52:12 +0000
Subject: [Koha-bugs] [Bug 11171] The basket group is not displayed on the
 supplier list page
In-Reply-To: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11171-70-bDjC7vmQ88@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:52:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:52:43 +0000
Subject: [Koha-bugs] [Bug 11171] The basket group is not displayed on the
 supplier list page
In-Reply-To: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11171-70-rgYHBll2tw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171

--- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22598
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22598&action=edit
Bug 11171: Display basket group name on the supplier list page

Test plan:
search supplier and verify the basket group column is filled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:52:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:52:56 +0000
Subject: [Koha-bugs] [Bug 11171] The basket group is not displayed on the
 supplier list page
In-Reply-To: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11171-70-7IvmExelWU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:53:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:53:04 +0000
Subject: [Koha-bugs] [Bug 11171] The basket group is not displayed on the
 supplier list page
In-Reply-To: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11171-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11171-70-To3eb724ON@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11111

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:53:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:53:04 +0000
Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the
	parcel page
In-Reply-To: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11111-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11111-70-tjX2lOEkBQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=11171

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:55:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:55:23 +0000
Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is
	Inconsistent
In-Reply-To: <bug-7255-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7255-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7255-70-i6GkhxwDSr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255

--- Comment #9 from Heather Braum <hbraum at nekls.org> ---
There was discussion on this bug more than a year ago--is it going to move
anywhere? What will it take for that to happen? I see Chris' comment that
there's a deeper issue going on. Just curious -- this issue is affecting our
libraries, too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:58:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:58:39 +0000
Subject: [Koha-bugs] [Bug 7627] Editing of invoice number
In-Reply-To: <bug-7627-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7627-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7627-70-LK2rPUTjGZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7627

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 15:59:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 14:59:24 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-imePfUCHJe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Created attachment 22599
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22599&action=edit
Bug 10939 - ICU does not transliterate polish special characters

Polish characters added to ICU config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:08:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:08:14 +0000
Subject: [Koha-bugs] [Bug 7677] New area in subscriptions and new function
	when receiving
In-Reply-To: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7677-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7677-70-6DVG8JUjGR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|colin.campbell at ptfs-europe. |matthias.meusburger at biblibr
                   |com                         |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:11:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:11:09 +0000
Subject: [Koha-bugs] [Bug 9822] No alert appears on adding an order to a
 basket if the budget has exceeded
In-Reply-To: <bug-9822-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9822-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9822-70-OAGnDivVPB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9822

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #9 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:14:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:14:59 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-Q5KypEMGnX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to Galen Charlton from comment #25)
> Broader question: do we really need another field in the items table?  Why
> not just tweak AnonymiseIssueHistory() so that if StoreLastBorrower is set,
> old_issue rows that are the most recent return for their items are not
> anonymized?

The more I think of it, the less I like this patch : it introduces a duplicate
information in our database: the last patron is in old_issues and in
items.last_borrower

I agree that the old_issues information can be removed by anonymisation. But a
better option, imho, would be to improve anonymization, to have something like:
 * anonymize
 * anonymize except the last patron
 * don't anonymize

However, I'm not the RM, so Galen final cut. But I really think that, on the
long term, this patch introduces some inconsistencies, and thus, pain.

(Sorry not to have written this earlier)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:19:07 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:19:07 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-RKT7NBdk3c@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #33 from Paola Rossi <paola.rossi at cineca.it> ---
against master 3.13.00.034:
Applying: Bug 10855: New fields on adding/updating a subscription
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging serials/subscription-detail.pl
Auto-merging serials/subscription-add.pl
CONFLICT (content): Merge conflict in serials/subscription-add.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
Auto-merging C4/Serials.pm
CONFLICT (content): Merge conflict in C4/Serials.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 10855: New fields on adding/updating a subscription

So I pass tha patch to "Failed QA" status.

NB. Update database entry needs to be rebased too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:22:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:22:35 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-OKdCkaFjAU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #35 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
This report still needs some help!
There are four patches (two have a signoff).
Two patches need a signoff: the unit test and the alldates followup.
For testing you need to run two unit tests (see commit message).
And follow the test plan in the alldates followup.
You should be able to complete them in well 10 minutes?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:27:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:27:05 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-W5vzTY3Lpt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19943|Bug 9788: Improvements when |[SIGNED_OFF] Bug 9788:
        description|calling                     |Improvements when calling
                   |GetReservesFromItemnumber   |GetReservesFromItemnumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:27:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:27:30 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-ddG9DhQ9LG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22309|Bug 9788: Followup for      |[SIGNED_OFF] Bug 9788:
        description|expirationdate in Letter.pm |Followup for expirationdate
                   |                            |in Letter.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:17 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-XUqPQrh7jG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22049|0                           |1
        is obsolete|                            |
  Attachment #22050|0                           |1
        is obsolete|                            |
  Attachment #22051|0                           |1
        is obsolete|                            |
  Attachment #22052|0                           |1
        is obsolete|                            |
  Attachment #22053|0                           |1
        is obsolete|                            |
  Attachment #22054|0                           |1
        is obsolete|                            |
  Attachment #22055|0                           |1
        is obsolete|                            |
  Attachment #22359|0                           |1
        is obsolete|                            |
  Attachment #22360|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22600
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22600&action=edit
Bug 10855: Add the new package Koha::AdditionalField

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:13 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-vBc1Nassdx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:22 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:22 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-Cch9ldKqLd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #35 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22601
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22601&action=edit
Bug 10855: Update database entry

Add 2 tables: additional_fields and additional_field_values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:36 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-fR4USYm36H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #36 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22602
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22602&action=edit
Bug 10855: Add unit tests for the new package Koha::AdditionalField

Test plan:
- prove t/db_dependent/AdditionalField.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:45 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-4LHwPDGKJo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #38 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22604
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22604&action=edit
Bug 10855: New fields on adding/updating a subscription

This patch adds the ability to add values for additional fields when
adding/updating a subscription.

Test plan (test the following on adding a new subscription and on
editing an existent one):
- add/edit a subscription.
- verify all additional fields appears into the "Additional fields"
  block.
- fill a value for af1 and af3.
- fill others values if you are adding a new subscription.
- save.
- verify values appears on the detail of the subscription page.
- verify the af2 field is automatically filled with the specified
  marc field of the notice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:40 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-CS5IQr2HzB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #37 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22603
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22603&action=edit
Bug 10855: interface configuration for adding new fields to subscriptions

This patch adds an interface configuration for adding fields to
subscriptions.

Test plan:
- go to serials/serials-home.pl
- click on the "Add subscription fields" link on the left of the screen
- try to add/update/delete new fields
You are not abble to add a field with an authorised value category and a
marcfield. Columns are sortable
- for the rest, you should have, at least:
  * a new field named af1, sortable, linked to a category
  * a new field named af2, sortable, linked to a marcfield
  * a new field named af3, not sortable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:51 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-ZJRsmcQR5X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #39 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22605
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22605&action=edit
Bug 10855: Search subscriptions by additional fields

Now you will abble to search subscriptions by additional fields.
The additional field values will be displayed in the table results.

Test plan:
- go on the subscriptions advanced search page
  (serials/serials-search.pl).
- verify all searchable additional fields are displayed on the form.
- combine 1 or more values and verify results are consistent.
- verify the values are displayed in new columns of the table.
- for field linked to an authorised value category, the description is
  displayed (not the code).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:28:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:28:56 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-NYjsLofJ8z@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22606
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22606&action=edit
Bug 10855: Search subscriptions by additional fields on the claim page

Test plan:
- create some serials in late.
- go on serials/claims.pl.
- choose a vendor.
- verify that additional fields are displayed in new columns.
- try filters on columns.
- verify there is no regression on this page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:29:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:29:01 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-Ue6GjRVjf4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #41 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22607
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22607&action=edit
Bug 10855: FIX: Add additional fields for closed subscriptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:29:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:29:06 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-8WGwHFjKuI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #42 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22608
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22608&action=edit
Bug 10855: Fix instance vs static method

This patch fixes the error message.
The 3 modified routines *are* static methods.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:38:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:38:06 +0000
Subject: [Koha-bugs] [Bug 10501] Can't order more than 1 when importing all
 from staged file (AcqCreateItem = on order)
In-Reply-To: <bug-10501-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10501-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10501-70-3ukIJxeHSk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10501

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:40:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:40:08 +0000
Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide
 tab-completion in bash
In-Reply-To: <bug-10003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10003-70-YHfOcVCig4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20743|0                           |1
        is obsolete|                            |

--- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 22609
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22609&action=edit
Bug 10003: bash-completion for koha-list and some other script

This is an initial commit submitted for peer review. It implements
bash-completion for the following commands:

 - koha-list
 - koha-enable
 - koha-disable
 - koha-email-enable
 - koha-email-disable
 - koha-enable-sip
 - koha-start-sip
 - koha-restart-sip
 - koha-stop-sip
 - koha-start-zebra
 - koha-stop-zebra
 - koha-restart-zebra

It is implemented in a way that it removes already used or mutually exclusive
parameters (instance names, option switches).
I already have written completion for other (more complex) commands, But I
belive a simpler patch is better to start with.

IMPORTANT: this patch relies on having the koha-list command available in the
path. Also 10622 is needed for the SIP-related option switches.

To test:
 - Make sure you have bash-completion installed and enabled (IRC might help us
if you encounter problems).
 - Apply the patch.
Option 1:
 - Pick the debian/koha-common.bash-completion file and do
   $ cp debian/koha-common.bash-completion /etc/bash_completion.d/koha-common
 - Open a new bash shell (I do it opening a new terminal on my Ubuntu box).
 - Type one of the listed commands...
  And repeatedly press <TAB>.
 - Enjoy, and signoff if you belive it is usable. Otherwise report back.
Option 2:
 - run:
   $ . debian/koha-common.bash-completion
 - Type one of the listed commands...
  And repeatedly press <TAB>.
 - Enjoy, and signoff if you belive it is usable. Otherwise report back.

Tests:
- Some koha-list option switches are mutually exclusive, -h should be available
in any context
- koha-enable should only autocomplete disabled instances
- koha-disable should only autocomplete enabled instances
- koha-email-enable should only autocomplete email-disabled instances
- koha-email-disable should only autocomplete email-enabled instances
- koha-*-zebra scripts should only autocomplete enabled instances.
- koha-*-sip scripts should only autocomplete sip-enabled instances.

Regards
To+

Note: writing bash-completion routines is a bit hacky, I tried to make it the
simplest way I could. Your comments are welcome.

Sponsored-by: Universidad Nacional de Cordoba

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 16:52:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 15:52:12 +0000
Subject: [Koha-bugs] [Bug 11172] New: Reports need a clear filter button
Message-ID: <bug-11172-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11172

            Bug ID: 11172
           Summary: Reports need a clear filter button
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: gmcharlt at gmail.com
          Reporter: david.roberts at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Once a report filter has been applied, it doesn't seem possible to clear the
filter without logging out of Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 17:54:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 16:54:56 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-wWvO6dy6gl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #43 from Paola Rossi <paola.rossi at cineca.it> ---
Thanks, Jonathan.
Applying the patch is OK.
I get this error message during step 3 of web installation:
----
The following error occurred while importing the database structure:
ERROR 1064 (42000) at line 3320: You have an error in your SQL syntax; check
the manual that corresponds to your MySQL server version for the right syntax
to use near '| CREATE TABLE `additional_field_values` ( `id` int(11) NOT NULL
AUTO_IN' 
----

In installer/data/mysql/updatedatabase.pl, there a 'q' instead of 'qq' in two
lines, and in kohastructure.sql the ending char of two lines is wrong [v.
ENGINE=InnoDB DEFAULT CHARSET=utf8 |].
So I pass the patch to "failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 18:19:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 17:19:20 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-1N7uNTGMgE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #36 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22610
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22610&action=edit
[SIGNED OFF] Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

Adds three tests to Reserves.t for GetReservesFromItemnumber.
We test if this routine does not return a future next available hold,
a future item level hold. And if it does return a future wait (that is:
a confirmed future hold, using ConfirmFutureHolds).

Note that Holds.t does also contains some basic tests for this routine,
but the additional tests seem to better located in the direct context of
tests for bug 9761 for ConfirmFutureHolds.

Test plan:
Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
Verify if both tests do not fail.

Holds.t required adding CPL branch to function.
Reserves.t does not fail for the three tests in question.

Signed-off-by: Mark Tompsett <mtompset at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 18:19:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 17:19:50 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-wWMMCxqrIh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21750|0                           |1
        is obsolete|                            |
                 CC|                            |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 18:41:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 17:41:06 +0000
Subject: [Koha-bugs] [Bug 11173] New: Carriage returns are missing in email
 notification when content type is html
Message-ID: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

            Bug ID: 11173
           Summary: Carriage returns are missing in email notification
                    when content type is html
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: sophie.meynieux at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Notifications by email lacks carriage returns if content type is HTML

Test plan :
- Define one letter template for overdues for example
- Check "HTML Message"
- Define some overdue rules that are using this letter
- Find one borrower that has overdues triggering this notification.
- Run misc/cronjobs/overdue_notices.pl to generate the message and change
to_address to give your email

Without patch :
- run misc/cronjobs/process_messsage_queue.pl => email content is all on one
line

With the patch :
- change message status to 'pending' so that it could be sent once again
- run misc/cronjobs/process_message_queue.pl => email content is displaid
correctly with carriage returns as defined in template

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 18:41:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 17:41:30 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-RyYVbAQqmC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |sophie.meynieux at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 18:48:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 17:48:13 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-JBvorNISTW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

--- Comment #1 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> ---
Created attachment 22611
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22611&action=edit
Bug 11173 : Notifications by email lacks carriage returns if content type is
HTML

Test plan :
- Define one letter template for overdues for example
- Check "HTML Message"
- Define some overdue rules that are using this letter
- Find one borrower that has overdues triggering this notification.
- Run misc/cronjobs/overdue_notices.pl to generate the message and change
to_address to give your email

Without patch :
- run misc/cronjobs/process_messsage_queue.pl => email content is all on one
line

With the patch :
- change message status to 'pending' so that it could be sent once again
- run misc/cronjobs/process_message_queue.pl => email content is displaid
correctly with carriage returns as defined in template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:11:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:11:38 +0000
Subject: [Koha-bugs] [Bug 11174] New: Wrong paramter 'valuec' in
 opac-authoritiessearchresultlist
Message-ID: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174

            Bug ID: 11174
           Summary: Wrong paramter 'valuec' in
                    opac-authoritiessearchresultlist
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: z.tajoli at cineca.it
        QA Contact: testopia at bugs.koha-community.org

In the template opac-authoritiessearchresultlist are dinamic written
link with 5xx heading.

But in the link is used a wrong 'valuec' parameter instead of 'value'.

It is present in prog and in / bootstrap template
opac-authoritiessearchresultlist.tt

In prog it is at line 62
In bootstrap it is at line 88

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:12:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:12:21 +0000
Subject: [Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in
 opac-authoritiessearchresultlist
In-Reply-To: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11174-70-MXBd96q6ef@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:12:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:12:32 +0000
Subject: [Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in
 opac-authoritiessearchresultlist
In-Reply-To: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11174-70-tkHwqQb9Vh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |z.tajoli at cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:15:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:15:38 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-aDIwXUfuN1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22610|0                           |1
        is obsolete|                            |

--- Comment #37 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 22610
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22610
[SIGNED OFF] Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

 FAIL   t/db_dependent/Reserves.t
   OK     pod
   OK     forbidden patterns
   FAIL   valid
                "my" variable @results masks earlier declaration in same scope
   OK     critic

Oops! Caught this while looking at the other patch, not signed off patch. I
really should run this all the time. Sorry, I should not have signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:16:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:16:28 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-MPyuODkIVL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21750|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:20:27 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:20:27 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-uxqYFpPpS6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #38 from M. Tompsett <mtompset at hotmail.com> ---
I did not run any code that would trigger all the change points in the
"Followup removing the alldates parameter" patch. I did, however, do a file
comparison between master and the modified code to confirm that the code was
identical. That would mean the last four diffs are fully accounted for, because
the left side of the diffs are due to another part of the four patches attached
to this bug.

Since I also ran the prove on the attached test, I know the SQL function is
working, and hence the first portion of this specific patch ("Followup removing
the alldates parameter") is functional.

It seems that initially, the code was NOT called with a parameter passed for
$alldates, and so the unless statement was always run. This is why it was moved
up into the SQL, which is working. I suppose ordering by priority is considered
part of the improvements too. And with the addition of the waitingdate into the
SQL statement there is an improvement by including a confirmed future hold.
Though, this is the part that makes me feel uncomfortable signing this off,
even though it probably is okay.

This series of patches have removed the alldates parameter and just put the
date restriction into the function. The perldoc has been appropriately updated
as well.

mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master
HEAD is now at 5d7aa7e Bug 10725: Add filters on the pending orders table
mtompset at ubuntu:~/kohaclone$ grep -n GetReservesFromItemnumber `find . -name
"*.p[lm]" | grep -v blib` `find . -name "*.t"`
./C4/Reserves.pm:98:        &GetReservesFromItemnumber
./C4/Reserves.pm:351:=head2 GetReservesFromItemnumber
./C4/Reserves.pm:353: ( $reservedate, $borrowernumber, $branchcode, $reserve_id
) = GetReservesFromItemnumber($itemnumber);
./C4/Reserves.pm:359:sub GetReservesFromItemnumber {
./circ/transferstoreceive.pl:102:            my @checkreserv =
GetReservesFromItemnumber($num->{'itemnumber'} );
./opac/opac-reserve.pl:434:        my ($reservedate,$reservedfor,$expectedAt) =
GetReservesFromItemnumber($itemNum);
./reserve/request.pl:331:            my
($reservedate,$reservedfor,$expectedAt,$reserve_id) =
GetReservesFromItemnumber($itemnumber);
./catalogue/detail.pl:223:    my ($reservedate,$reservedfor,$expectedAt) =
GetReservesFromItemnumber($item->{itemnumber});
./t/db_dependent/Holds.t:79:my ( $reservedate, $borrowernumber, $branchcode,
$reserve_id ) = GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Holds.t:80:ok($reserve_id, "Test
GetReservesFromItemnumber()");
./t/db_dependent/Holds.t:95:( $reservedate, $borrowernumber, $branchcode,
$reserve_id ) = GetReservesFromItemnumber($itemnumber);
mtompset at ubuntu:~/kohaclone$ git bz apply 9788
Bug 9788 - Improvements for calling GetReservesFromItemnumber

19943 - [SIGNED_OFF] Bug 9788: Improvements when calling
GetReservesFromItemnumber
21479 - Bug 9788: Followup removing the alldates parameter
22309 - [SIGNED_OFF] Bug 9788: Followup for expirationdate in Letter.pm
22610 - [SIGNED OFF] Bug 9788: Unit tests for changed routine
GetReservesFromItemnumber

Apply? [(y)es, (n)o, (i)nteractive] i
Applying: Bug 9788: Improvements when calling GetReservesFromItemnumber
Applying: Bug 9788: Followup for expirationdate in Letter.pm
Applying: Bug 9788: Unit tests for changed routine GetReservesFromItemnumber
Applying: Bug 9788: Followup removing the alldates parameter
mtompset at ubuntu:~/kohaclone$ grep -n GetReservesFromItemnumber `find . -name
"*.p[lm]" | grep -v blib` `find . -name "*.t"`
./C4/Reserves.pm:98:        &GetReservesFromItemnumber
./C4/Reserves.pm:351:=head2 GetReservesFromItemnumber
./C4/Reserves.pm:353: ( $reservedate, $borrowernumber, $branchcode,
$reserve_id, $waitingdate ) = GetReservesFromItemnumber($itemnumber);
./C4/Reserves.pm:361:sub GetReservesFromItemnumber {
./circ/transferstoreceive.pl:102:            my @checkreserv =
GetReservesFromItemnumber($num->{'itemnumber'});
./opac/opac-reserve.pl:434:        my
($reservedate,$reservedfor,$expectedAt,undef,$wait) =
GetReservesFromItemnumber($itemNum);
./reserve/request.pl:331:            my
($reservedate,$reservedfor,$expectedAt,$reserve_id,$wait) =
GetReservesFromItemnumber($itemnumber);
./catalogue/detail.pl:223:    my
($reservedate,$reservedfor,$expectedAt,undef,$wait) =
GetReservesFromItemnumber($item->{itemnumber});
./t/db_dependent/Reserves.t:269:# Tests for bug 9788: Does
GetReservesFromItemnumber return a future wait?
./t/db_dependent/Reserves.t:270:# 9788a: GetReservesFromItemnumber does not
return future next available hold
./t/db_dependent/Reserves.t:280:my @results=
GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Reserves.t:281:is(defined $results[3]?1:0, 0,
'GetReservesFromItemnumber does not return a future next available hold');
./t/db_dependent/Reserves.t:282:# 9788b: GetReservesFromItemnumber does not
return future item level hold
./t/db_dependent/Reserves.t:287:my @results=
GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Reserves.t:288:is(defined $results[3]?1:0, 0,
'GetReservesFromItemnumber does not return a future item level hold');
./t/db_dependent/Reserves.t:289:# 9788c: GetReservesFromItemnumber returns
future wait (confirmed future hold)
./t/db_dependent/Reserves.t:291:my @results=
GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Reserves.t:292:is(defined $results[3]?1:0, 1,
'GetReservesFromItemnumber returns a future wait (confirmed future hold)');
./t/db_dependent/Holds.t:79:my ( $reservedate, $borrowernumber, $branchcode,
$reserve_id ) = GetReservesFromItemnumber($itemnumber);
./t/db_dependent/Holds.t:80:ok($reserve_id, "Test
GetReservesFromItemnumber()");
./t/db_dependent/Holds.t:95:( $reservedate, $borrowernumber, $branchcode,
$reserve_id ) = GetReservesFromItemnumber($itemnumber);
mtompset at ubuntu:~/kohaclone$ perldoc C4/Reserves.pm | grep
GetReservesFromItemnumber
        ( $reservedate, $borrowernumber, $branchcode, $reserve_id, $waitingdate
) = GetReservesFromItemnumber($itemnumber);
mtompset at ubuntu:~/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:30:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:30:10 +0000
Subject: [Koha-bugs] [Bug 11175] New: Show the parent records child records
 (aka. component parts) in the detailed views.
Message-ID: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

            Bug ID: 11175
           Summary: Show the parent records child records (aka. component
                    parts) in the detailed views.
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: gmcharlt at gmail.com
          Reporter: olli-antti.kivilahti at jns.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

TERMINOLOGY:
"Child record" or "Component part": A Bibliographic record connected to it's
host record via $773w -> 001 or via other Record-control-number-index relation.
"Host record": A bibliographic record which contains child records. Host record
doesn't have a link to the child record.

USEFUL:
For music cataloguers whose jobs depend on these.
For browsing the contents of a musical record.
Provides the basis for a high quality music library service.

Because Koha has the building blocks to create these child records out of box,
it is odd that they can't be displayed out of box.


This patch adds a system preference AddChildRecordsToDetailedViews.
This controls if child records data is appended after the bibliographic data
for XSLT parsing.
Also makes sure that child records are not pulled needlessly for non-detailed
views as this would cripple performance.

Modifies the default XSLT templates:
 MARC21slim2intranetDetail.xsl and
 MARC21slim2OPACDetail.xsl
to display the child record data as HTML.
Modifies .css files as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:30:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:30:44 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent records child records (aka.
 component parts) in the detailed views.
In-Reply-To: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-xmg1ztAZGE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
  Change sponsored?|---                         |Sponsored

--- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Sponsored by the Joensuu Regional Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:33:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:33:24 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent records child records (aka.
 component parts) in the detailed views.
In-Reply-To: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-LfELy0upzq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

--- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22612
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22612&action=edit
Bug 11175 - Show the parent records child records (aka. component parts) in the
detailed views.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:52:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:52:44 +0000
Subject: [Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in
 opac-authoritiessearchresultlist
In-Reply-To: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11174-70-O4znLOhj5C@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174

--- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> ---
Created attachment 22613
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22613&action=edit
Changes for opac-authoritiessearchresultlist templates

Patch for prog and bootstrap

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 19:53:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 18:53:04 +0000
Subject: [Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in
 opac-authoritiessearchresultlist
In-Reply-To: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11174-70-VnXVmtKPTF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174

Zeno Tajoli <z.tajoli at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 20:13:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 19:13:18 +0000
Subject: [Koha-bugs] [Bug 11174] Wrong paramter 'valuec' in
 opac-authoritiessearchresultlist
In-Reply-To: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11174-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11174-70-sMytYzi6du@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11174

--- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> ---
Test plan:

1)Insert an authority record with a 5xx field  (on MARC21 or UNIMARC)
2)Index the record
3)Seek the record
4)Clik one of the link build from the 5xx field, the link doesn't work
5)Apply the patch
6)Close the browser
7)Open the opac and select the english interface
8)Redo the search 
9)Now the link works
10)To use the patch in others languages you need to regenerate the templates.


After test the 'prog' templates you need to test it with to 'bootstrap'
templates but it is not clear for me how to do, ask on koha-dev mailing list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Oct 30 22:11:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 21:11:05 +0000
Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to
 return an item
In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9011-70-ldo3qvoE58@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jdemuth at roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 00:00:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 23:00:00 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-azFjzwjez9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, not sure, but would we not be using <br/> and HTML block elements to create
line breaks in HTML overdues? If I am using HTML I might make line breaks for
better and easier readable display and wouldn't want those interpreted as new
lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 00:13:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 30 Oct 2013 23:13:47 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-mmDtPVTXVl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm that last sentence didn't make sense: make line breaks for an easier
readable template, but don't want them to appear in my notice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 01:46:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 00:46:28 +0000
Subject: [Koha-bugs] [Bug 11167] Remove memcached config from
	koha-conf-site.xml.in
In-Reply-To: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11167-70-BsvnUQcrcT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22576|0                           |1
        is obsolete|                            |

--- Comment #2 from Robin Sheat <robin at catalyst.net.nz> ---
Created attachment 22614
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22614&action=edit
Bug 11167 - Remove memcached config from koha-conf-site.xml.in

Memcached-configuration is now done with environment variables
or SetEnv in the Apache configs. Having remnants of the now
obsolete configuration in koha-conf.xml might cause confusion as
to where memcached is actually configured. This patch removes the
two lines related to memcached from koha-conf-site.xml.in

To test, the hard way:
- Apply the patch
- Build packages
- Install package
- Create instances and enable memcached
- Check that memcached is used, even without the settings in
  koha-conf.xml

To test, the easy way:
- On an installation running off the packages, verify that memcached
  is actually configured through environment variables/SetEnv in the
  Apache configs, and not through koha-conf.xml

Signed-off-by: Robin Sheat <robin at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 01:46:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 00:46:46 +0000
Subject: [Koha-bugs] [Bug 11167] Remove memcached config from
	koha-conf-site.xml.in
In-Reply-To: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11167-70-Ec4rYGtsye@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 01:46:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 00:46:55 +0000
Subject: [Koha-bugs] [Bug 11167] Remove memcached config from
	koha-conf-site.xml.in
In-Reply-To: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11167-70-6mK9ClYyOL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 03:01:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 02:01:56 +0000
Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should
 undebar automatically when returned
In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2720-70-eTUdlYz8lu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #48 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 03:25:02 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 02:25:02 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-7wKfSiq5fC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |gmcharlt at gmail.com

--- Comment #83 from Galen Charlton <gmcharlt at gmail.com> ---
Patch doesn't apply on account of the renaming of the serial claims export
script -- tossing back for the patch submitter to rebase.  Feel free to set
back to passed QA afterwards so that I can try to make this in before the
string freeze window closes.

General note for the future -- it would have been better if the patch for
renaming the existing script had stayed separate; in fact, that kind of
refactoring should have been a separate bug since the name of the serials claim
export script has no direct bearing on the functionality of the feature
proposed here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 04:02:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 03:02:40 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-RNMh6pCh8Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |gmcharlt at gmail.com

--- Comment #51 from Galen Charlton <gmcharlt at gmail.com> ---
Marking as failed QA, sorry.

This patch series (after fixing merge) conflicts, blows up every nearly every
DB-dependent serials unit test that calls GetSubscription() with an error
similar to this:

Can't use an undefined value as a HASH reference at
/home/gmc/koha/C4/Serials.pm line 2808, <DATA> line 558.

This, ultimately, is because the patch series makes it *required* that there is
a valid userenv, which was not the case before. can_edit_subscription() should
be revised so that it doesn't crash if there's no userenv.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 06:32:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 05:32:41 +0000
Subject: [Koha-bugs] [Bug 9044] Allow to select items on catalogue/detail.pl
 and trigger actions
In-Reply-To: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9044-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9044-70-gm6e6COHce@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9044

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #50 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks Julian!

I also pushed a follow-up that adds the toolbar menu items back.  From the
commit message:

    My rationale: the question of the best UI for selecting items for
    batch operations is not yet settled.  Adding the ability to select
    items from the bib details page is indeed useful, but as currently
    implemented, it can hide the availability of the batch
    edit/deletion operations if no item is yet selected.  Although
    having both the toolbar items and the links that display when an
    item is selected is a bit redundant, for now I think we can live
    with that until we get more eyes on the UI.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 06:40:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 05:40:15 +0000
Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted
In-Reply-To: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8231-70-agymF75v61@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #22 from Galen Charlton <gmcharlt at gmail.com> ---
This patch no longer applies.  This is more than just a merge conflict; the
change in the restriction introduced for bug 2720 should be taken into account.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 06:45:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 05:45:03 +0000
Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type
 Choice, choices being "no", "yes", "force"
In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7825-70-4Iee0WLIKo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |gmcharlt at gmail.com

--- Comment #79 from Galen Charlton <gmcharlt at gmail.com> ---
Patch no longer applies; merge conflict is not straightforward to resolve.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 06:55:23 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 05:55:23 +0000
Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart
In-Reply-To: <bug-9456-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9456-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9456-70-wOdDGpry3w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #87 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 08:45:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 07:45:06 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-26MAJX1p7U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21750|0                           |1
        is obsolete|                            |

--- Comment #39 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22615
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22615&action=edit
Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

Adds three tests to Reserves.t for GetReservesFromItemnumber.
We test if this routine does not return a future next available hold,
a future item level hold. And if it does return a future wait (that is:
a confirmed future hold, using ConfirmFutureHolds).

Note that Holds.t does also contains some basic tests for this routine,
but the additional tests seem to better located in the direct context of
tests for bug 9761 for ConfirmFutureHolds.

Test plan:
Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
Verify if both tests do not fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 08:46:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 07:46:24 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-h37qBVvD2k@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #40 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #37)
>  FAIL   t/db_dependent/Reserves.t
>    FAIL   valid
>                 "my" variable @results masks earlier declaration in same
> scope

> Oops! Caught this while looking at the other patch, not signed off patch. I
> really should run this all the time. Sorry, I should not have signed off.

Thanks for testing. Easy fix. Deleted two my's.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:16:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:16:49 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-wZ2dpMhI5M@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22601|0                           |1
        is obsolete|                            |

--- Comment #44 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22616
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22616&action=edit
Bug 10855: Update database entry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:17:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:17:30 +0000
Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions
In-Reply-To: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10855-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10855-70-4t4JKAuUuV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #45 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Paola Rossi from comment #43)
> In installer/data/mysql/updatedatabase.pl, there a 'q' instead of 'qq' in
> two lines, and in kohastructure.sql the ending char of two lines is wrong
> [v. ENGINE=InnoDB DEFAULT CHARSET=utf8 |].
> So I pass the patch to "failed QA" status.

The typo was in kohastructure.
The q syntax is valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:21:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:21:56 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-NDceHLJngy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #41 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #38)
> It seems that initially, the code was NOT called with a parameter passed for
> $alldates, and so the unless statement was always run. This is why it was
> moved up into the SQL, which is working. I suppose ordering by priority is
> considered part of the improvements too. And with the addition of the
> waitingdate into the SQL statement there is an improvement by including a
> confirmed future hold. Though, this is the part that makes me feel
> uncomfortable signing this off, even though it probably is okay.

Thanks for your comments.
Note that ordering by priority is a logical step. It actually solves the
following very small bug: If you have two item-level holds, the first is on
date A and the second is on date A-1, the second hold will have priority 1, but
catalogue/detail will show the first hold with priority 2 (because priority was
not used but just record order). This bug does not really hurt, it is just
wrong presentation. The priority sort fixes it. 

On the future hold: Could you further clarify? What makes you feel
uncomfortable about that part?
The idea behind this is: With ConfirmFutureHolds enabled, you confirmed a hold
for tomorrow. Currently, the routine checks <= NOW and thus ignores the fact
that the book is already waiting for borrower A (with highest priority) and
could say that it is still available (when no holds are returned) but it is no
longer. Makes that sense for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:25:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:25:28 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-KNOZbxl7WV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:25:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:25:32 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-Y0DdC7glW7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21383|0                           |1
        is obsolete|                            |
  Attachment #21384|0                           |1
        is obsolete|                            |
  Attachment #21385|0                           |1
        is obsolete|                            |
  Attachment #21386|0                           |1
        is obsolete|                            |
  Attachment #21387|0                           |1
        is obsolete|                            |
  Attachment #21523|0                           |1
        is obsolete|                            |

--- Comment #84 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22617
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22617&action=edit
Bug 7298 Export late orders as csv

This patch allows to export late orders as csv.

Test plan:
- Go on the late orders page (acqui/lateorders.pl)
- Select one or more order and click on the button "export as CSV".
- The generated file should contains some information on the orders
  (order date, estimated delivery date, vendor name, information field,
  cost, basket name (and basketid), claims count and the claimed date)
  The last line of the file is the total of orders.
- You are not allow to select order from different vendor.
- The check/uncheck all links appears only if a vendor is selected.
- Check that the check/uncheck works for all pages of the table.

Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr>
Signed-off-by: Paul Poulain <paul.poulain at biblibre.com>
Signed-off-by: sonia <koha at univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Testing comments on last patch in this series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:25:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:25:42 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-Q6KHqyv35U@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #85 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22618
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22618&action=edit
Bug 7298: Follow-up fixing capitalization and moving supplier id

Fixes a few capitalization errors on the late orders page like
- Claim orders
- filter
- Search results

Also moves the supplierid from the order date column to the
vendor column.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: sonia <koha at univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:25:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:25:48 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-vYcgzOZBkt@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #86 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22619
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22619&action=edit
Bug 7298: FIX checkboxes binding on load

Click on checkboxes should be bound on load.

Signed-off-by: sonia <koha at univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:25:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:25:55 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-p5CIba11RB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #87 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22620
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22620&action=edit
Bug 7298: CSV strings are translatables.

Using a template file, the CSV headers become translatable.

Signed-off-by: sonia <koha at univ-lyon3.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:26:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:26:01 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-UrcjQpeVdo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #88 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22621
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22621&action=edit
Bug 7298: QA Followup

- use Modern::Perl;
- GPL version
- tabs

Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Passes QA script and all tests.

Testing notes:
- CSV header row is now translatable.
  Tested by updating the German po files and checking for the line.
- Tested that claiming for late serial issues still works as
  expected, as one file has been renamed. Filed 10931 for
  untranslatable CSV contents.
- Tested that claiming late orders still works:
  * Table searching and sorting
    Works nicely, but some columns could be split up for better
    searching and sorting:
      * Order date: 20/01/2013 (245 days)
      * Total cost:     10.00x1 = 10.00 Books
        => item type should be separate
      * Basket:  10 MPL
        => Library and basket number could be separate columns
  * Filters
     * Combined various filters, search results look correct.
  * Selecting order for claiming
      * Limiting by vendor makes it possible to check/uncheck all
      * With no vendor limit, entries for other vendors will be
        locked after the first checkbox is checked for one vendor
  * Exporting as CSV
     * Exported single line > CSV appears correct.
     * Exporting multiple lines > CSV appears correct.
     PROBLEM: Translated CSV don't work correctly, as line
     breaks are lost in the translation process.
     Needs to be fixed in a follow-up.
  * Sending serial claim email
     * No regressions found - there are some problems with the
       email contents noted on bug 7298.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:26:08 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:26:08 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-dg4ITuEcVI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #89 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22622
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22622&action=edit
Bug 7298: Followup: CSV strings are translatables.

Following the same way as bug 10935, the headers are in an include file.

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>
Translatability tested successfully.
Passes all tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:27:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:27:28 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-H8cnZsU9tz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #90 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Galen,
All patches rebased.
The serial claims export does not work, see bug 11168.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:39:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:39:04 +0000
Subject: [Koha-bugs] [Bug 6815] Capture member photo via webcam
In-Reply-To: <bug-6815-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6815-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6815-70-NR27yQiXs4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

Amruta <amrutapatil_30 at yahoo.in> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amrutapatil_30 at yahoo.in

--- Comment #2 from Amruta <amrutapatil_30 at yahoo.in> ---
Created attachment 22623
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22623&action=edit
how to take Instead of uploading a file, capture the image directly from a
webcam

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:51:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:51:14 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-gjWECVwavo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:51:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:51:19 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-6FXv0CeKTd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21286|0                           |1
        is obsolete|                            |
  Attachment #21287|0                           |1
        is obsolete|                            |
  Attachment #21288|0                           |1
        is obsolete|                            |
  Attachment #21289|0                           |1
        is obsolete|                            |

--- Comment #52 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22624
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22624&action=edit
Bug 8435: If IndependantBranches is on, Serials can't be manage from others
libraries

In the serial module, we want to hide serials from others libraries.
New permission 'superserials'. If a patron have this permission, he can
override this restriction.

Test plan:
- Switch on the IndependantBranches syspref
- Add the permission 'superserials' for a patron and test you can
  navigate and see all serials
- Remove this permission and test you cannot manage/view subscriptions
  from others libraries

Signed-off-by: Frederic Durand <frederic.durand at unilim.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:51:25 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:51:25 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-Jiqy0NCnkX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #53 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22625
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22625&action=edit
Bug 8435: Followup add unit tests for can_edit_subscription

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:51:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:51:31 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-PJF5TNJ8gP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #54 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22626
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22626&action=edit
Bug 8435: use a transaction for unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:51:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:51:36 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-Iy7q65Mf3S@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #55 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22627
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22627&action=edit
Bug 8435: The unit tests should create the biblio

Previous version does not create the biblio.

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:51:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:51:41 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-5UNbeGG9sT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #56 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22628
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22628&action=edit
Bug 8435: Fix unit tests

C4::Serials::can_edit_subscription now deals with C4::Context->userenv.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 09:53:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 08:53:50 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-kq6dfnhYWM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

--- Comment #57 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #51)
> This, ultimately, is because the patch series makes it *required* that there
> is a valid userenv, which was not the case before. can_edit_subscription()
> should be revised so that it doesn't crash if there's no userenv.

Galen, I fixed that and added a new unit tests to check the userenv value.
The behavior is: without userenv, subscriptions cannot be edited.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 10:01:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 09:01:49 +0000
Subject: [Koha-bugs] [Bug 10092] Small improvements on serial missinglist
 and receivedlist
In-Reply-To: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10092-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10092-70-CUGRe8CSUC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10092

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #12 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
And yet another patch (from April 22 !!) down the drain..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 10:57:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 09:57:16 +0000
Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections
In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8836-70-U6TYubrZkW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836

--- Comment #27 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Also unit tests are required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:12:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:12:42 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-q7Ku1T0FTc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

--- Comment #8 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Some of the added transliteration rules are default ICU behaviour, i.e.
stripping accents. 

I'm a bit wary of this shipping as default as a polish language library would,
I assume, have to undo this. And why Polish especially? What about Norwegian
with its extra characters? I wonder if for release what is needed is rather
some documentation on 'how to alter normalization of non-ascii characters'. It
might call for a bit of research

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:28:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:28:04 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-uEoKcrOBI9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22587|0                           |1
        is obsolete|                            |

--- Comment #22 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22629
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22629&action=edit
Bug 10589 - Override OpacHiddenItems based on Patron Category

Two system preferences, PatronSingleBranch and
PatronEveryBranch, have been added to facilitate some
granularity on the override.

If the home branch of the item and the patron match and the
catgegory code of the patron matches one of the pipe delimited
values in the PatronSingleBranch patron category code, then
an item which would normally be hidden will be visible.

If the patron category matches one of the pipe delimited
values in the PatronEveryBranch patron category, then every
item hidden by OpacHiddenItems will be visible.

Since the patron category codes used by default for these
two system preferences are not added, OpacHiddenItems will
continue function as expected until individual patrons and
system preferences are configured.

There is no need to provide this functionality to staff,
as they have access to the staff client.

Rebased to current master (again).

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:38:56 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:38:56 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-H0Rl3jykjE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Code looks good to me. Works as advertised. No complaints from qa tools.
Passed QA

Just some smaller points (no blockers imo):
1) No unit tests. Adding these makes the chance of a push considerably larger
:)
2) The names of the prefs are not completely explanatory on itself. The name
does not give a clue that this pref has to do with unhiding items for some
patron categories.
3) The dbrev for install and upgrade contains empty string for the
systempreferences fields options and type. This works, but imo it should be
better (more consistent) to set type to Free and options to NULL. (Please have
a look at other prefs.)
4) To make it easier for the user, a followup could update the description of
OpacHiddenItems making the user aware that these two new prefs make it possible
to fine-tune its behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:39:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:39:11 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-KoUh3TDDmG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:40:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:40:28 +0000
Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron
	Category
In-Reply-To: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10589-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10589-70-G7BJd4xbBj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589

--- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. de Rooy from comment #23)
> 1) No unit tests. Adding these makes the chance of a push considerably
> larger :)

Reading back, I happen to notice that there seem to be tests under another
report. Sorry for that..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:46:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:46:12 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-JdncV2HoS4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
          'branchcode' => 'LIB1'
        };

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`kohatest`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN
KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at
/usr/share/koha/testclone/C4/SQLHelper.pm line 184.
# Sample Borrower added.
CHECK: 0
MflvoMfsof
# 199954 - LIB1
# 199955 - LIB2

Mark: It seems that your tests depend on some branch codes that do not always
exist. Could you take that into account?
Perhaps add these branch codes in that case, and roll back at the end?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 11:46:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 10:46:19 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-EncOLHgEzl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:02:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:02:03 +0000
Subject: [Koha-bugs] [Bug 10523] Remove two obsolete routines from
	Installer.pm
In-Reply-To: <bug-10523-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10523-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10523-70-IlgHbMWOr1@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21016|0                           |1
        is obsolete|                            |

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 21016
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21016
Bug 10523: QA Followup - Remove unused variable

Obsoleting this patch in light of the earlier comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:17:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:17:26 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-7EQbRjBu1F@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

--- Comment #9 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
(In reply to Colin Campbell from comment #8)
> I wonder if for release what is needed
> is rather some documentation on 'how to alter normalization of non-ascii
> characters'. It might call for a bit of research
Ok for documentation, there is indeed such a page on wiki for arabic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:17:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:17:44 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-f0k0PJO8o3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22599|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:17:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:17:55 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-pr3Ysv6PuM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:18:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:18:20 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-seZJ4hLSJ0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

--- Comment #10 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
I set to discussion while i create the wiki page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:23:03 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:23:03 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-hH6ZJy1eJD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Jonathan:
If there are still suggestions, there is also the Delete selected button below.
If you click on that button without a selection, it still says: Selected sugg
have been deleted.

For consistency, I would recommend adjusting that too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:28:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:28:20 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-9ldkFioRKo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22370|0                           |1
        is obsolete|                            |

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22630
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22630&action=edit
Bug 11134 - Typo on course reserves help

This patch fixes a small typo on course reserves help

To test:
1) Go to Course reserves
2) Press 'New course'
3) Press Help
4) On 3dr paragraph you will read "To link a ninstructor ..."
5) Apply patch
6) Now it reads "To link an instructor ..."

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:29:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:29:47 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-n35f5bJzg7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
As an exception to the rule, I move the status via Signed off to Passed QA for
this very trivial typo solver patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:30:29 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:30:29 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-sEChxUqEjm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:30:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:30:35 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-QklpT25h70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:31:09 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:31:09 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-JrKRsNyIaA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:51:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:51:32 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-WWCvyPT1iO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22611|0                           |1
        is obsolete|                            |

--- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22631
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22631&action=edit
Bug 11173 : Notifications by email lacks carriage returns if content type is
HTML

Test plan :
- Define one letter template for overdues for example
- Check "HTML Message"
- Define some overdue rules that are using this letter
- Find one borrower that has overdues triggering this notification.
- Run misc/cronjobs/overdue_notices.pl to generate the message and change
to_address to give your email

Without patch :
- run misc/cronjobs/process_messsage_queue.pl => email content is all on one
line

With the patch :
- change message status to 'pending' so that it could be sent once again
- run misc/cronjobs/process_message_queue.pl => email content is displaid
correctly with carriage returns as defined in template

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 12:54:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 11:54:57 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-MTspQDT52N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #2)
> Hm, not sure, but would we not be using <br/> and HTML block elements to
> create line breaks in HTML overdues? If I am using HTML I might make line
> breaks for better and easier readable display and wouldn't want those
> interpreted as new lines.

I guess that you would be formally right. But I think that most users (not
limited by extensive html knowledge..) would enjoy to get the line breaks as
they do now.

Looking forward to your QA remarks on that, Katrin. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:02:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:02:10 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-MMSbqk9OoH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:02:12 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:02:12 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-zBzBB2V87Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

--- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22632
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22632&action=edit
Bug 11135 Check variable exists before splitting

calling split on an undefined var generates warning to
the log. Lets check it exists before processing it

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:02:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:02:51 +0000
Subject: [Koha-bugs] [Bug 11176] New: Purchase suggestions should respect
 the 'active' switch on budgets
Message-ID: <bug-11176-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

            Bug ID: 11176
           Summary: Purchase suggestions should respect the 'active'
                    switch on budgets
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david.roberts at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

When creating a new purchase suggestion, all funds display and are available
for selection. 

The behaviour of this drop-down menu should mirror that of those drop-down
menus elsewhere in acquisitions, where only funds that are linked to active
budgets display to the user.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:03:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:03:42 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-KFrUuyGgEj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
           Severity|enhancement                 |normal

--- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
As an exception to the rule, I take the liberty to sign off and pass qa in one
run. This is a trivial patch that eliminates just another warning from the
logs.
Good catch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:03:55 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:03:55 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-2TATnDZqUa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22373|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:06:00 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:06:00 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-Og8zDAtCtR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:08:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:08:28 +0000
Subject: [Koha-bugs] [Bug 11176] Purchase suggestions should respect the
 'active' switch on budgets
In-Reply-To: <bug-11176-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11176-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11176-70-fGWLkIPP3w@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11176

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:23:57 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:23:57 +0000
Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special
	characters
In-Reply-To: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10939-70-pbHZuqlsRj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |INVALID

--- Comment #11 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
Done :

http://wiki.koha-community.org/wiki/Correcting_Search_of_Polish_records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:33:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:33:43 +0000
Subject: [Koha-bugs] [Bug 11177] New: Suppress No cover image available when
 there local image is available
Message-ID: <bug-11177-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11177

            Bug ID: 11177
           Summary: Suppress No cover image available when there local
                    image is available
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: imingchan at yahoo.com.au
        QA Contact: testopia at bugs.koha-community.org

Created attachment 22633
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22633&action=edit
Catalogue records for photographs

"No cover image available" is showing directly underneath an uploaded local
picture.  Will be nice that this can be hidden.  See screen image sample
attached.

Have tried to limit one uploaded local cover image to each catalogue, but this
made no difference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:34:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:34:04 +0000
Subject: [Koha-bugs] [Bug 11177] Suppress No cover image available when
 local image is available
In-Reply-To: <bug-11177-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11177-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11177-70-bujcfXFUPT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11177

Iming Chan <imingchan at yahoo.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Suppress No cover image     |Suppress No cover image
                   |available when there local  |available when local image
                   |image is available          |is available

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:34:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:34:39 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-3NGk50Dxru@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:34:43 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:34:43 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-IWMcbhDvS9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22172|0                           |1
        is obsolete|                            |

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22634
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22634&action=edit
Bug 11084 - Delete biblios on Leader 05 == d

Position 05 of the leader in MARC 21 indicates the record's status.
A lower case 'd' indicates that the record is to be deleted
(http://www.loc.gov/marc/authority/adleader.html).

This patch adds a cronjob script that may be run nightly to delete
records where position 05 of the leader is set to 'd'.

Test Plan:
1) Edit one or more records, and set the leader position 05 to 'd'.
2) Run misc/cronjobs/deleted_fixed_field_5.pl -c -v
3) Those records should either be deleted, or an error message should
   state why they were not.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Works as advertised. Put some points of attention on Bugzilla comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:35:32 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:35:32 +0000
Subject: [Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
In-Reply-To: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11084-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11084-70-nLKJ1U9jbN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Signing off but with some smaller comments:

typo delete_fixec_field_5.pl
test mode should be explained (not in usage)
name of the script could be confusing: you are obviously not deleting a fixed
field, but a record :)
encoding: when you are printing the title to stdout, you should probably open
stdout as utf8
verbose mode: would it be helpful to say which biblios or items were actually
deleted (and count them?)
license statement: version 2 or 3? address no longer?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:59:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:59:06 +0000
Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email
 notification when content type is html
In-Reply-To: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11173-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11173-70-WtnjGh4jI0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Well, I disagree. If I work with HTML, I want it to behave like HTML, else I
will have to write insanely long lines to avoid accidental line breaks - which
doesn't seem right to me. And I lose the ability that HTML gives me - to
control the layout more exactly that I can do with plain text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:59:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:59:40 +0000
Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type
 Choice, choices being "no", "yes", "force"
In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7825-70-Qpe9iBUKjS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 13:59:46 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 12:59:46 +0000
Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type
 Choice, choices being "no", "yes", "force"
In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7825-70-zDQJbMvJT7@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18926|0                           |1
        is obsolete|                            |
  Attachment #18927|0                           |1
        is obsolete|                            |
  Attachment #18928|0                           |1
        is obsolete|                            |

--- Comment #80 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22635
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22635&action=edit
Bug 7825: Changed OPACItemHolds syspref to be no|tes|force choice

Currently, the Koha system preference OPACItemHolds allows a library
system to choose to allow patrons to place bib and item level holds from
the OPAC, or to allow patrons only to place bib level holds only from
the opac.

This patch set adds a third option, "force", which *requires* that
patrons place item level holds from the opac, with no option of making a
bib level hold.

This patch modifies the system preference OPACItemHolds to be of the
type "Choice", with the choices being "no", "yes", "force". The patch
does not alter the currently set value of OPACItemHolds for database
updates, only adding the additional option.

Test Plan:
1) Set OPACItemHolds to "no". Check that OPAC holds behave as it is now
(no "Place On" column, no "Select a specific copy" table, making a
reserve is successful)
2) Set OPACItemHolds to "yes". Check that OPAC holds behave as it is now
( "Place On" column is there, "Select a specific copy" table shows when
"A specific copy" is selected, making a reserve is successful)
3) Set OPACItemHolds to "force". Check that OPAC holds behave as follows:
  -  no "Place On" column is present
  -  "Select a specific copy" table is opened
  -  making a reserve is successful

This patch is a squashed patch of the 3 following patches:

Amended opac-reserve.tt accordingly

Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com>

Bug 7825: Followup prevent submission without choosing an item

+ Fix some ergonomic issues in opac-reserve

Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com>

Bug 7825: Updatedatabase should only change the type and options values.

The value field should not be change. We have to keep '1' for 'yes' and ''
for 'no'.

Original patch is from Srdjan Jankovic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:01:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:01:35 +0000
Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type
 Choice, choices being "no", "yes", "force"
In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7825-70-dhlyV8odhl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

--- Comment #81 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to Galen Charlton from comment #79)
> Patch no longer applies; merge conflict is not straightforward to resolve.

Not easy to rebase, bug 10836 changed a big part of the html stucture.
Switch back to Needs Signoff :-(

I squashed all 3 patches, I did not manage to rebase them cleanly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:08:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:08:36 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-9sVzO18EhS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19789|0                           |1
        is obsolete|                            |

--- Comment #47 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22636
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22636&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl

Adds a column to indicate holds on recieved items, as well as adding
a new column for fund and showing the subtotals per fund above
the total subtotal.

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:08:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:08:44 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-ZEETXB56fJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19790|0                           |1
        is obsolete|                            |

--- Comment #48 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22637
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22637&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl - QA
Followup

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:08:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:08:51 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-GtzePx83RK@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19791|0                           |1
        is obsolete|                            |

--- Comment #49 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22638
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22638&action=edit
Bug 8037 - Add holds and funds to items already received in parcel.pl - QA
Followup 2

Adds the note "GST exc." for subtotals by fund.

Signed-off-by: Pierre Angot <tredok.pierre at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:11:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:11:11 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-dIy2RWbQML@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

--- Comment #50 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Rebased the "first three" but this last followup 

Applying: Bug 8037: FIX bad sql query and variable renaming
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 8037: FIX bad sql query and variable renaming

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:18:05 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:18:05 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-o3f1mAlmbi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22390|0                           |1
        is obsolete|                            |

--- Comment #51 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22639
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22639&action=edit
Bug 8037: FIX bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:22:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:22:26 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-fx33asmrur@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:22:30 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:22:30 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-JTu9amSMd6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22615|0                           |1
        is obsolete|                            |

--- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22640
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22640&action=edit
Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

Adds three tests to Reserves.t for GetReservesFromItemnumber.
We test if this routine does not return a future next available hold,
a future item level hold. And if it does return a future wait (that is:
a confirmed future hold, using ConfirmFutureHolds).

Note that Holds.t does also contains some basic tests for this routine,
but the additional tests seem to better located in the direct context of
tests for bug 9761 for ConfirmFutureHolds.

Test plan:
Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
Verify if both tests do not fail.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:27:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:27:51 +0000
Subject: [Koha-bugs] [Bug 11127] OPAC suggestion: the delete link is active
 when no suggestion selected
In-Reply-To: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11127-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11127-70-Gjp4HbRGbn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11127

--- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Owen,
Why are there 2 ways to delete selected suggestions? Should not we keep only
the button on the bottom?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:29:48 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:29:48 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-6iUqFCq5cM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21479|0                           |1
        is obsolete|                            |

--- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22641
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22641&action=edit
Bug 9788: Followup removing the alldates parameter

Before bug 9788 the alldates parameter of GetReservesFromItemnumber was
actually not used in the codebase.
The first patch of bug 9788 did change that and passed true by default.

But a closer look revealed that we do not really need it.
The parameter is removed by this patch; the SQL statement is slightly
adjusted: if reservedate<=now or a waitingdate is filled for the
requested itemnumber, GetReservesFromItemnumber will return the reserve.
This includes so-called future waits: a future hold that has been confirmed
ahead of time with pref ConfirmFutureHolds > 0 days.

Note that future item-level holds are not really interesting to return; this
just corresponds to original behavior. Future next-available holds are not
in view at all; they do not contain an item number.

Test plan:
Actually, the test plan of the first patch is valid. But for completeness I
repeat it here:

[1] Enable future holds and set ConfirmFutureHolds to 2 days.
[2] Place a future next-available hold for 2 days ahead.
[3] Check item status on catalogue detail. Available? That is fine.
[4] Confirm the future hold by checking it in. ('future wait')
[5] Look at item status again on catalogue detail. Must be Waiting now.
[6] Switch to OPAC and login as another opac user. Goto Place a hold.
[7] Check item status with item level hold info. Is it waiting?
[8] Try to place hold in staff, check item level status again. Waiting?
[9] Make a transfer for the item. Switch branch. Check hold status on
    Transfers to receive.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:29:59 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:29:59 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-lNwnGZv1tB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22642
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22642&action=edit
Bug 9788: Followup for expirationdate in Letter.pm

Pasting comment from the Bugzilla report:
Looking bit longer at this code, it is kind of strange to find it there in the
first place. Adding maxpickupdelay in Letters.pm should not be there, but it
is..

Also this date is not used normally in the default HOLD Available for Pickup
notice (that we are generating in this case). And if it would be undef, the
expiration date should imo be empty instead of today+0. (before adding
maxreservespickupdelay, you should test the allowexpire pref first)
So it is an (invisible) bug on its own.

Test plan:
See former patch. Kyle just discovered this bug, apparently by deleting the
maxpickupdelay pref..

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:31:28 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:31:28 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-raL64lXWuc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19943|0                           |1
        is obsolete|                            |
  Attachment #22309|0                           |1
        is obsolete|                            |
  Attachment #22640|0                           |1
        is obsolete|                            |
  Attachment #22641|0                           |1
        is obsolete|                            |
  Attachment #22642|0                           |1
        is obsolete|                            |

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22643
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22643&action=edit
Bug 9788: Improvements when calling GetReservesFromItemnumber

Description:
GetReservesFromItemnumber also returns waiting date. Simplifies some code.
Improves item status display on catalogue detail, when placing a hold at
opac-reserve and in staff, and on transfers to receive form.

This patch builds on work from reports 9367 and 9761.

Test plan:
Place a future next-av. hold (enable future holds prefs), say 2 days ahead.
Check item status on catalogue detail. Nothing to see.
Enable ConfirmFutureHolds by inserting a number of days, say 2.
Confirm earlier hold by checking it in. Look at item status again on detail.
Switch to other opac user. Try to place a hold again. Check item status with
item level hold info. Try to place hold in staff, check item level status.
Make a transfer for that item. Switch branch. Look at transfers to receive.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:31:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:31:35 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-fAgJLfAjJI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22644
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22644&action=edit
Bug 9788: Followup removing the alldates parameter

Before bug 9788 the alldates parameter of GetReservesFromItemnumber was
actually not used in the codebase.
The first patch of bug 9788 did change that and passed true by default.

But a closer look revealed that we do not really need it.
The parameter is removed by this patch; the SQL statement is slightly
adjusted: if reservedate<=now or a waitingdate is filled for the
requested itemnumber, GetReservesFromItemnumber will return the reserve.
This includes so-called future waits: a future hold that has been confirmed
ahead of time with pref ConfirmFutureHolds > 0 days.

Note that future item-level holds are not really interesting to return; this
just corresponds to original behavior. Future next-available holds are not
in view at all; they do not contain an item number.

Test plan:
Actually, the test plan of the first patch is valid. But for completeness I
repeat it here:

[1] Enable future holds and set ConfirmFutureHolds to 2 days.
[2] Place a future next-available hold for 2 days ahead.
[3] Check item status on catalogue detail. Available? That is fine.
[4] Confirm the future hold by checking it in. ('future wait')
[5] Look at item status again on catalogue detail. Must be Waiting now.
[6] Switch to OPAC and login as another opac user. Goto Place a hold.
[7] Check item status with item level hold info. Is it waiting?
[8] Try to place hold in staff, check item level status again. Waiting?
[9] Make a transfer for the item. Switch branch. Check hold status on
    Transfers to receive.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:31:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:31:41 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-oNCapoiWLa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22645
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22645&action=edit
Bug 9788: Followup for expirationdate in Letter.pm

Pasting comment from the Bugzilla report:
Looking bit longer at this code, it is kind of strange to find it there in the
first place. Adding maxpickupdelay in Letters.pm should not be there, but it
is..

Also this date is not used normally in the default HOLD Available for Pickup
notice (that we are generating in this case). And if it would be undef, the
expiration date should imo be empty instead of today+0. (before adding
maxreservespickupdelay, you should test the allowexpire pref first)
So it is an (invisible) bug on its own.

Test plan:
See former patch. Kyle just discovered this bug, apparently by deleting the
maxpickupdelay pref..

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 14:31:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 13:31:47 +0000
Subject: [Koha-bugs] [Bug 9788] Improvements for calling
	GetReservesFromItemnumber
In-Reply-To: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9788-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9788-70-yR70JCqkdC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

--- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22646
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22646&action=edit
Bug 9788: Unit tests for changed routine GetReservesFromItemnumber

Adds three tests to Reserves.t for GetReservesFromItemnumber.
We test if this routine does not return a future next available hold,
a future item level hold. And if it does return a future wait (that is:
a confirmed future hold, using ConfirmFutureHolds).

Note that Holds.t does also contains some basic tests for this routine,
but the additional tests seem to better located in the direct context of
tests for bug 9761 for ConfirmFutureHolds.

Test plan:
Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t.
Verify if both tests do not fail.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:13:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:13:26 +0000
Subject: [Koha-bugs] [Bug 11134] Typo on course reserves help
In-Reply-To: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11134-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11134-70-1XfJplZMkY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11134

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to M. de Rooy from comment #3)
> As an exception to the rule, I move the status via Signed off to Passed QA
> for this very trivial typo solver patch.

I'm fine with this for typo fixes.

Pushed to master, thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:13:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:13:37 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-IHk9T7fl6q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22639|0                           |1
        is obsolete|                            |

--- Comment #52 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 22647
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22647&action=edit
Bug 8037: FIX bad sql query and variable renaming

The first patch does a left join on aqorders_items which returns too
much order lines.

This patch follows the Galen's suggestion: it removes the join and calls
the GetItemnumbersFromOrder routine for retrieving itemnumbers.

Bonus: the "parcelitems" variable is badly named and obfuscates the code.
I changed it for "orders".

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:17:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:17:35 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-eaZiII3aeP@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:18:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:18:11 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-e2tgf1okUC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #53 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
I signed off on the last patch and looked at that one specifically.

no koha-qa warnings on all four patches
there was no test plan but I tested with AcqCreateItem=receiving, two orders on
one basket, received lines separately with second partially, placed hold on the
first item
ran perl t/db_dependent/Acquisition/Invoices.t: pass
ran perl t/Acquisition/Invoice.t: pass

I checked the calls to GetInvoiceDetails; removing the itemnumber from
aqorder_items seems to be no problem :) and solves the duplication problem.
Furthermore, the code looks good to me (code in last patch).

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:26:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:26:53 +0000
Subject: [Koha-bugs] [Bug 11135] Parsing of OVERRIDE_SYSPREF_NAMES logs
	warnings
In-Reply-To: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11135-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11135-70-OS9ypOFcTm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11135

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with a pendantic follow-up.  Thanks, Colin!

I sure wish there were a less verbose way to simultaneously check that a hash
key is present and that the value of it is defined, but c'est la vie.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:37:14 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:37:14 +0000
Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed
In-Reply-To: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8133-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8133-70-HNsmI20l49@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:38:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:38:19 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-AbDJMrIucG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #69 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22648
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22648&action=edit
Bug 10671: Update Cataloging Help

This patch updates the links to the manual in
the cataloging help files.

To test:

* Visit cataloging pages and click the help
* confirm links work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:46:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:46:18 +0000
Subject: [Koha-bugs] [Bug 10572] Add phone to message_transport_types table
 for new installs
In-Reply-To: <bug-10572-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10572-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10572-70-a8hkeDa0RY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10572

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #13 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:49:42 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:49:42 +0000
Subject: [Koha-bugs] [Bug 4812] Reserves for a specific copy of a book say
 book is available even though it it still checked out to someone else
In-Reply-To: <bug-4812-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4812-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4812-70-GdxvA8Zp3x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4812

Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolyn.somers at biblibre.co
                   |                            |m

--- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> ---
We have this problem for one of your libraries.
It is a real bug for me, not an enhancement.

By the way, I think the mean of ReservesNeedReturns is wrong, it generates
several bugs when inactive : 
- this bug
- you can place a waiting reserve when there is already a waiting reserve
- you do not have messages present is return page

In my opinion, reserves module is too weak to repair, this syspref should be
removed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:49:58 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:49:58 +0000
Subject: [Koha-bugs] [Bug 11175] Show the parent records child records (aka.
 component parts) in the detailed views.
In-Reply-To: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11175-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11175-70-HkOajlPVP4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22612|0                           |1
        is obsolete|                            |

--- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 22649
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22649&action=edit
Bug 11175 - Show the parent records child records (aka. component parts) in the
detailed views.

TERMINOLOGY:
"Child record" or "Component part": A Bibliographic record connected to it's
host record via $773w -> 001 or via other Record-control-number-index relation.
"Host record": A bibliographic record which contains child records. Host record
doesn't have a link to the child record.

USEFUL:
For music cataloguers whose jobs depend on these.
For browsing the contents of a musical record.
Provides the basis for a high quality music library service.

Because Koha has the building blocks to create these child records out of box,
it is odd that they can't be displayed out of box.

This patch adds a system preference AddChildRecordsToDetailedViews.
This controls if child records data is appended after the bibliographic data
for XSLT parsing.
Also makes sure that child records are not pulled needlessly for non-detailed
views as this would cripple performance.

Modifies the default XSLT templates:
 MARC21slim2intranetDetail.xsl and
 MARC21slim2OPACDetail.xsl
to display the child record data as HTML and link to the detailed views fopr
the child records.
Modifies .css files as well.

An extra container div is added to opac-detail.tt, mimicking presentation in
detail.tt, to prevent a possible long child records list from breaking
the opac-details -view.

--------------------------------------
TEST PLAN
--------------------------------------

PREREQUISITES:

-AddChildRecordsToDetailedViews system preference needs to be activated.

-Catalog a bunch of child records for a host record.
--Search a record and go to detailed view.
--Use the existing functionality "+ New" -> "New Child Record" to catalog child
records.

------------------------
TEST CASE1 - Staff client
------------------------

-Search for the record you just made and display it in the normal detail.pl
-view.
-Verify that a list of child records are displayed on the right side of the
browser window.

------------------------
TEST CASE2 - OPAC
------------------------

-Search for the record you just made and display it in the opac-detail.pl
-view.
-Verify that a list of child records are displayed on the right side of the
browser window.

------------------------
Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 15:59:06 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 14:59:06 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-zJLdq2tedR@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #70 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22650
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22650&action=edit
Bug 10671: Update Serials Help

This patch updates the links to the manual in
the serials help files.

To test:

* Visit serials pages and click the help
* confirm links work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:00:41 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:00:41 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-5MUABP4qdT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:00:49 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:00:49 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-mOA3ZGdG41@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:07:16 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:07:16 +0000
Subject: [Koha-bugs] [Bug 7478] Template/translation problem in
	catalogue_out.tt
In-Reply-To: <bug-7478-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7478-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7478-70-n57WiGilYn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7478

Tom?s Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> ---
This patch has been pushed to 3.12.x, will be in 3.12.7.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:10:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:10:26 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-D4JrD9YlrF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #71 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22651
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22651&action=edit
Bug 10671: Update Tools Help Files

This patch updates the links to the manual in
the tool help files.

To test:

* Visit tool pages and click the help
* confirm links work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:19:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:19:50 +0000
Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already
 received in parcel.pl
In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8037-70-HTEagoyKZq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #54 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master, along with some follow-ups.

Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:32:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:32:26 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-NkkemYge3n@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #72 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22652
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22652&action=edit
Bug 10671: Update Admin Help Files

This patch updates the links to the manual in the
help files. It also updates the text a bit in a few.

To test:

* Visit admin pages
* Check the help files on each
* Make sure links and text appears

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:38:38 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:38:38 +0000
Subject: [Koha-bugs] [Bug 8435] new permissions on subscriptions
	"superserials"
In-Reply-To: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8435-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8435-70-Mx8ANR5smD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8435

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #58 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:55:20 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:55:20 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-YCbZ7VrH8H@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #73 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22653
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22653&action=edit
Bug 10671: Update patron help files

This patch updates the text and links in the
patron related help files.

To test:

* visit all patron pages
* Click help
* confirm test and links

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 16:59:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 15:59:26 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7298-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7298-70-qMLl2pE50r@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #91 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:03:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:03:10 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-dmAm7GzReF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #74 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22654
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22654&action=edit
Bug 10671: Update Acq Help Files

This patch updates the Acq help file links
to the manual.

To test:

* visit acq pages
* confirm manual links are right

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:03:53 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:03:53 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-7NVpzscZ1V@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #75 from Nicole C. Engard <nengard at gmail.com> ---
These are the last of them - in before the string freeze this time :)

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:14:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:14:19 +0000
Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not
	mandatory
In-Reply-To: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11168-70-5Ft1oquICi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:14:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:14:26 +0000
Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not
	mandatory
In-Reply-To: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11168-70-QaloNhyaVC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:14:47 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:14:47 +0000
Subject: [Koha-bugs] [Bug 11168] GetLateOrMissingIssues: $supplierid is not
	mandatory
In-Reply-To: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11168-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11168-70-i98LZhYqsw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11168

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
I've taken the liberty of fast-tracking this as it fixes a regression.  Thanks,
Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:43:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:43:37 +0000
Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket
In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7295-70-4HTvSWczdf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #48 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:52:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:52:10 +0000
Subject: [Koha-bugs] [Bug 10523] Remove two obsolete routines from
	Installer.pm
In-Reply-To: <bug-10523-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10523-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10523-70-9INUcjrnz9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10523

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:54:24 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:54:24 +0000
Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using
 OpacSeparateHoldings
In-Reply-To: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10283-70-mmRJj93Uo6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 17:59:44 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 16:59:44 +0000
Subject: [Koha-bugs] [Bug 11142] Update Bootstrap theme's place hold form to
 match the new version in prog
In-Reply-To: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11142-70-9GDCYqfHiS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |gmcharlt at gmail.com

--- Comment #3 from Galen Charlton <gmcharlt at gmail.com> ---
Electing to push this to master now so that Bootstrap becoming the default
theme does not effectively cause a regression of bug 10836.

Thanks, Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:00:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:00:10 +0000
Subject: [Koha-bugs] [Bug 11142] Update Bootstrap theme's place hold form to
 match the new version in prog
In-Reply-To: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11142-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11142-70-CLY7zMLLM2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11142

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:02:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:02:04 +0000
Subject: [Koha-bugs] [Bug 11178] New: Make Bootstrap the default theme for
	new installs
Message-ID: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11178

            Bug ID: 11178
           Summary: Make Bootstrap the default theme for new installs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Following discussion on koha-devel (see
http://lists.koha-community.org/pipermail/koha-devel/2013-October/039944.html),
the consensus is that Bootstrap shall be the default OPAC theme for 3.14.  This
bug records this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:02:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:02:39 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-vk9cutoTfD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21153|0                           |1
        is obsolete|                            |

--- Comment #12 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22655
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22655&action=edit
Bug 10895 - Tests for C4::Items GetHiddenItems

Bug 10589 introduces PatronSingleBranch and PatronEveryBranch
system preferences. This ensures that the visibility of two
dummy records matches expectations. OpacHiddenItems is set
to hide 2 records. The system preferences are then toggled
between four cases ('SPT','SS','','SS|SPT') cross multipled
for the two system preferences to verify the correct visibility.

This will fail for a system with bug 10589 not applied, since
this tests the functionality of that patch. This will fail for a
system with bug 10900 not applied, since the calling convention
for set_userenv was fixed in C4::Context in this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:05:13 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:05:13 +0000
Subject: [Koha-bugs] [Bug 11178] Make Bootstrap the default theme for new
	installs
In-Reply-To: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11178-70-ly36OYkax3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11178

--- Comment #1 from Galen Charlton <gmcharlt at gmail.com> ---
Created attachment 22656
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22656&action=edit
Bug 11178: Make the Bootstrap OPAC theme the default for new installs

This patch implements the proposal adopted by the community to
make Boostrap be the default OPAC theme for new Koha installs.

Signed-off-by: Galen Charlton <gmc at esilibrary.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:05:10 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:05:10 +0000
Subject: [Koha-bugs] [Bug 11178] Make Bootstrap the default theme for new
	installs
In-Reply-To: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11178-70-jBzJjnsU9D@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11178

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:05:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:05:39 +0000
Subject: [Koha-bugs] [Bug 11178] Make Bootstrap the default theme for new
	installs
In-Reply-To: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11178-70-emhZsQM0sh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11178

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:05:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:05:45 +0000
Subject: [Koha-bugs] [Bug 11178] Make Bootstrap the default theme for new
	installs
In-Reply-To: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11178-70-F5inGfWIBU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11178

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 18:05:51 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 17:05:51 +0000
Subject: [Koha-bugs] [Bug 11178] Make Bootstrap the default theme for new
	installs
In-Reply-To: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11178-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11178-70-cRTdd06vde@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11178

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:03:17 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:03:17 +0000
Subject: [Koha-bugs] [Bug 10974] OAI-PMH Resumption Tokens Do Not Handle Time
In-Reply-To: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10974-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10974-70-w0tEivwP63@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10974

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #7 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:06:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:06:35 +0000
Subject: [Koha-bugs] [Bug 10445] SIP Server doesn't respect maxoutstanding
 system preference
In-Reply-To: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10445-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10445-70-JsPg8doXt4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10445

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #11 from Galen Charlton <gmcharlt at gmail.com> ---
Pushed to master.  Thanks, Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:15:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:15:40 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-6LsPWZw8qV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22654|0                           |1
        is obsolete|                            |

--- Comment #76 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22657
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22657&action=edit
Bug 10671: Update Acq Help Files

This patch updates the Acq help file links
to the manual.

To test:

* visit acq pages
* confirm manual links are right

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:18:35 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:18:35 +0000
Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update
In-Reply-To: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10671-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10671-70-glAu3hlfvI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671

--- Comment #77 from Nicole C. Engard <nengard at gmail.com> ---
Created attachment 22658
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22658&action=edit
Bug 10671: Update patron help files [ FOLLOW-UP ]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:22:31 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:22:31 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-wSb7Gketvm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from M. Tompsett <mtompset at hotmail.com> ---
The reason for failure was a lack of PT. I dropped my DB, did the web installer
steps (only default items checked), and then tried to prove it. It failed, like
M. de Rooy encountered. After adding checks in for SS, SPT, and PT patron
categories into the test, all seems to work fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:22:37 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:22:37 +0000
Subject: [Koha-bugs] [Bug 11172] Reports need a clear filter button
In-Reply-To: <bug-11172-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11172-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11172-70-w0Eyw7V2FY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11172

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:27:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:27:26 +0000
Subject: [Koha-bugs] [Bug 11179] New: opac-course-details.pl shows item as
 available when it is checked out
Message-ID: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179

            Bug ID: 11179
           Summary: opac-course-details.pl shows item as available when it
                    is checked out
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Course reserves
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

If an item is listed for a course and is checked out, the item will still show
as being available from the course details page which lists all the items that
are part of a course. This is due to the way the course reserves system handles
items and issues separately, while item-status.inc assumes the due date has
been embedded in items.datedue

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:29:18 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:29:18 +0000
Subject: [Koha-bugs] [Bug 11179] opac-course-details.pl shows item as
 available when it is checked out
In-Reply-To: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11179-70-UNJU7JxcsH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:29:21 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:29:21 +0000
Subject: [Koha-bugs] [Bug 11179] opac-course-details.pl shows item as
 available when it is checked out
In-Reply-To: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11179-70-OcFmycX0CL@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 22659
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22659&action=edit
Bug 11179 - opac-course-details.pl shows item as available when it is checked
out

If an item is listed for a course and is checked out, the item will
still show as being available from the course details page which lists
all the items that are part of a course. This is due to the way the
course reserves system handles items and issues separately, while
item-status.inc assumes the due date has been embedded in items.datedue

Test Plan:
1) Create a course
2) Add an item to that course
3) Check the item out to a patron
4) View the course details from the opac
5) Note the status says "Available"
6) Apply this patch
7) Repeat step 4
8) Note the status no longer says "Available"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:32:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:32:45 +0000
Subject: [Koha-bugs] [Bug 11179] opac-course-details.pl shows item as
 available when it is checked out
In-Reply-To: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11179-70-U58gnVBubs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:33:01 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:33:01 +0000
Subject: [Koha-bugs] [Bug 11179] opac-course-details.pl shows item as
 available when it is checked out
In-Reply-To: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11179-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11179-70-eiHh5LzNSD@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11179

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 19:41:50 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 18:41:50 +0000
Subject: [Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber
In-Reply-To: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9921-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9921-70-nnIXWBajwv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 20:10:15 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 19:10:15 +0000
Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable
 via SIPconfig.xml
In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9531-70-DVBTF42oqI@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531

--- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> ---
Tomas, Ive checked this is ok on 3.12.x too.

So if you want to push it to that, it should be fine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 20:42:04 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 19:42:04 +0000
Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios
In-Reply-To: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5725-70-x9uillC5Um@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 20:49:45 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 19:49:45 +0000
Subject: [Koha-bugs] [Bug 10213] UniqueItemFields should be implemented for
 creating items in cataloguing and serials
In-Reply-To: <bug-10213-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10213-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10213-70-LsldlMFIQT@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 20:51:11 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 19:51:11 +0000
Subject: [Koha-bugs] [Bug 8684] Duplicate check for creating items on order
	broken
In-Reply-To: <bug-8684-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8684-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8684-70-xrZyq9YnOM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8684

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 20:58:36 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 19:58:36 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-D2jbIpO0Xk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22655|0                           |1
        is obsolete|                            |

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 22660
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22660&action=edit
Bug 10895 - Tests for C4::Items GetHiddenItems

Bug 10589 introduces PatronSingleBranch and PatronEveryBranch
system preferences. This ensures that the visibility of two
dummy records matches expectations. OpacHiddenItems is set
to hide 2 records. The system preferences are then toggled
between four cases ('SPT','SS','','SS|SPT') cross multipled
for the two system preferences to verify the correct visibility.

This will fail for a system with bug 10589 not applied, since
this tests the functionality of that patch. This will fail for a
system with bug 10900 not applied, since the calling convention
for set_userenv was fixed in C4::Context in this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 21:00:39 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 20:00:39 +0000
Subject: [Koha-bugs] [Bug 9701] Configure default indicator
In-Reply-To: <bug-9701-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-9701-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9701-70-wb2KjQmIJV@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701

marjorie barry-vila <marjorie.barry-vila at ccsr.qc.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at ccsr.qc
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 21:01:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 20:01:40 +0000
Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems
In-Reply-To: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-10895-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10895-70-IzgRBczen4@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895

--- Comment #15 from M. Tompsett <mtompset at hotmail.com> ---
Remember that 10589 and 10900 are dependencies for this test.
This is how I tested it:

mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master                HEAD
is now at 7c521a8 Bug 8435: (follow-up) prevent t/00-load.t failing
mtompset at ubuntu:~/kohaclone$ git bz apply 10900                            Bug
10900 - Incorrect calling conventions accessing C4::Context

22585 - Bug 10900 - Incorrect calling conventions accessing C4::Context

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10900 - Incorrect calling conventions accessing C4::Context
mtompset at ubuntu:~/kohaclone$ git bz apply 10589                            Bug
10589 - Override OpacHiddenItems based on Patron Category

22629 - Bug 10589 - Override OpacHiddenItems based on Patron Category

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10589 - Override OpacHiddenItems based on Patron Category
mtompset at ubuntu:~/kohaclone$ git bz apply 10895                            Bug
10895 - Tests for C4::Items GetHiddenItems

22660 - Bug 10895 - Tests for C4::Items GetHiddenItems

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10895 - Tests for C4::Items GetHiddenItems
mtompset at ubuntu:~/kohaclone$ prove -v
t/db_dependent/GetHiddenItems_PatronCategory.t
t/db_dependent/GetHiddenItems_PatronCategory.t ..
1..22
ok 1 - use C4::Items;
ok 2 - LIB1 Item linked to correct biblionumber.
ok 3 - LIB1 Item linked to correct biblioitemnumber.
ok 4 - LIB2 Item linked to correct biblionumber.
ok 5 - LIB2 Item linked to correct biblioitemnumber.
$VAR1 = {
          'firstname' => 'Sample',
          'userid' => 'Sample.Borrower',
          'categorycode' => 'PT',
          'phone' => '967-1111',
          'zipcode' => 'H0H 0H0',
          'surname' => 'Borrower',
          'email' => 'santa at northpole.com',
          'city' => 'Bogusville',
          'address' => '123 Bogus Street',
          'branchcode' => 'LIB1'
        };
# Sample Borrower added.
CHECK: 4
IInDuWYkdr
# 7 - LIB1
# 8 - LIB2
ok 6 - OpacHiddenItems hid everything correctly.
# 7,8
# Borrower number: 4
# Sample Borrower environment variables set up.
ok 7 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SPT
#
ok 8 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SS
# 8
ok 9 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: ''
# 8
ok 10 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SPT
# PatronEveryBranch: SS|SPT
#
ok 11 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SPT
#
ok 12 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS
# 7,8
ok 13 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: ''
# 7,8
ok 14 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS
# PatronEveryBranch: SS|SPT
#
ok 15 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SPT
#
ok 16 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS
# 7,8
ok 17 - OpacHiddenItems hid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: ''
# 7,8
ok 18 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: ''
# PatronEveryBranch: SS|SPT
#
ok 19 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SPT
#
ok 20 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS
# 8
ok 21 - OpacHiddenItems hid LIB2 correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: ''
# 8
ok 22 - OpacHiddenItems unhid everything correctly.
# PatronSingleBranch: SS|SPT
# PatronEveryBranch: SS|SPT
#
ok
All tests successful.
Files=1, Tests=22,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.40 cusr  0.02
csys =  0.45 CPU)
Result: PASS
mtompset at ubuntu:~/kohaclone$ ~/qa-test-tools/koha-qa.pl -v 2 -c 1
testing 1 commit(s) (applied to c9dadf4 'Bug 10589 - Override OpacHiddenItems
')

 OK     t/db_dependent/GetHiddenItems_PatronCategory.t
   OK     pod
   OK     forbidden patterns
   OK     valid
   OK     critic

mtompset at ubuntu:~/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 22:57:19 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 21:57:19 +0000
Subject: [Koha-bugs] [Bug 11180] New: IP branch attrib showld acept CIDR
	notation
Message-ID: <bug-11180-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180

            Bug ID: 11180
           Summary: IP branch attrib showld acept CIDR notation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The most common way to talk about an IP range is the CIDR notation, for example
"157.93.48.0/22, 157.93.53.0/25, 157.93.54.0/25", instead of using an asterisk
(current "157.93.48.*" notation), which limit the mask to /24. I think koha
should handle both notations, or at least instead CIDR, which is much more
flexible.

As in the example also sometimes is necessary to deal with more than one subnet
(comma separated) at the same time (I could fill another bug for this one).

Of course all this is particularly useful to AutoLocation system preference.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 23:16:40 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 22:16:40 +0000
Subject: [Koha-bugs] [Bug 11181] New: Koha geolocalization of OPAC users for
 better sort results
Message-ID: <bug-11181-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11181

            Bug ID: 11181
           Summary: Koha geolocalization of OPAC users for better sort
                    results
 Change sponsored?: ---
           Product: Koha
           Version: 3.14
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: pablo.bianchi at gmail.com
        QA Contact: testopia at bugs.koha-community.org

As I suggest back on 2009
(http://koha.1045719.n5.nabble.com/Geolocalization-in-Koha-td3069181.html ) it
would be very nice if Koha could offer geolocation[0] (maybe using
openstreetmap.org or Google Maps API).

Having branches spread over a large territory make this feature very useful,
making the records of the searched material more near first in the result list.
Is possible to add some heuristics based on what people usually search for
nearby (as Google does).
There are some freely available databases[1], but also is possible to create
and improve one over time, based on location established on registered and
logged users, associating it with their IP address.

Some extra fields for each Library should be added to database (aside
code for geolocation and sorting OPAC results) like longitude and
latitude on Decimal Degrees, "DD"[2], and a system preference to
activate/deactivate this.

[0] http://en.wikipedia.org/wiki/Geolocation
[1] http://www.ipinfodb.com/ip_location_api.php
[2] http://en.wikipedia.org/wiki/Decimal_degrees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Oct 31 23:51:26 2013
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2013 22:51:26 +0000
Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to
 race condition during full rebuilds
In-Reply-To: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-11078-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11078-70-i2XuRcUFw8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078

--- Comment #19 from Robin Sheat <robin at catalyst.net.nz> ---
I attempted to have a go testing this, however the patches don't apply on
current master:

Applying: Bug 11078 Add locking to rebuild_zebra to prevent race conditions.
/home/robin/catalyst/koha/.git/rebase-apply/patch:67: tab in indent.
    if (flock(LockFH, LOCK_EX|LOCK_NB)) {
/home/robin/catalyst/koha/.git/rebase-apply/patch:68: tab in indent.
        do_one_pass() if ( zebraqueue_not_empty() );
/home/robin/catalyst/koha/.git/rebase-apply/patch:69: tab in indent.
        flock(LockFH, LOCK_UN);
/home/robin/catalyst/koha/.git/rebase-apply/patch:70: tab in indent.
    }
fatal: sha1 information is lacking or useless
(misc/migration_tools/rebuild_zebra.pl).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11078 Add locking to rebuild_zebra to prevent race
conditions.
The copy of the patch that failed is found in:
   /home/robin/catalyst/koha/.git/rebase-apply/patch

This usually happens if they're on top of a local patch or something that isn't
in master. It probably just needs a quick rebasing.

-- 
You are receiving this mail because:
You are watching all bug changes.