[Koha-bugs] [Bug 11010] New: Useless column purchaseordernumber in aqorders table

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 7 17:43:08 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11010

            Bug ID: 11010
           Summary: Useless column purchaseordernumber in aqorders table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Database
          Assignee: gmcharlt at gmail.com
          Reporter: mathieu.saby at univ-rennes2.fr
        QA Contact: testopia at bugs.koha-community.org

In Schemaspy, column purchaseordernumber is reported as "not used? always
NULL".
"grep -r cancelledby *" give this result : 

C4/Acquisition.pm:The following keys are used: "biblionumber", "title",
"basketno", "quantity", "notes", "rrp", "ecost", "gstrate", "unitprice",
"subscription", "sort1", "sort2", "booksellerinvoicenumber", "listprice",
"budgetdate", "purchaseordernumber", "branchcode", "booksellerinvoicenumber",
"budget_id".
C4/Acquisition.pm:                datereceived,purchaseordernumber,
installer/data/mysql/update22to30.pl:                field   =>
'purchaseordernumber',
installer/data/mysql/kohastructure.sql:  `purchaseordernumber` mediumtext, --
not used? always NULL
installer/data/Pg/kohastructure.sql:purchaseordernumber text,
t/db_dependent/Acquisition.t:                         purchaseordernumber


In C4::Acquisition.pm::GetParcels, the SELECT statement retreives
purchaseordernumber, but no value is pushed to that column in any part of
Koha's code. So I think it is useless.

I propose the deletion of this column.

M. Saby

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list