[Koha-bugs] [Bug 9084] Dates in notices should be formatted according to dateformat system preference
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Oct 11 07:51:40 CEST 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084
--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
I'm happy to see that someone else has already started work on this one.
However, I have a few reservations about this patch at the moment.
1) The list of tables.fields for which to format dates:
This list isn't comprehensive (it should probably include all date columns).
Also, being hard-coded, it makes for a bit of a maintenance nightmare, I think.
The overdue_notices.pl and advanced-notices.pl scripts use this regex
"/^date|date$/" to choose columns for which to format dates when using
items.content. I think that this would make sense here too.
Of course, "items.onloan" wouldn't be included in this, so we might need to use
a hard-coded list, or regex + a shorter hard-coded list.
2) I don't know if we want to strip the time from all of these fields.
I imagine there might be fields, like duedate, where we might want to include
the time.
We might not. I'm not 100% on this one.
--
In any case, if the list were expanded, I would be happy to sign off.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list