[Koha-bugs] [Bug 11058] Compile time warning issued by C4/Record.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11058

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22010|0                           |1
        is obsolete|                            |
                 CC|                            |mtompset at hotmail.com

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 22010
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22010
Proposed Patch

This is now obsolete.

mtompset at ubuntu:~/kohaclone$ git checkout -b bug_11058 origin/master
Branch bug_11058 set up to track remote branch master from origin.
Switched to a new branch 'bug_11058'

1) Confirmed Problem.
mtompset at ubuntu:~/kohaclone$ perl -wc C4/Record.pm
"my" variable $stylesheet masks earlier declaration in same scope at
C4/Record.p                                                                    
        m line 313.
C4/Record.pm syntax OK

2) Looked at code:
mtompset at ubuntu:~/kohaclone$ vi C4/Record.pm
The code has a parameter passed named stylesheet, and a variable declared
stylesheet. The parameter is used to set other variables which feed into this
secondary declaration. So, renaming this variable is a good solution and should
not cause any problems.

3) Applied patch
mtompset at ubuntu:~/kohaclone$ git bz apply 11058
Bug 11058 - Compile time warning issued by C4/Record.pm

22010 - Proposed Patch

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11058: make variable name unique within its scope

4) Confirmed problem solved.
mtompset at ubuntu:~/kohaclone$ perl -wc C4/Record.pm
C4/Record.pm syntax OK

5) Decided to run koha-qa.pl on it for kicks.
mtompset at ubuntu:~/kohaclone$ ~/qa-test-tools/koha-qa.pl -v 2 -c 1
testing 1 commit(s) (applied to 0f5dc60 'Bug 10309: (follow-up) restore
settin')

 OK     C4/Record.pm
   OK     pod
   OK     forbidden patterns
   OK     valid
                0
   OK     critic

6) Signed it off.
mtompset at ubuntu:~/kohaclone$ git so 1
Rewrite f1111fff1071b4a14251d5ecd80bfad07f567e4b (1/1)
Ref 'refs/heads/bug_11058' was rewritten
mtompset at ubuntu:~/kohaclone$ git commit --amend
[bug_11058 72c273c] [SIGNED OFF] Bug 11058: make variable name unique within
its                                                                            
 scope
 Author: Colin Campbell <colin.campbell at ptfs-europe.com>
 1 file changed, 3 insertions(+), 3 deletions(-)

7) Attached it.
mtompset at ubuntu:~/kohaclone$ git bz attach 11058 HEAD
Bug 11058 - Compile time warning issued by C4/Record.pm

72c273c [SIGNED OFF] Bug 11058: make variable name unique within its scope

Attach? [yn] y
Attached SIGNED-OFF-Bug-11058-make-variable-name-unique-wit.patch

8) And now obsolete the old one, and make sure the status is right.

-- 
You are receiving this mail because:
You are watching all bug changes.