[Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion
                 CC|                            |gmcharlt at gmail.com

--- Comment #12 from Galen Charlton <gmcharlt at gmail.com> ---
I have concerns about the implementation of this -- in particular, for a bib
that is /not/ going to end up hidden, the acts of retrieving all of the items
and checking which ones are hidden occur /twice/.

In my opinion, this is likely to impose too high of a performance penalty for
typical OPACs, which don't have high numbers of hidden items.

I suggest revising the patch so that rather than adding a call to
GetHiddenItems(), the bailing-out occurs after the original call to
GetHiddenItems().  Additional refactoring might be called for (but as the topic
of a separate bug) to minimize the processing gets wasted whether or not the
bib ends up hidden.

Also, I'm not a fan of the notion of using 0 as a "magic" biblionumber -- to
bail out, just issue the redirect.

-- 
You are receiving this mail because:
You are watching all bug changes.