[Koha-bugs] [Bug 3050] Add an option to upload scanned invoices.
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Apr 1 13:37:31 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050
--- Comment #7 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #5)
> Review of attachment 25306 [details] [review]:
> -----------------------------------------------------------------
>
> FAIL acqui/invoice-files.pl
> FAIL forbidden patterns
> forbidden pattern: trailing space char (line 130)
I was unable to locate that trailing space[s] in line 130, but this part of the
code was rewrited anyway, so this issue should now be fixed.
> You should check the syspref value in the templates using
> Koha.Preference('AcqEnableFiles')
Btw, this nice little TT plugin doesn't seem to utf8-encode it's output, unless
I'm very much mistaken.. Not really a problem with 0|1 kind of a syspref,
though.
> > + while (<$uploaded_file>) {
> > + $file_content .= $_;
> > + }
>
> I think
> my $file_content = <$uploaded_file>;
> does the same thing.
>
Doesn't work for files with "\n" 's in them. Replaced it with:
my $file_content = do { local $/; <$uploaded_file>; };
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
More information about the Koha-bugs
mailing list