[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Apr 21 17:48:52 CEST 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703
--- Comment #80 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #79)
> Hi Kyle,
>
> as promised, here my first test results:
>
> GENERAL
> - New jQuery plugin: jquery.dataTables.grouping.js
> Should we add a note to the about page about this?
Will do.
> - Translation:
> + var HOLD_IS = _("Hold is");
> + var SUSPENDED = _("suspended");
> + var UNTIL = _("until");
> + var ITEM_IS = _("Item is");
> + var WAITING = _("waiting");
> + var AT = _("at");
> + var FROM = _("from");
> Would be much nicer as complete sentences with placeholders - this is
> really hard to translate grammatically correct.
I don't think this is possible with JavaScript, as it has no string
interpolation.
> - renewal using checkboxes
> > Concern: It's only possible to do one renewal at a time.
> After renewing once the checkbox is gone and then you will have
> to reload the page to bring the checkboxes back.
This is by design. I think in those rare cases reloading the page would be a
fair resolution for this.
> - renewal override
> > OK. If the item is on hold, the renewal will fail. I wonder if that's
> always been the case, but it's behaviour pre-patches.
Yes, that has always been the case.
> - too early renewal (bug 6779)
> > Bug: Shows too_soon instead of a nice message for why the renewal
> is not yet allowed. Should show the date - compare to master.
Will fix
> System preferences
> - UseTableSortForCirc
> > Is removed, sorting will be always available
> > Bug: Should be removed properly with updatedatabase.pl as well
> - [prefs for sorting by checkout date] - still to be tested
Will fix
> RELATIVE's CHECKOUTS
> - releative's checkouts tab is only shown for the guarantee (child),
> but not for the parent - something seems messed up here?
> > Bug: My patron has 2 children, one of them has an item checked out.
> It doesn't show up, the relative's checkouts tab is empty.
I'll look into this
> HOLDS
> - Sorting table
> > Sorting the holds table was not possible pre-patches.
> Concern: The sorting and page load seems a bit slow for 4 holds
The sorting is done server side. We can either leave it as is, since there was
no sorting to begin with, make the sorting client side ( which will break
sorting on some columns possibly ), or just disable sorting altogether ( ie
pre-patch behavior )
> Concern: Performance testing / benchmarking
> - I would be really interested to see a comparison on how fast the
> complete page loads in comparison to before and similar. Is this possible?
Not easily. The idea is to get the circulation screen to be as *responsive* as
possible. The more checkouts and holds a patron has, the less responsive
circulation.pl becomes. This patch obviates that issue be loading the page, and
fetching that data afterward.
> Concern: Accessibility
> - We currently have no feedback about accessibility issues this might
> cause in circulation. I want to note that there is no non-Javascript
> fallback here. In case the Ajax proves to be a problem, we'd have
> a regression as currenct circulation works nicely.
These tables should be just as accessible as any other datatable in Koha, some
of which are also ajax based such as this.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list