[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
I absolutely agree with Fridolin on this one.

If you look at every other example of "UpdateStats()" in C4::Circulation,
you'll see that it uses $item->{itype} (the two bad examples being
$biblio->{itemtype} and $item->{itemtype}).

While it might be an idea to correct the behaviour to take into account
"item-level_itypes", I think that's really outside the scope of this bug. This
bug is just to create consistency in the usage of UpdateStats() within
C4::Circulation.

As for updating existing statistics... I think that's a very difficult idea:

1) If we update existing statistics without telling librarians, we're going to
cause huge headaches as their old statistics will be invalidated and their new
statistics will likely be very different than expected (even though they're
more accurate).

2) If we don't update the statistics, we cause huge headaches as the statistics
will be inconsistent. While fixing this in December seems to get around this a
bit, you never know when someone is going to apply a fix or switch to a fixed
version, so that cannot be banked on.

So... I don't know what the right thing to do here is. I think we probably need
to update existing statistics... but we need to be very explicit about that. As
Fridolin mentioned, libraries rely heavily on statistics, so if we're meddling
with their data, we need to make sure that they _know_ that we're doing it.

Of course, I don't know the best way to do that either, as it might be easy to
miscommunicate about this. Maybe... maybe we should update the statistics with
this patch, and the release manager and release maintainers should put a very
noticeable message in the release notes. In that way, the onus of passing
information on to librarian is - quite understandably - on the sysadmin.

Fridolin, if you add some SQL to update the statistics, I'd be happy to sign
off on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.