[Koha-bugs] [Bug 10869] can't delete order line if title deleted

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #53 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to mathieu saby from comment #46)
> If I understand well, it is because, as you stated in your comment,
> aqorders_items is not cleared automaticaly by DelOrder, but will be when Bug
> 11617 is pushed.
Yes. For now I removed this one test from your patch. It still checks in items,
no longer in aqorders_items. Note that if there would be a cascaded delete, I
think we should not have to check MySQL functionality either. So the test is no
longer needed. 

> As Bug 11617 is not yet pushed, and Katrin raised an objection to it, I
> would prefer to put this one in Discussion, with status 'Blocked by Bug
> 11617'.
Strictly speaking, they can be handled independently now.
But the discussion on bug 11617 made me think somewhat more about it.
If the user wants to delete an order, it is actually obvious that he wants to
delete records in aqorders_items too. You did in the former version (and I
moved it to another report :) But in the meantime we are now only deleting the
real item records here. And the question is: Did the user understand that, and
should he have the possibility to not remove the items (so only the order and
aqorders_items)? Should we add two options: Delete order / Delete order and
items. Note that Delete order and catalog record (or biblio) should obviously
include items. BTW Would biblio record be a better description than catalog
record in the second [or third] option? You can also misread it as follows now:
First delete the order and then catalog [read: edit] the record. When you say
biblio record, it is a noun and no verb.

Sorry for all these comments.. ;)
Setting to In Discussion, as you suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.