[Koha-bugs] [Bug 11732] Eliminate warning on undefined branchcode

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11732

--- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #5)
> Could you be explicit to the point of annoyance to confirm that I am trying
> to test it the same way, and have the same settings, and have similar data
> which triggers the error in master?

No annoyance as long as you keep testing :)
t/db_dependent/Letters.t does indeed produce some ugly errors with me too. Does
not call getletter.
t/Letters.t does not call getletter; so will not trigger the patch too.
The call ..$var=getletter(..).. will imo not trigger the patch; userenv will
return false. 
Note that Reserves.t also overrides userenv on line 23. We could do the same: 
perl -e "use C4::Letters; *C4::Context::userenv= sub { return {} }; my
$blah=C4::Letters::getletter('circulation','DUE', 'BRA');"
Without the patch, you have a warning. With the patch, you will have not.

-- 
You are receiving this mail because:
You are watching all bug changes.