[Koha-bugs] [Bug 11056] dead code in basketgroup.pl : remove code depending on "validate" param
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jan 17 18:22:56 CET 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11056
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24521|0 |1
is obsolete| |
--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 24526
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24526&action=edit
Bug 11056 : Delete dead code in basketgroup.pl
In basketgroup.pl, some code is supposed to be executed if $op = "validate".
But this value is no more assigned to $op variable since 2009.
This patch suppressed dead code, along with parseinputbaskets and
parseinputbasketgroups subs, which are obsolete.
No functional changes expected
Regression test :
Check basketgroup are shown as before the patch, and can be closed and reopen.
Check you can add or remove a basket from a basketgroup, and change
informations about it (like delivery place)
Check you can create a basketgroup when you close a basket.
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
The following commands return nothing:
- grep validate acqui/basketgroup.tt
- grep -R basketgroup.pl -C 2 | grep validate
- git grep parseinputbaskets
- git grep parseinputbasketgroups
- git grep basketgroup.pl | grep validate
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list