[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 29956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29956&action=edit
Documentation of some test cases

As BSZ has sponsored this feature I already got to test it quite a bit :)

Basically we are trying to copy the logic that is used to calculate fines when
finescalendar is set to "not including days the library is closed". 

With the new pref turned to on:
No overdue notice will be sent out on a holiday. Also, if the library is
closed, the overdue notice will be delayed accordingly. The overdue notice
delay can be read as 'days the library is open' instead of 'calendar days'.
This way the patron always has the same amount of days he actually can return
the items before the next overdue notice is sent.

With the new pref off, the current behaviour won't be changed at all.


== Example test plan ==

So for testing I added a fines configuration that would result in my overdue
notices being triggered the same day the fine would go up according to the
calendar. This way I could check the logic was the same. I tested without the
patch and with both possible settings for the new preference. 

= Configuration = 
- multiple items on multiple records with the itemtype "Books"
- circulation rule: 
  * fine amount: 1.00
  * charging interval: 5
  * fine grace period: 0
  * overdues fines cap: 3.00
- calendar: the library is closed on Saturday and Sunday
  * Note: Add more holidays later and rerun tests
- add 3 different overdue notices, so you can easily see which one has been 
  triggered, I used:
  * ODUE1, Overdue 1
  * ODUE2, Overdue 2
  * ODUE3, Overdue 3
- Overdue notice triggers
  * Start with for the patron category you want to test with:
    * ODUE1, delay 5
    * ODUE2, delay 10
    * ODUE3, delay 15
  * Note: Change settings later and rerun tests
- System preferences
  * finesCalendar - not including days the library is closed
  * OverdueNoticeCalendar - ignore calendar (previous behaviour)
  * Note: compare this to the behaviour without the patch being applied
    and then swith the pref to confirm the new behaviour
  * CalculateFinesOnReturn - Don't (for easier without having to waive fines)

= Test =
- Check out items to a patron with the chosen category. Due dates should be in
the past.
  Note: For some of my tests I checked out 1 item for each day the last 3 weeks
or similar.
  Sometimes it can also be useful to only check out 1 item and see which due
dates
  will trigger the overdue notice exactly.
- run fines.pl to create the fines
- run overdue_notices.pl -t [-v]
- If you want to send the overdue notices, you can also run:
  process_messagequeue.pl or you can check the generated overdue notices
  in the patron account (notices tab) or in the database (message_queue table).

I ran the scripts 3 times for each scenario I created, once on a branch without
the patch and then with the patch and both settings for the new system
preference 'OverdueNoticeCalendar'. After each test I truncated the
accountlines and message_queue and reran the scripts.

I cleaned up and translated some of my test cases, adding those as attachement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.