[Koha-bugs] [Bug 12061] tmpl_process3.pl new features

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12061

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
(In reply to Jonathan Druart from comment #9)
...
> It looks to be the same behavior as the -f option.

After all, it is not the same behavior!

This code on 'update' is the main difference

if ( @filenames ) {
   my ($tmph3, $tmpfile3) = tmpnam();
   $st = system("msgcat $str_file $tmpfile2 > $tmpfile3");
   $st = system("msgmerge ".($quiet?'-q':'')." -s $str_file $tmpfile3 -o - |
msgattrib --no-obsolete -o $str_file") unless $st;
} else {
  $st = system("msgmerge ".($quiet?'-q':'')." -s $str_file $tmpfile2 -o - |
msgattrib --no-obsolete -o $str_file");
}

'-f' is the right choice to use when a file is modified and one updates
translation file to reflect that.
But that is not the behavior that I want, PO file must reflect exactly the
contents of source dir on create & update.

I retained Fridolin sign, he signed a previous version with both (-n and -m)
new options, the code is slightly different but closer to the version that you
QAed.

Left as signed for your consideration, but only changed the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.