[Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #34 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
You add a routine GetReserve to C4/Reserves.pm
This is used only in  C4/ILSDI/Services.pm. The returned hashref is used to
check for the existence of the reserves record and to verify the
borrowernumber.

It seems that you could use GetReserveInfo to do exactly the same job. This
would prevent changing the Reserves module, the need of a unit test, etc. So
less maintenance. The only very small overhead is the join of a few tables
there; imo not too high.

Could you please adjust/simplify? Thanks.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.