[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Nov 11 13:38:04 CET 2014
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981
--- Comment #22 from Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> ---
Created attachment 33455
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33455&action=edit
Bug 7981 - Transfer message when returning doesn't properly respect
HomeOrHoldingBranchReturn syspref
This patch removes HomeOrHoldingBranchReturn syspref and makes circ/returns.pl
respect branch
circulation rules from C4::Circulation::GetBranchItemRule. Also transfer slip
notice should reflect this.
Default should always be to return item to home branch.
Test plan:
- make sure syspref 'AutomaticItemReturn' is set to 'false'
- unset 'Default checkout, hold and return policy' or set 'Return policy' to
'Item returns home'
- checkout an item and do a checkin from different branch than items homebranch
- verify that you're prompted with a transfer message to item's home branch and
that print slip matches
- set 'Return policy' to 'Item returns to issuing library'
- do a checkout and a checkin from branch different than item's home branch
- verify that you're not prompted with a transfer message and that holding
library is your current branch
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Follow-up:
- Added 3 tests in t/db_dependent/Circulation_Branches.t to test AddReturn
policies
- Removed HomeOrHoldingBranchReturn from sysprefs.sql
- Added notice on removing syspref in updatedatabase
QA edits:
- removed trailing whitespace in tests
- moved branchname lookup from returns.pl to template
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list