[Koha-bugs] [Bug 7976] "Borrow Permission" is not useless and can be removed

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976

Nick Clemens <nick at quecheelibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37382|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at quecheelibrary.org> ---
Created attachment 37914
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37914&action=edit
[SIGNED OFF] Bug 7976: Remove the borrow permission

The borrow permission was used but uselessly.
For instance, at the opac, the flagsrequired parameter was set to
'borrow' but the 'authnotrequired' was set also (which means no auth
required).
At the end, this permission was used at only 1 place: for the basket,
intranet side.
This can be replaced with the catalogue permission (which is used to
search).

Test plan:
1/ Confirm that you are able to show/download/sent the cart (intranet side)
with the catalogue permission.
2/ At the OPAC, you should be able to access the same pages as before
with any other permissions.

Concretely it is quite difficult to test this patch, you should have a
look at the code.

Signed-off-by: Nick Clemens <nick at quecheelibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.