[Koha-bugs] [Bug 1917] Add RSS Feeds for Lists

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1917

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 38117
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38117
[Signed-off] Bug 1917 - Add RSS Feeds for Lists

Review of attachment 38117:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1917&attachment=38117)
-----------------------------------------------------------------

Hi,

I love to see work on the low bug numbers! :)

The biggest issue here is that the strings from opac-shelves-rss.tt don't
appear to be translatable. I updated my po files, but the strings or file name
won't show up there.

I also found some smaller issues, please see comments below:

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves-rss.tt
@@ +2,5 @@
> +
> +<rss version="2.0">
> +
> +<channel>
> + <title>[% shelfname %]</title>

Why no |html here, but below?

@@ +8,5 @@
> + <description>RSS feed for public list [% shelfname | html %]</description>
> +
> +[% FOREACH i IN itemsloop %]
> + <item>
> +  <title>[% i.title %] by [% i.author %]</title>

The by is always shown, even if there is no author. Also because of the
included ISBD punctuation in MARC21 this would only be needed/useful for
UNIMARC.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ +153,5 @@
>                      [% IF ( viewshelf ) %]<!--  Viewing a particular shelf -->
> +                        <h3>
> +                            [% shelfname |html %]
> +                            <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&viewshelf=[% shelfnumber | html %]" class="rss-list-link noprint">
> +                                <img src="[% interface %]/[% theme %]/images/feed-icon-16x16.png" alt="Subscribe to this search" title="Subscribe to this search" border="0" class="rsssearchicon"/>

Should we adjust the title here? Maybe: Subscribe to this list

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.