[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337

--- Comment #19 from Kyle M Hall <kyle.m.hall at gmail.com> ---
(In reply to Jonathan Druart from comment #14)
> Comment on attachment 41708 [details] [review]
> Bug 14337 - Add Unit Tests
> 
> Review of attachment 41708 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: t/db_dependent/Circulation.t
> @@ +649,5 @@
> > +    my $borrower2 = GetMember( borrowernumber => $borrowernumber2 );
> > +
> > +    my $issue = AddIssue( $borrower1, $barcode1 );
> > +
> > +    my ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 );
> 
> Shouldn't be borrowernumber1?
> Chelsea didn't check out itemnumber1.
> 
> @@ +667,5 @@
> > +
> > +    ( $renewokay, $error ) = CanBookBeRenewed( $borrowernumber2, $itemnumber1 );
> > +    is( $renewokay, 1, 'Bug 14337 - Verify the borrower can renew with a hold on the record if AllowRenewalIfOtherItemsAvailable is enabled' );
> > +
> > +    diag("Setting item not checked out to be not for loan but holdable");
> 
> No need to overload the output, just a comment would be enough, don't you
> think?

You are correct. Unit test patch is updated based on your comments!

-- 
You are receiving this mail because:
You are watching all bug changes.