[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, So, you're always calling ->all on he dbic resultset, even when you may
only actually want the ->first result :(. Bad mojo, this is a big memory leak
in my opinion.

Yes calling ->all is a good idea when you know you want the full set (or you
know the full set will always be sufficiently small that your not worried about
the memory overhead, but calling it for all requests is just asking for trouble
in my opinion.

We should be encouraging thought behind these calls and good practice. Not
coding around other coders deficiencies.. that's what QA is for, spotting such
performance mistakes during QA time.

All in all, this gets a definitive thumbs down from me

-- 
You are receiving this mail because:
You are watching all bug changes.