[Koha-bugs] [Bug 12631] Inventory: fix "wrong place" and "item not scanned" statuses

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12631

Brendan Gallagher <brendan at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |brendan at bywatersolutions.co
                   |                            |m

--- Comment #8 from Brendan Gallagher <brendan at bywatersolutions.com> ---
(In reply to Brendan Gallagher from comment #7)
> Created attachment 35859 [details] [review]
> BZ12631: Inventory: fix "wrong place" and "item not scanned"
> 
> "item not scanned": when calling GetItemsForInventory, datelastseen should
>  be used when "compare barcodes list to result" is checked.
> 
>  Otherwise, when loading multiple barcodes files for the same inventory, many
>  items will be marked as "item not scanned" when loading the last barcode
> file
>  ("compare barcodes list to result" checked) even though they were scanned.
> 
>  "wrong place": when searching for wrongly placed items, we should only check
>  for the location (callnumbers, location and branch). To fix this, A new call
>  to  GetItemsForInventory has been made with location filters only.
> 
>  Otherwise, any item with a different itemtype for instance will be marked as
>  wrong place even if the location is correct.
> 
>  Test plan:
> 
> "item not scanned" status:
> 
> 1) Split a barcode file in two.
> 2) Load the first barcode file without checking "compare barcodes list to
> result".
> 3) Load the second barcode file with "compare barcodes list to result"
> checked.
> 4) Check in the csv report that you have a lot of scanned items with the
> "item
> not scanned" status.
> 
> Then apply the patch, do the same, and check that the false "item not
> scanned"
> statuses are gone.
> 
> "wrong place" status:
> 
> 1) Load a barcode file with barcode matching an item that has a correct
> location, but a different itemtype than what you're looking for.
> 2) Check in the results that this item will be marked as "change item status"
> and "wrong place".
> 
> Then apply the patch, do the same, and check that the only status for this
> item is "change item status", which is correct.
> 
> Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

I recently had a support ticket that dealt with inventory, so I easily had a
few copies of barcodes.  I split into two and followed the test plan. 
Excellent timing.

-- 
You are receiving this mail because:
You are watching all bug changes.