[Koha-bugs] [Bug 13499] Auth.pm needs a tidy
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Jan 5 19:53:19 CET 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13499
Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmmm, your right.. though it's still non-descructive in that all blames related
to my tidy appear to simply be the addition of some blank lines to space the
code out a little better.
You advice here would be apreciated Mark, would you prefer an updated test
plan, i.e.
Before patch
git blame -w Auth.pm > orig.blame
After patch
git blame -w Auth.pm > new.blame
A diff (I tend to use vimdiff so I can understand what it's telling me) between
orig.blame and new.blame should show the addition of a number of additional
blank lines atributed to the tidy commit, and a number of whitespace changes on
other lines but those changes should still be attributed to their original
authors.
I can attempt to prevent even these blank lines during the tidy, but I feel
this would negate at least some of the point of doing such a tidy to aid in
readability.
Let me know your thoughts, and thanks for testing
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list