[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Jan 21 13:45:36 CET 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602
Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #35436|0 |1
is obsolete| |
--- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
Created attachment 35437
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35437&action=edit
Bug 13602 - Username/password already exists when editing borrower attributes
and messaging preferences
When editing a Patron's messaging preferences or borrower attributes, one
cannot
save changes because 'userid' is not given as a parameter.
It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.
REPLICATE THE ISSUE:
1. Find a Borrower.
2. Go to the details-tab.
3. Under "Patron messaging preferences" click edit to edit just the messaging
preferences.
4. Just save, no need to make any modifications.
5. Observe the error "Username/password already exists"
This happens to all/most of the sub-forms in the Borrower's Details-view.
AFTER THIS PATCH:
Check_Userid() get the $userid from the new parameters, or if not present, from
the koha.borrowers-table.
TEST FOR REGRESSION:
1. Edit a borrower normally. Notice no errors.
2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no
errors.
DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's
extent without my permission. As long as it makes to Koha I am happy.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list