[Koha-bugs] [Bug 14480] Warns when modifying patron

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14480

--- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Comment on attachment 40744
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40744
Bug 14480: Silences warns triggered when modifying patron

Review of attachment 40744:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14480&attachment=40744)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +916,4 @@
>                <fieldset class="rows">
>                  <legend>Patron restrictions</legend>
>  
> +                [% IF ( debarments.size  && debarments.size < 1 ) %]

It should be
  IF debarments and debarments.size
That makes more sense.

::: members/memberentry.pl
@@ +563,4 @@
>  
>      if ($default_city) { # flag the current or default val
>          for my $city ( @{$city_arrayref} ) {
> +            if ($default_city eq $city->{cityid}) {

I don't get this warning but cityid is an integer, so == makes sense.
$default_city is tested before so cityid is empty? Don't understand how it's
possible (comes from the DB, stored as int)

-- 
You are receiving this mail because:
You are watching all bug changes.