[Koha-bugs] [Bug 13787] Clean up noisy koha qa tool warnings
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Mar 5 15:51:55 CET 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13787
Jonathan Druart <jonathan.druart at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #36557|0 |1
is obsolete| |
--- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 36610
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36610&action=edit
Bug 13787 - Clean up noisy opac-advsearch warnings
While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.
Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 384.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 161.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 177.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 202.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 240.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 256.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 356.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Argument "" isn't numeric in numeric gt (>) at
/home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
line 369.
Tweaking the [% IF %] statements eliminated the warnings.
TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
-- there will be noisy warnings in the before processing, but
there will be no such messages in the after processing.
3) git diff origin/master
-- there should be no visible typos.
Signed-off-by: Magnus Enger <magnus at enger.priv.no>
- Applied the patch from bug 10937
- Ran "koha-qa.pl -c 1" and observed the warnings described in the
commit message
- Applied the patch from this bug
- Ran "koha-qa.pl -c 1" again and saw no warnings
- Ran "koha-qa.pl -c 2" and saw no warnings
I have not tested the functionality of 10937 with this patch, just verified
that the changes look sensible.
This patch feels more like a followup for 10937, than a separate patch,
especially since 10937 is just "signed off" at this time. But as long as it
works...
Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list