[Koha-bugs] [Bug 14265] New: Replace instances of Javascript trim() with $.trim()
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon May 25 05:36:27 CEST 2015
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14265
Bug ID: 14265
Summary: Replace instances of Javascript trim() with $.trim()
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: dcook at prosentient.com.au
QA Contact: testopia at bugs.koha-community.org
At the moment, we use both jQuery's $.trim() and the regular Javascript trim()
in our templates.
You can find trim() in:
- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt
- koha-tmpl/intranet-tmpl/prog/en/modules/admin/categorie.tt
You can find $.trim() in:
- koha-tmpl/intranet-tmpl/prog/en/modules/admin/transport-cost-matrix.tt
The jQuery $.trim() appears perfectly cross-platform, but the Javascript trim()
isn't supported in IE8 or earlier. It was only introduced in IE9.
Since we already use jQuery everywhere, I don't see why we can't use $.trim()
instead of trim().
At the moment, people using IE8 in the staff client (and I'm sure there are
many of them) can't save patron categories. Javascript errors will prevent the
submission of the page.
--
I know we occasionally debate supporting older versions of IE, but this is a
pretty easy win.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list