[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211

--- Comment #51 from Jesse Weaver <jweaver at bywatersolutions.com> ---
(In reply to Magnus Enger from comment #48)
> (In reply to Jesse Weaver from comment #47)
> > RE: comment 5: I used event instead of holiday because you can now record
> > that a given day is open or closed, seperately of the precedence order of
> > specific day > day/month > weekday. 
> 
> That change makes sense to me - it looks like a good generalization from
> holiday (which to me is something like Easter or "summer hliday") to "event"
> (which to me could be something like "the library is closed for renovation",
> which would be hard to fit into the "holiday" concept).
>  
> > RE: comment 32: I will at least cite lines 219-220 of Koha/Calendar.pm to
> > argue for this patch's interpretation of isexception == open:
> > 
> >         # exceptions are not holidays
> >         return 0;
> 
> I can sort of see that, but I have two concerns:
> 
> 1) That future developers will find it hard to understand the name

This is reasonable. I'd offer the interpretation that the underlying tables are
named *_holidays, and an exception to a holiday is not being a holiday -> open.
(And, in theory, this is a stepping stone to bug 8133, though of course we want
to make the situation tenable now.)

> 
> 2) That we are loosing some functionality. The way I understand the current
> functionality, you can say that there is a holiday and the library is closed
> from date A to date C, BUT on date B (which is between A and C) the library
> is open anyway. If I remember correctly, you can also say that the library
> is closed for a month, but open on Wednesdays. Is it still possible to do
> something like that after applying the patch on this bug?

I believe so; the way that creating events on a range works is that the code
simply creates a set of single-date events. It is then possible to edit any of
these events individually.

The UI and calendar display are both a bit non-ideal, but are functional.

-- 
You are receiving this mail because:
You are watching all bug changes.