From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 22:20:26 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Before applying the patch I search and found the followin lines: 169 if ($duedatespec =~ C4::Dates->regexp('syspref')) { 178 our $todaysdate = C4::Dates->new->output('iso'); I do not know if there should be these lines! If the intention in bug 14870 is to delete C4::Dates, this will launch an error or warning when the script will executed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 22:21:22 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 22:21:26 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42721|0 |1 is obsolete| | Attachment #42722|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 42985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42985&action=edit [PASSED QA] Bug 10181: Make string translatable Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 22:21:39 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #11 from Katrin Fischer --- Created attachment 42986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42986&action=edit [PASSED QA] Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 22:28:51 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #3 from H?ctor Eduardo Castro Avalos --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > Before applying the patch I search and found the followin lines: > > 169 if ($duedatespec =~ C4::Dates->regexp('syspref')) { > 178 our $todaysdate = C4::Dates->new->output('iso'); > > I do not know if there should be these lines! > > If the intention in bug 14870 is to delete C4::Dates, this will launch an > error or warning when the script will executed. After applying the patch these lines continued there. The patch doesn't touch it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 00:35:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 22:35:36 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Same here about 4-8. New sequence looks good to me, but is there a reason we don't display all reasons why a hold can not be placed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 01:09:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 23:09:11 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42973|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 42987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42987&action=edit [SIGNED-OFF]Bug 14922 - Remove C4::Dates from cataloguing/additem.pl This patch removes C4::Dates from cataloguing/additem.pl To test: - In MARC bibliographic framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Create a new item for a biblio and verify that YYYY, MM and DD are replaced with today's values. - Apply patch and repeat that previous step behaves as before. - Verify that the overall functionality of the form is the same as before applying the patch. Signed-off-by: Hector Castro Works as advertised. With the last script not accept more than YYYYMMDD If you enter something else, the script sends to the end of line. This patch follow up the pattern in constraint default value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 01:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Sep 2015 23:09:53 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 03:11:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 01:11:06 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #17 from David Cook --- I don't think we needed to change "1=32" to "1=Date-of-acquisition", but it's a trivial difference, so no worries. Sign off to follow... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 03:11:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 01:11:27 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42980|0 |1 is obsolete| | --- Comment #18 from David Cook --- Created attachment 42988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42988&action=edit Bug 14861: Change acqdate to allow date ranges. Use 'r=o' to in ccl.properties enable acqudate date range searches of the form YYYY-MM-DD - yyyy-mm-dd Signed-off-by: David Cook Used the test plan from Bugzilla, and it works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 03:11:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 01:11:42 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 04:55:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 02:55:17 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #116 from Robin Sheat --- (In reply to Robin Sheat from comment #115) > I have a rebase done, though it's untested. Now it's had a quick test and some things have been fixed. It appears on the surface to be working again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 08:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 06:12:52 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 08:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 06:34:23 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:42:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 07:42:31 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #5 from Magnus Enger --- Colin: What do you think of the proposal from Jonathan? Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:48:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 07:48:34 +0000 Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.18 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- We are seeing this behaviour as well it seems in a 3.18.8 installation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 09:58:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 07:58:41 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42895|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 42989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42989&action=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl Patch to remove deprectated C4::Dates from circ/circulation.pl To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Verify that due date works as before (with syspref 'SpecifyDueDate' on and off (Amended following comment #3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:00:15 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:16:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:16:35 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart --- I am not familiar with ccl.properties, but there is a st-numeric 4=109 r=o Does - st-date-normalized 4=5 + st-date-normalized 4=5 r=o could do the trick for all date indexes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:20:24 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |ulrich.kleiber at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:26:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:26:31 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Marc, What about using Koha::DateUtils to replace ->today? Something like my $today = dt_from_string; my $month = $today->month; my $day = $today->day; do what you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:32:11 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #3 from Jonathan Druart --- Comment on attachment 42964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42964 [SIGNED-OFF]Bug 14924 - Remove C4::Dates from members/memberentry.pl Review of attachment 42964: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14924&attachment=42964) ----------------------------------------------------------------- ::: members/memberentry.pl @@ +170,5 @@ > foreach (qw(dateenrolled dateexpiry dateofbirth)) { > next unless exists $newdata{$_}; > my $userdate = $newdata{$_} or next; > + if ( $userdate ) { > + $newdata{$_} = output_pref({ dt => dt_from_string( $userdate ), dateformat => 'iso', dateonly => 1 }); You have to care of bad formatted dates, otherwise the user will get a software error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:32:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:32:17 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:42:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:42:00 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #4 from Marc V?ron --- Hi Jonathan, I tried to enter an invalid date, but we have the date picker for this date - it seems no longer to be possible to enter invalid dates for the due date. Or do I miss a way to enter an invalid date? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:44:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:44:29 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Marc, sorry but I get a software error if the date is not correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:57:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:57:51 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 --- Comment #3 from Marc V?ron --- Created attachment 42990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42990&action=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX) - Verify that Help displays as appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:59:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:59:10 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch Blocks|14870 | Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 10:59:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 08:59:10 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14929 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 [Bug 14929] Fix missing display of help page in contract management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:02:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:02:16 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod at lib.auth.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:13:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:13:35 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42975|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 42991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42991&action=edit [COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:14:03 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #42975|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:14:08 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:14:18 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 --- Comment #3 from Jonathan Druart --- Wrong bug report, sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:14:39 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:14:42 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42959|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 42992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42992&action=edit Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:16:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:16:00 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I suggest this counter-patch, the badly formatted dates are caught and don't make Koha explodes with a software error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:24:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:24:54 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:24:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:24:57 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42816|0 |1 is obsolete| | Attachment #42817|0 |1 is obsolete| | Attachment #42818|0 |1 is obsolete| | Attachment #42819|0 |1 is obsolete| | Attachment #42820|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart --- Created attachment 42993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42993&action=edit Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm http://bugs.koha-community.org/show_bug.cgi?id=14402 Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:25:03 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #31 from Jonathan Druart --- Created attachment 42994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42994&action=edit Bug 14402: Add unit tests for purge_zero_balance_fees() The function C4::Accounts::purge_zero_balance_fees() should delete rows in accountlines where amountoutstanding is 0 and accountlines.date is less than the current date minus '$days', i.e a number of days passed to the function. Tests were added to prove the following: * accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE. The accountlines row should not be deleted. This is merely a sanity check, because difference between today's date and the fee date cannot be greater than $days. * 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0 * accountlines.amountoutstanding is 0, and date is set to $days - 1 days ago. The accountlines row should not be deleted. * accountlines.amountoutstanding is 0, and date is set to $days days ago. the accountlines row should not be deleted, because the difference must be *greater* than $days. * accountlines.amountoutstanding is 0, and date is set to $days + 1 days ago. The accountlines row *will* be deleted in this case. * 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0. (3 tests). The accountlines row will never be deleted, because amountoutstanding is not 0. * 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0. (3 testes) This tests credits. Again, the accountlines row will never be deleted, because amountoutstanding is not 0. http://bugs.koha-community.org/show_bug.cgi?id=14402 Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:25:10 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #33 from Jonathan Druart --- Created attachment 42996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42996&action=edit Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance. Also, add notes to perldocs and usage that payments and credits are not linked to fines and may be deleted independently of the associated fine. Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:25:06 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #32 from Jonathan Druart --- Created attachment 42995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42995&action=edit Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl This will call C4::Accounts::purge_zero_balance_fees to remove all rows from accountlines which have 0 balance, and are more than DAYS old. Test plan: Run: t/db_dependent/Accounts.t If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl should act as documented, because it is a straight pass-through to C4::Accounts::purge_zero_balance_fees(). http://bugs.koha-community.org/show_bug.cgi?id=14402 Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:25:14 +0000 Subject: [Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #34 from Jonathan Druart --- Created attachment 42997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42997&action=edit Bug 14402: - QA Followup Added notes to usage in misc/cronjobs/cleanup_database.pl that --fees DAYS requires DAYS to be greater than or equal to 1. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:29:22 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #28 from Jonathan Druart --- Everything is signed off here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:40:29 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:40:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:40:37 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42990|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 42998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42998&action=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX) - Verify that Help displays as appropriate. Signed-off-by: Magnus Enger Works as advertised. All the tabs similar to "Contracts" have working help pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:46:33 +0000 Subject: [Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12770, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14666 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:46:33 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13816 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:46:33 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13816 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:48:01 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:48:03 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42937|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 42999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42999&action=edit Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:48:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:48:23 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > I think there is a bug hiding in this patch - I try renewing a patron from > the sample database: > > localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=41 > Gloria Odom (23529000054503) > > it works ok without this patch, but with the patch I get redirected to: > http://localhost:8080/cgi-bin/koha/members/moremember.pl?41&was_renewed=1 > With the message: This patron does not exist. > Looks like we are missing the borrowernumber part in the URL? Erk, last minute change! Thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:51:47 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #5 from Jonathan Druart --- (In reply to Marc V?ron from comment #4) > Hi Jonathan, > > I tried to enter an invalid date, but we have the date picker for this date > - it seems no longer to be possible to enter invalid dates for the due date. > > Or do I miss a way to enter an invalid date? I have tried with the date of birth on creating/updating a patron. You get a JS alert box but are able to submit the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:53:08 +0000 Subject: [Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14917 Status|Failed QA |RESOLVED Depends on|13382 | --- Comment #7 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13382 *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 [Bug 13382] RDA: 700/710/711 display in XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:53:08 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14359 | --- Comment #50 from Jonathan Druart --- *** Bug 14359 has been marked as a duplicate of this bug. *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:53:08 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14359 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:53:31 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:53:34 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42573|0 |1 is obsolete| | --- Comment #4 from Magnus Enger --- Created attachment 43000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43000&action=edit Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems. Signed-off-by: Magnus Enger Before patch: RIS file has wrongly encoded chars After patch: RIS file has no endcoding problems Tested on a NORMARC setup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 11:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 09:58:46 +0000 Subject: [Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 --- Comment #3 from Theodoros Theodoropoulos --- This proposed addition to have the user define the size of the barcode is very useful indeed! But until then, with the current situation, we realized that the hardcoded relative values in Label.pm were very conservative for 'normal'-sized labels For our needs, we found out that a default value of 20% of the label height and 90% of the label width (compared to the original values of 10% and 80% respectably) produce taller barcodes that are easier to read. In case it helps anyone, the relevant patch to achieve this is: --- ./src/C4/Labels/Label.pm 2015-10-01 10:35:54.414837999 +0300 +++ ./src/C4/Labels/Label.pm.orig 2015-10-01 10:34:38.470837999 +0300 @@ -282,8 +282,8 @@ my $self = shift; my $barcode_llx = $self->{'llx'} + $self->{'left_text_margin'}; # this places the bottom left of the barcode the left text margin distance to right of the left edge of the label ($llx) my $barcode_lly = $self->{'lly'} + $self->{'top_text_margin'}; # this places the bottom left of the barcode the top text margin distance above the bottom of the label ($lly) - my $barcode_width = 0.8 * $self->{'width'}; # this scales the barcode width to 80% of the label width - my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # this scales the barcode height to 10% of the label height + my $barcode_width = 0.9 * $self->{'width'}; # this scales the barcode width to 90% of the label width + my $barcode_y_scale_factor = 0.02 * $self->{'height'}; # this scales the barcode height to 20% of the label height return 0, 0, 0, $barcode_llx, $barcode_lly, $barcode_width, $barcode_y_scale_factor; } (Needless to say again that the best approach would be to make it selectable by the user in the template screen!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:02:34 +0000 Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42509|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 43001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43001&action=edit Bug 14812: Display the help in the correct language If opaclanguages != language, the language of the help page is the default one (en). Test plan: 1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR 2/ Translate the fr-FR and ar-Arab templates. 3/ Go on the mainpage, switch to ar-Arab, go to the help page. The help page content should be in Arabian, not English. Signed-off-by: Magnus Enger Set language = en, sv-SE, nb-NO. opaclanguage = en, nb-NO Went to the intranet main page, selected Swedish and clicked on help Without the patch, help was displayed in English With the patch, help was displayed in Swedish. Yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:02:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:02:31 +0000 Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:23:57 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #22 from Jonathan Druart --- (In reply to Josef Moravec from comment #21) > I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try > it on another machine with MySQL tomorow... Using MariaDB I don't get the issue you have described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:31:50 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus at libriotech.no --- Comment #7 from Magnus Enger --- (In reply to Jonathan Druart from comment #5) > Test plan: > 0/ Do not apply this patch > 1/ Create a patron with a cardnumber with a quote (rm'me) and another > one without a quote (rmme) > 2/ Go on the checkouts page (circ/circulation.pl) > 3/ Renew the 2 patrons > => With rm'me you are redirected to the circ module - ok > => With rmme you are redirected to the member module - nok I can reproduce this without the patch. But after I apply the patch, I get this: rm'me: No JS popup confirmation, but redirected to the circ module rmme: JS popup confirmation, but redirected to the member module For rmme I get this error in the Firebug Console: SyntaxError: expected expression, got ',' firstDay: , For rm'me I get two errors: SyntaxError: expected expression, got ',' firstDay: , SyntaxError: missing ; before statement ...owernumber=6450&cardnumber=rm'me&desintation=circ&reregistration=y' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:36:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:36:33 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #23 from Josef Moravec --- Hm, on another machine everything works perfect... So probably some problem with my specific data, or something on that one VM. So please, ignore me ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:47:00 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #24 from Jonathan Druart --- Comment on attachment 39800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800 Bug 14101: Automatic renewals exactly on due date Review of attachment 39800: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14101&attachment=39800) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +2737,4 @@ > return ( 0, "too_many" ) > if $issuingrule->{renewalsallowed} <= $itemissue->{renewals}; > > + if ( defined $issuingrule->{norenewalbefore} ) { What about the empty string? I am not sure it's relevant, but I would like to be sure. @@ +2751,5 @@ > return ( 0, "too_soon" ); > } > + else { > + return ( 0, "auto_renew" ) if $itemissue->{auto_renew}; > + return ( 1, undef ); This last return is not needed, the process should continue I think. Imagine someone else adds a new check in the futur. @@ +2759,5 @@ > + # Fallback for automatic renewals: > + # If norenewalbefore is undef, don't renew before due date. > + elsif ( $itemissue->{auto_renew} ) { > + return ( 0, "auto_renew" ) > + if DateTime->now( time_zone => C4::Context->tz() ) >= Prefer dt_from_string to get a DateTime object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:49:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:49:13 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #29 from Jonathan Druart --- Comment on attachment 41054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054 Bug 14395: Code changes Review of attachment 41054: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14395&attachment=41054) ----------------------------------------------------------------- Please provide a better commit description. ::: C4/Circulation.pm @@ +2772,5 @@ > + { > + $soonestrenewal->truncate( to => 'day' ); > + } > + > + if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) ) Prefer dt_from_string to get a DateTime object (yes this already existed before your patch, but it's worth to make things consistent). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 12:59:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 10:59:35 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #21 from Jonathan Druart --- Created attachment 43002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43002&action=edit Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:03:06 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #22 from Jonathan Druart --- Marc, Thanks for testing. I have added the trick on the messaging and circulation history page. I have not changed the lists/shelves page, the module and script are going to be rewritten on another bug (bug 14544) and I don't want to introduce conflicts. I am not sure we should add the no-store value for the cache policy on other pages. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:04:58 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #6 from Jonathan Druart --- (In reply to Magnus Enger from comment #5) > Colin: What do you think of the proposal from Jonathan? > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > a good idea. No, I would like to keep my QA token. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:09:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:09:04 +0000 Subject: [Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 --- Comment #4 from Jonathan Druart --- If I remember correctly you must use an itemtype with a return policy. Whatever the value of the policy, the return branch will always be the homebranch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:11:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:11:25 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #8 from Jonathan Druart --- Magnus, could you confirm you have correctly cleared your browser cache? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:14:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:14:43 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #24 from Jonathan Druart --- Josef, if you are still able to reproduce the issue, with the last patches against master, I think we should try to understand what is the problem :) Could you confirm you got the issue even with a non-empty creator_batches table? I have not tried with en empty table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:18:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:18:57 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #5 from Marc V?ron --- Created attachment 43003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43003&action=edit [Signed-off] Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error Counter patch works as expected and is a much cleaner solution. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:19:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:19:51 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:27:47 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I think this needs small tweaks. For instance, compare the "+" icon on /cgi-bin/koha/serials/serials-home.pl Before this patch, it was correctly aligned, now it's not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:39:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:39:32 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #23 from Marc V?ron --- Created attachment 43004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43004&action=edit [Signed-off] Bug 5371: Force no caching for private pages at the OPAC In order no to slow too much the browsing, it is certainly not a good idea to add this cache-control value for all pages at the OPAC. This patch just adds where the author found it could be useful. Test plan: 1/ Login at the OPAC 2/ Go on the account page (opac/opac-account.pl) 3/ Click log out 4/ Use the back button of your browser Without this patch you will see the previous page. With this patch, the previous page will be reloaded and you will be redirected to the login form. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:39:42 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #9 from Magnus Enger --- (In reply to Jonathan Druart from comment #8) > Magnus, could you confirm you have correctly cleared your browser cache? Ah, not necessarily. I'll have another go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:39:50 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42911|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:40:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:40:57 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #24 from Marc V?ron --- Created attachment 43005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43005&action=edit [Signed-off] Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl Signed-off-by: Marc V?ron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:41:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:41:12 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43002|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:41:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:41:23 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:42:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:42:56 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #25 from Josef Moravec --- I tried it on non-empty table, but have the same issue... I am not able to figure out where is the problem.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:50:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:50:30 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 13:56:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 11:56:53 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart --- I was afraid of the complexity in the call stack, so did some tests: $ more bug_8483.pl use Modern::Perl; use C4::Members; my $borrowernumber=42; my $issues = GetAllIssues( $borrowernumber, 'date_due desc' ); > select count(*) from old_issues where borrowernumber=42; 43 > select count(*) from issues where borrowernumber=42; 7 $ git checkout master; git reset --hard origin/master $ git checkout -b bug_8483; git bz apply 8483 $ git checkout master; time perl bug_8483.pl perl bug_8483.pl 1.23s user 0.04s system 99% cpu 1.270 total $ git checkout bug_8483; time perl bug_8483.pl perl bug_8483.pl 1.50s user 0.05s system 99% cpu 1.560 total # => Ok we get the old_issues in addition of # Adding some issues to the patron > select count(*) from issues where borrowernumber=42; 49 # master perl bug_8483.pl 1.21s user 0.08s system 99% cpu 1.280 total # bug_8483 perl bug_8483.pl 1.82s user 0.07s system 97% cpu 1.933 total 210 # master perl bug_8483.pl 1.21s user 0.07s system 98% cpu 1.293 total # bug_8483 perl bug_8483.pl 2.73s user 0.09s system 95% cpu 2.959 total 600 # master perl bug_8483.pl 1.28s user 0.03s system 97% cpu 1.340 total # bug_8483 perl bug_8483.pl 4.78s user 0.10s system 94% cpu 5.154 total -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:02:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:02:54 +0000 Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Christophe Brocquet changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.brocquet at obspm.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:04:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:04:17 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:04:54 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:05:01 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42999|0 |1 is obsolete| | --- Comment #10 from Magnus Enger --- Created attachment 43006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43006&action=edit Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted Signed-off-by: Magnus Enger Followed the test plan, works as advertised. (I did have some problems initially, but that was caused by me not using the interface in English...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:09:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:09:12 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:33:27 +0000 Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:42:44 +0000 Subject: [Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Assignee|koha-bugs at lists.koha-commun |j.kylmala at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:56:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:56:33 +0000 Subject: [Koha-bugs] [Bug 14932] New: serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Bug ID: 14932 Summary: serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:57:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:57:20 +0000 Subject: [Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 43007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43007&action=edit Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 14:57:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 12:57:39 +0000 Subject: [Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:08:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:08:25 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #7 from Colin Campbell --- (In reply to Magnus Enger from comment #5) > Colin: What do you think of the proposal from Jonathan? > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > a good idea. (In reply to Jonathan Druart from comment #6) > (In reply to Magnus Enger from comment #5) > > Colin: What do you think of the proposal from Jonathan? > > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > > a good idea. > > No, I would like to keep my QA token. Its not really a transaction method but a utility but will attempt to test that solution -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:13:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:13:29 +0000 Subject: [Koha-bugs] [Bug 14933] New: SIPserver should not use warn or die to log errors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 Bug ID: 14933 Summary: SIPserver should not use warn or die to log errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com warn and die are used in various places in the SIPServer but the messages are lost as STDERR is closed by Net::Server in these cases the error message should be logged to syslog as with other error and debug messages and exit should be used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:16:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:16:09 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Barton, to be consistent we should display the biblioitems fields when creating/editing a letter from the "reserves" module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:18:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:18:27 +0000 Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 --- Comment #3 from Katrin Fischer --- Hm, there is also the other way around - if we make Koha-to-MARC-Mappings 1:n, we also need to change the procedures that are used for creating a record from a non-marc format, for example in acquisitions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:18:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:18:34 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #29 from Jonathan Druart --- To test bug 13918 I need to apply this patch set before but it does not apply anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:31:58 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #5 from Jonathan Druart --- Comment on attachment 42978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42978 [SIGNED-OFF] Bug 14504: Add delete_items.pl: a command line batch deletion tool Review of attachment 42978: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14504&attachment=42978) ----------------------------------------------------------------- FAIL misc/cronjobs/delete_items.pl FAIL pod *** WARNING: Verbatim paragraph in NAME section in file misc/cronjobs/delete_items.pl ::: misc/cronjobs/delete_items.pl @@ +1,4 @@ > +#! /usr/bin/perl > + > +use warnings; > +use strict; warnings and strict are useless when Modern::Perl is already used. @@ +8,5 @@ > +use C4::Circulation; > +use Modern::Perl; > +use Pod::Usage; > + > +my $VERSION='1.0'; How this is useful? We usually don't use it in scripts. @@ +30,5 @@ > + , help => '' > + , manual => '' > + , version => '' > + } > +}; I am not really in favor of these 2 variables. IMO it is preferable to stick to the structure of the already existing scripts in misc/* @@ +39,5 @@ > + , 'V|version' => sub { $OPTIONS->{flags}->{version} = 1 } > + , 'h|help' => sub { $OPTIONS->{flags}->{help} = 1 } > + , 'm|manual' => sub { $OPTIONS->{flags}->{manual} = 1 } > + , 'c|commit' => sub { $OPTIONS->{flags}->{commit} = 1 } # aka DO-EET! > + , 'dry-run' => sub { $OPTIONS->{flags}->{commit} = 0; I don't think dry-run is useful, it's in dry-run mode if commit is not given. @@ +51,5 @@ > + exit; > +} > + > +pod2usage( -verbose => 2 ) if $OPTIONS->{flags}->{manual}; > +pod2usage(1) if ( $OPTIONS->{flags}->{help} || scalar @criteria == 0 ); The script should not return 1 if help is specified. It would be good to display on error for the @criteria==0 case (see msg option of pod2usage). @@ +65,5 @@ > +my $where_clause = ' where ' . join ( " and ", @criteria ); > + > +verbose "Where statement: $where_clause"; > + > +$GLOBAL->{sth}->{target_tiems} = $dbh->prepare( $query->{target_items} . $where_clause ); typo tiems vs items, I suppose. @@ +71,5 @@ > + > +DELITEM: while ( my $item = $GLOBAL->{sth}->{target_tiems}->fetchrow_hashref() ) { > + my $issue = GetOpenIssue( $item->{itemnumber} ); > + if( defined $issue ) { > + verbose "Cannot delete '$item->{itemnumber}' -- item is checked out." Shouldn't we also search for holds? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:32:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:32:05 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:33:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:33:38 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Bug 14788 fixes the ccode problem, but not the "multiple values" problem. So here is a patch that try to fix it (depends on 14788): -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:33:52 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #12 from Julian Maurice --- Created attachment 43008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43008&action=edit Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:34:07 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14788 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 [Bug 14788] Move opac-topissues.pl code into C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:34:07 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11139 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 [Bug 11139] opac-topissues does not work with CCODE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:34:20 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:34:34 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:38:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:38:50 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #6 from Marc V?ron --- Ok, I can make it explode if I enter 0000-00-00 for date of birth: --- Can't locate object method "ymd" via package "dateformat" (perhaps you forgot to load "dateformat"?) at /usr/share/kohaclone/Koha/DateUtils.pm line 206. --- I think we need a generic function in Koha::DateUtils to test a date string against the 'dateformat' syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:40:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:40:58 +0000 Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:41:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:41:01 +0000 Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42974|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43009&action=edit Bug 14927 Returns item info when resumptionToken is used To test: - activate OAI-PMH with the inclusion of items as explained on bug 12252 - set the OAI-PMH:MaxCount to a low number, 50 for instance - go to the OAI-PMH page to get the records : [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml - check that item data is included - get the resumptionToken at the end of the xml - got to the next page of records [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&resumptionToken=[your resumption token] - check that item data is now missing Apply the patch, and repeat previous steps: item data is back. Signed-off-by: Gaetan Boisson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:44:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:44:43 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:44:46 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42998|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43010&action=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=XXXX) - Verify that Help displays as appropriate. Signed-off-by: Magnus Enger Works as advertised. All the tabs similar to "Contracts" have working help pages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:45:10 +0000 Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:52:48 +0000 Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:52:51 +0000 Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42893|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43011&action=edit Bug 14900: Add ability to pay all fees at once from circulation screen Test plan: 1) Go to circulation screen for patron which has some not-payed charges (or make same if needed) 2) You should see infromation about fees and charges with ability to pay it. Note there is new link for paying all charges at once 3) Try the new link, you should be redirected to members/paycollect.pl, check if there is right amount and try to pay charges 4) try the old link to make sure it works still well after this patch Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:53:16 +0000 Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 15:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 13:54:26 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #7 from Jonathan Druart --- Marc's suggestion sounds like a good compromise :) Josef, do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:05:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:05:53 +0000 Subject: [Koha-bugs] [Bug 14934] New: Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 Bug ID: 14934 Summary: Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be very helpful to add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Thus, it will be possible to print the barcode in the fine invoice. Please see PDF attached -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:08:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:08:15 +0000 Subject: [Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 --- Comment #1 from bondiurbano --- Created attachment 43012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43012&action=edit Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Fines view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:09:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:09:48 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:10:19 +0000 Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:10:22 +0000 Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42942|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43013&action=edit Bug 14858: removed record length limit test Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:10:52 +0000 Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11399 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:10:52 +0000 Subject: [Koha-bugs] [Bug 11399] batch rebuild items tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14858 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:11:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:11:14 +0000 Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 --- Comment #6 from Jonathan Druart --- Thanks for the test plan Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:22:00 +0000 Subject: [Koha-bugs] [Bug 14935] New: waiting and in transit items cannot be reserved Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Bug ID: 14935 Summary: waiting and in transit items cannot be reserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com There's an issue with the possibility to place a hold on items waiting to be pick-up or in transit when you choose that on shelf holds are not allowed. In this case, items are not checked-out so there are considered to be available. But, they aren't, they are not on a shelf ready to be chosen by a patron but stored aside. So, other patrons should place a hold on it as they couldn't go on shelves to take it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:22:48 +0000 Subject: [Koha-bugs] [Bug 4319] waiting items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|REOPENED |RESOLVED --- Comment #25 from Koha Team Lyon 3 --- *** This bug has been marked as a duplicate of bug 14935 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:22:48 +0000 Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nahuel.angelinetti at biblibre | |.com --- Comment #1 from Koha Team Lyon 3 --- *** Bug 4319 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:22:56 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42355|0 |1 is obsolete| | --- Comment #8 from Colin Campbell --- Created attachment 43014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43014&action=edit Revised patch Revised to remove duplication of method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:24:22 +0000 Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anthony.laquerre at ccsr.qc.ca | |, chris at bigballofwax.co.nz, | |fridolin.somers at biblibre.co | |m, | |jesse at bywatersolutions.com, | |katrin.fischer at bsz-bw.de, | |koha-bugs at lists.koha-commun | |ity.org, | |koha at univ-lyon3.fr, | |marjorie.barry-vila at ccsr.qc | |.ca, nengard at gmail.com, | |Susanne.Jerger at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:24:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:24:42 +0000 Subject: [Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Colin Campbell --- Revised patch to inherit method from base class - works for me with Checkin and Renewal requests - please test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:57:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:57:48 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42853|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43015&action=edit Bug 14888: Add Koha::Cit[y|ies] classes Tested both patches together, works as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 16:59:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 14:59:39 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #6 from Jonathan Druart --- Last patch just removes +use C4::Members::Messaging; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:17:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 15:17:03 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #7 from Jonathan Druart --- You can try with: 32/01/1970 Actually it will explode if the date is not correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:27:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 15:27:33 +0000 Subject: [Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 bondiurbano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43012|0 |1 is obsolete| | --- Comment #2 from bondiurbano --- Created attachment 43016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43016&action=edit Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Fines view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 15:36:47 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #33 from Jonathan Druart --- Kyle, I don't understand how the changes you introduced in the tests for AddReserve highlight your changes in the subroutine. It would be better to first submit a patch to fix the issue then to clean some stuffs (indentation, replacement with Koha::Objects, etc.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:57:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 15:57:10 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:58:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 15:58:11 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #125 from Charles Farmer --- Created attachment 43017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43017&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 17:59:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 15:59:27 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu at inlibro.com |charles.farmer at inlibro.com CC| |charles.farmer at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:01:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:01:56 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42253|0 |1 is obsolete| | --- Comment #8 from Jesse Weaver --- Created attachment 43018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43018&action=edit Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:01:54 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:02:11 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:02:52 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42547|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver --- Created attachment 43019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43019&action=edit Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:06:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:06:08 +0000 Subject: [Koha-bugs] [Bug 14936] New: Add validation for date strings to Koha::DateUtils Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Bug ID: 14936 Summary: Add validation for date strings to Koha::DateUtils Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Patch to add a generic function in Koha::DateUtils to test a date string against the 'dateformat' syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:13:22 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 --- Comment #1 from Marc V?ron --- Created attachment 43020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43020&action=edit Bug 14936 - Add validation for date strings to Koha::DateUtils To test: - Apply patch - prove t/DateUtils.t Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug and test as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:16:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:16:58 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43020|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43021&action=edit Bug 14936 - Add validation for date strings to Koha::DateUtils To test: - Apply patch - prove t/DateUtils.t Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug and test as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:18:47 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14924 Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 [Bug 14924] Remove C4::Dates from members/memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:18:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:18:47 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14936 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:25:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:25:45 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42968|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43022&action=edit [SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro Works as expected. Magnifying glass icon corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:27:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:27:57 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43022|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 43023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43023&action=edit [SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro Works as expected. Magnifying glass icon corrected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:28:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:28:31 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:46:58 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #26 from Barton Chittenden --- Getting Software error: Can't call method "get_attr" without a package or object reference at /home/barton/kohaclone/patroncards/edit-batch.pl line 125. To re-create: 1/ go to Home ? Tools ? Patron card creator ? Manage card Batches (cgi-bin/koha/patroncards/manage.pl?card_element=batch) 2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new) 3/ click 'Add items' (opens new window -- cgi-bin/koha/patroncards/add_user_search.pl) 4/ click 'Search' to show all patrons (I don't have that many) 5/ click 'Add' on first patron -> Software error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:48:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:48:49 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:48:58 +0000 Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ulrich.kleiber at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 18:58:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 16:58:43 +0000 Subject: [Koha-bugs] [Bug 14937] New: Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Bug ID: 14937 Summary: Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org C4::Letters::_parseletter will replace reserves.expirationdate with the date a hold will be marked as problematic ( holds over ) if both ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled. There is no reason this feature needs to rely on ExpireReservesMaxPickUpDelay as there are many libraries that would like to send the last day to pick up a hold in notices, but would rather deal with the expired waiting holds manually rather than have Koha cancel them automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:01:38 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:01:40 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 --- Comment #1 from Kyle M Hall --- Created attachment 43024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43024&action=edit Bug 14937 - Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay C4::Letters::_parseletter will replace reserves.expirationdate with the date a hold will be marked as problematic ( holds over ) if both ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled. There is no reason this feature needs to rely on ExpireReservesMaxPickUpDelay as there are many libraries that would like to send the last day to pick up a hold in notices, but would rather deal with the expired waiting holds manually rather than have Koha cancel them automatically. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Disable ExpireReservesMaxPickUpDelay 4) Add reserves.expirationdate to your HOLD notice 5) Fill a hold for a patron 6) View the message, not that reserves.expirationdate is replaced with the date the hold will be marked as problematic -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:01:51 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:01:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:01:57 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:37:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:37:13 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41442|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 43025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43025&action=edit [SIGNED-OFF]Bug 14671 - Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result Signed-off-by: Hector Castro Works as advertised. Tranlated OK, tested in spanish es-ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:39:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:39:14 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off --- Comment #3 from H?ctor Eduardo Castro Avalos --- Hi Fridolin. Just one question, how the users will know the meaning of the acronym? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:52:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:52:03 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42424|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 19:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 17:52:40 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Winona Salesky changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:00:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 18:00:56 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 --- Comment #8 from Josef Moravec --- I absolutely agree. I'll try to go this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:29:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 18:29:02 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:29:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 18:29:05 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42709|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 43026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43026&action=edit Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1. Includes class="suppressed_opac" for library specific styles. Suggested css: .suppressed_opac { color:red; font-size:1.25em; font-weight:bold; float:right; margin-right:2em; clear:none; } Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 18:30:35 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #8 from Nick Clemens --- Works as expected. Style note: Without recommended CSS the 'Suppressed in Opac' in search results is next to result number and above title/author. I think the default location should be below these two if possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 20:44:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 18:44:05 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #7 from Barton Chittenden --- Just to be clear, this is ready for QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 21:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 19:20:21 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 21:31:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 19:31:01 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #29 from Charles Farmer --- Since June, did the BibLibre team had any chance to test/review/give their opinion on the matter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 21:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 19:37:28 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43021|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 43027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43027&action=edit Bug 14936 - Add validation for date strings to Koha::DateUtils To test: - Apply patch - prove t/DateUtils.t Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug and test as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:09:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:09:26 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #8 from Marc V?ron --- Created attachment 43028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43028&action=edit Bug 14924 - (follow-up) Add date validation This patch adds a date validation (see comment #3). To test: - Make sure that you test on top of Bug 14936 (Add validation for date strings to Koha::DateUtils - Apply patch - Create a new user or edit an existing user - Try valid dates for date of birth - Try invalid dates as 0000-00-00 or 32/01/1970. You can can copy/paste such strings to the date field, ignore the warning message and submit. Verify that after submit you get a message "Date of birth is invalid" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:10:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:10:03 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:10:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:10:34 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:32:02 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #27 from Barton Chittenden --- (In reply to Barton Chittenden from comment #26) > Getting > > Software error: > > Can't call method "get_attr" without a package or object reference at > /home/barton/kohaclone/patroncards/edit-batch.pl line 125. > > To re-create: > > 1/ go to Home ? Tools ? Patron card creator ? Manage card Batches > (cgi-bin/koha/patroncards/manage.pl?card_element=batch) > 2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new) > 3/ click 'Add items' (opens new window -- > cgi-bin/koha/patroncards/add_user_search.pl) > 4/ click 'Search' to show all patrons (I don't have that many) > 5/ click 'Add' on first patron -> Software error. This was user error on my part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:35:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:35:37 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:35:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:35:42 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43025|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 43029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43029&action=edit [PASSED QA] Bug 14671 - Allow correct translation of CAS authentication In authentication pages with CAS, the use of acronym or abbr tags does not allow a correct translation of the text. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983#c7 It does not help a lot end users to know that CAS is Central Authentication Service, I think. Now one can custom the login page with NoLoginInstructions syspref to describe how to use the authentication. This patch removes the use of acronym and abbr is authentication pages. Test plan (example with fr-FR locale) : - Without patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a " - Is is translated in : msgstr "Si vous avez un compte " - Apply patch - Update translation files : cd misc/translator ; perl translate update fr-FR - You see in fr-FR-opac-bootstrap.po : msgid "If you have a CAS account, %s please " - You can now translate it : msgstr "Si vous avez un compte CAS, %s veuillez " - Same test for intranet authentication page - Install the translation : cd misc/translator ; perl translate install fr-FR - Look at the result Signed-off-by: Hector Castro Works as advertised. Tranlated OK, tested in spanish es-ES Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:38:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:38:29 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #4 from Marc V?ron --- Created attachment 43030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43030&action=edit Bug 14923 - (follow-up) Test for invalid date input See comment #3 To test: - Make sure that you test on top of Bug 14936 (Add validation for date strings to Koha::DateUtils - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as 0000-00-00 or 32/01/1970 (copy/paste to date fields). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:39:08 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14923 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 [Bug 14923] Remove C4::Dates from labels/label-item-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:39:08 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14936 Patch complexity|Trivial patch |Small patch Status|Failed QA |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:39:16 +0000 Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:39:19 +0000 Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43001|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 43031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43031&action=edit [PASSED QA] Bug 14812: Display the help in the correct language If opaclanguages != language, the language of the help page is the default one (en). Test plan: 1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR 2/ Translate the fr-FR and ar-Arab templates. 3/ Go on the mainpage, switch to ar-Arab, go to the help page. The help page content should be in Arabian, not English. Signed-off-by: Magnus Enger Set language = en, sv-SE, nb-NO. opaclanguage = en, nb-NO Went to the intranet main page, selected Swedish and clicked on help Without the patch, help was displayed in English With the patch, help was displayed in Swedish. Yay! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:57:30 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:57:33 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43006|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 43032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43032&action=edit [PASSED QA] Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted Signed-off-by: Magnus Enger Followed the test plan, works as advertised. (I did have some problems initially, but that was caused by me not using the interface in English...) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:57:59 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43027|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43033&action=edit [SIGNED-OFF]Bug 14936 - Add validation for date strings to Koha::DateUtils To test: - Apply patch - prove t/DateUtils.t Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug and test as appropriate. Signed-off-by: Hector Castro Tested in conjunction with patches 14923 and 14924 with different date formats Tested with wrong formats 32/01/1970, 00-00-0000 and 0000-00-00 Test units pass OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 22:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 20:58:48 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:03:36 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42965|0 |1 is obsolete| | --- Comment #28 from Nick Clemens --- Created attachment 43034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43034&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:04:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:04:16 +0000 Subject: [Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:04:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:04:19 +0000 Subject: [Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42803|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 43035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43035&action=edit [PASSED QA] Bug 14842: Wrong call to GetBranchItemRule >From bug 7981: GetBranchItemRule expects an itemtype, a scalar. Here $itemtype is a hashref returned by C4::ItemType->get. So $itemtype->{itemtype} should be passed. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:07:02 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #4761|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:33:44 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:33:47 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43004|0 |1 is obsolete| | Attachment #43005|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer --- Created attachment 43036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43036&action=edit [PASSED QA] Bug 5371: Force no caching for private pages at the OPAC In order no to slow too much the browsing, it is certainly not a good idea to add this cache-control value for all pages at the OPAC. This patch just adds where the author found it could be useful. Test plan: 1/ Login at the OPAC 2/ Go on the account page (opac/opac-account.pl) 3/ Click log out 4/ Use the back button of your browser Without this patch you will see the previous page. With this patch, the previous page will be reloaded and you will be redirected to the login form. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:35:16 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #26 from Katrin Fischer --- Created attachment 43037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43037&action=edit [PASSED QA] Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:40:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:40:34 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #27 from Katrin Fischer --- Fixes a long existing security and privacy problem, but also changes behaviour a bit: when you are logged in and you try to use the back button, you will see a warning, that the browser won't automatically request the page again. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:48:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:48:50 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43034|0 |1 is obsolete| | --- Comment #29 from Nick Clemens --- Created attachment 43038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43038&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:49:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:49:22 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I tried with Arabic and some other diacritics, exported from detail page and cart, but can't reproduce the issue. Can you retest please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:49:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:49:49 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 --- Comment #6 from Katrin Fischer --- ... it doesn't happen on a MARC21 db... sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:58:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:58:29 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 1 23:58:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 21:58:32 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43000|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 43039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43039&action=edit [PASSED QA] Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems. Signed-off-by: Magnus Enger Before patch: RIS file has wrongly encoded chars After patch: RIS file has no endcoding problems Tested on a NORMARC setup. Signed-off-by: Katrin Fischer Tested on a MARC21 and a UNIMARC database. Problem only confirmed for UNIMARC, but no regressions in MARC21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 00:11:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 22:11:09 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Some first notes on this: I tested adding modifying and deleting cities and the display of the the cities list. All works well. but 3 requests, most important first: 1) Unit tests please! 2) Should the copyright line be updated/amended in cities.pl? # Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN 3) A suggestion for the error messages: use 'adding' instead of 'inserting' - as that fits with the terminology in Koha a bit better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 00:15:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 22:15:48 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43038|0 |1 is obsolete| | --- Comment #30 from Barton Chittenden --- Created attachment 43040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43040&action=edit [SIGNED-OFF] Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 00:20:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 22:20:13 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #31 from Barton Chittenden --- (In reply to Barton Chittenden from comment #30) > Created attachment 43040 [details] [review] > [SIGNED-OFF] Bug 14739 - Add several patrons to a new batch will create a > new batch per patron added > > This patch changes the functionality of adding patrons to patroncard > batches. Instead of using only the patron search, there is now a textarea > which can either be manually populated with borrowernumbers, or can be > populated using the patron-search > > To test: > 1 - Create a new patron batch > 2 - Click the add items button, if there is no data in the borrowrnumber > form you should get a popup > 3 - Add items to batch using the popup, borrowernumbers should populate to > the form > 4 - Click add items again and items should be added to a new batch > 5 - Create a new batch > 6 - Manually enter invalid borrowernumbers to the form > 7 - Click add items, batch should return empty > 8 - Manually enter valid borrowernumber > 9 - Click add items, batch should be updated > 10 - Edit an existing batch and confirm add items works as above > 11 - Create a new label batch > 12 - Click add items with no data, popup item search should appear > 13 - Adding items by checking boxes or using 'Add' button - they should > populate the text box on the edit batch page > 14 - When adding using form the 'Enter by itemnumber' button should be > marked automatically > 15 - Submit items and confirm they are added to batch > 16 - Create a new batch, enter by barcode manually and check 'Enter by > itemnumber" > 17 - Click add items, no items should be added > 18 - Repopulate form with barcodes, check 'Enter by barcode' > 19 - Click add items, items should be added correctly > 20 - Test various combinations of radio buttons and numbers and using form > or not > > Signed-off-by: Barton Chittenden I've tested without error, and I'm signing off, but I know that Jonathan wants to see if we can replicate the errors that Josef Moravec was seeing, so I'm not going to set the status of the bug as a whole to 'Signed Off'. This is simply saying 'the patch works for me'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:22:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:22:42 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #20 from David Cook --- (In reply to Jonathan Druart from comment #19) > I am not familiar with ccl.properties, but there is a > st-numeric 4=109 r=o > > Does > - st-date-normalized 4=5 > + st-date-normalized 4=5 r=o > could do the trick for all date indexes? Yes! That is probably a better idea! I was suggesting on bug 12897 that we use ranges for all date indexes, and I think that would be the way to do it. What's the best way to move forward? Should I provide an alternative patch? Perhaps Barton can sign that one off, and Jonathan you can still QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:36:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:36:23 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:36:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:36:25 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42145|0 |1 is obsolete| | --- Comment #3 from Jesse Weaver --- Created attachment 43041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43041&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. Signed-off-by: Michael Sauers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:37:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:37:29 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42252|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver --- Created attachment 43042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43042&action=edit Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Test plan: 1. Open OPAC self-registration page while logged out. 2. Note that cardnumber and categorycode are not shown. 3. Remove cardnumber and categorycode from PatronSelfRegistrationBorrowerUnwantedField. 4. Enable autoMemberNum. 5. Reload self-registration page, note that categorycode now shows. 6. Disable autoMemberNum. 7. Reload self-registration page, note that cardnumber now shows. 8. Try saving a patron with an existing cardnumber; this should fail and explain why. 9. Set CardnumberLength, and verify that those length restrictions are enforced. 10. Verify that patron can be created with custom categorycode and cardnumber. Signed-off-by: Michael Sauers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:38:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:38:08 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:38:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:38:14 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:38:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:38:32 +0000 Subject: [Koha-bugs] [Bug 14938] New: Dependency updates from bug 13791 prevent installation on jessie Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Bug ID: 14938 Summary: Dependency updates from bug 13791 prevent installation on jessie Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bad tcohen, no biscuit :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:39:08 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13791 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 [Bug 13791] Plack - Out of the box support on packages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 01:39:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 01 Oct 2015 23:39:08 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14938 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 02:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 00:32:44 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 --- Comment #1 from Robin Sheat --- Created attachment 43043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43043&action=edit Bug 14938: fix dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 02:32:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 00:32:42 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 02:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 00:32:59 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 02:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 00:33:05 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 02:38:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 00:38:02 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 --- Comment #2 from Robin Sheat --- Related: https://groups.google.com/forum/#!topic/linux.debian.maint.perl/e2tx-rdk7t0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 03:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 01:42:44 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- (In reply to Robin Sheat from comment #0) > Bad tcohen, no biscuit :) :-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 03:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 01:43:29 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #21 from Barton Chittenden --- (In reply to David Cook from comment #20) > (In reply to Jonathan Druart from comment #19) > > I am not familiar with ccl.properties, but there is a > > st-numeric 4=109 r=o > > > > Does > > - st-date-normalized 4=5 > > + st-date-normalized 4=5 r=o > > could do the trick for all date indexes? > > Yes! That is probably a better idea! I was suggesting on bug 12897 that we > use ranges for all date indexes, and I think that would be the way to do it. > > What's the best way to move forward? Should I provide an alternative patch? > Perhaps Barton can sign that one off, and Jonathan you can still QA? That works by me. --Barton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 04:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 02:34:26 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- Similar to Bug 14798 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 04:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 02:36:38 +0000 Subject: [Koha-bugs] [Bug 14798] Renew and checkin do not update parts of checkout page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- This should be fixed along with Bug 14803 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 04:43:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 02:43:58 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- This was fast, I deserve a biscuit :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 04:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 02:44:20 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 04:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 02:45:15 +0000 Subject: [Koha-bugs] [Bug 14938] Dependency updates from bug 13791 prevent installation on jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14938 --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Robin! PS: I pushed it fast, I deserve the biscuit :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 07:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 05:44:15 +0000 Subject: [Koha-bugs] [Bug 14933] SIPserver should not use warn or die to log errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 07:52:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 05:52:49 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #32 from Josef Moravec --- Now I now where is the difference. It's plack! When I stop using plack, everything works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:18:17 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:18:20 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42938|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 43044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43044&action=edit [PASSED QA] Bug 14871: Extend the patrons search to search like %$term% (checkout tab) The patrons search used by the checkout tab and the autocomplete is not the same as the "search patrons" tab. The main difference is the "contain" vs "start with". So that if you have a patron with a patron with a surname "foo bar" and you search for "foo bar", the autocomplete and the result of a search by the checkout tab will search for "foo%" or "bar%" which won't return the patron you are search for. This patch replaces both autocomplete and checkout tab searches with a "contain" search. The search will be "%foo%" or "%bar%". Note that on big DB, this can cause unexpected results. Test plan: Create a patron with a surname "foo bar" Search for "bar" using the checkout tab. You should see the patron in the autocomplete result and the result page after submitting the search form. Followed test plan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:21:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:21:14 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- This works as described, but I am concerned about the consequences for big library systems with lots of patron data. The search is very wide now, so it might get really hard to spot the one you have been actually looking for between those that just contain your typed in 3-4 letters. Are there better ways we could achieve this? like "p%" or like " p%" or like "-p%" maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:22:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:22:15 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:23:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:23:10 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:29:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:29:08 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Julian, With the patch, the checkouts on the result table do no longer sort numerically but alpabetically, something like: 1 -14 - 2- 26- 89 instead of 1 -2 -14 -26- 89 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:49:27 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #3 from Julian Maurice --- Hi Marc, I have the same behaviour on master, I don't think the patch is responsible for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 08:57:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 06:57:45 +0000 Subject: [Koha-bugs] [Bug 14939] New: OAI Server classes must be modularized Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Bug ID: 14939 Summary: OAI Server classes must be modularized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. Its classes must be modularized : putting each class in a separate file in a Koha::OAI namespace. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:13:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:13:13 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #13 from Fridolin SOMERS --- Nice job Julian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:13:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:13:16 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:14:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:14:13 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 --- Comment #5 from Fridolin SOMERS --- (In reply to H?ctor Eduardo Castro Avalos from comment #3) > Hi Fridolin. > > Just one question, how the users will know the meaning of the acronym? I think today people are used to search on internet. And library can customise this login page to explain which authentication to choose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:17:55 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Marc, This is not the way to go, for several reasons. The main reason is that you c/p dt_from_string to create the new subroutine, which is bad. Then, if you have a look at dt_from_string, you will note 1 eval around the first DateTime->new (l. 156), but not around the second one (l. 164). So I think there are at least 2 better ways to know if a date is not correctly formatted: 1/ add an eval around the second DateTime->new call, the subroutine will return undef and the caller will have to check if something has been returned ; 2/ or catch the croak raised by the DateTime in the callers I don't know what I would prefer (a bit early and not drank enough tea yet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:18:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:18:21 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:18:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:18:40 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:18:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:18:58 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:24:40 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14666, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13816 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:24:40 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12769 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:24:40 +0000 Subject: [Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12769 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:24:59 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:25:01 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #1 from Fr?d?ric Demians --- Created attachment 43045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43045&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI namespace. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:25:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:25:55 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:29:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:29:39 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #27) > Fixes a long existing security and privacy problem, but also changes > behaviour a bit: when you are logged in and you try to use the back button, > you will see a warning, that the browser won't automatically request the > page again. I don't remember I got a warning. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:31:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:31:06 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #10 from Martin Persson --- Created attachment 43046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43046&action=edit Bug 14248 - Optionally display authorship for news Test plan: * Apply dependant patches 14246 and 14247. * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Go to 'Tools' -> 'News' and add some news items (at least 2). * Use the MySQL command line tool to edit the opac_news table, removing the user id from one of the news items: $ mysql -u kohaadmin -p -D koha > SELECT `idnew`, `title`, `borrowernumber` FROM `opac_news`; * Make a mental note of one of the 'newid' numbers to change. > UPDATE `opac_news` SET `borrowernumber` = NULL WHERE `idnew` = ; * Now one of the news items will have no user id, and no author should be shown for it. * Go to OPAC and Staff client and make sure the display modes works as intended. * Repeat for all values, making sure that the settings works as intended. * The changed news item should have no author info shown at any time. * The unchanged news item should show your own user name if the settings match the section where it is displayed. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:31:50 +0000 Subject: [Koha-bugs] [Bug 14940] New: opac-topissues.pl sort is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Bug ID: 14940 Summary: opac-topissues.pl sort is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org A hidden text in "Checkouts" column prevent DataTables to sort numerically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:32:18 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 --- Comment #1 from Julian Maurice --- Created attachment 43047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43047&action=edit Bug 14940: Fix sorting in opac-topissues.pl There is hidden text in "Checkouts" cells that prevent DataTables to sort numerically. This patch adds the 'title-numeric' sort plugin and use it in opac-topissues.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:33:05 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Julian Maurice --- Created a new bug: Bug 14940 Switching back to Needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:33:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:33:29 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:44:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:44:53 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 --- Comment #6 from Marc V?ron --- Maybe a Syspref in 'Patrons' near 'PatronsPerPage'? -- to enable / disable a 'wider' search for autocomplete -- and/or to define different flavors (start with / contain / ...) -- and/or to give even the possibility to define the fields to search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:48:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:48:22 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #8 from Jonathan Druart --- Created attachment 43048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43048&action=edit Bug 14888: Update copyright and wording -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:48:24 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 --- Comment #7 from Katrin Fischer --- I didn't want to suggest another pref... but it would solve the immediate problem of the behaviour change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:48:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:48:26 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #9 from Jonathan Druart --- Created attachment 43049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43049&action=edit Bug 14888: Add tests for Koha::Cit[y|ies] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:49:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:49:34 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #29 from Katrin Fischer --- I tested a few times - maybe it's a firefox thing? I was using Firefox in Ubuntu. It was described as a privacy measure to not request pages not cached automatically again. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:49:56 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #7) > Some first notes on this: > > I tested adding modifying and deleting cities and the display of the the > cities list. All works well. but 3 requests, most important first: > > 1) Unit tests please! I am not sure they are useful in this case. The tests for Koha::Object[s] already cover this area. But they cannot hurt :) > 2) Should the copyright line be updated/amended in cities.pl? > # Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN > > 3) A suggestion for the error messages: use 'adding' instead of 'inserting' > - as that fits with the terminology in Koha a bit better. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:52:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:52:27 +0000 Subject: [Koha-bugs] [Bug 14798] Renew and checkin do not update parts of checkout page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.20 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 09:53:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 07:53:04 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:06:44 +0000 Subject: [Koha-bugs] [Bug 14941] New: Subfield defaults: Add information about substitutable values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Bug ID: 14941 Summary: Subfield defaults: Add information about substitutable values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you add 'user', 'YYYY, 'MM' and 'DD' as the default value for a subfield in the bibliographic frameworks, the field will be automatically filled with the data as appropriate. However, there is no information about this feature (hint in form, help page, manual). Related Bugs: - Bug 10294 - when the word "user" is included in default in framework, surname of login creating record inserted - Bug 7045 - Default-value substitution inconsistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:07:49 +0000 Subject: [Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:07:49 +0000 Subject: [Koha-bugs] [Bug 10294] when the word "user" is included in default in framework, surname of login creating record inserted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14941 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:08:16 +0000 Subject: [Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:08:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:08:16 +0000 Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14941 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:25:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:25:37 +0000 Subject: [Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:44:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:44:02 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 --- Comment #13 from Mason James --- (In reply to Liz Rea from comment #12) > Note to self to include "This makes Koha 3.18 compatible with Debian > (Jessie)" in the release notes. curious, would this be a problem in 3.16.x too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:45:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:45:28 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Kyle, is there a description of the feature available somewhere? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:52:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:52:02 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #33 from Jonathan Druart --- Created attachment 43050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43050&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:52:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:52:28 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #34 from Jonathan Druart --- (In reply to Josef Moravec from comment #32) > Now I now where is the difference. It's plack! > > When I stop using plack, everything works as expected. hehe, thanks Josef! Here is a patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:59:01 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- See comment #3 - I agree as there is some discussion here, another sign-off would be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:59:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:59:29 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12072 --- Comment #6 from Marc V?ron --- Hi Jonathan, Propositon 1/ changes the behaviour of dt_from_string. This function is spread all over the system, and we do not know what side effects it will have if we change the behavior regarding the return value. That's why I decided not to touch it at the moment. Proposition 2/ Catch a croak: Is that done by surrounding dt_from_string with an eval? (I simply do not know) My opinion is that it is much better to have a dedicated function to validate a date string. It works fine afak and it has tests. I know that it duplicates code, but that can easily be streamlined later, after we finally have added the long outstandig DD.MM.YYYY date format (Bug 12072). (In reply to Jonathan Druart from comment #5) > Marc, > This is not the way to go, for several reasons. > The main reason is that you c/p dt_from_string to create the new subroutine, > which is bad. > Then, if you have a look at dt_from_string, you will note 1 eval around the > first DateTime->new (l. 156), but not around the second one (l. 164). > So I think there are at least 2 better ways to know if a date is not > correctly formatted: > 1/ add an eval around the second DateTime->new call, the subroutine will > return undef and the caller will have to check if something has been > returned ; > 2/ or catch the croak raised by the DateTime in the callers > > I don't know what I would prefer (a bit early and not drank enough tea yet). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:59:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:59:29 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14936 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 10:59:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 08:59:58 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #22 from Jonathan Druart --- Yep, if it works, let's do it for all date indexes :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:13:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:13:53 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #4 from Jonathan Druart --- Comment on attachment 43041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43041 Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Review of attachment 43041: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14658&attachment=43041) ----------------------------------------------------------------- ::: opac/opac-memberentry.pl @@ +244,4 @@ > my %hidden_fields; > > my $BorrowerUnwantedField = > + C4::Context->preference( "PatronSelf" . ucfirst($action) . "BorrowerUnwantedField" ); As a grep fan, I would prefer to see the entire name of the prefs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:19:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:19:08 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42406|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 43051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43051&action=edit Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:20:25 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:20:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:20:47 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:22:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:22:36 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43040|0 |1 is obsolete| | --- Comment #35 from Josef Moravec --- Created attachment 43052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43052&action=edit [SIGNED-OFF] Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:23:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:23:57 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #36 from Josef Moravec --- It works like a charm ;) Thank you Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:24:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:24:50 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42474|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:25:14 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:32:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:32:26 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Julian, please provide tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:36:34 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #37 from Jonathan Druart --- There is something wrong in the first patch 59 my @item_numbers; #= $cgi->param('item_number') if $cgi->param('item_number'); Could someone re-upload a valid patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:37:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:37:39 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42474|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:37:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:37:58 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43040|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:38:49 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #38 from Josef Moravec --- Sorry, I did a mistake with obsoleting patches, now it should be OK, could you try it again please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:39:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:39:07 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #7 from Julian Maurice --- Created attachment 43053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43053&action=edit Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:41:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:41:30 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |julian.maurice at biblibre.com --- Comment #8 from Julian Maurice --- QA fix #2 not needed due to the removal of joins QA fix #3: the whole 'if' block is unnecessary, and wrong, since there is no placeholders in query. Replaced by a simple $sth2->execute; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:44:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:44:56 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #117 from Jonathan Druart --- I am getting error on the DB update process: C4::Installer::load_sql returned the following errors while attempting to load /home/koha/src/installer/data/mysql/elasticsearch_mapping.sql: ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for key 'index_name_2' ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for key 'index_name_2' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:46:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:46:07 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #118 from Jonathan Druart --- (In reply to Jonathan Druart from comment #117) > I am getting error on the DB update process: > C4::Installer::load_sql returned the following errors while attempting to > load /home/koha/src/installer/data/mysql/elasticsearch_mapping.sql: > ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for > key 'index_name_2' > ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for > key 'index_name_2' Robin, have a look at the patch "DB changes" I have attached on bug 14899, maybe it should be integrated here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:49:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:49:58 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42882|0 |1 is obsolete| | Attachment #42883|0 |1 is obsolete| | Attachment #42884|0 |1 is obsolete| | Attachment #42885|0 |1 is obsolete| | Attachment #42886|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 43054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43054&action=edit Bug 14899: Add Koha::SearchField[s] and Koha::SearchMarcMap[s] classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:50:01 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #10 from Jonathan Druart --- Created attachment 43055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43055&action=edit Bug 14899: Add tableDND JS lib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:50:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:50:04 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #11 from Jonathan Druart --- Created attachment 43056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43056&action=edit Bug 14899: DB changes This patch applies several changes to the DB structure introduced by the previous ES patch set: 1/ Add a search_field.label column => It will be easier to understand what the search_field does. Indeed, some are not user friendly: acqdate, an, pl, ff8-23, ln, etc. TODO later: Update the labels with correct values (at the moment label=name) 2/ Update the foreign key search_marc_to_field.search_marc_map_id with on delete cascase. This will permit to automatically remove the entries in search_marc_to_field when they are deleted in search_marc_map. 3/ Remove the index_name_2 unique constraint on the search_marc_map table. I don't understand how this could be useful, it was defined like (index_name, marc_type, marc_field), so it means a mapping cannot be defined twice with different values for facet, suggestible and sort. This limitation does not seem to make sense. Robin, please correct me if I am wrong :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:50:07 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #12 from Jonathan Druart --- Created attachment 43057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43057&action=edit Bug 14899: Add the mapping configuration page in the admin module This new page (admin/searchengine/elasticsearch/mappings.pl) will permit to manage the ES mappings. For the biblios and authorities indexes, the different mappings can be managed from this single page. The interface let you add, remove and update mappings. It's also possible to reorder the mappings, as the order can be important in the indexation process. Note that the table can be displayed in a different order that the one it was before saving, but the mappings are grouped by search field and the order inside the search field is preserved. Limitations: - If something went wrong during the insertion/deletion/modification, the users will loose all these changes. - Using the interface the user can defined several labels for a same field. The script will retrieve the first change and apply it, next ones will be avoided. TODO: - Add a specific permission (?) - Add some data checks client side (JS) - Use checkboxes for facet and suggestible (lazy today...) - Understand the difference between the 3 values that sortable can have and improve the value for the options in the select box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:50:10 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #13 from Jonathan Druart --- Created attachment 43058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43058&action=edit Bug 14899: Add a link to the new page in the admin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:50:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:50:14 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #11 from Martin Persson --- The last, updated patch has been rewritten to make use of the Koha Preferences system rather than the template variables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:50:58 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #14 from Jonathan Druart --- Patches updated, they now apply against the up-to-date catalyst/elastic_search branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:51:37 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #14 from Marc V?ron --- Hi Julian and Fridolin, It might be a good idea to have a separate syspref for the behavior of the most popular list instead of the double use of 'AdvancedSearchTypes' It would make things much more clearer. What do you think? Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 11:58:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 09:58:41 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #119 from Jonathan Druart --- Does the authorities index is supposed to work? I get Use of uninitialized value $id in concatenation (.) or string at misc/search_tools/rebuild_elastic_search.pl line 173. after a perl misc/search_tools/rebuild_elastic_search.pl -a -v and on /koha-es_authorities/_search?q=*&pretty "_index" : "koha-es_authorities", "_type" : "data", "_id" : "7c8462c8-c813-4013-9ab7-1ca77069bbc4", -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 12:10:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 10:10:20 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #120 from Jonathan Druart --- Robin, It seems that something was wrong during the rebase process. I have tried the updated branch without any success: $ git reset --hard catalyst/elastic_search $ installer/data/mysql/updatedatabase.pl # see error in previous comment, but I should not that the following is still true if I remove the unique key $ perl misc/search_tools/rebuild_elastic_search.pl -b -v # no error I can now only search for "*", other patterns return nothing, and /koha-es_biblios/_search?q=*&pretty shows entries like: { "_index" : "koha-es_biblios", "_type" : "data", "_id" : "11", "_score" : 1.0, "_source":{"record":[["LDR",null,null,"_","01199cam a22003134a 4500"],["001",null,null,"_","12011929"],["005",null,null,"_","20140507153623.0"],["008",null,null,"_","000518s2000 ch a b 001 0 eng "],["010"," "," ","a"," 00041664 "],["020"," "," ","a","1565924193"],["040"," "," ","a","DLC","c","DLC","d","DLC"],["042"," "," ","a","pcc"],["050","0","0","a","QA76.73.P22","b","G84 2000"],["082","0","0","a","005.2/762","2","21"],["100","1"," ","a","Guelich, Scott.","9","8"],["245","1","0","a","CGI programming with Perl /","c","Scott Guelich, Shishir Gundavaram and Gunther Birznieks."],["250"," "," ","a","2nd ed."],["260"," "," ","a","Beijing ;","a","Cambridge, Mass. :","b","O'Reilly,","c","2000."],["300"," "," ","a","xv, 451 p.","b","ill.","c","24 cm."],["504"," "," ","a","Includes bibliographical references (p. 403-406) and index."],["650"," ","0","a","Perl (Computer program language)","9","35"],["650"," ","0","a","CGI (Computer network protocol)","9","37"],["650"," ","0","a","Internet programming.","9","7"],["700","1"," ","a","Birznieks, Gunther.","9","38"],["856","4","2","3","Publisher description","u","http://www.loc.gov/catdir/enhancements/fy0715/00041664-d.html"],["906"," "," ","a","7","b","cbc","c","orignew","d","1","e","ocip","f","20","g","y-gencatlg"],["942"," "," ","2","ddc","c","BK"],["955"," "," ","a","to ASCD pc16 05-18-00; jf05 (desc.) 05/18/00 ; jf11 to sl 5-19-00; jf12 to Dewey 05-23-00;aa03 5-24-00;CIP ver jf0504/10/01; jf12 to BCCD 04-11-01"],["952"," "," ","0","0","1","0","4","0","6","_","7","0","8","GEN","9","32","a","ALPHA","b","ALPHA","c","GEN","d","2014-09-04","p","39999000000498","r","2014-09-04","w","2014-09-04","y","BK"],["999"," "," ","c","11","d","11"]],"_id":"11"} } There is something wrong when the tables are populated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 12:22:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 10:22:20 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #131 from Jonathan Druart --- I don't understand the current "in discussion" status, back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 12:36:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 10:36:43 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #30 from Kyle M Hall --- (In reply to Katrin Fischer from comment #29) > I tested a few times - maybe it's a firefox thing? I was using Firefox in > Ubuntu. It was described as a privacy measure to not request pages not > cached automatically again. I also was testing this patch using Chrome and Firefox on OS X. My experience is that some pages would give the "cache miss" error in both browsers and some would just redirect to the login screen. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 13:27:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 11:27:46 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #132 from Jonathan Druart --- Quick feedback after some random tests: 1/ + console.dir( _framework_kohafields ); => to remove 2/ dependency UUID should be added 3/ Edit/create a record, modify it, click on "New record" (you just missed the Save button), everything is lost. Should ask for confirmation :) 4/ Search a. Click on 1 server launch a request, what if you want to select/deselect all? I think it would be better to have a "search" button here, to avoid useless queries. b. The number of results is different with the same search on cataloguing/z3950_search.pl (5 pages vs 25!) c. The link is "Import" even if the users search in the local catalogue. Maybe "edit" is more appropriate. 5/ The favicon is missing on cataloguing/editor.pl 6/ I still have issue with mandatory/repeatable field. >From the editor: 615 _ _ $a [Dropdown list] Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing mandatory subfield: $x >From the (default) framework page: 615 centre d'int?r?t No No 2 code du syst?me d'indexation subfield ignored 3 num?ro de la notice d'autorit? subfield ignored a cat?gorie sujet Tab:1, Not repeatable, Not mandatory, | Auth value:interet m subdivision de la cat?gorie sujet sous forme cod?e subfield ignored n cat?gorie sujet sous forme cod?e subfield ignored x subdivision de la cat?gorie sujet subfield ignored 7/ I don't understand why the default framework is used. 8/ Import record, then save. "Saving" is processing, nothing happen, browser freezes JS error: Error: Script terminated by timeout at: P at http://pro.koha-qa.vm/intranet-tmpl/lib/codemirror/codemirror-compressed.js:11:7546 [...] some others errors The record has 50 items. 9/ macro delete 200 # delete only the first 200, is it expected? Is there a doc somewhere with the commands available? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 13:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 11:29:19 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #133 from Jonathan Druart --- (In reply to Jonathan Druart from comment #132) > 6/ I still have issue with mandatory/repeatable field. > From the editor: > 615 _ _ $a [Dropdown list] > Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing > mandatory subfield: $x > > From the (default) framework page: > 615 centre d'int?r?t No No > 2 code du syst?me d'indexation subfield ignored > 3 num?ro de la notice d'autorit? subfield ignored > a cat?gorie sujet Tab:1, Not repeatable, Not mandatory, | Auth > value:interet > m subdivision de la cat?gorie sujet sous forme cod?e subfield ignored > n cat?gorie sujet sous forme cod?e subfield ignored > x subdivision de la cat?gorie sujet subfield ignored Ok forget this one, the subfield are ignored but marked as mandatory. Not what we should do in this case. The checks done on the "normal" edition mode don't look to work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 13:39:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 11:39:09 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #39 from Jonathan Druart --- The second patch does not apply anymore, but maybe it was not based on the good one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:08:38 +0000 Subject: [Koha-bugs] [Bug 14942] New: if there is no barcode, item level hold can become a biblio level hold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942 Bug ID: 14942 Summary: if there is no barcode, item level hold can become a biblio level hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: j.kylmala at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In reserve/request.pl if you have a hold entry without a barcode and someone has added a new hold after the barcodeless hold, the barcodeless hold will get the new hold's itemnumber and the new hold will have no itemnumber and so the new hold will be set at biblio level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:18:59 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #31 from Marc V?ron --- (In reply to Kyle M Hall from comment #30) > (In reply to Katrin Fischer from comment #29) > > I tested a few times - maybe it's a firefox thing? I was using Firefox in > > Ubuntu. It was described as a privacy measure to not request pages not > > cached automatically again. > > I also was testing this patch using Chrome and Firefox on OS X. My > experience is that some pages would give the "cache miss" error in both > browsers and some would just redirect to the login screen. I think that happens if the page where you crawl back to is a page that was the result of a (log-in)form. See first point on comment #19 To reproduce (Firefox 40.1 Win / Chrome 45.0.2454.101 m / ): - Close all browser windows to have a clear base line - Open OPAC main page - Log in as user AAAA with the login form at the right on the main page - You are now on opac-user.pl - Go to 'your fines' - Log out - You are redirected to the main page - Hit back button - You are now on opac-account.pl, it displays the login form - Hit back button again - In browser address field you have .../cgi-bin/koha/opac-user.pl and the browser displays a message "Document expired... Try again" - Hit "ry again" - Brower displays a pop-up, something like "Send data again..." with buttons 'Send again' / 'Cancel' - Hit 'Send again' Result: - Firefox: ...you are logged in with user AAA and can browse to other pages - Chrome: the message on .../cgi-bin/koha/opac-user.pl says something like "Confirm sendign data again" and the string ERR_CACHE_MISS - IE: the message on .../cgi-bin/koha/opac-user.pl says something like 'Webite expired... local copy no longer valid... Fazit: The patches are fine to fix things for Chrome and IE (at least the version I tested), but with FF 40.1 I was able to get back again to a page with a valid login. Since the browsers behave differently (maybe additionally depending on individual browser settings), I would like to repeat my proposition from comment #11 (in addition to the patches): After a logout, display a message similar to the following: "Logout privacy warning: Please close this browser window if other persons have access to this computer." -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:25:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:25:17 +0000 Subject: [Koha-bugs] [Bug 14942] if there is no barcode, item level hold can become a biblio level hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:25:19 +0000 Subject: [Koha-bugs] [Bug 14942] if there is no barcode, item level hold can become a biblio level hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942 --- Comment #1 from Joonas Kylm?l? --- Created attachment 43059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43059&action=edit Bug 14942: add itemnumber even though there is no barcode Adding item number even though there's no barcode makes sure that some holds are not missing item number (and some won't have other hold's item numbers) and therefore not being changed to biblio level holds. Test plan: 1. Have a item level hold entry without a barcode 2. Add now a new item level hold request through OPAC 3. Go to edit that new hold request's pickup library through staff side. 4. Notice that the new hold request is now at biblio level 5. Apply patch 6. Do the same steps as before but now notice that the new hold request is still at item level. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:34:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:34:30 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43040|0 |1 is obsolete| | --- Comment #40 from Josef Moravec --- Created attachment 43060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43060&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:34:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:34:44 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43052|0 |1 is obsolete| | --- Comment #41 from Josef Moravec --- Created attachment 43061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43061&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:37:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:37:56 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #42 from Josef Moravec --- I rebased the patches in my local branch, could you please check if it's OK? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:43:40 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #43 from Jonathan Druart --- >From the first patch: -my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef; +my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0; >From the second patch: -my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0; +my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef; Initially my patch (the second one) didn't modify this line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:56:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:56:10 +0000 Subject: [Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:57:33 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43060|0 |1 is obsolete| | --- Comment #44 from Josef Moravec --- Created attachment 43062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43062&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:57:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:57:43 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43061|0 |1 is obsolete| | --- Comment #45 from Josef Moravec --- Created attachment 43063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43063&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 14:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 12:59:20 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #46 from Josef Moravec --- Is that better? I am sorry for this inconvenience... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:12:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:12:52 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Comment on attachment 43030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43030 Bug 14923 - (follow-up) Test for invalid date input Obsoleted to implement solution without using is_formatted_date_string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:14:37 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:31:54 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #6 from Marc V?ron --- Created attachment 43064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43064&action=edit Bug 14923 - (follow up) Add test for invalid dates using eval To test: - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as 0000-00-00 or 32/01/1970 (copy/paste to date fields). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:32:36 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Depends on|14936 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:32:36 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14923 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 [Bug 14923] Remove C4::Dates from labels/label-item-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:35:48 +0000 Subject: [Koha-bugs] [Bug 14943] New: Calendar Gadget in Guided Reports wizard Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14943 Bug ID: 14943 Summary: Calendar Gadget in Guided Reports wizard Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org When creating a report using the Guided Reports wizard, the calendar gadget does not work correctly for ending dates. To reproduce: Guided Reports Wizard - Build New Select Catalogue group Step 4 - select criteria to limit on There are 3 calendar gadgets - Creation Date, Modification Date, Due Date. Select a start date using the gadget. Click on End date and gadget is all greyed out. You can select a date in the past but you cannot move forward. The remaining months in the year are not visible in the pull down menu. For example, select start date of 1/9/2015. End date gadget defaults to September but it is all greyed out and October, November and December are not available to select. Can obviously manually type the date in to the field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:35:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:35:52 +0000 Subject: [Koha-bugs] [Bug 14943] Calendar Gadget in Guided Reports wizard In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14943 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:57:24 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #9 from Marc V?ron --- Created attachment 43065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43065&action=edit Bug 14924 - (follow-up) Add date validation using eval This patch adds a date validation (see comment #3). To test: - Apply patch - Create a new user or edit an existing user - Try valid dates for date of birth - Try invalid dates as 0000-00-00 or 32/01/1970. You can can copy/paste such strings to the date field, ignore the warning message and submit. Verify that after submit you get a message "Date of birth is invalid" - Try the same with enrollement /expiry dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:57:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:57:47 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:58:16 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Depends on|14936 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 15:58:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 13:58:16 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14924 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 [Bug 14924] Remove C4::Dates from members/memberentry.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:14:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:14:34 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #13 from Kyle M Hall --- Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:24:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:24:37 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:24:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:24:39 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42604|0 |1 is obsolete| | Attachment #42605|0 |1 is obsolete| | Attachment #42606|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 43066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43066&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since " 6) Notice the expiration field now has the date of + 7 days Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:24:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:24:48 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #32 from Kyle M Hall --- Created attachment 43068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43068&action=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:24:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:24:46 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #31 from Kyle M Hall --- Created attachment 43067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43067&action=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:25:41 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Failed QA --- Comment #27 from Tom?s Cohen Arazi --- I like the implementation (overall) but I don't think we should introduce things like Koha::Calendar::add_dummy_holiday. Worse, it relies on the 'MPL' branch existing on the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:28:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:28:19 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #7 from Marc V?ron --- Created attachment 43069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43069&action=edit Bug 14922 - Remove C4::Dates from cataloguing/additem.pl This patch removes C4::Dates from cataloguing/additem.pl To test: - In MARC bibliographic framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Create a new item for a biblio and verify that YYYY, MM and DD are replaced with today's values. - Apply patch and repeat that previous step behaves as before. - Verify that the overall functionality of the form is the same as before applying the patch. Signed-off-by: Hector Castro Works as advertised. With the last script not accept more than YYYYMMDD If you enter something else, the script sends to the end of line. This patch follow up the pattern in constraint default value Patch amended following comment #6 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:29:11 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42987|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:30:50 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:40:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:40:09 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #14 from Katrin Fischer --- Thx Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:44:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:44:57 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #28 from Tom?s Cohen Arazi --- Created attachment 43070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43070&action=edit Bug 14522: (QA followup) tidy tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 16:45:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 14:45:51 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:02:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:02:25 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #29 from Kyle M Hall --- Created attachment 43071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43071&action=edit Bug 14522 [QA Followup] * Change POD to a brief comment * Fix UT so it doesn't fail on Sundays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:07:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:07:17 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- To outline a way of dealing with this: One way of looking at the problem is that RDA and the 260/264 forces us to deal with the fact that some attributes that we might want to stick in a column in biblio or biblioitems needs to draw from multiple MARC fields. XSLT and XPath give ways to do that sort of parsing... so we can add it to Koha something like this: - Create a new table to store XSLT stylesheets. This could be a combination of standard stylesheets (e.g., the MARC21 to MODS transforming) and local ones. - Create a new table to specify mappings to columns, something like this: koha_attribute_map kohafield # name of table and column to store the results xslt # reference to the XSLT to use, if need be xpath # what to use to extract the value The process would then be, when saving a bib record, that for each attribute specified in koha_attribute_map, the XSLT (if specified) would be applied to the MARCXML, then the XPath used to extract a result, which is then placed in the column specified by kohafield. This process could be used to supplemnt the one-subfield-to-one-column mapping that the MARC frameworks already specify, or with a bit more work, replace it. I should note that this general idea is inspired largely by similar mechanisms in Evergreen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:09:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:09:59 +0000 Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:10:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:10:22 +0000 Subject: [Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:10:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:10:43 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #32 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:11:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:11:09 +0000 Subject: [Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:11:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:11:28 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:11:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:11:49 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:12:14 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Mason and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:18:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:18:18 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #33 from Chris Cormack --- I agree with Marc that we need to also waen the users to close the browser, as I can confirm that this fix doesn't work for Firefox -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 17:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 15:18:26 +0000 Subject: [Koha-bugs] [Bug 14939] OAI Server classes must be modularized In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43045|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 43072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43072&action=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI namespace. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 18:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 16:51:44 +0000 Subject: [Koha-bugs] [Bug 14944] New: show error in frameworks/cataloging if upload path not set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14944 Bug ID: 14944 Summary: show error in frameworks/cataloging if upload path not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 6874 It would be nice if when you were allowing file uploads via marc you were warned on the frameworks editor that your upload path is not set. Right now it only warns you in about koha, and most people don't look there. It would also be helpful if it shows on the cataloging editor. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 [Bug 6874] Attach files to bibliographic records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 18:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 16:51:44 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14944 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14944 [Bug 14944] show error in frameworks/cataloging if upload path not set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:27:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:27:22 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #1 from Kyle M Hall --- *** Bug 9011 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:26:58 +0000 Subject: [Koha-bugs] [Bug 14945] New: Add the ability to store the last patron to return an item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Bug ID: 14945 Summary: Add the ability to store the last patron to return an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:27:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:27:22 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #138 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 14945 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:28:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:28:08 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #139 from Kyle M Hall --- I've moved this to a fresh bug for the new implementation that uses a separate table to track the last patron to return an item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:28:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:28:27 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:37:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:37:32 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:37:57 +0000 Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not listed in the system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:40:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:40:43 +0000 Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:41:17 +0000 Subject: [Koha-bugs] [Bug 14141] Changing the Library for a notice duplicates the notice instead of updating it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:46:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:46:04 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:52:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:52:33 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:52:35 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #2 from Kyle M Hall --- Created attachment 43073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43073&action=edit Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:56:02 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43073|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 43074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43074&action=edit Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 19:58:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 17:58:06 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43074|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 43075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43075&action=edit Bug 14945 - Add the ability to store the last patron to return an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:05:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:05:48 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #20 from Tom?s Cohen Arazi --- Please, small rebase needed. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:09:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:09:57 +0000 Subject: [Koha-bugs] [Bug 1232] Add Invoice/Credit/Fines Payed For Day on Issues (Print Page) (Print Slip) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1232 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:25:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:25:44 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #243 from Tom?s Cohen Arazi --- Created attachment 43076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43076&action=edit Bug 10855: (RM followup) DBIx update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:27:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:27:02 +0000 Subject: [Koha-bugs] [Bug 14812] Help could not be displayed in the correct language In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:27:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:27:26 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:28:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:28:01 +0000 Subject: [Koha-bugs] [Bug 14880] Keyboard shortcuts don't work after setting CircAutocompl to "Don't try" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Lari! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:28:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:28:27 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:28:52 +0000 Subject: [Koha-bugs] [Bug 14829] Wrong shortcuts in module "cataloging" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14829 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:29:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:29:53 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #244 from Tom?s Cohen Arazi --- Feature pushed to master. Good job Jonatahn! and thanks Maurice for the followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:34:03 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #140 from Christopher Brannon --- (In reply to Kyle M Hall from comment #139) > I've moved this to a fresh bug for the new implementation that uses a > separate table to track the last patron to return an item. Yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:46:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:46:42 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 20:46:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 18:46:44 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43075|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 43077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43077&action=edit [SIGNED OFF] Bug 14945 - Add the ability to store the last patron to return an item Currently if the AnonymousPatron system preference is in use, all patron data is anonymized. Some libraries would like to be able to see the last patron who returned out an item ( in case of damage ) but still keep all other patrons anonymized. * Add the table items_last_borrower ( id, itemnumber, borrowernumber ) * Add new system preference StoreLastBorrower * If StoreLastBorrower is enabled, upon checkin have Koha insert into this table the patron who last returned this item. Replace existing row based on itemnumber if exists. * If table has a row for a given item, link to the patron from the item details page. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable StoreLastBorrower 4) Issue an item to a patron and return said item 5) Issue the same item to a second patron, do not return it. 6) View moredetail.pl for the given bib, find the given item. There should be a new field in the history list 'Last returned by' with a link to the last patron to return the item. Optionally, you can also verify this works even if patron issuing history has been set to anonymize issues upon return. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 21:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 19:49:12 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:11:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:11:10 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Christopher Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mr.cataloger at gmail.com --- Comment #33 from Christopher Davis --- (In reply to Kyle M Hall from comment #1) > Created attachment 23582 [details] [review] > Bug 11405 [1] - Warn of items possibly scanned out of order > > This patch addes the ability to choose to be warned if it's possible > an item was scanned out of order ( i.e. mis-shelved ). > > Test Plan: > 1) Apply this patch > 2) Generate a list of barcodes ordered by callnumber > 3) "Misplace" one callnumber by moving it to another area of the list > 4) Browse to the inventory tool, choose your barcodes file > 5) Check the checkbox for "Check barcodes list for items shelved out of > order" > 6) Click "submit", note the item has been flagged as possibly out of order Hi Everyone, When I attempt to test this bug on one of the Koha sandboxes, the Koha instance fails to load and the following message was emailed to me: The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11405:

Something went wrong !

Applying: Bug 11405 [1] - Warn of items possibly scanned out of order Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging tools/inventory.pl CONFLICT (content): Merge conflict in tools/inventory.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Failed to merge in the changes. Patch failed at 0001 Bug 11405 [1] - Warn of items possibly scanned out of order When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11405 - Inventory tool enhancements 40572 - Bug 11405 [1] - Warn of items possibly scanned out of order 40573 - Bug 11405 [2] - Skip items with waiting holds 40574 - Bug 11405 [3] - Update item status fieldset string to be more descriptive 40575 - Bug 11405 [4] - Allow long labels to be less word-wrapped 40576 - Bug 11405 [5] - Fix html fieldset weirdness 40577 - Bug 11405 [6] - Allow items with selected locations to be not be flagged as Item should have been scanned if not scanned 40578 - Bug 11405 [7] - Add out of order status to CSV file Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11405-1---Warn-of-items-possibly-scanned-out-o-sHNWpq.patch FWIW, Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:35:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:35:54 +0000 Subject: [Koha-bugs] [Bug 14946] New: Remove C4::Dates from files acqui/*.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Bug ID: 14946 Summary: Remove C4::Dates from files acqui/*.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:50:10 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #1 from Marc V?ron --- Created attachment 43078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43078&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:51:15 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Blocks| |14870 Patch complexity|--- |Medium patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:51:15 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14946 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 [Bug 14946] Remove C4::Dates from files acqui/*.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:56:39 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40918|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 43079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43079&action=edit [SIGNED OFF] Bug 14518 - Allow deleting recordss with reservations (and no item) after confirmation Cleaning up notices with no item but reservation is impossible since the code does not consider the result from the confirmation popup. This situation happens to our client in their (annual) cleanup. I suppose those are notices for orders that never materialized, but people already made reservations on them. Test: 1) create (or find) a notice with no item. 2) make a reservation on it. 3) try to delete the notice. a) a popup will ask for confirmation b) after accepting, validate if the notice is deleted. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 2 22:56:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 20:56:36 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 00:04:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 02 Oct 2015 22:04:19 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 09:40:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 07:40:01 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43047|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43080&action=edit Bug 14940: Fix sorting in opac-topissues.pl There is hidden text in "Checkouts" cells that prevent DataTables to sort numerically. This patch adds the 'title-numeric' sort plugin and use it in opac-topissues.pl Column 'Checkouts' in Home > Most popular items sorts as expected Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 09:40:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 07:40:34 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 19:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 17:30:18 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 19:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 17:30:21 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43080|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 43081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43081&action=edit [PASSED QA] Bug 14940: Fix sorting in opac-topissues.pl There is hidden text in "Checkouts" cells that prevent DataTables to sort numerically. This patch adds the 'title-numeric' sort plugin and use it in opac-topissues.pl Column 'Checkouts' in Home > Most popular items sorts as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 19:53:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 17:53:15 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 --- Comment #13 from Katrin Fischer --- Please always make sure that the commit message reflects the changes made to the patch - in this case the updated test plan. I have amended the commit message in QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 19:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 17:53:46 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 19:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 17:53:49 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43079|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 43082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43082&action=edit [PASSED QA] Bug 14518 - Allow deleting records with holds (and no item) after confirmation Cleaning up records with no item but holds is impossible since the code does not consider the result from the confirmation popup. This situation happens to our client in their (annual) cleanup. I. Setup Create the following if needed: 1) A patron for placing holds and checkouts 2) A test bibliographic record 3) An item for the record. Set the barcode to "DELETEME" II. Corrupting the Database 1) Checkout the item "DELETEME" 2) Place a record level hold on the test record (next available item) 3) Checkin the item "DELETEME" 4) MySQL: DELETE FROM items WHERE barcode="DELETEME"; III. Deleting the record. 1) On the test record's details page: Edit -> Delete record 2) Click 'yes' in the prompt 3) Nothing happens. IV. Fixing the bug 1) Apply the patch 2) Repeat step III to delete the record 3) Record is deleted Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Note: It's not possible in Koha to place a hold on a record with items, so the effect described here is more likely to be the result of a migration issue or another bug. But doesn't hurt to provide a way out :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 19:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 17:59:38 +0000 Subject: [Koha-bugs] [Bug 11405] Inventory tool enhancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Patch doesn't apply --- Comment #34 from Katrin Fischer --- This patch doesn't apply, I have changed the patch status accordingly. Please also note: 'Inventory tool enhancements' is a suspicious title for a bug and I usually take it as a sign that a patch tries to do a multitude of things at once where it would be nicer to have separated patches for each thing! ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 20:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 18:03:48 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- > ::: opac/opac-memberentry.pl > @@ +244,4 @@ > > my %hidden_fields; > > > > my $BorrowerUnwantedField = > > + C4::Context->preference( "PatronSelf" . ucfirst($action) . "BorrowerUnwantedField" ); > > As a grep fan, I would prefer to see the entire name of the prefs. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 20:05:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 18:05:29 +0000 Subject: [Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- Moving discussion to the older bug. *** This bug has been marked as a duplicate of bug 10306 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 20:05:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 18:05:29 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #6 from Katrin Fischer --- *** Bug 12756 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 21:22:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 19:22:31 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #7 from H?ctor Eduardo Castro Avalos --- (In reply to Galen Charlton from comment #5) > - Create a new table to store XSLT stylesheets. This could be a combination > of standard stylesheets (e.g., the MARC21 to MODS transforming) and local > ones. > - Create a new table to specify mappings to columns, something like this: > > koha_attribute_map > kohafield # name of table and column to store the results > xslt # reference to the XSLT to use, if need be > xpath # what to use to extract the value > > The process would then be, when saving a bib record, that for each attribute > specified in koha_attribute_map, the XSLT (if specified) would be applied to > the MARCXML, then the XPath used to extract a result, which is then placed > in the column specified by kohafield. It seems to be a good solution, Galen, with this you can fix the problem with UNIMARC too. The new 264 field is unsearchable in Zebra, I filed a bug for this . But since there are a new development with Elastic Search I don't know the future of Zebra in Koha. Regards. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 21:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 19:29:43 +0000 Subject: [Koha-bugs] [Bug 14947] New: Overdue Items warning not updated after renewal Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14947 Bug ID: 14947 Summary: Overdue Items warning not updated after renewal Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When bringing up a patron with overdue items, if you renew the overdue items, the overdue warning in the upper right corner of the screen (on circulation.pl) does not go away. You have to refresh the screen. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 22:38:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 20:38:46 +0000 Subject: [Koha-bugs] [Bug 14528] Viewing lists fails silently when not having correct permisison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 22:38:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 20:38:48 +0000 Subject: [Koha-bugs] [Bug 14528] Viewing lists fails silently when not having correct permisison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41090|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 43083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43083&action=edit [PASSED QA] Bug 14528: Inconsistency in permissions check when listing shelves The svc script needed borrowers when the shelves.pl needed catalogue. There is no sense to have different permissions here. Test plan: 1/ Remove the borrowers permission to a user 2/ Use this user to log in 3/ Go on the shelf list 4/ Without this patch, you should get an endless "Processing..." which is fixed if you apply it. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 22:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 20:54:49 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 22:54:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 20:54:52 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39088|0 |1 is obsolete| | Attachment #40915|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 43084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43084&action=edit [PASSED QA] Bug 6379: Remove link from unapproved tags At the OPAC, if the tag is not approved, the tag's link did not return any result. This patch removes the link. Test plan: 1/ Set TagsModeration to 'Require' 2/ Create tags at the OPAC 3/ Approve a couple 4/ Confirm that unapproved tags does not have links. Signed-off-by: Bernardo Gonzalez Kriegel works as described, no errors For the (approved) link to work I need to install YAML::XS Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 22:55:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 20:55:50 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #15 from Katrin Fischer --- Created attachment 43085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43085&action=edit [PASSED QA] Bug 6379: Fix if the reviewer is not the same patron get_approval_rows does a left join on tags_approval.approved_by = borrowers.borrowernumber This means it cannot return the approval tags for a given patron. Note that this patch could be time-consuming if there is a lot of tags in the DB. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:27:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:27:49 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #11 from Katrin Fischer --- Created attachment 43086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43086&action=edit [PASSED QA] Bug 14888: use Koha::Cit[y|ies] in admin/itemtypes Test plan: Add/edit/remove cities from the administration module (admin/cities.pl). You should get message feedback after each action. Tested both patches together, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:27:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:27:52 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #12 from Katrin Fischer --- Created attachment 43087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43087&action=edit [PASSED QA] Bug 14888: Add Koha::Cit[y|ies] classes Tested both patches together, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:27:58 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #14 from Katrin Fischer --- Created attachment 43089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43089&action=edit [PASSED QA] Bug 14888: Add tests for Koha::Cit[y|ies] Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:27:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:27:55 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #13 from Katrin Fischer --- Created attachment 43088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43088&action=edit [PASSED QA] Bug 14888: Update copyright and wording Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:28:45 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:28:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:28:47 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43048|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:28:51 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42854|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:28:49 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43049|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 3 23:28:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 21:28:53 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 00:56:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 22:56:40 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- Hm, this last patch doesn't work for me. I have reindexed and the MARC view shows: 942 _2ddc _cBK _n1 ddc BK 1 I think the test doesn't work quite right, but I haven't figured out why: test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']" Can you see, what might go wrong here? I am also not a fan of showing the bibnumber, I think it's more likely to confuse than being helpful. I'd like it better if we showed only the text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 01:26:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 03 Oct 2015 23:26:07 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hm, we need 14658 first here. Please unblock when the patch for 14658 is in the QA queue again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 03:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 01:54:46 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #10 from Winona Salesky --- Would you mind sending me your marcxml test record to test? Thanks, -Winona wsalesky at gmail.com (In reply to Katrin Fischer from comment #9) > Hm, this last patch doesn't work for me. I have reindexed and the MARC view > shows: > > 942 _2ddc > _cBK > _n1 > > > ddc > BK > 1 > > > I think the test doesn't work quite right, but I haven't figured out why: > test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']" > > Can you see, what might go wrong here? > > I am also not a fan of showing the bibnumber, I think it's more likely to > confuse than being helpful. I'd like it better if we showed only the text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 09:29:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 07:29:44 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41266|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 43090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43090&action=edit Bug 14627 Check for undef passed to GetAuthorisedValueByCode Dont prepare or execute unnecessary sql if passed an undef value routine is used in various places that dont check if the value returned from a nullable field is defined or not (e.g. streettype in the borrower record which many sites do not use) Lets save those cpu cycles for something useful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 09:29:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 07:29:51 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 --- Comment #5 from M. Tompsett --- Created attachment 43091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43091&action=edit Bug 14627: Improve SQL query A field=NULL condition does not run properly. If category is undefined, then don't include it in the query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 09:33:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 07:33:07 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett --- Just wanted to put my work here, before I blew it away. :) I figure bug 10363 as mentioned by Tomas will probably make this obsoleted and not required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 11:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 09:36:24 +0000 Subject: [Koha-bugs] [Bug 14948] New: Display amounts right aligned in tables on patron pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Bug ID: 14948 Summary: Display amounts right aligned in tables on patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Amounts for charge, cine, price etc. appear left alinged (instead of right aligned) in tables on patron pages. To verify: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 11:46:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 09:46:56 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #1 from Marc V?ron --- Created attachment 43092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43092&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 11:48:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 09:48:19 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 13:37:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 11:37:08 +0000 Subject: [Koha-bugs] [Bug 14881] batch item modification : item properties not displaying when accented characters are used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14881 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Current master branch doesn't show the problem - so probably only a patch for older versions would be needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 15:52:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 13:52:31 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #14 from Martin Persson --- Created attachment 43093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43093&action=edit Bug 14247: Add system preference for news display Added default value for system preference. Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 16:54:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 14:54:51 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from Martin Persson --- Updated as suggested, new patch has default value set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 17:14:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 15:14:11 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Mike Gabriel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mike.gabriel at das-netzwerkte | |am.de --- Comment #4 from Mike Gabriel --- Hi, (In reply to Jonathan Druart from comment #3) > Is it still valid or can be closed? cc Martin I have recently been contracting for making KOHA LDAP authentication against a Debian Edu (aka Skolelinux) main server work. The customer also finances upstream communication and asked me to do my best to get whatever solution I come up with into upstream KOHA. After auditing the Auth_with_LDAP.pm code, I come to these conclusions: 1. The customer runs a Koha 3.08.01.002 [1]. In the meantime, Koha 3.20.something is out. However, the Auth_with_LDAP.pm file in latest HEAD (master branch) is still at version 3.07.00.049 [2]. Also the Auth_with_LDAP.pm code looks far more advanced than the Auth_with_LDAP.pm code on latest HEAD. Is is possible that some branch merging did not happen for the Auth_with_LDAP.pm file? It feels like this requires some portion of investigation. Thanks. [1]http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Auth_with_ldap.pm;h=fab6e44fafd6bb4cde5c1cd3e66655be0989338e;hb=e7c7f7af023172aea3fb02e4c1fa356c99f69fec [2] http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Auth_with_ldap.pm;h=58484a2ba700b0d469cbaf14f1b56083e01ebbf1;hb=6f81f8a0e2309447acc6e5bb74f444102d8adf56 2. KOHA LDAP Auth seems to be working fine for AD authentication using userPrincipal attribute description and a valid password. The default AD setup always allows user binding to their own account's DN. So that should work out well. 3. Authentication against openLDAP with clear text passwords stored in LDAP should also work fine as long as an administrative DN object is used for binding (e.g. cn=admin of objectClass simpleSecurityObject or such). However, storing clear text passwords in an LDAP tree is really really old school and should neither happen nor be expected anymore. On most setups, using $db->compare() will be unusable as passwords in most recent openLDAP setups are stored in a hashed way (and have been salted before hashing). 4. In KOHA, it even seems to be an option to use anonymous bind and $db->compare() for LDAP authentication. This should not be allowed at all, as it requires (a) an anonymous bind LDAP configuration that reveals the userPassword field (to everyone!!!) and requires the value in the userPassword attribute description to be stored in clear text. Nothing people really want... The approach for my customer (and also my proposal for getting the above sorted out in KOHA, if devs here agree) is this: o drop anonymous bind + userPassword LDAP CompareRequest completely o keep admin-bind + userPassword LDAP CompareRequest o keep AD authentication as is o try an auth for a specific user against LDAP using the user's DN (as proposed by a patch similar to the patch provided by Robert Fox) o make the openLDAP user-login-via-test-authbind method configurable via koha-conf.xml Any feedback on this is highly welcome. I am also open to discuss a different approach (as long as it works against openLDAP deployed in Debian Edu / Skolelinux setups). Greets, Mike PS: I am also a Debian Developer, being interested in getting KOHA into Debian in the long run... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 17:27:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 15:27:39 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Martin Persson --- There are tests included in the original bug, 14246. They cover the changes in NewsChannel.pm, ar they enough to pass QA? Changing to 'Needs Signoff', please reset if not appropiate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 18:23:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 16:23:45 +0000 Subject: [Koha-bugs] [Bug 14949] New: Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Bug ID: 14949 Summary: Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Bug to remove C4::Dates from - admin/smart-rules.pl - admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 18:39:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 16:39:21 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #1 from Marc V?ron --- Created attachment 43094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43094&action=edit Bug 14949 - Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl Bug to remove C4::Dates from - admin/smart-rules.pl - admin/categorie.pl To test: - Apply patch - Go to Home > Administration > Circulation and fine rules (smart-rules.pl) - Edit or add a rule - Verify that 'Hard due date' displays and saves fine - Go to Home > Administration > Patron categories - Edit or add a category - Verify that 'Until date' displays and saves fine Note: The date picker does not warn about wrong date formats as e.g. while editing patrons, but that is not in the scope of this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 18:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 16:40:39 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14949 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 18:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 16:40:39 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |veron at veron.ch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:09:53 +0000 Subject: [Koha-bugs] [Bug 14950] New: Remove C4::Dates from tools/batchMod.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Bug ID: 14950 Summary: Remove C4::Dates from tools/batchMod.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from tools/batchMod.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:21:07 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #1 from Marc V?ron --- Created attachment 43095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43095&action=edit Bug 14950 - Remove C4::Dates from tools/batchMod.pl This patch removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Clcik 'Save' - Verify that the items are updated as appropriate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:22:49 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks| |14870 Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |veron at veron.ch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:22:49 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14950 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 [Bug 14950] Remove C4::Dates from tools/batchMod.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:39:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:39:15 +0000 Subject: [Koha-bugs] [Bug 14951] New: Remove C4::Dates from plugins/*.pl files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Bug ID: 14951 Summary: Remove C4::Dates from plugins/*.pl files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from: - plugins/plugins-home.pl - plugins/run.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:45:10 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 --- Comment #1 from Marc V?ron --- Created attachment 43096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43096&action=edit Bug 14951 - Remove C4::Dates from plugins/*.pl files This patch removes C4::Dates from: - plugins/plugins-home.pl - plugins/run.pl C4::Dates seem not to be used here, removed. For testing refer to: http://manual.koha-community.org/3.20/en/pluginsystem.html http://manual.koha-community.org/3.20/en/pluginsystem.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:45:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:45:38 +0000 Subject: [Koha-bugs] [Bug 14952] New: web installer database errors on 3.18.11 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952 Bug ID: 14952 Summary: web installer database errors on 3.18.11 Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: bob-ewart at bobsown.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Installing Koha 3.18.11 built from the tar ball on openSuse 13.2. Select all optional data in step 3. optional data added sample_patrons.sql ERROR 1048 (23000) at line 1: Column 'address' cannot be null mandatory data added authorities_normal_marc21.sql ERROR 1366 (22007) at line 270: Incorrect integer value: '' for column 'linkid' at row 1 The build used all the defaults except for 'icu' and the passwords. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:46:12 +0000 Subject: [Koha-bugs] [Bug 14952] web installer database errors on 3.18.11 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952 Bob Ewart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob-ewart at bobsown.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:46:36 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:46:36 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14951 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 [Bug 14951] Remove C4::Dates from plugins/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:49:51 +0000 Subject: [Koha-bugs] [Bug 7804] Add Koha Plugin System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7804 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14951 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 20:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 18:49:51 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7804 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:05:35 +0000 Subject: [Koha-bugs] [Bug 14953] New: Adlibris (Swedish supplier) cover image support Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14953 Bug ID: 14953 Summary: Adlibris (Swedish supplier) cover image support Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org The Swedish book retailer Adlibris (http://www.adlibris.se) has a web service that allows users to retrieve cover images over HTTP and HTTPS via ISBN. No credentials or cookies are required. Halland County library plans to add support (via a system preference) to retrieve this covers. Enabling this will risk data leakage to the store about what titles people search for and which titles they look at. Using HTTPS protects the data from interception by third parties but the second party can see the results in the web logs of the server. Identification of users is possible if the computer used has cookies set for the adlibris.se domain (as well as more sophisticated methods). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:12:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:12:16 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #32 from Marc V?ron --- Note for development: See also: tools/exceptionHolidays.pl tools/holidays.pl tools/newHolidays.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:19:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:19:51 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #82 from Katrin Fischer --- Sorry, but I still see the duplicate bug - last patch doesn't seem to work? Try changing an existing values description, you will receive: "This authorized value already exists." The change is not saved. Some small note for someone returning to this: I like 'added' better than 'inserted' in the error messages, as it matches the other terminology in Koha better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:22:49 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #83 from Katrin Fischer --- Hm, I think we are also missing a kohastructure.sql change here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:25:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:25:22 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #20 from Katrin Fischer --- Sorry, patch no longer applies, can you please fix? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14100: Generic solution for language overlay - Item types Using index info to reconstruct a base tree... M C4/Items.pm M cataloguing/additem.pl M installer/data/mysql/kohastructure.sql M tools/batchMod.pl Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: installer/data/mysql/atomicupdate/Bug_14100-add_table_localization.sql Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 14100: Generic solution for language overlay - Item types The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14100-Generic-solution-for-language-overlay----vNN_6L.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:27:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:27:28 +0000 Subject: [Koha-bugs] [Bug 14954] New: Remove C4::Dates from holiday related files in folder tools Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Bug ID: 14954 Summary: Remove C4::Dates from holiday related files in folder tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:29:37 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:29:40 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43023|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 43097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43097&action=edit [PASSED QA] Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro Works as expected. Magnifying glass icon corrected Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:35:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:35:44 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #1 from Marc V?ron --- Created attachment 43098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43098&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of hilidays and exceptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:36:34 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14954 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 [Bug 14954] Remove C4::Dates from holiday related files in folder tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:36:34 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |veron at veron.ch Blocks| |14870 Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 22:45:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 20:45:18 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #29 from Katrin Fischer --- Working on this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 4 23:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 21:21:51 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Started with testing the circulation rules GUI and found a problem: Default checkout, hold and return policy (second part of the page)- the onsite-checkouts number doesn't show in the field after saving, but it looks like it IS actually saved to the table. Can you check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 00:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 22:47:40 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 01:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 04 Oct 2015 23:57:01 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 --- Comment #14 from Robin Sheat --- (In reply to Mason James from comment #13) > (In reply to Liz Rea from comment #12) > > Note to self to include "This makes Koha 3.18 compatible with Debian > > (Jessie)" in the release notes. > > curious, would this be a problem in 3.16.x too? Yep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 03:00:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 01:00:39 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14304 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 03:00:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 01:00:39 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 04:05:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 02:05:40 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #15 from Robin Sheat --- (In reply to Jonathan Druart from comment #11) > 3/ Remove the index_name_2 unique constraint on the search_marc_map table. > I don't understand how this could be useful, it was defined like (index_name, > marc_type, marc_field), so it means a mapping cannot be defined twice with > different values for facet, suggestible and sort. > This limitation does not seem to make sense. > Robin, please correct me if I am wrong :) You are not wrong. I just wrote a big thing about what I was intending, realised I was wrong, so deleted it :) I think I was confusing index_name and field name, or something. I'll merge this in as part of the ES branch like you suggest, as it'll solve some issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 04:15:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 02:15:26 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #16 from Robin Sheat --- Though, it'd be best to just put DB changes in the .sql file for now and let that load them in from there, rather than creating a whole set of transactions to manage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 05:06:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 03:06:51 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #121 from Robin Sheat --- (In reply to Jonathan Druart from comment #119) > Does the authorities index is supposed to work? > > I get > Use of uninitialized value $id in concatenation (.) or string at > misc/search_tools/rebuild_elastic_search.pl line 173. That shouldn't happen, I think there was something underlying that changed in the rebase. Lemme sort that out... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 05:22:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 03:22:32 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #17 from Robin Sheat --- Created attachment 43099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43099&action=edit Bug 14899: schema changes to make the database better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 05:37:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 03:37:57 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #122 from Robin Sheat --- Fixed the authorities thing, there was an API change where what was 'idnumber' had to become 'id', which is now done. (In reply to Jonathan Druart from comment #120) > I can now only search for "*", other patterns return nothing, and > /koha-es_biblios/_search?q=*&pretty shows entries like: That's weird. Are you sure you reloaded the tables? I just have, and end up with: "_source":{"title__suggestion":{"input":[[["Harmonization of international accounting standards"]]]},"record":[["LDR",null,null,"_","01476pam a2200205 a 4500"],["110"," "," ","a","International Capital Markets Group"],["245"," "," ","a","Harmonization of international accounting standards","c","prepared by the International Federation of Accountants with the assistance of Federation Internationale des Bourses de Valeurs and the International Bar Association Section on Business Law"],["260"," "," ","a","London, United Kingdom","b","International Capital Markets Group","c","?"],["300"," "," ","a","67 p.","c","23 cm."],["650"," "," ","a","INTERNATIONAL ACCOUNTING STANDARDS"],["650"," "," ","a","HARMONI100 33019 100 33019 0 0 388k 0 --:--:-- --:--:-- --:--:-- 447k TION"],["650"," "," ","a","ACCOUNTING STANDARDS"],["650"," "," ","a","ACCOUNTING POLICIES"],["653"," "," ","a","INTERNATIONAL ACCOUNTING STANDARDS"],["505"," "," ","a","Introduction ; Accounting standards around the world - why are they different? ; Accounting standard setting in five countries ; What are the major differences? ; The costs of disharmony ; The barriers to harmonisation ; Toward global harmonisation ; International accounting standards ; Appendices"],["520"," "," ","a","The report examines the reasons for differences in accounting standards around the world, and, in the context of the pressures for global harmonisation of standards, examines the factors that have to be overcome if global harmonisation is to be achieved. It also examines what form global harmonisation might take, and considers the structure and organisation of accounting standard setting in this context."],["942"," "," ","c","Book"],["024"," "," ","a","16"],["900"," "," ","a","AJ9304"],["952"," "," ","0","0","1","0","2","ddc","4","0","6","100_600000000000000_HAR","7","0","9","16","a","WLGTN","b","WLGTN","d","2011-12-19","o","100.6 HAR","p","CA002438","r","2011-12-19","w","2011-12-19","y","BOOK"],["999"," "," ","c","16","d","16"]],"_id":"16","author__facet":[["International Capital Markets Group"]],"title":[["Harmonization of international accounting standards"]],"acqdate":[["2011-12-19"]],"Local-number":[["16"]],"subject":[["INTERNATIONAL ACCOUNTING STANDARDS"],["HARMONISATION"],["ACCOUNTING STANDARDS"],["ACCOUNTING POLICIES"],["INTERNATIONAL ACCOUNTING STANDARDS"]],"publisher":[["International Capital Markets Group"]],"place":[["London, United Kingdom"]],"subject__suggestion":{"input":[[["INTERNATIONAL ACCOUNTING STANDARDS"]],[["HARMONISATION"]],[["ACCOUNTING STANDARDS"]],[["ACCOUNTING POLICIES"]],[["INTERNATIONAL ACCOUNTING STANDARDS"]]]},"homebranch":[["WLGTN"]],"itype__facet":[["Book"],["BOOK"]],"local-classification__suggestion":{"input":[[["100.6 HAR"]]]},"author__suggestion":{"input":[[["International Capital Markets Group"]]]},"itemnumber":[["16"]],"copydate":[["?"]],"copydate__facet":[["?"]],"place__facet":[["London, United Kingdom"]],"author":[["International Capital Markets Group"],["prepared by the International Federation of Accountants with the assistance of Federation Internationale des Bourses de Valeurs and the International Bar Association Section on Business Law"]],"onloan":"0","subject__facet":[["INTERNATIONAL ACCOUNTING STANDARDS"],["HARMONISATION"],["ACCOUNTING STANDARDS"],["ACCOUNTING POLICIES"],["INTERNATIONAL ACCOUNTING STANDARDS"]],"publisher__facet":[["International Capital Markets Group"]],"local-classification":[["100.6 HAR"]],"author__sort":[["International Capital Markets Group"]],"holdingbranch":[["WLGTN"]],"itype":[["Book"],["BOOK"]],"homebranch__facet":[["WLGTN"]]} Which is what I would have expected. (sorry about the wall of text there) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 07:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 05:47:16 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 07:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 05:47:16 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14627 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 08:29:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 06:29:02 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? --- What is the comment "FIXME: iso dates don't have commas!" about? split ',', $today_iso doesn't work? Or is the comment about that Koha uses a comma instead of -? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 08:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 06:46:28 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43096|0 |1 is obsolete| | --- Comment #2 from Joonas Kylm?l? --- Created attachment 43100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43100&action=edit Bug 14951 - Remove C4::Dates from plugins/*.pl files I didn't see any dependencies for the Dates module. Also tested to load the plugins pages This patch removes C4::Dates from: - plugins/plugins-home.pl - plugins/run.pl C4::Dates seem not to be used here, removed. For testing refer to: http://manual.koha-community.org/3.20/en/pluginsystem.html http://manual.koha-community.org/3.20/en/pluginsystem.html Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 08:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 06:48:30 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:07:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:07:28 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:07:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:07:31 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43094|0 |1 is obsolete| | --- Comment #2 from Joonas Kylm?l? --- Created attachment 43101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43101&action=edit Bug 14949 - Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl Test plan works, code looks good. Bug to remove C4::Dates from - admin/smart-rules.pl - admin/categorie.pl To test: - Apply patch - Go to Home > Administration > Circulation and fine rules (smart-rules.pl) - Edit or add a rule - Verify that 'Hard due date' displays and saves fine - Go to Home > Administration > Patron categories - Edit or add a category - Verify that 'Until date' displays and saves fine Note: The date picker does not warn about wrong date formats as e.g. while editing patrons, but that is not in the scope of this bug Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:19:53 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:20:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:20:00 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #3 from Marc V?ron --- (In reply to Joonas Kylm?l? from comment #2) > What is the comment "FIXME: iso dates don't have commas!" about? split ',', > $today_iso doesn't work? Or is the comment about that Koha uses a comma > instead of -? I do not really know what the author of tis comment intended. But the comment now is obsolete because the code changed to get the values to replace YYYY, MM and DD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:29:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:29:22 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #34 from Jonathan Druart --- (In reply to Chris Cormack from comment #33) > I agree with Marc that we need to also waen the users to close the browser, > as I can confirm that this fix doesn't work for Firefox What version are you using? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:32:54 +0000 Subject: [Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #31 from Jonathan Druart --- (In reply to Jonathan Druart from comment #25) > Comment on attachment 42919 [details] [review] > [PASSED QA] Bug 14522 - Use Koha::Cache for accessing single_holidays() > > Review of attachment 42919 [details] [review]: > ----------------------------------------------------------------- > > It seems we were here at the same time :) > > I have also tried to reproduce the time reduction, without success. > A script I have used is coming... It would have been good to have a script to highlight the time reduction of this caching. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:35:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:35:44 +0000 Subject: [Koha-bugs] [Bug 14944] show error in frameworks/cataloging if upload path not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14944 --- Comment #1 from Marcel de Rooy --- (In reply to Nicole C. Engard from comment #0) > It would be nice if when you were allowing file uploads via marc you were > warned on the frameworks editor that your upload path is not set. Right now > it only warns you in about koha, and most people don't look there. It would > also be helpful if it shows on the cataloging editor. Are you sure? If I upload a file without this entry in koha-conf, I get this warning: Your koha-conf.xml does not contain a valid upload_path. Nice in yellow :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:39:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:39:04 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42635|0 |1 is obsolete| | --- Comment #4 from Joonas Kylm?l? --- Created attachment 43102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43102&action=edit Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:39:50 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:39:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:39:52 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38400|0 |1 is obsolete| | Attachment #38401|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 43103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43103&action=edit Bug 10020: Remove DB table and fields related to ethnicity This patch remove the ethnicity table and the ethnicity and ethnotes fields from the 3 tables: borrowers, deletedborrowers and borrower_modifications IF no data exist. Test plan: 0/ Apply this patch and update the Koha::Schema (misc/devel/update_dbix_class_files.pl). 1/ Make sure the ethnicity has at least 1 entry 2/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 3/ truncate the ethnicity table and fill ethnicity (or ethnotes) for at least 1 row of the borrowers table. 4/ Launch the updatedb entry and confirm you get a warning message and the DB structure is not updated. 5/ Make sure the ethnicity table is empty as well as the ethniciy and the ethnotes fields of borrowers, deletedborrowers and borrower_modifications 6/ Launch the updatedb entry and confirm you don't get the warning message and the DB structure is updated (ie. table and fields dropped). Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:39:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:39:57 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #22 from Jonathan Druart --- Created attachment 43104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43104&action=edit Bug 10020: Remove code related to ethnicity This is a(nother) vestige of Koha (2.2?). This patch removes unused code related to the 'ethnicity'. In detail: There is no way to fill the ethnicity table. There is no way to fill the borrowers.ethnicity and borrowers.ethnotes. BUT if borrowers.ethnicity exists, the value is displayed on members/moremember.pl (and only here). Test plan: Apply this patch and confirm there is no regression on adding/updating/deleting patrons. Note that you don't see the ethnicity value on the moremember.pl page even if a patron has it. Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:40:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:40:24 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:40:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:40:27 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42636|0 |1 is obsolete| | --- Comment #5 from Joonas Kylm?l? --- Created attachment 43105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43105&action=edit Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 09:45:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 07:45:53 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #4 from Joonas Kylm?l? --- (In reply to Marc V?ron from comment #3) > (In reply to Joonas Kylm?l? from comment #2) > > What is the comment "FIXME: iso dates don't have commas!" about? split ',', > > $today_iso doesn't work? Or is the comment about that Koha uses a comma > > instead of -? > > I do not really know what the author of tis comment intended. But the > comment now is obsolete because the code changed to get the values to > replace YYYY, MM and DD Yes, it's obsolete now. I was reading the git diff in the wrong way and thought that you put the comment there ! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:04:09 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:04:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:04:12 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43095|0 |1 is obsolete| | --- Comment #5 from Joonas Kylm?l? --- Created attachment 43106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43106&action=edit Bug 14950 - Remove C4::Dates from tools/batchMod.pl Test plan worked. Code looks good. This patch removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Clcik 'Save' - Verify that the items are updated as appropriate Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:17:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:17:28 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #5 from Martin Renvoize --- Hi Mike, Great to have some new blood on board; I totally agree that the Auth_with_ldap code needs a major rethink and would support such a piece of work. It's great to have your insight regarding best/worst practice's in the LDAP space and i'd be OK with deprecating some feature and clarifying the code.. though we'de need a good strong DEPRECATION warning because not all koha users are as technically able as yourself and may not be following current bets practice.. That's why it's always hard to get rid of some of these ldap related features. It might also be worth you taking a little look at bug 8993 as it was a piece of work aimed at re-working the LDAP code. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:18:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:18:59 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #6 from Martin Renvoize --- On the debian front, Robin is your man there.. it's always good to get some extra feedback on our packaging approach. Are you on the Koha IRC channel yet.. that's probably your best place to start getting involved? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:21:22 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43062|0 |1 is obsolete| | Attachment #43063|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 43107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43107&action=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:21:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:21:26 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #48 from Jonathan Druart --- Created attachment 43108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43108&action=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:21:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:21:29 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #49 from Jonathan Druart --- Created attachment 43109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43109&action=edit Bug 14739: Adapt wording in breadcrumbs if a new batch is created Don't display "Manage batch number 0" but "Create new batch" Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:24:38 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:24:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:24:42 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42525|0 |1 is obsolete| | Attachment #42526|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 43110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43110&action=edit Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:24:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:24:47 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #22 from Jonathan Druart --- Created attachment 43111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43111&action=edit Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: > admin/smart-rules.pl > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:25:14 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #23 from Jonathan Druart --- conflict on kohastructure.sql fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:31:17 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:31:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:31:32 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC|corinne.flacher-david at bibli | |bre.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:31:56 +0000 Subject: [Koha-bugs] [Bug 5456] Create a link to opac-ics.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:35:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:35:20 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? --- In the file orderreceive.pl there is code depending to Dates.pm: line 207: date => format_date($order->{entrydate}), Otherwise the patch looks good! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:43:01 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:43:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:43:05 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41345|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart --- Created attachment 43112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43112&action=edit Bug 10363: FIX regression - prevent duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:43:09 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #85 from Jonathan Druart --- Created attachment 43113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43113&action=edit Bug 13636: Change wording added vs inserted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:43:14 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #86 from Jonathan Druart --- Created attachment 43114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43114&action=edit Bug 10363: (follow-up) DB update - change in kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:45:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:45:55 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #87 from Jonathan Druart --- (In reply to Katrin Fischer from comment #82) > Sorry, but I still see the duplicate bug - last patch doesn't seem to work? > > Try changing an existing values description, you will receive: > "This authorized value already exists." > The change is not saved. It was not exactly the same issue, good catch. Should be fixed now. > Some small note for someone returning to this: I like 'added' better than > 'inserted' in the error messages, as it matches the other terminology in > Koha better. Fixed. (In reply to Katrin Fischer from comment #83) > Hm, I think we are also missing a kohastructure.sql change here? Added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:50:01 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #7 from Mike Gabriel --- (In reply to Martin Renvoize from comment #5) > It might also be worth you taking a little look at bug 8993 as it was a > piece of work aimed at re-working the LDAP code. The patches in #8993 look indeed promising. I will need some time to review and get back to you via #8993 or here (depends where it fits best). Mike -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 10:51:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 08:51:01 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 --- Comment #8 from Mike Gabriel --- (In reply to Martin Renvoize from comment #6) > On the debian front, Robin is your man there.. it's always good to get some > extra feedback on our packaging approach. Are you on the Koha IRC channel > yet.. that's probably your best place to start getting involved? Showing up on IRC now (my nick is around 24/7, nick is: sunweaver)... Mike -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:03:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:03:17 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #7 from Julian Maurice --- Created attachment 43115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43115&action=edit Bug 14788: Add unit tests for GetTopIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:03:34 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:12:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:12:14 +0000 Subject: [Koha-bugs] [Bug 14953] Adlibris (Swedish supplier) cover image support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14953 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:12:36 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com Assignee|magnus at libriotech.no |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:29:55 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #3 from Fridolin SOMERS --- Created attachment 43116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43116&action=edit Bug 14666 - add fixed_fines for overdues - Add a overduerules.fixed_fineX for the 3 levels - Add a column "Fixed fines" in the tools/overduerules.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:30:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:30:58 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:31:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:31:09 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 11:37:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 09:37:07 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #123 from Jonathan Druart --- Robin, just retried now with and everything works fine. Not sure where did it come from, but it looks to be fixed! Just got: Upgrade to XXX done (Bug 12478 - set up elasticsearch tables) DBD::mysql::db do failed: Can't DROP 'index_name_2'; check that column/key exists at installer/data/mysql/updatedatabase.pl line 10967.DBD::mysql::db do failed: Duplicate column name 'label' at installer/data/mysql/updatedatabase.pl line 10970. Upgrade to XXX done (Bug 12478/14899 - DB Changes to the elasticsearch tables) when updating the DB. You have updated the structure in the elasticsearch_mapping.sql file, so no need to remove the unique key and add the label field in the last updatedatabase entry. Not a big deal anyway :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:09:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:09:06 +0000 Subject: [Koha-bugs] [Bug 3719] Create syspref to allow sites to rename OPAC Cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3719 Madhukara M changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |librarian at iipr.in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:17:08 +0000 Subject: [Koha-bugs] [Bug 14955] New: "Show more" link contains double encoded characters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Bug ID: 14955 Summary: "Show more" link contains double encoded characters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:17:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:17:16 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13789 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789 [Bug 13789] facets with accented utf-8 characters generate double encoded links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:17:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:17:16 +0000 Subject: [Koha-bugs] [Bug 13789] facets with accented utf-8 characters generate double encoded links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14955 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 [Bug 14955] "Show more" link contains double encoded characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:23:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:23:04 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:23:06 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #1 from Jonathan Druart --- Created attachment 43117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43117&action=edit Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 12:24:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 10:24:51 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #124 from Jonathan Druart --- I have found an encoding bug on the "Show more" link, it will be fixed by bug 14955. Already exists on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 13:44:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 11:44:43 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #34 from Kyle M Hall --- Created attachment 43118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43118&action=edit Bug 5144 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 13:53:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 11:53:35 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42792|0 |1 is obsolete| | Attachment #42848|0 |1 is obsolete| | Attachment #43118|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 43119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43119&action=edit Bug 5144 [QA Followup] - Add unit test -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 13:53:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 11:53:44 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #36 from Kyle M Hall --- Created attachment 43120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43120&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 13:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 11:54:43 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #37 from Kyle M Hall --- The updates to the unit tests in the first patch do not actually test the new functionality. Those changes were necessary to keep the tests from failing not that the patron hold limit of one per record is enforced by AddReserve. I've attached a new follow up that adds a unit test to specifically test this. I have reworked the patches to split the unit tests into a separate patch for easier testing. (In reply to Jonathan Druart from comment #33) > Kyle, I don't understand how the changes you introduced in the tests for > AddReserve highlight your changes in the subroutine. > > It would be better to first submit a patch to fix the issue then to clean > some stuffs (indentation, replacement with Koha::Objects, etc.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 14:12:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 12:12:21 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43119|0 |1 is obsolete| | Attachment #43120|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 43121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43121&action=edit Bug 5144 - Add unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 14:12:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 12:12:31 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #39 from Kyle M Hall --- Created attachment 43122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43122&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 14:13:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 12:13:17 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5144 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 14:13:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 12:13:17 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14695 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 [Bug 14695] Add ability to place multiple item holds on a given record per patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 14:34:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 12:34:17 +0000 Subject: [Koha-bugs] [Bug 14956] New: C4::Dates from files opac/*.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Bug ID: 14956 Summary: C4::Dates from files opac/*.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:01:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:01:15 +0000 Subject: [Koha-bugs] [Bug 14956] C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #1 from Marc V?ron --- Created attachment 43123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43123&action=edit Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:01:49 +0000 Subject: [Koha-bugs] [Bug 14956] C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Small patch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:01:49 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14956 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 [Bug 14956] C4::Dates from files opac/*.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:04:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:04:39 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 --- Comment #7 from Matthias Meusburger --- Created attachment 43124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43124&action=edit Bug 14560 [Follow-up]: QA: Add debug warnings and get biblionumber with GetMarcFromKohaField -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:06:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:06:01 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43121|0 |1 is obsolete| | Attachment #43122|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 43125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43125&action=edit Bug 5144 - Add unit test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:06:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:06:08 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #41 from Kyle M Hall --- Created attachment 43126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43126&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:10:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:10:47 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:29:57 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #245 from Tom?s Cohen Arazi --- (In reply to Tom?s Cohen Arazi from comment #244) > Feature pushed to master. > > Good job Jonatahn! and thanks Maurice for the followup. Jonathan and Julian :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:38:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:38:40 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #125 from Jonathan Druart --- Robin, Another set of patches is coming. 1/ Reintroduce the SearchEngine pref 2/ Fix to correct the number of facets displayed (again) 3/ Remove an unnecessary "&limit=" (minor) 4/ Replace the Koha::ItemType[s] classes you have introduced with a Koha::Object[s] way 5/ Display description instead of code for locations in facets. About 4: I know you are now agreeing completely with Koha::Object[s] and how it has been implemented. But I think we need to have an homogeneous code, and all new classes in the Koha namespace should follow the same directions. I would please you to have a look at bug 14828 (and the see also ones), which introduces the Koha::ItemType[s] classes as well and rewrites the admin/itemtypes.pl script, to see how easy it is to use it. To avoid future conflicts and don't play to a race against each other we should agree on this kind of decisions now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:01 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #126 from Jonathan Druart --- Created attachment 43127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43127&action=edit Bug 12478: Reintroduce the SearchEngine system preference It is in the sysprefs.sql file, but could have been removed by the previous entry (3.17.00.027). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:06 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #127 from Jonathan Druart --- Created attachment 43128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43128&action=edit Bug 12478: (follow-up) Display the correct number of facets This patch fixes a side-effect of the previous "Display the correct number of facets (5 instead of 6)" patch. If you ask for more facets ('show more' link) and that the number of facets is > 5 but < 10, 1 facet will be missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:12 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #128 from Jonathan Druart --- Created attachment 43129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43129&action=edit Bug 12478: Remove empty limit parameter If no limit are passed, the url will contain '&limit=' anyway. It is not necessary and can be avoided easily Test plan: 1/ Search for a term in your catalogue 2/ Hover over a link in the facet area 3/ The link is cgi-bin/koha/opac-search.pl?idx=kw&q=your_term&limit=&limit=[...] With this patch, the empty limit parameter does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:17 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #129 from Jonathan Druart --- Created attachment 43130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43130&action=edit Bug 12478: Remove Koha::ItemType[s] Class::Accessor classes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:22 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #130 from Jonathan Druart --- Created attachment 43131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43131&action=edit Bug 12478: Add Koha::ItemType[s] classes These 2 classes come from bug 14828. Tests in t/db_dependent/Koha/ItemTypes.t should be updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:28 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #131 from Jonathan Druart --- Created attachment 43132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43132&action=edit Bug 12478: Use the new Koha::ItemTypes to retrieve itypes descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:33 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #132 from Jonathan Druart --- Created attachment 43133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43133&action=edit Bug 12478: Add Koha::AuthorisedValue[s] class These 2 classes come from bug 10363. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:42:39 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #133 from Jonathan Druart --- Created attachment 43134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43134&action=edit Bug 12478: facets - Display description instead of code for locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:54:43 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8147 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 15:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 13:54:43 +0000 Subject: [Koha-bugs] [Bug 8147] suggestions management forgets branch info In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8147 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10449 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:07:53 +0000 Subject: [Koha-bugs] [Bug 14957] New: Write protecting MARC fields based on source of import Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Bug ID: 14957 Summary: Write protecting MARC fields based on source of import Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: martin at bugs.koha-community.org.xinxidi.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Add options for write protecting individual MARC fields based on source of import (Z39.50, stage for import, etc) to avoid overwriting local changes. This feature is a superset of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:08:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:08:56 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin at bugs.koha-community. | |org.xinxidi.net Status|NEW |ASSIGNED CC| |martin at bugs.koha-community. | |org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:14:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:14:40 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41490|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 43135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43135&action=edit [SIGNED-OFF]Bug 3642 - New informations in overdues CSV export - prepare This patch prepare columns list to ease other patches Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:15:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:15:01 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 43136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43136&action=edit [SIGNED-OFF]Bug 3642 - New informations in overdues CSV export - add cardnumber This patch adds patron cardnumber to overdues CSV export Test plan : - Go to overdues page : /cgi-bin/koha/circ/overdue.pl - Find some overdues - Click on "Download file of displayed overdues" - Open generated CSV => You see cardnumber column with data Signed-off-by: Hector Castro Works as advertised. Cardnumber appeared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:15:13 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41491|0 |1 is obsolete| | Attachment #41492|0 |1 is obsolete| | --- Comment #11 from H?ctor Eduardo Castro Avalos --- Created attachment 43137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43137&action=edit [SIGNED-OFF]Bug 3642 - New informations in overdues CSV export - add itemtype This patch adds record itemtype to overdues CSV export, from item or biblioitems depending on syspref "item-level_itypes" Test plan : - Go to overdues page : /cgi-bin/koha/circ/overdue.pl - Find some overdues - Click on "Download file of displayed overdues" - Open generated CSV => You see itemtype column with data Signed-off-by: Hector Castro Works as advertised. itemtype appered on CSV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:15:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:15:28 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41493|0 |1 is obsolete| | --- Comment #12 from H?ctor Eduardo Castro Avalos --- Created attachment 43138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43138&action=edit [SIGNED-OFF]Bug 3642 - New informations in overdues CSV export - move streetnumber and streettype This patch moves columns streetnumber and streettype next to address. This is more logical to read the CSV. For example : streetnumber,streettype,address,address2,zipcode,city 181,rue,Breteuil,,13001,Marseille Test plan : - Go to overdues page : /cgi-bin/koha/circ/overdue.pl - Find some overdues of patrons with streetnumber and streettype - Click on "Download file of displayed overdues" - Open generated CSV => You see streetnumber and streettype before address Signed-off-by: Hector Castro Works as advertised. streetnumber and streettype appered on CSV -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:16:02 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:20:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:20:24 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42960|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:24:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:24:06 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #7 from Marc V?ron --- I re-do the patch from scratch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:24:22 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #8 from Marc V?ron --- Created attachment 43139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43139&action=edit Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:24:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:24:48 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:25:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:25:42 +0000 Subject: [Koha-bugs] [Bug 14958] New: wrong suggestions are displayed with IndependentBranches Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14958 Bug ID: 14958 Summary: wrong suggestions are displayed with IndependentBranches Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In suggestions page : /cgi-bin/koha/suggestion/suggestion.pl. - Define a user with access to intranet but not a superlibrarian. - Do not use the first branch of the list. - Set syspref IndependentBranches to "don't prevent" : - Go to Acquisitions module - Click on Suggestions => You see only the suggestions of the connected user branch, you do not see the suggestions of other branches nor the suggestions with no branch. - Set syspref IndependentBranches to "don't prevent" : - Go to Acquisitions module - Click on Suggestions => You see only the suggestions of the first branch and suggestions with no branch :( - Filter on any branch => Same result -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:25:57 +0000 Subject: [Koha-bugs] [Bug 14958] wrong suggestions are displayed with IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14958 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10449 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:25:57 +0000 Subject: [Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14958 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:26:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:26:16 +0000 Subject: [Koha-bugs] [Bug 14958] wrong suggestions are displayed with IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14958 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:37:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:37:23 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #11 from Winona Salesky --- I am unable to reproduce this issue. The record you sent me runs fine on my system. Can you give me any additional details about how you are testing this patch? Also, if you are comfortable looking in the xslt could you try changing the test (line 94 on MARC21slim2intranetDetail.xsl) to: test="marc:datafield[@tag=942][normalize-space(marc:subfield[@code='n']) = '1'] An additional tester may also be helpful. Thanks, -Winona (In reply to Katrin Fischer from comment #9) > Hm, this last patch doesn't work for me. I have reindexed and the MARC view > shows: > > 942 _2ddc > _cBK > _n1 > > > ddc > BK > 1 > > > I think the test doesn't work quite right, but I haven't figured out why: > test="marc:datafield[@tag=942][marc:subfield[@code='n'] = '1']" > > Can you see, what might go wrong here? > > I am also not a fan of showing the bibnumber, I think it's more likely to > confuse than being helpful. I'd like it better if we showed only the text. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:39:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:39:25 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #134 from Jonathan Druart --- Created attachment 43140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43140&action=edit Bug 12478: Display facet terms ordered by number of occurrences By default ES returns the facet terms ordered by most used, which makes sense. This patch removes resort done in the scripts (catalogue/search.pl and opac/opac-search.pl) and moves it to the module. For Zebra it's now done in C4::Search::getRecords, and there is no change to expect (still alphabetically). On the Elastic search side, we could imagine to let the library define the order of the facets. The facet terms are now sorted by most used. To test easily this change, turn on the displayFacetCount pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:40:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:40:43 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #135 from Jonathan Druart --- > (In reply to Jonathan Druart from comment #90) > > > Something else, there is a sort issue in the facets: > > > > > > [Some entries] > > > Zeitoun, Ariel, > > > ? Cadhain, M?irt?n. > > > ?lez, Ts.. > > > > > > ? should be after O, not after Z. > > > > Line 573 of opac/opac-search.pl does a sort with cmp, which isn't very > > unicode aware. I'm putting that in the not-my-problem bin as it's in > > upstream :) > > Yes, and, IMO, there is a design issue here. > We should not reuse the pl and tt files. > How do you plan to add features that Zebra cannot provide? :) > Not sure it will be maintainable to add conditions (if SE == 'ES') in the TT. > For instance, for the facets, we would like to display them as ES retrieve > them (order by most used), and add the number of occurrences. In the last patch I suggest to display the facet terms in the same order as ES build them (i.e. most used first). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:46:22 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43129|0 |1 is obsolete| | --- Comment #136 from Jonathan Druart --- Created attachment 43141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43141&action=edit Bug 12478: Remove empty limit parameter If no limit are passed, the url will contain '&limit=' anyway. It is not necessary and can be avoided easily Test plan: 1/ Search for a term in your catalogue 2/ Hover over a link in the facet area 3/ The link is cgi-bin/koha/opac-search.pl?idx=kw&q=your_term&limit=&limit=[...] With this patch, the empty limit parameter does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:48:41 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43141|0 |1 is obsolete| | --- Comment #137 from Jonathan Druart --- Created attachment 43142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43142&action=edit Bug 12478: Remove empty limit parameter If no limit are passed, the url will contain '&limit=' anyway. It is not necessary and can be avoided easily Test plan: 1/ Search for a term in your catalogue 2/ Hover over a link in the facet area 3/ The link is cgi-bin/koha/opac-search.pl?idx=kw&q=your_term&limit=&limit=[...] With this patch, the empty limit parameter does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:54:26 +0000 Subject: [Koha-bugs] [Bug 14959] New: Support for Library Communications Framework (LCF) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14959 Bug ID: 14959 Summary: Support for Library Communications Framework (LCF) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.field at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com LCF is a modern framework, based on web protocols, that builds on the foundations that SIP2 laid in the early years. The framework continues support for all existing communications, but supplements the basics with a range of calls that not only allows self-service systems to communicate more efficiently with the LMS, but opens up bi-directional communication to a range of other devices ? such as handheld inventory devices. Many UK RFID and LMS system vendors are moving to support this protocol. For details: http://www.bic.org.uk/114/LCF/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:57:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:57:03 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #2 from Marc V?ron --- Created attachment 43143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43143&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 16:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 14:59:31 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43143|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Comment on attachment 43143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43143 Bug 14946 - Remove C4::Dates from files acqui/*.pl Mistaked with bug number, sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:00:15 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43078|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 43144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43144&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor http://bugs.koha-community.org/show_bug.cgi?id=14926 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:01:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:01:08 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43139|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 43145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43145&action=edit [SIGNED-OFF]Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro Works as advertised. Tested with bad dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:01:33 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:25:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:25:58 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 43146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43146&action=edit Bug 14888: (QA followup) remove unused lib/var Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:38:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:38:54 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathhhhhhhhan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:39:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:39:21 +0000 Subject: [Koha-bugs] [Bug 14528] Viewing lists fails silently when not having correct permisison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks onathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:39:45 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:40:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:40:29 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Thknas Ojanahtn! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:41:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:41:07 +0000 Subject: [Koha-bugs] [Bug 14518] Deleting records with a hold (and no item) does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14518 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Remi and congrats for your commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:41:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:41:33 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 17:42:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 15:42:40 +0000 Subject: [Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 --- Comment #8 from Winona Salesky --- Great! Thank you. -Winona (In reply to Tom?s Cohen Arazi from comment #7) > Patch pushed to master. > > Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:00:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:00:59 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42625|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43147&action=edit [SIGNED-OFF]Bug 14734 - Enhance 264 display in OPAC and Staff XSLT. Makes 264 repeatable, prefer 264 over 260. If 264/ind1=3 is present in the record the xslt uses ind1 to determine latest 264, if no ind1=3 then all 264 fields are displayed. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with multiple MARC tags 264 4) Perform a search that would show the record in the search results. 5) Review results for correct 264 display. 6) Click title to review record details. Signed-off-by: Hector Castro Works as advertised. 260 not showed when 264 exists, tested with multiple records. If ind1=3 is present shows the current/latest data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:01:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:01:28 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:02:40 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:04:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:04:20 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:16:40 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #138 from Jonathan Druart --- Created attachment 43148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43148&action=edit Bug 12478: Take the FacetMaxCount pref into account The system preference FacetMaxCount should work as expected with ES. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:20:41 +0000 Subject: [Koha-bugs] [Bug 14960] New: Remove C4::Dates from files in misc/cronjobs (part 1) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Bug ID: 14960 Summary: Remove C4::Dates from files in misc/cronjobs (part 1) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from following files - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl (Note: The remainig files misc/cronjobs/overdue_notices.pl and misc/cronjobs/staticfines.pl will be covered with a separate bug) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:25:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:25:04 +0000 Subject: [Koha-bugs] [Bug 6379] Remove link from unapproved and rejected tags in the OPAC's "My tags" table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6379 --- Comment #17 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #16) > Patches pushed to master. > > Thknas Ojanahtn! You need some rest :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:26:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:26:34 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs (part 1) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #1 from Marc V?ron --- Created attachment 43149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43149&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs (part 1) This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:30:23 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14960 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 [Bug 14960] Remove C4::Dates from files in misc/cronjobs (part 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:30:23 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs (part 1) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 18:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 16:32:54 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Dates from files |Remove C4::Dates from files |opac/*.pl |opac/*.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 19:29:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 17:29:00 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #24 from Katrin Fischer --- Argh... late evening QA'ing... error: The following untracked working tree files would be overwritten by merge: installer/data/mysql/atomicupdate/Bug_14100-add_table_localization.sql Sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 19:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 17:31:10 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13696 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 [Bug 13696] Add support for Font Awesome icons in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 19:31:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 17:31:10 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14610 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 [Bug 14610] Add ability to place document delivery / article requests in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 19:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 17:34:58 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- +100! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 20:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 18:08:53 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 21:14:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 19:14:04 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #12 from Marc V?ron --- Some testing from my part: If I put an additional blank after the 1 in 942n, the record is suppressed in OPAC (with syspref 'OpacSuppression set to 'Hide'), but the message does not show up on the staff detail view. If I then add the normalize-space function to the XSL as described in comment #11 the message appears. If I have use the authorized value YesNo, it does not work. I tweaked the xsl to display the 942nvalue, and it is Yes instead of 1 As Katrin mentioned on IRC this is a problem, because the auhorized values are translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 21:39:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 19:39:39 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #25 from Jonathan Druart --- (In reply to Katrin Fischer from comment #24) > Argh... late evening QA'ing... > error: The following untracked working tree files would be overwritten by > merge: > installer/data/mysql/atomicupdate/Bug_14100-add_table_localization.sql > Sorry! You need remove the file before applying the patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 21:40:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 19:40:51 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #13 from Marc V?ron --- Workaround and/or possible solution: I created an authorized value category ONE_ZERO and gave it 0 / 1 for the values and for all descriptions. Then I linked it with 942 n. Display of suppression message is fine. And it displays 1 or 0 correctly while editing 942 n for records that formerly had YES_NO values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 21:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 19:41:11 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #26 from Katrin Fischer --- Yep, I missed that my workspace wasn't clean. I will fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 21:47:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 19:47:04 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #14 from Katrin Fischer --- Hm, I think 0/1 as the description is not very friendly for the cataloger and might lead to some confusion. Another suggestion: We could use the mechanism that makes system preferences available in the XSLT. We could create a variable to store the description that matches the authorised value category linked to 942$n for the value 1. And then base the check on that. Does that make sense? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 22:00:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 20:00:16 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #15 from Winona Salesky --- This would work for me. I'm afraid I am still using learning the ins and outs of Koha, and did not realize there were other possible values to 942$n. -Winona (In reply to Katrin Fischer from comment #14) > Hm, I think 0/1 as the description is not very friendly for the cataloger > and might lead to some confusion. Another suggestion: We could use the > mechanism that makes system preferences available in the XSLT. We could > create a variable to store the description that matches the authorised value > category linked to 942$n for the value 1. And then base the check on that. > Does that make sense? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 5 23:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 21:31:41 +0000 Subject: [Koha-bugs] [Bug 14961] New: Remove C4::Dates from files reports/*_stats.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Bug ID: 14961 Summary: Remove C4::Dates from files reports/*_stats.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:00:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:00:42 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 --- Comment #1 from Marc V?ron --- Created attachment 43150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43150&action=edit Bug 14961 - Remove C4::Dates from files reports/*_stats.pl Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl To test: - Go to Home > Reports - Verify that following reports work as before: - Other > Average loan time - Statistic wizards - Acquisitions - Patrons - Circulation - Serials - Holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:01:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:01:21 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Patch complexity|--- |Medium patch Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:01:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:01:21 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14961 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 [Bug 14961] Remove C4::Dates from files reports/*_stats.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:13:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:13:12 +0000 Subject: [Koha-bugs] [Bug 14962] New: Temp Shelving Location Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Bug ID: 14962 Summary: Temp Shelving Location Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Would like to see a new location field added to the items table, like TEMPLOC. This field would be ignored if blank, but if populated it's data would be used instead of the data in the LOCATION field. The idea is, if you are placing items in a temporary location, like a display, you can actually list the location, but not loose the permanent location. Then, when it comes time to move the item back to its regular location, you can simply clear the TEMPLOC field. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:20:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:20:10 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Doesn't this already exist with the "location" field? If you're losing the permanent location, it could be that there's a bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:23:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:23:50 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:26:00 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #2 from Christopher Brannon --- (In reply to David Cook from comment #1) > Doesn't this already exist with the "location" field? Sort of, but it is tied in with the PROC and CART features. How would you retain the permanent location, the temp location of the display, and the PROC/CART locations? I guess if you didn't want the item going back to display, that would work, but what if you have a special holiday or themed collection residing somewhere for a while? After the first time out it goes back to its permanent location. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:46:24 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #3 from David Cook --- (In reply to Christopher Brannon from comment #2) > (In reply to David Cook from comment #1) > > Doesn't this already exist with the "location" field? > > Sort of, but it is tied in with the PROC and CART features. How would you > retain the permanent location, the temp location of the display, and the > PROC/CART locations? > > I guess if you didn't want the item going back to display, that would work, > but what if you have a special holiday or themed collection residing > somewhere for a while? After the first time out it goes back to its > permanent location. > > Christopher Ahh, I see what you're saying. I've always found items in Koha to be a bit funny/confusing. There's a permanent_location, location, ccode (collection code). Personally, I would think the collection would be synonymous with shelving location, and that location would be more like "status" (in processing, on cart, on shelf, etc). If anything, I would think it would make more sense to have ccode and location/status. Maybe permanent_ccode if you wanted to designate the "true" collection for an item, and then have an ability to add it to temporary collections without losing track of the original collection. -- You might also be able to use the rotating collections feature: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Once upon a time, I worked at a multilingual library where we had books in 29 different languages each with their own set of collections. Every so often, a small rotating collection would be created from some of these books, it would be sent around the province (in Canada) to other libraries before returning home to our library where the books would go back to their original collection. In this case, you wouldn't have to transfer the collection to another library. You could use it as a temporary collection. That's theoretical though. I haven't used this feature in Koha... worth experimenting or talking to Kyle Hall about it, I imagine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:51:12 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I think a lot of libraries use the collection with something unrelated to the location in the library - for example it could be a special donation they want to highlight, that was shelved with the other books. I think the rotating collection an item belongs to is currently not visible in the OPAC, but might be something that could be added. A problem might be searching for it - that would be easier to solve if it was a field in the item record. Hm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 00:58:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 05 Oct 2015 22:58:15 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > I think a lot of libraries use the collection with something unrelated to > the location in the library - for example it could be a special donation > they want to highlight, that was shelved with the other books. > > I think the rotating collection an item belongs to is currently not visible > in the OPAC, but might be something that could be added. A problem might be > searching for it - that would be easier to solve if it was a field in the > item record. Hm. Fair enough. I suppose my concern is that there are already 43 columns in the items table, and we're running out of conventional subfield codes in the 952. I suppose we could start using capital letters or any of the other interesting things available in the following range: [\dA-Za-z!"#$%&'()*+,-./:;<=>?{}_^`~\[\]\\]{1} (http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 02:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 00:40:39 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #23 from David Cook --- (In reply to Jonathan Druart from comment #22) > Yep, if it works, let's do it for all date indexes :) I suppose I should clarify this a bit... In ccl.properties, we create the following mapping: "st-date-normalized 4=5" This associates a CCL qualifier name with a Bib-1 structure attribute. Internally in Zebra, the Bib-1 attribute "4=5" is mapped to the Date "d" register. http://www.indexdata.com/zebra/doc/querymodel-zebra.html#querymodel-pqf-apt-mapping If we search "biblio-zebra-indexdefs.xsl" for MARC21, we find that "Date-of-acquisition" is actually the only index defined in the Date "d" register. It's a little better for UNIMARC, as it also has "onloan" added to the "d" register. What that means is that "st-date-normalized" can really only be used for "Date-of-acquisition" with MARC21/NORMARC, and "Date-of-acquisition" and "onloan" for UNIMARC. -- Of course, there are lots of other MARC fields where we store ISO formatted dates, but we put them in the "w" register, so that they can be found using "kw,wrdl" queries it seems. We probably under-use the various registers available. The only index using the "y" register is "pubdate" in MARC21. UNIMARC has a few more although I'm not sure whether they're used correctly as I'm not familiar with the format. The "y" register is only suitable for "YYYY" strings. The only way to access the "y" register is by using "st-year" as well. "st-numeric" accesses the "n" register which seems to be relied upon a lot in Koha. -- In any case, I'll add a patch to add "r=o" to "st-date-normalized", even though it will only really affect the advanced search for acquisition date (and any CCL queries that are formed by hand). In the future, we could look at adding other indexes to the "d" register if necessary... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 02:45:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 00:45:05 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 02:45:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 00:45:09 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #24 from David Cook --- Created attachment 43151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43151&action=edit Bug 14861 - [ALTERNATE] Accession date comparison does not work in advanced search _Test plan_ Prerequisites: Make sure that you have an item with a valid dateaccessioned, and that the bib is indexed in zebra. For the purposes of explanation, I'm going to use the date '2011-09-07' 1) Go to advanced search in the staff client and choose 'Acquisition date (yyyy-mm-dd)' 2) Enter 2011-09-07 (or the date of your choice). 3) Click the search button - you should get your item in the search results. 4) Return to the advanced search screen and select Acquisition date again. 5) Enter a start and end date in the text field separated by ' - '. For example: 2011-09-01 - 2011-09-30 6) Click the search button -- this will return no results. 7) Apply the patch and copy etc/zebradb/ccl.properties to whatever directory is specified by the koha-conf.xml referenced by $KOHA_CONF. 8) Try the search again -- this will return the expected results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 03:57:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 01:57:57 +0000 Subject: [Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #4 from Liz Rea --- I am pretty sure that the todaysIssuesDefaultSortOrder preference is actually reversed in meaning. Latest to earliest (according to the preference) Today's checkouts 10/06/2015 14:29 10/06/2015 14:30 10/06/2015 14:36 10/06/2015 14:39 Earliest to latest 10/06/2015 14:39 10/06/2015 14:36 10/06/2015 14:30 10/06/2015 14:29 This doesn't seem right to me? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 05:01:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 03:01:14 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #19 from David Cook --- Probably won't have time to test this one actually... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 06:18:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 04:18:03 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #139 from Robin Sheat --- (In reply to Jonathan Druart from comment #123) > You have updated the structure in the elasticsearch_mapping.sql file, so no > need to remove the unique key and add the label field in the last > updatedatabase entry. > Not a big deal anyway :) Oh, yes. That should have been removed. (In reply to Jonathan Druart from comment #125) > I know you are now agreeing completely with Koha::Object[s] and how it has > been implemented. > But I think we need to have an homogeneous code, and all new classes in the > Koha namespace should follow the same directions. > I would please you to have a look at bug 14828 (and the see also ones), > which introduces the Koha::ItemType[s] classes as well and rewrites the > admin/itemtypes.pl script, to see how easy it is to use it. > To avoid future conflicts and don't play to a race against each other we > should agree on this kind of decisions now. Sure, that's fine. Consistency is generally better than reinventing everything. (In reply to Jonathan Druart from comment #135) > In the last patch I suggest to display the facet terms in the same order as > ES build them (i.e. most used first). While I've added this, in general I'm avoiding changing of behaviour too much. We can always remove it later if it's decided we don't want it (and personally, I think it'll be better.) All these patches are added. Thanks Jonathan! FYI, I'm looking into the notforloan stuff at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 07:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 05:41:11 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #140 from Katrin Fischer --- sorting facets by number of use sounds better to me than alphabetic - maybe a good change :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 07:48:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 05:48:53 +0000 Subject: [Koha-bugs] [Bug 14962] Temp Shelving Location In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #6 from Katrin Fischer --- Maybe this could work like the course reserves? The former location is stored separate from the item data until the item is moved back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 09:39:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 07:39:14 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 09:50:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 07:50:48 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #141 from Jonathan Druart --- Robin, Thanks for your responsiveness! Yesterday I have read a bit of doc about facets and on the Terms Facet page of the ES doc ( https://www.elastic.co/guide/en/elasticsearch/reference/current/search-facets-terms-facet.html), there is a big warning on top " Warning Facets are deprecated and will be removed in a future release. You are encouraged to migrate to aggregations instead.". Did you have time to look into the terms aggregations? Or maybe is it what you are already using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 09:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 07:52:48 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #142 from Jonathan Druart --- On a unimarc installation, there are no mapping at all for authorities. If an unimarc user follows this bug report... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:04:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:04:55 +0000 Subject: [Koha-bugs] [Bug 8127] Most Circulated Items not working right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8127 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:18:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:18:32 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:31:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:31:14 +0000 Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.fiol at biblibre.com |julian.maurice at biblibre.com CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:31:45 +0000 Subject: [Koha-bugs] [Bug 14707] Change UsageStatsCountry and UsageStatsLibraryType from free text to a dropdown list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14707 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.fiol at biblibre.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:31:49 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.fiol at biblibre.com |julian.maurice at biblibre.com CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:31:54 +0000 Subject: [Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.fiol at biblibre.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 11:59:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 09:59:39 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #143 from Jonathan Druart --- Robin, Maybe I have not drunk enough tea this morning but... I am trying to improve the mappings area to have a consistent interface to manage them. The idea is to 1) move the elastic_mapping.sql to a elastic_mapping.json file (easier to modify and read), 2) provide methods to serialize/unserialize mappings and then 3) introduce a backup/import/reset mappings feature and finally 4) make easier the mapping progression to get a good basis to use ES. I have managed to create a json file from the sql file, the structure is something like: { biblio => { title => { label => 'Title', type => 'string', mappings => [ { suggestible => 1, facet => 1, marc21 => '245a', unimarc => '200a', normarc => '245a', }, ] }, } And I have some questions :) - Do you agree with the idea? - Don't you think the index_name should be a column of the search_fields table? - Some of the fields don't have a type, should we assign "string" as the default value? - wordings: 'sortable' and 'facetable' sounds more appropriate than 'sort' and 'facet' - (/me is clearing his throat) I think that all the mappings of a field should be removed if the field is removed. In other word, there is a 1-n relationship beetwen search_field and search_marc_map, which means that the join table (search_marc_to_field) is not needed and we could simplify the structure removing it. I am going to wait for an answer before starting anything :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:01:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:01:29 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #144 from Jonathan Druart --- Ha, something else: the biblionumber should be a field of the biblios index. It will fix a couple of issues (click on a result at the intranet and non-xslt views). And certainly some others, for instance I get a lot of warnings in the logs: opac-search.pl: GetCOinSBiblio called with undefined record at /home/koha/src/opac/opac-search.pl line 636. opac-search.pl: GetMarcBiblio called with undefined biblionumber at /home/koha/src/opac/opac-search.pl line 635. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:24:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:24:24 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- Regression found: There is no way to reset a hard due date. To reproduce: Don't apply this patch, go on smart-rules.pl and edit a line. Do not define a Hard due date, save. The value is "None defined". Apply this patch, edit the line, do not change anything and save. The value is now "before 06/10/2015" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:34:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:34:48 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:34:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:34:50 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43100|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43152&action=edit Bug 14951 - Remove C4::Dates from plugins/*.pl files This patch removes C4::Dates from: - plugins/plugins-home.pl - plugins/run.pl C4::Dates seem not to be used here, removed. For testing refer to: http://manual.koha-community.org/3.20/en/pluginsystem.html http://manual.koha-community.org/3.20/en/pluginsystem.html Signed-off-by: Joonas Kylm?l? Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:35:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:35:56 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42970|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 43153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43153&action=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:40:22 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:40:25 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43145|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 43154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43154&action=edit Bug 14923 - Remove C4::Dates from labels/label-item-search.pl This patch removes C4::Dates from labels/label-item-search.pl To test: - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. Signed-off-by: Hector Castro Works as advertised. Tested with bad dates Signed-off-by: Jonathan Druart Todo later: Some checks should be added on client side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:41:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:41:20 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:54:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:54:41 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:54:43 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43106|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 43155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43155&action=edit Bug 14950 - Assign default value for YYYY, MM and DD [was Remove C4::Dates from tools/batchMod.pl] This patch replace the YYYY, MM and DD if defined in the default values. This patch also removes C4::Dates from tools/batchMod.pl To test: - In MARC bibliographic Default framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Got to Home > Tools > Batch item modification - Enter one ore more barcodes you want to modify - Check checkbox 'Populate fields with defautl values from defautl framework - Click 'Continue' - Verify on the follwing screen that the field in Edit form is populated as appropriate (in our example 'x - Non public note') - Click 'Save' - Verify that the items are updated as appropriate Signed-off-by: Joonas Kylm?l? Signed-off-by: Jonathan Druart Amended commit message: This is a bug fix and can be backported. The YYYY, MM and DD were not replaced correctly before this patch. I got Year:2015-10-06 Month: Day: now I correctly get Year: 2015 Month: 10 Day: 06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:54:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:54:48 +0000 Subject: [Koha-bugs] [Bug 14950] Remove C4::Dates from tools/batchMod.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #7 from Jonathan Druart --- Created attachment 43156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43156&action=edit Bug 14950: Remove unused variable $today_iso This variable is not used anymore in the template (and has never been used...). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 12:55:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 10:55:54 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Remove C4::Dates from |A date is not correctly |tools/batchMod.pl |filled in default values | |from batch mod [was Remove | |C4::Dates from | |tools/batchMod.pl] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:03:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:03:20 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #8 from Jonathan Druart --- IMO the TODO about the category handling should be addressed in this patch set. I let the needs QA status if another QAer think it can go as it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:10:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:10:14 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Barton, you should fix the author's patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:14:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:14:22 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:14:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:14:24 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41633|0 |1 is obsolete| | Attachment #43018|0 |1 is obsolete| | Attachment #43019|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 43157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43157&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:14:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:14:27 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #11 from Jonathan Druart --- Created attachment 43158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43158&action=edit Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:14:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:14:31 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #12 from Jonathan Druart --- Created attachment 43159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43159&action=edit Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:18:51 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7710 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:18:51 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:26:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:26:05 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42976|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 43160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43160&action=edit Bug 11565 - decreaseLoanHighHolds needs Override This patch allows the high holds loan length decrease to be overridden either by a checkbox that remembers its setting during a series of checkouts, or by a one time use override checkbox that will show in the warning popup if a checkout is affected by high holds. Test Plan: 1) Set up a checkout that will be affected by decreaseLoanHighHolds 2) Attempt to check out an item 3) Check the override checkbox 4) Note the checkout date is not reduced 5) Return the item 6) Start a new checkout for the patron 7) Check the "Don't decrease lean length based on holds" checkbox 8) Check out the item 9) Note you are not warned about the high holds decrease and that the checkout length is not reduced -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:30:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:30:38 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #42 from Jonathan Druart --- Kyle, now that bug 5371 has been pushed, I cannot longer reproduce the issue. Should we push these changes anyway? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:36:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:36:33 +0000 Subject: [Koha-bugs] [Bug 14005] Fix wording of previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 --- Comment #5 from Kyle M Hall --- (In reply to Liz Rea from comment #4) > I am pretty sure that the todaysIssuesDefaultSortOrder preference is > actually reversed in meaning. > > Latest to earliest (according to the preference) > Today's checkouts > 10/06/2015 14:29 > 10/06/2015 14:30 > 10/06/2015 14:36 > 10/06/2015 14:39 > > Earliest to latest > 10/06/2015 14:39 > 10/06/2015 14:36 > 10/06/2015 14:30 > 10/06/2015 14:29 > > This doesn't seem right to me? It's the ambiguity of the terms. It's like looking at that image that's either a face or a lamp! I suggested with do with "Most recently issued to least recently issued" and "Least recently issued to most recently issued". What do you think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:36:47 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |cbrannon at cdalibrary.org, | |crohde at roseville.ca.us, | |jdemuth at roseville.ca.us, | |jerry at brookslibraryvt.org, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |kgnerre at hotchkiss.org, | |mr.cataloger at gmail.com, | |olli-antti.kivilahti at jns.fi | |, | |paul.poulain at biblibre.com, | |srdjan at catalyst.net.nz --- Comment #6 from Jonathan Druart --- As bug 9011 raised some discussion about this feature, I am ccing the people involved in previous bug and would like to get another signoff on this one, please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:37:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:37:55 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:42:23 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #6) > As bug 9011 raised some discussion about this feature, I am ccing the people > involved in previous bug and would like to get another signoff on this one, > please. I agree everyone involved on bug 9011 should be aware of the new patches ( which is why I marked the bug moved ). However, you have provided no justification for requiring a second signoff on this patch. This version is the end product of all the discussion on bug 9011. This version uses a join table to track the last returner for an item. This solves the privacy issues of the first version, and the speed issues of the second version. Anyone and everyone is free to fail qa on this patch due to concerns they would like addressed, but there is nothing to be gained from requiring a second signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 13:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 11:53:16 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #43 from Kyle M Hall --- (In reply to Jonathan Druart from comment #42) > Kyle, now that bug 5371 has been pushed, I cannot longer reproduce the issue. > Should we push these changes anyway? Yes, I believe these changes should be pushed anyway. This fixes the bug at a deeper level than bug 5371 and there is a definite possibility that future changes could cause a new regression. This fix should stop all future regressions of this behavior and has a unit test to prove it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:01:19 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #8 from Katrin Fischer --- It gains us more eyes and should not be too hard to achieve given that there is a lot of active interest in thsi feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:01:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:01:49 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:09:14 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #9 from Barton Chittenden --- (In reply to Jonathan Druart from comment #8) > Barton, you should fix the author's patch. Jonathan, I don't think that there's anything wrong with the patch ... I signed off on the patch for our partner library [we ran a demo for them], and I forgot to obsolete the un-signed patch when I submitted it. Test plan: 1) Import MARC21 bibs containing - ISBN in 020$z - ISSN in 022$y - ISSN in 022$z 2) Make sure that bibs are indexed 3) Search by ISBN and ISSN above -- bibs should not show in search. 4) Apply patch, re-index 5) Search again; ISBN in 020$z and ISSN in 022$y and 022$z should return results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:17:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:17:41 +0000 Subject: [Koha-bugs] [Bug 14963] New: Ability to suggest purchase on existing catalog record without holdings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Bug ID: 14963 Summary: Ability to suggest purchase on existing catalog record without holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: imingchan at yahoo.com.au QA Contact: testopia at bugs.koha-community.org Expand the existing Purchase Suggestion to cater for titles already found in the library catalogue. Currently, it is impossible to link a suggestion to a matching catalogue record. Some catalogue records may no longer have items/holdings attached (as they could have been deleted earlier). Also it will be nice that titles accepted for purchase, also appear in OPAC with a similar remark to items on order (i.e. 1 item accepted for purchase). This will prevent repeated suggestions of the same title from different users! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:18:16 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to suggest purchase |Ability to suggest purchase |on existing catalog record |on existing catalogue |without holdings |record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:30:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:30:14 +0000 Subject: [Koha-bugs] [Bug 14964] New: Email notices will be queued for patrons with no email address Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Bug ID: 14964 Summary: Email notices will be queued for patrons with no email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:36:57 +0000 Subject: [Koha-bugs] [Bug 14965] New: Remove C4::Dates from 'lists' in folder reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Bug ID: 14965 Summary: Remove C4::Dates from 'lists' in folder reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:41:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:41:39 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:41:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:41:42 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 --- Comment #1 from Kyle M Hall --- Created attachment 43161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43161&action=edit Bug 14964 - Email notices will be queued for patrons with no email address If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. Test Plan: 1) Set up patron with checkout messaging preference and no email address 2) Check out an item to the patron 3) Note the message in the message queue with no email address 4) Apply this patch 5) Check out an item to the patron 6) Note no message was queued this time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:41:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:41:47 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:42:26 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43161|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 43162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43162&action=edit Bug 14964 - Email notices will be queued for patrons with no email address If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. Test Plan: 1) Set up patron with checkout messaging preference and no email address 2) Check out an item to the patron 3) Note the message in the message queue with no email address 4) Apply this patch 5) Check out an item to the patron 6) Note no message was queued this time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:48:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:48:05 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #10 from Jonathan Druart --- (In reply to Barton Chittenden from comment #9) > (In reply to Jonathan Druart from comment #8) > > Barton, you should fix the author's patch. > > Jonathan, > > I don't think that there's anything wrong with the patch ... I signed off on > the patch for our partner library [we ran a demo for them], and I forgot to > obsolete the un-signed patch when I submitted it. The author's patch is "From: Koha instance bug_14617-koha " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:50:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:50:30 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #1 from Marc V?ron --- Created attachment 43163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43163&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:51:05 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Blocks| |14870 Patch complexity|--- |Small patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:51:05 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14965 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 [Bug 14965] Remove C4::Dates from 'lists' in folder reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:59:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:59:30 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:59:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:59:33 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43125|0 |1 is obsolete| | Attachment #43126|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 43164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43164&action=edit Bug 5144 - Add unit test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:59:43 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #45 from Jonathan Druart --- Created attachment 43165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43165&action=edit Bug 5144 - Duplicate holds allowed if patron clicks back button after placing hold Koha is currently not engineered to handle multiple holds per record. Until such time that is does, we should not allow them to be created. Test Plan: 1) Apply this patch 2) Log in to the opac 3) Place a hold 4) Hit the back button on your browser 5) Place the hold again 6) Note the new message Signed-off-by: David Kuhn Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:59:46 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #46 from Jonathan Druart --- Created attachment 43166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43166&action=edit Bug 5144: Add test on carp message Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 14:59:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 12:59:51 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #47 from Jonathan Druart --- Created attachment 43167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43167&action=edit Bug 5144: Don't display the failed_holds param in the url if not needed Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:03:36 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:19:11 +0000 Subject: [Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14966 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:19:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:19:11 +0000 Subject: [Koha-bugs] [Bug 14966] New: Table header broken at detail.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Bug ID: 14966 Summary: Table header broken at detail.tt Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: rkopaczka at afm.edu.pl Reporter: rkopaczka at afm.edu.pl QA Contact: testopia at bugs.koha-community.org Created attachment 43168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43168&action=edit screenshot After Bug 14354, when user without permission to edit items, goes to page: /cgi-bin/koha/catalogue/detail.pl?biblionumber=xxx, table with item info is corrupted. See screenshot attached. Looks like additional '', are unnecessary. A patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:20:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:20:57 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #4 from Marc V?ron --- Created attachment 43169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43169&action=edit Bug 14949 - (followup) Fix regression with hard due date This patch fixes the regresseion as described in comment #3 To test: - Go on smart-rules.pl and edit a line. Do not define a Hard due date, save. The value is "None defined". - Edit the line, do not change anything and save. The value should be "None defined" - Edit the line, define a hard due date, save. The date should display as expected. - Edit the line agein, remove the hard due date, save. The value should be "None defined" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:21:19 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Rafal Kopaczka changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:21:58 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 --- Comment #1 from Rafal Kopaczka --- Created attachment 43170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43170&action=edit Bug 14966:Table header broken at detail.tt For user without item edit permission, table at catalogue/detail.pl is corrupted. Test plan: 1) Log in as staff member, without edit item permission. 2) Go to biblio view, with items attached: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table does not display correctly. 3) Apply patch. 4) Repeat steps 1 and 2. Confirm patch works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:22:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:22:03 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:22:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:22:44 +0000 Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Bug 9809 already updated all calls to AddReserve, to prevent a future change again it could worth to change the prototype of this subroutine to make it get a hashref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:27:05 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42607|0 |1 is obsolete| | --- Comment #11 from Barton Chittenden --- Created attachment 43171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43171&action=edit Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z http://bugs.koha-community.org/show_bug.cgi?id=14617 Signed-off-by: kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:28:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:28:06 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #12 from Barton Chittenden --- (In reply to Jonathan Druart from comment #10) > (In reply to Barton Chittenden from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > Barton, you should fix the author's patch. > > > > Jonathan, > > > > I don't think that there's anything wrong with the patch ... I signed off on > > the patch for our partner library [we ran a demo for them], and I forgot to > > obsolete the un-signed patch when I submitted it. > > The author's patch is "From: Koha instance bug_14617-koha > " Fixed author of patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:28:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:28:52 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use a translateable file |Use a translatable file |instead of the database for |instead of the database for |managing permission |managing permission |descriptions |descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:34:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:34:56 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43170|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 43172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43172&action=edit Bug 14966:Table header broken at detail.tt For user without item edit permission, table at catalogue/detail.pl is corrupted. Test plan: 1) Log in as staff member, without edit item permission. 2) Go to biblio view, with items attached: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table does not display correctly. 3) Apply patch. 4) Repeat steps 1 and 2. Confirm patch works. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:34:54 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:35:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:35:08 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.20 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:36:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:36:15 +0000 Subject: [Koha-bugs] [Bug 14967] New: update_dbix_class_files.pl should have a default DB name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14967 Bug ID: 14967 Summary: update_dbix_class_files.pl should have a default DB name Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz It would be handy if update_dbix_class_files.pl defaulted to some name; say dbic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:36:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:36:22 +0000 Subject: [Koha-bugs] [Bug 14967] update_dbix_class_files.pl should have a default DB name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14967 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:36:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:36:28 +0000 Subject: [Koha-bugs] [Bug 14967] update_dbix_class_files.pl should have a default DB name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14967 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:41:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:41:50 +0000 Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli at cineca.it | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:42:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:42:25 +0000 Subject: [Koha-bugs] [Bug 14968] New: found shouldn't be set to null when cancelling holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Bug ID: 14968 Summary: found shouldn't be set to null when cancelling holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: koha at univ-lyon3.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com We want to provide statistics on canceled holds to know if they haven't been picked-up while waiting for the borrower or if the expiration_date on hold have been passed. But if we can see if a hold is waiting in found column of reserves table, this information disappeared from old_reserves table. Found shouldn't be set to Null when cancelling in order to keep this information in old_reserves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:51:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:51:46 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #1 from Koha Team Lyon 3 --- Created attachment 43173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43173&action=edit found shouldn't be set to null when cancelling holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:51:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:51:59 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:52:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:52:24 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 15:56:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 13:56:34 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #23 from Tom?s Cohen Arazi --- Created attachment 43174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43174&action=edit Bug 10020: (RM followup) DBIx update Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:03:12 +0000 Subject: [Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #48 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:03:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:03:48 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #50 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:06:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:06:53 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:07:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:07:14 +0000 Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Barton! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:07:38 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:08:00 +0000 Subject: [Koha-bugs] [Bug 14951] Remove C4::Dates from plugins/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14951 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:08:20 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:20:56 +0000 Subject: [Koha-bugs] [Bug 14840] Added new cron script send membership expiry reminder notices in crontab.example file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6810 CC| |tomascohen at gmail.com See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6810 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 [Bug 6810] Send membership expiry reminder notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:20:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:20:56 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14840 See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14840 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 [Bug 14840] Added new cron script send membership expiry reminder notices in crontab.example file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 16:39:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 14:39:45 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 43175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43175&action=edit Bug 14667: (QA followup) make the UI show 'Label creator' consistently The tool is documented and accessed (via Tools >) as 'Label creator'. But the pages titles say 'Labels' and the breadcumbs 'Labels home'. It should be called 'Label creator' for consistency. This patch changes the tt files so they are consistent. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 17:34:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 15:34:06 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 17:54:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 15:54:49 +0000 Subject: [Koha-bugs] [Bug 14968] found shouldn't be set to null when cancelling holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14968 --- Comment #2 from Koha Team Lyon 3 --- Test plan : - fill syspref ReservesMaxPickUpDelay = 0 - Add a hold and return the item to make it waiting for the borrower - Wait one day or change waitingdate in reserves table to put yesterday date - launch the script /src/misc/cronjobs/holds/cancel_expired_holds.pl You should find your reserve in old_rerseves table with W in column found -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 17:55:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 15:55:51 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43175|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi --- Created attachment 43176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43176&action=edit Bug 14667: (QA followup) make the UI show 'Label creator' consistently The tool is documented and accessed (via Tools >) as 'Label creator'. But the pages titles say 'Labels' and the breadcumbs 'Labels home'. It should be called 'Label creator' for consistency. This patch changes the tt files so they are consistent. It also makes the title show the same page name as the breadcumbs. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 17:56:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 15:56:02 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 43177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43177&action=edit Bug 14667: (QA followup) remove useless labels-menu.inc file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 18:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 16:18:25 +0000 Subject: [Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jesse! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 18:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 16:19:48 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #90 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Amit, Alex and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 18:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 16:20:21 +0000 Subject: [Koha-bugs] [Bug 14840] Added new cron script send membership expiry reminder notices in crontab.example file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14840 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Amit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 18:20:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 16:20:46 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 19:22:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 17:22:51 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 19:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 17:22:55 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #31 from Jonathan Druart --- Created attachment 43178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43178&action=edit Bug 14045: Fix typo in template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 19:24:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 17:24:08 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #32 from Jonathan Druart --- (In reply to Katrin Fischer from comment #30) > Started with testing the circulation rules GUI and found a problem: > > Default checkout, hold and return policy (second part of the page)- the > onsite-checkouts number doesn't show in the field after saving, but it looks > like it IS actually saved to the table. Can you check? Came from a typo in the template: default_onsitemaxissueqty vs default_maxonsiteissueqty Should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 20:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 18:30:04 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle.m.hall at gmail.com |y.org | CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 20:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 18:45:07 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #160 from Kyle M Hall --- Testing so far looks good! A couple things I'd like to address before passing qa: 1) Accessing invalid paths gives us a Mojo generated page that gives data that while useful for development should probably just give us 404's in production. How do you think we should address this? 2) One of the bits of data from that invalid page leads me to this: http://mojolicio.us/perldoc/Mojolicious/Guides/FAQ#What-does-Your-secret-passphrase-needs-to-be-changed-mean Is this something we should be setting? Perhaps a hard coded default secret for Koha and the option to specify a different one in koha-conf.xml? 3) A wiki page for RESTful api developer guidelines would be most helpful. Nothing too fancy, just a "here are the bits you need to change and add to extend the REST api". The code itself is a good document but an actual guide would certainly be helpful. Setting to failed qa until 1 and 2 are addressed. 3 is more of a wish list item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:00:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:00:55 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:13:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:13:57 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:20:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:20:26 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 --- Comment #5 from Barton Chittenden --- Created attachment 43179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43179&action=edit Bug 14515: Add biblioitems to messages in C4/Reserves.pm http://bugs.koha-community.org/show_bug.cgi?id=14515 Signed-off-by: Danielle Aloia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:20:43 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 --- Comment #6 from Barton Chittenden --- Created attachment 43180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43180&action=edit Bug 14515 (QA Followup) fix letter.pl available fields. Add bibliotiems to the 'available fields' list for module 'Holds' (aka reserves). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:21:39 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #17 from Liz Rea --- Oh awesome,thanks for the followups! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:22:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:22:33 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:26:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:26:10 +0000 Subject: [Koha-bugs] [Bug 14718] Documentation/screenshot update for label creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14718 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Documentation/screenshot |Documentation/screenshot |update |update for label creator Severity|normal |critical --- Comment #1 from Liz Rea --- This has been pushed, so this is now a requirement. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:38:28 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #134 from Jesse Weaver --- Librarians/catalogers: your feedback is requested below, please! (In reply to Jonathan Druart from comment #132) > Quick feedback after some random tests: > > 1/ + console.dir( _framework_kohafields ); > => to remove > > 2/ dependency UUID should be added > > 3/ Edit/create a record, modify it, click on "New record" (you just missed > the Save button), everything is lost. > Should ask for confirmation :) > All easy fixes, will submit a followup. > 4/ Search > a. Click on 1 server launch a request, what if you want to select/deselect > all? I think it would be better to have a "search" button here, to avoid > useless queries. > My thought was that most searches with a need to specify a set of servers much different from the norm would start on the advanced search screen. This has come up before, though, so I want to ask for input from the librarians/catalogers on this bug. > b. The number of results is different with the same search on > cataloguing/z3950_search.pl (5 pages vs 25!) > Could I ask for the search you used? > c. The link is "Import" even if the users search in the local catalogue. > Maybe "edit" is more appropriate. > That's a reasonable change, will fix. > 5/ The favicon is missing on cataloguing/editor.pl > Can't replicate, are you sure this isn't a local problem? > 6/ I still have issue with mandatory/repeatable field. > From the editor: > 615 _ _ $a [Dropdown list] > Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing > mandatory subfield: $x > > From the (default) framework page: > 615 centre d'int?r?t No No > 2 code du syst?me d'indexation subfield ignored > 3 num?ro de la notice d'autorit? subfield ignored > a cat?gorie sujet Tab:1, Not repeatable, Not mandatory, | Auth > value:interet > m subdivision de la cat?gorie sujet sous forme cod?e subfield ignored > n cat?gorie sujet sous forme cod?e subfield ignored > x subdivision de la cat?gorie sujet subfield ignored > > 7/ I don't understand why the default framework is used. > The default framework was used in order to not deal with the complexities of switching frameworks after a record was loaded. > 8/ Import record, then save. > "Saving" is processing, nothing happen, browser freezes > JS error: > Error: Script terminated by timeout at: > > P at http://pro.koha-qa.vm/intranet-tmpl/lib/codemirror/codemirror-compressed. > js:11:7546 > [...] some others errors > The record has 50 items. > Could I ask for a play-by-play on this? (What server/search/record/etc.) > 9/ macro > delete 200 # delete only the first 200, is it expected? > Is there a doc somewhere with the commands available? Will post. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:40:10 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #135 from Jesse Weaver --- (In reply to Jonathan Druart from comment #133) > (In reply to Jonathan Druart from comment #132) > > 6/ I still have issue with mandatory/repeatable field. > > From the editor: > > 615 _ _ $a [Dropdown list] > > Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing > > mandatory subfield: $x > > > > From the (default) framework page: > > 615 centre d'int?r?t No No > > 2 code du syst?me d'indexation subfield ignored > > 3 num?ro de la notice d'autorit? subfield ignored > > a cat?gorie sujet Tab:1, Not repeatable, Not mandatory, | Auth > > value:interet > > m subdivision de la cat?gorie sujet sous forme cod?e subfield ignored > > n cat?gorie sujet sous forme cod?e subfield ignored > > x subdivision de la cat?gorie sujet subfield ignored > > Ok forget this one, the subfield are ignored but marked as mandatory. > Not what we should do in this case. The UNIMARC framework is very strange; what is the intended effect of an ignored/mandatory subfield? > The checks done on the "normal" edition mode don't look to work correctly. What do you mean by this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:45:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:45:47 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #137 from Jesse Weaver --- Another thing I'd like some cataloger feedback on, if any of you have the chance. (In reply to H?ctor Eduardo Castro Avalos from comment #123) > Good job, Weaver. > > I was testing in your sandbox, but i got some issues when typing and trying > to delete characters with backspace, sometimes the last word cannot be > deleted and sometimes all line cannot be deleted or edited. > > 1) IMHO, i prefer the MARC Maker style like MARC Edit > . So you shouldn't take care about > the spaces around the subfields, that i think is the problem in previous > issue. e.g. > =100 1\$aWeaver, Jesse. > =245 10$aProfessional cataloger's interface /$bby Jesse Weaver. > I'm contemplating switching wholesale to using the double-cross character (with the shortcut of alt-d). Using the dollar sign introduces a number of problems, and isn't really much more ergonomic (especially as seen above with alternative keyboard layouts). Thoughts? > 2) Also some scape character like {dollar}, {ntilde}, {phono} this is when > you cannot infer with some accent character, MARCMaker uses this scape > characters. They call this Character Mnemonic Strings at > maybe providing a Modal with all > those characters. > This will not be supported in this version of Rancor, but is planned for development in the near future and will be added in the future. > A cataloger thought > > Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 22:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 20:42:12 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #136 from Jesse Weaver --- (In reply to H?ctor Eduardo Castro Avalos from comment #128) > (In reply to Christopher Davis from comment #120) > > Anyone care to reply to comment 115? I think that step 15 of the test plan > > is referring to Koha authorized values (Home>Administration>Authorized > > values) and not authorized access points from the authority file. Your > > thoughts? > > > > Thanks > > Yep there aren't a modal, pop-up, or, single-dropdown widgets to get > authorities linked to bib record. > > Maybe when typing $9 or $0, in theory, should appear something to link our > authorities in 1XX, 6XX, 7XX, and, 8XX fields > > Regards Authorities will unfortunately not be supported in this version of Rancor, but they will be developed soon and in a future version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 23:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 21:18:26 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42158|0 |1 is obsolete| | --- Comment #40 from Eivin Giske Skaaren --- Created attachment 43181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43181&action=edit Bug 12768: Use the Price TT plugin to display prices Retested also with item-level_itypes set to biblio and made sure to delete relevant rows from accountlines table when using same item and patron: Scenario 1 works Scenario 2 works I have also manually tested the sql in C4::Circulation::LostItem and it seems to work from what I can see. Adding a test for that in t/db_dependent/Circulation/Chargelostitem.t was not trivial. I am not a test developer but if it really is needed someone with more experience developing mockups with the db should probably be able to do it. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 23:28:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 21:28:48 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #41 from Eivin Giske Skaaren --- I am setting this to signed off again even though there are no tests written for the C4::Circulation::LostItem subroutine. The test seems to need to mock several tables and someone experienced writing that type of tests for Koha should probably do it if it really is needed. I have tested thoroughly manually in GUI, console and mysql client. Peggy: This patch has already consumed considerable time and perhaps it is better to not increase its scope at this stage. My suggestion is that you file a new bug with the wanted enhancements and refer to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 6 23:51:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 21:51:21 +0000 Subject: [Koha-bugs] [Bug 14969] New: Remove C4::Dates from serials/*.pl files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Bug ID: 14969 Summary: Remove C4::Dates from serials/*.pl files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Bug to remove C4::Dates from files: - serials/acqui-search-result.pl - serials/checkexpiration.pl - serials/routing-preview.pl - serials/routing.pl - serials/serial-issues.pl - serials/serials-collection.pl - serials/serials-edit.pl - serials/showpredictionpattern.pl - serials/subscription-add.pl - serials/subscription-detail.pl - serials/subscription-history.pl - serials/subscription-renew.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 00:43:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 22:43:24 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #1 from Marc V?ron --- Created attachment 43182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43182&action=edit Bug 14969 - Remove C4::Dates from serials/*.pl files Bug to remove C4::Dates from files: - serials/acqui-search-result.pl - serials/checkexpiration.pl - serials/routing-preview.pl - serials/routing.pl - serials/serial-issues.pl - serials/serials-collection.pl - serials/serials-edit.pl - serials/showpredictionpattern.pl - serials/subscription-add.pl - serials/subscription-detail.pl - serials/subscription-history.pl - serials/subscription-renew.pl To test: - Go to Home > Serials - Add, edit serials and routing lists with focus on date entry and display - Verify that information for serials on item detail pages look fine in OPAC and staff client as well - Try to find regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 00:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 22:44:15 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Blocks| |14870 Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 00:44:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 22:44:15 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14969 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 [Bug 14969] Remove C4::Dates from serials/*.pl files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 00:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 06 Oct 2015 22:47:16 +0000 Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 05:26:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 03:26:02 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- Maybe an example? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 05:39:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 03:39:52 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #126 from Liz Rea --- Created attachment 43183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43183&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 08:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 06:03:35 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #145 from Robin Sheat --- (In reply to Jonathan Druart from comment #141) > Did you have time to look into the terms aggregations? > Or maybe is it what you are already using? Yeah, I'm aware of that. Unfortunately, it only became deprecated after I'd implemented it, and I haven't got around to going back and reworking it. I don't think it'll be a big change, it's possible it's sufficient to just switch the ES type we're using. Anyway, I've put it on the "deal with later" pile. (In reply to Jonathan Druart from comment #142) > On a unimarc installation, there are no mapping at all for authorities. > If an unimarc user follows this bug report... Working out the MARC21 mappings was tedious enough :) (In reply to Jonathan Druart from comment #143) > Maybe I have not drunk enough tea this morning but... > I am trying to improve the mappings area to have a consistent interface to > manage them. > The idea is to 1) move the elastic_mapping.sql to a elastic_mapping.json > file (easier to modify and read), 2) provide methods to > serialize/unserialize mappings and then 3) introduce a backup/import/reset > mappings feature and finally 4) make easier the mapping progression to get a > good basis to use ES. > > I have managed to create a json file from the sql file, the structure is > something like: > > { > biblio => { > title => { > label => 'Title', > type => 'string', > mappings => [ > { > suggestible => 1, > facet => 1, > marc21 => '245a', > unimarc => '200a', > normarc => '245a', > }, > ] > }, > } > > And I have some questions :) > - Do you agree with the idea? Well... I don't know. Though I'm not a fan of that structure really, as it's not ideal, and is a bit more limited. Also, in this case you can't have more than one title, but that's not really the big issue. Mostly it's just a very denormalised view of the data. Better for manually editing an SQL file, but not really so good for a computer to use. This is why the SQL file has the data in that form and then normalises it in the database. > - Don't you think the index_name should be a column of the search_fields > table? Yes, it should be kept with search_field.name as it's effectively more information needed to describe where something gets stored. > - Some of the fields don't have a type, should we assign "string" as the > default value? I'd like to not just because that implies that they've consciously been made strings. Ideally as time goes on, people will decide that this is a date, and this is a ... IP address or something, and add those as types while putting the logic in to handle it. So, if a type is unspecified, then it gets treated like a string by default, but it really means "we haven't decided yet." > - wordings: 'sortable' and 'facetable' sounds more appropriate than 'sort' > and 'facet' hmm. I don't really mind either way. My thinking was that "facet" and "sort" were easier to type. But I broke the consistency because "suggest" seemed weird. I don't object to any of them changing. > - (/me is clearing his throat) I think that all the mappings of a field > should be removed if the field is removed. In other word, there is a 1-n > relationship beetwen search_field and search_marc_map, which means that the > join table (search_marc_to_field) is not needed and we could simplify the > structure removing it. I had a good reason for doing many-to-many. Let me see if I can remember it... Oh wait, I documented it: -- This joins the two search tables together. We can have any combination: -- one marc field could have many search fields (maybe you want one value -- to go to 'author' and 'corporate-author) and many marc fields could go -- to one search field (e.g. all the various author fields going into -- 'author'.) If you remove the many-to-many relationship then you end up with duplication/denormalisation. My thinking behind the UI is that you might have, say, a list of all the fields and under them, a set of all the MARC fields that map to it. Or perhaps the inverse. I hadn't really thought about it too much, but a properly denormalised relational structure means that we have the maximum amount of flexibility. The only improvement to the structure in this respect is that the sort, facet, suggest things should really be at the join level. I have a feeling I considered that, then decided it risked crossing the line into too fiddly, but it would get more power out of it. At the moment you'd have to duplicate the MARC details if you want different values for those three which isn't ideal. (In reply to Jonathan Druart from comment #144) > Ha, something else: the biblionumber should be a field of the biblios index. Oh, it's embedded as the ID on the ES record. There's no point duplicating it as its own field, but it's reasonable to copy it out as a post-process step and put it into a biblionumber field. We don't have a reliable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 08:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 06:04:58 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #146 from Robin Sheat --- (In reply to Robin Sheat from comment #145) > We don't have a reliable I was going to say we don't have a reliable biblionumber source in the marc, but we do as I force it to be correct. But that's not relevant, we should just use the ID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:37:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:37:59 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Hi Kyle, I get errors with: t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 2048 Tests: 12 Failed: 8) Failed tests: 2, 4-5, 7, 9-12 Non-zero exit status: 8 (...) not ok 4 - Should have duration of 1 # Failed test 'Should have duration of 1' # at t/db_dependent/DecreaseLoanHighHolds.t line 97. # got: '0' # expected: '1' not ok 5 - due_date should be a DateTime object # Failed test 'due_date should be a DateTime object' # at t/db_dependent/DecreaseLoanHighHolds.t line 98. # got: '' # expected: 'DateTime' (...) not ok 7 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 116. # got: '0' # expected: '1' (... and more) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:39:13 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43115|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 43185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43185&action=edit Bug 14788: Add unit tests for GetTopIssues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:39:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:39:11 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43051|0 |1 is obsolete| | --- Comment #9 from Julian Maurice --- Created attachment 43184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43184&action=edit Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:40:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:40:14 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #11 from Julian Maurice --- Patches rebased on master. Minor conflict resolved, switching back to Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:50:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:50:50 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #147 from Jonathan Druart --- (In reply to Robin Sheat from comment #145) > (In reply to Jonathan Druart from comment #143) > > Maybe I have not drunk enough tea this morning but... > > I am trying to improve the mappings area to have a consistent interface to > > manage them. > > The idea is to 1) move the elastic_mapping.sql to a elastic_mapping.json > > file (easier to modify and read), 2) provide methods to > > serialize/unserialize mappings and then 3) introduce a backup/import/reset > > mappings feature and finally 4) make easier the mapping progression to get a > > good basis to use ES. > > > > I have managed to create a json file from the sql file, the structure is > > something like: > > > > { > > biblio => { > > title => { > > label => 'Title', > > type => 'string', > > mappings => [ > > { > > suggestible => 1, > > facet => 1, > > marc21 => '245a', > > unimarc => '200a', > > normarc => '245a', > > }, > > ] > > }, > > } > > > > And I have some questions :) > > - Do you agree with the idea? > > Well... I don't know. Though I'm not a fan of that structure really, as it's > not ideal, and is a bit more limited. Also, in this case you can't have more > than one title, but that's not really the big issue. Mostly it's just a very > denormalised view of the data. Better for manually editing an SQL file, but > not really so good for a computer to use. This is why the SQL file has the > data in that form and then normalises it in the database. I don't understand the problem with the structure, you could have several mappings (it's an arrayref of hashrefs). With this structure I could insert exactly the same data in the tables (except if I missed something...). > > - Some of the fields don't have a type, should we assign "string" as the > > default value? > > I'd like to not just because that implies that they've consciously been made > strings. Ideally as time goes on, people will decide that this is a date, > and this is a ... IP address or something, and add those as types while > putting the logic in to handle it. So, if a type is unspecified, then it > gets treated like a string by default, but it really means "we haven't > decided yet." So todo later :) > > - wordings: 'sortable' and 'facetable' sounds more appropriate than 'sort' > > and 'facet' > > hmm. I don't really mind either way. My thinking was that "facet" and "sort" > were easier to type. But I broke the consistency because "suggest" seemed > weird. I don't object to any of them changing. Not a big deal but better sooner than later. > > - (/me is clearing his throat) I think that all the mappings of a field > > should be removed if the field is removed. In other word, there is a 1-n > > relationship beetwen search_field and search_marc_map, which means that the > > join table (search_marc_to_field) is not needed and we could simplify the > > structure removing it. > > I had a good reason for doing many-to-many. Let me see if I can remember > it... > > Oh wait, I documented it: > > -- This joins the two search tables together. We can have any combination: > -- one marc field could have many search fields (maybe you want one value > -- to go to 'author' and 'corporate-author) and many marc fields could go > -- to one search field (e.g. all the various author fields going into > -- 'author'.) > > If you remove the many-to-many relationship then you end up with > duplication/denormalisation. My thinking behind the UI is that you might > have, say, a list of all the fields and under them, a set of all the MARC > fields that map to it. Or perhaps the inverse. I hadn't really thought about > it too much, but a properly denormalised relational structure means that we > have the maximum amount of flexibility. The only improvement to the > structure in this respect is that the sort, facet, suggest things should > really be at the join level. I have a feeling I considered that, then > decided it risked crossing the line into too fiddly, but it would get more > power out of it. At the moment you'd have to duplicate the MARC details if > you want different values for those three which isn't ideal. Yes, it's related to the index_name unique key discussion we had last week. We should either move sort, facet, suggest to the join table or remove it, but not keep the current structure. I am not sure about the gain of having the three tables, we could still know what fields are mapped with this MARC field or the inverse (same marc_field values). Anyway, the current structure force us to duplicate the MARC details, because of the sort, facet, suggest, which could differ. > (In reply to Jonathan Druart from comment #144) > > Ha, something else: the biblionumber should be a field of the biblios index. > > Oh, it's embedded as the ID on the ES record. There's no point duplicating > it as its own field, but it's reasonable to copy it out as a post-process > step and put it into a biblionumber field. We don't have a reliable Indeed we could add it later, but don't you think it's worth to let the librarians (and devs) search something like "biblionumber:42", which is a more familiar term than "ID"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:57:25 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #91 from Jonathan Druart --- Comment on attachment 42609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42609 Bug-6810: Send membership expiry reminder notices. Review of attachment 42609: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6810&attachment=42609) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +800,5 @@ > > + if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){ > + my @dateexpiry = split /-/, $values->{'dateexpiry'}; > + > + $values->{'dateexpiry'} = C4::Dates->new( This was not really kind of Marc. He is trying to remove the C4::Dates usage. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 09:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 07:58:27 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #92 from Jonathan Druart --- (In reply to Jonathan Druart from comment #91) > Comment on attachment 42609 [details] [review] > Bug-6810: Send membership expiry reminder notices. > > Review of attachment 42609 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Letters.pm > @@ +800,5 @@ > > > > + if ( $table eq 'borrowers' && $values->{'dateexpiry'} ){ > > + my @dateexpiry = split /-/, $values->{'dateexpiry'}; > > + > > + $values->{'dateexpiry'} = C4::Dates->new( > > This was not really kind of Marc. He is trying to remove the C4::Dates usage. Ooops, sorry, removed by next patch!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 10:38:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 08:38:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #161 from Jonathan Druart --- I have also started QAing this one yesterday. Back today with few comments: 1/ 404 is not documented in the swagger.json file 2/ The properties for "borrowers" are not exhaustive 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially for new code. 4/ this patch set introduces swagger.json but nothing to use it, how is it useful? 5/ We need a way to split this json file, it will be a mess to edit! And something to validate it. We need guidelines. 6/ Koha::Borrowers->find is called in Koha::REST::V1::Borrowers::get_borrower and Koha::REST::V1->startup (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 10:42:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 08:42:13 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #162 from Jonathan Druart --- (In reply to Jonathan Druart from comment #161) > 6/ Koha::Borrowers->find is called in > Koha::REST::V1::Borrowers::get_borrower and Koha::REST::V1->startup (?) Forget that! (I am hidden already). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 10:53:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 08:53:35 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #163 from Jonathan Druart --- (In reply to Jonathan Druart from comment #161) > 1/ 404 is not documented in the swagger.json file Forget that again, it is! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 11:12:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 09:12:58 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #164 from Julian Maurice --- Created attachment 43186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43186&action=edit Bug 13799: Change Mojolicious default mode to 'production' This avoid getting a debug page when URL is wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 11:13:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 09:13:03 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #165 from Julian Maurice --- Created attachment 43187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43187&action=edit Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 11:25:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 09:25:47 +0000 Subject: [Koha-bugs] [Bug 14959] Support for Library Communications Framework (LCF) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14959 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 11:30:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 09:30:19 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #166 from Julian Maurice --- (In reply to Jonathan Druart from comment #161) > 2/ The properties for "borrowers" are not exhaustive > 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially > for new code. Ok, these points need to be fixed > 4/ this patch set introduces swagger.json but nothing to use it, how is it > useful? swagger.json, apart from being the api documentation, is also used by Mojolicious' plugin Swagger2 to create the routes (map URL to controller/action) and do some basic type check on input and output. So it is useful (or at least, used) even without documentation generators like SwaggerUI > 5/ We need a way to split this json file, it will be a mess to edit! There is an issue on Github for splitting the JSON spec https://github.com/jhthorsen/swagger2/issues/33 which was moved to https://github.com/jhthorsen/json-validator/issues/4 which ends with a commit in master https://github.com/jhthorsen/json-validator/commit/5d7d9db22b891758ac979cc87f1ab018030df2c2 It seems there is something to test here. > And something to validate it. We need guidelines. What kind of validation ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 11:37:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 09:37:40 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #1 from Martin Persson --- Created attachment 43188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43188&action=edit Bug 8630 - Adlibris covers (syspref files) This patch adds a system preference for cover images from Swedish book retailer Adlibris. Images are retrieved via http or https from an external web server. This might leak OPAC and Staff interface data to third parties and should thus be used with caution. Sponsored-By: Halland County Library Test plan: Test 1: Test upgrade procedure for clean installation. Start by removing existing sysprefs, if present: $ mysql -u kohaadmin -p -D koha > DELETE FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; * Apply this patch which will add a pref file, update the 'syspref' structure and add an atomic upgrade file. * Install the update: Koha$ perl installer/data/mysql/updatedatabase.pl * Once upgraded and logged in, Select 'More', 'Administration', 'Global Preferences' and finally 'Enhanced content'. There should be a new option called 'Adlibris'. The first option should default to "Don't show", if not the patch is broken. The second options should show the default URL: http://www.adlibris.com/se/organisationer/showimagesafe.aspx If not, the patch is broken. Test 2: Changing sysprefs * In the control panel, change the first value from "Don't show" to "Show" and save the changes. Use MySQL client to inspect changes: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; The column 'value' should now have the value '1', if not the patch is broken. Test 3: Apply update to existing data * Re-execute the installer now that the database has the data already: Koha$ perl installer/data/mysql/updatedatabase.pl If any errors occur the patch is broken. Examine the database contents: $ mysql -u kohaadmin -p -D koha > SELECT * FROM `systempreferences` WHERE `variable` LIKE 'Adlibris%'; If the values were overwritten by the installer the patch is broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 12:58:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 10:58:25 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #16 from Kyle M Hall --- (In reply to Katrin Fischer from comment #14) > Hm, I think 0/1 as the description is not very friendly for the cataloger > and might lead to some confusion. Another suggestion: We could use the > mechanism that makes system preferences available in the XSLT. We could > create a variable to store the description that matches the authorised value > category linked to 942$n for the value 1. And then base the check on that. > Does that make sense? :) I don't think I followed that well ; ) Here's what I'm thinking: 1) Add a new system preference OpacSuppressionValue that defines the value ( 1, the Authorised Value description for 1, default of 1 if not set ). So this value could be 1, Yes, Si, Oui or what have you. 2) Pass this new pref to the XSLT 3) Compare against the pref value rather than just '1' Is this what you are thinking Katrin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 13:40:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 11:40:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #167 from Kyle M Hall --- (In reply to Julian Maurice from comment #166) > (In reply to Jonathan Druart from comment #161) > > 2/ The properties for "borrowers" are not exhaustive > > 3/ Wording: borrowers vs patrons? "Patron" should be used now, especially > > for new code. > > Ok, these points need to be fixed Agreed. The external api terminology must be patron / patrons at the least. At some point we need to change Koha::Borrower(s) to Koha::Patron(s) but that is entirely separate and distinct from this work. > > 5/ We need a way to split this json file, it will be a mess to edit! > > There is an issue on Github for splitting the JSON spec > https://github.com/jhthorsen/swagger2/issues/33 > which was moved to > https://github.com/jhthorsen/json-validator/issues/4 > which ends with a commit in master > https://github.com/jhthorsen/json-validator/commit/ > 5d7d9db22b891758ac979cc87f1ab018030df2c2 > > It seems there is something to test here. Agreed. It would be *much* better if we can split this file up. If the Swagger2 version we are using doesn't support it, we may have to table this issue until a newer version is available for us to use with Koha. > > And something to validate it. We need guidelines. > > What kind of validation ? I think a unit test using Test::JSON::is_valid_json should be sufficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 13:40:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 11:40:47 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #168 from Kyle M Hall --- Also, thanks for the followups Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:00:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:00:01 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Colin Campbell --- having applied the patch against current master server terminates when processing an issue transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:14:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:14:59 +0000 Subject: [Koha-bugs] [Bug 12152] Holds to pull report should show library and itype description instead of their codes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12152 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #3 from Magnus Enger --- Locations (authorized value LOC) also show the codes instead of descriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:21:23 +0000 Subject: [Koha-bugs] [Bug 14970] New: routed items still say available Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14970 Bug ID: 14970 Summary: routed items still say available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nicole at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com If you set up a routing list in Serials and you have a serial that is being routed it says it's available in the opac, but it's not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:21:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:21:33 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #169 from Julian Maurice --- Created attachment 43189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43189&action=edit Bug 13799: Change 'required' value type from string to boolean String is not accepted as a valid value in more recent versions of Swagger2 module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:39:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:39:27 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #170 from Martin Renvoize --- I've been working allot lately with the developer of the Swagger2 perl tools. We have got $ref support working well now, with relative paths, full paths and url's all passing tests. I asusme it's this piece you were refering to when talking about splitting up the spec file khall? Regarding 'patrons' vs 'borrowers' can we not use the 'americanised' term pretty please.. to me it would be much better to generalise it.. they're not limited to borrowers/patrons at all.. they're 'users' ;) Back on topic, I'll be looking at all this stuff today.. great work Julian in my brief look so far. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:50:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:50:13 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Tom?s Cohen Arazi --- This patchset removes DBIx::Connector usage, but is also moving the database handler creation responsability into the Koha::Database class. It looks great, convenient and makes a lot of sense. But right now it breaks some tests. Probably due to problems on the tests themselves: Test Summary Report ------------------- t/db_dependent/Borrower.t (Wstat: 65280 Tests: 8 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 13 tests but ran 8. t/db_dependent/Circulation_issuingrules.t (Wstat: 768 Tests: 7 Failed: 3) Failed tests: 2, 6-7 Non-zero exit status: 3 t/db_dependent/Installer.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 9 tests but ran 1. t/db_dependent/Items.t (Wstat: 65280 Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 255 Parse errors: Bad plan. You planned 9 tests but ran 6. t/db_dependent/Reports_Guided.t (Wstat: 256 Tests: 18 Failed: 1) Failed test: 16 Non-zero exit status: 1 t/db_dependent/Search.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 4 tests but ran 1. t/db_dependent/Sitemapper.t (Wstat: 1536 Tests: 14 Failed: 6) Failed tests: 6, 8, 10, 12-14 Non-zero exit status: 6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 14:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 12:53:49 +0000 Subject: [Koha-bugs] [Bug 14971] New: RIS only outputs the first 10 characters for either ISBN10 or ISBN13 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14971 Bug ID: 14971 Summary: RIS only outputs the first 10 characters for either ISBN10 or ISBN13 Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jvr at fct.unl.pt QA Contact: testopia at bugs.koha-community.org RIS only outputs the first 10 characters for either ISBN10 or ISBN13. After "[Bug 14245] RIS in unimarc flavour is still deficient" where "Pushed to Stable" I upgrade to version 3.20.04 and tested sucessfully several exports to RIS until I try my own book with ISBN ending with "letter X" it was than that I realized that RIS was just only outputing the first 10 characters of either ISBN10 or ISBN13. Please use these live examples to compare MARC view data with RIS exported data: https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=9 https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=130 https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=47281 https://opac.fct.unl.pt/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=54176 Errors encountered are: 0-19-855284-X exported as SN - 0-19-85528 1-881526-11-9 exported as SN - 1-881526-1 9780444521262 exported as SN - 9780444521 972-97183-0-X exported as SN - 972-97183- Please don't limit the size length for "SN" in RIS, because it also may contain (-) hyfens. Thank You. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 15:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 13:29:03 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #171 from Kyle M Hall --- (In reply to Martin Renvoize from comment #170) > I've been working allot lately with the developer of the Swagger2 perl > tools. We have got $ref support working well now, with relative paths, full > paths and url's all passing tests. I asusme it's this piece you were > refering to when talking about splitting up the spec file khall? Yes, I believe so. > Regarding 'patrons' vs 'borrowers' can we not use the 'americanised' term > pretty please.. to me it would be much better to generalise it.. they're not > limited to borrowers/patrons at all.. they're 'users' ;) The general consensus has been for internal terminology to match outward terminology. Right now we use patrons, members and borrowers internally. Since we use patrons externally we should use it internally. I we want to change the nomenclature further we should put it to a dev meeting vote! > Back on topic, I'll be looking at all this stuff today.. great work Julian > in my brief look so far. Excellent! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 15:41:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 13:41:20 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #17 from Tom?s Cohen Arazi --- Ok, a brief about the errors and causes. Trivial: t/db_dependent/Borrower.t: transaction race, probably TestBuilder's fault. t/db_dependent/Installer.t: Uses DBI directly, should be easy to tweak t/db_dependent/Items.t: transaction race, probably TestBuilder's fault. t/db_dependent/Reports_Guided.t: DBIx doesn't raise the warning the test expect. t/db_dependent/Search.t: It seems to be failing to connect. The code actually mocks the connection, the _new_dbh function. There shouldn't be a behaviour change, but it fails. t/db_dependent/Sitemapper.t: It seems to be failing to connect. The code actually mocks the connection, the _new_dbh function. There shouldn't be a behaviour change, but it fails. Might be an important issue: t/db_dependent/Circulation_issuingrules.t: results differ from expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 16:25:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 14:25:07 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #172 from Martin Renvoize --- Firs comment: Unless we're actually going to use Mojolicious Sessions, and thus mojo cookies then we need not confuse users by making the secret configurable. As far as I can tell, secrets are only used to sign mojo cookies (Whether we should eventually switch to mojo hmac signed cookies over csgisessid is another question all together) As such, I would suggest we hard code a suitably silly secret just to quell warnings that will be output otherwise safe in the knowledge that we are not actually using said secret anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 16:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 14:38:13 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #173 from Martin Renvoize --- x-mojo-controller has recently been deprecated, though not entirely removed from the Swagger2 Mojo Plugin, withe the prefernce now being that the core swagger key 'operationId' is used in preference to it. I'm happy to submit a patch that updates both our spec and the resultant method names in the Borrowers controller. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 16:46:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 14:46:15 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #174 from Martin Renvoize --- Error responses.. I see you've added a nice simple schema for validating error responses. However, there seems to be a general move toward standardising on the error format at described by the Swagger2 plugins error handler.. Perhaps we should follow suite and adopt that same format, which is pretty darn close to what we have already (with the exception that it allows for an array of errors with messages as a posed to just a single error message string). I'm also happy to supply a patch if this is how we wish to proceed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 16:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 14:51:41 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #175 from Martin Renvoize --- Created attachment 43190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43190&action=edit Bug 13799 - Followup: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 16:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 14:55:47 +0000 Subject: [Koha-bugs] [Bug 14972] New: Limit by availability does not return results if *any* items are on-loan or lost Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972 Bug ID: 14972 Summary: Limit by availability does not return results if *any* items are on-loan or lost Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Viewing search results on search.pl -- if I click 'Limit to currently available items.', any Bib records that have items which are on-loan or lost do not show in the facet search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:01:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:01:23 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #4 from Marjorie Barry-Vila --- Hi, I tested it on a sand box and I do not have good results. The commands fails and nothing happens. See video here https://owncloud.ccsr.qc.ca/index.php/s/jxTIuf3cq0cl5j9/download Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:04:32 +0000 Subject: [Koha-bugs] [Bug 12331] can't save results to zotero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12331 Francisco Peixoto changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|CLOSED |REOPENED CC| |fabreupeixoto at gmail.com --- Comment #4 from Francisco Peixoto --- Good evening Dear Nicole and Bernardo Probably you still didn't reach any solution for this. I'am also having problems with Zotero Koha connector and I reported in the Zotero forum https://forums.zotero.org/discussion/52521/koha-translator/#Item_5 The problem I reported is a bit different but might be connected with this one. The problem I reported I face it in different catalogs even on the Bywater demo OPAC. Hope this could be a way to solve the problem. Thanks Kind regards Francisco -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:21:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #176 from Julian Maurice --- Created attachment 43191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43191&action=edit Bug 13799: Reword 'borrower' to 'patron' Also, complete the Swagger definition of a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:22:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:22:01 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #177 from Martin Renvoize --- Created attachment 43192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43192&action=edit Bug 13799 - Followup: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:30:36 +0000 Subject: [Koha-bugs] [Bug 14973] New: Suggestions - Search and warn user about existing biblio when submitting a suggestion Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Bug ID: 14973 Summary: Suggestions - Search and warn user about existing biblio when submitting a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alex.arnaud at biblibre.com QA Contact: testopia at bugs.koha-community.org When submitting a new purchase suggestion, we search for similar document among biblio and show a message if a duplicate is found. User can ignore the message and confirm the suggestion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:35:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:35:51 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #1 from Alex Arnaud --- Created attachment 43193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43193&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:41:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:41:14 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:41:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:41:35 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:51:12 +0000 Subject: [Koha-bugs] [Bug 14974] New: Use the REST API for cities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Bug ID: 14974 Summary: Use the REST API for cities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13799, 14888 One of the simplest script in Koha is admin/cities.pl. There is no relationship, very few columns, etc. The script has been rewritten recently (bug 14888) to use Koha::Object[s]. It has been cleaned and is a good candidate to collect the different point of views/implementations possible to use the REST API (bug 13799). Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 [Bug 14888] Move the cities related code to Koha::Cities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:51:12 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14974 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 [Bug 14974] Use the REST API for cities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:51:12 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14974 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 [Bug 14974] Use the REST API for cities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:53:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:53:00 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 17:54:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 15:54:53 +0000 Subject: [Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:09:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:09:26 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #1 from Jonathan Druart --- Created attachment 43194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43194&action=edit Bug 14974: Joubu's try to use the REST API for cities Here's my try. The naive way is to do AJAX calls and redirect to the list after delete/update/add. The main issue is that it does not simplify the code so far... Question: How to display notif to the user after actions (delete/update/add)? How to simplify the swagger file? How to present a search interface? See other comments in the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:09:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:09:53 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- I would be happy to see a try using AngularJS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:12:51 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:13:34 +0000 Subject: [Koha-bugs] [Bug 13016] Add fine grace period by hour In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13016 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Kyle M Hall --- Grace periods for hourly checkouts are in hours. The column is just labeled wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:15:12 +0000 Subject: [Koha-bugs] [Bug 14975] New: Fine grace period label is incorrect Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Bug ID: 14975 Summary: Fine grace period label is incorrect Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The column heading for grace period is "Fine grace period (day)" but the grace period works based on the unit selected ( hours or days ). The "(day)" part should be removed as it caused confusion for librarians. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:15:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:15:16 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:16:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:16:22 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:16:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:16:24 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 --- Comment #1 from Kyle M Hall --- Created attachment 43195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43195&action=edit Bug 14975 - Fine grace period label is incorrect The column heading for grace period is "Fine grace period (day)" but the grace period works based on the unit selected ( hours or days ). The "(day)" part should be removed as it caused confusion for librarians. Test Plan: 1) Apply this patch 2) Go to the circ rules editor 3) Note the header and footer columns for grace period no longer have "(days)" at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:23:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:23:53 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |julian.maurice at biblibre.com | |, | |jweaver at bywatersolutions.co | |m, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |olli-antti.kivilahti at jns.fi | |, tomascohen at gmail.com --- Comment #3 from Jonathan Druart --- Hi everyone (ccing some people who could be interested in this discussion), Bug 13799 is going to pass the QA step. I think we need to know where we are going and what is the next step. Beside the authentication problem, how could we use the REST API from Koha scripts? I have submitted my naive implementation (see above), but it's not so nice and would like to see what you have in mind. We need to have good basis, write guidelines and impose them, before pushing any patches, IMO. What is suggested on bug 13799 is too light and need a framework to be used efficiently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:27:27 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to place |Add ability to place |document delivery / article |article requests in Koha |requests in Koha | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:42:01 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > I would be happy to see a try using AngularJS. Looks good! I've *love* to see an Angular implementation! I think as a best practice we should build our interfaces so they can interact with Angular's $resource service factory with no customization wherever possible ( see http://www.sitepoint.com/creating-crud-app-minutes-angulars-resource/ for example ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:55:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:55:57 +0000 Subject: [Koha-bugs] [Bug 14890] Remove C4::Dates from circ/bookcount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:56:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:56:16 +0000 Subject: [Koha-bugs] [Bug 14890] Remove C4::Dates from circ/bookcount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42852|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 43196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43196&action=edit [SIGNED-OFF]Bug 14890 - Remove C4::Dates from circ/bookcount.pl This patch removes deprecated C4::Dates from circ/bookcount.pl To test: - Search for biblio with an item that has been checked out several times and that has been transferred - In left navigation click on 'Items' - In list of items click on 'View item's checkout history' - Verify that dates in 'Date arrived at current library' and in column 'Last seen' display properly. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 18:57:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 16:57:47 +0000 Subject: [Koha-bugs] [Bug 14972] Limit by availability does not return results if *any* items are on-loan or lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14972 --- Comment #1 from Barton Chittenden --- Created attachment 43197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43197&action=edit Marc file containing 2 test bibs To replicate: Setup: Create the branches and itemtypes with the following branch codes, itemtypes respectively: Branches ======== BAILEYCOVE BOOKMOBILE GURLEY HAZELGREEN MADISON MAIN MONROVIA MURPHY NEWHOPE OUTREACH RUSSELL SHOWERS TRIANA Item types ========== BOOK BOOKCD QUICKPICK Import 'test_bug_14972', and make sure that both bibs are indexed. Step by step: 1) Do a keyword search on 'Gray Mountain', you should see two bibs with multiple items. 2) Click 'Limit to currently available items' -- this should show the same two bibs. -- note that under 3.16, where I identified the bug, this is what happens, on master, I don't get any results whatsoever -- so the bug is worse on master than it is in a previous version. 3) Check out one item on one of bibs, wait for fast-indexing to catch up. 4) Re-run steps 1) and 2). Now, 'Limit to currently available items' only shows the bib with no items checked out -- even though both bibs still have items available for checkout. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:02:41 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:02:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:02:43 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42823|0 |1 is obsolete| | Attachment #42824|0 |1 is obsolete| | Attachment #42825|0 |1 is obsolete| | Attachment #42826|0 |1 is obsolete| | Attachment #42827|0 |1 is obsolete| | Attachment #42828|0 |1 is obsolete| | Attachment #42829|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 43198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43198&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:02:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:02:51 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #16 from Kyle M Hall --- Created attachment 43199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43199&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:02:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:02:54 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #17 from Kyle M Hall --- Created attachment 43200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43200&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:02:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:02:59 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #19 from Kyle M Hall --- Created attachment 43202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43202&action=edit Bug 14610 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:02:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:02:57 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #18 from Kyle M Hall --- Created attachment 43201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43201&action=edit Bug 14610 - Add and update scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:38:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:38:55 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from H?ctor Eduardo Castro Avalos --- (In reply to Marc V?ron from comment #7) > Created attachment 43069 [details] [review] > Bug 14922 - Remove C4::Dates from cataloguing/additem.pl > ... > Patch amended following comment #6 / mv Hi, MARC I tested this patch with this kind of patterns: Pattern: Year:YYYY Month:MM Day:DD the result is: Year:2015-10-07T11:26:57->year Mount:2015-10-07T11:26:57->month Date:2015-10-07T11:26:57->day Pattern: YYYYMMDD Result: 2015-10-07T11:35:32->year2015-10-07T11:35:32->month2015-10-07T11:35:32->day I've been tested other sort of patterns but the result is the same. Patch 14936 not applied since patch in Discussion and not mentioned in this bug. I don't know if this behaviour in dates is right. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 19:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 17:50:43 +0000 Subject: [Koha-bugs] [Bug 9701] Configure default indicator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9701 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 20:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 18:20:09 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14734 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 20:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 18:20:09 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Nicole Engard (ByWater) changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12468 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 20:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 18:41:48 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #9 from Marc V?ron --- Hi Hector, Thanks for testing - and silly me, I tested be editing an item where the value had already been set by previous tests. Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 20:50:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 18:50:21 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #10 from Marc V?ron --- Created attachment 43203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43203&action=edit Bug 14922 - (followup) Fix string output This patch makes YYYY MM and DD display correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 20:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 18:57:54 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:02:58 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:10 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #178 from Martin Renvoize --- Created attachment 43204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43204&action=edit Bug 13799: RESTful API with Mojolicious and Swagger2 Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t All API stuff is in /api/v1 (except Perl modules) So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification Change both OPAC and Intranet VirtualHosts to access the API, so we have: http://OPAC/api/v1/swagger.json Swagger specification http://OPAC/api/v1/{path} API endpoint http://INTRANET/api/v1/swagger.json Swagger specification http://INTRANET/api/v1/{path} API endpoint Add a (disabled) virtual host in Apache configuration api.HOSTNAME, so we have: http://api.HOSTNAME/api/v1/swagger.json Swagger specification http://api.HOSTNAME/api/v1/{path} API endpoint Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious Test plan: 1/ Install Perl modules Mojolicious and Swagger2 2/ perl Makefile.PL 3/ make && make install 4/ Change etc/koha-httpd.conf and copy it to the right place if needed 5/ Reload Apache 6/ Check that http://(OPAC|INTRANET)/api/v1/borrowers and http://(OPAC|INTRANET)/api/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers (where X is an integer greater than 1) returns a 404 error Signed-off-by: Alex Arnaud Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:15 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #179 from Martin Renvoize --- Created attachment 43205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43205&action=edit Bug 13799: Add cookie-based authentication to REST API Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:20 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #180 from Martin Renvoize --- Created attachment 43206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43206&action=edit Bug 13799: Add missing license notices Signed-off-by: Joonas Kylm?l? Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:25 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #181 from Martin Renvoize --- Created attachment 43207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43207&action=edit Bug 13799: Fix API unit tests They were failing because of the now required 'borrowers' permission Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:30 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #182 from Martin Renvoize --- Created attachment 43208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43208&action=edit Bug 13799: (QA followup) make tests use random data With the introduction of TestBuilder there's no need to rely on existing data on the DB (the original patch relies on categories and branches already existing). This patch creates a random branch, category and two borrowers with the fixed data that is needed for the tests. It adjusts the tests to use the randomized data instead of the previously fixed one. Signed-off-by: Tomas Cohen Arazi The feature works as expected and all tests passes. koha-qa.pl too. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:34 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43186|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize --- Created attachment 43209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43209&action=edit Bug 13799: Change Mojolicious default mode to 'production' This avoid getting a debug page when URL is wrong. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:39 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43187|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize --- Created attachment 43210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43210&action=edit Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43189|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize --- Created attachment 43211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43211&action=edit Bug 13799: Change 'required' value type from string to boolean String is not accepted as a valid value in more recent versions of Swagger2 module Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:49 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43191|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize --- Created attachment 43212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43212&action=edit Bug 13799: Reword 'borrower' to 'patron' Also, complete the Swagger definition of a patron Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:54 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43190|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize --- Created attachment 43213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43213&action=edit Bug 13799 - Followup: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:21:59 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43192|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize --- Created attachment 43214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43214&action=edit Bug 13799 - Followup: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:22:43 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42874|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:23:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:23:13 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:23:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:23:42 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:24:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:24:06 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:24:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:24:28 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:26:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:26:37 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #189 from Martin Renvoize --- Rebased my two patches (marked with 'Followup' keyword) and signed off on prior patches. QA Note, let's get he patrons example right and not only define all fields with descriptions but actually define types so validation may become useful. I'm happy to do this as another followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:31:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:31:00 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #190 from Martin Renvoize --- My patches require the latest versions of Swagger2 and JSON::Validator modules. I highly recommend especially whilst in development that we stick to the latest versions of these modules... The code is moving fast and becoming more and more refined almost daily. The latest changes include.. * Validating the swagger.json specification file against the swagger schema during application startup (This should prevent 'bad schema' making it into release). * Correct handling of $ref json-references in schemata * Stricter coercion functions and validation (JSON::Boolean and Integer coercion handling improvements) and various other bugfixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:51:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:51:40 +0000 Subject: [Koha-bugs] [Bug 14976] New: Specify due date, calendar and useDaysMode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14976 Bug ID: 14976 Summary: Specify due date, calendar and useDaysMode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, If you check out an item with "specify due date", due date does not take into account the calendar and closing days. It will be nice that syspref useDaysMode be used for loans with a manual due date. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 21:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 19:57:21 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #11 from H?ctor Eduardo Castro Avalos --- I was looking that there no info about this in documentation , section Advanced constraints or I don't know if this exist in another page. I added here Documentation Manager. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 22:06:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 20:06:15 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43069|0 |1 is obsolete| | --- Comment #12 from H?ctor Eduardo Castro Avalos --- Created attachment 43215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43215&action=edit [SIGNED OFF]Bug 14922 - Remove C4::Dates from cataloguing/additem.pl This patch removes C4::Dates from cataloguing/additem.pl To test: - In MARC bibliographic framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Create a new item for a biblio and verify that YYYY, MM and DD are replaced with today's values. - Apply patch and repeat that previous step behaves as before. - Verify that the overall functionality of the form is the same as before applying the patch. Signed-off-by: Hector Castro Works as advertised. With the last script not accept more than YYYYMMDD If you enter something else, the script sends to the end of line. This patch follow up the pattern in constraint default value Patch amended following comment #6 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 22:06:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 20:06:26 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43203|0 |1 is obsolete| | --- Comment #13 from H?ctor Eduardo Castro Avalos --- Created attachment 43216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43216&action=edit [SIGNED-OFF]Bug 14922 - (followup) Fix string output This patch makes YYYY MM and DD display correctly. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 22:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 20:06:54 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 22:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 20:49:45 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #5 from H?ctor Eduardo Castro Avalos --- This record exist in Library of Congress but don't have copyright date. I've been searching another example but after an hour I found nothing. Although a record with phonograph found in LC database with LCCN 2014618376 in Koha searched with Standard ID. The record was successfully copied to the default framework. Maybe, like comments 3 and 4 only OCLC connexion got that problem. It seems to be an UTF-8 problem. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 23:50:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 21:50:11 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43065|0 |1 is obsolete| | --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 43217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43217&action=edit [SIGNED-OFF]Bug 14924 - (follow-up) Add date validation using eval This patch adds a date validation (see comment #3). To test: - Apply patch - Create a new user or edit an existing user - Try valid dates for date of birth - Try invalid dates as 0000-00-00 or 32/01/1970. You can can copy/paste such strings to the date field, ignore the warning message and submit. Verify that after submit you get a message "Date of birth is invalid" - Try the same with enrollement /expiry dates Signed-off-by: Hector Castro Works as advertised. Tested with invalid dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 7 23:52:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 21:52:05 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 00:11:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 22:11:35 +0000 Subject: [Koha-bugs] [Bug 14977] New: Remove C4::Dates from files t/db_dependent/*.t Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Bug ID: 14977 Summary: Remove C4::Dates from files t/db_dependent/*.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 00:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 22:17:29 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 --- Comment #1 from Marc V?ron --- Created attachment 43218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43218&action=edit Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 00:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 22:18:17 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14977 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 00:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 22:18:17 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |veron at veron.ch Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 00:32:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 22:32:15 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #20 from Liz Rea --- This looks like it needs a rebase on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 01:34:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 07 Oct 2015 23:34:21 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #8 from Liz Rea --- I have seen double ups in issues on 3.20, probably because of this. Example: +----------+----------------+------------+---------------------+---------------------+---------------------+ | issue_id | borrowernumber | itemnumber | date_due | timestamp | issuedate | +----------+----------------+------------+---------------------+---------------------+---------------------+ | 1840368 | 547 | 123292 | 2015-10-29 23:59:00 | 2015-10-08 10:09:20 | 2015-10-08 10:09:19 | | 1840369 | 547 | 123292 | 2015-10-29 23:59:00 | 2015-10-08 10:09:21 | 2015-10-08 10:09:20 | +----------+----------------+------------+---------------------+---------------------+---------------------+ Because the ajax table is slow to load, sometimes extra careful staff members scan things twice because they thought they didn't get it. Seems a bit odd that it wouldn't prompt for renew instead of generating another issue, but there it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 03:18:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 01:18:23 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #51 from Liz Rea --- Hi, If you feel like it, a version of this for 3.18 would be pretty nice, as this one doesn't apply cleanly. (Maybe I'll have a look, but don't count on it!) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 03:52:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 01:52:50 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #148 from Robin Sheat --- (In reply to Jonathan Druart from comment #147) > I don't understand the problem with the structure, you could have several > mappings (it's an arrayref of hashrefs). Oh, yes, you're right. I missed that bit. > With this structure I could insert exactly the same data in the tables > (except if I missed something...). It's just that it's not a natural representation from a database theory point of view. Why are the various MARC forms lumped together like that? Why should a schema change be necessary when (god forbid) a new flavour is added? Actually, that could be important as if we want to add support for different things into ES, say importing a feed from a journal provider or whatever, you could use a flavour to mark how the source is mapped into elasticsearch. Additionally, it promotes redundancy as you are forced to repeat things to have all the required combinations, which always causes an icky feeling :) Essentially, having a proper relational many-to-many is the most expressive and flexible system that is feasible. I think I'm OK with moving the attributes (sortable, etc) into the join though. It probably makes the most sense. > Yes, it's related to the index_name unique key discussion we had last week. > We should either move sort, facet, suggest to the join table or remove it, > but not keep the current structure. > > I am not sure about the gain of having the three tables, we could still know > what fields are mapped with this MARC field or the inverse (same marc_field > values). > Anyway, the current structure force us to duplicate the MARC details, > because of the sort, facet, suggest, which could differ. Right, but removing the M-to-M still means we have to duplicate things. And that'll be why the index was there but problematic, because the attributes are in the wrong place. The index will (I think) be fine if they get removed. > Indeed we could add it later, but don't you think it's worth to let the > librarians (and devs) search something like "biblionumber:42", which is a > more familiar term than "ID"? Oh, good point. Yes, that should be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 04:11:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 02:11:39 +0000 Subject: [Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774 Craig Miskell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |craig at catalyst.net.nz --- Comment #1 from Craig Miskell --- It appears based on some debugging that when running under apache-mpm-itk, setuid binaries like 'at' don't have quite enough permissions to do what they need. While it does end up running as daemon.daemon, and can write to files in /var/spool/cron/atjobs/, it fails at the fchown step with EPERM. From the docs for fchown, that means "The effective UID does not match the owner of the file, and the process is not privileged (Linux: it does not have the CAP_FOWNER capability))". Without going deeper, I expect this is a result of mpm-itk dropping capabilities or privileges to get down to the run-time user, and not being able to elevate back up as a result. This would affect any other setuid programs too. Converting to some sort of app-layer (starman? plack?) may solve it, where apache runs as normal, and the application runs out of app processes that run as the correct user from the start, and which can therefore setuid back up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 04:53:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 02:53:57 +0000 Subject: [Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Liz Rea --- In additional, unexpected news: Debian Jessie seems to be unaffected, and honestly I expected it would be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 04:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 02:56:04 +0000 Subject: [Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 06:16:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 04:16:34 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #149 from Robin Sheat --- (In reply to Robin Sheat from comment #91) > > The item is a "Visual Materials" which has a itemtype.notforloan flag set. > > Good to know, I've not tested that case yet. Well, I spent far too long staring at that, only to find it's been working all along. You can set it on the itemtype and it should have always worked (as that's done in post-processing, which is the same between zebra and es), and all it needed to work at the item level was a mapping from the notforloan field into es to be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 09:13:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 07:13:45 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #5 from Jonathan Druart --- Sorry Marjorie but I don't manage to watch the video, vlc simply displays an image, nothing moves. Could you please describe the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 09:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 07:34:39 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #5 from Martin Renvoize --- I've posted a followup to the main api bug to showcase using $ref's to split up the specification file, that 'should' help with that side of things a bit. UI wise, I agree we need a good example implementation an I think AngularJS would be a great one to showcase here too. I'm not entirely sure that $resource is still the way to go with angular now, I've asked a colleague (whose spent the best part of the last year shoulder deep in angular) to come in and comment on angular best practice to help guide us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 09:41:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 07:41:12 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #150 from Jonathan Druart --- (In reply to Robin Sheat from comment #148) > (In reply to Jonathan Druart from comment #147) > > I don't understand the problem with the structure, you could have several > > mappings (it's an arrayref of hashrefs). > > Oh, yes, you're right. I missed that bit. > > > With this structure I could insert exactly the same data in the tables > > (except if I missed something...). > > It's just that it's not a natural representation from a database theory > point of view. Why are the various MARC forms lumped together like that? Why > should a schema change be necessary when (god forbid) a new flavour is > added? Actually, that could be important as if we want to add support for > different things into ES, say importing a feed from a journal provider or > whatever, you could use a flavour to mark how the source is mapped into > elasticsearch. Additionally, it promotes redundancy as you are forced to > repeat things to have all the required combinations, which always causes an > icky feeling :) Erk, of course! I did not c/p the correct structure I have in my document! It was: { biblio => { title => { # name label => 'Title', type => 'string', mappings => [ { suggestible => 1, facet => 1, sort => 0, marc_type => 'marc21', marc_field => '245a', }, { suggestible => 1, facet => 1, sort => 0, marc_type => 'unimarc', marc_field => '200a', }, [ and normarc of course :) ] ] }, } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 09:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 07:52:10 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14978 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 [Bug 14978] issues.itemnumber should be a unique key -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 09:52:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 07:52:10 +0000 Subject: [Koha-bugs] [Bug 14978] New: issues.itemnumber should be a unique key Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Bug ID: 14978 Summary: issues.itemnumber should be a unique key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 14069 Bug 14069 removed existing primary key on issues without questioning why one could exist. Note that the primary key was not in the kohastructure.sql and only existed on old DB. issues.itemnumber should be a unique key to avoid duplication of issues on the same item. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 09:52:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 07:52:11 +0000 Subject: [Koha-bugs] [Bug 13790] Add unique id issue_id to issues and old_issues tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14978 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:08:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #145 from Marcel de Rooy --- I am planning to look at this patch set tomorrow, but I still have: Applying: Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page fatal: sha1 information is lacking or useless (catalogue/detail.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:10:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:10:56 +0000 Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:14:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:14:59 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy --- - my $pastdate= sprintf("%-04.4d-%-02.2d-%02.2d", Add_Delta_YMD($year, $month, $day, 0, 0, -C4::Context->preference('HoldsToPullStartDate')||TWO_DAYS_AGO )); - $startdate = format_date($pastdate); + $startdate = $today - DateTime::Duration->new( days => C4::Context->preference('HoldsToPullStartDate') || 2 ); Replacing a constant by a hardcoded value is not an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:19:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:19:07 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:19:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:19:09 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 --- Comment #1 from Jonathan Druart --- Created attachment 43219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43219&action=edit Bug 14978: Add unique key constraint on issues.itemnumber The constraint might have existed before bug 14069. For these DB, this patch will restore it, for others, it will add it :) Test plan: > show create table issues; should not return "unique key itemnumber" Execute the updatedb entry twice > show create table issues; should return only one "unique key itemnumber" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:20:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:20:57 +0000 Subject: [Koha-bugs] [Bug 14069] Follow-up 13790: Fix database update to drop PK on issues/old_issues first In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14069 --- Comment #9 from Jonathan Druart --- I have restored the constraint on bug 14978, but I think the checkout will now make Koha explodes (the DB will raise on error). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:32:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:32:40 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:32:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:32:43 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42964|0 |1 is obsolete| | Attachment #43217|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 43220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43220&action=edit Bug 14924 - Remove C4::Dates from members/memberentry.pl This patch removes C4::Dates from members/memberentry.pl To test: - Apply patch - Add and edit patrons with and without birthdate as mandatory field (syspref BorrowerMandatoryField) - Verify that dates (birtdate, registration, expiration) display and are stored correctly Signed-off-by: Hector Castro Works as advertised. Tested with syspref BorrowerMandatoryField and table borrowers.dateofbirth Bug 14924 - (follow-up) Add date validation using eval This patch adds a date validation (see comment #3). To test: - Apply patch - Create a new user or edit an existing user - Try valid dates for date of birth - Try invalid dates as 0000-00-00 or 32/01/1970. You can can copy/paste such strings to the date field, ignore the warning message and submit. Verify that after submit you get a message "Date of birth is invalid" - Try the same with enrollement /expiry dates Signed-off-by: Hector Castro Works as advertised. Tested with invalid dates. Signed-off-by: Jonathan Druart Amended patch: I have splitted them to make them much more readable (some lines were removed then added). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:34:46 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com --- Comment #6 from Andrew Isherwood --- Hi all My first posting to the Koha community, exciting stuff! :) As Martin mentioned, I've been working with Angular for about a year, so I'm by no means an expert (Angular is a big beastie), I've got a good feel for ways to do things and how Angular "works". The $resource service is a nice wrapper around the $http service and enables you to create API resource objects that can be interacted with in the traditional CRUD methods. If you're starting from scratch and looking for a consistent way of accessing API resources then it's a good way to go. Although I'm up to my eyeballs at the moment (aren't we all), I'd be happy to offer any guidance if it's all needed. Cheers Andrew ------ Andrew Isherwood Software Developer PTFS Europe Limited Content Management and Library Solutions +44 (0) 20 8123 4257 email: andrew.isherwood at ptfs-europe.com skype: andrewisherwood.ptfseurope web: http://www.ptfs-europe.com/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:44:31 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Jonathan Druart --- Marc, I would prefer the first version, could be done with: my ( $yyyy, $mm, $dd ) = ( $today->year, $today->month, $today->day ); $value =~ s/YYYY/$yyyy/g; $value =~ s/MM/$mm/g; $value =~ s/DD/$dd/g; and avoid 1 call to output_string. Especially because it's how we did on bug 14950 for batchMod.pl (also the default values). But maybe we have an issue, the $today->day returns "8" instead of "08". I don't know what is the expected behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:55:10 +0000 Subject: [Koha-bugs] [Bug 14890] Remove C4::Dates from circ/bookcount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:55:13 +0000 Subject: [Koha-bugs] [Bug 14890] Remove C4::Dates from circ/bookcount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43196|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43221&action=edit Bug 14890 - Remove C4::Dates from circ/bookcount.pl This patch removes deprecated C4::Dates from circ/bookcount.pl To test: - Search for biblio with an item that has been checked out several times and that has been transferred - In left navigation click on 'Items' - In list of items click on 'View item's checkout history' - Verify that dates in 'Date arrived at current library' and in column 'Last seen' display properly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:55:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:55:18 +0000 Subject: [Koha-bugs] [Bug 14890] Remove C4::Dates from circ/bookcount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 --- Comment #4 from Jonathan Druart --- Created attachment 43222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43222&action=edit Bug 14890: Simplify processing to display a date with hours The KohaDates plugin does that, it's not necessary to split the output. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 10:56:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 08:56:01 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #12 from Jonathan Druart --- (In reply to Jonathan Druart from comment #11) > Amended patch: I have splitted them to make them much more readable > (some lines were removed then added). s/splitted/squashed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:05:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:05:31 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14950 --- Comment #15 from Marc V?ron --- Hi Jonathan, Would that be the same as the patch from comment #5, the first one signed-off by H?ctor? http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:05:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:05:31 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14922 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:09:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:09:54 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42199|0 |1 is obsolete| | --- Comment #146 from Jonathan Druart --- Created attachment 43223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43223&action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves The 2 modules C4::VirtualShelves and C4::VirtualShelves::Page are really badly coded and buggy. It became complicated to fix and enhance them. This rewrite will make the code more robust and the list feature will be easier to change. Some new modules are added to the Koha namespace (Koha::Virtualshelf, Koha::Virtualshelves, Koha::Virtualshelfshare[s] and Koha::Virtualshelfcontent[s]) to take advantage of Dbix::Class. The patchset fixes some bugs: 1/ Bug 6279 - Can't delete lists from the second page of lists in the OPAC 2/ The owner of a list should not need any permission to remove content from his lists. 3/ No feedback messages when actions are done Test plan: A) Intranet and OPAC 1/ Create more than 20 private and public lists with different users 2/ Edit some and confirm that the changes are taken into account 3/ Share some lists with other users 4/ Add / remove contents Be sure you have some lists with more than 20 items (to test the pagination) 5/ Play with permissions and confirm it works as expected. For private lists: They should not be viewed by anyone else, if they are not shared If they are shared (OPAC only): a. "Allow anyone else to add entries" Should allow the user with whom the list is shared to add entries. b. "Allow anyone to remove his own contributed entries." Should allow the user with whom the list is shared to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow the user with whom the list is shared to remove any entries. For public lists: They should be viewed by anyone else. a. "Allow anyone else to add entries" Should allow any user to add entries. b. "Allow anyone to remove his own contributed entries." Should allow any user to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow any user to remove any entries. 6/ Download and sent lists. 7/ Confirm that the "Add to" feature works as expected. 8/ Confirm that the "Add an item to" works as expected. 9/ Delete some lists. 10/ Print some lists and subscribe to the RSS feed (OPAC only) (with more than 20 items). 11/ Use the remove "Remove share" links. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:09:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:09:59 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42200|0 |1 is obsolete| | --- Comment #147 from Jonathan Druart --- Created attachment 43224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43224&action=edit Bug 14544: Get rid of GetShelf Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:03 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42201|0 |1 is obsolete| | --- Comment #148 from Jonathan Druart --- Created attachment 43225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43225&action=edit Bug 14544: Get rid of AddShelf Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:07 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42202|0 |1 is obsolete| | --- Comment #149 from Jonathan Druart --- Created attachment 43226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43226&action=edit Bug 14544: Get rid of DelShelf Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:12 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42203|0 |1 is obsolete| | --- Comment #150 from Jonathan Druart --- Created attachment 43227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43227&action=edit Bug 14544: Get rid of ModShelf Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42204|0 |1 is obsolete| | --- Comment #151 from Jonathan Druart --- Created attachment 43228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43228&action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:21 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42205|0 |1 is obsolete| | --- Comment #152 from Jonathan Druart --- Created attachment 43229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43229&action=edit Bug 14544: Get rid of GetAllShelves Signed-off-by: Koha Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:26 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42206|0 |1 is obsolete| | --- Comment #153 from Jonathan Druart --- Created attachment 43230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43230&action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf Bug 14544: Allow a user to delete his own contents Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:30 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42207|0 |1 is obsolete| | --- Comment #154 from Jonathan Druart --- Created attachment 43231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43231&action=edit Bug 14544: Make the intranet side independent of Page.pm Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42208|0 |1 is obsolete| | --- Comment #155 from Jonathan Druart --- Created attachment 43232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43232&action=edit Bug 14544: Get rid of GetBibliosShelves Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:44 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42210|0 |1 is obsolete| | --- Comment #157 from Jonathan Druart --- Created attachment 43234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43234&action=edit Bug 14544: Make the OPAC side independent of Page.pm Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). Bug 14544: Cosmetic: › should be a class divider Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:39 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42209|0 |1 is obsolete| | --- Comment #156 from Jonathan Druart --- Created attachment 43233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43233&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:49 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42211|0 |1 is obsolete| | --- Comment #158 from Jonathan Druart --- Created attachment 43235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43235&action=edit Bug 14544: Get rid of ShelfPossibleAction Bug 14544: (follow-up) Get rid of ShelfPossibleAction Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:53 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42212|0 |1 is obsolete| | --- Comment #159 from Jonathan Druart --- Created attachment 43236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43236&action=edit Bug 14544: Get rid of GetShelfContent Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:10:58 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42213|0 |1 is obsolete| | --- Comment #160 from Jonathan Druart --- Created attachment 43237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43237&action=edit Bug 14544: Get rid of GetSomeShelfNames Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:11:02 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42214|0 |1 is obsolete| | --- Comment #161 from Jonathan Druart --- Created attachment 43238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43238&action=edit Bug 14544: Move HandleDelBorrower to C4::Members Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:11:07 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42215|0 |1 is obsolete| | --- Comment #162 from Jonathan Druart --- Created attachment 43239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43239&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:11:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:11:12 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42216|0 |1 is obsolete| | --- Comment #163 from Jonathan Druart --- Created attachment 43240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43240&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:11:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42217|0 |1 is obsolete| | --- Comment #164 from Jonathan Druart --- Created attachment 43241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43241&action=edit Bug 14544: Fix regression on adding a new list The user should not be allowed to create a new list and get a friendly error message if he tries. The "New list" links are removed. Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:11:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:11:21 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42218|0 |1 is obsolete| | --- Comment #165 from Jonathan Druart --- Created attachment 43242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43242&action=edit Bug 14544: DB Changes: Set a default value for sortfield Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:11:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:11:25 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42638|0 |1 is obsolete| | --- Comment #166 from Jonathan Druart --- Created attachment 43243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43243&action=edit Bug 14544 - Handle database error when creating a shelf with DB admin account Signed-off-by: Jonathan Druart I don't think this is useful, it will be a mess if we have to check this case everywhere. But it works! I let the cut to the QAer or RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:12:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:12:31 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #167 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #145) > I am planning to look at this patch set tomorrow, but I still have: > > Applying: Bug 14544: Get rid of C4::VirtualShelves and > C4::VirtualShelves::Page > fatal: sha1 information is lacking or useless (catalogue/detail.pl). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:15:11 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #7 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > - my $pastdate= sprintf("%-04.4d-%-02.2d-%02.2d", Add_Delta_YMD($year, > $month, $day, 0, 0, > -C4::Context->preference('HoldsToPullStartDate')||TWO_DAYS_AGO )); > - $startdate = format_date($pastdate); > + $startdate = $today - DateTime::Duration->new( days => > C4::Context->preference('HoldsToPullStartDate') || 2 ); > > > Replacing a constant by a hardcoded value is not an improvement. A constant named TWO_DAYS_AGO does not make really sense... And is only used once. Feel free to use TWO_DAYS instead, if you prefer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:34:43 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #168 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #167) > (In reply to Marcel de Rooy from comment #145) > > I am planning to look at this patch set tomorrow, but I still have: > > > > Applying: Bug 14544: Get rid of C4::VirtualShelves and > > C4::VirtualShelves::Page > > fatal: sha1 information is lacking or useless (catalogue/detail.pl). > > Repository lacks necessary blobs to fall back on 3-way merge. > > Cannot fall back to three-way merge. > > Patches rebased against master. Thanks. Applies now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:44:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:44:35 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #1 from Mason James --- Created attachment 43244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43244&action=edit Bug 14830 - anonymous purchase suggestions are invisible/inaccessible in staff interface To test bug... 1/ set various suggestion sysprefs like so mysql> select variable, value from systempreferences where variable like '%sugg%'; +-------------------------------------+-------+ | variable | value | +-------------------------------------+-------+ | AllowPurchaseSuggestionBranchChoice | 0 | | AnonSuggestions | 1 | | OpacSuggestionManagedBy | 1 | | OPACViewOthersSuggestions | 0 | | suggestion | 1 | +-------------------------------------+-------+ 2/ create an generic ANON borrower for testing 3/ set 'AnonymousPatron' syspref to ANON's borrowernumber 4/ add a suggestion from the OPAC, without being logged in (ie: an anonymous suggestion) 2/ go to staff interface , fail to see suggestion :'( https://demo-admin.yourkoha.foo/cgi-bin/koha/suggestion/suggestion.pl 3/ apply patch... 4/ go to staff interface , see suggestion! :) (pix attached) https://demo-admin.yourkoha.foo/cgi-bin/koha/suggestion/suggestion.pl 5/ reward yourself with cake (optional) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:47:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:47:06 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #2 from Mason James --- this patch adds some SQL to display suggestion rows with a NULL branchcode, in the staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:48:52 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #3 from Mason James --- Created attachment 43245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43245&action=edit pix, after patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:50:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:50:07 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Priority|P5 - low |P3 Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:51:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:51:00 +0000 Subject: [Koha-bugs] [Bug 14839] 'anonymous' purchase suggestions are created with 'Anon' user's branchcode ignored, (NULL branchcode) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 --- Comment #5 from Mason James --- (In reply to Mason James from comment #4) > (In reply to Jonathan Druart from comment #2) > > Mason, > > If you plan to work on it, please assign you the bug. > > yes, will do i've attached my patch to BZ 14830 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:51:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:51:18 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:51:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:51:31 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 11:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 09:53:03 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43244|0 |1 is obsolete| | --- Comment #4 from Mason James --- Created attachment 43246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43246&action=edit Bug 14830 - anonymous purchase suggestions are invisible/inaccessible in staff interface To test bug... 1/ set various suggestion sysprefs like so mysql> select variable, value from systempreferences where variable like '%sugg%'; +-------------------------------------+-------+ | variable | value | +-------------------------------------+-------+ | AllowPurchaseSuggestionBranchChoice | 0 | | AnonSuggestions | 1 | | OpacSuggestionManagedBy | 1 | | OPACViewOthersSuggestions | 0 | | suggestion | 1 | +-------------------------------------+-------+ 2/ create an generic ANON borrower for testing 3/ set 'AnonymousPatron' syspref to ANON's borrowernumber 4/ add a suggestion from the OPAC, without being logged in (ie: an anonymous suggestion) 5/ go to staff interface , fail to see suggestion :'( https://demo-admin.yourkoha.foo/cgi-bin/koha/suggestion/suggestion.pl 6/ apply patch... 7/ go to staff interface , see suggestion! :) (pix attached) https://demo-admin.yourkoha.foo/cgi-bin/koha/suggestion/suggestion.pl 8/ reward yourself with cake (optional) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:04:25 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron --- Hi Alex, I tested in Opac: Purchase Suggestions Existing Biblio with item: Wachtmeister Studers erste F?lle by Friedrich Glauser Suggested: Wachtmeister Studers erste F?lle -> Duplicate messsage Wachtmeister Studer -> No message Wachtmeister Studers -> No message Wachtmeister Studers erste -> No Message Studers erste F?lle -> No message Combining full title with full Author Wachtmeister Studers erste F?lle Friedrich Glauser -> No Message Wachtmeister Studers erste F?lle Glauser, Friedrich -> No Message Combining full title with partial Author Wachtmeister Studers erste F?lle Glauser -> No Message So it seems to work with the full title only. Is this intended? Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:12:03 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy --- First chmod your opac logfile to 400. Second, try this test please: use Koha::Logger; my $logger = Koha::Logger->get({ interface => 'opac' }); $logger->warn('L4'); Without this patch, you will have no warning since the log is not writable. With your patch, the program will crash (on the following call on line 132 after calling _check_conf): Log::Log4perl->init_once($conf); The intention of the code in Logger.pm was just to prevent such a crash. This patch reintroduces it. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:18:22 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 --- Comment #4 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #0) > Also, the _check_conf subroutine will fail (return undef) if at least 1 path > is not correctly defined, which is not necessary: Yes it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:42:23 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #18 from Jonathan Druart --- Created attachment 43247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43247&action=edit Bug 14778: Make 3 tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:42:29 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #19 from Jonathan Druart --- Created attachment 43248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43248&action=edit Bug 14778: Make the installer test pass - use DBI missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:42:32 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #20 from Jonathan Druart --- Created attachment 43249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43249&action=edit Bug 14778: Set PrintError as it was before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:42:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:42:36 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #21 from Jonathan Druart --- Created attachment 43250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43250&action=edit Bug 14778: [DO NOT WORK] Try to make DBI:Mock pass but fail I need some help here, I don't understand what's happen. Some other tests are failing because they mock the db handler. Let's try with this easy one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 12:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 10:54:54 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #16 from Jonathan Druart --- I would prefer not to depend on something else than Koha::DateUtils. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:06:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:06:25 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 --- Comment #7 from Lari Taskula --- Created attachment 43251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43251&action=edit Bug 14912: (follow-up) Use priority sorting only if AdvancedSearchLanguagesSort is set to priority. This patch adds a system preference "AdvancedSearchLanguagesSort" that defines whether the drop-down list should be sorted by priority in AdvancedSearchLanguages or alphabetically like before. To test: -1. Set some languages into AdvancedSearchLanguages system preference 1. Go to advanced search and look at Languages drop-down list 2. Note that the list is in alphabetical order 3. Apply patches and run database update 4. Change system preference AdvancedSearchLanguagesSort to "by priority" 5. Repeat step 1 6. Note that the list is sorted like AdvancedSearchLanguages 7. Change system preference AdvancedSearchLanguagesSort to "alphabetically" 8. Repeat step 1 9. Note that the list is again in alphabetical order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:07:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:07:04 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:15:44 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23305|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 43252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43252&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:15:41 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:17:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:17:18 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43252|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall --- Created attachment 43253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43253&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:38:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:38:01 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #191 from Kyle M Hall --- (In reply to Martin Renvoize from comment #189) > Rebased my two patches (marked with 'Followup' keyword) and signed off on > prior patches. > > QA Note, let's get he patrons example right and not only define all fields > with descriptions but actually define types so validation may become useful. > > I'm happy to do this as another followup. Please do! Once you've got that dealt with I'll continue with QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 13:57:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 11:57:58 +0000 Subject: [Koha-bugs] [Bug 14979] New: Limit the number of "in process" purchase suggestions a patron can place at one time Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14979 Bug ID: 14979 Summary: Limit the number of "in process" purchase suggestions a patron can place at one time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org Patron's have the ability to place an unlimited number of suggestions from the OPAC. This has been an issue at some libraries where some patrons will place many dozens or more suggestions at once. Here's the idea: 1) Add new system preference "MaxOpenSuggestions" 2) Modify opac-suggestions.pl to count the number of suggesions the patron has that are not Accepted or Rejected 3) If that count has reached the number specified in MaxOpenSuggestions, deny the ability to place another suggestion with the message: "You have reached your limit of suggestions you can place at this time. Once the library has processed those suggestions you will be able to place more" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 14:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 12:34:58 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #6 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #5) > Sorry Marjorie but I don't manage to watch the video, vlc simply displays an > image, nothing moves. > Could you please describe the problem? Hi Jonathan, When i choose a renewal due date, it just hang forever, nothing happens. See capture attached. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 14:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 12:35:48 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #7 from Marjorie Barry-Vila --- Created attachment 43254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43254&action=edit renewal due date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:06:33 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:12:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:12:37 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:14:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:14:39 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43151|0 |1 is obsolete| | --- Comment #25 from Barton Chittenden --- Created attachment 43255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43255&action=edit Bug 14861 - [SIGNED OFF] Accession date comparison does not work in advanced search _Test plan_ Prerequisites: Make sure that you have an item with a valid dateaccessioned, and that the bib is indexed in zebra. For the purposes of explanation, I'm going to use the date '2011-09-07' 1) Go to advanced search in the staff client and choose 'Acquisition date (yyyy-mm-dd)' 2) Enter 2011-09-07 (or the date of your choice). 3) Click the search button - you should get your item in the search results. 4) Return to the advanced search screen and select Acquisition date again. 5) Enter a start and end date in the text field separated by ' - '. For example: 2011-09-01 - 2011-09-30 6) Click the search button -- this will return no results. 7) Apply the patch and copy etc/zebradb/ccl.properties to whatever directory is specified by the koha-conf.xml referenced by $KOHA_CONF. 8) Try the search again -- this will return the expected results Signed-off-by: Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:14:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:14:37 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:21:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:21:10 +0000 Subject: [Koha-bugs] [Bug 8875] Cataloging authorithy search plugin displays badly accented characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8875 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #5 from Gaetan Boisson --- Just tested and couldn't reproduce the issue. Is it still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:37:30 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #8 from Jonathan Druart --- Could you check the log file? Looks good here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:42:43 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 --- Comment #5 from Jonathan Druart --- I get Logger configuration error - Wrong permission for file /home/koha/var/log/opac-error.log at t.pl line 289. Can't open /home/koha/var/log/opac-error.log (Permission denied) at /usr/share/perl5/Log/Log4perl/Appender/File.pm line 124. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:47:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:47:47 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 15:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 13:50:39 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 --- Comment #6 from Jonathan Druart --- Forget last comment. Marcel, what do you suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:00:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:00:41 +0000 Subject: [Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:01:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:01:03 +0000 Subject: [Koha-bugs] [Bug 14890] Remove C4::Dates from circ/bookcount.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14890 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:01:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:01:28 +0000 Subject: [Koha-bugs] [Bug 14980] New: Add a page showing one news Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Bug ID: 14980 Summary: Add a page showing one news Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. It allows to create custom pages a little bit like : http://wiki.koha-community.org/wiki/Koha_as_a_CMS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:01:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:01:35 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:01:43 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:26:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:26:22 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #2 from Martin Persson --- Created attachment 43256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43256&action=edit Bug 8630 - Adlibris covers (intranet templates) Changes to staff interface (intranet) templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test results.tt * From the main intranet page, select "Search the catalog" and enter the title we added, "1984" and press "Search". * You should end up with the url: http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984 * The cover image should be shown in the leftmost column. * If cover is clicked, the full cover image should be shown. * Test detail.tt (continue from the search results used in prev. test) * Click on the title text, you should be sent to: http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 * The cover image should be shown on the right. * If clicked, the full cover should be shown. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:26:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:26:42 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #3 from Martin Persson --- Created attachment 43257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43257&action=edit Bug 8630 - Adlibris covers (intranet CSS) This defined two new CSS classes for use by the intranet templates. Apply this patch before doing the testing of "intranet templates". Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:26:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:26:54 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #4 from Martin Persson --- Created attachment 43258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43258&action=edit Bug 8630 - Adlibris covers (OPAC templates) Changes to OPAC templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test opac-results.tt * Search library catalog from OPAC for "1984". * You should be sent to: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984 * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * Test opac-detail.tt (continued from previous test's location) * Click on the title with cover (1984, ISBN: 9780451524935) * Cover should be displayed to the left in full size. * If clicked, should link to the full-size image. Test opac-results-grouped.tt * This template is only used if an external "grouping" server is setup and the syspref "OPACGroupResults" is set to "Use". * Personally I did not test this, b/c: terminally lazy * Test opac-showreviews.tt * Could not find any links to this location, manually enter it: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl * Image should be shown to the right in full size. * If clicked it should take you to the detail view with the comments tab opened. * Test opac-showreviews-rss.tt * Click on the RSS icon from previous test's start location. URL should be: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss * An image tag linking to the full-size image without any styling class should be present. * Test opac-user.tt * Click on your username to open: http://127.0.1.1/cgi-bin/koha/opac-user.pl * Covers should be shown for checked out items with CSS class: adlibris-cover * When clicked the destination should be the same as clicking the title column entry: opac-details.pl * Test opac-opensearch.tt * Click on "Advanced search" and enter "1984" then press "Search" * This search screen uses a different template. * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * If clicked, should link to the OPAC detail view. * Test opac-readingrecord.tt * Click on your logged-in name to go to your personal page. * Click on "Your reading history" tab on the left. http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl * Covers should be shown in leftmost column with CSS class: adlibris-cover * If clicked, should link to the same as the 'Title' link. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:27:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:27:11 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #5 from Martin Persson --- Created attachment 43259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43259&action=edit Bug 8630 - Adlibris covers (OPAC less changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:27:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:27:23 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 --- Comment #6 from Martin Persson --- Created attachment 43260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43260&action=edit Bug 8630 - Adlibris covers (OPAC minified CSS) This is the minified CSS updated via the lessc tool, separated into a standalone patch for ease of integration. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:29:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:29:26 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron --- Testing: - Check with mysql: I did not have branchcode = NULL in the suggestions table. - I tried to have one by removing syspref AnonymousPatron and then submit a suggestion from OPAC, it resulted in an software error on Suggestions.pm line 108 (Column 'suggestedby' canot be null). - I set the branchcode of one of the suggestions to NULL usimg mysql - I could reproduce the issue (the one with NULL branchcode did not show up) - With patch, the NULL-suggestion shows up, that is OK so far. More testing: - In the mysgl table I have following branchcodes: FFL, FFL, FFL, MPL, NULL, all with status ASKED - On the home page, I have "Suggestions pending approval: 5" - But not all suggestions show up when managing suggestions, only the ones with the same branchcode as the staff user (branch code FFL, all rights set, superlibrarian), plus the NULL one if the patch is applied. That is not consistent. The question is: Should the librarian be able to manage the suggestions for all branches? - If yes, all sggestions should display on Home > Acquisitions > Suggestions management (I think including the NULL branchcode ones). I would expect that for IndependentBranches = 'Don't prevent...' and superlibrarians. (That's the behaviour of this syspref for other things). - If no, the counter on the home page needs some adjustement to show the count of pending suggestions that are manageable for the staff users branch I would expect that for IndependentBranches = 'Don't prevent...' current staff user is not a superlibrarian. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:30:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:30:20 +0000 Subject: [Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Martin Persson --- Added a system preference to the "Enhanced content" tab and changed all templates in Intranet and OPAC to include this new cover source. The images needed some new CSS classes for scaling purposes, these were added to both OPAC and intranet CSS files. Separated into a bunch of patchsets in case someone deems there is a better way to handle parts of this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:38:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:38:58 +0000 Subject: [Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:43:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:43:29 +0000 Subject: [Koha-bugs] [Bug 14085] search biblionumber in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:58:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:58:32 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #138 from Jonathan Druart --- (In reply to Jesse Weaver from comment #134) > > b. The number of results is different with the same search on > > cataloguing/z3950_search.pl (5 pages vs 25!) > > > > Could I ask for the search you used? title: tintin on the BNF server. > > 5/ The favicon is missing on cataloguing/editor.pl > > > > Can't replicate, are you sure this isn't a local problem? Actually it's not missing, but it's the OPAC's one (white). On the intranet side, the favicon is the green one. > > 6/ I still have issue with mandatory/repeatable field. > > From the editor: > > 615 _ _ $a [Dropdown list] > > Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing > > mandatory subfield: $x > > > > From the (default) framework page: > > 615 centre d'int?r?t No No > > 2 code du syst?me d'indexation subfield ignored > > 3 num?ro de la notice d'autorit? subfield ignored > > a cat?gorie sujet Tab:1, Not repeatable, Not mandatory, | Auth > > value:interet > > m subdivision de la cat?gorie sujet sous forme cod?e subfield ignored > > n cat?gorie sujet sous forme cod?e subfield ignored > > x subdivision de la cat?gorie sujet subfield ignored > > > > 7/ I don't understand why the default framework is used. > > > > The default framework was used in order to not deal with the complexities of > switching frameworks after a record was loaded. And I am sure this will be one of the first demands from users :) > > 8/ Import record, then save. > > "Saving" is processing, nothing happen, browser freezes > > JS error: > > Error: Script terminated by timeout at: > > > > P at http://pro.koha-qa.vm/intranet-tmpl/lib/codemirror/codemirror-compressed. > > js:11:7546 > > [...] some others errors > > The record has 50 items. > > > > Could I ask for a play-by-play on this? (What server/search/record/etc.) I am going to attach the file to this bug report. (In reply to Jesse Weaver from comment #135) > > Ok forget this one, the subfield are ignored but marked as mandatory. > > Not what we should do in this case. > > The UNIMARC framework is very strange; what is the intended effect of an > ignored/mandatory subfield? > > > The checks done on the "normal" edition mode don't look to work correctly. > > What do you mean by this? I mean that both edition mode (the "normal"/current and the new editor) don't work similarly. Given an ignored subfield, if it is marked as mandatory, the normal view won't ask to fill it. The new editor won't save the record. I don't know what is the correct behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 16:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 14:59:56 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #139 from Jonathan Druart --- Created attachment 43261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43261&action=edit Importing this record will raise a JS timeout error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:06:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:06:58 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42956|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43262&action=edit [SIGNED-OFF]Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Signed-off-by: Hector Castro Works as advertised. Date displayed 2015-10-08 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:07:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:07:20 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:08:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:08:54 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:17:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:17:08 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:17:21 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:24:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:24:19 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #9 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #8) > Could you check the log file? > Looks good here. Sorry Jonathan, I tested it again and it do not work. I don't know if you want logs of action_logs or logs of browser? I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an error in console like: Uncaught SynthaxError : Unexpected token circulation.pl:180 Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:27:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:27:14 +0000 Subject: [Koha-bugs] [Bug 14981] New: Sample patron data broken by removal of ethnicity column Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Bug ID: 14981 Summary: Sample patron data broken by removal of ethnicity column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 10020 has removed the ethnicity columns in Koha, but they are still referenced in the sample_patrons.sql file. Attempting to install using the sample data results in this error: ERROR 1054 (42S22) at line 1: Unknown column 'ethnicity' in 'field list' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:27:19 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14981 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 [Bug 14981] Sample patron data broken by removal of ethnicity column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:27:19 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10020 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 [Bug 10020] Remove old code related to 'ethnicity' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:29:55 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #1 from Fridolin SOMERS --- Created attachment 43263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43263&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:33:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:33:02 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Fridolin SOMERS --- This patch is a POC, open to changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:33:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:33:40 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43198|0 |1 is obsolete| | Attachment #43199|0 |1 is obsolete| | Attachment #43200|0 |1 is obsolete| | Attachment #43201|0 |1 is obsolete| | Attachment #43202|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 43264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43264&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:33:47 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #22 from Kyle M Hall --- Created attachment 43265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43265&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:33:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:33:50 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #23 from Kyle M Hall --- Created attachment 43266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43266&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:33:54 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #24 from Kyle M Hall --- Created attachment 43267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43267&action=edit Bug 14610 - Add and update scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:33:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:33:56 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #25 from Kyle M Hall --- Created attachment 43268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43268&action=edit Bug 14610 - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 17:50:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 15:50:03 +0000 Subject: [Koha-bugs] [Bug 13864] Columns configuration - Late orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13864 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 18:06:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 16:06:31 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #151 from Jonathan Druart --- Found something else: In the sql file you have Heading-main vs Heading-Main. record-source vs Record-Source. For the first one, it's a typo (both for authorities). For the second one (it's a typo too, but), and for Local-number, you have the search_field.name which will be mapped with biblios and authorities fields. Does it make sense in your mind? In mine it's a bit weird (but maybe I need a pint). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 18:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 16:21:28 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 18:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 16:23:06 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 --- Comment #1 from Jonathan Druart --- Created attachment 43269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43269&action=edit Bug 14981: Remove ethnicity occurrences from sample patrons file Bug 10020 has removed these columns, the should be removed from the patron sample file. Test plan: Insert the files updated by this patch into a fresh DB, you shouldn't get any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 18:23:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 16:23:21 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 18:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 16:24:30 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 --- Comment #2 from Jonathan Druart --- Remove 2 NULL from the end for the 1 insert, then s|,NULL,NULL,'F',/,'F',/ s|,NULL,NULL,'M',/,'M',/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:31:24 +0000 Subject: [Koha-bugs] [Bug 14982] New: Remove C4::Dates from guided report wizard and dictionary Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Bug ID: 14982 Summary: Remove C4::Dates from guided report wizard and dictionary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:49:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:49:30 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14982 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 [Bug 14982] Remove C4::Dates from guided report wizard and dictionary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:49:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:49:30 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |veron at veron.ch Patch complexity|--- |Trivial patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:58:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:58:27 +0000 Subject: [Koha-bugs] [Bug 14952] web installer database errors on 3.18.11 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952 --- Comment #1 from Bob Ewart --- As Liz Rea reported on the mailing list, this problem is caused by the "STRICT_TRANS_TABLES" settings. If you turn it off, all the data is created as it should be -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:58:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:58:37 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43264|0 |1 is obsolete| | Attachment #43265|0 |1 is obsolete| | Attachment #43266|0 |1 is obsolete| | Attachment #43267|0 |1 is obsolete| | Attachment #43268|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 43270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43270&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:58:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:58:48 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #27 from Kyle M Hall --- Created attachment 43271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43271&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:58:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:58:51 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #28 from Kyle M Hall --- Created attachment 43272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43272&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:58:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:58:54 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #29 from Kyle M Hall --- Created attachment 43273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43273&action=edit Bug 14610 - Add and update scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:58:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:58:57 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #30 from Kyle M Hall --- Created attachment 43274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43274&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 19:59:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 17:59:38 +0000 Subject: [Koha-bugs] [Bug 14952] web installer database errors on 3.18.11 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14952 --- Comment #2 from Bob Ewart --- As Liz Rea reported on the mailing list, this problem is caused by the "STRICT_TRANS_TABLES" settings. If you turn it off, all the data is created as it should be -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:01:10 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42943|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 43275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43275&action=edit Bug 14915 - Use Font Awesome instead of Glyphicons for the staff intranet We should be using Font Awesome for our icons instead of Glyphicons, for the reasons discussed on bug 13696. Test Plan: 1) Apply this patch 2) Note all Glyphicons have been replaced with FA icons in the staff intranet 3) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/modules/ should give no results 4) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/includes/ should give no results Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:04:30 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 --- Comment #1 from Marc V?ron --- Created attachment 43276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43276&action=edit Remove C4::Dates from guided report wizard and dictionary This patch removes C4::Dates from files: - reports/guided_reports.pl - reports/dictionary.pl To test: - Go to Home > Reports > Guided reports wizard - Then go to 'View Dictionary' (menue at teh left) - Click 'New definition' and step through - In step 2. select e.g. borrowers - In step 3 select a date field - In step 4, select date range and test start / end dates - In step 5, verify that dates display properly - Save and verify that dates are insertet properly in sql definition - Go back to Home > Reports > Guided reports wizard - Step through the wizard and verify that it works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:08:38 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #6 from Kyle M Hall --- Created attachment 43277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43277&action=edit Bug 14915 [QA Followup] - Tweak '+' icon for serials-home -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:14:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:14:12 +0000 Subject: [Koha-bugs] [Bug 14983] New: tools/inventory.pl uses itemcallnumber rather than cn_sort to determine shelf order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14983 Bug ID: 14983 Summary: tools/inventory.pl uses itemcallnumber rather than cn_sort to determine shelf order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To replicate: 1) Find several items where cn_sort and itemcallnumber sort differently 2) Note the first and last values of your range when ordered by itemcallnumber. Make sure that cn_source is correct for all values of cn_sort. 3) Export the barcodes to a file, ordered by cn_sort. 4) Go to Tools > Inventory/Stocktaking 5) Choose your barcode file, and set inventory date to today's date 6) Specify the start and end values for itemcallnumber, from step 2). 7) Check 'Skip items on loan', 'Export to CSV file', 'Compare barcodes list to results' and 'Do not check in items scanned during inventory' * 8) Click submit. The resulting file will show "wrong place" everywhere that cn_sort differs from the itemcallnumber sort. * I don't know if any of these are relevant, but they're what I had checked when I ran my test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:32:02 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43270|0 |1 is obsolete| | Attachment #43271|0 |1 is obsolete| | Attachment #43272|0 |1 is obsolete| | Attachment #43273|0 |1 is obsolete| | Attachment #43274|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 43278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43278&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:32:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:32:09 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #32 from Kyle M Hall --- Created attachment 43279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43279&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:32:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:32:12 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #33 from Kyle M Hall --- Created attachment 43280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43280&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:32:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:32:15 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #34 from Kyle M Hall --- Created attachment 43281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43281&action=edit Bug 14610 - Add and update scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 20:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 18:32:18 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #35 from Kyle M Hall --- Created attachment 43282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43282&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 21:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 19:21:02 +0000 Subject: [Koha-bugs] [Bug 14984] New: send notice to patron when a item is available (after a requisition but not a suggestion Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14984 Bug ID: 14984 Summary: send notice to patron when a item is available (after a requisition but not a suggestion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 21:26:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 19:26:55 +0000 Subject: [Koha-bugs] [Bug 14984] -- In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14984 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|send notice to patron when |-- |a item is available (after | |a requisition but not a | |suggestion | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 21:49:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 19:49:00 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43276|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43283&action=edit Remove C4::Dates from guided report wizard and dictionary This patch removes C4::Dates from files: - reports/guided_reports.pl - reports/dictionary.pl - C4/Reports/Guided.pm To test: - Go to Home > Reports > Guided reports wizard - Then go to 'View Dictionary' (menue at teh left) - Click 'New definition' and step through - In step 2. select e.g. borrowers - In step 3 select a date field - In step 4, select date range and test start / end dates - In step 5, verify that dates display properly - Save and verify that dates are insertet properly in sql definition - Go back to Home > Reports > Guided reports wizard - Step through the wizard and verify that it works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 21:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 19:53:50 +0000 Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 22:29:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 20:29:04 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42955|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43284&action=edit [SIGNED-OFF]Bug 14925 - Remove C4::Dates from members/moremember.pl This patch removes C4::Dates from members/moremember.pl To test: - Go to Details page of several members - Verify that all dates display OK, including restrictions Signed-off-by: Hector Castro Works as advertised. All dates displayed OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 22:29:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 20:29:33 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 22:30:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 20:30:18 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 22:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 20:42:14 +0000 Subject: [Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #52 from Liz Rea --- This change might require documentation updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 22:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 20:59:50 +0000 Subject: [Koha-bugs] [Bug 14985] New: Remove C4::Dates from files in folder C4/*.pm (part one) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Bug ID: 14985 Summary: Remove C4::Dates from files in folder C4/*.pm (part one) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 23:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 21:05:33 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from files in folder C4/*.pm (part one) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #1 from Marc V?ron --- Created attachment 43285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43285&action=edit Remove C4::Dates from files in folder C4/*.pm (part one) This patch removes C4::Dates from following files in folder C4: - C4/Members.pm - C4/Reserves.pm - C4/Search.pm - C4/Utils/DataTables.pm - C4/Utils/DataTables/Members.pm - C4/VirtualShelves/Page.pm To test: -run tests as appropriate, - have a close look at the code changes - try to find regressions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 23:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 21:06:28 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14985 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 [Bug 14985] Remove C4::Dates from files in folder C4/*.pm (part one) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 23:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 21:06:28 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from files in folder C4/*.pm (part one) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |veron at veron.ch Blocks| |14870 Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 23:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 21:17:29 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42975|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43286&action=edit [SIGNED-OFF]Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Signed-off-by: Hector Castro Works as advertised. Date printed in PDF Ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 8 23:17:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 21:17:46 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 00:39:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 22:39:02 +0000 Subject: [Koha-bugs] [Bug 14986] New: Report Group and Subgroup Duplications Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14986 Bug ID: 14986 Summary: Report Group and Subgroup Duplications Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Created attachment 43287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43287&action=edit duplicated report The ability to create Report Groups and Report Subgroups on reports without a check of the authorised_value table causes a large list of authorised values. This large list of authorised values is not only difficult to administer within the authorised_value area of Koha, but it also defeats the purpose of an authorised_values list. Users are able to enter duplicated Groups and Subgroups in reports. Duplicated Groups do not appear as separate groups in the tabs, nor do the duplicates appear in the dropdown list for Groups. Duplicated Subgroups (and perhaps Groups) also cause 1 report to appear multiple times in the listing of Reports. (attached image) But the duplicated authorised_value does not appear in the Subgroup list to select. If free text is allowed, before adding to the authorised_value table, the system needs to first verify if the Group or Subgroup already exists and if so, notify the user that a group or subgroup already exists. Further storing the "report group" in the authorised_value table lib_opac field makes no sense and is not intuitive to the user if they are to create Subgroups in the Authorised Value module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 01:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 23:33:44 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14987 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 01:33:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 08 Oct 2015 23:33:44 +0000 Subject: [Koha-bugs] [Bug 14987] New: patron card creator not displaying correct cardnumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Bug ID: 14987 Summary: patron card creator not displaying correct cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Actually, I'm not entirely sure what the context of "cardnumber" is on edit-batch - is it the number of the card being printed? Is it supposed to be the cardnumber of the borrower? I admit to not having the chance to really dig up what it's supposed to be but it doesn't really make sense to me as it stands. I think it should either be the cardnumber of the borrower (i.e. the barcode that would be printed) or explicitly labelled something that is not "cardnumber" if it's something else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 03:44:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 01:44:56 +0000 Subject: [Koha-bugs] [Bug 14804] Software error while removing duplicates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14804 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- Hi Joonas, I'm not able to replicate this issue on current master. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 04:14:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 02:14:20 +0000 Subject: [Koha-bugs] [Bug 4115] print a batch of patron cards from an import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4115 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 04:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 02:17:40 +0000 Subject: [Koha-bugs] [Bug 14988] New: Patron import tool -- add option to match on borrowernumber Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14988 Bug ID: 14988 Summary: Patron import tool -- add option to match on borrowernumber Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org In the patron import tool, is there a reason why the borrowernumber isn't listed as a match option, especially in cases when you're overwriting data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 04:18:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 02:18:44 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #152 from Robin Sheat --- (In reply to Jonathan Druart from comment #150) > Erk, of course! > I did not c/p the correct structure I have in my document! OK, yeah, that's a fair bit better :) But you still have an amount of duplication, for example when two search fields come from one marc field, you'll have to repeat the marc field. I don't know if that's good or bad really, but from a database normalisation point of view, it's bad (not seriously so though.) But between what's there now (including having moved the attributes appropriately), and what you're suggesting, I don't have particularly strong feelings. If you think it'll make other parts easier, then go with it. Changing the schema is pretty easy really, there's only a few places it touches. (In reply to Jonathan Druart from comment #151) > Found something else: > In the sql file you have Heading-main vs Heading-Main. record-source vs > Record-Source. > For the first one, it's a typo (both for authorities). > For the second one (it's a typo too, but), and for Local-number, you have > the search_field.name which will be mapped with biblios and authorities > fields. > > Does it make sense in your mind? In mine it's a bit weird (but maybe I need > a pint). It's OK to have the same field for authorities and biblios, they're totally different indices. As for the capitalisation stuff, there was a period when I wanted everything to be lower case before I discovered that would cause many things to break. So there may be some leftovers from that. Or just typos. What really ought to happen is a big go-over where the mapping is generated from scratch from the zebra files. Probably in an automated fashion. Mostly these mappings are there to get something functional out of it, it'll be a bit more work to make them actually correct :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 04:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 02:23:47 +0000 Subject: [Koha-bugs] [Bug 14989] New: Patron import tool -- required fields list missing surname Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14989 Bug ID: 14989 Summary: Patron import tool -- required fields list missing surname Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org In the patron import tool, the Notes area includes this comment: 'The fields 'branchcode' and 'categorycode' are required and must match valid entries in your database.' I didn't include surname in an upload, and received this error: "Line 2 Critical field "surname" missing", but that field isn't listed in the Notes area. Should the surname also be listed in the notes area as a required field be or is this a bug and the surname shouldn't be required in an upload? I wondered if the patron import tool might be also be using the fields in our BorrowerMandatoryField sys pref, which includes the dateofbirth|surname|cardnumber|firstname fields, but in the next upload test, I only included branchcode, categorycode, cardnumber, and surname fields in the upload, and the file uploaded successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 05:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 03:57:13 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron --- Card number is the position number in the batch. It comes from: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt Line 215 [% SWITCH header_field.field_label -%] [% CASE "Card Number" -%] Card number ^----------------------- patroncards/edit-batch.pl Line 50 my $display_columns = [ {_card_number => {label => 'Card Number', (...) ^---------------------- Line 138 get_card_summary ^---------------------- C4/Creators/Lib.pm get_card_summary: This function returns an arrayref whose elements are hashes containing the label_ids of current cards along with the item count Line 367 : my $card_number = 0; (...) foreach my $item (@{$params{'items'}}) { $card_number++; (...) my $card_summary->{'_card_number'} = $card_number; Fazit: Quick string fix would be to change edit-batch.cc More comprensible / sustainable fix would be to change edit-batch.pl and Lib.pm as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 06:29:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 04:29:18 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #2 from Marc V?ron --- Typo: Quick string fix would be to change edit-batch.cc ^^ edit-bach.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 06:38:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 04:38:19 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #3 from Liz Rea --- Ah right. Well that's still a little silly. I'm doing heaps of stuff in there atm, maybe I'll fix it. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 07:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 05:55:53 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:06:24 +0000 Subject: [Koha-bugs] [Bug 14984] -- In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14984 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |m.de.rooy at rijksmuseum.nl Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:06:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:06:36 +0000 Subject: [Koha-bugs] [Bug 14984] -- In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14984 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:07:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:07:25 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #169 from Marcel de Rooy --- QA: Looking at this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:08:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:08:38 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:32:39 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #4 from Marc V?ron --- Some more findings: In label batches, the column is called 'Label number', I think the internals are similar to patron cards. The patron cards and labels are printed in this order. It would be a good idea to have the same column name for both. Maybe something like 'Item Number'. 'Position' or 'Batch position' would collide with the meaning of 'Position' while exporting labels: "Enter starting label position (PDF)" i.e. the position where the first batch item will be printed on the paper / printing form (see Bug 8796). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:37:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:37:55 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #5 from Liz Rea --- Hm, but you can't change it, and it is basically the order the items are added... Idk, I suppose I'm questioning why we need to display it at all. It would, in fact, be good to make it consistent between the label creator and patron card creator. That is if we don't remove the display entirely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 08:56:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 06:56:40 +0000 Subject: [Koha-bugs] [Bug 4858] Ability to Charge for Print Notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4858 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 09:08:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 07:08:54 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #7 from Jonathan Druart --- (In reply to Kyle M Hall from comment #6) > Created attachment 43277 [details] [review] > Bug 14915 [QA Followup] - Tweak '+' icon for serials-home There are certainly some others I have not found. I also tested for a few minutes. I think we need either another signoff (the tester must test a lot of pages and compare them with master) or wait for the beginning of the next release cycle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 09:19:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 07:19:04 +0000 Subject: [Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987 --- Comment #6 from Marc V?ron --- I also was thinking about not displaying this column. Hmm, we can sort the colums e.g. alphabetically by name (in the table only, not for printing), so it might be needed to switch back to the order 'how I added items'. It would be a big enhancement (and quite a task) - to have te possibility to print in different orders - to be able to move an item inside the 'added' batch position Hmm, at the moment I propose to change the template files only (string change for the headers to avoid user confusion) and to postpone the rest. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 09:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 07:23:32 +0000 Subject: [Koha-bugs] [Bug 13791] Plack - Out of the box support on packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #49 from Magnus Enger --- Traditionally, changes to the koha-*scripts have been backported to stable releases, so that the tools around package installations are the same, no matter what version they are running. Could/should this be considered for the present bug too, or is it too big a leap to incorporate it into the stable branches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 09:37:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 07:37:05 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #3 from Alex Arnaud --- Hello Marc, I used C4::Search::FindDuplicate which seems to require almost the full title / author. Either we fix findDuplicate to make it more flexible or we create an other subrutine (using simpleSearch ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 09:56:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 07:56:04 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 09:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 07:56:39 +0000 Subject: [Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |gaetan.boisson at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:10:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:10:55 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43284|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43288&action=edit Bug 14925 - Remove C4::Dates from members/moremember.pl This patch removes C4::Dates from members/moremember.pl To test: - Go to Details page of several members - Verify that all dates display OK, including restrictions Signed-off-by: Hector Castro Works as advertised. All dates displayed OK Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:10:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:10:52 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:12:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:12:54 +0000 Subject: [Koha-bugs] [Bug 14990] New: Make the date formatting template side - moremember.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Bug ID: 14990 Summary: Make the date formatting template side - moremember.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:13:59 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14925 --- Comment #1 from Jonathan Druart --- I wrote a qa followup for bug 14925, but I would like to get a signoff on it. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 [Bug 14925] Remove C4::Dates from members/moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:13:59 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14990 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 [Bug 14990] Make the date formatting template side - moremember.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:15:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:15:54 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:15:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:15:56 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 --- Comment #2 from Jonathan Druart --- Created attachment 43289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43289&action=edit Bug 14990: Format the date template-side for moremember Test plan: print slip and show the member detail page, the 3 dates date of birth, date enrolled and date of expiry should be displayed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:23:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:23:16 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- (In reply to H?ctor Eduardo Castro Avalos from comment #4) > Signed-off-by: Hector Castro > Works as advertised. Date displayed 2015-10-08 Yes but YYYY-MM-DD is the iso format. If you change your pref to something else, it will be the iso format too. So the patch does not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:26:49 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:26:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:26:52 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #6 from Jonathan Druart --- Created attachment 43290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43290&action=edit Bug 14926: Format the date according to the dateformat syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:27:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:27:25 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #7 from Jonathan Druart --- Please try again with the last patch, and don't forget to change your dateformat pref to something else than iso :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:33:41 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:33:43 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43286|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43291&action=edit Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm This patch removes C4::Dates from: - acqui/pdfformat/layout2pages.pm - acqui/pdfformat/layout2pagesde.pm - acqui/pdfformat/layout3pages.pm - acqui/pdfformat/layout3pagesfr.pm To test: - Apply patch - Go to Home > Acquisitions > [Vendor] > Basket groups - Print a basket (order) - Verify that the current date is formatted respects syspref 'dateformat' - Do the same with syspref 'OrderPdfFormat' set to the four different choices Signed-off-by: Hector Castro Works as advertised. Date printed in PDF Ok Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:40:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:40:23 +0000 Subject: [Koha-bugs] [Bug 14804] Software error while removing duplicates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14804 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Joonas Kylm?l? --- (In reply to Liz Rea from comment #1) > Hi Joonas, > > I'm not able to replicate this issue on current master. > > Cheers, > Liz Me neither, anymore. I guess something fixed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:46:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:46:12 +0000 Subject: [Koha-bugs] [Bug 14991] New: Add search main heading ($a only) to authority search, reword and clarify Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 Bug ID: 14991 Summary: Add search main heading ($a only) to authority search, reword and clarify Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gaetan.boisson at biblibre.com QA Contact: testopia at bugs.koha-community.org At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both patches offer: Search main heading ($a only) Search main heading Search all headings Search entire record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:47:20 +0000 Subject: [Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add search main heading ($a |Reword, clarify and add |only) to authority search, |consistency to authority |reword and clarify |search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:47:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:47:32 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:47:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:47:37 +0000 Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Joonas Kylm?l? --- (In reply to Jonathan Druart from comment #2) > Bug 9809 already updated all calls to AddReserve, to prevent a future change > again it could worth to change the prototype of this subroutine to make it > get a hashref. Attachment 42198 is now obsolete, right? Shall we create a new bug report for the hashref change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:48:00 +0000 Subject: [Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 10:52:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 08:52:24 +0000 Subject: [Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:12:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:12:43 +0000 Subject: [Koha-bugs] [Bug 14992] New: New options and clarification for authority search modes dropdown Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992 Bug ID: 14992 Summary: New options and clarification for authority search modes dropdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: gaetan.boisson at biblibre.com QA Contact: testopia at bugs.koha-community.org Right now the options for searching in the authorities in the dropdown menu are confusing a lot of users. They are: Contains Starts with Is exactly What they actually do is: "Contains" searches for all the terms entered, in any order, with a right truncature. "Starts with" searches for all the terms entered, in that order, with a right truncature. The matching subfield itself doesn't have to start with the terms entered. If you search for "John", "Cash, Johnny" will be a valid result. (This is the most confusing option right now.) "Is exactly" searches for all the terms entered, in that order, without a truncature. The whole subfield doesn't have to match the phrase entered by the user though, so if you search for "Johnny", "Cash, Johnny" will be a valid result, more confusingly "Smith-Cash, Johnny" will be a valid result if you search for "Cash, Johnny". This patch will change the options offered so that they are: "with truncature, in any order" (what "contains" does right now) "without truncature, in any order" (new option, all the entered terms exactly as they were entered, in any order) "without truncature, in that order" (what "is exactly" does right now) "Is exactly" (new option, there is a subfield that matches exactly the entered sequence, the whole subfield has to match) The current "Starts with" will be removed as there doesn't seem to be a way of searching for "the subfield starts with" (See bug 11158). What it does right now would be "with truncature, in that order" but i cannot think of a useful case for this. (It allows for searching for "Cas John" and finding "Cash, Johnny".) If someone sees a reason to keep it, then we will reword it to "with truncature, in that order". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:13:02 +0000 Subject: [Koha-bugs] [Bug 14992] New options and clarification for authority search modes dropdown In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14991 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:13:02 +0000 Subject: [Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14992 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:16:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:16:26 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #6 from Magnus Enger --- Wouldn't it make sense to also document this new feature in the POD of C4/SMS.pm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:28:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:28:04 +0000 Subject: [Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029 --- Comment #7 from Magnus Enger --- How will this work for a Debian-package based installation that serves multiple Koha instances? There will only be one YAML file, right? So it is not possible to have different settings for different instances? For SMS::Send::Telenor (https://github.com/eskaaren/SMS-Send-Telenor) it is possible to pass in a sender, but that will have to be a different sender for each Koha instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:35:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:35:03 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:35:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:35:06 +0000 Subject: [Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41436|0 |1 is obsolete| | --- Comment #6 from Joonas Kylm?l? --- Created attachment 43292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43292&action=edit Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) Works as expected This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 11:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 09:53:16 +0000 Subject: [Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 --- Comment #4 from Jonathan Druart --- no, just submit another patch with the call updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 12:19:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 10:19:23 +0000 Subject: [Koha-bugs] [Bug 14993] New: rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 Bug ID: 14993 Summary: rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org This is due to implicit perl programming. Avoid doing this! mkdir $bdir || die "Error $!"; TO REPLICATE: 1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location is) 2. run rebuild_zebra.pl -b -a -r -x -v 3. Observe how rebuild_zebra.pl tells that it has rebuilt all the missing directories. 4. cd /home/koha/koha-dev/var/lib/zebradb/biblios 5. No such directory??? 6. You wait for several hours to reindex your zebradb to find that nothing works :( AFTER THIS PATCH: 1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location is) 2. run rebuild_zebra.pl -b -a -r -x -v 3. Observe how rebuild_zebra.pl tells that it couldn't create missing directories. A (possibly) better fix would be to recreate the top two directories from the path, but no point patching a dead horse, since ElasticSearch will be here soon :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 12:19:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 10:19:46 +0000 Subject: [Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 43293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43293&action=edit Bug 14993 - rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die This is due to implicit perl programming. Avoid doing this! mkdir $bdir || die "Error $!"; TO REPLICATE: 1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location is) 2. run rebuild_zebra.pl -b -a -r -x -v 3. Observe how rebuild_zebra.pl tells that it has rebuilt all the missing directories. 4. cd /home/koha/koha-dev/var/lib/zebradb/biblios 5. No such directory??? 6. You wait for several hours to reindex your zebradb to find that nothing works :( AFTER THIS PATCH: 1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location is) 2. run rebuild_zebra.pl -b -a -r -x -v 3. Observe how rebuild_zebra.pl tells that it couldn't create missing directories. A (possibly) better fix would be to recreate the top two directories from the path, but no point patching a dead horse, since ElasticSearch will be here soon :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 12:20:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 10:20:13 +0000 Subject: [Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 12:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 10:33:12 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #10 from Jonathan Druart --- (In reply to Marjorie Barry-Vila from comment #9) > (In reply to Jonathan Druart from comment #8) > > Could you check the log file? > > Looks good here. > > Sorry Jonathan, I tested it again and it do not work. > > I don't know if you want logs of action_logs or logs of browser? > > I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an > error in console like: > Uncaught SynthaxError : Unexpected token circulation.pl:180 > > Marjorie I was asking for the Koha log file, on the server. Could you confirm you don't get this error without the patch and that your pref IntranetUserJS is empty? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 12:59:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 10:59:11 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com --- Comment #3 from Fiona Borthwick --- One of our customers reported that they were not receiving these welcome email messages either. As it turns out they leave the username and password fields blank and Koha generates them upon saving. So in effect I suppose that this is a 2 stage registration too but it would be nice if the email could be sent. After all they want the username and password generated automatically for a reason. It also makes sense that an email is sent if username and password are generated automatically as the borrower will need to know this information as it is not entered manually. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:03:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:03:28 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:03:31 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42979|0 |1 is obsolete| | Attachment #43180|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 43294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43294&action=edit Bug 14515: Add biblioitems to messages in C4/Reserves.pm http://bugs.koha-community.org/show_bug.cgi?id=14515 Signed-off-by: Danielle Aloia Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:03:34 +0000 Subject: [Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 --- Comment #8 from Jonathan Druart --- Created attachment 43295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43295&action=edit Bug 14515 (QA Followup) fix letter.pl available fields. Add bibliotiems to the 'available fields' list for module 'Holds' (aka reserves). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:05:36 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |liz at catalyst.net.nz --- Comment #3 from Jonathan Druart --- This one fixes a regression on stable branches 3.20.x and 3.18.x and should be backported on the next release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:27:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:27:15 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Theodoros Theodoropoulos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod at lib.auth.gr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:30:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:30:58 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #170 from Marcel de Rooy --- Created attachment 43296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43296&action=edit Bug 14544: [QA Follow-up] Fix warning about transaction When running Virtualshelves.t, you have this warning: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. By moving the DBI lines after creating the TestBuilder object, the warning will be gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:42:23 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:42:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:42:23 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13995 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:43:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:43:43 +0000 Subject: [Koha-bugs] [Bug 13995] Proper Exception handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 --- Comment #18 from Marcel de Rooy --- Bug 14544 also introduces a Koha::Exceptions module. Has there been any interaction between the authors about the road to follow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 13:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 11:54:10 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #171 from Marcel de Rooy --- QA Comment: Great job !!! Lot of work involved. Still have some points for consideration: OPAC -- View contents of a list -- Send shelf - Crash Can't call method "can_be_viewed" on an undefined value at /home/koha/testclone/opac/opac-sendshelf.pl line 55. *BLOCKER* OPAC - View contents of a list - Sort by callnumber - Bang DBIx::Class::ResultSet::next(): Unknown column 'itemcallnumber' in 'order clause' at /home/koha/testclone/opac/opac-shelves.pl line 236 *BLOCKER* OPAC - Lists- Open a shared list where you do not have permission to remove items of someone else. Try to remove such an item. No success, but no warning too! IIRC There was a warning in the past about some items not deleted.. Now try to remove a item you added yourself to that list while having permission to remove your own entries. This does not work ! No items are deleted, no message. I am inclined to see this last point as a *BLOCKER* too. OPAC - View list - Delete your own item while the perms are ADD or DDD. Should not be possible. But the owner is able to now. This is change of behavior and not consistent with the wording of those permissions "Do not allow anyone to remove his own contributed entries" (including your own!). I would view it as a sort of Readonly list where you cannot accidentally delete your own items. (Note however that adding is still possible.) I am inclined to see this last point as a *BLOCKER* too (but I may not be completely neutral here :) + # FIXME + # This does not make sense, but it's has been backported from DelFromShelf. + # Why shouldn't we allow to remove his own contribution if allow_delete_other is on? Code Exceptions.pm module comes in now with a dependency Exception::Class. The description => "poeut" still needs some attention apparently :) Not sure what it means btw.. Although this looks good to me on itself, this dev should probably better have gone on its own report. Note there is another report too (13995). It kind of creeps in now. OPAC - Share a list - Enter email address - Return to your lists: This list does not exist ?? op=view && category=1. Adjust the URL? OPAC - I shared a list with AAD perms. The other user could add a few entries. After that removed the share. Now come back as owner of the list and try to remove one item of yourself and one of the other user. You will get the message: The item has been removed from the list. This is not completely true: You could only remove one item; the other is not permitted. OPAC - Create a new list - Starts with permissions D D D - Would it not be better to default to D A D ? Note that if I create a list with save to new list, it does default to DAD. So this is a minor inconsistency.. OPAC - View a list: For a list with ADD or DDD perms, the button Remove could be hidden or disabled? Might be the case now too btw. OPAC Detail - List(s) this item appears in: [nothing filled while expected] I click from view a (private) list on one entry. So go to opac detail. Should I expect that list to be mentioned now? It is not. Staff - View public lists [Related to another report] With the delete public lists permission I can delete the public list of another user. OK The staff user probably has a good reason to do so. Just noting that it would perhaps be more friendly to switch it to Private instead of a rigourous Delete? Code in opac-addbybiblionumber.pl: HandleSelectedShelf: Empty TODO in an else branch. Noting for the record. Code t/db_dependent/Utils/Datatables_Virtualshelves.t and C4/Utils/DataTables/VirtualShelves.pm This is only justified/used by svc/virtualshelves/search Isn't this the time to move this svc script to Koha::Virtualshelves too ? Or at least on another report ? Database design: Do we still need (or use) virtualshelfcontents.flags ? Could a dbrev remove it now? An observation (which could be considered as outside the scope): Add an item to the list with a barcode (in staff) is somewhat strange. You cannot add items, only biblios. This is current situation already. Just for completeness :) Moving the status to FQA now to reflect the need for some adjustments/clarifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:04:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:04:42 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #27 from Kyle M Hall --- With 540 checkouts I get the following with your script: on master: real 0m1.023s user 0m0.980s sys 0m0.044s with bug 8483: real 0m1.032s user 0m0.980s sys 0m0.052s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:14:29 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Severity|enhancement |normal --- Comment #29 from Paul Poulain --- changing severity : this is a bug for non english Koha (and when you demo & try to convince a library to choose Koha, this has a negative result) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:17:29 +0000 Subject: [Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:21:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:21:53 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #12 from Kyle M Hall --- > There is a difference between none_available (but eventually some may) vs. > comment #2's "{item} is not allowed to be placed on hold". Is there a way to > check for this? If I understand you correctly, the answer is no at this time. That would be outside the scope of this bug. > Similarly there is a minor difference between a borrower who has too many > holds (non-zero), and one who isn't allowed to place any at all, as per my > understanding of comment #1. That is correct, and this patch deals with that situation. The patron will get different messages if they exceed the maxreserves vs they can't place a hold on any of the items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:46:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:46:53 +0000 Subject: [Koha-bugs] [Bug 14974] Use the REST API for cities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #7 from Kyle M Hall --- Thanks for your input Andrew! I'm sure any guidance and guidelines you may suggest would be greatly appreciated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:53:13 +0000 Subject: [Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 --- Comment #1 from Gaetan Boisson --- Created attachment 43297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43297&action=edit BUG 14991 Improve consistency of authority search At the moment we can search authorities from two places: authorities-home.pl and auth_finder.pl (while cataloguing). The auth_finder.pl page offers searching specifically in the $a of the main heading, while the authorities home page doesn't. Additionally, the wording and order of the options is different. authorities-home.pl has: Search main heading Search all headings Keyword search while auth_finder.pl has: Main entry ($a only) Main entry Anywhere Heading match This patch will add some consistency so that both pages offer: Search main heading ($a only) Search main heading Search all headings Search entire record Test plan: - apply patch - go to authorities home - check that previous searches are still working - check that the new ($a only) search is working - go to auth finder (from cataloguing) - check that searches are still working - check that we do have the same wording in both pages and that forms are now consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 14:53:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 12:53:29 +0000 Subject: [Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:11:32 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Kyle M Hall --- (In reply to Colin Campbell from comment #29) > having applied the patch against current master server terminates when > processing an issue transaction I have been unable to reproduce this on master. It seems unlikely to be related to this patch since this patch only modifies the checkins, and not checkouts. Can you please retest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:21:07 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43253|0 |1 is obsolete| | --- Comment #42 from Cindy Murdock Ames --- Created attachment 43298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43298&action=edit [SIGNED OFF] [patch] Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Patch applied without error and test plan produced expected result of a fine equalling the replacement cost price. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:22:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:22:09 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Cindy Murdock Ames changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:29:14 +0000 Subject: [Koha-bugs] [Bug 9150] Add authorities search sorts by id and relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com Summary|Add authorities search sort |Add authorities search |by id |sorts by id and relevance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:31:30 +0000 Subject: [Koha-bugs] [Bug 9150] Add authorities search sorts by id and relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150 --- Comment #1 from Gaetan Boisson --- Sorting by id seems to be what the "none" choice for sorting does. It would be practical to let the user choose this explicitly, and choose between older to newer or newer to older. It would also be interesting to have a "relevance" sorting option available, similar to what we have in bibliographic search. Searching for "history" would then bring up the "History" record higher than "European history". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:38:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:38:26 +0000 Subject: [Koha-bugs] [Bug 14992] New options and clarification for authority search modes dropdown In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:39:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:39:18 +0000 Subject: [Koha-bugs] [Bug 9150] Add authorities search sorts by id and relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:40:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:40:28 +0000 Subject: [Koha-bugs] [Bug 14994] New: Add RSS/Atom feed proxy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14994 Bug ID: 14994 Summary: Add RSS/Atom feed proxy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: xarragon at gmail.com QA Contact: testopia at bugs.koha-community.org Some libraries uses a separate blog on an external site such as blogspot.com. We are working on enhancements to make Koha a fully-featured blog in the future, removing that need. The external blogs publishes the content as RSS/Atom feeds which can then be pulled to the OPAC via some Javascript and/or Yahoo Pipes. Pipes was recently decomissioned and I am now trying to solve this issue. I do not have full information yet. At present I have created a small web proxy that pulls RSS/Atom from an external source via LWP. This allows us to overcome the same-origin limitation. There are security considerations for this that must be looked at. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 15:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 13:40:25 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 43299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43299&action=edit Bug 14925: (QA followup) tidy code block Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:30:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:30:07 +0000 Subject: [Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:30:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:30:27 +0000 Subject: [Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:30:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:30:48 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #8 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #7) > Please try again with the last patch, and don't forget to change your > dateformat pref to something else than iso :) Okidoki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:32:02 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 --- Comment #11 from Marjorie Barry-Vila --- (In reply to Jonathan Druart from comment #10) > (In reply to Marjorie Barry-Vila from comment #9) > > (In reply to Jonathan Druart from comment #8) > > > Could you check the log file? > > > Looks good here. > > > > Sorry Jonathan, I tested it again and it do not work. > > > > I don't know if you want logs of action_logs or logs of browser? > > > > I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an > > error in console like: > > Uncaught SynthaxError : Unexpected token circulation.pl:180 > > > > Marjorie > > I was asking for the Koha log file, on the server. > Could you confirm you don't get this error without the patch and that your > pref IntranetUserJS is empty? I don't know how see koha log file on the server, action_logs? In my version 3.18.04, when I make a renewal, it works and I have no error in console but hour of date is not considered. Sorry. Maybe someone else can test on a sandbox? The problem may come from me. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:33:26 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43098|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43300&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:34:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:34:00 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:50:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:50:37 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43290|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 43301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43301&action=edit [SIGNED-OFF]Bug 14926: Format the date according to the dateformat syspref Signed-off-by: Hector Castro Works as advertised. Tested with the three values from dateformat syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 16:51:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 14:51:00 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 17:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 15:04:22 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This should be QAed please. It is not a blocker for 3.22 as the Plack integration it introduces is at package-level, but worth having both in sync. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 18:15:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 16:15:21 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42977|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 43302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43302&action=edit [SIGNED-OFF]Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Signed-off-by: Hector Castro Works as advertised. Tested with dateformat syspref Dates in planning by months not needed to be on iso format, aqplan.pl uses instead Date::Calc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 18:15:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 16:15:44 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 18:24:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 16:24:16 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 18:29:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 16:29:30 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42989|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Comment on attachment 42989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42989 Bug 14903 - Remove C4::Dates from circ/circulation.pl New patch will follow with C4/Dates.pm included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 18:59:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 16:59:46 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #6 from Marc V?ron --- Created attachment 43303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43303&action=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more) Patch to remove deprectated C4::Dates from: - circ/circulation.pl - C4/Circulation.pm - koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Search for regressions - prove -v t/db_dependent/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:00:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:00:09 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:19:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:19:10 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:19:18 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:30:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:30:24 +0000 Subject: [Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not be required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:31:24 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration and Zebra info to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:34:09 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 19:34:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 17:34:32 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 20:14:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 18:14:42 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42614|0 |1 is obsolete| | --- Comment #9 from Barton Chittenden --- Created attachment 43304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43304&action=edit Bug 14292: Add patron category restrictions to longoverdue.pl Add command line options --category and --skip-category Convert usage() to pod2usage. (This was previous FIXME) http://bugs.koha-community.org/show_bug.cgi?id=14292 Signed-off-by: hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 20:15:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 18:15:13 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42892|0 |1 is obsolete| | --- Comment #10 from Barton Chittenden --- Created attachment 43305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43305&action=edit Bug 14292: QA Follow-up Make borrower category handling more user friendly: Make --category and --skip-category mutally exclusive Check that categories specified by --category and --skip-category exist in categories table. Add --list-categories opttion to show available borrower categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 20:25:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 18:25:57 +0000 Subject: [Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #15 from M. Tompsett --- Comment on attachment 36875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36875 Bug 11373: Add a "cash register" feature to the fine payment form. Review of attachment 36875: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11373&attachment=36875) ----------------------------------------------------------------- Changing the sign of what was there before would need something done during upgrade to change it to a new way of processing. This wasn't done, so frankly, I think the logic I highlighted is broken. Though, admittedly, I did not run this code yet. ::: C4/Accounts.pm @@ +722,5 @@ > my $insert = 'INSERT INTO accountlines (borrowernumber, accountno, date, amount, ' > . 'description, accounttype, amountoutstanding, itemnumber, manager_id, note) ' > . ' VALUES (?, ?, now(), ?, ?, ?, 0, ?, ?, ?)'; > > + $dbh->do( $insert, undef, $borrowernumber, $nextaccntno, $payment, 0-$amount is the negative of $amount. This is a vast change! Is this correct? @@ +728,5 @@ > > UpdateStats({ > branch => $user, > type => 'payment', > + amount => $payment, This is 0-$amount which is the negative of what was put here before. @@ +739,4 @@ > action => 'create_payment', > borrowernumber => $user, > accountno => $nextaccntno, > + amount => $payment, On a positive note, by putting $payment earlier, it can be used nicely here. @@ +820,4 @@ > UpdateStats({ > branch => $branch, > type => 'writeoff', > + amount => $payment, Again, 0-$amount is negative of what was there before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 20:29:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 18:29:40 +0000 Subject: [Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 --- Comment #2 from M. Tompsett --- Comment on attachment 43293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43293 Bug 14993 - rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die Review of attachment 43293: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14993&attachment=43293) ----------------------------------------------------------------- ::: misc/migration_tools/rebuild_zebra.pl @@ -305,4 @@ > my $bdir = $base . $dir; > if (! -d $bdir) { > $needed_repairing = 1; > - mkdir $bdir || die "Unable to create '$bdir': $!\n"; oh my! What a nasty glob'ing issue. Thanks for this fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:25:38 +0000 Subject: [Koha-bugs] [Bug 7899] Remove C4::Dates from C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12072, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13813 | Blocks|14870 | Resolution|--- |DUPLICATE --- Comment #1 from Marc V?ron --- Bug 14903 removes deprectated C4::Dates from - circ/circulation.pl - C4/Circulation.pm - koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt *** This bug has been marked as a duplicate of bug 14903 *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:25:39 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #7 from Marc V?ron --- *** Bug 7899 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:25:38 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7899 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:25:38 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7899 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899 [Bug 7899] Remove C4::Dates from C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:25:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:25:39 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7899 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:40:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:40:26 +0000 Subject: [Koha-bugs] [Bug 14995] New: Remove C4::Dates: Delete files reservereport.pl / reservereport.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Bug ID: 14995 Summary: Remove C4::Dates: Delete files reservereport.pl / reservereport.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify, git grep 'reservereport'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:43:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:43:03 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 --- Comment #1 from Marc V?ron --- Created attachment 43306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43306&action=edit Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify: git grep 'reservereport' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:44:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:44:13 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |veron at veron.ch Blocks| |14870 Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:44:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:44:13 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14995 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:57:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:57:40 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 43307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43307&action=edit [SIGNED-OFF]Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 21:58:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 19:58:12 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Attachment #43307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:03:38 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41399|0 |1 is obsolete| | --- Comment #4 from H?ctor Eduardo Castro Avalos --- Created attachment 43308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43308&action=edit [SIGNED-OFF]Bug 14653 - Acq planning filter always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the filter form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - In filter form, select "by months" in "Select planning type" => Without patch, you see planning of "B_ACTIVE" with 1 fund => Without patch, you see planning of "B_OLD" with 3 funds Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:03:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:03:52 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41400|0 |1 is obsolete| | --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 43309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43309&action=edit [SIGNED-OFF]Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Signed-off-by: Hector Castro Works as advertised Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:04:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:04:40 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:36:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:36:28 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs (part 1) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #2 from Marc V?ron --- Created attachment 43310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43310&action=edit Bug 14960 - Remove C4::Dates from files in misc/cronjobs This patch removes C4::Dates from following files: - misc/cronjobs/batch_anonymise.pl - misc/cronjobs/cleanup_database.pl - misc/cronjobs/gather_print_notices.pl - misc/cronjobs/serialsUpdate.pl - misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl - misc/cronjobs/overdue_notices.pl - misc/cronjobs/staticfines.pl To test: - Carefully review code changes. - Verify that the cronjobs behave as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:36:44 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs (part 1) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:38:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:38:38 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove C4::Dates from files |Remove C4::Dates from files |in misc/cronjobs (part 1) |in misc/cronjobs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 22:57:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 20:57:24 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42168|0 |1 is obsolete| | --- Comment #78 from H?ctor Eduardo Castro Avalos --- Created attachment 43311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43311&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patches. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Unit test, prove t/db_dependent/Record.t Sponsored-by: Universidad de El Salvador NOTE: XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 23:11:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 21:11:54 +0000 Subject: [Koha-bugs] [Bug 14996] New: Remove C4::Dates from tags/review.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Bug ID: 14996 Summary: Remove C4::Dates from tags/review.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from file tags/review.pl To test: - Create some tags - Go to Home > Tools > Tags - Verify that dates display properly - Verify that the date filter works as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 23:14:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 21:14:34 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 --- Comment #1 from Marc V?ron --- Created attachment 43312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43312&action=edit Bug 14996 - Remove C4::Dates from tags/review.pl This patch removes C4::Dates from file tags/review.pl To test: - Create some tags - Go to Home > Tools > Tags - Verify that dates display properly - Verify that the date filter works as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 23:15:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 21:15:09 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Blocks| |14870 Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 23:15:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 21:15:09 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14996 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 [Bug 14996] Remove C4::Dates from tags/review.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 23:41:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 21:41:52 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43311|0 |1 is obsolete| | --- Comment #79 from Marc V?ron --- Created attachment 43313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43313&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patches. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Unit test, prove t/db_dependent/Record.t Sponsored-by: Universidad de El Salvador NOTE: XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 9 23:42:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 09 Oct 2015 21:42:18 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 02:13:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 00:13:28 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 02:13:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 00:13:30 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41933|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver --- Created attachment 43314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43314&action=edit Bug 14727: koha-indexer tab completion in bash This patch introduces tab-completion in bash to the koha-indexer command. It completes using valid option switches and instance names. It stops completing then -h or --help are issued, and once a command switch is chosen (either --start, --stop or --restart) it goes ahead with valid instances completion. To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-indexer - Play with all the options => SUCCESS: They work as they should. - Sign off :-D Note: it fixes a small glitch on the plack completion. Signed-off-by: Jesse Weaver Verified working, including filtering out already used options and instances. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 08:08:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 06:08:45 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Patch does not apply: CONFLICT (content): Merge conflict in members/moremember.pl Failed to merge in the changes. It's related to the QA follow-up im 14925 already pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 10:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 08:01:54 +0000 Subject: [Koha-bugs] [Bug 14997] New: Remove C4::Dates from tools (import / export) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Bug ID: 14997 Summary: Remove C4::Dates from tools (import / export) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 10:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 08:38:31 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 --- Comment #1 from Marc V?ron --- Created attachment 43315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43315&action=edit Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron categorie like 'TEST' (usful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 10:39:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 08:39:57 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Assignee|gmcharlt at gmail.com |veron at veron.ch Status|NEW |Needs Signoff Patch complexity|--- |Small patch Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 10:39:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 08:39:57 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14997 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 [Bug 14997] Remove C4::Dates from tools (import / export) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 10:41:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 08:41:46 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:36:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:36:57 +0000 Subject: [Koha-bugs] [Bug 14998] New: Remove C4::Dates from install and maintenance folder Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Bug ID: 14998 Summary: Remove C4::Dates from install and maintenance folder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org This patch removes C4::Dates from files: - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:37:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:37:32 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove C4::Dates from |Remove C4::Dates from |install and maintenance |installer and maintenance |folder |folders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:48:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:48:39 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #1 from Marc V?ron --- Created attachment 43316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43316&action=edit Bug 14998 - Remove C4::Dates from installer and maintenance folders - installer/data/mysql/updatedatabase.pl - misc/maintenance/fix_accountlines_date.pl To test for updatedatabase.pl - perl installer/data/mysql/updatedatabase.pl - review code. Difficult to test, because the code affects $DBversion = '3.03.00.035' To test for misc/maintenance/fix_accountlines_date.pl - review code - The file seems to be a file used for an update, could it be obsolete? If yes, remove it in a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:49:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:49:15 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:51:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:51:58 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14998 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 [Bug 14998] Remove C4::Dates from installer and maintenance folders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:51:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:51:58 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14870 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 11:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 09:57:13 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #8 from Marc V?ron --- I hope that is no blocker :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 12:05:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 10:05:49 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #1 from Marc V?ron --- With all the blocking Bugs pushed (latest is Bug 14998), the only remaining files should be: To be removed: C4/Dates.pm t/Dates.t To be changed: debian/templates/plack.psgi misc/plack/koha.psgi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 13:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 11:36:30 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #33 from Marc V?ron --- Created attachment 43317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43317&action=edit Bug 12072 - Step 1: Add system preference for New dateformat dd.mm.yyyy As a first step, this patch adds a new system preference for the dateformat dd.mm.yyy No other changes are made. To test: 1. apply the patch 2. run updatedatabase.pl 3. go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save 4. verify that the value was saved Signed-off-by: Bernardo Gonzalez Kriegel New preference brakes a lot of things, hopefully will be fixed on 13813 No koha-qa errors Amended to replace changes to updatedatabase.pl with atomic update. /mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 13:51:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 11:51:13 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 14:38:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 12:38:18 +0000 Subject: [Koha-bugs] [Bug 14999] New: Adding to basket orders from staged files mixes up the prices and quantities between different orders Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Bug ID: 14999 Summary: Adding to basket orders from staged files mixes up the prices and quantities between different orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org If one adds multiple item orders from a staged file to an basket the orders might change their values like price and item quantity between each other. This happens because in addorderiso2709.pl under the part "3rd step = import the records" there is a call to hasGetImportRecordsRange($import_batch_id) which gives some biblio info in some random order. And so this biblio info is used then like it would be in order and then the values mix up because of this. I have done a patch for this, and I'll put it here soon, so it will be more easier for you to understand! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 14:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 12:42:32 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #34 from Marc V?ron --- Created attachment 43318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43318&action=edit Bug 12072 - Add system preference for New dateformat dd.mm.yyyy (dmydot) Note: This feature depends on Bug 14870 'Delete C4/Dates from system' System preferences: To test: - apply the patch - run updatedatabase.pl - go to Admin > Sysprefs > I18N, change dateformat to dd.mm.yyyy, save - verify that the value was saved Date handling: - go through the staff client and verify that dates behave as expected. The Bugs where Bug 14870 depends on contain test plans that can be used for the overall testing. Note: Make sure that you reset the dateformat to the former value after testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 14:43:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 12:43:03 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 14:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 12:44:14 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 --- Comment #1 from Joonas Kylm?l? --- Created attachment 43319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43319&action=edit Bug 14999: Fetch the corresponding values for the specific biblio item This is just a fast way to fix this bug. If you figure out an better one, please send it here! Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 14:52:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 12:52:37 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #35 from Marc V?ron --- For preliminary testing it is a good idea to have Bug 14985 applied. For full testing we need all Bugs where Bug 14870 depends on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 10 17:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 15:18:52 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 01:44:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 23:44:31 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #12 from Marc V?ron --- Created attachment 43320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43320&action=edit Bug 4078 - Display active currency symbol on currency output and input Display active currency using international formatting patterns and active currency symbol withplugin price. The patch inlcudes an example on Opac. To test: Without patch: - Log in to the Opac with an user who has credits or fines. - Go to 'Your summary'. The amount appears in the tab 'Credits'rsp. 'Fines' - Apply patch - Make sure that you have defined an active currency in Home > Administration > Currency & Exchange rates - Search for Syspref 'Currency Format' - Select a formatting pattern from the drop down list - Go back to the Opac and verify that the amount is properly formatted, including the position of the currency symbol. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 01:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 23:45:07 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 01:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 23:45:37 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 01:47:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 10 Oct 2015 23:47:29 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 09:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 07:06:24 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14252 CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 09:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 07:06:24 +0000 Subject: [Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12017 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 10:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 08:33:41 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 18:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 16:51:04 +0000 Subject: [Koha-bugs] [Bug 13755] Suggestions: Strange additional tab if suggestion is saved without choosing a status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13755 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14830 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 18:51:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 16:51:04 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13755 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 18:51:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 16:51:26 +0000 Subject: [Koha-bugs] [Bug 14839] 'anonymous' purchase suggestions are created with 'Anon' user's branchcode ignored, (NULL branchcode) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14839 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 21:05:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 19:05:38 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #4 from Marc V?ron --- Hi Alex, Maybe simpleSearch is better in this case. Can you give it a try? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 21:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 19:38:28 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12017 --- Comment #8 from Marc V?ron --- Hi Lari, It seems that the alphabetical order uses the English language names and not the (translated) names, is that the case? I have: fre|eng|ger Order: alphabetically and I get E-D-F instead of D-E-F: English (English) Deutsch (German) Fran?ais (French) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 21:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 19:38:28 +0000 Subject: [Koha-bugs] [Bug 12017] Move language description out of database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14912 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 22:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 20:45:00 +0000 Subject: [Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 11 22:53:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 20:53:24 +0000 Subject: [Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 00:57:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 22:57:54 +0000 Subject: [Koha-bugs] [Bug 15000] New: Adding patron card images with duplicate descriptions causes data loss Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 Bug ID: 15000 Summary: Adding patron card images with duplicate descriptions causes data loss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Adding a patron card image with a duplicate description to an existing one saves the first one fine, but subsequent images with no description overwrite the initial image with no warning. The work-around is to always give your images a unique description, but we shouldn't depend on the user to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 00:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 11 Oct 2015 22:58:42 +0000 Subject: [Koha-bugs] [Bug 15000] Adding patron card images with duplicate descriptions causes data loss In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15000 --- Comment #1 from Liz Rea --- /cgi-bin/koha/patroncards/image-manage.pl This is the page I'm referring to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 03:32:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 01:32:34 +0000 Subject: [Koha-bugs] [Bug 15001] New: imported auth records are incorrectly labeled as 'biblio' in action_log Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15001 Bug ID: 15001 Summary: imported auth records are incorrectly labeled as 'biblio' in action_log Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org spotted in 3.20.0, not confirmed in master more info to come... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 05:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 03:43:04 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #153 from Robin Sheat --- I've created a zebra-running version to help shake out the bugs that have accumulated in there. It's at: http://zebra.koha.catalystdemo.net.nz/ and is exactly the same code as the elasticsearch version, but with the SearchEngine preference set to 'Zebra'. It isn't working right now, I've probably broken something. That's what I'll be fixing for the next little while. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:22:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:22:02 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:22:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:22:05 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43102|0 |1 is obsolete| | Attachment #43105|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 43321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43321&action=edit Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylm?l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:22:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:22:16 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #7 from Katrin Fischer --- Created attachment 43322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43322&action=edit [PASSED QA] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:23:11 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43321|0 |1 is obsolete| | Attachment #43322|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 43323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43323&action=edit [PASSED QA] Bug 14841: Columns settings are not taken into account for checkout table / moremember There is a typo member vs members in the template when retrieving the existing settings. So that all columns are displayed, even the ones which are hidden (sort_order, due_date_unformatted, etc.) Test plan: 0/ Does not apply this patch 1/ Go on the columns config page and check some fields not to display by default for Patrons > moremember > issues-table 2/ Go on the patron detail page (with checkouts), click on the "show/hide columns" button (top right of the table). Confirm that the config is not taken into account and that it's ugly (hidden columns are displayed) 3/ Apply this patch 4/ Everything should be fine now :) Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:23:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:23:33 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 --- Comment #9 from Katrin Fischer --- Created attachment 43324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43324&action=edit [PASSED QA] Bug 14841: Fine column is not manage by columns settings Bug 9481 added the "Fine" columns to the checkouts table and bug 13492 added the columns settings to these table. They overlapped each others in the bugs queue. Test plan: Confirm that you are able to hide/show the "Fine" columns on both checkouts table. Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:26:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:26:36 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:26:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:26:39 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43172|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 43325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43325&action=edit [PASSED QA] Bug 14966:Table header broken at detail.tt For user without item edit permission, table at catalogue/detail.pl is corrupted. Test plan: 1) Log in as staff member, without edit item permission. 2) Go to biblio view, with items attached: /cgi-bin/koha/catalogue/detail.pl?biblionumber=X. Confirm that table does not display correctly. 3) Apply patch. 4) Repeat steps 1 and 2. Confirm patch works. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:52:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:52:01 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #33 from Katrin Fischer --- Hm, I think I might have uncovered a small bug in master: If you set the circulation rule max to 2, but have a default total of checkouts allowed of 1 - the circulation rule seems to be looked at first, and you can check out 2 books total instead of only 1. But this appears to happen with and without the patches... so just a testing note for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:54:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:54:58 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #34 from Katrin Fischer --- Created attachment 43326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43326&action=edit [PASSED QA] Bug 14045: Add specific quotas to on-site checkouts This patch set adds the ability to defined independent quotas for on-site checkouts. This will be done using the circulation rules matrix where a new column ?Current on-site checkouts allow? will be added. This feature is going to use the same method as the existing fields maxissueqty ("Current checkouts allowed"), the new fields will be added to the different tables (see the "DB changes" patch) and will be named maxonsiteissueqty (for consistency). In order to keep the existing behavior and to let more flexibility, a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts). This syspref will let the liberty to the library to decide if an on-site checkout should be considered as a "normal" checkout or not. To keep the existing behavior, the syspref will be disabled (i.e. an on-site checkout is considered as a normal checkout) and the number of on-site checkouts will be the same as the number of checkout (maxissueqty == maxonsiteissueqty). Technically: There are only very few tests for the Circulation module, and the 2 subroutines impacted by this patch set were not tested at all. It is necessary to introduce non-regression tests for this area. The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule and C4::Circulation::TooMany (only called by C4::Circulation::CanBookBeIssued, so we will take the liberty to change the prototype to raise a better warning to the end user). Test plan: I. Confirm there is no regression and the existing behavior is kept 0/ Let the syspref disabled 1/ Set a rule to limit to 2 the number of checkouts allowed 2/ Do a normal checkout 3/ Do an on-site checkout 4/ Try to checkout (on-site or normal) an item again. You should not be allowed. II. Test the new feature - pref disabled 0/ Let the syspref disabled 1/ Set a rule to limit to 2 the number of checkouts allowed and to 1 the number of on-site checkouts allowed. 2/ Do an on-site checkout 3/ Try to do another one, you should not be allowed to do it. 4/ A normal checkout should pass successfully Note that it does not make sense to have the number of on-site checkouts alowed > number of checkouts allowed. III. Test the new feature - pref enabled 0/ Enable the syspref Now an on-site checkout is *not* counted as a normal checkout. This means you can have the number of on-site checkouts > number of checkouts allowed. 1/ Set the values you want for the 2 types of checkouts (normal vs on-site). 2/ Even if a patron has reached the maximum of checkouts allowed, he will be allowed to do a on-site checkout (vice versa). IV. Stress the developper Using the different configurations available in the circulation matrix, try to find one where the checkout is allowed and not should be. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:55:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:55:06 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #36 from Katrin Fischer --- Created attachment 43328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43328&action=edit [PASSED QA] Bug 14045: Introduce the maxonsiteissueqty field as a copy of maxissueqty This patch adds the new fields maxonsiteissueqty as a copy of the existing maxissueqty field. There is no brainy code here, it only adds the ability to fill the new field from the admin interface (admin/smart-rules.pl). Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:55:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:55:02 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #35 from Katrin Fischer --- Created attachment 43327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43327&action=edit [PASSED QA] Bug 14045: Change prototype of TooMany to raise a better warning With this patch, the user will know why the checkout is refused. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:55:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:55:10 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #37 from Katrin Fischer --- Created attachment 43329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43329&action=edit [PASSED QA] Bug 14045: Make GetBranchBorrowerCircRule return maxonsiteissueqty GetBranchBorrowerCircRule should return the value for maxissueqty and maxonsiteissueqty. It's what this patch does. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:55:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:55:13 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #38 from Katrin Fischer --- Created attachment 43330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43330&action=edit [PASSED QA] Bug 14045: DB Changes This patch is the DB changes for the feature. It adds 5 new columns named 'maxonsiteissueqty' to the following tables: - branch_borrower_circ_rules - default_borrower_circ_rules - default_branch_circ_rules - default_circ_rules - issuingrules It also adds the pref ConsiderOnSiteCheckoutsAsNormalCheckouts. See main patch for more details. Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:55:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:55:16 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #39 from Katrin Fischer --- Created attachment 43331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43331&action=edit [PASSED QA] Bug 14045: DBIC Changes Signed-off-by: Nicolas Legrand Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:55:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:55:20 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #40 from Katrin Fischer --- Created attachment 43332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43332&action=edit [PASSED QA] Bug 14045: Fix typo in template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:05 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Medium patch |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:07 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43178|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:09 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42317|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:11 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42318|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:13 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42319|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:16 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42320|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:18 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 07:56:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 05:56:20 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 08:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 06:07:43 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43251|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 43333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43333&action=edit Bug 14912: (follow-up) Use priority sorting only if AdvancedSearchLanguagesSort is set to priority. This patch adds a system preference "AdvancedSearchLanguagesSort" that defines whether the drop-down list should be sorted by priority in AdvancedSearchLanguages or alphabetically like before. To test: -1. Set some languages into AdvancedSearchLanguages system preference 1. Go to advanced search and look at Languages drop-down list 2. Note that the list is in alphabetical order 3. Apply patches and run database update 4. Change system preference AdvancedSearchLanguagesSort to "by priority" 5. Repeat step 1 6. Note that the list is sorted like AdvancedSearchLanguages 7. Change system preference AdvancedSearchLanguagesSort to "alphabetically" 8. Repeat step 1 9. Note that the list is again in alphabetical order Signed-off-by: Josef Moravec Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 08:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 06:08:00 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 08:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 06:10:12 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 --- Comment #10 from Josef Moravec --- Marc, I tried some combinations, including the one you wrote about, but I have no problems with sorting. Is it possible that something else comes into effect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 09:13:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 07:13:28 +0000 Subject: [Koha-bugs] [Bug 4078] Display active currency symbol on currency output and input In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #13 from Jonathan Druart --- Note: the symbol should not be displayed by default. (I have not tested it, but it's a personal note for later). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:23:44 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12806 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:23:44 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14980 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:23:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:23:54 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7840 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:23:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:23:54 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14980 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:25:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:25:43 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 --- Comment #13 from Gaetan Boisson --- I am still very much in favor of brining this into master, even in a very unpolished way that will allow us to build upon later. Fridolin has done a POC in bug 14980. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:26:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:26:15 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #11 from Gaetan Boisson --- See Fridolin's POC on bug 14980. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:39:23 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #172 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #171) > QA Comment: > Great job !!! Lot of work involved. Thanks a lot for Qaing this! Very useful feedback :) > Still have some points for consideration: > > OPAC -- View contents of a list -- Send shelf - Crash > Can't call method "can_be_viewed" on an undefined value at > /home/koha/testclone/opac/opac-sendshelf.pl line 55. > *BLOCKER* Fixed! The shelfnumber param was not passed. I have also add a test in the pl file to avoid this crash when viewing an non-existing shelf (now display 'not authorized', which is the current behavior). > OPAC - View contents of a list - Sort by callnumber - Bang > DBIx::Class::ResultSet::next(): Unknown column 'itemcallnumber' in 'order > clause' at /home/koha/testclone/opac/opac-shelves.pl line 236 > *BLOCKER* Fixed! But... This is a bad one. In opac-shelves.pl and shelves.pl, the join was only done on biblio. But itemcallnumber is in the items table. I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent without declared primary key). Fixed in a separate patch. Note that bug 14819 is stuck in the NSO status but also adds the relationships. > OPAC - Lists- Open a shared list where you do not have permission to remove > items of someone else. Try to remove such an item. No success, but no > warning too! IIRC There was a warning in the past about some items not > deleted.. > Now try to remove a item you added yourself to that list while having > permission to remove your own entries. This does not work ! No items are > deleted, no message. > I am inclined to see this last point as a *BLOCKER* too. Fixed! The "op" was "view" instead of "remove_biblios" on the submit button. Note that the individual links work (and intranet is ok). > OPAC - View list - Delete your own item while the perms are ADD or DDD. > Should not be possible. But the owner is able to now. This is change of > behavior and not consistent with the wording of those permissions "Do not > allow anyone to remove his own contributed entries" (including your own!). I > would view it as a sort of Readonly list > where you cannot accidentally delete your own items. (Note however that > adding is still possible.) > I am inclined to see this last point as a *BLOCKER* too (but I may not be > completely neutral here :) > + # FIXME > + # This does not make sense, but it's has been > backported from DelFromShelf. > + # Why shouldn't we allow to remove his own contribution > if allow_delete_other is on? Well, not fixed. I have asked on #koha and Nicole agreed (http://irc.koha-community.org/koha/2015-08-18#i_1716925). So I am not sure what to do here. > Code Exceptions.pm module comes in now with a dependency Exception::Class. > The description => "poeut" still needs some attention apparently :) Not sure > what it means btw.. > Although this looks good to me on itself, this dev should probably better > have gone on its own report. Note there is another report too (13995). > It kind of creeps in now. poeut is a typo for pouet which does not mean anything :) The exceptions implementation can be modified easily later (the question was: should we put all exceptions in 1 file, all exceptions of a given module in 1 file or 1 exception per file). > OPAC - Share a list - Enter email address - Return to your lists: This list > does not exist ?? op=view && category=1. Adjust the URL? Fixed! Yes, the op is 'list', not 'view". > OPAC - I shared a list with AAD perms. The other user could add a few > entries. After that removed the share. > Now come back as owner of the list and try to remove one item of yourself > and one of the other user. > You will get the message: The item has been removed from the list. > This is not completely true: You could only remove one item; the other is > not permitted. This is a specific case and I would prefer to manage it in a separate bug report. I am not sure this work on master :) > OPAC - Create a new list - Starts with permissions D D D - Would it not be > better to default to D A D ? > Note that if I create a list with save to new list, it does default to DAD. > So this is a minor inconsistency.. Yes, and it's a regression. Fixed on both interface (I have c/p OPAC code for the intranet). > OPAC - View a list: For a list with ADD or DDD perms, the button Remove > could be hidden or disabled? Might be the case now too btw. Not easily, and there is no regression here: it's how it works currently. The problem is that the queries done in remove_biblios should be executed for each biblio in the list. Maybe not a big deal, to investigate... > OPAC Detail - List(s) this item appears in: [nothing filled while expected] > I click from view a (private) list on one entry. So go to opac detail. > Should I expect that list to be mentioned now? It is not. Fixed! In the template shelves->count should be check, not only the shelves variable (which is always defined). > Staff - View public lists [Related to another report] > With the delete public lists permission I can delete the public list of > another user. OK The staff user probably has a good reason to do so. > Just noting that it would perhaps be more friendly to switch it to Private > instead of a rigourous Delete? Todo later yes. > Code in opac-addbybiblionumber.pl: HandleSelectedShelf: Empty TODO in an > else branch. Noting for the record. Yes, I preferred to add the TODO marked than nothing, but no regression here. > Code t/db_dependent/Utils/Datatables_Virtualshelves.t and > C4/Utils/DataTables/VirtualShelves.pm > This is only justified/used by svc/virtualshelves/search > Isn't this the time to move this svc script to Koha::Virtualshelves too ? Or > at least on another report ? Not ready yet. The rewrite should use the REST api. > Database design: Do we still need (or use) virtualshelfcontents.flags ? > Could a dbrev remove it now? To investigate, but yes, I am not sure to have found any usefulness to this column. > An observation (which could be considered as outside the scope): Add an item > to the list with a barcode (in staff) is somewhat strange. You cannot add > items, only biblios. This is current situation already. Just for > completeness :) Changing the wording could maybe fix the ambiguity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:46:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:46:58 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #173 from Jonathan Druart --- Created attachment 43334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43334&action=edit Bug 14544: Add missing biblio <=> biblioitems <=> items relationships to the schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:47:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:47:03 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #174 from Jonathan Druart --- Created attachment 43335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43335&action=edit Bug 14544: QA fixes - some minor bug fixes See comment 171 and 172 for more details. This patch mainly fixes typo or silly error in templates. It also uses the relationships added by previous patch to join the biblioitems and items tables (changes in opac-shelves.pl and shelves.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 11:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 09:58:59 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #28 from Jonathan Druart --- (In reply to Kyle M Hall from comment #27) > With 540 checkouts I get the following with your script: > > on master: > real 0m1.023s > user 0m0.980s > sys 0m0.044s > > with bug 8483: > real 0m1.032s > user 0m0.980s > sys 0m0.052s Is it 500 checkouts for 1 patron? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 12:01:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 10:01:36 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 12:40:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 10:40:56 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #11 from Jonathan Druart --- Created attachment 43336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43336&action=edit Bug 14292: QA fixes - wording and trailing whitespaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 12:41:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 10:41:01 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #12 from Jonathan Druart --- Created attachment 43337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43337&action=edit Bug 14292: Simplify the category list Basically we have 3 lists of categories: 1/ The full one, in the DB 2/ The one we want and list with --category 3/ The one we don't want and list with --skip-category The list of categories to process is: * 1 if none --category or --skip-category options are provided * 2 if --category is provided * 1 - 3 if --skip-category is provided -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 12:42:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 10:42:24 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #13 from Jonathan Druart --- Barton, I am sorry but I think there was a misunderstanding. The idea was not to add more complexity but simplify the --category and --skip-category options. Could you please have a look at the last patch and, if you agree with this change, add your signoff on it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 12:45:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 10:45:43 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43289|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 43338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43338&action=edit Bug 14990: Format the date template-side for moremember Test plan: print slip and show the member detail page, the 3 dates date of birth, date enrolled and date of expiry should be displayed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 13:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 11:02:20 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #175 from Marcel de Rooy --- >From IRC http://irc.koha-community.org/koha/2015-08-18 === 11:24 Joubu: nengard: Don't you think the following does not make sense? : "The owner of a list is always allowed to add entries, but needs permission to remove." 11:25 nengard that makes no sense at all === Well, i do not agree that it make no sense at all.. Although this is not the most important issue on lists, but just a detail, such a short conversation on irc is not the decisive factor for me to justify changing current behavior. Also note that the question is formulated rather suggestive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 13:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 11:12:40 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #176 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #175) > From IRC http://irc.koha-community.org/koha/2015-08-18 > === > 11:24 Joubu: nengard: Don't you think the following does not make sense? : > "The owner of a list is always allowed to add entries, but needs permission > to remove." > 11:25 nengard that makes no sense at all > === > > Well, i do not agree that it make no sense at all.. > Although this is not the most important issue on lists, but just a detail, > such a short conversation on irc is not the decisive factor for me to > justify changing current behavior. Also note that the question is formulated > rather suggestive. I don't have a strong opinion on it. I have to admit I did not see the "readonly list" feature, and it could make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 13:56:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 11:56:07 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43338|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 43339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43339&action=edit Bug 14990: Format the date template-side for moremember Test plan: print slip and show the member detail page, the 3 dates date of birth, date enrolled and date of expiry should be displayed correctly. Followed test pan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 13:56:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 11:56:59 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 16:07:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 14:07:16 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #3 from Marc V?ron --- Fridolin, I like the feature very much! Thinking about enhancements (not necessarily for this bug, it is rather a wishlist): - I would like to see the page id in the staff client (Home > Tools > News). The current column 'Number' could be renamed to 'Sort'. - Flag news to display only as CMS page - Flag news for "Display for logged in users only". Oh, and then, additionally flag news for certain user categories only - Make it possible to include other news in a news. Let's say you have a 'news' with opening hours and an other one with the staff mebers. It would be nice to make them re-usable as page content inside other news. Marc PS: (One small thing in opac/opac-page.pl,line 2 says "This script lets the users change their privacy rules") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 16:08:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 14:08:30 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43263|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 43340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43340&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 Works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 16:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 14:10:46 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Marc V?ron --- (In reply to Marc V?ron from comment #3) > - I would like to see the page id.... I mean the news id that is used to create the link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 16:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 14:51:49 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41356|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 43341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43341&action=edit Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. Followed test plan. It works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 16:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 14:53:58 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off --- Comment #13 from Marc V?ron --- Note: I tested on current master (3.21.00.034) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:29:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:29:58 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43219|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43342&action=edit Bug 14978: Add unique key constraint on issues.itemnumber The constraint might have existed before bug 14069. For these DB, this patch will restore it, for others, it will add it :) Test plan: > show create table issues; should not return "unique key itemnumber" Execute the updatedb entry twice > show create table issues; should return only one "unique key itemnumber" Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:31:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:31:00 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:35:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:35:33 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43195|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43343&action=edit Bug 14975 - Fine grace period label is incorrect The column heading for grace period is "Fine grace period (day)" but the grace period works based on the unit selected ( hours or days ). The "(day)" part should be removed as it caused confusion for librarians. Test Plan: 1) Apply this patch 2) Go to the circ rules editor 3) Note the header and footer columns for grace period no longer have "(days)" at the end. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:35:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:35:48 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:47:58 +0000 Subject: [Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42928|0 |1 is obsolete| | --- Comment #3 from H?ctor Eduardo Castro Avalos --- Created attachment 43344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43344&action=edit [SIGNED-OFF]Bug 14916 - Remove C4::Dates from circ/overdue.pl Patch to remove deprectated C4::Dates from circ/overdue.pl To test: - Tests without patch: - Make sure that you have patron(s) with overdues. - Go to Home > Circulation > Overdues - Apply date filter, perform CSV download Apply patch, then - Reload page - Check that everything behaves as before Signed-off-by: Hector Castro Works as advertised. Tested with dateformat syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:48:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:48:17 +0000 Subject: [Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 17:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 15:53:45 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Marc V?ron --- The feature works and I like it, but sorry, tests do not work. See comment #5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:17:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:17:38 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #154 from Jonathan Druart --- Created attachment 43345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43345&action=edit Bug 12478: [DO NOT PUSH] script to generate the mappings yaml file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:17:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:17:46 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #155 from Jonathan Druart --- Created attachment 43346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43346&action=edit Bug 12478: Add the yaml mappings file This should facilitate the modification of the mappings. The yaml format is more readable than sql. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:18:02 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #156 from Jonathan Druart --- Created attachment 43347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43347&action=edit Bug 12478: Add Koha::SearchField[s] and Koha::SearchMarcMap[s] classes This was initially submited on bug 14899, but we will need it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:18:09 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #157 from Jonathan Druart --- Created attachment 43348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43348&action=edit Bug 12478: Move mapping attributes to the join table To make things consistent, the attributes of the mappings (sort, suggestible, facet) should be moved to the join tables (search_marc_to_field). Indeed the search_marc_map could represent a mapping for several search fields with different attributes. Before this change it was not possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:18:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:18:18 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #158 from Jonathan Druart --- Created attachment 43349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43349&action=edit Bug 12478: update the schema These files have been generated with the misc/devel/update_dbix_class_files.pl script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:18:26 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #159 from Jonathan Druart --- Created attachment 43350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43350&action=edit Bug 12478: Manually add the many_to_many relationships This will create the add_to_* accessors for us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:18:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:18:42 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #160 from Jonathan Druart --- Created attachment 43351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43351&action=edit Bug 12478: Remove previous mappings file (sql) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:20:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:20:14 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33137|0 |1 is obsolete| | Attachment #33138|0 |1 is obsolete| | Attachment #33139|0 |1 is obsolete| | Attachment #33140|0 |1 is obsolete| | Attachment #33141|0 |1 is obsolete| | Attachment #42062|0 |1 is obsolete| | Attachment #42063|0 |1 is obsolete| | Attachment #42064|0 |1 is obsolete| | Attachment #42065|0 |1 is obsolete| | Attachment #42066|0 |1 is obsolete| | Attachment #42067|0 |1 is obsolete| | Attachment #42068|0 |1 is obsolete| | Attachment #42069|0 |1 is obsolete| | Attachment #42392|0 |1 is obsolete| | Attachment #42393|0 |1 is obsolete| | Attachment #43127|0 |1 is obsolete| | Attachment #43128|0 |1 is obsolete| | Attachment #43130|0 |1 is obsolete| | Attachment #43131|0 |1 is obsolete| | Attachment #43132|0 |1 is obsolete| | Attachment #43133|0 |1 is obsolete| | Attachment #43134|0 |1 is obsolete| | Attachment #43140|0 |1 is obsolete| | Attachment #43142|0 |1 is obsolete| | Attachment #43148|0 |1 is obsolete| | --- Comment #161 from Jonathan Druart --- Created attachment 43352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43352&action=edit Bug 14899: Add a link to the new page in the admin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:20:35 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:20:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:20:43 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |In Discussion --- Comment #4 from H?ctor Eduardo Castro Avalos --- Hi Marc Datepicker fails in refine results. This is the error launched: The 'day' parameter ("32") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'hour', 0, 'minute', 0, 'second', 0, 'month', 10, ...) called at /home/koha/kohaclone/Koha/DateUtils.pm line 164 Koha::DateUtils::dt_from_string('2014-10-32') called at /home/koha/kohaclone/circ/reserveratios.pl line 87 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:23:44 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #162 from Jonathan Druart --- Hi Robin, I think I did it! :) Last patch set move the mapping attributes to the join table and provide a yaml file to manage the default mappings. I will test it a bit more tomorrow, to be sure I have not introduced regression. Let me know if it goes in the direction of what you had in mind! I am also attaching patches on bug 14899, the interface is now much more consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:24:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:24:22 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #163 from Jonathan Druart --- well, s/much more/a bit more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:25:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:25:43 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43054|0 |1 is obsolete| | Attachment #43055|0 |1 is obsolete| | Attachment #43056|0 |1 is obsolete| | Attachment #43057|0 |1 is obsolete| | Attachment #43058|0 |1 is obsolete| | Attachment #43099|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 43353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43353&action=edit Bug 14899: Add tableDND JS lib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:25:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:25:51 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #19 from Jonathan Druart --- Created attachment 43354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43354&action=edit Bug 14899: Add the mapping configuration page in the admin module This new page (admin/searchengine/elasticsearch/mappings.pl) will permit to manage the ES mappings. For the biblios and authorities indexes, the different mappings can be managed from this single page. The interface let you add, remove and update mappings and search fields. It's also possible to reorder the mappings, as the order can be important in the indexation process. Note that the table can be displayed in a different order that the one it was before saving, but the mappings are grouped by search field and the order inside the search field is preserved. Limitations: - If something went wrong during the insertion/deletion/modification, the users will loose all these changes. TODO: - Add a specific permission (?) - Add some data checks client side (JS) - Use checkboxes for facet and suggestible (lazy today...) - Understand the difference between the 3 values that sortable can have and improve the value for the options in the select box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 18:25:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 16:25:58 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #20 from Jonathan Druart --- Created attachment 43355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43355&action=edit Bug 14899: Add a link to the new page in the admin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 19:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 17:26:30 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Marc After applying patch I've found this: /opac/opac-showreviews.pl got C4::Dates declaration in line 59, 116 and patch only eliminate the declaration 'use C4::Dates' Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 20:34:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 18:34:04 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org Status|NEW |In Discussion --- Comment #2 from Karl Holten --- (In reply to Theodoros Theodoropoulos from comment #1) > We had the same issue and found out that in order for fine collection to > work, > > (borrowers) Add or modify patrons > > permission must also be checked! > > Can you please verify it? > If so, this finding should could help the person who deals with the case > identify the problem. If this is by design (although these permissions > should work independently!), a note should be added in the relevant docs. We can confirm that what Theodoros is saying about this bug is true. Enabling the ability to add or modify patrons allowed our staff members to write-off fines. I agree with Theodoros that these permissions should indeed be made wholly separate ideally, or documented if making them separate is a major project. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 21:16:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 19:16:32 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43123|0 |1 is obsolete| | --- Comment #3 from Marc V?ron --- Created attachment 43356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43356&action=edit Bug 14956 - C4::Dates from files opac/*.pl Remove C4::Dates from files: - opac/opac-memberentry.pl - opac/opac-reserve.pl - opac/opac-search-history.pl - opac/opac-showreviews.pl - opac/opac-suggestions.pl - opac/opac-serial-issues.pl - opac/opac-alert-subscribe.pl - opac/opac-ics.pl To test: - Apply patch - Verify, that self registration and holds work as before - Verify that tabs in catalog item detail work and display as before - For serials: Verify that subscriptions work as before. It is a little bit hidden, in tab Subscriptions, then 'More details', then tab 'Brief history', button 'Subscribe to email notificatin on new issues' - For ics: Can not be tested at the moment, not yet used (Bug 5456), pls. have a look at the code changes (Amended following comment #2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 21:17:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 19:17:37 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 21:47:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 19:47:00 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:01:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:01:37 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #4 from H?ctor Eduardo Castro Avalos --- Hi Marc When you go to "your personal details" (opac/opac-memberentry.pl) and if you alter to an invalid date the form it doesn't fail but when you go to staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' (depends in which format you have dateformat syspref) this data shown in a table: Field From To Date of birth 2015-11-01 0000-00-00 To prevent this (IMHO) I suggest to add readonly="" to the input text or follow the example as koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt Patch follow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:03:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:03:59 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #5 from H?ctor Eduardo Castro Avalos --- Created attachment 43357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43357&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac/opac-memberentry.pl Prevent to insert dates like 0000-00-00, 1970-32-10, etc., according with comment 4. To test 1) Apply last patch 2) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:07:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:07:20 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #27 from Katrin Fischer --- Working on this one now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:21:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:21:49 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #5 from Marc V?ron --- Hi H?ctor, thank you for testing! I refactured the date handling. Patch follows. Can you please test again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:21:51 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Hi Joubu, I started testing with the itemtypes administration page and the new modal for adding the translations. Some first findings: 1) I think "Translate for other languages" would work better as "Translate into other languages". 2) I added "B?cher" as the German translation for "Books" and the umlauts in the table with the translated strings are broken. 3) I accidentally added the "B?cher" string twice - should we allow multiple translations for the same lang and entity combination? 4) There should be a way to delete strings accidentally added, but I don't see one. There is an empty last cell in the last column, only when you open the modal a second time the X appears. 5) I think it would be good to switch the sequence and have the entry field above the table. 6) It would be good to show the entity and code you are translating for in the window somewhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:22:28 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42950|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 43358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43358&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:23:06 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:23:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:23:18 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:27:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:27:23 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43357|0 |1 is obsolete| | --- Comment #6 from H?ctor Eduardo Castro Avalos --- Created attachment 43359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43359&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:34:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:34:21 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #7 from Marc V?ron --- Created attachment 43360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43360&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. Field 'Date of birth' in Opac is now restricted to date picker. Works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:36:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:36:29 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43358|0 |1 is obsolete| | --- Comment #8 from H?ctor Eduardo Castro Avalos --- Created attachment 43361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43361&action=edit [SIGNED-OFF] Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. Signed-off-by: Hector Castro Works as advertised. Tested with dateformat syspref, datepiker Ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:36:35 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43360|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Comment on attachment 43360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43360 Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Wrong bug number. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:37:28 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43359|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 43362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43362&action=edit Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Prevent to insert invalid dates in opac-memberentry.tt. To test 1) Apply last patch (interactive) 2) Goto 'your personal details in opac' and modify date of birth with 2015-10-32 3) Goto staff in Home > Patrons requesting modifications, at the bottom of screen this redirect to members/members-update.pl and you get noticed that the date sent is '0000-00-00' 4) Apply patch 5) Go to 'your personal details in opac' (opac/opac-memberentry.pl) observe that field is readonly and patrons can't insert invalid dates. Field 'Date of birth' in Opac is now restricted to date picker. Works as advertised. Signed-off-by: Marc V?ron http://bugs.koha-community.org/show_bug.cgi?id=14920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:37:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:37:44 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:39:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:39:37 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 12 23:51:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 12 Oct 2015 21:51:18 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #29 from Katrin Fischer --- http://localhost:8080/cgi-bin/koha/tools/batchMod.pl and issues_avg_stats.pl If you have multiple translations for a entity-code-language combination, they all show up in the pull down. In other pull downs, like on the reserve_stats.pl only one translation shows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 03:56:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 01:56:37 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #164 from Robin Sheat --- Jonathan, you're not putting correct copyright headers into the files you're creating/modifying. You need to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 05:32:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 03:32:05 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #165 from Robin Sheat --- (In reply to Jonathan Druart from comment #162) > Let me know if it goes in the direction of what you had in mind! Just reading the patches, this all looks good to me. I'll pull them in (excluding the one you don't want pulled :) My only thought is that doing scripted (e.g. in vim) updates of the yaml will be harder, as it's not each entry on one like the SQL. Perhaps the best way to deal with that is something that will dump the database out to YAML, so you can do batch changes in SQL and then just rexport the YAML. > I am also attaching patches on bug 14899, the interface is now much more > consistent. Brilliant, I need to try that out some time soon. I'm kinda thinking of moving this somewhere else, maybe gitlab, so that you don't have to wait for me to merge things in for you. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 06:19:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 04:19:49 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #166 from Robin Sheat --- Commit cd4905c2 (Display facet terms ordered by number of occurrences) introduces a bug when searching with zebra (i.e. it makes it break.) I will roll it back until we get a better solution. Feel free to unroll it back if you get the chance to make one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 07:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 05:42:59 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43319|0 |1 is obsolete| | --- Comment #2 from Joonas Kylm?l? --- Created attachment 43363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43363&action=edit Bug 14999: Fetch the corresponding values for the specific biblio item UPDATE: I added a test plan, and this version also applies cleanly on the master branch. Test plan: 1. In acquisitions add orders to basket from a staged file. You need to add orders which when added doesn't show the right quantity/price in the basket (after it has been added). I succeeded in this by selecting order items from under different headings (in the page "Add orders from iso2709 file"). So this means that you would need to have a staged file with multiple sections in it. 2. Notice the problem with the wrong prices and quantities showing in the basket. 3. Apply this patch. 4. Remove those items you added to the basket and add them again and notice that they have now the corresponding values in them in the basket. 5. Look for anomalies. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 07:43:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 05:43:30 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 07:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 05:47:39 +0000 Subject: [Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43363|0 |1 is obsolete| | --- Comment #3 from Joonas Kylm?l? --- Created attachment 43364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43364&action=edit Bug 14999: Fetch the corresponding values for the specific biblio item Test plan: 1. In acquisitions add orders to basket from a staged file. You need to add orders which when added doesn't show the right quantity/price in the basket (after it has been added). I succeeded in this by selecting order items from under different headings (in the page "Add orders from iso2709 file"). So this means that you would need to have a staged file with multiple sections in it. 2. Notice the problem with the wrong prices and quantities showing in the basket. 3. Apply this patch. 4. Remove those items you added to the basket and add them again and notice that they have now the corresponding values in them in the basket. 5. Look for anomalies. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 08:50:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 06:50:27 +0000 Subject: [Koha-bugs] [Bug 15002] New: All system resources get used if user refreshes a web page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15002 Bug ID: 15002 Summary: All system resources get used if user refreshes a web page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org All system resources get used if the user refreshes a web page multiple times (and then database services etc. start to get killed by the system etc.). Couldn't we have some way to kill the previous perl scripts which were running (I guess the user won't need them), or how could we solve this problem? Could there happen some data loss if we kill the already running perl scripts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 10:39:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 08:39:37 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #7 from Joonas Kylm?l? --- (In reply to M. Tompsett from comment #6) > I wrote: > > I was not able to duplicate issue with Debian Jessie on Master. > > Though, this patch clearly forces sorting. > > (In reply to Jonathan Druart from comment #5) > > They are currently sorted by budget_id. > > My screen says otherwise. I'm wondering if this is a hashes are stored in a > random order issue, because it ordered 2,1,3 on my screen without the patch. Mine too. But this happened only when I had first applied the patch and then retracted it. Before I applied the patch they were ordered by the budget_id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:01:33 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:04:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:04:09 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #31 from Jonathan Druart --- Created attachment 43366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43366&action=edit Bug 14100: Move add form to the top Not sure this is the best: now the messages will make the table moves. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:04:05 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #30 from Jonathan Druart --- Created attachment 43365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43365&action=edit Bug 14100: Better errors handling This patch mainly improves the errors handling. It's now not possible to add a translation for the same entity-code-lang combination. Note that we could add entity,code,lang,translation as a unique key but translation is TEXT (TEXT column 'translation' used in key specification without a key length). Let's see later what's is best here. It also: - wording: Translate for other languages => into - fixes encoding issues on add/update (was just display) - add entity and code to the title of the pop-up window Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:13:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:13:08 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43365|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 43367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43367&action=edit Bug 14100: Better errors handling This patch mainly improves the errors handling. It's now not possible to add a translation for the same entity-code-lang combination. Note that we could add entity,code,lang,translation as a unique key but translation is TEXT (TEXT column 'translation' used in key specification without a key length). Let's see later what's is best here. It also: - wording: Translate for other languages => into - fixes encoding issues on add/update (was just display) - add entity and code to the title of the pop-up window Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:13:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:13:12 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43366|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 43368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43368&action=edit Bug 14100: Move add form to the top Not sure this is the best: now the messages will make the table moves. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:13:58 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #8 from Joonas Kylm?l? --- (In reply to Joonas Kylm?l? from comment #7) > (In reply to M. Tompsett from comment #6) > > I wrote: > > > I was not able to duplicate issue with Debian Jessie on Master. > > > Though, this patch clearly forces sorting. > > > > (In reply to Jonathan Druart from comment #5) > > > They are currently sorted by budget_id. > > > > My screen says otherwise. I'm wondering if this is a hashes are stored in a > > random order issue, because it ordered 2,1,3 on my screen without the patch. > > Mine too. But this happened only when I had first applied the patch and then > retracted it. Before I applied the patch they were ordered by the budget_id. It happened because in acqui-home.tt there is a javascript line which states: 'aaSortingFixed': [[ 1, 'asc' ]], So the table shown to the user is sorted with that. I'm just wondering why it started to only work after I applied the patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:15:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:15:28 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #34 from Jonathan Druart --- (In reply to Katrin Fischer from comment #28) > Hi Joubu, Thanks Katrin for QAing this! > I started testing with the itemtypes administration page and the new modal > for adding the translations. Some first findings: > > 1) I think "Translate for other languages" would work better as "Translate > into other languages". Fixed. > 2) I added "B?cher" as the German translation for "Books" and the umlauts in > the table with the translated strings are broken. Oops, fixed! > 3) I accidentally added the "B?cher" string twice - should we allow multiple > translations for the same lang and entity combination? I added a check on update/insert. You should now get a warning/error message. > 4) There should be a way to delete strings accidentally added, but I don't > see one. There is an empty last cell in the last column, only when you open > the modal a second time the X appears. It should yes, but... I would prefer to see this feature push as it and receive feedback: is it useful? how could we improve it? etc. This will take me ages (because js...) and I don't think the added value is high. And there is a workaround... > 5) I think it would be good to switch the sequence and have the entry field > above the table. > 6) It would be good to show the entity and code you are translating for in > the window somewhere. Done in a separate patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:41:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:41:35 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43367|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 43369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43369&action=edit Bug 14100: Better errors handling This patch mainly improves the errors handling. It's now not possible to add a translation for the same entity-code-lang combination. Note that we could add entity,code,lang,translation as a unique key but translation is TEXT (TEXT column 'translation' used in key specification without a key length). Let's see later what's is best here. It also: - wording: Translate for other languages => into - fixes encoding issues on add/update (was just display) - add entity and code to the title of the pop-up window Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:41:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:41:38 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43368|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 43370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43370&action=edit Bug 14100: Move add form to the top Not sure this is the best: now the messages will make the table moves. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:42:59 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35553|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 43371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43371&action=edit BUG 12027: Added shibboleth authentication to the staff client - This patch adds shibboleth authentication to the staff client. - Depending upon how your url structure works, you may or may not need a second native shibboleth service provider profile configured for this to work. http://bugs.koha-community.org/show_bug.cgi?id=12026 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:43:02 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35554|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 43372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43372&action=edit BUG 12027 [Followup]: Added missing documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:43:45 +0000 Subject: [Koha-bugs] [Bug 12027] Shibboleth authentication for staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 --- Comment #10 from Martin Renvoize --- Rebased again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:47:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:47:20 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com --- Comment #2 from Joonas Kylm?l? --- After doing the test plan you can't remove the filter item (author). If you click the |x| it will stay still there (and if you try again, it will just stay there....). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:53:25 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43345|0 |1 is obsolete| | Attachment #43346|0 |1 is obsolete| | Attachment #43347|0 |1 is obsolete| | Attachment #43348|0 |1 is obsolete| | Attachment #43349|0 |1 is obsolete| | Attachment #43350|0 |1 is obsolete| | Attachment #43351|0 |1 is obsolete| | --- Comment #167 from Jonathan Druart --- Created attachment 43373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43373&action=edit Bug 12478: Display facet terms ordered by number of occurrences By default ES returns the facet terms ordered by most used, which makes sense. This patch removes resort done in the scripts (catalogue/search.pl and opac/opac-search.pl) and moves it to the module. For Zebra it's now done in C4::Search::getRecords, and there is no change to expect (still alphabetically). On the Elastic search side, we could imagine to let the library define the order of the facets. The facet terms are now sorted by most used. To test easily this change, turn on the displayFacetCount pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:54:11 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #168 from Jonathan Druart --- (In reply to Robin Sheat from comment #166) > Commit cd4905c2 (Display facet terms ordered by number of occurrences) > introduces a bug when searching with zebra (i.e. it makes it break.) I will > roll it back until we get a better solution. Feel free to unroll it back if > you get the chance to make one. Oops, sorry about that! The last patch should work now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:56:11 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14923 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:56:11 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:56:35 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:56:35 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. |http://bugs.koha-community. |org/bugzilla3/show_bug.cgi? |org/bugzilla3/show_bug.cgi? |id=14923 |id=14293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:56:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:56:35 +0000 Subject: [Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14975 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:57:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:57:02 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:57:05 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43343|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43374&action=edit Bug 14975 - Fine grace period label is incorrect The column heading for grace period is "Fine grace period (day)" but the grace period works based on the unit selected ( hours or days ). The "(day)" part should be removed as it caused confusion for librarians. Test Plan: 1) Apply this patch 2) Go to the circ rules editor 3) Note the header and footer columns for grace period no longer have "(days)" at the end. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 11:58:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 09:58:28 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #74 from Joonas Kylm?l? --- Jonathan, The commits in GitHub branch look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:07:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:07:45 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:21:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:21:21 +0000 Subject: [Koha-bugs] [Bug 15003] New: Help should be a wiki, not translatable via po-files Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15003 Bug ID: 15003 Summary: Help should be a wiki, not translatable via po-files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at pttk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com [Note: This is brainstorming based on feedback from Vaarakirjastot] Po-files split the help pages into sentences, or worse, into sentence fragments. This makes translating them into fluent language nearly impossible, because they are text articles and direct sentence translation makes bad prose. Each help page should be a single translatable element. As the help pages are already sort-of like wiki, and editable in Koha itself, it would make sense to package the actual help pages for each language separately, which could then be installed (either in Koha itself, or by external means). And/Or perhaps there could be a syspref to use external URL instead of local help, with some substitutions for language, Koha version, and the help article. For example, setting the syspref value to "http://help.koha-community.org/wiki/${lang}/${version}/${article}" would open that page on a wiki set up there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:23:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:23:58 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |j.kylmala at gmail.com --- Comment #28 from Joonas Kylm?l? --- If I go to koha/admin/itemtypes.pl I get: Software error: Template process failed: file error - parse error - /home/putti/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt line 197: unexpected token (eq) [% IF Koha.Preference('AcqCreateItem') eq 'ordering' and Koha.Preference('item-level_itypes') eq '0' %] at /home/putti/kohaclone/C4/Templates.pm line 121. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:24:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:24:35 +0000 Subject: [Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:24:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:24:38 +0000 Subject: [Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43344|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 43375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43375&action=edit Bug 14916: Display overdues if due on 23:59 If an item is due on today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:25:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:25:42 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:25:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:25:45 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Remove C4::Dates from |Overdues are not listed if |circ/overdue.pl |due on 23:59 of the 'to | |date' (Was: Remove | |C4::Dates from | |circ/overdue.pl) Severity|enhancement |normal Assignee|veron at veron.ch |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Marc, Sorry to steal your bug (again), but I think I have found a bug on master. Could you please confirm? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:30:33 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #75 from Jonathan Druart --- (In reply to Joonas Kylm?l? from comment #74) > Jonathan, The commits in GitHub branch look good. I have added you signed-off-by line on the 2 last patch. Feel free to mark the bug report as Signed off if you feel confident enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:48:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:48:48 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:48:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:48:51 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43361|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 43376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43376&action=edit Bug 14920 - Remove C4::Dates from circ/reserveratios.pl This patch removes C4::Dates from circ/reserveratios.pl To test: - Make sure you have many holds for biblios with not so much items (e.g. 5 holds, 1 item) or follow hint below - Go to Home > Circulation > Hold ratios - Verify that everything works the same without an dwith patch Hint: To get a big table you can set 'Hod ratio' in the filter to 0.1 (default value is 3). This was will trigger biblios with less holds than items. Signed-off-by: Hector Castro Works as advertised. Tested with dateformat syspref, datepiker Ok Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:48:54 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 --- Comment #11 from Jonathan Druart --- Created attachment 43377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43377&action=edit Bug 14920: Simplify the date management on reserveratios Note that the previous patch was wrong, the start date defaulted to yesterday, the original behavior is to default to last year. This patch removes some unecessary variable declarations and tests. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:57:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:57:53 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #3 from Jonathan Druart --- I have retried and it works here. What is the url for the [x] link? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 12:59:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 10:59:52 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |claire.hernandez at biblibre.c |ommunity.org |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:02:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:02:52 +0000 Subject: [Koha-bugs] [Bug 12993] Add a default tax rate on item types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #29 from Jonathan Druart --- The 3 occurrences of + [% IF Koha.Preference('AcqCreateItem') eq 'ordering' and Koha.Preference('item-level_itypes') eq '0' %] should be s/eq/== -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:04:30 +0000 Subject: [Koha-bugs] [Bug 9305] Attach adults to each other In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Is this a duplicate with bug 12446? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:19:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:19:44 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- The second patch is not the way to do, especially at the OPAC: if the user turned off JS, he cannot enter a date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:20:25 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |j.kylmala at gmail.com Status|Needs Signoff |In Discussion --- Comment #16 from Joonas Kylm?l? --- I guess this feature should be also be used by OPAC/Staff side. Now the user itself cannot use the feature (only people with access to the db). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:30:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:30:33 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43308|0 |1 is obsolete| | Attachment #43309|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 43378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43378&action=edit Bug 14653 - Acq planning filter always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code : - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the filter form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - In filter form, select "by months" in "Select planning type" => Without patch, you see planning of "B_ACTIVE" with 1 fund => Without patch, you see planning of "B_OLD" with 3 funds Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:30:30 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:30:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:30:36 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 --- Comment #7 from Jonathan Druart --- Created attachment 43379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43379&action=edit Bug 14653 - Acq planning export always use default active period In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export forms have no parameter budget_period_id nor authcat, so the use the default active period. As said in code - IF PERIOD_ID IS DEFINED, GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY DEFAULT my $period = GetBudgetPeriod($budget_period_id); This patch corrects the export form. Test plan : - Create an active budget "B_ACTIVE" with 1 fund - Create an inactive budget "B_OLD" with 3 funds - Go to "B_OLD" planning by libraries - You see 3 funds - Click on "Submit" in export form => Without patch, you get the planning of "B_ACTIVE" with 1 fund => Without patch, you get the planning of "B_OLD" with 3 funds by libraries Signed-off-by: Hector Castro Works as advertised Signed-off-by: Hector Castro Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:31:28 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- So it seems that only 1 library uses this feature :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:34:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:34:07 +0000 Subject: [Koha-bugs] [Bug 15004] New: Allow to change amounts of duplicated budgets Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Bug ID: 15004 Summary: Allow to change amounts of duplicated budgets Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org Use case: "I want to create a '2016' budget, same as '2015' budget, but I will have 15% more (or less) money in 2016, and I don't want to update all the funds manually" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:35:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:35:41 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 --- Comment #1 from Julian Maurice --- Created attachment 43380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43380&action=edit Bug 15004: Allow to change amounts of duplicated budgets When duplicating a budget we now have the possibility to change amounts of budget and funds by a given percentage. Additionally, we can configure how to round the amounts. Test plan: 1. Create a budget and several funds with different amounts 2. Duplicate it using the 2 new options 3. Check that the amounts are correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:35:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:35:49 +0000 Subject: [Koha-bugs] [Bug 15004] Allow to change amounts of duplicated budgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15004 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:49:01 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #4 from Joonas Kylm?l? --- (In reply to Jonathan Druart from comment #3) > I have retried and it works here. > What is the url for the [x] link? http://10.0.3.132/cgi-bin/koha/opac-search.pl?idx=kw&q=a&limit=au%3AHurme-Ker%C3%A4nen%2C%20Auli.&sort_by=relevance_dsc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:54:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:54:52 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:54:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:54:55 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43314|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43381&action=edit Bug 14727: koha-indexer tab completion in bash This patch introduces tab-completion in bash to the koha-indexer command. It completes using valid option switches and instance names. It stops completing then -h or --help are issued, and once a command switch is chosen (either --start, --stop or --restart) it goes ahead with valid instances completion. To test: - Have a packages install (kohadevbox works) - Run: $ . debian/koha-common.bash-completion - Type koha-indexer - Play with all the options => SUCCESS: They work as they should. - Sign off :-D Note: it fixes a small glitch on the plack completion. Signed-off-by: Jesse Weaver Verified working, including filtering out already used options and instances. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 13:56:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 11:56:24 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- The completion works but: root at kohadevbox:~# koha-indexer --start kohadev [ ok ] Starting Koha indexing daemon for kohadev:. root at kohadevbox:~# koha-indexer --stop kohadev [FAIL] Error: Indexer not running for kohadev: failed! root at kohadevbox:~# ps aux | grep zebra kohadev+ 509 0.0 0.0 18596 188 ? S 11:45 0:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --stdout=/var/log/koha/kohadev/zebra.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 511 0.0 0.8 121780 9148 ? S 11:45 0:00 zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 3017 0.0 0.0 18596 188 ? S 11:52 0:00 daemon --name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log --stdout=/var/log/koha/kohadev/indexer.log --output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 kohadev+ 3020 0.8 11.0 341964 113288 ? S 11:52 0:01 /usr/bin/perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:07:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:07:30 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43117|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43382&action=edit Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:08:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:08:01 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #6 from Jonathan Druart --- Indeed, it worked for the intranet, not for the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:10:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:10:38 +0000 Subject: [Koha-bugs] [Bug 15005] New: (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Bug ID: 15005 Summary: (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org The current plack-on-packages schema points the apache vhost (for example for the intranet) like this: /cgi-bin/koha/ => /intranet/ So the code that uses ENV{SCRIPT_NAME} "sees" it is being called for example like /intranet/mainpage.pl. This gets problematic in some scenarios, because it is used to then redirect the browser, or to create links to things. Steps to reproduce: - Check out an old DBRev in the koha repo (1 step older is ok) - Pick the ansible branch from the kohadevbox [1] - Launch it, on jessie: $ vagrant up jessie - Log into it $ vagrant ssh jessie - Enable Plack for the automatically created instance $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev $ sudo service apache2 restart - Get the DB password to be able to login $ koha-pass - Point your browser to the staff interface: http://localhost:8081 - Login with koha_kohadev and the retrieved password => FAIL: You cannot login - Disable Plack for the instance $ sudo koha-plack --disable kohadev $ sudo koha-plack --stop kohadev $ sudo service apache2 restart - Point your browser to the staff interface: http://localhost:8081 - Login with koha_kohadev and the retrieved password => SUCCESS: You can login - Proceed to install with the default data (you can try enabling plack and you will notice it works) - Once you are in, enable plack $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev $ sudo service apache2 restart - Checkout the latest master (so it triggers an update) - Go somewhere inside (about?) - You are required to login (which is expected) => FAIL: the links back are pointing to /intranet/ so they are shortcircuited to the installer cyclically (see screenshot) [1] https://github.com/digibib/kohadevbox/tree/ansible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:11:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:11:15 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 43383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43383&action=edit Wrong links generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:11:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:11:27 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:39:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:39:53 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 15:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 13:40:22 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 16:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 14:17:01 +0000 Subject: [Koha-bugs] [Bug 15006] New: Need to distinguish client timeout from login timeout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Bug ID: 15006 Summary: Need to distinguish client timeout from login timeout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Since patch 13432 was applied the main sip loop times out according to the timeout value. This can cause considerable instability and cause client machines to shutdown if the value is too low. As the timeout variable is a login timeout it is typically on the low side (30sec) for client connections it needs to be over 5mins typically possibly more. Suggest a the time out for active connections be separated from the login timeout. we also need the possibility to switch it off completely. Submit a patch adding a 'client_timeout' parameter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 16:29:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 14:29:54 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #1 from Kyle M Hall --- This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 16:38:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 14:38:07 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 --- Comment #5 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #4) > The completion works but: > > root at kohadevbox:~# koha-indexer --start kohadev > [ ok ] Starting Koha indexing daemon for kohadev:. > root at kohadevbox:~# koha-indexer --stop kohadev > [FAIL] Error: Indexer not running for kohadev: failed! > > root at kohadevbox:~# ps aux | grep zebra > kohadev+ 509 0.0 0.0 18596 188 ? S 11:45 0:00 daemon > --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ > --errlog=/var/log/koha/kohadev/zebra-error.log > --stdout=/var/log/koha/kohadev/zebra.log > --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn > --delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn > -f /etc/koha/sites/kohadev/koha-conf.xml > kohadev+ 511 0.0 0.8 121780 9148 ? S 11:45 0:00 zebrasrv -v > none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml > kohadev+ 3017 0.0 0.0 18596 188 ? S 11:52 0:00 daemon > --name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log > --stdout=/var/log/koha/kohadev/indexer.log > --output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn > --delay=30 --user=kohadev-koha.kohadev-koha -- > /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 > kohadev+ 3020 0.8 11.0 341964 113288 ? S 11:52 0:01 > /usr/bin/perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon > -x -sleep 5 Please fill a bug for that... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:14:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:14:46 +0000 Subject: [Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #25 from Tom?s Cohen Arazi --- Created attachment 43384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43384&action=edit Bug 10020: (RM followup) DBIx update / delete leftover file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:15:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:15:43 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #41 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:16:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:16:09 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:16:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:16:34 +0000 Subject: [Koha-bugs] [Bug 14841] Columns settings on checkouts table have 2 bugs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14841 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:16:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:16:57 +0000 Subject: [Koha-bugs] [Bug 14920] Remove C4::Dates from circ/reserveratios.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14920 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:21:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:21:55 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:22:19 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:22:43 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Rafal! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:27:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:27:18 +0000 Subject: [Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS --- in my opinion, -t should not be used for --table, it is usually used for --test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:31:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:31:26 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:33:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:33:10 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #42 from Nicolas Legrand --- \o/ thanks ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:33:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:33:45 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #2 from Kyle M Hall --- Created attachment 43385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43385&action=edit MARC21 File for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:36:30 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #3 from Kyle M Hall --- Created attachment 43386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43386&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B Test Plan: 1) Import the records in the attached MARC21 file, re-index 2) From the OPAC search for "Frank Einstein and the antimatter motor" 3) Click the series link, note you get no results 4) Apply this patch 5) Refresh the record details page 6) Click the series link 7) Results! NOTE: This bug does not occurr with all Koha server configurations. I have yet to determine the specific variable that creates this truncation behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:36:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:36:28 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:51:20 +0000 Subject: [Koha-bugs] [Bug 15007] New: Slips and notices table 'letters' should have an 'id' primary key column Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007 Bug ID: 15007 Summary: Slips and notices table 'letters' should have an 'id' primary key column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org The recent issues related to duplicate notices have demonstrated that it would be much better to have an id column on letters so these issues not do re-emerge at a later date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 17:51:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 15:51:24 +0000 Subject: [Koha-bugs] [Bug 15007] Slips and notices table 'letters' should have an 'id' primary key column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 18:01:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 16:01:39 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 18:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 16:01:43 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #2 from Jonathan Druart --- Created attachment 43387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43387&action=edit Bug 15005: Replace CGI->url with the corresponding url CGI->url does not return the correct url on install using packages. Test plan: 1/ Try to reproduce the bug from the description of bug 15005. You should be able to login to the intranet and the OPAC 2/ Send a basket and a list from the intranet and the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 18:01:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 16:01:46 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #3 from Jonathan Druart --- Created attachment 43388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43388&action=edit Bug 15005: Remove CGI->url calls from pl scripts Same as previous patch for calls in pl scripts. Test plan: - delete an entry of your search history from intranet and opac - with IndependentBranches=OFF, go on the waiting holds and confirm that the link next to 'Holds awaiting pickup for your library on' is correct. - search for items, the pagination should work correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 18:01:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 16:01:52 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #4 from Jonathan Druart --- Created attachment 43389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43389&action=edit Bug 15005: Fix pagination_bar calls Test plan: Create an order for an existing biblio, confirm that the pagination links work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 18:35:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 16:35:51 +0000 Subject: [Koha-bugs] [Bug 13628] clicking + on patron does nothing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13628 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #1 from Heather Braum --- This was also reported on import_borrowers.pl, on bug 14690. It looks like a patch needs signoff there. Could it apply to this bug, too? I can confirm this continues to be an issue, at least in 3.18.8. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 18:36:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 16:36:18 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 --- Comment #3 from Heather Braum --- This is also an issue for bug 13628. Would this patch fix that bug, too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:00:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:00:50 +0000 Subject: [Koha-bugs] [Bug 15008] New: Add custom HTML areas to circulation and reports home pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Bug ID: 15008 Summary: Add custom HTML areas to circulation and reports home pages Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nengard at gmail.com Add two new sysprefs, IntranetReportsHomeHTML and IntranetCirculationHomeHTML, that define new HTML areas on the reports and circulation home pages respectively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:02:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:02:50 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:03:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:03:57 +0000 Subject: [Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:20:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:20:13 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:23:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:23:31 +0000 Subject: [Koha-bugs] [Bug 4948] canceling a hold missing steps for existing holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:54:17 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43024|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 43390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43390&action=edit [SIGNED-OFF] Bug 14937 - Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay C4::Letters::_parseletter will replace reserves.expirationdate with the date a hold will be marked as problematic ( holds over ) if both ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled. There is no reason this feature needs to rely on ExpireReservesMaxPickUpDelay as there are many libraries that would like to send the last day to pick up a hold in notices, but would rather deal with the expired waiting holds manually rather than have Koha cancel them automatically. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Disable ExpireReservesMaxPickUpDelay 4) Add reserves.expirationdate to your HOLD notice 5) Fill a hold for a patron 6) View the message, not that reserves.expirationdate is replaced with the date the hold will be marked as problematic Signed-off-by: Karl Holton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:54:15 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:55:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:55:07 +0000 Subject: [Koha-bugs] [Bug 14235] Items appear as LOST when Missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14235 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:58:13 +0000 Subject: [Koha-bugs] [Bug 13950] Sort Item search home library list by branch name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13950 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:58:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:58:39 +0000 Subject: [Koha-bugs] [Bug 15009] New: Planning dropdown button in aqbudget can have empty line Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Bug ID: 15009 Summary: Planning dropdown button in aqbudget can have empty line Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 43391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43391&action=edit Planning dropdown having useless fourth row When displaying a budget, the Planning button in the admin toolbar displays Plan by months Plan by libraries Plan by item types Plan by The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 21:59:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 19:59:24 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 22:01:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 20:01:55 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 22:19:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 20:19:00 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 --- Comment #1 from Blou --- Created attachment 43392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43392&action=edit Bug 15009 - Planning dropdown button in aqbudget can have empty line When displaying a budget, the Planning button in the admin toolbar displays Plan by months Plan by libraries Plan by item types Plan by The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined. This prevents returning an array with empty element(s) TEST: 1) Admin -> Budgets 2) Select a budget a) you must have '' (empty) in your aqbudgets.sort1_authcat field. b) edit the budget (direct DB or interface) to get that. 3) Click on Planning dropdown, see the "Plan by " entry. 4) apply the patch, revalidate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 22:19:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 20:19:42 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 13 23:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 21:40:48 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx at gmail.com --- Comment #5 from H?ctor Eduardo Castro Avalos --- Hi Marc Yet another line with C4::Dates in admin/categorie.pl $category->enrolmentperioddate( C4::Dates::format_date( $category->enrolmentperioddate() ) ); This in line 286 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 00:05:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 22:05:27 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Katrin Fischer --- Hi Jonathan, thx for the changes. I continue with checking the pages and scripts changed, some more findings: 1) The pull down on reports/bor_issues_top.pl is empty apart from the 'any' entry. 2) There is something weird about sorting going on. Example: With the sample data, translate only MP = Maps to "Test" for another language. Go to the item search page - check the pull down: Test is sorted, as if it was still Maps. I think it would make more sense to sort always by the displayed description. 3) The intranet result list doesn't show the right description in the right column with the item information. It still lists 'Books' when it should be 'B?cher' 4) Same for the itemtype facet descriptions in staff and the OPAC - the new translations are not used. It would be good to at least solve this for the OPAC side. 5) Not working on OPAC advanced search. 6) Not working for opac-topissues.pl filters and result list. Only opac page working seems to be the opac/detail.pl page? Lost patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 00:07:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 22:07:35 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |hector.hecaxmmx at gmail.com --- Comment #3 from H?ctor Eduardo Castro Avalos --- A problem when creating a new holiday The 'day' parameter ("32") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'year', 2015, 'month', 10, 'day', 32) called at /home/koha/kohaclone/tools/newHolidays.pl line 67 The error was launched when enter an invalid date, for example >From date: Fridays, 30/10/2015 To date: 32/10/2015 this is DD/MM/YYYY -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 00:07:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 22:07:53 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #38 from Katrin Fischer --- 7) The duplicate check only seems to work if entity - code - langauge - description are the same - but it should only be entity - code - langauge identical instead. Multiple German translations for the same itemtype make no sense :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 00:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 22:31:38 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #4 from H?ctor Eduardo Castro Avalos --- Another thing observed is: if you edit a holiday you can see in the first date, the form set it in dateformat syspref, but when you include a new date in the text field 'To Date:' from datepicker you'll see another format with hyphens not following the syspref. Example: >From date: Thursdays, 2015/12/24 To Date : 2015-12-24 And again, if you alter the date to 2015-12-32 the same error is shown in the screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 01:47:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 23:47:17 +0000 Subject: [Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 01:52:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 23:52:04 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 01:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 13 Oct 2015 23:52:22 +0000 Subject: [Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 02:44:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 00:44:02 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christopherlawrencekirby at gm | |ail.com Status|Needs Signoff |Signed Off --- Comment #5 from Chris Kirby --- Tested on sandboxes as follows: - Set OpacLangSelectorMode to 'both' - Went to SCO page - Verified that the language menu did not display in the header - Entered a card number to check out (this logs in the SCO user) - Verified that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Requested that that patch be applied to a separate sandbox - Verified that the language menu appears and the SCO user's information disappears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 03:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 01:07:55 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #169 from Robin Sheat --- (In reply to Jonathan Druart from comment #168) > Oops, sorry about that! > The last patch should work now. It does, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 03:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 01:54:14 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #15 from Robin Sheat --- Rebased this on top of the current ES code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 04:31:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 02:31:17 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 04:31:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 02:31:20 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 --- Comment #1 from Liz Rea --- Created attachment 43393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43393&action=edit Bug 14676 - UI/UX improvements to patron card creator Reasoning Librarians will be doing patron card things in the following frequencies, from most frequent to least frequent: 1. Creating new patron card batches - every day/every few days 2. Managing existing card batches - every day/every few days 3. Managing existing card layouts - as needed, infrequent 5. Managing existing card templates - as needed, infrequent 6. Creating new card layouts - as needed, infrequent 7. Creating new card templates - as needed, infrequent 8. Managing existing printer profiles - possibly once only! 9. Creating new printer profiles - possibly once only! This change to the patron card creator aims to make the most frequently used items easily accessible at the top of the main area, reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha. I think I've also improved the translatability here somewhat, please check that. To test: Open the patron card creator: More -> Tools -> Patron card creator Note that the toolbar has changed. It should be consistent across all of the patron card creator (it is an include). + New menu: patron card batch 1. make sure it looks ok - toolbar buttons are consistent at the top of the main block. 2. add patrons both by borrowernumber, and by search 3. note that the usual buttons have moved below the textarea, and now have icons. 4. delete and export single patrons using the buttons corresponding to each patron 5. select multiple and use the buttons above the table to remove and export selected patrons 6. export a full batch 7. deduplicate a batch There should be no regressions in functionality. Image 1. This menu item should take you directly to the upload/delete images interface 2. Upload an image, note success message is now below the form, eliminating the jumping box. 3. Delete single images using the buttons 4. Delete multiple images using the tickboxes and "Delete selected" 5. Not deletion success message is below the table, eliminating the jumping box. Layout 1. This menu item should take you directly to the "Edit layout" screen. 2. no functional changes here. 3. note toolbar at top is consistent Card template 1. this menu item should take you directly to the "Edit patron card template" page. 2. no functional changes here. 3. note toolbar at top is consistent. Printer profile 1. this menu item should take you directly to the "Edit printer profile" page. 2. no functional changes here. 3. note toolbar at top is consistent. + Manage menu: Card batches 1. This menu item should take you directly to the "currently available batches" page. 2. select a batch to edit using the buttons - it should take you to the editing interface 3. select a batch to delete using the buttons - it should ask for confirm. 4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal. 5. note toolbar at top is consistent. Images (this is actually the same page as on the new menu, I included it in both because it does both functions - can change if requested) 1. This menu item should take you directly to the upload/delete images interface 2. Upload an image, note success message is now below the form, eliminating the jumping box. 3. Delete single images using the buttons 4. Delete multiple images using the tickboxes and "Delete selected" 5. Not deletion success message is below the table, eliminating the jumping box. Layouts 1. This menu item should take you directly to the "currently available layouts" page. 2. select a layout to edit using the buttons 3. select a layout to delete using the buttons 4. note toolbar at top is consistent. Card templates 1. This menu item should take you directly to the "currently available templates" page. 2. select a template to edit using the buttons 3. select a template to delete using the buttons 4. note toolbar at top is consistent. Printer profiles 1. This menu item should take you directly to the "currently available profiles" page. 2. select a profile to edit using the buttons 3. select a profile to delete using the buttons 4. note toolbar at top is consistent + General * note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up. Please note that I am happy to take suggestions/amendments to these changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 06:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 04:02:29 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14676 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 [Bug 14676] UI/UX enhancements for the patron card creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 06:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 04:02:29 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14131 --- Comment #2 from Marc V?ron --- Hi Liz, Great! (However I could not yet test). I note here following Bug because I think it will depend from that one: Bug 14131 - Patroncard: Add possibility to print from patron lists Marc Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 [Bug 14131] Patroncard: Add possibility to print from patron lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 10:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 08:39:42 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 --- Comment #3 from Liz Rea --- Hmm, yes. I'll have a look at your patch and see what I see. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:24:49 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #39 from Jonathan Druart --- (In reply to Katrin Fischer from comment #37) > Hi Jonathan, > > thx for the changes. I continue with checking the pages and scripts changed, > some more findings: > > 1) The pull down on reports/bor_issues_top.pl is empty apart from the 'any' > entry. Will be fixed. > 2) There is something weird about sorting going on. Example: With the sample > data, translate only MP = Maps to "Test" for another language. Go to the > item search page - check the pull down: Test is sorted, as if it was still > Maps. I think it would make more sense to sort always by the displayed > description. Yes, sometimes it's ordered by 'itemtype' and sometimes by 'description'. I have not changed the behavior when it's ordered by itemtype here, but it could be done on top of bug 14828. > 3) The intranet result list doesn't show the right description in the right > column with the item information. It still lists 'Books' when it should be > 'B?cher' I have not found this info (unimarc?) but I think I have fixed it. > 4) Same for the itemtype facet descriptions in staff and the OPAC - the new > translations are not used. It would be good to at least solve this for the > OPAC side. Same. > 5) Not working on OPAC advanced search. Fixed. > 6) Not working for opac-topissues.pl filters and result list. Fixed. > Only opac page working seems to be the opac/detail.pl page? Lost patch? I don't think so :) (In reply to Katrin Fischer from comment #38) > 7) The duplicate check only seems to work if entity - code - langauge - > description are the same - but it should only be entity - code - langauge > identical instead. Multiple German translations for the same itemtype make > no sense :) Yes! And I have added the unique key at the DB level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:25:20 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43369|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 43394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43394&action=edit Bug 14100: Better errors handling This patch mainly improves the errors handling. It's now not possible to add several translations for the same entity-code-lang combination. It also: - wording: Translate for other languages => into - fixes encoding issues on add/update (was just display) - add entity and code to the title of the pop-up window Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:25:25 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43370|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 43395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43395&action=edit Bug 14100: Move add form to the top Not sure this is the best: now the messages will make the table moves. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:25:30 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #42 from Jonathan Druart --- Created attachment 43396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43396&action=edit Bug 14100: Fix some missing occurrences This patch fixes: - reports/bor_issues_top.pl - sort order - adv search and search results - opac-topissues.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:27:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:27:15 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #6 from Fridolin SOMERS --- (In reply to Marc V?ron from comment #5) > (In reply to Marc V?ron from comment #3) > > > - I would like to see the page id.... > I mean the news id that is used to create the link. Indeed, I was thinking to even show the OPAC full url. So one can copy/paste into OPACNav for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:28:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:28:49 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #7 from Fridolin SOMERS --- (In reply to Marc V?ron from comment #3) > > PS: > (One small thing in opac/opac-page.pl,line 2 says "This script lets the > users change their privacy rules") Oups, copy/paste error, I change it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:29:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:29:32 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:31:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:31:03 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43340|0 |1 is obsolete| | --- Comment #8 from Fridolin SOMERS --- Created attachment 43397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43397&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:31:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:31:48 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Fridolin SOMERS --- @Marc Please re-signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 11:38:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 09:38:21 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #10 from Fridolin SOMERS --- (In reply to Marc V?ron from comment #3) > > - Flag news to display only as CMS page > I think this is the first feat to develop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 12:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 10:23:37 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 sally.healey at cheshirewestandchester.gov.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshirewestan | |dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:10:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:10:59 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #14 from Barton Chittenden --- (In reply to Jonathan Druart from comment #13) > Barton, > I am sorry but I think there was a misunderstanding. > The idea was not to add more complexity but simplify the --category and > --skip-category options. > Could you please have a look at the last patch and, if you agree with this > change, add your signoff on it? I eyeballed it; it looks good. I'll run a quick test and sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:19:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:19:25 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 --- Comment #10 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #8) > So it seems that only 1 library uses this feature :) Indeed :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:38:28 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #15 from Fridolin SOMERS --- (In reply to Marc V?ron from comment #14) > Hi Julian and Fridolin, > > It might be a good idea to have a separate syspref for the behavior of the > most popular list instead of the double use of 'AdvancedSearchTypes' > > It would make things much more clearer. > > What do you think? > > Marc I agree -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:48:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:48:21 +0000 Subject: [Koha-bugs] [Bug 15010] New: Import patron tool creates 'duplicate' restrictions ( debarments ) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Bug ID: 15010 Summary: Import patron tool creates 'duplicate' restrictions ( debarments ) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:51:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:51:14 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 --- Comment #1 from Kyle M Hall --- Created attachment 43398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43398&action=edit Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). Test Plan: 1) Create a patron with one or more restrictions 2) Import a CSV file that updates that patron, but with no debarred columns 3) Note a new restrictions is created 4) Delete the new restriction 5) Apply this patch 6) Re-import the CSV file again 7) Note that no new restriction is created 8) Add debarred and debarredcomment columns to the CSV file with a test date and description 9) Re-import the CSV file again 10) Note the new restriction is added to the patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:51:12 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:51:23 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 14:56:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 12:56:00 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #5 from Jonathan Druart --- Breaking news: Add this line to /etc/koha/sites/kohadev/plack.psgi enable "ReverseProxyPath"; And this one to /etc/koha/apache-shared-intranet-plack.conf RequestHeader set "X-Forwarded-Script-Name" /cgi-bin/koha fix the $ENV{SCRIPT_NAME}! ($cgi->url still does not work) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:20:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:20:10 +0000 Subject: [Koha-bugs] [Bug 15011] New: koha-indexer --stop does not work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Bug ID: 15011 Summary: koha-indexer --stop does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org root at kohadevbox:~# koha-indexer --start kohadev [ ok ] Starting Koha indexing daemon for kohadev:. root at kohadevbox:~# koha-indexer --stop kohadev [FAIL] Error: Indexer not running for kohadev: failed! root at kohadevbox:~# ps aux | grep zebra kohadev+ 509 0.0 0.0 18596 188 ? S 11:45 0:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --stdout=/var/log/koha/kohadev/zebra.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 511 0.0 0.8 121780 9148 ? S 11:45 0:00 zebrasrv -v none,fatal,warn -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 3017 0.0 0.0 18596 188 ? S 11:52 0:00 daemon --name=kohadev-koha-indexer --errlog=/var/log/koha/kohadev/indexer-error.log --stdout=/var/log/koha/kohadev/indexer.log --output=/var/log/koha/kohadev/indexer-output.log --verbose=1 --respawn --delay=30 --user=kohadev-koha.kohadev-koha -- /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 kohadev+ 3020 0.8 11.0 341964 113288 ? S 11:52 0:01 /usr/bin/perl /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -daemon -x -sleep 5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:20:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:20:23 +0000 Subject: [Koha-bugs] [Bug 14727] koha-indexer tab completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15011 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:20:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:20:23 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14727 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:23:55 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 --- Comment #1 from Jonathan Druart --- Created attachment 43399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43399&action=edit Bug 15011: koha-indexer should define the --pidfiles on starting the daemon The --pidfiles options is not provided on starting the daemon and the is_indexer_running consider that the daemon is not running Test plan: koha-indexer start koha-indexer stop should start and stop the zebra daemon wuthout any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:23:52 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:42:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:42:53 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:44:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:44:46 +0000 Subject: [Koha-bugs] [Bug 15012] New: koha-shell raises " no job control in shell" error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Bug ID: 15012 Summary: koha-shell raises " no job control in shell" error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org vagrant at kohadevbox:kohaclone(master)$ sudo koha-shell kohadev bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell kohadev-koha at kohadevbox:/home/vagrant/kohaclone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:48:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:48:15 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:48:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:48:17 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 --- Comment #1 from Jonathan Druart --- Created attachment 43400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43400&action=edit Bug 15012: use sudo instead of su in koha-shell Not sure this is the best way to fix it but it looks to work. Test plan: sudo koha-shell kohadev should not return any error Without this patch, you should get bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell Confirm that other options work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:48:24 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:48:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:48:27 +0000 Subject: [Koha-bugs] [Bug 15011] koha-indexer --stop does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15011 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43399|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 43401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43401&action=edit Bug 15011: koha-indexer should define the --pidfiles on starting the daemon The --pidfiles options is not provided on starting the daemon and the is_indexer_running consider that the daemon is not running Test plan: koha-indexer start koha-indexer stop should start and stop the zebra daemon wuthout any error. Signed-off-by: Tomas Cohen Arazi Tested on kohadevbox:ansible sudo debian/scripts/koha-indexer --stop kohadev sudo debian/scripts/koha-indexer --start kohadev sudo debian/scripts/koha-indexer --restart kohadev All work as expected on the different scenarios. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:48:58 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:49:20 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #17 from Katrin Fischer --- Hi Kyle, I think we don't need a system preference, because we can find out what the right value is within Koha: 1) Look up, which authorised value is linked to 942$n 2) Look up for the authorised value, which description is used for the value 1 Does this make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:52:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:52:36 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #18 from Katrin Fischer --- ... and the value you get, you pass into the XSLT using a similar mechanism as for the system preferences. And later on we can enhance it to also work for mulitple translations, when a similar mechanism as proposed in 14100 is implemented for authorised values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:54:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:54:16 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:54:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:54:19 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43400|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 43402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43402&action=edit Bug 15012: use sudo instead of su in koha-shell Not sure this is the best way to fix it but it looks to work. Test plan: sudo koha-shell kohadev should not return any error Without this patch, you should get bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell Confirm that other options work as before Signed-off-by: Tomas Cohen Arazi Works as expected. Tested on kohadevbox:ansible. KOHA_CONF and PERL5LIB are correctly set on the child shell. Bonus point: koha-shell doesn't die if the user issues Ctrl+C to abort an execution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:55:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:55:31 +0000 Subject: [Koha-bugs] [Bug 14901] koha-shell killed by control-c In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14901 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 15012 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:55:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:55:31 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- *** Bug 14901 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:56:03 +0000 Subject: [Koha-bugs] [Bug 11775] koha-shell displays warning on Debian Wheezy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11775 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 15012 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 15:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 13:56:03 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- *** Bug 11775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 16:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 14:10:58 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 16:11:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 14:11:03 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #177 from Jonathan Druart --- Created attachment 43403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43403&action=edit Bug 14544: allow_delete_own == 0 could represent a read-only list This patch reintroduces the previous behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 16:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 14:12:18 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #178 from Jonathan Druart --- Marcel, The last patch reintroduces the read-only list feature/bug :) If we decide later to remove it, we would be able to do it reverting this patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 16:17:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 14:17:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #179 from Marcel de Rooy --- I plan to look at this again Friday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:32:54 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43397|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 43404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43404&action=edit Bug 14980 - Add a page showing one news The news system allow to create rich HTML content on OPAC main page. This enh proposes a new page that shows one of these new. Test plan : - Go to Tools > News - Create a new entry - Enter a title and a few content - Save - You see the new entry in table - Note its number, for example 3 - Go to opac and enter URL : /cgi-bin/koha/opac-page.pl?id=3 Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:33:20 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:35:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:35:54 +0000 Subject: [Koha-bugs] [Bug 11368] Add script to import Lexile scores In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11368 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:43:39 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:43:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:43:46 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:43:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:43:51 +0000 Subject: [Koha-bugs] [Bug 14713] remaining_permissions permission under the "updatecharges" permission not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14713 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 18:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 16:49:17 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #20 from Nicole C. Engard --- 11:48 ~/kohaclone (master % u=)$ git qa 13590 >From git://git.koha-community.org/koha * branch master -> FETCH_HEAD Branch bug13590-qa set up to track remote branch master from origin. Switched to a new branch 'bug13590-qa' Bug 13590 - Add ability to charge fines at start of charge period 41151 - Bug 13590 - Add ability to charge fines at start of charge period Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13590 - Add ability to charge fines at start of charge period Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation_Issuingrule.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation_Issuingrule.t Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging Koha/Schema/Result/Issuingrule.pm Failed to merge in the changes. Patch failed at 0001 Bug 13590 - Add ability to charge fines at start of charge period When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13590---Add-ability-to-charge-fines-at-start-o-yKwpQy.patch 11:48 ~/kohaclone (bug13590-qa *+%|AM u=)$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:10:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:10:56 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_3_22_candidate --- Comment #140 from Tom?s Cohen Arazi --- I think this is a candidate for 3.22 once it is PQA, and also includes big warning about its experimental status. My only problem with the current implementation is that I think it should have value builders for fixed lenght. But overall I think it is an interesting tool for some people, and doesn't break Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:16:28 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 --- Comment #6 from Marc V?ron --- Hi Jonathan, No problem, steal as much as you like :-) And confirmed, sign-off follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:17:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:17:37 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43375|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 43405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43405&action=edit Bug 14916: Display overdues if due on 23:59 If an item is due on today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Issue reproduced, it's resloved with this patch. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:17:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:17:49 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:18:46 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:18:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:18:50 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41151|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 43406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43406&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:30:21 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 --- Comment #13 from Barton Chittenden --- (In reply to Barton Chittenden from comment #12) > (In reply to Jonathan Druart from comment #10) > > > > The author's patch is "From: Koha instance bug_14617-koha > > " > > Fixed author of patch. Jonathan, can you take a quick look at this? I fixed the 'author' and 'email' on the patch. Thanks, --Barton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:31:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:31:55 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:31:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:31:57 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #22 from Nicole C. Engard --- Created attachment 43407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43407&action=edit [SIGNED-OFF] Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules Signed-off-by: Daniel Grobani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:50:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:50:19 +0000 Subject: [Koha-bugs] [Bug 15013] New: test option (-t) does not work in batchRebuildItemsTables.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15013 Bug ID: 15013 Summary: test option (-t) does not work in batchRebuildItemsTables.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz batchRebuildItemsTables.pl should allow a dry-run using the '-t' parameter, but the script aborts instead, due to the following line: pod2usage(1) if ($help || (!$confirm)); The logic for actually committing records to the database is in place farther on in the code, so we shouldn't be quitting there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 19:59:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 17:59:01 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43362|0 |1 is obsolete| | --- Comment #9 from Marc V?ron --- Comment on attachment 43362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43362 Bug 14956 - (follow) Prevent patrons to insert invalid dates in opac-memberentry.tt Obsoleted this patch becaues of comment #8, replacment patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 20:01:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 18:01:36 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #10 from Marc V?ron --- Created attachment 43408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43408&action=edit Bug 14956 - (follow) Validate incoming birth date This patch validates the birthdate and resets it to empty if date is not valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 20:02:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 18:02:20 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 20:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 18:17:36 +0000 Subject: [Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED --- Comment #7 from Marc V?ron --- Date strings can be validated by using dt_from_string inside an eval{ }. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:01:22 +0000 Subject: [Koha-bugs] [Bug 10839] Claim report of all vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10839 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:02:03 +0000 Subject: [Koha-bugs] [Bug 12178] Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:07:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:07:14 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #30 from bondiurbano --- (In reply to Holger Mei?ner from comment #27) > Sry it took so long, bondiurbano! > > Now bug 14101 and 14395 have their own unit tests. Setting back to signed > off. Holger! My friend! You did not abandon me, didn't you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:25:35 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #6 from Marc V?ron --- Hi H?ctor, Thaks for this catch. The date formatting is not necessary here. Additionally, there is a bug: enrolmentperiod and enrolmentperioddate are not transmitted to the template. To verify, try to delete some categories. The confirmation screen will always display Enrollment period: until instead of Enrollment period: 99 months or Enrollment period: until (a date) Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:26:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:26:48 +0000 Subject: [Koha-bugs] [Bug 12452] check susbscription expiration doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12452 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:29:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:29:54 +0000 Subject: [Koha-bugs] [Bug 15007] Slips and notices table 'letters' should have an 'id' primary key column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:55:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:55:14 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #7 from Marc V?ron --- Created attachment 43409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43409&action=edit Bug 14949 - Remove remaining C4::Dates and fix display in admin/categorie.pl This patch removes a remaining C4::Dates from admin/categroie.pl and fixes the display of "Enrollment period" on the confirmation screen for deleting. To verify and test pls. refer to comments #5 and #6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 21:55:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 19:55:45 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 23:10:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 21:10:33 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43300|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 43410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43410&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 23:20:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 21:20:12 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 23:40:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 21:40:19 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43393|0 |1 is obsolete| | --- Comment #4 from Marc V?ron --- Created attachment 43411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43411&action=edit Bug 14676 - UI/UX improvements to patron card creator Reasoning Librarians will be doing patron card things in the following frequencies, from most frequent to least frequent: 1. Creating new patron card batches - every day/every few days 2. Managing existing card batches - every day/every few days 3. Managing existing card layouts - as needed, infrequent 5. Managing existing card templates - as needed, infrequent 6. Creating new card layouts - as needed, infrequent 7. Creating new card templates - as needed, infrequent 8. Managing existing printer profiles - possibly once only! 9. Creating new printer profiles - possibly once only! This change to the patron card creator aims to make the most frequently used items easily accessible at the top of the main area, reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha. I think I've also improved the translatability here somewhat, please check that. To test: Open the patron card creator: More -> Tools -> Patron card creator Note that the toolbar has changed. It should be consistent across all of the patron card creator (it is an include). + New menu: patron card batch 1. make sure it looks ok - toolbar buttons are consistent at the top of the main block. 2. add patrons both by borrowernumber, and by search 3. note that the usual buttons have moved below the textarea, and now have icons. 4. delete and export single patrons using the buttons corresponding to each patron 5. select multiple and use the buttons above the table to remove and export selected patrons 6. export a full batch 7. deduplicate a batch There should be no regressions in functionality. Image 1. This menu item should take you directly to the upload/delete images interface 2. Upload an image, note success message is now below the form, eliminating the jumping box. 3. Delete single images using the buttons 4. Delete multiple images using the tickboxes and "Delete selected" 5. Not deletion success message is below the table, eliminating the jumping box. Layout 1. This menu item should take you directly to the "Edit layout" screen. 2. no functional changes here. 3. note toolbar at top is consistent Card template 1. this menu item should take you directly to the "Edit patron card template" page. 2. no functional changes here. 3. note toolbar at top is consistent. Printer profile 1. this menu item should take you directly to the "Edit printer profile" page. 2. no functional changes here. 3. note toolbar at top is consistent. + Manage menu: Card batches 1. This menu item should take you directly to the "currently available batches" page. 2. select a batch to edit using the buttons - it should take you to the editing interface 3. select a batch to delete using the buttons - it should ask for confirm. 4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal. 5. note toolbar at top is consistent. Images (this is actually the same page as on the new menu, I included it in both because it does both functions - can change if requested) 1. This menu item should take you directly to the upload/delete images interface 2. Upload an image, note success message is now below the form, eliminating the jumping box. 3. Delete single images using the buttons 4. Delete multiple images using the tickboxes and "Delete selected" 5. Not deletion success message is below the table, eliminating the jumping box. Layouts 1. This menu item should take you directly to the "currently available layouts" page. 2. select a layout to edit using the buttons 3. select a layout to delete using the buttons 4. note toolbar at top is consistent. Card templates 1. This menu item should take you directly to the "currently available templates" page. 2. select a template to edit using the buttons 3. select a template to delete using the buttons 4. note toolbar at top is consistent. Printer profiles 1. This menu item should take you directly to the "currently available profiles" page. 2. select a profile to edit using the buttons 3. select a profile to delete using the buttons 4. note toolbar at top is consistent + General * note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up. Please note that I am happy to take suggestions/amendments to these changes. Followed test plan, behaves as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 14 23:40:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 21:40:38 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 00:08:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 14 Oct 2015 22:08:33 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m, liz at catalyst.net.nz --- Comment #5 from Jesse Weaver --- Possible 3.18 candidate, por favor? Can be triggered by locked budgets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 02:09:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 00:09:44 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 02:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 00:28:33 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 02:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 00:28:36 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43386|0 |1 is obsolete| | --- Comment #4 from Mason James --- Created attachment 43412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43412&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B Test Plan: 1) Import the records in the attached MARC21 file, re-index 2) From the OPAC search for "Frank Einstein and the antimatter motor" 3) Click the series link, note you get no results 4) Apply this patch 5) Refresh the record details page 6) Click the series link 7) Results! NOTE: This bug does not occurr with all Koha server configurations. I have yet to determine the specific variable that creates this truncation behavior. Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 02:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 00:30:04 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #5 from Mason James --- > Signed-off-by: Mason James thanks Barton - patch works perfectly for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:21:19 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #6 from Mason James --- Created attachment 43413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43413&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] correct 2 other problematic series links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:22:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:22:45 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:23:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:23:24 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #7 from Mason James --- (In reply to Mason James from comment #6) > Created attachment 43413 [details] [review] > Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] switching back to 'needs signoff' for followup patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:32:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:32:52 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- (In reply to Marcel de Rooy from comment #1) > To make life easier when multiple instances are uploading temporary > files to Koha, this patch adds the database name to the upload subfolder > in your /tmp folder. /tmp may empty after a reboot. I think I best do more testing to understand file flow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:33:41 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13316 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:33:41 +0000 Subject: [Koha-bugs] [Bug 13316] Opac series search adding a delimiter in the wrong place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13316 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 03:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 01:34:29 +0000 Subject: [Koha-bugs] [Bug 13316] Opac series search adding a delimiter in the wrong place In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13316 --- Comment #1 from Mason James --- i think this bug is a dupe of bug 14716 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 04:05:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 02:05:01 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42491|0 |1 is obsolete| | --- Comment #14 from Liz Rea --- Created attachment 43414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43414&action=edit Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF Modified patch to work with Bug 14676 changes. Functionality unchanged. Signed-off-by: Nick Clemens Signed-off-by: Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 04:09:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 02:09:20 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #15 from Liz Rea --- Hm, I could possibly look after the ergonomic things once both this and 14676 are upstream, because the suggestions would only apply on the current UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 05:46:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 03:46:19 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #5 from Robin Sheat --- This looks like it could be good. Seems faster than waiting on whoever to fix su, anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 06:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 04:15:37 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #16 from Liz Rea --- Created attachment 43415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43415&action=edit Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 08:53:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 06:53:12 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43008|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 43416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43416&action=edit Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 Tested on top of 14788. Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 08:53:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 06:53:32 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 08:54:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 06:54:41 +0000 Subject: [Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Marc V?ron --- *** This bug has been marked as a duplicate of bug 11139 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 08:54:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 06:54:41 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #17 from Marc V?ron --- *** Bug 12136 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 10:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 08:11:18 +0000 Subject: [Koha-bugs] [Bug 14893] Separate temporary storage per instance in Upload.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 --- Comment #3 from Marcel de Rooy --- (In reply to M. Tompsett from comment #2) > (In reply to Marcel de Rooy from comment #1) > > To make life easier when multiple instances are uploading temporary > > files to Koha, this patch adds the database name to the upload subfolder > > in your /tmp folder. > > /tmp may empty after a reboot. I think I best do more testing to understand > file flow. Not necessarily. Depends on your configuration. On Debian, check /etc/default/rcS # delete files in /tmp during boot older than x days. # '0' means always, -1 or 'infinite' disables the feature #TMPTIME=0 Note that when the OS empties the /tmp folder, this is not a problem. The files that we stored there were temporary. A future cronjob will remove all entries in the upload table that are not found anymore. Of course, one should not set /tmp as the location for permanent storage :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 10:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 08:42:16 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #22 from Jonathan Druart --- Could anyone interested in this bug report have a look at the last patch and try to understand what's wrong? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 10:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 08:42:29 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Same here about 4-8. New sequence looks good to me, but is there a reason we > don't display all reasons why a hold can not be placed? Kyle, I am not sure this patch addresses correctly the problem. I think the logic should be reworked in the script. But yes I know it will certainly be more difficult that just switching some conditional blocks in the template, so maybe it is worth to go first with this patch. Could you please answer Katrin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:04:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:04:45 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:04:48 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43390|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43417&action=edit Bug 14937 - Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay C4::Letters::_parseletter will replace reserves.expirationdate with the date a hold will be marked as problematic ( holds over ) if both ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled. There is no reason this feature needs to rely on ExpireReservesMaxPickUpDelay as there are many libraries that would like to send the last day to pick up a hold in notices, but would rather deal with the expired waiting holds manually rather than have Koha cancel them automatically. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Disable ExpireReservesMaxPickUpDelay 4) Add reserves.expirationdate to your HOLD notice 5) Fill a hold for a patron 6) View the message, not that reserves.expirationdate is replaced with the date the hold will be marked as problematic Signed-off-by: Karl Holton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:08:47 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 --- Comment #11 from Jonathan Druart --- Lari, Don't you think it would be better to have the 2 prefs on the same line (Same as OpacSeparateHoldings and OpacSeparateHoldingsBranch)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:13:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:13:56 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #80 from Jonathan Druart --- Could you please provide tests for the new package? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:16:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:16:40 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- I get a software error if the dates are not correctly formatted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:18:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:18:16 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:18:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:18:19 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43262|0 |1 is obsolete| | Attachment #43301|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 43418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43418&action=edit Bug 14926 - Remove C4::Dates from members/printfeercpt.pl This patch removes C4::Dates from members/printfeercpt.pl To test: - Go to a patron's fines (members/boraccount.pl) and make sure that he/she has made a payment - Select 'Print' in the payment's line - Verify that the payment date on the slip displays correctly Signed-off-by: Hector Castro Works as advertised. Date displayed 2015-10-08 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:18:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:18:25 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 --- Comment #11 from Jonathan Druart --- Created attachment 43419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43419&action=edit Bug 14926: Format the date according to the dateformat syspref Signed-off-by: Hector Castro Works as advertised. Tested with the three values from dateformat syspref Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:24:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:24:34 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #17 from Jonathan Druart --- Marc, I think that 14950 has introduced a bug (3 instead of 03), do you agree with that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:34:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:34:37 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #31 from Holger Mei?ner --- I apologize. We have a bit of staff shortage here. But don't worry, it's on my to-do-list. I hope I'll get it done next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:34:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:34:50 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:34:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:34:53 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43255|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 43420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43420&action=edit Bug 14861 - [SIGNED OFF] Accession date comparison does not work in advanced search _Test plan_ Prerequisites: Make sure that you have an item with a valid dateaccessioned, and that the bib is indexed in zebra. For the purposes of explanation, I'm going to use the date '2011-09-07' 1) Go to advanced search in the staff client and choose 'Acquisition date (yyyy-mm-dd)' 2) Enter 2011-09-07 (or the date of your choice). 3) Click the search button - you should get your item in the search results. 4) Return to the advanced search screen and select Acquisition date again. 5) Enter a start and end date in the text field separated by ' - '. For example: 2011-09-01 - 2011-09-30 6) Click the search button -- this will return no results. 7) Apply the patch and copy etc/zebradb/ccl.properties to whatever directory is specified by the koha-conf.xml referenced by $KOHA_CONF. 8) Try the search again -- this will return the expected results Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:43:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:43:17 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #17 from Marc V?ron --- (In reply to Joonas Kylm?l? from comment #16) > I guess this feature should be also be used by OPAC/Staff side. Now the user > itself cannot use the feature (only people with access to the db). This patch simply adds a new column as a base for further development. It does what is advertised in comment #1: "it adds a column called 'borrowernumber' to the 'koha_news' table, adding a foreign key relationship to the 'borrowers' table." With patch, creating a news item fills in the borrowernumber. This information can later be used, it opens up a lot of possibilities. My opinion is that the patch should be switched back to "Needs sign-off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:46:34 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Jonathan Druart --- Eivin, It seems that my concerns on comment 38 have not been addressed. (In reply to Eivin Giske Skaaren from comment #40) > Adding a test for that in t/db_dependent/Circulation/Chargelostitem.t was > not trivial. You can also have a look at t/db_dependent/Circulation.t > I am not a test developer Of course you are, if you are a developer, you can are a test developer :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:48:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:48:53 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #13 from Jonathan Druart --- Frido, The description of this bug report mentions """ cardnumber # ok borrowertype and all the extended attributes displaying their DESCRIPTION from the authorized values table in seperate columns if possible. """ Don't you think they should be added too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:51:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:51:12 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #43 from Jonathan Druart --- CONFLICT (content): Merge conflict in opac/opac-user.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:51:48 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:52:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:52:24 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #81 from Jonathan Druart --- No need to ask for a signoff for the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:53:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:53:41 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from Jonathan Druart --- Barton, Ok, waiting for your signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:54:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:54:18 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #31 from Colin Campbell --- Restested and working (??) Message suppressed and ok set to 1 In the test plan step 9 it talks of 4th character but should be 3rd as in step 3 Although discharge is now ok and no message sent the alert flag is being returned as 'Y' which would indicate a condition requiring special action. should this not be set to N in this case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:57:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:57:01 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43046|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 43421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43421&action=edit Bug 14248 - Optionally display authorship for news Test plan: * Apply dependant patches 14246 and 14247. * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Go to 'Tools' -> 'News' and add some news items (at least 2). * Use the MySQL command line tool to edit the opac_news table, removing the user id from one of the news items: $ mysql -u kohaadmin -p -D koha > SELECT `idnew`, `title`, `borrowernumber` FROM `opac_news`; * Make a mental note of one of the 'newid' numbers to change. > UPDATE `opac_news` SET `borrowernumber` = NULL WHERE `idnew` = ; * Now one of the news items will have no user id, and no author should be shown for it. * Go to OPAC and Staff client and make sure the display modes works as intended. * Repeat for all values, making sure that the settings works as intended. * The changed news item should have no author info shown at any time. * The unchanged news item should show your own user name if the settings match the section where it is displayed. Sponsored-By: Halland County Library Tested on top of Bugs 1246 and 1247, works as advertised. Note: Some whitespaces changed / removed in koha-news.tt to pass qa tools. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:58:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:58:13 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:58:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:58:35 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 11:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 09:58:38 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43171|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 43422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43422&action=edit Bug 14617: Add fields to ISBN and ISSN indexes: 020$z, 022$y, 022$z 1) Import MARC21 bibs containing - ISBN in 020$z - ISSN in 022$y - ISSN in 022$z 2) Make sure that bibs are indexed 3) Search by ISBN and ISSN above -- bibs should not show in search. 4) Apply patch, re-index 5) Search again; ISBN in 020$z and ISSN in 022$y and 022$z should return results. Signed-off-by: kholten at switchinc.org Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:20:48 +0000 Subject: [Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 --- Comment #12 from Marc V?ron --- (In reply to Josef Moravec from comment #10) > Marc, I tried some combinations, including the one you wrote about, but I > have no problems with sorting. Is it possible that something else comes into > effect? Josef, The problem is that sorting happens with iso639-2. (Lanugages.pm after line 255) See: https://en.wikipedia.org/wiki/List_of_ISO_639-2_codes For German (Deutsch), the code can be ger *or* deu. With ger it would be sorted as g and not as d (Deutsch). There are more languages where the code can be ambivalent, e.g. dutch, and it is not guaranteed that it is alphabetically on the same place as the native name. Maye the usage of ambivalent codes depends in Koha on what language was used during installation, that could explain that it works for you and not for me. In my opinion, the sorting should happen with the native description anyway, not with the iso 639-2 code. BTW, the native description already exists Lanugages.pm (see around line 240). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:26:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:26:13 +0000 Subject: [Koha-bugs] [Bug 14290] Add a table foot to circulation matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14290 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #16 from Jonathan Druart --- The table footer should not be contained in the table body. A correct table structure is: table -tbody -tfoot not table -tbody -tfoot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:28:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:28:35 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #43 from Jonathan Druart --- Created attachment 43423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43423&action=edit Bug 14045: Add missing th in tfoot Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:29:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:29:37 +0000 Subject: [Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #44 from Jonathan Druart --- Tomas, there is a small bug caused by a conflict with bug 14290 (add a tfoot to the table). The last patch is really trivial and could be pushed bypassing all so/qa steps I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:29:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:29:50 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #18 from Marc V?ron --- (In reply to Jonathan Druart from comment #17) > Marc, I think that 14950 has introduced a bug (3 instead of 03), do you > agree with that? Do you mean because of tools/batchMod.pl near line 337? my $month = $today->month; my $day = $today->day; Output without leading 0 (3 instead of 03)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:37:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:37:28 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:37:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:37:31 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43406|0 |1 is obsolete| | Attachment #43407|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 43424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43424&action=edit Bug 13590 - Add ability to charge fines at start of charge period Right now, Koha only charges fines at the end of a given charge period. For example, let us assume a circulation rule has a charge period of one week ( 7 days ) and a fine of $5. This means that an item can be overdue for 6 days without accruing a fine. Koha should allow circulation rules to be configured to place the charge at the start of the end of the charge period so the library can decide when the fine should accrue. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) prove t/db_dependent/Circulation_Issuingrule.t 4) prove t/db_dependent/Circulation.t 5) prove t/db_dependent/Fines.t 6) Ensure you can still create/edit circulation rules Signed-off-by: Daniel Grobani Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:37:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:37:42 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #24 from Jonathan Druart --- Created attachment 43425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43425&action=edit Bug 13590: Add missing th in tfoot Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:44:28 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #19 from Jonathan Druart --- yes, exactly, both should have the same behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:44:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:44:49 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #20 from Jonathan Druart --- (and yes I know, it was my idea... sorry!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 12:48:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 10:48:58 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #43 from Eivin Giske Skaaren --- Hi Jonathan, Perhaps a clarification: Yes I did look at that example but to develop tests for C4::Circulation::LostItem seemed more complex. Anyway I am not the original dev of this patch and will need to talk to the sponsor before putting more time into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:00:23 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43411|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 43426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43426&action=edit Bug 14676 - UI/UX improvements to patron card creator Reasoning Librarians will be doing patron card things in the following frequencies, from most frequent to least frequent: 1. Creating new patron card batches - every day/every few days 2. Managing existing card batches - every day/every few days 3. Managing existing card layouts - as needed, infrequent 5. Managing existing card templates - as needed, infrequent 6. Creating new card layouts - as needed, infrequent 7. Creating new card templates - as needed, infrequent 8. Managing existing printer profiles - possibly once only! 9. Creating new printer profiles - possibly once only! This change to the patron card creator aims to make the most frequently used items easily accessible at the top of the main area, reduces clutter on the page, and makes the label creator fall in line with UI paradigms found elsewhere in Koha. I think I've also improved the translatability here somewhat, please check that. To test: Open the patron card creator: More -> Tools -> Patron card creator Note that the toolbar has changed. It should be consistent across all of the patron card creator (it is an include). + New menu: patron card batch 1. make sure it looks ok - toolbar buttons are consistent at the top of the main block. 2. add patrons both by borrowernumber, and by search 3. note that the usual buttons have moved below the textarea, and now have icons. 4. delete and export single patrons using the buttons corresponding to each patron 5. select multiple and use the buttons above the table to remove and export selected patrons 6. export a full batch 7. deduplicate a batch There should be no regressions in functionality. Image 1. This menu item should take you directly to the upload/delete images interface 2. Upload an image, note success message is now below the form, eliminating the jumping box. 3. Delete single images using the buttons 4. Delete multiple images using the tickboxes and "Delete selected" 5. Not deletion success message is below the table, eliminating the jumping box. Layout 1. This menu item should take you directly to the "Edit layout" screen. 2. no functional changes here. 3. note toolbar at top is consistent Card template 1. this menu item should take you directly to the "Edit patron card template" page. 2. no functional changes here. 3. note toolbar at top is consistent. Printer profile 1. this menu item should take you directly to the "Edit printer profile" page. 2. no functional changes here. 3. note toolbar at top is consistent. + Manage menu: Card batches 1. This menu item should take you directly to the "currently available batches" page. 2. select a batch to edit using the buttons - it should take you to the editing interface 3. select a batch to delete using the buttons - it should ask for confirm. 4. select several batches using the tickboxes, and select Export selected. Batches should be exported as normal. 5. note toolbar at top is consistent. Images (this is actually the same page as on the new menu, I included it in both because it does both functions - can change if requested) 1. This menu item should take you directly to the upload/delete images interface 2. Upload an image, note success message is now below the form, eliminating the jumping box. 3. Delete single images using the buttons 4. Delete multiple images using the tickboxes and "Delete selected" 5. Not deletion success message is below the table, eliminating the jumping box. Layouts 1. This menu item should take you directly to the "currently available layouts" page. 2. select a layout to edit using the buttons 3. select a layout to delete using the buttons 4. note toolbar at top is consistent. Card templates 1. This menu item should take you directly to the "currently available templates" page. 2. select a template to edit using the buttons 3. select a template to delete using the buttons 4. note toolbar at top is consistent. Printer profiles 1. This menu item should take you directly to the "currently available profiles" page. 2. select a profile to edit using the buttons 3. select a profile to delete using the buttons 4. note toolbar at top is consistent + General * note that sidebar now only has "labels home" instead of the full "manage" list. It seemed redundant with the toolbar tidied up. Please note that I am happy to take suggestions/amendments to these changes. Followed test plan, behaves as advertised. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:00:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:00:20 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:02:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:02:18 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Note there is maybe something not very consistent: The New > Image and Manage > Image link point to the same page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:05:56 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #4 from Marc V?ron --- Created attachment 43427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43427&action=edit Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:07:02 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Marc V?ron --- The Follow-up needs an other sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:11:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:11:26 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #21 from Marc V?ron --- (In reply to Jonathan Druart from comment #20) > (and yes I know, it was my idea... sorry!) No problem :-) Is it necessay to fix 14950 immediately? My problem is that I am now out of office for about 2 days... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:30:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:30:12 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #32 from Kyle M Hall --- (In reply to Colin Campbell from comment #31) > Restested and working (??) > > Message suppressed and ok set to 1 Excellent! > In the test plan step 9 it talks of 4th character but should be 3rd as in > step 3 Sorry about that! I will revise the test plan. > Although discharge is now ok and no message sent the alert flag is being > returned as 'Y' which would indicate a condition requiring special action. > should this not be set to N in this case? This appears to be out of the scope of this bug. Here is a checkin with the item checked out to a patron SEND: 09N20151015 07240220151015 072402APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 101YNY20151015 072402AOCPL|AB0140620125|AQMY|AJWuthering heights /|AA23529000035676|CSPZ3.B7902 W36|CV04| Here is a checkin of the same item without it being checked out: SEND: 09N20151015 07222220151015 072222APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 101YNY20151015 072222AOCPL|AB0140620125|AQMY|AJWuthering heights /|CSPZ3.B7902 W36|CV04| Here is the same checkin with a checkout on master: SEND: 09N20151015 07271820151015 072718APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 101YNY20151015 072719AOCPL|AB0140620125|AQMY|AJWuthering heights /|AA23529000035676|CSPZ3.B7902 W36|CV04| And on master without a checkout: SEND: 09N20151015 07280320151015 072803APCPL|AOCPL|AB0140620125|ACstaff|BIN| READ: 100YNY20151015 072803AOCPL|AB0140620125|AQMY|AJWuthering heights /|CSPZ3.B7902 W36|CV04|AFItem not checked out| So it appears that Koha always sets the alert flag no matter what. I think we should file a new bug report for this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 13:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 11:41:19 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #17 from Jonathan Druart --- What is the state of this one? Does the ergonomic issue fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:34:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:34:18 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #32 from bondiurbano --- (In reply to Holger Mei?ner from comment #31) > I apologize. We have a bit of staff shortage here. But don't worry, it's on > my to-do-list. I hope I'll get it done next week. Thank you Holger! Nice to read you and take your time...Thanks again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:39:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:39:32 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:39:35 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39181|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 43428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43428&action=edit Bug 12461 - Add patron clubs feature This features would add the ability to create clubs which patrons may be enrolled in. It would be particularly useful for tracking summer reading programs, book clubs and other such clubs. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure your staff user has the new 'Patron clubs' permissions 4) Under the tools menu, click the "Patron clubs" link 5) Create a new club template * Here you can add fields that can be filled out at the time a new club is created based on the template, or a new enrollment is created for a given club based on the template. 6) Create a new club based on that template 7) Attempt to enroll a patron in that club 8) Create a club with email required set 9) Attempt to enroll a patron without an email address in that club 10) Create a club that is enrollable from the OPAC 11) Attempt to enroll a patron in that club 12) Attempt to cancel a club enrollment from the OPAC 13) Attempt to cancel a club enrollment from the staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:41:48 +0000 Subject: [Koha-bugs] [Bug 12461] Add patron clubs feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 --- Comment #18 from Kyle M Hall --- Updated patch merges constraints into table creation, fixes merge conflicts. Tested with fresh install and upgrade! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:53:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:53:21 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:53:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:53:24 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42779|0 |1 is obsolete| | Attachment #42780|0 |1 is obsolete| | Attachment #42781|0 |1 is obsolete| | Attachment #42782|0 |1 is obsolete| | Attachment #42783|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 43429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43429&action=edit Bug 13918 - Add waiting expiration date to opac list of holds for user Waiting holds for patrons in the opac should display the hold expiration date based on the max pickup delay if it is set. Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Check in the item, use it to fill the hold 4) Log into the opac as that user 5) View the holds list, note the 'until ' addition to the waiting hold line. Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:53:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:53:51 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #45 from Kyle M Hall --- Created attachment 43430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43430&action=edit Bug 13918 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:53:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:53:54 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #46 from Kyle M Hall --- Created attachment 43431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43431&action=edit Bug 13918 [QA Followup] - Remove reserves_count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:53:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:53:57 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #47 from Kyle M Hall --- Created attachment 43432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43432&action=edit Bug 13918 [QA Followup] - Improve $biblio->subtitles() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:54:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:54:00 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #48 from Kyle M Hall --- Created attachment 43433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43433&action=edit Bug 13918 [QA Followup] - Remove dead template code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:54:21 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #9 from Jonathan Druart --- Created attachment 43434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43434&action=edit Bug 14922: Fix day formatting if < 10 $dt->day return a single digit if < 10, we want to display it on 2 digits Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:55:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:55:33 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #10 from Jonathan Druart --- Tomas, could you please consider this last patch for master please? On bug 14922, I caught this problem and would prefer to fix it here as the patches could be backported on stable branches (14922 is an enh). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:57:09 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:57:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:57:12 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43215|0 |1 is obsolete| | Attachment #43216|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 43435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43435&action=edit Bug 14922 - Remove C4::Dates from cataloguing/additem.pl This patch removes C4::Dates from cataloguing/additem.pl To test: - In MARC bibliographic framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year:YYYY Month:MM Day:DD - Create a new item for a biblio and verify that YYYY, MM and DD are replaced with today's values. - Apply patch and repeat that previous step behaves as before. - Verify that the overall functionality of the form is the same as before applying the patch. Signed-off-by: Hector Castro Works as advertised. With the last script not accept more than YYYYMMDD If you enter something else, the script sends to the end of line. This patch follow up the pattern in constraint default value Patch amended following comment #6 / mv Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:57:18 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #23 from Jonathan Druart --- Created attachment 43436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43436&action=edit Bug 14922 - (followup) Fix string output This patch makes YYYY MM and DD display correctly. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:57:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:57:39 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #24 from Jonathan Druart --- (In reply to Marc V?ron from comment #21) > (In reply to Jonathan Druart from comment #20) > > (and yes I know, it was my idea... sorry!) > > No problem :-) > > Is it necessay to fix 14950 immediately? My problem is that I am now out of > office for about 2 days... I have submitted a patch on bug 14950 to fix the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:58:36 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #12 from Fridolin SOMERS --- > - Note its number, for example 3 This may not be clear : its the primary key, the id of the news. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 14:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 12:59:43 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #49 from Jonathan Druart --- Software error: Global symbol "$wcount" requires explicit package name at /home/koha/src/opac/opac-user.pl line 323. Execution of /home/koha/src/opac/opac-user.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 15:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 13:01:45 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #14 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #13) > Frido, > The description of this bug report mentions > """ > cardnumber # ok > borrowertype > and all the extended attributes displaying their DESCRIPTION from the > authorized values table in seperate columns if possible. > """ > > Don't you think they should be added too? This whould make the patch really more complexe, I propose to move this part in a new bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 15:13:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 13:13:33 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #13 from Gaetan Boisson --- My two cents on what needs to go in before this can be integrated in master: - easy access to the url of the page (as Fridolin suggested, a linkn column where you can copy the link with the news id would be perfect) - ability to flag such pages as "CMS only", I would say this kind of page is definitely not going to appear in the news flow, but maybe some people will want to use it this way. - make sure multiple languages are properly managed. This is trickier. If I build my menu in opacnav for instance, i will not be able to build a different menu, with different page ids, for different languages. So choosing OPAC (fr-FR) as the display location is not quite enough, because equivalent pages in each language will end up with different ids. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 15:21:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 13:21:12 +0000 Subject: [Koha-bugs] [Bug 14067] 500 error when deleting patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14067 BUWM changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |w.miedzybrodzki at uw.edu.pl --- Comment #9 from BUWM --- Created attachment 43437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43437&action=edit error when deleting patron We also had problem with deleting patrons. `borrowers` . `password` was VARCHAR(60), while `deletedborrowers` . `password` was VARCHAR(30). Setting the latter to 60 resolved this issue in our case (Koha 3.20.01) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 15:45:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 13:45:17 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #50 from Kyle M Hall --- Created attachment 43438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43438&action=edit Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 15:46:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 13:46:40 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:12:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:12:22 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #16 from Barton Chittenden --- Created attachment 43439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43439&action=edit bug 14292: Make --category and --skip-category case insensitive -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:14:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:14:05 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Barton Chittenden --- Made small tweak: --category and --skip-category are now case insensitive. Tested and Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:18:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:18:49 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #23 from Jonathan Druart --- Created attachment 43440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43440&action=edit Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:19:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:19:02 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:19:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:19:34 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #24 from Jonathan Druart --- This is the way to go, it will take me ages to update all occurrences... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:42:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:42:12 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 --- Comment #11 from Tom?s Cohen Arazi --- Good catch Jonathan! Patch pushed to master, with correctect subject. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:53:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:53:20 +0000 Subject: [Koha-bugs] [Bug 15014] New: Plack testing -- Import patrons tool -- sample text file link broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Bug ID: 15014 Summary: Plack testing -- Import patrons tool -- sample text file link broken Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org To recreate: 1. Go to Tools --> Import Patrons 2. Click on the "here" link under notes (Download a starter CSV file with all the columns here.) 3. Note the Internal Server Error for this link http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/tools/import_borrowers.pl?sample=1 That's the old link, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 16:56:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 14:56:09 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #25 from Jonathan Druart --- Second try - t/Acquisition/Invoice.t: I don't understand what it tested here. - t/Barcodes_ValueBuilder.t: It does not seem to work because of the complex select in C4::Barcodes::ValueBuilder (substring_index, etc.) DBI Exception: DBD::SQLite::db prepare failed: no such function: SUBSTRING [for Statement "SELECT MAX(CAST(SUBSTRING(barcode,-4) AS signed)) AS number FROM items WHERE barcode REGEXP ?"] at t/Barcodes_ValueBuilder.t line 56 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:00:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:00:34 +0000 Subject: [Koha-bugs] [Bug 15015] New: Plack testing -- Import patrons tool -- uploading file fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 Bug ID: 15015 Summary: Plack testing -- Import patrons tool -- uploading file fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org Uploading a file of patrons using the Import patrons tool is broken. To recreate: 1. Go to Tools --> Import Patrons 2. Select file for upload. 3. All settings left at default. 4. Scroll to bottom and click Import. 5. Error: Link: http://test-intra.plack.bywatersolutions.com/intranet/tools/import_borrowers.pl An error has occurred! Error 404 This message may have been caused by any of the following reasons: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:04:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:04:01 +0000 Subject: [Koha-bugs] [Bug 15016] New: Plack testing -- Stage MARC records for import -- Parsing error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15016 Bug ID: 15016 Summary: Plack testing -- Stage MARC records for import -- Parsing error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org When I try to import a set of records, at the staging MARC record step, when I click on the Stage for Import button, the system returns the message, "Failed to submit form: error" To recreate: 1. go to Tools --> Stage MARC for Import. 2. Upload a MARC file. I left all the default options set. 3. Click the Stage for Import button. 4. Error message returned. Additionally, I checked the Stage MARC Management area to see if any record batches were listed, anyway; none were. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:20:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:20:53 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #54 from Brendan Gallagher --- (In reply to Jonathan Druart from comment #47) > I would like to get point of view from another QAer on this one and bug > 11747. > I don't know to be sure Kyle's patch won't introduce regression on the > tools/letter.pl page. > Moreover I am still concerned by the addition of 3 prefs to do the same > thing. I did not see a regression in the tools/letter.pl area - do you have an exact process - I test but not find problem with the letter I have already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:21:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:21:41 +0000 Subject: [Koha-bugs] [Bug 15017] New: Plack test: marc biblio imported doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15017 Bug ID: 15017 Summary: Plack test: marc biblio imported doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org This test is done on http://test-intra.plack.bywatersolutions.com I try to use /tools/stage-marc-import.pl No problem on upload .mrc file on server [5.000 marc21 biblio records]. When I try the secon point, "Stage for import", there is an error. The error on display is: Failed to submit form: error. The options selected are: Comments about this file: Record type: Bibliographic Character encoding: UTF-8 Record matching rule: Do no look for matching records Action if matching record found: Replace existing records ... Action if no match is found: Add incamming records Check for embedded item record data? No How to process items: Always add items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:34:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:34:37 +0000 Subject: [Koha-bugs] [Bug 15018] New: Plack testing -- Adding Items Display - Home Library/Current Location columns missing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 Bug ID: 15018 Summary: Plack testing -- Adding Items Display - Home Library/Current Location columns missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This may be outside the Plack testing and an entirely separate issue, but I noticed when adding items, that the home library and current location columns are missing from http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/cataloguing/additem.pl and are not in the option list for show/hide columns. That's a huge problem for a multibranch system..... To recreate: 1. Add a record and then an item or add an item to an existing record. 2. After the item is added, note that the items table on http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/cataloguing/additem.pl (which is that a Plack url? or the old one?) does not show the home library or current location columns and that they are not available as options in the show/hide columns display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:35:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:35:41 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:39:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:39:16 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42622|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 43441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43441&action=edit Bug 14244: viewing a bib item's circ history requires circulation permissions On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:39:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:39:14 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:41:24 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #30 from Eivin Giske Skaaren --- (In reply to Charles Farmer from comment #29) > Since June, did the BibLibre team had any chance to test/review/give their > opinion on the matter? +1 Since this is a sponsored patch the need is real. What can be done to make progress here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:44:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:44:37 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:55:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:55:34 +0000 Subject: [Koha-bugs] [Bug 15019] New: Plack testing - Umbrella Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug ID: 15019 Summary: Plack testing - Umbrella Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:55:52 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15014, 15015, 15016, 15017 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 [Bug 15015] Plack testing -- Import patrons tool -- uploading file fails http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15016 [Bug 15016] Plack testing -- Stage MARC records for import -- Parsing error http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15017 [Bug 15017] Plack test: marc biblio imported doesn't work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:55:52 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:55:52 +0000 Subject: [Koha-bugs] [Bug 15015] Plack testing -- Import patrons tool -- uploading file fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:55:52 +0000 Subject: [Koha-bugs] [Bug 15016] Plack testing -- Stage MARC records for import -- Parsing error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:55:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:55:52 +0000 Subject: [Koha-bugs] [Bug 15017] Plack test: marc biblio imported doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:56:18 +0000 Subject: [Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:56:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:56:18 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15018 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:57:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:57:30 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master Severity|enhancement |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:57:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:57:39 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:58:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:58:01 +0000 Subject: [Koha-bugs] [Bug 15017] Plack test: marc biblio imported doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15017 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 17:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 15:58:08 +0000 Subject: [Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:09:31 +0000 Subject: [Koha-bugs] [Bug 15020] New: Plack testing -- Patron name search fails in Checkout search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15020 Bug ID: 15020 Summary: Plack testing -- Patron name search fails in Checkout search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron has a two part first name (White Sox Cat is my example patron I've added to the Plack test server), and you search for White Sox OR White Sox Cat in the checkout search, no results found. When you search for White Sox OR White Sox Cat under the Patron Search, you get a result. To Recreate: 1. Go the the Checkout search on any page 2. Search for White Sox. No results found. 3. Search for White Sox Cat. No results found. 4. Go to the Patron search and repeat steps 2-3 searches. Both times, Patron found. (Again this may be outside Plack changes -- but I don't want to miss it) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:12:03 +0000 Subject: [Koha-bugs] [Bug 15016] Plack testing -- Stage MARC records for import -- Parsing error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15016 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #1 from Heather Braum --- *** Bug 15017 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:12:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:12:03 +0000 Subject: [Koha-bugs] [Bug 15017] Plack test: marc biblio imported doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15017 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |hbraum at nekls.org --- Comment #1 from Heather Braum --- I think we filed our bugs back to back. *** This bug has been marked as a duplicate of bug 15016 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:12:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:12:04 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15017, which changed state. Bug 15017 Summary: Plack test: marc biblio imported doesn't work http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15017 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:12:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:12:47 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15015 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:12:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:12:47 +0000 Subject: [Koha-bugs] [Bug 15015] Plack testing -- Import patrons tool -- uploading file fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15005 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:12:59 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #1 from Heather Braum --- So far I've separately added bug reports that have come from my Plack testing: 15014, 15015, 15016, 15018, 15020. Should I keep filing separate bugs or track them here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 18:16:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 16:16:06 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 --- Comment #2 from Jonathan Druart --- Open 1 bug report / problem, but link them to this bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:27:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:27:28 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #32 from Charles Farmer --- >From what I see, the last patch *did* keep branchode and category code as a unique key for table overduerules. Unless there are more things to change, this does not warrant any more discussion. Since both available patches have been signed off by Marting Persson, I'm putting this to "Signed off". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:32:01 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #7 from Kyle M Hall --- *** Bug 10314 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:32:01 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #21 from Kyle M Hall --- I believe that bug 13687 has resolved this issue. *** This bug has been marked as a duplicate of bug 13687 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:35:23 +0000 Subject: [Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:43:45 +0000 Subject: [Koha-bugs] [Bug 4888] pre-set of field indicators value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca --- Comment #29 from Marjorie Barry-Vila --- (In reply to Mirko Tietgen from comment #27) > Created attachment 14837 [details] [review] > Bug 4888 - pre-set of field indicators value > > Preload on database of the set of field indicators value as defined by > http://www.loc.gov/marc/bibliographic/ecbdhome.html. > New sql files in marc21/mandatory to create and populate the indicators > tables with the sets of values for > the Default framework/authtype. > Each framework/authtype will be able to have its own copy to allow > individual modification of indicators value. > When editing the framework/authtype exists the possibility of cloning the > indicators set from an existing > framework/authtype populated with indicators. > > Modification of the intranet administration-Marc Frameworks/Authority MARC > Framework to clone on creation from > another framework and to delete set of indicators from a framework. > Management (add/modify/delete) for indicators of the fields in the Framework > Structure. > > Modification of the intranet cataloguing addbiblio / authorities authorities > to enable a plugin to see the > defined indicators value for a specific framework, and to check validity of > indicators value. > > Two new system preferences: CheckValueIndicators for checking the value of > the indicators when cataloguing > a biblio record; DisplayPluginValueIndicators: to enable the plugin at > addbiblio to see indicators value and to > check too. > > Rebased to master 01/2013 > > Bug 4888 - rebase follow-up > > Fixing errors I made during rebase > > Bug 4888 follow-up: rebase errors 2 > > Another rebase error fixed > > Bug 4888 follow-up: fix authorities.tt > > Fixed an error in authorities.tt > > Bug 4888 follow-up > > fixed auth_tag_structure.tt Hi, Do you always work on this patch? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:51:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:51:47 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #8 from Nicole C. Engard --- How do people feel about Keyword to Marc mapping as a solution here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 19:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 17:54:17 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:05:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:05:22 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34336|0 |1 is obsolete| | --- Comment #8 from Eivin Giske Skaaren --- Created attachment 43442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43442&action=edit Bug 12770 - Notice template tool enhancement Fixed merge conflict and rebased. Tested OK. Values now show up i table. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:06:54 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #6 from Tom?s Cohen Arazi --- Created attachment 43443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43443&action=edit Bug 15005: Use ReverseProxyPath on plack.psgi This patch makes plack.psgi use ReverseProxyPath so %ENV{SCRIPT_NAME} is correctly set when running Koha behind a reverse proxy that changes the URI path (which is done on the Plack integration into packages). The apache includes for plack are tweaked so the needed headers are set before passing the request to the Plack backend. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:09:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:09:27 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:10:28 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43443|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 43444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43444&action=edit Bug 15005: Use ReverseProxyPath on plack.psgi This patch makes plack.psgi use ReverseProxyPath so %ENV{SCRIPT_NAME} is correctly set when running Koha behind a reverse proxy that changes the URI path (which is done on the Plack integration into packages). The apache includes for plack are tweaked so the needed headers are set before passing the request to the Plack backend. Edit: added missing dependency Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:30:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:30:45 +0000 Subject: [Koha-bugs] [Bug 15015] Plack testing -- Import patrons tool -- uploading file fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 --- Comment #1 from Heather Braum --- 15005 patches are helping this -- but it hasn't been fixed yet. Got this result this import attempt: not found on the page and link is now http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/intranet/tools/import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:37:51 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:01 +0000 Subject: [Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:06 +0000 Subject: [Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:10 +0000 Subject: [Koha-bugs] [Bug 13385] RDA: 508 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:13 +0000 Subject: [Koha-bugs] [Bug 13386] 246 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13386 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:20 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:24 +0000 Subject: [Koha-bugs] [Bug 13434] 586 XSLT improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13434 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:28 +0000 Subject: [Koha-bugs] [Bug 13387] Uniform titles (130 / 240 / 730) Display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13387 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:33 +0000 Subject: [Koha-bugs] [Bug 13734] RDA: Display 33xs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:39 +0000 Subject: [Koha-bugs] [Bug 12726] Show RDA tag 264 on OPAC Results XSLT view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12726 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:43 +0000 Subject: [Koha-bugs] [Bug 12725] Show RDA tag 264 on Intranet Results and Detail XSLT view (MARC21) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12725 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:38:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:38:49 +0000 Subject: [Koha-bugs] [Bug 12724] Show RDA tag 264 on OPAC Detail XSLT view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12724 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:42:32 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 20:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 18:59:56 +0000 Subject: [Koha-bugs] [Bug 12468] copyright symbol not translating right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 21:03:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 19:03:40 +0000 Subject: [Koha-bugs] [Bug 11071] RDA Helper In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11071 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 21:56:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 19:56:59 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 --- Comment #7 from Liz Rea --- I mentioned that in the patch notes :) The page does both functions, here was my reasoning. When I was working on this, I noticed that the images function basically stands alone. Because it adds images for patron cards, I first added it to the "New" menu, then went away and did other things. When I came back to do the manage menu, I was personally surprised that it wasn't there in the manage menu. If I want to manage things, wouldn't I click on the manage menu and expect to find the interface to manage images there? So I wondered if other people would be surprised that there wasn't a manage interface too (even though they are the same page). When I put the same link in the Manage menu, it felt right to me. Balanced. Even though technically we are putting a link to the same place in two places. I want people to be able to expect that they will find what they are looking for in the place they think it might be, so that's why I did it that way. There might be another way to do it - we could make a link in the sidebar menu, but that would be a departure from the way the Label Creator works now and would be an inconsistency in itself. Or maybe you have an idea on how to do it differently, I'm completely open to suggestions. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 22:03:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 20:03:01 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Liz Rea --- The ergonomic change I added will probably want testing on top of this patch. The modified patch I did for compatibility with 14676 is likely ok, but if you're gonna test the one, you'll have to have the other(s) anyway. Note that the two I've uploaded will need to be applied on top of 14676. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 22:17:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 20:17:38 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #141 from Nick Clemens --- I ran through the test plan and all worked as expected. My previous concerns about item loss have been addressed. Tested using the sandbox provided by Jesse but happy to officially sign off if needed. Seeing this move ahead into 3.22 would be great, this bug ticket is becoming a bear to navigate as well and would be nice to see issues addressed on their own bugs. I think the huge advantage of the tool outweighs the usability issues that production testing will raise Minor notes: I get this js error when playing with macros: "modified.toLocaleFormat is not a function" Once a macro autosaves it can be run or deleted, but I cannot create another macro (left side of screen is blank). After deleting I can create a new one. Additionally, refreshing the page while the macro window is open seems to lock in to the current macro, I can run good commands but cannot delete the macro or create new. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 22:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 20:41:51 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 15 22:41:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 20:41:53 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #6 from Barton Chittenden --- Created attachment 43445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43445&action=edit Bug 14504 [QA Follow-up] * Fix POD warning. * Remove redundant 'use stric' and 'use warnings' * Remove $VERSION and --version option. * Remove --dry-run option * Split test for --help and check for @criteria into two separate pod2usage calls, enabling -msg on the latter. * Fix 'target_tiems' typo. * Test for holds on items to be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 00:17:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 22:17:01 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #9 from David Cook --- (In reply to Nicole C. Engard from comment #8) > How do people feel about Keyword to Marc mapping as a solution here? Not very positive, because Keyword to Marc mapping only allows one mapping, when you theoretically might want to use 264 "or" 260 depending on which is available per record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 00:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 22:32:18 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 --- Comment #6 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.12. Leaving pushed to master so it turns up on Chris's radar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 00:33:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 15 Oct 2015 22:33:15 +0000 Subject: [Koha-bugs] [Bug 13675] the budget of an order is set to null if not changed on receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13675 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Liz Rea --- (actually never mind, it's already in 3.20) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 03:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 01:22:48 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 03:23:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 01:23:13 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 03:24:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 01:24:59 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #1 from Heather Braum --- I just came into Bugzilla tonight looking to see if this feature had ever been requested and found this bug. Is this under development yet? What's been proposed? Also, how will this data be stored in the database? Any discussion/thoughts about creating a separate guarantor table and no longer storing the guarantor borrowernumber in the guarantee's borrower record? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 03:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 01:31:30 +0000 Subject: [Koha-bugs] [Bug 14733] Prevent a record from having holds with duplicate priorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14733 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #13 from Liz Rea --- Pushed to 3.18.x, will be in 3.18.12. Noting that I resolved a conflict in the unit tests regarding the number of tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 04:47:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 02:47:49 +0000 Subject: [Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #2 from Liz Rea --- Created attachment 43446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43446&action=edit Bug 13216 - fix koha shell to accept alternative perl5lib paths To test: gitify an install run sudo koha-shell instance run env | grep PERL5LIB it should be set to /usr/share/koha/lib run sudo koha-shell -d /path/to/your/git/install run env | grep PERL5LIB it should be set to /path/to/your/git/install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 04:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 02:47:46 +0000 Subject: [Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 08:50:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 06:50:49 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43387|0 |1 is obsolete| | --- Comment #8 from Josef Moravec --- Created attachment 43447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43447&action=edit Bug 15005: Replace CGI->url with the corresponding url CGI->url does not return the correct url on install using packages. Test plan: 1/ Try to reproduce the bug from the description of bug 15005. You should be able to login to the intranet and the OPAC 2/ Send a basket and a list from the intranet and the OPAC. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 08:50:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 06:50:58 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43388|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 43448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43448&action=edit Bug 15005: Remove CGI->url calls from pl scripts Same as previous patch for calls in pl scripts. Test plan: - delete an entry of your search history from intranet and opac - with IndependentBranches=OFF, go on the waiting holds and confirm that the link next to 'Holds awaiting pickup for your library on' is correct. - search for items, the pagination should work correctly Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 08:51:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 06:51:06 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43389|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 43449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43449&action=edit Bug 15005: Fix pagination_bar calls Test plan: Create an order for an existing biblio, confirm that the pagination links work correctly. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 08:53:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 06:53:08 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #11 from Josef Moravec --- The patches works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:12:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:12:55 +0000 Subject: [Koha-bugs] [Bug 15021] New: Batch item modification does not work correctly on plack Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Bug ID: 15021 Summary: Batch item modification does not work correctly on plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 43450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43450&action=edit Batch item modification display issue In Batch item modification tool, after inserting some codes (in textarea or as file), in second step you should normally see the table with many columns and checkboxes to display/hide each of these columns. But under plack you see only the Title column (see attachment) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:21:20 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:21:20 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Depends on| |15021 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 [Bug 15021] Batch item modification does not work correctly on plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:22:19 +0000 Subject: [Koha-bugs] [Bug 15020] Plack testing -- Patron name search fails in Checkout search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15020 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:22:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:22:19 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15020 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15020 [Bug 15020] Plack testing -- Patron name search fails in Checkout search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:27:53 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 kohayu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |long_sam.tw at yahoo.com.tw -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:37:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:37:19 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #31 from Jonathan Druart --- There are 2 other vug reports (see also field) which propose the same enhancement. You can try and contact the authors of these patches and work all together to find a solution that please everybody. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:37:26 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:40:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:40:39 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #170 from kohayu --- Dear folk, I git clone git://git.catalyst.net.nz/koha.git . os - debian 7.9 wheezy , x86_64 Linux debian 3.2.0-4-amd64 #1 SMP Debian 3.2.68-1+deb7u4 x86_64 GNU/Linux koha version - 3.21.00.030 perl - 5.014002 mysql - mysql Ver 14.14 Distrib 5.5.44, for debian-linux-gnu (x86_64) using readline 6.2 Elasticsearch version: 1.7.2 JVM name: Java HotSpot(TM) 64-Bit Server VM JVM vendor: Oracle Corporation JVM version: 25.60-b23 Java version: 1.8.0_60 I use bulkmarcimport.pl to import marc data, But import 1,000 records every time , it occurred "................[NoNodes] ** No nodes are available: [http://127.0.0.1:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch.pm line 61.root at debian:/usr/share/koha/bin/migration_tools#" This job stopped. Has anyone see the same condition? BR. longshan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:41:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:41:18 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #171 from kohayu --- Dear folk, I git clone git://git.catalyst.net.nz/koha.git . os - debian 7.9 wheezy , x86_64 Linux debian 3.2.0-4-amd64 #1 SMP Debian 3.2.68-1+deb7u4 x86_64 GNU/Linux koha version - 3.21.00.030 perl - 5.014002 mysql - mysql Ver 14.14 Distrib 5.5.44, for debian-linux-gnu (x86_64) using readline 6.2 Elasticsearch version: 1.7.2 JVM name: Java HotSpot(TM) 64-Bit Server VM JVM vendor: Oracle Corporation JVM version: 25.60-b23 Java version: 1.8.0_60 I use bulkmarcimport.pl to import marc data, But import 1,000 records every time , it occurred "................[NoNodes] ** No nodes are available: [http://127.0.0.1:9200], called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch.pm line 61.root at debian:/usr/share/koha/bin/migration_tools#" This job stopped. Has anyone see the same condition? BR. longshan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 09:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 07:49:20 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Joonas Kylm?l? changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:07:46 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43444|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 43451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43451&action=edit Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths Since I don't manage to make SCRIPT_NAME works directly with RequestHeader and/or ReverseProxyPath, the easier way it to fix all the different occurrences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:09:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:09:28 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #13 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #7) > Created attachment 43444 [details] [review] > Bug 15005: Use ReverseProxyPath on plack.psgi > > This patch makes plack.psgi use ReverseProxyPath so %ENV{SCRIPT_NAME} is > correctly set when running Koha behind a reverse proxy that changes > the URI path (which is done on the Plack integration into packages). > > The apache includes for plack are tweaked so the needed headers are set > before passing the request to the Plack backend. > > Edit: added missing dependency > > Signed-off-by: Tomas Cohen Arazi Tomas, Unfortunately, this does not work, the path generated is now /cgi-bin/koha/intranet/modules/script.pl (note the '/intranet'). The last patch I have proposed should fix the issue on a silly way (but working...). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:15:47 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43447|0 |1 is obsolete| | Attachment #43448|0 |1 is obsolete| | Attachment #43449|0 |1 is obsolete| | Attachment #43451|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 43452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43452&action=edit Bug 15005: Replace CGI->url with the corresponding url CGI->url does not return the correct url on install using packages. Test plan: 1/ Try to reproduce the bug from the description of bug 15005. You should be able to login to the intranet and the OPAC 2/ Send a basket and a list from the intranet and the OPAC. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:15:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:15:51 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #15 from Jonathan Druart --- Created attachment 43453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43453&action=edit Bug 15005: Remove CGI->url calls from pl scripts Same as previous patch for calls in pl scripts. Test plan: - delete an entry of your search history from intranet and opac - with IndependentBranches=OFF, go on the waiting holds and confirm that the link next to 'Holds awaiting pickup for your library on' is correct. - search for items, the pagination should work correctly Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:15:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:15:54 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #16 from Jonathan Druart --- Created attachment 43454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43454&action=edit Bug 15005: Fix pagination_bar calls Test plan: Create an order for an existing biblio, confirm that the pagination links work correctly. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:15:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:15:57 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #17 from Jonathan Druart --- Created attachment 43455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43455&action=edit Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths Since I don't manage to make SCRIPT_NAME works directly with RequestHeader and/or ReverseProxyPath, the easier way it to fix all the different occurrences. Test plan: On the import patrons page, confirm that the "Import" button does not redirect to a 'Not found' page. You should stay on the import patrons page. Note that if this change works, all others should work too. Have a look at the diff of this patch and confirm there is no typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:27:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:27:09 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #172 from Jonathan Druart --- (In reply to kohayu from comment #171) > > I use bulkmarcimport.pl to import marc data, > But import 1,000 records every time , it occurred > > "................[NoNodes] ** No nodes are available: > [http://127.0.0.1:9200], called from sub > Search::Elasticsearch::Role::Client::Direct::__ANON__ at > /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch.pm line > 61.root at debian:/usr/share/koha/bin/migration_tools#" > > This job stopped. See comment 62. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:49:10 +0000 Subject: [Koha-bugs] [Bug 7172] Omnibus for Plack variable scoping problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15021 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 [Bug 15021] Batch item modification does not work correctly on plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:49:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:49:10 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7172 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 [Bug 7172] Omnibus for Plack variable scoping problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:51:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:51:23 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #173 from kohayu --- (In reply to Jonathan Druart from comment #172) > (In reply to kohayu from comment #171) > > > > I use bulkmarcimport.pl to import marc data, > > But import 1,000 records every time , it occurred > > > > "................[NoNodes] ** No nodes are available: > > [http://127.0.0.1:9200], called from sub > > Search::Elasticsearch::Role::Client::Direct::__ANON__ at > > /usr/local/share/perl/5.14.2/Catmandu/Store/ElasticSearch.pm line > > 61.root at debian:/usr/share/koha/bin/migration_tools#" > > > > This job stopped. > > See comment 62. my config 127.0.0.1:9200 koha_robin elasticsearch no log, my elasticseach works very well. http://i.imgur.com/ESRj0oj.png ElasticSearch.pm sub _build_es { my ($self) = @_; my $es = Search::Elasticsearch->new($self->_es_args); # line 61 unless ($es->indices->exists(index => $self->index_name)) { $es->indices->create( index => $self->index_name, body => { settings => $self->index_settings, mappings => $self->index_mappings, }, ); } $es; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:51:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:51:37 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43403|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:17 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43223|0 |1 is obsolete| | --- Comment #180 from Marcel de Rooy --- Created attachment 43456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43456&action=edit Bug 14544: Add Koha::Virtualshelf and Koha::Virtualshelves The 2 modules C4::VirtualShelves and C4::VirtualShelves::Page are really badly coded and buggy. It became complicated to fix and enhance them. This rewrite will make the code more robust and the list feature will be easier to change. Some new modules are added to the Koha namespace (Koha::Virtualshelf, Koha::Virtualshelves, Koha::Virtualshelfshare[s] and Koha::Virtualshelfcontent[s]) to take advantage of Dbix::Class. The patchset fixes some bugs: 1/ Bug 6279 - Can't delete lists from the second page of lists in the OPAC 2/ The owner of a list should not need any permission to remove content from his lists. 3/ No feedback messages when actions are done Test plan: A) Intranet and OPAC 1/ Create more than 20 private and public lists with different users 2/ Edit some and confirm that the changes are taken into account 3/ Share some lists with other users 4/ Add / remove contents Be sure you have some lists with more than 20 items (to test the pagination) 5/ Play with permissions and confirm it works as expected. For private lists: They should not be viewed by anyone else, if they are not shared If they are shared (OPAC only): a. "Allow anyone else to add entries" Should allow the user with whom the list is shared to add entries. b. "Allow anyone to remove his own contributed entries." Should allow the user with whom the list is shared to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow the user with whom the list is shared to remove any entries. For public lists: They should be viewed by anyone else. a. "Allow anyone else to add entries" Should allow any user to add entries. b. "Allow anyone to remove his own contributed entries." Should allow any user to remove his own entries. c. "Allow anyone to remove other contributed entries." Should allow any user to remove any entries. 6/ Download and sent lists. 7/ Confirm that the "Add to" feature works as expected. 8/ Confirm that the "Add an item to" works as expected. 9/ Delete some lists. 10/ Print some lists and subscribe to the RSS feed (OPAC only) (with more than 20 items). 11/ Use the remove "Remove share" links. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:22 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43224|0 |1 is obsolete| | --- Comment #181 from Marcel de Rooy --- Created attachment 43457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43457&action=edit Bug 14544: Get rid of GetShelf Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:29 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43225|0 |1 is obsolete| | --- Comment #182 from Marcel de Rooy --- Created attachment 43458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43458&action=edit Bug 14544: Get rid of AddShelf Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43226|0 |1 is obsolete| | --- Comment #183 from Marcel de Rooy --- Created attachment 43459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43459&action=edit Bug 14544: Get rid of DelShelf Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:40 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43227|0 |1 is obsolete| | --- Comment #184 from Marcel de Rooy --- Created attachment 43460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43460&action=edit Bug 14544: Get rid of ModShelf Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:41 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:46 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43228|0 |1 is obsolete| | --- Comment #185 from Marcel de Rooy --- Created attachment 43461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43461&action=edit Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:51 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43229|0 |1 is obsolete| | --- Comment #186 from Marcel de Rooy --- Created attachment 43462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43462&action=edit Bug 14544: Get rid of GetAllShelves Signed-off-by: Koha Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:52:56 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43230|0 |1 is obsolete| | --- Comment #187 from Marcel de Rooy --- Created attachment 43463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43463&action=edit Bug 14544: Koha::Virtualshelfcontent[s] Get rid of AddToShelf and DelFromShelf Bug 14544: Allow a user to delete his own contents Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:02 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43231|0 |1 is obsolete| | --- Comment #188 from Marcel de Rooy --- Created attachment 43464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43464&action=edit Bug 14544: Make the intranet side independent of Page.pm Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:07 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43232|0 |1 is obsolete| | --- Comment #189 from Marcel de Rooy --- Created attachment 43465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43465&action=edit Bug 14544: Get rid of GetBibliosShelves Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:12 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43233|0 |1 is obsolete| | --- Comment #190 from Marcel de Rooy --- Created attachment 43466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43466&action=edit Bug 14544: Get rid of GetShelves This does not work for now, see later. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:17 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:18 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43234|0 |1 is obsolete| | --- Comment #191 from Marcel de Rooy --- Created attachment 43467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43467&action=edit Bug 14544: Make the OPAC side independent of Page.pm Bug 14544: Fix redirect on editing a list If you edit a list from the list view, after saving the form, you are not redirected to the list view (but on the edit form). Bug 14544: Cosmetic: › should be a class divider Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:21 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 --- Comment #1 from Jonathan Druart --- Created attachment 43468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43468&action=edit Bug 15021: Fix scoping variable in tools/batchMod.pl $tagslib is used in subroutines and should be declare as global. Test plan: On the Batch item modification page, all item fields should be listed, not only the title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:23 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43235|0 |1 is obsolete| | --- Comment #192 from Marcel de Rooy --- Created attachment 43469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43469&action=edit Bug 14544: Get rid of ShelfPossibleAction Bug 14544: (follow-up) Get rid of ShelfPossibleAction Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:29 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43236|0 |1 is obsolete| | --- Comment #193 from Marcel de Rooy --- Created attachment 43470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43470&action=edit Bug 14544: Get rid of GetShelfContent Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:34 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43237|0 |1 is obsolete| | --- Comment #194 from Marcel de Rooy --- Created attachment 43471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43471&action=edit Bug 14544: Get rid of GetSomeShelfNames Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:33 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:39 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43238|0 |1 is obsolete| | --- Comment #195 from Marcel de Rooy --- Created attachment 43472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43472&action=edit Bug 14544: Move HandleDelBorrower to C4::Members Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:45 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43239|0 |1 is obsolete| | --- Comment #196 from Marcel de Rooy --- Created attachment 43473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43473&action=edit Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:50 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43240|0 |1 is obsolete| | --- Comment #197 from Marcel de Rooy --- Created attachment 43474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43474&action=edit Bug 14544: Remove wrong tips about permissions The owner of a list should not need any permission to remove contents. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:53:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:53:56 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43241|0 |1 is obsolete| | --- Comment #198 from Marcel de Rooy --- Created attachment 43475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43475&action=edit Bug 14544: Fix regression on adding a new list The user should not be allowed to create a new list and get a friendly error message if he tries. The "New list" links are removed. Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:01 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43242|0 |1 is obsolete| | --- Comment #199 from Marcel de Rooy --- Created attachment 43476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43476&action=edit Bug 14544: DB Changes: Set a default value for sortfield Signed-off-by: Alex Arnaud Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:06 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43243|0 |1 is obsolete| | --- Comment #200 from Marcel de Rooy --- Created attachment 43477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43477&action=edit Bug 14544 - Handle database error when creating a shelf with DB admin account Signed-off-by: Jonathan Druart I don't think this is useful, it will be a mess if we have to check this case everywhere. But it works! I let the cut to the QAer or RM. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:12 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43296|0 |1 is obsolete| | --- Comment #201 from Marcel de Rooy --- Created attachment 43478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43478&action=edit Bug 14544: [QA Follow-up] Fix warning about transaction When running Virtualshelves.t, you have this warning: DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. By moving the DBI lines after creating the TestBuilder object, the warning will be gone. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:17 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43334|0 |1 is obsolete| | --- Comment #202 from Marcel de Rooy --- Created attachment 43479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43479&action=edit Bug 14544: Add missing biblio <=> biblioitems <=> items relationships to the schema Signed-off-by: Marcel de Rooy Adjusted by a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:23 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43335|0 |1 is obsolete| | --- Comment #203 from Marcel de Rooy --- Created attachment 43480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43480&action=edit Bug 14544: QA fixes - some minor bug fixes See comment 171 and 172 for more details. This patch mainly fixes typo or silly error in templates. It also uses the relationships added by previous patch to join the biblioitems and items tables (changes in opac-shelves.pl and shelves.pl). Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:28 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #204 from Marcel de Rooy --- Created attachment 43481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43481&action=edit Bug 14544: [QA Follow-up] Added some test descriptions Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:54:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:54:33 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #205 from Marcel de Rooy --- Created attachment 43482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43482&action=edit Bug 14544: [QA Follow-up] DBIx::Class changes One of the follow-ups added a belongs_to from Biblioitem to Item just as biblioitemnumber was a foreign key to Item. The relation goes the other way. As a temporary measure, I added set_primary_key in the local section of Virtualshelfcontent. Should be moved later with a real db rev. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:55:09 +0000 Subject: [Koha-bugs] [Bug 15020] Patron name search fails in Checkout search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15020 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15019 | CC| |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Plack testing -- Patron |Patron name search fails in |name search fails in |Checkout search |Checkout search | Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 14871 *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:55:09 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #8 from Jonathan Druart --- *** Bug 15020 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:55:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:55:09 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15020 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15020 [Bug 15020] Patron name search fails in Checkout search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:55:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:55:43 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #206 from Marcel de Rooy --- QA Comment [Continuation]: Thanks again for your hard work. >> OPAC - Share a list - Enter email address - Return to your lists: This list >> does not exist ?? op=view && category=1. Adjust the URL? > Fixed! > Yes, the op is 'list', not 'view". Fixed?? This is still a problem. Did you test it? (No blocker for such a large patch, but ... Do you miss the shelf number?) > Fixed! But... This is a bad one. > In opac-shelves.pl and shelves.pl, the join was only done on biblio. > But itemcallnumber is in the items table. > I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table > (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent > without declared primary key). But this is not completely solved. View a private list in opac or staff: Bang. DBIx::Class::ResultSet::next(): Operation requires a primary key to be declared on 'Virtualshelfcontent' via set_primary_key How did you test this? :) Apparently, you forgot to include this added PK in your patches. Fixed by a hack now: added set_primary_key in Virtualshelfcontent in the local section. Please adjust this by defining the PK on the table and regenerating the DBIx file. Note also that I removed the belongs_to from Biblioitem to Item. This is not a FK but a PK. > Fixed! > The "op" was "view" instead of "remove_biblios" on the submit button. > Note that the individual links work (and intranet is ok). I removed two items. One should not be removed, the other should. This works now, but the message is not really clear. No blocker. > The last patch reintroduces the read-only list feature/bug :) > If we decide later to remove it, we would be able to do it reverting this patch! Applying: Bug 14544: allow_delete_own == 0 could represent a read-only list Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Virtualshelves.t CONFLICT (content): Merge conflict in t/db_dependent/Virtualshelves.t At this time I rather obsolete this additional patch. The wording was removed, the behavior slightly changed. No need to test this now. It has been just a reminder that changing behavior may need more communication than one incidental IRC chat :) Additional observation: The Author and [Date added] column in the shelf view on staff are empty. (With and without the last four follow-up patches.) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:56:06 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #207 from Marcel de Rooy --- Note to RM Another db rev may follow from Jonathan to correct the mentioned PK issue with DBIx. Please note that you get Koha::Exception too now. (See earlier QA comment.) An early push may help us to detect if this patch set still contains some further issues. But it looks quite good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:57:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:57:34 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:57:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:57:34 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15005 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:58:08 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- Will be fixed by Subject: [PATCH] Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths *** This bug has been marked as a duplicate of bug 15005 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:58:08 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #18 from Jonathan Druart --- *** Bug 15014 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:58:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:58:08 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15014, which changed state. Bug 15014 Summary: Plack testing -- Import patrons tool -- sample text file link broken http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:59:37 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- --- Comment #2 from Jonathan Druart --- No it's not! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:59:37 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15014, which changed state. Bug 15014 Summary: Plack testing -- Import patrons tool -- sample text file link broken http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 10:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 08:59:44 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:00:10 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #19 from Jonathan Druart --- *** Bug 15015 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:00:10 +0000 Subject: [Koha-bugs] [Bug 15015] Plack testing -- Import patrons tool -- uploading file fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart --- This one fixed fixed by Subject: [PATCH] Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths *** This bug has been marked as a duplicate of bug 15005 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:00:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:00:10 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15015, which changed state. Bug 15015 Summary: Plack testing -- Import patrons tool -- uploading file fails http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15015 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:02:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:02:31 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #174 from kohayu --- my elaticsearch index http://imgur.com/htHLWCW koha_robin_authorities koha_robin_biblios I import data by hand , koha can't import all marc data once. BR, longshan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:04:05 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:04:08 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 --- Comment #3 from Jonathan Druart --- Created attachment 43483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43483&action=edit Bug 15014: Returns 0 if everything went fine Be kind and return 0 if the sample file has been generated correctly. Otherwise you are a bad guy and you make Plack returns an internal error (exited nonzero: 1 at /home/vagrant/kohaclone/tools/import_borrowers.pl line 390.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:06:54 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #20 from Jonathan Druart --- *** Bug 15016 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:06:54 +0000 Subject: [Koha-bugs] [Bug 15016] Plack testing -- Stage MARC records for import -- Parsing error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- I have tested on my local install with Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths And it works \o/ Please retest when it will be applied on the test server. *** This bug has been marked as a duplicate of bug 15005 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:06:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:06:54 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15016, which changed state. Bug 15016 Summary: Plack testing -- Stage MARC records for import -- Parsing error http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15016 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:22:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:22:56 +0000 Subject: [Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 --- Comment #1 from Jonathan Druart --- Heather, On editing an item (http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=1&itemnumber=1&searchid=#edititem), I see the current location and the home library is the "Permanent location" field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:35:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:35:05 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #175 from Jonathan Druart --- What is the return of curl -X GET http://localhost:9200/ ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:36:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:36:39 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43455|0 |1 is obsolete| | --- Comment #21 from Josef Moravec --- Created attachment 43484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43484&action=edit Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths Since I don't manage to make SCRIPT_NAME works directly with RequestHeader and/or ReverseProxyPath, the easier way it to fix all the different occurrences. Test plan: On the import patrons page, confirm that the "Import" button does not redirect to a 'Not found' page. You should stay on the import patrons page. Note that if this change works, all others should work too. Have a look at the diff of this patch and confirm there is no typo. Signed-off-by: Josef Moravec Tested in patron import and item batch modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:50:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:50:35 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #208 from Jonathan Druart --- Created attachment 43485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43485&action=edit Bug 14544: Fix 'back to lists' link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:53:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:53:12 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #209 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #206) > QA Comment [Continuation]: > > Thanks again for your hard work. > > >> OPAC - Share a list - Enter email address - Return to your lists: This list > >> does not exist ?? op=view && category=1. Adjust the URL? > > Fixed! > > Yes, the op is 'list', not 'view". > Fixed?? This is still a problem. Did you test it? (No blocker for such a > large patch, but ... Do you miss the shelf number?) Hum no, I have tested the link just before the form submit! The last patch fixes that. > > Fixed! But... This is a bad one. > > In opac-shelves.pl and shelves.pl, the join was only done on biblio. > > But itemcallnumber is in the items table. > > I had to add the biblio<=>biblioitems<=>items relationship to the Schema and a PK on virtualshelfcontents table > > (DBIx::Class::Storage::DBIHacks::_adjust_select_args_for_complex_prefetch(): Unable to perform complex limited prefetch off Virtualshelfcontent > > without declared primary key). > But this is not completely solved. > View a private list in opac or staff: Bang. > DBIx::Class::ResultSet::next(): Operation requires a primary key to be > declared on 'Virtualshelfcontent' via set_primary_key > How did you test this? :) Apparently, you forgot to include this added PK in > your patches. > Fixed by a hack now: added set_primary_key in Virtualshelfcontent in the > local section. > Please adjust this by defining the PK on the table and regenerating the DBIx > file. > Note also that I removed the belongs_to from Biblioitem to Item. This is not > a FK but a PK. With my previous branch (so without your follow-ups), I have regenerated the schema and I don't get an error viewing a private list. That's why I have added the belongs_to rs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 11:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 09:59:31 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:02:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:02:48 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #210 from Jonathan Druart --- Created attachment 43486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43486&action=edit Bug 14544: Fixes regression: display author and dateadded on the list view [intranet] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:03:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:03:34 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #211 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #206) > Additional observation: The Author and [Date added] column in the shelf view > on staff are empty. (With and without the last four follow-up patches.) See last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:11:05 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #15 from Jonathan Druart --- (In reply to Fridolin SOMERS from comment #14) > (In reply to Jonathan Druart from comment #13) > > Frido, > > The description of this bug report mentions > > """ > > cardnumber # ok > > borrowertype > > and all the extended attributes displaying their DESCRIPTION from the > > authorized values table in seperate columns if possible. > > """ > > > > Don't you think they should be added too? > > This whould make the patch really more complexe, I propose to move this part > in a new bug So you have to either move your patch or open a new bug report. And also edit the title of the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:23:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:23:14 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- Barton, it does not work: the items are never deleted. You should also launch the qa script every time you submit a patch, it will catch warnings/errors for you (here 2 trailing white-spaces). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:24:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:24:24 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #212 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #208) > Created attachment 43485 [details] [review] > Bug 14544: Fix 'back to lists' link Sure about the location? sendshelf? Creating a share is shareshelf? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:25:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:25:20 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #33 from Jonathan Druart --- (In reply to Charles Farmer from comment #32) > From what I see, the last patch *did* keep branchode and category code as a > unique key for table overduerules. Unless there are more things to change, > this does not warrant any more discussion. > > Since both available patches have been signed off by Marting Persson, I'm > putting this to "Signed off". Do you confirm that the QA concerns have been taken into account, the patches work as advertised and you have tested them? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:26:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:26:30 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #213 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #212) > (In reply to Jonathan Druart from comment #208) > > Created attachment 43485 [details] [review] [review] > > Bug 14544: Fix 'back to lists' link > > Sure about the location? sendshelf? Creating a share is shareshelf? Erk, no! So there is another one missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:27:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:27:47 +0000 Subject: [Koha-bugs] [Bug 5366] Koha does not work right with MariaDB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5366 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #22 from Manos PETRIDIS --- It seems not to be a MySQL/MiariaDB issue, but a koha one. If no nulls may be entered in a column, then the code should check for nulls and exclude such records from the import procedure, creating perhaps an exceprion report of records that failed the insertion criteria. If blanks are considered sufficient Information, then the code should check for nulls and convert them to empty strings (''). If on the other hand nulls are to be allowed as such, the column(s) should not have the NOT NULL attribute in the First place. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:30:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:30:09 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #214 from Jonathan Druart --- Created attachment 43487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43487&action=edit Bug 14544: Fix 'Back to lists' links on sharing a shelf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:31:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:31:16 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #215 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #212) > (In reply to Jonathan Druart from comment #208) > > Created attachment 43485 [details] [review] [review] > > Bug 14544: Fix 'back to lists' link > > Sure about the location? sendshelf? Creating a share is shareshelf? Sorry about that. I am sure I have fixed it already but I have certainly lost it during a rebase -i. Now it works! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:39:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:39:28 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #18 from Jonathan Druart --- No it doesn't, the script explodes! FAIL misc/cronjobs/longoverdue.pl FAIL valid "my" variable $borrower_category masks earlier declaration in same scope "my" variable $skip_borrower_category masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:39:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:39:34 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:40:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:40:59 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:41:11 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43468|0 |1 is obsolete| | --- Comment #2 from Josef Moravec --- Created attachment 43488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43488&action=edit Bug 15021: Fix scoping variable in tools/batchMod.pl $tagslib is used in subroutines and should be declare as global. Test plan: On the Batch item modification page, all item fields should be listed, not only the title. Signed-off-by: Josef Moravec Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:43:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:43:41 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:43:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:43:45 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43304|0 |1 is obsolete| | Attachment #43305|0 |1 is obsolete| | Attachment #43336|0 |1 is obsolete| | Attachment #43337|0 |1 is obsolete| | Attachment #43439|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 43489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43489&action=edit Bug 14292: Add patron category restrictions to longoverdue.pl Add command line options --category and --skip-category Convert usage() to pod2usage. (This was previous FIXME) http://bugs.koha-community.org/show_bug.cgi?id=14292 Signed-off-by: hbraum at nekls.org Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:43:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:43:51 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #20 from Jonathan Druart --- Created attachment 43490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43490&action=edit Bug 14292: QA Follow-up Make borrower category handling more user friendly: Make --category and --skip-category mutally exclusive Check that categories specified by --category and --skip-category exist in categories table. Add --list-categories opttion to show available borrower categories. Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:43:55 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #21 from Jonathan Druart --- Created attachment 43491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43491&action=edit Bug 14292: QA fixes - wording and trailing whitespaces Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:43:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:43:59 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #22 from Jonathan Druart --- Created attachment 43492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43492&action=edit Bug 14292: Simplify the category list Basically we have 3 lists of categories: 1/ The full one, in the DB 2/ The one we want and list with --category 3/ The one we don't want and list with --skip-category The list of categories to process is: * 1 if none --category or --skip-category options are provided * 2 if --category is provided * 1 - 3 if --skip-category is provided Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:44:03 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #23 from Jonathan Druart --- Created attachment 43493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43493&action=edit bug 14292: Make --category and --skip-category case insensitive Signed-off-by: Barton Chittenden Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:44:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:44:07 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #24 from Jonathan Druart --- Created attachment 43494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43494&action=edit Bug 14292: (follow-up) Make --category and --skip-category case insensitive "my" variable $borrower_category masks earlier declaration in same scope "my" variable $skip_borrower_category masks earlier declaration in same scope Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:44:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:44:51 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #176 from kohayu --- (In reply to Jonathan Druart from comment #175) > What is the return of > curl -X GET http://localhost:9200/ > ? Dear Jonbathan, output as follow, root at debian:~# curl -X GET http://localhost:9200/ { "status" : 200, "name" : "Zero", "cluster_name" : "elasticsearch", "version" : { "number" : "1.7.2", "build_hash" : "e43676b1385b8125d647f593f7202acbd816e8ec", "build_timestamp" : "2015-09-14T09:49:53Z", "build_snapshot" : false, "lucene_version" : "4.10.4" }, "tagline" : "You Know, for Search" } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:44:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:44:55 +0000 Subject: [Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #18) > No it doesn't, the script explodes! > > FAIL misc/cronjobs/longoverdue.pl > FAIL valid > "my" variable $borrower_category masks earlier declaration > in same scope > "my" variable $skip_borrower_category masks earlier > declaration in same scope I have submitted a follow-up, marked as passed QA. (Have a look at the QA script :)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:53:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:53:24 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #177 from Jonathan Druart --- Sorry, the answer was in your first post: try using jessie instead of wheezy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 12:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 10:55:27 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #178 from Jonathan Druart --- (In reply to Jonathan Druart from comment #177) > Sorry, the answer was in your first post: try using jessie instead of wheezy. At least it's what I am using, maybe it works under wheezy, I don't know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:03:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:03:25 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:03:29 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43441|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 43495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43495&action=edit Bug 14244: viewing a bib item's circ history requires circulation permissions On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:03:31 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #179 from kohayu --- (In reply to Jonathan Druart from comment #178) > (In reply to Jonathan Druart from comment #177) > > Sorry, the answer was in your first post: try using jessie instead of wheezy. > > At least it's what I am using, maybe it works under wheezy, I don't know! ok, i try jessie , thanks a lot, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:03:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:03:46 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |misilot at fit.edu |ity.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:09:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:09:05 +0000 Subject: [Koha-bugs] [Bug 12770] Notice template tool enhancement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #9 from Jonathan Druart --- Blocked by 12769. At first glance I don't understand the change made in C4::Letters. And no tests for this change. Then, you add sql queries to pl file: should be in module and covered by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:15:47 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #55 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #54) > (In reply to Jonathan Druart from comment #47) > > I would like to get point of view from another QAer on this one and bug > > 11747. > > I don't know to be sure Kyle's patch won't introduce regression on the > > tools/letter.pl page. > > Moreover I am still concerned by the addition of 3 prefs to do the same > > thing. > > I did not see a regression in the tools/letter.pl area - do you have an > exact process - I test but not find problem with the letter I have already. This is no longer valid, Kyle validated my counter patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:21:19 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 --- Comment #7 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > Forget last comment. > > Marcel, what do you suggest? If one of those two logfiles (opac, intranet) is not writable, log4perl will crash nicely. The goal was to prevent such a crash. So I would suggest to add the warnings about the unwritable logfile and still return undef. So do not call log4perl and no additional log message. Note that this situation should be quite unusual. Probably both files are writable or both are not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:21:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:21:27 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #56 from Jonathan Druart --- For both 11625 and 11747 (I have squashed the patch, I don't which patch is guilty): 1) FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 11101) forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 11116) and 11109 print "Upgrade to $DBversion done (Bug 13379 - Modify authorised_values.category to varchar(32))\n"; 11120 print "Upgrade to $DBversion done (Bug 13379 - Modify authorised_values.category to varchar(32))\n"; Wrong c/p. Please prefer to amend the original patch than submit another follow-up (to prevent future conflicts). Otherwise the code looks good. I am redoing some UI tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:22:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:22:48 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #9 from Marcel de Rooy --- (In reply to Marc V?ron from comment #8) > I hope that is no blocker :-) No. I will fix it next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:31:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:31:29 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #57 from Jonathan Druart --- It does not work: Try and delete a notice for a given library (not the default one). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:44:14 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #58 from Jonathan Druart --- (In reply to Jonathan Druart from comment #57) > It does not work: > Try and delete a notice for a given library (not the default one). It looks like a bug from master, if IndependentBranches is ON. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:49:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:49:55 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:49:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:49:59 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41795|0 |1 is obsolete| | Attachment #41796|0 |1 is obsolete| | Attachment #41797|0 |1 is obsolete| | --- Comment #59 from Jonathan Druart --- Created attachment 43496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43496&action=edit Bug 11625 - Add system preferences DefaultToLoggedInLibraryCircRules and DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Amended patch: INSERT IGNORE INTO + msg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:50:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:50:05 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #60 from Jonathan Druart --- Created attachment 43497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43497&action=edit Bug 11625 - Implement DefaultToLoggedInLibraryCircRules This patch set makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Administration/Circulation and fines rules 4) Note the rule set selected is for your library 5) Select "All libraries" 6) Note the rule set selected is for "All libraries" 7) Browse to Toos/Notices & slips 8) Note the notice set selected is for your library 9) Select "All libraries" 10) Not the rule set selected is for "All libraries" 11) Click "New Notice" 12) Note the Library field is set to "All libraries" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Passes QA script and tests. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:50:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:50:10 +0000 Subject: [Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 --- Comment #61 from Jonathan Druart --- Created attachment 43498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43498&action=edit Bug 11625: Implement DefaultToLoggedInLibraryNoticesSlips Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:53:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:53:06 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:53:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:53:10 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38279|0 |1 is obsolete| | Attachment #38281|0 |1 is obsolete| | Attachment #38346|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 43499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43499&action=edit Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart Amended patch: INSERT IGNORE INTO + msg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:53:13 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #26 from Jonathan Druart --- Created attachment 43500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43500&action=edit Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 13:53:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 11:53:23 +0000 Subject: [Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747 --- Comment #27 from Jonathan Druart --- Created attachment 43501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43501&action=edit Bug 11747 [QA Followup] - Use system preference Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 14:01:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 12:01:01 +0000 Subject: [Koha-bugs] [Bug 3642] New informations in overdues CSV export In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 --- Comment #16 from Fridolin SOMERS --- (In reply to Jonathan Druart from comment #15) > And also edit the title of the bug report. "New informations in overdues CSV export" is not correct ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 14:06:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 12:06:41 +0000 Subject: [Koha-bugs] [Bug 15022] New: Add support for holds to action logs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15022 Bug ID: 15022 Summary: Add support for holds to action logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org It would be very beneficial for action logs to support holds. We'd need a HoldsLog system preference. I think that we should log pretty much all actions related to a hold except for updating the priorities ( at least not during a re-flow ) as that would just cause an incredible amount of data to wade through. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 14:18:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 12:18:22 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #32 from Manos PETRIDIS --- Wouldn't a user_defined_function be better suited to the task? One could create a koha_getdate() or even a koha_getdatetime() and they would only need be be changed once, depending on RDBMS used, until koha starts using a db abstraction layer that is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 14:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 12:20:35 +0000 Subject: [Koha-bugs] [Bug 15023] New: Allow patron anonymize/bulk delete tool to be limited by branch Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Bug ID: 15023 Summary: Allow patron anonymize/bulk delete tool to be limited by branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org It has been requested that the anonymization tool be allowed to work on patrons for an individual branch rather than being all or nothing as it is now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 14:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 12:20:41 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 14:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 12:20:44 +0000 Subject: [Koha-bugs] [Bug 15023] Allow patron anonymize/bulk delete tool to be limited by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:00:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:00:16 +0000 Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export authorized values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:02:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:02:56 +0000 Subject: [Koha-bugs] [Bug 7663] batch add barcodes to a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:11:18 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #10 from Nicole C. Engard --- (In reply to David Cook from comment #9) > Not very positive, because Keyword to Marc mapping only allows one mapping, > when you theoretically might want to use 264 "or" 260 depending on which is > available per record. But, we could enhance it to do what we need ... couldn't we? Just spit balling ideas here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:12:24 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #142 from Nicole C. Engard --- I'll add here, that once this is in 3.22 I can guarantee many many testers and since it doesn't hurt the existing cataloging tool I like the idea of adding it in with an experimental warming. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:32 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:36 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43429|0 |1 is obsolete| | Attachment #43430|0 |1 is obsolete| | Attachment #43431|0 |1 is obsolete| | Attachment #43432|0 |1 is obsolete| | Attachment #43433|0 |1 is obsolete| | Attachment #43438|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 43502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43502&action=edit Bug 13918 - Add waiting expiration date to opac list of holds for user Waiting holds for patrons in the opac should display the hold expiration date based on the max pickup delay if it is set. Test Plan: 1) Ensure ReservesMaxPickUpDelay is set 2) Place a hold on a record 3) Check in the item, use it to fill the hold 4) Log into the opac as that user 5) View the holds list, note the 'until ' addition to the waiting hold line. Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:39 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #52 from Jonathan Druart --- Created attachment 43503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43503&action=edit Bug 13918 [QA Followup] - Unit Tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:43 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #53 from Jonathan Druart --- Created attachment 43504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43504&action=edit Bug 13918 [QA Followup] - Remove reserves_count Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:47 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #54 from Jonathan Druart --- Created attachment 43505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43505&action=edit Bug 13918 [QA Followup] - Improve $biblio->subtitles() Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:50 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #55 from Jonathan Druart --- Created attachment 43506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43506&action=edit Bug 13918 [QA Followup] - Remove dead template code Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:17:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:17:54 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #56 from Jonathan Druart --- Created attachment 43507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43507&action=edit Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:18:46 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |charles.farmer at inlibro.com --- Comment #4 from Charles Farmer --- Hi Fridolin, Could you take a look at Bug 12769? The patch was developed in 2014 to address the issue of adding a fee to any kind of notice, including overdue notices, and from what I see, your needs could be covered by that patch. If we want to see this feature added to Koha someday, we will have to join our efforts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:22:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:22:10 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 --- Comment #6 from Marc V?ron --- One more finding: A suggestion ist not visible / manageable if created in staff client with Library set to "Any" The value for the library code in the database is en empty string in that case. It is not visible in staff client, not even for superlibrarians (with and without patch). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:22:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:22:34 +0000 Subject: [Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer at inlibro.com Status|NEW |In Discussion --- Comment #2 from Charles Farmer --- Hi Olli-Antti, Could you take a look at Bug 12769? The patch was developed in 2014 to address the issue of adding a fee to any kind of notice, including overdue notices, and from what I see, your needs could be covered by that patch. Since we are all submitting patches that do relatively the same thing, we will have to get behind one of them to have any chance of making it to the master branch. Tell us what you think in Bug 12769. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:22:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:22:53 +0000 Subject: [Koha-bugs] [Bug 14341] XSLT 773$x In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341 --- Comment #2 from Nicole C. Engard --- 773 0#$tEntomologists' monthly magazine$pENTOMOL MON MAG$dWallingford : Gem Publishing Company$x0013-8908$yFNMMA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:27:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:27:23 +0000 Subject: [Koha-bugs] [Bug 13384] RDA: 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #2 from Nicole C. Engard --- This was based on rules given to me by a library. I'm fine with anything as long as it's hideable using spans if need be. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:27:53 +0000 Subject: [Koha-bugs] [Bug 13384] RDA: 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |wsalesky at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:29:03 +0000 Subject: [Koha-bugs] [Bug 14227] rda toolkit integration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14227 --- Comment #2 from Nicole C. Engard --- I'm actually not sure. I was sharing an idea from a library. This is the tool: https://access.rdatoolkit.org/ and apparently it's in other ILSes, but that's the limit of my knowledge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:31:35 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:31:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:31:37 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42971|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 43508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43508&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard I love it, I'd recommend adding an icon to the menu next to it, but this patch works as described so I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:31:54 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:38:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:38:37 +0000 Subject: [Koha-bugs] [Bug 15024] New: Add a link to add more than one title to another list in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15024 Bug ID: 15024 Summary: Add a link to add more than one title to another list in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt at gmail.com Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, It would be fine to have a link to add more than one title to another list in OPAC. Add a link like "Remove from list" which appears at the top of list and for each individual title. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:51:41 +0000 Subject: [Koha-bugs] [Bug 13269] not all 5xx fields show in the staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13269 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:54:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:54:34 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:54:37 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31630|0 |1 is obsolete| | Attachment #31631|0 |1 is obsolete| | Attachment #32046|0 |1 is obsolete| | Attachment #32271|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 43509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43509&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:54:46 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #25 from Kyle M Hall --- Created attachment 43510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43510&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:59:32 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43509|0 |1 is obsolete| | Attachment #43510|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 43511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43511&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 15:59:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 13:59:41 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #27 from Kyle M Hall --- Created attachment 43512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43512&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:22:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:22:49 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:22:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:22:52 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43153|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 43513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43513&action=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:32:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:32:04 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41606|0 |1 is obsolete| | Attachment #41607|0 |1 is obsolete| | Attachment #41608|0 |1 is obsolete| | Attachment #41609|0 |1 is obsolete| | Attachment #41610|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall --- Created attachment 43514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43514&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:32:01 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:32:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:32:19 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #43 from Kyle M Hall --- Created attachment 43515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43515&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:32:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:32:22 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #44 from Kyle M Hall --- Created attachment 43516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43516&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:32:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:32:26 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #45 from Kyle M Hall --- Created attachment 43517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43517&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:32:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:32:29 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #46 from Kyle M Hall --- Created attachment 43518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43518&action=edit Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:36:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:36:12 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43514|0 |1 is obsolete| | Attachment #43515|0 |1 is obsolete| | Attachment #43516|0 |1 is obsolete| | Attachment #43517|0 |1 is obsolete| | Attachment #43518|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall --- Created attachment 43519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43519&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:36:19 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #48 from Kyle M Hall --- Created attachment 43520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43520&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:36:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:36:26 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #50 from Kyle M Hall --- Created attachment 43522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43522&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:36:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:36:23 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #49 from Kyle M Hall --- Created attachment 43521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43521&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:36:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:36:30 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #51 from Kyle M Hall --- Created attachment 43523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43523&action=edit Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:37:27 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #52 from Kyle M Hall --- (In reply to Jonathan Druart from comment #41) > There is something wrong in the second patch: > > installer/data/mysql/updatedatabase.pl | 1157 > +------------------- Fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:41:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:41:57 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Depends on| |13918 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 [Bug 13918] Add waiting expiration date to opac list of holds for user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:41:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:41:57 +0000 Subject: [Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14310 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:56:30 +0000 Subject: [Koha-bugs] [Bug 13016] Add fine grace period by hour In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13016 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Kyle M Hall from comment #1) > Grace periods for hourly checkouts are in hours. The column is just labeled > wrong. Hi Kyle, Thank you for your response. Do you mean that if hour is selected in Unit, grace period will be in hour? Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 16:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 14:57:37 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #34 from Charles Farmer --- (In reply to Jonathan Druart from comment #33) To better make progress, I would need to know precisely what you mean by "QA concerns". After reading this thread through and through and opening the most recent patches, I think the only concern that wasn't explicitly addressed, about the UNIQUE key, was covered by the patch. Also, prove was run against t/db_dependant/Overdues.t without errors. There is, however, one odd thing: atomicupdates are only considered by updatedatabase.pl if the file extension is .perl or .sql, not .pl. I'll follow up this post with a new patch that fixes this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:00:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:00:23 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:00:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:00:54 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #35 from Charles Farmer --- Created attachment 43524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43524&action=edit Bug 13624 - renaming atomicupdate from .pl to .perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:04:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:04:16 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:04:18 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40034|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 43525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43525&action=edit Bug 14310 - Suspend and resume indvidual holds from patron holds table This enhancment adds the ability to suspend and resume individual holds from the holds table on circulation.pl and moremember.pl. The interface is inspired/cribbed from the same feature already available in the opac. Test Plan: 1) Apply this patch 2) Find a patron with holds 3) Suspend a hold with no resume date 4) Resume the suspended hold 5) Suspend a hold with a resume date 6) Resume the suspended hold Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:04:25 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #13 from Kyle M Hall --- Created attachment 43526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43526&action=edit Bug 14310 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:12:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:12:58 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:13:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:13:01 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42772|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 43527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43527&action=edit [PASSED QA] Bug 8417: Make the order receive date editable Currently the date of the order reception is the date of shipping date, which is wrong. This patch makes this date editable (with default is today). Test plan: 1/ Create an order and receive it 2/ Confirm that you can edit the reception date and it's take into account as the datereceived. Signed-off-by: Aleisha Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:31:30 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:31:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:31:33 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42756|0 |1 is obsolete| | Attachment #42757|0 |1 is obsolete| | Attachment #42758|0 |1 is obsolete| | Attachment #42759|0 |1 is obsolete| | Attachment #42760|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 43528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43528&action=edit [DO NOT PUSH] [SIGNED-OFF] Script to generate the permissions include file perl build_permissions_file.pl > koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc http://bugs.koha-community.org/show_bug.cgi?id=13632 Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=13622 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:31:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:31:44 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #32 from Kyle M Hall --- Created attachment 43530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43530&action=edit [SIGNED-OFF] Bug 13632: Do not use userflags.flagdesc and permissions.description These 2 fields are not used anymore, but we want to keep them anyway. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:31:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:31:41 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #31 from Kyle M Hall --- Created attachment 43529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43529&action=edit [SIGNED-OFF] Bug 13632: Use an include file to display permissions This patch set moves the permissions' descriptions to the po files instead of having them in the DB. Test plan: 0/ Apply all patches 1/ Create a new installation 2/ Confirm the userflags and permissions tables are correctly populated 3/ Update the po file for a translated language 4/ Confirm you are able to translate the permissions descriptions 5/ Install the template files for this language 6/ Switch the interface to use this language and confirm the string are correctly translated. QA Note: At this point we could remove the userflags.flagdesc and permissions.description DB fields, but I would prefer to keep them: developers will know what the permission do without the need to go and see the include file (we have it in the sql files and so, in the DB). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:31:47 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #33 from Kyle M Hall --- Created attachment 43531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43531&action=edit [SIGNED-OFF] Bug 13632: Populate user_flags and permissions tables in the web installer Move the 2 specific 'en' files outside of the language directory. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 17:31:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 15:31:50 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #34 from Kyle M Hall --- Created attachment 43532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43532&action=edit [SIGNED-OFF] Bug 13632: Remove specific files Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:01:45 +0000 Subject: [Koha-bugs] [Bug 5655] printing of fines should support more than one line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5655 --- Comment #2 from bondiurbano --- Nicole, Please look at bugs #12769 and #12770. There's a discussion about issues that I think have some contact points with your/my requirement. By the way, I've opened bug #14934. Perhaps it may be included here... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:38:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:38:37 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:38:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:38:39 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43445|0 |1 is obsolete| | --- Comment #8 from Barton Chittenden --- Created attachment 43533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43533&action=edit Bug 14504 [QA Follow-up] * Fix POD warning. * Remove redundant 'use stric' and 'use warnings' * Remove $VERSION and --version option. * Remove --dry-run option * Split test for --help and check for @criteria into two separate pod2usage calls, enabling -msg on the latter. * Fix 'target_tiems' typo. * Test for holds on items to be deleted. * Fix whitespace * Fix test for holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:42:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:42:55 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:42:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:42:58 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43452|0 |1 is obsolete| | Attachment #43453|0 |1 is obsolete| | Attachment #43454|0 |1 is obsolete| | Attachment #43484|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall --- Created attachment 43534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43534&action=edit [PASSED QA] Bug 15005: Replace CGI->url with the corresponding url CGI->url does not return the correct url on install using packages. Test plan: 1/ Try to reproduce the bug from the description of bug 15005. You should be able to login to the intranet and the OPAC 2/ Send a basket and a list from the intranet and the OPAC. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:43:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:43:09 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #23 from Kyle M Hall --- Created attachment 43535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43535&action=edit [PASSED QA] Bug 15005: Remove CGI->url calls from pl scripts Same as previous patch for calls in pl scripts. Test plan: - delete an entry of your search history from intranet and opac - with IndependentBranches=OFF, go on the waiting holds and confirm that the link next to 'Holds awaiting pickup for your library on' is correct. - search for items, the pagination should work correctly Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:43:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:43:12 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #24 from Kyle M Hall --- Created attachment 43536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43536&action=edit [PASSED QA] Bug 15005: Fix pagination_bar calls Test plan: Create an order for an existing biblio, confirm that the pagination links work correctly. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:43:16 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 --- Comment #25 from Kyle M Hall --- Created attachment 43537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43537&action=edit [PASSED QA] Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script paths Since I don't manage to make SCRIPT_NAME works directly with RequestHeader and/or ReverseProxyPath, the easier way it to fix all the different occurrences. Test plan: On the import patrons page, confirm that the "Import" button does not redirect to a 'Not found' page. You should stay on the import patrons page. Note that if this change works, all others should work too. Have a look at the diff of this patch and confirm there is no typo. Signed-off-by: Josef Moravec Tested in patron import and item batch modification Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 18:45:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 16:45:16 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #26 from Kyle M Hall --- Note: SCRIPT_NAME is referenced in a number of templates and a few perl scripts. In some cases it is passed to the template as a parameter. In others it is not, which makes the form action submit to the current url. As far as I'm aware this works fine and is non-detrimental, but I did want to make a note of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 19:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 17:16:02 +0000 Subject: [Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 20:39:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 18:39:36 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43093|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 43538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43538&action=edit Bug 14247: Add system preference for news display Added default value for system preference. Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 20:43:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 18:43:56 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #17 from Marc V?ron --- Created attachment 43539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43539&action=edit Bug 14246: Update NewsChannel tests This commit adds the new 'borrowernumber' field to the existing test framework to make it pass. It does not include new tests. Sponsored-by: Halland County Library Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 20:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 18:45:32 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 20:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 18:53:33 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43538|0 |1 is obsolete| | --- Comment #18 from Marc V?ron --- Created attachment 43540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43540&action=edit Bug 14247: Add system preference for news display Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 20:58:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 18:58:44 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43540|0 |1 is obsolete| | --- Comment #19 from Marc V?ron --- Created attachment 43541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43541&action=edit Bug 14247: Add system preference for news display Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:17:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:17:29 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #20 from Marc V?ron --- Created attachment 43542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43542&action=edit Bug 14247: Add system preference for news display Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:17:58 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:25:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:25:03 +0000 Subject: [Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645 Andreas Hedstr?m Mace changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace at sub.s | |u.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:25:02 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #21 from Marc V?ron --- Created attachment 43543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43543&action=edit Bug 14247: Rename sysprefs atomic update file This trivial patch changes the name of the SQL update file to match the guidelines on the wiki. Sponsored-by: Halland County Library Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:25:56 +0000 Subject: [Koha-bugs] [Bug 15025] New: Regression: "print summary" does not display fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15025 Bug ID: 15025 Summary: Regression: "print summary" does not display fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Possibly a similar issue to bug 12971. Patrons' fines should show on "print summary" (i.e. members/summary-print.pl), and their outstanding balance should show in the "Total Due" row. No fines show, and "Total Due" is always 0. To replicate: Find a patron who has unpaid fines, go to their patron detail page (moremember.pl). Click on the 'Print' button and choose 'Print Summary' This *should* display the outstanding fines, and the total due; no fines display, and the total due shows as 0. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:26:24 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39527|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:30:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:30:53 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43541|0 |1 is obsolete| | --- Comment #22 from Marc V?ron --- Comment on attachment 43541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43541 Bug 14247: Add system preference for news display Obsoleted because the same content is in second patch. @ Martin, can you please verify / confirm that the signed-off patches are the correct ones? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:38:41 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:47:24 +0000 Subject: [Koha-bugs] [Bug 14911] Serial Subscr. and Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 21:58:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 19:58:57 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42821|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:04:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:04:50 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43415|0 |1 is obsolete| | --- Comment #19 from Marc V?ron --- Created attachment 43544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43544&action=edit Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:05:37 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:13:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:13:27 +0000 Subject: [Koha-bugs] [Bug 9026] Reject/approve a tag *one time* / (batch) edit tags In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9026 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:20:06 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #43 from Marc V?ron --- *** Bug 14063 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:20:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:20:06 +0000 Subject: [Koha-bugs] [Bug 14063] Implement language overlay for authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Marc V?ron --- *** This bug has been marked as a duplicate of bug 14100 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:21:58 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 22:30:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 20:30:26 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org --- Comment #19 from Karl Holten --- Hi, we're the institution that requested the bibnumber show up. Our staff do a lot of searching but standard numbers such as the bib record number, OCLC number, barcode, ISSN. It's a more direct way to search in Koha which tends to be very keyword heavy. Staff want to get fewer results, not more or even multiple. Seeing the record number also helps identify it quickly versus the title which can be more generic and/or be one of other similar titles. Anyway, that's the reason we made that request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 23:38:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 21:38:55 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #82 from H?ctor Eduardo Castro Avalos --- Created attachment 43545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43545&action=edit Bug 13642 - Unit Test for Koha::DublinCore.pm To test -Apply patches -prove t/db_dependent/DublinCore.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 23:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 21:39:22 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 23:41:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 21:41:00 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #83 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #81) > No need to ask for a signoff for the tests. Hi Jonathan Unit test added for Koha::DublinCore Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 23:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 21:44:14 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 23:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 21:44:27 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #44 from Charles Farmer --- Created attachment 43546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43546&action=edit Bug 12768: Fixed tests 44 and 45 of t/db_dependant/Circulation.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 16 23:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 21:47:42 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #45 from Charles Farmer --- (In reply to Jonathan Druart from comment #38) > It does not seem to work if item-level_itypes is set to biblio. > You should also provide tests for C4::Circulation::LostItem (I suspect that > the problem comes from the query executed in this subroutine). When you say "provide tests for LostItem", do you mean that a separate file should be written under t/db_dependent/Circulation/ for that purpose, or would you accept if the tests were added to everything else in Circulation.t ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 00:21:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 22:21:20 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #84 from Tom?s Cohen Arazi --- I liked the Koha::Crosswalk::DublinCore package name. Can we keep it? :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 01:06:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 23:06:34 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #85 from H?ctor Eduardo Castro Avalos --- (In reply to Tom?s Cohen Arazi from comment #84) > I liked the Koha::Crosswalk::DublinCore package name. Can we keep it? :-D Yes, Mr. Tom?s Tomorrow morning i'll make the changes. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 01:07:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 23:07:08 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #143 from Jesse Weaver --- Created attachment 43547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43547&action=edit Bug 11559: (QA followup) switch to new delimiter, fix minor issues This followup introduces a major change; instead of subfields starting with '$', they now start with '?'. The double-cross character can be typed with Ctrl-D. It also fixes the following: * Add UUID.pm dependency * Remove debugging call * Fix toLocaleFormat error reported by Nick Clemens * Ignore subfields that are marked as unrepeatable/mandatory AND ignored (tab is -1) * Mention lack of support for UNIMARC/NORMARC fixed fields in system preferences screen * Confirm when user creates new record and current record is modified * Perform better when importing gigantic record dump * Show "Edit" instead of "Import" and allow direct editing for local catalog records in search screen * Add "Keyboard shortcuts" help button to toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 01:16:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 16 Oct 2015 23:16:09 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #144 from Jesse Weaver --- I've pushed a major update that I think should fix most outstanding issues. Specific things that weren't fixed: * Search results: because the search screen allows on-the-fly resorting, it can only fetch so many records and be reasonably performant. The current cap is 100 records per server. * Favicon: I have literally no idea what's going on with this. It only seems to display correctly after a forced reload (Ctrl-Shift-R). Rancor isn't doing anything differently of note. Also, there's finally proper documentation for the macro language: http://wiki.koha-community.org/wiki/Rancor_Macro_Language -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 17:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 15:05:03 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #145 from Nick Clemens --- Major issue: Saving a record deletes the first character of every subfield (tested on firefox/chrome ubuntu/debian) Small merge conflict in C4/Installer/PerlDependencies.pm Other minor issues discovered in testing: -Ctrl+D when dropdown is selected bookmarks page instead of adding a new field -Backspace when a dropdown is selected backs browser out of the page, changes lost -If a subfield is mandatory the containing filed must be mandatory to make sure it is applied -Cannot delete a subfield with a dropdown -Ctrl+X does not remove an empty field -Import record should be optional to overlay or create new -Import record with curly bracket escaped characters e.g. {uml} breaks formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 17:08:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 15:08:48 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #8 from Marc V?ron --- The feature works, but the tests still fail, same results as in comment #5: 1..12 ok 1 - userenv set not ok 2 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 95. # got: '0' # expected: '1' ok 3 - Should have 5 outstanding holds not ok 4 - Should have duration of 1 # Failed test 'Should have duration of 1' # at t/db_dependent/DecreaseLoanHighHolds.t line 97. # got: '0' # expected: '1' not ok 5 - due_date should be a DateTime object # Failed test 'due_date should be a DateTime object' # at t/db_dependent/DecreaseLoanHighHolds.t line 98. # got: '' # expected: 'DateTime' ok 6 - Should not exceed threshold not ok 7 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 116. # got: '0' # expected: '1' ok 8 - Should not exceed threshold not ok 9 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 127. # got: '0' # expected: '1' not ok 10 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 134. # got: '0' # expected: '1' not ok 11 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 141. # got: '0' # expected: '1' not ok 12 - Should exceed threshold # Failed test 'Should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 148. # got: '0' # expected: '1' # Looks like you failed 8 tests of 12. Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/12 subtests Test Summary Report ------------------- t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 2048 Tests: 12 Failed: 8) Failed tests: 2, 4-5, 7, 9-12 Non-zero exit status: 8 Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.30 cusr 0.10 csys = 1.42 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 18:11:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 16:11:32 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43545|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 19:02:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 17:02:34 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43313|0 |1 is obsolete| | --- Comment #86 from H?ctor Eduardo Castro Avalos --- Created attachment 43548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43548&action=edit Bug 13642 [ENH] Adding new features for Dublin Core metadata When Koha export a bibliographic record to DC, makes it in XML format. This XML not follows the DC-XML recommendations as should be: elements in uppercase eg. dc:Date, dc:Creator, section 4.2, recommendation 4 explain that "The property names for the 15 DC elements should be all lower-case." eg. dc:date, dc:creator" and section "4.3 Example - a simple DC record", xsi:schemaLocation="http://example.org/myapp/ http://example.org/myapp/schema.xsd" schema does not exist. The recommendation can be consulted at . This new feature, adds an ability to export Dublin Core metadata to XML and RDF (including rdfxml, rdfjson, ntriples, turtle, etc.) Test plan --------------- 1) Download Dublin Core file. Open up the file, and make sure that the document not follows the DC-XML recommendations as should be. 2) Apply patches. 3) Go to whichever bib record in OPAC or staff and click on Save > Dublin Core. A modal will display, prove all options. 4) Change the system preference 'Opac ExportOptions' by enabling and disabling Dublin Core and try to download a record in the OPAC. 5) Try several bibliographic records in any format (book, magazine, DVD, etc.) to confirm that properly exported. 6) RDF/XML can be validated per RDF Validator W3C. 7) DC-XML cannot valid if not exist a valid XSD schema. 8) OAI-DC can be validated using and the proper schema typed in text field for URL. 9) Unit test, prove t/db_dependent/Record.t Sponsored-by: Universidad de El Salvador NOTE: XML::Entities, HTML::Entities and, HTML::Entities::Numbered were eliminated from patch, use instead C4::Record::_entity_encode, RDF::Helper has been eliminated too. DublinCore.pm Changed to Crosswalk/ according with comment 83 by RM Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 19:11:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 17:11:43 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #87 from H?ctor Eduardo Castro Avalos --- Created attachment 43549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43549&action=edit Bug 13642 - Unit Test for Koha::Crosswalk::DublinCore.pm To test -Apply patches -porve t/db_dependent/DublinCore.t Sponsored-by: Universidad de El Salvador -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 17 19:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 17:44:22 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #88 from H?ctor Eduardo Castro Avalos --- Hi Tom?s and Jonathan Changes Done! I don't know if I need another sign-off or I can keep the last one by Marc. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 00:10:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 17 Oct 2015 22:10:21 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #127 from David Kuhn --- I get the following error message when I try to install patch: Some problems occurred applying patches from bug 8753:

Something went wrong !

Applying: Bug 8753 - Add forgot password link to OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/en/mandatory/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sample_notices.sql Failed to merge in the changes. Patch failed at 0001 Bug 8753 - Add forgot password link to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 10:45:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 08:45:07 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer --- Hi Jonathan, this looks very good by now - I am optimistic that this is the last list: Not working yet: - opac-suggestions.pl - opac-readingrecord.pl - opac-reserve.pl I think it would be really nice to cover the OPAC with the initial patch. - suggestion/suggestion.pl Organize by itemtype - tab descriptions are not correct I think I have checked all files touched by this bug - at least I tried really hard - everything else looked fine to me. --- Could go on a separate bug to be fixed later: - Allow editing of entries, instead of having to delete and readd them Further testing notes - out of scope for this bug: - circ/returns.pl Shows code of homebranch and hodingbranch Show code of itemtype, incorrect label: Type should be Itemtype - suggestion/suggestion.pl Edit page: Pull down needs empty entry, when no itemtype was selected in the OPAC on adding it. Otherwise first entry will accidentally be saved on editing. Summary page: Show description instead of itemtype code - Guided reports - Definitions Shows itemtype code instead of description in pull down -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:30 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #88 from Katrin Fischer --- Created attachment 43550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43550&action=edit [PASSED QA] Bug 10363: There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:35 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #89 from Katrin Fischer --- Created attachment 43551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43551&action=edit [PASSED QA] Bug 10363: Use Koha::AuthorisedValue[s] in the admin page Now we have packages, we need use them in the pl script. Test plan: Verify there are no regression on addind/editing/deleting authorised values. Done forget to test the branch limitation. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:40 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #90 from Katrin Fischer --- Created attachment 43552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43552&action=edit [PASSED QA] Bug 10363: [QA Followup] Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:44 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #91 from Katrin Fischer --- Created attachment 43553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43553&action=edit [PASSED QA] Bug 10363: Fix pod Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:49 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #92 from Katrin Fischer --- Created attachment 43554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43554&action=edit [PASSED QA] Bug 10363: (QA followup) DB update / atomic update This patch just moves the DB update code into an atomicupdate file to avoid nasty merge conflicts. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:53 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #93 from Katrin Fischer --- Created attachment 43555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43555&action=edit [PASSED QA] Bug 10363: QA Follow-up - fixing POD and spelling We should stick with either AE (authorized) or BE (authorised) spelling. Corrected error messages to use authorized. Also fixed tiny copy & paste error in POD. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:02:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:02:58 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #94 from Katrin Fischer --- Created attachment 43556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43556&action=edit [PASSED QA] Bug 10363: FIX rebase conflict error Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:03:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:03:02 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #95 from Katrin Fischer --- Created attachment 43557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43557&action=edit [PASSED QA] Bug 10363: FIX regression - prevent duplicate Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:03:12 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #96 from Katrin Fischer --- Created attachment 43558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43558&action=edit [PASSED QA] Bug 13636: Change wording added vs inserted http://bugs.koha-community.org/show_bug.cgi?id=10363 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:03:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:03:16 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #97 from Katrin Fischer --- Created attachment 43559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43559&action=edit [PASSED QA] Bug 10363: (follow-up) DB update - change in kohastructure.sql Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:05 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:08 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:12 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41290|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:15 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:22 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41293|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:18 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:25 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41294|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:29 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41302|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:32 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43114|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:04:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:04:35 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:05:25 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|m.de.rooy at rijksmuseum.nl |katrin.fischer at bsz-bw.de --- Comment #98 from Katrin Fischer --- Over 2 years... but finally! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:16:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:16:02 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #20 from Katrin Fischer --- Hi Karl, with this patch the bibnumber will only show for suppressed records - that's what didn't make so much sense to me. I am not opposed at all to add the bibnumber to display in general, but then maybe on a separate bug as it doesn't really fit here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:27:44 +0000 Subject: [Koha-bugs] [Bug 8438] Allow staff only to only claim serial issues of their own branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Users should only claim for |Allow staff only to only |serials related to their |claim serial issues of |branch. |their own branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:45:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:45:01 +0000 Subject: [Koha-bugs] [Bug 8438] Allow staff only to only claim serial issues of their own branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 11:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 09:45:04 +0000 Subject: [Koha-bugs] [Bug 8438] Allow staff only to only claim serial issues of their own branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35311|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer --- Created attachment 43560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43560&action=edit [PASSED QA] Bug 8438: Users can only claim for serials related to their branch. Only superlibrarian users and users with superserials permission can override this limitation. This patch adds a new subroutine C4::Serials::can_claim_subscription. Signed-off-by: Paola Rossi The upgrading of the DB was as required: for each [PT/S] patron with the permission "claim_serials" ON, the permission "superserials" became[/was kept to] ON. Then, after having checked the DB upgrading, to test the currently adding limitation: > Users can only claim for serials related to their branch , I reset 2 PT/S patrons-users to: permission claim_serials: YES permission superserials: NO and I set the syspref "IndependendeBranches" to "Prevent". For: > Only superlibrarian users can override this limitation. the S patron-user could list AND claim: A) subscriptions of his own branch, B) subscriptions of other branch, C) subscriptions without branch. For: > Only users with superserials permission can override this limitation. the PT patron-user could list: A) subscriptions of his own branch, B) subscriptions of other branch, C) subscriptions without branch, and could claim only: A) subscriptions of his own branch, C) subscriptions without branch. NB: a subscription is selected to be claimed. Then I set the syspref "IndependendeBranches" to "Don't prevent". The behaviour was [exactly the same as in master] without the added limitation. On [S/PT] patrons, if permission claim_serials was NO, no Claims link was available on Serials' page, either under "Prevent" or under "Don't prevent". Signed-off-by: Katrin Fischer Added the results of Paola's testing to the commit message as test plan. Note to RM: Maybe we could add a note to the release notes, that Koha now enforces superserials with independent branches better, so people might have to adapt permissions in order to claim for other branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:33:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:33:51 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #35 from Katrin Fischer --- Created attachment 43561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43561&action=edit Script to generate the permissions include file perl build_permissions_file.pl > koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc http://bugs.koha-community.org/show_bug.cgi?id=13632 Signed-off-by: Kyle M Hall http://bugs.koha-community.org/show_bug.cgi?id=13622 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:33:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:33:54 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #36 from Katrin Fischer --- Created attachment 43562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43562&action=edit [PASSED QA] Bug 13632: Use an include file to display permissions This patch set moves the permissions' descriptions to the po files instead of having them in the DB. Test plan: 0/ Apply all patches 1/ Create a new installation 2/ Confirm the userflags and permissions tables are correctly populated 3/ Update the po file for a translated language 4/ Confirm you are able to translate the permissions descriptions 5/ Install the template files for this language 6/ Switch the interface to use this language and confirm the string are correctly translated. QA Note: At this point we could remove the userflags.flagdesc and permissions.description DB fields, but I would prefer to keep them: developers will know what the permission do without the need to go and see the include file (we have it in the sql files and so, in the DB). Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:33:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:33:58 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #37 from Katrin Fischer --- Created attachment 43563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43563&action=edit [PASSED QA] Bug 13632: Do not use userflags.flagdesc and permissions.description These 2 fields are not used anymore, but we want to keep them anyway. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:34:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:34:02 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #38 from Katrin Fischer --- Created attachment 43564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43564&action=edit [PASSED QA] Bug 13632: Populate user_flags and permissions tables in the web installer Move the 2 specific 'en' files outside of the language directory. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:34:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:34:06 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #39 from Katrin Fischer --- Created attachment 43565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43565&action=edit [PASSED QA] Bug 13632: Remove specific files Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:34:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:34:10 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #40 from Katrin Fischer --- Created attachment 43566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43566&action=edit Bug 13632: QA follow-up: Tidy installer directories / update permissions.inc - removes permission related text files from translated web installer directories - updates the permissions.inc file to include the newest permission 'self_checkout' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:35:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:35:04 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:35:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:35:07 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43529|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:35:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:35:10 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43530|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:35:12 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43531|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:35:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:35:15 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:35:17 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43561|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:36:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:36:34 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #41 from Katrin Fischer --- Really happy about this one - there was currently no way to update/fix permission descriptions apart from SQL. Especially annoying for older databases. Jonathan - I added a follow-up. Can you check please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:55:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:55:12 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:55:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:55:15 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43405|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 43567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43567&action=edit [PASSED QA] Bug 14916: Display overdues if due on 23:59 If an item is due today 23:59 and the filter is from yesterday to today, the overdue won't appear on the list. Test plan: Be sure you have an item due on DATE 23:59 Search for overdues from DATE-1 to DATE Without this patch, the item won't appear. With this patch, it will. Regression test: test the CSV download. Note: On the way, this patch remove the deps to C4::Dates (which was the original goal of the bug report). Issue reproduced, it's resolved with this patch. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 12:58:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 10:58:01 +0000 Subject: [Koha-bugs] [Bug 14562] [3.18.x] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Patron with empty card |[3.18.x] Patron with empty |number will be only result |card number will be only |returned by patron |result returned by patron |datatables search |datatables search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 13:03:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 11:03:30 +0000 Subject: [Koha-bugs] [Bug 14562] [3.18.x] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 13:03:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 11:03:32 +0000 Subject: [Koha-bugs] [Bug 14562] [3.18.x] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43292|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 43568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43568&action=edit [PASSED QA] Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string (Fix conflict with bug 12833) This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x): commit 481479fe627dcbabb3ef66df0724cc3fe75b110c Bug 12648: Fix conflict with bug 12833 Test plan: Set the cardnumber of one of the patron to an empty string Do a patron search and use filters The search will redirect to the patron detail page of the patron with the empty string Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 14:08:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 12:08:24 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 14:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 12:08:27 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43341|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer --- Created attachment 43569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43569&action=edit [PASSED QA] Bug 11298: Don't force the renew time to 23:59 If you try to renew an item using the "Renewal due date" at the bottom of the checkouts table, the time will be hardcoded to 23:59 no matter what the user has chosen. Test plan: Check an item out to a patron renew the item and specify a due date using the datetime picker plugin at the bottom of the table Confirm the time you have chosen is correctly used. Followed test plan. It works as advertised. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 14:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 12:18:52 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 14:18:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 12:18:54 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43339|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 43570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43570&action=edit [PASSED QA] Bug 14990: Format the date template-side for moremember Test plan: print slip and show the member detail page, the 3 dates date of birth, date enrolled and date of expiry should be displayed correctly. Followed test pan, works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 14:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 12:22:00 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer --- Jonathan, there are some conflicts - can you please take a look and fix? Applying: Bug 13345: Allow patrons to choose format on sending basket/list by email Using index info to reconstruct a base tree... M C4/Biblio.pm M basket/basket.pl M basket/downloadcart.pl M basket/sendbasket.pl M koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt M opac/opac-downloadcart.pl M opac/opac-downloadshelf.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/downloadshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging virtualshelves/downloadshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging opac/opac-downloadshelf.pl Auto-merging opac/opac-downloadcart.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl Auto-merging basket/downloadcart.pl Auto-merging basket/basket.pl Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 13345: Allow patrons to choose format on sending basket/list by email The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 15:03:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 13:03:18 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43524|0 |1 is obsolete| | --- Comment #36 from Eivin Giske Skaaren --- Created attachment 43571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43571&action=edit Bug 13624 - renaming atomicupdate from .pl to .perl I have not tested this very thoroughly e.g. understood the SQL changes etc. since the patch has been signed off twice before. But it seems to me like this patch is OK. Applied, ran automatic tests and saved some values in the overduerules matrix/tabs OK. Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 15:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 13:03:36 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eivin at sysmystic.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 15:15:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 13:15:14 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |m.de.rooy at rijksmuseum.nl, | |tomascohen at gmail.com --- Comment #1 from Marcel de Rooy --- What about /usr/share/koha_$instance_upload ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 15:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 13:16:44 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #2 from Marcel de Rooy --- Note that it would preferably be a folder that is NOT shared between instances. For simplicity I would recommend that each instance, which has its own upload table, also has its own upload folder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 15:27:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 13:27:59 +0000 Subject: [Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:27:54 +0000 Subject: [Koha-bugs] [Bug 12721] Fix crash if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | Summary|Wrong fieldnames or |Fix crash if incorrect |trailing | in system |fieldnames given in sypref |preference StatisticsFields |StatisticsFields |lead to crash | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:29:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:29:58 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix crash if incorrect |Prevent software error if |fieldnames given in sypref |incorrect fieldnames given |StatisticsFields |in sypref StatisticsFields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:31:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:31:49 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 --- Comment #4 from Eivin Giske Skaaren --- Created attachment 43572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43572&action=edit Bug 14190: Scale search boxes in staff head In this simple patch the width gets controlled by CSS and it becomes easy to set it in just one place. The exact width may need to be discussed but I thought 30em made it look ok on my screen. With this patch we get the wider search boxes with a very small change and another bug may be created if needed to do a bigger refactor and remove stuff not needed in the html and perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this) To test: Apply the patch and reload the staff client. Now the search box is a bit wider and the border etc has changed with it. Some places with more than one search box like "Serials" will not be affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:32:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:32:24 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:42:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:42:06 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #2 from Marc V?ron --- Created attachment 43573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43573&action=edit Bug 12721 - Prevent software error if incorrect fieldnames given in sypref StatisticsFields To reproduce issue: See comment #1 To test: - Apply patch - Leave syspref StatisticsFields empty - Display statistics for an author => Result: Table displays Shelving location, Collection code, Item type (as before) - Change syspref to any combination of location|itype|ccode => Result: Table displays columns as appropriate - Change syspref to some garbage => Result: Same as with empty syspref (was crashing without patch) - Change syspref to valid combination with trailing | => Result: Table displays columns as appropriate (was crashing without patch) - Change syspref to a combination of valid and invalid fields (location|blah|ccode) => Result: Table displays column of valid fields only (was crashing without patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:43:02 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:46:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:46:26 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- A few small things: 1) Could we rename the script from just export.pl to export_records.pl? I think this would make it easier to spot and be in line with the export_borrowers.pl script already in the same directory. 2) Running the script without any argument exports all your bibliographic records - this could create quite a big file for a bigger catalog. Could it be better to display the help and have a -c switch for confirming or similar? 3) Some of the options have no documentation. For example: start_accession and end_accession - is this the date_created from the record? 4) Are csv and auths incompatible? It seems that ./misc/export.pl --filename=koha2.mrc --format=csv --record-type=auths Creates a file with bib data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:48:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:48:21 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #6 from Katrin Fischer --- Overall - big improvement. Please take a look at my comments soon! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:58:36 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43572|0 |1 is obsolete| | --- Comment #5 from Marc V?ron --- Created attachment 43574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43574&action=edit Bug 14190: Scale search boxes in staff head In this simple patch the width gets controlled by CSS and it becomes easy to set it in just one place. The exact width may need to be discussed but I thought 30em made it look ok on my screen. With this patch we get the wider search boxes with a very small change and another bug may be created if needed to do a bigger refactor and remove stuff not needed in the html and perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this) To test: Apply the patch and reload the staff client. Now the search box is a bit wider and the border etc has changed with it. Some places with more than one search box like "Serials" will not be affected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:58:42 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #746 from Katrin Fischer --- Hi Kyle, not sure about the dependency on 13790 - maybe this should be blocked by it and not the other way around (might have made a mistake there)? Also I saw you split of some patches for a more granular approach - what shall we do here? Patch currently doesn't apply - so choosing that for now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 16:58:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 14:58:50 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 17:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 15:30:46 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #95 from Katrin Fischer --- 1) Hm, something strange, I see Removed date in the code, but it doesn't show up on the form for me? I was looking for it, as I wanted to suggest a change: Date deleted (item). 2) Similarly, I would use "Date acquired (item)" for "Acquired date". Because someone might question if this is about the record or the item and it's what the field in the item is labelled. 3) Can you please update and post the initial commit message? For example it still lists a items.statisticvalue that doesn't exist. So a bit hard to see what actually happens now as this has been going back and forth a bit. Maybe we should also upate the actual commit message? X) the ... characters in the second line seems to belong to a lccn related feature and has no label at all :( But this is an old problem, so out of scope here. Can you take a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 18:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 16:38:41 +0000 Subject: [Koha-bugs] [Bug 12721] Prevent software error if incorrect fieldnames given in sypref StatisticsFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12721 --- Comment #3 from Marc V?ron --- Created attachment 43575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43575&action=edit Bug 12721 - Syspref StatisticsFields: Warning on About page and text change in System preferences This patch adds a warning to the about page if the syspref 'StatisticFields' is misconfigured. Additionally, the text on Home > Administration > SystemPreferences is changed. To test: - Apply patch - Edit syspref 'StatisticFields'. Verify that the explanation makes sense. - Leave field empty => verify that no message appears on About page, tab System information - Insert valid field names, e.g. location|itype => verify that no message appears on the About page - Add trailing char => verify that the warning message appears on the About page - Fill in some garbage or misspell a field name => verify that the warning message appears on the About page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 19:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 17:34:23 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #3 from Tom?s Cohen Arazi --- In /var/lib/koha/instace/upload_dir please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 21:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 19:50:36 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #112 from Katrin Fischer --- (In reply to Julian Maurice from comment #111) > (In reply to Katrin Fischer from comment #103) > > Hi Julian, > > > > I think the common "entry page" to subscriptions for parons in the OPAC is > > opac-detail > subscriptions tab. This view is labelled as 'Normal view' when > > you look at it from the the full history page. I think adding the > > information there the same way we have it on the full history page would > > make sense to me. > > It appears that the date shown on this page is the 'planneddate' which is > the date of reception. Should we change that and display the 'publisheddate' > instead ? Sorry to come back to this so late - I feel like it is a little weird to not display in the OPAC, but not sure right now how best to fix. I will look at the patches again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 22:23:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 20:23:49 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |eivin at sysmystic.com CC| |eivin at sysmystic.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 22:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 20:30:54 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #128 from Liz Rea --- Created attachment 43576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43576&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author: Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 22:47:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 20:47:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39144|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 22:48:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 20:48:56 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #129 from Liz Rea --- That latest one should resolve the merge issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 18 23:55:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 21:55:55 +0000 Subject: [Koha-bugs] [Bug 13585] HEA - Cronjob Setup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13585 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 00:05:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 22:05:11 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #41 from Katrin Fischer --- There are some conflicts - especially in the CSS files. Please fix! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8995: Show OpenURL links in OPAC search results Using index info to reconstruct a base tree... M C4/Biblio.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref M koha-tmpl/opac-tmpl/bootstrap/css/opac.css M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl M koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl M koha-tmpl/opac-tmpl/bootstrap/less/opac.less M opac/opac-detail.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/less/opac.less CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/less/opac.less Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/css/opac.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 8995: Show OpenURL links in OPAC search results The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-Bug-8995-Show-OpenURL-links-in-OPAC-sea-AHeoX5.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 00:07:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 22:07:15 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #43 from Katrin Fischer --- There are some conflicts, due to recent changes in master (I suspect for the on-site quotas), please fix: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Using index info to reconstruct a base tree... M Koha/Schema/Result/Issuingrule.pm M admin/smart-rules.pl M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging admin/smart-rules.pl CONFLICT (content): Merge conflict in admin/smart-rules.pl Auto-merging Koha/Schema/Result/Issuingrule.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Issuingrule.pm Failed to merge in the changes. Patch failed at 0001 Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/SIGNED-OFF-patch-Bug-9129---Add-the-ability-to-set-G3gYvN.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 00:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 22:21:59 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #11 from David Cook --- (In reply to Nicole C. Engard from comment #10) > (In reply to David Cook from comment #9) > > Not very positive, because Keyword to Marc mapping only allows one mapping, > > when you theoretically might want to use 264 "or" 260 depending on which is > > available per record. > > But, we could enhance it to do what we need ... couldn't we? Just spit > balling ideas here. I'd be down with that. A while back, I was hard-coding something like that (checking to see if the record had a 264 and if not falling back to the 260), but got sidetracked by more important things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 00:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 22:51:15 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I don't know how out of date this is and I haven't been following the BIBFRAME listserv but according to the Library of Congress website: "BIBFRAME is far from an environment that you could move to yet. The model and its components are still in discussion and development -- a work in progress. When it is more mature, vendors and suppliers will need time to adjust services to accommodate it. And then we can expect a mixed environment for some time." http://www.loc.gov/bibframe/faqs/#q08 -- I see Zepheira working with LoC, SirsiDynix, and the NLM... but BIBFRAME still seems like a distant future kind of thing... even though libraries want it now because they're hearing it's the new hotness. Regarding that tool: "This XQuery version was developed by the Library of Congress Network Development and MARC Standards Office. This transformation is under development and does not at this time represent a canonical transformation of MARC Bib data to BIBFRAME resources. It is made available for evaluation and comment." https://github.com/lcnetdev/marc2bibframe I don't think XQuery will be very usable for us, but certainly something useful to watch. Might also be worth looking at https://github.com/lcnetdev/marc2bibframe-python although it doesn't look like it's been touched in years whereas the XQuery version was updated only 5 days ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 01:12:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 23:12:10 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 --- Comment #2 from David Cook --- It might be worthwhile to follow the following as well: http://www.loc.gov/bibframe/implementation/register.html It doesn't seem like it's reliably updated, but it provides some info... It looks like the National Library of Medicine and Zepheira have actually made a fork of BIBFRAME called BF Lite. Check out "June 12, 2015" from the below link. https://github.com/fallgrennj/BIBFRAME-NLM -- I fear that public perception of BIBFRAME will be similar to that of RDA. That people will want it without understanding what it is, because they don't want to be behind the curve. For my part, I think we should keep an eye on BIBFRAME, but we might be waiting a long time... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 01:12:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 18 Oct 2015 23:12:39 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #4 from Robin Sheat --- (In reply to Marcel de Rooy from comment #1) > What about /usr/share/koha_$instance_upload ? Writeable stuff under /usr/share is very non-standard. On larger unixy systems, it's not uncommon for that to be read-only. This is what /var is for. My suggestion would simply be /var/lib/koha/[instance]/uploads -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 03:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 01:20:41 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #180 from Robin Sheat --- (In reply to Jonathan Druart from comment #178) > At least it's what I am using, maybe it works under wheezy, I don't know! I forget the exact details, but there were some issues with wheezy. Additionally, when debugging, always add: Stderr to the block in koha-conf.xml, it will trace all the traffic between elasticsearch and Koha to stderr. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 03:36:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 01:36:40 +0000 Subject: [Koha-bugs] [Bug 15026] New: Staged authority records diff wrongly compares auth to biblios Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15026 Bug ID: 15026 Summary: Staged authority records diff wrongly compares auth to biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 03:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 01:51:49 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #181 from kohayu --- (In reply to Robin Sheat from comment #180) > (In reply to Jonathan Druart from comment #178) > > At least it's what I am using, maybe it works under wheezy, I don't know! > > I forget the exact details, but there were some issues with wheezy. > > Additionally, when debugging, always add: > > Stderr > > to the block in koha-conf.xml, it will trace all the traffic > between elasticsearch and Koha to stderr. Dear Robin, Jonbathan I change jessie, it can import marc data to koha successfully. I also find some es plugin to debug koha. https://github.com/lukas-vlcek/bigdesk https://github.com/mobz/elasticsearch-head https://github.com/karmi/elasticsearch-paramedic https://github.com/NLPchina/elasticsearch-sql/ opac http://i.imgur.com/orvED9C.png thanks a lot, BR, longshan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 04:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 02:21:23 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #93 from David Cook --- Any movement on this one? I'd be keen to see this one go in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 06:33:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 04:33:55 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #182 from Robin Sheat --- I've started writing some documentation on how the Elasticsearch stuff works internally here: http://wiki.koha-community.org/wiki/Elasticsearch/Implementation Right now it's just the high-level stuff, but I'll get finer detail on it soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 06:38:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 04:38:03 +0000 Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 --- Comment #55 from David Cook --- Upgrading a system now, so I'm looking at XSLT improvements, but I'm guessing problems I highlighted in the past are still problems... Might look at these again soon... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 07:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 05:38:56 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #12 from Katrin Fischer --- I think enhancing the Koha-to-MARC-Mappings would be better than using the Keyword-to-MARC-Mappings for some reasons: - the keyword system gets the data from the MARCXML record for display each time, so I suspect it to be slower than the Koha-to-MARC-mappings that get the information from the db and it might slow down Koha a bit more. - I'd like to keep the option to use a database column for things like the publication year when writing reports, as the XML functions also seem quite slow in comparison. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 07:43:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 05:43:01 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 --- Comment #22 from David Cook --- Just noticed some typos in the POD Checkout "stautshash" below. It should be "statushash" and it should have a comma after $statushash at the end. Probably worth fixing in the event of someone copying and pasting, but not really a bug... =head2 GetItemsForInventory ($itemlist, $iTotalRecords) = GetItemsForInventory( { minlocation => $minlocation, maxlocation => $maxlocation, location => $location, itemtype => $itemtype, ignoreissued => $ignoreissued, datelastseen => $datelastseen, branchcode => $branchcode, branch => $branch, offset => $offset, size => $size, stautshash => $statushash interface => $interface, } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 07:44:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 05:44:47 +0000 Subject: [Koha-bugs] [Bug 15027] New: Typo in GetItemsForInventory POD Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Bug ID: 15027 Summary: Typo in GetItemsForInventory POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Developer documentation Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Just noticed some typos in the POD Checkout "stautshash" below. It should be "statushash" and it should have a comma after $statushash at the end. Probably worth fixing in the event of someone copying and pasting, but not really a bug... =head2 GetItemsForInventory ($itemlist, $iTotalRecords) = GetItemsForInventory( { minlocation => $minlocation, maxlocation => $maxlocation, location => $location, itemtype => $itemtype, ignoreissued => $ignoreissued, datelastseen => $datelastseen, branchcode => $branchcode, branch => $branch, offset => $offset, size => $size, stautshash => $statushash interface => $interface, } ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 07:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 05:45:04 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14057 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 07:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 05:45:04 +0000 Subject: [Koha-bugs] [Bug 14057] Inventory is painfully slow In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14057 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15027 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 07:47:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 05:47:44 +0000 Subject: [Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #13 from David Cook --- (In reply to Katrin Fischer from comment #12) > I think enhancing the Koha-to-MARC-Mappings would be better than using the > Keyword-to-MARC-Mappings for some reasons: > - the keyword system gets the data from the MARCXML record for display each > time, so I suspect it to be slower than the Koha-to-MARC-mappings that get > the information from the db and it might slow down Koha a bit more. > - I'd like to keep the option to use a database column for things like the > publication year when writing reports, as the XML functions also seem quite > slow in comparison. Ahh, I misread Nicole's comment. I thought she was talking about enhancing Koha-to-MARC-Mapping. Yeah, no, I think Koha-to-MARC-Mapping is the way to go. I don't think it would make sense to use Keyword-to-MARC-Mappings. Especially since there are already so many places where we're using/need to use Koha-to-MARC-mapping... it makes sense to enhance the thing that we're already using. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 09:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 07:14:57 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #42 from Jonathan Druart --- Katrin, thanks for the follow-up. Yes of course it makes sense to remove the txt files! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 09:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 07:33:37 +0000 Subject: [Koha-bugs] [Bug 14562] [3.18.x] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 09:36:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 07:36:33 +0000 Subject: [Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |claire.hernandez at biblibre.c |ommunity.org |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 09:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 07:48:40 +0000 Subject: [Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:06:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:06:38 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #45 from Jonathan Druart --- Created attachment 43577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43577&action=edit Bug 14100: Fix 3 occurrences more - opac-suggestions.pl - opac-readingrecord.pl - opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:08:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:08:45 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #46 from Jonathan Druart --- (In reply to Katrin Fischer from comment #44) > Hi Jonathan, > > this looks very good by now - I am optimistic that this is the last list: > > Not working yet: > - opac-suggestions.pl > - opac-readingrecord.pl > - opac-reserve.pl > I think it would be really nice to cover the OPAC with the initial patch. Fixed. > - suggestion/suggestion.pl > Organize by itemtype - tab descriptions are not correct Not so easy, because of C4::Koha::GetSupportName I would prefer to fix it later, on top of bug 14828. > I think I have checked all files touched by this bug - at least I tried > really hard - everything else looked fine to me. Thanks a lot for QAing this! > Could go on a separate bug to be fixed later: > - Allow editing of entries, instead of having to delete and readd them It's possible! It's not obvious but... you can click on the table to edit the lang or the translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:08:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:08:53 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:29:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:29:06 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #7 from Jonathan Druart --- Created attachment 43578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43578&action=edit Bug 14722: rename the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:29:11 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #8 from Jonathan Druart --- Created attachment 43579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43579&action=edit Bug 14722: Add POD for some options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:29:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:29:14 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #9 from Jonathan Druart --- Created attachment 43580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43580&action=edit Bug 14722: CSV is only available for biblio records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:31:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:31:27 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > A few small things: > > 1) Could we rename the script from just export.pl to export_records.pl? I > think this would make it easier to spot and be in line with the > export_borrowers.pl script already in the same directory. Yes, agreed. Feel free to squash patches 2 and 3. > 2) Running the script without any argument exports all your bibliographic > records - this could create quite a big file for a bigger catalog. Could it > be better to display the help and have a -c switch for confirming or similar? It's the current behavior. If we want to change it, it should be done in another bug report I think. > 3) Some of the options have no documentation. For example: start_accession > and end_accession - is this the date_created from the record? I documented all the options in a new patch. > 4) Are csv and auths incompatible? It seems that > ./misc/export.pl --filename=koha2.mrc --format=csv --record-type=auths > Creates a file with bib data. Exactly, it does not work. I have added a safeguard in the script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:52:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:52:57 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37838|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 43581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43581&action=edit Bug 11678: Gather print notices: add --email parameter Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:53:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:53:05 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #12 from Julian Maurice --- Created attachment 43582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43582&action=edit Bug 11678: Improve documentation of new parameter Say --email is repeatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:53:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:53:16 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 10:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 08:54:08 +0000 Subject: [Koha-bugs] [Bug 14671] Allow correct translation of CAS authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14671 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #7 from Sophie MEYNIEUX --- Would it be possible to have it in 3.20 and 3.18 ? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:19:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:19:45 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:19:48 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41684|0 |1 is obsolete| | Attachment #41685|0 |1 is obsolete| | Attachment #43571|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart --- Created attachment 43583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43583&action=edit Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This patch is a _requirement_ to Bug #12771, and will be necessary once we start managing more than 3 levels of overdue notice TEST PLAN 1) Create or improve on overduerules data .1) Intranet -> tools -> overdue notices .2) Make sure to have data in first, second and third tabs .3) Make sure to have checked mixes of Email/Phone/Print/SMS (depending on availability) .4) Make sure to have different letters and delay on first/second/third tab for at least one category .5) Remember it all. 2) Apply patch 3) run installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl 4) run t/db_dependant/Overdues.t 5) Validate Overdue Notice page .1) validate data entered previously is still there .2) Add some more, save changes, validate In installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl - A new column and primary key, 'overduerules_id', is added to the table 'overduerules' - A new column referencing a foreign key, 'overduerules_id', is added to the table 'overduerules_transport_types' - The columns 'branchcode' and 'categorytype' are removed from the table 'overduerules_transport_types' - Data is migrated from the old tables to the new ones In installer/data/mysql/kohastructure.sql : - Table 'overduerules' - Added a primary key named 'overduerules_id' - Table 'overduerules_transport_types' - Added a foreign key named 'overduerules_id' - Dropped columns 'branchcode', 'categorycode' since we now have them referenced through 'overduerules_id' In tools/overduerules.pl - INSERT and DELETE queries on 'overduerules_transport_types' were changed to reflect the new schema In C4/Overdues.pm : - The SQL query of the function 'GetOverdueMessageTransportTypes' is changed to take into account the new design of 'overduerules_transport In t/db_dependent/Overdues.t : - The INSERT calls before the tests were changed to take into account the new design of 'overduerules' and 'overduerules_transport_types' Sponsored by : Halland County Library Signed-off-by: Jesse Maseto Signed-off-by: Martin Persson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:19:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:19:52 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #38 from Jonathan Druart --- Created attachment 43584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43584&action=edit Bug 13624 - Tidying the atomicupdate file and kohastructure.sql Signed-off-by: Martin Persson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:19:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:19:59 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #39 from Jonathan Druart --- Created attachment 43585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43585&action=edit Bug 13624 - renaming atomicupdate from .pl to .perl I have not tested this very thoroughly e.g. understood the SQL changes etc. since the patch has been signed off twice before. But it seems to me like this patch is OK. Applied, ran automatic tests and saved some values in the overduerules matrix/tabs OK. Signed-off-by: Eivin Giske Skaaren Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:44:27 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #89 from Jonathan Druart --- koha-tmpl/opac-tmpl/bootstrap/css/opac.css has been updated but koha-tmpl/opac-tmpl/bootstrap/less/opac.less Please provide the related change to this file too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:48:18 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #90 from Jonathan Druart --- Comment on attachment 43548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43548 Bug 13642 [ENH] Adding new features for Dublin Core metadata Review of attachment 43548: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13642&attachment=43548) ----------------------------------------------------------------- ::: debian/control @@ -86,4 @@ > libopenoffice-oodoc-perl, > libpdf-api2-perl, > libpdf-api2-simple-perl, > - libpdf-fromhtml-perl, Why did you remove it? It is used by Koha::Borrower::Discharge @@ -99,4 @@ > libtemplate-perl, > libtemplate-plugin-htmltotext-perl, > libtemplate-plugin-json-escape-perl, > - libtemplate-plugin-stash-perl, Same here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 11:49:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 09:49:39 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #91 from Jonathan Druart --- Comment on attachment 43548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43548 Bug 13642 [ENH] Adding new features for Dublin Core metadata Review of attachment 43548: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13642&attachment=43548) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +1999,5 @@ > + }); > + }); > + > + $(document).ready(function(){ > + $("#input-oai").click(function(){ This @@ +2008,5 @@ > + }); > + }); > + > + $(document).ready(function(){ > + $("#input-srw").click(function(){ and this could be merged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:19:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:19:27 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #92 from Jonathan Druart --- Comment on attachment 43548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43548 Bug 13642 [ENH] Adding new features for Dublin Core metadata Review of attachment 43548: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13642&attachment=43548) ----------------------------------------------------------------- ::: opac/opac-export.pl @@ +69,5 @@ > $format = 'bibtex'; > } > elsif ($format =~ /dc/) { > + SWITCH: > + for ($recommendation) { What are the possible values for this variable? /^simple-dc-rdf/ => why not /^simple-dc-rdf$/ ? I think this block could be better written with if-elsif blocks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:21:05 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #93 from Jonathan Druart --- In the generated file I get 158 Lasletté Stéphanie 070 I would be better to have the utf-8 characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:25:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:25:36 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #94 from Jonathan Druart --- When you click save > dublin core, "DC-RDF (Recommended)" is checked but the "Output options for RDF" block is not expanded. I think it should. On a UNIMARC install, there is not "dcterms:title" entry, is it normal? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:27:08 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #95 from Jonathan Druart --- Created attachment 43586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43586&action=edit Bug 13642: (qa follow-up) spelling + pod Fixes the 2 following errors: - spelling neccesary ==> necessary - *** ERROR: Spurious =cut command in file Koha/Crosswalk/DublinCore.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:32:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:32:45 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #9 from Jonathan Druart --- Barton, Actually I think you should reuse the C4::Items::DelItemCheck subroutine, which does exactly what you are doing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:46:50 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Jonathan Druart --- % prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. ok All tests successful. Files=1, Tests=22, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.90 cusr 0.02 csys = 1.96 CPU) Result: PASS % git bz apply 12803 Bug 12803 - Add ability to skip closed libraries when generating the holds queue 43511 - Bug 12803 - Add ability to skip closed libraries when generating the holds queue 43512 - Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12803 - Add ability to skip closed libraries when generating the holds queue Applying: Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes % qa -c 2 -v 2 testing 2 commit(s) (applied to 390233a 'Bug 14966: Table header broken at det') Processing files before patches |========================>| 4 / 4 (100.00%) Processing files after patches |========================>| 4 / 4 (100.00%) OK Koha/Calendar.pm OK critic OK forbidden patterns OK pod OK spelling OK valid FAIL t/db_dependent/HoldsQueue.t OK critic FAIL forbidden patterns forbidden pattern: trailing space char (line 322) OK pod OK spelling OK valid OK C4/HoldsQueue.pm OK critic OK forbidden patterns OK pod OK spelling OK valid FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs HoldsQueueSkipClosed is bad placed (see bug 10610) % prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 13/24 # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 327. # got: '1' # expected: '2' # Looks like you failed 1 test of 24. t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/24 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 24 Failed: 1) Failed test: 23 Non-zero exit status: 1 Files=1, Tests=24, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.76 cusr 0.06 csys = 1.86 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:47:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:47:31 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #29 from Jonathan Druart --- Comment on attachment 43511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43511 Bug 12803 - Add ability to skip closed libraries when generating the holds queue Review of attachment 43511: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12803&attachment=43511) ----------------------------------------------------------------- ::: C4/HoldsQueue.pm @@ +29,4 @@ > use C4::Circulation; > use C4::Members; > use C4::Biblio; > +use C4::Dates qw/format_date/; Don't use C4::Dates, we are going to kick it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 12:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 10:52:48 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- Marc, It looks like this code comes from includes/masthead.inc and/or includes/opac-bottom.inc. Could you confirm (I have not compared the diff line by line)? In this case, it's certainly the good time to refactor it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:02:35 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #39 from Jonathan Druart --- Comment on attachment 42597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42597 Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - Unit Test Review of attachment 42597: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7560&attachment=42597) ----------------------------------------------------------------- You are using 3 different ways to insert data in your tests: Test::Builder, Koha::Object->store and directly the INSERT statement. It would make sense to use Test::Builder for all of them. ::: t/db_dependent/Accounts.t @@ +291,4 @@ > } > }; > > +subtest "makepartialpayment() tests" => sub { Wrong c/p. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:03:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:03:47 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #40 from Jonathan Druart --- Comment on attachment 42595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42595 Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books Review of attachment 42595: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7560&attachment=42595) ----------------------------------------------------------------- ::: C4/SIP/ILS/Transaction/Renew.pm @@ +47,5 @@ > } > + > + unless ( C4::Overdues::GetTotalFines($borrower->{borrowernumber}) < C4::Context->preference('OPACFineNoRenewals') ) { > + $renewokay = 0; > + $renewerror = 'too_many_fines' I have not tested, but this certainly needs more changes. Looking at the code, there is a $renewerror=~s/too_many/Item has reached maximum renewals/; few lines after. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:03:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:03:55 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:15:53 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #41 from Kyle M Hall --- Created attachment 43587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43587&action=edit Bug 7560 [QA Followup] - Fix up unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:18:17 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:36:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:36:16 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Kyle, I don't have any idea what is a AV field, so it's a bit difficult to test this patch. Could you please detail the step 8 8) Note your custom AV field is being used! What am I supposed to see where? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:37:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:37:48 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #33 from Jonathan Druart --- (In reply to Kyle M Hall from comment #32) > > In the test plan step 9 it talks of 4th character but should be 3rd as in > > step 3 > > Sorry about that! I will revise the test plan. Setting the status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:47:39 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 43588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43588&action=edit Bug 13409 - Add ability to purge old special holidays using cleanup_database.pl v2 We are having a massive amount of special holidays in the calendar and those are cluttering the calendar views. A simple solution is to remove stale special holidays from the koha.special_holidays-table. Test Plan: 1) Create some special holidays in the past 2) Use the new --calendar DAYS option to test deleting special holidays 3) Verify only special holidays past the given amount of days were deleted P.S. No test included! Do not push without proper integration tests, preferably with Cucumber + PageObject and some kind of a cronjob-runner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 13:50:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 11:50:40 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Status|In Discussion |Failed QA --- Comment #5 from Olli-Antti Kivilahti --- Hi there! I accidentally implemented this simple fix and found Kyle's patch later. Sharing my solution regardless. My solution actually could be tested if somebody decided to write tests for it. Not implementing this with DBIx because it is very counterproductive and I don't feel like spending a day doing an 2-hour job. Failed QA for both commits due to a lack of tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 14:55:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 12:55:26 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43513|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 43589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43589&action=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:05:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:05:04 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42081|0 |1 is obsolete| | Attachment #42082|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 43590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43590&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:05:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:05:12 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #35 from Kyle M Hall --- Created attachment 43591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43591&action=edit Bug 13411 [QA Followup] - Add logging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:05:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:05:26 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:05:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:05:33 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:10:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:10:09 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #5 from Kyle M Hall --- The AV field is for SIP2 fine items. There should be an AV field returned for each fee/fine in Koha. The specification doesn't actually specify what each AV field should look like, and different SIP2 devices expect different data, which is why I've made the contents of the field configurable. You should expect to see the AV fields in the SIP2 response for your Patron Information request ( assuming you pass in the flag requesting the fee items ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:14:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:14:35 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |kyle.m.hall at gmail.com --- Comment #30 from Kyle M Hall --- > Don't use C4::Dates, we are going to kick it out. Can you please point me to the method I should be using? I don't see a replacement in Koha::Calendar! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:15:53 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #27 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! We need to fill an enhancement bug for letting Koha stand in whatever endpoint we want instead of the legacy URI path. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:23:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:23:51 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:23:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:23:55 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43298|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 43592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43592&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:26:56 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #747 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 14825 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:26:56 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #2 from Kyle M Hall --- *** Bug 6427 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:26:59 +0000 Subject: [Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Bug 10021 depends on bug 6427, which changed state. Bug 6427 Summary: Rewrite of the accounts system http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:26:59 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Bug 11887 depends on bug 6427, which changed state. Bug 6427 Summary: Rewrite of the accounts system http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:26:59 +0000 Subject: [Koha-bugs] [Bug 14373] Disallow payment of accruing fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373 Bug 14373 depends on bug 6427, which changed state. Bug 6427 Summary: Rewrite of the accounts system http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:29:43 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 --- Comment #1 from M. Tompsett --- Created attachment 43593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43593&action=edit Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:29:41 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:36:59 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Attachment #43588|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:37:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:37:45 +0000 Subject: [Koha-bugs] [Bug 15028] New: Jenkins is unhappy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Bug ID: 15028 Summary: Jenkins is unhappy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The 3.22 release is coming and Jenkins is not happy at all (http://jenkins.koha-community.org/). All tests should pass before the release! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:38:47 +0000 Subject: [Koha-bugs] [Bug 15028] Jenkins is unhappy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 --- Comment #1 from Jonathan Druart --- This is obviously caused because our test suite is dependent of the data of a given DB (see bug 10273). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:41:13 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Kyle M Hall --- Thanks Olli! I do like your version ( except for the odd default value ; ). However it does break from the standard way of doing things in cleanup_database. That being said, if you *were* to add a unit test I'd say that would be a worthwhile improvement and I'd be more than happy to deprecate my version and sign off on yours! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:41:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:41:27 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:41:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:41:50 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #31 from Jonathan Druart --- (In reply to Kyle M Hall from comment #30) > > Don't use C4::Dates, we are going to kick it out. > > Can you please point me to the method I should be using? I don't see a > replacement in Koha::Calendar! I was talking about C4::Dates, you should use Koha::DateUtils instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:44:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:44:22 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #14 from Kyle M Hall --- (In reply to Katrin Fischer from comment #11) > Same here about 4-8. New sequence looks good to me, but is there a reason we > don't display all reasons why a hold can not be placed? Basically, it causes confusion for librarians. For example, iirc, a patron may not be able to place holds on any of the items, and thus the librarian receives the "too many holds" error which is not actually true. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:44:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:44:27 +0000 Subject: [Koha-bugs] [Bug 15028] Jenkins is unhappy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:44:30 +0000 Subject: [Koha-bugs] [Bug 15028] Jenkins is unhappy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 --- Comment #2 from Jonathan Druart --- Created attachment 43594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43594&action=edit Bug 15028: tests - force the numbering pattern to 'No. {X}' On some jenkins DB, this pattern is "No.{X}" instead of "No. {X}" and the test fails ("Serial notification text constructed successfully"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:46:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:46:30 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #43 from Tom?s Cohen Arazi --- Long-standing missing feature, good job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:46:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:46:55 +0000 Subject: [Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:47:51 +0000 Subject: [Koha-bugs] [Bug 14617] Add indexes for MARC 020$z => ISBN, 022$y, 022$z => ISSN In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14617 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Barton! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:48:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:48:16 +0000 Subject: [Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:51:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:51:14 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Summary|Jenkins is unhappy |t/db_dependent/Letters.t | |should set the numbering | |pattern it needs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 15:59:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 13:59:19 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:13:22 +0000 Subject: [Koha-bugs] [Bug 4437] acq.js uses XMLHttpRequest() directly; should use jQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4437 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:18:35 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:19:48 +0000 Subject: [Koha-bugs] [Bug 2499] Improvement on text wrapping algorithm needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:22:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:22:26 +0000 Subject: [Koha-bugs] [Bug 2601] Order fines by date and time In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- How can this be Failed QA if the patch is obsoleted? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:24:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:24:27 +0000 Subject: [Koha-bugs] [Bug 2946] Lost items (that are hidden in Normal View) still show up in the MARC View in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2946 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Though bug 10589 and 10895 are in need of a serious re-write, I wonder if they would solve this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:36:59 +0000 Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success in anonymous patron not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756 --- Comment #14 from Jonathan Druart --- Liz, This has been backported to 3.18, but the tests use the t::lib::TestBuilder lib which has been introduced by bug 12603, not in 3.18 yet. 04:05:47 Can't locate t/lib/TestBuilder.pm in @INC (you may need to install the t::lib::TestBuilder module) (@INC contains: /srv/jenkins/workspace/Koha_3.18.x_U14/blib/arch /srv/jenkins/workspace/Koha_3.18.x_U14/blib/lib /srv/jenkins/workspace/Koha_3.18.x_U14 /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at t/db_dependent/Circulation/AnonymiseIssueHistory.t line 7. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:45:04 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:45:06 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43594|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 43595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43595&action=edit Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs On some jenkins DBs, this pattern is "No.{X}" instead of "No. {X}" and the test fails ("Serial notification text constructed successfully"). Tests should always create their own data. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:45:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:45:10 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #5 from Fridolin SOMERS --- (In reply to Charles Farmer from comment #4) > Hi Fridolin, > > Could you take a look at Bug 12769? Nope, thanks for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:50:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:50:49 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:50:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:50:51 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 --- Comment #4 from Kyle M Hall --- Created attachment 43596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43596&action=edit [PASSED QA] Bug 15028: Make t/db_dependent/Letters.t set the numbering pattern it needs On some jenkins DBs, this pattern is "No.{X}" instead of "No. {X}" and the test fails ("Serial notification text constructed successfully"). Tests should always create their own data. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:51:09 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Attachment #43595|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:52:35 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:54:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:54:20 +0000 Subject: [Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #25 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:55:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:55:22 +0000 Subject: [Koha-bugs] [Bug 14916] Overdues are not listed if due on 23:59 of the 'to date' (Was: Remove C4::Dates from circ/overdue.pl) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:55:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:55:47 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:56:08 +0000 Subject: [Koha-bugs] [Bug 15028] t/db_dependent/Letters.t should set the numbering pattern it needs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15028 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 16:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 14:56:30 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #27 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:10:51 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Tom Misilo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot at fit.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:12:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:12:13 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #32 from Charles Farmer --- (In reply to Jonathan Druart from comment #31) > You can try and contact the authors of these patches and work all together > to find a solution that please everybody. The collaborative approach is not bearing any fruits, I'm afraid. Bug 14666's assignee is uninterested in looking elsewhere for his needs. Compared to the other patches I've seen for this feature, this one allows a fine to be added to any kind of notice, including overdue notices. Adding a fee solely to overdue notices feels rather incomplete in comparison. (In reply to Jonathan Druart from comment #27) > My concern is that the field will be display for all notices but will only > be take into account in few cases. Yes, the added flexibility means we would see the fee box appear every time. I don't know enough about Koha's UX to really give you an alternative, but perhaps you have an idea on how we could answer your concern? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:17:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:17:24 +0000 Subject: [Koha-bugs] [Bug 15029] New: Tests fail if launched after 23:00 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Bug ID: 15029 Summary: Tests fail if launched after 23:00 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org % sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t Mon 19 Oct 23:50:00 BST 2015 t/db_dependent/Members/IssueSlip.t .. # Child (Hourly loans) exited without calling finalize() # Failed test 'Hourly loans' # at /home/koha/perl5/lib/perl5/Test/Builder.pm line 276. The 'hour' parameter ("24") to DateTime::set did not pass the 'an integer between 0 and 23' callback at /usr/lib/i386-linux-gnu/perl5/5.20/DateTime.pm line 1944. DateTime::set(undef, "hour", 24) called at t/db_dependent/Members/IssueSlip.t line 200 main::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 258 Test::Builder::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 eval {...} called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 Test::Builder::subtest(Test::Builder=HASH(0x9dd4818), "Hourly loans", CODE(0xd30bc20)) called at /home/koha/perl5/lib/perl5/Test/More.pm line 770 Test::More::subtest("Hourly loans", CODE(0xd30bc20)) called at t/db_dependent/Members/IssueSlip.t line 259 main::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 258 Test::Builder::__ANON__() called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 eval {...} called at /home/koha/perl5/lib/perl5/Test/Builder.pm line 263 Test::Builder::subtest(Test::Builder=HASH(0x9dd4818), "Issue slip", CODE(0xd13eb1c)) called at /home/koha/perl5/lib/perl5/Test/More.pm line 770 Test::More::subtest("Issue slip", CODE(0xd13eb1c)) called at t/db_dependent/Members/IssueSlip.t line 261 # Child (Issue slip) exited without calling finalize() t/db_dependent/Members/IssueSlip.t .. 1/3 # Failed test 'Issue slip' # at /home/koha/perl5/lib/perl5/Test/Builder.pm line 276. # Looks like you planned 3 tests but ran 1. # Looks like you failed 1 test of 1 run. # Looks like your test exited with 29 just after 1. t/db_dependent/Members/IssueSlip.t .. Dubious, test returned 29 (wstat 7424, 0x1d00) Failed 3/3 subtests Test Summary Report ------------------- t/db_dependent/Members/IssueSlip.t (Wstat: 7424 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 29 Parse errors: Bad plan. You planned 3 tests but ran 1. Files=1, Tests=1, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.60 cusr 0.04 csys = 1.66 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:19:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:19:39 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 --- Comment #1 from Jonathan Druart --- Created attachment 43597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43597&action=edit Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:19:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:19:36 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:20:35 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |liz at catalyst.net.nz, | |tomascohen at gmail.com --- Comment #2 from Jonathan Druart --- Ccing RM & RMaints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:34:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:34:54 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:34:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:34:57 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43589|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 43598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43598&action=edit [SIGNED-OFF] Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:45:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:45:47 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #44 from Tom?s Cohen Arazi --- Created attachment 43599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43599&action=edit Bug 13632: (QA followup) remove xt/permissions.t There's no longer a need for this tests, as their goal was to make sure en (the basis) was in sync with the translated files. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:46:33 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #6 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #5) > (In reply to Charles Farmer from comment #4) > > Hi Fridolin, > > > > Could you take a look at Bug 12769? > Nope, thanks for this Sorry I thought you said "Did you have a look at Bug 12769?" :D So my real answer : Yes, I'll have a look when I can find time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:52:14 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #33 from Charles Farmer --- (In reply to Charles Farmer from comment #32) > Bug 14666's assignee is uninterested in looking elsewhere for his needs. Scratch that, there was a misunderstanding in the other thread :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:54:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:54:38 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 --- Comment #7 from Charles Farmer --- (In reply to Fridolin SOMERS from comment #6) Thank you for clearing this up ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:54:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:54:53 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 17:55:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 15:55:22 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #99 from Tom?s Cohen Arazi --- Patches pushed to master. Great job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:03:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:03:06 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:03:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:03:10 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43160|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 43600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43600&action=edit [SIGNED-OFF] Bug 11565 - decreaseLoanHighHolds needs Override This patch allows the high holds loan length decrease to be overridden either by a checkbox that remembers its setting during a series of checkouts, or by a one time use override checkbox that will show in the warning popup if a checkout is affected by high holds. Test Plan: 1) Set up a checkout that will be affected by decreaseLoanHighHolds 2) Attempt to check out an item 3) Check the override checkbox 4) Note the checkout date is not reduced 5) Return the item 6) Start a new checkout for the patron 7) Check the "Don't decrease lean length based on holds" checkbox 8) Check out the item 9) Note you are not warned about the high holds decrease and that the checkout length is not reduced Signed-off-by: Kyle M Hall Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:10:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:10:25 +0000 Subject: [Koha-bugs] [Bug 4158] cannot create list whose title is '0' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Failed QA |Patch doesn't apply --- Comment #4 from M. Tompsett --- Prog theme no longer exists. This would need a rewrite. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:15:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:15:11 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Failed QA |Patch doesn't apply --- Comment #3 from M. Tompsett --- Prog theme no longer exists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:15:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:15:29 +0000 Subject: [Koha-bugs] [Bug 15030] New: Certain values in serials' items are lost on next edit Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Bug ID: 15030 Summary: Certain values in serials' items are lost on next edit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: philippe.blouin at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:17:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:17:50 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #1 from Blou --- Created attachment 43601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43601&action=edit Bug 15030 - Certain values in serials' items are lost on next edit When editing serials subscription, we can edit them but some values are not pulled from the DB correctly to be put in the edit box. If not noticed, the value will be overwritten on the next save. Test: - Create a subscription - Edit itemcallnumber (952o?) and make sure to have a different value than the default one. - Save. - Edit it again - The saved value is not there. This is true for itemcallnumber and a few other fields. This was caused by calls to ->field($subfield). This would always fail, of course. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:19:18 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |philippe.blouin at inlibro.com |ity.org | CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:35:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:35:22 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #96 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #94) > When you click save > dublin core, "DC-RDF (Recommended)" is checked but the > "Output options for RDF" block is not expanded. I think it should. > > On a UNIMARC install, there is not "dcterms:title" entry, is it normal? I Jonathan The problem is that MARC::Crosswalk::DublinCore map only MARC21 fields. This is because the autor of package follows the crosswalk from LC at , i.e., title statement is saved in different fields (MARC 21 in 245 and UNIMARC in 200). Let me do a crosswalk for UNIMARC in another bug. This new bug must consider the MARC flauvor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:37:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:37:12 +0000 Subject: [Koha-bugs] [Bug 13976] Sorting search results by popularity is alphabetical In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13976 --- Comment #3 from Fridolin SOMERS --- (In reply to M. Tompsett from comment #2) > http://www.indexdata.com/yaz/doc/zoom.resultsets.html#zoom.z3950.resultset. > sort > > http://www.indexdata.com/yaz/doc/yaz-client.html#sortspec > > Hmmm... There is a problem, isn't there? :) What do you mean ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:52:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:52:13 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #47 from Katrin Fischer --- Created attachment 43602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43602&action=edit [PASSED QA] Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:52:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:52:57 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #48 from Katrin Fischer --- Created attachment 43603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43603&action=edit [PASSED QA] Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: > admin/smart-rules.pl > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl Signed-off-by: Josef Moravec Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:53:50 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #49 from Katrin Fischer --- Created attachment 43604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43604&action=edit [PASSED QA] Bug 14100: Better errors handling This patch mainly improves the errors handling. It's now not possible to add several translations for the same entity-code-lang combination. It also: - wording: Translate for other languages => into - fixes encoding issues on add/update (was just display) - add entity and code to the title of the pop-up window Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 18:55:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 16:55:01 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #50 from Katrin Fischer --- Created attachment 43605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43605&action=edit [PASSED QA] Bug 14100: Move add form to the top Not sure this is the best: now the messages will make the table moves. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 19:01:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 17:01:26 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #51 from Katrin Fischer --- Created attachment 43606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43606&action=edit [PASSED QA] Bug 14100: Fix some missing occurrences This patch fixes: - reports/bor_issues_top.pl - sort order - adv search and search results - opac-topissues.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 19:23:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 17:23:51 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 19:23:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 17:23:54 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43398|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 43607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43607&action=edit [SIGNED-OFF] Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). Test Plan: 1) Create a patron with one or more restrictions 2) Import a CSV file that updates that patron, but with no debarred columns 3) Note a new restrictions is created 4) Delete the new restriction 5) Apply this patch 6) Re-import the CSV file again 7) Note that no new restriction is created 8) Add debarred and debarredcomment columns to the CSV file with a test date and description 9) Re-import the CSV file again 10) Note the new restriction is added to the patron Signed-off-by: Kyle M Hall Signed-off-by: Daniel Grobani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 19:51:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 17:51:53 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com Keywords| |rel_3_22_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 19:54:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 17:54:10 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #94 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Lyon3 team! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 19:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 17:54:35 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 20:26:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 18:26:56 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 20:26:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 18:26:59 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34177|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 43608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43608&action=edit Bug 13409 - Add ability to purge old special holidays using cleanup_database.pl Some libraries have expressed interested in being able to purge old holidays from the database. Test Plan: 1) Create some special holidays in the past 2) Use the new --holidays DAYS option to test deleting special holidays 3) Verify only special holidays past the given amount of days were deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 20:27:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 18:27:05 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #8 from Kyle M Hall --- Created attachment 43609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43609&action=edit Bug 13409 [QA Followup] - Remove MySQLism -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 20:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 18:29:41 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #32 from Kyle M Hall --- (In reply to Jonathan Druart from comment #31) > (In reply to Kyle M Hall from comment #30) > > > Don't use C4::Dates, we are going to kick it out. > > > > Can you please point me to the method I should be using? I don't see a > > replacement in Koha::Calendar! > > I was talking about C4::Dates, you should use Koha::DateUtils instead. Ah, I see now. I was looking at the wrong code! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 20:32:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 18:32:35 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #33 from Kyle M Hall --- Created attachment 43610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43610&action=edit Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 20:55:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 18:55:27 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 --- Comment #10 from M. Tompsett --- Created attachment 43611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43611&action=edit Bug 4226: Follow to address comment #9 It would be appreciated if testing of this script was redone to confirm if all the points were handled properly. The only point truly outstanding still is 6. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:28:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:28:47 +0000 Subject: [Koha-bugs] [Bug 15031] New: PLACK looping installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15031 Bug ID: 15031 Summary: PLACK looping installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: nick at quecheelibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Running the Ansible-kohadev with plack Did a git pull. Was able to keep testing for a while, then was kicked into installer (after closing an invoice) Installer kept looping me back through, never performing update. Disabled plack and update went through. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:29:03 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15031 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:29:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:29:03 +0000 Subject: [Koha-bugs] [Bug 15031] PLACK looping installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15031 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15019 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:38:28 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15032 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:38:28 +0000 Subject: [Koha-bugs] [Bug 15032] New: Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Bug ID: 15032 Summary: Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org Blocks: 15019 After the fixes for 15005, I retried importing a record batch. I didn't get the error pop up message, but this time I get the message "Internal Server Error" for this page: http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/tools/stage-marc-import.pl However, when I go directly to the Manage Staged Records page, I see my staged batch. To recreate: 1) Go to Tools --> Stage MARC records for import. 2) Upload file and click Import. I left all the settings on default ones. 3) Click Stage for Import. 4) Note the "Internal Server Error" message. 5) Click the back button and click on the Managed Staged Records link in the side bar. 6) Note the presence of the file you just uploaded. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:38:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:38:34 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #1 from Heather Braum --- A second file I just staged for import, stalled on 24% Job Progress on the screen, but when I manually go to the Managed Staged Records link, my second batch is there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:53:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:53:27 +0000 Subject: [Koha-bugs] [Bug 15033] New: Plack testing -- Search results link problems Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15033 Bug ID: 15033 Summary: Plack testing -- Search results link problems Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org Blocks: 15019 When I perform this search: http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/catalogue/search.pl?q=harry+potter the following problems happen: 1) In the results, clicking on the Holds/Edit Biblio/Edit Items links returns an Internal Server Error Message. (not expected behavior, even if the record doesn't exist; should return page that says the record doesn't exist) 2) Clicking on the Record link, returns a page that says the record doesn't exist. (expected behavior if the record doesn't exist) 3) Clicking on a call number link in the Location column returns a page that says the record doesn't exist. (Expected behavior if the record doesn't exist) Has reindexing been turned back on for the Plack server after the issues over the weekend? Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:53:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:53:27 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15033 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15033 [Bug 15033] Plack testing -- Search results link problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:58:07 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15034 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15034 [Bug 15034] Plack testing -- Importing a staged record batch returns the Koha web installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 21:58:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 19:58:07 +0000 Subject: [Koha-bugs] [Bug 15034] New: Plack testing -- Importing a staged record batch returns the Koha web installer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15034 Bug ID: 15034 Summary: Plack testing -- Importing a staged record batch returns the Koha web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org Blocks: 15019 Importing a staged record batch is returning the Koha web installer option. To recreate: 1) Go to Tools --> Manage Staged Records. 2) Choose a batch. 3) Click on Import this batch into the catalog. 4) Note the Welcome to the Koha web installer message that appears. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:06:43 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #7 from Marc V?ron --- Jonathan, Good idea. Are you thinking about an extra include for the language menue that would be inserted into koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc and koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead-sco.inc ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:25:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:25:38 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #14 from Marc V?ron --- (In reply to Gaetan Boisson from comment #13) (...) > - make sure multiple languages are properly managed. This is trickier. If I > build my menu in opacnav for instance, i will not be able to build a > different menu, with different page ids, for different languages. So > choosing OPAC (fr-FR) as the display location is not quite enough, because > equivalent pages in each language will end up with different ids. Gaetan, I think the translation handling could be based on or similar to Bug 14100 - Generic solution for language overlay -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:25:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:25:41 +0000 Subject: [Koha-bugs] [Bug 15033] Plack testing -- Search results link problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15033 --- Comment #1 from Heather Braum --- Nope reindexing is turned on -- but maybe the reindexes need to be rebuilt? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:33:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:33:19 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:33:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:33:19 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14060 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:48:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:48:25 +0000 Subject: [Koha-bugs] [Bug 14562] [3.18.x] Patron with empty card number will be only result returned by patron datatables search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #8 from Liz Rea --- Pushed to 3.18.x will be in 3.18.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:49:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:49:50 +0000 Subject: [Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success in anonymous patron not defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756 --- Comment #15 from Liz Rea --- Ah thanks I'll pull out the tests I suppose. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 22:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 20:57:13 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #97 from H?ctor Eduardo Castro Avalos --- Created attachment 43612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43612&action=edit Bug 13642: (following qa) Fixing according with QA comments Fixes the following: -Add css to less.css -Add missing libraries in debian/control (libpdf-fromhtml-perl, libtemplate-plugin-stash-perl) -Merge ids in JQuery -Delete switch statements and correcting regex -Change to utf-8 characteres without entities -Expand RDF block to "DC-RDF (Recommended)" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:12:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:12:43 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #98 from H?ctor Eduardo Castro Avalos --- Hi Jonathan I think the UNIMARC can be corrected of various forms. For example with XSLT Transformation, C4/Breeding.pm use something like that (C4::Breeding->_do_xslt_proc) and the xslt to transform UNIMARC2MARC21 is here Although exist this module . C4::Record->marc2marc deal with marc flavour, but it seems to be that it does not work or is not fully developed. So my question is: Can I fix it in another bug or I need to fix it in this one? Thanks Jonathan Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:39:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:39:42 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #52 from Katrin Fischer --- Created attachment 43613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43613&action=edit [PASSED QA] Bug 14100: Fix 3 occurrences more - opac-suggestions.pl - opac-readingrecord.pl - opac-reserve.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:17 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:19 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:22 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:24 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43396|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:29 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43111|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:26 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43110|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:40:35 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43577|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:41:24 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 19 23:59:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 21:59:53 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #10 from Barton Chittenden --- (In reply to Jonathan Druart from comment #9) > Barton, > Actually I think you should reuse the C4::Items::DelItemCheck subroutine, > which does exactly what you are doing. Jonathan, C4::Items::DelItemCheck doesn't have any kind of 'commit' check... I'm torn, because I would *like* to use it to avoid duplication of code (plus there are a number of cases that it covers that I don't), but I don't want to sacrifice the ability to accurately report what's going to happen if I run the script in verbose mode without '--commit'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:05:35 +0000 Subject: [Koha-bugs] [Bug 4268] Incorrect check of OPACItemsResultsDisplay preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4268 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #11 from M. Tompsett --- Two years later and no follow up. As far as I can tell with the current state of things, the obsoleted patch seems to have been the cause of things discussed in comments 1 through 8 and leading up to jcamin's confusion in comment #9, but that obsolete patch is not in master. And the proposed fix was addressed in Bug 5409 as noted in comment #10. Given this inactivity, I am marking this resolved duplicate. *** This bug has been marked as a duplicate of bug 5409 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:05:35 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #20 from M. Tompsett --- *** Bug 4268 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:05:36 +0000 Subject: [Koha-bugs] [Bug 1348] Call number does not display in 'Call Number' column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1348 Bug 1348 depends on bug 4268, which changed state. Bug 4268 Summary: Incorrect check of OPACItemsResultsDisplay preference http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4268 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:09:10 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Failed QA |Patch doesn't apply --- Comment #13 from M. Tompsett --- Not only is this failed QA, but a full rewrite is needed to deal with with deprecation of the prog theme. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:28:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:28:36 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #11 from Barton Chittenden --- (In reply to Barton Chittenden from comment #10) > (In reply to Jonathan Druart from comment #9) > > Barton, > > Actually I think you should reuse the C4::Items::DelItemCheck subroutine, > > which does exactly what you are doing. > > Jonathan, > > C4::Items::DelItemCheck doesn't have any kind of 'commit' check... I'm torn, > because I would *like* to use it to avoid duplication of code (plus there > are a number of cases that it covers that I don't), but I don't want to > sacrifice the ability to accurately report what's going to happen if I run > the script in verbose mode without '--commit'. Jonathan, Jesse Weaver (pianohacker) and I discussed this: 18:15 <@pianohacker> barton: I'd suggest to Joubu to either add a 'check_only' kind of parameter to DelItemCheck or move the check logic into a completely different function like ItemSafeToDelete (with a slight personal preference for the latter) 18:18 < barton> cleanest would probably be both -- write ItemSafeToDelete, then have DelItemCheck be a wrapper around DelItem which uses ItemSafeToDelete as its test. 18:18 <@pianohacker> yeah, definitely So I'd like to open a separate bug to * add C4::Items::ItemSafeToDelete() * add a 'do-not-commit' option to DelItemCheck (omitting the flag would make it work as usual) * Use C4::Items::ItemSafeToDelete to do the internal checking for DelItemCheck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:52:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:52:15 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #11 from M. Tompsett --- Can someone clarify the point of this bug? I'm not sure I understand, and it has been sitting Failed QA for nearly 3 years. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:55:42 +0000 Subject: [Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan.sieira at xercode.es --- Comment #113 from M. Tompsett --- *** Bug 6146 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 00:55:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 22:55:42 +0000 Subject: [Koha-bugs] [Bug 6146] In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #6 from M. Tompsett --- It's been a year without comment, and I believe that bug 5010 which has been integrated to master dealt with this. I am marking this resolved duplicate instead of Failed QA. *** This bug has been marked as a duplicate of bug 5010 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:45:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:45:37 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 --- Comment #27 from Mason James --- Hmm, I think I've found a small bug here, patch coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:01 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:06 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40811|0 |1 is obsolete| | --- Comment #146 from Jesse Weaver --- Created attachment 43614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43614&action=edit Bug 11559: Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib Test plan: 1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage works as expected, despite the change to pass on the fragment (...#blah) from the URL. 2. C4/Service.pm and humanmsg.js: verify that editing system preferences (the main user of these modules) works correctly despite updates. 3. svc/bib: verify that records can be correctly downloaded with the change of character set. This can be done in a Firebug/Chrome Devtools console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the results (possibly replacing 1 with a different valid biblionumber). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:12 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40812|0 |1 is obsolete| | --- Comment #147 from Jesse Weaver --- Created attachment 43615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43615&action=edit Bug 11559: New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * require - dependency resolver and module loader -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:19 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40813|0 |1 is obsolete| | --- Comment #148 from Jesse Weaver --- Created attachment 43616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43616&action=edit Bug 11559: Rancor: advanced cataloging interface Full test plan is posted on bug. Test plan for system preference: 1. Apply patch, clear cookies. 2. Go to "Cataloging." 3. Add new record, verify that basic editor is used. 4. Navigate to existing record, click on "Edit record", verify that basic editor is used. 5. Inside basic editor, verify that no button appears to switch to the advanced editor. 6. Enable the "EnableAdvancedCatalogingEditor" syspref. 7. Repeat above steps, should still go to basic editor, but button should appear to switch to the advanced editor; click it. 8. Now, adding new records and editing existing records should go to the advanced editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:27 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40814|0 |1 is obsolete| | --- Comment #149 from Jesse Weaver --- Created attachment 43617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43617&action=edit Bug 11559: (followup) Fix keyboard control bugs, make labels clickable This fixes the following issues: * Labels of search server checkboxes cannot be clicked * Quick search fields cannot be focused * Search results cannot be scrolled with a keyboard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:33 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40815|0 |1 is obsolete| | --- Comment #150 from Jesse Weaver --- Created attachment 43618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43618&action=edit Bug 11559: (followup) Fill in default values, fix redirect and UNIMARC This fixes the following issues: * Help for UNIMARC tags broken * MARC21 resources loaded when in UNIMARC * Clicking on "advanced editor" in basic editor fails * Shift-Tab goes to the beginning of a fixed-field widget rather than the end -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:40 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41425|0 |1 is obsolete| | --- Comment #151 from Jesse Weaver --- Created attachment 43619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43619&action=edit Bug 11559: (followup) Fix import bugs, display/parsing issues This fixes the following issues: * ISO2709 import fails for Unicode * Import only works with .mrc/.xml extensions * MARC21 widgets not translatable * Macro UI broken * Uppercase subfield codes forbidden * Tag with no valid subfields shows as error but tries to save -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:50 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41476|0 |1 is obsolete| | --- Comment #152 from Jesse Weaver --- Created attachment 43620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43620&action=edit Bug 11559: (followup) Fix error when all servers are deselected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:49:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:49:57 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42373|0 |1 is obsolete| | --- Comment #153 from Jesse Weaver --- Created attachment 43621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43621&action=edit Bug 11559: (followup) Prevent saving item tags, fix other issues This fixes the following issues: * Spaces are now allowed in indicators * Shift-Enter is available to insert a newline if needed * Item tags, if present, will prevent saving (as they are not correctly processed by the backend) * biblionumber tags (999 in MARC21) will be stripped before the record is saved to Koha, to prevent their modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:50:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:50:03 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43547|0 |1 is obsolete| | --- Comment #154 from Jesse Weaver --- Created attachment 43622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43622&action=edit Bug 11559: (QA followup) switch to new delimiter, fix minor issues This followup introduces a major change; instead of subfields starting with '$', they now start with '?'. The double-cross character can be typed with Ctrl-D. It also fixes the following: * Add UUID.pm dependency * Remove debugging call * Fix toLocaleFormat error reported by Nick Clemens * Ignore subfields that are marked as unrepeatable/mandatory AND ignored (tab is -1) * Mention lack of support for UNIMARC/NORMARC fixed fields in system preferences screen * Confirm when user creates new record and current record is modified * Perform better when importing gigantic record dump * Show "Edit" instead of "Import" and allow direct editing for local catalog records in search screen * Add "Keyboard shortcuts" help button to toolbar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:50:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:50:14 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #155 from Jesse Weaver --- Created attachment 43623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43623&action=edit Bug 11559: (followup) fix first-character deletion, small usability issues This should fix the first-character deletion bug reported by Nick, and also: * Fix subfield deletion * Attempted fix for special keys on dropdowns * Allow deleting empty fields * Fix bug with composed characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:54:35 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15035 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 01:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 19 Oct 2015 23:54:57 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 --- Comment #45 from David Cook --- Thanks Jonathan! I've been so busy this year, so I'm really glad that you kept going with this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:43:02 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #26 from Tom?s Cohen Arazi --- FTR: http://lists.scsys.co.uk/pipermail/dbix-class/2006-June/001690.html Also, this patches fixed the "MySQL server has gone away" problem in the test server. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:46:00 +0000 Subject: [Koha-bugs] [Bug 15033] Plack testing -- Search results link problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15033 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- This bug is invalid. This is a side effect of a problem with MySQL connections being lost, and reindexing this failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:46:00 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15033, which changed state. Bug 15033 Summary: Plack testing -- Search results link problems http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15033 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:47:39 +0000 Subject: [Koha-bugs] [Bug 15034] Plack testing -- Importing a staged record batch returns the Koha web installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15034 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- This is due to a problem with the DB handler. It is fixed by bug 14778. *** This bug has been marked as a duplicate of bug 14778 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:47:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:47:39 +0000 Subject: [Koha-bugs] [Bug 14778] Get rid of DBIx::Connector In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #27 from Tom?s Cohen Arazi --- *** Bug 15034 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:47:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:47:40 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15034, which changed state. Bug 15034 Summary: Plack testing -- Importing a staged record batch returns the Koha web installer http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15034 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 04:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 02:49:20 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of DBIx::Connector |DBIC should create/own the | |DB handler -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 08:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 06:32:11 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Mike changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 09:18:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 07:18:03 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 09:32:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 07:32:17 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8970 CC| |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 09:32:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 07:32:17 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15032 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 09:35:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 07:35:28 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #2 from Jonathan Druart --- For the same file, sometimes it works, sometimes you get "Internal server error" and sometimes the progress bar is stuck, that's it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 09:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 07:50:41 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #12 from Fridolin SOMERS --- Is the ISBD view even used today ? Since the XSLT are largely used for a customised view. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 12:13:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 10:13:26 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #13 from Zeno Tajoli --- I confirm that ISBD view (opac and intranet) is wide used here in Italy. The main user are librarians. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 13:59:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 11:59:18 +0000 Subject: [Koha-bugs] [Bug 15036] New: Closeing and reopening a basket should not alter status of completed orders Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Bug ID: 15036 Summary: Closeing and reopening a basket should not alter status of completed orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org When a basket is closed all orders are set to status 'ordered', if reopened they are all set to 'new', however if some orderlines are receipted and the basket subsequently reopened and again closed (e.g. to cancel some orders) although the order has copies received set, a datereceived and a link to an invoice it status reverts to new 9after reopen) or on order (after close) which does not reflect its true state. These operations should not include completed lines in their status updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 14:34:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 12:34:58 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 43625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43625&action=edit "Stage to import" fails The upload step doesn't seem to fail. But the "Stage to import" step raises the error from the screenshot. I tried to upload both authority and bibliographic records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:48:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:48:10 +0000 Subject: [Koha-bugs] [Bug 15007] Slips and notices table 'letters' should have an 'id' primary key column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:48:38 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #69 from Tom?s Cohen Arazi --- Created attachment 43626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43626&action=edit Bug 11759: (QA followup) minor text changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:49:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:49:03 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #70 from Tom?s Cohen Arazi --- Created attachment 43627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43627&action=edit Bug 11759: (QA followup) Sysprefs should be kosher The introduced syspref was defined before we added new guidelines for them. This patch puts them in sync with current standards. It also splits them into: - A big on/off switch (BatchCheckouts) - Patron category filter (BatchCheckoutsValidCategories) The latter is expected to go away if we move this into a boolean column on the 'categories' table, which seems a better approach. I'm filling a new bug for this last comment. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:53:58 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #95 from Tom?s Cohen Arazi --- Created attachment 43628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43628&action=edit Bug 8236: (QA followup) fix test count error due to bad merge On rebasing the patchset I introduced a wrong number of tests. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:56:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:56:22 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #71 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Jonathan! PS. I'm filling a couple followup bugs that I will link. I hope someone can take a look before the release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:58:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:58:47 +0000 Subject: [Koha-bugs] [Bug 15037] New: Batch checkout tab should be hidden for patrons not satisfying policy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Bug ID: 15037 Summary: Batch checkout tab should be hidden for patrons not satisfying policy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com There's no use for the Batch checkout tab when the patron belongs to a category that is not listed in BatchCheckoutsValidCategories. I belive the tab should be hidden in that case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:58:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:58:55 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15037 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 15:58:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 13:58:55 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11759 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 [Bug 11759] Batch checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:02:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:02:17 +0000 Subject: [Koha-bugs] [Bug 15038] New: Move BatchCheckoutsValidCategories into the categories table Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038 Bug ID: 15038 Summary: Move BatchCheckoutsValidCategories into the categories table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The batch checkouts feature introduced by bug 11759, adds a BatchCheckoutsValidCategories syspref which is a free-text one. It is expected to be filled with pipe-separated patron categories. The syspref should be removed, and this should be moved to the categories table: - A checkbox on editing patron categories (conditional to the BatchCheckouts syspref value) - A new column: categories.allow_batch_checkouts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:02:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:02:26 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15038 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038 [Bug 15038] Move BatchCheckoutsValidCategories into the categories table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:02:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:02:26 +0000 Subject: [Koha-bugs] [Bug 15038] Move BatchCheckoutsValidCategories into the categories table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11759 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 [Bug 11759] Batch checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:10:37 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:10:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:10:40 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43597|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 43629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43629&action=edit Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:26:19 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #11 from Christopher Brannon --- We're excited to see this enhancement move forward. Would love it if it could get through QA in time for the next release. :) Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:27:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:27:18 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 --- Comment #4 from Christopher Brannon --- We've been waiting a while for this enhancement. Would love it if someone could run it through QA ASAP. :) Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:34:43 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:34:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:34:47 +0000 Subject: [Koha-bugs] [Bug 15038] Move BatchCheckoutsValidCategories into the categories table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15038 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:41:11 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:41:13 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 43630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43630&action=edit Bug 14674: koha-create should populate upload_path This patch makes koha-create and koha-create-dirs aware of the new upload_path configuration entry. It defaults to /var/lib/koha//uploads as proposed by Robin but lets the user specify its own directory, using the --upload-path option switch that is added by this patch. koha-create-dirs is tweaked so it also creates this new directory. The docs are updated accordingly. To test: - Apply the patch, have a packages setup (either by grabbing the relevant files [1] or by creating your own package). - Run koha-create --create-db instance => SUCCESS: /var/lib/koha/instance/uploads directory is created => SUCCESS: /etc/koha/sites/instance/koha-config.xml has upload_path set correctly - Create a new instance using the --upload-path making it point to whatever you want => SUCCESS: koha-conf.xml points to your chosen path - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:46:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:46:36 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_22_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 16:52:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 14:52:38 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:01:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:01:42 +0000 Subject: [Koha-bugs] [Bug 15039] New: Move top language menu to include and streamline logic Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Bug ID: 15039 Summary: Move top language menu to include and streamline logic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is used at other places as well (see Bug 14776). This patch moves it to a file masthead-langmenu.inc to make it re-usable. Additionally it streamlines the logic (not all combinations of Opac sysprefs that should display the menu did so). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:01:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:01:44 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43440|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 43631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43631&action=edit Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t We can use Test::DBIx::Class to install fixtures before our tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:01:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:01:47 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #29 from Jonathan Druart --- Created attachment 43632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43632&action=edit Bug 14778: Mocks Koha::Database->_new_schema instead of C4::Context->_new_dbh C4::Context::_new_dbh does not exist anymore. Koha::Database::_new_schema should be mocked instead. Will fix: - t/00-load.t - t/Breeding.t - t/ImportBatch.t - t/Message.t - t/Overdues.t - t/Prices.t - t/RotatingCollections.t - t/Search.t - t/SuggestionEngine_AuthorityFile.t - t/XSLT.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:01:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:01:50 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #30 from Jonathan Druart --- Created attachment 43633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43633&action=edit Bug 14778: Use mock_dbh where it should be used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:01:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:01:54 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #31 from Jonathan Druart --- Created attachment 43634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43634&action=edit Bug 14778: Install fixtures for t/Calendar.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:01:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:01:59 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #32 from Jonathan Druart --- Created attachment 43635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43635&action=edit Bug 14778: Install fixtures for t/Biblio.t Note that it already passed before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:03 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #33 from Jonathan Druart --- Created attachment 43636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43636&action=edit Bug 14778: Install fixtures for t/Images.t Note that this tests file were completely buggy before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:09 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #34 from Jonathan Druart --- Created attachment 43637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43637&action=edit Bug 14778: Install fixtures for t/ItemType.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:14 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #35 from Jonathan Druart --- Created attachment 43638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43638&action=edit Bug 14778: Install fixtures for t/Koha.t Warning: This patch modifies a module! What's the need of the binary function here? The data are case insensitive, so no need to use this mysql function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:19 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #36 from Jonathan Druart --- Created attachment 43639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43639&action=edit Bug 14778: Install fixtures for t/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:23 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #37 from Jonathan Druart --- Created attachment 43640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43640&action=edit Bug 14778: Install fixtures for t/Matcher.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:28 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #38 from Jonathan Druart --- Created attachment 43641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43641&action=edit Bug 14778: Install fixtures for t/Members_AttributeTypes.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:32 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #39 from Jonathan Druart --- Created attachment 43642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43642&action=edit Bug 14778: Install fixtures for t/SocialData.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:36 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #40 from Jonathan Druart --- Created attachment 43643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43643&action=edit Bug 14778: Make Barcodes_ValueBuilder.t db dependent The get_barcode subroutines call very mysql specific functions and it's not possible to easily use fixtures here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:41 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #41 from Jonathan Druart --- Created attachment 43644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43644&action=edit Bug 14778: Mock the dbh for t/db_dependent/Search.t No need to mock the items' columns (?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:02:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:02:47 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #42 from Jonathan Druart --- Created attachment 43645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43645&action=edit Bug 14778: Remove t/Acquisition/Invoices.t Using Test::DBIx::Class now, we cannot do what we did in this file with DBD::Mock. Since the Invoice[s] subroutines are already tested in t/db_dependent/Acquisition/Invoices.t there is no special needs to have these ones. Instead of loosing 2 hours on this file, I would prefer to remove it. Feel free to provide a counter patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:03:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:03:36 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #43 from Jonathan Druart --- Enjoy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:04:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:04:47 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #19 from Katrin Fischer --- Created attachment 43646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43646&action=edit [PASSED QA] Bug 8436: Add limit on branch in checkexpiration.pl This limit is only available for superlibrarians and patrons that have superserials permission. Other patrons will only see subscriptions of their branch. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:04:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:04:51 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #20 from Katrin Fischer --- Created attachment 43647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43647&action=edit [PASSED QA] Bug 8436: Replace GetBranches with GetBranchesLoop The branch selection logic still exists in GetBranchesLoop, it should be used here. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:04:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:04:54 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #21 from Katrin Fischer --- Created attachment 43648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43648&action=edit [PASSED QA] Bug 8436: Use C4::Context->IsSuperLibrarian() Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:04:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:04:59 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #22 from Katrin Fischer --- Created attachment 43649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43649&action=edit Bug 8436: QA Follow-up: Activate branch filter, if IndependentBranches is off The superserials permission is only in use in combination with IndependentBranches - so it makes sense to also show the branch filter when IndependentBranches is off. Permission description: superserials Manage subscriptions from any branch (only applies when IndependentBranches is used) Also adds a missing check for superlibraian. Note: the duplicated permission check in the code is not really nice - would be good to rewrite this to be more clean. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:05:03 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #23 from Katrin Fischer --- Created attachment 43650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43650&action=edit Bug 8436: QA Follow-up: Add Library to result list If we offer a library filter, we should also show the library in the result list, so that search options and result list match. Otherwise, for libraries with multiple branches, there is no way to see, which is the subscription of a specific branch in the list. - Add a Library column in the result list - Rename branch to library in the template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:05:25 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:07:48 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41891|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:07:51 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:07:54 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35166|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:10:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:10:12 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #24 from Katrin Fischer --- I am guilty of 2 small follow-ups here - Julian or some other QA person - could you take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:12:36 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #44 from Jonathan Druart --- Note about DBIx::Class warnings: These changes will raise warnings: DBIx::Class::Storage::DBI::_warn_undetermined_driver(): This version of DBIC does not yet seem to supply a driver for your particular RDBMS and/or connection method ('Mock'). While we will attempt to continue anyway, the results are likely to be underwhelming. Please upgrade DBIC, and if this message does not go away, file a bugreport including the following info: { DBD => "DBD::Mock", DBD_VER => "1.45", DBIC_DRIVER => "DBIx::Class::Storage::DBI", DBIC_DSN => "DBI:Mock:", DBIC_VER => "0.082820", DBI_VER => "1.631" } They can be hidden creating a package DBIx::Class::Storage::DBI::Mock (in /usr/share/perl5/DBIx/Class/Storage/DBI/Mock.pm for instance): === package DBIx::Class::Storage::DBI::Mock; use base DBIx::Class::Storage::DBI; 1; === We will still get: DBIx::Class::Storage::DBI::sql_maker(): Your storage class (DBIx::Class::Storage::DBI::Mock) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI::Mock' This could be fixed later with deeper examinations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:14:06 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 --- Comment #1 from Marc V?ron --- Created attachment 43651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43651&action=edit Bug 15039 - Move top language menu to include and streamline logic The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is used at other places as well (see Bug 14776). This patch moves it to a file masthead-langmenu.inc to make it re-usable. Additionally it streamlines the logic (not all combinations of Opac sysprefs that should display the menu did so). To test: - Apply patch - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verify that sysprefs opacuserlogin and EnableOpacSearchHistory do not interfere with the lenguage menu (before, at least one of them had to be on to display the menu) - Verify that language switching works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:15:41 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |veron at veron.ch Blocks| |14776 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:15:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:15:41 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15039 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 [Bug 15039] Move top language menu to include and streamline logic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:16:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:16:28 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:36:44 +0000 Subject: [Koha-bugs] [Bug 8417] date acquired is shipping date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 --- Comment #14 from Jonathan Druart --- Created attachment 43652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43652&action=edit Bug 8417: Fix test ModReceiveOrder now excepts a date formatted following the dateformat pref. If nothing is given, default is now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 17:48:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 15:48:48 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42423|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:00:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:00:52 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43651|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 43653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43653&action=edit Bug 15039 - Move top language menu to include and streamline logic The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is used at other places as well (see Bug 14776). This patch moves it to a file masthead-langmenu.inc to make it re-usable. Additionally it streamlines the logic (not all combinations of Opac sysprefs that should display the menu did so). To test: - Apply patch - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verify that sysprefs opacuserlogin and EnableOpacSearchHistory do not interfere with the lenguage menu (before, at least one of them had to be on to display the menu) - Verify that language switching works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:17:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:17:59 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:18:02 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43278|0 |1 is obsolete| | Attachment #43279|0 |1 is obsolete| | Attachment #43280|0 |1 is obsolete| | Attachment #43281|0 |1 is obsolete| | Attachment #43282|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 43654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43654&action=edit [SIGNED-OFF] Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:18:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:18:14 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #38 from Kyle M Hall --- Created attachment 43656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43656&action=edit [SIGNED-OFF] Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:18:11 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #37 from Kyle M Hall --- Created attachment 43655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43655&action=edit [SIGNED-OFF] Bug 14610 - Update Schema files Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:18:17 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #39 from Kyle M Hall --- Created attachment 43657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43657&action=edit [SIGNED-OFF] Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:18:20 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #40 from Kyle M Hall --- Created attachment 43658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43658&action=edit [SIGNED-OFF] Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Jennifer Schmidt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:31:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:31:13 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #254 from Heather Braum --- As the 3.22 feature flush approaches, I was wondering if this one was going to be considered a candidate for 3.22. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 18:59:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 16:59:42 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #8 from Marc V?ron --- Created attachment 43659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43659&action=edit Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header The SCO screen displays patron related menu items in it's header (Link to the account and "Logout"). This makes no sense since the patron that is logged in is the 'selfcheck' user as defined in syspref AutoSelfCheckId. Additionally, the language menue is missing when the syspref OpacLangSelectorMode is set to 'top' or to 'both'. To test: - Apply on top of Bug 15039 - Set AutoSelfCheck sysprefs as appropriate - Set OpacLangSelectorMode to 'top' or 'both' - Go to SCO page - Verify that the language menue does not display in the header - Enter a card number to check out (this logs in the SCO user) - Verify that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Apply patch - Verify that the language menu appears and the SCO user's information disappears. - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 19:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 17:02:30 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 19:11:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 17:11:02 +0000 Subject: [Koha-bugs] [Bug 10598] self check shouldn't link out to catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598 --- Comment #3 from Marc V?ron --- Re-tested on top of Bugs 15039 and 14776, could not reprduce the issue. Can this bug be set to resolved? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 19:16:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 17:16:21 +0000 Subject: [Koha-bugs] [Bug 2696] Fine Payments Should Show What Was Paid For In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 19:20:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 17:20:45 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 19:20:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 17:20:47 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43629|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 43660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43660&action=edit [PASSED QA] Bug 15029: Make the IssueSlip tests pass even if launched after 23:00 Prior to this patch, the tests did not pass if they were launched after 23:00. DateTime complains if you ask for creating a date with hour => 24 (which is logical so far). Test plan: 0/ Don't apply this patch 1/ sudo date -s "2015-10-19 23:50:00";prove t/db_dependent/Members/IssueSlip.t 2/ Apply this patch and repeat 1. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:22:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:22:10 +0000 Subject: [Koha-bugs] [Bug 15007] Slips and notices table 'letters' should have an 'id' primary key column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:24:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:24:10 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 43661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43661&action=edit Bug 14676: (QA followup) remove useless patroncards-menu.inc file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:24:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:24:14 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 43662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43662&action=edit Bug 14676: (QA followup) Make title, breadcrumbs and labels consistent It does so by slightly changing the naming schema, in line with bug 14667 changes. It also corrects a minor bug in the breadcrumbs for printer profiles. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:24:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:24:18 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 --- Comment #10 from Tom?s Cohen Arazi --- Created attachment 43663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43663&action=edit Bug 14676: (QA followup) Fix case problems carried from the past Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:26:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:26:46 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:27:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:27:08 +0000 Subject: [Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:36:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:36:19 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #29 from Kyle M Hall --- (In reply to Jonathan Druart from comment #28) > (In reply to Kyle M Hall from comment #27) > > With 540 checkouts I get the following with your script: > > > > on master: > > real 0m1.023s > > user 0m0.980s > > sys 0m0.044s > > > > with bug 8483: > > real 0m1.032s > > user 0m0.980s > > sys 0m0.052s > > Is it 500 checkouts for 1 patron? Yes, all the checkouts are for one patron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 20:46:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 18:46:07 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, robin at catalyst.net.nz --- Comment #45 from Tom?s Cohen Arazi --- The only (and not minor) issue I see is: tests relying on Test::DBIx::Class only make sense in t/* (i.e. the point of db_dependent tests is that they are integration tests, using the DB for real). So the problem is that if we don't have Test::DBIx::Class packaged, then the .deb packages cannot build (they need prove t/ pass clean). So we need to either: (a) have Test::DBIx::Class and friends packaged (Robin?) (b) have those tests conditional to its availability: use Module::Load::Conditional qw/check_install/; BEGIN { if ( check_install( module => 'Test::DBIx::Class' ) ) { plan tests => 11; } else { plan skip_all => "Need Test::DBIx::Class" } } (b) is sub optimal. We want to run the tests. But (a) needs Robin's intervention I think, so I have no clue. Help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 21:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 19:04:00 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Marc V?ron --- Does not apply: CONFLICT (content): Merge conflict in t/Creators.t Failed to merge in the changes. Patch failed at 0001 Bug 12194 - add more tests for pdf creation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 21:14:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 19:14:44 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Marc V?ron --- Patch does not apply: Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 21:53:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 19:53:52 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42804|0 |1 is obsolete| | --- Comment #16 from Marc V?ron --- Created attachment 43664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43664&action=edit Bug 13881: Add desk management Desks can be created for a branch. If a librarian sets a desk in the intranet and check in a document on hold, the document is then attached to a desk. Test plan, basic desk creation/modification/deletion: 1/ perl installer/data/mysql/updatedatabase.pl (create new table desks) 2/ prove t/db_dependent/Desks.t 3/ go to admin page, click on desk management, try to create, modify and delete desks Test plan, setting desk in the intranet: 1/ Go to the intranet administration, remove all desks if you have any. The desks should not appear in the header. 2/ add some desks in administration, without selecting some. The message ? NO DESK SET ? should appear at the left of the branchname. 3/ set a desk for your session. The desk deskcode should appear beside the branchname. 4/ change desk, the new name should appear also. Test plan, attach holds awaiting pickup to a desk: 1/ Set a desk, put a book on hold, check it in, confirm hold, it should appear in the "holds awaiting pickup" circulation page, it should appear as waiting at the desk on the patron's session. 2/ Suppress desk. The hold is still pending, but desk mentions should have disappear from "holds awaiting pickup" and patron's session. http://bugs.koha-community.org/show_bug.cgi?id=13881 Fixed conflict in installer/data/mysql/kohastructure.sql Followed testplan, works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 21:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 19:54:57 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 22:18:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 20:18:52 +0000 Subject: [Koha-bugs] [Bug 15008] Add custom HTML areas to circulation and reports home pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15008 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 22:39:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 20:39:04 +0000 Subject: [Koha-bugs] [Bug 12752] OVERDUE notice mis-labeled as "Hold Available for Pickup" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12752 --- Comment #4 from Heather Braum --- Bug 15007 will add a primary key id to the letter table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 22:39:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 20:39:26 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz Status|NEW |In Discussion --- Comment #4 from Liz Rea --- This is what I was seeing too - though I never got a server error, it just hung. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:02 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41830|0 |1 is obsolete| | Attachment #41831|0 |1 is obsolete| | Attachment #41832|0 |1 is obsolete| | Attachment #41833|0 |1 is obsolete| | Attachment #41834|0 |1 is obsolete| | Attachment #41835|0 |1 is obsolete| | Attachment #41836|0 |1 is obsolete| | --- Comment #113 from Katrin Fischer --- Created attachment 43665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43665&action=edit [PASSED QA] Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:13 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #114 from Katrin Fischer --- Created attachment 43666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43666&action=edit [PASSED QA] Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:19 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #115 from Katrin Fischer --- Created attachment 43667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43667&action=edit [PASSED QA] Bug 8296: Follow up for QA 1 redefined variable removed Signed-off-by: Julian Maurice Signed-off-by: Cedric Vita Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:25 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #116 from Katrin Fischer --- Created attachment 43668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43668&action=edit [PASSED QA] Bug 8296: Don't fill text field automatically + minor fixes: * Add bug number to updatedatabase * Fix colspan in serials-edit.tt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:31 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #117 from Katrin Fischer --- Created attachment 43669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43669&action=edit [PASSED QA] Bug 8296: Display publisheddatetext in OPAC bootstrap theme and remove modifications for OPAC prog theme Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:36 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #118 from Katrin Fischer --- Created attachment 43670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43670&action=edit [PASSED QA] Bug 8296: Fix unit tests in t/db_dependent/Serials.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:13:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:13:42 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #119 from Katrin Fischer --- Created attachment 43671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43671&action=edit [PASSED QA] Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is empty To test: - make sure you have a subscription where only some fields have a published date (text) set - check the subscription detail page, issues tab - check the serial collection page - both pages should show an empty field, when published date (text) has not been set Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:15:07 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #5 from Heather Braum --- I didn't get a server error just now when staging for import, but the page never goes to the MARC staging results page. When you manually access the manage staged records page, the file you tried to stage for import is listed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:16:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:16:17 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #120 from Katrin Fischer --- I have to admit, I am not sure about the use case for this patch, but it works as described and shouldn't affect the existing workflows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:20:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:20:25 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #6 from Liz Rea --- Yep, this is what I was seeing yesterday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:22:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:22:22 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #7 from Heather Braum --- I also got another Internal Server Error for http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/tools/manage-marc-import.pl page when trying to import the batch of staged records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:25:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:25:53 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |normal --- Comment #1 from Katrin Fischer --- eek! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:34:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:34:56 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 --- Comment #25 from Katrin Fischer --- +1 for QA Jonathan - this was/is a wish list item for us! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:40:52 +0000 Subject: [Koha-bugs] [Bug 15040] New: Plack testing -- patron files area not behaving as expected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15040 Bug ID: 15040 Summary: Plack testing -- patron files area not behaving as expected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 15019 I'm checking the patron file upload with Plack, and seeing something odd; this may or may not be Plack-related. First, I set the patronimages & EnableBorrowerFiles sys prefs to Allow/Do. Here's the oddity I've run into so far (the other one went away while writing the bug report): When I can finally get the Files tab up, the system says the patron has no files attached -- even though I've uploaded 2 files already. But if I upload another file, the now three attached files display, but if I click away from the files area, and come back, the system says the patron has no files attached, yet again. The borrower I was working with: http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/members/files.pl?borrowernumber=102 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 20 23:40:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 21:40:52 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15040 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15040 [Bug 15040] Plack testing -- patron files area not behaving as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:10:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:10:20 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer --- Kyle, I have tested this and am almost ready to pass QA on this, but please add some tests highlighting the change in CalcFines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:13:54 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15041 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15041 [Bug 15041] Plack testing -- Batch Item Modification Issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:13:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:13:54 +0000 Subject: [Koha-bugs] [Bug 15041] New: Plack testing -- Batch Item Modification Issues Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15041 Bug ID: 15041 Summary: Plack testing -- Batch Item Modification Issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: hbraum at nekls.org QA Contact: testopia at bugs.koha-community.org Blocks: 15019 Created attachment 43672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43672&action=edit Screenshot of batch item modification table in plack 1) After uploading a set of barcodes, the batch item modification area has no columns displaying other than Title. (this one may not be a plack-related issue) see attached screenshot for that display 2) After setting the batch changes I want made and clicking Save, the job progress sits at 0%. I go manually to the edited items, and the items were changed. The job never says it completed successfully. This is very similar behavior to that reported with staged MARC records in bug 15032. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:23:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:23:29 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #46 from Robin Sheat --- (In reply to Tom?s Cohen Arazi from comment #45) > So we need to either: > (a) have Test::DBIx::Class and friends packaged (Robin?) I'll have a look to see how feasible this is. It's probably not terrible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:27:44 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #11 from Katrin Fischer --- Created attachment 43673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43673&action=edit [PASSED QA] Bug 14722: Add Koha::Biblioitem[s] Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:27:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:27:48 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #12 from Katrin Fischer --- Created attachment 43674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43674&action=edit [PASSED QA] Bug 14722: Refactor the export tool Why a refactoring was need for this script? The export tool (tools/export.pl) can be called from the command line and some parts of code were unnecessarity complicated (just look at the code, you will understand). Worse still, the script does not provide the same options for both interface. For instance you cannot export records given a range of biblionumbers, authids, callnumbers, etc. from the commandline. What does this patch? 1/ Important: The script tools/export.pl does not work anymore if called from the command line (should be in the release notes). 2/ The code used to generated a file (csv, iso2709 or xml) has been moved to a new module (Koha::Exporter::Record) and tests have been provided. 3/ No change is done on the web interface 4/ Some new options have been added to the commandline script (misc/export.pl): - starting_authid - ending_authid - authtype - starting_biblionumber - ending_biblionumber - itemtype - starting_callnumber - ending_callnumber - start_accession - end_accession 5/ There is a change in the behavior if an error occurs: Can't call method "as_usmarc" on an undefined value at Koha/Exporter/Record.pm line 114. record (number 5530) is invalid and therefore not exported because its reopening generates warnings above at Koha/Exporter/Record.pm line 117. Before this patch, they were not displayed (using the command line). What does not do this patch? It does not provide the 'clean', 'timestamp' and 'deleted_barcodes' options to the web interface (same as before). What about the perfs? With a DB with ~800 biblios (MARC21) Before: perl tools/export.pl 14.79s user 0.83s system 71% cpu 21.905 total After: perl misc/export.pl 17.19s user 0.84s system 75% cpu 24.018 total With a DB with ~6400 biblios (UNIMARC) Before: perl tools/export.pl 26.55s user 0.76s system 76% cpu 35.498 total After: perl misc/export.pl 26.78s user 0.84s system 80% cpu 34.494 total How to test this patch? Test plan: A. Web interface: 1/ On the current master, export some records, biblios and authorities (with the 3 differents exports) playing with the different filters (item type, libraries, callnumber, accession date, don't export items, remove non-local items, don't export fields, etc.). 2/ Apply this patch, export again the same records, and compare the generated files. They must be identical! 3/ Confirm that the export features on the checkout list (circ/circulation.pl) works as before this patch. B. The command line 1/ On the current master, export some records, biblios and authorities (with the 2 differents exports) playing with the different options (date, deleted_barcodes, clean). 2/ Apply this patch, export again the same records, and compare the generated files. They must be identical! Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:27:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:27:51 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #13 from Katrin Fischer --- Created attachment 43675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43675&action=edit [PASSED QA] Bug 14722: rename the script Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:27:54 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #14 from Katrin Fischer --- Created attachment 43676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43676&action=edit [PASSED QA] Bug 14722: Add POD for some options Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:27:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:27:58 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #15 from Katrin Fischer --- Created attachment 43677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43677&action=edit [PASSED QA] Bug 14722: CSV is only available for biblio records Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:28:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:28:38 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:28:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:28:42 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42281|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:28:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:28:40 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:28:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:28:44 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:28:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:28:45 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:28:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:28:47 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:44:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:44:05 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #89 from Katrin Fischer --- Hi Julian, I think the last patch makes a wrong assumption - the browse feature is useless if OpacBrowseResults is turned off (which some of our libraries actually have). So I think removing the checks for the checkboxes should be undone and a check for this pref added to the code - for the checkboxes and also for the link at the top of the results. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:45:25 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #15 from Katrin Fischer --- (In reply to Kyle M Hall from comment #14) > (In reply to Katrin Fischer from comment #11) > > Same here about 4-8. New sequence looks good to me, but is there a reason we > > don't display all reasons why a hold can not be placed? > > Basically, it causes confusion for librarians. For example, iirc, a patron > may not be able to place holds on any of the items, and thus the librarian > receives the "too many holds" error which is not actually true. I agree that the 'too many' is often confusing, just wondering if we could be more precise as several of the reasons might apply at the same time - too many holds, restricted, too many fines... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:54:08 +0000 Subject: [Koha-bugs] [Bug 15031] PLACK looping installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15031 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi --- This is fixed by bug 14778. If you look at the plack logs, you will notice it says "MySQL server has gone away" which is the root cause of Koha redirecting to the installer. Please test against master+14778 *** This bug has been marked as a duplicate of bug 14778 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:54:08 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at quecheelibrary.org --- Comment #47 from Tom?s Cohen Arazi --- *** Bug 15031 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 00:55:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 22:55:56 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #16 from Katrin Fischer --- Huh, I realize now that we do currently display all reasons. I think this patch might just hide the real problem - that the "too_many" is not accurate enough to be helpful. With the patch it will show up less, but it will still show up sometimes if none of the other reasons applies. Maybe we could just rephrase? Too many holds: [% borrowerfirstname %] [% borrowersurname %] has too many holds. can't place holds on these item types or already has too many holds placed. Something like that? Can we pin down, when exactly the 'too many' is displayed and if that would cover it? Ultimately I think we need to make the feedback more meaningful, but would like the option to see if multiple things block placing holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 01:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 23:18:09 +0000 Subject: [Koha-bugs] [Bug 13699] DBD::mysql mysql_auto_reconnect attribute ceases to function after DBIx call[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13699 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |DUPLICATE --- Comment #2 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14778 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 01:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 20 Oct 2015 23:18:09 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #48 from Tom?s Cohen Arazi --- *** Bug 13699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 03:55:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 01:55:21 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration and Zebra info to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 03:55:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 01:55:23 +0000 Subject: [Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration and Zebra info to about In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 43678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43678&action=edit Bug 7895: Test for PSGI-related env to report in about.pl This patch introduces a test for psgi/plack in %ENV and uses that data to report in the about page. To test: - On current master (without Plack), go to about.pl - Notice no mention of Plack - Apply the patch - Reload the about page => SUCCESS: No change - Enable plack, and access the about page through Plack => SUCCESS: There is a PSGI label, showing that you are running Plack - Sign off :-D Regards PS: I haven't tested the mod_perl scenario, I just grabbed the MOD_PERL env var from the docs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 04:27:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 02:27:17 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 04:27:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 02:27:35 +0000 Subject: [Koha-bugs] [Bug 13384] RDA: 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 04:28:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 02:28:03 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Irma Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 07:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 05:45:48 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Mark, I think "Failed QA" is a stronger status than "Patch doesn't apply" - which normally just means that a rebase is needed. I'd prefer "Failed QA" in the cases where there were issues with the patch too. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 07:45:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 05:45:59 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 09:24:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 07:24:47 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38882|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 43679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43679&action=edit Bug 14154 - 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In DOM config file : etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml, the 608$9 is defined a second time instead of 610$9. Just a type I think. Test plan : - Apply patch - Install a UNIMARC + DOM instance - Define in a framework 610 using a thesaurus - Create a new biblio - Create a new authority (same type as the thesaurus defined above) - Index : rebuild_zebra.pl -a -b -x -z - Link the field 610 to the new authority - Index : rebuild_zebra.pl -a -b -x -z - In authorities search, search for the new authority => You see Use in 1 Records(s) Signed-off-by: Frederic Demians I confirm the typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 09:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 07:25:01 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 09:30:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 07:30:10 +0000 Subject: [Koha-bugs] [Bug 10890] Autobarcode "yymm00001" Fails in Acquisitions When Receiving Item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #7 from Magnus Enger --- David: Can you confirm that this is a duplicate of bug 11273 (which is now Pushed to stable)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 10:00:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 08:00:24 +0000 Subject: [Koha-bugs] [Bug 13402] Can't tab to barcode field when adding item to serial In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13402 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #2 from Magnus Enger --- The tab order seems OK to me now. Can this be closed? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 10:26:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 08:26:38 +0000 Subject: [Koha-bugs] [Bug 15042] New: Barcode yymm0001 does not work when receiving serials Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Bug ID: 15042 Summary: Barcode yymm0001 does not work when receiving serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com To reproduce: - Set autoBarcode = yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens Bug 11273, attachment 42372 changes the logic around locating the barcode field in the item table from this: - for (i=0 ; i{loctag}' && document.f.subfield[i].value == '$args->{locsubfield}') { To this: + var form = document.getElementById('f'); + if ( !form ) { + form = document.getElementById('Aform'); + } + for (i=0 ; i{loctag}' && form.subfield[i].value == '$args->{locsubfield}') { This works for the item table that adds items to a bib record:
but not for the item table that you get when receiving a serials issue, which is missing the id="f": Patch coming! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 10:40:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 08:40:33 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #49 from Martin Renvoize --- Agree with Tomas, all looks good here to me.. but he's right about either making the tests conditions or packaging up Test::DBIx::Class and friends. Jonathan, many thanks for seeing this one through.. it's a real step in the right direction and I know was a bit of an *** to work through. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:20:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:20:22 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #1 from Magnus Enger --- Created attachment 43680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43680&action=edit Item form with id=f -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:20:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:20:48 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #2 from Magnus Enger --- Created attachment 43681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43681&action=edit Item form without id=f -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:21:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:21:48 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #3 from Magnus Enger --- I thought this would be as easy as adding id="f" to the item form for receiving serials, but that changes the whole look of the form. See attached screenshots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:24:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:24:50 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #27 from Martin Renvoize --- Could we have some documentation on what a sensible directory location would look like, and what permissions the files within it may require to be accessible by this route (and only this route)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:41:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:41:23 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #28 from Katrin Fischer --- I am really keen on this feature, as Koha lacks a good way to access files like the ones generated for print notices. I have a few concerns tho: - The files should be stored in a directory on the server that is safe and cannot be accessed from outside as these files can and will most likely contain patron information in some way. How can we make this happen? I think the least we need to do is add a documentation saying that clearly. - Related to the first thing... can we please rename publicdir again to indicate something that should not be public/open? internal_files? privatefiledir? Not really a good idea here, but someone else might have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:49:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:49:31 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #50 from Jonathan Druart --- On Jessie: dh-make-perl --pkg-perl --build --cpan Test::DBIx::Class build a wonderfull libtest-dbix-class-perl_0.45-1_all.deb package without any error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 11:55:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 09:55:46 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Could you please detail? The tab is hidden for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 12:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 10:26:32 +0000 Subject: [Koha-bugs] [Bug 15036] Closeing and reopening a basket should not alter status of completed orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15036 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com Status|NEW |Needs Signoff --- Comment #2 from Colin Campbell --- Created attachment 43682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43682&action=edit Proposed patch Patch. To test create a basket with a number of orders close. receive one of the orders, reopening and closing the basket will change the received order status as outlined in the bug report. Apply the patch. Receive another order in the basket again reopen and close the basket. Note that the status of the completed order is not overridden by these operations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 12:30:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 10:30:44 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 12:30:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 10:30:47 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43679|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 43683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43683&action=edit Bug 14154 - 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In DOM config file : etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml, the 608$9 is defined a second time instead of 610$9. Just a type I think. Test plan : - Apply patch - Install a UNIMARC + DOM instance - Define in a framework 610 using a thesaurus - Create a new biblio - Create a new authority (same type as the thesaurus defined above) - Index : rebuild_zebra.pl -a -b -x -z - Link the field 610 to the new authority - Index : rebuild_zebra.pl -a -b -x -z - In authorities search, search for the new authority => You see Use in 1 Records(s) Signed-off-by: Frederic Demians I confirm the typo. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 12:40:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 10:40:25 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #17 from Kyle M Hall --- (In reply to Katrin Fischer from comment #16) > Huh, I realize now that we do currently display all reasons. > > I think this patch might just hide the real problem - that the "too_many" is > not accurate enough to be helpful. With the patch it will show up less, but > it will still show up sometimes if none of the other reasons applies. > > Maybe we could just rephrase? > > Too many holds: href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber > %]">[% borrowerfirstname %] [% borrowersurname %] has too many holds. > > can't place holds on these item types or already has too many holds > placed. > > Something like that? Can we pin down, when exactly the 'too many' is > displayed and if that would cover it? > > Ultimately I think we need to make the feedback more meaningful, but would > like the option to see if multiple things block placing holds. Rephrasing does nothing to fix the issue. The problem isn't that the too_many message is wrong, it's that it is triggered by almost all situations where a patron cannot place holds. That makes it not useful. This patch changes that so that it displays only if no other limitations exist, which means the patron really has simply placed too many holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 12:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 10:44:39 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #46 from Jonathan Druart --- (In reply to Charles Farmer from comment #45) > (In reply to Jonathan Druart from comment #38) > > It does not seem to work if item-level_itypes is set to biblio. > > You should also provide tests for C4::Circulation::LostItem (I suspect that > > the problem comes from the query executed in this subroutine). > > When you say "provide tests for LostItem", do you mean that a separate file > should be written under t/db_dependent/Circulation/ for that purpose, or > would you accept if the tests were added to everything else in Circulation.t > ? The last patch could do the job, if the itemtype type you used (BK) was created (tests should create their own data). But thinking about it, I am wondering why you pass the processfee to chargelostitem and don't retrieve it in the chargelostitem subroutine. It also a bit weird to pass an issue, the name of the sub is chargelost*item* :) Kyle, could I get your opinion on that please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 12:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 10:57:42 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #34 from Jonathan Druart --- (In reply to Charles Farmer from comment #32) > (In reply to Jonathan Druart from comment #27) > > My concern is that the field will be display for all notices but will only > > be take into account in few cases. > Yes, the added flexibility means we would see the fee box appear every time. > I don't know enough about Koha's UX to really give you an alternative, but > perhaps you have an idea on how we could answer your concern? Heh, on one hand you add flexibility (ability to specify fee for any types of notices) but on the other hand you don't: the need on bug 13816 and bug 14666 is to define different fees for the same letter. You could want to charge a student for an overdue, but not a staff member, using the same notice template. I don't have a good idea to give you right now, but maybe an email on koha-devel to explain the problem could bring us feedback/help/ideas? There is something else wrong with your patch: You can only define a fee on editing a circulation notice (not on creating), minor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:08:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:08:15 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 --- Comment #18 from Katrin Fischer --- But it can also hide the information that you want to see - like no item available and age restriction could happen at the same time - that's what bugs me a bit about this approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:11:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:11:16 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #4 from Magnus Enger --- D'oh, the form already has id="serials_edit". Patch coming in a sec. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:17:21 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 --- Comment #5 from Magnus Enger --- Created attachment 43684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43684&action=edit Bug 15042 - Barcode hbyymmincr does not work when receiving serials To test: - Set autoBarcode = yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens - Apply patch and reload page - Receive an issue - Click in the barcode field - a barcode conforming to the hbyymmincr setting appears -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:17:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:17:18 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:18:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:18:48 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:18:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:18:51 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43592|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall --- Created attachment 43685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43685&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:19:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:19:03 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #47 from Kyle M Hall --- Created attachment 43686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43686&action=edit Bug 9129 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:29:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:29:08 +0000 Subject: [Koha-bugs] [Bug 15043] New: Bottom table header row for circulation rules missing a column Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043 Bug ID: 15043 Summary: Bottom table header row for circulation rules missing a column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The bottom table header cell for "Current on-site checkouts allowed" column is missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:29:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:29:19 +0000 Subject: [Koha-bugs] [Bug 15043] Bottom table header row for circulation rules missing a column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:30:01 +0000 Subject: [Koha-bugs] [Bug 15043] Bottom table header row for circulation rules missing a column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:30:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:30:03 +0000 Subject: [Koha-bugs] [Bug 15043] Bottom table header row for circulation rules missing a column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043 --- Comment #1 from Kyle M Hall --- Created attachment 43687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43687&action=edit Bug 15043 - Bottom table header row for circulation rules missing a column The bottom table header cell for "Current on-site checkouts allowed" column is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:36:49 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #6 from Marcel de Rooy --- debian/scripts/koha-create: line 294: local: `=upload21': not a valid identifier Trivial typo in the routine set_upload_path: remove the $ from instance sed: -e expression #26, char 20: unknown option to `s' Not sure why this comes up But it appears to be something with the new line: -e "s/__UPLOAD_PATH__/$UPLOAD_PATH/g" \ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:39:13 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13590 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 [Bug 13590] Add ability to charge fines at start of charge period -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:39:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:39:13 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9129 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:39:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:39:40 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43685|0 |1 is obsolete| | Attachment #43686|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall --- Created attachment 43688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43688&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:39:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:39:47 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #49 from Kyle M Hall --- Created attachment 43689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43689&action=edit Bug 9129 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:41:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:41:35 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 --- Comment #2 from Tom?s Cohen Arazi --- Steps to reproduce: - Set BatchCheckouts to "allow" - Set BatchCheckoutsValidCategories to ST - Have a patron in another category (for example S) - Go to that patron details => FAIL: You can see the "Batch checkouts" tab, if you choose it, Koh correctly says that patron category cannot be used for batch checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:47:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:47:15 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 --- Comment #3 from Jonathan Druart --- That's how I have tested, and it works here, weird. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 13:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 11:50:43 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #47 from Kyle M Hall --- Comment on attachment 40000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40000 Bug 12768 - Updated schema files Review of attachment 40000: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12768&attachment=40000) ----------------------------------------------------------------- ::: Koha/Schema/Result/Itemtype.pm @@ +37,4 @@ > > =head2 rentalcharge > > + data_type: 'decimal' itemtypes.rentalcharge is changed from double to decimal in Schema and kohastructure.pl, but no corrosponding change is made in bug_12768-update_schema_files.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:00:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:00:04 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #48 from Kyle M Hall --- > Kyle, could I get your opinion on that please? I agree. This change makes the LostItem far more complicated. Using the plural form "issues" adds even more confusion. Please restore the prototype for LostItem to its original form and fetch the processing fee from the itemtype within chargelostitem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:00:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:00:09 +0000 Subject: [Koha-bugs] [Bug 12768] Replacement cost and processing fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #49 from Kyle M Hall --- > Kyle, could I get your opinion on that please? I agree. This change makes the LostItem far more complicated. Using the plural form "issues" adds even more confusion. Please restore the prototype for LostItem to its original form and fetch the processing fee from the itemtype within chargelostitem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:04:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:04:31 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #7 from Robin Sheat --- (In reply to Marcel de Rooy from comment #6) > debian/scripts/koha-create: line 294: local: `=upload21': not a valid > identifier > Trivial typo in the routine set_upload_path: remove the $ from instance > > sed: -e expression #26, char 20: unknown option to `s' > Not sure why this comes up > But it appears to be something with the new line: > -e "s/__UPLOAD_PATH__/$UPLOAD_PATH/g" \ I bet that the / in the path are confusing sed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:07:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:07:02 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #8 from Marcel de Rooy --- (In reply to Robin Sheat from comment #7) > I bet that the / in the path are confusing sed. Probably. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:41:51 +0000 Subject: [Koha-bugs] [Bug 14994] Add RSS/Atom feed proxy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14994 --- Comment #1 from Martin Persson --- Created attachment 43690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43690&action=edit Bug 14994 - Request proxy (added syspref) Adds a web proxy allowing external RSS and Atom feeds to be displayed in OPAC and staff interface pages. This patch adds system preference(s) under the 'Web services' tabs. Sponsored-By: Halland County Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:42:14 +0000 Subject: [Koha-bugs] [Bug 14994] Add RSS/Atom feed proxy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14994 --- Comment #2 from Martin Persson --- Created attachment 43691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43691&action=edit Bug 14994 - Request proxy (added opac-proxy.pl) This patch adds a new opac page that is used as an endpoint for external web requests such as RSS feeds. This allows user scripts to pull data via XHR requests from external resources without violating the 'same-origin' restriction. I would appreciate some feedback on security implications of doing this. Might need to add some DoS protection etc. The script takes a single parameter; 'id', the number of the feed to retrieve. This is an offset into an array of URLs stored in the system preference named 'RequestProxyURL'. The offset i based on 1 to make it easier for non-technical people. The first feed is '1', '0' is invalid. Test plan: 1) Apply the syspref patch first. 2) Apply this patch. 3) Enable the request proxy by going into System Preferences, Web Services, set RequestProxyEnabled to 'yes' and enter a test URL such as: http://hyltebiblioteken.blogspot.se/feeds/posts/default and: http://bokbastisarna.blogspot.com/feeds/posts/default into RequestProxyURL. 4) Save and go to the new url: http://127.0.1.1/cgi-bin/koha/opac-proxy.pl?id=1 You should get the content of the first URL with 'id' = 1. With 'id' = 2 you should get the second URL. With 'id' = 3 you should get a 503 error. 5) Disable the service again, 'RequestProxyEnabled' = no. 6) Go back to the proxy url, you should now receive a 503 error even for valid feed id's AND for invalid ones. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 14:47:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 12:47:58 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 --- Comment #5 from Tom?s Cohen Arazi --- Clarification, just in case: this bug is passed-QA, I've just requested the QAM's opinion privately, but I also marked with the rel_3_22_candidate keyword to make it clear it will be pushed for 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:11:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:11:20 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #7) > (In reply to Kyle M Hall from comment #6) > > Created attachment 43277 [details] [review] [review] > > Bug 14915 [QA Followup] - Tweak '+' icon for serials-home > > There are certainly some others I have not found. > I also tested for a few minutes. > > I think we need either another signoff (the tester must test a lot of pages > and compare them with master) or wait for the beginning of the next release > cycle. Jonathan, you are so lazy :-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:12:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:12:36 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:12:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:12:38 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 --- Comment #4 from Jonathan Druart --- Created attachment 43692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43692&action=edit Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:13:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:13:37 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:16:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:16:44 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #9 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #8) > Jonathan, you are so lazy :-P Indeed, I am a developer, I have to be lazy! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:29:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:29:11 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #10 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #9) > (In reply to Tom?s Cohen Arazi from comment #8) > > Jonathan, you are so lazy :-P > > Indeed, I am a developer, I have to be lazy! Feature, not a bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:30:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:30:13 +0000 Subject: [Koha-bugs] [Bug 12769] Notice fee management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769 --- Comment #35 from Gaetan Boisson --- ---Short Version--- Do we want to be able to charge users on arbitrary notifications, and if we do, are we willing to provide users with a design that will require maintaining all the different variants of the notifications? ---Long Prose--- I went and read the RFC mentioned at the top of this thread first, which seems to be where the initial requirement was expressed. Bug 14666 is obviously trying to achieve something quite similar. I see two possibilities: - The requirement is to charge on notifications for late documents, something that indeed cannot be done in Koha right now. That is my understanding of the RFC actually, but I didn't write it, and I don't know the sponsor;). I have had libraries asking me how to have a one time charge when patrons have late documents. Koha makes some complicated calculations regarding each document and the number of days late, according to the circulation matrix, which definitely doesn't fit everyone's needs, and which will generate odd amounts for fines. My point is that there clearly is a need to be able to charge a simple one time amount to patrons with late documents. If this is the only scenario for the requirement, then I think adding this possibility at the notification level is a bad idea. It makes it difficult to charge different amounts for different patron categories or different libraries since you will have to edit different notifications for these, I find the "notices and slips" tool quite complicated already, while the "overdue status trigger" tool is very clear. It also makes it possible to charge for notifications for which I cannot see the need, like PREDUE. There are other notifications for which I think "fair enough, why not", like "hold available for pick up", but frankly none of them make as much sense to me as the overdue notices (and I don't see myself needing this anytime soon). - But maybe that is precisely the requirement, to be able to charge users on arbitrary notifications and not just for late items. If this is the case then in the current design libraries who want to manage different fine amounts for different patron categories / libraries combinations for overdue notices will have to deal with having a really long list of notifications to maintain, since they will have one for each combination of patron category / library for which the amount is different. If the wording has to change in the notification, all of them will need to be edited. This adds up with the different notifications for each stage (1st reminder, 2nd reminder, etc.), so it will be a lot of lines in the tool. So I would say the question is: do we want to be able to charge users on arbitrary notifications, and if we do, are we willing to provide users with a design that will require maintaining all the different variants of the notifications? The BibLibre development (bug 14666) is not about charging for arbitrary notifications. You have my opinion on the above question ;) InLibro and the Halland County Library should give their input and we'll see how to move forward! (Although I work for BibLibre, I am not in charge of the development on bug 14666. So if the answer is that the need is to send notifications for arbitrary notifications, I will not block the proposed functionality: it is possible to achieve our needs with it. I just think the interface is going to make it painful. I will ask St?phane Delaye to give his opinion here though.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:31:59 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43608|0 |1 is obsolete| | Attachment #43609|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 43693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43693&action=edit Bug 13409 - Add ability to purge old special holidays using cleanup_database.pl Some libraries have expressed interested in being able to purge old holidays from the database. Test Plan: 1) Create some special holidays in the past 2) Use the new --holidays DAYS option to test deleting special holidays 3) Verify only special holidays past the given amount of days were deleted Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:31:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:31:56 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:32:02 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #10 from Jonathan Druart --- Created attachment 43694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43694&action=edit Bug 13409 [QA Followup] - Remove MySQLism Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:32:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:32:08 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #11 from Jonathan Druart --- Created attachment 43695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43695&action=edit Bug 13409: Remove MySQLism - Replace DATE with CAST AS DATE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:35:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:35:58 +0000 Subject: [Koha-bugs] [Bug 15044] New: add suggestion's date on Your purchase suggestions tab in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15044 Bug ID: 15044 Summary: add suggestion's date on Your purchase suggestions tab in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Hi, In OPAC, it would be nice to see the date on which the suggestion was sent, as it appears in intranet in column Suggested by - on and in column Managed by - on. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:43:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:43:40 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Jonathan Druart --- Kyle, comment 28 is not fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:44:20 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #12 from Olli-Antti Kivilahti --- (In reply to Kyle M Hall from comment #6) > Thanks Olli! I do like your version ( except for the odd default value ; ). Heh, you should see the odd default values in acquisitions.module. (if don't know what to do order, order one piece of this Biblio) > However it does break from the standard way of doing things in > cleanup_database. Erm... The cleanup_database is from the 1990's based on the programming patterns. Why do you need to follow such a standard? Is it too much to ask to expose business logic inside the core API rather than access DB directly from the Controller/script? This is the root of many issues in Koha and we need to break that crappy cycle of untestable/automatable features. > That being said, if you *were* to add a unit test I'd say > that would be a worthwhile improvement and I'd be more than happy to > deprecate my version and sign off on yours! Well now nobody can test it, unless they refactor the feature by moving the business logic inside the API. This modification would need to pass yet another community process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:48:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:48:54 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #13 from Olli-Antti Kivilahti --- I could still fail QA due to missing tests. But back then nobody wrote test, so according to the spirit of cleanup_database.pl this behaviour is acceptable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:50:22 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43608|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:50:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:50:27 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43609|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:50:39 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:50:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:50:33 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43693|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:51:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:51:38 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #14 from Jonathan Druart --- Ok, removing my signoff, obsoleting patches. Please (someone) move the sql to a pm and write tests. Marked as Failed QA. (Everybody's happy?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 15:58:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 13:58:45 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #12 from Jonathan Druart --- I think an even better solution would be to do the job in a transaction and rollback if the commit flag is not there. So it would be something like: start transaction foreach items: is_deleted = DelItemCheck display error unless is_deleted if commit flag: commit else: rollback What do you think about that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:00:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:00:03 +0000 Subject: [Koha-bugs] [Bug 15045] New: URLs should be built using PATH_INFO and SCRIPT_NAME Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045 Bug ID: 15045 Summary: URLs should be built using PATH_INFO and SCRIPT_NAME Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Currently, Koha has different ways of building the URI path when rendering links. Some of them are hardcoded, some rely on $cgi->url. We need to calculate them correctly to support arbitrary places to put Koha's intefaces in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:00:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:00:44 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:02:30 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #3 from Josef Moravec --- *** Bug 15041 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:02:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:02:31 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15041, which changed state. Bug 15041 Summary: Plack testing -- Batch Item Modification Issues http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15041 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:02:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:02:30 +0000 Subject: [Koha-bugs] [Bug 15041] Plack testing -- Batch Item Modification Issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15041 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Josef Moravec --- *** This bug has been marked as a duplicate of bug 15021 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:03:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:03:46 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 --- Comment #3 from Jonathan Druart --- Marc, why didn't you use the include into includes/opac-bottom.inc? (I didn't check line by line if it was the same piece of code) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:15:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:15:16 +0000 Subject: [Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:16:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:16:51 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 --- Comment #4 from Marc V?ron --- (In reply to Jonathan Druart from comment #3) > Marc, why didn't you use the include into includes/opac-bottom.inc? (I > didn't check line by line if it was the same piece of code) Jonathan, because the language switcher in the bottomline is different to the language switcher in the header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:26:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:26:33 +0000 Subject: [Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:39:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:39:44 +0000 Subject: [Koha-bugs] [Bug 15046] New: Possibility to see last borrower when an item lost is returned Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15046 Bug ID: 15046 Summary: Possibility to see last borrower when an item lost is returned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Hi, When an item is marked lost, it is returned in the same time. If item is finaly checked in, we see a checkin message "Item was lost, now found.". It will be great to see in this message a link to the last borrower. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:46:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:46:00 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #100 from Jonathan Druart --- Created attachment 43696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43696&action=edit Bug 10363: Fix tests The delete op is now "delete" and the confirmation is a JS dialog box. Note that now this patch removes the categories the tests will add (to avoid error on inserting duplicate). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:51:22 +0000 Subject: [Koha-bugs] [Bug 15043] Bottom table header row for circulation rules missing a column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart --- commit e8232522a92b47090d651ea8cf6a92aa463454fb Bug 14045: Add missing th in tfoot fixes the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 16:58:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 14:58:20 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #30 from Jonathan Druart --- tested again, without plack, and got exactly the same difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:08:20 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:08:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:08:23 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30217|0 |1 is obsolete| | Attachment #40702|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 43697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43697&action=edit Bug 12194 - add more tests for pdf creation When run with KEEP_PDF enviroment variable it will keep test.pdf for manual inspection. This can be used to verify that ttf font configuration is complete like: KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t sample of utf-8 text, font name and type will be on bottom of second page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:08:27 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #9 from Jonathan Druart --- Created attachment 43698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43698&action=edit Bug 12194: Add option 'Oblique title' in labels This patch adds a checkbox on Label creator to use or not an oblique variant of main font for title Also fix font selection for title in case an oblique variant is used. To test: Before patch 1) Go to Tools > Label creator 2) Create a new layout, default values but select any 'Oblique' variant for main font and 'Biblio/Barcode' for layout type 3) Go to Manage batches, create a batch, add items, export PDF, download 4) Check logs, you must find a line with 'ERROR in koha-conf.xml -- missing ' for example if main font Courier-Oblique 5) Open PDF, title could be right but not using selected font After patch 6) Apply the patch 7) Run updatedatabase.pl 8) Repeat 1-2, note new checkbox 'Oblique title', default checked 9) Repeat export, no new warnings on log 10) Create a new layout or edit an existent one, uncheck 'Oblique title', save, export again Check PDF has non slanted title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:08:59 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #10 from Jonathan Druart --- Patches rebased, conflicts with bug 14602 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:11:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:11:52 +0000 Subject: [Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys pref In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:14:09 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15018, which changed state. Bug 15018 Summary: Plack testing -- Adding Items Display - Home Library/Current Location columns missing http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:14:09 +0000 Subject: [Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec --- I can't reproduce it on the test server as well, so I'm closing with WORKSFORME status. Heather, if you have more information on it, please reopen. Maybe i just misunderstood the problem... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:23:15 +0000 Subject: [Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 --- Comment #3 from Heather Braum --- I just relooked at this particular one and either when I first tested, I didn't realize that future releases change homelibrary to permanent location and/or the items I originally added didn't have current location/permanent locations yet. It works me now, too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:39:35 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 17:39:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 15:39:35 +0000 Subject: [Koha-bugs] [Bug 15045] URLs should be built using PATH_INFO and SCRIPT_NAME In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15005 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:09:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:09:39 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christopherlawrencekirby at gm | |ail.com --- Comment #5 from Chris Kirby --- Comment on attachment 43653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43653 Bug 15039 - Move top language menu to include and streamline logic Signed off on patch. Applied patch - Verified, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verified that sysprefs opacuserlogin and EnableOpacSearchHistory did not interfere: with the lenguage menu (before, at least one of them had to be on to display the menu) - Verified that language switching works as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:09:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:09:52 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:48:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:48:12 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:51:27 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 --- Comment #9 from Tom?s Cohen Arazi --- This is only restoring previous behaviour actually. I'm not sure why we reverted it. But assuming that matching the first firstname/surname is a good relevance algorithm falls short I think. We should definitely consider moving this into fulltext search engines, because after all, using LIKEs is so inefficient... and those tools take care of this things so well... I'm not saying Zebra, we can put it on hold until ES is here, but we should thing ASAP of a better way of doing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:51:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:51:41 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:52:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:52:14 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Frido! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 18:52:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 16:52:55 +0000 Subject: [Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 19:13:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 17:13:41 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #11 from Marc V?ron --- To make it work, I had to - update the database (obvious, but not in test plan) - copy the font definitions from etc/koha-conf.xml to my own koha-conf.xml - then I had a lot of warnings like "ERROR in koha-conf.xml -- missing /path/to/font.ttf", they vanished after applying Bug 14468 - Remove warnings when creating Labels Idea for a separate bug: On the About page > System warnings we have a section about errors in koha-conf.xml, we could add there a sanity check for font definitions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 19:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 17:14:41 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14486 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 19:14:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 17:14:41 +0000 Subject: [Koha-bugs] [Bug 14486] C4/Accountlines.pm needs better documentation and removal of stale code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14486 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12194 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 19:18:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 17:18:38 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43697|0 |1 is obsolete| | --- Comment #12 from Marc V?ron --- Created attachment 43699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43699&action=edit Bug 12194 - add more tests for pdf creation When run with KEEP_PDF enviroment variable it will keep test.pdf for manual inspection. This can be used to verify that ttf font configuration is complete like: KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t sample of utf-8 text, font name and type will be on bottom of second page Followed test plan, works as expected. (See comment#11) Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 19:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 17:19:47 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43698|0 |1 is obsolete| | --- Comment #13 from Marc V?ron --- Created attachment 43700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43700&action=edit Bug 12194: Add option 'Oblique title' in labels This patch adds a checkbox on Label creator to use or not an oblique variant of main font for title Also fix font selection for title in case an oblique variant is used. To test: Before patch 1) Go to Tools > Label creator 2) Create a new layout, default values but select any 'Oblique' variant for main font and 'Biblio/Barcode' for layout type 3) Go to Manage batches, create a batch, add items, export PDF, download 4) Check logs, you must find a line with 'ERROR in koha-conf.xml -- missing ' for example if main font Courier-Oblique 5) Open PDF, title could be right but not using selected font After patch 6) Apply the patch 7) Run updatedatabase.pl 8) Repeat 1-2, note new checkbox 'Oblique title', default checked 9) Repeat export, no new warnings on log 10) Create a new layout or edit an existent one, uncheck 'Oblique title', save, export again Check PDF has non slanted title Followed test plan, works as expected. (See comment #11). Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 19:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 17:20:33 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 20:39:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 18:39:22 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #2 from Blou --- Created attachment 43701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43701&action=edit Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite the previously saved value This fixes the remaining fields from serials-edit.pl that were seeing their previously entered values be oblitarated with each new edit. The fields associated to a plugin (dateaccessioned and barcode) were always displaying with each new edit, losing the previous effort. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 22:26:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 20:26:32 +0000 Subject: [Koha-bugs] [Bug 15045] URLs should be built using PATH_INFO and SCRIPT_NAME In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 22:31:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 20:31:45 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 22:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 20:31:47 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43692|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 43702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43702&action=edit Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 23:47:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 21:47:18 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #50 from Katrin Fischer --- Is this something to worry about? $ perl t/db_dependent/Circulation/CalcFine.t 1..2 DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489. # Subtest: Test basic functionality 1..1 ok 1 - Amount is calculated correctly ok 1 - Test basic functionality # Subtest: Test cap_fine_to_replacement_price 1..1 ok 1 - Amount is calculated correctly ok 2 - Test cap_fine_to_replacement_price DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0x432c8c0), attempting ROLLBACK anyway at /home/katrin/kohaclone/t/lib/TestBuilder.pm line 363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 21 23:55:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 21:55:32 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #51 from Katrin Fischer --- I thought it was problems with the Schema first and tried to regenerate, but this shows a problem: Dumping manual schema for Koha::Schema to directory ./ ... DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in './/Koha/Schema/Result/Issuingrule.pm', the auto-generated part of the file has been modified outside of this loader. Aborting. If you want to overwrite these modifications, set the 'overwrite_modifications' loader option. Can you please put the Schema changes into a separate patch? I think it didn't like the merging when fixing the conflicts with the other bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:03:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:03:37 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #43539|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:15:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:15:28 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- This patch is needed to continue with 14247. Please sign-off asap! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:17:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:17:39 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer --- There is something wrong here - the 3 patches, even with the one I put back lack the logic in the template/pl files for the display. bumblebee:~/kohaclone (14247-newsauthor) $ git diff --stat HEAD~3 installer/data/mysql/atomicupdate/bug_14247-add_news_prefs.sql | 2 ++ installer/data/mysql/sysprefs.sql | 1 + koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref | 10 ++++++++++ t/db_dependent/NewsChannels.t | 45 ++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 57 insertions(+), 1 deletion(-) Also, the tests are not passing - I think because we are missing a dependency - "newsauthor" or bug 14246. We need this to be signed off please asap and this to be put in order. bumblebee:~/kohaclone (14247-newsauthor) $ perl t/db_dependent/NewsChannels.t 1..11 ok 1 - use C4::NewsChannels; # Category CAT1 not found, inserting # Borrower BRWR1 not found, inserting ok 2 ok 3 - Correctly failed on no parameter! ok 4 - Successfully added the first dummy news item! DBD::mysql::st execute failed: Unknown column 'borrowernumber' in 'field list' at /home/katrin/kohaclone/C4/NewsChannels.pm line 69. DBD::mysql::st execute failed: Unknown column 'borrowernumber' in 'field list' at /home/katrin/kohaclone/C4/NewsChannels.pm line 69. # Looks like you planned 11 tests but ran 4. # Looks like your test exited with 255 just after 4. Please check asap - feature slush is close!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:13 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:17 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43614|0 |1 is obsolete| | --- Comment #156 from Nick Clemens --- Created attachment 43703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43703&action=edit Bug 11559: Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib Test plan: 1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage works as expected, despite the change to pass on the fragment (...#blah) from the URL. 2. C4/Service.pm and humanmsg.js: verify that editing system preferences (the main user of these modules) works correctly despite updates. 3. svc/bib: verify that records can be correctly downloaded with the change of character set. This can be done in a Firebug/Chrome Devtools console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the results (possibly replacing 1 with a different valid biblionumber). Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:26 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43615|0 |1 is obsolete| | --- Comment #157 from Nick Clemens --- Created attachment 43704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43704&action=edit Bug 11559: New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * require - dependency resolver and module loader Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:35 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43616|0 |1 is obsolete| | --- Comment #158 from Nick Clemens --- Created attachment 43705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43705&action=edit Bug 11559: Rancor: advanced cataloging interface Full test plan is posted on bug. Test plan for system preference: 1. Apply patch, clear cookies. 2. Go to "Cataloging." 3. Add new record, verify that basic editor is used. 4. Navigate to existing record, click on "Edit record", verify that basic editor is used. 5. Inside basic editor, verify that no button appears to switch to the advanced editor. 6. Enable the "EnableAdvancedCatalogingEditor" syspref. 7. Repeat above steps, should still go to basic editor, but button should appear to switch to the advanced editor; click it. 8. Now, adding new records and editing existing records should go to the advanced editor. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:43 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43617|0 |1 is obsolete| | --- Comment #159 from Nick Clemens --- Created attachment 43706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43706&action=edit Bug 11559: (followup) Fix keyboard control bugs, make labels clickable This fixes the following issues: * Labels of search server checkboxes cannot be clicked * Quick search fields cannot be focused * Search results cannot be scrolled with a keyboard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:50 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43618|0 |1 is obsolete| | --- Comment #160 from Nick Clemens --- Created attachment 43707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43707&action=edit Bug 11559: (followup) Fill in default values, fix redirect and UNIMARC This fixes the following issues: * Help for UNIMARC tags broken * MARC21 resources loaded when in UNIMARC * Clicking on "advanced editor" in basic editor fails * Shift-Tab goes to the beginning of a fixed-field widget rather than the end Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:18:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:18:58 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43619|0 |1 is obsolete| | --- Comment #161 from Nick Clemens --- Created attachment 43708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43708&action=edit Bug 11559: (followup) Fix import bugs, display/parsing issues This fixes the following issues: * ISO2709 import fails for Unicode * Import only works with .mrc/.xml extensions * MARC21 widgets not translatable * Macro UI broken * Uppercase subfield codes forbidden * Tag with no valid subfields shows as error but tries to save Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:19:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:19:06 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43620|0 |1 is obsolete| | --- Comment #162 from Nick Clemens --- Created attachment 43709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43709&action=edit Bug 11559: (followup) Fix error when all servers are deselected Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:19:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:19:14 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43621|0 |1 is obsolete| | --- Comment #163 from Nick Clemens --- Created attachment 43710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43710&action=edit Bug 11559: (followup) Prevent saving item tags, fix other issues This fixes the following issues: * Spaces are now allowed in indicators * Shift-Enter is available to insert a newline if needed * Item tags, if present, will prevent saving (as they are not correctly processed by the backend) * biblionumber tags (999 in MARC21) will be stripped before the record is saved to Koha, to prevent their modification Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:19:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:19:22 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43622|0 |1 is obsolete| | --- Comment #164 from Nick Clemens --- Created attachment 43711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43711&action=edit Bug 11559: (QA followup) switch to new delimiter, fix minor issues This followup introduces a major change; instead of subfields starting with '$', they now start with '?'. The double-cross character can be typed with Ctrl-D. It also fixes the following: * Add UUID.pm dependency * Remove debugging call * Fix toLocaleFormat error reported by Nick Clemens * Ignore subfields that are marked as unrepeatable/mandatory AND ignored (tab is -1) * Mention lack of support for UNIMARC/NORMARC fixed fields in system preferences screen * Confirm when user creates new record and current record is modified * Perform better when importing gigantic record dump * Show "Edit" instead of "Import" and allow direct editing for local catalog records in search screen * Add "Keyboard shortcuts" help button to toolbar Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:19:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:19:29 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43623|0 |1 is obsolete| | --- Comment #165 from Nick Clemens --- Created attachment 43712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43712&action=edit Bug 11559: (followup) fix first-character deletion, small usability issues This should fix the first-character deletion bug reported by Nick, and also: * Fix subfield deletion * Attempted fix for special keys on dropdowns * Allow deleting empty fields * Fix bug with composed characters Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:34:42 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #166 from Nick Clemens --- Have been testing this as much as possible, only small notes this pass: -Composed characters behavior is better, but they still mess up indicators on import -Empty field at end doesn't delete with Ctrl+x, however, it does anywhere else and backspace does delete it -Ctrl+D doesn't add delimiter in macros (must use alt+0135) Attaching a sample record to show breaking of indicators. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:36:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:36:14 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #167 from Nick Clemens --- Created attachment 43713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43713&action=edit Record with composed character that breaks import into rancor When importing all fields after 518 containing {uml} have mangled indicators Could be another issue causing it, but that seemed to be the case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 00:51:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 22:51:19 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer --- I retested, this still has issues for me :( Trying again with a test plan, hoping someone can find out what's going on: - Created a patron list "Delete" with 2 borrowers from the sample data: Nicole Schneider - has 1 checkout Keith Hendrix - Chose Delete and checked the checkbox, no other changes - Chose "mose to trash" - Tool reports: 2 patrons have been successfully moved to trash - Nicole Schneider now exists in both borrowers and deletedborrowers The logs show: [Thu Oct 22 00:47:50.410257 2015] [cgi:error] [pid 11589] [client 127.0.0.1:36610] AH01215: [Thu Oct 22 00:47:50 2015] cleanborrowers.pl: DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at /home/katrin/kohaclone/C4/Members.pm line 1813., referer: http://localhost:8080/cgi-bin/koha/tools/cleanborrowers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:17:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:17:19 +0000 Subject: [Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512 Chris Rohde changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde at roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:11:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:11:07 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #19 from M. Tompsett --- (In reply to Katrin Fischer from comment #18) > This patch is needed to continue with 14247. Please sign-off asap! Koha Dev folks... can we sign off without Koha::Schema::Result::Opacnews being updated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:23:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:23:35 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #20 from Katrin Fischer --- Including a Schema changes is still optional I'd say, see: http://wiki.koha-community.org/wiki/Database_updates ...if you _want_ to... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:33:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:33:58 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #21 from M. Tompsett --- (In reply to Katrin Fischer from comment #20) > Including a Schema changes is still optional I'd say, see: > http://wiki.koha-community.org/wiki/Database_updates > ...if you _want_ to... I asked, because I discovered issues with AuthorisedValuesBranch and MarcModificationTemplateAction and isnullable, when I tried the koha schema building thing. Totally unrelated to this. Back to testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:40:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:40:46 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:40:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:40:49 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39521|0 |1 is obsolete| | --- Comment #22 from Nick Clemens --- Created attachment 43714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43714&action=edit Bug 14246: Add borrowernumber to koha_news This patch adds a new column to koha_news that links a borrowernumber to each item. This allows Koha to display the author for each entry which makes it suitable as a simple CMS. Changes (from rejected patch): * Added missing kohastructure.sql changes. * Turned the atomic update file into a SQL file and changed name in accordance with wiki guidelines. * Changed SQL syntax and naming to be consistent with existing code. * Attached test plan to commit message. Test plan: * You need at least one news item, log in and add one from 'Administration' -> 'Tools' -> 'News'. * Apply the patch. * Apply database upgrade (directly or indirectly). * Go back to Staff interface and post a new news item. * Use the mysql command line client to connect to the Koha installation's database: mysql -u kohaadmin -p -D koha (change username and database to values appropiate for your system). * Execute the following query: SELECT title, borrowernumber FROM opac_news; * Inspect the results, the 'borrowernumber' column should be NULL for all news items created before the patch was applied, and non-NULL for the new item created AFTER the patch was applied. Optional: Remove database changes via: ALTER TABLE opac_news DROP FOREIGN KEY borrowernumber_fk; ALTER TABLE opac_news DROP COLUMN borrowernumber; Sponsored-By: Halland County Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:41:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:41:03 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39745|0 |1 is obsolete| | --- Comment #23 from Nick Clemens --- Created attachment 43715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43715&action=edit Bug 14246: Add borrowernumber, altered SQL As suggested by kind reviewers, an AFTER statement was added to the atomic upgrade script to ensure that the final field order is consistent is both fresh and upgraded databases. Also: * UPDATE action changed to CASCADE to improve robustness. Test plan: * Apply first patch in this set. * Apply this patch. * Perform a database upgrade. * Use mysql client to inspect field order. It should be identical to the kohastructure.sql order. Sponsored-by: Halland County Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:41:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:41:11 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39747|0 |1 is obsolete| | --- Comment #24 from Nick Clemens --- Created attachment 43716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43716&action=edit Bug 14246: Update NewsChannel tests This commit adds the new 'borrowernumber' field to the existing test framework to make it pass. It does not include new tests. Sponsored-by: Halland County Library Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:41:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:41:17 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40125|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 43717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43717&action=edit (fix) correct ALTER TABLE mysql syntax Address bug 14246 comment 13 remark - correcting MySQL ALTER TABLE syntax. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:58:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:58:32 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #26 from M. Tompsett --- Created attachment 43718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43718&action=edit Bug 14246: Adding Koha::Schema::Result differences Ran misc/devel/update_dbix_class_files.pl as shown on wiki/Database_updates#updatedatabase.pl However, only git added Borrower and Opacnews, since those were the two affected by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:59:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:59:39 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43714|0 |1 is obsolete| | --- Comment #27 from M. Tompsett --- Created attachment 43719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43719&action=edit Bug 14246: Add borrowernumber to koha_news This patch adds a new column to koha_news that links a borrowernumber to each item. This allows Koha to display the author for each entry which makes it suitable as a simple CMS. Changes (from rejected patch): * Added missing kohastructure.sql changes. * Turned the atomic update file into a SQL file and changed name in accordance with wiki guidelines. * Changed SQL syntax and naming to be consistent with existing code. * Attached test plan to commit message. Test plan: * You need at least one news item, log in and add one from 'Administration' -> 'Tools' -> 'News'. * Apply the patch. * Apply database upgrade (directly or indirectly). * Go back to Staff interface and post a new news item. * Use the mysql command line client to connect to the Koha installation's database: mysql -u kohaadmin -p -D koha (change username and database to values appropiate for your system). * Execute the following query: SELECT title, borrowernumber FROM opac_news; * Inspect the results, the 'borrowernumber' column should be NULL for all news items created before the patch was applied, and non-NULL for the new item created AFTER the patch was applied. Optional: Remove database changes via: ALTER TABLE opac_news DROP FOREIGN KEY borrowernumber_fk; ALTER TABLE opac_news DROP COLUMN borrowernumber; Sponsored-By: Halland County Library Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:59:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:59:49 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43716|0 |1 is obsolete| | --- Comment #29 from M. Tompsett --- Created attachment 43721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43721&action=edit Bug 14246: Update NewsChannel tests This commit adds the new 'borrowernumber' field to the existing test framework to make it pass. It does not include new tests. Sponsored-by: Halland County Library Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:59:44 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43715|0 |1 is obsolete| | --- Comment #28 from M. Tompsett --- Created attachment 43720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43720&action=edit Bug 14246: Add borrowernumber, altered SQL As suggested by kind reviewers, an AFTER statement was added to the atomic upgrade script to ensure that the final field order is consistent is both fresh and upgraded databases. Also: * UPDATE action changed to CASCADE to improve robustness. Test plan: * Apply first patch in this set. * Apply this patch. * Perform a database upgrade. * Use mysql client to inspect field order. It should be identical to the kohastructure.sql order. Sponsored-by: Halland County Library Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:59:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:59:54 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43717|0 |1 is obsolete| | --- Comment #30 from M. Tompsett --- Created attachment 43722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43722&action=edit (fix) correct ALTER TABLE mysql syntax Address bug 14246 comment 13 remark - correcting MySQL ALTER TABLE syntax. Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 01:59:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 21 Oct 2015 23:59:59 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43718|0 |1 is obsolete| | --- Comment #31 from M. Tompsett --- Created attachment 43723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43723&action=edit Bug 14246: Adding Koha::Schema::Result differences Ran misc/devel/update_dbix_class_files.pl as shown on wiki/Database_updates#updatedatabase.pl However, only git added Borrower and Opacnews, since those were the two affected by this patch. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:05:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:05:54 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #32 from M. Tompsett --- I tested: - Cascading when a borrower is deleted, the borrowernumber is set to NULL. - Adding is the only time a borrowernumber is set. - t/db_dependent/NewsChannels.t A couple remarks: - I don't like diags added in the tests. - I would have gone further and allowed setting and changing the borrower number, but I think that is beyond scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:09:35 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43539|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Comment on attachment 43539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43539 Bug 14246: Update NewsChannel tests This patch is identical to the one on bug 14246. Since we know that this bug depends on it, there is no need to include it here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:26:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:26:34 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #25 from M. Tompsett --- Created attachment 43724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43724&action=edit Bug 14247: Add system preference for news display Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql NOTE: Adds and allows changes, but no apparent change in OPAC. Signed-off-by: Marc V?ron Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:26:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:26:43 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43543|0 |1 is obsolete| | --- Comment #26 from M. Tompsett --- Created attachment 43725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43725&action=edit Bug 14247: Rename sysprefs atomic update file This trivial patch changes the name of the SQL update file to match the guidelines on the wiki. Sponsored-by: Halland County Library Signed-off-by: Marc V?ron Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:27:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:27:53 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:36:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:36:17 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #14 from M. Tompsett --- (In reply to Jonathan Druart from comment #6) > Martin, > > Actually the 3 patches (from bug 14246 and 14247) could have been attached > to this bug report. No need to open 3 bug reports for 1 enh :) I agree. However, 14246 and 14247 are passable in my opinion. This one is not. > I have some remarks concerning this patch: > 1/ You add changes to a module file, in most of the cases, you have to > provide tests to make sure there won't be regression later. > Here you have to test C4::NewsChannels::get_opac_news, have a look at > t/db_dependent/NewsChannels.t There are no tests added. Suggestion: test to see that the title, firstname, and surname keys exist in at least the first row of results. This is why I'm leaving it failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:36:49 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 02:38:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 00:38:48 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:18:39 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:20:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:20:09 +0000 Subject: [Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:21:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:21:09 +0000 Subject: [Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:22:18 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13217 CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:22:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:22:18 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:22:50 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13217 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:22:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:22:50 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15012 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:44:54 +0000 Subject: [Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:44:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:44:54 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13216 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:54:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:54:04 +0000 Subject: [Koha-bugs] [Bug 15047] New: Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Bug ID: 15047 Summary: Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org Created attachment 43726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43726&action=edit pix, before patch pix attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:54:11 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:54:13 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43402|0 |1 is obsolete| | --- Comment #6 from Robin Sheat --- Created attachment 43727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43727&action=edit Bug 15012: use sudo instead of su in koha-shell Not sure this is the best way to fix it but it looks to work. Test plan: sudo koha-shell kohadev should not return any error Without this patch, you should get bash: cannot set terminal process group (-1): Inappropriate ioctl for device bash: no job control in this shell Confirm that other options work as before Signed-off-by: Tomas Cohen Arazi Works as expected. Tested on kohadevbox:ansible. KOHA_CONF and PERL5LIB are correctly set on the child shell. Bonus point: koha-shell doesn't die if the user issues Ctrl+C to abort an execution. Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:54:32 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13433 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 [Bug 13433] 655 display in XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 04:54:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 02:54:32 +0000 Subject: [Koha-bugs] [Bug 13433] 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13433 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15047 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:02:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:02:11 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #1 from Mason James --- Created attachment 43728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43728&action=edit Bug 15047 - Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled to test... 1/ create a 655$a subfield in a bib, with some general info - save bib 2/ view bib in opac-detail.pl - confim genre/form is displayed, but non-clickable :/ 3/ apply patch 4/ confim genre/form is displayed, and *is* clickable :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:04:48 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #2 from Mason James --- Created attachment 43729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43729&action=edit pic, after patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:04:57 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:05:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:05:06 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:14:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:14:36 +0000 Subject: [Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi --- I'd like to say that gitified instance issues should be handled outside Koha... With that in mind, I'd say the best approach to this is to make the scripts (all of them?) - Test for PERL5LIB be defined (so we can make koha-gitify wrap things or... we'll solve it) - Otherwise fallback to the system-wide one that is set in /etc/default/koha-common So maintenance scripts should do something like this: # include helper functions if [ -f "/usr/share/koha/bin/koha-functions.sh" ]; then . "/usr/share/koha/bin/koha-functions.sh" else echo "Error: /usr/share/koha/bin/koha-functions.sh not present." 1>&2 exit 1 fi Ok, most of them do it already. And then add to koha-functions.sh the check+read: if [ ! -z $PERL5LIB ]; then CLI_PERL5LIB=$PERL5LIB fi if [ -r /etc/default/$NAME ]; then # Debian / Ubuntu . /etc/default/$NAME elif [ -r /etc/sysconfig/$NAME ]; then # RedHat / SuSE . /etc/sysconfig/$NAME fi if [ ! -z $CLI_PERL5LIB ]; then PERL5LIB=$CLI_PERL5LIB fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:18:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:18:58 +0000 Subject: [Koha-bugs] [Bug 15048] New: subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Bug ID: 15048 Summary: subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:19:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:19:16 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15047 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 05:19:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 03:19:16 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15048 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 07:33:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 05:33:48 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Mark, thx for clearing this up - I see now how the 3 patches go together. I think all we are missing is the tests asked for on this bug report. Martin - small steps are great - this just went a little too far :) It would have been ok to do the database changes and the feature in one go in this case, as this is a nice contained feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:10:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:10:53 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #12 from Katrin Fischer --- Created attachment 43730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43730&action=edit [PASSED QA] Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:11:04 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #13 from Katrin Fischer --- Created attachment 43731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43731&action=edit [PASSED QA] Bug 14788: Add unit tests for GetTopIssues Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:11:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:11:23 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:11:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:11:25 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:11:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:11:27 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:12:42 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #14 from Katrin Fischer --- I think this is an improvement over the current code, but needs to be pushed together with bug 11139 that will actually make it work nicely :) If you add multiple values in AdvancedSearchTypes with only this patch, it doesn't work quite right yet - but tested with 11139 things look alright. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:13:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:13:02 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #18 from Katrin Fischer --- Created attachment 43732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43732&action=edit [PASSED QA] Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 Tested on top of 14788. Works as expected. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:13:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:13:34 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:13:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:13:36 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:28:11 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #103 from Katrin Fischer --- Patch doesn't apply - please fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:50:36 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 --- Comment #72 from Marcel de Rooy --- (In reply to Tom?s Cohen Arazi from comment #70) > The introduced syspref was defined before we added new guidelines > for them. Where can we find those guidelines btw ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 08:53:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 06:53:15 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #29 from Martin Renvoize --- A further enhancement I'd love to see is multiple directories. The was initially designed as a way to expose log files, and it shows. It's fast turning into a more generic solution for exposing notices, logs, whatever... but putting notices under a tool called 'reports' and combining files with different purposes into one directory both make little sense.. I'm thinking along the lines of a config block of the form: This would yield a much more comprehensive and viable feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:30:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:30:17 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:30:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:30:23 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43269|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 43733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43733&action=edit Bug 14981: Remove ethnicity occurrences from sample patrons file Bug 10020 has removed these columns, the should be removed from the patron sample file. Test plan: Insert the files updated by this patch into a fresh DB, you shouldn't get any error. Signed-off-by: Frederic Demians Before applying the patch, I was able to notice the error when loading the patron sample SQL file to a DB. With the patch, it's solved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:35:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:35:29 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #33 from Marc V?ron --- (In reply to M. Tompsett from comment #32) (...) > - I would have gone further and allowed > setting and changing the borrower number, but I think that is beyond scope. I look forward to see that as well - in a new Bug on top of and as enhancement to this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:41:24 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:41:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:41:27 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43593|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 43734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43734&action=edit Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools Signed-off-by: Frederic Demians This typo patch could hit the highway to master at high speeds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:47:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:47:14 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:47:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:47:16 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43734|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 43735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43735&action=edit Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools Signed-off-by: Frederic Demians This typo patch could hit the highway to master at high speeds. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:48:13 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43735|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 43736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43736&action=edit Bug 15027: Correct Type in C4::Items perldoc As noted in the bug report, there is a typo. This corrects that typo in documentation. TEST PLAN --------- 1) perldoc C4::Items 2) Find GetItemsForInventory -- note that status is spelt incorrectly. 3) Apply patch 4) repeat steps 1-2 -- note that status is spelt correctly now. 5) git diff origin/master -- note only that line changed. 6) run koha qa tools Signed-off-by: Frederic Demians This typo patch could hit the highway to master at high speeds. Signed-off-by: Jonathan Druart Amended patch: add a comma at the end of the line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:48:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:48:41 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:58:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:58:30 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:58:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:58:33 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43699|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 43737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43737&action=edit Bug 12194 - add more tests for pdf creation When run with KEEP_PDF enviroment variable it will keep test.pdf for manual inspection. This can be used to verify that ttf font configuration is complete like: KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t sample of utf-8 text, font name and type will be on bottom of second page Followed test plan, works as expected. (See comment#11) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:58:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:58:36 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43700|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 43738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43738&action=edit Bug 12194: Add option 'Oblique title' in labels This patch adds a checkbox on Label creator to use or not an oblique variant of main font for title Also fix font selection for title in case an oblique variant is used. To test: Before patch 1) Go to Tools > Label creator 2) Create a new layout, default values but select any 'Oblique' variant for main font and 'Biblio/Barcode' for layout type 3) Go to Manage batches, create a batch, add items, export PDF, download 4) Check logs, you must find a line with 'ERROR in koha-conf.xml -- missing ' for example if main font Courier-Oblique 5) Open PDF, title could be right but not using selected font After patch 6) Apply the patch 7) Run updatedatabase.pl 8) Repeat 1-2, note new checkbox 'Oblique title', default checked 9) Repeat export, no new warnings on log 10) Create a new layout or edit an existent one, uncheck 'Oblique title', save, export again Check PDF has non slanted title Followed test plan, works as expected. (See comment #11). Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:58:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:58:40 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #16 from Jonathan Druart --- Created attachment 43739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43739&action=edit Bug 12194: Add change to kohastructure.sql Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 09:59:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 07:59:04 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #17 from Jonathan Druart --- Created attachment 43740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43740&action=edit :x Bug 12194: fix label for oblique_title Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:06:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:06:09 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43684|0 |1 is obsolete| | --- Comment #6 from Marc V?ron --- Created attachment 43741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43741&action=edit Bug 15042 - Barcode hbyymmincr does not work when receiving serials To test: - Set autoBarcode = yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens - Apply patch and reload page - Receive an issue - Click in the barcode field - a barcode conforming to the hbyymmincr setting appears Patch works as advertised. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:06:44 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:08:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:08:03 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #76 from Jonathan Druart --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:11:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:11:05 +0000 Subject: [Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409 --- Comment #15 from Olli-Antti Kivilahti --- No. I think everybody is really pissed off :) But I guess we first need to get really pissed and then start thinking on how we can improve ourselves/statuq quo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:21:19 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:21:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:21:22 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43653|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 43742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43742&action=edit Bug 15039 - Move top language menu to include and streamline logic The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is used at other places as well (see Bug 14776). This patch moves it to a file masthead-langmenu.inc to make it re-usable. Additionally it streamlines the logic (not all combinations of Opac sysprefs that should display the menu did so). To test: - Apply patch - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verify that sysprefs opacuserlogin and EnableOpacSearchHistory do not interfere with the lenguage menu (before, at least one of them had to be on to display the menu) - Verify that language switching works as before. Signed-off-by: Chris Kirby Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:36:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:36:35 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:36:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:36:38 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43741|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 43743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43743&action=edit Bug 15042 - Barcode hbyymmincr does not work when receiving serials To test: - Set autoBarcode = yymm0001 - Make sure you have a serial that is set to "create an item record when receiving this serial" - Receive an issue - Click in the barcode field - nothing happens - Apply patch and reload page - Receive an issue - Click in the barcode field - a barcode conforming to the hbyymmincr setting appears Patch works as advertised. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:37:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:37:26 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Not sure it's a major one, but definitely annoying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 10:59:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 08:59:50 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #168 from Jonathan Druart --- Jesse, new problem found (sorry): Search for a term which will return several pages of results, then search for something which will return only 1 page of results. The pagination buttons are still there. The problem with the double-cross chars is that it's not directly accessible, except if you now the shortcut. I don't have a strong opinion on it, but would like to get other QAer opinions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:06:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:06:01 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart --- Nicolas, This is the very old fashion way to do. I am rewriting all the admin scripts not make them use Koha::Objects, so I am strongly against pushing this one as it. See bug 10363, bug 14828, bug 14836, bug 14888 and bug 14889 for examples. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:32:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:32:46 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #18 from Nicolas Legrand --- ok, I'll check that, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:36:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:36:48 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Jonathan Druart --- CONFLICT (content): Merge conflict in t/db_dependent/Hold.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:43:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:43:55 +0000 Subject: [Koha-bugs] [Bug 15049] New: Add warning about "No active currency" to Acquisitions start page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bug ID: 15049 Summary: Add warning about "No active currency" to Acquisitions start page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org If no active currency is defined, Acquisitions dose not work properly and there can occur software errors while receiving. This patch adds the warning about missing active currency to Home > Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:46:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:46:50 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- QA comments: 1/ New subroutines have to be covered by tests 2/ You should provide the related change for opac.less Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:49:38 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #1 from Marc V?ron --- Created attachment 43744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43744&action=edit Bug 15049 - Add warning about "No active currency" to Acquisitions start page If no active currency is defined, Acquisitions dose not work properly and there can occur software errors while receiving. This patch adds the warning about missing active currency to Home > Acquisitions To test: - Apply patch - Go to Home > Administration > Currencies & Exchange Rates > Currencies - Make sure that no active currency is set - Go to Home > Acquisitions - Verify that a warning displays - Set an active currency - Veryfy that warning no longer displays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 11:50:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 09:50:41 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:10:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:10:51 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- # Looks like you failed 5 tests of 12. t/db_dependent/DecreaseLoanHighHolds.t .. Dubious, test returned 5 (wstat 1280, 0x500) Failed 5/12 subtests You should also change the descriptions of the tests to make them unique. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:11:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:11:24 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:12:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:12:47 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #42 from Jonathan Druart --- And what about comment 40? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:40:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:40:41 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:40:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:40:44 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43688|0 |1 is obsolete| | Attachment #43689|0 |1 is obsolete| | --- Comment #52 from Kyle M Hall --- Created attachment 43745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43745&action=edit Bug 9129 - Update database Signed-off-by: Cindy Murdock Ames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:41:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:41:00 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #53 from Kyle M Hall --- Created attachment 43746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43746&action=edit Bug 9129 - Update schema Signed-off-by: Cindy Murdock Ames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 12:41:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 10:41:03 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #54 from Kyle M Hall --- Created attachment 43747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43747&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:00:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:00:29 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:00:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:00:32 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42657|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart --- Created attachment 43748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43748&action=edit Bug 11250 - "too many holds" message appears inappropriately This patch gives the various reasons precedence in this order: 1) Already in possesion 2) Already on hold 3) Age restricted 4) No items available 5) Too many holds Test Plan: 1) Attempt to place a hold where both "too many holds" and "no items available" messages display 2) Apply this patch 3) Refresh 4) Note only the "no items available" message displays Signed-off-by: Heather Braum Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:01:04 +0000 Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:01:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:01:08 +0000 Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42936|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 43749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43749&action=edit Bug 12197: enforce the maxreserves preference when staff members place hold requests This patch ensures that the global maxreserves preference is enforced when staff members place hold requests. For example: Create 3 items to place holds on. Set the circulation rule to allow 50 holds for all items. Set maxreserves to 2. Place a hold on 3 different items. On the third item, it will give a warning, but you can still place the hold. Despite what the circulation rule is set for (which is only a specific case rule), maxreserves is a global rule and should stop this from happening, not just give a warning. Test Plan: 1) Reproduce the bug by following the steps above 2) Verify the bug exists 3) Apply this patch 4) Verify the librarian cannot place the hold now 5) Enable AllowHoldPolicyOverride 6) Verify the librarian can forcefully place the hold Signed-off-by: Galen Charlton Bug 12197: (follow-up) rename variable for greater clarity "maxreserves" was referring both to the system preference and to the condition of having exceeded the number of hold requests allowed. This patch renames a variable to remove the ambguity. Test plan: * Same as the main patch. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:09:09 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #34 from Jonathan Druart --- Waiting for bug 14248. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:09:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:09:16 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #27 from Jonathan Druart --- Waiting for bug 14248. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:17:09 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:17:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:17:11 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43649|0 |1 is obsolete| | Attachment #43650|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 43750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43750&action=edit [PASSED QA] Bug 8436: QA Follow-up: Activate branch filter, if IndependentBranches is off The superserials permission is only in use in combination with IndependentBranches - so it makes sense to also show the branch filter when IndependentBranches is off. Permission description: superserials Manage subscriptions from any branch (only applies when IndependentBranches is used) Also adds a missing check for superlibraian. Note: the duplicated permission check in the code is not really nice - would be good to rewrite this to be more clean. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:17:21 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 --- Comment #26 from Kyle M Hall --- Created attachment 43751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43751&action=edit [PASSED QA] Bug 8436: QA Follow-up: Add Library to result list If we offer a library filter, we should also show the library in the result list, so that search options and result list match. Otherwise, for libraries with multiple branches, there is no way to see, which is the subscription of a specific branch in the list. - Add a Library column in the result list - Rename branch to library in the template Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 13:54:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 11:54:03 +0000 Subject: [Koha-bugs] [Bug 15050] New: Nonpublic note searchable from OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 Bug ID: 15050 Summary: Nonpublic note searchable from OPAC Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Text in the Nonpublic note can be found via OPAC. The text is not displayed, but if you know what you are looking for, you still get the information. Found in 3.20, I assume it is still valid in master. Bug 13023 does not fix it. To reproduce, put something unique in an item's nonpublic note. Re-index. Search from the OPAC -> you will find the title your item belongs to. Delete the nonpublic note and reindex, you can't find it anymore. Don't know if this qualifies as a security risk. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:12:34 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #13 from Kyle M Hall --- Created attachment 43752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43752&action=edit Bug 14694 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:24:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:24:35 +0000 Subject: [Koha-bugs] [Bug 14994] Add RSS/Atom feed proxy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14994 --- Comment #3 from Martin Persson --- For a working example which puts the first three posts from two separate Atom feeds on the OPAC front page via jQuery, add this code to the system preferences. It is used with the example URLs used in the test plan: URL1: http://hyltebiblioteken.blogspot.se/feeds/posts/default URL2: http://bokbastisarna.blogspot.com/feeds/posts/default OpacNavRight ============
Rubriker fr?n bloggen
    Laddar inneh?ll fr?n bloggen. Detta kr?ver Javascript aktiverat i din webbl?sare.
    Bokb?stisarna
      Laddar inneh?ll fr?n bloggen. Detta kr?ver Javascript aktiverat i din webbl?sare.
      ============ OPACUserJS ========== $('#bloggen').ready(function() { var url = 'http://127.0.1.1/cgi-bin/koha/opac-proxy.pl?id=1'; $.ajax(url, { dataType: 'xml', success: function(xmldata) { var item_html = ''; var xml = $(xmldata).find('entry').slice(0,3).each(function(index, value) { var title = $(this).children('title'); var link = $(this).children('link'); item_html += '
    • ' + title.text() + "
      • \n"; }); $('#bloggen div.loading').fadeOut('slow', function () { $(this).html(item_html); $(this).slideDown('slow'); }); } }); }); $('#bokbastisarna').ready(function() { var url = 'http://127.0.1.1/cgi-bin/koha/opac-proxy.pl?id=2'; $.ajax(url, { dataType: 'xml', success: function(xmldata) { var item_html = ''; var xml = $(xmldata).find('entry').slice(0,3).each(function(index, value) { var title = $(this).children('title'); var link = $(this).children('link'); item_html += '
    • ' + title.text() + "
      • \n"; }); $('#bokbastisarna div.loading').fadeOut('slow', function () { $(this).html(item_html); $(this).slideDown('slow'); }); } }); }); ========== These examples are in Swedish, based on real-life usage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:41:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:41:45 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #16 from Martin Persson --- Yes, thanks. This was the first ticket I created of any complexity and it got messy. I am sorry, I have since learned. I am now starting to complement it to have it pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:43:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:43:11 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:25 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:29 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42678|0 |1 is obsolete| | Attachment #42679|0 |1 is obsolete| | Attachment #42680|0 |1 is obsolete| | Attachment #42681|0 |1 is obsolete| | Attachment #42682|0 |1 is obsolete| | Attachment #42683|0 |1 is obsolete| | Attachment #42684|0 |1 is obsolete| | Attachment #42685|0 |1 is obsolete| | Attachment #42686|0 |1 is obsolete| | Attachment #42687|0 |1 is obsolete| | Attachment #42688|0 |1 is obsolete| | Attachment #42689|0 |1 is obsolete| | Attachment #42696|0 |1 is obsolete| | --- Comment #104 from Kyle M Hall --- Created attachment 43753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43753&action=edit Bug 11431 [1] - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:38 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #105 from Kyle M Hall --- Created attachment 43754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43754&action=edit Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:41 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #106 from Kyle M Hall --- Created attachment 43755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43755&action=edit Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:45 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #107 from Kyle M Hall --- Created attachment 43756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43756&action=edit Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:49 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #108 from Kyle M Hall --- Created attachment 43757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43757&action=edit Bug 11431 [QA Followup] - Allow https in sound URLs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:53 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #109 from Kyle M Hall --- Created attachment 43758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43758&action=edit Bug 11431 [QA Followup] - Fix POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:44:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:44:56 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #110 from Kyle M Hall --- Created attachment 43759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43759&action=edit Bug 11431 - Update UsageStats.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:45:00 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #111 from Kyle M Hall --- Created attachment 43760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43760&action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:45:04 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #112 from Kyle M Hall --- Created attachment 43761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43761&action=edit Bug 11431 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:45:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:45:08 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #113 from Kyle M Hall --- Created attachment 43762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43762&action=edit Bug 11431 [QA Followup] - Simplify audio_alert_id to just id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:45:12 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #114 from Kyle M Hall --- Created attachment 43763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43763&action=edit Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:45:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:45:15 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #115 from Kyle M Hall --- Created attachment 43764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43764&action=edit Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:45:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:45:19 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #116 from Kyle M Hall --- Created attachment 43765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43765&action=edit Bug 11431 [QA Followup] - Fix alter precedences on delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:54:13 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 14:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 12:54:15 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #17 from M. Tompsett --- Created attachment 43766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43766&action=edit Bug 14248: Regression tests requested TEST PLAN --------- 1) apply patch 2) prove -v t/db_dependent/NewsChannels.t 3) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:04:44 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #14 from Jonathan Druart --- Comment on attachment 43598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43598 [SIGNED-OFF] Bug 14694 - Make decreaseloanHighHolds more flexible Review of attachment 43598: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14694&attachment=43598) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1189,5 @@ > + > + # static means just more than a given number of holds on the record > + > + # If the number of holds is less than the threshold, we can stop here > + if ( $holds->count() < $decreaseLoanHighHoldsValue ) { Just looking at the code, something smells wrong here. There is a strict comparison here. @@ +1214,5 @@ > + my $threshold = $items_count + $decreaseLoanHighHoldsValue; > + > + # If the number of holds is less than the count of items we have > + # plus the number of holds allowed above that count, we can stop here > + if ( $holds->count() <= $threshold ) { And an inclusive here. ::: Koha/Biblio.pm @@ +41,5 @@ > +or list of Koha::Item objects in list context. > + > +=cut > + > +sub items { Wouldn't be better to use a DBIx::Class relation? Something like bug 14819. ::: installer/data/mysql/sysprefs.sql @@ +103,3 @@ > ('decreaseLoanHighHoldsDuration',NULL,'','Specifies a number of days that a loan is reduced to when used in conjunction with decreaseLoanHighHolds','Integer'), > ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum number of holds needed to trigger a reduction in loan duration (used with decreaseLoanHighHolds)','Integer'), > +('decreaseLoanHighHoldsIgnoreStatuses', '', 'damaged|itemlost|notforloan|withdrawn', "Ignore items with these statuses for dynamic high holds checking", 'Choice'), Wrongly placed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:05:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:05:35 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #15 from Jonathan Druart --- Comment on attachment 43752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43752 Bug 14694 [QA Followup] - Fix unit tests Review of attachment 43752: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14694&attachment=43752) ----------------------------------------------------------------- ::: t/db_dependent/DecreaseLoanHighHolds.t @@ +92,5 @@ > my $patron_hr = { borrower => $patron->id, branchcode => 'MPL' }; > > my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr ); > +is( $data->{exceeded}, 1, "Static mode should exceed threshold" ); > +is( $data->{outstanding}, 6, "Should have 5 outstanding holds" ); 6 vs 5 @@ +123,5 @@ > $unholdable->damaged(-1); > $unholdable->store(); > > $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr ); > +is( $data->{exceeded}, 1, "Should exceed threshold with one damanged item" ); typo damaged @@ +137,5 @@ > $unholdable->notforloan(-1); > $unholdable->store(); > > $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr ); > +is( $data->{exceeded}, 1, "Should exceed threshold wiht one notforloan item" ); typo with vs with -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:05:42 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:22:07 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13517 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 [Bug 13517] Show waiting date on reserve/request.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:22:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:22:07 +0000 Subject: [Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14310 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:23:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:23:52 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #15 from Kyle M Hall --- Not getting any merge conflicts. Did you apply 13517 and 13918 first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:24:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:24:54 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #3 from Winona Salesky --- Created attachment 43767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43767&action=edit Bug 15047 - 655 URL not clickable in opac-detail. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 655 4) Perform an opac search and select records with 655 field, select record and review details page. 5) Check that 655 field is clickable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:29:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:29:07 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #16 from Kyle M Hall --- Created attachment 43768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43768&action=edit Bug 14694 [QA Followup] - Fix typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:31:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:31:27 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #17 from Kyle M Hall --- > ::: t/db_dependent/DecreaseLoanHighHolds.t > @@ +92,5 @@ > > my $patron_hr = { borrower => $patron->id, branchcode => 'MPL' }; > > > > my $data = C4::Circulation::checkHighHolds( $item_hr, $patron_hr ); > > +is( $data->{exceeded}, 1, "Static mode should exceed threshold" ); > > +is( $data->{outstanding}, 6, "Should have 5 outstanding holds" ); > > 6 vs 5 That is a purposeful change. The issue was that the logic of the unit test was off by one. The assumption was that the number of holds must greater than or equal to, but as per the code and sys pref definition, the number of holds must be simply greater than. Thus adding one more hold fixes all the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:31:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:31:34 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:48:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:48:07 +0000 Subject: [Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #20 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:48:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:48:35 +0000 Subject: [Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #21 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:48:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:48:59 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:49:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:49:42 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Dobrica, Bernardo and Joanthan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 15:50:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 13:50:06 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 16:30:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 14:30:12 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Martin Persson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43766|0 |1 is obsolete| | --- Comment #18 from Martin Persson --- Created attachment 43769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43769&action=edit Bug 14248: Regression tests requested TEST PLAN --------- 1) apply patch 2) prove -v t/db_dependent/NewsChannels.t 3) run koha qa test tools. Signed-off-by: Martin Persson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 16:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 14:31:31 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #19 from Martin Persson --- Not sure if it is enough to sign off on tests for my own code made by a third party, but there you go. Not touching status. All tests passes on a clean test system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 16:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 14:32:50 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Katrin Fischer --- If you are ok with the tests, signing them off is perfectly fine. Just important you don't sign your own things :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 16:43:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 14:43:48 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #4 from Martin Stenberg --- Created attachment 43770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43770&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 16:44:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 14:44:01 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #5 from Martin Stenberg --- Created attachment 43771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43771&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:01:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:01:40 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #65 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Ahmed and Philippe! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:02:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:02:07 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- Patches pushed to master. Good job Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:02:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:02:35 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Maurice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:03:04 +0000 Subject: [Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:28:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:28:00 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Karl Holten changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:41:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:41:02 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #9 from Chris Kirby --- Hi Marc, I am testing here on Sandbox 8, and here is what I am finding: testing with AutoSelfCheckAllowed DISABLED: when one visits /cgi-bin/koha/sco/sco-main.pl there is an option to login. However, once logged in, you are redirected to /cgi-bin/koha/opac-user.pl If one has already logged into Koha with staff credentials, and then visits /cgi-bin/koha/sco/sco-main.pl, the patch is successful. testing with AutoSelfCheckAllowed ENABLED: Your patch works when the AutoSelfCheckAllowed preference is enabled and login credentials have been stored. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:44:03 +0000 Subject: [Koha-bugs] [Bug 15051] New: 245 Marc Field Order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 Bug ID: 15051 Summary: 245 Marc Field Order Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 13381 I have been informed that per marc rules the 245 should display the following subfields in this order: a, n, p, h, b, c Right now we're showing them in a, b, c, k, n, p, s I am unsure of where k and s fit in the scheme of things, but I thought I'd bring this up to discussion and/or fixing. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 [Bug 13381] RDA: 245 field changes in XSLT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:44:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:44:03 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15051 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 [Bug 15051] 245 Marc Field Order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:44:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:44:30 +0000 Subject: [Koha-bugs] [Bug 15051] 245 Marc Field Order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:59:31 +0000 Subject: [Koha-bugs] [Bug 13384] RDA: 655 display in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED --- Comment #3 from Nicole C. Engard --- On discussing this we have decided we don't need this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 17:59:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 15:59:31 +0000 Subject: [Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Bug 10344 depends on bug 13384, which changed state. Bug 13384 Summary: RDA: 655 display in XSLT http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 18:29:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 16:29:57 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi --- Comment #36 from Olli-Antti Kivilahti --- What a great idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 18:48:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 16:48:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #169 from Nicole C. Engard --- (In reply to Jonathan Druart from comment #168) > The problem with the double-cross chars is that it's not directly > accessible, except if you now the shortcut. I don't have a strong opinion on > it, but would like to get other QAer opinions. I think having the keyboard shortcuts button right there at the top makes it pretty darn easy. Also I will of course document it in the manual. That's about all we can do if we're not going to use the $ . Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 18:48:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 16:48:38 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #170 from Nicole C. Engard --- Created attachment 43772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43772&action=edit shortcuts image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 19:08:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 17:08:15 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 43773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43773&action=edit Bug 14333: Update MARC21 frameworks to Update No. 20 and 21 Default frameworks updated to update 20 (April 2015) and 21 (September 2015) Update No. 20 Bibliographic New field 884 New subfields 037$3, 037$5 and 382$e Authority New field 884 New subfields 046$q, 046$r and 382$e Update No. 21 Bibliographic New tag 348 New subfields 336$0, 337$0 and 338$0 Authority New field 348 New sufields 336$0 and 670$w To test: 1) Remove all your frameworks 2) Check mandatory bibliographic and authority files load without problem 3) Check new fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 19:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 17:08:20 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 43774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43774&action=edit Bug 14333: followup - Fix labels This patch fixes same labels on bibliographic and authority frameworks, and one typo. To test: 1) Remove all your frameworks 2) Check mandatory bibliographic and authority files load without problem 3) Check fixed labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 19:08:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 17:08:49 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update MARC21 frameworks to |Update MARC21 frameworks to |Update No. 20 (April 2015) |Update No. 20 (April 2015) | |and 21 (September 2015) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 19:09:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 17:09:57 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Bernardo Gonzalez Kriegel --- One patch with cumulative changes from update 20 and 21 Other with label fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 19:12:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 17:12:59 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:02:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:02:10 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #19 from Tom?s Cohen Arazi --- Patch authors: please check that tests are failing due to this patchset: prove t/db_dependent/Labels/* Might not be the only tests failing, so please check jenkins (D7 is fine) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:09:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:09:31 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42846|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 43775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43775&action=edit [SIGNED-OFF] Bug 14889: Add Koha::BiblioFramework[s] classes Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:09:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:09:40 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42847|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 43776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43776&action=edit [SIGNED-OFF] Bug 14889: Use Koha::BiblioFramework[s] in admin/biblio_framework.pl Test plan: Add/edit/remove biblio frameworks from the administration module (admin/biblio_framework.pl). You should get message feedback after each action. Signed-off-by: Bernardo Gonzalez Kriegel No problems found. Tested add/edit/delete No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:10:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:10:02 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:32:50 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #43 from Kyle M Hall --- Created attachment 43777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43777&action=edit Bug 7560 [QA Followup] - Fix string name conflict, add screen message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:32:50 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 43778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43778&action=edit Bug 12194: followup to fix test This patch adds new column 'oblique_title' to tested data structure, and update number of tests To test: 1) Run prove t/db_dependent/Labels/*, or specifically prove t/db_dependent/Labels/t_Layout.t It fails 2) apply the patch 3) Run test again, this time must pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:33:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:33:47 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:33:53 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:34:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:34:37 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:34:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:34:59 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #21 from Bernardo Gonzalez Kriegel --- Added followup, needs revision i think, so changed to Needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:41:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:41:10 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #35 from Kyle M Hall --- Created attachment 43779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43779&action=edit Bug 12803 [QA Followup] - Fix koha-qa.pl errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 20:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 18:42:32 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Kyle M Hall --- > % prove t/db_dependent/HoldsQueue.t > t/db_dependent/HoldsQueue.t .. 13/24 > # Failed test 'Holds not filled with items from closed libraries' > # at t/db_dependent/HoldsQueue.t line 327. > # got: '1' > # expected: '2' > # Looks like you failed 1 test of 24. > t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/24 subtests > > Test Summary Report > ------------------- > t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 24 Failed: 1) > Failed test: 23 > Non-zero exit status: 1 > Files=1, Tests=24, 3 wallclock secs ( 0.04 usr 0.00 sys + 1.76 cusr 0.06 > csys = 1.86 CPU) > Result: FAIL So far I have been completely unable to reproduce this failure using my test database or a fresh Koha db with all the sample data. Have you tested it with a fresh sample data database? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 21:15:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 19:15:12 +0000 Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42549|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 43780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43780&action=edit Bug 14824 - Fix sorting of Norwegian vowels Currently, Norwegian vowels are not sorted correctly, even when you have chosen "nb" as the ZEBRA_LANGUAGE during installation. To test: - Make sure you have three records with titles that begin with ??? respectively - Do a search that turns up those three records and some others, and sort the results by title, bot ascending and descending. - Verify that ??? is shown in some weird order. - Edit your sort-string-utf.chr* so it is in line with the current patch. It should include these two lines: lowercase {0-9}{a-z}??? uppercase {0-9}{A-Z}??? - Restart Zebra and reindex all the records, e.g.: $?sudo koha-restart-zebra $?sudo koha-rebuild-zebra -f -v - Do the search again, make sure you order by title and check that ??? are sorted in the order of 1. ? 2. ? 3. ?, and after all other characters * = If you are on a gitified install, you need to edit this file: /etc/koha/zebradb/lang_defs//sort-string-utf.chr NOT the file in your git clone (yeah, i wasted some time there...) Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 21:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 19:15:33 +0000 Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 21:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 19:44:16 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12426 CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- This functionality could be in conflict with: Bug 12426 - Allow resending of emails from the notices tab in the patron account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 21:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 19:44:16 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14964 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 21:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 19:46:33 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #32 from Katrin Fischer --- Would be really nice to see a sign-off for this asap! Please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:00:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:00:22 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #10 from Marc V?ron --- Hi Chris, Thanks for testing. Questions: - How is the behaviour without patch? It seems to me that it behaves the same (redirect to a login page). - What would you expect to happen if AutoSelfCheckAllowed is DISABLED? - Maybe your finding is something for a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:16:53 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #55 from Katrin Fischer --- Created attachment 43781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43781&action=edit [PASSED QA] Bug 9129 - Update database Signed-off-by: Cindy Murdock Ames Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:17:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:17:17 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43781|0 |1 is obsolete| | --- Comment #56 from Katrin Fischer --- Created attachment 43782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43782&action=edit [PASSED QA] Bug 9129 - Update database Signed-off-by: Cindy Murdock Ames Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:17:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:17:21 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #57 from Katrin Fischer --- Created attachment 43783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43783&action=edit [PASSED QA] Bug 9129 - Update schema Signed-off-by: Cindy Murdock Ames Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:17:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:17:25 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #58 from Katrin Fischer --- Created attachment 43784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43784&action=edit [PASSED QA] Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price This patch adds the ability to set the maximum fine for a given item to its replacement price ( assuming the replacement price is set ). If overduefinescap is also set, the fine will be the lesser of the two, if both apply to the given overdue checkout. To enable this new limit, create or edit your circulation rules and check the checkbox for "Cap fines at replacement price" Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Pick an item, and set it's replacement price to 3.99 4) Edit the circulation rule that would apply to this item and the patron you will check it out to. 5) Check out the item to the patron, and backdate the due date such that the fine generated would be more than 3.99 6) Enable CalculateFinesOnReturn 7) Return the item, and view the fine generated, it should be 3.99 Signed-off-by: Cindy Murdock Ames Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:17:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:17:51 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:17:55 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43745|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:17:58 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43746|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:18:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:18:01 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:23:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:23:08 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Wondering... should we queue a message of the type 'print' if there is no e-mail address? I think this might be what we do for overdues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:24:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:24:40 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 --- Comment #5 from Katrin Fischer --- ... but probably should be configurable - for some notices you might not want to have a printed one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:34:03 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #15 from Katrin Fischer --- Hi Jonathan, can you take a quick look at the failing test please? not ok 16 - Calling delete without userid raises warning # Failed test 'Calling delete without userid raises warning' # at t/db_dependent/Search/History.t line 128. # found warning: ERROR: userid, id or interval is required for history deletion at /home/katrin/kohaclone/C4/Search/History.pm line 77. # expected to find warning: (?^u:^ERROR: userid or id is required for history deletion) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:35:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:35:38 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Katrin Fischer --- Never mind - I fixed it, continuing with testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:49:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:49:38 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #3 from Blou --- Created attachment 43785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43785&action=edit Bug 15030 - continue. The enumchron value was overwritten by 'header' even when value supplied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:49:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:49:52 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #33 from Marc V?ron --- I'm sorry, conflict with first patch: CONFLICT (content): Merge conflict in t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:56:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:56:30 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:56:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:56:34 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42114|0 |1 is obsolete| | Attachment #42116|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 43786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43786&action=edit [PASSED QA] Bug 10933: The PurgeSearchHistory should be merge into the C4::Search::History module Since bug 10803 adds a C4::Search::History module, the PurgeSearchHistory routine should be moved. Test plan: - run misc/cronjobs/cleanup_database.pl with the searchhistory param and verify behavior is the same as before applying this patch. - run prove t/Search/History.t Signed-off-by: Joonas Kylm?l? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:56:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:56:49 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 --- Comment #18 from Katrin Fischer --- Created attachment 43787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43787&action=edit [PASSED QA] Bug 10933: (follow-up) fix the previous patch to work with master Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 22:58:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 20:58:59 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #43 from Katrin Fischer --- Patch does not apply - please rebase! Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10988: Allow login via Google OAuth2 Using index info to reconstruct a base tree... M C4/Auth.pm M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Auth.pm CONFLICT (content): Merge conflict in C4/Auth.pm Failed to merge in the changes. Patch failed at 0001 Bug 10988: Allow login via Google OAuth2 The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-10988-Allow-login-via-Google-OAuth2-fFUW8a.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 23:10:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 21:10:35 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 23:10:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 21:10:37 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #13 from Barton Chittenden --- Created attachment 43788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43788&action=edit bug 14504: split logic from DelItemCheck() into ItemSafeToDelete() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 23:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 21:12:01 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #14 from Barton Chittenden --- Created attachment 43789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43789&action=edit bug 14504: use C4::Items::DelItemCheck in delete_items.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 23:22:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 21:22:35 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- Some first results: - Please submit the Schema changes as a separate patch next time. - The new attributes field should not show up on the "New SRU server" page - I believe it does not apply there. Please fix. - While validation would be nice, we don't provide it for the other fields here and I am not sure how it could work. So I would not insist on it, but any help we can give the user is of course always welcome. That's why I second Jonathan's comment 10 - we need some end user documentation on how to use this. Please provide an update to the help file. - Last but not least: I'd really like to see a second use case where this feature is helpful - so not only the one server causing problems, but maybe another good/clever idea on how to use this feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 22 23:34:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 21:34:19 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #15 from Barton Chittenden --- Jonathan, The call to C4::Context->IsSuperLibrarian() in C4::Items::ItemSafeToDelete (formerly in C4::Items::DelItemCheck) is throwing the following warning: C4::Context->userenv not defined! at /var/lib/koha/nekls2/kohaclone/C4/Items.pm line 2336. I've gone ahead and attached the patches, because everything else works, but thoughts about how to fix the "not_same_branch" code would be appreciated. --Barton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 00:06:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 22:06:29 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Some more notes: - +use strict; +use warnings; > Please use Modern::Perl; instead - The table should use a standard display format of Koha for the date and time information. The information form the patch doesn't translate and can't be configured with the dateformat/timeformat preferences: Thu Aug 2 16:41:30 2012 - I feel this would be better as a tool than as a link on the reports page - I don't really see a connection to reports so much, as it's a very general tool. - I am still in favor of renaming the directory to something less 'public' and we should have some information on how to use this feature safely without exposing data accidentally via your web server that should be kept safe. Possible enhancements: - As the kind of files presented can be quite different, it would be nice if this had its own permission. - Allow multiple directories - @Martin, maybe this could be added later? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 00:27:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 22:27:27 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #21 from David Cook --- (In reply to Katrin Fischer from comment #20) > - Last but not least: I'd really like to see a second use case where this > feature is helpful - so not only the one server causing problems, but maybe > another good/clever idea on how to use this feature. It's not just about the one server. It theoretically could be any server. http://www.loc.gov/z3950/agency/bib1.html: "Within an attribute list, each attribute type is optional. However, if a particular attribute type is not supplied, this document does not address target behavior -- a given target might supply a default attribute, dynamically select an appropriate attribute based on the other attributes supplied, or fail the search because it requires that the attribute type be supplied." At the moment, we don't have a way for users to specify Bib-1 attributes, so some servers will fail for all Z39.50 searches. Without this patch (or a similar one), I think the way we do Z39.50 searches is short-sighted. While Zebra will provide default attributes, it's clear that not all Z39.50 targets do. I don't think there are any other good/clever ideas for other ways to use this feature. It basically lets you provide attributes that are applied to the rest of the query. I suppose in other use cases... it lets you specify new defaults. For instance, Zebra will default to a Structure attribute of "phrase". Maybe you would prefer to default to a Structure attribute of "word list" instead, so you can specify that using this patch, and there you go. Or maybe you want to use a "relevance relation" for all your queries to a target, so you specify @attr 2=102. Or maybe you don't want to truncate anything in your queries so you supply @attr 5=100. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 00:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 22:33:26 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #22 from Katrin Fischer --- Hi David, thx for the quick reply and the examples - I'll say that reasolved that point in my list. Your examples would be great for the help page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 00:56:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 22:56:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #171 from Jesse Weaver --- Created attachment 43790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43790&action=edit Bug 11559: (QA followup) fix pagination bar, add Ctrl-D to macro editor Also, fix incredibly silly mistake with keyboard shortcuts popup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 00:57:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 22:57:37 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #117 from Katrin Fischer --- Hi Kyle, one small thing: If AudioAlerts is turned off the 'play' button on the administration page won't work and save the entry instead. That was quite confusing. I think independent of the AudioAlerts setting, you should be able to 'preview' the sounds on the admin page. The second best solution would be to not display the play button in this case. Enhancement ideas: - I'd really really like an option to play the sounds of saved entries for easier testing and also the option of editing the entries - if you get your selector wrong, it can be quite annoying to delete and start over. - Adding an example to the help page would be great. The example on the bug report is not quite so good, as it relies on the existence of an English string in a certain place and would be hard to translate, but maybe another example that is based on a class or id? Can you please take a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:03:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:03:11 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Failed QA |Signed Off --- Comment #6 from Katrin Fischer --- Hi Martin, it's usually ok to switch back to signed off once you have provided patches fixing the QA issues - this way it will get reviewed again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:09:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:09:35 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #172 from Jesse Weaver --- (In reply to Nick Clemens from comment #167) > Created attachment 43713 [details] > Record with composed character that breaks import into rancor > > When importing all fields after 518 containing {uml} have mangled indicators > Could be another issue causing it, but that seemed to be the case Ugh... this is a MARC-8 record. I _could_ add support for MARC-8, but it might be a bit ugly at this late hour. The current behavior (asplode) is non-ideal, so should I: a) Display an error when attempting to import MARC-8 records b) Add support for MARC-8 _import_ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:15:37 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #34 from David Cook --- I suppose it's way too late for this so someday I'll make a different bug but... I think the following: Should actually be: If you look at the LoC website (http://www.loc.gov/marc/bibliographic/bd245.html), you'll see that $h is always between $a and $b. -- Ahh... interesting... in the "CONTENT DESIGNATOR HISTORY", you'll see an explanation for this: "Prior to 1994, AACR2 cataloging rules required that the medium designator be recorded following other title information and all the title in works lacking a collective title. In Pre-1994 records, subfield $h generally follows subfield $b and even subfield $c in some cases." However, in post-1994 records, that does not appear to be the case. If anyone has access to the AACR2*, they could verify this. *Have to love closed standards in libraries. Terry Reese has a good post about this: http://blog.reeset.net/archives/1100 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:31:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:31:48 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40979|0 |1 is obsolete| | --- Comment #44 from M. Tompsett --- Created attachment 43791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43791&action=edit Bug 10988: Allow login via Google OAuth2 Adds googleoauth2 login to koha. Adds applicable system preferences Modifies templates to support oauth2 login failures changes the login links to use googleoauth2 when oauth2 is enabled. Updated patch to address the concerns in Comment 36. Test Plan: 0) Back up your database 1) Apply this patch 2) In your mysql client use your Koha database and execute: > DELETE FROM systempreferences; > SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql; -- Should be no errors. > SELECT * FROM systempreferences LIKE 'GoogleOAuth%'; -- Should see 4 entries. > QUIT; 3) Restore your database 4) Run ./installer/data/mysql/updatedatabase.pl; 5) In your mysql client use your Koha database and execute: > SELECT * FROM systempreferences LIKE 'GoogleOAuth%'; -- Should see the same 4 entries. 6) Log into the staff client 7) Home -> Koha administration -> Global system preferences 8) -> OPAC -- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca) 9) -> Administration -- There should be a 'Google OAuth2' section with the ability to set those 4 system preferences. 10) In a new tab, go to https://console.developers.google.com/project 11) Click 'Create Project' 12) Type in a project name that won't freak users out, like your library name (e.g. South Pole Library). 13) Click the 'Create' button. 14) Click the 'APIs & auth' in the left frame. 15) Click 'Credentials' 16) Click 'Create new Client ID' 17) Select 'Web application' and click 'Configure consent screen'. 18) Select the Email Address. 19) Put it a meaningful string into the Product Name (e.g. South Pole Library Authentication) 20) Fill in the other fields as desired (or not) 21) Click 'Save' 22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL. (http://library.yourDNS.org) 23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new googleoauth2 script (http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleoauth2) 24) Click 'Create Client ID' 25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID system preference. 26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret system preference. 27) Change the GoogleOAuth2 preference to 'Use'. 28) Click 'Save all Administration preferences' 29) In the OPAC, click 'Log in to your account'. -- You should get a confirmation request, if you are already logged in, OR a login screen if you are not. -- You need to have the primary email address set to one authenticated by Google in order to log in. 30) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:31:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:31:55 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41663|0 |1 is obsolete| | --- Comment #45 from M. Tompsett --- Created attachment 43792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43792&action=edit Bug 10988: Fix the svc script path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:37:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:37:51 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #46 from M. Tompsett --- Setting back to Signed Off after this rebasing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:48:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:48:00 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #1 from Mason James --- to test bug... 1/ define a 655$a value in a bib, save, reindex 2/ in opac-detail.pl click on its genre/form url, the search should successfully return a result (good!) 3/ next, define both a 655$a *and* 655$x value in a bib, save, reindex 4/ in opac-detail.pl click its genre/form url, the search should FAIL to return a result (BAD!) :/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:51:20 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #2 from Mason James --- Created attachment 43793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43793&action=edit successful search on 655$a - 'speedy reads' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:51:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:51:28 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:54:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:54:46 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #3 from Mason James --- Created attachment 43794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43794&action=edit successful search on 655$a - 'speedy reads' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 01:58:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 22 Oct 2015 23:58:24 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #4 from Mason James --- Created attachment 43795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43795&action=edit FAILED search on 655$a and 655$x - 'Family -- Fiction' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 02:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 00:26:40 +0000 Subject: [Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #35 from Winona Salesky --- The order in the for-each does not determine the order of the output. Subfields are output in the order they appear in the marc record. They are in alphabetical order in the for-each, purely for convenience sake. -Winona (In reply to David Cook from comment #34) > I suppose it's way too late for this so someday I'll make a different bug > but... > > I think the following: > > > > Should actually be: > > > > If you look at the LoC website > (http://www.loc.gov/marc/bibliographic/bd245.html), you'll see that $h is > always between $a and $b. > > -- > > Ahh... interesting... in the "CONTENT DESIGNATOR HISTORY", you'll see an > explanation for this: > > "Prior to 1994, AACR2 cataloging rules required that the medium designator > be recorded following other title information and all the title in works > lacking a collective title. In Pre-1994 records, subfield $h generally > follows subfield $b and even subfield $c in some cases." > > However, in post-1994 records, that does not appear to be the case. If > anyone has access to the AACR2*, they could verify this. > > *Have to love closed standards in libraries. Terry Reese has a good post > about this: http://blog.reeset.net/archives/1100 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 03:07:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 01:07:11 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #5 from Mason James --- my hunch is that the CCL syntax for the search query is incorrect my example returns no results.. (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 03:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 01:07:55 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 03:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 01:07:55 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15047 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 03:56:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 01:56:56 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Chris Kirby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Chris Kirby --- Hi Marc, >How is the behaviour without patch? It seems to me that it behaves the same (redirect to a login page). Without the patch, the behavior is the same. >What would you expect to happen if AutoSelfCheckAllowed is DISABLED? I was expect to have a login page for the selfcheck and then the SCO user's information is hidden, just as your patch achieves. >Maybe your finding is something for a separate bug? Yes, this might make sense if there is a desire to use the selfcheck when AutoSelfCheckAllowed is DISABLED. Signed off on patch: Applied on top of Bug 15039 - Set AutoSelfCheckAllowed to ENABLED, and provided values for AutoSelfCheckID, AutoSelfCheckPass - Set OpacLangSelectorMode to 'top' or 'both' - Went to SCO page - Verified that the language menu does not display in the header - Entered a card number to check out (this logs in the SCO user) - Verified that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Applied patch for 14776 - Verified that the language menu appears and the SCO user's information disappears. - Verified, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 04:37:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 02:37:43 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #6 from Mason James --- (In reply to Mason James from comment #5) > my hunch is that the CCL syntax for the search query is incorrect > > my example returns no results.. > (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction") the other issue is that the 650$x and/or 655$x subfields don't seem to be configured to be indexed by Zebra in.. /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml (and others) ..so a query for (su,complete-subfield:"Fiction") would be expected to fail, as that info is located in the unindexed 655$x subfield -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 05:01:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 03:01:22 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #173 from Nick Clemens --- (In reply to Jesse Weaver from comment #172) > a) Display an error when attempting to import MARC-8 records I think this would be fine, Marcedit can transform from marc-8 in the case of the error so I don't think it should be a huge deal. I would then file the marc-8 support as a separate bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 06:58:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 04:58:06 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #7 from Mason James --- (In reply to Mason James from comment #6) > (In reply to Mason James from comment #5) > > my hunch is that the CCL syntax for the search query is incorrect > > > > my example returns no results.. > > (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction") > > the other issue is that the 650$x and/or 655$x subfields don't seem to be > configured to be indexed by Zebra in.. > /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml (and > others) > > ..so a query for (su,complete-subfield:"Fiction") would be expected to fail, > as that info is located in the unindexed 655$x subfield good news, i have a fix for this... i'll attach a patch soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:40:40 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #11 from Josef Moravec --- There are still some Glyphicons, probably from recent development in these files: koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt koha-tmpl/intranet-tmpl/prog/en/includes/labels-toolbar.inc koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-toolbar.inc Maybe we should update Coding Guidelines, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:53:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:53:09 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:53:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:53:12 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43003|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy --- Created attachment 43796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43796&action=edit Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error Counter patch works as expected and is a much cleaner solution. Signed-off-by: Marc V?ron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:53:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:53:34 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #11 from Marcel de Rooy --- Created attachment 43797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43797&action=edit Bug 14918: [QA Follow-up] Correct enddate and use constant Corrected enddate (subtraction in the revised code must be an addition). Replaced hardcoded 2 days by a constant. Renamed the constant TWO_DAYS to PULL_INTERVAL. Signed-off-by: Marcel de Rooy Tested all three date formats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:53:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:53:48 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:54:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:54:37 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:58:02 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43796|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy --- Created attachment 43798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43798&action=edit Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error Counter patch works as expected and is a much cleaner solution. Signed-off-by: Marc Veron Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 08:58:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 06:58:06 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43797|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy --- Created attachment 43799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43799&action=edit Bug 14918: [QA Follow-up] Correct enddate and use constant Corrected enddate (subtraction in the revised code must be an addition). Replaced hardcoded 2 days by a constant. Renamed the constant TWO_DAYS to PULL_INTERVAL. Signed-off-by: Marcel de Rooy Tested all three date formats. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:01:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:01:04 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:01:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:01:16 +0000 Subject: [Koha-bugs] [Bug 15014] Plack testing -- Import patrons tool -- sample text file link broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15014 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43483|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 43800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43800&action=edit Bug 15014: Returns 0 if everything went fine Be kind and return 0 if the sample file has been generated correctly. Otherwise you are a bad guy and you make Plack returns an internal error (exited nonzero: 1 at /home/vagrant/kohaclone/tools/import_borrowers.pl line 390.) Signed-off-by: Josef Moravec Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:12:07 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #18 from Jonathan Druart --- (In reply to Kyle M Hall from comment #17) > > 6 vs 5 > > That is a purposeful change. The issue was that the logic of the unit test > was off by one. The assumption was that the number of holds must greater > than or equal to, but as per the code and sys pref definition, the number of > holds must be simply greater than. Thus adding one more hold fixes all the > tests. (In reply to Jonathan Druart from comment #14) > > + if ( $holds->count() <= $threshold ) { > > And an inclusive here. So should this be < also? > ::: Koha/Biblio.pm > @@ +41,5 @@ > > +or list of Koha::Item objects in list context. > > + > > +=cut > > + > > +sub items { > > Wouldn't be better to use a DBIx::Class relation? > Something like bug 14819. > > ::: installer/data/mysql/sysprefs.sql > @@ +103,3 @@ > > ('decreaseLoanHighHoldsDuration',NULL,'','Specifies a number of days that a loan is reduced to when used in conjunction with decreaseLoanHighHolds','Integer'), > > ('decreaseLoanHighHoldsValue',NULL,'','Specifies a threshold for the minimum number of holds needed to trigger a reduction in loan duration (used with decreaseLoanHighHolds)','Integer'), > > +('decreaseLoanHighHoldsIgnoreStatuses', '', 'damaged|itemlost|notforloan|withdrawn', "Ignore items with these statuses for dynamic high holds checking", 'Choice'), > > Wrongly placed. What about these 2 comments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:17:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:17:41 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:17:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:17:43 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43778|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 43801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43801&action=edit Bug 12194: followup to fix test This patch adds new column 'oblique_title' to tested data structure, and update number of tests To test: 1) Run prove t/db_dependent/Labels/*, or specifically prove t/db_dependent/Labels/t_Layout.t It fails 2) apply the patch 3) Run test again, this time must pass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:17:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:17:52 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:18:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:18:09 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43740|:x |Bug 12194: fix label for description| |oblique_title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:23:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:23:40 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #12 from Marc V?ron --- Hi Chris, Thanks for your comments. I propose that you file a new bug that describes the behaviour you would like to see when AutoSelfCheckAllowed is DISABLED. Regarding your sign-off: Did you just switch the status? Ot did you forget to attach the patch with your sign-off? It seems that the patch itself did not change. See http://wiki.koha-community.org/wiki/Sign_off_on_patches and http://wiki.koha-community.org/wiki/Git_bz_configuration (I use the git bz method). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:27:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:27:54 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #35 from Chris Cormack --- (In reply to Jonathan Druart from comment #34) > (In reply to Chris Cormack from comment #33) > > I agree with Marc that we need to also waen the users to close the browser, > > as I can confirm that this fix doesn't work for Firefox > > What version are you using? It is now ok in the latest version, I am running firefox developer edition, 43.0a2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:37:27 +0000 Subject: [Koha-bugs] [Bug 14884] [3.20.X] Test failure from Bug 14470 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14884 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:43:39 +0000 Subject: [Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:50:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:50:43 +0000 Subject: [Koha-bugs] [Bug 14929] Fix missing display of help page in contract management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:51:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:51:36 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Jonathan Druart --- (In reply to Kyle M Hall from comment #36) > So far I have been completely unable to reproduce this failure using my test > database or a fresh Koha db with all the sample data. Have you tested it > with a fresh sample data database? Everything passes with a fresh install, but then add a biblio and the tests won't pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:52:56 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #2 from Marc V?ron --- 17 patches left to sign-off as of today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:53:47 +0000 Subject: [Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #13 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:58:42 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:58:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:58:45 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43630|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy --- Created attachment 43802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43802&action=edit Bug 14674: koha-create should populate upload_path This patch makes koha-create and koha-create-dirs aware of the new upload_path configuration entry. It defaults to /var/lib/koha//uploads as proposed by Robin but lets the user specify its own directory, using the --upload-path option switch that is added by this patch. koha-create-dirs is tweaked so it also creates this new directory. The docs are updated accordingly. To test: - Apply the patch, have a packages setup (either by grabbing the relevant files [1] or by creating your own package). - Run koha-create --create-db instance => SUCCESS: /var/lib/koha/instance/uploads directory is created => SUCCESS: /etc/koha/sites/instance/koha-config.xml has upload_path set correctly - Create a new instance using the --upload-path making it point to whatever you want => SUCCESS: koha-conf.xml points to your chosen path - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Marcel de Rooy Does not work in its current state. Needs a follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:58:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:58:49 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #10 from Marcel de Rooy --- Created attachment 43803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43803&action=edit Bug 14674: [QA Follow-up] Typos and textual adjustment This patch does: [1] Resolve error [koha-create: line 294: local: `=upload21': not a valid identifier] by replacing $instance by instance. [2] Resolved typo for 'specify'. [3] Resolve error: [sed: -e expression #26, char 20: unknown option to `s'] by replacing the slash in the sed line by a #. This makes sed not stumble over the slashes in the upload path. [4] Added the aspect of permanent storage in the wording (as opposed to the storage of temporary uploads in /tmp or similar). Signed-off-by: Marcel de Rooy Verified that koha-create now inserts the right path in koha-conf.xml. Verified that koha-create-dirs created the new uploads directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 09:59:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 07:59:06 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|julian.maurice at biblibre.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:01:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:01:36 +0000 Subject: [Koha-bugs] [Bug 14820] SMSSendUsername and SMSSendPassword are not listed in the system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14820 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:06:20 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|6874 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 [Bug 6874] Attach files to bibliographic records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:06:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:06:20 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14674 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 [Bug 14674] koha-create should set upload_path in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:06:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:06:37 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6874 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:06:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:06:37 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14674 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:06:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:06:44 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:06:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:06:46 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43659|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 43804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43804&action=edit Bug 14776 - Remove 'selfcheck' patron related links from and add language selector to SCO header The SCO screen displays patron related menu items in it's header (Link to the account and "Logout"). This makes no sense since the patron that is logged in is the 'selfcheck' user as defined in syspref AutoSelfCheckId. Additionally, the language menue is missing when the syspref OpacLangSelectorMode is set to 'top' or to 'both'. To test: - Apply on top of Bug 15039 - Set AutoSelfCheck sysprefs as appropriate - Set OpacLangSelectorMode to 'top' or 'both' - Go to SCO page - Verify that the language menue does not display in the header - Enter a card number to check out (this logs in the SCO user) - Verify that you get text similar to "Welcome, checkout" with a link to the sco user's account in the OPAC and a 'Logout' link - Apply patch - Verify that the language menu appears and the SCO user's information disappears. - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:12:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:12:28 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #16 from Jonathan Druart --- Barton, have you seen my suggestion on comment 12? I think it will be really easy to implement what you want using it (no change in pm and no additional tests). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:13:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:13:07 +0000 Subject: [Koha-bugs] [Bug 14811] Don't set permanent_location to CART or PROC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14811 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:21:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:21:52 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:21:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:21:55 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43544|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 43805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43805&action=edit Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:21:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:21:59 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #21 from Jonathan Druart --- Created attachment 43806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43806&action=edit Bug 14131: Reduce the greybox height to 400px Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:23:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:23:07 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #22 from Jonathan Druart --- The display looks better on my screens (15" and 26"), 800 is definitely too much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:23:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:23:32 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #23 from Jonathan Druart --- ... with the last patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:25:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:25:12 +0000 Subject: [Koha-bugs] [Bug 13971] Adjusted locations in koha-rebuild-zebra for gitified instance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy --- Moving this one to BLOCKED May come up with a slightly adjusted approach.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:32:11 +0000 Subject: [Koha-bugs] [Bug 15052] New: Add diagnostic for the TestBuilder tests Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Bug ID: 15052 Summary: Add diagnostic for the TestBuilder tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:35:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:35:14 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:35:17 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 --- Comment #1 from Jonathan Druart --- Created attachment 43807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43807&action=edit Bug 15052: Add diagnostic for the TestBuilder tests Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed. Test plan: Create the following file: Koha/Schema/Result/Test.pm package Koha::Schema::Result::Test; use base 'DBIx::Class::Core'; __PACKAGE__->table("test"); 1; If you don't have a table named 'test' in your DB, prove t/db_dependent/TestBuilder.t should return a failure, but without any explanation. With this patch you should get a diag and know what's wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:35:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:35:31 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 10:48:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 08:48:40 +0000 Subject: [Koha-bugs] [Bug 14141] Changing the Library for a notice duplicates the notice instead of updating it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14141 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:04:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:04:30 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39800|0 |1 is obsolete| | --- Comment #25 from Holger Mei?ner --- Created attachment 43808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43808&action=edit Bug 14101: Automatic renewals exactly on due date If no value for 'no renewal before' is specified, automatic renewal now falls back on the due date. Also 'no renewal before' can now be zero, so both automatic and manual renewals can be delayed until due date. Test plan: 1) Create some circulation rules with different settings for 'No renewal before' and 'Automatic renewal'. Both daily and hourly loans should work. 2) Try to renew both manually and automatically before and after a renewal should be possible. You can run misc/cronjobs/automatic_renewals.pl for automatic renewal. 3) Confirm that: * Both automatic and manual renewal with 'No renewal before' set to 0 do not happen before the due date (exact DateTime). * Manual renewal with 'No renewal before' set to undef (enter empty string) is unrestricted. * Automatic renewal with 'No renewal before' set to undef does not happen before the due date. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:04:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:04:33 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42773|0 |1 is obsolete| | --- Comment #26 from Holger Mei?ner --- Created attachment 43809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43809&action=edit Bug 14101: Unit tests This patch adds new test cases to check if CanBookBeRenewed provides correct return values and error codes for premature renewals. Both manual and automatic renewals and different settings for 'No renewal before' are tested. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:05:36 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41053|0 |1 is obsolete| | --- Comment #33 from Holger Mei?ner --- Created attachment 43810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43810&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is always based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. This is only relevant for loans caluclated in days. Hourly loans are not affected. To test: 1) Apply bug 14101, then apply this patch. 2) Run installer/data/mysql/updatedatabase.pl 3) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:05:39 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41054|0 |1 is obsolete| | --- Comment #34 from Holger Mei?ner --- Created attachment 43811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43811&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Check out an hour-based loan with 'No renewal before' set to 1. Switch syspref NoRenewalBeforePrecision between 'date' and 'exact time'. Confirm that with both settings the item cannot be renewed until exactly one hour before due. 2) Check out a day-based loan with 'No renewal before' set to 1 day. Confirm that: * with NoRenewalBeforePrecision set to 'date', renewal is possible at 12:00 AM on the day before due. * with NoRenewalBeforePrecision set to 'exact time', renewal is possible at 11:59 PM on the day before due. Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:05:42 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Mei?ner changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42785|0 |1 is obsolete| | --- Comment #35 from Holger Mei?ner --- Created attachment 43812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43812&action=edit Bug 14395: Unit tests This patch adds test cases for the new syspref NoRenewalBeforePrecision. Tests if GetSoonestRenewDate returns correct values for both 'date' and 'exact_time' settings. Also adds a few comments related to bugs 7413 and 14101. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule f?r Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:09:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:09:23 +0000 Subject: [Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #27 from Holger Mei?ner --- Hi Jonathan, thanks for QA! I think I fixed everything :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:13:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:13:58 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #36 from Holger Mei?ner --- Here you go, bondiurbano. Have a nice weekend :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:20:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:20:38 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #28 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:28:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:28:33 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:29:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:29:47 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 --- Comment #2 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:30:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:30:56 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #2 from Marc V?ron --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:31:38 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 --- Comment #2 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:32:30 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Jonathan Druart --- (In reply to Kyle M Hall from comment #15) > Not getting any merge conflicts. Did you apply 13517 and 13918 first? Oops, no, sorry about that. I thought they were already pushed. 1/ It seems that you forgot to include some files to this patch, please check. 2/ $hold->suspend_hold sounds a bit redundant :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:32:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:32:30 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 --- Comment #3 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:33:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:33:20 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from files in folder C4/*.pm (part one) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #2 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:34:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:34:28 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #17 from Jonathan Druart --- Looking at the obsolete patches, the 2 following files don't exist in the last patch set: svc/hold/resume | 48 +++++++++++ svc/hold/suspend | 51 ++++++++++++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:34:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:34:34 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #8 from Marc V?ron --- Still applies / auto-merging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:35:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:35:17 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 --- Comment #2 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:35:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:35:51 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #3 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:36:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:36:39 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 --- Comment #2 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:37:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:37:20 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 --- Comment #2 from Marc V?ron --- Still appplies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:37:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:37:54 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #2 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:38:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:38:33 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #2 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:39:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:39:19 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #11 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:40:10 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #8 from Marc V?ron --- Still applies / Auto merging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:40:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:40:55 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #6 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:41:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:41:33 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #6 from Marc V?ron --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 11:55:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 09:55:25 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- Please launch the QA script before submitting patches: FAIL C4/Record.pm FAIL critic # ControlStructures::ProhibitMutatingListFunctions: Got 1 violation(s). FAIL valid "my" variable @authors masks earlier declaration in same scope use perl -wc and perlcritic to get more info. There is something wrong with the css/less files, but it already exists on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:33:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:33:34 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:33:37 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43733|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 43813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43813&action=edit [PASSED QA] Bug 14981: Remove ethnicity occurrences from sample patrons file Bug 10020 has removed these columns, the should be removed from the patron sample file. Test plan: Insert the files updated by this patch into a fresh DB, you shouldn't get any error. Signed-off-by: Frederic Demians Before applying the patch, I was able to notice the error when loading the patron sample SQL file to a DB. With the patch, it's solved. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:35:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:35:46 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #51 from Martin Renvoize --- Poke, just awaiting yeah or neigh from Robin on this one.. I'll happily sign everything off again once we have a definitive In/Out on packaging the test dependencies :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:43:00 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:43:02 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43488|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 43814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43814&action=edit [PASSED QA] Bug 15021: Fix scoping variable in tools/batchMod.pl $tagslib is used in subroutines and should be declare as global. Test plan: On the Batch item modification page, all item fields should be listed, not only the title. Signed-off-by: Josef Moravec Works as expected Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:53:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:53:50 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43702|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 43815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43815&action=edit [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:53:47 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:54:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:54:08 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43815|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 43816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43816&action=edit [PASSED QA] Bug 15037: Correctly check the patron categories on displaying the Batch checkout tab When checking for the patron categories allowed to use the batch checkout, the comparison should be strict (eq). Test plan: 0/ Do not apply this patch 1/ Create 2 patron categories ST and S 2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S 3/ Create 2 patrons, 1 in the ST category and the other one in S 4/ On the patron detail page, you should see the "batch checkout" tab for both patron 5/ Apply this patch 6/ The tab should only be displayed for the patron S Signed-off-by: Tomas Cohen Arazi Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected. Also tried setting &batch=1 to force it to show the batch page, and it says I'm not allowed to do batch checkouts for that patron. Great! Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 12:59:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 10:59:37 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #52 from Robin Sheat --- (In reply to Martin Renvoize from comment #51) > Poke, just awaiting yeah or neigh from Robin on this one.. I'll happily sign > everything off again once we have a definitive In/Out on packaging the test > dependencies :) Oh bother*. I'm speaking at a conference next week and spent most of my time in the past few days preparing for that. I might get on to this in the weekend, but it's hard to promise. And next week I'll be in Hobart. So sorry for not being on to this quickly. * said Poo as he carved Eeyore's name into a black candle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:06:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:06:04 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #118 from Kyle M Hall --- Created attachment 43817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43817&action=edit Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:06:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:06:13 +0000 Subject: [Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #37 from bondiurbano --- (In reply to Holger Mei?ner from comment #36) > Here you go, bondiurbano. Have a nice weekend :) Thanks Holger! Impressive... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:06:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:06:24 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:19:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:19:47 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:19:50 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43802|0 |1 is obsolete| | Attachment #43803|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 43818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43818&action=edit Bug 14674: koha-create should populate upload_path This patch makes koha-create and koha-create-dirs aware of the new upload_path configuration entry. It defaults to /var/lib/koha//uploads as proposed by Robin but lets the user specify its own directory, using the --upload-path option switch that is added by this patch. koha-create-dirs is tweaked so it also creates this new directory. The docs are updated accordingly. To test: - Apply the patch, have a packages setup (either by grabbing the relevant files [1] or by creating your own package). - Run koha-create --create-db instance => SUCCESS: /var/lib/koha/instance/uploads directory is created => SUCCESS: /etc/koha/sites/instance/koha-config.xml has upload_path set correctly - Create a new instance using the --upload-path making it point to whatever you want => SUCCESS: koha-conf.xml points to your chosen path - Sign off :-D Regards Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Marcel de Rooy Does not work in its current state. Needs a follow-up. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:19:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:19:55 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 --- Comment #12 from Jonathan Druart --- Created attachment 43819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43819&action=edit Bug 14674: [QA Follow-up] Typos and textual adjustment This patch does: [1] Resolve error [koha-create: line 294: local: `=upload21': not a valid identifier] by replacing $instance by instance. [2] Resolved typo for 'specify'. [3] Resolve error: [sed: -e expression #26, char 20: unknown option to `s'] by replacing the slash in the sed line by a #. This makes sed not stumble over the slashes in the upload path. [4] Added the aspect of permanent storage in the wording (as opposed to the storage of temporary uploads in /tmp or similar). Signed-off-by: Marcel de Rooy Verified that koha-create now inserts the right path in koha-conf.xml. Verified that koha-create-dirs created the new uploads directory. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:46:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:46:23 +0000 Subject: [Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack --- String changes, held for 3.20.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 13:55:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 11:55:49 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #119 from Kyle M Hall --- Created attachment 43820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43820&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:13:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:13:04 +0000 Subject: [Koha-bugs] [Bug 7789] Add translations of item type and authorized value descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7789 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Duplicate of bug 14100?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:16:13 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #120 from Kyle M Hall --- Created attachment 43821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43821&action=edit Bug 11431 [QA Followup] - Update help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:25:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:25:14 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43820|0 |1 is obsolete| | Attachment #43821|0 |1 is obsolete| | --- Comment #121 from Kyle M Hall --- Created attachment 43822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43822&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:25:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:25:25 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #122 from Kyle M Hall --- Created attachment 43823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43823&action=edit Bug 11431 [QA Followup] - Update help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:31:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:31:07 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43822|0 |1 is obsolete| | Attachment #43823|0 |1 is obsolete| | --- Comment #123 from Kyle M Hall --- Created attachment 43824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43824&action=edit Bug 11431 [QA Followup] - Update help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:31:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:31:24 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #124 from Kyle M Hall --- Created attachment 43825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43825&action=edit Bug 11431 [QA Followup] - Add ability to edit audio alerts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:36:44 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:36:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:36:46 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43807|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 43826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43826&action=edit Bug 15052: Add diagnostic for the TestBuilder tests Sometimes t/db_dependent/TestBuilder.t fails with 'TestBuilder can create a entry for every sources' but we don't know which ones have failed. Test plan: Create the following file: Koha/Schema/Result/Test.pm package Koha::Schema::Result::Test; use base 'DBIx::Class::Core'; __PACKAGE__->table("test"); 1; If you don't have a table named 'test' in your DB, prove t/db_dependent/TestBuilder.t should return a failure, but without any explanation. With this patch you should get a diag and know what's wrong. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:36:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:36:49 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #17 from Kyle M Hall --- (In reply to Jonathan Druart from comment #16) > Barton, have you seen my suggestion on comment 12? > I think it will be really easy to implement what you want using it (no > change in pm and no additional tests). While your suggestions would definitely work, I think what Barton's changes are a good and worthwhile improvement. The logic to for deciding if an item is deletable should definitely be separate from the actual deleting of items, and now we've got more through unit tests as well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:37:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:37:03 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:55:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:55:15 +0000 Subject: [Koha-bugs] [Bug 14880] Keyboard shortcuts don't work after setting CircAutocompl to "Don't try" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:56:11 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #26 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:56:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:56:42 +0000 Subject: [Koha-bugs] [Bug 15052] Add diagnostic for the TestBuilder tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15052 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Tom?s Cohen Arazi --- Patch pushed to master. I was thinking of doing the same! Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:57:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:57:18 +0000 Subject: [Koha-bugs] [Bug 12194] Some fonts don't work on printing label In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #23 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks for taking care, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 14:59:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 12:59:27 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #4 from Kyle M Hall --- (In reply to Nick Clemens from comment #3) > Test plan worked as expected with one question: if they are hours overdue on > an hourly loan, and not a day overdue, it seems to not suspend them. Should > it? I suppose the question is, should hourly loans suspend in days the number of hours overdue? If an hourly loan is 3 hours late, should the patron be suspended for 3 days? If so, changes are needed. This patch makes it so that hourly loans are suspended based on the number of *days* the item is overdue. Anything less than 24 hours rounds down to 0 days. Should hourly loans suspend for a minimum of 1 day if they are overdue by less than 24 hours? I think the logic of how hourly loan suspension should work needs to be decided before it can be decided if this patch is correct, or if it needs additional changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:03:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:03:10 +0000 Subject: [Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:06:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:06:03 +0000 Subject: [Koha-bugs] [Bug 13590] Add ability to charge fines at start of charge period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13590 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #27 from Katrin Fischer --- *** Bug 9768 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:06:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:06:03 +0000 Subject: [Koha-bugs] [Bug 9768] Problem with grace period calculation and fine intervals >1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9768 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer --- I am quite confident that bug 13590 fixes this. *** This bug has been marked as a duplicate of bug 13590 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:16:13 +0000 Subject: [Koha-bugs] [Bug 14674] koha-create should set upload_path in koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14674 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks for the followup, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:16:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:16:37 +0000 Subject: [Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:16:53 +0000 Subject: [Koha-bugs] [Bug 14528] Viewing lists fails silently when not having correct permisison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14528 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:21:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:21:07 +0000 Subject: [Koha-bugs] [Bug 14940] opac-topissues.pl sort is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14940 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:21:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:21:38 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #101 from Jonathan Druart --- Created attachment 43827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43827&action=edit Bug 10363: Fix Updatedb entry on MariaDB With MariaDB, I get the following error: ERROR 1832 (HY000): Cannot change column 'av_id': used in a foreign key constraint 'authorised_values_branches_ibfk_1' The solution would be to remove the constraints, modify the columns and finally reintroduce the foreign keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:24:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:24:54 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #8 from Martin Stenberg --- Sorry about that, didn't know about the QA test tool. Issues are fixed, attaching two patches below. What is wrong with the css/less? Is it something introduced with any of the 14670 patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:25:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:25:21 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #9 from Martin Stenberg --- Created attachment 43828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43828&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:25:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:25:32 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #10 from Martin Stenberg --- Created attachment 43829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43829&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:25:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:25:56 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:31:38 +0000 Subject: [Koha-bugs] [Bug 14950] A date is not correctly filled in default values from batch mod [was Remove C4::Dates from tools/batchMod.pl] In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14950 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:34:42 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #18 from Kyle M Hall --- (In reply to Jonathan Druart from comment #17) > Looking at the obsolete patches, the 2 following files don't exist in the > last patch set: > svc/hold/resume | 48 +++++++++++ > svc/hold/suspend | 51 ++++++++++++ Scripts got lost in last rebase. Will fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:34:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:34:51 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |In Discussion --- Comment #9 from Mirko Tietgen --- Hi Marc, it works mostly well for me. Among other things I tried changing the date format in between and using wrong preset dates in the URL like circulation.pl?borrowernumber=51&duedatespec=10%2F30%2F2015+23%3A59 While the old version shows warnings or even breaks ("30" in the "month" position leads to a software error because it is not between 1 and 12), with your patch the wrong format passed by URL is displayed in the calendar, but no warnings or errors appear and the correct date is used when checking out. (In reply to Marc V?ron from comment #6) > - Verify that data displays properly (including for users with a card > that expires in the near future, see syspref 'NotifyBorrowerDeparture') That breaks it for me: > Template process failed: undef error - KohaDates: filter not found at /home/mirko/koha/C4/Templates.pm line 121. As you seem to have tested this, is that taken care of by one of the other patches by any chance? I would sign off if it has a "depends on" that works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:35:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:35:16 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:35:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:35:18 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43525|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 43830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43830&action=edit Bug 14310 - Suspend and resume indvidual holds from patron holds table This enhancment adds the ability to suspend and resume individual holds from the holds table on circulation.pl and moremember.pl. The interface is inspired/cribbed from the same feature already available in the opac. Test Plan: 1) Apply this patch 2) Find a patron with holds 3) Suspend a hold with no resume date 4) Resume the suspended hold 5) Suspend a hold with a resume date 6) Resume the suspended hold Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:39:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:39:01 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #53 from Martin Renvoize --- Thanks for the reply Robin.. I'll go ahead and get the ball rolling with the signoff and we can worry about the packaging stuff after that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:39:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:39:44 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #54 from Martin Renvoize --- I'm afraid I get a QA script failure Jonathan: FAIL t/db_dependent/Barcodes_ValueBuilder.t OK critic OK forbidden patterns OK pod OK spelling FAIL valid "my" variable $DEBUG masks earlier declaration in same scope Any thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:43:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:43:04 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #10 from Mirko Tietgen --- There is bug 14985 labelled as "part one". Maybe C4/Templates.pm is in a part two not yet on BZ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:45:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:45:25 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43526|0 |1 is obsolete| | Attachment #43830|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 43831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43831&action=edit Bug 14310 - Suspend and resume indvidual holds from patron holds table This enhancment adds the ability to suspend and resume individual holds from the holds table on circulation.pl and moremember.pl. The interface is inspired/cribbed from the same feature already available in the opac. Test Plan: 1) Apply this patch 2) Find a patron with holds 3) Suspend a hold with no resume date 4) Resume the suspended hold 5) Suspend a hold with a resume date 6) Resume the suspended hold Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:45:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:45:32 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #21 from Kyle M Hall --- Created attachment 43832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43832&action=edit Bug 14310 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:46:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:46:20 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:47:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:47:50 +0000 Subject: [Koha-bugs] [Bug 13414] Enable right truncation with search by relevance In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #19 from Fridolin SOMERS --- Syspref could be more friendly with strings instead of numbers. My 2c -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:52:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:52:24 +0000 Subject: [Koha-bugs] [Bug 14981] Sample patron data broken by removal of ethnicity column In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14981 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:52:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:52:44 +0000 Subject: [Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tom?s Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:53:13 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:53:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:53:47 +0000 Subject: [Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776 --- Comment #15 from Tom?s Cohen Arazi --- Sorry Johathan, no credit for you on this one :-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:54:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:54:12 +0000 Subject: [Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan and Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:54:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:54:35 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #38 from Kyle M Hall --- Created attachment 43833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43833&action=edit Bug 12803 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:55:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:55:03 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #102 from Tom?s Cohen Arazi --- Followup pushed to master. Thanks for taking care, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 15:58:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 13:58:46 +0000 Subject: [Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:01:10 +0000 Subject: [Koha-bugs] [Bug 15053] New: sample_creator_data.sql now fails during a fresh install Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Bug ID: 15053 Summary: sample_creator_data.sql now fails during a fresh install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:32 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42326|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize --- Created attachment 43834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43834&action=edit Bug 14778: Get rid of DBIx::Connector Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:36 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42388|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize --- Created attachment 43835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43835&action=edit Bug 14778: Make sure the dbh returned is checked by DBIC Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:40 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43247|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize --- Created attachment 43836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43836&action=edit Bug 14778: Make 3 tests pass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:44 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43248|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize --- Created attachment 43837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43837&action=edit Bug 14778: Make the installer test pass - use DBI missing Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:47 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43249|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize --- Created attachment 43838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43838&action=edit Bug 14778: Set PrintError as it was before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:51 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43631|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize --- Created attachment 43839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43839&action=edit Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t We can use Test::DBIx::Class to install fixtures before our tests. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:55 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43632|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize --- Created attachment 43840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43840&action=edit Bug 14778: Mocks Koha::Database->_new_schema instead of C4::Context->_new_dbh C4::Context::_new_dbh does not exist anymore. Koha::Database::_new_schema should be mocked instead. Will fix: - t/00-load.t - t/Breeding.t - t/ImportBatch.t - t/Message.t - t/Overdues.t - t/Prices.t - t/RotatingCollections.t - t/Search.t - t/SuggestionEngine_AuthorityFile.t - t/XSLT.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:07:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:07:58 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43633|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize --- Created attachment 43841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43841&action=edit Bug 14778: Use mock_dbh where it should be used Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:02 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43634|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize --- Created attachment 43842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43842&action=edit Bug 14778: Install fixtures for t/Calendar.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:06 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43635|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize --- Created attachment 43843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43843&action=edit Bug 14778: Install fixtures for t/Biblio.t Note that it already passed before Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:09 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43636|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize --- Created attachment 43844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43844&action=edit Bug 14778: Install fixtures for t/Images.t Note that this tests file were completely buggy before. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:13 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43637|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize --- Created attachment 43845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43845&action=edit Bug 14778: Install fixtures for t/ItemType.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:17 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43638|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize --- Created attachment 43846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43846&action=edit Bug 14778: Install fixtures for t/Koha.t Warning: This patch modifies a module! What's the need of the binary function here? The data are case insensitive, so no need to use this mysql function. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:21 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43639|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize --- Created attachment 43847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43847&action=edit Bug 14778: Install fixtures for t/Letters.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:24 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43640|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize --- Created attachment 43848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43848&action=edit Bug 14778: Install fixtures for t/Matcher.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:28 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43641|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize --- Created attachment 43849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43849&action=edit Bug 14778: Install fixtures for t/Members_AttributeTypes.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:32 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43642|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize --- Created attachment 43850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43850&action=edit Bug 14778: Install fixtures for t/SocialData.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:36 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43643|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize --- Created attachment 43851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43851&action=edit Bug 14778: Make Barcodes_ValueBuilder.t db dependent The get_barcode subroutines call very mysql specific functions and it's not possible to easily use fixtures here. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:39 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43644|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize --- Created attachment 43852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43852&action=edit Bug 14778: Mock the dbh for t/db_dependent/Search.t No need to mock the items' columns (?) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:08:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:08:43 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43645|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize --- Created attachment 43853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43853&action=edit Bug 14778: Remove t/Acquisition/Invoices.t Using Test::DBIx::Class now, we cannot do what we did in this file with DBD::Mock. Since the Invoice[s] subroutines are already tested in t/db_dependent/Acquisition/Invoices.t there is no special needs to have these ones. Instead of loosing 2 hours on this file, I would prefer to remove it. Feel free to provide a counter patch. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:11:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:11:04 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:11:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:11:13 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:11:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:11:47 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #75 from Martin Renvoize --- Signed everything off, we decided the failure in the qa script was in fact an error in the modules itself which only presents in the qa script run (the tests do all pass if run with prove) Well tidy up the offending module later.. it's not a killer.. more of a style thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:12:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:12:01 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:12:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:12:15 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:12:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:12:17 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #1 from Kyle M Hall --- Created attachment 43854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43854&action=edit Bug 15053 - sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:14:06 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:16:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:16:18 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #22 from Kyle M Hall --- (In reply to Jonathan Druart from comment #16) > (In reply to Kyle M Hall from comment #15) > > Not getting any merge conflicts. Did you apply 13517 and 13918 first? > > Oops, no, sorry about that. I thought they were already pushed. > > 1/ It seems that you forgot to include some files to this patch, please > check. Fixed! > 2/ $hold->suspend_hold > sounds a bit redundant :) Agreed, but the column is already named 'suspend' so I didn't want to conflict with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:38:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:38:14 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:38:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:38:17 +0000 Subject: [Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42364|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 43855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43855&action=edit [PASSED QA] Bug 14198: RDA: Indexing 264 field (Zebra) This patch add zebra indexes to RDA 264 field. The new Provider index is added too. QA comments corrected. To test: 1) Download RDA records with 264 fields from this attachment . Import the file and re-index/rebuild zebra. These records contain 260 and 264 fields per record. 2) Do a search with pb:Bethany two records will appear with title The guardian. Search with pl:Minneapolis too, the two records will appear. 3) Select one record of both records and delete the 260 field keeping the 264 field and save, rebuild your zebra. 4) Search again with pb:Bethany and just one record will appear. Thats mean 264 is not indexed. 5) Apply patches. 6) Rebuild your zebra but this time all biblio records. 7) Search again with pv:Bethany or Provider:Bethany, this time will appear the two records, 264 is indexed. Note that if you search again with pb only one record appear. This is because the suggestion of LOC. 10) Search with copydate:2013 only launch records with 260 fields and pv:2013 show both fields, i.e., 260 and 264. 11) Apply QA Test Tools Sponsored-by: Universidad de El Salvador Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:42:28 +0000 Subject: [Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047 --- Comment #4 from M. Tompsett --- Comment on attachment 43767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43767 Bug 15047 - 655 URL not clickable in opac-detail. Review of attachment 43767: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15047&attachment=43767) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ +785,4 @@ > /cgi-bin/koha/opac-search.pl?q=an: > > > + /cgi-bin/koha/opac-search.pl?q= Why the name change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:45:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:45:06 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #16 from Jonathan Druart --- ]% prove t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation/GetTopIssues.t .. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at C4/Items.pm line 2196. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at C4/Items.pm line 2196. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Circulation/GetTopIssues.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/14 subtests Test Summary Report ------------------- t/db_dependent/Circulation/GetTopIssues.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 14 tests but ran 0. Files=1, Tests=0, 2 wallclock secs ( 0.02 usr 0.00 sys + 1.40 cusr 0.02 csys = 1.44 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:54:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:54:42 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43315|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 43856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43856&action=edit Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron categorie like 'TEST' (usful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:55:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:55:57 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43834|0 |1 is obsolete| | Attachment #43835|0 |1 is obsolete| | Attachment #43836|0 |1 is obsolete| | Attachment #43837|0 |1 is obsolete| | Attachment #43838|0 |1 is obsolete| | Attachment #43839|0 |1 is obsolete| | Attachment #43840|0 |1 is obsolete| | Attachment #43841|0 |1 is obsolete| | Attachment #43842|0 |1 is obsolete| | Attachment #43843|0 |1 is obsolete| | Attachment #43844|0 |1 is obsolete| | Attachment #43845|0 |1 is obsolete| | Attachment #43846|0 |1 is obsolete| | Attachment #43847|0 |1 is obsolete| | Attachment #43848|0 |1 is obsolete| | Attachment #43849|0 |1 is obsolete| | Attachment #43850|0 |1 is obsolete| | Attachment #43851|0 |1 is obsolete| | Attachment #43852|0 |1 is obsolete| | Attachment #43853|0 |1 is obsolete| | --- Comment #76 from Kyle M Hall --- Created attachment 43857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43857&action=edit [PASSED QA] Bug 14778: Get rid of DBIx::Connector Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:06 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #77 from Kyle M Hall --- Created attachment 43858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43858&action=edit [PASSED QA] Bug 14778: Make sure the dbh returned is checked by DBIC Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:11 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #78 from Kyle M Hall --- Created attachment 43859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43859&action=edit [PASSED QA] Bug 14778: Make 3 tests pass Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:15 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #79 from Kyle M Hall --- Created attachment 43860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43860&action=edit [PASSED QA] Bug 14778: Make the installer test pass - use DBI missing Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:19 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #80 from Kyle M Hall --- Created attachment 43861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43861&action=edit [PASSED QA] Bug 14778: Set PrintError as it was before Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:23 +0000 Subject: [Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #17 from Jonathan Druart --- Ok... The AI on my biblio and biblioitems tables differ. I don't really know why... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:23 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #81 from Kyle M Hall --- Created attachment 43862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43862&action=edit [PASSED QA] Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t We can use Test::DBIx::Class to install fixtures before our tests. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:28 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #82 from Kyle M Hall --- Created attachment 43863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43863&action=edit [PASSED QA] Bug 14778: Mocks Koha::Database->_new_schema instead of C4::Context->_new_dbh C4::Context::_new_dbh does not exist anymore. Koha::Database::_new_schema should be mocked instead. Will fix: - t/00-load.t - t/Breeding.t - t/ImportBatch.t - t/Message.t - t/Overdues.t - t/Prices.t - t/RotatingCollections.t - t/Search.t - t/SuggestionEngine_AuthorityFile.t - t/XSLT.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:32 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #83 from Kyle M Hall --- Created attachment 43864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43864&action=edit [PASSED QA] Bug 14778: Use mock_dbh where it should be used Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:36 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #84 from Kyle M Hall --- Created attachment 43865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43865&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Calendar.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:39 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #85 from Kyle M Hall --- Created attachment 43866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43866&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Biblio.t Note that it already passed before Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:43 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #86 from Kyle M Hall --- Created attachment 43867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43867&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Images.t Note that this tests file were completely buggy before. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:46 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #87 from Kyle M Hall --- Created attachment 43868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43868&action=edit [PASSED QA] Bug 14778: Install fixtures for t/ItemType.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:51 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #88 from Kyle M Hall --- Created attachment 43869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43869&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Koha.t Warning: This patch modifies a module! What's the need of the binary function here? The data are case insensitive, so no need to use this mysql function. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:56:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:56:55 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #89 from Kyle M Hall --- Created attachment 43870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43870&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Letters.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:00 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #90 from Kyle M Hall --- Created attachment 43871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43871&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Matcher.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:05 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #91 from Kyle M Hall --- Created attachment 43872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43872&action=edit [PASSED QA] Bug 14778: Install fixtures for t/Members_AttributeTypes.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:09 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #92 from Kyle M Hall --- Created attachment 43873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43873&action=edit [PASSED QA] Bug 14778: Install fixtures for t/SocialData.t Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:13 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #93 from Kyle M Hall --- Created attachment 43874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43874&action=edit [PASSED QA] Bug 14778: Make Barcodes_ValueBuilder.t db dependent The get_barcode subroutines call very mysql specific functions and it's not possible to easily use fixtures here. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:17 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #94 from Kyle M Hall --- Created attachment 43875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43875&action=edit [PASSED QA] Bug 14778: Mock the dbh for t/db_dependent/Search.t No need to mock the items' columns (?) Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:21 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #95 from Kyle M Hall --- Created attachment 43876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43876&action=edit [PASSED QA] Bug 14778: Remove t/Acquisition/Invoices.t Using Test::DBIx::Class now, we cannot do what we did in this file with DBD::Mock. Since the Invoice[s] subroutines are already tested in t/db_dependent/Acquisition/Invoices.t there is no special needs to have these ones. Instead of loosing 2 hours on this file, I would prefer to remove it. Feel free to provide a counter patch. Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:57:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:57:42 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 16:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 14:58:42 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #4 from Mirko Tietgen --- Exported MARC data was the same with and without patch. Borrower import without patch (mis)calculated dates in wrong format, like 2010-30-12 in yyy-mm-dd becoming 2012-06-15. After the patch, default values were used instead. Data in correct format was imported as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:03:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:03:13 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #96 from Tom?s Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:03:31 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #39 from Jonathan Druart --- (In reply to Kyle M Hall from comment #38) > Created attachment 43833 [details] [review] > Bug 12803 [QA Followup] - Fix unit tests This is a bit radical and I would like to know why it fails. I don't understand why adding 1 biblio to the DB makes your tests failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:08:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:08:58 +0000 Subject: [Koha-bugs] [Bug 15054] New: Get items from database instead of search engine in search results Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 Bug ID: 15054 Summary: Get items from database instead of search engine in search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Since OPAC uses the XSLT, the items displayed in search results does not come from search engine results anymore (see C4::XSLT::buildKohaItemsNamespace), they come from database table items. At intranet, the search results page, even when XSLT is used, displays items in left column and they come from search engine result. This enh proposes to get items from database. The big advantage is that item status display does not relay on indexing anymore. When checking in or out, the effect in search results is instantaneous, same for item defined as lost, damaged, ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:09:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:09:01 +0000 Subject: [Koha-bugs] [Bug 15055] New: Koha generates new subscription item even when it's not necessary Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15055 Bug ID: 15055 Summary: Koha generates new subscription item even when it's not necessary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: j.kylmala at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When receiving a subscription item, Koha will assume that you want to create a new subscription item (which will be put in the "expected" status) every time. How to reproduce this: 1. Someone accidentally changes something to "received" and then changes it back to "expected". -> a new item in subscriptions has been generated 2. Now we go and change that accidentally changed item back to "received". -> a new item in subscriptions has been generated 3. Now there is two new items waiting to be received. Normally there should be just one. 4. and what if someone changes the status 10 times accidentally to received.. Then there would be 10 new items waiting with the status "expected". Also when you add the last item of that specific subscription period Koha shouldn't generate the maybe future subscriptions item there. There is a huge bug(?) in the C4::Serials::abouttoexpire(), so fixing this might be difficult. The bug is that originally periodic subscription has been changed to non-periodic in the renewal phase and then it doesn't take that account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:09:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:09:05 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:14:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:14:29 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43312|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 43877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43877&action=edit Bug 14996 - Remove C4::Dates from tags/review.pl This patch removes C4::Dates from file tags/review.pl To test: - Create some tags - Go to Home > Tools > Tags - Verify that dates display properly - Verify that the date filter works as before Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:16:13 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 --- Comment #1 from Fridolin SOMERS --- Created attachment 43878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43878&action=edit TEMP get items from database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:16:49 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #4 from Mirko Tietgen --- Works for me. I noticed that the date filter does not work correctly with and without patch. To find tags from today (23/10/2015) I have to set the end date to 24/10/2015. A date range until 23/10/2015 does not show tags added today. Not related to this patch though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:19:05 +0000 Subject: [Koha-bugs] [Bug 15055] Koha generates new subscription item even when it's not necessary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15055 --- Comment #1 from Joonas Kylm?l? --- Created attachment 43879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43879&action=edit Bug 15055: Koha generates new subscription item even when it's not necessary Do checking whether the item which is been received is already in the system or not. If it is, then do not generate a new subscription item. Sponsored-by: Vaara-kirjastot This is a work-in-progress version (may not even apply but look at the code). This doesn't work optimally with the subscription expiration situation (when the abouttoexpire fixed, now it works in some cases) In order to get this working we need to call the C4::Serials::GenerateNewIssue also when we renew the subscription. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:20:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:20:33 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:20:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:20:35 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 --- Comment #2 from Fridolin SOMERS --- Created attachment 43880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43880&action=edit Bug 15054 - Get items from database instead of search engine in search results Since OPAC uses the XSLT, the items displayed in search results does not come from search engine results anymore (see C4::XSLT::buildKohaItemsNamespace), they come from database table items. At intranet, the search results page, even when XSLT is used, displays items in left column and they come from search engine result. This enh proposes to get items from database. The big advantage is that item status display does not relay on indexing anymore. When checking in or out, the effect in search results is instantaneous, same for item defined as lost, damaged, ... Test plan : - Disable zebraqueue indexing (rebuild_zebra -z) - Perform a search - Choose a result with an item available for loan - Perform a checkout on this item - Re-perform a search => Without patch you see the item still available => With patch you see the item on loan - Test also with checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:21:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:21:04 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43878|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:22:43 +0000 Subject: [Koha-bugs] [Bug 15054] Get items from database instead of search engine in search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15054 --- Comment #3 from Fridolin SOMERS --- I've run some tests : Search with 100 results per page, with and without the patch. I do not see a significant performance difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 17:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 15:34:46 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Failed QA --- Comment #3 from Mirko Tietgen --- (In reply to Marc V?ron from comment #1) > - 'Patrons who haven't checked out (reports/borrowers_out.pl) With the patch applied, the 'Global' column showing name and card number is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 18:02:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 16:02:13 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43306|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 43881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43881&action=edit Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify: git grep 'reservereport' Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 18:03:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 16:03:04 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off --- Comment #4 from Mirko Tietgen --- It looks like reservereport got superseeded by reserves_stats.pl and should have been removed some time ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 18:44:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 16:44:26 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 --- Comment #14 from Bernardo Gonzalez Kriegel --- Created attachment 43882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43882&action=edit Bug 14468: followup to fix tests This patch fix an expected test result. Also changes a comparison for the return value to 'delete' layout sub, in case of success it returns 'undef' and triggers the message 'use of uninitialized value $del_results ...' To test: 1) Whitout this patch prove t/db_dependent/Labels/t_Layout.t fails. Also note the message "Use of uninitialized value $del_results in string ne at t/db_dependent/Labels/t_Layout.t line 110." for using the return value of delete layout (undef on success!) 2) Apply the patch 3) Test pass and no more message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 18:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 16:45:41 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from Bernardo Gonzalez Kriegel --- Fixed test, changed to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 19:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 17:07:00 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #174 from Jesse Weaver --- Created attachment 43883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43883&action=edit Bug 11559: (QA followup) detect and warn about corruption caused by MARC-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 19:36:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 17:36:42 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #40 from Kyle M Hall --- (In reply to Jonathan Druart from comment #39) > (In reply to Kyle M Hall from comment #38) > > Created attachment 43833 [details] [review] [review] > > Bug 12803 [QA Followup] - Fix unit tests > > This is a bit radical and I would like to know why it fails. > I don't understand why adding 1 biblio to the DB makes your tests failing. I wish I could help you find out why, but I can't seem to reproduce your error! I tried with 1 bib and 0, 1 and 2 items. There must be something else going on in your database . If you can send me a copy of your test database I'll give it a shot! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 20:16:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 18:16:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Bob Geoghegan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |KonigDelos at gmail.com --- Comment #175 from Bob Geoghegan --- (In reply to Jesse Weaver from comment #174) > Created attachment 43883 [details] [review] > Bug 11559: (QA followup) detect and warn about corruption caused by MARC-8 To clarify: does this apply to all MARC-8 records or just certain records or characters in MARC-8? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 20:34:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 18:34:32 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #176 from Jesse Weaver --- (In reply to Bob Geoghegan from comment #175) > (In reply to Jesse Weaver from comment #174) > > Created attachment 43883 [details] [review] [review] > > Bug 11559: (QA followup) detect and warn about corruption caused by MARC-8 > > To clarify: does this apply to all MARC-8 records or just certain records or > characters in MARC-8? The corruption (and subsequent warning) occur only if a single record opened directly from a file contains MARC-8 special characters that cause the internal ISO 2709 parsing logic to fail. Note that records that are imported into the Koha catalog or import batches, or loaded from a Z39-50 search result, will be automatically converted from MARC-8 to UTF-8, so loading a single record from a file is the only case where this fails. This is because this is really the only case where ISO-2709-formatted records are decoded within Rancor itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 21:37:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 19:37:01 +0000 Subject: [Koha-bugs] [Bug 12157] Batch delete for serial holdings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12157 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 21:51:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 19:51:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jacob changed: What |Removed |Added ---------------------------------------------------------------------------- CC|tenorphunk at yahoo.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 21:59:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 19:59:40 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Keywords| |rel_3_22_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 22:34:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 20:34:40 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from H?ctor Eduardo Castro Avalos --- Sorry Marc, but fail me. This is the error message: DBIx::Class::ResultSet::find(): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '= 'booksellerid' AND me.1 IS NULL AND me.2015-12-31 = 'contractname' AND me.Fict' at line 1 at /home/koha/kohaclone/C4/Contract.pm line 125 This happend me when modifing the contract and i've entered an invalid date 32/10/2015 (DD/MM/YY) This happen me when modifying the contract and entered an invalid date 32/10/2015 (DD/MM/YY) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 22:51:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 20:51:39 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from H?ctor Eduardo Castro Avalos --- Sorry, but when editing an existing "Holiday repeating yearly" for example, christmas i get an error Software error: The 'day' parameter ("32") to DateTime::new did not pass the 'an integer which is a possible valid day of month' callback at /usr/lib/perl5/DateTime.pm line 199 DateTime::new(undef, 'year', 2015, 'month', 10, 'day', 32) called at /home/koha/kohaclone/tools/exceptionHolidays.pl line 64 When enter an invalid date like 32/10/2015 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 23:00:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 21:00:31 +0000 Subject: [Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 23:25:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 21:25:04 +0000 Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #3 from Jason Robb --- I want this! I don't see it explicitly mentioned, will borrowernumbers for both the hold placer/modifier and the hold placee(who it's for) be recorded? I know logs usually track "Librarian"(user) and "Object"(borrower), so will this track the patron as both the "Librarian" and the "Object" if they originate the hold in the OPAC? Also, this sounds very similar to bug 6890. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 23:32:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 21:32:15 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43169|0 |1 is obsolete| | --- Comment #9 from H?ctor Eduardo Castro Avalos --- Created attachment 43884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43884&action=edit [SIGNED-OFF]Bug 14949 - (followup) Fix regression with hard due date This patch fixes the regresseion as described in comment #3 To test: - Go on smart-rules.pl and edit a line. Do not define a Hard due date, save. The value is "None defined". - Edit the line, do not change anything and save. The value should be "None defined" - Edit the line, define a hard due date, save. The date should display as expected. - Edit the line agein, remove the hard due date, save. The value should be "None defined" Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 23:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 21:32:59 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43409|0 |1 is obsolete| | --- Comment #10 from H?ctor Eduardo Castro Avalos --- Created attachment 43885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43885&action=edit [SIGNED-OFF]Bug 14949 - Remove remaining C4::Dates and fix display in admin/categorie.pl This patch removes a remaining C4::Dates from admin/categroie.pl and fixes the display of "Enrollment period" on the confirmation screen for deleting. To verify and test pls. refer to comments #5 and #6 Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 23:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 21:33:26 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 23 23:44:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 23 Oct 2015 21:44:16 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #11 from Marc V?ron --- Hi Mirko, Thank you for the comments and for testing. Sorry, I have no time at teh moment to fined out what's wrong here; maybe I can come back to that on Sunday evening. I think the circulation files are the most sensible ones,maybe it is a good idea to fix them in one of the very last steps of this loooong journey. That said I really appreciate every sign-off and QA on the other C4::Dates Bugs. BTW: If anybody wants to take one of the C4::Dates bugs to help to get them through, I'll be very grateful. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 04:01:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 02:01:07 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 04:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 02:01:10 +0000 Subject: [Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 --- Comment #15 from Tom?s Cohen Arazi --- Created attachment 43886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43886&action=edit Bug 14106: (RM followup) sick of failing tests in Jessie This patch adds the original fix for source installs too... Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 09:34:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 07:34:33 +0000 Subject: [Koha-bugs] [Bug 14975] Fine grace period label is incorrect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14975 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- String changes, held for 3.20.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 09:38:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 07:38:16 +0000 Subject: [Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 09:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 07:41:19 +0000 Subject: [Koha-bugs] [Bug 14966] Table header broken at detail.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 09:44:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 07:44:39 +0000 Subject: [Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #46 from Chris Cormack --- Translation changes, held for 3.20.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 10:02:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 08:02:12 +0000 Subject: [Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 10:17:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 08:17:52 +0000 Subject: [Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 10:29:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 08:29:21 +0000 Subject: [Koha-bugs] [Bug 15029] Tests fail if launched after 23:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 10:32:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 08:32:44 +0000 Subject: [Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 10:35:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 08:35:11 +0000 Subject: [Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 11:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 09:50:45 +0000 Subject: [Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:04:44 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #125 from Katrin Fischer --- Created attachment 43887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43887&action=edit [PASSED QA] Bug 11431 [1] - Update database Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:04:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:04:48 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #126 from Katrin Fischer --- Created attachment 43888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43888&action=edit [PASSED QA] Bug 11431 [2] - Add audio alerts to installer http://bugs.koha-community.org/show_bug.cgi?id=11431 Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:04:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:04:53 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #127 from Katrin Fischer --- Created attachment 43889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43889&action=edit [PASSED QA] Bug 11431 [3] - Update schema Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:04:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:04:59 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #128 from Katrin Fischer --- Created attachment 43890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43890&action=edit [PASSED QA] Bug 11431 [4] - Add additional sound options This patch set replaces and extends Koha's current sound options. This is implemented be removing the existing sound system, and re-engineering using a table of selector/sound combinations such that the highest precedence selector that is found in the DOM will trigger and audio alert. The existing audio behaviors are implemented as a set of default audio alerts. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Enable the AudioAlerts system preference 4) Test existing sounds 5) Enter the new alerts editor in the admin section 6) Add a new audo alert with the following selector: "body:contains('Check in message')", choose any sound alert you wish, make sure it's not one of the 3 sounds already used! Make this selector precedence 1 4) Browse to the checkins page, you should hear the default sound 5) Attempt to return an invalid barcode, you should hear your custom sound! Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:03 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #129 from Katrin Fischer --- Created attachment 43891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43891&action=edit [PASSED QA] Bug 11431 [QA Followup] - Allow https in sound URLs Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:08 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #130 from Katrin Fischer --- Created attachment 43892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43892&action=edit [PASSED QA] Bug 11431 [QA Followup] - Fix POD Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:13 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #131 from Katrin Fischer --- Created attachment 43893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43893&action=edit [PASSED QA] Bug 11431 - Update UsageStats.pm Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:18 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #132 from Katrin Fischer --- Created attachment 43894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43894&action=edit [PASSED QA] Bug 11431 [QA Followup] - Fix js error Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:23 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #133 from Katrin Fischer --- Created attachment 43895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43895&action=edit [PASSED QA] Bug 11431 [QA Followup] - Unit Tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:27 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #134 from Katrin Fischer --- Created attachment 43896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43896&action=edit [PASSED QA] Bug 11431 [QA Followup] - Simplify audio_alert_id to just id Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:32 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #135 from Katrin Fischer --- Created attachment 43897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43897&action=edit [PASSED QA] Bug 11431 [QA Followup] - Move AudioAlerts to a separate plugin Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:37 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #136 from Katrin Fischer --- Created attachment 43898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43898&action=edit [PASSED QA] Bug 11431 [QA Followup] - Hard code list of sounds for security The sounds directory is no longer available for listing for security. It is better and safer to hard code the list of sounds. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:42 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #137 from Katrin Fischer --- Created attachment 43899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43899&action=edit [PASSED QA] Bug 11431 [QA Followup] - Fix alter precedences on delete Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:47 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #138 from Katrin Fischer --- Created attachment 43900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43900&action=edit [PASSED QA] Bug 11431 [QA Followup] - Always allow audio alerts for audio alerts editor page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:52 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #139 from Katrin Fischer --- Created attachment 43901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43901&action=edit [PASSED QA] Bug 11431 [QA Followup] - Update help Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:05:56 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #140 from Katrin Fischer --- Created attachment 43902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43902&action=edit [PASSED QA] Bug 11431 [QA Followup] - Add ability to edit audio alerts Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:06:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:06:01 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #141 from Katrin Fischer --- Created attachment 43903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43903&action=edit Bug 11431: QA follow-up: Typo in help file / variable name Fixes the variable name to avoid a double-up that made it impossible to turn off the sounds in general. If AudioAlerts are turned off, they will only work on the audio administration page now so you can set up and test the different sounds there. Also fixes a little typo in the help file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:08:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:08:48 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:08:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:08:51 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:08:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:08:55 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43825|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:08:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:08:59 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:03 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:06 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:10 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:14 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:18 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:22 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:25 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:29 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:33 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:37 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:41 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:45 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:09:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:09:49 +0000 Subject: [Koha-bugs] [Bug 11431] Add additional sound options for warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 12:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 10:15:07 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #53 from Katrin Fischer --- Sorry, patch doesn't apply, please rebase: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 12933 - Add ability to print overdue slip from staff intranet Using index info to reconstruct a base tree... M C4/Overdues.pm Falling back to patching base and 3-way merge... Auto-merging C4/Overdues.pm CONFLICT (content): Merge conflict in C4/Overdues.pm Failed to merge in the changes. Patch failed at 0001 Bug 12933 - Add ability to print overdue slip from staff intranet The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12933---Add-ability-to-print-overdue-slip-from-IujNUN.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:15:55 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:15:58 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43519|0 |1 is obsolete| | Attachment #43520|0 |1 is obsolete| | Attachment #43521|0 |1 is obsolete| | Attachment #43522|0 |1 is obsolete| | Attachment #43523|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall --- Created attachment 43904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43904&action=edit Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:16:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:16:06 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #55 from Kyle M Hall --- Created attachment 43905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43905&action=edit Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis Signed-off-by: Laurie McKee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:16:10 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #56 from Kyle M Hall --- Created attachment 43906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43906&action=edit Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:16:13 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #57 from Kyle M Hall --- Created attachment 43907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43907&action=edit Bug 12933 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:16:16 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #58 from Kyle M Hall --- Created attachment 43908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43908&action=edit Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:31:21 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #35 from Katrin Fischer --- Created attachment 43909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43909&action=edit [PASSED QA] Bug 14246: Add borrowernumber to koha_news This patch adds a new column to koha_news that links a borrowernumber to each item. This allows Koha to display the author for each entry which makes it suitable as a simple CMS. Changes (from rejected patch): * Added missing kohastructure.sql changes. * Turned the atomic update file into a SQL file and changed name in accordance with wiki guidelines. * Changed SQL syntax and naming to be consistent with existing code. * Attached test plan to commit message. Test plan: * You need at least one news item, log in and add one from 'Administration' -> 'Tools' -> 'News'. * Apply the patch. * Apply database upgrade (directly or indirectly). * Go back to Staff interface and post a new news item. * Use the mysql command line client to connect to the Koha installation's database: mysql -u kohaadmin -p -D koha (change username and database to values appropiate for your system). * Execute the following query: SELECT title, borrowernumber FROM opac_news; * Inspect the results, the 'borrowernumber' column should be NULL for all news items created before the patch was applied, and non-NULL for the new item created AFTER the patch was applied. Optional: Remove database changes via: ALTER TABLE opac_news DROP FOREIGN KEY borrowernumber_fk; ALTER TABLE opac_news DROP COLUMN borrowernumber; Sponsored-By: Halland County Library Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:31:25 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #36 from Katrin Fischer --- Created attachment 43910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43910&action=edit [PASSED QA] Bug 14246: Add borrowernumber, altered SQL As suggested by kind reviewers, an AFTER statement was added to the atomic upgrade script to ensure that the final field order is consistent is both fresh and upgraded databases. Also: * UPDATE action changed to CASCADE to improve robustness. Test plan: * Apply first patch in this set. * Apply this patch. * Perform a database upgrade. * Use mysql client to inspect field order. It should be identical to the kohastructure.sql order. Sponsored-by: Halland County Library Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:31:28 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #37 from Katrin Fischer --- Created attachment 43911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43911&action=edit [PASSED QA] Bug 14246: Update NewsChannel tests This commit adds the new 'borrowernumber' field to the existing test framework to make it pass. It does not include new tests. Sponsored-by: Halland County Library Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:31:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:31:31 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #38 from Katrin Fischer --- Created attachment 43912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43912&action=edit [PASSED QA] (fix) correct ALTER TABLE mysql syntax Address bug 14246 comment 13 remark - correcting MySQL ALTER TABLE syntax. Signed-off-by: Nick Clemens Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:31:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:31:35 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 --- Comment #39 from Katrin Fischer --- Created attachment 43913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43913&action=edit [PASSED QA] Bug 14246: Adding Koha::Schema::Result differences Ran misc/devel/update_dbix_class_files.pl as shown on wiki/Database_updates#updatedatabase.pl However, only git added Borrower and Opacnews, since those were the two affected by this patch. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:32:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:32:01 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:32:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:32:03 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43720|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:32:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:32:06 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:32:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:32:08 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:32:11 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:32:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:32:14 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:33:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:33:01 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #28 from Katrin Fischer --- Created attachment 43914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43914&action=edit [PASSED QA] Bug 14247: Add system preference for news display Test plan: * Apply dependant patch 14246 (if not done already). * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and 'Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Use the mysql command line client to connect to the Koha database: $ mysql -u kohaadmin -p -D koha * Enter the following query: SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay'; * Check to make sure that the 'value' column has changed to reflect the choice you made in the above step. Separate SQL testing (clean installation of Koha): * Koha$ mysql -u root < create_koha_test_db.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/kohastructure.sql * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql Testing the update script works the same way: * Koha$ echo "DELETE FROM systempreferences WHERE variable = 'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test * Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/atomicupdate/add_news_prefs.sql Signed-off-by: Marc V?ron Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:33:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:33:05 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 --- Comment #29 from Katrin Fischer --- Created attachment 43915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43915&action=edit [PASSED QA] Bug 14247: Rename sysprefs atomic update file This trivial patch changes the name of the SQL update file to match the guidelines on the wiki. Sponsored-by: Halland County Library Signed-off-by: Marc V?ron Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:33:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:33:29 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:33:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:33:31 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:33:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:33:33 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43725|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:34:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:34:16 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #21 from Katrin Fischer --- Created attachment 43916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43916&action=edit [PASSED QA] Bug 14248 - Optionally display authorship for news Test plan: * Apply dependant patches 14246 and 14247. * Apply current patch. * Log into the Staff client, go to 'Administration' -> 'Global Preferences' -> 'Tools', a new section titled 'News' should appear with a single option named 'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only', 'Staff client only' and Both OPAC and staff client'. By default the value should be 'Not at all' (to mimic existing behaviour, important!). * Change the value to something different and save the changes. * Go to 'Tools' -> 'News' and add some news items (at least 2). * Use the MySQL command line tool to edit the opac_news table, removing the user id from one of the news items: $ mysql -u kohaadmin -p -D koha > SELECT `idnew`, `title`, `borrowernumber` FROM `opac_news`; * Make a mental note of one of the 'newid' numbers to change. > UPDATE `opac_news` SET `borrowernumber` = NULL WHERE `idnew` = ; * Now one of the news items will have no user id, and no author should be shown for it. * Go to OPAC and Staff client and make sure the display modes works as intended. * Repeat for all values, making sure that the settings works as intended. * The changed news item should have no author info shown at any time. * The unchanged news item should show your own user name if the settings match the section where it is displayed. Sponsored-By: Halland County Library Tested on top of Bugs 1246 and 1247, works as advertised. Note: Some whitespaces changed / removed in koha-news.tt to pass qa tools. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:34:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:34:20 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #22 from Katrin Fischer --- Created attachment 43917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43917&action=edit [PASSED QA] Bug 14248: Regression tests requested TEST PLAN --------- 1) apply patch 2) prove -v t/db_dependent/NewsChannels.t 3) run koha qa test tools. Signed-off-by: Martin Persson Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:34:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:34:23 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #23 from Katrin Fischer --- Created attachment 43918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43918&action=edit Bug 12428: QA Follow-up: Wrap borrower's title in a span to make it possible to hide I think showing the title with the user name is quite unusual for Koha. Wrapping the title in a span with a unique class makes it possible to hide it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:35:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:35:51 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:35:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:35:53 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:35:55 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43421|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 13:52:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 11:52:24 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #24 from Katrin Fischer --- There is just one small thing that is irritating to me about this patch set - the display of the news author's name: <firstname> <surname>. Thinking of blogs and similar I think the <title> is not needed. I think we could maybe remove it. I provided a follow-up wrapping the title into a span with a unique class so now you can hide it if you want to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:41:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:41:48 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-NZHh2uQPQG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I don't feel like this is ready to be pushed quite yet. I will give some examples: 1) If a record (serials?) don't have a publication year, the styles will look like this: APA (). Handelsblatt. D?sseldorf: Verl.-Gruppe Handelsblatt. Chicago . Handelsblatt. D?sseldorf: Verl.-Gruppe Handelsblatt. Harvard (). Handelsblatt. D?sseldorf: Verl.-Gruppe Handelsblatt. MLA Handelsblatt. D?sseldorf: Verl.-Gruppe Handelsblatt. . So it doesn't cover for the case the publication year doesn't exist in the record. Another case are articles - the citation will miss the host item information, which is very vital for those: APA Schweizer K., . (2010). 100 Jahre Internationaler Frauentag. : . Chicago Schweizer Karl, . 2010. 100 Jahre Internationaler Frauentag. : . Harvard Schweizer K., . (2010). 100 Jahre Internationaler Frauentag. : . MLA Schweizer Karl, . 100 Jahre Internationaler Frauentag. : . 2010. I think this needs more testing with different type of media. Also one small thing, that I had fixed for a follow-up, but will put here as a comment now: - place => $record->subfield("260", "a") || "", + place => $record->subfield("264", "a") || $record->subfield("260", "a") || "", publisher => $record->subfield("264", "b") || $record->subfield("260", "b") || "", Last but not least: I am reattaching the patches with a follow up taking care of a conflict in the opac.css. I have removed it from the first patch and put the fixed file into a separate patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:42:32 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-0sd8Mbvn0n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43508|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43919&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:42:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:42:35 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-ZTrM8qQxPd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43770|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43920&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:42:39 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-eSheFYBWLY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43771|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43921&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:42:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:42:44 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-YVzn3tdKAo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43828|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43922&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:42:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:42:47 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-BrrO9kqAaB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43829|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43923&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 14:42:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 12:42:51 +0000 Subject: [Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC In-Reply-To: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14670-70-Xei6BRevQP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43924&action=edit Bug 14670: QA follow-up: Regenerated opac.css The first patch originally contained the changes opac.css. I removed the file to fix the conflict. This patch readds the opac.css changes generated from the changes to the .less file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:29:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:29:44 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-447KOvmeNY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43925&action=edit [PASSED QA] Bug 12933 - Add ability to print overdue slip from staff intranet Some librarians would like to be able to print an overdues slip from the staff intranet. This slip would be defined as the print transport version of the ODUE slip. Test Plan: 1) Apply this patch 2) Locate a patron with overdues 3) Define a print version of the OVERDUES_SLIP slip 4) Try Print > Print overdues Signed-off-by: Amy Purvis <APurvis at galencollege.edu> Signed-off-by: Laurie McKee <lmckee at littleelm.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:29:48 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-7ISlluTMlz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #60 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43926&action=edit [PASSED QA] Bug 12933 - Add new OVERDUES_SLIP letter Signed-off-by: Amy Purvis <APurvis at galencollege.edu> Signed-off-by: Laurie McKee <lmckee at littleelm.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:29:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:29:52 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-9zhmlvE2DU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #61 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43927&action=edit [PASSED QA] Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:29:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:29:56 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-m48flPQmfN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43928&action=edit [PASSED QA] Bug 12933 [QA Followup] - Add Unit Tests Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:00 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-f2iDSt9Rnh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #63 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43929&action=edit [PASSED QA] Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:04 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-uGs2LmN8ac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 --- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43930&action=edit Bug 12933: QA Followq-up - Add missing notice templates and other small fixes - Fixes page title of slip print window: Members > Patrons - Fixes error message if no notice template is found - Fixes a stray template variable that resulted in the borrower number showing in the 'Print' pull down - Fixes xt/sample_notices.t by adding the sample notice to it-IT and es-ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:40 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-SYM18Htwo2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:38 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-8WzxmooYb9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:46 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-MafdQVH4j4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:43 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-XZ1h8pc5l2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:49 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-OQoOdBYLXu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43907|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:30:51 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-BzvR3fTbSL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43908|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:53:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:53:27 +0000 Subject: [Koha-bugs] [Bug 232] OPAC - user fax number is displayed as work phone In-Reply-To: <bug-232-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-232-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-232-70-TaOnVQZNmF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=232 pankajbishty <jasvir.email11 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jasvir.email11 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:54:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:54:59 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-cUAa84t7bL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:55:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:55:03 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-z2wKpkQjqS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43147|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43931&action=edit [PASSED QA] Bug 14734 - Enhance 264 display in OPAC and Staff XSLT. Makes 264 repeatable, prefer 264 over 260. If 264/ind1=3 is present in the record the xslt uses ind1 to determine latest 264, if no ind1=3 then all 264 fields are displayed. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with multiple MARC tags 264 4) Perform a search that would show the record in the search results. 5) Review results for correct 264 display. 6) Click title to review record details. Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised. 260 not showed when 264 exists, tested with multiple records. If ind1=3 is present shows the current/latest data Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 21:55:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 19:55:25 +0000 Subject: [Koha-bugs] [Bug 264] Day phone not output on confirm record. In-Reply-To: <bug-264-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-264-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-264-70-CfmlsbLRG1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=264 pankajbishty <jasvir.email11 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jasvir.email11 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:00:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:00:46 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: <bug-14996-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14996-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14996-70-Kcwewk6dVu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:00:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:00:49 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: <bug-14996-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14996-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14996-70-IQwiImVfMD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43877|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43932&action=edit [PASSED QA] Bug 14996 - Remove C4::Dates from tags/review.pl This patch removes C4::Dates from file tags/review.pl To test: - Create some tags - Go to Home > Tools > Tags - Verify that dates display properly - Verify that the date filter works as before Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:17:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:17:06 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14995-70-5jcPSeg7m4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Not only unused, but appears to be broken as well: Undefined subroutine &main::unfilledreserves called at /home/katrin/kohaclone/reports/reservereport.pl line 74. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:17:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:17:44 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14995-70-kL8NlwTOYr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:17:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:17:47 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14995-70-G4Rg67t7yP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43881|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43933&action=edit [PASSED QA] Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt The following files use C4::Dates, but they seem no longer to be in use: - koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt - reports/reservereport.pl To verify: git grep 'reservereport' Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:26:49 +0000 Subject: [Koha-bugs] [Bug 7789] Add translations of item type and authorized value descriptions In-Reply-To: <bug-7789-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7789-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7789-70-fhrwcGQFpR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7789 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It is! Discussion from 2012... time flies! *** This bug has been marked as a duplicate of bug 14100 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:26:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:26:49 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-dPrXzxHNAJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 7789 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:50:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:50:26 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-Qt7HZx7bhS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43934&action=edit [PASSED QA] Bug 14949 - Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl Bug to remove C4::Dates from - admin/smart-rules.pl - admin/categorie.pl To test: - Apply patch - Go to Home > Administration > Circulation and fine rules (smart-rules.pl) - Edit or add a rule - Verify that 'Hard due date' displays and saves fine - Go to Home > Administration > Patron categories - Edit or add a category - Verify that 'Until date' displays and saves fine Note: The date picker does not warn about wrong date formats as e.g. while editing patrons, but that is not in the scope of this bug Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:50:29 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-6mhhVngHZD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43935&action=edit [PASSED QA] Bug 14949 - (followup) Fix regression with hard due date This patch fixes the regresseion as described in comment #3 To test: - Go on smart-rules.pl and edit a line. Do not define a Hard due date, save. The value is "None defined". - Edit the line, do not change anything and save. The value should be "None defined" - Edit the line, define a hard due date, save. The date should display as expected. - Edit the line agein, remove the hard due date, save. The value should be "None defined" Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:50:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:50:32 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-eRfORlbmQV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43936&action=edit [PASSED QA] Bug 14949 - Remove remaining C4::Dates and fix display in admin/categorie.pl This patch removes a remaining C4::Dates from admin/categroie.pl and fixes the display of "Enrollment period" on the confirmation screen for deleting. To verify and test pls. refer to comments #5 and #6 Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:50:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:50:59 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-cym16KT4Rh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:51:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:51:01 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-n6HDjgQS1A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:51:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:51:03 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-1BnUbGd9xs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 22:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 20:51:05 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-hNr5IvULnd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 23:23:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 21:23:40 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: <bug-14997-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14997-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14997-70-25UMpxbaiO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 23:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 21:23:43 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: <bug-14997-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14997-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14997-70-QcYwgV3Coh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43856|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43937&action=edit [PASSED QA] Bug 14997 - Remove C4::Dates from tools (import / export) This patch removes C4::Dates from: - tools/export.pl - tools/import_borrowers.pl Note: For testing, both need preparation without patch, see below. To test export: - Without patch applied, go to Home > Tools > Export data > Export bibliographic records - Define Start date / End date for Accession dates - Export bibliographic records as 'without-patch.mrc' - Do the same with patch, export as 'with-patch.mrc - Compare the files, they should be the same To test Import patrons: - Without patch - Go to Home > Tools > Import patrons - Create a patron category like 'TEST' (useful for filtering...) - Prepare a file with some patrons with category TEST to import. Fill date of birth, enrolment date, expiry date with values formatted in syspref format, in iso format and garbage - Import - Review the imported patrons (search for category TEST) - With patch: Change cardnumber and names in import file - Import - Review again and compare with results from previous import. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 23:53:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 21:53:58 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-JLOEBO5oif@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have a follow-up with some suggestions for the wording - but can't test on my local Koha installation (localhost...) Also: the svc script asks for the 'borrow' permission, that has since be removed. Please take a look and fix. Bug 7976 - "Borrow Permission" is not used and can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 24 23:57:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 21:57:17 +0000 Subject: [Koha-bugs] [Bug 10988] Allow login via Google OAuth2 In-Reply-To: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10988-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10988-70-3M68eokCu4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43938&action=edit Bug 10988: QA Follow-up - rewording suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:14:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:14:20 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-JB8O1KZyAa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just noting: an odt export would also be very nice - with every notice on a separate page! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:23:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:23:08 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-0p6nNkyrmc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43939&action=edit [PASSED QA] Bug 11678: Gather print notices: add --email parameter This patch add the ability to send generated files by email. You can specify several emails. Test plan: - same as Bug 11603 - call the script misc/cronjobs/gather_print_notices.pl with the following parameters: perl misc/cronjobs/gather_print_notices.pl /tmp/test --csv --ods --html --letter_code=CHECKIN -d=: --email="email_one at example.org" --email="email_two at example.org" Signed-off-by: Frederic Demians <f.demians at tamil.fr> - Works as desribed. Rebased upon bug-11603. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:23:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:23:11 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-SjKJq8DUOZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43940&action=edit [PASSED QA] Bug 11678: Improve documentation of new parameter Say --email is repeatable Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:23:15 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-6lxytiYHD1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43941&action=edit Bug 11678: QA follow-up - Fixing some typos in the documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:23:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:23:39 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-US98vTW5rr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:23:41 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-4mi4snmRb4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:23:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:23:43 +0000 Subject: [Koha-bugs] [Bug 11678] Gather print notices: send files by email In-Reply-To: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11678-70-Yvf4YPNK5Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:42:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:42:45 +0000 Subject: [Koha-bugs] [Bug 12802] Sent notices using several email addresses In-Reply-To: <bug-12802-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12802-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12802-70-jVHBcD237U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Conflicts in both first and second patch, please rebase! Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 12802: Sent notices using several email addresses Using index info to reconstruct a base tree... M C4/Branch.pm M C4/Letters.pm M C4/Members.pm M C4/Message.pm M C4/Reserves.pm M misc/cronjobs/overdue_notices.pl M opac/opac-memberentry.pl M opac/opac-shareshelf.pl M t/db_dependent/Letters.t M t/db_dependent/Members.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Members.t Auto-merging t/db_dependent/Letters.t CONFLICT (content): Merge conflict in t/db_dependent/Letters.t Auto-merging opac/opac-shareshelf.pl Auto-merging opac/opac-memberentry.pl Auto-merging misc/cronjobs/overdue_notices.pl Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm Auto-merging C4/Message.pm Auto-merging C4/Members.pm Auto-merging C4/Letters.pm Auto-merging C4/Branch.pm Failed to merge in the changes. Patch failed at 0001 Bug 12802: Sent notices using several email addresses The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-12802-Sent-notices-using-several-email-address-C2M_Ge.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:46:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:46:34 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-TE6km14wYL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, waiting for feedback on comment 18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 00:50:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 22:50:06 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: <bug-11565-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11565-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11565-70-rJVFvSZle8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Status|Signed Off |BLOCKED --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Blocked for now as we are waiting for bug 14694 to move. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 01:38:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 23:38:25 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-NKEbqq4Yt3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Kyle, this currently doesn't apply. I read through the code and noted some things to fix and have some suggestions: 0) AR_PRINT I'd like to rename the letter code to AR_SLIP or ARSLIP to be consistent with the other slips we have. +('circulation', 'AR_PRINT', '', 'Article Request - Print Slip', 0, 'Test' Test? 1) circ/request-article.pl Copyright statements are a bit odd for a new file :) @@ -0,0 +1,53 @@ +#!/usr/bin/perl + +# Copyright 2015 ByWater Solutions +# Copyright 2000-2002 Katipo Communications +# Copyright 2011 Catalyst IT 2) installer/data/mysql/atomicupdate/bug_14610.sql Please amend to use AFTER... to make sure the column always ends up in the same spot. +ALTER TABLE `issuingrules` ADD `article_requests` ENUM( 'no', 'yes', 'bib_only', 'item_only' ) NOT NULL DEFAULT 'no'; 3) kohastructure.sql Can you please add database documentation comments for the new table? 4) Please include the new notices in all translated sample_notices.sql as well. xt/sample_notice.t is your friend :) Small typo in one of the subjects: Article Request _Recieved_ 5) circ/article-requests.tt - notes = prompt("Reason for cancelation:"); is not translatable - [% ar.borrower.surname %], [% ar.borrower.firstname %] please fix display for the case, that a firstname is not given (organisations for example). 6) request-article.tt - var c = confirm("Are you sure you want to change the pickup library from " + previo... is not translatable - Additionally there is this new 'format' syntax that you can use to fill in the placeholders nicely and that allows for good translation. If you don't know what I am talking about I can probably dig up an example :) 7) opac/opac-article-request-cancel.pl + authnotrequired => 0, Please account for the OpacPublic system preference! Same for the other 2 opac/ .pl files. 8) Terminology - instead of 'open' maybe 'pending' would be better? This is what we use for suggestions and I think holds. Sometimes you are using 'open' and other times 'pending' (intranet-main.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 01:49:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 23:49:12 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-xM1UIhh3zC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #99 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This currently doesn't apply cleanly due to conflicts in the css files - please fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 01:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 24 Oct 2015 23:54:11 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-ZJoCerb3FW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think in order to have n:n relationships separate tables will be needed. Would also like to see some more information about this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 09:01:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 08:01:43 +0000 Subject: [Koha-bugs] [Bug 15056] New: hold-transfer-slip.pl print "No hold found" Message-ID: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056 Bug ID: 15056 Summary: hold-transfer-slip.pl print "No hold found" Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: mustaqeemabd at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 43942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43942&action=edit print no hold found Hi, When items are returned into library and there is a hold placed, after click "Print slip and confirm", just appear "No hold found". No information at all on the printed slip. The example address: elib.usm.my:8000/cgi-bin/koha/circ/hold-transfer-slip.pl?borrowernumber=2581&biblionumber=724975 Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 09:41:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 08:41:39 +0000 Subject: [Koha-bugs] [Bug 15056] hold-transfer-slip.pl print "No hold found" In-Reply-To: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15056-70-urw3PPddZh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- mustageeem, please check that you have your notice templates correctly defined - the error message can appear when the template is missing. Tools > Notices and Slips > RESERVESLIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:03:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:03:28 +0000 Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels In-Reply-To: <bug-14824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14824-70-lVW9033KeX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:03:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:03:31 +0000 Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels In-Reply-To: <bug-14824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14824-70-Uc3JcvlfJX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43780|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43943&action=edit [PASSED QA] Bug 14824 - Fix sorting of Norwegian vowels Currently, Norwegian vowels are not sorted correctly, even when you have chosen "nb" as the ZEBRA_LANGUAGE during installation. To test: - Make sure you have three records with titles that begin with ??? respectively - Do a search that turns up those three records and some others, and sort the results by title, bot ascending and descending. - Verify that ??? is shown in some weird order. - Edit your sort-string-utf.chr* so it is in line with the current patch. It should include these two lines: lowercase {0-9}{a-z}??? uppercase {0-9}{A-Z}??? - Restart Zebra and reindex all the records, e.g.: $?sudo koha-restart-zebra <instancename> $?sudo koha-rebuild-zebra -f -v <instancename> - Do the search again, make sure you order by title and check that ??? are sorted in the order of 1. ? 2. ? 3. ?, and after all other characters * = If you are on a gitified install, you need to edit this file: /etc/koha/zebradb/lang_defs/<your ZEBRA_LANGUAGE>/sort-string-utf.chr NOT the file in your git clone (yeah, i wasted some time there...) Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:09:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:09:58 +0000 Subject: [Koha-bugs] [Bug 15057] New: Exporting Default Framework results in empty file Message-ID: <bug-15057-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15057 Bug ID: 15057 Summary: Exporting Default Framework results in empty file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To test: - Go to Administration > Bibliographic frameworks - In the default framework line: Export > CSV > Open in <whatever you use> - Note that the file is empty - Repeat for another framework - Note that the export works correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:36:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:36:44 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-hRbz4H75he@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43944&action=edit Bug 14889: QA Follow-up - Removes unused package from BiblioFramework.pm - Makes framework table sortable - Some small changes in wording of error messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:38:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:38:58 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-NZzFBy9MQp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have added a follow-up - but there are 2 things: 1) Please add some unit tests. 2) When you add a new framework with the same frameworkcode than an existing framework, I think it should display the appropriate message, but instead, it updates the existing framework description. On current master, you have a silent SQL erorr in the logs, but the existing framework is left unchanged. (not ideal either...) Otherwise this works quite well, so almost there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:46:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:46:31 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14190-70-if4Ea9uizR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:46:33 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14190-70-WOrOMG2Jg5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43574|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43945&action=edit [PASSED QA] Bug 14190: Scale search boxes in staff head In this simple patch the width gets controlled by CSS and it becomes easy to set it in just one place. The exact width may need to be discussed but I thought 30em made it look ok on my screen. With this patch we get the wider search boxes with a very small change and another bug may be created if needed to do a bigger refactor and remove stuff not needed in the html and perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer will do this) To test: Apply the patch and reload the staff client. Now the search box is a bit wider and the border etc has changed with it. Some places with more than one search box like "Serials" will not be affected. Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 10:48:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 09:48:10 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14190-70-HeSm9oZ8Jx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this is really a question of taste somehow. I am passing this, as it can be easily changed back with a line in IntranetUserCSS and we can see how people like it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:45:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:45:12 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-2JDs1eQvxi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- No problem with the patch itself, but I am not a fan of the name of the class: CommasWithLinebreaks A good rule is not to name classes on appearance, as appearance can change with CSS, but according to what they contain - something that describes that it's the item information for one branch maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:54:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:54:11 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-Fmq7Ain0xH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:54:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:54:14 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-GFwvzYklkK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42807|0 |1 is obsolete| | Attachment #42808|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43946&action=edit [PASSED QA] Bug 11881: Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:57:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:57:05 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-lJZTJBKuMf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43947&action=edit [OPTIONAL] Bug 11881: QA follow-up - rename class A suggestion for renaming the class to be a bit more "content" then "appearance". Strictly optional. .ItemSummary { display: block; # block - line breaks, inline - all one line } .LabelCallNumber { display: inline; # inline - display, none - don't display } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:57:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:57:48 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-Eg8hHrchCg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43946|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43948&action=edit [PASSED QA] Bug 11881: Small improvements for the availability informations in the search results list on the OPAC This patch contains small modifications to the template of OPAC search results. Theses modifications affect the "Availability" line : * Add a linebreak after each location. * Add the text "Call Number:" before call numbers. To test: I) Apply the patch II) Include the following test in the OPACUserCSS preference: .searchresults .CommasWithLinebreaks { display: block; # block - line breaks, inline - all one line } .searchresults .LabelCallNumber { display: inline; # inline - display, none - don't display } III) Do a search on the OPAC IV) Validate : check the format of availability informations for each search result (Breakline or "Call Number:" text). Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:57:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:57:51 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-A2nCB5174i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 --- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43949&action=edit [PASSED QA] Bug 11881 - Small improvements for Items available for reference As said on comment #31, Items available for reference weren't displayed like Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks class and LabelCallNumber class Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 11:57:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 10:57:55 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-evV1NsZs7T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43947|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43950&action=edit [OPTIONAL] Bug 11881: QA follow-up - rename class A suggestion for renaming the class to be a bit more "content" then "appearance". Strictly optional. .ItemSummary { display: block; # block - line breaks, inline - all one line } .LabelCallNumber { display: inline; # inline - display, none - don't display } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 12:37:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 11:37:03 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-Qpv0ynhWFb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #68 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43951&action=edit Bug 12395: QA follow-up - Add class/id to body tag and fix title description - Fixes title attribute for some of the new links - Adds a unique id and a class to the new modal (xt/tt_valid.t) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 12:37:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 11:37:41 +0000 Subject: [Koha-bugs] [Bug 12395] Save order line's creator In-Reply-To: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12395-70-Wohk6Kktf7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 1) xt/tt_valid.t was failing, I fixed it in my follo-up, please check. 1..3 ok 1 - TT syntax: not using TT directive within HTML tag not ok 2 - <body> tag with id and class attributes # Failed test '<body> tag with id and class attributes' # at xt/tt_valid.t line 91. # Files list: # intranet-tmpl/prog/en/modules/acqui/showorder.tt: 12 ok 3 - Token received same as original put on stack # Looks like you failed 1 test of 3. 2) Some of the title="MARC" should be title="Card" - fixed in my follow-up, please check. 3) t/db_dependent/Acquisition/NewOrder.t fails, please fix (blocker) :( I think it's not only the test - in my testing the creator is not saved for newly created orders. Only the 'migrated' orders have created_by set in the database. 1..8 ok 1 - Inserting an order with no params returns undef and croaks ok 2 - Inserting an order with no budget_id returns undef and croaks with expected error message ok 3 - Inserting an order with no biblionumber returns undef and croaks with expected error message ok 4 - Inserting an order with no basketno returns undef and croaks with expected error message ok 5 - Inserting an order with no quantity returns undef and croaks with expected error message ok 6 - Koha::Acquisition::Order->insert set quantityreceivedto 0 if undef is given ok 7 - Koha::Acquisition::Order->insert set entrydate to today not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if not given # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 93. # got: undef # expected: '42' # Looks like you failed 1 test of 8. 4) The 'look' of the new modal for order information is slightly off, especially font and font-size are unusual. Would be nice to be more consistent with Koha's look and feel here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 12:41:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 11:41:25 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14980-70-tVltxXRbS2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |viktor.sarge at regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 12:57:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 11:57:26 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14980-70-fLjcjqIZIn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 43404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43404 Bug 14980 - Add a page showing one news Review of attachment 43404: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14980&attachment=43404) ----------------------------------------------------------------- Some small issues, noted below, and 2 other things: 1) You can access internal news (staff interface) via guessing ids. (blocker) 2) The feature is too hidden for my taste as we don't even show the id internally. A link 'Show in OPAC' or similar could be helpful. I'd also like to encourage you to talk to Viktor Sarge - I know he has been working on adding a 'Mini-CMS' feature to Koha and I think there are already some patches for small steps in that direction available on bugzilla. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt @@ +29,5 @@ > + > + <div id="page-main"> > + <h4 class="newsheader">[% data.title | html %]</h4> > + <div class="newsbody">[% data.new %]</div> > + <div class="newsfooter">(published on [% data.expirationdate %])</div> Please take a look at bugs 14246-14246 - it's a new feature that just passed QA that will allow to also display the author of a news. ::: opac/opac-page.pl @@ +15,5 @@ > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use strict; > +use warnings; Please always use Modern::Perl; @@ +31,5 @@ > + { > + template_name => "opac-page.tt", > + query => $query, > + type => "opac", > + authnotrequired => 1, Please check if this should be: authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 12:57:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 11:57:38 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14980-70-MWgGvIqvti@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 13:01:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 12:01:17 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-fXsd3yXYE1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #20 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to Jonathan Druart from comment #18) > (In reply to Kyle M Hall from comment #17) > > > 6 vs 5 > > > > That is a purposeful change. The issue was that the logic of the unit test > > was off by one. The assumption was that the number of holds must greater > > than or equal to, but as per the code and sys pref definition, the number of > > holds must be simply greater than. Thus adding one more hold fixes all the > > tests. > > (In reply to Jonathan Druart from comment #14) > > > + if ( $holds->count() <= $threshold ) { > > > > And an inclusive here. > > So should this be < also? No, that is the correct comparison. If you look at the descritions for the two high holds behavior options you will see the static ( original ) version requires a < comparison, and the new dynamic versions needs <=. > > ::: Koha/Biblio.pm > > @@ +41,5 @@ > > > +or list of Koha::Item objects in list context. > > > + > > > +=cut > > > + > > > +sub items { > > > > Wouldn't be better to use a DBIx::Class relation? > > Something like bug 14819. No, we want to return a Koha::Object object, not a DBIC object. It would be most confusing if a Koha::Object method were to return a DBIC object instead of a Koha Object. > > What about these 2 comments? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 13:01:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 12:01:33 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-Cnsl0my0xJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 13:03:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 12:03:03 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-JuzwCjOOVa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43952&action=edit Bug 14694 [QA Followup] - Fix syspref order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 13:05:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 12:05:55 +0000 Subject: [Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet In-Reply-To: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12933-70-DeybcZmHUK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43930|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43953&action=edit Bug 12933: QA Followq-up - Add missing notice templates and other small fixes - Fixes page title of slip print window: Members > Patrons - Fixes error message if no notice template is found - Fixes a stray template variable that resulted in the borrower number showing in the 'Print' pull down - Fixes xt/sample_notices.t by adding the sample notice to it-IT and es-ES Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 15:17:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 14:17:20 +0000 Subject: [Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion In-Reply-To: <bug-14376-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14376-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14376-70-vH4Pji5MVZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Matthias, I've taken a look at the code and the GUI, but there are some small and some bigger things bothering me: 1) Display of patron names (trivial) + .append( "<a>" + item.surname + ", " + item.firstname + ", " + item.branch + "</a>" ) Please also think about the case where the patron has no firstname (organisations for example) 2) Logging + my $member = GetMember(borrowernumber => $$suggestion_only{'suggestedby'}); + logaction('ACQUISITIONS', 'MODIFY', undef, 'Suggestion title: ' . $$suggestion_only{'title'} . ", creator: " . + $member->{'surname'} . ', ' . + $member->{'firstname'} . ' (' . + $member->{'cardnumber'} . ')' ); a) I think we need to make more clear about which action in acquisitions this entry is about. I'd suggest to either add a new module 'SUGGESTIONS' or to be more clear about the action: 'MODIFY SUGG' or similar. b) For privacy reasons I am also quite uncomfortable about adding the name in plain text to the logs. We don't need this information if we reference the borrowernumber instead and it will also be better for privacy. For me this is a (blocker). c) Why are you leaving the object undef? I feel like this should be the suggestion id. Then we could just have the borrowernumber in the description. All other information can easily be found. d) I think the new logging needs to be covered by a system preference to be consistent with current practice. -- Don't misunderstand me - I really think we should do more nice logging! But I think we should try to avoid some of the problems we had with it in the past. One idea might even be to add a new column to action_logs to be able to store another id in a better way (user, object, affected_user?) 3) GUI I'd prefer the way patron search is done in other places taking place in a separate pop-up or modal. Because it offers a better overview for libraries with a lot of patrons and better options to limit search. An example would be the way it's done for searching patrons to be notified about an order (when creating an order line). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 15:44:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 14:44:14 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-DgIpIFNNOR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 43831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43831 Bug 14310 - Suspend and resume indvidual holds from patron holds table Review of attachment 43831: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14310&attachment=43831) ----------------------------------------------------------------- Hi Kyle, I have patches from the 2 dependent bugs and this one. QA script is clean, but code review and testing showed 2 big problems: 1) Suspending holds doesn't work for me, clicking on Suspend with or without a date - nothing happens. Tested from /cgi-bin/koha/members/moremember.pl?borrowernumber=1 Firebug: Post: reserve_id=407&suspend_until=31%2F10%2F2015 Response: <!-- TEMPLATE FILE: 500.tt --> error page. 2) Almost all the new strings are not translatable, because they are trapped inside the .js file. ::: koha-tmpl/intranet-tmpl/prog/en/js/holds.js @@ +129,5 @@ > + if ( oObj.found ) { > + return ""; > + } else if ( oObj.suspend == 1 ) { > + return "<a class='hold-resume btn btn-link' id='resume" + oObj.reserve_id + "' style='display: inline; white-space: nowrap;'>" > + + "<i class='icon-play'></i> " + _("Resume") + "</a>"; .js files are not translatable - we need to move the strings to the templates or find another solution to this. @@ +132,5 @@ > + return "<a class='hold-resume btn btn-link' id='resume" + oObj.reserve_id + "' style='display: inline; white-space: nowrap;'>" > + + "<i class='icon-play'></i> " + _("Resume") + "</a>"; > + } else { > + return "<a class='hold-suspend btn btn-link' id='suspend" + oObj.reserve_id + "' style='display: inline; white-space: nowrap;'>" > + + "<i class='icon-pause'></i> " + _("Suspend") + "</a>"; Same as above, and many more below. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 15:44:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 14:44:25 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-vYVoK3aRzD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 16:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 15:00:15 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-QqExX4MDL8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Not much help here I am afraid, but adding to the weirdness. Tests passed the second time I ran them, then they kept failing constantly. Additional weirdness: it's not always the same tests failing: Sometimes: perl t/db_dependent/HoldsQueue.t ... not ok 23 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 337. # got: '1' # expected: '2' Other times: perl t/db_dependent/HoldsQueue.t ... not ok 21 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 320. # got: '2' # expected: '1' ok 22 - Holds queue filling correct number for holds for default holds policy 'from any library' not ok 23 - Holds not filled with items from closed libraries # Failed test 'Holds not filled with items from closed libraries' # at t/db_dependent/HoldsQueue.t line 337. # got: '3' # expected: '2' ok 24 - Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch # Looks like you failed 2 tests of 24. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 17:17:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 16:17:49 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: <bug-14946-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14946-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14946-70-XGUtxgXnxT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43144|0 |1 is obsolete| | --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 43954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43954&action=edit Bug 14946 - Remove C4::Dates from files acqui/*.pl This patch removes C4::Dates from: - acqui/histsearch.pl - acqui/invoice.pl - acqui/invoices.pl - acqui/orderreceive.pl - acqui/parcel.pl - acqui/parcels.pl - acqui/transferorder.pl To test: - Apply patch - Go to Home > Acquisitions > Invoices - Verify that Search filters work OK - Edit an invoice - Verify that Shipment date and Billing date display OK and edit / save is OK - Receive shipment for a vendor - Verify that Shipment date behaves OK and that you can filter list of shipents for this vendor - Transfer an item from a basket to another vendor Amended to make patch apply 25.10.2015/mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 17:20:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 16:20:20 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: <bug-14946-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14946-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14946-70-VnS7bATIWB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 17:36:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 16:36:53 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-BdbuJiGvAN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43163|0 |1 is obsolete| | --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 43955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43955&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 17:37:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 16:37:14 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-Qav87GY6t9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 18:03:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 17:03:26 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: <bug-14985-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14985-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14985-70-rlyVWxOwgF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove C4::Dates from files |Remove C4::Dates from 6 |in folder C4/*.pm (part |files in folder C4/*.pm |one) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 18:22:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 17:22:55 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-Y2yJvova4D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43427|0 |1 is obsolete| | --- Comment #8 from Marc V?ron <veron at veron.ch> --- Created attachment 43956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43956&action=edit Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 18:23:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 17:23:29 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-a6E3hYqxHc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:06:22 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-W9PVdm6pcB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43410|0 |1 is obsolete| | --- Comment #8 from Marc V?ron <veron at veron.ch> --- Created attachment 43957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43957&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) (Amended following comment #7 / 25.10.2015 / mv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:06:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:06:43 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-CV3WXvZwT6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:33:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:33:40 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-wUEjGe7WfU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #12 from Marc V?ron <veron at veron.ch> --- (In reply to Mirko Tietgen from comment #9) (...) > ....using wrong preset dates in the URL like > circulation.pl?borrowernumber=51&duedatespec=10%2F30%2F2015+23%3A59 > > While the old version shows warnings or even breaks ("30" in the "month" > position leads to a software error because it is not between 1 and 12), with > your patch the wrong format passed by URL is displayed in the calendar, but > no warnings or errors appear and the correct date is used when checking out. (...) MV: Found, will be fixed in amended patch: Date will not be displayed if params do not result in a correct date. > (In reply to Marc V?ron from comment #6) > > > - Verify that data displays properly (including for users with a card > > that expires in the near future, see syspref 'NotifyBorrowerDeparture') > > That breaks it for me: > > > Template process failed: undef error - KohaDates: filter not found at /home/mirko/koha/C4/Templates.pm line 121. (...) MV: Found, was due to a typo, will be fixed in amended patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:38:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:38:20 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-2myvDlwKWJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43303|0 |1 is obsolete| | --- Comment #13 from Marc V?ron <veron at veron.ch> --- Created attachment 43958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43958&action=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more) Patch to remove deprectated C4::Dates from: - circ/circulation.pl - C4/Circulation.pm - koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Search for regressions - prove -v t/db_dependent/Circulation.t (Amended following comment #9 / #11 25.10.2015 /mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:38:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:38:53 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-x1d0vIMiT4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:40:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:40:50 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14870-70-docoZFwfcQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #3 from Marc V?ron <veron at veron.ch> --- 13 patches left to sign-off as of today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 20:45:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 19:45:02 +0000 Subject: [Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy In-Reply-To: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12072-70-KyiiP8vHUW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 --- Comment #36 from Marc V?ron <veron at veron.ch> --- Depends on 13 bugs left to sign off as of today (see list in Bug 14870). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:17:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:17:50 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-I6cK2bLdCN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43959&action=edit [PASSED QA] Bug 13696 [QA Followup] - Add Font Awesome license to the about page Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:17:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:17:55 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-QMQUfsDEbg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43960&action=edit [PASSED QA] Bug 14915 - Use Font Awesome instead of Glyphicons for the staff intranet We should be using Font Awesome for our icons instead of Glyphicons, for the reasons discussed on bug 13696. Test Plan: 1) Apply this patch 2) Note all Glyphicons have been replaced with FA icons in the staff intranet 3) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/modules/ should give no results 4) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/includes/ should give no results Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> We need a follow-up to cover the files changes since this patch was written. Especially to cover the changes in the label creator modules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:17:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:17:58 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-0nXyRxqnZ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43961&action=edit [PASSED QA] Bug 14915 [QA Followup] - Tweak '+' icon for serials-home Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:02 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-0QXQMCpzXV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43962&action=edit Bug 14915: QA Follow-up - Replace fa-remove-sign with fa-times-circle Noticed that an icon was missing in the templates. Replaced fa-remove-sign with same-looking fa-times-circle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:05 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-GYX2EUkqlP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43963&action=edit Bug 14915: QA Follow-up - Replace fa-hdd with fa-save Alternative patch to using hdd-o. As the Font Awesome Icon is different to what we used before, an alternative could be switching back to the 'classic' symbol for save. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:08 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-lG7nYE481d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43964&action=edit Bug 14915: QA Follow-up - Replace fa-downlowd-alt with fa-download Fixes non-existing fa-download-alt by using fa-download instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:11 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-nVXNaWAZGC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43965&action=edit Bug 14915: QA Follow-up - Replace fa-zoom-in and fa-zoom-out Same icons don't appear to exist for Font awesome. Replaced with fa-folder and fa-folder-open for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:14 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-4SBtdaM34B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43966&action=edit Bug 14915: QA Folloq-up - Replace fa-merge with fa-compress Another icon that doesn't quite exist in Font Awesome - this is starting to get a bit troublesome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:17 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-jXgY8tZwA7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43967&action=edit Bug 14915: [FA 4.4] QA Follow-up - Replace fa-hold with fa-sticky-note-o Ok, this is a fun one: There is no icon like our current hold icon in Font Awesome. So I picked fa-sticky-note-o for a replacement. But since this is a new one, it doesn't exist in Koha yet. I found no better match and the patch was already written... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:18:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:18:20 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-EeVjkYhRxi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43968&action=edit Bug 14915: QA Follow-up - Replace fa-time with fa-clock-o Icon looks almost the same, just has a different name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:19:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:19:46 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-UbR2TA9Hgo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:19:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:19:48 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-UdFAXpbDx2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:19:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:19:52 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-fwv5xxhFiO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43959|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:19:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:19:50 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-SyTTPbDhiw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:28:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:28:07 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-poJxGNoreg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #22 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Some comments about this: - It looks like the patch assumed that the file names from Glyphicons and Font Awesome would match. They do not. This led to a bit of silliness in QA follow-ups... (7). - Not always there is an equivalent icon available in Font Awesome. I have tried to pick an icon close to our original one or come up with a good alternative suggestion - the ones that changed most would be (Glyphicon name): hdd, zoom-in, zoom-out, hold. - Especially hold is a hard one - the best I could come up with was sticky-note-o. But then I learned that this was only added in Font Awesome 4.4, while bug bug 13696 adds 4.3. The patch is marked - the result is the same with and without the patch currently - no icon shown. - The git grep ... statements given in the first patch now come back 'non-empty' - as we have added more icons with some of the new features being pushed. Most of the files seem to belong to the label creators. It would be good to follow-up on those and others before release. I like that the Font Awesome Icons look nicer - less pixelated than our current ones, especially if you zoom in. But there are some catches like that we have to replace some of the icons. Leaving to RM for final decision and review/pushing back to QA :) My recommendation would be to update to 4.4 (makes sense to start with the newest set) and to do follow-ups once the new features have been pushed to fix the remaining or newly introduced icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:37:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:37:15 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: <bug-3886-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3886-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3886-70-NI5CSMe4ps@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:37:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:37:27 +0000 Subject: [Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission In-Reply-To: <bug-3886-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3886-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3886-70-fY9FoikvH9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:38:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:38:28 +0000 Subject: [Koha-bugs] [Bug 2601] Order fines by date and time In-Reply-To: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2601-70-KK3SqkMNE3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:38:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:38:37 +0000 Subject: [Koha-bugs] [Bug 2601] Order fines by date and time In-Reply-To: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2601-70-goegbc6rNa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:49:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:49:08 +0000 Subject: [Koha-bugs] [Bug 4158] cannot create list whose title is '0' In-Reply-To: <bug-4158-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4158-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4158-70-PgrtcArUyh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:49:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:49:17 +0000 Subject: [Koha-bugs] [Bug 4158] cannot create list whose title is '0' In-Reply-To: <bug-4158-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4158-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4158-70-r6Yi9LnQ8h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:51:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:51:39 +0000 Subject: [Koha-bugs] [Bug 14725] Searching by Author limited to 245$c on Koha 3.12.04.000 In-Reply-To: <bug-14725-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14725-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14725-70-GQQfnLaXx2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14725 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jesus, I know this is working in current versions of Koha - please reopen if you still experience problems in later versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Oct 25 23:54:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 22:54:21 +0000 Subject: [Koha-bugs] [Bug 15058] New: Update German web installer sample files for 3.22 Message-ID: <bug-15058-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Bug ID: 15058 Summary: Update German web installer sample files for 3.22 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr, mirko at abunchofthings.net, veron at veron.ch The same procedure as ... every 6 months... :) We need to check the files are still all good and translate anything that was added since last version. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 00:15:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 23:15:37 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-i5mUNN9zQw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #177 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Some late (sorry!) first notes on this: 1) Please check with the QA script, it's noting several problems. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt FAIL forbidden patterns forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 6) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc FAIL forbidden patterns forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 43) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 1) forbidden pattern: tab char (line 45) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 7) forbidden pattern: tab char (line 50) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 3) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 4) forbidden pattern: tab char (line 47) forbidden pattern: intranet-tmpl should certainly replaced with [% interface %] (line 2) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 46) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 51) FAIL cataloguing/editor.pl FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) ... and also some problems with tabs. 2) Please add the newly added Javascript libraries with their license to the listing on the about page. I saw: codemirror-compressed.js filesaver.js require.js 3) Pretty please: Resort in a logical way - for now copying the old sequence would be nice. Alphabetic sorting doesn't work in I18N environments and it's not very practical - author and title being far apart Also... current sorting is not even alphabetical (publication date) :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 00:26:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 25 Oct 2015 23:26:25 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11297-70-WZ46cQYXIo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #23 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #22) > Hi David, > thx for the quick reply and the examples - I'll say that reasolved that > point in my list. Your examples would be great for the help page. I keep meaning to update the manual and help pages in regards to Zebra and Z39.50... I'll keep this on my to do list! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 02:37:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 01:37:09 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-9YwrMcyoQ4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #178 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 43969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43969&action=edit Bug 11559: (QA followup) fix QA issues This fixes the following: * License of editor.pl * Remove tabs * Use [% interface %] * Re-order search fields like the old interface * Add license information for new libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 03:11:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 02:11:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-YxNWGCZpW7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #179 from Nicole Engard (ByWater) <nicole at bywatersolutions.com> --- Great job Jesse and Katrin! Three years in the making - let's get this in to 3.22 for production testing!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 07:33:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 06:33:40 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: <bug-14248-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14248-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14248-70-NChyV24qo8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #25 from Viktor Sarge <viktor.sarge at regionhalland.se> --- Thanks Katrin! We don't use title either, but we solved that by removing the field in the "add patron" form and without any value in the field things display ok without having to mod other areas/reports that includes title. I like the span approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 07:38:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 06:38:10 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: <bug-14248-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14248-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14248-70-PjXqDCz26X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I was not sure if it was from your specification that it showed up in the patch - so I didn't want to remove it totally. We still could I guess - it will show now by default until you remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:06:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:06:32 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-mLkB8h1Knx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #180 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jesse, thx for the follow-up! I tried to use the macro editor but I am having problems with the indicators. I used the example from the wiki and switched out the subfield indicator: new 500=_ _ ?a Edited with Rancor This creates the field with 4 indicators (guess the wiki is wrong :)) Next try: new 500a=Edited with Rancor indicators=1_ I deleted the field again and tried to rerun the macro with a change, but now nothing happens whenever I run it. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:10:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:10:39 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-NwKFH7wYrj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #181 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, not sure that comment made sense, so trying again: - Tried example from the wiki - didn't quite work - Read further and changed it, kinda worked - Tried to repeat... broke the macro editor... now it won't do anything for me :( - Tried shift reload and reopening the page etc... still not working What's peep under settings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:14:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:14:40 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14982-70-8ydkSJ8kpq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:14:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:14:52 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14982-70-oNC1uQHKA4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43283|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 43970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43970&action=edit Remove C4::Dates from guided report wizard and dictionary This patch removes C4::Dates from files: - reports/guided_reports.pl - reports/dictionary.pl - C4/Reports/Guided.pm To test: - Go to Home > Reports > Guided reports wizard - Then go to 'View Dictionary' (menue at teh left) - Click 'New definition' and step through - In step 2. select e.g. borrowers - In step 3 select a date field - In step 4, select date range and test start / end dates - In step 5, verify that dates display properly - Save and verify that dates are insertet properly in sql definition - Go back to Home > Reports > Guided reports wizard - Step through the wizard and verify that it works as before. http://bugs.koha-community.org/show_bug.cgi?id=14982 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:20:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:20:41 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14982-70-2e2rBiigBa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:20:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:20:44 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14982-70-bWFyETUcDp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43970|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 43971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43971&action=edit [PASSED QA] Remove C4::Dates from guided report wizard and dictionary This patch removes C4::Dates from files: - reports/guided_reports.pl - reports/dictionary.pl - C4/Reports/Guided.pm To test: - Go to Home > Reports > Guided reports wizard - Then go to 'View Dictionary' (menue at teh left) - Click 'New definition' and step through - In step 2. select e.g. borrowers - In step 3 select a date field - In step 4, select date range and test start / end dates - In step 5, verify that dates display properly - Save and verify that dates are insertet properly in sql definition - Go back to Home > Reports > Guided reports wizard - Step through the wizard and verify that it works as before. http://bugs.koha-community.org/show_bug.cgi?id=14982 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:26:19 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14982-70-9kvcaqc68n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Josef! Looking forward to see the C4::Dates removal finished! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:43:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:43:08 +0000 Subject: [Koha-bugs] [Bug 15059] New: Line break in html attribute Message-ID: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Bug ID: 15059 Summary: Line break in html attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:43:14 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-p0kxHNsNFx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:45:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:45:20 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14961-70-hORGi5ZKCS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 08:45:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 07:45:30 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14961-70-BqBcdHUcGj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43150|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 43972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43972&action=edit Bug 14961 - Remove C4::Dates from files reports/*_stats.pl Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl To test: - Go to Home > Reports - Verify that following reports work as before: - Other > Average loan time - Statistic wizards - Acquisitions - Patrons - Circulation - Serials - Holds Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:19:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:19:02 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-2LlbBZTQQB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- In "Patrons with the most checkouts" report (reports/bor_issues_top.pl) doesn't work filter for checked-out and checked-in dates... Other reports works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:19:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:19:18 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14961-70-oH3XbNIHh3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:23:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:23:58 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-xNcmWJReD0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:24:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:24:00 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-LKm1eFZ4Ay@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 43973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43973&action=edit Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:31:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:31:30 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-9OnOWQBQmi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #40) > (In reply to Jonathan Druart from comment #39) > > (In reply to Kyle M Hall from comment #38) > > > Created attachment 43833 [details] [review] [review] [review] > > > Bug 12803 [QA Followup] - Fix unit tests > > > > This is a bit radical and I would like to know why it fails. > > I don't understand why adding 1 biblio to the DB makes your tests failing. > > I wish I could help you find out why, but I can't seem to reproduce your > error! I tried with 1 bib and 0, 1 and 2 items. There must be something else > going on in your database . If you can send me a copy of your test database > I'll give it a shot! I used the DB generated by bug 10337. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:57:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:57:14 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-U78lZ44bms@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:57:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:57:16 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-McBV4BqDc8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 43974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43974&action=edit Bug 14889: Fix error msg on duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 09:57:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 08:57:19 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-2yQfZKHK2n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 43975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43975&action=edit Bug 14889: Add tests for Koha::BiblioFramework[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:04:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:04:18 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14961-70-KJcBWL7NfA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:04:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:04:20 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14961-70-dM1gL6PNzP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43972|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 43976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43976&action=edit Bug 14961 - Remove C4::Dates from files reports/*_stats.pl Remove C4::Dates from following files: - reports/acquisitions_stats.pl - reports/borrowers_stats.pl - reports/reserves_stats.pl - reports/serials_stats.pl - reports/issues_avg_stats.pl - reports/issues_stats.pl To test: - Go to Home > Reports - Verify that following reports work as before: - Other > Average loan time - Statistic wizards - Acquisitions - Patrons - Circulation - Serials - Holds Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:10:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:10:11 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-CNarZ8mPvu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #192 from Julian Maurice <julian.maurice at biblibre.com> --- I'm having problems with the latest patches When I go to http://pro.koha-dev/api/v1/patrons/7680, error: Can't use string ("error.json") as a HASH ref while "strict refs" in use at /usr/local/share/perl/5.14.2/JSON/Validator.pm line 515. If I remove patch "Followup: Refactor spec file", another error: {"errors":[{"path":"\/","message":"Controller could not be loaded."}]} Then, if I remove patch "Followup: x-mojo-controller deprecation", everyting is ok. $ pmvers JSON::Validator 0.59 $ pmvers Swagger2 0.60 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:25:01 +0000 Subject: [Koha-bugs] [Bug 15040] Plack testing -- patron files area not behaving as expected In-Reply-To: <bug-15040-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15040-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15040-70-x9tPHifkkp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15040 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME CC| |josef.moravec at gmail.com Status|NEW |RESOLVED --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- I can't reproduce it, everything around upload patron files works as expected for me... So I'm closing it. If you think it's still valid, please reopen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:25:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:25:01 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: <bug-15019-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15019-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15019-70-VyFrXMZyoE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Bug 15019 depends on bug 15040, which changed state. Bug 15040 Summary: Plack testing -- patron files area not behaving as expected http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15040 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:31:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:31:18 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: <bug-15010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15010-70-9jqEjcnQKq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:31:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:31:21 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: <bug-15010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15010-70-yQbicI87mP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43607|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 43977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43977&action=edit Bug 15010 - Import patron tool creates 'duplicate' restrictions ( debarments ) If a patron has restrictions and a CSV file of patrons to be overwritten is uploaded but has no debarred / debarredcomment columns, the a new restriction will be added that combines all the existing restrictions ( i.e. a new debarment based on the existing borrowers.debarred and borrowers.debarredcomment fields ). Test Plan: 1) Create a patron with one or more restrictions 2) Import a CSV file that updates that patron, but with no debarred columns 3) Note a new restrictions is created 4) Delete the new restriction 5) Apply this patch 6) Re-import the CSV file again 7) Note that no new restriction is created 8) Add debarred and debarredcomment columns to the CSV file with a test date and description 9) Re-import the CSV file again 10) Note the new restriction is added to the patron Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Daniel Grobani <dgrobani at samuelmerritt.edu> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:39:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:39:46 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14980-70-h8AmYkKuwZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 Viktor Sarge <viktor.sarge at regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xarragon at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:41:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:41:54 +0000 Subject: [Koha-bugs] [Bug 14980] Add a page showing one news In-Reply-To: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14980-70-ozMK0seA7x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980 --- Comment #16 from Viktor Sarge <viktor.sarge at regionhalland.se> --- Nice idea. I added Martin Persson to the CC-list since he has developed something similar during our project, but I'm not shure if there is any Buzilla thread for it. We want to expand the news with an news archive as well + some other patches making the news a plausible replacement for a separate blog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 10:46:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 09:46:28 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-FQcel8zvyH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #17) > (In reply to Jonathan Druart from comment #16) > > Barton, have you seen my suggestion on comment 12? > > I think it will be really easy to implement what you want using it (no > > change in pm and no additional tests). > > While your suggestions would definitely work, I think what Barton's changes > are a good and worthwhile improvement. The logic to for deciding if an item > is deletable should definitely be separate from the actual deleting of > items, and now we've got more through unit tests as well! Yes maybe you are right but we are adding 1 new subroutine and lot of code when the 2 start_transaction/rollback lines would make the job. Anyway, if you really want this way, I have still some concerns: 1/ Tests should create their own data (branchcode/categorycode), it is easier to use TestBuilder for that. 2/ I don't think a subroutine should take a do_not_commit parameter, this should not do it in the subroutine but from the scripts. Keeping the signed off status to get feedback from other QAers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:16:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:16:05 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-RNhDHF7ztV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #6 from Marc V?ron <veron at veron.ch> --- Hi Josef, I just tested with patch applied: Checkout date from: 01/01/2015 ... To: 31/10/2015 Check-in date from: 01/01/2015 ... To: 31/10/2015 Any library / Itemtype / Category Limit: 5 By: None It worked. What did you use for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:17:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:17:03 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-28w3x3FxpT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- - You should extract the less/css changes from the mainpage. - There is still something wrong with the radio buttons on the modal window (staff). - export oai-dc: in opac/oai.pl we use HTTP::OAI::Metadata::OAI_DC, so now we will have 2 differents module to do the same job? I am not familiar enough with Dublin core to know what to do with the UNIMARC export and validate it works well for other flavors. Fr?d?ric (cced), Is there any chance to get your opinion on this enhancement? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:29:48 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: <bug-13665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13665-70-UhXc1lLrpT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Have we reported this upstream at all? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:40:21 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-FBRhD194j3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43978&action=edit Bug 14310 [QA Followup] - Enable translations, set svc script to be executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:40:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:40:33 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-xxCvOg1q0k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:57:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:57:46 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-3UIVeuvuqC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #43 from Kyle M Hall <kyle.m.hall at gmail.com> --- Created attachment 43979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43979&action=edit Test Database SQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:59:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:59:23 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-nqPagDjGXB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #44 from Kyle M Hall <kyle.m.hall at gmail.com> --- Please try running the unit tests against the attached Test Database SQL file. I've run the unit test hundreds of times with this database and got no errors. I am very interested to see if you get any errors using the same database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 11:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 10:59:56 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-IbVwWTpPcV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #193 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 43980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43980&action=edit Bug 13799: Followup of "Followup: Refactor spec file" Fix Swagger2 definitions file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:00:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:00:02 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Y0oMlDxaST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #194 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 43981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43981&action=edit Bug 13799: Followup of "Followup: x-mojo-controller deprecation" Rename controller Koha::REST::V1::Patrons to Koha::REST::V1::Patron so Swagger2 can find it Also remove most of the "type" specifications in patron schema object, since most of the fields can be null, and Swagger2 does not support anyOf nor oneOf -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:00:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:00:36 +0000 Subject: [Koha-bugs] [Bug 12785] OPAC normal view displays unwanted ISBD punctuation In-Reply-To: <bug-12785-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12785-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12785-70-kRZsDrsEfs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12785 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED CC| |z.tajoli at cineca.it --- Comment #4 from Zeno Tajoli <z.tajoli at cineca.it> --- To have the best display you need to adapt visalization with the avaible sys pref and xslt personalization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:01:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:01:19 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-i24lkSmFNy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:12:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:12:37 +0000 Subject: [Koha-bugs] [Bug 15007] Slips and notices table 'letters' should have an 'id' primary key column In-Reply-To: <bug-15007-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15007-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15007-70-xuha06Fxz6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15007 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Kyle M Hall <kyle.m.hall at gmail.com> --- This idea actually makes no sense with the current letters schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:19:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:19:02 +0000 Subject: [Koha-bugs] [Bug 14584] Encoding broken with system preferences In-Reply-To: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14584-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14584-70-lijXJh2Y1l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #11 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- (In reply to Jonathan Druart from comment #6) > Should be backported to 3.20, not 3.18! Seems to have been pushed in 3.18.11 despite Jonathan's comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:21:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:21:04 +0000 Subject: [Koha-bugs] [Bug 15060] New: Setup standard ISBD view Message-ID: <bug-15060-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15060 Bug ID: 15060 Summary: Setup standard ISBD view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org For MARC21 setups the default sys prefer ISBD doesn't create a standard ISBD in title area. Now the default is: #245||{ 245a }{ 245b }{245f }{ 245g }{ 245k }{ 245n }{ 245p }{ 245s }{ 245h }|\r\n #246||{ : 246i }{ 246a }{ 246b }{ 246f }{ 246g }{ 246n }{ 246p }{ 246h }|\r\n #242||{ = 242a }{ 242b }{ 242n }{ 242p }{ 242h }|\r\n #245||{ 245c }|\r\n #242||{ = 242c }|\r\n We mix 245 tag in 242 (Translation of Title by Cataloging Agency) and 246 (Varying Form of Title). I think is very difficult to have valuse in 242 and/or 256 with an empty 245. I suggest to insert only #245||{ 245a }{ 245b }{245f }{ 245g }{ 245k }{ 245n }{ 245p }{ 245s }{ 245h }|\r\n #245||{ 245c }|\r\n in default sys pref ISBD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:39:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:39:38 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-Fl8oxjX8vR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #44) > Please try running the unit tests against the attached Test Database SQL > file. I've run the unit test hundreds of times with this database and got no > errors. I am very interested to see if you get any errors using the same > database. I confirm that it fails here. I am using mysql Ver 15.1 Distrib 10.0.19-MariaDB, for debian-linux-gnu (i686) using readline 5.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:43:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:43:34 +0000 Subject: [Koha-bugs] [Bug 15061] New: Can't add item to rotating collection Message-ID: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Bug ID: 15061 Summary: Can't add item to rotating collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Everytime you enter barcode to add it to rotating collection, you get an error message: "Failed to add item with barcode xxx: NO_ID" Also, in empty collection you see table with items, but only with one empty row... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:43:42 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15061-70-vR7kgeT9Xe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:43:42 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: <bug-15019-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15019-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15019-70-sMglwPsqiC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15061 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 [Bug 15061] Can't add item to rotating collection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:47:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:47:05 +0000 Subject: [Koha-bugs] [Bug 13665] Retrieve facets from zebra is slow In-Reply-To: <bug-13665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13665-70-RraoUaV8bM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13665 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Martin Renvoize from comment #2) > Have we reported this upstream at all? I don't think so. The main problem is that we are retrieving each facet at a time. This gets really better when we retrieve all facets at once. The problem is that if you ask for a setSpec containing all facets, and one is empty, then the result is empty. I've tried to patch zebra for that, but didn't finish it. The IndexData guys didn't seem to accept such a solution anyway. The best approach IMO is to make rebuild_zebra.pl create phantom entries for all facets. But didn't have the time and memory to do it. PS: When we first tried zebra facets in Reno, they were really better speed-wise. I think something changed between 2.0.47 and 2.0.60 that made them worse. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 12:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 11:58:38 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12803-70-mpzpIeTAV9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I was using Ubuntu with MySQL - using my 'normal' db with quite a bit of test data by now. Not sure we can find the 'common' thing for those who fail and does who fail not easily :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:05:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:05:58 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-XtCJGwWFtf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14321 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This seems to be caused by bug 14321 The errors in the logs are: binmode() on closed filehandle _GEN_2 at /home/vagrant/kohaclone/C4/Templates.pm line 120. seek() on closed filehandle _GEN_2 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 32. Can't seek stdout handle: Bad file descriptor at /usr/share/perl5/Plack/App/WrapCGI.pm line 87. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:05:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:05:58 +0000 Subject: [Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload In-Reply-To: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14321-70-Qj9OVxRMZN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15032 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:16:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:16:21 +0000 Subject: [Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! In-Reply-To: <bug-14932-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14932-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14932-70-QW7a51GgmX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:16:49 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-lsQ1vt1WOd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #195 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Removing 'type' from the definitions removes validation of the requests and responses.. that loses 2/3rds of the reason for using swagger with the final 3rd being the documentation of the api which by removing 'types' your also massively limiting the usefulness of. If we're not using 'null' as a meaningful value then we should not be using it at all. Also, the definitions still do not contain a 'requires' block which should really be present to show what fields are always required. For a fully restful api, this would be all of them for POST, PUT and GET as rest is all about dealing with full documents. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:21:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:21:51 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-fhmUgVRm0v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #8) > This seems to be caused by bug 14321 Not sure actually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:27:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:27:06 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-NDvHJaMqfy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 43982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43982&action=edit Bug 1433: followup 2 - split line to ease translation This patch only put in its own line inserted values. This is necessary in order to translate this files. To test: 1) Just check that files load normally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:27:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:27:59 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-SsxzsbWf3h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43982|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 43983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43983&action=edit Bug 14333: followup 2 - split line to ease translation This patch only put in its own line inserted values. This is necessary in order to translate this files. To test: 1) Just check that files load normally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:30:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:30:43 +0000 Subject: [Koha-bugs] [Bug 15062] New: Holds queue with Transport Cost Matrix will transfer item even if transfers disabled Message-ID: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Bug ID: 15062 Summary: Holds queue with Transport Cost Matrix will transfer item even if transfers disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:30:50 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15062-70-VzsWebJEGT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:35:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:35:02 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15062-70-kAwQphFUSB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43984&action=edit Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:35:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:35:00 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15062-70-kQokWfKxEw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:42:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:42:32 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11626-70-ka33EQvPUm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 43985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43985&action=edit Bug 11626 - Cannot receive serial issues after subscription expiry date Some of our serials subscriptions were not renewed after 31/12/2013 but I cannot receive any of the outstanding 2013 issues unless I renew the subscription record (a couple of publishers are about 3 months late with their printing/postage schedules compared to the subscription/cover dates). We should still be able to receive late issues after the subscription expiry date (the date published for these issues would in most cases be on or before the expiry date). THIS PATCH: Changes expiration date checking for each serial to be calculated from the individual Serial's serial.publicationdate instead of the Serial's Subscription's expirationdate. Thus you can still receive late serials if their publicationdate is within the Subscription period. Replicating this issue in finicky, just as the Serials module is, but this patch fixes this design flaw in the Serials-module. REPLICATE THE ISSUE: 0. Have a Subscription with an end date. 1. Receive all the Subscription's Serials. 2. You cannot receive the last Serial of the subscription period. TEST PLAN: 0. Have a Subscription with an end date. 1. Receive all the Subscription's Serials. 2. Receive the last Subscription of the subscription period. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:43:00 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11626-70-b8IHTsTTGl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:44:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:44:20 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11626-70-kYN24jNuI6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Failing QA because of missing test. Good luck creating the test context without Bug 13906. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:45:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:45:22 +0000 Subject: [Koha-bugs] [Bug 15063] New: Update MARC21 es-ES frameworks to Update 21 (September 2015) Message-ID: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Bug ID: 15063 Summary: Update MARC21 es-ES frameworks to Update 21 (September 2015) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Update fields and translations of es-ES frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:59:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:59:25 +0000 Subject: [Koha-bugs] [Bug 11626] Cannot receive serial issues after subscription expiry date In-Reply-To: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11626-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11626-70-lZDsbcy9E5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11626 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43985|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 43986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43986&action=edit Bug 11626 - Cannot receive serial issues after subscription expiry date Added an eval block to not die if timestamp parsing fails -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 13:59:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 12:59:34 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Y9SoPNK1qa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43981|0 |1 is obsolete| | --- Comment #196 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 43987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43987&action=edit Bug 13799: Followup of "Followup: x-mojo-controller deprecation" Rename controller Koha::REST::V1::Patrons to Koha::REST::V1::Patron so Swagger2 can find it Also change most of the "type" specifications in patron schema object, since most of the fields can be null. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:04:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:04:44 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-1GvSTxNLf5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_22_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:06:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:06:15 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Bf0gbyTp2l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #197 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Started writing some guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines_-_API Still very much a work in progress -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:09:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:09:01 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-H5zgCwsxRQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #198 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- My current feeling now is that this is a great base and should be pushed sooner rather than later. I expect as we refine the guidelines and documentation I will continue to update the Patrons route to conform to the evolving guidelines. As such, I don't see any of the outstanding comments being blockers for the push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:16:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:16:33 +0000 Subject: [Koha-bugs] [Bug 11780] Need to prevent specific fields from being overwritten with z39.50 import In-Reply-To: <bug-11780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11780-70-4l8n0ZgoKH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin at bugs.koha-community. | |org.xinxidi.net --- Comment #1 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Related to bug 14957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:16:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:16:46 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15063-70-S7a1TZe5EA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 43988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43988&action=edit Bug 15063: Update MARC21 es-ES frameworks to Update 21 (September 2015) This patch put in sync es-ES marc21 fields/subfields with english ones. To test: 1) Apply the patch 2) Remove all bib/auth frameworks 3) Load all files, check they load without errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:17:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:17:34 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-d481joWASm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #199 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to Martin Renvoize from comment #198) > My current feeling now is that this is a great base and should be pushed > sooner rather than later. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:18:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:18:54 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15063-70-KbDNn1yKn2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:37:47 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-b9kiRFbcOs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:37:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:37:52 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-p2DDetwoJ7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43204|0 |1 is obsolete| | Attachment #43205|0 |1 is obsolete| | Attachment #43206|0 |1 is obsolete| | Attachment #43207|0 |1 is obsolete| | Attachment #43208|0 |1 is obsolete| | Attachment #43209|0 |1 is obsolete| | Attachment #43210|0 |1 is obsolete| | Attachment #43211|0 |1 is obsolete| | Attachment #43212|0 |1 is obsolete| | Attachment #43213|0 |1 is obsolete| | Attachment #43214|0 |1 is obsolete| | Attachment #43980|0 |1 is obsolete| | Attachment #43987|0 |1 is obsolete| | --- Comment #200 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43989&action=edit [PASSED QA] Bug 13799: RESTful API with Mojolicious and Swagger2 Actual routes are: /borrowers Return a list of all borrowers in Koha /borrowers/{borrowernumber} Return the borrower identified by {borrowernumber} (eg. /borrowers/1) There is a test file you can run with: $ prove t/db_dependent/rest/borrowers.t All API stuff is in /api/v1 (except Perl modules) So we have: /api/v1/script.cgi CGI script /api/v1/swagger.json Swagger specification Change both OPAC and Intranet VirtualHosts to access the API, so we have: http://OPAC/api/v1/swagger.json Swagger specification http://OPAC/api/v1/{path} API endpoint http://INTRANET/api/v1/swagger.json Swagger specification http://INTRANET/api/v1/{path} API endpoint Add a (disabled) virtual host in Apache configuration api.HOSTNAME, so we have: http://api.HOSTNAME/api/v1/swagger.json Swagger specification http://api.HOSTNAME/api/v1/{path} API endpoint Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be able to pass it to Mojolicious Test plan: 1/ Install Perl modules Mojolicious and Swagger2 2/ perl Makefile.PL 3/ make && make install 4/ Change etc/koha-httpd.conf and copy it to the right place if needed 5/ Reload Apache 6/ Check that http://(OPAC|INTRANET)/api/v1/borrowers and http://(OPAC|INTRANET)/api/v1/borrowers/{borrowernumber} works Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers (where X is an integer greater than 1) returns a 404 error Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:14 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-MQ1AzxLiOZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #201 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43990&action=edit [PASSED QA] Bug 13799: Add cookie-based authentication to REST API Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:19 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-SGdKJb4tl3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #202 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43991&action=edit [PASSED QA] Bug 13799: Add missing license notices Signed-off-by: Joonas Kylm?l? <j.kylmala at gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:24 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-Mk5IsXmoKs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #203 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43992&action=edit [PASSED QA] Bug 13799: Fix API unit tests They were failing because of the now required 'borrowers' permission Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:29 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-dqhIHRwnjN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #204 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43993&action=edit [PASSED QA] Bug 13799: (QA followup) make tests use random data With the introduction of TestBuilder there's no need to rely on existing data on the DB (the original patch relies on categories and branches already existing). This patch creates a random branch, category and two borrowers with the fixed data that is needed for the tests. It adjusts the tests to use the randomized data instead of the previously fixed one. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> The feature works as expected and all tests passes. koha-qa.pl too. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:33 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-4NsjXF8DCO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #205 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43994&action=edit [PASSED QA] Bug 13799: Change Mojolicious default mode to 'production' This avoid getting a debug page when URL is wrong. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:38 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-f5XMDdgSVh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #206 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43995&action=edit [PASSED QA] Bug 13799: Allow to set Mojolicious secret in $KOHA_CONF Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:42 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-qpE5paPWI8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #207 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43996&action=edit [PASSED QA] Bug 13799: Change 'required' value type from string to boolean String is not accepted as a valid value in more recent versions of Swagger2 module Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:47 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-ZivEsVv4x3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #208 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43997&action=edit [PASSED QA] Bug 13799: Reword 'borrower' to 'patron' Also, complete the Swagger definition of a patron Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:52 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-1My3VtCSNo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #209 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43998&action=edit [PASSED QA] Bug 13799 - Followup: x-mojo-controller deprecation Remove the use of soon to be deprecated x-mojo-controller from our specification and replace with the recommended operationId format. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:38:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:38:57 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-d0I4m1cwlD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #210 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 43999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43999&action=edit [PASSED QA] Bug 13799 - Followup: Refactor spec file Spreading the specification over multiple files should lead to a more manageable specification long term Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:39:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:39:01 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-U4bb3rlxZV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #211 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44000&action=edit [PASSED QA] Bug 13799: Followup of "Followup: Refactor spec file" Fix Swagger2 definitions file Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:39:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:39:06 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-TUCUcYsdMx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #212 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44001&action=edit [PASSED QA] Bug 13799: Followup of "Followup: x-mojo-controller deprecation" Rename controller Koha::REST::V1::Patrons to Koha::REST::V1::Patron so Swagger2 can find it Also change most of the "type" specifications in patron schema object, since most of the fields can be null. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:43:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:43:28 +0000 Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional In-Reply-To: <bug-14781-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14781-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14781-70-lgFG5Xzo4j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:45:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:45:03 +0000 Subject: [Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional In-Reply-To: <bug-14781-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14781-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14781-70-b99IWCnldW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42378|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44002&action=edit [SIGNED-OFF] Bug 14781 - Creation of barcode types 2of5 not functional This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module. To test: - Create a label layout with COOP2of5 barcode type - Create labels (make sure that the items's barcode values are numeric only!) - Export batch and download PDF. Without patch: - No barcodes rendered With patch - Barcodes should render as expected. Test for both barcode types. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works as described, tested both formats. Non digit barcode is not printed. No koha-qa errors, no t/ & xt/ errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:52:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:52:46 +0000 Subject: [Koha-bugs] [Bug 15064] New: Fix sample label creator data Message-ID: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 Bug ID: 15064 Summary: Fix sample label creator data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Bug 12194 added a new column to 'creator_layouts'table. Sample data needs to be updated or installer will fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 14:55:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 13:55:48 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: <bug-12904-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12904-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12904-70-yxsE2xApXH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle.m.hall at gmail.com --- Comment #37 from Kyle M Hall <kyle.m.hall at gmail.com> --- Doesn't apply. I'd *really* like to sign off on this. Martin, can you rebase? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:00:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:00:59 +0000 Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler In-Reply-To: <bug-14778-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14778-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14778-70-o782tgGRiK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778 --- Comment #97 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44003&action=edit Bug 14778: Make Search.t pass - replace SHOW COLUMNS For an unkown reason, when executed from a test file, the 'SHOW COLUMNS' statement does not return anything. We need to retrieve the column list from the DBIx::Class resultset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:22:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:22:14 +0000 Subject: [Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels In-Reply-To: <bug-14824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14824-70-poXeX3b4hC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:22:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:22:36 +0000 Subject: [Koha-bugs] [Bug 14961] Remove C4::Dates from files reports/*_stats.pl In-Reply-To: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14961-70-nm1yDzABro@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14961 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:23:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:23:19 +0000 Subject: [Koha-bugs] [Bug 14982] Remove C4::Dates from guided report wizard and dictionary In-Reply-To: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14982-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14982-70-A8Xhzfm9NW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14982 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:26:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:26:58 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-MaCR0gVJJW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I thnk this might be duplicate... sec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:30:46 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-RVAEXJ1C7a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- ... found with Kyle's help - needs sign-off :) *** This bug has been marked as a duplicate of bug 15053 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:30:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:30:46 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-o6mdRHFCYQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 15064 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:40:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:40:13 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-exemp9mOdk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #5 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- I would say not finding a match on a partial title is ok. Otherwise we'll have a lot of fake positives, which will be unsettling for our users and might discourage them from creating suggestions. However, not finding a match when the full title and the author was entered is definitely a bug for me. I think if findDuplicate says there is a duplicate when just the title is entered, it should definitely find one if both title and author are entered. I am not sure about how it works though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:48:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:48:30 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-VkH1izz7og@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44004&action=edit Bug 15064: Fix sample label creator data To test: 1) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 2) Try to load sample data, it fails en/optional/sample_creator_data.sql 3) Apply the patch 4) Try again, must load without errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:48:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:48:33 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-wEjCGMrsPA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44005&action=edit Bug 15064: Fix sample creator data, other languages This patch fix sample creator installer data for most languages other than english. pt-PT does not have this data uk and ru cannt' load, not fixed. To test: 1) delete sample creator data http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 2) foreach lang/file, test file loads without problem, repeat 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:50:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:50:36 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-qnrh5LJzBp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Bernardo, did you see Kyle's patch on the other bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:51:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:51:45 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-8fxsk34SKA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Oops, Ok. I'll see the other one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:54:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:54:03 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-VlX47QMRur@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:54:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:54:13 +0000 Subject: [Koha-bugs] [Bug 15064] Fix sample label creator data In-Reply-To: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15064-70-S8IgQqosjL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15064 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 15:59:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 14:59:43 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-PafPGghmEG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43854|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44006&action=edit [SIGNED-OFF] Bug 15053 - sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> All fixed files loads without problem. No errors found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 16:05:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 15:05:45 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-rBLus5DOJh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44007&action=edit Bug 15053: Followup for french file Fixes french sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql Without the patch french file can't be loaded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 16:23:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 15:23:37 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-0HezX1gmjW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #6 from Alex Arnaud <alex.arnaud at biblibre.com> --- I agree with Gaetan. If we use simpleSearch, this means that if we type "Dragons" as a title, a book like "Rise of the Dragons" could be shown as a duplicate to the user. I think this is not what we want. However, findDuplicate should be able to find duplicate when typing full title and author. So i think we should fix this sub. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 16:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 15:41:24 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch item modification/deletion tools In-Reply-To: <bug-12759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12759-70-0bVoLb4CSs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 16:45:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 15:45:00 +0000 Subject: [Koha-bugs] [Bug 5560] pagination option for lists In-Reply-To: <bug-5560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5560-70-0mOGZCikg9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5560 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 16:45:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 15:45:24 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-F4Hvj6u4k9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43218|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44008&action=edit [SIGNED-OFF] Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 16:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 15:46:05 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-Ojq1iftRZ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44009&action=edit Bug 14977: followup to fix NewsChanell.t With this patch test pass. To test: Run without and with the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:02:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:02:03 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-tMdCz6BIy1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44009|0 |1 is obsolete| | --- Comment #5 from Marc V?ron <veron at veron.ch> --- Created attachment 44010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44010&action=edit Bug 14977: followup to fix NewsChanell.t With this patch test pass. To test: Run without and with the patch Followed test plan, works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:02:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:02:29 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-StSHaYq16i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:28:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:28:14 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-uSMV6gBGbQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:28:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:28:18 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-fR4VYLY5Wf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44011&action=edit Bug 15032: Make sure the filehandle is not close on background mode With Plack, when a file is uploaded for import, the fh created on this file in Koha::Upload is closed. To be sure we are using an opened one, we need to open it in the current scope. Test plan: 1) Go to Tools --> Stage MARC records for import. 2) Upload file and click Import. 3) Click Stage for Import. You should not get any error and the records have been correctly staged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:28:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:28:30 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-jTAhawoJUV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:48:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:48:13 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-kpeI7JUUkU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44012&action=edit Bug 13696 [QA Followup] - Update FA to 4.4.0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 17:54:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 16:54:26 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-ASncMjV5jg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #23 from Kyle M Hall <kyle.m.hall at gmail.com> --- I've added a followup to Bug 13696 to upgrade FA to 4.4.0! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 18:12:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 17:12:24 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-9NonVqJjxV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #19 from Barton Chittenden <barton at bywatersolutions.com> --- Created attachment 44013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44013&action=edit Bug 14504 QA Fixes -- use TestBuilder, remove do_not_commit Use t::lib::TestBuilder in t/db_dependent/Items_DelItemCheck.t Remove the option 'do_not_commit' from C4::Items::DelItemCheck. Whitespace cleanup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 18:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 17:16:53 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-k7gjeGzYMw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 --- Comment #24 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44014&action=edit Bug 14915 [QA Followup] - Switch recent commits from Glyphicons to Font Awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 18:27:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 17:27:44 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-TlkniGAA2K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The last patch fixes the popup with not the internal server error. I only get the error with a kohadevbox install, using a dev install and my "old Plack config", everything works fine with this patch. My "old Plack config" is: INTRANET=1 INTRANETDIR=/home/koha/src plackup --reload --port 5001 $HOME/src/misc/plack/koha.psgi -E deployment Apache config: <Proxy> Order deny,allow Allow from 127.0.0.1,localhost </Proxy> <location /cgi-bin/koha/> ProxyPass http://localhost:5001/cgi-bin/koha/ </location> % INTRANET=1 INTRANETDIR=/home/koha/src plackup --reload --port 5001 $HOME/src/misc/plack/koha.psgi -E deployment service apache2 restart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 18:28:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 17:28:08 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-dgmAYW8I89@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- > The last patch fixes the popup with not the internal server error. s/with/but -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 19:02:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 18:02:32 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-n4nxL8HUgl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Testing with fr-CA translation When importing data into db: userpermissions.sql ERROR 1452 (23000) at line 1: Cannot add or update a child row: a foreign key constraint fails (`kohadev`.`permissions`, CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `userflags` (`bit`) ON DELETE CASCADE ON UPDATE CASCADE) sample_creator_data.sql ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 this is fixed in Bug 15053, check the solution sample_patrons.sql ERROR 1054 (42S22) at line 1: Unknown column 'ethnicity' in 'field list' I wrote an email to you about frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 20:07:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 19:07:31 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14468-70-uXUYEnOKlh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43882|0 |1 is obsolete| | --- Comment #16 from Marc V?ron <veron at veron.ch> --- Created attachment 44015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44015&action=edit Bug 14468: followup to fix tests This patch fix an expected test result. Also changes a comparison for the return value to 'delete' layout sub, in case of success it returns 'undef' and triggers the message 'use of uninitialized value $del_results ...' To test: 1) Whitout this patch prove t/db_dependent/Labels/t_Layout.t fails. Also note the message "Use of uninitialized value $del_results in string ne at t/db_dependent/Labels/t_Layout.t line 110." for using the return value of delete layout (undef on success!) 2) Apply the patch 3) Test pass and no more message Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 20:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 19:07:54 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14468-70-LixNjKPOmh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 20:36:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 19:36:47 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-FdJYyAPqeK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #101 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Katrin Fischer from comment #99) > This currently doesn't apply cleanly due to conflicts in the css files - > please fix! Okidoki. I will fix this as soon as possible. Also I'm going to change here the status to In Discussion Thanks Katrin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 21:10:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 20:10:17 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-bnRLUQLAiQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #102 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Jonathan Druart from comment #100) Hi Jonathan > - You should extract the less/css changes from the mainpage. > - There is still something wrong with the radio buttons on the modal window > (staff). I'll fix this as soon as possible. > - export oai-dc: in opac/oai.pl we use HTTP::OAI::Metadata::OAI_DC, so now > we will have 2 differents module to do the same job? Yep, you're right. But at least with this one I can reproduce another kind of metadata (DC-XML standard, SRW-DC, RDF serialization) starting from a marc record. Besides, this enhancement let us to work with more than simple dc (namespace for elements 1.1) otherwise works with complete dcterms namespace. With HTTP::OAI::Metadata::OAI_DC -I think- you need to create a record from scratch. > > I am not familiar enough with Dublin core to know what to do with the > UNIMARC export and validate it works well for other flavors. I think that this can be corrected if we do the conversion between unimarc and marc 21 flavor as i explained in comment 98. NORMARC works like marc21, so i don't need to fix somethin here. > Fr?d?ric (cced), Is there any chance to get your opinion on this enhancement? I will work with the corrections and make something to convert unimarc to marc21. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 21:51:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 20:51:20 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-sPkHXLIuVa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #182 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 44016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44016&action=edit Bug 11559: (QA followup) replace font choices, fix macro editor More specifically: * Use monospace font options that are more widely installed * Don't allow entering macros until the user loads/creates a macro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:06:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:06:33 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-hWpd26BE50@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43744|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 44017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44017&action=edit Bug 15049 - Add warning about "No active currency" to Acquisitions start page If no active currency is defined, Acquisitions dose not work properly and there can occur software errors while receiving. This patch adds the warning about missing active currency to Home > Acquisitions To test: - Apply patch - Go to Home > Administration > Currencies & Exchange Rates > Currencies - Make sure that no active currency is set - Go to Home > Acquisitions - Verify that a warning displays - Set an active currency - Veryfy that warning no longer displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:12:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:12:40 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-NUUY4MfqKq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #183 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 44018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44018&action=edit Bug 11559: (QA followup) fix several small issues This fixes the following: * Remove unneeded year on use Modern::Perl * Fix occasional freeze when reloading existing record * Fix encoding for returned record on first save to catalog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:21:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:21:02 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14199-70-fVS004K9a5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40943|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44019&action=edit [SIGNED-OFF] Bug 14199: Unify marc orgcode plugins, not overwriting existing values This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl for more generic use. Other fields like 040c or 040d should use it too. Note: The plugin is used for authorities too (003, 040a). One behaviour change is added: If the corresponding field is already filled, it will not be overwritten. In the unit test marc21_orgcode already replaces marc21_field_003. Test plan: [1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in the MARC editor of Cataloguing or Authorities. [2] Check if a value is not overwritten any more. [3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by the noisy warnings of marc21_field_007.pl. They will be addressed on another report. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:21:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:21:11 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14199-70-iBlDUbsyT0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42513|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44020&action=edit [SIGNED-OFF] Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin This patch updates the sql installer files for new installations. Occurrences to the three plugins marc21_field_003, 040c and 040d are replaced by marc21_orgcode.pl. This has been generated by one sed statement. Test plan: [1] Run a new installation or run some of the changed sql files manually. [2] Verify that marc21_orgcode is linked to fields previously linked to the three old plugins. [3] Do a git grep on the three plugin file names. No occurrences expected. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Have tested the three english sql files: authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a for 9 auth codes) marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch does not add them to 040c or 040d; no behavior change.. marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:21:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:21:19 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14199-70-RGrvdyVOWd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42514|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44021&action=edit [SIGNED-OFF] Bug 14199: Database revision for marc21_orgcode.pl This patch adds the dbrev in atomicupdate, updating the marc structure for existing installations. (New installation in previous patch.) And it removes the obsolete plugin files. Test plan: Run upgrade. Verify that new plugin is linked (for bib and auth). Check plugin in editor. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Plugin tested, added to 040a/c/d Test pass No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:21:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:21:45 +0000 Subject: [Koha-bugs] [Bug 14199] Unify all organization code plugins In-Reply-To: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14199-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14199-70-vFqYjwj0wh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:29:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:29:29 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-yuYVpUrkvY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #184 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44022&action=edit [PASSED QA] Bug 11559: Supporting changes for Rancor * Extends login screen to pass along #hash * Adds JSONP support to C4::Service * Extends humanmsg to allow per-message classes * Adds proper charset to results of svc/bib Test plan: 1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage works as expected, despite the change to pass on the fragment (...#blah) from the URL. 2. C4/Service.pm and humanmsg.js: verify that editing system preferences (the main user of these modules) works correctly despite updates. 3. svc/bib: verify that records can be correctly downloaded with the change of character set. This can be done in a Firebug/Chrome Devtools console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the results (possibly replacing 1 with a different valid biblionumber). Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:29:38 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-400Fn15m43@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #185 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44023&action=edit [PASSED QA] Bug 11559: New libraries for Rancor Adds the following JS libraries: * CodeMirror - extensible text editor * FileSaver - shim for saving files * require - dependency resolver and module loader Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:29:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:29:48 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-cwgN21Zs46@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #186 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44024&action=edit [PASSED QA] Bug 11559: Rancor: advanced cataloging interface Full test plan is posted on bug. Test plan for system preference: 1. Apply patch, clear cookies. 2. Go to "Cataloging." 3. Add new record, verify that basic editor is used. 4. Navigate to existing record, click on "Edit record", verify that basic editor is used. 5. Inside basic editor, verify that no button appears to switch to the advanced editor. 6. Enable the "EnableAdvancedCatalogingEditor" syspref. 7. Repeat above steps, should still go to basic editor, but button should appear to switch to the advanced editor; click it. 8. Now, adding new records and editing existing records should go to the advanced editor. Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:29:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:29:54 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-Ij2hryZVSO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #187 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44025&action=edit [PASSED QA] Bug 11559: (followup) Fix keyboard control bugs, make labels clickable This fixes the following issues: * Labels of search server checkboxes cannot be clicked * Quick search fields cannot be focused * Search results cannot be scrolled with a keyboard Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:01 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-4AzNbh086o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #188 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44026&action=edit [PASSED QA] Bug 11559: (followup) Fill in default values, fix redirect and UNIMARC This fixes the following issues: * Help for UNIMARC tags broken * MARC21 resources loaded when in UNIMARC * Clicking on "advanced editor" in basic editor fails * Shift-Tab goes to the beginning of a fixed-field widget rather than the end Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:08 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-0EI2Nza3oe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #189 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44027&action=edit [PASSED QA] Bug 11559: (followup) Fix import bugs, display/parsing issues This fixes the following issues: * ISO2709 import fails for Unicode * Import only works with .mrc/.xml extensions * MARC21 widgets not translatable * Macro UI broken * Uppercase subfield codes forbidden * Tag with no valid subfields shows as error but tries to save Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:14 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-BT0URVpFsl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #190 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44028&action=edit [PASSED QA] Bug 11559: (followup) Fix error when all servers are deselected Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:21 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-l98HvLlUe8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #191 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44029&action=edit [PASSED QA] Bug 11559: (followup) Prevent saving item tags, fix other issues This fixes the following issues: * Spaces are now allowed in indicators * Shift-Enter is available to insert a newline if needed * Item tags, if present, will prevent saving (as they are not correctly processed by the backend) * biblionumber tags (999 in MARC21) will be stripped before the record is saved to Koha, to prevent their modification Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:28 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-th9UAmVJpV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #192 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44030&action=edit [PASSED QA] Bug 11559: (QA followup) switch to new delimiter, fix minor issues This followup introduces a major change; instead of subfields starting with '$<code><space>', they now start with '?<code>'. The double-cross character can be typed with Ctrl-D. It also fixes the following: * Add UUID.pm dependency * Remove debugging call * Fix toLocaleFormat error reported by Nick Clemens * Ignore subfields that are marked as unrepeatable/mandatory AND ignored (tab is -1) * Mention lack of support for UNIMARC/NORMARC fixed fields in system preferences screen * Confirm when user creates new record and current record is modified * Perform better when importing gigantic record dump * Show "Edit" instead of "Import" and allow direct editing for local catalog records in search screen * Add "Keyboard shortcuts" help button to toolbar Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:35 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-TiGS2VBobf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #193 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44031&action=edit [PASSED QA] Bug 11559: (followup) fix first-character deletion, small usability issues This should fix the first-character deletion bug reported by Nick, and also: * Fix subfield deletion * Attempted fix for special keys on dropdowns * Allow deleting empty fields * Fix bug with composed characters Signed-off-by: Nick Clemens <nick at quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:42 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-3G71KhuGCy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #194 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44032&action=edit [PASSED QA] Bug 11559: (QA followup) fix pagination bar, add Ctrl-D to macro editor Also, fix incredibly silly mistake with keyboard shortcuts popup. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:49 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-jYAXRwTsgH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #195 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44033&action=edit [PASSED QA] Bug 11559: (QA followup) detect and warn about corruption caused by MARC-8 Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:30:55 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-uMXwKdiZbx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #196 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44034&action=edit [PASSED QA] Bug 11559: (QA followup) fix QA issues This fixes the following: * License of editor.pl * Remove tabs * Use [% interface %] * Re-order search fields like the old interface * Add license information for new libraries Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:31:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:31:02 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-6YBpvReT56@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #197 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44035&action=edit [PASSED QA] Bug 11559: (QA followup) replace font choices, fix macro editor More specifically: * Use monospace font options that are more widely installed * Don't allow entering macros until the user loads/creates a macro Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:31:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:31:08 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-UctgC9Sr9P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #198 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44036&action=edit [PASSED QA] Bug 11559: (QA followup) fix several small issues This fixes the following: * Remove unneeded year on use Modern::Perl * Fix occasional freeze when reloading existing record * Fix encoding for returned record on first save to catalog Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:31:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:31:52 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-y9EGOm35cd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:31:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:31:57 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-E2ITk0IuOo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43712|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:02 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-WT1DY1zeUk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43969|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:08 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-92Ec32QFae@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43883|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:13 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-Xd8tvBdXC5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:18 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-hxkq2pXu7Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:23 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-sK0iPRRulV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44018|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:28 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-GqEWnLqsS0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:33 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-xiqE2Q9n1l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:38 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-CVf3EOUfWb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43705|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:43 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-6yFFStqE3G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43706|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:49 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-ET6vW0dJ8G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43707|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:54 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-T4q6SU8ifh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:32:59 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-XKkr6Vp0mn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43709|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:33:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:33:07 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-z9zDrTRfRr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43710|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 22:33:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 21:33:12 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-Qi8DWXSQ1B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:16:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:16:16 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-aX56W1awtY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |bgkriegel at gmail.com --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- You need to use currency => GetCurrency()->{currency}, in acqui/acqui-home.pl, if not you get "Currency = HASH(0x763c5a8)" Save for that, it works Ok & without errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:28:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:28:10 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-RGqXLpYScS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44037&action=edit [PASSED QA] Bug 13696 - Add support for Font Awesome icons in Koha Font Awesome is similar to Glyphicons included in Twitter Bootstrap, except better in every way and more Free. Test Plan: 1) Apply this patch 2) Edit the template for a page, and add a Font Awesome tag to it, examples can be found here: http://fortawesome.github.io/Font-Awesome/examples/ 3) Reload the page and verify the icon displays. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:28:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:28:13 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-kmn9T5YS6m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44038&action=edit [PASSED QA] Bug 13696 [QA Followup] - Add Font Awesome license to the about page Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:28:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:28:25 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-FnhLWbJrTl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 44039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44039&action=edit [PASSED QA] Bug 13696 [QA Followup] - Update FA to 4.4.0 Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:29:36 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-EnsZxE5FPb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:29:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:29:38 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-BO1XCbvWzm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:29:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:29:41 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-FxoSvrJqYH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Oct 26 23:31:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 26 Oct 2015 22:31:59 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-D28yj4KWQV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #4 from Marc V?ron <veron at veron.ch> --- (In reply to Bernardo Gonzalez Kriegel from comment #3) > You need to use > > currency => GetCurrency()->{currency}, > > in acqui/acqui-home.pl, if not you get "Currency = HASH(0x763c5a8)" > > Save for that, it works Ok & without errors. Hi Bernardo, Thanks for pointing that out. However with GetCurrency()->{currency} I get: Can't use an undefined value as a HASH reference at /usr/share/kohaclone/acqui/acqui-home.pl line 117. The reason is that GetCurrency does a SELECT * FROM currency where active = '1' (C4/Budgets.pm, after line 932) If no active currency is set the return value is not defined. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:02:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:02:39 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-eunwTh0kPm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #8 from Mason James <mtj at kohaaloha.com> --- Created attachment 44040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44040&action=edit Bug 15048 - subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values to test... 1/ define both a 655$a *and* 655$x value in a bib, save, reindex 2/ in opac-detail.pl click bib's genre/form url, the search should FAIL to return a result (BAD!) :/ 3/ apply patch 4/ copy updated files to your live zebradb dir (or build/install a debian package) $ sudo cp ./etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml $ sudo cp etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl \ /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl 5/ run a full zebra reindex 6/ in opac-detail.pl click bib's genre/form url, the search should return a result (GOOD!) :0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:03:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:03:29 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-bpwClpy9wp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:06:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:06:59 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-q8RXgpHeva@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #9 from Mason James <mtj at kohaaloha.com> --- Created attachment 44041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44041&action=edit SUCCESSFUL search on 655$a and 655$x - 'Family -- Fiction' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:08:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:08:02 +0000 Subject: [Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-2NOtuAiLoV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #10 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #9) > Created attachment 44041 [details] > SUCCESSFUL search on 655$a and 655$x - 'Family -- Fiction' pic of successful result attached ^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:31:58 +0000 Subject: [Koha-bugs] [Bug 15048] Genre (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-3G1RncHgrO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|subject/genre (650/655) |Genre (655) searches fail |searches fail on searches |on searches with $x |with $x 'General |'General subdivision' |subdivision' subfield |subfield values |values | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:39:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:39:33 +0000 Subject: [Koha-bugs] [Bug 15048] Genre (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-75A6rylOcz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 --- Comment #11 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #6) > (In reply to Mason James from comment #5) > > my hunch is that the CCL syntax for the search query is incorrect > > > > my example returns no results.. > > (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction") > > the other issue is that the 650$x and/or 655$x subfields don't seem to be > configured to be indexed by Zebra NOTE: this patch only fixes Genre/Form (655) searches - not subject/650 searches The patch to fix the subject/650 equivalent of this issue will be moved to a separate bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:40:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:40:13 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-3DsaAaPXAu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Genre (655) searches fail |Genre/Form (655) searches |on searches with $x |fail on searches with $x |'General subdivision' |'General subdivision' |subfield values |subfield values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:43:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:43:16 +0000 Subject: [Koha-bugs] [Bug 15065] New: Subject (650) searches fail on searches with $x 'General subdivision' subfield values Message-ID: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15065 Bug ID: 15065 Summary: Subject (650) searches fail on searches with $x 'General subdivision' subfield values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org more info to come... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:43:39 +0000 Subject: [Koha-bugs] [Bug 15065] Subject (650) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15065-70-9rzb2X22CF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15065 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15048 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:43:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:43:39 +0000 Subject: [Koha-bugs] [Bug 15048] Genre/Form (655) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15048-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15048-70-H83ND2gElL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15065 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 02:43:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 01:43:49 +0000 Subject: [Koha-bugs] [Bug 15065] Subject (650) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15065-70-Bnmojw3WsA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15065 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 03:00:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 02:00:37 +0000 Subject: [Koha-bugs] [Bug 15065] Subject (650) searches fail on searches with $x 'General subdivision' subfield values In-Reply-To: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15065-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15065-70-zOMBb17uao@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15065 --- Comment #1 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #0) > more info to come... ..in the meantime, take a look at BZ-15048 for more general info about this issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 06:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 05:06:02 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-ZT80MnKn5D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43973|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 44042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44042&action=edit Bug 15059 - Line break in html attribute In some templates, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet (same at OPAC) - perform a search on one word with a sort order (anything but relevance) - click on "Next" at the bottom of the page - look at link "Show more" in facets => Without patch the URL contains a lot of spaces => With patch the URL is correct - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 06:06:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 05:06:22 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-dJTO5zjvsO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 06:30:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 05:30:26 +0000 Subject: [Koha-bugs] [Bug 11780] Need to prevent specific fields from being overwritten with z39.50 import In-Reply-To: <bug-11780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11780-70-vnH2RleLL8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 06:30:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 05:30:26 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-Czs7HWntSf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11780 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 06:30:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 05:30:51 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-nBjtYgT7PX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 07:08:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 06:08:03 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: <bug-15050-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15050-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15050-70-8ddTgXd50W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron <veron at veron.ch> --- Reproduced on current master 3.21.00.041 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 07:15:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 06:15:16 +0000 Subject: [Koha-bugs] [Bug 15025] Regression: "print summary" does not display fines In-Reply-To: <bug-15025-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15025-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15025-70-99NmEfcOk1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15025 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #1 from Marc V?ron <veron at veron.ch> --- Tested on current master 3.21.00.041 I could not reproduce the issue, the summary printed fine for a patron with unpaid fines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 08:26:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 07:26:19 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14578-70-Tne4Qr3zeA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jesse, I'd be very interested in more information about this! Do you have a spec or can you describe the idea in a few sentences? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:23:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:23:48 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-03BfI2ZAtl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 44013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44013 Bug 14504 QA Fixes -- use TestBuilder, remove do_not_commit Review of attachment 44013: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14504&attachment=44013) ----------------------------------------------------------------- ::: C4/Items.pm @@ +2378,2 @@ > > + DelItemCheck( $dbh, $biblionumber, $itemnumber ); $dbh shouldn't pass as a parameter. @@ +2381,4 @@ > =cut > > sub DelItemCheck { > + my ( $dbh, $biblionumber, $itemnumber ) = @_; $dbh shouldn't pass as a parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:27:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:27:04 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-SqI2ShIsle@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 140 "DelItemCheck should delete item if 'do_not_commit' not set" => 'do_not_commit' occurrence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:27:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:27:07 +0000 Subject: [Koha-bugs] [Bug 1985] Email notification of new OPAC comments In-Reply-To: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1985-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1985-70-MpidBzaUiu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:39:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:39:36 +0000 Subject: [Koha-bugs] [Bug 4456] Enable addition of PO Number to order In-Reply-To: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4456-70-v4NqgC5lVd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10454 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:39:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:39:37 +0000 Subject: [Koha-bugs] [Bug 10454] Duplicate card numbers may be generated In-Reply-To: <bug-10454-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10454-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10454-70-kXp3rHUj4g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4456 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:50:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:50:02 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-fPZdZBcqi6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- CONFLICT (content): Merge conflict in t/db_dependent/Hold.t I think the possible errors should be handle. For instance: An hold suspended but has been deleted in the meantime, the suspend until date is not valid, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 09:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 08:57:25 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15061-70-YYd0WHkZpp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Josef, It looks good here: http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/rotating_collections/addItems.pl Could you please detail your issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:03:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:03:08 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15061-70-gKx8xWazwh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 44044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44044&action=edit rotating collection issue I'm adding a screenshot of the problem I'm facing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:03:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:03:08 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-CHwaqs6Ve1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The NewsChannels.t test fail for me, with and without the last patch: With: # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 90. # Structures begin differing at: # $got->{expirationdate} = '12/30/2999' # $expected->{expirationdate} = '30/12/2999' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 112. # Structures begin differing at: # $got->{expirationdate} = '12/31/2999' # $expected->{expirationdate} = '31/12/2999' # Looks like you failed 2 tests of 10. Without: # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 90. # Structures begin differing at: # $got->{expirationdate} = '30/12/2999' # $expected->{expirationdate} = '2999-12-30' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 112. # Structures begin differing at: # $got->{timestamp} = '01/01/2000' # $expected->{timestamp} = '2000-01-01' # Looks like you failed 2 tests of 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:05:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:05:36 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15061-70-XkXMNXq8Jk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- I understand now, when I created a new collection, I tried to add items and somehow was redirected on page addItems without colId parameter... so of course adding items failed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:05:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:05:56 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14468-70-5atkb2X1eq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:06:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:06:00 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14468-70-jxBAUgnwKp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44015|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44045&action=edit Bug 14468: followup to fix tests This patch fix an expected test result. Also changes a comparison for the return value to 'delete' layout sub, in case of success it returns 'undef' and triggers the message 'use of uninitialized value $del_results ...' To test: 1) Whitout this patch prove t/db_dependent/Labels/t_Layout.t fails. Also note the message "Use of uninitialized value $del_results in string ne at t/db_dependent/Labels/t_Layout.t line 110." for using the return value of delete layout (undef on success!) 2) Apply the patch 3) Test pass and no more message Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:08:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:08:30 +0000 Subject: [Koha-bugs] [Bug 15066] New: Transfer rotating collection fails on plack Message-ID: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Bug ID: 15066 Summary: Transfer rotating collection fails on plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org When I tried to transfer rotating collection, I saw "Internal server error", collection was marked with new location, but items in that collection weren't marked with new location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:08:39 +0000 Subject: [Koha-bugs] [Bug 15019] Plack testing - Umbrella In-Reply-To: <bug-15019-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15019-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15019-70-3e2uhA8y3y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15066 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 [Bug 15066] Transfer rotating collection fails on plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:08:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:08:39 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15066-70-5qshoIqLBl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15019 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019 [Bug 15019] Plack testing - Umbrella -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:08:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:08:47 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-Rh9hA6uZn6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #103 from Fr?d?ric Demians <frederic at tamil.fr> --- Here's what I can think of this. There is already in Koha an inconsistency in the way DC is generated. (1) When exporting, C4::Record::marc2dcxml() is used. (2) In OAI server, an XSLT transformation is done using XSL file found in koha-tmpl/intranet- tmpl/prog/en/xslt. The OAI approach seems more sensible since it allows to have a transformation logic per MARC flavor, and even in OAI extended mode, a transformation specific to a Koha installation. Currently, C4::Record::marc2dcxml() delegates the semantic transformation from MARC21 to XML DC to this module: MARC::Crosswalk::DublinCore. I don't think this is a great idea. This is an old-unmaintained module (10 years old). And it doesn't work for Unimarc. I haven't paid attention to that, but I can't see how DC export could work with an Unimarc catalog. Your module Koha::Crosswalk::DublinCore still wraps a call MARC::Crosswalk::DublinCore. The MARC21 to Unimarc transformation on the fly isn't a good idea at all. This would add complexity for an unreliable result. Why not just fixing XSL files transforming MARCXML biblios into DC and use them in marc2dcxml()? Side note about dependencies -- RDF::Trine have Moose as dependency. Aren't we supposed to avoid that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:14:01 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-8BkvjFWBhv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #104 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Frederick, thx for your comment! I like the idea of reusing the XSLT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:15:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:15:33 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15061-70-okDXQup4EO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please provide a step by step plan to reproduce, I don't get it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:16:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:16:36 +0000 Subject: [Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die In-Reply-To: <bug-14993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14993-70-5F0hkOMGkq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:26:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:26:00 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15066-70-Ua5yat7agL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:26:03 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15066-70-UIODs1cWLt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44046&action=edit Bug 15066: Make transfer rotating collection works under Plack This patch the 2 following errors: Undefined subroutine &C4::RotatingCollections::transferbook called at C4/RotatingCollections.pm line 451. Undefined subroutine &C4::RotatingCollections::GetTransfers called at C4/RotatingCollections.pm line 450. And this warning: "my" variable $colId masks earlier declaration in same scope at /home/koha/src/rotating_collections/transferCollection.pl line 75. Test plan: Create a rotating collection Transfer it to another branch It should work with this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:26:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:26:17 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15066-70-otFoWbMBmU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:49:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:49:56 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-2PoNzhBPAv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40175|0 |1 is obsolete| | --- Comment #18 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44047&action=edit Add maxreserves and alreadyreserved checks when placing hold via ILSDI http://bugs.koha-community.org/show_bug.cgi?id=14155 Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:50:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:50:04 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-GxX7N0KEIo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40176|0 |1 is obsolete| | --- Comment #19 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44048&action=edit Bug 14155 - Add tests in t/db_dependent/Reserves.t - add tests for C4::Reserves::AlreadyReserved(), - add tests for C4::Reserves::ReachedMaxReserves(), Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:50:17 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-d5EPdYGx2Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40240|0 |1 is obsolete| | --- Comment #20 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44049&action=edit (fix typo) AddBiblio call in Reserves.t Fix for the typo, it read : my ($broken_id, $title, $bibitemnum) = AddBiblio($miniaturist, ''); it should read : my ($broken_id, $title, $bibitemnum) = AddBiblio($broken, ''); Signed-off-by: Alex Arnaud (Biblibre) <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:50:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:50:22 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-92DvokhLli@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40241|0 |1 is obsolete| | --- Comment #21 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44050&action=edit (qa followup) variable declaration and cleanup 1/ running koha qa tools showed up valid FAIL. This patch fix that error. FAIL t/db_dependent/Reserves.t OK critic OK forbidden patterns OK pod FAIL valid "my" variable $title masks earlier declaration in same scope "my" variable $bibitemnum masks earlier declaration in same scope 2/ the following redundant line was removed as it had no use: t::lib::Mocks::mock_preference('maxreserves', 15); Signed-off-by: Alex Arnaud (Biblibre) <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:54:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:54:51 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14078-70-s5dZ8xc99N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:54:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:54:54 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14078-70-Jj3lSjmkKU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38655|0 |1 is obsolete| | --- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44051&action=edit Bug 14078 - converting from ISO5426 is not complete Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426(). Each character or combined characters conversion is defined in a map. This patch changes some odd actual conversions. In char_decode5426(), only characters between 0xC0 and 0xDF will be used for combining with following charater : ($char >= 0xC0 && $char <= 0xDF) So conversion like "$chars{0x81d1}=0x00b0" will never be used. Rules for "h with breve below" use combining with 0xf9 but looks like the correct caracter is 0xd5. See http://www.gymel.com/charsets/MAB2.html Signed-off-by: Frederic Demians <f.demians at tamil.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:57:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:57:22 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14078-70-7bgkkp0pOs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38656|0 |1 is obsolete| | Attachment #44051|0 |1 is obsolete| | CC| |frederic at tamil.fr --- Comment #11 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44052&action=edit Bug 14078 - converting from ISO5426 is not complete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 10:58:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 09:58:03 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14078-70-2mWePd2j7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 --- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44053&action=edit Bug 14078 - converting from ISO5426 is not complete followup1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:12:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:12:31 +0000 Subject: [Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE In-Reply-To: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12488-70-MvMSagBMBQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 --- Comment #7 from Magnus Enger <magnus at libriotech.no> --- Could it be an idea to introduce a command line switch, to let the user choose between DELETE and TRUNCATE? With TRUNCATE (the current behaviour) as the default if e.g. --use_delete is not provided? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:34:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:34:25 +0000 Subject: [Koha-bugs] [Bug 15067] New: Add additional languages to advanced search language search Message-ID: <bug-15067-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Bug ID: 15067 Summary: Add additional languages to advanced search language search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The language option list in the advanced search can now be configured now, but not all languages are available. 3 of the missing that should be added are: Estonian Latvian Lithuanian -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:42:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:42:59 +0000 Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in In-Reply-To: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14821-70-yZ3j2XvI8r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:43:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:43:02 +0000 Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in In-Reply-To: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14821-70-NLGK7Peg2n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42548|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44054&action=edit Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. Signed-off-by: Frederic Demians <f.demians at tamil.fr> I confirm that the checkin table hasn't to be populated with info on items which haven't been checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:48:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:48:52 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15066-70-6CdzIldopf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:49:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:49:02 +0000 Subject: [Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack In-Reply-To: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15066-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15066-70-1KWSMkNyMC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44046|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 44055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44055&action=edit Bug 15066: Make transfer rotating collection works under Plack This patch the 2 following errors: Undefined subroutine &C4::RotatingCollections::transferbook called at C4/RotatingCollections.pm line 451. Undefined subroutine &C4::RotatingCollections::GetTransfers called at C4/RotatingCollections.pm line 450. And this warning: "my" variable $colId masks earlier declaration in same scope at /home/koha/src/rotating_collections/transferCollection.pl line 75. Test plan: Create a rotating collection Transfer it to another branch It should work with this patch Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 11:55:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 10:55:19 +0000 Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. In-Reply-To: <bug-14844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14844-70-nc6DJVvjhY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians <frederic at tamil.fr> --- I've already seen that. What web server do you use? and what browsers? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:11:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:11:44 +0000 Subject: [Koha-bugs] [Bug 15068] New: Get rid of warnings in members/summary-print.pl Message-ID: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Bug ID: 15068 Summary: Get rid of warnings in members/summary-print.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Printing a summary from a member's detail page can result in a lot of warnings like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:12:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:12:07 +0000 Subject: [Koha-bugs] [Bug 15061] Can't add item to rotating collection In-Reply-To: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15061-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15061-70-lY8Fx6FI9V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061 --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- I can't reproduce it now as well... the problem was, I think, that collection ID was lost... but only one way I can reproduce it now is to manually go to address /cgi-bin/koha/rotating_collections/addItems.pl without any parameter... but it's not the way used by normal work.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:31:38 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-kp5utLbeUD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #2 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 44056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44056&action=edit Bug 14957: Rule based permission for MARC fields This patch adds a rule based permission system for MARC field modifications. Test plan: 1. Apply this patch 2. Apply related database patch 2. Apply related scripts update patch 3. Run updatedatabase.pl 5. Log in to staff client 4. Enable new syspref MARCPermissions 5. You should see a new link "MARC field permissions" in the "Catalog" section under "Koha administrtion". 6. Go to the "MARC field permissions" page 7. Next to the page heading ("Manage MARC field permissions") there is a button with a question mark, click this for more information about the rule system. 8. Add desired rules to the rule table, press the +-button to add. 9. Clicking the pen-icon (edit) should allow you to edit corresponding rule. 10. Clicking the x-icon should remove corresponding rule after confirmation. 11. Selecting one or more rules followed by clicking the trash-icon should remove all selected rules after confirmation. 12. To test your rules, import or in other way modify a record. 13. Check that the record was modified as defined by your rules. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:31:47 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-7XHe0WMH8u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #3 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 44057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44057&action=edit Bug 14957: Database changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:31:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:31:58 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-4cynQtPuiD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #4 from Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> --- Created attachment 44058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44058&action=edit Bug 14957: Add filters to relevant scripts Add MARCPermissions filters in scripts which modifies MARC records to enable the permission system for these scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:33:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:33:17 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-8FMCuVEUFq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Martin Stenberg <martin at bugs.koha-community.org.xinxidi.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:37:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:37:48 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-HgTU05vFLu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42617|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44059&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Operations in admin/category is unchanged, and functionnal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:38:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:38:46 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-NDevPC0AZl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44059|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44060&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Operations in admin/category is unchanged, and functionnal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:40:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:40:11 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-9CbnxSRgpk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:40:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:40:14 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-fV43y93LEa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42616|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44061&action=edit Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians at tamil.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:43:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:43:42 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15068-70-GMUFrIrJhg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 --- Comment #1 from Marc V?ron <veron at veron.ch> --- Created attachment 44062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44062&action=edit Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:44:38 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15068-70-w8LraWQ3JE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14483 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:44:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:44:38 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: <bug-14483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14483-70-CfoStpFWCV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15068 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:45:48 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15068-70-6j1imxE75E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com --- Comment #2 from Marc V?ron <veron at veron.ch> --- *** Bug 14483 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:45:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:45:48 +0000 Subject: [Koha-bugs] [Bug 14483] Warns when printing summary slip for patron In-Reply-To: <bug-14483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14483-70-0WJ34VAzMg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED CC| |veron at veron.ch --- Comment #4 from Marc V?ron <veron at veron.ch> --- *** This bug has been marked as a duplicate of bug 15068 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 12:48:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 11:48:53 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-M3umBEVvxQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I made it works on kohadevbox:ansible, using plackup, ports and the koha.psgi from the source: vagrant at kohadevbox:~$ sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone plackup --port 5001 /home/vagrant/kohaclone/misc/plack/koha.psgi -E deployment and /etc/koha/apache-shared-intranet-plack.conf ProxyPass /cgi-bin/koha http://localhost:5001/cgi-bin/koha ProxyPassReverse /cgi-bin/koha http://localhost:5001/cgi-bin/koha Otherwise, trying with socket: vagrant at kohadevbox:~$ sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone plackup --socket /var/run/koha/kohadev/plack.sock /home/vagrant/kohaclone/misc/plack/koha.psgi -E deployment # using Koha intranet CGI from /home/vagrant/kohaclone failed to listen to port 8080: Address already in use at /usr/share/perl5/HTTP/Server/PSGI.pm line 94. --socket does not seems to work here (??) Note that it works if I use Starman: sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone plackup -s Starman --socket /var/run/koha/kohadev/plack.sock /home/vagrant/kohaclone/misc/plack/koha.psgi -E deployment # using Koha intranet CGI from /home/vagrant/kohaclone 2015/10/27-11:42:45 Starman::Server (type Net::Server::PreFork) starting! pid(11966) Binding to UNIX socket file "/var/run/koha/kohadev/plack.sock" Setting gid to "0 0 0" But when I try and access the interface: [Tue Oct 27 11:45:11.077045 2015] [proxy_http:error] [pid 12238] (70008)Partial results are valid but processing is incomplete: [client 192.168.50.1:47165] AH01110: error reading response, referer: http://kohadev-intra.box.vm:8080/ and finish with a 503 Service Unavailable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:07:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:07:24 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-JnOEaYHOtJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Starman with ports: sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone /usr/bin/starman -M FindBin --max-requests 50 --workers 2 --user=kohadev-koha --group kohadev-koha --pid /var/run/koha/kohadev/plack.pid --port 5001 /home/vagrant/kohaclone/misc/plack/koha.psgi Everyting looks fine, but the import tool is still broken (no progress bar). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:09:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:09:02 +0000 Subject: [Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import In-Reply-To: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-7QE5ziEIkY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #8) > This seems to be caused by bug 14321 > > The errors in the logs are: > > binmode() on closed filehandle _GEN_2 at > /home/vagrant/kohaclone/C4/Templates.pm line 120. > seek() on closed filehandle _GEN_2 at /usr/share/perl5/CGI/Emulate/PSGI.pm > line 32. > Can't seek stdout handle: Bad file descriptor at > /usr/share/perl5/Plack/App/WrapCGI.pm line 87. Note that these errors always appear, even when the import and the progress bar work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:25:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:25:02 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-yjSIZ9tTMY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Marc V?ron from comment #4) > > However with GetCurrency()->{currency} I get: > > Can't use an undefined value as a HASH reference at > /usr/share/kohaclone/acqui/acqui-home.pl line 117. > > The reason is that GetCurrency does a SELECT * FROM currency where active = > '1' > (C4/Budgets.pm, after line 932) > > If no active currency is set the return value is not defined. Yeap, but 'budgets-active-currency.inc' expects the currency and not a hashref. Other files that use the include put "currency => $cur->{currency}" Perhaps this code my $cur = GetCurrency(); if ( $cur ) { $template->param( currency => $cur->{currency}, ); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:30:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:30:54 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: <bug-14435-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14435-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14435-70-kggzFeRXa2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:45:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:45:35 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14578-70-lrcVr72OlV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Work to be done: 1) For all staged records with found matches, add a 'merge editor' link. This link will open a page similar to cataloguing/merge.pl 2) Within the merge editor you will be able to select fields to retain/remove from each record 3) Saving the merge will update the staged record with the selected value 4) At this point, importing the record will replace the existing record with the staged record that you modified with the merge values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:50:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:50:28 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14578-70-ypZuSzjnjb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ah, thx Nicole that makes sense - just not quite what I was hoping for :) We'd like to have something that happens automatically if certain conditions are met. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 13:55:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 12:55:19 +0000 Subject: [Koha-bugs] [Bug 15056] hold-transfer-slip.pl print "No hold found" In-Reply-To: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15056-70-8FMn88S3jK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056 --- Comment #2 from mustaqeem <mustaqeemabd at gmail.com> --- (In reply to Katrin Fischer from comment #1) > mustageeem, please check that you have your notice templates correctly > defined - the error message can appear when the template is missing. > > Tools > Notices and Slips > RESERVESLIP Dear Katrin, thank you so much..! that really solve that problem..! I close my case..:) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:08:14 +0000 Subject: [Koha-bugs] [Bug 15056] hold-transfer-slip.pl print "No hold found" In-Reply-To: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15056-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15056-70-8wgfFamRca@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:41:28 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14468-70-wMxyHtAr2t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44063&action=edit Bug 14468: (QA followup) remove useless diags Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:44:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:44:09 +0000 Subject: [Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha In-Reply-To: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13696-70-lT1nEMzBMc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Good job Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:44:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:44:32 +0000 Subject: [Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet In-Reply-To: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14915-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14915-70-RYWDLdtnnU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #25 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle and Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:44:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:44:56 +0000 Subject: [Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export) In-Reply-To: <bug-14997-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14997-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14997-70-UQL6e5pHCi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:45:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:45:16 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-IDPyT8mPnF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:45:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:45:20 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-VUSrgW94Pp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 --- Comment #22 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44064&action=edit Bug 14155 - Update tests and fix failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:45:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:45:39 +0000 Subject: [Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt In-Reply-To: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14995-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14995-70-KLBVktHO4Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:46:05 +0000 Subject: [Koha-bugs] [Bug 14468] Remove warnings when creating Labels In-Reply-To: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14468-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14468-70-cgKXANKpBC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Parche aplicado en master. ?Gracias Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:47:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:47:55 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14578-70-XPGo42j2Qc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- That would be AWESOME!!! I think this is a step in that direction though :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:48:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:48:24 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-4giAo2cK71@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41790|0 |1 is obsolete| | Attachment #41791|0 |1 is obsolete| | Attachment #41792|0 |1 is obsolete| | Attachment #41793|0 |1 is obsolete| | Attachment #41794|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44065&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:48:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:48:32 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-2xEGGL43jm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44066&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:48:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:48:36 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-pDCghMEc8v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #57 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44067&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:48:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:48:39 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-v1ZDnTlNPQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44068&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:48:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:48:42 +0000 Subject: [Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks In-Reply-To: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14155-70-j7PixftK0l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:48:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:48:43 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-PuLH0LegyG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44069&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:49:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:49:48 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12598-70-BegV5WpeRg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #60 from Kyle M Hall <kyle.m.hall at gmail.com> --- I would really like to see this qa'ed for a fast push after the 3.22 release. The longer this sits here the more likely the new subroutine will fall out of sync with the current import code in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 14:52:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 13:52:20 +0000 Subject: [Koha-bugs] [Bug 14578] Allow merging of records upon import match In-Reply-To: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14578-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14578-70-fRJQk0rwEm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Yep of course - I think that will be helpful for everyone running the imports manually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:05:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:05:59 +0000 Subject: [Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl In-Reply-To: <bug-14996-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14996-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14996-70-ddWKHNIHog@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:07:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:07:46 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-1o1QRlOnU1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #6 from Marc V?ron <veron at veron.ch> --- Additionaly there was an issue if an user had no permission to manage the currencies table. In such case the warning message should not display a link to the currencies. Patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:08:07 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10933-70-OfyZWysxU9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:08:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:08:08 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-IbrPgd3jxI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44017|0 |1 is obsolete| | --- Comment #7 from Marc V?ron <veron at veron.ch> --- Created attachment 44070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44070&action=edit Bug 15049 - Add warning about "No active currency" to Acquisitions start page If no active currency is defined, Acquisitions does not work properly and software can occur while receiving. This patch adds the warning message about missing active currency to Home > Acquisitions To test: - Apply patch - Go to Home > Administration > Currencies & Exchange Rates > Currencies - Make sure that no active currency is set - Go to Home > Acquisitions - Verify that a warning displays: - If user has at least permission for parameters_remaining_perissions, the warning should display a link to Currencies and exchange rates (currency.pl) - If the user has no permission to edit the Currencies and exchange rates, no link is displayed. - Set an active currency - Veryfy that the warning no longer displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:13:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:13:39 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-gJ0yHkDJT8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44070|0 |1 is obsolete| | --- Comment #8 from Marc V?ron <veron at veron.ch> --- Created attachment 44071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44071&action=edit Bug 15049 - Add warning about "No active currency" to Acquisitions start page If no active currency is defined, Acquisitions does not work properly and software can occur while receiving. This patch adds the warning message about missing active currency to Home > Acquisitions To test: - Apply patch - Go to Home > Administration > Currencies & Exchange Rates > Currencies - Make sure that no active currency is set - Go to Home > Acquisitions - Verify that a warning displays: - If user has at least permission for parameters_remaining_perissions, the warning should display a link to Currencies and exchange rates (currency.pl) - If the user has no permission to edit the Currencies and exchange rates, no link is displayed. - Set an active currency - Veryfy that the warning no longer displays (Amended to remove superfluous line / mv) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:13:49 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-GxbaFgQzs7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43958|0 |1 is obsolete| | --- Comment #14 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 44072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44072&action=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more) Patch to remove deprectated C4::Dates from: - circ/circulation.pl - C4/Circulation.pm - koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Search for regressions - prove -v t/db_dependent/Circulation.t (Amended following comment #9 / #11 25.10.2015 /mv) Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:14:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:14:03 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-CpNldz582M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:14:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:14:01 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-jIuE5AvNZZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:26:06 +0000 Subject: [Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE In-Reply-To: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12488-70-xyKqLvNlOF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12486 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:26:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:26:06 +0000 Subject: [Koha-bugs] [Bug 12486] Appendix G (Resetting the Koha Database) using DELETE instead of TRUNCATE In-Reply-To: <bug-12486-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12486-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12486-70-lV6z5rHs3h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12486 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12488 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:28:34 +0000 Subject: [Koha-bugs] [Bug 13379] authorised_values.category is varchar(16) In-Reply-To: <bug-13379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13379-70-cF9ZlmKSFR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15069 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:28:34 +0000 Subject: [Koha-bugs] [Bug 15069] New: items_search_fields.authorised_values_category is still a varchar(32) Message-ID: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Bug ID: 15069 Summary: items_search_fields.authorised_values_category is still a varchar(32) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13379 This is a follow-up for bug 13379. items_search_fields.authorised_values_category is now a varchar(32) but the updatedatabase.pl did not modify it (changed only on kohastructure.sql) Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379 [Bug 13379] authorised_values.category is varchar(16) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:30:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:30:50 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-nXJxmaCby6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:30:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:30:52 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-IwIXserkOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44073&action=edit Bug 15069: Update items_search_fields.authorised_values_category to varchar(32) This is a follow-up for bug 13379. items_search_fields.authorised_values_category is now a varchar(32) but the updatedatabase.pl did not modify it (changed only on kohastructure.sql) Test plan: SHOW CREATE TABLE items_search_fields before and after this patch. items_search_fields.authorised_values_category should be a varchar(32) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:31:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:31:04 +0000 Subject: [Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE In-Reply-To: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12488-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12488-70-efe9ZVT5vh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Magnus Enger from comment #7) > Could it be an idea to introduce a command line switch, to let the user > choose between DELETE and TRUNCATE? With TRUNCATE (the current behaviour) as > the default if e.g. --use_delete is not provided? I'd think that --use_truncate would be better, and default with DELETE, because the original intent is almost always rollback, is it not? Adding a command line option would make this somewhere between a fix and enhancement (not going to make 3.22, is it?). Changing it to use DELETE would just be a fix (could make it into 3.22), in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:31:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:31:54 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-rFW1s5uE7A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Should be backported to 3.20.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:34:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:34:38 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-8OokfK1WQV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:34:42 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-7NCXNYNJTF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:34:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:34:41 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-3wjyrCdN8h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44073|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44074&action=edit Bug 15069: Update items_search_fields.authorised_values_category to varchar(32) This is a follow-up for bug 13379. items_search_fields.authorised_values_category is now a varchar(32) but the updatedatabase.pl did not modify it (changed only on kohastructure.sql) Test plan: SHOW CREATE TABLE items_search_fields before and after this patch. items_search_fields.authorised_values_category should be a varchar(32) Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:35:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:35:26 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-o0grmW4sPn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:36:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:36:52 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-f4xQrZihWf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Karl Holten <kholten at switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kholten at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:40:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:40:08 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: <bug-14435-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14435-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14435-70-FwCeu6mDyZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:41:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:41:13 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-8s0KzQ1ldc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please provide a fix on top of bug 14955 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:41:19 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-D9aGDFwvYH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:41:24 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-w78aZoIJkI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14955 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 [Bug 14955] "Show more" link contains double encoded characters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:41:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:41:24 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14955-70-KFlMAqE712@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15059 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 [Bug 15059] Line break in html attribute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:42:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:42:42 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14955-70-nhDH0RDwPU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Encoding issue at the OPAC on a stable version, I am raising the severity to major. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:43:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:43:00 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14955-70-rTcoL3X7zG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:43:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:43:43 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-jaKUJGxn4s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:48:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:48:15 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: <bug-14945-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14945-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14945-70-PYeo3fEyvT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 --- Comment #9 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 44075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44075&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) (Amended following comment #7 / 25.10.2015 / mv Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:52:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:52:26 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-fTbSH6RbvP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- I have test instance with only few checkouts in last 2 months. Some checkouts were made in september and some in october. But it doesn't matter which dates I use in checkout/checkin date filter, I still get exactly same data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:57:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:57:56 +0000 Subject: [Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32) In-Reply-To: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15069-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15069-70-S9J4eds50e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks for taking care, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:58:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:58:21 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-aCkIdR5X2E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 15:58:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 14:58:56 +0000 Subject: [Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT In-Reply-To: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14734-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14734-70-2KYjhe9wed@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734 --- Comment #7 from Winona Salesky <wsalesky at gmail.com> --- Great! Thanks, -Winona (In reply to Tom?s Cohen Arazi from comment #6) > Patch pushed to master. > > Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:00:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:00:25 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-TfmwSENnBv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 44072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44072 Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more) Review of attachment 44072: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14903&attachment=44072) ----------------------------------------------------------------- ::: circ/circulation.pl @@ +174,4 @@ > > my $stickyduedate = $query->param('stickyduedate') || $session->param('stickyduedate'); > my $duedatespec = $query->param('duedatespec') || $session->param('stickyduedate'); > +$duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ), dateformat => 'iso' }); }; No, only if duedatespec if given. Otherwise "Automatic due date" is always filled with now. @@ +203,4 @@ > $datedue = output_pref({ dt => dt_from_string, dateonly => 1, dateformat => 'iso' }); > $datedue .= ' 23:59:00'; > } elsif( $duedatespec_allow ) { > + if ($datedue) { That's not the same code as before ($dateduespec vs $datedue), please double check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:00:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:00:33 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-IuU1ttEgup@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:03:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:03:35 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-TwwawBA5xI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:03:38 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-7pmLNMue49@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44071|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44076&action=edit [SIGNED-OFF] Bug 15049: Add warning about "No active currency" to Acquisitions start page If no active currency is defined, Acquisitions does not work properly and software can occur while receiving. This patch adds the warning message about missing active currency to Home > Acquisitions To test: - Apply patch - Go to Home > Administration > Currencies & Exchange Rates > Currencies - Make sure that no active currency is set - Go to Home > Acquisitions - Verify that a warning displays: - If user has at least permission for parameters_remaining_perissions, the warning should display a link to Currencies and exchange rates (currency.pl) - If the user has no permission to edit the Currencies and exchange rates, no link is displayed. - Set an active currency - Veryfy that the warning no longer displays (Amended to remove superfluous line / mv) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Work as described. No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:08:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:08:31 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-tYyjcbFM6E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #122 from Zeno Tajoli <z.tajoli at cineca.it> --- I insert the patch rebasing this branch of Colin [https://github.com/colinsc/koha/tree/edifact_snapshot_150911] with origin/master of today (27/10/2015]. Patch 0001-Rebase-on-master: the main rebase on master done from Colin's work. Patch 0002-Patch-to-update-DBIx: Update DBIX files from Colin's work Patch 0003-Modification-in-Acquisition.t: Update of Acquisition.t with new DB structure. Patch 0004-Fixed-the-definition-of-table-edifact_ean: My proposal to fix problem of defintion in edifact_ean table Patch 0005-EdifactEan_DBIx-update: The update of DBIx file for table edifact_ean Patch 0006-Fix-differences-between-kohastructure.sql-and-edifact.sql: There are same differences between kohastructure.sql and atomicupdate/edifact.sql about the structure of edifact_ean. With this patch I insert also in kohastructure.sql the creation of the coloum ee_id. With all patch installed there are still problem on using edi. I try to add the EAN/SAN to the library using administration/acquisitions/EDI EANs [...:8080/cgi-bin/koha/admin/edi_ean_accounts.pl] The result is: Software error: DBIx::Class::ResultSet::search(): No such relationship branch on EdifactEan at /production/develops/admin/edi_ean_accounts.pl line 93 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:10:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:10:29 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-H9osZfFV7M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43957|0 |1 is obsolete| | --- Comment #9 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 44077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44077&action=edit Bug 14954 - Remove C4::Dates from holiday related files in folder tools This patch removes C4::Dates from: Remove C4::Dates from: - tools/exceptionHolidays.pl - tools/holidays.pl - tools/newHolidays.pl - C4/Calendar.pm To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - prove t/Calendar.t (Amended following comments #3 and #4 / mv) (Amended following comment #7 / 25.10.2015 / mv Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> http://bugs.koha-community.org/show_bug.cgi?id=14945 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:11:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:11:17 +0000 Subject: [Koha-bugs] [Bug 14945] Add the ability to store the last patron to return an item In-Reply-To: <bug-14945-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14945-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14945-70-dAuLUiwjVO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14945 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44075|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <mirko at abunchofthings.net> --- Comment on attachment 44075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44075 Bug 14954 - Remove C4::Dates from holiday related files in folder tools Sorry, wrong bug (typo) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:11:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:11:50 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-fvYEyA7npZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44078&action=edit Bug 10120: (QA followup) avoid raising warnings on upgrade Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:13:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:13:51 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-UGx0g0yyoK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #123 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44079&action=edit 0001-Rebase-on-master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:14:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:14:06 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-alK6pb2Bzd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:14:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:14:26 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-fIzbBEZcMZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #124 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44080&action=edit 0002-Patch-to-update-DBIx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:14:54 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-RAEcTMh5MF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #125 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44081&action=edit 0003-Modification-in-Acquisition.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:15:35 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-QBZKP1WfPe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #126 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44082&action=edit 0004-Fixed-the-definition-of-table-edifact_ean -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:16:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:16:20 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-41ccUtmgdp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #127 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44083&action=edit 0005-EdifactEan_DBIx-update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:16:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:16:49 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-I7elU7mOWR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:16:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:16:53 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-3fEFnzHqP1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #128 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44084&action=edit 0006-Fix-differences-between-kohastructure.sql-and-edifact.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:18:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:18:46 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-54iMWSHDGE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43602|0 |1 is obsolete| | Attachment #43603|0 |1 is obsolete| | Attachment #43604|0 |1 is obsolete| | Attachment #43605|0 |1 is obsolete| | Attachment #43606|0 |1 is obsolete| | Attachment #43613|0 |1 is obsolete| | --- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44085&action=edit Bug 14100: Generic solution for language overlay - Item types Test plan: 1/ update the Schema (misc/devel/update_dbix_class_files.pl) 2/ Translate templates for some languages (es-DE, de-DE for instance) 3/ Enable them in the pref (search for 'lang') for the staff interface 4/ Go on the item type admin page (admin/itemtypes.pl) 5/ Edit one 6/ Click on the 'translate for other languages' link 7/ You are now on the interface to translate the item type's description in the languages you want. So translate some :) 8/ Go back on the item type list view (admin/itemtypes.pl) 9/ You should see the original description (non translated) 10/ Switch the language 11/ You should see the translated description in the correct language. If the description is non translated, the original description is displayed. 12/ On the different page where the item type is displayed, confirm that the translated description appears. Think further / Todo: 1/ Update all occurrences of the item type's description (DONE) 2/ Implement for authorised values 3/ Implement for syspref value (at least textarea) 4/ Implement for branch names 5/ Centralize all the translation on a single page in the admin area ... N/ Implement a webservice to centralize all the translations and give the ability to sync the item types/authorised values description with the rest of the world (push and pull). Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:18:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:18:50 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-6ocnicUcVM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44086&action=edit Bug 14100: (follow-up) Language overlay for item types Display the translated description for item types in the following pages: > admin/smart-rules.pl > catalogue/detail.pl > catalogue/itemsearch.pl > catalogue/moredetail.pl > reports/acquisitions_stats.pl > reports/bor_issues_top.pl > reports/cat_issues_top.pl > reports/catalogue_out.pl > reports/catalogue_stats.pl > reports/issues_avg_stats.pl > reports/issues_stats.pl > reports/itemslost.pl > reports/manager.pl > reports/reserves_stats.pl > suggestion/suggestion.pl > tools/export.pl > Opac: > opac-detail.pl > opac-MARCdetail.pl > opac-search.pl Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:18:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:18:57 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-xHUFFBvcbM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44088&action=edit Bug 14100: Move add form to the top Not sure this is the best: now the messages will make the table moves. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:18:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:18:54 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-j6ZCYZlYoN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44087&action=edit Bug 14100: Better errors handling This patch mainly improves the errors handling. It's now not possible to add several translations for the same entity-code-lang combination. It also: - wording: Translate for other languages => into - fixes encoding issues on add/update (was just display) - add entity and code to the title of the pop-up window Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:19:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:19:01 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-vpjrlSHUUf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44089&action=edit Bug 14100: Fix some missing occurrences This patch fixes: - reports/bor_issues_top.pl - sort order - adv search and search results - opac-topissues.pl Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:19:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:19:05 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-SkPZeacqJh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44090&action=edit Bug 14100: Fix 3 occurrences more - opac-suggestions.pl - opac-readingrecord.pl - opac-reserve.pl Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:19:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:19:20 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-WmsQ7C29UX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #7 from Alex Arnaud <alex.arnaud at biblibre.com> --- I go back on my word about findDuplicate. Searching duplicates with full title and author works for me. I have a book: Les montagnes from Keith Lye. Submit a suggestion with title "Les montagnes" => duplicate message Submit a suggestion with title "Les montagnes" and author "Keith Lye" => duplicate message Submit a suggestion with title "Les montagnes", author "Keith Lye" and itemtype "Book" => duplicate message. Anyone has the same problem than Marc ? I will send a new patch because i have broken the itemtypes list in the form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:21:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:21:44 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-smD5rJBWvr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #8 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44091&action=edit Bug 14973 - Fix broken itemtypes list in opac-suggestions form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:24:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:24:49 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-JWPkCEHhtC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:35:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:35:49 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-2oWardpMTc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #105 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Fr?d?ric Demians from comment #103) > Here's what I can think of this. > > There is already in Koha an inconsistency in the way DC is generated. (1) > When > exporting, C4::Record::marc2dcxml() is used. (2) In OAI server, an XSLT > transformation is done using XSL file found in koha-tmpl/intranet- > tmpl/prog/en/xslt. The OAI approach seems more sensible since it allows to > have a transformation logic per MARC flavor, and even in OAI extended mode, a > transformation specific to a Koha installation. > > Currently, C4::Record::marc2dcxml() delegates the semantic transformation > from > MARC21 to XML DC to this module: MARC::Crosswalk::DublinCore. I don't think > this is a great idea. This is an old-unmaintained module (10 years old). And > it doesn't work for Unimarc. I haven't paid attention to that, but I can't > see > how DC export could work with an Unimarc catalog. Your module > Koha::Crosswalk::DublinCore still wraps a call MARC::Crosswalk::DublinCore. > > The MARC21 to Unimarc transformation on the fly isn't a good idea at all. > This > would add complexity for an unreliable result. > > Why not just fixing XSL files transforming MARCXML biblios into DC and use > them in marc2dcxml()? > > Side note about dependencies -- RDF::Trine have Moose as dependency. Aren't > we > supposed to avoid that? Where I can find information about avoiding Moose in Koha? Another question is: How to deal with RDF and SPARQL in Koha if we can't use Moose? All linked data in Semantic Web point to use RDF as basis. For example, the new recommendation for DC is RDF <http://dublincore.org/documents/dc-rdf/>. BIBCO works with RDF. RDA Resgistry <http://www.rdaregistry.info/> works with RDF. RIMMF works with RDF. With xslt transformation we can only transform to simple DC RDF (BTW, out-of-date, superseded standard <http://dublincore.org/documents/dcmes-xml/>), and what about the potential to use the complete dcterm namespace? Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:40:40 +0000 Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships - biblio<->biblioitem<->item In-Reply-To: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14819-70-ncavIMQaX4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle.m.hall at gmail.com --- Comment #2 from Kyle M Hall <kyle.m.hall at gmail.com> --- Koha::Item::biblioitem appears to return a DBIC object. Can you create Koha::Biblioitem and use the _wrap method so it can return a Koha::Biblioitem object? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:41:28 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14133-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14133-70-HBsglkyWZX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Fr?d?ric Demians <frederic at tamil.fr> --- > IMPORTANT NOTE: This test plan does not take into account the notices > generated for the staff ("These messages were not sent directly to the > patrons."). However the behavior will also change, the print template > will be used in all cases. Is it what we want? The question is: What for the -n parameter is used? Who used it? I personally never uses it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:42:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:42:07 +0000 Subject: [Koha-bugs] [Bug 15070] New: Update MARC21 it-IT frameworks to Update 21 (September 2015) Message-ID: <bug-15070-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Bug ID: 15070 Summary: Update MARC21 it-IT frameworks to Update 21 (September 2015) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org The defaults .sql files for authority and bibliographic need to be updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:42:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:42:29 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: <bug-15070-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15070-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15070-70-RMTFsGn8da@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:43:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:43:06 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14998-70-M4QGY2Vk4e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #3 from Marc V?ron <veron at veron.ch> --- Created attachment 44092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44092&action=edit Bug 14998 - (followup) Remove file fix_accountlines_date.pl This patch removes the file misc/maintenance/fix_accountlines_date.pl To test: - Verify that the file is no longer used - Apply patch - Verify that the file vanished -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:43:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:43:13 +0000 Subject: [Koha-bugs] [Bug 15070] Update MARC21 it-IT frameworks to Update 21 (September 2015) In-Reply-To: <bug-15070-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15070-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15070-70-m4ArqrjIc2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15070 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:45:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:45:16 +0000 Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships - biblio<->biblioitem<->item In-Reply-To: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14819-70-olarWdRTdP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:45:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:45:30 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-ERR77g5hm4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #106 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Katrin Fischer from comment #104) > Hi Frederick, thx for your comment! I like the idea of reusing the XSLT. Let me propose a patch in this way... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:45:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:45:52 +0000 Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships - biblio<->biblioitem<->item In-Reply-To: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14819-70-b04rOVorLl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42531|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44093&action=edit [SIGNED-OFF] Bug 14819: Add missing DBIx::Class relationships - biblio<->biblioitem<->item To access the biblio from an item, we should not use the biblioitemnumber relationship autogenerated by DBIx::Class::Schema::Loader but create our own one. Test plan: Confirm the tests pass and that there is no regression on bug 14726. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test pass, no regressions, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:52:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:52:47 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-xdZNjYQrWW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #60 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44094&action=edit Bug 14100: (QA followup) fix wrong comment in kohastructure.sql Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:54:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:54:15 +0000 Subject: [Koha-bugs] [Bug 11559] Professional cataloger's interface In-Reply-To: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11559-70-PUnfv9zaRv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #199 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Feature pushed to master. Thanks Jesse and everyone testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 16:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 15:54:57 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-DupBcyXET5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #61 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Nice feature! Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 17:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 16:06:02 +0000 Subject: [Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module In-Reply-To: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10933-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10933-70-vKK5zUTIfo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44095&action=edit ug 10933: (follow-up of the follow-up) fix the previous patch to work with master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 17:11:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 16:11:41 +0000 Subject: [Koha-bugs] [Bug 15071] New: red color on check outs Message-ID: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Bug ID: 15071 Summary: red color on check outs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org I got an inquiry about the way call numbers used to be highlighted in red when an item was checked out. It now goes to gray which is less noticeable to students and staff and has caused a few people to make more inquiries about items. I think this is qualified as a bug. Is it possible to get that feature back in Koha. It was a small thing, but it was nice because it was a signal that the item was out. There are no CSS elements to select on to add the color back that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 17:19:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 16:19:53 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15071-70-wL0sMrLVO4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Where? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 17:28:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 16:28:11 +0000 Subject: [Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search In-Reply-To: <bug-14861-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14861-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14861-70-1CRmFj4GL8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 17:53:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 16:53:25 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-16wJHZwU9W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #16 from Marc V?ron <veron at veron.ch> --- Created attachment 44096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44096&action=edit Bug 14903 - (followup)Remove C4::Dates from circ/circulation.pl Follow up to fix QA issues from comment #15 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 17:54:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 16:54:47 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-X65YDbJEl7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Marc V?ron <veron at veron.ch> --- Jonathan, is it OK to switch back to Signed-off with the followup? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 18:43:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 17:43:14 +0000 Subject: [Koha-bugs] [Bug 15072] New: Breadcrumbs and titles inconsistent in Label creator Message-ID: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bug ID: 15072 Summary: Breadcrumbs and titles inconsistent in Label creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 18:44:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 17:44:36 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-vjkclw8OMd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14667 Assignee|cnighswonger at foundations.ed |tomascohen at gmail.com |u | CC| |katrin.fischer at bsz-bw.de, | |liz at catalyst.net.nz --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- After the UX/UI patches got pushed, the only missing piece was making the breadcrumbs more consistent. The same applies to the page title. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 [Bug 14667] Label creator UI/UX revamp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 18:44:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 17:44:36 +0000 Subject: [Koha-bugs] [Bug 14667] Label creator UI/UX revamp In-Reply-To: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14667-70-3rzoCQjqAN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15072 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 [Bug 15072] Breadcrumbs and titles inconsistent in Label creator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 19:13:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 18:13:50 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-zMlP848T41@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #107 from Fr?d?ric Demians <frederic at tamil.fr> --- > With xslt transformation we can only transform to simple DC RDF (BTW, out- > of-date, superseded standard <http://dublincore.org/documents/dcmes-xml/>), > and what about the potential to use the complete dcterm namespace? Can you elaborate? I don't understand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 19:25:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 18:25:16 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-S7XdHLta88@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44097&action=edit Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 19:25:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 18:25:19 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-7sXIkEn0HK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44098&action=edit Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 19:25:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 18:25:24 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-xdZ9JhSlhk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44099&action=edit Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 19:25:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 18:25:58 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-AavWmQeUDp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 19:28:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 18:28:37 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-Imu3hquwsc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:04:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:04:58 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-pW51uWuUE9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44010|0 |1 is obsolete| | --- Comment #7 from Marc V?ron <veron at veron.ch> --- Comment on attachment 44010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44010 Bug 14977: followup to fix NewsChanell.t Thanks Bernardo for the trying to fix. It helped to find out what happens. New patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:12:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:12:18 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-jTNg8m8vM4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 --- Comment #8 from Marc V?ron <veron at veron.ch> --- Created attachment 44100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44100&action=edit Bug 14977 - Followup to fix issue with NewsChannels.t The problem was that get_opac_new returns dates already syspref-formatted. To test: - Apply patch - Verify that t/db_dependent/NewsChannels.t does not fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:12:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:12:51 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-7uylOPcljn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:30:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:30:08 +0000 Subject: [Koha-bugs] [Bug 14246] Add borrowernumber to koha_news In-Reply-To: <bug-14246-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14246-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14246-70-Jf5U0zGdDE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #40 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:30:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:30:30 +0000 Subject: [Koha-bugs] [Bug 14247] System preference for news author display In-Reply-To: <bug-14247-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14247-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14247-70-j2swhZNYlE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:31:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:31:11 +0000 Subject: [Koha-bugs] [Bug 14248] Optionally display authorship for news items In-Reply-To: <bug-14248-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14248-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14248-70-CBRZati88a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Martin, Mark and Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:46:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:46:55 +0000 Subject: [Koha-bugs] [Bug 14190] Scale search boxes in staff head In-Reply-To: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14190-70-tnYeeMAq7f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Eivin and congratulations for your commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 20:51:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 19:51:16 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-DpnnhLVPo3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #108 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Fr?d?ric Demians from comment #107) >Can you elaborate? I don't understand. Have you tested the patch? With this module (Koha::Crosswalk::DublinCore) I can support more metada than the simple 15 DC elements (Element Set Version 1.1). This Simple DC is used for OAI and SRW in xml format. But also i can reproduce this other guidelines/recommendations: * <http://dublincore.org/documents/dc-xml-guidelines/> and example of this in <http://www.dublincoregenerator.com/generator.html> * <http://dublincore.org/documents/dcmes-xml/> * <http://dublincore.org/documents/dc-rdf/> And RDF::Trine can serialize multiple rdf formats (rdf-json, rdf-xml, nquads, nquads-canonical, turtle) also give us the opportunity of storing the triples in databases; with RDF::Query we can perform queries with SPARQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 21:01:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 20:01:45 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: <bug-10347-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10347-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10347-70-fAbcPoayzg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 21:07:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 20:07:00 +0000 Subject: [Koha-bugs] [Bug 15042] Barcode <branchcode>yymm0001 does not work when receiving serials In-Reply-To: <bug-15042-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15042-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15042-70-PLhME9Fu4F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 21:07:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 20:07:54 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-FmeSb0QOvz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Nice job Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 21:43:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 20:43:25 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14131-70-XgeB5N6tlA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #24 from Liz Rea <liz at catalyst.net.nz> --- Jonathan, do you think we should change the height on that greybox across the board for the label and patron card creators? It kinda feels like the right thing to do. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 22:40:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 21:40:35 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-XEssIOiL6L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 22:40:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 21:40:38 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-RwrtXRSEZ2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43956|0 |1 is obsolete| | --- Comment #9 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 44101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44101&action=edit [SIGNED OFF] Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv Signed-off-by: Jesse Weaver <pianohacker at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 23:38:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 22:38:18 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11858-70-GXMunE2S6W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 NancyK. <nkeener at washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us --- Comment #5 from NancyK. <nkeener at washoecounty.us> --- We are looking to go with RFID at Washoe County. To have to check in and out one item at a time is not going to go over well. What can we do to get this moving? NancyK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 23:39:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 22:39:24 +0000 Subject: [Koha-bugs] [Bug 14959] Support for Library Communications Framework (LCF) In-Reply-To: <bug-14959-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14959-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14959-70-C82cOfGPyu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14959 NancyK. <nkeener at washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 23:40:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 22:40:14 +0000 Subject: [Koha-bugs] [Bug 2244] RFID Cataloguing and Circulation In-Reply-To: <bug-2244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2244-70-VOzDEcRD8A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244 NancyK. <nkeener at washoecounty.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nkeener at washoecounty.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Oct 27 23:45:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 27 Oct 2015 22:45:04 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15071-70-0CgSuIzh51@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Nicole, which spot in Koha are you talking about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 01:29:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 00:29:18 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10154-70-xXOAcDLK2R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #2 from Eivin Giske Skaaren <eivin at sysmystic.com> --- Created attachment 44102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44102&action=edit Added functionality for ccode and shelving location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 01:46:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 00:46:54 +0000 Subject: [Koha-bugs] [Bug 15071] red color on check outs In-Reply-To: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15071-70-lFDvrYr9Qy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Owen Leonard from comment #1) > Where? Yeah, where? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:21:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:21:58 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14131-70-4y9QU5YqpA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Liz Rea from comment #24) > Jonathan, do you think we should change the height on that greybox across > the board for the label and patron card creators? > > It kinda feels like the right thing to do. > > Liz Indeed, to be consistent it would be good to reduce them too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:23:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:23:25 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14131-70-HpxSItGXwB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #26 from Liz Rea <liz at catalyst.net.nz> --- cool I'll probably have a poke at that one unless you've already started on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:27:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:27:41 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-tUv7g9QayM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:33:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:33:08 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the export tool In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-AsS2EsDex1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Is the script "misc/exportauth.pl" then obsolete ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:42:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:42:26 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-M05lpoPhIn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:42:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:42:28 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-tcnFlYd8YQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43302|0 |1 is obsolete| | Attachment #44101|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44103&action=edit Bug 14931 - Remove C4::Dates from files admin/aq*.pl This patch removes C4::Dates from: - admin/aqbudgets.pl - admin/aqplan.pl - admin/aqcontract.pl To test: - Apply patch - Go to Home > Adminstration > Budgets > All funds (admin/aqbudgets.pl) - Verify that everything displays as before - Edit one of the funds and click on 'Planning - Plan by months' (admin/aqplan.pl) - Verify that planning works as before - Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised. Tested with dateformat syspref Dates in planning by months not needed to be on iso format, aqplan.pl uses instead Date::Calc Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:42:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:42:43 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-NxHAipWNm5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44105&action=edit Bug 14931: (qa followu-up) small improvements - Avoid 1 call to dt_from_string in some cases - Do not use $_ Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:42:39 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-PjQMpRxqEH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44104&action=edit Bug 14931 - (Follow-up) Validate date entry in contracts Go to Home > Acquisitions, search for an active vendor and view the vendor - Click on 'Contracts' at the left (admin/aqcontract.pl) - Create and edit contracts and verify that it works OK. (Note: there is no help for this page, see Bug 14929) Amended for comment #7 25.10.2015 / mv Signed-off-by: Jesse Weaver <pianohacker at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:52:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:52:36 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-v5ZU88ilDL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:52:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:52:43 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-DFiRZJ9NP6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 44106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44106&action=edit Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:58:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:58:01 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-D66dK8ESjy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #3) > Please provide a fix on top of bug 14955 Super, Bug 14955 fixes the facets includes. This patch will only fix branchoverdues.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 09:59:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 08:59:41 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-aKWYxeYYT1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44107&action=edit Bug 14931: Fix test xt/author/valid_templates complaining on opac-topissues.tt undef error - Undefined subroutine &C4::Languages::getlanguage called at C4/Koha.pm line 250. Test plan: prove xt/author/valid-templates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:00:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:00:37 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-QOzXmkAZFx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:01:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:01:10 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-TLlrNYL7Nl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44108&action=edit Bug 14100: Fix test xt/author/valid_templates complaining on opac-topissues.tt undef error - Undefined subroutine &C4::Languages::getlanguage called at C4/Koha.pm line 250. Test plan: prove xt/author/valid-templates.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:05:39 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-X96PHSGHL5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #5) > (In reply to Jonathan Druart from comment #3) > > Please provide a fix on top of bug 14955 > > Super, Bug 14955 fixes the facets includes. > This patch will only fix branchoverdues.tt In this case, this bug can be tested without bug 14955. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:12:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:12:42 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-3fvcjNznyv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44109&action=edit Bug 14100: Fix t/db_dependent/Items.t prove t/db_dependent/Items.t Undefined subroutine &C4::Languages::getlanguage called at C4/Items.pm line 1304. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:24:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:24:55 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14955-70-OY4akHnloR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43382|0 |1 is obsolete| | --- Comment #8 from Marc V?ron <veron at veron.ch> --- Created attachment 44110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44110&action=edit Bug 14955: Don't double encode chars in the "Show more" link Bug 13789 has fixed this issue for the facet links (select/unselect) but not for the "Show more" facets link. This patch reuses the "url" variable, generated for the facets, for these links. A new "local_url" variable is used to build links for each entry. Test plan (for OPAC and intranet): - Search for a very common term - Filter the results using facets - You should get more than 5 entries for a facet and 1 selected: Author author 1 author 2 [x] # Selected author 3 author 4 author 5 Show more # you see this link if there is 5+ values for this facet - Click on the Show more link Without this patch, the url contains double-encoded characters and you will certainly don't get any results With this patch, you should get results. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:25:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:25:34 +0000 Subject: [Koha-bugs] [Bug 14955] "Show more" link contains double encoded characters In-Reply-To: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14955-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14955-70-4MYrKZL426@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14955 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:29:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:29:09 +0000 Subject: [Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists In-Reply-To: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14131-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14131-70-XqSMWSMTJr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Liz Rea from comment #26) > cool I'll probably have a poke at that one unless you've already started on > it. I don't :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:33:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:33:39 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-0SAvArapW9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #109 from Fr?d?ric Demians <frederic at tamil.fr> --- > Have you tested the patch? Yes. My questions are not related to your patch WUI and result, but to your implementation, your goals. Somehwhere in the process, I take a look at the code, spend time on it, trying to figure out how it works, how it has been done. Testing and QAing is all about that. I have mixed feeling, when I find duplicated code (for example). In opac/opac- export.pl and catalog/export.pl: SWITCH: for ($recommendation) { if (/^simple-dc-rdf/) { ($error,$marc) = marc2dcxml($marc, $recommendation, 0, 1, undef, undef, $resource_url , $formats); $format = "dublin-core." . $formats; last SWITCH; } if (/^dc-rdf/) { ($error,$marc) = marc2dcxml($marc, $recommendation, 1, 1, undef, undef, $resource_url, $formats); $format = "dublin-core." . $formats; last SWITCH; } if (/^dc-xml/) { ($error,$marc) = marc2dcxml($marc, $recommendation, $qualifier, 1, $root_element, $xsischemalocation, undef, undef); $format = "dublin-core.xml"; last SWITCH; } if (/^oai-dc/) { ($error,$marc) = marc2dcxml($marc, $recommendation); $format = "dublin-core.xml"; last SWITCH; } if (/^srw_dc/) { ($error,$marc) = marc2dcxml($marc, $recommendation); $format = "dublin-core.xml"; last SWITCH; } } Or in Koha::Crosswalk::DublinCore.pm, line 242, you get: if ( exists $self->{xsi_schemaLocation} ) { $dataxml{'xsi_schemaLocation'} = $self->{xsi_schemaLocation}; } if ( exists $self->{xsi_schemaLocation} ) { $dataxml{'opt_namespace'} = $self->{opt_namespace}; } if ( exists $self->{xsi_schemaLocation} ) { $dataxml{'opt_namespace_url'} = $self->{opt_namespace_url}; } Is it valid? > With this module (Koha::Crosswalk::DublinCore) I can support more metada > than the simple 15 DC elements (Element Set Version 1.1). This Simple DC is > used for OAI and SRW in xml format. But also i can reproduce this other > guidelines/recommendations: How will you extend the semantic of the produced metadata with MARC::Crosswalk::Dublincore? If you want more than the 15 DC elements, doesn't it mean that you need a mean to improve, granularize the way Koha MARC record is transformed. The current DC exported from Koha is not that good because (1) it doesn't work for Unimarc, (2) it doesn't allow each library to tweak the transformation from MARC to DC (the way it's done by OAI server). > And RDF::Trine can serialize multiple rdf formats (rdf-json, rdf-xml, > nquads, nquads-canonical, turtle) also give us the opportunity of storing > the triples in databases; with RDF::Query we can perform queries with SPARQL It's far beyond the scope of this patch. Open a new bug if you want, and name it Semantic-Koha, or Sekoa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:33:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:33:53 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-0JNqmaloEW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42340|0 |1 is obsolete| | --- Comment #63 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44111&action=edit Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:34:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:34:39 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-bSFc0O0H6o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44106|0 |1 is obsolete| | --- Comment #7 from Marc V?ron <veron at veron.ch> --- Created attachment 44112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44112&action=edit Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:34:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:34:50 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-46fdTtwgUC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:39:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:39:23 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-mh7tDvJBD7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #64 from Alex Arnaud <alex.arnaud at biblibre.com> --- Fixed last patch. A rebase against master is coming soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:39:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:39:24 +0000 Subject: [Koha-bugs] [Bug 14722] Refactor the catalogue export tool (command-line tools/export.pl does not work anymore. Use misc/export_catalogue.pl instead) In-Reply-To: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14722-70-WJKuj6V9Or@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14722 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Refactor the export tool |Refactor the catalogue | |export tool (command-line | |tools/export.pl does not | |work anymore. Use | |misc/export_catalogue.pl | |instead) CC| |paul.poulain at biblibre.com Severity|enhancement |new feature --- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> --- Updating title and importance to have the release notes automatically filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:52:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:52:37 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13671-70-lBuvMOXB8u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #5 from Liz Rea <liz at catalyst.net.nz> --- I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it before but for the life of me I can't remember what I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:52:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:52:48 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13671-70-hY5R0jqLkd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 --- Comment #6 from Liz Rea <liz at catalyst.net.nz> --- I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it before but for the life of me I can't remember what I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:52:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:52:54 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13671-70-v6ZcEL8jCy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 --- Comment #7 from Liz Rea <liz at catalyst.net.nz> --- I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it before but for the life of me I can't remember what I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:52:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:52:58 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13671-70-B2fpBBuYSu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 --- Comment #8 from Liz Rea <liz at catalyst.net.nz> --- I just saw this happen moving from 3.14 -> 3.20 - I'm sure I've solved it before but for the life of me I can't remember what I did. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:53:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:53:13 +0000 Subject: [Koha-bugs] [Bug 13671] Search returning empty In-Reply-To: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13671-70-ndHdpWjcO6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13671 --- Comment #9 from Liz Rea <liz at catalyst.net.nz> --- jesus, sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:59:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:59:20 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-S1HqfUYd5Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42336|0 |1 is obsolete| | --- Comment #65 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44113&action=edit Bug 9223: Multiple values of AdvancedSearchTypes in suggestions Suggestion form uses C4::Koha::GetSupportList to get a list of supports that can come from itemtypes or authoritized values LOC or CCODE. C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one value. But this syspref can contain several values separated by a pipe. This patch introduces a new syspref SupportsAuthorizedValues to select wich authorized values category that represents the physical support (itemtypes by default, loc or ccode). These authorized values will be used in suggestion management, known as 'document type'. (Note that database field is still 'itemtype'). Test plan : ----------- - Set SupportsAuthorizedValues with itemtypes or loc or ccode - Get to suggestion form (OPAC or intranet) - Look at "Document type" combobox, it must contains descriptions of selected authorized values - Save the suggestion - Get to intranet suggestions management - Organize suggestions by document type => your suggestion must appear in a tab with its document type description Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:59:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:59:32 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-H5xciA4JrS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42337|0 |1 is obsolete| | --- Comment #66 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44114&action=edit Bug 9223: Add SupportsAuthorizedValues syspref (followup 1) Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:59:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:59:44 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-qceY48Ig2V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42338|0 |1 is obsolete| | --- Comment #67 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44115&action=edit Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions This follow-up implements some things I think will improve on the previous patches: - Change the system preference name to "SuggestionsUseValues" - Change the description of the preference to "Suggestions can be submitted using the following authorized values:" - Move the new preference to the OPAC tab so that it is grouped with other suggestions-related preferences. - Add the option offer no itemtype/collection code chooser on the submission form. - Display the correct label on the submission form depending on the value of the SuggestionsUseValues preference. To test, apply this patch on top of the previous ones. Test submission of purchase suggestions through the OPAC and staff client with the SuggestionsUseValues preference set to all the various choices: item type, collection code, shelving location, and 'none.' The suggestion forms should look correct and work correctly. HOWEVER, neither the previous patches nor mine address the problem of the suggestions management page's "organize by" option, which is hard-coded to work with item types. Whether or not my patch is acceptable this issue will need to be addressed. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> Tested the TEST PLAN. With ccode, itype, none, loc. On both OPAC and SC. Making a code review, but it is hard during the hackfest. Morbid lack of any kind of unit test! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 10:59:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 09:59:56 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-e4CXYNKVct@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42339|0 |1 is obsolete| | --- Comment #68 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44116&action=edit Bug 9223 [Follow-up] change the way syspref SuggestionsUseValues is added: Use the new worflow (atomic update) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 11:00:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 10:00:06 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-LPIESBbZgh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44111|0 |1 is obsolete| | --- Comment #69 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44117&action=edit Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName subroutine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 11:00:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 10:00:15 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-9TaFdpn9Fg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 --- Comment #70 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44118&action=edit Bug 9223 - Fix QA issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 11:03:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 10:03:12 +0000 Subject: [Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions In-Reply-To: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9223-70-dwHf37943Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 11:55:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 10:55:48 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-2wQr6DFMsq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44119&action=edit Bug 14100: Fix Search.t tests So, this one is VERY weird, let me try to explain what I have understood. Bisecting using run prove t/db_dependent/Search.t, I have found that the following commit make the test fail: commit 0f63f89f66e40cc01ef02da3654fcfb404c9001d Bug 14100: Generic solution for language overlay - Item types The error is DBI bind_columns: invalid number of arguments: got handle + 0, expected handle + between 1 and -1 Usage: $h->bind_columns(\$var1 [, \$var2, ...]) at /usr/lib/i386-linux-gnu/perl5/5.20/DBI.pm line 2065. Note that the interface (admin/itemtypes.pl) which calls the same subroutine with the same parameter (style => 'array') works great. The problem comes from the change in C4::Search::searchResults, if I only apply the change done to this subroutine on 0f63f89f^1, I reproduce the issue. Looking closely at how %itemtypes is built, we could actually call GetItemTypes with the style => 'hash' to get exactly what we want. The following piece prove it for you: use Test::More; use C4::Koha; my $i = GetItemTypes; my $j = GetItemTypes(style => 'array'); my %itemtypes; for my $itemtype ( @$j ) { $itemtypes{ $itemtype->{itemtype} } = $itemtype; } is_deeply( \%itemtypes, $i); So changing the code accordingly and just forget this last hour... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 11:56:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 10:56:16 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-4fXfPghYq2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #5 from Marc V?ron <veron at veron.ch> --- Created attachment 44120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44120&action=edit Bug 14722: CSV is only available for biblio records Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 11:57:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 10:57:21 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-dNJkUkmnfz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Attachment #44120|0 |1 is obsolete| | --- Comment #6 from Marc V?ron <veron at veron.ch> --- Comment on attachment 44120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44120 Bug 14722: CSV is only available for biblio records Sorry, i messed something whil trying to attach multiple patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 12:03:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 11:03:38 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-fAiK1lV3Rn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 12:03:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 11:03:42 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-0asqhQSQwi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44008|0 |1 is obsolete| | Attachment #44100|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44121&action=edit Bug 14977 - Remove C4::Dates from files t/db_dependent/*.t This patch removes C4::Dates from following files: - t/db_dependent/Budgets.t - t/db_dependent/Holds.t - t/db_dependent/Koha_template_plugin_KohaDates.t - t/db_dependent/Log.t - t/db_dependent/NewsChannels.t To test: - First run all tests above - Apply patch - Then run tests again. The results should be the same. (Note: I get 2 fails with NewsChannels.t, they are the same with and without patch). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> NewsChanell pass for me before patch, no after. Followup follows :) Rest of tests pass Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 12:03:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 11:03:45 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-pQFNdzxBbM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44122&action=edit Bug 14977 - Followup to fix issue with NewsChannels.t The problem was that get_opac_new returns dates already syspref-formatted. To test: - Apply patch - Verify that t/db_dependent/NewsChannels.t does not fail. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 12:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 11:04:00 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-jvdJqCTHWZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 12:15:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 11:15:20 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-OB0WJeL0Io@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marc V?ron from comment #17) > Jonathan, is it OK to switch back to Signed-off with the followup? Yes because the following is still wrong: $template->param( IMPOSSIBLE=>1, INVALID_DATE=>$datedue ) Test plan: Set and force an invalid date for the due date and confirm you get a warning with the invalid date displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 14:38:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 13:38:56 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-dVsayutoO4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- $ git grep -l labels_t I think Russian and Ukrainian are broken as well. Please submit follow ups for those, so I can just sign off everyone accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 14:48:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 13:48:14 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: <bug-15030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15030-70-yvDChXr5uG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 43601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43601 Bug 15030 - Certain values in serials' items are lost on next edit Review of attachment 43601: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15030&attachment=43601) ----------------------------------------------------------------- ::: C4/Items.pm @@ +2944,4 @@ > if ( $tagslib->{$tag}->{$subfield}->{kohafield} eq 'items.itemcallnumber' > && $defaultvalues > && $defaultvalues->{'callnumber'} ) { > + if( $itemrecord and $defaultvalues and not $itemrecord->subfield($tag,$subfield) ){ YIKES! Nice find. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 14:57:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 13:57:00 +0000 Subject: [Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit In-Reply-To: <bug-15030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15030-70-Xx8eejm0SV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Okay... this modifies a routine in C4/Items.pm There is no test coverage directly for PrepareItemrecordDisplay. However, there is some in t/db_dependent/Serials.t I would recommend adding a test there to validate your changes as a separate commit. This would allow the test to run before applying the other patches (expecting failure), and after applying them (expecting passing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:12:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:12:34 +0000 Subject: [Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address In-Reply-To: <bug-14964-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14964-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14964-70-kC8Aq3OBqa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- I cringe at the lack of test coverage for C4::Message. *sigh* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:15:47 +0000 Subject: [Koha-bugs] [Bug 15073] New: FeeOnChangePatronCategory in wrong place Message-ID: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Bug ID: 15073 Summary: FeeOnChangePatronCategory in wrong place Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: System Administration Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 13697 The FeeOnChangePatronCategory preference needs to be moved to a more logical place. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:15:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:15:47 +0000 Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13697-70-1mWjIOf9mP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15073 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 [Bug 15073] FeeOnChangePatronCategory in wrong place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:21:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:21:23 +0000 Subject: [Koha-bugs] [Bug 15074] New: build-git-snapshot does not work in Jessie (can't build with source format '3.0 (native)') Message-ID: <bug-15074-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15074 Bug ID: 15074 Summary: build-git-snapshot does not work in Jessie (can't build with source format '3.0 (native)') Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mirko at abunchofthings.net QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz On Jessie, build-git-snapshot dies with > dpkg-source: error: can't build with source format '3.0 (native)': native package version may not have a revision" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:23:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:23:06 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-51T1ZivtIY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10327|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44123&action=edit Bug 5979 - Follow up: using OPACISBD systempreference to display link -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:31:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:31:36 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15073-70-YgHCNRoSyc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:31:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:31:38 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15073-70-uEFUdm9WcJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44124&action=edit Bug 15073: Move FeeOnChangePatronCategory This patch moves the FeeOnChangePatronCategory system preference so that it's in a more logical place. Also a few typos were fixed. To test: * Go to System Preferences * Go to Patrons * Find FeeOnChangePatronCategory and confirm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:47:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:47:23 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-NBwDb4DD4J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44007|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44125&action=edit Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Fixes other sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql or ru-RU/optional/print_labels.sql or uk-UA/optional/print_labels.sql Without the patch this files can't be loaded Test all of them In case of ru and uk I removed a patron card layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:49:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:49:20 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-ad4FlMZjSJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to M. Tompsett from comment #5) > $ git grep -l labels_t > I think Russian and Ukrainian are broken as well. > Please submit follow ups for those, so I can just sign off everyone > accordingly. Uploaded some kind of fix for ru and uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:50:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:50:39 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-ugPRY5K6vm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #15 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44126&action=edit Bug 5979 - OPAC ISBD view has its own syspref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 15:53:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 14:53:03 +0000 Subject: [Koha-bugs] [Bug 15074] build-git-snapshot does not work in Jessie (can't build with source format '3.0 (native)') In-Reply-To: <bug-15074-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15074-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15074-70-icBKrPIV9G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15074 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> --- Nevermind, was probably caused by the version name I chose. It's not supposed to have something like -1 in there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:03:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:03:00 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-ZPooolTHBA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #16 from Alex Arnaud <alex.arnaud at biblibre.com> --- Syspref OPACISBD is now a textarea so it's possible to have a different template in staff and opac. I didn't add a "OPACviewISBD", empty OPACISBD is enough for disable ISBD view in opac. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:08:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:08:32 +0000 Subject: [Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee In-Reply-To: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13697-70-EQAPm1IX2V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #13 from Nicole C. Engard <nengard at gmail.com> --- All better: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:10:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:10:00 +0000 Subject: [Koha-bugs] [Bug 14209] opacserialdefaulttab ignored with bibs having items <1 or >50 In-Reply-To: <bug-14209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14209-70-x2A2IOY9qG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14209 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:10:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:10:28 +0000 Subject: [Koha-bugs] [Bug 13294] Subscription and Holding tab interaction. In-Reply-To: <bug-13294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13294-70-fdxH5WyQLH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13294 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:11:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:11:09 +0000 Subject: [Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata In-Reply-To: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13642-70-d7I1EqtacG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #110 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to Fr?d?ric Demians from comment #109) > Somehwhere in the process, I take a look at the code, spend time on it, > trying > to figure out how it works, how it has been done. Testing and QAing is all > about that. > > I have mixed feeling, when I find duplicated code (for example). In > opac/opac- > export.pl and catalog/export.pl: > Or in Koha::Crosswalk::DublinCore.pm, line 242, you get: > Is it valid? > How will you extend the semantic of the produced metadata with > MARC::Crosswalk::Dublincore? If you want more than the 15 DC elements, > doesn't > it mean that you need a mean to improve, granularize the way Koha MARC record > is transformed. The current DC exported from Koha is not that good because > (1) > it doesn't work for Unimarc, (2) it doesn't allow each library to tweak the > transformation from MARC to DC (the way it's done by OAI server). > It's far beyond the scope of this patch. Open a new bug if you want, and name > it Semantic-Koha, or Sekoa. Yes, you're right Fr?d?ric. I'm just a librarian trying to improve. Let me propose another patch with your suggestion, using the xslts for transforming the marc flavors. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:30:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:30:48 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-o1yUXZL2BJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 44077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44077 Bug 14954 - Remove C4::Dates from holiday related files in folder tools Review of attachment 44077: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14954&attachment=44077) ----------------------------------------------------------------- Looking at the patch, some changes smell false. I might be wrong. ::: C4/Calendar.pm @@ +707,5 @@ > > sub addDate { > my ($self, $startdate, $offset) = @_; > + $startdate = eval { output_pref( { dt => dt_from_string( $startdate ), dateonly => 1, dateformat => 'iso' } ); }; > + my ( $year, $month, $day) = split( "-", $startdate ); $startdate is already a dt! @@ +730,5 @@ > } else { ## ($daysMode eq 'Days') > ($year, $month, $day) = &Date::Calc::Add_Delta_Days($year, $month, $day, $offset ); > } > + my $date_ret = sprintf(ISO_DATE_FORMAT,$year,$month,$day); > + $date_ret = eval { output_pref( { dt => dt_from_string( $date_ret), dateonly => 1, dateformat => 'iso' } ); }; This looks wrong, $date_ret is not in the pref format (what dt_from_string is expecting). There is a fallback on iso, but when you know the format is iso, you have to provide it. @@ +736,3 @@ > } > > =head2 daysBetween This subroutine is not used anywhere, prefer to remove it before this patch. ::: tools/holidays.pl @@ +49,3 @@ > # if the url has an invalid date default to 'now.' > +$calendardate = output_pref( { dt => $calendarinput_dt, dateonly => 1 } ); > +$keydate = output_pref( { dt => $calendarinput_dt, dateonly => 1, dateformat => 'iso' } ); That's not what it was done before. @@ +132,4 @@ > my $single_holidays = $calendar->get_single_holidays(); > my @holidays; > foreach my $yearMonthDay (keys %$single_holidays) { > + my $holidaydate = eval { dt_from_string( $single_holidays->{$yearMonthDay}{date} ) }; specify iso. @@ +136,4 @@ > my %holiday; > %holiday = (KEY => $yearMonthDay, > DATE_SORT => $single_holidays->{$yearMonthDay}{date}, > + DATE => output_pref( { dt => $holidaydate, dateonly => 1, dateformat => 'iso' } ), before the output was "syspref" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:30:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:30:55 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-jy4PNUlDtU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:35:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:35:38 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-ygnC9CCJqc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 44125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44125 Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Review of attachment 44125: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15053&attachment=44125) ----------------------------------------------------------------- Same for both RU and UK files. ::: installer/data/mysql/ru-RU/optional/print_labels.sql @@ -17,5 @@ > -LOCK TABLES `labels_conf` WRITE; > -/*!40000 ALTER TABLE `labels_conf` DISABLE KEYS */; > -INSERT INTO `labels_conf` > -(id,barcodetype,title,subtitle,itemtype,barcode,dewey,classification,subclass,itemcallnumber,author,issn,isbn,startlabel, > -printingtype,formatstring,layoutname,guidebox,active,fonttype,ccode,callnum_split) Why remove the fields list completely? It would have been good to keep updated. @@ -21,5 @@ > -printingtype,formatstring,layoutname,guidebox,active,fonttype,ccode,callnum_split) > -VALUES > -(5,'CODE39',2,0,3,0,0,0,0,4,1,0,0,1,'BIBBAR','??????-?????? ? ?????-???',1,1,NULL,NULL,NULL,NULL), > -(6,'CODE39',2,0,0,0,0,3,4,0,1,0,3,1,'BAR','??????????',1,1,NULL,NULL,NULL,NULL), > -(7,'CODE39',1,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,1,'PATCRD','???????? ????????????? ???????????',1,NULL,NULL,NULL,NULL,NULL); This last one looks strange, but why not keep the strange data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:46:35 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-kLvmrq3A6l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- > Why remove the fields list completely? It would have been good to keep > updated. > Table names have changed. Column names have changed. There is a different number of columns now. This is really old data > This last one looks strange, but why not keep the strange data? Because that data need to be fixed to be loaded. I'm in other things right now, that's the reason I don't fix them in the first place, only french data in which I simply added a couple of columns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:49:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:49:37 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-Jk35Hmzc3A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- > > -(5,'CODE39',2,0,3,0,0,0,0,4,1,0,0,1,'BIBBAR','??????-?????? ? ?????-???',1,1,NULL,NULL,NULL,NULL), > > -(6,'CODE39',2,0,0,0,0,3,4,0,1,0,3,1,'BAR','??????????',1,1,NULL,NULL,NULL,NULL), > > -(7,'CODE39',1,NULL,NULL,NULL,NULL,NULL,NULL,NULL,2,NULL,NULL,1,'PATCRD','???????? ????????????? ???????????',1,NULL,NULL,NULL,NULL,NULL); >From this I only removed the last one, patron card data, 1 & 2 in my patch are equivalent to 5 & 6 (1,'CODE39',1,'BIBBAR','??????-?????? ? ?????-???',0,1,'TR',7,'POINT',0,'L','title, author, itemcallnumber', '<opt></opt>', 'Labels'), (2,'CODE39',1,'BAR','??????????',0,1,'TR',3,'POINT',0,'L','','','Labels'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:51:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:51:18 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-N0xROfli8E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #11 from M. Tompsett <mtompset at hotmail.com> --- Wow... That error in comment #1 was hard to notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:54:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:54:36 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15063-70-5EVLi8YDH3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 --- Comment #2 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44127&action=edit Update MARC21 es-ES frameworks to Update 21 Patch test and all is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:54:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:54:57 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15063-70-swlVouEoFo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |z.tajoli at cineca.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:55:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:55:33 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15063-70-XXqXR7oPQw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 16:56:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 15:56:27 +0000 Subject: [Koha-bugs] [Bug 15063] Update MARC21 es-ES frameworks to Update 21 (September 2015) In-Reply-To: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15063-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15063-70-WtGGJpFRMq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15063 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44127|Update MARC21 es-ES |[SIGN-OFF] Update MARC21 description|frameworks to Update 21 |es-ES frameworks to Update | |21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:10:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:10:46 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50 In-Reply-To: <bug-12620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12620-70-0VkWFJ1w3G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Depending on the nature of the proxy involved, it may not be necessary to use YAZProxy. In particular, the YAZ toolkit supports a special connection syntax to direct Z39.50 and SRU traffic through a proxy. For example, suppose you have a Squid proxy running on localhost and listening on port 210, and further suppose that the proxy is configured to allow connecting to the target Z39.50 server(s). In that case, with yaz-client you can do something like this: yaz-client connect:localhost:3128,tcp:lx2.loc.gov:210/LCDB and that will get you a proxied Z39.50 connection to the Library of Congress. As another example, the following would open a proxied connection to the GBV (Gemeinsame Bibliotheksverbund) SRU server: yaz-client connect:localhost:3128,http://sru.gbv.de:80/gvk Translating that to Koha, a system preference or a new column in the z3950servers table could be added to specify a proxy to use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:10:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:10:48 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-m9KKSNMxGH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43773|0 |1 is obsolete| | --- Comment #8 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44128&action=edit Update MARC21 frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:11:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:11:24 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-PZ4qoe18At@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Attachment #44128|Update MARC21 frameworks |[SIGN-OFF] Update MARC21 description| |frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:12:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:12:53 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-TMy7X02mw5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Zeno Tajoli <z.tajoli at cineca.it> --- Test the patch and it is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:14:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:14:33 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-Plb5Fh0idc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43774|0 |1 is obsolete| | --- Comment #10 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44129&action=edit [SIGN-OFF] followup - Fix labels -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:15:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:15:38 +0000 Subject: [Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015) In-Reply-To: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14333-70-kxZCZqR2kB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43983|0 |1 is obsolete| | --- Comment #11 from Zeno Tajoli <z.tajoli at cineca.it> --- Created attachment 44130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44130&action=edit [SIGN-OFF] followup 2 - split line to ease translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:23:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:23:44 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-nV5b4P64ba@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44096|0 |1 is obsolete| | --- Comment #19 from Marc V?ron <veron at veron.ch> --- Created attachment 44131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44131&action=edit Bug 14903 - (followup)Remove C4::Dates from circ/circulation.pl Follow up to fix QA issues from comment #15 ...and amended for comment #18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:27:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:27:25 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-2GgGD19P5A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Marc V?ron <veron at veron.ch> --- Hi Jonathan, I amended the patch. However, I can not trigger the message. The datepicker does not allow to enter wrong dates (field is readonly). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:29:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:29:32 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15068-70-3jdEbYjNBH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Marc V?ron from comment #1) > - Use of uninitialized value in addition (+) > at /usr/share/kohaclone/members/summary-print.pl line 87 > > - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) > at /usr/share/kohaclone/members/summary-print.pl line 103 > ... > - Go to a detail page with a member who has a lot of fines ... And items checked out, potentially overdue. Triggering 47 and 61 is easy with the sample data after creating some fines on a user. Having difficulty triggering 87, which I feel will also trigger 103, if I have something checked out, but working on multiple bugs at once is hard. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:31:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:31:25 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-JOdW2DfELV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #12 from M. Tompsett <mtompset at hotmail.com> --- Any logic with printers_profile should be placed BEFORE the creators_layout and creators_templates logic in: installer/data/mysql/de-DE/optional/sample_creator_data.sql installer/data/mysql/en/optional/sample_creator_data.sql installer/data/mysql/es-ES/optional/sample_creator_data.sql installer/data/mysql/it-IT/necessari/sample_creator_data.sql installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql to completely avoid errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:31:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:31:28 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13146-70-7QutLRqQla@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32749|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44132&action=edit Bug 13146 UT Run the test before applying the second patch: prove -v t/db_dependent/FieldMapping.t Apply the 2nd patch, and redo the test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:32:11 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13146-70-WrVUOg1E1G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 --- Comment #6 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 44133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44133&action=edit Bug 13146 Improve GetRecordValue function by caching field mapping GetRecordValue function is called each time a specific field mapping is required. For example, bug 12692 display biblio record subtitle for each hold awaiting pickup or overdue. As it is implemented now, GetRecordValue queries directly the fieldmapping table to determine in which tag/letter a field has to be searched. It means, that the same mapping are requested over and over. This patch uses Koha cache system to store a complete data structure representing the field mapping. TO TEST: (1) Look at the code! and check that Koha caching system is properly used. (2) Find out a Koha function where subtitle field mapping is used. Make you choice: sending a basket, tag list, overdues with fines, renew item, etc. (3) Note that the display of subtitle field hasn't changed. (4) If you really want to see how less queries are sent to MySQL with this patch, you have to monitor your MySQL log files! Suggestion to do it on a Debian box: - In MySQL client: SHOW VARIABLES LIKE "general_log%"; It gives you MySQL log file path. Usually, /var/run/mysqld/mysqld.log - Enable log, with: SET GLOBAL general_log = 'ON'; - Display a page displaying the subtitle field - Compare request send with/withouth this patch. Without the patch, you will see plenty of query like that: SELECT fieldcode, subfieldcode FROM fieldmapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:32:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:32:47 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13146-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13146-70-T37r3K3CUg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 --- Comment #7 from Fr?d?ric Demians <frederic at tamil.fr> --- (In reply to Jonathan Druart from comment #3) > Fr?d?ric, It would be great to provide a couple of tests to confirm the > patch does not introduce any regressions. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:38:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:38:01 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report In-Reply-To: <bug-10744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10744-70-dj0rYdaqco@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 44134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44134&action=edit Bug 10744 - ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report Initial commit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 17:41:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 16:41:28 +0000 Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay has minor workflow conflicts with hold(s) over report In-Reply-To: <bug-10744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10744-70-7x91TA0HUp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti at jns.fi Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 20:29:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 19:29:35 +0000 Subject: [Koha-bugs] [Bug 8937] Translation process removes CDATA in HTML In-Reply-To: <bug-8937-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8937-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8937-70-U6k6sIaG4J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8937 Marjorie Barry-Vila <marjorie.barry-vila at ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 21:15:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 20:15:53 +0000 Subject: [Koha-bugs] [Bug 15075] New: Patron searches default parameters Message-ID: <bug-15075-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15075 Bug ID: 15075 Summary: Patron searches default parameters Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jesse at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When we are browsing our patron names by letter is it possible filter that by our home library? When we click on the filter it no longer browses by letter, and if you click on the letter it loses the library filter. Also, when I search for a patron who has more than one word in their last name in the circulation search box it comes up with no results. Example: White Bear. It works if you are in the patron screen but not from the main search box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 21:51:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 20:51:05 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10154-70-buHhroMOJg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 --- Comment #3 from Eivin Giske Skaaren <eivin at sysmystic.com> --- Created attachment 44135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44135&action=edit Bug 10154 Add Call number in the filter of most circulated items This patch adds call number, collection code and shelving location to the filter. To test: It is of course a prerequisite to have items in the DB with the correct MARC fields and that they have been checked out etc. to get a valid result when testing. 1. Apply patch to koha synced to master. 2. Go to /cgi-bin/koha/reports/cat_issues_top.pl 3. Select filters, the new ones are Call number, Collection code and Shelving location 4. Hit submit. Expected result: The filters chosen will be printed under "Filtered on". A table with the result is shown. For manual verification here is some SQL to run: SELECT DISTINCT biblio.title, COUNT(biblio.biblionumber) AS RANK, biblio.biblionumber AS ID, itemcallnumber as CALLNUM, ccode as CCODE, location as LOC FROM `old_issues` LEFT JOIN items USING(itemnumber) LEFT JOIN biblio USING(biblionumber) LEFT JOIN biblioitems USING(biblionumber) LEFT JOIN borrowers USING(borrowernumber) WHERE 1 AND biblioitems.itemtype like 'BK' AND itemcallnumber like '005.2/762' AND ccode like 'NFIC' AND location like 'CART' AND borrowers.categorycode like 'PT' group by biblio.biblionumber order by RANK DESC; Put in your valid values in the WHERE clause for the values in the single quotes ''. Sponsored-by: Halland county library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 21:52:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 20:52:20 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10154-70-oQ1FwcHYhx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren <eivin at sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 22:11:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 21:11:01 +0000 Subject: [Koha-bugs] [Bug 10154] Add Call number in the filter of most circulated items In-Reply-To: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10154-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10154-70-A81k2HtpAf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10154 Eivin Giske Skaaren <eivin at sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Oct 28 22:12:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 21:12:23 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15062-70-uRLqujy4rF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 00:01:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 23:01:37 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-ut7A333XcC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #11 from Marc V?ron <veron at veron.ch> --- Created attachment 44136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44136&action=edit Bug 14954 - (followup) Remove C4::Dates from holiday related files Followup for comment #10 To test: - Go to Home > Tools > Calendar - Add, edit, delete the different types of holidays and exceptions - git grep 'C4::Calendar' and test such files - git grep daysBetween to make sure that this sub is not used - prove t/Calendar.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 00:07:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 23:07:06 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-2UuuWbkuLb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 00:31:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 23:31:18 +0000 Subject: [Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl In-Reply-To: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15068-70-XIN0euYuHX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 --- Comment #4 from Marc V?ron <veron at veron.ch> --- (In reply to M. Tompsett from comment #3) > (In reply to Marc V?ron from comment #1) > > - Use of uninitialized value in addition (+) > > at /usr/share/kohaclone/members/summary-print.pl line 87 > > > > - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) > > at /usr/share/kohaclone/members/summary-print.pl line 103 > > > ... > > - Go to a detail page with a member who has a lot of fines > ... > And items checked out, potentially overdue. > > Triggering 47 and 61 is easy with the sample data after creating some fines > on a user. Having difficulty triggering 87, which I feel will also trigger > 103, if I have something checked out, but working on multiple bugs at once > is hard. :) - 87 is due to items with no replacementprice (NULL in db) - 103 triggers with multiple checkouts with due dates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 00:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 28 Oct 2015 23:37:50 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14998-70-efaCqwbQQN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Marc V?ron from comment #3) > - Verify that the file is no longer used While it isn't used as far as I can tell. Does a date get placed in description still? If so, this script may still be handy to keep. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:13:49 +0000 Subject: [Koha-bugs] [Bug 10804] SQL in categorie.pl should be moved into its own module and tested In-Reply-To: <bug-10804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10804-70-pMeXT3PVSk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10804 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 14836 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:13:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:13:49 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-lX76moJBH5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 10804 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:26:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:26:02 +0000 Subject: [Koha-bugs] [Bug 900] Unimarc Authorities In-Reply-To: <bug-900-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-900-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-900-70-QW3wa7QNg1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=900 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As bug 917 is marked closed fix I hope this is fixed as well. Please reopen with more information if it is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:28:43 +0000 Subject: [Koha-bugs] [Bug 1700] Child patron can't have two parents In-Reply-To: <bug-1700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1700-70-h2Uj6DWL0O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1700 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 14570 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:28:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:28:43 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-VY6zkViwGM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 1700 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:45:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:45:14 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14998-70-V2qBPin2nH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 --- Comment #5 from Marc V?ron <veron at veron.ch> --- (In reply to M. Tompsett from comment #4) > (In reply to Marc V?ron from comment #3) > > - Verify that the file is no longer used > > While it isn't used as far as I can tell. Does a date get placed in > description still? If so, this script may still be handy to keep. In the first patch I removed C4::Dates from misc/maintenance/fix_accountlines_date.pl So it does no harm to keep the file. I obsolete the second patch and open a new bug for removing. That can be discussed later. The main thing now bring the C4::Dates removal to an end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:45:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:45:41 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14998-70-Ww72tZelqx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:54:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:54:34 +0000 Subject: [Koha-bugs] [Bug 15076] New: Remove file misc/maintenance/fix_accountlines_date.pl Message-ID: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Bug ID: 15076 Summary: Remove file misc/maintenance/fix_accountlines_date.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org The file misc/maintenance/fix_accountlines_date.pl seems to be a file used for an update, could it be obsolete? If yes, it can be removed. See discussion on Bug 14998 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998#c5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:55:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:55:28 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15076-70-OsWd8iIchW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14998 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 [Bug 14998] Remove C4::Dates from installer and maintenance folders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 08:55:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 07:55:28 +0000 Subject: [Koha-bugs] [Bug 14998] Remove C4::Dates from installer and maintenance folders In-Reply-To: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14998-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14998-70-WnWqcsAe3s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14998 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15076 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 09:18:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 08:18:39 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15076-70-JgZeecKxVk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure about removing it - it might still be useful for people updating from really old versions or something like that. Can we find out more about the context of when this was added? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 09:24:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 08:24:08 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-PcopKvDzM2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marc, are you sure all the subroutines you have changed with these patches are triggered by your test plan? I would like to see a more complete test plan and a second signoff here please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 09:35:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 08:35:09 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-hwoYQhcRO3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 09:35:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 08:35:12 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-YLFf6FLTwz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44072|0 |1 is obsolete| | Attachment #44131|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44137&action=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more) Patch to remove deprectated C4::Dates from: - circ/circulation.pl - C4/Circulation.pm - koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Search for regressions - prove -v t/db_dependent/Circulation.t (Amended following comment #9 / #11 25.10.2015 /mv) Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 09:35:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 08:35:18 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-VPSdffvBSO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44138&action=edit Bug 14903 - (followup)Remove C4::Dates from circ/circulation.pl Follow up to fix QA issues from comment #15 ...and amended for comment #18 Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 09:47:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 08:47:51 +0000 Subject: [Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl In-Reply-To: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15076-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15076-70-txXD3eoHZE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 10:09:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 09:09:09 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-CnspZb7z9a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44060|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44139&action=edit Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Operations in admin/category is unchanged, and functionnal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 10:09:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 09:09:12 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-6ZgcsmJBeu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44061|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44140&action=edit Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians at tamil.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 10:09:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 09:09:15 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-opcnGKxHd5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44141&action=edit Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 10:09:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 09:09:18 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-u82qh6HPFv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44142&action=edit Bug 14836: Add tests for Koha::Patron::Categor[y|ies] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 10:14:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 09:14:09 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-dP3GSBzvdA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 --- Comment #13 from Marc V?ron <veron at veron.ch> --- More complete test plan as requested by comment #12 - Prove t/Calendar.t - Go to Home > Tools > Calendar - Verify that adding holidays works as before: - Holiday only on one day. - Holiday repeated every same day of the week. - Holiday repeated yearly on the same date. - Holidays on a range. - Holidays repeated yearly on a range. - Verify that editing (including deleting) holidays and exceptions work as before: - For repeated holidays: - Generate an exception for this repeated holiday. - Generate exceptions on a range for this repeated holiday. - Generate exceptions on a range of dates. - Delete this holiday. - Delete the single holidays on a range. - Delete the repeated holidays on a range. - Delete the exceptions on a range. - For a single holiday: - Generate exceptions on a range of dates. - Delete this holiday. - Delete the single holidays on a range. - Delete the repeated holidays on a range. - Delete the exceptions on a range. - Edit this holiday Hint: There is a [?] after each function with explanation how it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 10:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 09:14:54 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-kG4JtN8Kzh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Now there is a "Currency = EUR" on top of the acqui home page. I am not sure it is useful to display it there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 11:19:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 10:19:38 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12540-70-X7ktMoVGc4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #3 from Alex Arnaud <alex.arnaud at biblibre.com> --- I'm ok with the patch. Now i have "every" if i had "every" before saving. But what is the point of changing this choice ? Especially as we change only the label, not the value of the option. So it would not change anything in the modification process ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:07:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:07:40 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-gIiuBCOIxE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44143&action=edit Bug 14695 - Tidy CanItemBeReserved and CanBookBeReserved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:07:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:07:38 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-OVUdkCGzVU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:07:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:07:48 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-0q3FmGvGwu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44144&action=edit Bug 14695 - Add new issuing rule This patch fines a new issuing rule 'holds_per_record' which defines the number of holds a given patron can place on a given record. The default is 1 to retain Koha's current behavior as the default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:07:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:07:51 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-HNmY4C2zDh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44145&action=edit Bug 14695 - - Add ability to place multiple item holds on a given record per patron Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Edit your circulation rules to allow 3 holds per record 4) In the staff client, test the ability to place multiple holds per patron per record. You should be able to place any combination of 3 holds per patron per record, with the exception that you cannot place multiple item level holds for the same item for the same patron. 5) Repeat step 4 for the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:34:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:34:19 +0000 Subject: [Koha-bugs] [Bug 15077] New: Fix Fast Add framework to pass test Message-ID: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 Bug ID: 15077 Summary: Fix Fast Add framework to pass test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Simplified creation introduced in Bug 10963 makes FA framework fail MARC bibliographic framework test. Sorry for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:38:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:38:31 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-kfAMYIbofi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_22_candidate CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:47:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:47:46 +0000 Subject: [Koha-bugs] [Bug 15078] New: Item items.hidden field cannot be filled in item creation Message-ID: <bug-15078-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15078 Bug ID: 15078 Summary: Item items.hidden field cannot be filled in item creation Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: laurence.lefaucheur at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl New field items.hidden can't be filled during item creation. Possible only in item modification. (seen on unimarc, not tested in marc21) It seems that hidden field is not defined in C4:Items sub _koha_new_item, maybe also in other places. To test : Add an item marc subfield mapped whith hidden Add an new item whith 0 or 1 in the subfield items.hidden and the subfield are empty after validation Modify the item and add value for hidden items.hidden is then filled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:47:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:47:48 +0000 Subject: [Koha-bugs] [Bug 15079] New: Batch Delete Records Error Message-ID: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Bug ID: 15079 Summary: Batch Delete Records Error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using the batch deletion tool, if the script attempts to delete an undeletable item, the script will die with the error: Label not found for "next BIBLIONUMBER" at /usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:47:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:47:52 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15079-70-XBFQLLlaub@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:50:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:50:31 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15079-70-5SQM7Qpilc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44146&action=edit Bug 15079 - Batch Delete Records Error When using the batch deletion tool, if the script attempts to delete an undeletable item, the script will die with the error: Label not found for "next BIBLIONUMBER" at /usr/share/koha/intranet/cgi-bin/tools/batch_delete_records.pl line 172. Test Plan: 1) Attempt to batch delete a record with an item that cannot be deleted 2) Note error 3) Apply this patch 4) Repeat step 1 5) Note the error no longer occurs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:50:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:50:29 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15079-70-3szN5hdJlb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:51:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:51:15 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-m3TEf8XD1Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44147&action=edit Bug 15077: Fix Fast Add framework to pass test This patch fixes tab location for FA frameworks. Not all subfields belongs to tab 0. To test: 1) On current master, with default and fasadd fw loaded, go to Home > Administration > MARC bibliographic framework test it fails 2) Apply the patch 3) Delete all fw, reload all, or just default (bib & auth) and fast add 4) Repeat 1, now test must pass This is only on master, so no need to database update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 12:52:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 11:52:56 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-n2qyLHtWP3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 13:29:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 12:29:58 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-aQhovdiDWr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44148&action=edit Bug 15049: Hide currency but preserv alert This follow up hides currency, but the alert pops if no currency is active. To test: 1) Apply the patch 2) Unset any active currency 3) Alert must show on Acquisitons home 4) Set a currency active, no currency display on Acqui home 5) Check that currency IS displayed on /cgi-bin/koha/admin/aqbudgets.pl or /cgi-bin/koha/admin/aqbudgetperiods.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 13:32:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 12:32:39 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-jd2xh5yXjE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- I propose a followup to hide the currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:17:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:17:40 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-Qx3TJwE63C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:17:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:17:42 +0000 Subject: [Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses In-Reply-To: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14504-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14504-70-cDQfXe8pC1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #22 from Barton Chittenden <barton at bywatersolutions.com> --- Created attachment 44149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44149&action=edit bug 14504: QA Followup -- fixing DelItemCheck arguments Remove $dbh as argument to C4::Items::DelItemCheck and C4::Items::ItemSafeToDelete, also change all calls to these functions throughout the codebase. Also remove remaining reference to 'do_not_commit' in t/db_dependent/Items_DelItemCheck.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:40:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:40:40 +0000 Subject: [Koha-bugs] [Bug 15080] New: ./translate-tool should tell if xgettext-executable is missing Message-ID: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Bug ID: 15080 Summary: ./translate-tool should tell if xgettext-executable is missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org Just upgraded our Koha container to 14.04 and noticing the misc/translator/translate doesn't work. This is because of a missing package gettext. This patch makes ./translate die with a helpful suggestion to install gettext if xgettext-program is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:41:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:41:34 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15080-70-ZAtKQJJeBX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> --- Created attachment 44150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44150&action=edit Bug 15080 - ./translate-tool should tell if xgettext-executable is missing Just upgraded our Koha container to 14.04 and noticing the misc/translator/translate doesn't work. This is because of a missing package gettext. This patch makes ./translate die with a helpful suggestion to install gettext if xgettext-program is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:41:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:41:44 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15080-70-jmcttqgYca@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:41:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:41:51 +0000 Subject: [Koha-bugs] [Bug 15080] ./translate-tool should tell if xgettext-executable is missing In-Reply-To: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15080-70-9A0LvT1czS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15080 Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |olli-antti.kivilahti at jns.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:43:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:43:35 +0000 Subject: [Koha-bugs] [Bug 15081] New: TestBuilder should not handle the transaction Message-ID: <bug-15081-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 Bug ID: 15081 Summary: TestBuilder should not handle the transaction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com Right now, TestBuilder has the side effect of introducing a race condition on the DBIC transaction. The consecquences are uncomfortable, because warnings are raised on all tests that use it. A patch removing it should make sure the tests have their own rollback handling using the Koha::Databases-provided schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:53:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:53:49 +0000 Subject: [Koha-bugs] [Bug 14100] Generic solution for language overlay In-Reply-To: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14100-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14100-70-bQRTdwvK4T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #65 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44151&action=edit Bug 14100: (QA followup) add missing mocked sysprefs Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 14:59:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 13:59:48 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-6C5mUJtYu3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44148|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44152&action=edit Bug 15049: Hide currency but preserv alert This follow up hides currency, but the alert pops if no currency is active. To test: 1) Apply the patch 2) Unset any active currency 3) Alert must show on Acquisitons home 4) Set a currency active, no currency display on Acqui home 5) Check that currency IS displayed on /cgi-bin/koha/admin/aqbudgets.pl or /cgi-bin/koha/admin/aqbudgetperiods.pl Amended for better translation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:07:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:07:43 +0000 Subject: [Koha-bugs] [Bug 14960] Remove C4::Dates from files in misc/cronjobs In-Reply-To: <bug-14960-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14960-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14960-70-SPwCjMc8x7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14960 --- Comment #4 from Marc V?ron <veron at veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:08:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:08:29 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: <bug-14969-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14969-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14969-70-HKL24KZyyh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #3 from Marc V?ron <veron at veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:09:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:09:36 +0000 Subject: [Koha-bugs] [Bug 14956] Remove C4::Dates from files opac/*.pl In-Reply-To: <bug-14956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14956-70-quO2vm70nj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #12 from Marc V?ron <veron at veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:10:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:10:13 +0000 Subject: [Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl In-Reply-To: <bug-14946-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14946-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14946-70-vccMMfCvAg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946 --- Comment #5 from Marc V?ron <veron at veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:10:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:10:58 +0000 Subject: [Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm In-Reply-To: <bug-14985-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14985-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14985-70-ElMQzR4tIY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985 --- Comment #3 from Marc V?ron <veron at veron.ch> --- Still applies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:20:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:20:34 +0000 Subject: [Koha-bugs] [Bug 15082] New: t/db_dependent/Search.t shouldn't mock the DB connection Message-ID: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Bug ID: 15082 Summary: t/db_dependent/Search.t shouldn't mock the DB connection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: tomascohen at gmail.com QA Contact: gmcharlt at gmail.com DB-dependent tests don't need to mock the DB. Actually, this one is not using the mock at all, so we might be hiding side effects. It seems that as the configuration file is created on each test run, we just need to grab the DB configuration from C4::Context and use it in rewrite-config.PL to go un-mocked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:26:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:26:43 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-jFStYrtuQg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44153&action=edit Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection This patch makes the t/db_dependent/Search.t tests use a real DB instead of mocking the DB handler (which is not actually used and generates unnecesary warnings when running the tests). It does so by grabbing the DB configuration data using C4::Context->config() and passing it (writing %ENV) to rewrite-config.PL, all is done in zebra_config.pl which is only used on the Search.t file. To test: - Run $ prove t/db_dependent/Search.t => FAIL: Warnings are raised about DB being mocked and DBIC not recognising 'Mock' as a valid DB driver. - Apply the patch - Run $ prove r/db_dependent/Search.t => SUCCESS: Same tests results, no warning about DBIC driver. - Sign off :-D Disclamer: As of writing this patch, the Search.t tests pass. The patch is not dealing with tests results, but how they use the DB. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:26:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:26:40 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-rV2qlTVrjY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:30:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:30:22 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12540-70-DFBKXwE7II@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It's just a wording improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:32:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:32:37 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-ZD4pxgdDna@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Sorry, but my test was bad, only tried with superlibrarian. Marc, are you sure that needed permission check is CAN_user_parameters_parameters_remaining_permissions Can't found another instance of that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:42:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:42:01 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-ZhrDq8S5U3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 --- Comment #8 from Marc V?ron <veron at veron.ch> --- (In reply to Josef Moravec from comment #7) > I have test instance with only few checkouts in last 2 months. Some > checkouts were made in september and some in october. But it doesn't matter > which dates I use in checkout/checkin date filter, I still get exactly same > data. Josef, thanks a lot for testing, I found the issue. Amended patch follows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:43:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:43:12 +0000 Subject: [Koha-bugs] [Bug 15083] New: acqui/currency.pl is unused Message-ID: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Bug ID: 15083 Summary: acqui/currency.pl is unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org This script is never called from the Koha code and should be removed (especially regarding the FIXME...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:45:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:45:03 +0000 Subject: [Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports In-Reply-To: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14965-70-zg9g62Kl6N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43955|0 |1 is obsolete| | --- Comment #9 from Marc V?ron <veron at veron.ch> --- Created attachment 44154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44154&action=edit Remove C4::Dates from 'lists' in folder reports Remove C4::Dates from: - reports/bor_issues_top.pl - reports/borrowers_out.pl - reports/cat_issues_top.pl - reports/itemslost.pl To test: - Go to Home > Reports - Verify that following reports behave as before: - 'Patrons with the most checkouts (reports/bor_issues_top.pl) - 'Most circulated items' (reports/cat_issues_top.pl) - 'Patrons who haven't checked out (reports/borrowers_out.pl) - 'Items lost' Amended to fix issue with reports/borrowers_out.pl / see comment #3 Amended to fix issue with reports/bor_issues_top.pl / see comment #7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:46:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:46:05 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15083-70-tTrkOWji24@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44155&action=edit Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:46:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:46:02 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15083-70-OxH5jlToDO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:49:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:49:45 +0000 Subject: [Koha-bugs] [Bug 15084] New: Move the currency related code to Koha::Cities Message-ID: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Bug ID: 15084 Summary: Move the currency related code to Koha::Cities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:49:51 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15083-70-B4fPpFsSGy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15084 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Cities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:49:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:49:51 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Cities In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-Jyti2Hv98k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15083 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 [Bug 15083] acqui/currency.pl is unused -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:50:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:50:17 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15073-70-RQPYHVhUxR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44124|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44156&action=edit [SIGNED-OFF] Bug 15073: Move FeeOnChangePatronCategory This patch moves the FeeOnChangePatronCategory system preference so that it's in a more logical place. Also a few typos were fixed. To test: * Go to System Preferences * Go to Patrons * Find FeeOnChangePatronCategory and confirm Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Confirmed. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:50:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:50:55 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15073-70-BEHz28OwD6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 15:59:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 14:59:49 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-bZyWvDAdgi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move the currency related |Move the currency related |code to Koha::Cities |code to | |Koha::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:00:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:00:33 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-NVP9V6zo45@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move the currency related |Move the currency related |code to |code to |Koha::Currenc[y|ies] |Koha::Acquisition::Currenc[ | |y|ies] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:04:57 +0000 Subject: [Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl In-Reply-To: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14903-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14903-70-bgh0sVOImo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:05:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:05:20 +0000 Subject: [Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t In-Reply-To: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14977-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14977-70-eBbNzBG46i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:05:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:05:42 +0000 Subject: [Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl In-Reply-To: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14931-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14931-70-1DUDpqtnSx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:25:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:25:59 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15083-70-gSrmEUverR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:26:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:26:10 +0000 Subject: [Koha-bugs] [Bug 15078] Item items.hidden field cannot be filled in item creation In-Reply-To: <bug-15078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15078-70-wIVFSm7Y8s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15078 Laurence Lefaucheur <laurence.lefaucheur at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Laurence Lefaucheur <laurence.lefaucheur at biblibre.com> --- wrong alert ; some people here added manually the hidden field to items table... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:26:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:26:03 +0000 Subject: [Koha-bugs] [Bug 15083] acqui/currency.pl is unused In-Reply-To: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15083-70-hAJq0doNCB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44155|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44158&action=edit [SIGNED-OFF] Bug 15083: Remove acqui/currency.pl This script has scary FIXMEs and can be removed. It is never called from Koha code. On the way, this patch remove the C4::Budgets::ModCurrencies subroutine, which was only called from this script. Test plan: git grep 'acqui/currency.pl and git grep ModCurrencies should not return anything. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> No more ModeCurrencies, no call to acqui/currency.pl No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:26:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:26:14 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-YzVl809zwK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44006|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44159&action=edit [SIGNED OFF] Bug 15053: sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> All fixed files loads without problem. No errors found Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:27:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:27:15 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-IHB4UycK3U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44125|0 |1 is obsolete| | --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44160&action=edit [SIGNED OFF] Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Fixes other sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql or ru-RU/optional/print_labels.sql or uk-UA/optional/print_labels.sql Without the patch this files can't be loaded Test all of them In case of ru and uk I removed a patron card layout Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:27:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:27:11 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-Q4Ek21jATW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:34:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:34:42 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-fGcJ3dcQ5d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:34:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:34:46 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-ZUGPPTGOVT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44153|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44161&action=edit [SIGNED-OFF] Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection This patch makes the t/db_dependent/Search.t tests use a real DB instead of mocking the DB handler (which is not actually used and generates unnecesary warnings when running the tests). It does so by grabbing the DB configuration data using C4::Context->config() and passing it (writing %ENV) to rewrite-config.PL, all is done in zebra_config.pl which is only used on the Search.t file. To test: - Run $ prove t/db_dependent/Search.t => FAIL: Warnings are raised about DB being mocked and DBIC not recognising 'Mock' as a valid DB driver. - Apply the patch - Run $ prove r/db_dependent/Search.t => SUCCESS: Same tests results, no warning about DBIC driver. - Sign off :-D Disclamer: As of writing this patch, the Search.t tests pass. The patch is not dealing with tests results, but how they use the DB. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test pass before & after, a 'little' less noisy No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:24 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-WDPDycyBaN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:26 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-lSrkt9OvYp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44162&action=edit Bug 15084: Add Koha::Acquisition::Currenc[y|ies] classes The first step of this patch set is to move the business logic code from admin/currencies.pl to Koha::Acquisition::Currenc[y|ies]. Then a foreign key will be created on aqorders.currency as we want to assure data integrity. Note that a aqbooksellers.currency also exists but is never used. It could be removed in another bug report. This update has to care about possible breaking relation. For instance an old order has been made using a currency which is now deleted. To be sure the update process won't break a new column currency.archived is created and leave open the door for a further improvement (marked a currency as archived from the interface: this won't be provided by this enhancement). These archived currencies won't appear on the interface for newly created items (order/suggestion). Once this is done it becomes easy to remove the subroutine from C4::Budgets: GetCurrencies and GetCurrency. ConvertCurrency will also be removed but is not used anymore. Note that none of these subroutines were covered by tests. Now they are. Test plan: 0/ Don't apply this patch 1/ Create a temporary currency and an order using it 2/ Remove the currency from your CLI 3/ Apply the patch and execute the DB entry 4/ Note that the currency is inserted and marked as archived. 5/ Edit the previous order and confirm that the correct currency is still selected. It won't never be displayed anywhere else. 6/ Test the admin script: on admin/currency.pl add/remove/edit currencies. You could not have 2 active currencies at the same time. 7/ Then on the different scripts of the acquisition module, focus on the currencies values and create a new order, receive it. Create/edit a suggestion Other changes must be checked by the QAer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:29 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-kA8SP8li7G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44163&action=edit Bug 15084: Make sure the previous active currency is marked as inactive On inserting an active currency, others should be marked as inactive. We can only have 1 active currency at the same time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:33 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-6XPrwiTJiI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44164&action=edit Bug 15084: use Koha::Acquisition::Currenc[y|ies] in admin/currency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:35 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-3H18kpSR6i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44165&action=edit Bug 15084: DB Changes - add currency.archived and FK on aqorders.currency See the comment for details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:38 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-00yYg9UoBE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44166&action=edit Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search Most part of the code here is unnecessary complex. We should selected the currency if it is selected, that's all :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:42 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-fzblUKyWJu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44167&action=edit Bug 15084: Remove C4::Budgets::ConvertCurrency This subroutine is unused and can be removed. There is no trace left of currency in C4::Budgets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:47:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:47:45 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-x7LxeGRQSt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44168&action=edit Bug 15084: Add tests for Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:50:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:50:47 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15049-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15049-70-uRxyhHKv6I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 --- Comment #15 from Marc V?ron <veron at veron.ch> --- (In reply to Bernardo Gonzalez Kriegel from comment #14) > Sorry, but my test was bad, only tried with superlibrarian. > > Marc, are you sure that needed permission check is > > CAN_user_parameters_parameters_remaining_permissions > > Can't found another instance of that. Bernardo, I wanted the link not to display if the user is not able to edit the currencies table. Who should be able to display and edit the currencies table: When I go through the permissions, I think the following should be able to display and edit the table: - superlibrarian (yes) - paramters (yes) - manage_circ_rules (no, but see remark below) - parameters_remaining_permissions (yes) Strange enough, with manage_circ_rules I can not only edit the circulation rules (what I would expect), but it seems that it allows to edit ALL of the parameters. I think this is a bug, what is yout opinion about? My implementation tests for parameters_remaining_permissions (i.e. CAN_user_parameters_parameters_remaining_permissions internally as I figured out). This triggers the 'mother'-permission for parameters as well. I tested with two browsers, one as superlibrarian for setting the permission and one on an other computer with the non-superlibrarian. It worked well for me. But anyway, it is not really a very important enhancement. I'd rather like to see the C4:Dates sign-offs for Bug 14870 'Delete C4/Dates.pm from System' and Bug 12072 'New dateformat dd.mm.yyyy' move forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:09 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-D1mBYsxgmj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14836, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14828, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:09 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-ILkfFVlShW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:09 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-5ytIbAxLs9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:09 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: <bug-14828-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14828-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14828-70-IBkUXBo1Qt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:09 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-kGLQPCD3Az@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:09 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: <bug-14888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14888-70-d6gzuxpYfQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:27 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-Jl6y9llmjP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14836, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14828, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10363, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14888, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14889 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:27 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-tuYWNywHOb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:27 +0000 Subject: [Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes In-Reply-To: <bug-14828-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14828-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14828-70-azXuu7ZsXu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:27 +0000 Subject: [Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities In-Reply-To: <bug-14888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14888-70-hNM8YoyzbE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:27 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-dgFMniBs1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:27 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-6p58w9oEU0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:38 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-Ktzl4shXEE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 16:51:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 15:51:38 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15084-70-2mInzWWfoP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14544 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:02:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:02:04 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-YJGQwqJUH9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What is this labels_templates table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:05:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:05:22 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-m32qJHZd7g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:05:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:05:25 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-TV8FVVexGt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44161|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44169&action=edit Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection This patch makes the t/db_dependent/Search.t tests use a real DB instead of mocking the DB handler (which is not actually used and generates unnecesary warnings when running the tests). It does so by grabbing the DB configuration data using C4::Context->config() and passing it (writing %ENV) to rewrite-config.PL, all is done in zebra_config.pl which is only used on the Search.t file. To test: - Run $ prove t/db_dependent/Search.t => FAIL: Warnings are raised about DB being mocked and DBIC not recognising 'Mock' as a valid DB driver. - Apply the patch - Run $ prove r/db_dependent/Search.t => SUCCESS: Same tests results, no warning about DBIC driver. - Sign off :-D Disclamer: As of writing this patch, the Search.t tests pass. The patch is not dealing with tests results, but how they use the DB. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Test pass before & after, a 'little' less noisy No errors Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:05:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:05:39 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-MVMf1LNykM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:08:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:08:06 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-8rQ5MntBRr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #15) > What is this labels_templates table? Old data for an old table I suppose, forget to change the comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:57:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:57:25 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-44FZIzu8yZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44097|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44170&action=edit [SIGNED-OFF] Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:57:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:57:33 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-jHQ9e825Ib@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44098|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44171&action=edit [SIGNED-OFF] Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:57:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:57:40 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-TguQjxlOgM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44099|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44172&action=edit [SIGNED-OFF] Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> All patches without errors. More consistent view. A few spaces and a little fix in followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:58:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:58:42 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-SwYNwboJ5B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44173&action=edit Bug 15072: (followup) fix spaces and consistency This patch add a few spaces when required and adds layout_id on title and breadcrumbs (for patroncards) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 17:59:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 16:59:29 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-IVQN2BuR2P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:14:54 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:14:54 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14716-70-zx9lZiYkWR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:14:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:14:57 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14716-70-doyxldmA46@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43412|0 |1 is obsolete| | Attachment #43413|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44174&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. This is happening because the query is malformed. Take for example the query se,phr:"Frank%20Einstein%20;" which is se,phr:"Frank Einstein" but the semicolon is truncating the query so it looks to Koha se,phr:"Frank Einstein which is not a problem on the staff side. Zebra seems to deal with this ok. On the opac side though, we are adding on supression, so the query ends up like this: (se,phr:"Frank Einstein ) not Suppress=1 which zebra chokes on. Removing the semicolon from the subject heading would fix this, but I imagine that's a band-aid as the semi is part of the standard. The semi is being treated as an ampersand. This is deep in the machinery ( http://www.w3.org/TR/1999/REC-html401-19991224/appendix/notes.html#h-B.2.2 ) Basically, the semi needs to be url encoded as %3B Test Plan: 1) Import the records in the attached MARC21 file, re-index 2) From the OPAC search for "Frank Einstein and the antimatter motor" 3) Click the series link, note you get no results 4) Apply this patch 5) Refresh the record details page 6) Click the series link 7) Results! NOTE: This bug does not occurr with all Koha server configurations. I have yet to determine the specific variable that creates this truncation behavior. Signed-off-by: Mason James <mtj at kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:15:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:15:07 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14716-70-ZQe0nMFFFQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44175&action=edit Bug 14716 - opac-detail.pl -- Series link fails when series - [FOLLOWUP] correct 2 other problematic series links Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:20:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:20:57 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-AJ0b0vcdrX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44147|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Created attachment 44176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44176&action=edit [SIGNED-OFF] Bug 15077: Fix Fast Add framework to pass test This patch fixes tab location for FA frameworks. Not all subfields belongs to tab 0. To test: 1) On current master, with default and fasadd fw loaded, go to Home > Administration > MARC bibliographic framework test it fails 2) Apply the patch 3) Delete all fw, reload all, or just default (bib & auth) and fast add 4) Repeat 1, now test must pass This is only on master, so no need to database update. Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised. MARC bibliographic framework test passed Ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:21:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:21:18 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-t8DtUZ8jwT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:25:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:25:06 +0000 Subject: [Koha-bugs] [Bug 15082] t/db_dependent/Search.t shouldn't mock the DB connection In-Reply-To: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15082-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15082-70-lRGsO3PHCP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15082 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:25:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:25:35 +0000 Subject: [Koha-bugs] [Bug 11881] Small improvements in OPAC results list. In-Reply-To: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11881-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11881-70-msFXRY7R0g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen at gmail.com --- Comment #48 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Simith and Genevieve! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 18:46:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 17:46:09 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-jvkQ5B9BdS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #17 from M. Tompsett <mtompset at hotmail.com> --- Please don't forget about comment #12. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 19:23:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 18:23:41 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-idCaLIkdQ7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 19:23:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 18:23:47 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-Hx5bvZLMnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41883|0 |1 is obsolete| | --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44177&action=edit [SIGNED-OFF] Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax This patch does the following: [1] Adjust authorities_merge_ajax just as in bug 14588. [2] Replace some indirect syntax for fetch GGI::Cookie. [3] Along the way replace some new CGI's. Note that I am not aiming to replace them Koha wide. The "fetch class" variant is less readable. NOTE: The changes to tools/upload-file.pl and upload-file-progress.pl are moved to report 14321. Test plan: [1] Run the URL authorities/merge_ajax.pl in staff. [2] Upload a file with Stage MARC records for import. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> [1] It runs, but also before patch [2] File uploads without problem No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 19:24:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 18:24:07 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-VPYz7yjX4D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to M. Tompsett from comment #17) > Please don't forget about comment #12. :) Do this patches introduce the problem you mention? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 19:24:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 18:24:30 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-Xz9Bfh2yV1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 20:31:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 19:31:12 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-qAces0JA2H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #19 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Tom?s Cohen Arazi from comment #18) > (In reply to M. Tompsett from comment #17) > > Please don't forget about comment #12. :) > > Do this patches introduce the problem you mention? These patches do correct the error in comment #1. They do not introduce new errors, as far as I can tell. But a: truncate blah 1 truncate blah 2 truncate blah 3 source blah 4 where blah 1..3 = the creator_ tables and printers_profile and where blah 4 is in a nice loop for each of the 8 files. (I ignored pl-PL) -- I believe this does have an error. I'll retest later to be sure. But like comment #12 says, printers_profile stuff before the other stuff dealt with it. I suspect it is because cascading creates a printers_profile entry, but I didn't look closely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 20:41:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 19:41:58 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-aaQm0cBGQm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to M. Tompsett from comment #19) > (In reply to Tom?s Cohen Arazi from comment #18) > > (In reply to M. Tompsett from comment #17) > > > Please don't forget about comment #12. :) > > > > Do this patches introduce the problem you mention? > > These patches do correct the error in comment #1. > They do not introduce new errors, as far as I can tell. > But a: > truncate blah 1 > truncate blah 2 > truncate blah 3 > source blah 4 > where blah 1..3 = the creator_ tables and printers_profile > and where blah 4 is in a nice loop for each of the 8 files. > (I ignored pl-PL) > -- I believe this does have an error. I'll retest later to be sure. > But like comment #12 says, printers_profile stuff before the other stuff > dealt with it. I suspect it is because cascading creates a printers_profile > entry, but I didn't look closely. Yes, please. Re-test and fill a bug if your suspicion is correct. 3.22 needs to be rock solid. As all Koha releases ;-) Thanks for taking the time to do this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:00:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:00:29 +0000 Subject: [Koha-bugs] [Bug 15085] New: Require confirmation before check in Message-ID: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 Bug ID: 15085 Summary: Require confirmation before check in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hectorejch at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com A nice feature to include would be: ask for confirmation before the system to record the check in. This confirmation should be requested only on the screen: circulation->returns. Of course it should be enabled / disabled in the system preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:10:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:10:36 +0000 Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in In-Reply-To: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15085-70-M6ilpWEQhs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hector, sorry, but I don't understand your use case :) Can you explain? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:13:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:13:11 +0000 Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in In-Reply-To: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15085-70-s1A8FpK5Fs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 H?ctor <hectorejch at yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hectorejch at yahoo.com.ar |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:13:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:13:27 +0000 Subject: [Koha-bugs] [Bug 10363] Move authorised value related code into its own package In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-ZfCUQPD6Jw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|There is no package for |Move authorised value |authorised values. |related code into its own | |package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:13:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:13:59 +0000 Subject: [Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC In-Reply-To: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12528-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12528-70-yfgc1aVmk9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Bouzid <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com Assignee|simith.doliveira at inlibro.co |bouzid.fergani at inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:28:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:28:28 +0000 Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in In-Reply-To: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15085-70-dayad0IZUf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 --- Comment #2 from H?ctor <hectorejch at yahoo.com.ar> --- Hi Katrin. First, sorry for my bad English, I speak Spanish. Referring to the use case: in the library where I work, the barcodes of books are sometimes worn, therefore code readers misread. The steps are as follows: 1) income the barcode of the book to be returned (check in) 2) before the Koha system to record the return in the database, ask for a confirmation that this really is the book you want to return 3) If it is accepted, the return actually recorded (check in ok) 4) If you do not accept the return registration is canceled (check in cancell) Add an image attached to help clarify the idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:29:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:29:43 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11858-70-GDZoIj7yvn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 H?ctor <hectorejch at yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hectorejch at yahoo.com.ar --- Comment #6 from H?ctor <hectorejch at yahoo.com.ar> --- Created attachment 44178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44178&action=edit Screenshot of new featured -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:32:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:32:11 +0000 Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in In-Reply-To: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15085-70-lHhsTlk1ty@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 --- Comment #3 from H?ctor <hectorejch at yahoo.com.ar> --- Created attachment 44179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44179&action=edit Screenshot of new featured -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:33:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:33:27 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11858-70-EdHHWNdDt2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 --- Comment #7 from H?ctor <hectorejch at yahoo.com.ar> --- Sorry for the last comment/attachment. It was a mistake. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 21:46:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 20:46:33 +0000 Subject: [Koha-bugs] [Bug 12620] Proxy Add-on for Koha z39.50 In-Reply-To: <bug-12620-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12620-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12620-70-MRv1hfMOWG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 22:04:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 21:04:14 +0000 Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in In-Reply-To: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15085-70-76QAmqX2ZH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #4 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- (In reply to H?ctor from comment #2) > Hi Katrin. > > First, sorry for my bad English, I speak Spanish. > > Referring to the use case: > in the library where I work, the barcodes of books are sometimes worn, > therefore code readers misread. > > The steps are as follows: > 1) income the barcode of the book to be returned (check in) > 2) before the Koha system to record the return in the database, ask for a > confirmation that this really is the book you want to return > 3) If it is accepted, the return actually recorded (check in ok) > 4) If you do not accept the return registration is canceled (check in > cancell) > > Add an image attached to help clarify the idea. Hi H?ctor Why not you only change the barcode? There are font type to generate the barcode in MSOffice or LibreOffice and it is works fine for Windows, MacOS, and, Linux systems. IDAutomation.com Free Code 39 Font is in <http://www.idautomation.com/free-barcode-products/code39-font/> In libraries with heavy traffic this could be a problem. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 22:20:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 21:20:21 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-ZeoeVHwbtE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #21 from M. Tompsett <mtompset at hotmail.com> --- (In reply to Tom?s Cohen Arazi from comment #20) > Yes, please. Re-test and fill a bug if your suspicion is correct. 3.22 needs > to be rock solid. As all Koha releases ;-) Thanks for taking the time to do > this. No errors thus far in the retest. I'll file a bug to remove all warnings. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:07:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:07:49 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15079-70-MsYwAdjmXw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com --- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Hi Kyle Another kind of error occur when you only enter one record with an item checked out. The record is highlighted but let delete it with message " All records have been deleted successfully! ", but when you go to see the record, the record still there. I think if only one record exist with an item that cannot deleted, the module must prevent to perform the action in some way. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:23:15 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:23:15 +0000 Subject: [Koha-bugs] [Bug 15086] New: Creators layout and template sql has warnings Message-ID: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 Bug ID: 15086 Summary: Creators layout and template sql has warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org When doing a hacked install: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. TEST PLAN --------- (1) Run this BEFORE applying: truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/de-DE/optional/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/es-ES/optional/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/it-IT/necessari/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/ru-RU/optional/print_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/uk-UA/optional/print_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/en/optional/sample_creator_data.sql --Notice the warnings show warnings; -- Most of them are the: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. (2) Apply the patch (3) Run the database update (4) Redo step (1) -- There should be no warnings or errors NOTE: fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:25:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:25:26 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15079-70-e92vvfMnNV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 --- Comment #3 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Hi Kyle I cannot reproduce the error. Is this in master? I'm testing with a fresh installation with only three records (one ?tem per record and just one with item that cannot be deleted), but works well for me. Regards -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:34:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:34:10 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15086-70-E7EkS2lh9f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:34:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:34:12 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15086-70-tQoueEfMjS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 44180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44180&action=edit Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_illegal_ha In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn_data_truncated Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:38:41 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-dONCnuwSga@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15086 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 [Bug 15086] Creators layout and template sql has warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:38:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:38:41 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15086-70-6SUhrC0OAq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15053 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 [Bug 15053] sample_creator_data.sql now fails during a fresh install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:39:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:39:21 +0000 Subject: [Koha-bugs] [Bug 15086] Creators layout and template sql has warnings In-Reply-To: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15086-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15086-70-OltgkzqGyz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Don't forget to apply 15053 first, before applying this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Oct 29 23:57:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 22:57:04 +0000 Subject: [Koha-bugs] [Bug 15087] New: make dt_from_string return undef for '0000-00-00' Message-ID: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bug ID: 15087 Summary: make dt_from_string return undef for '0000-00-00' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org Current master, define circulation rule All, All any number of days, but left 'Hard due date' EMPTY. Try to checkout something to a patron, you get Can't locate object method "truncate" via package "-1" (perhaps you forgot to load "-1"?) at .... Problem comes from GetHardDueDate, it returns return (dt_from_string($rule->{hardduedate}, 'iso'),$rule->{hardduedatecompare}); But dt_from_string returns without value in case of '0000-00-00' date, return if $date_string and $date_string =~ m|^0000-0| which evaluates to an empty list in this case, making the final return value for GetHardDueDate ( -1 ) instead of ( undef, -1 ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 00:04:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 23:04:06 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-QYrEmfL9Lg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44181&action=edit Bug 15087: make dt_from_string return undef for '0000-00-00' To test: 1) Reproduce problem in description 2) Apply the patch 3) Try again, no more problems I don't know if this could have side effects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 00:04:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 29 Oct 2015 23:04:59 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-Ru9yFtx2IA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron at veron.ch Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 02:25:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 01:25:43 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-J8rGc6F2dG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org Version|unspecified |master --- Comment #2 from H?ctor Eduardo Castro Avalos <hector.hecaxmmx at gmail.com> --- Hi Bernardo I'll add here Marc and Jonathan, since they have more experience with Koha::DateUtils. I feel scared when you mention that can have side effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 03:30:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 02:30:05 +0000 Subject: [Koha-bugs] [Bug 15088] New: Note in koha-remove help that --keep-mysql is how you remove instances with remote databases Message-ID: <bug-15088-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 Bug ID: 15088 Summary: Note in koha-remove help that --keep-mysql is how you remove instances with remote databases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: liz at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz If you try to remove a Koha instance that is using a remote database, it will fail and the sysadmin will feel sad. We already provide a mechanism by which we don't touch the mysql bits (--keep-mysql), it might be nice to explain in the help that using this will allow a sysadmin to remove the front-end of Koha and remove the remote database independently, at a later (or previous) time. I don't think we need a different option, maybe the existing one needs a different name... I'm not really sure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 03:32:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 02:32:36 +0000 Subject: [Koha-bugs] [Bug 15088] Note in koha-remove help that --keep-mysql is how you remove instances with remote databases In-Reply-To: <bug-15088-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15088-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15088-70-beIJfmTC2e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15088 --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- the only option name that is coming to my mind on this sunny friday afternoon is "--no-touchy-the-database-bits" I don't think that would really be good. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:15:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:15:00 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-ijyPUdLiyL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- (In reply to Owen Leonard from comment #2) > How about this in OPACUserCSS: > > span.no-image { > display: none; > } (In reply to Owen Leonard from comment #3) > Given the OPACUserCSS workaround I'm going to consider this WONTFIX. If > anyone wants to argue please re-open. I just confirmed this CSS does not work for OPAC, with 'GoogleJackets' syspref enabled, on Koha 3.18.8 so, re-opening - can someone else confirm this please? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:15:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:15:25 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-uTGENrLynA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:15:42 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:15:42 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-yFdx4kBTAG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:16:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:16:03 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-F7RRVjjIsk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:21:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:21:35 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-CVjMoAz8NO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 --- Comment #5 from Mason James <mtj at kohaaloha.com> --- Created attachment 44182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44182&action=edit pic showing FAILING solution -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:46:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:46:35 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-WAx9qkIoEE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 --- Comment #6 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #4) > (In reply to Owen Leonard from comment #2) > > How about this in OPACUserCSS: > > > > span.no-image { > > display: none; > > } > > (In reply to Owen Leonard from comment #3) > > Given the OPACUserCSS workaround I'm going to consider this WONTFIX. If > > anyone wants to argue please re-open. > > I just confirmed this CSS does not work for OPAC, with 'GoogleJackets' > syspref enabled, > on Koha 3.18.8 ..also, for me, the JS solution described below does not work either http://wiki.koha-community.org/wiki/JQuery_Library#Show_nothing_when_cover_images_are_not_found -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:51:44 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:51:44 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-rIakVfpeGW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 --- Comment #7 from Mason James <mtj at kohaaloha.com> --- Created attachment 44183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44183&action=edit pic showing FAILING JS solution -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 06:53:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 05:53:04 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-aeXkiqcXVR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44182|pic showing FAILING |pic showing FAILING CSS description|solution |solution -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 07:03:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 06:03:07 +0000 Subject: [Koha-bugs] [Bug 5761] system preference to control "No cover image available" message In-Reply-To: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5761-70-iOXySLtrbW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5761 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Mason: Can you explain why Owen's CSS doesn't work for you? I've been using the CSS mentioned by Owen for a few years now and I haven't noticed any difficulties. Does Google Jackets use a different HTML element and/or class? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 07:18:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 06:18:40 +0000 Subject: [Koha-bugs] [Bug 11858] RFID for circulation In-Reply-To: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11858-70-rohIPae4uR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 --- Comment #8 from Viktor Sarge <viktor.sarge at regionhalland.se> --- > We are looking to go with RFID at Washoe County. To have to check in and out > one item at a time is not going to go over well. What can we do to get this > moving? I?d say that even without the feature for RFID discussed in this thread there are two quite good options: * The new batch checkout feature. This one lets you send all the barcodes at once. It?s pushed to master and I hope that means it will show up in 3.22 that?s released in november. * Plack. It's not fully tested for staff use yet but we use it in production with quite good results (only have to restart every night and stay off the parts with known bugs - which we don't use anyway). Let med explain: The library I work tightly together with uses RFID in the existing circulation without adaptations. The RFID scanners just send the barcodes one at a time and rely on the fact that the barcode box has focus. The RFID scanner can then just pretend to be a keyboard. The problem has been page load times. Before with a load time of generally in the 1,5 - 2,5 span with some transactions taking perhaps 3,5-4 seconds we had to set the RFID scanners to wait up to 5 seconds between every barcode. Now with Plack they have been able to set the delay to 1 second. Hence: - 10 books before = 5*10 seconds = 50 seconds. - 10 books now = 1 * 10 seconds = 10 seconds. Much better. We will anyhow have a look at batch checkout which seems even better. In short a proper RFID feature would be welcome but we don't really feel any need to work towards this development now. It's not perfect but it works well enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 08:41:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 07:41:19 +0000 Subject: [Koha-bugs] [Bug 15089] New: koha-dump set permissions correct Message-ID: <bug-15089-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15089 Bug ID: 15089 Summary: koha-dump set permissions correct Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: muri+koha at immerda.ch QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Created attachment 44184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44184&action=edit patch for the koha-dump script the koha-dump script sets the permissions for the sql dump, but not for the tar.gz. this patch fixes this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 08:50:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 07:50:23 +0000 Subject: [Koha-bugs] [Bug 13799] Add base for building RESTful API In-Reply-To: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13799-70-21rJE0Z0Jw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #213 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44185&action=edit Bug 13799: Rename t/.../v1/borrowers.t to t/.../v1/patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:16:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:16:05 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-F4AB5C0Rt8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:16:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:16:05 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14870-70-HU0AehWHi9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15087 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:17:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:17:09 +0000 Subject: [Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools In-Reply-To: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14954-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14954-70-iIT10PsMn3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:21:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:21:47 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14870-70-0OzXhAcNDc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 --- Comment #4 from Marc V?ron <veron at veron.ch> --- As of today - 7 patches left to sign-off - 1 signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:29:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:29:18 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-btlCoLolFW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14870 --- Comment #3 from Marc V?ron <veron at veron.ch> --- At other places we did return ( eval { dt_from_string($rule->{hardduedate}, 'iso'),$rule->{hardduedatecompare}); }; ...to avoid such errors. I propose to do it here as well and postpone the change to dt_from_string until the C4::Dates removal is finished. It is in C4/Circulation.pm Line 1498 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:29:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:29:18 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14870-70-LAwO5k2sBg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15087 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 [Bug 15087] make dt_from_string return undef for '0000-00-00' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:39:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:39:50 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: <bug-7497-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7497-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7497-70-8C4KhVHpt2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|fridolin.somers at biblibre.co |gmcharlt at gmail.com |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:40:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:40:29 +0000 Subject: [Koha-bugs] [Bug 7497] "kw, wrdl" and variants should be replaced by something more explicit in search history In-Reply-To: <bug-7497-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7497-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7497-70-MZJCPBEEBd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7497 --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I'm not working on that, I dont even remember why I was assigned. Feel free -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:46:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:46:24 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-cYF2Oha2J2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44186&action=edit Bug 15077: Fix Fast Add framework to pass test This patch fixes tab location for FA frameworks. Not all subfields belongs to tab 0. To test: 1) On current master, with default and fasadd fw loaded, go to Home > Administration > MARC bibliographic framework test it fails 2) Apply the patch 3) Delete all fw, reload all, or just default (bib & auth) and fast add 4) Repeat 1, now test must pass This is only on master, so no need to database update. Signed-off-by: Hector Castro <hector.hecaxmmx at gmail.com> Works as advertised. MARC bibliographic framework test passed Ok. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:46:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:46:22 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-fxQfej77WD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 09:46:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 08:46:48 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-wZWxqyAcxB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #44176|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:00:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:00:07 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-Fzp1yYS2R9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44177|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44187&action=edit Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax This patch does the following: [1] Adjust authorities_merge_ajax just as in bug 14588. [2] Replace some indirect syntax for fetch GGI::Cookie. [3] Along the way replace some new CGI's. Note that I am not aiming to replace them Koha wide. The "fetch class" variant is less readable. NOTE: The changes to tools/upload-file.pl and upload-file-progress.pl are moved to report 14321. Test plan: [1] Run the URL authorities/merge_ajax.pl in staff. [2] Upload a file with Stage MARC records for import. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> [1] It runs, but also before patch [2] File uploads without problem No errors Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> We could certainly remove 1 or 2 call to CGI->new in tools/background-job-progress.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:00:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:00:05 +0000 Subject: [Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax In-Reply-To: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14589-70-ZXNhCCiWnN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:08:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:08:00 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-X67UxsvyEQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:08:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:08:03 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-gxUobSO5nY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44170|0 |1 is obsolete| | Attachment #44171|0 |1 is obsolete| | Attachment #44172|0 |1 is obsolete| | Attachment #44173|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44188&action=edit Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:08:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:08:07 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-KsyaoCMJdE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44189&action=edit Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:08:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:08:10 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-JXQrqWqmy3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44190&action=edit Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> All patches without errors. More consistent view. A few spaces and a little fix in followup Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:08:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:08:14 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-yyQ7VbNH6b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44191&action=edit Bug 15072: (followup) fix spaces and consistency This patch add a few spaces when required and adds layout_id on title and breadcrumbs (for patroncards) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:11:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:11:57 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-PNzDXeGPO2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #47 from Magnus Enger <magnus at libriotech.no> --- This bug might be related: Bug 14712 - Feature for controlling cron jobs/cmd line scripts from staff client http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 There are people in Sweden working on it. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:16:10 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-9xvPMinknM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Second patch does not work: mysql koha_empty < installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql ERROR 1136 (21S01) at line 15: Column count doesn't match value count at row 1 [koha at koha-qa:~/src (BZ15053) ?]% mysql koha_empty < installer/data/mysql/ru-RU/optional/print_labels.sql ERROR 1136 (21S01) at line 19: Column count doesn't match value count at row 1 [koha at koha-qa:~/src (BZ15053) ?]% mysql koha_empty < installer/data/mysql/uk-UA/optional/print_labels.sql ERROR 1136 (21S01) at line 21: Column count doesn't match value count at row 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:37:47 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15073-70-JnQ1e2EnJW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:37:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:37:50 +0000 Subject: [Koha-bugs] [Bug 15073] FeeOnChangePatronCategory in wrong place In-Reply-To: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15073-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15073-70-gmJ26wT0aO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15073 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44156|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44192&action=edit Bug 15073: Move FeeOnChangePatronCategory This patch moves the FeeOnChangePatronCategory system preference so that it's in a more logical place. Also a few typos were fixed. To test: * Go to System Preferences * Go to Patrons * Find FeeOnChangePatronCategory and confirm Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Confirmed. No errors. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:47:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:47:02 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-JfTL0kdTz5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44112|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44193&action=edit Bug 15059 - Line break in html attribute in branchoverdues.tt In circ/branchoverdues.tt, there is a line break inside href attribute. This generates an attribute with a lot of spaces %20. Test plan : - at intranet go to ciculation module - click on "Overdues with fines" - look at links "Phone", "Notice" and "Considered lost" => Without patch the URL contains a lot of spaces => With patch the URL is correct Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:46:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:46:59 +0000 Subject: [Koha-bugs] [Bug 15059] Line break in html attribute In-Reply-To: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15059-70-trdrZnXNYu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15059 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 10:52:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 09:52:35 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14694-70-WtTLygEPfS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #20) > > > ::: Koha/Biblio.pm > > > @@ +41,5 @@ > > > > +or list of Koha::Item objects in list context. > > > > + > > > > +=cut > > > > + > > > > +sub items { > > > > > > Wouldn't be better to use a DBIx::Class relation? > > > Something like bug 14819. > > No, we want to return a Koha::Object object, not a DBIC object. It would be > most confusing if a Koha::Object method were to return a DBIC object instead > of a Koha Object. And what about using the _wrap method? I am afraid that we are going to introduce quickly circular dependencies in the Koha namespace if we follow this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 11:28:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 10:28:29 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-LRVQ30NmZy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #34) > 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do > not recieve the item not checked out message. Why don't we want to display the message? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 11:51:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 10:51:49 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-auSNBNfdzM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #0) > Current master, define circulation rule All, All any number of days, > but left 'Hard due date' EMPTY. > > Try to checkout something to a patron, you get > > Can't locate object method "truncate" via package "-1" (perhaps you forgot > to load "-1"?) at .... Outch! > Problem comes from GetHardDueDate, it returns > > return (dt_from_string($rule->{hardduedate}, > 'iso'),$rule->{hardduedatecompare}); Yep. > But dt_from_string returns without value in case of '0000-00-00' date, It usually return undef when not called in a list context. (In reply to Bernardo Gonzalez Kriegel from comment #1) > Created attachment 44181 [details] [review] > Bug 15087: make dt_from_string return undef for '0000-00-00' No! :) It is usually a bad idea to explicitly return undef, and you get a perlcritic warning. > I don't know if this could have side effects That's why it's preferable not to change the return of the subroutine but the caller(s?). (In reply to Marc V?ron from comment #3) > At other places we did > > return ( eval { dt_from_string($rule->{hardduedate}, > 'iso'),$rule->{hardduedatecompare}); }; It's a weird hack :) dt_from_string does not return an error. > I propose to do it here as well and postpone the change to dt_from_string > until the C4::Dates removal is finished. We cannot wait for a fix here as it makes the application explodes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:00:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:00:45 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-gU6842QufZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #22) > Second patch does not work: > > mysql koha_empty < installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql > ERROR 1136 (21S01) at line 15: Column count doesn't match value count at row > 1 > > [koha at koha-qa:~/src (BZ15053) ?]% mysql koha_empty < > installer/data/mysql/ru-RU/optional/print_labels.sql > ERROR 1136 (21S01) at line 19: Column count doesn't match value count at row > 1 > > [koha at koha-qa:~/src (BZ15053) ?]% mysql koha_empty < > installer/data/mysql/uk-UA/optional/print_labels.sql > ERROR 1136 (21S01) at line 21: Column count doesn't match value count at row > 1 $ git log --oneline | head -4 81c151f Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data 9dc6b80 Bug 15053: sample_creator_data.sql now fails during a fresh install 05d3770 Bug 11881: QA follow-up - rename class 5adb226 Bug 11881: Small improvements for Items available for reference $ mysql koha_empty < kohastructure.sql $ mysql koha_empty < ru-RU/optional/print_labels.sql $ mysql koha_empty -e "delete from creator_layouts; delete from creator_templates; delete from printers_profile" $ mysql koha_empty < uk-UA/optional/print_labels.sql $ mysql koha_empty -e "delete from creator_layouts; delete from creator_templates; delete from printers_profile" $ mysql koha_empty < fr-FR/2-Optionel/sample_labels.sql Works for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:08:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:08:27 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-OzrCS3NXeD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bernardo, I don't reproduce the problem you described. My issuingrules table is empty. Please detail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:17:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:17:34 +0000 Subject: [Koha-bugs] [Bug 15087] make dt_from_string return undef for '0000-00-00' In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-zYT7PpPm2h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44181|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44194&action=edit Bug 15087: Fix GetHardDueDate return value This patch fixes GetHardDueDate return value in case of empty ('0000-00-00') hard due date. To test: 1) Reproduce problem in description 2) Apply the patch 3) Try again, no more problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:21:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:21:16 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-q1Sq8Lpado@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Summary|make dt_from_string return |Fix GetHardDueDate return |undef for '0000-00-00' |value --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #5) > Bernardo, I don't reproduce the problem you described. > My issuingrules table is empty. > Please detail. Problem arises when you create a rule mysql kohadev -e "select categorycode,itemtype,hardduedate from issuingrules" +--------------+----------+-------------+ | categorycode | itemtype | hardduedate | +--------------+----------+-------------+ | * | * | 0000-00-00 | +--------------+----------+-------------+ Changed patch and bug description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:23:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:23:17 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-Rf7C5yNvo6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #4) > (In reply to Bernardo Gonzalez Kriegel from comment #0) > > Current master, define circulation rule All, All any number of days, > > but left 'Hard due date' EMPTY. > > > > Try to checkout something to a patron, you get > > > > Can't locate object method "truncate" via package "-1" (perhaps you forgot > > to load "-1"?) at .... > > Outch! > The problem was discovered by Hector. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:32:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:32:50 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-KqR9C09Qbz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:32:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:32:53 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-u6bTM6maSr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44159|0 |1 is obsolete| | Attachment #44160|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44195&action=edit Bug 15053: sample_creator_data.sql now fails during a fresh install ERROR 1136 (21S01) at line 6: Column count doesn't match value count at row 1 Test Plan: 1) Start fresh install 2) Install all test data 3) Note the SQL error 4) Apply this patch 5) Repeat steps 1 and 2 6) Note no error Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> All fixed files loads without problem. No errors found Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:32:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:32:59 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-mYpIkKNLES@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44196&action=edit Bug 15053: Fix fr-FR, ru-RU and uk-UK sample creator data Fixes other sample creators data To test: 1 ) Apply the patch 2) Remove sample creator date delete from creator_layouts; delete from creator_templates; delete from printers_profile 3) Load fr-FR/2-Optionel/sample_labels.sql or ru-RU/optional/print_labels.sql or uk-UA/optional/print_labels.sql Without the patch this files can't be loaded Test all of them In case of ru and uk I removed a patron card layout Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:34:09 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:34:09 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-rZZRELwJcW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Bernardo Gonzalez Kriegel from comment #23) > Works for me OOpps! Sorry about that Bernardo, indeed it works well. My koha_empty DB was not updated :-/ So again, my apologies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:39:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:39:52 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-nHUQhHjG7k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bgkriegel at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bernardo, ok thanks, I am on it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:40:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:40:10 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-qWdzDb0tUT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:53:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:53:43 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-zicNA3Czd8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:53:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:53:46 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-x4hfIKpfqi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44194|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 44197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44197&action=edit Bug 15087: hardduedate should not be inserted as 0000-00-00 but NULL This has been introduced by bug 14949, recently pushed. So I don't think we need to update the DB, only devs will face this problem. The hardduedate was inserted as 0000-00-00 because was en empty string. To be inserted as NULL, the value should be undef. Test plan: 0/ Don't apply this patch 1/ Edit a circ rules and don't fill the hard due date 2/ Look at the DB, the value is 0000-00-00 3/ Apply this patch and confirm that the value is now NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:54:43 +0000 Subject: [Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl In-Reply-To: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14949-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14949-70-RUev8XoFIS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15087 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 [Bug 15087] Fix GetHardDueDate return value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:54:43 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-LUrd3wgbvS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14870 |14949 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- To restore the behavior that existed before bug 14949, I think this is the way to go. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949 [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:54:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:54:41 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-NxDYny049A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 --- Comment #27 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to Jonathan Druart from comment #26) > So again, my apologies. No problem :) Thank you for your work!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:54:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:54:43 +0000 Subject: [Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System In-Reply-To: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14870-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14870-70-c1lct9dZG7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15087 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 [Bug 15087] Fix GetHardDueDate return value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 12:55:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 11:55:00 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-ms8XaLhAfY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- And this is critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 13:04:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 12:04:00 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-vqLlRibzVe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 13:04:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 12:04:03 +0000 Subject: [Koha-bugs] [Bug 15087] Fix GetHardDueDate return value In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-Zkor4CGAzC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44197|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44198&action=edit [SIGNED-OFF] Bug 15087: hardduedate should not be inserted as 0000-00-00 but NULL This has been introduced by bug 14949, recently pushed. So I don't think we need to update the DB, only devs will face this problem. The hardduedate was inserted as 0000-00-00 because was en empty string. To be inserted as NULL, the value should be undef. Test plan: 0/ Don't apply this patch 1/ Edit a circ rules and don't fill the hard due date 2/ Look at the DB, the value is 0000-00-00 3/ Apply this patch and confirm that the value is now NULL Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Confirmed +--------------+----------+-------------+ | categorycode | itemtype | hardduedate | +--------------+----------+-------------+ | * | * | NULL | +--------------+----------+-------------+ No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 13:06:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 12:06:23 +0000 Subject: [Koha-bugs] [Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-1Xwb9np9ik@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix GetHardDueDate return |hardduedate should not be |value |inserted as 0000-00-00 but | |NULL --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Signed and changed description... again :) (In reply to Jonathan Druart from comment #11) > To restore the behavior that existed before bug 14949, I think this is the > way to go. Agreed Signed and changed summary... again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 13:13:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 12:13:29 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-IJV50P5LP3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #172 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 42292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42292 Bug 13813: Remove deprecated module C4::Dates from system Review of attachment 42292: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13813&attachment=42292) ----------------------------------------------------------------- ::: C4/Suggestions.pm @@ +179,5 @@ > my $to = $field . "_to"; > if ( $suggestion->{$from} || $suggestion->{$to} ) { > push @query, qq{ AND suggestions.$field BETWEEN ? AND ? }; > push @sql_params, > + output_pref({ dt => dt_from_string( $suggestion->{$from} ), dateformat => 'iso', dateonly => 1 }) || '0000-00-00'; This is wrong. Please provide a follow-up. Before this patch the "from" date was 0000-00-00 if not filled, now it's today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 13:43:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 12:43:26 +0000 Subject: [Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out In-Reply-To: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13411-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13411-70-3nuB28MgJt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #36) > (In reply to Kyle M Hall from comment #34) > > 9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do > > not recieve the item not checked out message. > > Why don't we want to display the message? Because some SIP2 sorters will behave badly if we send the message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 13:46:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 12:46:49 +0000 Subject: [Koha-bugs] [Bug 15079] Batch Delete Records Error In-Reply-To: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15079-70-oeVai8QZnJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15079 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- It may be that I'm test plan is incomplete. I spotted the error after a library reported the issue. The bad label clearly exists in master, but the problem records had already been removed so I was unable to reproduce the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:05:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:05:30 +0000 Subject: [Koha-bugs] [Bug 15053] sample_creator_data.sql now fails during a fresh install In-Reply-To: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15053-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15053-70-X8nODQyQ6a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks Kyle and Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:06:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:06:02 +0000 Subject: [Koha-bugs] [Bug 15072] Breadcrumbs and titles inconsistent in Label creator In-Reply-To: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15072-70-oNl5hQhGGw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master. Thanks for the followup, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:06:28 +0000 Subject: [Koha-bugs] [Bug 15077] Fix Fast Add framework to pass test In-Reply-To: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15077-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15077-70-sYtsbiDBYt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15077 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:06:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:06:50 +0000 Subject: [Koha-bugs] [Bug 15010] Import patron tool creates 'duplicate' restrictions ( debarments ) In-Reply-To: <bug-15010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15010-70-OXPYNYu2X8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15010 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:50:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:50:01 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: <bug-6657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6657-70-uP4u0QI5bm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:50:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:50:05 +0000 Subject: [Koha-bugs] [Bug 6657] Making 999 visible in framework duplicates 999 entry and affects index In-Reply-To: <bug-6657-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6657-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6657-70-5WAVKRT5o3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6657 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42667|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44199&action=edit [SIGNED-OFF] Bug 6657: Prevent biblionumber to be duplicated If the biblionumber field is displayed in the framework, on editing a biblio the field/subfield will be duplicated. To prevent that this patch adds a check when building the field list. Test plan: 1/ map biblio.biblionumber with 999$c 2/ Display 999$c in a framework 3/ Edit a biblio using this framework 4/ Save => The field should not have been duplicated 5/ map biblio.biblionumber with 001 6/ Display 001 in a framework 7/ Edit a biblio using this framework 8/ Save => The field should not have been duplicated Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works as described, aldo removes duplicate values. No errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 14:56:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 13:56:58 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12540-70-5DyRDKmWAK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42767|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 44200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44200&action=edit [SIGNED-OFF] Bug 12540: Display "Every" on editing a MMT action if previously selected On creating a marc modification template action, the "All" is changed with "Every" if the condition field is the same as the original field. But on editing, the "All" value is not replaced. For consistency, it should. Test plan: 1/ Create the following action: Copy field 650$x to 650$y if 650$z matches "foobar" Note that the "All" is replaced with "Every" when the condition is the same field as the original field. 2/ Save 3/ Edit the action. The "Every" should be selected. Without this patch, "All" is selected. Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:00:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:00:27 +0000 Subject: [Koha-bugs] [Bug 4502] Perl error in acq budget planning In-Reply-To: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4502-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4502-70-XGTHWohWLP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Sorry, does not apply anymore Applying: Bug 4502: Catch software error if no active budget defined Applying: Bug 4502: An attempt to make things more sensible. fatal: sha1 information is lacking or useless (admin/aqplan.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 4502: An attempt to make things more sensible. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:06:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:06:28 +0000 Subject: [Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed In-Reply-To: <bug-14878-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14878-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14878-70-PdkwisJ2h6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:08:20 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:08:20 +0000 Subject: [Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option In-Reply-To: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-12540-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12540-70-XLnZqU6jl6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:21:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:21:05 +0000 Subject: [Koha-bugs] [Bug 15090] New: Fix date filter for Suggestions management Message-ID: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Bug ID: 15090 Summary: Fix date filter for Suggestions management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org Bug 13813 introduced an error with datefilters in Home > Acquisitions > Suggestions management See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 Before 1383 the "from" date was 0000-00-00 if not filled, now it's today. This patch re-introduces 0000-00-00. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:21:28 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15090-70-lJSbvJYihk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:21:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:21:28 +0000 Subject: [Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system In-Reply-To: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13813-70-Cy6mUr6Zqv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15090 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:22:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:22:26 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15090-70-k72tSKVXZt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Marc V?ron <veron at veron.ch> --- Ccing Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:28:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:28:34 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15062-70-LZZLPrmftV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:31:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:31:47 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15090-70-Kegk2QpWij@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 44201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44201&action=edit Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:32:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:32:25 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15090-70-TAgJf7G5TJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Priority|P5 - low |P1 - high Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:33:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:33:43 +0000 Subject: [Koha-bugs] [Bug 15062] Holds queue with Transport Cost Matrix will transfer item even if transfers disabled In-Reply-To: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15062-70-N7qG7Po0Uu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15062 Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43984|0 |1 is obsolete| | --- Comment #2 from Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> --- Created attachment 44202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44202&action=edit Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled If the transfer of an item from Library A to Library B is disabled in the Transport Cost Matrix, but the only item on a record is from Library A, the holds queue will request a transfer of that item from Library A to Library B even though the rules state such a transfer is not allowed! Test Plan: 1) Enable the transport cost matrix 2) For simplicity, leave all cells disabled on it, save this state. This state means that only items at each location should fill holds where the pickup library is that same location. 3) Create a record with one item, set its home and holding branch to Library A 4) Create a hold for pickup at Library B 5) Rebuild the holds queue 6) Note the transfer request for the item to Library B 7) Apply this patch 8) Rebuild the holds queue 9) Note the transfer request is gone Signed-off-by: Andreas Hedstr?m Mace <andreas.hedstrom.mace at sub.su.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:34:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:34:29 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-hthzIKQtVr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43831|0 |1 is obsolete| | Attachment #43832|0 |1 is obsolete| | Attachment #43978|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44203&action=edit Bug 14310 - Suspend and resume indvidual holds from patron holds table This enhancment adds the ability to suspend and resume individual holds from the holds table on circulation.pl and moremember.pl. The interface is inspired/cribbed from the same feature already available in the opac. Test Plan: 1) Apply this patch 2) Find a patron with holds 3) Suspend a hold with no resume date 4) Resume the suspended hold 5) Suspend a hold with a resume date 6) Resume the suspended hold Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS at ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki at mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:34:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:34:26 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-HJ6cFNszHN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:34:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:34:37 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-RjAiFwQeAh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44204&action=edit Bug 14310 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:34:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:34:40 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-X2t9GyQ4K6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44205&action=edit Bug 14310 [QA Followup] - Enable translations, set svc script to be executable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:34:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:34:43 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-asjxtNqCaA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 --- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44206&action=edit Bug 14310 [QA Followup] - Deal with error conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:35:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:35:23 +0000 Subject: [Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table In-Reply-To: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14310-70-m6ByT8h5vb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44206|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44207&action=edit Bug 14310 [QA Followup] - Deal with error conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:37:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:37:30 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-JB2DJBazGq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10326|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44208&action=edit [SIGNED-OFF] Bug 5979 : OPAC : using OPACISBD systempreference to display link The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Verified that new system preference is added cleanly and ISBD view can be configured independently for staff and OPAC using OPACISBD and viewISBD system preferences. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:37:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:37:38 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-Ee33Oagi67@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44123|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44209&action=edit [SIGNED-OFF] Bug 5979 - Follow up: using OPACISBD systempreference to display link Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:37:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:37:47 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-q7Fk9lDCXM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44126|0 |1 is obsolete| | --- Comment #19 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44210&action=edit [SIGNED-OFF] Bug 5979 - OPAC ISBD view has its own syspref Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Works well, empty OPACISBD removes link. Test pass. Small koha-qa error fixed in followup -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:40:18 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:40:18 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-oAVSqwEGNS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44211&action=edit Bug 5979: follow to fix spelling Changed Montains -> Mountains koha-qa complains!! Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 15:40:48 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 14:40:48 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5979-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5979-70-vpK0rx7g1L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:28:51 +0000 Subject: [Koha-bugs] [Bug 15091] New: Batch Checkout Doesn't Tell You it Failed Message-ID: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Bug ID: 15091 Summary: Batch Checkout Doesn't Tell You it Failed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 11759 If you do a batch checkout and the patron is blocked for some reason it shows you a list of the barcodes you scanned, but not warning or confirmation that none of the items were checked out. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 [Bug 11759] Batch checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:28:51 +0000 Subject: [Koha-bugs] [Bug 11759] Batch checkout In-Reply-To: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-11759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11759-70-2kOwX0Gk6a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15091 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 [Bug 15091] Batch Checkout Doesn't Tell You it Failed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:32:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:32:24 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15091-70-i3DZCzSfRx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44212&action=edit warning? This image shows that the patron owes money but it doesn't say that it won't be checking out - there are checkboxes next to all of the ones with error. Then when you confirm it shows you the same titles again but no title on the page to indicate that they did not in fact checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:50:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:50:53 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-cF0HJhKqCV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44213&action=edit Bug 13501: Indentation fix (batchMod-edit.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:50:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:50:56 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-a4DGSQ6tAi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44214&action=edit Bug 13501: Move "Required" and checkbox after input/select -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:51:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:51:00 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-RwcXcaqh8p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 --- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44215&action=edit Bug 13501: Downgrade Select2 to version 3.5.4 version 3.5.4 is more "keyboard-friendly" than version 4.0.0 + add Select2 to the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:51:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:51:22 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-X2qvS74REc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:52:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:52:25 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15091-70-gW78W70of2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:55:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:55:53 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-1kxmIIJgsM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40708|0 |1 is obsolete| | Attachment #44215|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44216&action=edit Bug 13501: Add JS library select2 3.5.4 use it on cataloguing and batch items edit pages Note: this is a squash of two commits: - Add JS library select2, use it on cataloguing and batch items edit pages - Downgrade Select2 to version 3.5.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:56:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:56:03 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-HjiKodjgQd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44213|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44217&action=edit Bug 13501: Indentation fix (batchMod-edit.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 16:56:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 15:56:08 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-13501-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13501-70-RJcl8qbAqM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44214|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 44218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44218&action=edit Bug 13501: Move "Required" and checkbox after input/select -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:32 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-2h8tWuQFza@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:35 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:35 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-GzlzsvqMVy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43654|0 |1 is obsolete| | Attachment #43655|0 |1 is obsolete| | Attachment #43656|0 |1 is obsolete| | Attachment #43657|0 |1 is obsolete| | Attachment #43658|0 |1 is obsolete| | --- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44219&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:45 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-JxCVwXDy3R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44220&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:49 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-sHSN3I1CA6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44221&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:52 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-J8yR8U1MFQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44222&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:58 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-aBDT8wQPLL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44224&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:16:01 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:16:01 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-y1jcuM9ywX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44225&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:15:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:15:55 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-UQjQBI9W76@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #46 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44223&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:16:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:16:04 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-6ifBwa7tIK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44226&action=edit Bug 14610 [QA Followup] - Add notices for all translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:16:07 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:16:07 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-oRbQtRBVct@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44227&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:16:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:16:10 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-zpCZvhaoYR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44228&action=edit Bug 14610 [QA Followup] - Change 'Opan' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:16:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:16:13 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-pbc8zNVoqV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #52 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44229&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:16:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:16:17 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-4KDdMBtcIg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44230&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:11 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:11 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-ZMlqO9Pag8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44219|0 |1 is obsolete| | Attachment #44220|0 |1 is obsolete| | Attachment #44221|0 |1 is obsolete| | Attachment #44222|0 |1 is obsolete| | Attachment #44223|0 |1 is obsolete| | Attachment #44224|0 |1 is obsolete| | Attachment #44225|0 |1 is obsolete| | Attachment #44226|0 |1 is obsolete| | Attachment #44227|0 |1 is obsolete| | Attachment #44228|0 |1 is obsolete| | Attachment #44229|0 |1 is obsolete| | Attachment #44230|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44231&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:26 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-j4Z14sdSou@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44232&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:30 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-WorPR9MJE2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44233&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:33 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-ibKbjgh9ek@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #57 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44234&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt at switchinc.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:37 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-rs1sFDgZbc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44235&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:41 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-aW4Ji98ueQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44236&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:46 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:46 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-GCHhoMaR3j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #60 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44237&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:49 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-yduigLPs6V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #61 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44238&action=edit Bug 14610 [QA Followup] - Add notices for all translations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:52 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-dYMGGoa4Ac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44239&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:56 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-pa4lbAdPzk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44240&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:33:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:33:59 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-jZXqqM8iaH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44241&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:34:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:34:03 +0000 Subject: [Koha-bugs] [Bug 14610] Add ability to place article requests in Koha In-Reply-To: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14610-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14610-70-VIupHbdN0v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44242&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:50:40 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:50:40 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14078-70-fl8YpdSqHn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Attachment #44052|application/mbox |text/plain mime type| | Attachment #44052|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 18:50:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 17:50:57 +0000 Subject: [Koha-bugs] [Bug 14078] converting from ISO5426 is not complete In-Reply-To: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14078-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14078-70-etqtE7QViO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44053|0 |1 is patch| | Attachment #44053|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:13:22 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:13:22 +0000 Subject: [Koha-bugs] [Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-PjnvIfYCDl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:13:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:13:24 +0000 Subject: [Koha-bugs] [Bug 15087] hardduedate should not be inserted as 0000-00-00 but NULL In-Reply-To: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15087-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15087-70-Sn7iQh9Gbg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15087 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44198|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44244&action=edit [PASSED QA] Bug 15087: hardduedate should not be inserted as 0000-00-00 but NULL This has been introduced by bug 14949, recently pushed. So I don't think we need to update the DB, only devs will face this problem. The hardduedate was inserted as 0000-00-00 because was en empty string. To be inserted as NULL, the value should be undef. Test plan: 0/ Don't apply this patch 1/ Edit a circ rules and don't fill the hard due date 2/ Look at the DB, the value is 0000-00-00 3/ Apply this patch and confirm that the value is now NULL Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Confirmed +--------------+----------+-------------+ | categorycode | itemtype | hardduedate | +--------------+----------+-------------+ | * | * | NULL | +--------------+----------+-------------+ No koha-qa errors Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:16:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:16:17 +0000 Subject: [Koha-bugs] [Bug 15092] New: item type descriptions not showing if no logo Message-ID: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bug ID: 15092 Summary: item type descriptions not showing if no logo Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 10937 Created attachment 44245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44245&action=edit missing item type images/text If there is no icon the item type description should show in the opac, but nothing is showing. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 [Bug 10937] Option to hide and group itemtypes from advanced search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:16:17 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:16:17 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10937-70-pd2DgXvhxh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15092 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 [Bug 15092] item type descriptions not showing if no logo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:18:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:18:10 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: <bug-14978-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14978-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14978-70-KfpgIuq48d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:18:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:18:13 +0000 Subject: [Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key In-Reply-To: <bug-14978-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14978-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14978-70-aKcgAMfQrF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43342|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44246&action=edit [PASSED QA] Bug 14978: Add unique key constraint on issues.itemnumber The constraint might have existed before bug 14069. For these DB, this patch will restore it, for others, it will add it :) Test plan: > show create table issues; should not return "unique key itemnumber" Execute the updatedb entry twice > show create table issues; should return only one "unique key itemnumber" Signed-off-by: Marc V?ron <veron at veron.ch> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:21:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:21:57 +0000 Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in In-Reply-To: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14821-70-dFyRs7POiw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:21:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:21:57 +0000 Subject: [Koha-bugs] [Bug 15093] New: item type groups not saving Message-ID: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Bug ID: 15093 Summary: item type groups not saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 10937 See here: http://screencast.com/t/qKx78oxQ When I add an item type to a group it doesn't seem save. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 [Bug 10937] Option to hide and group itemtypes from advanced search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:21:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:21:57 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10937-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10937-70-lm4OmA242m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15093 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 [Bug 15093] item type groups not saving -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:22:00 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:22:00 +0000 Subject: [Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in In-Reply-To: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14821-70-gojwoJh2AA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44054|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44247&action=edit [PASSED QA] Bug 14821: Do not list not returned items On the checkin page, the table is always filled with info of the scanned barcode, even if the checkin has failed. When the checkin fails, there is already an error displayed, so there is no need to keep a row for fails. Test plan: Confirm that the failed checkins don't appear anymore in the checkin table. - checkin an item which is not issued; - BlockReturnOfWithdrawnItems is set and item is withdrawn; - Not returned at the right place; - privacy=2 and AnonymousPatron not correctly set; Before this patch this behavior existed only for bad barcode. Signed-off-by: Frederic Demians <f.demians at tamil.fr> I confirm that the checkin table hasn't to be populated with info on items which haven't been checked in. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:25:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:25:29 +0000 Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships - biblio<->biblioitem<->item In-Reply-To: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14819-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14819-70-f65KLQ9jO0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Koha::Item::biblioitem should return a Koha::Biblioitem object, rather than a DBIC object. Another possibility would be to extend Koha::Biblio so that it handles both the biblio and biblioitem tables internally, so they look like one unified table from the perspective using using Koha::Biblio. The auto method on Koha::Biblio could be extended to check for a valid biblio field first, and if it doesn't find one, a valid biblioitem field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:27:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:27:19 +0000 Subject: [Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed In-Reply-To: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15091-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15091-70-zhO2XkWfO3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Here is a video of what I'm seeing as a big usability issue: http://screencast.com/t/lx6C2zKPxd -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:36:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:36:14 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14889-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14889-70-24YhLELJbE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:42:14 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:42:14 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: <bug-14388-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14388-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14388-70-YHGmhzzxjR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:42:16 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:42:16 +0000 Subject: [Koha-bugs] [Bug 14388] add sorting to funds In-Reply-To: <bug-14388-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14388-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14388-70-j0oDgbFwJR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40855|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44248&action=edit Bug 14388: Funds should be sorted by budget_code Before this patch, the funds were sorted by budget_id, which does not make any sense. This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and admin/aqbudgets.pl) Test plan: On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that the funds are now sorted by fund code (DB column budget_code) Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:43:37 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:43:37 +0000 Subject: [Koha-bugs] [Bug 14060] Remove readonly on date inputs In-Reply-To: <bug-14060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14060-70-qI6TvJN2EU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nengard at gmail.com --- Comment #7 from Nicole C. Engard <nengard at gmail.com> --- g13:42 ~/kohaclone (master % u=)$ git qa 14060 Note: checking out 'origin/master'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b new_branch_name HEAD is now at fd12390... Bug 15010: Import patron tool creates 'duplicate' restrictions ( debarments ) Branch bug14060-qa set up to track remote branch master from origin. Switched to a new branch 'bug14060-qa' Bug 14060 - Remove readonly on date inputs 38484 - Bug 14060: Remove readonly attributes on date inputs 38540 - Bug 14060: Add OnClose event on missing datepicker 38541 - Bug 14060: Display the date format on the warning popup Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14060: Remove readonly attributes on date inputs Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table-footer.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc Applying: Bug 14060: Add OnClose event on missing datepicker Applying: Bug 14060: Display the date format on the warning popup 13:43 ~/kohaclone (bug14060-qa % u+3)$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:47:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:47:38 +0000 Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu In-Reply-To: <bug-14773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14773-70-1utCI0iq2R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:47:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:47:41 +0000 Subject: [Koha-bugs] [Bug 14773] Move help link back out of the dropdown menu In-Reply-To: <bug-14773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14773-70-0JYy31FfRr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14773 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42452|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44249&action=edit Bug 14773: Move help link back out of the dropdown menu This moves the help link back out of the dropdown menu like it used to be. To test: 1. Notice that in intra the help link is inside the dropdown menu. 2. Apply the patch 3. Notice that the help link is now clearly visible in the top right corner of the page. Sponsored-by: Vaara-kirjastot Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:57:26 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:57:26 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-BMWczti5jO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:57:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:57:29 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-USghnAetOK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44139|0 |1 is obsolete| | Attachment #44140|0 |1 is obsolete| | Attachment #44141|0 |1 is obsolete| | Attachment #44142|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44250&action=edit [PASSED QA] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Operations in admin/category is unchanged, and functionnal Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:57:50 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:57:50 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-bvDhrMSXer@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44250|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44251&action=edit [PASSED QA] Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl Test plan: Add/edit/remove patron categories from the administration module (admin/categories.pl). You should get message feedback after each action. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Operations in admin/category is unchanged, and functionnal Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:57:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:57:57 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-lf4RJBIwxf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44252&action=edit [PASSED QA] Bug 14836: Add Koha::PatronCategor[y|ies] classes Note that some of the routines are retrieved from bug 10363 (branch limitations). They are not all used in these patch set, but they will permit to replace the subroutines in C4::Form::MessagingPreferences, in the next step. Signed-off-by: Frederic Demians <f.demians at tamil.fr> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:57:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:57:59 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-V72wNQ5VO1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44253&action=edit [PASSED QA] Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:58:05 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:58:05 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-UKVagBx7Or@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44255&action=edit [PASSED QA] Bug 14836 [QA Followup] - Fix number of unit tests Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 19:58:02 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 18:58:02 +0000 Subject: [Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories In-Reply-To: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14836-70-4OUXH4vd2W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 44254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44254&action=edit [PASSED QA] Bug 14836: Add tests for Koha::Patron::Categor[y|ies] Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:28:51 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:28:51 +0000 Subject: [Koha-bugs] [Bug 15085] Require confirmation before check in In-Reply-To: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15085-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15085-70-J2gZd4uLRi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15085 --- Comment #5 from H?ctor <hectorejch at yahoo.com.ar> --- Hi H?ctor, This is also a requirement that made me from the library management. Bar codes themselves are in good condition, but very occasionally have a false reading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:36:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:36:24 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15093-70-HWVR6UZiQo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44256&action=edit Bug 15093: Load/show saved item type group and hideinopac This patch adds loading of hideinopac and searchgroup when showing/editing itemtypes To test: 1) Put some values in ITEMTYPCAT auth value 2) Edit an item type, select a value for search category & check 'Hide in OPAC' Save 3) Results do no show on list of item types 4) Edit same item type, values are default/empty 5) Apply the patch 6) Edit again, change again, save Now values shows in list 7) Edit again, values are now correct Values were saved on db, but not loaded from it How this happen? Side note: searching for searchcategory I found installer/data/mysql/kohastructure.sql: searchcategory varchar(80) default NULL, -- Group this item type with others w installer/data/mysql/updatedatabase.pl: ADD searchcategory VARCHAR(20) DEFAULT NULL Its varchar(80) in kohastructure and varchar(20) in updatedatabase We need more eyes :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:36:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:36:59 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15093-70-nj6xfIG96A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:48:06 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:48:06 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15093-70-NP5PYPMd6s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:48:08 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:48:08 +0000 Subject: [Koha-bugs] [Bug 15093] item type groups not saving In-Reply-To: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15093-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15093-70-I7JVpI1T1O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15093 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44256|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44257&action=edit Bug 15093: Load/show saved item type group and hideinopac This patch adds loading of hideinopac and searchgroup when showing/editing itemtypes To test: 1) Put some values in ITEMTYPCAT auth value 2) Edit an item type, select a value for search category & check 'Hide in OPAC' Save 3) Results do no show on list of item types 4) Edit same item type, values are default/empty 5) Apply the patch 6) Edit again, change again, save Now values shows in list 7) Edit again, values are now correct Values were saved on db, but not loaded from it How this happen? Side note: searching for searchcategory I found installer/data/mysql/kohastructure.sql: searchcategory varchar(80) default NULL, -- Group this item type with others w installer/data/mysql/updatedatabase.pl: ADD searchcategory VARCHAR(20) DEFAULT NULL Its varchar(80) in kohastructure and varchar(20) in updatedatabase We need more eyes :) Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:50:45 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:50:45 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15090-70-bEqraUSK2m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:50:47 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:50:47 +0000 Subject: [Koha-bugs] [Bug 15090] Fix date filter for Suggestions management In-Reply-To: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15090-70-hhT1vlQMxq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15090 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44201|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44258&action=edit Bug 15090: Fix date filter for Suggestions management Home > Acquisitions > Suggestions management: Before 13813 the "from" date in filters was 0000-00-00 if not filled, afer 13813 it's today. This patch re-introduces 0000-00-00. See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813#c172 To test: - Go to Home > Acquisitions > Suggestions management - Verify that date filters work as expected - Verify that start dates in sql query are 0000-00-00 if no start dates are given - Note: Line 185 outputs the start dates as warn if $debug is set. Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:54:27 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:54:27 +0000 Subject: [Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options In-Reply-To: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14690-70-eBZ1x7SXVE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- I'm not seeing this problem. I do see lines appear when I click the + before applying this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:58:25 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:58:25 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14948-70-V7DFo4NlWY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- On the patron details and the check out tab at the bottom the amounts are not right aligned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 20:58:38 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 19:58:38 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14948-70-q7OPjdYyly@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44259&action=edit not aligned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 21:10:29 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 20:10:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9303-70-bC1mo6h4g6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #255 from Nicole C. Engard <nengard at gmail.com> --- My understanding is that if it's passed qa it's going to be considered for 3.22. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 21:25:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 20:25:30 +0000 Subject: [Koha-bugs] [Bug 15094] New: update link to offline circ for windows Message-ID: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Bug ID: 15094 Summary: update link to offline circ for windows Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: nengard at gmail.com Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The offline circ for windows tool has a new home: https://github.com/bywatersolutions/koha-offline-circulation/releases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 21:29:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 20:29:55 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15094-70-zEToWZZR9i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 21:29:58 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 20:29:58 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15094-70-HXhn8cJq8a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 44260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44260&action=edit Bug 15094: Update link to Windows Offline Circ This patch updates the link on the main circulation page to point to the newest release of the offline circulation tool. To test: * Go to Circulation * Click 'Get desktop application' * Confirm the link goes to github -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Oct 30 23:25:12 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 22:25:12 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15092-70-nIbV4yyNtX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Problem here is in opac-search.pl $itemytpes = GetItemTypesCategorized; but this itemtypes don't have $itemtypes->{$thisitemtype}->{translated_description} which is the string printed I put Jonathan in CC, he knows better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 00:29:34 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 23:29:34 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15094-70-zNV6anRmZu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 00:29:36 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 23:29:36 +0000 Subject: [Koha-bugs] [Bug 15094] update link to offline circ for windows In-Reply-To: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15094-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15094-70-vX5urLeUvB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15094 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44260|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44261&action=edit [SIGNED-OFF] Bug 15094: Update link to Windows Offline Circ This patch updates the link on the main circulation page to point to the newest release of the offline circulation tool. To test: * Go to Circulation * Click 'Get desktop application' * Confirm the link goes to github Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Link Ok No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 00:56:56 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 23:56:56 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: <bug-15009-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15009-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15009-70-ZGS4KqINWr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 00:56:59 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 30 Oct 2015 23:56:59 +0000 Subject: [Koha-bugs] [Bug 15009] Planning dropdown button in aqbudget can have empty line In-Reply-To: <bug-15009-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15009-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15009-70-r5tePPMYkK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15009 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43392|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44262&action=edit [SIGNED-OFF] Bug 15009 - Planning dropdown button in aqbudget can have empty line When displaying a budget, the Planning button in the admin toolbar displays Plan by months Plan by libraries Plan by item types Plan by The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined. This prevents returning an array with empty element(s) TEST: 1) Admin -> Budgets 2) Select a budget a) you must have '' (empty) in your aqbudgets.sort1_authcat field. b) edit the budget (direct DB or interface) to get that. 3) Click on Planning dropdown, see the "Plan by <nothing> " entry. 4) apply the patch, revalidate. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> No more empty option No errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 01:04:57 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 00:04:57 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14482-70-bIcvRIc37V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Can't reproduce -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 01:22:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 00:22:21 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: <bug-14627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14627-70-mpDtV2dWRN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43090|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44263&action=edit [SIGNED-OFF] Bug 14627: Check for undef passed to GetAuthorisedValueByCode Dont prepare or execute unnecessary sql if passed an undef value routine is used in various places that dont check if the value returned from a nullable field is defined or not (e.g. streettype in the borrower record which many sites do not use) Lets save those cpu cycles for something useful Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 01:22:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 00:22:28 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: <bug-14627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14627-70-ew3x7I635k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43091|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44264&action=edit [SIGNED-OFF] Bug 14627: Improve SQL query A field=NULL condition does not run properly. If category is undefined, then don't include it in the query. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> No regressions detected, no errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 01:22:43 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 00:22:43 +0000 Subject: [Koha-bugs] [Bug 14627] GetAuthorisedValueByCode does not handle undef intelligently In-Reply-To: <bug-14627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14627-70-pkBWkDmlJy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14627 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 01:26:24 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 00:26:24 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-ZX0vxG1jvi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel at gmail.com --- Comment #225 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Sorry, does not apply Auto-merging C4/Reports/Guided.pm CONFLICT (content): Merge conflict in C4/Reports/Guided.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 13:35:55 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 12:35:55 +0000 Subject: [Koha-bugs] [Bug 15058] Update German web installer sample files for 3.22 In-Reply-To: <bug-15058-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15058-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15058-70-ekIlZd5TKe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- There are a few strings to check at http://translate.koha-community.org/de/marc21/ When finished you could download from http://translate.koha-community.org/files/de/ It's master files + Bug 14333 + Bug 15077 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 15:12:41 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 14:12:41 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15092-70-qGoMTuE3ZN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 44265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44265&action=edit Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 15:15:30 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 14:15:30 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15092-70-31yxBwSh4B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |bgkriegel at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 15:57:23 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 14:57:23 +0000 Subject: [Koha-bugs] [Bug 15095] New: marc_modificacation_template_actions DB not consistent between fresh and updated DB Message-ID: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Bug ID: 15095 Summary: marc_modificacation_template_actions DB not consistent between fresh and updated DB Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org A review of the 3.20.00 + upgrade DB, compared to a fresh master install highlighted an inconsistency on that table. This is mysqldbcompare's output for it: - `action` enum('delete_field','update_field','move_field','copy_field','copy_and_replace_field') COLLATE utf8_unicode_ci DEFAULT NULL, ? ------------------------- ^^^^^^ + `action` enum('delete_field','update_field','move_field','copy_field') COLLATE utf8_unicode_ci NOT NULL, So one ENUM value is missing on fresh installs, and an upgraded one yields a DEFAULT NULL configuration for the 'action' column. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 16:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 15:08:13 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15095-70-FIRja4m25A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14098 Assignee|gmcharlt at gmail.com |tomascohen at gmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 [Bug 14098] Regression in Marc Modification Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 16:08:13 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 15:08:13 +0000 Subject: [Koha-bugs] [Bug 14098] Regression in Marc Modification Templates In-Reply-To: <bug-14098-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14098-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14098-70-MZccKrpAEG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15095 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 16:08:49 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 15:08:49 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15095-70-T7HBzsAT1P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 16:08:52 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 15:08:52 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15095-70-XjkSEBguwS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 44266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44266&action=edit Bug 15095: marc_modificacation_template_actions DB not consistent between fresh and updated DB A review of the 3.20.00 + upgrade DB, compared to a fresh master install highlighted an inconsistency on that table. This is mysqldbcompare's output for it: - `action` enum('delete_field','update_field','move_field','copy_field','copy_and_replace_field') COLLATE utf8_unicode_ci DEFAULT NULL, ? ------------------------- ^^^^^^ + `action` enum('delete_field','update_field','move_field','copy_field') COLLATE utf8_unicode_ci NOT NULL, So one ENUM value is missing on fresh installs, and an upgraded one yields a DEFAULT NULL configuration for the 'action' column. To test: 1) have a v3.20.00 DB: > CREATE DATABASE koha_master_upgraded; $ git checkout v3.20.00 $ mysql koha_master_upgraded < installer/data/mysql/kohastructure.sql 2) upgrade it to latest master by running: $ git checkout origin/master $ perl installer/data/mysql/updatedatabase.pl 3) Create a new DB > CREATE DATABASE koha_master_fresh; $ mysql koha_master_fresh < installer/data/mysql/kohastructure.sql 4) Run mysqldbcompare (you need mysql-utilities installed for that) $ mysqldbcompare --difftype=differ --server1=root at localhost \ --skip-data-check --skip-table-options \ --run-all-tests koha_master_upgraded:koha_master_fresh => FAIL: You will notice the marc_modification_template_actions discrepancy - Repeat from 1), but apply this patch on 2) before the upgrade. => SUCCESS: The DB's discrepancies are now irrelevant [1] - Sign off :-D [1] Only KEY definition order is 'wrong', but it is not relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 16:09:10 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 15:09:10 +0000 Subject: [Koha-bugs] [Bug 15095] marc_modificacation_template_actions DB not consistent between fresh and updated DB In-Reply-To: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15095-70-uJvSTjb5tR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 17:53:33 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 16:53:33 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15092-70-t1XRtkOCJq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44265|0 |1 is obsolete| | --- Comment #3 from Marc V?ron <veron at veron.ch> --- Created attachment 44267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44267&action=edit Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description Followed test plan, works as expected. Signed-off-by: Marc V?ron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 17:54:03 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 16:54:03 +0000 Subject: [Koha-bugs] [Bug 15092] item type descriptions not showing if no logo In-Reply-To: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15092-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15092-70-6ream7YrnP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 18:42:53 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 17:42:53 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14948-70-9PuVjSsUDN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 44268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44268&action=edit Values right-aligned in checkout and detail tabs I tested again with patch applied, the values are right-aligned, see screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 18:48:32 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 17:48:32 +0000 Subject: [Koha-bugs] [Bug 14948] Display amounts right aligned in tables on patron pages In-Reply-To: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14948-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14948-70-bdK4cJstVT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #5 from Marc V?ron <veron at veron.ch> --- BTW, I had to do a full browser reload (F5) after applying the patch to see the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 18:56:19 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 17:56:19 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14482-70-Q9ogaUk1e7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #5 from Marc V?ron <veron at veron.ch> --- Reproduced: readingrec.pl: Use of uninitialized value in pattern match (m//) at /usr/share/kohaclone/members/readingrec.pl line 80., referer: http://10.0.0.31:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 19:34:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 18:34:28 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14482-70-SnaQ1FfYu4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 --- Comment #6 from Marc V?ron <veron at veron.ch> --- Sorry, warning from comment #5 is on line 80 and it is not the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 20:42:39 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 19:42:39 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14482-70-Z4V0rc6zXt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 --- Comment #7 from Marc V?ron <veron at veron.ch> --- (In reply to Marc V?ron from comment #6) > Sorry, warning from comment #5 is on line 80 and it is not the same. Update: Warning from comment #5 occurs if patron's privacy rules for the reading history are set to "Never". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 20:53:31 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 19:53:31 +0000 Subject: [Koha-bugs] [Bug 15096] New: Export today's checked in barcodes: Display warning if reading history is set to "never" Message-ID: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Bug ID: 15096 Summary: Export today's checked in barcodes: Display warning if reading history is set to "never" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: veron at veron.ch QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. In such case there should be an explanation / warning on the patron's details page and/or the meu item "Export today's checked in barcodes" should be grayed out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 21:40:21 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 20:40:21 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15096-70-U4U5LEmFBA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 21:41:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 20:41:04 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15096-70-UYWLcHUyiI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 --- Comment #1 from Marc V?ron <veron at veron.ch> --- Created attachment 44269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44269&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch skips the export if such privacy rule is set and dsiplays a message. To test: - Apply patch - Search for a user who has privacy rules set to never keeping a circulation history - Check out / check in in some items - On users detail page, go to More->Export today's checked in barcodes - Verify that a message appears about user's privacy settings - Click left tab "Circulation hsitory" - Verify that the same message appears - Seach for a user who allows circulation hsitory - repeat steps above, verify that circulation hsitory appears and that today's checkouts are exported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 21:42:04 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 20:42:04 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15096-70-34ndjoxMfr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 21:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 20:44:28 +0000 Subject: [Koha-bugs] [Bug 14482] Warns when exporting patron's checked-in barcodes In-Reply-To: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-14482-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14482-70-wKqLpi7iJu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14482 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15096 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Oct 31 21:44:28 2015 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Oct 2015 20:44:28 +0000 Subject: [Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never" In-Reply-To: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-15096-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15096-70-b0HItP2ucw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14482 -- You are receiving this mail because: You are watching all bug changes.