[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #139 from Robin Sheat <robin at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #123)
> You have updated the structure in the elasticsearch_mapping.sql file, so no
> need to remove the unique key and add the label field in the last
> updatedatabase entry.
> Not a big deal anyway :)

Oh, yes. That should have been removed.

(In reply to Jonathan Druart from comment #125)
> I know you are now agreeing completely with Koha::Object[s] and how it has
> been implemented.
> But I think we need to have an homogeneous code, and all new classes in the
> Koha namespace should follow the same directions.
> I would please you to have a look at bug 14828 (and the see also ones),
> which introduces the Koha::ItemType[s] classes as well and rewrites the
> admin/itemtypes.pl script, to see how easy it is to use it.
> To avoid future conflicts and don't play to a race against each other we
> should agree on this kind of decisions now.

Sure, that's fine. Consistency is generally better than reinventing everything.

(In reply to Jonathan Druart from comment #135)
> In the last patch I suggest to display the facet terms in the same order as
> ES build them (i.e. most used first).

While I've added this, in general I'm avoiding changing of behaviour too much.
We can always remove it later if it's decided we don't want it (and personally,
I think it'll be better.)

All these patches are added. Thanks Jonathan!

FYI, I'm looking into the notforloan stuff at the moment.

-- 
You are receiving this mail because:
You are watching all bug changes.