[Koha-bugs] [Bug 16179] Clicking Rate me button in OPAC without selecting rating produces error
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Apr 14 07:45:07 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16179
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #50030|0 |1
is obsolete| |
--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 50222
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50222&action=edit
[PASSED QA] Bug 16179: Do not crash if "rate me" is clicked and not rate
selected
If JS is disabled and a user clicks on the "Rate me" button, Koha will
crashes with:
DBIx::Class::ResultSet::create(): Column 'rating_value' cannot be null
at /usr/share/koha/lib/C4/Ratings.pm line 208
To avoid that, opac-ratings.pl will check if a rate has been selected.
Test plan:
Disable JS
On a record detail page, click on the "Rate me" button
TESTED PLAN:
1) go to /cgi-bin/koha/opac-ratings.pl?biblionumber=1
-- kaboom as above.
2) apply patch
3) refresh
-- either login screen (don't know why)
-- or if already logged in, detail page.
4) koha qa test tool
Signed-off-by: Mark Tompsett <mtompset at hotmail.com>
Signed-off-by: Owen Leonard <oleonard at myacpl.org>
I tested successfully by temporarily removing the modification made by
Bug 16210.
Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list