[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |frederic at tamil.fr

--- Comment #2 from Frédéric Demians <frederic at tamil.fr> ---
It works as described. Reading the code, and for the sake of discussion:

You have this:

    $("#searchform").on("submit",function(){
        return filter();
    });

Why not directly:

    $("#searchform").on("submit",filter);

Or, since filter() isn't used anywhere else, why not moving its code directly
above:

    $("#searchform").on("submit",function(){
      // filter() code

And this old code:

    var type_fees = new Array();
    type_fees['L'] = '';
    type_fees['F'] = '';
    type_fees['A'] = '';
    type_fees['N'] = '';
    type_fees['M'] = '';

could be cleaned up:

    var type_fees = {'L':'','F':'','A':'','N':'','M':''};

-- 
You are receiving this mail because:
You are watching all bug changes.