[Koha-bugs] [Bug 17089] Move the star ratings related code to Koha::Ratings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17089

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Medium patch
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Code looks good to me.

eval { $avg = $sum / $total }; 
Not your code, but an eval around a non-zero division seems overkill.

[% rating_avg_int = BLOCK %][% rating_avg | format("%.0f") %][% END %]
This kind of construct does not look very pretty. Simplify?

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.